[webkit-changes] [WebKit/WebKit] 3f0053: Bogus lang= attributes can cause null pointer dere...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f00535f91586f763507aa8085232b947e1354a8 https://github.com/WebKit/WebKit/commit/3f00535f91586f763507aa8085232b947e1354a8 Author: Myles C. Maxfield Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/fast/text/bogus-lang-expected.txt A LayoutTests/fast/text/bogus-lang.html M Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h M Source/WTF/wtf/text/icu/TextBreakIteratorICU.h Log Message: --- Bogus lang= attributes can cause null pointer derefs (line breaker object fails to be created) https://bugs.webkit.org/show_bug.cgi?id=258483 rdar://110440971 Reviewed by Cameron McCormack. A bogus lang attribute can cause our line breaker objects to fail to be created, causing null pointer derefs. There are 2 possible ways to fix this: 1) If creation fails, try again without a lang 2) If creation fails, mark the text as "there are no line breaking opportunities here" Option 1) is less likely to break content if the author makes a mistake, so that's the option I went with. * LayoutTests/fast/text/bogus-lang-expected.txt: Added. * LayoutTests/fast/text/bogus-lang.html: Added. * Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h: (WTF::TextBreakIteratorCFStringTokenizer::TextBreakIteratorCFStringTokenizer): * Source/WTF/wtf/text/icu/TextBreakIteratorICU.h: (WTF::TextBreakIteratorICU::TextBreakIteratorICU): Canonical link: https://commits.webkit.org/265495@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ceb2f8: Add declaration for proxyConfigurations in WKWebsi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ceb2f8e72f8ac5690d6843b3a0c179b68df5178b https://github.com/WebKit/WebKit/commit/ceb2f8e72f8ac5690d6843b3a0c179b68df5178b Author: Sihui Liu Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h Log Message: --- Add declaration for proxyConfigurations in WKWebsiteDataStore.h https://bugs.webkit.org/show_bug.cgi?id=258417 rdar://110338162 Reviewed by Wenson Hsieh. Also, guard the implemenation by SDK version instead of deployment target. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h: Canonical link: https://commits.webkit.org/265494@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c59e3: Enable macOS previews in SwiftUI MiniBrowser Brows...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c59e3a33892b111ed0d9d8ffb21996a418e7c20 https://github.com/WebKit/WebKit/commit/3c59e3a33892b111ed0d9d8ffb21996a418e7c20 Author: Brandon Stewart Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/MiniBrowserSwiftUI/Shared/BrowserTab.swift Log Message: --- Enable macOS previews in SwiftUI MiniBrowser BrowserTab https://bugs.webkit.org/show_bug.cgi?id=258263 Reviewed by Jonathan Bedard. BrowserTab previews are available on iOS. This adds support to view them on macOS too. * Tools/MiniBrowserSwiftUI/Shared/BrowserTab.swift: (BrowserTab_Previews.previews): Canonical link: https://commits.webkit.org/265493@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8a7ef: SwiftUI MiniBrowser Enable Implicit Dependencies
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8a7efec14c0cfe87e595a6f5d1f6af6181570bf https://github.com/WebKit/WebKit/commit/a8a7efec14c0cfe87e595a6f5d1f6af6181570bf Author: Brandon Stewart Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/xcshareddata/xcschemes/MiniBrowserSwiftUI.xcscheme Log Message: --- SwiftUI MiniBrowser Enable Implicit Dependencies https://bugs.webkit.org/show_bug.cgi?id=258262 Reviewed by Elliott Williams. SwiftUI MiniBrowser requires _WebKit_SWIFTUI to compile. Enable buildImplicitDependencies to ensure _WebKit_SWIFTUI is built automatically by the MiniBrowserSwiftUI application. * Tools/MiniBrowserSwiftUI/MiniBrowserSwiftUI.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/265492@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d5223: Treat performance.mark like console.timeStamp in W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d52235be538b0fb8ab33a0d80f1d7b18799f8df https://github.com/WebKit/WebKit/commit/4d52235be538b0fb8ab33a0d80f1d7b18799f8df Author: Ryosuke Niwa Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M LayoutTests/inspector/timeline/resources/timeline-event-utilities.js A LayoutTests/inspector/timeline/timeline-event-performance-mark-expected.txt A LayoutTests/inspector/timeline/timeline-event-performance-mark.html M Source/WTF/wtf/Stopwatch.h M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp M Source/WebCore/inspector/agents/InspectorTimelineAgent.h M Source/WebCore/page/Performance.cpp M Source/WebCore/page/Performance.h M Source/WebCore/page/PerformanceMarkOptions.h M Source/WebCore/page/PerformanceUserTiming.cpp M Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js Log Message: --- Treat performance.mark like console.timeStamp in Web Inspector's timeline https://bugs.webkit.org/show_bug.cgi?id=258385 Reviewed by Patrick Angle. Treat performance.mark like console.timeStamp and generate a timeline marker (vertical line). This will help investigate various aspects of the Speedometer 3 benchmark. Since performance.now can be called at anytime even when inspector's stopwatch is paused, this patch also introduces Stopwatch::fromMonotonicTime to convert monotonic time to time used by the stopwatch. Also expose markers via a public accessor in TimelineRecording. * LayoutTests/inspector/timeline/resources/timeline-event-utilities.js: (TestPage.registerInitializer.InspectorTest.TimelineEvent.captureTimelineWithMarker): Added. * LayoutTests/inspector/timeline/timeline-event-performance-mark-expected.txt: Added. * LayoutTests/inspector/timeline/timeline-event-performance-mark.html: Added. * Source/WTF/wtf/Stopwatch.h: (WTF::Stopwatch::stop): (WTF::Stopwatch::fromMonotonicTime): Added. * Source/WebCore/inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::performanceMarkImpl): Added. * Source/WebCore/inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::performanceMark): * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::timestampFromMonotonicTime): Added. (WebCore::InspectorTimelineAgent::didPerformanceMark): Added. (WebCore::InspectorTimelineAgent::appendRecord): Now optionally takes startTime. * Source/WebCore/inspector/agents/InspectorTimelineAgent.h: * Source/WebCore/page/Performance.cpp: (WebCore::Performance::monotonicTimeFromRelativeTime const): Added. * Source/WebCore/page/Performance.h: * Source/WebCore/page/PerformanceMarkOptions.h: * Source/WebCore/page/PerformanceUserTiming.cpp: (WebCore::PerformanceUserTiming::mark): * Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js: (WI.TimelineRecording): (WI.TimelineRecording.prototype.exportData): (WI.TimelineRecording.prototype.get markers): (WI.TimelineRecording.prototype.reset): (WI.TimelineRecording.prototype.addEventMarker): Canonical link: https://commits.webkit.org/265491@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48d9a4: [macOS Sonoma] Update SPI headers now that -[NSVie...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48d9a42d0a4ce579f1a1180bc1ca45aff0c5a9e4 https://github.com/WebKit/WebKit/commit/48d9a42d0a4ce579f1a1180bc1ca45aff0c5a9e4 Author: Elliott Williams Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h Log Message: --- [macOS Sonoma] Update SPI headers now that -[NSView clipsToBounds] is API https://bugs.webkit.org/show_bug.cgi?id=258473 Reviewed by Alexey Proskuryakov and Jonathan Bedard. Work towards making the build functional on macOS Sonoma. * Source/WTF/wtf/PlatformHave.h: Add a HAVE_NSVIEW_CLIPSTOBOUNDS_API flag. * Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h: Only declare clipsToBounds on older SDK versions. Canonical link: https://commits.webkit.org/265490@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26c431: Upstream autocorrection enhancements support for W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26c431674886169ee8198abcd8f3942c13dcb872 https://github.com/WebKit/WebKit/commit/26c431674886169ee8198abcd8f3942c13dcb872 Author: Richard Robinson Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/AlternativeTextController.h M Source/WebCore/editing/Editor.cpp M Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- Upstream autocorrection enhancements support for WebKit https://bugs.webkit.org/show_bug.cgi?id=258410 rdar://41592 Reviewed by Aditya Keerthi. Upstream support for autocorrection enhancements. * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::removeCorrectionIndicatorMarkers): * Source/WebCore/editing/Editor.cpp: (WebCore::shouldRemoveAutocorrectionIndicator): (WebCore::didApplyAutocorrection): (WebCore::respondToAppliedEditing): (WebCore::adjustMarkerTypesToRemoveForWordsAffectedByEditing): * Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm: (WebCore::drawRoundedRectForDocumentMarker): (WebCore::GraphicsContextCG::drawDotsForDocumentMarker): * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformAutocorrectionReplacementMarkerColor const): (WebCore::usePlatformColorForAutocorrectionReplacementMarker): Deleted. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView applyAutocorrection:toString:shouldUnderline:withCompletionHandler:]): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::adjustCandidateAutocorrectionInFrame): Canonical link: https://commits.webkit.org/265489@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8da688: [CSS-Text-Decoration] Text decorations should prop...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8da68845476a06674ef08f1639f124cb7ac535c9 https://github.com/WebKit/WebKit/commit/8da68845476a06674ef08f1639f124cb7ac535c9 Author: Ahmad Saleem Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05.html M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- [CSS-Text-Decoration] Text decorations should propagate into tables https://bugs.webkit.org/show_bug.cgi?id=258465 Reviewed by Tim Nguyen. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Spec [1]: Partial Merge: https://src.chromium.org/viewvc/blink?view=revision=199637 This patch fixes our text-decoration propagation logic to allow propagation into "display: table" elements. These elements are block-level element which participates in a block formatting context and so decorations should propagate into them. [1] https://drafts.csswg.org/css-text-decor-3/#line-decoration * Source/WebCore/style/StyleAdjuster.cpp: (shouldInheritTextDecorationsInEffect): Remove 'Table' as per commit log * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05.html: Add Test Case * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/265488@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ba47d: [build.webkit.org] Skip WebDriver tests in GTK4 bot
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ba47d488186584f3d22f62ba5354a1b210473f8 https://github.com/WebKit/WebKit/commit/7ba47d488186584f3d22f62ba5354a1b210473f8 Author: Diego Pino Garcia Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/CISupport/build-webkit-org/config.json M Tools/CISupport/build-webkit-org/factories.py M Tools/CISupport/build-webkit-org/factories_unittest.py Log Message: --- [build.webkit.org] Skip WebDriver tests in GTK4 bot https://bugs.webkit.org/show_bug.cgi?id=258432 Reviewed by Jonathan Bedard. WebDriver tests are not running successfully in WebKitGTK GTK4 bot, causing very lengthy build times. Skip this test suite for now. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories.py: (Factory.__init__): (BuildFactory.__init__): (TestFactory.__init__): (BuildAndTestAndArchiveAllButJSCFactory.__init__): (BuildAndPerfTestFactory.__init__): * Tools/CISupport/build-webkit-org/factories_unittest.py: (TestExpectedBuildSteps): Canonical link: https://commits.webkit.org/265487@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5da3ca: AX: Improve accessibility for tables and table com...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5da3ca1446784ca0ef8c55e5eb292c855b85575d https://github.com/WebKit/WebKit/commit/5da3ca1446784ca0ef8c55e5eb292c855b85575d Author: Tyler Wilcock Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M LayoutTests/accessibility/display-contents/table-expected.txt M LayoutTests/accessibility/list-detection-expected.txt M LayoutTests/accessibility/list-detection.html A LayoutTests/accessibility/table-display-block-expected.txt A LayoutTests/accessibility/table-display-block.html A LayoutTests/accessibility/table-display-flex-expected.txt A LayoutTests/accessibility/table-display-flex.html A LayoutTests/accessibility/table-display-grid-expected.txt A LayoutTests/accessibility/table-display-grid.html A LayoutTests/accessibility/table-display-inline-block-expected.txt A LayoutTests/accessibility/table-display-inline-block.html M LayoutTests/platform/glib/accessibility/generated-content-with-display-table-crash-expected.txt M LayoutTests/platform/glib/accessibility/list-detection-expected.txt A LayoutTests/platform/glib/accessibility/table-display-block-expected.txt A LayoutTests/platform/glib/accessibility/table-display-flex-expected.txt A LayoutTests/platform/glib/accessibility/table-display-grid-expected.txt A LayoutTests/platform/glib/accessibility/table-display-inline-block-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/accessibility/display-contents/table-expected.txt A LayoutTests/platform/ios/accessibility/table-display-block-expected.txt A LayoutTests/platform/ios/accessibility/table-display-flex-expected.txt A LayoutTests/platform/ios/accessibility/table-display-grid-expected.txt A LayoutTests/platform/ios/accessibility/table-display-inline-block-expected.txt M LayoutTests/platform/mac/accessibility/generated-content-with-display-table-crash-expected.txt M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.cpp Log Message: --- AX: Improve accessibility for tables and table components with display flex, grid, block, inline-block, and contents https://bugs.webkit.org/show_bug.cgi?id=258439 rdar://problem/111202843 Reviewed by Chris Fleizach. https://bugs.webkit.org/show_bug.cgi?id=258223 did the hard work of computing table structure based on the DOM rather than the render tree. But even after that patch, tables and table components with assorted display values were often inaccessible to VoiceOver. This is due to parent-child mismatches caused by anonymous RenderTables, RenderTableRows, and RenderTableCells generated when these display values are used on table components. With this patch, we properly ignore all of these anonymous table renderers, completing the transition of table accessibility to be DOM-based. This matches author expectations and is much more simple to reason about, and fixes the parent-child mismatches that were breaking the accessibility hierarchy. * LayoutTests/accessibility/display-contents/table-expected.txt: * LayoutTests/accessibility/list-detection-expected.txt: * LayoutTests/accessibility/list-detection.html: * LayoutTests/accessibility/table-display-block-expected.txt: * LayoutTests/accessibility/table-display-block.html: Added. * LayoutTests/accessibility/table-display-flex-expected.txt: * LayoutTests/accessibility/table-display-flex.html: Added. * LayoutTests/accessibility/table-display-grid-expected.txt: * LayoutTests/accessibility/table-display-grid.html: Added. * LayoutTests/accessibility/table-display-inline-block-expected.txt: * LayoutTests/accessibility/table-display-inline-block.html: Added. * LayoutTests/platform/glib/accessibility/list-detection-expected.txt: * LayoutTests/platform/ios/TestExpectations: Enable all new tests. * LayoutTests/platform/ios/accessibility/display-contents/table-expected.txt: * LayoutTests/platform/ios/accessibility/table-display-block-expected.txt: * LayoutTests/platform/ios/accessibility/table-display-flex-expected.txt: * LayoutTests/platform/ios/accessibility/table-display-grid-expected.txt: * LayoutTests/platform/ios/accessibility/table-display-inline-block-expected.txt: * LayoutTests/platform/mac/accessibility/generated-content-with-display-table-crash-expected.txt: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::createObjectFromRenderer): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Canonical link: https://commits.webkit.org/265486@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a05f74: [macOS Sonoma] Add -[NSSpellChecker isAutomaticInl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a05f740204c812cd7f5a9608a6d9047fe6b92f6e https://github.com/WebKit/WebKit/commit/a05f740204c812cd7f5a9608a6d9047fe6b92f6e Author: Elliott Williams Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h Log Message: --- [macOS Sonoma] Add -[NSSpellChecker isAutomaticInlineCompletionEnabled] SPI https://bugs.webkit.org/show_bug.cgi?id=258475 Reviewed by Aditya Keerthi. Work towards making the build functional on macOS Sonoma. * Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h: Canonical link: https://commits.webkit.org/265485@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3acf1f: GARDENING: REGRESSION(264706@main): [ macOS ] Test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3acf1fdd307e2a4d26acbf0fa5c2a383a49dbdd4 https://github.com/WebKit/WebKit/commit/3acf1fdd307e2a4d26acbf0fa5c2a383a49dbdd4 Author: Robert Jenner Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm Log Message: --- GARDENING: REGRESSION(264706@main): [ macOS ] TestWebKitAPI.WebKit.AutoFi llAvailable is a constant timeout rdar://110336197 https://bugs.webkit.org/show_bug.cgi?id=257756 Unreviewed test gardening. * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: Canonical link: https://commits.webkit.org/265484@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 677b44: Throw when constructing a SharedWorker in a detach...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 677b4473a8cb849af5d8af685b7b9e72e838cb3c https://github.com/WebKit/WebKit/commit/677b4473a8cb849af5d8af685b7b9e72e838cb3c Author: Chris Dumez Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/http/tests/workers/shared/resources/start-worker-detached-frame-iframe.html A LayoutTests/http/tests/workers/shared/start-worker-detached-frame-expected.txt A LayoutTests/http/tests/workers/shared/start-worker-detached-frame.html M Source/WebCore/workers/shared/SharedWorker.cpp Log Message: --- Throw when constructing a SharedWorker in a detached document https://bugs.webkit.org/show_bug.cgi?id=258477 rdar://110231627 Reviewed by Sihui Liu and Brent Fulgham. Throw an exception when constructing a SharedWorker in a detached iframe, similarly to what Chrome and Firefox are already doing. Previously, we would successfully create the SharedWorker but the topOrigin would be wrong in the case of a third-party iframe and we would hit an assertion later on. * LayoutTests/http/tests/workers/shared/resources/start-worker-detached-frame-iframe.html: Added. * LayoutTests/http/tests/workers/shared/start-worker-detached-frame-expected.txt: Added. * LayoutTests/http/tests/workers/shared/start-worker-detached-frame.html: Added. * Source/WebCore/workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::create): Canonical link: https://commits.webkit.org/265483@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55c123: Revert [265365@main] [WPE] Crash in `WebKit.OnDevi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55c1230cb9f38777923cc78824dcd7c9617ba7f3 https://github.com/WebKit/WebKit/commit/55c1230cb9f38777923cc78824dcd7c9617ba7f3 Author: Robert Jenner Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- Revert [265365@main] [WPE] Crash in `WebKit.OnDeviceChangeCrash` API test https://bugs.webkit.org/show_bug.cgi?id=258353 rdar://problem/111234270 Unreviewed revert. * Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/265482@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a2b3dc: [ANGLE] UBO convert only whole block
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2b3dcad4f04acf986db93170bebfbe88c991517 https://github.com/WebKit/WebKit/commit/a2b3dcad4f04acf986db93170bebfbe88c991517 Author: Dan Glastonbury Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm Log Message: --- [ANGLE] UBO convert only whole block rdar://108349524 [Relanded by David Kilzer after being rolled out by 264786@main.] [Originally tracked by: rdar://106964250] Reviewed by Dean Jackson. OpenGL doesn't guarantee that the buffer backing uniform blocks needs to be a multiple of the block size. When converting OpenGL layout blocks to Metal layout, ConvertUniformBufferData is rounding up the size of the backing buffer to a multiple of the block size which leads to reading out of bounds. To ensure we don't read outside the source buffer, this change replaces calls to `memcpy` with `memcpy_guarded` which accepts a pointer to the limit of available data and copies as much data as is available, writing zeroes for any unavailable amount. Conversion of bools didn't use memcpy, so the raw pointer is checked against maxSrcPtr and only dereferenced if valid, otherwise zero is used. This has been tested with ASan and UBSan enabled against the OpenGL dEQP tests for Uniform Buffer Objects in ANGLE. * Source/ThirdParty/ANGLE/changes.diff: - Ran `update-angle --regenerate-changes-diff`. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm: Originally-landed-as: 259548.667@safari-7615-branch (4aa8750579fb). rdar://106964250 Canonical link: https://commits.webkit.org/265481@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 604de1: Avoid a dispatch() in IPC sending if we're already...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 604de1a10add685f880174d4c16784f369c9e5eb https://github.com/WebKit/WebKit/commit/604de1a10add685f880174d4c16784f369c9e5eb Author: Simon Fraser Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/Platform/IPC/Connection.cpp Log Message: --- Avoid a dispatch() in IPC sending if we're already processing outgoing messages https://bugs.webkit.org/show_bug.cgi?id=258427 rdar://92703 Reviewed by Ben Nham and Chris Dumez. Connection::sendMessage() would do a dispatch to the connection queue on every message send, but this dispatch just triggers sendOutgoingMessages() to send things in the m_outgoingMessages queue. So we only need to dispatch when this queue is empty. This reduces the number of calls to dispatch() when loading amazon.com by about 18%. If we're in the middle of dispatching normal-QOS messages and we're asked to dispach a higher QOS message, dispatch anyway. It's not clear if this has the intended effect of boosting the priority of the already-running dispatch work. * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::sendMessage): Canonical link: https://commits.webkit.org/265480@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4880ef: [macOS Sonoma] Avoid redeclaration of PKApplePayLa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4880ef75f75a5316289e1ad8b734aaa9882abb19 https://github.com/WebKit/WebKit/commit/4880ef75f75a5316289e1ad8b734aaa9882abb19 Author: Elliott Williams Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h Log Message: --- [macOS Sonoma] Avoid redeclaration of PKApplePayLaterAvailability https://bugs.webkit.org/show_bug.cgi?id=258474 Reviewed by Alexey Proskuryakov and Aditya Keerthi. Work towards making the build functional on macOS Sonoma. * Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h: Remove enum and PKPaymentRequest declarations that are part of the public SDK. Canonical link: https://commits.webkit.org/265479@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ec2b6: [GLib] Misc fixes for GResource file generation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ec2b6d3c34850d235939b7007b9454eeb1cf58c https://github.com/WebKit/WebKit/commit/9ec2b6d3c34850d235939b7007b9454eeb1cf58c Author: Michael Catanzaro Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/InspectorGResources.cmake M Source/WebKit/ModernMediaControlsGResources.cmake M Source/WebKit/PdfJSGResources.cmake Log Message: --- [GLib] Misc fixes for GResource file generation https://bugs.webkit.org/show_bug.cgi?id=258478 Reviewed by Philippe Normand. This splits some of Lauro's fixes for GResource dependencies out from bug #257516. These fixes were developed by Lauro Moura: * Source/WebKit/InspectorGResources.cmake: Fix typo * Source/WebKit/ModernMediaControlsGResources.cmake: Fix typo * Source/WebKit/PdfJSGResources.cmake: Fix failure to generate .deps file Canonical link: https://commits.webkit.org/265478@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 473724: Add test parameter to performance dashboard to sup...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 473724c9a49c6b95dc3104784c2eb7fbc0c0764b https://github.com/WebKit/WebKit/commit/473724c9a49c6b95dc3104784c2eb7fbc0c0764b Author: Dewei Zhu Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Websites/perf.webkit.org/init-database.sql M Websites/perf.webkit.org/migrate-database.sql A Websites/perf.webkit.org/public/admin/test-parameters.php M Websites/perf.webkit.org/public/api/build-requests.php M Websites/perf.webkit.org/public/api/test-groups.php M Websites/perf.webkit.org/public/api/update-triggerable.php M Websites/perf.webkit.org/public/include/admin-header.php M Websites/perf.webkit.org/public/include/build-requests-fetcher.php M Websites/perf.webkit.org/public/include/commit-sets-helpers.php M Websites/perf.webkit.org/public/include/db.php M Websites/perf.webkit.org/public/include/manifest-generator.php M Websites/perf.webkit.org/public/privileged-api/add-build-requests.php M Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php M Websites/perf.webkit.org/public/privileged-api/create-test-group.php M Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js M Websites/perf.webkit.org/public/v3/index.html M Websites/perf.webkit.org/public/v3/models/build-request.js M Websites/perf.webkit.org/public/v3/models/commit-set.js M Websites/perf.webkit.org/public/v3/models/manifest.js M Websites/perf.webkit.org/public/v3/models/measurement-adaptor.js M Websites/perf.webkit.org/public/v3/models/test-group.js A Websites/perf.webkit.org/public/v3/models/test-parameter.js M Websites/perf.webkit.org/public/v3/models/triggerable.js M Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js M Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js M Websites/perf.webkit.org/server-tests/api-build-requests-tests.js M Websites/perf.webkit.org/server-tests/api-manifest-tests.js M Websites/perf.webkit.org/server-tests/api-test-groups.js M Websites/perf.webkit.org/server-tests/api-update-triggerable-tests.js M Websites/perf.webkit.org/server-tests/privileged-api-add-build-requests-tests.js M Websites/perf.webkit.org/server-tests/privileged-api-create-analysis-task-tests.js M Websites/perf.webkit.org/server-tests/privileged-api-create-test-group-tests.js M Websites/perf.webkit.org/server-tests/resources/mock-data.js M Websites/perf.webkit.org/server-tests/tools-buildbot-triggerable-tests.js M Websites/perf.webkit.org/server-tests/tools-sync-buildbot-integration-tests.js M Websites/perf.webkit.org/tools/js/buildbot-syncer.js M Websites/perf.webkit.org/tools/js/buildbot-triggerable.js M Websites/perf.webkit.org/tools/js/database.js M Websites/perf.webkit.org/tools/js/v3-models.js M Websites/perf.webkit.org/unit-tests/build-request-tests.js M Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js M Websites/perf.webkit.org/unit-tests/test-groups-tests.js A Websites/perf.webkit.org/unit-tests/test-parameter-tests.js Log Message: --- Add test parameter to performance dashboard to support more customization in A/B testing. https://bugs.webkit.org/show_bug.cgi?id=257017 rdar://100645382 Reviewed by Alexey Proskuryakov. Introduce 'test parameter' concept to performance dashboard which adds more customization ability. Create 1-to-N relationship between triggerable configuration and test parameter so that different (platform, test) pair can support different test parameters. Add test parameter set which stores a set of parameter value and build requests can optionally refer to it. * Websites/perf.webkit.org/init-database.sql: Added 'test_parameters' and its related tables. Added 'test_parameter_sets' and a corresponding field in 'build_requests' table that refers to it. * Websites/perf.webkit.org/migrate-database.sql: Added migration SQL queries. * Websites/perf.webkit.org/public/admin/test-parameters.php: Added an admin page for 'test_parameters' table. * Websites/perf.webkit.org/public/api/build-requests.php: Added 'testParameterSets' to API return value. * Websites/perf.webkit.org/public/api/test-groups.php: Added 'testParameterSets' to API return value. * Websites/perf.webkit.org/public/api/update-triggerable.php: Added support for updating test parameters for triggerable configurations. * Websites/perf.webkit.org/public/include/admin-header.php: Added 'Test Parameters' tab. Updated 'assert' usage to avoid using deprecated syntax. Fixed a bug in 'update_boolean_field' that updating a boolean column on a table with multile boolean columns only works for first column. Added 'select' type in 'render_form_control_for_column'. * Websites/perf.webkit.org/public/include/build-requests-fetcher.php: Added 'testParameterSets' to API return value. *
[webkit-changes] [WebKit/WebKit] 224ebe: Ensure completion handler is always called in WebP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 224ebe1caabd0b48122e0b6bc5912687b2567722 https://github.com/WebKit/WebKit/commit/224ebe1caabd0b48122e0b6bc5912687b2567722 Author: Abrar Rahman Protyasha Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Ensure completion handler is always called in WebPage::performHitTestForMouseEvent https://bugs.webkit.org/show_bug.cgi?id=258459 rdar://111220210 Reviewed by Wenson Hsieh. Currently we don't call the completion handler when the page's main frame (or its view) is null. This commit fixes that by calling the completion handler with sane defaults instead. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performHitTestForMouseEvent): Canonical link: https://commits.webkit.org/265476@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 146364: [git-webkit] Add clone command
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1463644b7ce9725be5e1ec33d0870244409f02cb https://github.com/WebKit/WebKit/commit/1463644b7ce9725be5e1ec33d0870244409f02cb Author: Jonathan Bedard Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Tools/Scripts/libraries/webkitbugspy/setup.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py A Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py A Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py Log Message: --- [git-webkit] Add clone command https://bugs.webkit.org/show_bug.cgi?id=254599 rdar://107320897 Reviewed by Dewei Zhu. Add a command to quickly clone a radar from a commit or Bugzilla. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/__init__.py: Import mock milestones. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py: Add mock milestones. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py: (AppleDirectoryQuery.member_dsid_list_for_group_name): Add. (RadarModel.Milestone): Add mock Milestone object. (RadarModel.Category): Add mock Category object. (RadarModel.Event): Add mock Event object. (RadarModel.Tentpole): Add mock Tentpole object. (RadarModel.MilestoneAssociations): Add mock MilestoneAssociations object. (RadarModel.commit_changes): Commit milestone, category, event and tentpole. (RadarModel.milestone_associations): List MilestoneAssociations object from Milestone object. (RadarClient.milestones_for_component): List all mock milestones. (RadarClient.clone_radar): Mock implementation of Radarclient's clone_radar. (Radar.__init__): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker.create): Handle empty project. (Tracker.clone): Clone radar with specified reason. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py: * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clone.py: Added. (Clone.parser): User must specify problem, reason and optionally milestone to clone radar into. (Clone.main): Resolve the provided argument to a radar and then clone the specified radar. Attempt to copy as much of the original radar as possible after moving the cloned radar into the specified milestone. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clone_unittest.py: Added. (TestClone): Canonical link: https://commits.webkit.org/265475@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e01c72: [css-counter-styles-3] cjk-earthly-branch and cjk-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e01c725885a7983395016526cfcd160a6e4999e4 https://github.com/WebKit/WebKit/commit/e01c725885a7983395016526cfcd160a6e4999e4 Author: Vitor Roriz Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html M Source/WebCore/css/counterStyles.css Log Message: --- [css-counter-styles-3] cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal https://bugs.webkit.org/show_bug.cgi?id=258447 rdar://111208503 Reviewed by Tim Nguyen. cjk-earthly-branch and cjk-heavenly-stem should fallback to cjk-decimal according to CSSWG resolution: https://github.com/w3c/csswg-drafts/issues/8975 * LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt: * LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-earthly-branch/css3-counter-styles-202.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-counter-styles/cjk-heavenly-stem/css3-counter-styles-205.html: * Source/WebCore/css/counterStyles.css: (@counter-style cjk-earthly-branch): (@counter-style cjk-heavenly-stem): Canonical link: https://commits.webkit.org/265474@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a9910: Remove unnecessary soft linking of Data Detector f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a99108f9c33f2eaabcc36abba55c5032a8d https://github.com/WebKit/WebKit/commit/9a99108f9c33f2eaabcc36abba55c5032a8d Author: Per Arne Vollan Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Remove unnecessary soft linking of Data Detector framework https://bugs.webkit.org/show_bug.cgi?id=258469 rdar://111222985 Reviewed by Chris Dumez. This soft linking is no longer needed, since the WebContent process is no longer being terminated when accessing launchd. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): (WebKit::softlinkDataDetectorsFrameworks): Deleted. Canonical link: https://commits.webkit.org/265473@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2c434: [WebVTT] Cues with line setting containing aligmen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2c434a9b4567ec35d7a1038784cf144b2e050bc https://github.com/WebKit/WebKit/commit/b2c434a9b4567ec35d7a1038784cf144b2e050bc Author: Jer Noble Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/media/track/captions-webvtt/line-align.vtt A LayoutTests/media/track/webvtt-line-align-expected.txt A LayoutTests/media/track/webvtt-line-align.html M Source/WebCore/html/track/VTTCue.cpp Log Message: --- [WebVTT] Cues with line setting containing aligment parse as 'start' https://bugs.webkit.org/show_bug.cgi?id=258456 rdar://111220055 Reviewed by Eric Carlson. The line alignment settings are already parsed, but not stored in an ivar. Even though layout using those alignment values is not yet implemented, we should at least parse the correct values from source WebVTT. * LayoutTests/media/track/captions-webvtt/line-align.vtt: Added. * LayoutTests/media/track/webvtt-line-align-expected.txt: Added. * LayoutTests/media/track/webvtt-line-align.html: Added. * Source/WebCore/html/track/VTTCue.cpp: (WebCore::VTTCue::settingName): (WebCore::VTTCue::setCueSettings): Canonical link: https://commits.webkit.org/265472@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c13b5: [css-text-decor] Don't propagate decorations to in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c13b5adb5e3ed5e11d75560a48c8e2ab21c855c https://github.com/WebKit/WebKit/commit/1c13b5adb5e3ed5e11d75560a48c8e2ab21c855c Author: Ahmad Saleem Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-02-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-02.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-03-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-03.html M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- [css-text-decor] Don't propagate decorations to inline-flex/inline-grid https://bugs.webkit.org/show_bug.cgi?id=258420 Reviewed by Tim Nguyen. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. This patch extends our 'shouldInheritTextDecorations' to also account for additional atomic inlines (i.e., Inline-Flex and Inline-Grid). * Source/WebCore/style/StyleAdjuster.cpp: (shouldInheritTextDecorationsInEffect): Add two more display types to not propagate text decorations * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-02.html: Add Test Case * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-02-expected.html: Add Test Case Expectation * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-03.html: Add Test Case * LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-03-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/265471@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23e7f4: AX: Table structure broken for role grid, treegrid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23e7f4efeb894ce46f230ca7298130f83563412c https://github.com/WebKit/WebKit/commit/23e7f4efeb894ce46f230ca7298130f83563412c Author: Tyler Wilcock Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/accessibility/display-contents/aria-grid-expected.txt A LayoutTests/accessibility/display-contents/aria-grid.html A LayoutTests/platform/glib/accessibility/display-contents/aria-grid-expected.txt M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityARIAGrid.cpp M Source/WebCore/accessibility/AccessibilityARIAGrid.h M Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp M Source/WebCore/accessibility/AccessibilityARIAGridCell.h M Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp M Source/WebCore/accessibility/AccessibilityARIAGridRow.h Log Message: --- AX: Table structure broken for role grid, treegrid, table, row, gridcell, cell, and columnheader elements with display:contents https://bugs.webkit.org/show_bug.cgi?id=258430 rdar://problem/93901 Reviewed by Chris Fleizach. With this patch, we now create the appropriate subclass for node-only objects (like those with display:contents) with roles equal to grid, treegrid, table, row, gridcell, cell, and columnheader. This enables the table structure to be built correctly in AccessibilityTable::addChildren (and represented accurately in various other places that do class type-checking for these table / grid types). * LayoutTests/accessibility/display-contents/aria-grid-expected.txt: Added. * LayoutTests/accessibility/display-contents/aria-grid.html: Added. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::isAccessibilityARIAGrid): (WebCore::isAccessibilityARIAGridRow): (WebCore::isAccessibilityARIAGridCell): (WebCore::AXObjectCache::createObjectFromRenderer): (WebCore::createFromNode): * Source/WebCore/accessibility/AccessibilityARIAGrid.cpp: (WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid): (WebCore::AccessibilityARIAGrid::create): * Source/WebCore/accessibility/AccessibilityARIAGrid.h: * Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp: (WebCore::AccessibilityARIAGridCell::AccessibilityARIAGridCell): (WebCore::AccessibilityARIAGridCell::create): (WebCore::AccessibilityARIAGridCell::readOnlyValue const): (WebCore::AccessibilityARIAGridCell::parentRowGroup const): Deleted. * Source/WebCore/accessibility/AccessibilityARIAGridCell.h: * Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp: (WebCore::AccessibilityARIAGridRow::AccessibilityARIAGridRow): (WebCore::AccessibilityARIAGridRow::create): * Source/WebCore/accessibility/AccessibilityARIAGridRow.h: Canonical link: https://commits.webkit.org/265470@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4c5bc: Calculate CSS unit `x` as resolution for calc comb...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4c5bcd2ebf9effc1d52f8dbc298f46b08c1eb64 https://github.com/WebKit/WebKit/commit/a4c5bcd2ebf9effc1d52f8dbc298f46b08c1eb64 Author: Cheng-You Bai Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html M Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp Log Message: --- Calculate CSS unit `x` as resolution for calc combination https://bugs.webkit.org/show_bug.cgi?id=257717 Reviewed by Tim Nguyen. Previously, `x` was calculated as `other`category so it cannot be canonicalized to `dppx` unit correctly. Thus, in this patch, we'll calculate `x` as `resolution` category in calc combination to fix the issue. * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html: * Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp: (WebCore::calculationCategoryForCombination): Canonical link: https://commits.webkit.org/265469@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 76bf4e: REGRESSION(265249@main): Infinite recursion in Leg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76bf4e5df476a9d854011bdaf9bc9252cb3ef5a4 https://github.com/WebKit/WebKit/commit/76bf4e5df476a9d854011bdaf9bc9252cb3ef5a4 Author: Ryosuke Niwa Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/svg/custom/svg-reference-cycle-between-two-svg-elements-expected.txt A LayoutTests/svg/custom/svg-reference-cycle-between-two-svg-elements.html M Source/WebCore/rendering/svg/SVGContainerLayout.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/rendering/svg/SVGResources.cpp M Source/WebCore/rendering/svg/SVGResources.h Log Message: --- REGRESSION(265249@main): Infinite recursion in LegacyRenderSVGContainer::layout and SVGRenderSupport::layoutChildren https://bugs.webkit.org/show_bug.cgi?id=258419 Reviewed by Darin Adler. Partially revert 265249@main by restoring the check for the current root. This turned out be necessary to avoid infinite recursion. * LayoutTests/svg/custom/svg-reference-cycle-between-two-svg-elements-expected.txt: Added. * LayoutTests/svg/custom/svg-reference-cycle-between-two-svg-elements.html: Added. * Source/WebCore/rendering/svg/SVGContainerLayout.cpp: (WebCore::SVGContainerLayout::layoutDifferentRootIfNeeded): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutDifferentRootIfNeeded): * Source/WebCore/rendering/svg/SVGResources.cpp: (WebCore::SVGResources::layoutDifferentRootIfNeeded): (WebCore::SVGResources::layoutReferencedRootIfNeeded): Deleted. * Source/WebCore/rendering/svg/SVGResources.h: Canonical link: https://commits.webkit.org/265468@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d1f7e: Re-enable IOKit blocking when in Lockdown Mode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d1f7e7f1641152d1ed7d36b8fea2d06199e18c4 https://github.com/WebKit/WebKit/commit/3d1f7e7f1641152d1ed7d36b8fea2d06199e18c4 Author: Per Arne Vollan Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- Re-enable IOKit blocking when in Lockdown Mode https://bugs.webkit.org/show_bug.cgi?id=258320 rdar://109736680 Reviewed by Brent Fulgham. Re-enable IOKit blocking in the WebProcess when in Lockdown Mode. * Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::useGPUProcessForDOMRenderingEnabled const): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): Canonical link: https://commits.webkit.org/265467@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d681c: Block logd in internal builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d681c005fa8dabc9acbe94dfc5ab7bf45888d5a https://github.com/WebKit/WebKit/commit/0d681c005fa8dabc9acbe94dfc5ab7bf45888d5a Author: Per Arne Vollan Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- Block logd in internal builds https://bugs.webkit.org/show_bug.cgi?id=258453 rdar://111215780 Reviewed by Brent Fulgham. Block logd in internal builds on iOS. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/265466@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7798da: [WebVTT] Cues with position setting containing ali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7798da0bec55b133d9d63ea9dd37c9be06f4b1bf https://github.com/WebKit/WebKit/commit/7798da0bec55b133d9d63ea9dd37c9be06f4b1bf Author: Jer Noble Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: A LayoutTests/media/track/captions-webvtt/position-align.vtt A LayoutTests/media/track/webvtt-position-align-expected.txt A LayoutTests/media/track/webvtt-position-align.html M Source/WebCore/html/track/VTTCue.cpp Log Message: --- [WebVTT] Cues with position setting containing aligment parse as 'auto' https://bugs.webkit.org/show_bug.cgi?id=258431 rdar://96313 Reviewed by Eric Carlson. WebVTT cues which include position alignment values have those positions rejected by the parser, leading to broken layout issues. Even without adding full support for those alignments, we can at least not reject those values and achieve partially correct layouts. * LayoutTests/media/track/captions-webvtt/position-align.vtt: Added. * LayoutTests/media/track/webvtt-position-align-expected.txt: Added. * LayoutTests/media/track/webvtt-position-align.html: Added. * Source/WebCore/html/track/VTTCue.cpp: (WebCore::VTTCue::setCueSettings): Canonical link: https://commits.webkit.org/265465@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c78a5: [IFC] List bullets are aligned differently within ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1c78a5cfb74b76035c0d2836a18e36ce2ed4db8c
https://github.com/WebKit/WebKit/commit/1c78a5cfb74b76035c0d2836a18e36ce2ed4db8c
Author: Alan Baradlay
Date: 2023-06-23 (Fri, 23 Jun 2023)
Changed paths:
A LayoutTests/fast/inline/list-marker-inside-flex-expected.html
A LayoutTests/fast/inline/list-marker-inside-flex.html
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
Log Message:
---
[IFC] List bullets are aligned differently within a list when the list item
has a flex container
https://bugs.webkit.org/show_bug.cgi?id=258414
Reviewed by Antti Koivisto.
Let's account for the box logical left position when computing the adjustment
for outside list markers inside flex/grid.
In many cases outside list marker renderers end up inside descendant blocks
("closest" to the inline content on line) while their
horizontal position should ignore such "embedding".
Essentially they are supposed to show up at the same horizontal position
regardless of how many generated/non-generated blocks
there are between the (tree) position of the RenderListMarker and the
associated RenderListItem.
e.g.
this is where the list marker gets inserted
While the list marker is visually placed at the left side of , it is placed
under .
offsetFromParentListItem is supposed to resolve this by climbing up the
ancestor chain and accumulating
padding and border on the (logical) left between the RenderListMarker and
RenderListItem. With flex/grid layout there
could be some additional offset between those renderers (other flex/grid items).
This patch fixes such cases by taking logical left into account for such
content (sadly we can't have a uniform approach to this since
(in the render tree) block content does not get its final position until after
this code runs. Moreover stale logicalLeft (leftover from previous
layout could lead to misplaced list markers. Legacy line layout addresses this
by computing this offset (and moving the list marker!) _after_
layout at overflow computation time (see
RenderListMarker::addOverflowFromListMarker)
In full LFC this will be fixed by inserting the marker box where it belongs).
* LayoutTests/fast/inline/list-marker-inside-flex-expected.html: Added.
* LayoutTests/fast/inline/list-marker-inside-flex.html: Added.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateListMarkerDimensions):
Canonical link: https://commits.webkit.org/265464@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b893e: Adopt delegation NEFilterSource SPI
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b893edcda1fb9040803a678003359ce823f7a2f https://github.com/WebKit/WebKit/commit/4b893edcda1fb9040803a678003359ce823f7a2f Author: Per Arne Vollan Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm Log Message: --- Adopt delegation NEFilterSource SPI https://bugs.webkit.org/show_bug.cgi?id=258304 rdar://109900099 Reviewed by Brent Fulgham. Adopt delegation NEFilterSource SPI, providing audit token of the UI process. * Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): Canonical link: https://commits.webkit.org/265463@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79eec4: Revert [265458@main] Update libvpx to M115
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79eec4a0348601a3cf27ec19e283fe568f183ee6 https://github.com/WebKit/WebKit/commit/79eec4a0348601a3cf27ec19e283fe568f183ee6 Author: Karl Rackler Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/BUILD.gn M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/OWNERS M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/README.chromium M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/generate_gni.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/libvpx_srcs.gni M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/lint_config.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/run_perl.py M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_dsp_rtcd.h M
[webkit-changes] [WebKit/WebKit] 0a7b2c: Adopt ThreadSafeWeakPtr in LocalSampleBufferDispla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a7b2cd6eaaf26123fbcfeffae9adc0c07ed79ef https://github.com/WebKit/WebKit/commit/0a7b2cd6eaaf26123fbcfeffae9adc0c07ed79ef Author: Youenn Fablet Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h Log Message: --- Adopt ThreadSafeWeakPtr in LocalSampleBufferDisplayLayer https://bugs.webkit.org/show_bug.cgi?id=258441 rdar://111203259 Reviewed by Eric Carlson. SampleBufferDisplayLayer was migrated to ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr but not LocalSampleBufferDisplayLayer. LocalSampleBufferDisplayLayer was still using WeakPtr and a work queue, with dispatchSync in its destructor. This works ok except if dispatching a task from another dispatched task, which was happening in LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition. To prevent this, we are introducing enqueueBufferInternal which should be called from the work queue. In addition to that, we are removing the dispatchSync in the destructor and make use of ThreadSafeWeakPtr in the work queue, to make code more robust. We have to change WebAVSampleBufferStatusChangeListener also and are now storing the displayLayer at begin time, since stop might be called within LocalSampleBufferDisplayLayer destructor. Covered by exsting tests. * Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h: * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h: * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: (-[WebAVSampleBufferStatusChangeListener begin:]): (-[WebAVSampleBufferStatusChangeListener stop]): (-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]): (WebCore::LocalSampleBufferDisplayLayer::initialize): (WebCore::LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer): (WebCore::LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition): (WebCore::LocalSampleBufferDisplayLayer::flush): (WebCore::LocalSampleBufferDisplayLayer::flushAndRemoveImage): (WebCore::LocalSampleBufferDisplayLayer::enqueueVideoFrame): (WebCore::LocalSampleBufferDisplayLayer::enqueueBuffer): (WebCore::LocalSampleBufferDisplayLayer::enqueueBufferInternal): (WebCore::LocalSampleBufferDisplayLayer::onIrregularFrameRateNotification): (WebCore::LocalSampleBufferDisplayLayer::clearVideoFrames): (WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData): (-[WebAVSampleBufferStatusChangeListener begin]): Deleted. * Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h: Canonical link: https://commits.webkit.org/265461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3704f: Fix imported/w3c/web-platform-tests/webcodecs/vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3704f2543bc83cd160a72aac8219c30b8d953d6 https://github.com/WebKit/WebKit/commit/a3704f2543bc83cd160a72aac8219c30b8d953d6 Author: Youenn Fablet Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoColorSpace.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoColorSpace.any.worker-expected.txt M Source/WebCore/Modules/webcodecs/VideoColorPrimaries.idl M Source/WebCore/Modules/webcodecs/VideoColorSpace.idl Log Message: --- Fix imported/w3c/web-platform-tests/webcodecs/videoColorSpace.any.html test https://bugs.webkit.org/show_bug.cgi?id=258448 rdar://111210254 Reviewed by Eric Carlson. Add constructor to VideoColorSpace as per https://w3c.github.io/webcodecs/#dom-videocolorspace-videocolorspace Update VideoColorPrimaries to change VideoColorPrimaries "smpteEg432" as "smpte432", as per https://w3c.github.io/webcodecs/#enumdef-videocolorprimaries. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoColorSpace.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoColorSpace.any.worker-expected.txt: * Source/WebCore/Modules/webcodecs/VideoColorPrimaries.idl: * Source/WebCore/Modules/webcodecs/VideoColorSpace.idl: Canonical link: https://commits.webkit.org/265460@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c27e33: [Curl] Remove unnecessary trailing CR/LF of the st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c27e334aeb4005d27773fc4ee9f45741e58ea21a https://github.com/WebKit/WebKit/commit/c27e334aeb4005d27773fc4ee9f45741e58ea21a Author: Kenji Shukuwa Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp Log Message: --- [Curl] Remove unnecessary trailing CR/LF of the status text of ResourceResponse https://bugs.webkit.org/show_bug.cgi?id=258442 Reviewed by Fujii Hironori. The status text of ResourceResponse contains unnecessary CR/LF after 265395@main. So remove unnecessary trailing CR/LF. * Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::appendHTTPHeaderField): Canonical link: https://commits.webkit.org/265459@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 683769: Update libvpx to M115
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68376925091d5487460e919993d1e5a776080ce3 https://github.com/WebKit/WebKit/commit/68376925091d5487460e919993d1e5a776080ce3 Author: Youenn Fablet Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/BUILD.gn M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/OWNERS M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/README.chromium M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/generate_gni.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/libvpx_srcs.gni M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/lint_config.sh M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/run_perl.py M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64-highbd/vpx_dsp_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vp8_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vp9_rtcd.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.asm M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_config.h M Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/linux/arm64/vpx_dsp_rtcd.h M
[webkit-changes] [WebKit/WebKit] 923265: [CSS] Use "enum class" for CSSSelector Match and R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 923265e5941bc1687fb511685061d831a92189b5 https://github.com/WebKit/WebKit/commit/923265e5941bc1687fb511685061d831a92189b5 Author: Matthieu Dubet Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/css/CSSSelectorList.cpp M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/SelectorChecker.h M Source/WebCore/css/SelectorFilter.cpp M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSParserSelector.cpp M Source/WebCore/css/parser/CSSParserSelector.h M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/cssjit/SelectorCompiler.cpp M Source/WebCore/dom/SelectorQuery.cpp M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp M Source/WebCore/style/HasSelectorFilter.cpp M Source/WebCore/style/PageRuleCollector.cpp M Source/WebCore/style/RuleData.cpp M Source/WebCore/style/RuleFeature.cpp M Source/WebCore/style/RuleSet.cpp Log Message: --- [CSS] Use "enum class" for CSSSelector Match and RelationType https://bugs.webkit.org/show_bug.cgi?id=258358 rdar://04973 Reviewed by Brent Fulgham. It's a pure refactoring without any functional change. * Source/WebCore/css/CSSSelector.cpp: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::createRareData): (WebCore::simpleSelectorSpecificity): (WebCore::CSSSelector::specificityForPage const): (WebCore::CSSSelector::firstInCompound const): (WebCore::CSSSelector::selectorText const): (WebCore::CSSSelector::resolveNestingParentSelectors): (WebCore::CSSSelector::replaceNestingParentByPseudoClassScope): (WebCore::CSSSelector::hasExplicitNestingParent const): * Source/WebCore/css/CSSSelector.h: (WebCore::CSSSelector::hasDescendantRelation const): (WebCore::CSSSelector::hasDescendantOrChildRelation const): (WebCore::CSSSelector::matchesPseudoElement const): (WebCore::CSSSelector::isUnknownPseudoElement const): (WebCore::CSSSelector::isCustomPseudoElement const): (WebCore::CSSSelector::isSiblingSelector const): (WebCore::CSSSelector::isAttributeSelector const): (WebCore::CSSSelector::setValue): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::value const): (WebCore::CSSSelector::serializingValue const): (WebCore::CSSSelector::pseudoClassType const): (WebCore::CSSSelector::pseudoElementType const): (WebCore::CSSSelector::pagePseudoClassType const): (WebCore::CSSSelector::setPagePseudoType): (WebCore::CSSSelector::setRelation): (WebCore::CSSSelector::setMatch): * Source/WebCore/css/CSSSelectorList.cpp: (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): * Source/WebCore/css/SelectorChecker.cpp: (WebCore::localContextForParent): (WebCore::SelectorChecker::matchRecursively const): (WebCore::attributeValueMatches): (WebCore::canMatchHoverOrActiveInQuirksMode): (WebCore::SelectorChecker::checkOne const): (WebCore::SelectorChecker::checkScrollbarPseudoClass const): (WebCore::SelectorChecker::determineLinkMatchType): * Source/WebCore/css/SelectorChecker.h: (WebCore::SelectorChecker::isCommonPseudoClassSelector): * Source/WebCore/css/SelectorFilter.cpp: (WebCore::SelectorFilter::collectSimpleSelectorHash): (WebCore::SelectorFilter::collectSelectorHashes): * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::parsePageSelector): * Source/WebCore/css/parser/CSSParserSelector.cpp: (WebCore::CSSParserSelector::parsePagePseudoSelector): (WebCore::CSSParserSelector::parsePseudoElementSelector): (WebCore::CSSParserSelector::parsePseudoClassSelector): (WebCore::CSSParserSelector::appendTagHistory): (WebCore::CSSParserSelector::prependTagSelector): (WebCore::CSSParserSelector::releaseTagHistory): (WebCore::CSSParserSelector::isHostPseudoSelector const): * Source/WebCore/css/parser/CSSParserSelector.h: (WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const): (WebCore::CSSParserSelector::isPseudoElementCueFunction const): * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::extractCompoundFlags): (WebCore::isDescendantCombinator): (WebCore::CSSSelectorParser::consumeComplexSelector): (WebCore::CSSSelectorParser::consumeRelativeScopeSelector): (WebCore::CSSSelectorParser::consumeRelativeNestedSelector): (WebCore::isSimpleSelectorValidAfterPseudoElement): (WebCore::CSSSelectorParser::consumeCompoundSelector): (WebCore::CSSSelectorParser::consumeId): (WebCore::CSSSelectorParser::consumeClass): (WebCore::CSSSelectorParser::consumeNesting): (WebCore::CSSSelectorParser::consumeAttribute): (WebCore::CSSSelectorParser::consumePseudo): (WebCore::CSSSelectorParser::consumeCombinator): (WebCore::CSSSelectorParser::consumeAttributeMatch): (WebCore::CSSSelectorParser::consumeAttributeFlags): (WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):
[webkit-changes] [WebKit/WebKit] 46b03a: WebPageProxy::setToolTip accesses a null PageClient
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46b03afa5a231970ac09fdd9cbfeeaaa68dc31b0 https://github.com/WebKit/WebKit/commit/46b03afa5a231970ac09fdd9cbfeeaaa68dc31b0 Author: Abrar Rahman Protyasha Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm Log Message: --- WebPageProxy::setToolTip accesses a null PageClient https://bugs.webkit.org/show_bug.cgi?id=258313 rdar://110501313 Reviewed by Chris Dumez and Wenson Hsieh. In 264455@main, we introduced `WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously`, which asks to perform `WebPageProxy::mouseDidMoveOverElement` at a future time. It turns out there's a null access on `m_pageClient` when we then call into `WebPageProxy::setToolTip`, which happens because we hold a `WeakPtr` instance to the `PageClient` object, meaning there are no guarantees on the PageClient instance's lifetime. To avoid this null dereference, we should only inform the web page about a `MouseMove` event upon consulting whether the web page is closed through `WebPageProxy::isClosed()`. We also add an API test that crashes without this mitigation in place. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: (+[TestEventMonitor addLocalMonitorForEventsMatchingMask:handler:]): Canonical link: https://commits.webkit.org/265456@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 61fca7: Unreviewed, reverting 265453@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61fca740d5a7c4a4ba4c350acbb07c27c2bbd058 https://github.com/WebKit/WebKit/commit/61fca740d5a7c4a4ba4c350acbb07c27c2bbd058 Author: Commit Queue Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj R Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/spi/cocoa/SecuritySPI.h M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/cocoa/StringCocoa.mm M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h M Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h M Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h M Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h M Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp M Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm M Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm M Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h M Source/WebKit/Platform/spi/Cocoa/NWSPI.h M Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h M Tools/TestWebKitAPI/ios/UIKitSPI.h Log Message: --- Unreviewed, reverting 265453@main. https://bugs.webkit.org/show_bug.cgi?id=258446 Revert this revert. This was not the issue Reverted changeset: "Unreviewed, reverting 265448@main." https://bugs.webkit.org/show_bug.cgi?id=258444 https://commits.webkit.org/265453@main Canonical link: https://commits.webkit.org/265455@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f26f5: Unreviewed, reverting 265450@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f26f549486143664543e952f066a5913c1025ac https://github.com/WebKit/WebKit/commit/7f26f549486143664543e952f066a5913c1025ac Author: Commit Queue Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h Log Message: --- Unreviewed, reverting 265450@main. https://bugs.webkit.org/show_bug.cgi?id=258445 Broke builds Reverted changeset: "Add declaration for proxyConfigurations in WKWebsiteDataStore.h" https://bugs.webkit.org/show_bug.cgi?id=258417 https://commits.webkit.org/265450@main Canonical link: https://commits.webkit.org/265454@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 12776e: Unreviewed, reverting 265448@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12776ec9ec0a2897ac139542a5f9a931aca4b599 https://github.com/WebKit/WebKit/commit/12776ec9ec0a2897ac139542a5f9a931aca4b599 Author: Commit Queue Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj A Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/spi/cocoa/SecuritySPI.h M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/cocoa/StringCocoa.mm M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h M Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h M Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h M Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h M Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp M Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm M Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm M Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h M Source/WebKit/Platform/spi/Cocoa/NWSPI.h M Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h M Tools/TestWebKitAPI/ios/UIKitSPI.h Log Message: --- Unreviewed, reverting 265448@main. https://bugs.webkit.org/show_bug.cgi?id=258444 Broke builds Reverted changeset: "[Cocoa] Delete dead code after cleaning up HAVE() and USE() macros" https://bugs.webkit.org/show_bug.cgi?id=258436 https://commits.webkit.org/265448@main Canonical link: https://commits.webkit.org/265453@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7529d2: [TextureMapper] Wrong flags passed to BitmapTextur...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7529d2ec5c77fce30382d8fa2b029ee1b10883d0 https://github.com/WebKit/WebKit/commit/7529d2ec5c77fce30382d8fa2b029ee1b10883d0 Author: Carlos Garcia Campos Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapper.h M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperGL.h M Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp Log Message: --- [TextureMapper] Wrong flags passed to BitmapTextureGL::create in some cases https://bugs.webkit.org/show_bug.cgi?id=258398 Reviewed by Michael Catanzaro. There are some calls passing the internal format as flags. * Source/WebCore/platform/graphics/texmap/TextureMapper.h: * Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::TextureMapperGL::createTexture): * Source/WebCore/platform/graphics/texmap/TextureMapperGL.h: * Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp: (WebCore::TextureMapperPlatformLayerBuffer::clone): Canonical link: https://commits.webkit.org/265452@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f0659: LocalSampleBufferDisplayLayer gets errored in SVC ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f0659d6fa39e7fd3b80a3934f98015fc6a5b1af https://github.com/WebKit/WebKit/commit/6f0659d6fa39e7fd3b80a3934f98015fc6a5b1af Author: Youenn Fablet Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Log Message: --- LocalSampleBufferDisplayLayer gets errored in SVC when going in the background https://bugs.webkit.org/show_bug.cgi?id=258401 rdar://57247 Reviewed by Eric Carlson. In case of LocalSampleBufferDisplayLayer getting errored, we no longer are resetting the bounds of the newly created LocalSampleBufferDisplayLayer. This was removed as part of https://bugs.webkit.org/show_bug.cgi?id=256695 patch as it was creating visible artifacts/flashes. We are now resetting the bounds of a newly created LocalSampleBufferDisplayLayer in case it is recreated. We do by storing the bounds of the LocalSampleBufferDisplayLayer. Manually tested. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layersAreInitialized): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoInlineSizeFenced): Canonical link: https://commits.webkit.org/265451@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4206bf: Add declaration for proxyConfigurations in WKWebsi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4206bf355d9e14f2a27c5e537058497c2bdd1dde https://github.com/WebKit/WebKit/commit/4206bf355d9e14f2a27c5e537058497c2bdd1dde Author: Sihui Liu Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h Log Message: --- Add declaration for proxyConfigurations in WKWebsiteDataStore.h https://bugs.webkit.org/show_bug.cgi?id=258417 rdar://110338162 Reviewed by Wenson Hsieh. Also, guard the implemenation by SDK version instead of deployment target. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.h: Canonical link: https://commits.webkit.org/265450@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c15e56: Remove some unused code relating to isAwaitingLaye...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c15e563b86267df276083a9fe9d5b083aee7e5cc https://github.com/WebKit/WebKit/commit/c15e563b86267df276083a9fe9d5b083aee7e5cc Author: Simon Fraser Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/page/Page.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Remove some unused code relating to isAwaitingLayerTreeTransactionFlush() https://bugs.webkit.org/show_bug.cgi?id=258364 rdar://18430 Reviewed by Tim Horton. The code that called Page::isAwaitingLayerTreeTransactionFlush() was removed in 263798@main, so we can remove isAwaitingLayerTreeTransactionFlush() and related code. * Source/WebCore/page/Page.h: (WebCore::Page::setIsAwaitingLayerTreeTransactionFlush): Deleted. (WebCore::Page::isAwaitingLayerTreeTransactionFlush const): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::willCommitLayerTree): (WebKit::WebPage::didFlushLayerTreeAtTime): Canonical link: https://commits.webkit.org/265449@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a90e5: [Cocoa] Delete dead code after cleaning up HAVE() ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a90e53bcf696a35822fec8282cdc6b230732fef https://github.com/WebKit/WebKit/commit/6a90e53bcf696a35822fec8282cdc6b230732fef Author: Myles C. Maxfield Date: 2023-06-22 (Thu, 22 Jun 2023) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj R Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WTF/wtf/WTFConfig.cpp M Source/WTF/wtf/spi/cocoa/SecuritySPI.h M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/cocoa/StringCocoa.mm M Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h M Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h M Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h M Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h M Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp M Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp M Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm M Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm M Source/WebKit/GPUProcess/mac/GPUProcessMac.mm M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm M Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h M Source/WebKit/Platform/spi/Cocoa/NWSPI.h M Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h M Tools/TestWebKitAPI/ios/UIKitSPI.h Log Message: --- [Cocoa] Delete dead code after cleaning up HAVE() and USE() macros https://bugs.webkit.org/show_bug.cgi?id=258436 rdar://98556 Reviewed by Tim Horton and Alexey Proskuryakov. Now that we've removed a bunch of configurations, there is a bunch of leftover dead code we can remove. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm: Removed. * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformUse.h: * Source/WTF/wtf/text/WTFString.h: * Source/WTF/wtf/text/cocoa/StringCocoa.mm: (WTF::String::String): Deleted. * Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp: * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h: * Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h: * Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h: * Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h: * Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::createTextStyleFont): (WebCore::mapWidth): * Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp: (WebCore::NetworkStorageSession::createCFStorageSessionForIdentifier): * Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::createPrivateStorageSession): * Source/WebKit/GPUProcess/mac/GPUProcessMac.mm: (WebKit::GPUProcess::initializeSandbox): * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm: (WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm: (WebKit::setNWParametersApplicationIdentifiers): (WebKit::setNWParametersTrackerOptions): (WebKit::isKnownTracker): * Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h: * Source/WebKit/Platform/spi/Cocoa/NWSPI.h: * Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h: * Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::initializeSandbox): * Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Canonical link: https://commits.webkit.org/265448@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
