[webkit-changes] [WebKit/WebKit] 53c9be: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53c9beee074782ce0c200522de1e26fc232e88d1 https://github.com/WebKit/WebKit/commit/53c9beee074782ce0c200522de1e26fc232e88d1 Author: Fujii Hironori Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/compositing/geometry/clipping-foreground-expected.txt M LayoutTests/platform/wincairo/compositing/shadows/shadow-drawing-expected.txt M LayoutTests/platform/wincairo/css1/basic/inheritance-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/clear_float-expected.txt M LayoutTests/platform/wincairo/css1/font_properties/font-expected.txt M LayoutTests/platform/wincairo/css1/font_properties/font_size-expected.txt M LayoutTests/platform/wincairo/css1/formatting_model/inline_elements-expected.txt M LayoutTests/platform/wincairo/css1/text_properties/vertical_align-expected.txt M LayoutTests/platform/wincairo/css2.1/20110323/table-height-algorithm-023-expected.txt M LayoutTests/platform/wincairo/css2.1/20110323/table-height-algorithm-024-expected.txt M LayoutTests/platform/wincairo/css2.1/t100801-c544-valgn-02-d-agi-expected.txt M LayoutTests/platform/wincairo/css2.1/t100801-c544-valgn-04-d-agi-expected.txt M LayoutTests/platform/wincairo/css2.1/t1507-c526-font-sz-00-b-expected.txt M LayoutTests/platform/wincairo/css2.1/t1507-c526-font-sz-02-b-a-expected.txt M LayoutTests/platform/wincairo/css2.1/t1508-c527-font-09-b-expected.txt M LayoutTests/platform/wincairo/editing/selection/select-text-overflow-ellipsis-expected.txt M LayoutTests/platform/wincairo/fast/css-generated-content/013-expected.txt M LayoutTests/platform/wincairo/fast/css-generated-content/014-expected.txt M LayoutTests/platform/wincairo/fast/css-generated-content/015-expected.txt M LayoutTests/platform/wincairo/fast/css/css1_forward_compatible_parsing-expected.txt M LayoutTests/platform/wincairo/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt M LayoutTests/platform/wincairo/fast/css/h1-in-section-elements-expected.txt M LayoutTests/platform/wincairo/fast/css/invalid-percentage-property-expected.txt M LayoutTests/platform/wincairo/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt M LayoutTests/platform/wincairo/fast/css/text-overflow-ellipsis-text-align-center-expected.txt M LayoutTests/platform/wincairo/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt M LayoutTests/platform/wincairo/fast/css/text-overflow-ellipsis-text-align-left-expected.txt M LayoutTests/platform/wincairo/fast/css/text-overflow-ellipsis-text-align-right-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-center-mixed-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-justify-mixed-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-left-mixed-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt M LayoutTests/platform/wincairo/fast/css/vertical-text-overflow-ellipsis-text-align-right-mixed-expected.txt M LayoutTests/platform/wincairo/fast/css/word-space-extra-expected.txt M LayoutTests/platform/wincairo/fast/text/basic/generic-family-changes-expected.txt M LayoutTests/platform/wincairo/fast/text/basic/generic-family-reset-expected.txt M LayoutTests/platform/wincairo/fast/text/line-breaks-expected.txt M LayoutTests/platform/wincairo/fast/transforms/bounding-rect-zoom-expected.txt M LayoutTests/platform/wincairo/fast/transforms/transforms-with-zoom-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/compositing/geometry/clipping-foreground-expected.txt: * LayoutTests/platform/wincairo/compositing/shadows/shadow-drawing-expected.txt: * LayoutTests/platform/wincairo/css1/basic/inheritance-expected.txt: * LayoutTests/platform/wincairo/css1/box_properties/clear_float-expected.txt: * LayoutTests/platform/wincairo/css1/font_properties/font-expected.txt: * LayoutTests/platform/wincairo/css1/font_properties/font_size-expected.txt: * LayoutTests/platform/wincairo/css1/formatting_model/inline_elements-expected.txt: * LayoutTests/platform/wincairo/css1/text_properties/vertical_align-expected.txt: * LayoutTests/platform/wincairo/css2.1/20110323/table
[webkit-changes] [WebKit/WebKit] 72c08b: [Cocoa] Forward-declare PlatformPlaybackSessionInt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72c08bf5020233bbc470713f02c08914c2bc4690 https://github.com/WebKit/WebKit/commit/72c08bf5020233bbc470713f02c08914c2bc4690 Author: Andy Estes Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/graphics/PlatformPlaybackSessionInterface.h A Source/WebCore/platform/graphics/PlatformVideoFullscreenInterface.h M Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- [Cocoa] Forward-declare PlatformPlaybackSessionInterface and PlatformVideoFullscreenInterface https://bugs.webkit.org/show_bug.cgi?id=258760 rdar://111597144 Reviewed by Jer Noble. Added PlatformPlaybackSessionInterface.h and PlatformVideoFullscreenInterface.h to define typedefs for PlatformPlaybackSessionInterface and PlatformVideoFullscreenInterface using forward declarations of their platform-specific class names rather than header imports. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/PlatformPlaybackSessionInterface.h: Added. * Source/WebCore/platform/graphics/PlatformVideoFullscreenInterface.h: Added. * Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm: * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController _togglePiPAction:]): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: Canonical link: https://commits.webkit.org/265681@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7dc4e7: REGRESSION(265569@main): All path segments should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7dc4e7c7d38b1bc12aa3b7ba168e23699bc5fe6e https://github.com/WebKit/WebKit/commit/7dc4e7c7d38b1bc12aa3b7ba168e23699bc5fe6e Author: Said Abou-Hallawa Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/platform/graphics/PathSegmentData.cpp M Source/WebCore/platform/graphics/PathSegmentData.h M Source/WebCore/platform/graphics/PathStream.cpp M Source/WebCore/platform/graphics/PathStream.h M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h M Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in M Source/WebKit/Shared/WebCoreArgumentCoders.h M Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp Log Message: --- REGRESSION(265569@main): All path segments should be coded by StreamConnectionEncoder https://bugs.webkit.org/show_bug.cgi?id=258734 rdar://111570644 Reviewed by Wenson Hsieh. Detemplatize the composite path segments. Add StreamConnectionEncoder as additional encoder for these structures. This should recover part of the CanvasLines regression which was caused by 265569@main. * Source/WebCore/platform/graphics/PathSegmentData.cpp: (WebCore::calculateArcToEndPoint): (WebCore::PathArcTo::calculateEndPoint const): (WebCore::PathArcTo::extendBoundingRect const): (WebCore::PathDataLine::calculateEndPoint const): (WebCore::PathDataLine::extendFastBoundingRect const): (WebCore::PathDataLine::extendBoundingRect const): (WebCore::PathDataLine::addToImpl const): (WebCore::PathDataLine::applyElements const): (WebCore::operator<<): (WebCore::PathDataQuadCurve::calculateEndPoint const): (WebCore::PathDataQuadCurve::extendFastBoundingRect const): (WebCore::PathDataQuadCurve::extendBoundingRect const): (WebCore::PathDataQuadCurve::addToImpl const): (WebCore::PathDataQuadCurve::applyElements const): (WebCore::PathDataBezierCurve::calculateEndPoint const): (WebCore::PathDataBezierCurve::extendFastBoundingRect const): (WebCore::PathDataBezierCurve::extendBoundingRect const): (WebCore::PathDataBezierCurve::addToImpl const): (WebCore::PathDataBezierCurve::applyElements const): (WebCore::PathDataArc::calculateEndPoint const): (WebCore::PathDataArc::extendFastBoundingRect const): (WebCore::PathDataArc::extendBoundingRect const): (WebCore::PathDataArc::addToImpl const): (WebCore::DataType2>::calculateEndPoint const): Deleted. (WebCore::DataType2>::extendFastBoundingRect const): Deleted. (WebCore::DataType2>::extendBoundingRect const): Deleted. (WebCore::DataType2>::addToImpl const): Deleted. (WebCore::DataType2>::applyElements const): Deleted. * Source/WebCore/platform/graphics/PathSegmentData.h: (WebCore::PathDataArc::applyElements const): (WebCore::operator<<): Deleted. * Source/WebCore/platform/graphics/PathStream.cpp: (WebCore::PathStream::lastIfMoveTo const): (WebCore::PathStream::addLineTo): (WebCore::PathStream::addQuadCurveTo): (WebCore::PathStream::addBezierCurveTo): (WebCore::PathStream::addArcTo): (WebCore::PathStream::mergeIntoComposite): Deleted. * Source/WebCore/platform/graphics/PathStream.h: * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::strokePath): * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h: (WebCore::DisplayList::StrokeLine::StrokeLine): * Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in: * Source/WebKit/Shared/WebCoreArgumentCoders.h: (): Deleted. * Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/265680@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cacc9a: Undefined behavior in HashSet
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cacc9a183c3e854c7478221014706a45dfcdbfe3 https://github.com/WebKit/WebKit/commit/cacc9a183c3e854c7478221014706a45dfcdbfe3 Author: Chris Dumez Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/css/CSSSelector.cpp M Source/WebCore/css/CSSSelector.h M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/SelectorChecker.h M Source/WebCore/css/SelectorCheckerTestFunctions.h M Source/WebCore/css/SelectorFilter.cpp M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in M Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py M Source/WebCore/css/parser/CSSParserSelector.cpp M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/cssjit/SelectorCompiler.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/FullscreenManager.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/html/HTMLDialogElement.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLFieldSetElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLOptGroupElement.cpp M Source/WebCore/html/HTMLOptionElement.cpp M Source/WebCore/html/HTMLProgressElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/InputType.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/InteractionRegion.cpp M Source/WebCore/style/ChildChangeInvalidation.cpp M Source/WebCore/style/HasSelectorFilter.cpp M Source/WebCore/style/RuleFeature.cpp M Source/WebCore/style/RuleSet.cpp M Source/WebCore/style/StyleResolver.cpp Log Message: --- Undefined behavior in HashSet https://bugs.webkit.org/show_bug.cgi?id=258755 Reviewed by Ryosuke Niwa. Undefined behavior in HashSet: ``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /usr/local/include/wtf/RefPtr.h:75:82 in /usr/local/include/wtf/HashTable.h:301:114: runtime error: load of value 4294967295, which is not a valid value for type 'const WebCore::CSSSelector::PseudoClassType' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /usr/local/include/wtf/HashTable.h:301:114 in /usr/local/include/wtf/HashFunctions.h:104:46: runtime error: load of value 4294967295, which is not a valid value for type 'WebCore::CSSSelector::PseudoClassType' ``` The issue is that CSSSelector is not a scoped enumeration but we use `StrongEnumHashTraits` for HashSets (in RuleFeature.h for example). This means we end up using `std::underlying_type::max()` and `std::underlying_type::max() -1` as special HashMap values. Casting values outside the enum value range to an enumeration that is not scoped is undefined behavior. To address the issue, I am converting CSSSelector::PseudoClassType to a scoped enumeration. * Source/WebCore/css/CSSSelector.cpp: (WebCore::simpleSelectorSpecificity): (WebCore::appendPseudoClassFunctionTail): (WebCore::CSSSelector::selectorText const): (WebCore::CSSSelector::resolveNestingParentSelectors): (WebCore::CSSSelector::replaceNestingParentByPseudoClassScope): * Source/WebCore/css/CSSSelector.h: (WebCore::pseudoClassIsRelativeToSiblings): (WebCore::isTreeStructuralPseudoClass): (WebCore::isLogicalCombinationPseudoClass): (WebCore::CSSSelector::setPseudoClassType): * Source/WebCore/css/SelectorChecker.cpp: (WebCore::localContextForParent): (WebCore::canMatchHoverOrActiveInQuirksMode): (WebCore::SelectorChecker::checkOne const): (WebCore::SelectorChecker::checkScrollbarPseudoClass const): (WebCore::SelectorChecker::determineLinkMatchType): * Source/WebCore/css/SelectorChecker.h: (WebCore::SelectorChecker::isCommonPseudoClassSelector): * Source/WebCore/css/SelectorCheckerTestFunctions.h: (WebCore::matchesLegacyDirectFocusPseudoClass): (WebCore::matchesFocusPseudoClass): (WebCore::matchesFocusVisiblePseudoClass): (WebCore::matchesFocusWithinPseudoClass): * Source/WebCore/css/SelectorFilter.cpp: (WebCore::SelectorFilter::collectSimpleSelectorHash): * Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in: * Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py: (enumerablePseudoType): * Source/WebCore/css/parser/CSSParserSelector.cpp: (WebCore::CSSParserSelector::parsePseudoClassSelector): (WebCore::CSSParserSelector::isHostPseudoSelector const): * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeRelativeScopeSelector): (WebCore::isScrollbarPseudoClass): (WebCore::isUserActionPseudoClass): (WebCore::isPseudoClassValidAfterPseudoElement): (WebCore::isOnlyPseudoClassFu
[webkit-changes] [WebKit/WebKit] 0105c6: REGRESSION(264489@main): wpt/webaudio/the-audio-ap...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0105c62ef91b4f82e7f09f42287bbd445ed65ddc https://github.com/WebKit/WebKit/commit/0105c62ef91b4f82e7f09f42287bbd445ed65ddc Author: Chris Dumez Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https-expected.txt M Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp Log Message: --- REGRESSION(264489@main): wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html https://bugs.webkit.org/show_bug.cgi?id=258209 rdar://110900370 Reviewed by Jer Noble. The test was passing a blob inside the options passed to the AudioWorklet processor constructor and expecting a processorerror event to get fired. The reason for this expectation is that Blobs (as well as all other non-builtin JS types) are not exposed to AudioWorklet and we thus expect the deserialization of the Blob to fail for the AudioWorkletGlobalScope. To address the issue, we now check the deserialized type inside SerializedScriptValue's CloneDeserializer to make sure the type is exposed to the current global scope. If it isn't, we fail deserialization. We now also do proper deserialization error handling inside AudioWorkletGlobalScope::createProcessor(). * LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https-expected.txt: * Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp: (WebCore::AudioWorkletGlobalScope::createProcessor): * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::isTypeExposedToGlobalObject): (WebCore::CloneDeserializer::readTerminal): Canonical link: https://commits.webkit.org/265678@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f807b4: REGRESSION(265657@main): imported/w3c/web-platform...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f807b4b42e8a1051a2d3032b6a519017be24e63d https://github.com/WebKit/WebKit/commit/f807b4b42e8a1051a2d3032b6a519017be24e63d Author: Myles C. Maxfield Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-35-t-manual-expected.txt Log Message: --- REGRESSION(265657@main): imported/w3c/web-platform-tests/svg/import/animate-elem-35-t-manual.svg is failing https://bugs.webkit.org/show_bug.cgi?id=258756 rdar://111593596 Unreviewed test gardening. Simply needs a rebaseline. * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/animate-elem-35-t-manual-expected.txt: Canonical link: https://commits.webkit.org/265677@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ce829: REGRESSION(265657@main): svg/W3C-I18N/tspan-direct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ce829b573fa79059fedf82b13be8ea472cb6ab6 https://github.com/WebKit/WebKit/commit/2ce829b573fa79059fedf82b13be8ea472cb6ab6 Author: Myles C. Maxfield Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt Log Message: --- REGRESSION(265657@main): svg/W3C-I18N/tspan-direction-rtl.svg is failing https://bugs.webkit.org/show_bug.cgi?id=258751 rdar://111591383 Unreviewed test gardening. Simply needs a rebaseline. * LayoutTests/platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Canonical link: https://commits.webkit.org/265676@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37aaa1: [WebGPU] Abstract interface needs to use WebCore t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37aaa17f0b0b96081c9135b94ce88c7516027892 https://github.com/WebKit/WebKit/commit/37aaa17f0b0b96081c9135b94ce88c7516027892 Author: Myles C. Maxfield Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/Headers.cmake M Source/WebCore/Modules/WebGPU/GPU.cpp M Source/WebCore/Modules/WebGPU/GPU.h M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp M Source/WebCore/Modules/WebGPU/GPUAdapter.h M Source/WebCore/Modules/WebGPU/GPUAddressMode.h M Source/WebCore/Modules/WebGPU/GPUAutoLayoutMode.h M Source/WebCore/Modules/WebGPU/GPUBindGroup.cpp M Source/WebCore/Modules/WebGPU/GPUBindGroup.h M Source/WebCore/Modules/WebGPU/GPUBindGroupDescriptor.h M Source/WebCore/Modules/WebGPU/GPUBindGroupEntry.h M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.cpp M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.h M Source/WebCore/Modules/WebGPU/GPUBindGroupLayoutDescriptor.h M Source/WebCore/Modules/WebGPU/GPUBindGroupLayoutEntry.h M Source/WebCore/Modules/WebGPU/GPUBlendComponent.h M Source/WebCore/Modules/WebGPU/GPUBlendFactor.h M Source/WebCore/Modules/WebGPU/GPUBlendOperation.h M Source/WebCore/Modules/WebGPU/GPUBlendState.h M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp M Source/WebCore/Modules/WebGPU/GPUBuffer.h M Source/WebCore/Modules/WebGPU/GPUBufferBinding.h M Source/WebCore/Modules/WebGPU/GPUBufferBindingLayout.h M Source/WebCore/Modules/WebGPU/GPUBufferBindingType.h M Source/WebCore/Modules/WebGPU/GPUBufferDescriptor.h M Source/WebCore/Modules/WebGPU/GPUBufferUsage.h M Source/WebCore/Modules/WebGPU/GPUCanvasCompositingAlphaMode.h M Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/GPUColorDict.h M Source/WebCore/Modules/WebGPU/GPUColorTargetState.h M Source/WebCore/Modules/WebGPU/GPUColorWrite.h M Source/WebCore/Modules/WebGPU/GPUCommandBuffer.cpp M Source/WebCore/Modules/WebGPU/GPUCommandBuffer.h M Source/WebCore/Modules/WebGPU/GPUCommandBufferDescriptor.h M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.h M Source/WebCore/Modules/WebGPU/GPUCommandEncoderDescriptor.h M Source/WebCore/Modules/WebGPU/GPUCompareFunction.h M Source/WebCore/Modules/WebGPU/GPUCompilationInfo.h M Source/WebCore/Modules/WebGPU/GPUCompilationMessage.cpp M Source/WebCore/Modules/WebGPU/GPUCompilationMessage.h M Source/WebCore/Modules/WebGPU/GPUCompilationMessageType.h M Source/WebCore/Modules/WebGPU/GPUCompositorIntegration.h M Source/WebCore/Modules/WebGPU/GPUComputePassDescriptor.h M Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp M Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.h M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampLocation.h M Source/WebCore/Modules/WebGPU/GPUComputePassTimestampWrite.h M Source/WebCore/Modules/WebGPU/GPUComputePipeline.h M Source/WebCore/Modules/WebGPU/GPUComputePipelineDescriptor.h M Source/WebCore/Modules/WebGPU/GPUCullMode.h M Source/WebCore/Modules/WebGPU/GPUDepthStencilState.h M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h M Source/WebCore/Modules/WebGPU/GPUDeviceDescriptor.h M Source/WebCore/Modules/WebGPU/GPUDeviceError.idl M Source/WebCore/Modules/WebGPU/GPUDeviceLost.idl M Source/WebCore/Modules/WebGPU/GPUDeviceLostInfo.cpp M Source/WebCore/Modules/WebGPU/GPUDeviceLostInfo.h M Source/WebCore/Modules/WebGPU/GPUDeviceLostReason.h M Source/WebCore/Modules/WebGPU/GPUDeviceUncapturedError.idl M Source/WebCore/Modules/WebGPU/GPUError.h M Source/WebCore/Modules/WebGPU/GPUErrorFilter.h M Source/WebCore/Modules/WebGPU/GPUExtent3DDict.h M Source/WebCore/Modules/WebGPU/GPUExternalTexture.cpp M Source/WebCore/Modules/WebGPU/GPUExternalTexture.h M Source/WebCore/Modules/WebGPU/GPUExternalTextureBindingLayout.h M Source/WebCore/Modules/WebGPU/GPUExternalTextureDescriptor.h M Source/WebCore/Modules/WebGPU/GPUFeatureName.h M Source/WebCore/Modules/WebGPU/GPUFilterMode.h M Source/WebCore/Modules/WebGPU/GPUFragmentState.h M Source/WebCore/Modules/WebGPU/GPUFrontFace.h M Source/WebCore/Modules/WebGPU/GPUImageCopyBuffer.h M Source/WebCore/Modules/WebGPU/GPUImageCopyExternalImage.h M Source/WebCore/Modules/WebGPU/GPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/GPUImageCopyTextureTagged.h M Source/WebCore/Modules/WebGPU/GPUImageDataLayout.h M Source/WebCore/Modules/WebGPU/GPUIndexFormat.h M Source/WebCore/Modules/WebGPU/GPUIntegralTypes.h M Source/WebCore/Modules/WebGPU/GPUInternalError.h M Source/WebCore/Modules/WebGPU/GPULoadOp.h M Source/WebCore/M
[webkit-changes] [WebKit/WebKit] cecd69: [ watchOS ] Crash in PlaybackSessionInterfaceAVKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cecd69451d07f0ab7eb2fbba3661ef19fa085072 https://github.com/WebKit/WebKit/commit/cecd69451d07f0ab7eb2fbba3661ef19fa085072 Author: Jer Noble Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h A Source/WebCore/platform/graphics/cocoa/NullVideoFullscreenInterface.h M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h Log Message: --- [ watchOS ] Crash in PlaybackSessionInterfaceAVKit::PlaybackSessionInterfaceAVKit https://bugs.webkit.org/show_bug.cgi?id=258750 rdar://110387309 Reviewed by Andy Estes and Eric Carlson. Video playback on watchOS is disabled, but somehow pages are getting far enough along in video playback to cause a PlaybackSessionInterfaceAVKit to be instantiated. Due to differences in the implementation of AVKit on watchOS from iOS, our technique of creating a WebAVPlayerController causes an unimplemented selector exception. Since we shouldn't be playing any video on watchOS anyway, just add empty implementations of VideoFullscreenInterface and PlaybackSessionInterface for use there. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h: Added. * Source/WebCore/platform/graphics/cocoa/NullVideoFullscreenInterface.h: Added. * Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h: * Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h: Canonical link: https://commits.webkit.org/265674@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92384c: AX: TextMarker-based assistive technologies skip d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92384cf464fb98c7f6df0797a36b84417f1bfe63 https://github.com/WebKit/WebKit/commit/92384cf464fb98c7f6df0797a36b84417f1bfe63 Author: Tyler Wilcock Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: A LayoutTests/accessibility/display-contents/end-text-marker-expected.txt A LayoutTests/accessibility/display-contents/end-text-marker.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityNodeObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.h M Source/WebCore/editing/Editing.cpp M Source/WebCore/editing/Editing.h M Source/WebCore/editing/VisiblePosition.cpp M Source/WebCore/editing/VisiblePosition.h Log Message: --- AX: TextMarker-based assistive technologies skip display:contents text content on macOS https://bugs.webkit.org/show_bug.cgi?id=258687 rdar://problem/111523549 Reviewed by Chris Fleizach. This bug happened because `WebCore::nextVisuallyDistinctCandidate` had an optimization to skip to the end of nodes that had no associated renderer. However, `AXObjectCache::characterOffsetFromVisiblePosition` relies on processing every character to build the right `CharacterOffset`. This patch fixes the issue by allowing the skip-unrendered-nodes behavior to be configurable specifically for display contents elements, since AX is fine to skip other types of unrendered nodes. This patch also moves several `VisiblePosition`-related function implementations that were unnecessarily in `AccessibilityRenderObject` to `AccessibilityNodeObject`, since all only require a `Node`. * LayoutTests/accessibility/display-contents/end-text-marker-expected.txt: Added. * LayoutTests/accessibility/display-contents/end-text-marker.html: Added. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::characterOffsetFromVisiblePosition): * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::CharacterOffset::debugDescription): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::visiblePositionRange const): (WebCore::AccessibilityNodeObject::selectedVisiblePositionRange const): (WebCore::AccessibilityNodeObject::indexForVisiblePosition const): (WebCore::AccessibilityNodeObject::visiblePositionForIndex const): (WebCore::AccessibilityNodeObject::visiblePositionRangeForLine const): * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::topRenderer const): (WebCore::AccessibilityObject::visiblePositionForPoint const): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::shouldGetTextFromNode const): (WebCore::AccessibilityRenderObject::visiblePositionForIndex const): (WebCore::AccessibilityRenderObject::indexForVisiblePosition const): (WebCore::AccessibilityRenderObject::topRenderer const): Deleted. (WebCore::AccessibilityRenderObject::visiblePositionRange const): Deleted. (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const): Deleted. (WebCore::AccessibilityRenderObject::selectedVisiblePositionRange const): Deleted. (WebCore::AccessibilityRenderObject::visiblePositionForPoint const): Deleted. * Source/WebCore/accessibility/AccessibilityRenderObject.h: * Source/WebCore/editing/Editing.cpp: (WebCore::nextVisuallyDistinctCandidate): * Source/WebCore/editing/Editing.h: * Source/WebCore/editing/VisiblePosition.cpp: (WebCore::VisiblePositionRange::debugDescription const): * Source/WebCore/editing/VisiblePosition.h: Canonical link: https://commits.webkit.org/265673@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c819e7: Fullscreen video does not always match window size...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c819e77ac5671e6c2df6822462a0294871b492c5 https://github.com/WebKit/WebKit/commit/c819e77ac5671e6c2df6822462a0294871b492c5 Author: Mike Wyrzykowski Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm M Source/WebCore/rendering/RenderVideo.cpp Log Message: --- Fullscreen video does not always match window size at certain resolutions https://bugs.webkit.org/show_bug.cgi?id=258484 rdar://110724034 Reviewed by Jer Noble. The video is using ObjectFit::Contain and UIKit is trying to preserve the initial aspect ratio from when the video entered fullscreen during resizes. However, we requested the the window to only resize to integral point values, so the aspect ratio can be off more after a resize than it was initially. * Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm: (-[WebAVPlayerLayer calculateTargetVideoFrame]): Ensure the target video frame is integral values. * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::areAspectRatiosEssentiallyEqual): At most the difference is one point, i.e., deviceScaleFactor, so we can use this as a tolerance value passed to WTF::areEssentiallyEqual. (WebCore::RenderVideo::videoBox const): (WebCore::RenderVideo::updatePlayer): Make the video take up the entire area if the aspect ratio is almost identical and we are in fullscreen. Canonical link: https://commits.webkit.org/265672@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd7169: Implement word-break: auto
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd716947b5196a89ab2d9621075984389e2d4e50 https://github.com/WebKit/WebKit/commit/bd716947b5196a89ab2d9621075984389e2d4e50 Author: Myles C. Maxfield Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-invalid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-invalid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-break-valid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-000-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-000.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-004-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-005-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-text/word-break/auto/word-break-auto-005.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderText.h M Source/WebCore/rendering/line/BreakingContext.h M Source/WebCore/rendering/style/RenderStyleConstants.cpp M Source/WebCore/rendering/style/RenderStyleConstants.h M Source/WebCore/rendering/style/StyleRareInheritedData.h Log Message: --- Implement word-break: auto https://bugs.webkit.org/show_bug.cgi?id=258668 rdar://111507205 Reviewed by Tim Nguyen. https://github.com/w3c/csswg-drafts/issues/7193#issuecomment-1611772475 says: > RESOLVED: remove auto () from word-boundary-detection, add keyword to > word-break > for this functionality This patch implements word-break: auto and hooks it up to the CFStringTokenizer infrastructure already implemented in 265059@main. * Source/WebCore/css/CSSPrimitiveValueMappings.h: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp: (WebCore::Layout::InlineItemsBuilder::handleTextContent): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::endsWithSoftWrapOpportunity): * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::contentAnalysis): * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h: * Source/WebCore/rendering/RenderText.cpp: (WebCore::mapWordBreakToContentAnalysis): (WebCore::RenderText::computePreferredLogicalWidths): (WebCore::mapWordBoundaryDetectionToContentAnalysis): Deleted. * Source/WebCore/rendering/RenderText.h: * Source/WebCore/rendering/line/BreakingContext.h: (WebCore::BreakingContext::handleText): * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: Canonical link: https://commits.webkit.org/265671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9311f4: bordercolor attribute should not create a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9311f46770bac895da2a29aedd976598f44e1ca0 https://github.com/WebKit/WebKit/commit/9311f46770bac895da2a29aedd976598f44e1ca0 Author: Karl Dubost Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/table/border-changes-expected.txt M LayoutTests/fast/table/border-changes.html M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/colgroup_valign_bottom-expected.xhtml A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/colgroup_valign_top-expected.xhtml A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/w3c-import.log M LayoutTests/platform/glib/tables/mozilla/bugs/bug1163-1-expected.txt M LayoutTests/platform/glib/tables/mozilla/bugs/bug131020-expected.txt M LayoutTests/platform/glib/tables/mozilla/bugs/bug131020_iframe-expected.txt R LayoutTests/platform/gtk/tables/mozilla/bugs/bug1163-1-expected.png A LayoutTests/platform/ios-wk2/tables/mozilla/bugs/bug1163-1-expected.txt A LayoutTests/platform/ios-wk2/tables/mozilla/bugs/bug131020-expected.txt A LayoutTests/platform/ios-wk2/tables/mozilla/bugs/bug131020_iframe-expected.txt R LayoutTests/platform/ios/tables/mozilla/bugs/bug1163-1-expected.txt R LayoutTests/platform/ios/tables/mozilla/bugs/bug131020-expected.txt R LayoutTests/platform/ios/tables/mozilla/bugs/bug131020_iframe-expected.txt R LayoutTests/platform/mac/tables/mozilla/bugs/bug1163-1-expected.png R LayoutTests/platform/mac/tables/mozilla/bugs/bug1163-1-expected.txt R LayoutTests/platform/mac/tables/mozilla/bugs/bug131020-expected.txt R LayoutTests/platform/mac/tables/mozilla/bugs/bug131020_iframe-expected.txt R LayoutTests/platform/wincairo/tables/mozilla/bugs/bug1163-1-expected.txt R LayoutTests/platform/wincairo/tables/mozilla/bugs/bug131020-expected.txt R LayoutTests/platform/wincairo/tables/mozilla/bugs/bug131020_iframe-expected.txt A LayoutTests/tables/mozilla/bugs/bug1163-1-expected.txt A LayoutTests/tables/mozilla/bugs/bug131020-expected.txt A LayoutTests/tables/mozilla/bugs/bug131020_iframe-expected.txt M Source/WebCore/html/HTMLTableElement.cpp M Source/WebCore/html/HTMLTableElement.h Log Message: --- bordercolor attribute should not create a visible border https://bugs.webkit.org/show_bug.cgi?id=256850 rdar://109436009 Reviewed by Tim Nguyen. A single bordercolor attribute on a table should not affect the visibility of the border, which is none by default. This is aligned with Firefox and what the HTML spec is prescribing. > treat the [bordercolor] attribute as a presentational hint setting > the element's 'border-top-color', 'border-right-color', > 'border-bottom-color', and 'border-left-color' properties to the > resulting color." > — https://html.spec.whatwg.org/multipage/rendering.html#tables-2 It imports also one knew WPT test WPT: 3d9cd84 There is a followup bug for tests failing https://bugs.webkit.org/show_bug.cgi?id=257254 This is the next step. * LayoutTests/fast/table/border-changes-expected.txt: * LayoutTests/fast/table/border-changes.html: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/colgroup_valign_bottom-expected.xhtml: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/colgroup_valign_top-expected.xhtml: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/table-bordercolor-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/tables/w3c-import.log: * LayoutTests/platform/glib/tables/mozilla/bugs/bug1163-1-expected.txt: * LayoutTests/platform/glib/tables/mozilla/bugs/bug131020_iframe-expected.txt: * LayoutTests/platform/glib/tables/mozilla/bugs/bug131020-expected.txt: * LayoutTests/platform/gtk/tables/mozilla/bugs/bug1163-1-
[webkit-changes] [WebKit/WebKit] 6178f6: Add IDL files and empty implementation for Cookie ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6178f6321703c1007f79e9beeef8d27f8da9eec2 https://github.com/WebKit/WebKit/commit/6178f6321703c1007f79e9beeef8d27f8da9eec2 Author: Rupin Mittal Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_document_cookie.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_http_cookie_and_set_cookie_headers.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_and_no_value.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_equals_in_value.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/change_eventhandler_for_no_name_multiple_values.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieListItem_attributes.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_arguments.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_delete_basic.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_basic.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_delete.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_event_overwrite.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_arguments.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_multiple.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_getAll_set_basic.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_arguments.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_delete_basic.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_frames.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_basic.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_ordering.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_in_detached_frame.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_opaque_origin.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_set_arguments.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/cookieStore_special_names.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/encoding.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/httponly_cookies.https.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookie-store/cookieStore_get_set_across_origins.sub.https-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookie-store/serviceworker_cookieStore_cross_origin.https.sub-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/cookie-store/idlharness.tentative.https.any-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make A Source/WebCore/Modules/cookie-store/CookieInit.h A Source/WebCore/Modules/cookie-store/CookieInit.idl A Source/WebCore/Modules/cookie-store/CookieListItem.h A Source/WebCore/Modules/cookie-store/CookieListItem.idl A Source/WebCore/Modules/cookie-store/CookieSameSite.h A Source/WebCore/Modules/cookie-store/CookieSameSite.idl A Source/WebCore/Modules/cookie-store/CookieStore.cpp A Source/WebCore/Modules/cookie-store/CookieStore.h A Source/WebCore/Modules/cookie-store/CookieStore.idl A Source/WebCore/Modules/cookie-store/CookieStoreDeleteOptions.h A Source/WebCore/Modules/cookie-store/CookieStoreDeleteOptions.idl A Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.h A Source/WebCore/Modules/cookie-store/CookieStoreGetOptions.idl A Source/WebCore/Modules/cookie-store/LocalDOMWindow+CookieStore.idl
[webkit-changes] [WebKit/WebKit] b0d43f: Revert gardening changes 265171@main and 265172@ma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b0d43f67764c4857903c3e79800664eff4aa95b6 https://github.com/WebKit/WebKit/commit/b0d43f67764c4857903c3e79800664eff4aa95b6 Author: Jer Noble Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- Revert gardening changes 265171@main and 265172@main after fix in 265656@main https://bugs.webkit.org/show_bug.cgi?id=258742 Unreviewed gardening after addressing issue causing these tests to fail flakily. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/265668@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db8fe9: REGRESSION: (264863@main) Fix regression in CSSCal...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db8fe90cd4538413b18338e2308c9754c37fffe3 https://github.com/WebKit/WebKit/commit/db8fe90cd4538413b18338e2308c9754c37fffe3 Author: Chirag M Shah Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: A LayoutTests/fast/css/css-calc-rem-no-children-crash-expected.txt A LayoutTests/fast/css/css-calc-rem-no-children-crash.html M Source/WebCore/css/calc/CSSCalcValue.cpp Log Message: --- REGRESSION: (264863@main) Fix regression in CSSCalcValue https://bugs.webkit.org/show_bug.cgi?id=258684 rdar://111512503 Reviewed by Antti Koivisto. This change fixes a regression introduced in rdar://109503971 where we now create a step operation with no children. This makes sense for CalcOperator::Round, but not for CalcOperator::Mod and CalcOperator::Rem * LayoutTests/fast/css/css-calc-rem-no-children-crash-expected.txt: Added. * LayoutTests/fast/css/css-calc-rem-no-children-crash.html: Added. * Source/WebCore/css/calc/CSSCalcValue.cpp: (WebCore::createCSS): Canonical link: https://commits.webkit.org/265667@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 604725: Add Nvidia to domain affiliations on team page
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6047253bcede33baac91b5717ee82a3a8c9619a8 https://github.com/WebKit/WebKit/commit/6047253bcede33baac91b5717ee82a3a8c9619a8 Author: Byungseon(Sun) Shin Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Websites/webkit.org/wp-content/themes/webkit/team.php Log Message: --- Add Nvidia to domain affiliations on team page https://bugs.webkit.org/show_bug.cgi?id=258744 Reviewed by Yusuke Suzuki. * Websites/webkit.org/wp-content/themes/webkit/team.php: Canonical link: https://commits.webkit.org/265666@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cee3c7: Audio element control buttons are no longer circul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cee3c7d1803a4e8ab72a2f4c8065e4d226b18c54 https://github.com/WebKit/WebKit/commit/cee3c7d1803a4e8ab72a2f4c8065e4d226b18c54 Author: Richard Robinson Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/Modules/modern-media-controls/controls/button.js Log Message: --- Audio element control buttons are no longer circular after refreshing the page in visionOS https://bugs.webkit.org/show_bug.cgi?id=258739 rdar://111523213 Reviewed by Jer Noble. Fix the logic in `_updateImageMetrics` to possibly return early only after the final new width and height are actually computed. * Source/WebCore/Modules/modern-media-controls/controls/button.js: (Button.prototype._updateImageMetrics): (Button): Canonical link: https://commits.webkit.org/265665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 606e9d: Revert(265057@main): Stop parsing word-boundary-de...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 606e9d4b0da442b51d9acb9ef992895e3c7f32f5 https://github.com/WebKit/WebKit/commit/606e9d4b0da442b51d9acb9ef992895e3c7f32f5 Author: Myles C. Maxfield Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-text/animations/word-boundary-detection-interpolation-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-text/animations/word-boundary-detection-interpolation.html M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-boundary-detection-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-boundary-detection-valid-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSValue.cpp M Source/WebCore/css/CSSValue.h R Source/WebCore/css/CSSWordBoundaryDetectionValue.cpp R Source/WebCore/css/CSSWordBoundaryDetectionValue.h M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderText.h M Source/WebCore/rendering/line/BreakingContext.h M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h M Source/WebCore/rendering/style/StyleRareInheritedData.cpp M Source/WebCore/rendering/style/StyleRareInheritedData.h R Source/WebCore/rendering/style/WordBoundaryDetection.h M Source/WebCore/style/StyleBuilderConverter.h Log Message: --- Revert(265057@main): Stop parsing word-boundary-detection https://bugs.webkit.org/show_bug.cgi?id=258667 rdar://111506541 Reviewed by Alan Baradlay. https://github.com/w3c/csswg-drafts/issues/7193#issuecomment-1611772475 says: > RESOLVED: remove auto () from word-boundary-detection The only reason we parsed word-boundary-detection was for the `auto` value, so we can just revert 265057@main entirely. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/animations/word-boundary-detection-interpolation-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/animations/word-boundary-detection-interpolation.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-boundary-detection-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/word-boundary-detection-valid-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/CSSValue.cpp: (WebCore::CSSValue::visitDerived): * Source/WebCore/css/CSSValue.h: (WebCore::CSSValue::isVariableReferenceValue const): (WebCore::CSSValue::isWordBoundaryDetectionValue const): Deleted. * Source/WebCore/css/CSSWordBoundaryDetectionValue.cpp: Removed. * Source/WebCore/css/CSSWordBoundaryDetectionValue.h: Removed. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): (WebCore::wordBoundaryDetection): Deleted. * Source/WebCore/css/
[webkit-changes] [WebKit/WebKit] 09159f: Make ReplaceSelectionCommand not to attempt to mod...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09159fc78c97383b8a3a6531a99ae68f53c0d94f https://github.com/WebKit/WebKit/commit/09159fc78c97383b8a3a6531a99ae68f53c0d94f Author: Ahmad Saleem Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: A LayoutTests/editing/execCommand/insert-list-into-list-crash-expected.txt A LayoutTests/editing/execCommand/insert-list-into-list-crash.html M Source/WebCore/editing/ReplaceSelectionCommand.cpp Log Message: --- Make ReplaceSelectionCommand not to attempt to modify uneditable list element https://bugs.webkit.org/show_bug.cgi?id=258736 Reviewed by Ryosuke Niwa. This aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium.googlesource.com/chromium/src.git/+/835ae14aec4cdc54e151eaf583fa51a12460e276 This patch makes 'ReplaceSelectionCommand' not to attempt to modify uneditable list element, when replaced range inside list element, e.g. UL and OL element, and replacing fragment contains list item within list element. * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (ReplaceSelectionCommand::doApply): Add condition for 'editable' style * LayoutTests/editing/execCommand/insert-list-into-list-crash.html: Add Test Case * LayoutTests/editing/execCommand/insert-list-into-list-crash-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/265663@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b80e1: html/browsers/browsing-the-web/read-media/cross-or...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b80e1fb9da84bd4763357aa590c48a20a85e9f9 https://github.com/WebKit/WebKit/commit/4b80e1fb9da84bd4763357aa590c48a20a85e9f9 Author: Chris Dumez Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/cross-origin-video-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/cross-origin-video.html M LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-access-control.py Log Message: --- html/browsers/browsing-the-web/read-media/cross-origin-video.html gives different results on different platforms https://bugs.webkit.org/show_bug.cgi?id=258689 rdar://111070171 Reviewed by Jer Noble. The test was using an ogv file but was serving a "video/webm" Content-Type header. We don't support ogv and we only support webm on some platforms. To address the issue, we now rely on video.canPlayType() to see if the browser can play ogv. If it cannot, we request a mp4 video file instead. * LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/cross-origin-video-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/fetch-access-control.py: (main): * LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/cross-origin-video-expected.txt: Removed. Canonical link: https://commits.webkit.org/265662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46b57a: Update Byungseon Shin in contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46b57a69bda9758827da93a86299dc59f7bef48e https://github.com/WebKit/WebKit/commit/46b57a69bda9758827da93a86299dc59f7bef48e Author: Byungseon(Sun) Shin Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M metadata/contributors.json Log Message: --- Update Byungseon Shin in contributors.json https://bugs.webkit.org/show_bug.cgi?id=258703 Unreviewed, changing my primary email and updating interests * metadata/contributors.json: Canonical link: https://commits.webkit.org/265661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d007b4: Add myself and Myah Cobbs as a committer.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d007b42d7cb496eb2fcd091223cff8056829381b https://github.com/WebKit/WebKit/commit/d007b42d7cb496eb2fcd091223cff8056829381b Author: Dan Robson Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M metadata/contributors.json Log Message: --- Add myself and Myah Cobbs as a committer. https://bugs.webkit.org/show_bug.cgi?id=258735 Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/265660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74ea12: [FFC][Integration] Logical flex item location is b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74ea124c2a63c121117976380078c10b258f4f35 https://github.com/WebKit/WebKit/commit/74ea124c2a63c121117976380078c10b258f4f35 Author: Alan Baradlay Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp Log Message: --- [FFC][Integration] Logical flex item location is border box based https://bugs.webkit.org/show_bug.cgi?id=258733 Reviewed by Antti Koivisto. Remove redundant margin offset. Flex layout now returns flex item with their border box location. * Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp: (WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry): Canonical link: https://commits.webkit.org/265659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92cad9: Update contributors.json for Alice
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92cad9913a9ae642e4b04c777fb5c8810e987487 https://github.com/WebKit/WebKit/commit/92cad9913a9ae642e4b04c777fb5c8810e987487 Author: Michael Catanzaro Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M metadata/contributors.json Log Message: --- Update contributors.json for Alice https://bugs.webkit.org/show_bug.cgi?id=258737 Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/265658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05ca73: ASSERTION FAILED: willBeComposited == needsToBeCom...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05ca73cb5029e97a9ccd343be8e5589ae4d66507 https://github.com/WebKit/WebKit/commit/05ca73cb5029e97a9ccd343be8e5589ae4d66507 Author: Jer Noble Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData) https://bugs.webkit.org/show_bug.cgi?id=257970 rdar://110656130 Reviewed by Antti Koivisto. Notify the renderer when a new MediaPlayer has been created or destroyed, as the value of canAccelerateVideoRendering() may have changed. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaPlayer): Canonical link: https://commits.webkit.org/265656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa1a33: Fix PlayStation build following 265651@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa1a33ed1ca1ff3e4310a3d530a778903ef10d75 https://github.com/WebKit/WebKit/commit/aa1a33ed1ca1ff3e4310a3d530a778903ef10d75 Author: Ross Kirsling Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- Fix PlayStation build following 265651@main https://bugs.webkit.org/show_bug.cgi?id=258729 Unreviewed build fix. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: Move #if ENABLE(WEBASSEMBLY_BBQJIT) where it belongs. This isn't a new issue in 265651@main, but it means that non-WASM platforms have needed to load every header in this file. Canonical link: https://commits.webkit.org/265655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4d32d: [CSS Container Queries] Use element writing mode f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4d32d728a61a0786b99f30af82b3d4c92422afd https://github.com/WebKit/WebKit/commit/b4d32d728a61a0786b99f30af82b3d4c92422afd Author: Antti Koivisto Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt M Source/WebCore/css/CSSPrimitiveValue.cpp Log Message: --- [CSS Container Queries] Use element writing mode for unit resolution https://bugs.webkit.org/show_bug.cgi?id=258722 rdar://111565488 Reviewed by Simon Fraser. Correct handling for vertical writing mode per https://github.com/w3c/csswg-drafts/issues/6873 * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-in-at-container-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-selection-expected.txt: * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble): Resolve logical to to physical axis based on the element writing mode. Also explicitly fall back to small viewport units to guarantee consistency. Canonical link: https://commits.webkit.org/265654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5373a1: [FFC][Integration] Take box-sizing into account wh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5373a15c33d63c582e63f795a9b178d8b360b942 https://github.com/WebKit/WebKit/commit/5373a15c33d63c582e63f795a9b178d8b360b942 Author: Alan Baradlay Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp Log Message: --- [FFC][Integration] Take box-sizing into account when setting renders' size https://bugs.webkit.org/show_bug.cgi?id=258731 Reviewed by Antti Koivisto. * Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp: (WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry): * Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp: (WebCore::Layout::FlexLayout::computeFlexLines const): construct a vector with one range entry. Canonical link: https://commits.webkit.org/265653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57a7de: [GStreamer][WebRTC] Potential null dereference on ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57a7de84fd522f52b5b1e9d43aeeb7fe0d1af491 https://github.com/WebKit/WebKit/commit/57a7de84fd522f52b5b1e9d43aeeb7fe0d1af491 Author: Philippe Normand Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- [GStreamer][WebRTC] Potential null dereference on webrtcbin https://bugs.webkit.org/show_bug.cgi?id=258724 Reviewed by Xabier Rodriguez-Calvar. In a situation where the webrtc plugin is not available we might end up destroying an end-point that has no webrtcbin element, so we need to check this before disconnecting signal handlers. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::teardownPipeline): Canonical link: https://commits.webkit.org/265652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e7fe4: [JSC] Use std::popcount instead of __builtin_popco...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e7fe413ab40496e17623f5679b3e21cda074f1f https://github.com/WebKit/WebKit/commit/4e7fe413ab40496e17623f5679b3e21cda074f1f Author: Hayashida Ryuichi Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp Log Message: --- [JSC] Use std::popcount instead of __builtin_popcount and __builtin_popcountll https://bugs.webkit.org/show_bug.cgi?id=258557 Reviewed by Ross Kirsling. __builtin_popcount and __builtin_popcountll are builtin functions provided by GCC and Clang. However MSVC doesn't provide them so they don't compile with MSVC. This patch replaces the builtin functions with portable std::popcount defined in C++ STL. The function is available in all major C++ standard library implementations (libstdc++, libc++, MSVC STL). * libc++: https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/libcxx/include/bit#L192 * libstdc++: https://github.com/gcc-mirror/gcc/blob/releases/gcc-9.5.0/libstdc%2B%2B-v3/include/std/bit#L169 * MSVC STL: https://github.com/microsoft/STL/blob/40640c6df9754ea031f8df7c720b89714d19df97/stl/inc/__msvc_bit_utils.hpp#L396 It is confirmed that all implementations are optimized to use the compiler-specific intrinsics. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addI32Popcnt): (JSC::Wasm::BBQJIT::addI64Popcnt): * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::slow_path_wasm_popcount): (JSC::LLInt::slow_path_wasm_popcountll): Canonical link: https://commits.webkit.org/265651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 610110: [GTK][WPE] Flush TestWebKitAPI binaries before bui...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61011010ac86bae6d31a3de8c5387716714eb7e6 https://github.com/WebKit/WebKit/commit/61011010ac86bae6d31a3de8c5387716714eb7e6 Author: Diego Pino Garcia Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Tools/TestWebKitAPI/PlatformGTK.cmake M Tools/TestWebKitAPI/PlatformWPE.cmake M Tools/TestWebKitAPI/glib/PlatformGTK.cmake M Tools/TestWebKitAPI/glib/PlatformWPE.cmake Log Message: --- [GTK][WPE] Flush TestWebKitAPI binaries before building https://bugs.webkit.org/show_bug.cgi?id=258707 Reviewed by Carlos Alberto Lopez Perez. Flushing the contents inside TestWebKitAPI before building prevents executing former binaries that might be still there as the result of previous builds. * Tools/TestWebKitAPI/PlatformGTK.cmake: * Tools/TestWebKitAPI/PlatformWPE.cmake: * Tools/TestWebKitAPI/glib/PlatformGTK.cmake: * Tools/TestWebKitAPI/glib/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/265650@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8ac54: [GStreamer][WebCodecs] Rebaseline after 265616@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8ac547a12a92c5e13dfc5d38816922295beb1a7 https://github.com/WebKit/WebKit/commit/e8ac547a12a92c5e13dfc5d38816922295beb1a7 Author: Philippe Normand Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] Rebaseline after 265616@main https://bugs.webkit.org/show_bug.cgi?id=258678 Reviewed by Xabier Rodriguez-Calvar. Add basic sanity checks on width and height values of the encoder configuration. This also makes the "Too strenuous accelerated encoding parameters" test pass on our platform, so add baselines accordingly. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt: Added. * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (videoEncoderSetEncoder): Canonical link: https://commits.webkit.org/265649@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3747c: Fix non scrollable check for interaction regions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3747cf8f4f7dc3aa651c926793c7e0e5fbca6d6 https://github.com/WebKit/WebKit/commit/d3747cf8f4f7dc3aa651c926793c7e0e5fbca6d6 Author: Tim Nguyen Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/interaction-region/hover-style-expected.txt M LayoutTests/interaction-region/hover-style.html M Source/WebCore/page/InteractionRegion.cpp Log Message: --- Fix non scrollable check for interaction regions https://bugs.webkit.org/show_bug.cgi?id=258582 rdar://110652649 Reviewed by Simon Fraser. overflow: hidden containers can be scrolled programatically, but from the user perspective, they are not scrollable. * LayoutTests/interaction-region/hover-style-expected.txt: * LayoutTests/interaction-region/hover-style.html: * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): Canonical link: https://commits.webkit.org/265648@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 884b2e: Re-import css/mediaqueries WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 884b2e26cb219b9dac284e83bd4b5372875da7d4 https://github.com/WebKit/WebKit/commit/884b2e26cb219b9dac284e83bd4b5372875da7d4 Author: Cheng-You Bai Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json R LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-001-expected.xht R LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-001.html R LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-005-expected.xht R LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-005.html M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/dynamic-range-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/dynamic-range.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/inverted-colors-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/inverted-colors.html M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/match-media-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/match-media-parsing.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-calc-resolution-expected.xht A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-calc-resolution.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-non-matching-lazy-load.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-non-matching-lazy-load.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/overflow-media-features-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/overflow-media-features.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/prefers-reduced-transparency-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/prefers-reduced-transparency.html A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/resources/mq-non-matching-lazy-load-style.css M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/resources/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/update-media-feature-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/update-media-feature.html M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/w3c-import.log Log Message: --- Re-import css/mediaqueries WPT https://bugs.webkit.org/show_bug.cgi?id=258438 Reviewed by Tim Nguyen. Import based on dc23a29 commit in WPT. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-001.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-005-expected.xht: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-005.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/dynamic-range-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/dynamic-range.html: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/inverted-colors-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/inverted-colors.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/match-media-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/match-media-parsing.html: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-calc-resolution-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/device-aspect-ratio-001-expected.xht. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-calc-resolution.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-non-matching-lazy-load.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-non-matching-lazy-load.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/overflow-media-features-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/overflow-media-features.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/prefers-reduced-transparency-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/prefers-reduced-transparency.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/resources/mq-non-matching-lazy-load-style.css: Added. (body): * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/resources/w3c
[webkit-changes] [WebKit/WebKit] d95cad: [LibWebRTC] Enable AVX2 extensions only if host su...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d95cad7579b54950ac97ad0f0c19d1c29aeef489 https://github.com/WebKit/WebKit/commit/d95cad7579b54950ac97ad0f0c19d1c29aeef489 Author: Diego Pino Garcia Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/ThirdParty/libwebrtc/CMakeLists.txt A Source/cmake/DetectAVX2.cmake M Source/cmake/WebKitCommon.cmake Log Message: --- [LibWebRTC] Enable AVX2 extensions only if host supports AVX2 https://bugs.webkit.org/show_bug.cgi?id=258708 Reviewed by Philippe Normand. Include specialized AVX2 files in LibWebRTC only if the host supports AVX2 extensions. Also, when AVX2 is enabled, avoid building using AVX512 extensions even if the host has support for it since it may result into compatibility issues (binary built on host with AVX512 support but executed in host without AVX512 support will result into a crash). * Source/ThirdParty/libwebrtc/CMakeLists.txt: * Source/cmake/DetectAVX2.cmake: Added. * Source/cmake/WebKitCommon.cmake: Canonical link: https://commits.webkit.org/265646@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1135be: [JSC] Allow SpecEmpty only when GetClosureVar from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1135bec30752857ee903c83143af853d88eba103 https://github.com/WebKit/WebKit/commit/1135bec30752857ee903c83143af853d88eba103 Author: Yusuke Suzuki Date: 2023-06-30 (Fri, 30 Jun 2023) Changed paths: M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp Log Message: --- [JSC] Allow SpecEmpty only when GetClosureVar from ResolvedClosureVar is used https://bugs.webkit.org/show_bug.cgi?id=258714 rdar://111553671 Reviewed by Mark Lam. ResolvedClosureVar is not used normally. It is very special internal ResolveType, mainly used for generators and private fields. In these variables, it can happen that we use JSEmpty as a result of op_get_from_scope (which becomes a TDZ error in normal ClosureVar). One example of this is op_iterator_open's m_next location, which can become JSEmpty. And if it is captured by a generator, then op_get_from_scope should see JSEmpty. The problem is that ValueProfile never tells about JSEmpty since it sees no value is stored when JSEmpty is stored. As a result, we emit ForceOSRExit in DFG since SpecNone is reported. We workaround this very special internal use case by explicitly setting SpecEmpty when ValueProfile tells this is SpecNone for ResolvedClosureVar op_get_from_scope, not to cause repeated OSR exit observed in JetStream2/Basic. * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): Canonical link: https://commits.webkit.org/265645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
