[webkit-changes] [WebKit/WebKit] b60e4d: Resizing video on YouTube can result in aliasing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b60e4db278efb963ae5a48fb81e0f71030263b12 https://github.com/WebKit/WebKit/commit/b60e4db278efb963ae5a48fb81e0f71030263b12 Author: Mike Wyrzykowski Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/rendering/RenderVideo.cpp M Source/WebCore/rendering/RenderVideo.h Log Message: --- Resizing video on YouTube can result in aliasing https://bugs.webkit.org/show_bug.cgi?id=259171 Reviewed by Tim Horton. Apply the same change as 265672@main but support it for videos playing in a fullscreen element as well. * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox const): (WebCore::RenderVideo::inElementOrVideoFullscree const): (WebCore::RenderVideo::updatePlayer): * Source/WebCore/rendering/RenderVideo.h: Canonical link: https://commits.webkit.org/266284@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 64ebe5: Add --profiling-interval to run-benchmark
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64ebe5ffcf06e4b81e34e00f8644f2d28fa92086 https://github.com/WebKit/WebKit/commit/64ebe5ffcf06e4b81e34e00f8644f2d28fa92086 Author: Ryosuke Niwa Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py Log Message: --- Add --profiling-interval to run-benchmark https://bugs.webkit.org/show_bug.cgi?id=259470 Reviewed by Cameron McCormack. Added an option to specify the profiling interval such as 1ms and 100us. * Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py: (BenchmarkRunner.__init__): * Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: (BrowserDriver.profile): * Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py: (config_argument_parser): (run_benchmark_plan): * Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: (WebServerBenchmarkRunner.__init__): (WebServerBenchmarkRunner): Canonical link: https://commits.webkit.org/266283@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7cfbb0: Remove JSC VM usage from LegacyCDMSessionClearKey
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cfbb042f9c0cca987611f667c6e0968756b1241 https://github.com/WebKit/WebKit/commit/7cfbb042f9c0cca987611f667c6e0968756b1241 Author: Yusuke Suzuki Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp Log Message: --- Remove JSC VM usage from LegacyCDMSessionClearKey https://bugs.webkit.org/show_bug.cgi?id=259386 rdar://112642265 Reviewed by Darin Adler. LegacyCDMSessionClearKey is creating JSC VM and JSGlobalObject just to parse JSON!! This is significantly costly. JSC::VM and JSGlobalObject are large JS environments. Instantiation takes some time & it takes memory. They should not be required just to parse JSON. Furthermore, this code runs on GPUProcess, and this part is the sole reason why GPUProcess still creates JSC VM. We should just use WTF::JSON::Value. * Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp: (WebCore::CDMSessionClearKey::update): (WebCore::CDMSessionClearKey::cachedKeyForKeyID const): (WebCore::clearKeyVM): Deleted. Canonical link: https://commits.webkit.org/266282@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b98c2d: [Win][MiniBrowser] Enable "Download linked file" a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b98c2d1c85b607d1d7a5836e6948bde2bc9d6294 https://github.com/WebKit/WebKit/commit/b98c2d1c85b607d1d7a5836e6948bde2bc9d6294 Author: Kenji Shukuwa Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h M Tools/MiniBrowser/win/Common.cpp M Tools/MiniBrowser/win/Common.h M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp M Tools/MiniBrowser/win/WebKitBrowserWindow.h Log Message: --- [Win][MiniBrowser] Enable "Download linked file" and "Download Image" https://bugs.webkit.org/show_bug.cgi?id=234887 Reviewed by Fujii Hironori. WinCairo WebKit2 now supports downloading files with 250472@main. So, we enable "Download linked file" and "Download Image" in MiniBrowser. * Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): (WebKit::NetworkDataTaskCurl::setPendingDownloadLocation): (WebKit::NetworkDataTaskCurl::suggestedFilename const): (WebKit::NetworkDataTaskCurl::deleteDownloadFile): * Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.h: * Tools/MiniBrowser/win/Common.cpp: (getKnownFolderPath): * Tools/MiniBrowser/win/Common.h: * Tools/MiniBrowser/win/WebKitBrowserWindow.cpp: (WebKitBrowserWindow::WebKitBrowserWindow): (WebKitBrowserWindow::navigationActionDidBecomeDownload): (WebKitBrowserWindow::navigationResponseDidBecomeDownload): (WebKitBrowserWindow::contextMenuDidCreateDownload): (WebKitBrowserWindow::setDownloadClient): (WebKitBrowserWindow::downloadDecideDestinationWithResponse): (WebKitBrowserWindow::downloadDidFinish): (WebKitBrowserWindow::downloadDidFailWithError): * Tools/MiniBrowser/win/WebKitBrowserWindow.h: Canonical link: https://commits.webkit.org/266281@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c5799: [JSC] Use SIMD fast find64 even in normal Array#in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c57997e4a9b602a17c9c2a3f3dd1c399787d001 https://github.com/WebKit/WebKit/commit/2c57997e4a9b602a17c9c2a3f3dd1c399787d001 Author: Yusuke Suzuki Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/JavaScriptCore/runtime/ArrayPrototype.cpp Log Message: --- [JSC] Use SIMD fast find64 even in normal Array#indexOf runtime function https://bugs.webkit.org/show_bug.cgi?id=259463 rdar://112804277 Reviewed by Keith Miller and Mark Lam. Let's just use find64 even in runtime function of Array#indexOf. We already used this in DFG operations. We can improve startup time for lower tiers by expanding this coverage. * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: (JSC::fastIndexOf): Canonical link: https://commits.webkit.org/266280@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c82ca3: Remove the embedder InlinePredictionsEnabled prefe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c82ca3ff5ea27d224713169862dd81e323391dd4 https://github.com/WebKit/WebKit/commit/c82ca3ff5ea27d224713169862dd81e323391dd4 Author: Richard Robinson Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- Remove the embedder InlinePredictionsEnabled preference from UnifiedWebPreferences https://bugs.webkit.org/show_bug.cgi?id=259236 rdar://112304979 Reviewed by Tim Horton. Since this preference isn't read in WebCore, or in the WebProcess, we can simply read off the WKWebViewConfiguration, without a need for a preference associated with the API. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _initializeWithConfiguration:]): (-[WKWebView _setupPageConfiguration:]): * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::setInlinePredictionsEnabled): (WebKit::WebViewImpl::inlinePredictionsEnabled const): (WebKit::WebViewImpl::allowsInlinePredictions const): Canonical link: https://commits.webkit.org/266279@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 986587: [GTK] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98658724ae07199014bc51d7d5916b34a19c7be9 https://github.com/WebKit/WebKit/commit/98658724ae07199014bc51d7d5916b34a19c7be9 Author: Diego Pino Garcia Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations Log Message: --- [GTK] Unreviewed test gardening Garden flakey crashes reported by GTK Relase and Debug bots. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/266278@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25fbfd: Use FrameType instead of a bool after 266266@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25fbfde472ee3eecdd5b20b28600d7b62334fc61 https://github.com/WebKit/WebKit/commit/25fbfde472ee3eecdd5b20b28600d7b62334fc61 Author: Alex Christensen Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Use FrameType instead of a bool after 266266@main https://bugs.webkit.org/show_bug.cgi?id=259459 rdar://112801948 Reviewed by Tim Nguyen. Tim gave some great review feedback after I merged my PR. This uses an enum instead of a bool. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::clientForMainFrame): (WebKit::m_appHighlightsVisible): Canonical link: https://commits.webkit.org/266277@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca2d70: Remove empty switch statements generated by opcode...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca2d701ed88485940fc7979244bdcba0bf3c8b32
https://github.com/WebKit/WebKit/commit/ca2d701ed88485940fc7979244bdcba0bf3c8b32
Author: Ian Grunert
Date: 2023-07-24 (Mon, 24 Jul 2023)
Changed paths:
M Source/JavaScriptCore/b3/air/opcode_generator.rb
Log Message:
---
Remove empty switch statements generated by opcode_generator.rb
https://bugs.webkit.org/show_bug.cgi?id=259429
Reviewed by Yusuke Suzuki.
The opcode_generator.rb was generating switch statements with no case
clauses:
```
switch (argIndex) {
default:
break;
}
```
This is compiled by clang into a jmp instruction to the next line. This
change only generates the switch statement if there's at least one case
clause for it.
* Source/JavaScriptCore/b3/air/opcode_generator.rb:
Canonical link: https://commits.webkit.org/266276@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 983e47: [Crash] WebCoreNSURLSessionTaskTransactionMetrics ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 983e4773e9b1ebac4384f6bdfa00c874168dbceb https://github.com/WebKit/WebKit/commit/983e4773e9b1ebac4384f6bdfa00c874168dbceb Author: Jean-Yves Avenard Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- [Crash] WebCoreNSURLSessionTaskTransactionMetrics _privacyStance]: unrecognized selector sent to instance https://bugs.webkit.org/show_bug.cgi?id=258288 rdar://111015018 Reviewed by Wenson Hsieh. privacyStance is supported since watchOS 8.0 and tvOS 15.0. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/266275@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ae731: [iOS] Safari window sometimes flashes black when a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ae7317c43cdc8799371c8f0cbde1dc5c683ae78 https://github.com/WebKit/WebKit/commit/5ae7317c43cdc8799371c8f0cbde1dc5c683ae78 Author: Simon Fraser Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/UIProcess/ApplicationStateTracker.h M Source/WebKit/UIProcess/ApplicationStateTracker.mm M Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm Log Message: --- [iOS] Safari window sometimes flashes black when app switching or tab switching https://bugs.webkit.org/show_bug.cgi?id=259455 rdar://107673739 Reviewed by Tim Horton. WebKit relies on the _UIApplicationDidFinishSuspensionSnapshotNotification notification to do two things in WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground(): if layers contain Mach port contents, map in IOSurfaces for those so that we don't hold an in-use count which prevents the layers from becoming volatile (no longer applicable now that layers hold CAIOSurfaceRefs), and storing a TransactionID in RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate() to keep content hidden until we get a new transaction on resume. UIKit stopped sending that notification a few years ago (rdar://112569013) so just hook up our call to `applicationDidFinishSnapshottingAfterEnteringBackground()` at the end of `_didCompleteSnapshotSequence`. Also add some release logging for background snapshotting. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/UIProcess/ApplicationStateTracker.h: * Source/WebKit/UIProcess/ApplicationStateTracker.mm: (WebKit::ApplicationStateTracker::ApplicationStateTracker): (WebKit::ApplicationStateTracker::~ApplicationStateTracker): (WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground): Deleted. * Source/WebKit/UIProcess/ios/WKApplicationStateTrackingView.mm: (-[WKApplicationStateTrackingView didMoveToWindow]): (-[WKApplicationStateTrackingView _applicationDidFinishSnapshottingAfterEnteringBackground]): (-[WKApplicationStateTrackingView _willBeginSnapshotSequence]): (-[WKApplicationStateTrackingView _didCompleteSnapshotSequence]): Canonical link: https://commits.webkit.org/266274@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d721c: REGRESSION (UI-side compositing): Jumpy full scree...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d721c09585b37b63eb4172c53ab61da282d2c3e https://github.com/WebKit/WebKit/commit/3d721c09585b37b63eb4172c53ab61da282d2c3e Author: Richard Robinson Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/spi/mac/AppKitSPI.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/API/mac/WKView.mm M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm M Source/WebKit/UIProcess/mac/WKViewLayoutStrategy.h M Source/WebKit/UIProcess/mac/WKViewLayoutStrategy.mm M Source/WebKit/UIProcess/mac/WebViewImpl.h M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- REGRESSION (UI-side compositing): Jumpy full screen transition animation https://bugs.webkit.org/show_bug.cgi?id=259375 rdar://111534888 Reviewed by Wenson Hsieh. With UI-side compositing, when entering or exiting window fullscreen mode, the transition is sometimes jumpy. This happens in cases where the UI process resizes before the web content has a chance to resize. The web content and the UI Process should always resize in the same CA commit. Fix by adopting an AppKit SPI to defer entering or exiting window fullscreen mode until the web content has actually been resized to the new size. This is done by using a "window snapshot readiness handler". * Source/WTF/wtf/PlatformHave.h: Add a new `HAVE` definition to only enable this on macOS, and only on versions where the SPI exists. * Source/WebKit/Platform/spi/mac/AppKitSPI.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView dealloc]): (-[WKWebView _invalidateWindowSnapshotReadinessHandler]): Invokes the readiness handler and then resets it, indicating to AppKit that the full screen should be allowed to resume. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/mac/WKView.mm: (-[WKView _web_windowWillEnterFullScreen]): (-[WKView _web_windowWillExitFullScreen]): Stub methods required to compile legacy WebKit. * Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm: (-[WKWebView _doWindowSnapshotReadinessUpdate]): (-[WKWebView setFrameSize:]): When `setFrameSize` gets called with the new frame size, the UI process waits for the next presentation update of the web prcoess. Once in the completion handler, we know that the web content has properly resized, and so we should now invalidate the readiness handler. (-[WKWebView _web_windowWillEnterFullScreen]): (-[WKWebView _web_windowWillExitFullScreen]): Upon receiving one of these notifications, we take out a window snapshot readiness handler and store it. This tells AppKit to defer the final stage of the enter and exit full screen animations until the handler is invoked. * Source/WebKit/UIProcess/mac/WKViewLayoutStrategy.h: * Source/WebKit/UIProcess/mac/WKViewLayoutStrategy.mm: (-[WKViewLayoutStrategy disableFrameSizeUpdates]): (-[WKViewLayoutStrategy enableFrameSizeUpdates]): (-[WKViewLayoutStrategy frameSizeUpdatesDisabled]): (-[WKViewLayoutStrategy didChangeFrameSize]): In some cases, `setFrameSize` would early return inside of `didChangeFrameSize` due to these set of methods. This caused the bug to still reproduce, since the new drawing area size was no longer being set. These methods have long been not actually needed, so their implementations are now removed and there is no longer a need for an early return. * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (-[WKWindowVisibilityObserver startObserving:]): (-[WKWindowVisibilityObserver stopObserving:]): (-[WKWindowVisibilityObserver _windowWillEnterFullScreen:]): (-[WKWindowVisibilityObserver _windowWillExitFullScreen:]): (WebKit::WebViewImpl::windowWillEnterFullScreen): (WebKit::WebViewImpl::windowWillExitFullScreen): When entering or exiting full screen, we now listen to their respective notifications. Canonical link: https://commits.webkit.org/266273@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87119f: Fix usage of asm.putsLabel
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87119fef338fd6862aff24ccd2d75c0856ee5df0 https://github.com/WebKit/WebKit/commit/87119fef338fd6862aff24ccd2d75c0856ee5df0 Author: Daniel Liu Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/JavaScriptCore/offlineasm/cloop.rb Log Message: --- Fix usage of asm.putsLabel https://bugs.webkit.org/show_bug.cgi?id=259453 rdar://112798638 Reviewed by Yusuke Suzuki and Justin Michaud. Fixes an oversight in #15659 where a putsLabel call was missing the aligned parameter. * Source/JavaScriptCore/offlineasm/cloop.rb: Canonical link: https://commits.webkit.org/266272@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 972473: Unreviewed, attaching a+x to display-sampling-prof...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 972473f044076e4e7742b53f15a3324734a72e95 https://github.com/WebKit/WebKit/commit/972473f044076e4e7742b53f15a3324734a72e95 Author: Yusuke Suzuki Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Tools/Scripts/display-sampling-profiler-output Log Message: --- Unreviewed, attaching a+x to display-sampling-profiler https://bugs.webkit.org/show_bug.cgi?id=259461 rdar://112802788 * Tools/Scripts/display-sampling-profiler-output: Canonical link: https://commits.webkit.org/266271@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc1dd7: [JSC] Add dumpAndClearSamplingProfilerSamples func...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc1dd7f1939dc03e9cf8e606067e3b5e90a78ee9 https://github.com/WebKit/WebKit/commit/cc1dd7f1939dc03e9cf8e606067e3b5e90a78ee9 Author: Yusuke Suzuki Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M JSTests/stress/sampling-profiler-anonymous-function.js M JSTests/stress/sampling-profiler-stack-trace-with-double-quote-in-function-name.js M JSTests/stress/sampling-profiler/samplingProfiler.js M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/SamplingProfiler.cpp M Source/JavaScriptCore/runtime/SamplingProfiler.h M Source/JavaScriptCore/runtime/VM.cpp M Source/JavaScriptCore/runtime/VM.h A Tools/Scripts/display-sampling-profiler-output Log Message: --- [JSC] Add dumpAndClearSamplingProfilerSamples function https://bugs.webkit.org/show_bug.cgi?id=259411 rdar://112686960 Reviewed by Justin Michaud. This patch adds dumpAndClearSamplingProfilerSamples behind a flag, which dumps sampling profiler data into temp file. This allows us to automated sampling data collection for benchmarks by calling this function at the right timing. We also significantly expand the JSON data generation of SamplingProfiler to reconstruct enough information from this output. We also attach display-sampling-profiler-output script as the same to display-profiler-output. Which can feed the above JSON and dump sampling profiler output. * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::JSGlobalObject::init): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::enableSamplingProfiler): (JSC::VM::disableSamplingProfiler): (JSC::VM::takeSamplingProfilerSamplesAsJSONString): * Source/JavaScriptCore/runtime/VM.h: Canonical link: https://commits.webkit.org/266270@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e812d6: [WebGPU] Make wgslc and wgslfuzz distinct from eac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e812d681255b5530d4bdc7272899b17dbf023342 https://github.com/WebKit/WebKit/commit/e812d681255b5530d4bdc7272899b17dbf023342 Author: Myles C. Maxfield Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: A Source/WebGPU/Configurations/wgslfuzz.xcconfig M Source/WebGPU/WGSL/wgslc.cpp A Source/WebGPU/WGSL/wgslfuzz.cpp M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj A Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/wgslfuzz.xcscheme Log Message: --- [WebGPU] Make wgslc and wgslfuzz distinct from each other https://bugs.webkit.org/show_bug.cgi?id=259454 rdar://112798797 Reviewed by Mike Wyrzykowski. It would be useful to make the compiler and the fuzzer different executables for local development, so when the fuzzer finds a problem, you can feed that into the compiler to debug it. The way this works is: % set-webkit-configuration --debug --asan --libFuzzer % cd Source/WebGPU % make SCHEME=wgslfuzz % make SCHEME=wgslc % ASAN_OPTIONS=whatever DYLD_FRAMEWORK_PATH=/path/to/Products/Debug DYLD_LIBRARY_PATH=/path/to/Products/Debug /path/to/Products/Debug/wgslfuzz % ASAN_OPTIONS=whatever DYLD_FRAMEWORK_PATH=/path/to/Products/Debug DYLD_LIBRARY_PATH=/path/to/Products/Debug /path/to/Products/Debug/wgslc * Source/WebGPU/Configurations/wgslfuzz.xcconfig: Added. * Source/WebGPU/WGSL/wgslc.cpp: (main): (LLVMFuzzerTestOneInput): Deleted. * Source/WebGPU/WGSL/wgslfuzz.cpp: Added. (LLVMFuzzerTestOneInput): * Source/WebGPU/WebGPU.xcodeproj/project.pbxproj: * Source/WebGPU/WebGPU.xcodeproj/xcshareddata/xcschemes/wgslfuzz.xcscheme: Added. Canonical link: https://commits.webkit.org/266269@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6be02: Generate serialization of LayerCreationProperties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6be02efdc1819cbcead28681d297002283ad2bc https://github.com/WebKit/WebKit/commit/a6be02efdc1819cbcead28681d297002283ad2bc Author: Alex Christensen Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/platform/graphics/Model.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteHost.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm Log Message: --- Generate serialization of LayerCreationProperties https://bugs.webkit.org/show_bug.cgi?id=259413 rdar://112694735 Reviewed by Tim Horton. * Source/WebCore/platform/graphics/Model.h: (WebCore::Model::encode const): Deleted. (WebCore::Model::decode): Deleted. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTransaction::description const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::hostIdentifier const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::hostingContextID const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::preservesFlip const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::hostingDeviceScaleFactor const): (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties): Deleted. (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode const): Deleted. (WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::createLayer): (WebKit::RemoteLayerTreeHost::makeNode): * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm: (WebKit::RemoteLayerTreeHost::makeNode): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm: (WebKit::PlatformCALayerRemoteCustom::populateCreationProperties): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteHost.mm: (WebKit::PlatformCALayerRemoteHost::populateCreationProperties): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteModelHosting.mm: (WebKit::PlatformCALayerRemoteModelHosting::populateCreationProperties): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::layerDidEnterContext): Canonical link: https://commits.webkit.org/266268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d015b: Enable Web process cache on iOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d015b7c0f7a00805f719bf96e04f2f33b2ff77d https://github.com/WebKit/WebKit/commit/7d015b7c0f7a00805f719bf96e04f2f33b2ff77d Author: Per Arne Vollan Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WTF/wtf/RAMSize.cpp M Source/WTF/wtf/RAMSize.h M Source/WebKit/UIProcess/WebProcessCache.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- Enable Web process cache on iOS https://bugs.webkit.org/show_bug.cgi?id=258978 rdar://111908431 Reviewed by Brent Fulgham. Enable the Web process cache on iOS by addressing an issue where the physical memory size in GB is reported as zero, causing the process cache capacity to be set to zero. This is because the jetsam limit is taken into consideration in this computation on iOS. This patch adds a function that returns the memory size without considering the jetsam limit of the calling process. This patch also delays releasing memory when preparing to suspend, since this is further improving the page load speed when reusing a process from the cache. Releasing the memory is delayed until we drop the last assertion, which will suspend the process. Until then, the process is running and able to respond to memory pressure warnings from the system and releasing memory. Furthermore, the process is not added to the cache if assertions are being held, preventing it from suspending. This is a fix for a regression in page load speed we see on http://www.youtube.com when adding it to the cache. This change is a speedup on page load benchmarks. * Source/WTF/wtf/RAMSize.cpp: (WTF::ramSizeDisregardingJetsamLimit): * Source/WTF/wtf/RAMSize.h: * Source/WebKit/UIProcess/WebProcessCache.cpp: (WebKit::WebProcessCache::updateCapacity): * Source/WebKit/UIProcess/WebProcessProxy.cpp: * Source/WebKit/WebProcess/WebProcess.cpp: Canonical link: https://commits.webkit.org/266267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a7682: Implement postMessage for site-isolated iframes af...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a7682ec22d5425edc3464a5be2d48df538ef312 https://github.com/WebKit/WebKit/commit/3a7682ec22d5425edc3464a5be2d48df538ef312 Author: Alex Christensen Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/PageConfiguration.cpp M Source/WebCore/page/PageConfiguration.h M Source/WebCore/page/RemoteDOMWindow.cpp M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebCore/page/RemoteFrameClient.h M Source/WebKit/Shared/FrameTreeCreationParameters.h M Source/WebKit/Shared/FrameTreeCreationParameters.serialization.in M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebProcessProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKit/WebProcess/WebProcess.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Implement postMessage for site-isolated iframes after cross-origin navigation https://bugs.webkit.org/show_bug.cgi?id=259423 rdar://112719991 Reviewed by Tim Nguyen. Broadcasting process identifier updates when an iframe changes processes would necessarily introduce a point of time where messages could be dropped because updates hadn't been received in the sending web content processes. Rather than trying to keep that information up to date in all web content processes, use the UI process as the source of truth for what frame is in what process. The FrameIdentifier is therefore all the context we need when sending messages to another process. * Source/WebCore/page/Page.cpp: (WebCore::createMainFrame): * Source/WebCore/page/PageConfiguration.cpp: (WebCore::PageConfiguration::PageConfiguration): * Source/WebCore/page/PageConfiguration.h: * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::postMessage): * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::createMainFrame): (WebCore::RemoteFrame::createSubframe): (WebCore::RemoteFrame::createSubframeWithContentsInAnotherProcess): (WebCore::RemoteFrame::RemoteFrame): (WebCore::m_layerHostingContextIdentifier): (WebCore::RemoteFrame::renderTreeAsText): (WebCore::m_remoteProcessIdentifier): Deleted. * Source/WebCore/page/RemoteFrame.h: * Source/WebCore/page/RemoteFrameClient.h: * Source/WebKit/Shared/FrameTreeCreationParameters.h: * Source/WebKit/Shared/FrameTreeCreationParameters.serialization.in: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::didCommitLoadForFrame): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::commitProvisionalFrame): (WebKit::WebFrameProxy::frameTreeCreationParameters const): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::postMessageToRemote): (WebKit::WebProcessProxy::renderTreeAsText): * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::postMessageToRemote): (WebKit::WebRemoteFrameClient::renderTreeAsText): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h: * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::createRemoteSubframe): (WebKit::WebFrame::didCommitLoadInAnotherProcess): * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::clientForMainFrame): (WebKit::m_appHighlightsVisible): (WebKit::WebPage::constructFrameTree): (WebKit::WebPage::createRemoteSubframe): (WebKit::WebPage::didCommitLoadInAnotherProcess): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Source/WebKit/WebProcess/WebProcess.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/266266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80f6e2: Allocating a new IPC::Semaphore for each RemoteIma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80f6e24ca1d10903db9e2c76dd6ea91249a45d9f https://github.com/WebKit/WebKit/commit/80f6e24ca1d10903db9e2c76dd6ea91249a45d9f Author: Matt Woodrow Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp Log Message: --- Allocating a new IPC::Semaphore for each RemoteImageBufferProxy::flushDrawingContextAsync adds significant overhead. https://bugs.webkit.org/show_bug.cgi?id=259433 Reviewed by Dean Jackson. Frequently we have an existing pending flush object, where the semaphore has already been signaled. This makes the m_signaled bool atomic, so that we can check for completed flush objects without taking the lock and blocking. This will still be false if the existing use of the semaphore hasn't yet been signaled, or if the waitFor call failed. If we find a completed flush objects, then moves the semaphore across into the new one to prevent a new allocation. * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteImageBufferProxyFlushFence::tryTakeSemaphore): (WebKit::RemoteImageBufferProxy::flushDrawingContextAsync): (WebKit::RemoteImageBufferProxyFlushFence::WTF_GUARDED_BY_LOCK): Deleted. Canonical link: https://commits.webkit.org/266265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe314e: Use a new type PathCloseSubpath instead of std::mo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe314ea4b982abb2cf203a909be9c5fc180cbcb0 https://github.com/WebKit/WebKit/commit/fe314ea4b982abb2cf203a909be9c5fc180cbcb0 Author: Cameron McCormack Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/platform/graphics/PathSegment.cpp M Source/WebCore/platform/graphics/PathSegment.h M Source/WebCore/platform/graphics/PathSegmentData.cpp M Source/WebCore/platform/graphics/PathSegmentData.h M Source/WebCore/platform/graphics/PathStream.cpp M Source/WebCore/platform/graphics/cairo/PathCairo.cpp M Source/WebCore/platform/graphics/cg/PathCG.cpp M Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in Log Message: --- Use a new type PathCloseSubpath instead of std::monostate to represent a close command in PathSegment https://bugs.webkit.org/show_bug.cgi?id=259430 rdar://problem/112741404 Reviewed by Simon Fraser. Adding an empty struct lets us treat this command like all the others, and not special case it in the WTF::switchOn calls in PathSegment.cpp. * Source/WebCore/platform/graphics/PathSegment.cpp: (WebCore::PathSegment::calculateEndPoint const): (WebCore::PathSegment::extendFastBoundingRect const): (WebCore::PathSegment::extendBoundingRect const): (WebCore::PathSegment::addToImpl const): (WebCore::PathSegment::applyElements const): (WebCore::operator<<): * Source/WebCore/platform/graphics/PathSegment.h: (WebCore::PathSegment::isCloseSubPath const): * Source/WebCore/platform/graphics/PathSegmentData.cpp: (WebCore::PathCloseSubpath::calculateEndPoint const): (WebCore::PathCloseSubpath::extendFastBoundingRect const): (WebCore::PathCloseSubpath::extendBoundingRect const): (WebCore::PathCloseSubpath::addToImpl const): (WebCore::PathCloseSubpath::applyElements const): (WebCore::operator<<): * Source/WebCore/platform/graphics/PathSegmentData.h: * Source/WebCore/platform/graphics/PathStream.cpp: (WebCore::PathStream::closeSubpath): * Source/WebCore/platform/graphics/cg/PathCG.cpp: (WebCore::pathSegmentApplierCallback): * Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in: Canonical link: https://commits.webkit.org/266264@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00c679: REGRESSION(265930@main): [ iOS 16 ] TestWTF.WTF_Pa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00c679a9ae1b56c9a4e21f43aaab9bb26123222c https://github.com/WebKit/WebKit/commit/00c679a9ae1b56c9a4e21f43aaab9bb26123222c Author: Justin Michaud Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WTF/Packed.cpp Log Message: --- REGRESSION(265930@main): [ iOS 16 ] TestWTF.WTF_Packed.PackedAlignedPtr is a constant failure https://bugs.webkit.org/show_bug.cgi?id=259366 rdar://112620141 Reviewed by Brent Fulgham. I missed a compile guard. * Tools/TestWebKitAPI/Tests/WTF/Packed.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/266263@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e2daf: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e2daf2898443d71fb85c86765f75302cd6ce9c7 https://github.com/WebKit/WebKit/commit/5e2daf2898443d71fb85c86765f75302cd6ce9c7 Author: Russell Epstein Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7617.1.3 Canonical link: https://commits.webkit.org/266262@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e41f56: [UI-side compositing] REGRESSION: empty Mail compo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e41f5679593f6e0a4eb380dd580392234ea3fd4b https://github.com/WebKit/WebKit/commit/e41f5679593f6e0a4eb380dd580392234ea3fd4b Author: Nikolaos Mouchtaris Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h M Source/WebCore/page/scrolling/mac/ScrollerMac.h M Source/WebCore/page/scrolling/mac/ScrollerMac.mm M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebCore/platform/Scrollbar.cpp M Source/WebCore/platform/ScrollbarsController.h M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm Log Message: --- [UI-side compositing] REGRESSION: empty Mail compose window always shows a scrollbar https://bugs.webkit.org/show_bug.cgi?id=259323 rdar://110872395 Reviewed by Simon Fraser. To properly set NSScrollerImps as enabled in the UI-process, send accross the web process state from the Scrollbar class. It is also necessary to set the state in setScrollingNodeScrollableAreaGeometry because the first time setting this state on the Scrollbar class can happen before the corresponding scrollable area has been added to the scrolling tree. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setScrollbarEnabled): (WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::setScrollbarEnabled): * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setScrollbarEnabledState): * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollingStateScrollingNode::scrollbarEnabledState const): * Source/WebCore/page/scrolling/mac/ScrollerMac.h: (WebCore::ScrollerMac::setEnabled): * Source/WebCore/page/scrolling/mac/ScrollerMac.mm: (WebCore::ScrollerMac::updateValues): * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode): * Source/WebCore/platform/Scrollbar.cpp: (WebCore::Scrollbar::setEnabled): * Source/WebCore/platform/ScrollbarsController.h: (WebCore::ScrollbarsController::setScrollbarEnabledSate): * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder::encode): (ArgumentCoder::decode): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm: (WebKit::RemoteScrollbarsController::setScrollbarEnabledSate): Canonical link: https://commits.webkit.org/266261@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f89f7: Overlapping VTTCues carried by InbandTextTrack (Le...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f89f7891c5c2c079ee58270d0bc96c8457e4475 https://github.com/WebKit/WebKit/commit/6f89f7891c5c2c079ee58270d0bc96c8457e4475 Author: Eric Carlson Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: A LayoutTests/http/tests/media/hls/track-in-band-multiple-cues-expected.txt A LayoutTests/http/tests/media/hls/track-in-band-multiple-cues.html A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/master.m3u8 A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/multiple0.vtt A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/multiple1.vtt A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/test-0.ts A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/test-1.ts A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/video.m3u8 A LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/vtt.m3u8 M Source/WebCore/html/track/InbandGenericTextTrack.cpp M Source/WebCore/html/track/InbandGenericTextTrack.h M Source/WebCore/html/track/InbandTextTrack.h M Source/WebCore/html/track/TextTrackCue.h M Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp Log Message: --- Overlapping VTTCues carried by InbandTextTrack (LegibleOutput) does not handle correctly https://bugs.webkit.org/show_bug.cgi?id=251771 rdar://105372930 Reviewed by Jer Noble. Parse every cue in each CMSampleBuffer provided the the AVPlayerItemLegibleOutput delegate, not just the first one. * LayoutTests/http/tests/media/hls/track-in-band-multiple-cues-expected.txt: Added. * LayoutTests/http/tests/media/hls/track-in-band-multiple-cues.html: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/master.m3u8: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/multiple0.vtt: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/multiple1.vtt: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/test-0.ts: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/test-1.ts: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/video.m3u8: Added. * LayoutTests/http/tests/media/resources/hls/multiple-cues-per-sample/vtt.m3u8: Added. * Source/WebCore/html/track/InbandGenericTextTrack.cpp: (WebCore::InbandGenericTextTrack::cueToExtend): Look for an existing cue with the same contents and start time and duration within the allowed delta. (WebCore::InbandGenericTextTrack::newCuesParsed): Use cueToExtend. * Source/WebCore/html/track/InbandGenericTextTrack.h: * Source/WebCore/html/track/InbandTextTrack.h: * Source/WebCore/html/track/TextTrackCue.h: * Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: (WebCore::InbandTextTrackPrivateAVF::processNativeSamples): There may be more than one cue in each CMSampleBuffer. Canonical link: https://commits.webkit.org/266260@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 90608f: Disable builtInNotification endpoints when builtIn...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90608fd2ccb65a13532b9b9042b67962e8e89c18 https://github.com/WebKit/WebKit/commit/90608fd2ccb65a13532b9b9042b67962e8e89c18 Author: Gavin Phillips Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h M Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in M Source/WebKit/NetworkProcess/NetworkSession.cpp M Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp Log Message: --- Disable builtInNotification endpoints when builtInNotificationsEnabled is set to false https://bugs.webkit.org/show_bug.cgi?id=259443 rdar://112769420 Reviewed by Alex Christensen. When builtInNotificationsEnabled is set to false, we don't need to expose the endpoints associated with the feature. This change syncs the feature state to the network process and checks the endpoints is only reached when it's enabled. * LayoutTests/TestExpectations: * LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html: Added. * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didReceiveMessage): * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): * Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h: * Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.serialization.in: * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::m_shouldAcceptInsecureCertificatesForWebSockets): * Source/WebKit/Shared/Notifications/NotificationManagerMessageHandler.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess): Canonical link: https://commits.webkit.org/266259@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b1106: Rename isBlobURLContainsNullOrigin to isBlobURLCon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b1106bf431a9c62941d89bf6c119c85161c2cee https://github.com/WebKit/WebKit/commit/2b1106bf431a9c62941d89bf6c119c85161c2cee Author: Anne van Kesteren Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/fileapi/ThreadableBlobRegistry.cpp Log Message: --- Rename isBlobURLContainsNullOrigin to isBlobURLContainingNullOrigin https://bugs.webkit.org/show_bug.cgi?id=259426 rdar://112731483 Reviewed by Tim Nguyen. * Source/WebCore/fileapi/ThreadableBlobRegistry.cpp: (WebCore::isBlobURLContainingNullOrigin): (WebCore::addToOriginMapIfNecessary): (WebCore::unregisterBlobURLOriginIfNecessaryOnMainThread): (WebCore::ThreadableBlobRegistry::registerBlobURLHandle): (WebCore::ThreadableBlobRegistry::getCachedOrigin): (WebCore::isBlobURLContainsNullOrigin): Deleted. Canonical link: https://commits.webkit.org/266258@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7f28b: Resizing a fullscreen element doesn't always resiz...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7f28b8f18d6f400feac62dc7054759e91014765 https://github.com/WebKit/WebKit/commit/d7f28b8f18d6f400feac62dc7054759e91014765 Author: Mike Wyrzykowski Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/ios/WKWebViewResize.mm Log Message: --- Resizing a fullscreen element doesn't always resize children to the correct size https://bugs.webkit.org/show_bug.cgi?id=258847 Reviewed by Tim Horton. During a window resize, [_contentView bounds] will not be up to date during the precommit handler so it is incorrect to intersect it with the web view's bounds. Additionally it makes fullscreen resizing look much smoother. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _updateVisibleContentRects]): Skip intersection if we just resized the WKWebView. * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/ios/WKWebViewResize.mm: Added. (-[NSObject swizzled_didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:viewStability:enclosedInScrollableAncestorView:sendEvenIfUnchanged:]): (setupWKContentViewSwizzle): (operator==): Required for EXPECT_EQ on CGRect. (webViewHasExpectedBounds): (TEST): Add API test which ensures a content view with no other insets will have an unobscuredRect which matches the enclosing WKWebView's bounds after setFrame: is called. Tests both resizing the web view larger and smaller. Canonical link: https://commits.webkit.org/266257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b532c6: [iOS 17] [Mail] Tabbing from subject field to comp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b532c60a79794ae5c6d41f02419bbba79a3da347 https://github.com/WebKit/WebKit/commit/b532c60a79794ae5c6d41f02419bbba79a3da347 Author: Wenson Hsieh Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: A LayoutTests/editing/selection/ios/become-first-responder-after-relinquishing-focus-expected.txt A LayoutTests/editing/selection/ios/become-first-responder-after-relinquishing-focus.html M Source/WebCore/page/FocusController.cpp Log Message: --- [iOS 17] [Mail] Tabbing from subject field to compose body dismisses the keyboard and ends editing https://bugs.webkit.org/show_bug.cgi?id=259434 rdar://109244061 Reviewed by Megan Gardner. In Mail on iOS 17, shift-tabbing from the compose body field to the subject field and attempting to tab back into the body field causes the keyboard to dismiss. This happens because when the user attempts to tab back into the web view, we fail to set the focused element to the `body`, while handling the `IsFocused` activity state change in the web process after `-becomeFirstResponder`; more precisely, when entering `dispatchEventsOnWindowAndFocusedElement` during the activity state change, `document->focusedElement()` is null and so we don't dispatch a focus event. On iOS 16, this bug doesn't happen — when the selection is moved into the native subject field, UIKit code ends up calling into `-[WKContentView clearSelection]` to clear out the previous selection, such that when we try to tab back into the web view, we set the focused element back to the `body` as a byproduct of the fact that we're changing the selection underneath this call stack: ``` 1 WebCore::Document::setFocusedElement(…) 2 WebCore::FocusController::setFocusedElement(…) 3 WebCore::FrameSelection::setFocusedElementIfNeeded(…) 4 WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance(…) 5 WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance(…) 6 WebCore::FrameSelection::setSelection(…) 7 WebCore::FrameSelection::setSelectionFromNone(…) 8 WebCore::FrameSelection::focusedOrActiveStateChanged(…) 9 WebCore::FrameSelection::setFocused(…) ``` In contrast, on iOS 17, the call to `-[WKContentView clearSelection]` never happens; this in turn causes the selection to remain the same after tabbing back into the web view, which means that `willMutateSelection := false` in `FrameSelection::setSelectionWithoutUpdatingAppearance` and we bail before we get a chance to invoke `setFocusedElementIfNeeded();`. From examining UIKit sources, this basically worked by sheer accident on iOS 16: there's code in `UITextSelectionView` to *collapse* the selection to the end, but ends up clearing the selection only in WebKit views because `-[WKContentView textRangeFromPosition:toPosition:]` unconditionally returns `nil`. In iOS 17, we now use `UITextSelectionDisplayInteraction` instead of the legacy `UITextSelectionView`, which skips this codepath, and so the (accidental-but-necessary) process of clearing the selection no longer happens. Rather than try and ressurrect the iOS 16 codepath in a way that works with `UITextSelectionDisplayInteraction`, this patch fixes the bug by instead changing `relinquishFocusToChrome` to additionally clear the selection, such that when we subsequently refocus the web view and set the initial selection, we'll trigger a selection change that will also update the focused element. Note that this also brings `FocusController::relinquishFocusToChrome` more in line with `FocusController::setFocusedElement`, which also uses the same helper to clear the selection prior to updating the focused element. * LayoutTests/editing/selection/ios/become-first-responder-after-relinquishing-focus-expected.txt: Added. * LayoutTests/editing/selection/ios/become-first-responder-after-relinquishing-focus.html: Added. Add a layout test to exercise the bug, by using shift-tab and `-resignFirstResponder` to dismiss the keyboard in an editable web view, and then verifying that the keyboard shows up again after calling `-becomeFirstResponder`. * Source/WebCore/page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Move this helper function to the top of this file, so we can use it in `relinquishFocusToChrome`. Also make some minor adjustments to handle the case where the `newFocusedFrame` is `nullptr`. (WebCore::FocusController::relinquishFocusToChrome): Call `clearSelectionIfNeeded` when relinquishing focus to be consistent with the regular `setFocusedElement` codepath. Canonical link: https://commits.webkit.org/266256@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a76856: Prewarm Web process when load starts
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7685646bededd26e4b2a8a0b69e0b7c05cbede8 https://github.com/WebKit/WebKit/commit/a7685646bededd26e4b2a8a0b69e0b7c05cbede8 Author: Per Arne Vollan Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.h Log Message: --- Prewarm Web process when load starts https://bugs.webkit.org/show_bug.cgi?id=259447 rdar://112777207 Reviewed by Brent Fulgham. We currently prewarm a Web process when the main frame load has finished. Instead, prewarm a Web process when the provisional load starts, which has been measured to be a 1-2% speedup in page load time. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::notifyProcessPoolToPrewarm): (WebKit::WebPageProxy::didStartProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didFinishLoadForFrame): * Source/WebKit/UIProcess/WebProcessPool.h: Canonical link: https://commits.webkit.org/266255@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 681597: Reduce logging volume
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 681597b43c00a5e240424f051c4fa49a5c958055 https://github.com/WebKit/WebKit/commit/681597b43c00a5e240424f051c4fa49a5c958055 Author: Per Arne Vollan Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- Reduce logging volume https://bugs.webkit.org/show_bug.cgi?id=259421 rdar://112718525 Reviewed by Eric Carlson and Brent Fulgham. Reduce logging volume, since WebKit is sometimes quarantined by the logging system due to high volume. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::scheduleUpdateMediaState): (WebCore::HTMLMediaElement::updateMediaPlayer): Canonical link: https://commits.webkit.org/266254@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f70bfc: Merge isXMLSpace() into isJSONOrHTTPWhitespace()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f70bfc73d58cb05654edbe416adde6bb63804c79 https://github.com/WebKit/WebKit/commit/f70bfc73d58cb05654edbe416adde6bb63804c79 Author: Anne van Kesteren Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WTF/wtf/ASCIICType.h M Source/WTF/wtf/JSONValues.cpp M Source/WTF/wtf/text/StringToIntegerConversion.h M Source/WebCore/Modules/cache/DOMCache.cpp M Source/WebCore/Modules/cache/DOMCacheEngine.cpp M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp M Source/WebCore/Modules/fetch/FetchHeaders.cpp M Source/WebCore/mathml/MathMLPresentationElement.cpp M Source/WebCore/mathml/MathMLTokenElement.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebCore/platform/ReferrerPolicy.cpp M Source/WebCore/platform/network/DataURLDecoder.cpp M Source/WebCore/platform/network/HTTPParsers.cpp M Source/WebCore/platform/network/HTTPParsers.h M Source/WebCore/platform/network/ParsedContentType.cpp M Source/WebCore/platform/network/ResourceResponseBase.cpp M Source/WebCore/platform/network/TimingAllowOrigin.cpp M Source/WebCore/xml/XMLHttpRequest.cpp M Source/WebCore/xml/XPathFunctions.cpp M Source/WebCore/xml/XPathParser.cpp M Source/WebCore/xml/XPathUtil.cpp M Source/WebCore/xml/XPathUtil.h M Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp M Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageRecord.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- Merge isXMLSpace() into isJSONOrHTTPWhitespace() https://bugs.webkit.org/show_bug.cgi?id=255872 rdar://108738795 Reviewed by Darin Adler. It turns out that JSON, HTTP, and XML all use the same whitespace definition, so let's make them share it. Also correct an existing comment for that function as \v is not part of isASCIIWhitespace(), but \f is. Furthermore, remove the "optimization" from these whitespace functions per a comment from Chris Dumez at https://github.com/WebKit/WebKit/pull/13080#discussion_r1174653845: > Just verified out of curiosity and llvm does generate the same code > with -O2 (tried both arm64 and x86_64): > > isXMLSpace1(char): // @isXMLSpace1(char) > mov x8, #9728 // =0x2600 > and w9, w0, #0xff > movkx8, #1, lsl #32 > cmp w9, #33 > csetw9, lo > lsr x8, x8, x0 > and w0, w9, w8 > ret > isXMLSpace2(char): // @isXMLSpace2(char) > mov x8, #9728 // =0x2600 > and w9, w0, #0xff > movkx8, #1, lsl #32 > cmp w9, #33 > csetw9, lo > lsr x8, x8, x0 > and w0, w9, w8 > ret > > Ahmad-S792 Let's simplify the code then. * Source/WTF/wtf/ASCIICType.h: (WTF::isASCIIWhitespace): (WTF::isJSONOrHTTPOrXMLWhitespace): (WTF::isJSONOrHTTPWhitespace): Deleted. * Source/WTF/wtf/JSONValues.cpp: (WTF::JSONImpl::Value::parseJSON): * Source/WTF/wtf/text/StringToIntegerConversion.h: * Source/WebCore/Modules/cache/DOMCache.cpp: (WebCore::hasResponseVaryStarHeaderValue): * Source/WebCore/Modules/cache/DOMCacheEngine.cpp: (WebCore::DOMCacheEngine::queryCacheMatch): * Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp: (WebCore::parseParameters): (WebCore::parseMIMEType): (WebCore::FetchBodyConsumer::packageFormData): * Source/WebCore/Modules/fetch/FetchHeaders.cpp: (WebCore::canWriteHeader): (WebCore::appendToHeaderMap): (WebCore::FetchHeaders::set): (WebCore::FetchHeaders::filterAndFill): * Source/WebCore/mathml/MathMLPresentationElement.cpp: (WebCore::MathMLPresentationElement::parseMathMLLength): * Source/WebCore/mathml/MathMLTokenElement.cpp: (WebCore::MathMLTokenElement::convertToSingleCodePoint): * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::parse): * Source/WebCore/platform/ReferrerPolicy.cpp: (WebCore::parseReferrerPolicy): * Source/WebCore/platform/network/DataURLDecoder.cpp: (WebCore::DataURLDecoder::DecodeTask::process): * Source/WebCore/platform/network/HTTPParsers.cpp: (WebCore::parseContentTypeOptionsHeader): (WebCore::parseClearSiteDataHeader): (WebCore::parseRange): (WebCore::parseCrossOriginResourcePolicyHeader): * Source/WebCore/platform/network/HTTPParsers.h: (WebCore::addToAccessControlAllowList): * Source/WebCore/platform/network/ParsedContentType.cpp: (WebCore::skipSpaces): (WebCore::parseToken): (WebCore::ParsedContentType::create): (WebCore::ParsedContentType::setContentType): * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::containsInvalidHTTPHeaders const): * Source/WebCore/platform/network/TimingAllowOrigin.cpp: (WebCore::passesTimingAllowOriginCheck): * Source/We
[webkit-changes] [WebKit/WebKit] cc626f: URL pathname and search setter incorrectly strips ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc626f31c37433b6ed8bb007f1ad67a6f8697639 https://github.com/WebKit/WebKit/commit/cc626f31c37433b6ed8bb007f1ad67a6f8697639 Author: Anne van Kesteren Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json M LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/URL.h M Source/WTF/wtf/URLParser.cpp M Source/WTF/wtf/URLParser.h Log Message: --- URL pathname and search setter incorrectly strips trailing spaces https://bugs.webkit.org/show_bug.cgi?id=259080 rdar://112433299 Reviewed by Alex Christensen. Potentially (maybe) trim opaque paths after a query or fragment has been removed. This ensures that re-parsing roundtrips, even when URL component setters are used. Additionally, preserve trailing C0 for the path and query setters using a new shared function. * LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt: This is now synchronized up to the latest commit for the url directory: 01b31f8bbcf570218465a08e8dde4442ae8c3565. * Source/WTF/wtf/URL.cpp: (WTF::URL::parseAllowingC0AtEnd): (WTF::URL::setFragmentIdentifier): (WTF::URL::potentiallyStripTrailingSpacesFromOpaquePath): (WTF::URL::removeFragmentIdentifier): (WTF::URL::removeQueryAndFragmentIdentifier): (WTF::URL::setQuery): (WTF::URL::setPath): * Source/WTF/wtf/URL.h: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse): * Source/WTF/wtf/URLParser.h: Canonical link: https://commits.webkit.org/266252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d88a0: Only special-case document element outermost `svg`...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d88a0a85b71cfcf3ddba9e1fbfd7eeb6aeff4ec https://github.com/WebKit/WebKit/commit/4d88a0a85b71cfcf3ddba9e1fbfd7eeb6aeff4ec Author: Ahmad Saleem Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/foreign-object-containing-svg-in-svg-in-object-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/foreign-object-containing-svg-in-svg-in-object.html M Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp Log Message: --- Only special-case document element outermost `svg` embedded via a frame https://bugs.webkit.org/show_bug.cgi?id=259313 Reviewed by Simon Fraser. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium-review.googlesource.com/c/chromium/src/+/4681730 In Legacy & LBSE *RenderSVGRoot::IsEmbeddedThroughFrameContainingSVGDocument(), it wasn't considered whether the `svg` was the document element or not, and thus the special layout rules would be applied for all outermost `svg` elements. This lead to incorrect layout results being calculated in some of these cases. Return false from said function if the *RenderSVGRoot is not associated with the document element. * Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp: (LegacyRenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): As above * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): As above * LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/foreign-object-containing-svg-in-svg-in-object.html: Add Test Case (manually) * LayoutTests/imported/w3c/web-platform-tests/svg/extensibility/foreignObject/foreign-object-containing-svg-in-svg-in-object-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/266251@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f53815: Handle SVGLength resolving in an inactive document...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f538153c22209151c67f41eba0ab10d7672f2e65 https://github.com/WebKit/WebKit/commit/f538153c22209151c67f41eba0ab10d7672f2e65 Author: Ahmad Saleem Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: A LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt A LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html M Source/WebCore/svg/SVGLengthContext.cpp Log Message: --- Handle SVGLength resolving in an inactive document gracefully https://bugs.webkit.org/show_bug.cgi?id=258226 rdar://problem/112704896 Reviewed by Simon Fraser. Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=196269 If the element associated with the SVGLength is in an inactive document, there'll be no layout, so renderStyleForLengthResolving() will be able to exit the loop without finding a RenderStyle to return. * Source/WebCore/svg/SVGLengthContext.cpp: (renderStyleForLengthResolving): Remove 'ASSERT_NOT_REACHED' * LayoutTests/svg/dom/SVGLength-value-in-inactive-document.html: Add Test Case * LayoutTests/svg/dom/SVGLength-value-in-inactive-document-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/266250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7db5c: GARDENING: REGRESSION(265878@main): [ Ventura acce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7db5ca5dd5c4f87d4cb750e13426f0e584b4390 https://github.com/WebKit/WebKit/commit/b7db5ca5dd5c4f87d4cb750e13426f0e584b4390 Author: Ben Schwartz Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- GARDENING: REGRESSION(265878@main): [ Ventura accessibility-isolated-tree ] accessibility/content-editable-set-inner-text-generates-axvalue-notification.html is a consistent TEXT failure rdar://112688542 https://bugs.webkit.org/show_bug.cgi?id=259412 Unreviewed gardening commit. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/266249@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] edc7d0: Use setSearch() in URLSearchParams
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: edc7d0143e8d477dce8bdc66f2ab2b6247bc0b94 https://github.com/WebKit/WebKit/commit/edc7d0143e8d477dce8bdc66f2ab2b6247bc0b94 Author: Anne van Kesteren Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/html/DOMURL.cpp M Source/WebCore/html/DOMURL.h M Source/WebCore/html/URLSearchParams.cpp Log Message: --- Use setSearch() in URLSearchParams https://bugs.webkit.org/show_bug.cgi?id=259425 rdar://112728305 Reviewed by Alex Christensen. Removes the need for setQuery() in DOMURL. * Source/WebCore/html/DOMURL.cpp: (WebCore::DOMURL::setQuery): Deleted. * Source/WebCore/html/DOMURL.h: * Source/WebCore/html/URLSearchParams.cpp: (WebCore::URLSearchParams::updateURL): Canonical link: https://commits.webkit.org/266248@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1a659: Return opaque origin for blob: URL containing inne...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1a659b38f09d05fd3e7b3b112066894ab099b8c https://github.com/WebKit/WebKit/commit/b1a659b38f09d05fd3e7b3b112066894ab099b8c Author: Anne van Kesteren Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt M Source/WebCore/fileapi/BlobURL.cpp M Source/WebCore/fileapi/ThreadableBlobRegistry.cpp M Source/WebCore/page/SecurityOrigin.cpp M Source/WebCore/page/SecurityOrigin.h M Source/WebCore/page/SecurityOriginData.cpp Log Message: --- Return opaque origin for blob: URL containing inner non-http(s): URL https://bugs.webkit.org/show_bug.cgi?id=257262 rdar://109781193 Reviewed by Alex Christensen and Darin Adler. Refactor SecurityOrigin so it is more clear blob: URLs are the sole special case. And change how we derive the blob: URL origin to align with the URL standard: * No longer perform percent-decoding (matches other browsers). * Restrict non-opaque origins to HTTP(S) URLs (will soon match other browsers). However: * Still give blob: URLs derived from file: origins an origin for now as removing that ability needs a bit more care. This currently goes against the URL standard, but that might change. * Also give registered schemes a pass to allow embedders to continue to use blob: URLs as they see fit. Also change BlobURL to rely more directly on SecurityOrigin. * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * Source/WebCore/fileapi/BlobURL.cpp: (WebCore::BlobURL::getOriginURL): (WebCore::BlobURL::isSecureBlobURL): * Source/WebCore/fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::getCachedOrigin): * Source/WebCore/page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::forBlobURL): (WebCore::SecurityOrigin::isSecure): (WebCore::SecurityOrigin::shouldUseInnerURL): Deleted. (WebCore::SecurityOrigin::extractInnerURL): Deleted. * Source/WebCore/page/SecurityOrigin.h: * Source/WebCore/page/SecurityOriginData.cpp: (WebCore::SecurityOriginData::shouldTreatAsOpaqueOrigin): Canonical link: https://commits.webkit.org/266247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9368e: NetworkLoad should pass redirect completion handle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9368e2a4d3b76ce151cedc0c0969f61d0bba0e4 https://github.com/WebKit/WebKit/commit/a9368e2a4d3b76ce151cedc0c0969f61d0bba0e4 Author: Alex Christensen Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h M Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h M Source/WebKit/NetworkProcess/NetworkLoad.cpp M Source/WebKit/NetworkProcess/NetworkLoad.h M Source/WebKit/NetworkProcess/NetworkLoadClient.h M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoader.h M Source/WebKit/NetworkProcess/NetworkResourceLoader.messages.in M Source/WebKit/NetworkProcess/PreconnectTask.cpp M Source/WebKit/NetworkProcess/PreconnectTask.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp M Source/WebKit/UIProcess/Downloads/DownloadProxy.h M Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in M Source/WebKit/WebProcess/Network/WebResourceLoader.cpp M Source/WebKit/WebProcess/Network/WebResourceLoader.h M Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in Log Message: --- NetworkLoad should pass redirect completion handler to client https://bugs.webkit.org/show_bug.cgi?id=259276 rdar://112410538 Reviewed by Youenn Fablet. This is needed to clean up NetworkSessionCocoa::BlobDataTaskClient. Some other redirect improvements related to site isolation are also coming up soon (See the SiteIsolation.IframeRedirectCrossSite API test). * Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp: (WebKit::DownloadManager::continueWillSendRequest): Deleted. * Source/WebKit/NetworkProcess/Downloads/DownloadManager.h: * Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp: (WebKit::PendingDownload::willSendRedirectedRequest): (WebKit::PendingDownload::continueWillSendRequest): Deleted. * Source/WebKit/NetworkProcess/Downloads/PendingDownload.h: * Source/WebKit/NetworkProcess/NetworkLoad.cpp: (WebKit::NetworkLoad::~NetworkLoad): (WebKit::NetworkLoad::willPerformHTTPRedirection): (WebKit::NetworkLoad::continueWillSendRequest): Deleted. * Source/WebKit/NetworkProcess/NetworkLoad.h: * Source/WebKit/NetworkProcess/NetworkLoadClient.h: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::continueWillSendRequest): Deleted. * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::startRequest): (WebKit::NetworkResourceLoader::willSendRedirectedRequest): (WebKit::NetworkResourceLoader::willSendServiceWorkerRedirectedRequest): (WebKit::NetworkResourceLoader::willSendRedirectedRequestInternal): (WebKit::NetworkResourceLoader::continueWillSendRedirectedRequest): (WebKit::NetworkResourceLoader::restartNetworkLoad): (WebKit::NetworkResourceLoader::continueWillSendRequest): (WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry): (WebKit::NetworkResourceLoader::serviceWorkerDidNotHandle): * Source/WebKit/NetworkProcess/NetworkResourceLoader.h: * Source/WebKit/NetworkProcess/NetworkResourceLoader.messages.in: * Source/WebKit/NetworkProcess/PreconnectTask.cpp: (WebKit::PreconnectTask::willSendRedirectedRequest): * Source/WebKit/NetworkProcess/PreconnectTask.h: * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.cpp: (WebKit::ServiceWorkerNavigationPreloader::willSendRedirectedRequest): * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerNavigationPreloader.h: * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp: (WebKit::ServiceWorkerSoftUpdateLoader::willSendRedirectedRequest): * Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h: * Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp: (WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest): * Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h: * Source/WebKit/UIProcess/Down
[webkit-changes] [WebKit/WebKit] 85e47c: [GLib] In new API, update to base data directories...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85e47cd2bdd527cd70684647f9bfd50c32dac7d6 https://github.com/WebKit/WebKit/commit/85e47cd2bdd527cd70684647f9bfd50c32dac7d6 Author: Amanda Falke Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GLib] In new API, update to base data directories in TestWebsiteData configuration test. https://bugs.webkit.org/show_bug.cgi?id=259427 Reviewed by Michael Catanzaro. In 260375@main, we use UnifiedOriginStorageLevel::Basic in the new GLib API, which means that WebsiteDataStore::defaultLocalStorageDirectory and WebsiteDataStore::defaultIndexedDBDatabaseDirectory are no longer respected. Updating the dirs fixes the tests in the new API for WPE and GTK; this essentially uses WebsiteDataStore:defaultGeneralStorageDirectory. Some other helpful commit messages I found along the way were 253824@main, 259132@main and 260511@main; noting those here for historical purposes. * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: (testWebsiteDataConfiguration): Update to base directories per new API. * Tools/TestWebKitAPI/glib/TestExpectations.json: remove failing WPE test expectation that was added in a "meta gardening" bug ticket. Canonical link: https://commits.webkit.org/266245@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc4e64: Build against libjxl 0.9
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc4e645b7e9b460eddb956debc09b5da1cd8b6f5 https://github.com/WebKit/WebKit/commit/bc4e645b7e9b460eddb956debc09b5da1cd8b6f5 Author: Michael Catanzaro Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp Log Message: --- Build against libjxl 0.9 https://bugs.webkit.org/show_bug.cgi?id=259393 Reviewed by Carlos Garcia Campos. As libjxl works towards version 1.0, there are still API/ABI breaks on every 0.n release. libjxl 0.9 removed an unused parameter to some ICC functions we depend on. * Source/WebCore/platform/image-decoders/jpegxl/JPEGXLImageDecoder.cpp: (WebCore::JPEGXLImageDecoder::tryDecodeICCColorProfile): Canonical link: https://commits.webkit.org/266244@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0a8ad: [iOS] REGRESSION(265596@main) Captions fail to ren...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0a8ad8a73cac61855ac287a954115d35bfe60f9 https://github.com/WebKit/WebKit/commit/e0a8ad8a73cac61855ac287a954115d35bfe60f9 Author: Jer Noble Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css Log Message: --- [iOS] REGRESSION(265596@main) Captions fail to render in video-fullscreen mode https://bugs.webkit.org/show_bug.cgi?id=259438 rdar://112496682 Reviewed by Eric Carlson. VTTCues now use `cqw` and `cqh` units to define the height of individual cues. However, the text-track-container did not establish a container for those units, so the height of the still-inline element was used to generate the height of cues. In the case of very small elements, this resulted in no visible cues being painted. Instead, mark the text-track-container as a basis for inline and block size calculations. * Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css: (video::-webkit-media-text-track-container): Canonical link: https://commits.webkit.org/266243@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f48e0: [GTK] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f48e02db13d1ac13b841b649fdb130aa07f38d6 https://github.com/WebKit/WebKit/commit/4f48e02db13d1ac13b841b649fdb130aa07f38d6 Author: Diego Pino Garcia Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK] Unreviewed test gardening Garden tests crashing in Debug only. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/266242@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96ecc8: [GTK] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96ecc8899a1cb3a0061f908284ce6f89fd01 https://github.com/WebKit/WebKit/commit/96ecc8899a1cb3a0061f908284ce6f89fd01 Author: Diego Pino Garcia Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/private-network-access/iframe.tentative.window-expected.txt M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- [GTK] Unreviewed test gardening Whole directories should not be tagged with DumpJSConsoleLogInStdErr only, because that implicitly means all tests within that folder pass. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/fetch/private-network-access/iframe.tentative.window-expected.txt: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/266241@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40825e: [ Monterey+ WK2 ] http/wpt/service-workers/cache-m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40825ec29338f0099218fbdfd4b78a23ec31afc8 https://github.com/WebKit/WebKit/commit/40825ec29338f0099218fbdfd4b78a23ec31afc8 Author: Youenn Fablet Date: 2023-07-24 (Mon, 24 Jul 2023) Changed paths: M LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html Log Message: --- [ Monterey+ WK2 ] http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html is a flaky TEXT failure https://bugs.webkit.org/show_bug.cgi?id=259382 rdar://112630912 Reviewed by Alex Christensen. fourth, fifth and sixth script resources were expected to be in the memory cache thus avoiding the service worker since cache mode should be default. But memory cache may not always kick in in which case the loads will hit service worker. In that case, it is important to validate that the cache mode is default but we do not log those loads since they might not reliably hit the service worker. * LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html: Canonical link: https://commits.webkit.org/266240@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
