[webkit-changes] [WebKit/WebKit] 7873a1: Basic support for SVGImageElement in createImageBi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7873a1e800d01e459f642ebba2a8044d587ec867 https://github.com/WebKit/WebKit/commit/7873a1e800d01e459f642ebba2a8044d587ec867 Author: Matt Woodrow Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/drawing-images-to-the-canvas/drawimage_svg_image_1-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-origin.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-serializable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-transfer-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub-expected.txt M Source/WebCore/Modules/ShapeDetection/BarcodeDetector.idl M Source/WebCore/Modules/ShapeDetection/FaceDetector.idl M Source/WebCore/Modules/ShapeDetection/TextDetector.idl M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/html/ImageBitmap.h M Source/WebCore/page/WindowOrWorkerGlobalScope.idl M Source/WebCore/svg/SVGImageElement.cpp Log Message: --- Basic support for SVGImageElement in createImageBitmap https://bugs.webkit.org/show_bug.cgi?id=26 Reviewed by Said Abou-Hallawa. * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/drawing-images-to-the-canvas/drawimage_svg_image_1-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-origin.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-serializable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-transfer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.fillStyle.sub-expected.txt: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/Modules/ShapeDetection/BarcodeDetector.idl: * Source/WebCore/Modules/ShapeDetection/FaceDetector.idl: * Source/WebCore/Modules/ShapeDetection/TextDetector.idl: * Source/WebCore/html/ImageBitmap.cpp: (WebCore::ImageBitmap::createCompletionHandler): * Source/WebCore/html/ImageBitmap.h: * Source/WebCore/page/WindowOrWorkerGlobalScope.idl: * Source/WebCore/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::cachedImage const): Canonical link: https://commits.webkit.org/267218@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d7f14: [Gardening]: REGRESSION(266260@main): [ WK1 Ventur...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d7f14bbe65a61ce544c7e1c1ab0a0148361b945 https://github.com/WebKit/WebKit/commit/8d7f14bbe65a61ce544c7e1c1ab0a0148361b945 Author: Karl Rackler Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION(266260@main): [ WK1 Ventura ] http/tests/media/hls/track-in-band-multiple-cues.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=259485 rdar://112841466 Unreviewed test gardening. Correcting test expectation to be Ventura+. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/267217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1238f6: Migrate benchmark_json_merge in webkitpy/benchmark...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1238f66382701acf7c499a4a56a314e6a1c7954e https://github.com/WebKit/WebKit/commit/1238f66382701acf7c499a4a56a314e6a1c7954e Author: James Bohan Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Tools/Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py Log Message: --- Migrate benchmark_json_merge in webkitpy/benchmark_runner to Python 3 https://bugs.webkit.org/show_bug.cgi?id=260307 Reviewed by Dewei Zhu. Imports reduce from functools since it is no longer a built-in function in Python 3. Uses Python 3 list comprehension syntax to add the object keys. * Tools/Scripts/webkitpy/benchmark_runner/benchmark_json_merge.py: (deepAppend): Canonical link: https://commits.webkit.org/267216@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] baa5c6: [WGSL] Add codegen support for binary shift operators
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: baa5c67430942419d743400d9d2aa6730bae67c7 https://github.com/WebKit/WebKit/commit/baa5c67430942419d743400d9d2aa6730bae67c7 Author: Tadeu Zagallo Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp Log Message: --- [WGSL] Add codegen support for binary shift operators https://bugs.webkit.org/show_bug.cgi?id=260608 rdar://114320593 Reviewed by Dan Glastonbury. In 266979@main I updated the type declarations to include left and right shift, but I forgot to update the code generator. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): Canonical link: https://commits.webkit.org/267215@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9e3f2: [IFC] Minimum content width with "line-break: afte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9e3f2480826ae077bc48a4a41e776f97f14ab46 https://github.com/WebKit/WebKit/commit/c9e3f2480826ae077bc48a4a41e776f97f14ab46 Author: Alan Baradlay Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/editing/deleting/delete-block-table-expected.txt A LayoutTests/fast/text/preferred-widht-with-line-break-after-whitespace-expected.html A LayoutTests/fast/text/preferred-widht-with-line-break-after-whitespace.html M LayoutTests/platform/ios-wk2/editing/style/table-selection-expected.txt M LayoutTests/platform/ios/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/ios/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/mac/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/mac/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/mac/editing/style/table-selection-expected.txt M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp Log Message: --- [IFC] Minimum content width with "line-break: after-white-space" should not include trailing whitespace https://bugs.webkit.org/show_bug.cgi?id=260617 Reviewed by Antti Koivisto. This matches legacy line layout behavior (except inside table cells with one (unbreakable) word, where legacy diverges from default behavior). * LayoutTests/fast/text/preferred-widht-with-line-break-after-whitespace-expected.html: Added. * LayoutTests/fast/text/preferred-widht-with-line-break-after-whitespace.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::placeInlineAndFloatContent): * Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp: (WebCore::Layout::TextOnlySimpleLineBuilder::handleLineEnding): Canonical link: https://commits.webkit.org/267214@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f7775: Remove InMemoryDisplayList
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f7775558dc854a5ccbf94798d75f1ace93dbccd https://github.com/WebKit/WebKit/commit/2f7775558dc854a5ccbf94798d75f1ace93dbccd Author: Said Abou-Hallawa Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/platform/graphics/FontCascade.cpp M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/displaylists/DisplayList.cpp M Source/WebCore/platform/graphics/displaylists/DisplayList.h M Source/WebCore/platform/graphics/displaylists/DisplayListDrawingContext.h M Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h R Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp R Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.h R Source/WebCore/platform/graphics/displaylists/DisplayListItemBufferIdentifier.h R Source/WebCore/platform/graphics/displaylists/DisplayListItemType.cpp R Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h R Source/WebCore/platform/graphics/displaylists/DisplayListIterator.cpp R Source/WebCore/platform/graphics/displaylists/DisplayListIterator.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h M Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h R Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.cpp R Source/WebCore/platform/graphics/displaylists/InMemoryDisplayList.h M Source/WebCore/rendering/GlyphDisplayListCache.cpp M Source/WebCore/rendering/GlyphDisplayListCache.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Tools/TestWebKitAPI/Tests/WebCore/DisplayListRecorderTests.cpp M Tools/TestWebKitAPI/Tests/WebCore/DisplayListTests.cpp M Tools/TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp M Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp Log Message: --- Remove InMemoryDisplayList https://bugs.webkit.org/show_bug.cgi?id=260213 rdar://113921399 Reviewed by Kimmo Kinnunen and Wenson Hsieh. Make DisplayList hold a Vector of DisplayList items. There is no need for its read and write clients anymore. They were used in the past to share the recorded DisplayList items with GPU Process through a ring buffer. After introducing the StreamConnection, using the DisplayList became limited to the TextPainter recording. Simplifying this code will allow replaying back a whole DisplayList in GPU Process all at once. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/HTMLCanvasElement.cpp: * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::displayListForTextRun const): * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::displayListForTextRun): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::platformCALayerPaintContents): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/displaylists/DisplayList.cpp: (WebCore::DisplayList::DisplayList::append): (WebCore::DisplayList::DisplayList::shrinkToFit): (WebCore::DisplayList::DisplayList::clear): (WebCore::DisplayList::DisplayList::isEmpty const): (WebCore::DisplayList::DisplayList::cacheImageBuffer): (WebCore::DisplayList::DisplayList::cacheNativeImage): (WebCore::DisplayList::DisplayList::cacheFont): (WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs): (WebCore::DisplayList::DisplayList::cacheGradient): (WebCore::DisplayList::DisplayList::cacheFilter): (WebCore::DisplayList::DisplayList::asText const): (WebCore::DisplayList::DisplayList::dump const): (WebCore::DisplayList::DisplayList::description const): Deleted. (WebCore::DisplayList::DisplayList::DisplayList): Deleted. (WebCore::DisplayList::m_items): Deleted. (WebCore::DisplayList::DisplayList::operator=): Deleted. (WebCore::DisplayList::DisplayList::shouldDumpForFlags): Deleted. (WebCore::DisplayList::DisplayList::sizeInBytes const): Deleted. (WebCore::DisplayList::DisplayList::itemBuffer): Deleted. (WebCore::DisplayList::DisplayList::setItemBufferReadingClient): Deleted. (WebCore::DisplayL
[webkit-changes] [WebKit/WebKit] 266e31: [Gardening]: [ Release wk2 arm64 ] editing/execCom...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 266e319fa4d22078a654e0351a1c51b55c01a7df https://github.com/WebKit/WebKit/commit/266e319fa4d22078a654e0351a1c51b55c01a7df Author: Ben Schwartz Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/platform/wk2/TestExpectations Log Message: --- [Gardening]: [ Release wk2 arm64 ] editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html is a flaky text failure (260640) rdar://114354029 https://bugs.webkit.org/show_bug.cgi?id=260640 Unreviewed test gardening. * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/267212@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f950e: [JSC] Make PerfLog work on Darwin
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f950e05da63384e2e49fb9375558f688b4667db https://github.com/WebKit/WebKit/commit/7f950e05da63384e2e49fb9375558f688b4667db Author: Yusuke Suzuki Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/assembler/LinkBuffer.cpp M Source/JavaScriptCore/assembler/LinkBuffer.h M Source/JavaScriptCore/assembler/PerfLog.cpp M Source/JavaScriptCore/assembler/PerfLog.h M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/JavaScriptCore/runtime/Options.cpp Log Message: --- [JSC] Make PerfLog work on Darwin https://bugs.webkit.org/show_bug.cgi?id=260626 rdar://problem/114345611 Reviewed by Justin Michaud. This patch makes PerfLog work on Darwin, which generates JITDump[1] on Darwin. While this is not performance efficient enough, we can later optimize the way to dump this, and try using it for a prototype. [1]: https://raw.githubusercontent.com/torvalds/linux/master/tools/perf/Documentation/jitdump-specification.txt * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/assembler/LinkBuffer.cpp: (JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl): * Source/JavaScriptCore/assembler/LinkBuffer.h: * Source/JavaScriptCore/assembler/PerfLog.cpp: (JSC::PerfLog::singleton): (JSC::getCurrentThreadID): * Source/JavaScriptCore/assembler/PerfLog.h: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::initializeJITPageReservation): * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::isAvailable): Canonical link: https://commits.webkit.org/267211@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5dad01: [Cocoa] Add implementation for voiceschanged event...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5dad0170279988a68369b9bd12f9f64be0fbb21b https://github.com/WebKit/WebKit/commit/5dad0170279988a68369b9bd12f9f64be0fbb21b Author: Sihui Liu Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/platform/PlatformSpeechSynthesizer.cpp M Source/WebCore/platform/PlatformSpeechSynthesizer.h M Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm Log Message: --- [Cocoa] Add implementation for voiceschanged event of SpeechSynthesis API https://bugs.webkit.org/show_bug.cgi?id=260228 rdar://113933356 Reviewed by Chris Fleizach. Adopt new AVSpeechSynthesis API to receive notification about changes in available voices list, and fire voiceschanged event based on that. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/platform/PlatformSpeechSynthesizer.cpp: (WebCore::PlatformSpeechSynthesizer::resetVoiceList): (WebCore::PlatformSpeechSynthesizer::voicesDidChange): * Source/WebCore/platform/PlatformSpeechSynthesizer.h: * Source/WebCore/platform/cocoa/PlatformSpeechSynthesizerCocoa.mm: (-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:]): (-[WebSpeechSynthesisWrapper availableVoicesDidChange]): Canonical link: https://commits.webkit.org/267210@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2bec7b: Skip `watchdog-fire-while-in-forEachInIterable` fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2bec7b6bcb9a6be87744ef86200ead38af8e7475 https://github.com/WebKit/WebKit/commit/2bec7b6bcb9a6be87744ef86200ead38af8e7475 Author: Joseph Griego Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M JSTests/stress/watchdog-fire-while-in-forEachInIterable.js Log Message: --- Skip `watchdog-fire-while-in-forEachInIterable` for memory-limited platforms https://bugs.webkit.org/show_bug.cgi?id=260616 Reviewed by Yusuke Suzuki. This has been failing on 32-bit release builds for some time; skip there for now. If the array size was smaller, we could make this test work--AIUI, if the watchdog doesn't fire at all, the test still passes? So, I'm being quite conservative about not changing the test for 64-bit. * JSTests/stress/watchdog-fire-while-in-forEachInIterable.js: Canonical link: https://commits.webkit.org/267209@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c0d42: [Gardening]: REGRESSION(266644@main): [wk2] http/t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c0d424af07af5643f6a61691fa1d6f34a7f0b24 https://github.com/WebKit/WebKit/commit/2c0d424af07af5643f6a61691fa1d6f34a7f0b24 Author: Ben Schwartz Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/platform/wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(266644@main): [wk2] http/tests/security/referrer-policy-header.html is a flaky text failure, crash rdar://114349670 https://bugs.webkit.org/show_bug.cgi?id=260632 Unreviewed test gardening. * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/267208@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26b96b: Improve support in the HTML fast parser
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26b96bce3e5f8e65fec3bcd642aecac66856e2d7 https://github.com/WebKit/WebKit/commit/26b96bce3e5f8e65fec3bcd642aecac66856e2d7 Author: Chris Dumez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp Log Message: --- Improve support in the HTML fast parser https://bugs.webkit.org/show_bug.cgi?id=260619 Reviewed by Ryosuke Niwa. This moves to flow, so that it will be created in more situations. As s have special handling (primarily around nesting) this will not handle all situations. In particular, if an is encountered inside an then the fast parser aborts. This is a cherry-pick from Blink: - https://chromium-review.googlesource.com/c/chromium/src/+/4516018 * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::parseElement): * Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/267207@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 969f99: [Gardening]: Batch mark expectations for Ventura t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 969f99e0f53b4abc0c4730f2d9e6eaef5a17678c https://github.com/WebKit/WebKit/commit/969f99e0f53b4abc0c4730f2d9e6eaef5a17678c Author: Karl Rackler Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: Batch mark expectations for Ventura test failures https://bugs.webkit.org/show_bug.cgi?id=248537 rdar://102820070 Unreviewed test gardening. Update test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/267206@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66b628: Add a Loader malloc heap zone
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66b6285e8f367770bb1acc584f8ff1f270259b26 https://github.com/WebKit/WebKit/commit/66b6285e8f367770bb1acc584f8ff1f270259b26 Author: Ryan Reno Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/loader/ApplicationManifestLoader.h M Source/WebCore/loader/ContentFilter.h M Source/WebCore/loader/CrossOriginPreflightResultCache.h M Source/WebCore/loader/DocumentThreadableLoader.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/HistoryController.h M Source/WebCore/loader/ImageLoader.h M Source/WebCore/loader/LinkPreloadResourceClients.h A Source/WebCore/loader/LoaderMalloc.cpp A Source/WebCore/loader/LoaderMalloc.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/loader/NavigationDisabler.h M Source/WebCore/loader/NavigationScheduler.cpp M Source/WebCore/loader/NavigationScheduler.h M Source/WebCore/loader/PolicyChecker.h M Source/WebCore/loader/ProgressTracker.cpp M Source/WebCore/loader/ProgressTracker.h M Source/WebCore/loader/ProgressTrackerClient.h M Source/WebCore/loader/ResourceLoadObserver.h M Source/WebCore/loader/ResourceTiming.h M Source/WebCore/loader/SubframeLoader.h M Source/WebCore/loader/SubresourceLoader.h M Source/WebCore/loader/TextTrackLoader.h M Source/WebCore/loader/ThreadableLoaderClient.h M Source/WebCore/loader/WorkerThreadableLoader.h M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp M Source/WebCore/loader/appcache/ApplicationCacheGroup.h M Source/WebCore/loader/appcache/ApplicationCacheHost.h M Source/WebCore/loader/archive/ArchiveResourceCollection.h M Source/WebCore/loader/cache/CachedFontLoadRequest.h M Source/WebCore/loader/cache/CachedResource.h M Source/WebCore/loader/cache/CachedResourceLoader.h M Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.h M Source/WebCore/loader/cache/CachedSVGDocumentReference.h M Source/WebCore/loader/cache/MemoryCache.h M Source/WebCore/loader/icon/IconLoader.h M Source/WebCore/loader/ios/LegacyPreviewLoader.h Log Message: --- Add a Loader malloc heap zone https://bugs.webkit.org/show_bug.cgi?id=260623 rdar://114340888 Reviewed by Brent Fulgham and Simon Fraser. This adds a generic Loader allocator that fast malloc classes can use in the loading subsystem. This will allow us to categorize classes with WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER into a loader malloc zone without the need to make a zone for each class. Use by including "LoaderMalloc.h" (if necessary) and replacing WTF_MAKE_FAST_ALLOCATED with WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(Loader) in your loader class. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/loader/ApplicationManifestLoader.h: * Source/WebCore/loader/ContentFilter.h: * Source/WebCore/loader/CrossOriginPreflightResultCache.h: * Source/WebCore/loader/DocumentThreadableLoader.h: * Source/WebCore/loader/FrameLoader.cpp: * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/HistoryController.h: * Source/WebCore/loader/ImageLoader.h: * Source/WebCore/loader/LinkPreloadResourceClients.h: * Source/WebCore/loader/LoaderMalloc.cpp: Copied from Source/WebCore/loader/ProgressTrackerClient.h. * Source/WebCore/loader/LoaderMalloc.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h. * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/loader/NavigationDisabler.h: * Source/WebCore/loader/NavigationScheduler.cpp: * Source/WebCore/loader/NavigationScheduler.h: * Source/WebCore/loader/PolicyChecker.h: * Source/WebCore/loader/ProgressTracker.cpp: * Source/WebCore/loader/ProgressTracker.h: * Source/WebCore/loader/ProgressTrackerClient.h: * Source/WebCore/loader/ResourceLoadObserver.h: * Source/WebCore/loader/ResourceTiming.h: * Source/WebCore/loader/SubframeLoader.h: * Source/WebCore/loader/SubresourceLoader.h: * Source/WebCore/loader/TextTrackLoader.h: * Source/WebCore/loader/ThreadableLoaderClient.h: * Source/WebCore/loader/WorkerThreadableLoader.h: * Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp: * Source/WebCore/loader/appcache/ApplicationCacheGroup.h: * Source/WebCore/loader/appcache/ApplicationCacheHost.h: * Source/WebCore/loader/archive/ArchiveResourceCollection.h: * Source/WebCore/loader/cache/CachedFontLoadRequest.h: * Source/WebCore/loader/cache/CachedResource.h: * Source/WebCore/loader/cache/CachedResourceLoader.h: * Source/WebCore/loader/cache/CachedResourceRequestInitiatorTypes.h: * Source/WebCore/loader/cache/CachedSVGDocumentReference.h: * Source/WebCore/loader/cache/MemoryCache.h: * Source/WebCore/load
[webkit-changes] [WebKit/WebKit] 346fda: RemoteLayerTreeDrawingAreaProxy needs to hold use-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 346fdad1569da1c50564a62ee569a7f519d9cd46 https://github.com/WebKit/WebKit/commit/346fdad1569da1c50564a62ee569a7f519d9cd46 Author: Matt Woodrow Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- RemoteLayerTreeDrawingAreaProxy needs to hold use-count for IOSurfaces until CA commits. https://bugs.webkit.org/show_bug.cgi?id=260374 Reviewed by Simon Fraser. CoreAnimation doesn't guarantee to have marked the IOSurface as in-use until the transaction is committed, not once the layer mutation happens. This code was removed in 266557@main (rdar://111986083) with the belief that it was no longer necessary. This adds it back, but replaces kCATransactionPhasePostSynchronize with kCATransactionPhasePostCommit. Waiting for the synchronize phase was a performance regression, and is unnecessary with the latest CoreAnimation, but we still need to wait for the commit to happen. WebKit doesn't explicitly commit the CoreAnimation transaction, so the implicit transaction commit might happen significantly later, and we need to ensure that we continue to mark any IOSurfaces as in-use (by retaining the wrapping mach_port) in the interim. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): Canonical link: https://commits.webkit.org/267204@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c01e6: Update fast_float to v5.2.0
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c01e6175739acfed8f7da021d7b80694aeab989 https://github.com/WebKit/WebKit/commit/6c01e6175739acfed8f7da021d7b80694aeab989 Author: Yusuke Suzuki Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/FastFloat.cpp M Source/WTF/wtf/FastFloat.h M Source/WTF/wtf/dtoa.cpp M Source/WTF/wtf/dtoa.h M Source/WTF/wtf/fast_float/ascii_number.h M Source/WTF/wtf/fast_float/bigint.h A Source/WTF/wtf/fast_float/constexpr_feature_detect.h M Source/WTF/wtf/fast_float/decimal_to_binary.h M Source/WTF/wtf/fast_float/digit_comparison.h M Source/WTF/wtf/fast_float/fast_float.h M Source/WTF/wtf/fast_float/fast_table.h M Source/WTF/wtf/fast_float/float_common.h M Source/WTF/wtf/fast_float/parse_number.h Log Message: --- Update fast_float to v5.2.0 https://bugs.webkit.org/show_bug.cgi?id=260604 rdar://114310405 Reviewed by Justin Michaud. This patch updates WTF's fast_float to v5.2.0[1]. 1. This offers 3% improvement in JSTests/microbenchmarks/json-parse-double.js micro benchmark. 2. New fast_float can offer a way to parse UTF-16 directly. We use this instead of converting UTF-16 chars into LChars. [1]: https://github.com/fastfloat/fast_float/releases/tag/v5.2.0 * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/fast_float/ascii_number.h: (fast_float::has_simd_opt): (fast_float::byteswap): (fast_float::read8_to_u64): (fast_float::simd_read8_to_u64): (fast_float::write_u64): (fast_float::parse_eight_digits_unrolled): (fast_float::FASTFLOAT_ENABLE_IF): (fast_float::loop_parse_if_eight_digits): (fast_float::read_u64): Deleted. * Source/WTF/wtf/fast_float/bigint.h: (fast_float::stackvec::stackvec): (fast_float::bigint::bigint): * Source/WTF/wtf/fast_float/constexpr_feature_detect.h: Added. * Source/WTF/wtf/fast_float/decimal_to_binary.h: * Source/WTF/wtf/fast_float/digit_comparison.h: * Source/WTF/wtf/fast_float/fast_float.h: (): Deleted. (fast_float::parse_options::parse_options): Deleted. * Source/WTF/wtf/fast_float/fast_table.h: * Source/WTF/wtf/fast_float/float_common.h: (fast_float::parse_options_t::parse_options_t): (fast_float::cpp20_and_in_constexpr): (fast_float::fastfloat_strncasecmp): (fast_float::span::span): (fast_float::value128::value128): (fast_float::leading_zeroes_generic): (fast_float::leading_zeroes): (fast_float::emulu): (fast_float::umul128_generic): (fast_float::_umul128): (fast_float::full_multiplication): (fast_float::adjusted_mantissa::operator== const): (fast_float::adjusted_mantissa::operator!= const): (fast_float::binary_format::min_exponent_fast_path): (fast_float::binary_format::min_exponent_fast_path): (fast_float::binary_format::max_mantissa_fast_path): (fast_float::binary_format::max_mantissa_fast_path): (fast_float::binary_format::exact_power_of_ten): (fast_float::binary_format::exact_power_of_ten): (fast_float::to_float): (fast_float::is_space): (fast_float::int_cmp_zeros): (fast_float::int_cmp_len): (fast_float::str_const_nan): (fast_float::str_const_nan): (fast_float::str_const_nan): (fast_float::str_const_nan): (fast_float::str_const_nan): (fast_float::str_const_inf): (fast_float::str_const_inf): (fast_float::str_const_inf): (fast_float::str_const_inf): (fast_float::str_const_inf): * Source/WTF/wtf/fast_float/parse_number.h: Canonical link: https://commits.webkit.org/267203@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c42aae: Leverage fast HTML parser in DOMParser::parseFromS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c42aaec46c580f52c3a101b51f011a605101fbc8 https://github.com/WebKit/WebKit/commit/c42aaec46c580f52c3a101b51f011a605101fbc8 Author: Chris Dumez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Source/WebCore/xml/DOMParser.cpp Log Message: --- Leverage fast HTML parser in DOMParser::parseFromString() https://bugs.webkit.org/show_bug.cgi?id=260076 rdar://113738031 Reviewed by Ryosuke Niwa. Leverage the fast HTML parser in DOMParser::parseFromString(), like we already do for HTMLElement::setInnerHTML(). * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: * Source/WebCore/xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): Canonical link: https://commits.webkit.org/267202@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b93889: [visionOS] Fullscreen windows do not cast shadows
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b938895dd2133d2caa69e79f4b525e252b61dbd6 https://github.com/WebKit/WebKit/commit/b938895dd2133d2caa69e79f4b525e252b61dbd6 Author: Aditya Keerthi Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- [visionOS] Fullscreen windows do not cast shadows https://bugs.webkit.org/show_bug.cgi?id=260620 rdar://114049859 Reviewed by Richard Robinson and Tim Horton. Adopt UIKit SPI to add a grounding shadow to the fullscreen window. The fullscreen window does not get a shadow by default since it's not platter-backed. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Canonical link: https://commits.webkit.org/267201@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 32965c: [iOS 17] AdvancedPrivacyProtections.AddNoiseToWebA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 32965cbc22aadcd07512035fa16ebb89c1b007f5 https://github.com/WebKit/WebKit/commit/32965cbc22aadcd07512035fa16ebb89c1b007f5 Author: Wenson Hsieh Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm Log Message: --- [iOS 17] AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs fails after 265168@main https://bugs.webkit.org/show_bug.cgi?id=260618 Reviewed by Tim Horton. After the changes in 265168@main, this API test fails because the `testOscillatorCompressorWorklet` step requires user activation after triggering the initial async function call in order to begin producing "sound" (really, an inaudible audio signal), which the test then waits for; avoid this issue altogether by using `-[WKWebViewConfiguration setMediaTypesRequiringUserActionForPlayback:]` to allow web audio to play back regardless of user activation. * Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm: Canonical link: https://commits.webkit.org/267200@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c6b1e: Safari can't open the page when navigating back fr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c6b1e0f4c367656d18d45a8b4f6d2ec60ec128c https://github.com/WebKit/WebKit/commit/6c6b1e0f4c367656d18d45a8b4f6d2ec60ec128c Author: Chris Dumez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make A Source/WebKit/Shared/GoToBackForwardItemParameters.h A Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- Safari can't open the page when navigating back from a remote HTTP URL to a local html file https://bugs.webkit.org/show_bug.cgi?id=260504 rdar://103697846 Reviewed by Brent Fulgham. When calling loadFile on a WKWebView, we create a sandbox extension in the UIProcess and send it to the WebProcess. In turn the WebProcess uses this to create a temporary extension for the network process. Without this, sandboxed apps such as Safari would be unable to load such local files. When doing a back/forward navigation to a history item for a file URL, we often get lucky and load the page from the back/forward cache. However, if the page was evicted from the cache (or wasn't cached in the first place), we end up using a fresh new process for the navigation. However, we were not issuing a sandbox extension and the load would fail. To address the issue, we now create a sandbox extension in ProvisionalPageProxy::goToBackForwardItem(), whenever we process-swap on back/forward navigation to a file URL. Note that Cocoa ports are only able to create sandbox extensions once the process has finished launching (and we have its PID). As a result, the call to maybeInitializeSandboxExtensionHandle() may fail when calling ProvisionalPageProxy::goToBackForwardItem() if the process is still launching. In this case, the sandbox extension gets created later on, when the process has finished launching and we're sending the queued IPC. This is the exact same approach that we were using for WebPage::LoadRequest, but I am now applying it to WebPage::GoToBackForwardItem IPC too. If the process is not done launching, we send a WebPage::GoToBackForwardItemWaitingForProcessLaunch IPC instead, which gets handled in WebProcessProxy::shouldSendPendingMessage(), similarly to WebPage::LoadRequestWaitingForProcessLaunch. At this point, we create the sandbox extensions and convert the IPC message into a regular WebPage::GoToBackForwardItem one. To simplify the code, I moved all the parameters for the WebPage::GoToBackForwardItem IPC to a new GoToBackForwardItemParameters structure with its generated IPC coders. I also added the new sandbox extension handle to this structure. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/GoToBackForwardItemParameters.h: Added. * Source/WebKit/Shared/GoToBackForwardItemParameters.serialization.in: Added. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::goToBackForwardItem): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::launchProcessForReload): (WebKit::WebPageProxy::goToBackForwardItem): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::shouldSendPendingMessage): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goToBackForwardItem): (WebKit::WebPage::goToBackForwardItemWaitingForProcessLaunch): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/267199@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 706e89: [MQ5] Ensure that media “scripting: initial-only” ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 706e894119545882666bdaef16156905f323d364 https://github.com/WebKit/WebKit/commit/706e894119545882666bdaef16156905f323d364 Author: Michael[tm] Smith Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: A LayoutTests/fast/css/media-query-scripting-initial-only-expected.html A LayoutTests/fast/css/media-query-scripting-initial-only.html M Source/WebCore/css/query/MediaQueryFeatures.cpp Log Message: --- [MQ5] Ensure that media “scripting: initial-only” never matches https://bugs.webkit.org/show_bug.cgi?id=260432 Reviewed by Tim Nguyen. https://github.com/w3c/csswg-drafts/issues/8621 * LayoutTests/fast/css/media-query-scripting-initial-only-expected.html: Added. * LayoutTests/fast/css/media-query-scripting-initial-only.html: Added. * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::scripting): Canonical link: https://commits.webkit.org/267198@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 508ac9: Fix container selection for container units in pse...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 508ac946574ee4391a8cfbec22af8c95bd8ea57b https://github.com/WebKit/WebKit/commit/508ac946574ee4391a8cfbec22af8c95bd8ea57b Author: Antti Koivisto Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-006-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-007-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-008-expected.txt M Source/WebCore/css/CSSPrimitiveValue.cpp Log Message: --- Fix container selection for container units in pseudo elements https://bugs.webkit.org/show_bug.cgi?id=253939 rdar://106739553 Reviewed by Alan Baradlay. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-006-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-007-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-008-expected.txt: * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble): Tell the container selection algorithm that we selecting for a pseudo-element. Canonical link: https://commits.webkit.org/267197@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 793f13: Enable Fetch Priority by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 793f132ba08ba69462713ded8e74294bd400023e https://github.com/WebKit/WebKit/commit/793f132ba08ba69462713ded8e74294bd400023e Author: Brent Fulgham Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Enable Fetch Priority by default https://bugs.webkit.org/show_bug.cgi?id=255008 Reviewed by Youenn Fablet. Enable this feature now that Igalia has completed it. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/267196@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 949488: Add heap identifier macros to WebCore/accessibilit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 949488d0ba4570304abd961339360389e90997f4 https://github.com/WebKit/WebKit/commit/949488d0ba4570304abd961339360389e90997f4 Author: Ryan Reno Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/accessibility/AXGeometryManager.cpp M Source/WebCore/accessibility/AXGeometryManager.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AXTextMarker.cpp M Source/WebCore/accessibility/AXTextMarker.h M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityAtspi.h M Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp M Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/css/CSSCounterStyleRegistry.cpp M Source/WebCore/css/CSSCounterStyleRegistry.h M Source/WebCore/css/CSSFontFaceSource.cpp M Source/WebCore/css/CSSFontFaceSource.h M Source/WebCore/css/CSSSegmentedFontFace.cpp M Source/WebCore/css/CSSSegmentedFontFace.h M Source/WebCore/css/CSSStyleSheet.cpp M Source/WebCore/css/CSSValuePool.cpp M Source/WebCore/css/CSSValuePool.h M Source/WebCore/css/CSSVariableData.cpp M Source/WebCore/css/CSSVariableData.h M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/ComputedStyleExtractor.h M Source/WebCore/css/DOMCSSPaintWorklet.cpp M Source/WebCore/css/DOMCSSPaintWorklet.h M Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp M Source/WebCore/css/DOMCSSRegisterCustomProperty.h M Source/WebCore/css/StyleRuleImport.cpp M Source/WebCore/css/StyleRuleImport.h M Source/WebCore/css/calc/CSSCalcOperationNode.cpp M Source/WebCore/css/calc/CSSCalcOperationNode.h M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp M Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h M Source/WebCore/css/parser/CSSParserToken.cpp M Source/WebCore/css/parser/CSSParserToken.h M Source/WebCore/css/parser/CSSTokenizer.cpp M Source/WebCore/css/parser/CSSTokenizer.h M Source/WebCore/css/parser/CSSTokenizerInputStream.cpp M Source/WebCore/css/parser/CSSTokenizerInputStream.h M Source/WebCore/css/typedom/CSSNumericFactory.cpp M Source/WebCore/css/typedom/CSSNumericFactory.h Log Message: --- Add heap identifier macros to WebCore/accessibility and WebCore/css https://bugs.webkit.org/show_bug.cgi?id=260544 rdar://114281241 Reviewed by Brent Fulgham. Replace WTF_MAKE_FAST_ALLOCATED with WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER for more fine-grained diagnostics when building with MallocHeapBreakdown enabled. * Source/WebCore/accessibility/AXGeometryManager.cpp: * Source/WebCore/accessibility/AXGeometryManager.h: * Source/WebCore/accessibility/AXObjectCache.cpp: * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AXTextMarker.cpp: * Source/WebCore/accessibility/AXTextMarker.h: * Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp: * Source/WebCore/accessibility/atspi/AccessibilityAtspi.h: * Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp: * Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: * Source/WebCore/css/CSSCounterStyleRegistry.cpp: * Source/WebCore/css/CSSCounterStyleRegistry.h: * Source/WebCore/css/CSSFontFaceSource.cpp: * Source/WebCore/css/CSSFontFaceSource.h: * Source/WebCore/css/CSSSegmentedFontFace.cpp: * Source/WebCore/css/CSSSegmentedFontFace.h: * Source/WebCore/css/CSSStyleSheet.cpp: * Source/WebCore/css/CSSValuePool.cpp: * Source/WebCore/css/CSSValuePool.h: * Source/WebCore/css/CSSVariableData.cpp: * Source/WebCore/css/CSSVariableData.h: * Source/WebCore/css/ComputedStyleExtractor.cpp: * Source/WebCore/css/ComputedStyleExtractor.h: * Source/WebCore/css/DOMCSSPaintWorklet.cpp: * Source/WebCore/css/DOMCSSPaintWorklet.h: * Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp: * Source/WebCore/css/DOMCSSRegisterCustomProperty.h: * Source/WebCore/css/StyleRuleImport.cpp: * Source/WebCore/css/StyleRuleImport.h: * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: * Source/WebCore/css/calc/CSSCalcOperationNode.h: * Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp: * Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h: * Source/WebCore/css/parser/CSSParserToken.cpp: * Source/WebCore/css/parser/CSSParserToken.h: * Source/WebCore/css/parser/CSSTokenizer.cpp: * Source/WebCore/css/parser/CSSTokenizer.h: * Source/WebCore/css/parser/CSSTokenizerInputStream.cpp: * Source/WebCore/css/parser/CSSTokenizerInputStream.h: * Source/WebCore/css/typedom/CSSNumericFactory.cpp: * Sourc
[webkit-changes] [WebKit/WebKit] 049544: ASSERTION FAILED: isAllowedByContentSecurityPolicy...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0495446c22a5e5e8b5615363f9a6c100ec00f3ff https://github.com/WebKit/WebKit/commit/0495446c22a5e5e8b5615363f9a6c100ec00f3ff Author: Youenn Fablet Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/http/wpt/workers/modules/dedicated-worker-import-csp-expected.txt M LayoutTests/http/wpt/workers/modules/shared-worker-import-csp-expected.txt M LayoutTests/platform/wk2/TestExpectations M Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp M Source/WebCore/bindings/js/WorkerModuleScriptLoader.h Log Message: --- ASSERTION FAILED: isAllowedByContentSecurityPolicy(request.url(), ContentSecurityPolicy::RedirectResponseReceived::No) seen with multiple tests under http/wpt/workers/modules/ https://bugs.webkit.org/show_bug.cgi?id=260107 rdar://113777310 Reviewed by Chris Dumez. CSP initial checks are done by each fetch client currently. WorkerModuleScriptLoader needs to add the same checks as other clients. * LayoutTests/http/wpt/workers/modules/dedicated-worker-import-csp-expected.txt: * LayoutTests/http/wpt/workers/modules/shared-worker-import-csp-expected.txt: * LayoutTests/platform/wk2/TestExpectations: * Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp: (WebCore::WorkerModuleScriptLoader::load): * Source/WebCore/bindings/js/WorkerModuleScriptLoader.h: * Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp: (WebKit::NetworkLoadChecker::isAllowedByContentSecurityPolicy): Canonical link: https://commits.webkit.org/267194@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9743e0: Remove ParseSdpForH264ProfileLevelId defaulting in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9743e04f0013d4c3719964096053cddfe1b28578 https://github.com/WebKit/WebKit/commit/9743e04f0013d4c3719964096053cddfe1b28578 Author: Youenn Fablet Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: A LayoutTests/http/wpt/webcodecs/H264-422-expected.txt A LayoutTests/http/wpt/webcodecs/H264-422.html M Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h264_profile_level_id.cc M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h Log Message: --- Remove ParseSdpForH264ProfileLevelId defaulting introduced in https://commits.webkit.org/266392@main https://bugs.webkit.org/show_bug.cgi?id=260467 rdar://problem/114311260 Reviewed by Eric Carlson. Before this patch, in case of bad or unsupported profile, we would downgrade to a default profile. We are now reporting the error back from RTCVideoEncoderH264 to LibWebRTCCodecsProxy then to LibWebRTCCodecs and RemoteVideoCodecFactory. This allows to notify WebCodecs JS that a particular profile is not supported. Covered by added test. * LayoutTests/http/wpt/webcodecs/H264-422-expected.txt: Added. * LayoutTests/http/wpt/webcodecs/H264-422.html: Added. * Source/ThirdParty/libwebrtc/Source/webrtc/api/video_codecs/h264_profile_level_id.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm: (-[WK_RTCLocalVideoH264H265Encoder initWithCodecInfo:]): (webrtc::createLocalEncoder): * Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm: (-[RTCVideoEncoderH264 initWithCodecInfo:]): * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h: * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in: * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm: (WebKit::LibWebRTCCodecsProxy::createEncoder): (WebKit::LibWebRTCCodecsProxy::releaseEncoder): (WebKit::LibWebRTCCodecsProxy::initializeEncoder): (WebKit::LibWebRTCCodecsProxy::encodeFrame): (WebKit::LibWebRTCCodecsProxy::flushEncoder): (WebKit::LibWebRTCCodecsProxy::setEncodeRates): (WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameSemaphore): (WebKit::LibWebRTCCodecsProxy::setSharedVideoFrameMemory): * Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp: (WebKit::RemoteVideoCodecFactory::createEncoder): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::LibWebRTCCodecs::createEncoder): (WebKit::LibWebRTCCodecs::createEncoderAndWaitUntilReady): (WebKit::LibWebRTCCodecs::createEncoderInternal): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: Canonical link: https://commits.webkit.org/267193@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9853d1: [CSS Container Queries] Container unit resolution ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9853d19085bb0a308a87cd21447a9504c20d5427 https://github.com/WebKit/WebKit/commit/9853d19085bb0a308a87cd21447a9504c20d5427 Author: Antti Koivisto Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-ineligible-container-expected.txt M Source/WebCore/css/CSSPrimitiveValue.cpp M Source/WebCore/css/query/ContainerQueryFeatures.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h Log Message: --- [CSS Container Queries] Container unit resolution should check the selected container is eligible https://bugs.webkit.org/show_bug.cgi?id=260561 rdar://problem/114291153 Reviewed by Alan Baradlay. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-ineligible-container-expected.txt: * Source/WebCore/css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble): Loop until an eligible container is found. * Source/WebCore/css/query/ContainerQueryFeatures.cpp: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::hasEligibleContainmentForSizeQuery const): Factor into a shared function. * Source/WebCore/rendering/RenderElement.h: Canonical link: https://commits.webkit.org/267192@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7e81ee: [WPE][GTK] Cleanup `TestExpectations.json`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e81eec70de3b5eabb497f532edf580bb13294bb https://github.com/WebKit/WebKit/commit/7e81eec70de3b5eabb497f532edf580bb13294bb Author: Vitaly Dyachkov Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [WPE][GTK] Cleanup `TestExpectations.json` Unreviewed test gardening. All these tests have been constantly passing for at least 100 runs. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/267191@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8ef16: AX: Relations updates thrash between dirty and cle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8ef167b97d50bce3f8d37fcc098266d79094152 https://github.com/WebKit/WebKit/commit/f8ef167b97d50bce3f8d37fcc098266d79094152 Author: Tyler Wilcock Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- AX: Relations updates thrash between dirty and clean when multiple deferred id attribute changes are processed https://bugs.webkit.org/show_bug.cgi?id=260370 rdar://problem/114052085 Reviewed by Andres Gonzalez. In AXObjectCache::handleAttributeChange, any change to the `id` attribute causes AXObjectCache::m_relationsNeedUpdate to become true. This is problematic when `m_deferredAttributeChange` contains multiple `id` attribute changes, as we thrash between setting m_relationsNeedUpdate to true, immediately resetting it to false as a result of an arbitrary` parentObject` call, and then re-dirtying it with the next id attribute change. With this patch (authored by Andres Gonzalez), we only update relations once, even when a group of id attribute changes are processed. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::performDeferredCacheUpdate): (WebCore::AXObjectCache::relationsNeedUpdate): * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/267190@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1534da: AX: AXObjectCache::handleAllDeferredChildrenChange...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1534dabccbb4b5b6cc80d8e072d77223a16a8a90 https://github.com/WebKit/WebKit/commit/1534dabccbb4b5b6cc80d8e072d77223a16a8a90 Author: Andres Gonzalez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: AXObjectCache::handleAllDeferredChildrenChanged doesn't need to call postPlatformNotification in MAC and IOS_FAMILY ports. https://bugs.webkit.org/show_bug.cgi?id=260562 Reviewed by Tyler Wilcock. This patch is a follow up to the patch in https://bugs.webkit.org/show_bug.cgi?id=258998. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAllDeferredChildrenChanged): Do not call postPlatformNotification for the COCOA platforms since AXChildrenChanged is not mapped to any platform notification. Even if this notification were mapped, like in the case of GTK, the update to the isolated tree should happen before a platform client is notify of a change. This patch also fixes that issue. (WebCore::AXObjectCache::handleChildrenChanged): Moved the postPlatformNotification call from this method to the above one. (WebCore::AXObjectCache::updateIsolatedTree): Removed the case for AXChildrenNotification since it is not used any longer. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateChildrenForObjects): Added this new method with a FIXME comment for future optimization. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/267189@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7ea43: [Media] Rename videoInlineSize to videoLayerSize
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7ea43266acd19a923068cd3bc302fd6156d16a3 https://github.com/WebKit/WebKit/commit/f7ea43266acd19a923068cd3bc302fd6156d16a3 Author: Andy Estes Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp M Source/WebKit/WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm M Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- [Media] Rename videoInlineSize to videoLayerSize https://bugs.webkit.org/show_bug.cgi?id=260567 rdar://114296677 Reviewed by Jer Noble. Renamed videoInlineSize to videoLayerSize. The latter better reflects its value as the content size of MediaPlayerPrivate's video layer and avoids confusion with the concept of an inline video element. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::videoLayerSize const): (WebCore::HTMLMediaElement::setVideoLayerSizeFenced): (WebCore::HTMLMediaElement::videoInlineSize const): Deleted. (WebCore::HTMLMediaElement::setVideoInlineSizeFenced): Deleted. * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm: (WebCore::VideoFullscreenModelVideoElement::setVideoSizeFenced): * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::videoLayerSize const): (WebCore::MediaPlayer::setVideoLayerSizeFenced): (WebCore::MediaPlayer::videoInlineSize const): Deleted. (WebCore::MediaPlayer::setVideoInlineSizeFenced): Deleted. * Source/WebCore/platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerVideoLayerSize const): (WebCore::MediaPlayerClient::mediaPlayerVideoInlineSize const): Deleted. * Source/WebCore/platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::videoLayerSize const): (WebCore::MediaPlayerPrivateInterface::setVideoLayerSizeFenced): (WebCore::MediaPlayerPrivateInterface::videoInlineSize const): Deleted. (WebCore::MediaPlayerPrivateInterface::setVideoInlineSizeFenced): Deleted. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoLayerSizeFenced): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoInlineSizeFenced): Deleted. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoLayerSizeFenced): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVideoInlineSizeFenced): Deleted. * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.serialization.in: * Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.
[webkit-changes] [WebKit/WebKit] e53448: Remove unused 'tc019-cue-size.vtt' and 'tc019-cue-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e53448e5929cdb9a4a3775320dfa83691a3ff8ae https://github.com/WebKit/WebKit/commit/e53448e5929cdb9a4a3775320dfa83691a3ff8ae Author: Ahmad Saleem Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: R LayoutTests/media/track/captions-webvtt/tc019-cue-size-bad.vtt R LayoutTests/media/track/captions-webvtt/tc019-cue-size.vtt Log Message: --- Remove unused 'tc019-cue-size.vtt' and 'tc019-cue-size-bad.vtt' files post 267041@main https://bugs.webkit.org/show_bug.cgi?id=260613 Reviewed by Jer Noble. This patch remove unused support files needed by test 'track-webvtt-tc019-cue-size.html' removed in commit 267041@main. * LayoutTests/media/track/captions-webvtt/tc019-cue-size-bad.vtt: Removed * LayoutTests/media/track/captions-webvtt/tc019-cue-size.vtt: Ditto Canonical link: https://commits.webkit.org/267187@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e99fa: [Tools][GTK][WPE] generate-bundle: include the gra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e99fa3f861b9ab48569aa970498ab63b5db8ba9 https://github.com/WebKit/WebKit/commit/2e99fa3f861b9ab48569aa970498ab63b5db8ba9 Author: Carlos Alberto Lopez Perez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Tools/Scripts/generate-bundle Log Message: --- [Tools][GTK][WPE] generate-bundle: include the graphics libraries also on the sysdeps bundle with install script https://bugs.webkit.org/show_bug.cgi?id=260496 Reviewed by Carlos Garcia Campos. Since the GTK MiniBrowser switched to using libepoxy after r265017@main there is an indirect dependency on libGLESv2.so.2 that can't be determined via ldd because libepoxy uses dlopen(). And the package for libepoxy on Ubuntu doesn't depend on the graphic libraries. Add the same list of graphics libraries that we use for bundle syslibs=bundle-all to the bundle that generates a install script. Meanwhile at it, fix a bug where the code was not checking if the object was provided by a system package in the case of libraries and binaries. A small refactor is done in order to make the code more tidy moving the code for finding the libraries and the interpreter to its own function. This should fix the bug that has caused the WebKitGTK WPT runs at wpt.fyi to be failing since a while. * Tools/Scripts/generate-bundle: Canonical link: https://commits.webkit.org/267186@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41b901: Remove RemoteScrollingCoordinatorTransaction.cpp.o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41b901f1fb5f2a77edefe7a0c08cb7c6f551561d https://github.com/WebKit/WebKit/commit/41b901f1fb5f2a77edefe7a0c08cb7c6f551561d Author: Alan Baradlay Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: R Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp.orig R Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp.rej Log Message: --- Remove RemoteScrollingCoordinatorTransaction.cpp.orig and .rej https://bugs.webkit.org/show_bug.cgi?id=260612 Unreviewed. These diff files got accidentally landed at 267174@main. * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp.orig: Removed. * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp.rej: Removed. Canonical link: https://commits.webkit.org/267185@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c9a44: [WebCrypto] Implement a key pair check for Ed25519.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c9a448b18a44fda10a8b6de16db52e7582cefa9 https://github.com/WebKit/WebKit/commit/8c9a448b18a44fda10a8b6de16db52e7582cefa9 Author: Javier Fernandez Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt M Source/WebCore/crypto/keys/CryptoKeyOKP.cpp M Source/WebCore/crypto/keys/CryptoKeyOKP.h M Source/WebCore/crypto/mac/CryptoKeyOKPCocoa.cpp Log Message: --- [WebCrypto] Implement a key pair check for Ed25519. https://bugs.webkit.org/show_bug.cgi?id=260469 Reviewed by Youenn Fablet. When importing an Ed25519 key-pair in JWK format we extract different values from the 'x' and 'd' dict properties, which correspond to the public and private keys respectively. The new platformCheckPairedKeys ensures that the public key imported matches the one generated from the private one, using the Ed25519 key-pair generation operation. There are several WPT that pass thanks to this change, so no new tests are needed. * Source/WebCore/crypto/keys/CryptoKeyOKP.cpp: (WebCore::CryptoKeyOKP::platformCheckPairedKeys): * Source/WebCore/crypto/keys/CryptoKeyOKP.h: * Source/WebCore/crypto/mac/CryptoKeyOKPCocoa.cpp: (WebCore::CryptoKeyOKP::platformCheckPairedKeys): Canonical link: https://commits.webkit.org/267184@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a55c5: WebGL resource creation is not robust against cont...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a55c5eda697bbd893e6db2a7e7b899553c9227d
https://github.com/WebKit/WebKit/commit/6a55c5eda697bbd893e6db2a7e7b899553c9227d
Author: Kimmo Kinnunen
Date: 2023-08-23 (Wed, 23 Aug 2023)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGLBuffer.cpp
M Source/WebCore/html/canvas/WebGLBuffer.h
M Source/WebCore/html/canvas/WebGLFramebuffer.cpp
M Source/WebCore/html/canvas/WebGLFramebuffer.h
M Source/WebCore/html/canvas/WebGLObject.cpp
M Source/WebCore/html/canvas/WebGLObject.h
M Source/WebCore/html/canvas/WebGLProgram.cpp
M Source/WebCore/html/canvas/WebGLProgram.h
M Source/WebCore/html/canvas/WebGLQuery.cpp
M Source/WebCore/html/canvas/WebGLQuery.h
M Source/WebCore/html/canvas/WebGLRenderbuffer.cpp
M Source/WebCore/html/canvas/WebGLRenderbuffer.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLSampler.cpp
M Source/WebCore/html/canvas/WebGLSampler.h
M Source/WebCore/html/canvas/WebGLShader.cpp
M Source/WebCore/html/canvas/WebGLShader.h
M Source/WebCore/html/canvas/WebGLSync.cpp
M Source/WebCore/html/canvas/WebGLSync.h
M Source/WebCore/html/canvas/WebGLTexture.cpp
M Source/WebCore/html/canvas/WebGLTexture.h
M Source/WebCore/html/canvas/WebGLTimerQueryEXT.cpp
M Source/WebCore/html/canvas/WebGLTimerQueryEXT.h
M Source/WebCore/html/canvas/WebGLTransformFeedback.cpp
M Source/WebCore/html/canvas/WebGLTransformFeedback.h
M Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
M Source/WebCore/html/canvas/WebGLVertexArrayObject.h
M Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp
M Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h
M Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.cpp
M Source/WebCore/html/canvas/WebGLVertexArrayObjectOES.h
Log Message:
---
WebGL resource creation is not robust against context loss
https://bugs.webkit.org/show_bug.cgi?id=260513
rdar://problem/114245538
Reviewed by Dan Glastonbury.
At the moment, the various GraphicsContextGL::create{Resource}() calls
might return 0 if the context is lost during that call. Handle this in
all the WebGL resource constructors. Return RefPtr and handle the
nullptr in the caller.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::create):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::fenceSync):
* Source/WebCore/html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::create):
(WebCore::WebGLBuffer::WebGLBuffer):
* Source/WebCore/html/canvas/WebGLBuffer.h:
* Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::create):
(WebCore::WebGLFramebuffer::createOpaque):
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
* Source/WebCore/html/canvas/WebGLFramebuffer.h:
* Source/WebCore/html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::WebGLObject):
(WebCore::WebGLObject::setObject): Deleted.
* Source/WebCore/html/canvas/WebGLObject.h:
* Source/WebCore/html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::create):
(WebCore::WebGLProgram::WebGLProgram):
* Source/WebCore/html/canvas/WebGLProgram.h:
* Source/WebCore/html/canvas/WebGLQuery.cpp:
(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::WebGLQuery):
* Source/WebCore/html/canvas/WebGLQuery.h:
* Source/WebCore/html/canvas/WebGLRenderbuffer.cpp:
(WebCore::WebGLRenderbuffer::create):
(WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
* Source/WebCore/html/canvas/WebGLRenderbuffer.h:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::createProgram):
* Source/WebCore/html/canvas/WebGLSampler.cpp:
(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::WebGLSampler):
* Source/WebCore/html/canvas/WebGLSampler.h:
* Source/WebCore/html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::create):
(WebCore::WebGLShader::WebGLShader):
* Source/WebCore/html/canvas/WebGLShader.h:
* Source/WebCore/html/canvas/WebGLSync.cpp:
(WebCore::WebGLSync::create):
(WebCore::WebGLSync::WebGLSync):
(WebCore::m_sync):
(WebCore::WebGLSync::deleteObjectImpl):
* Source/WebCore/html/canvas/WebGLSync.h:
* Source/WebCore/html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::create):
(WebCore::WebGLTexture::WebGLTexture):
* Source/WebCore/html/canvas/WebGLTexture.h:
* Source/WebCore/html/canvas/WebGLTimerQueryEXT.cpp:
(WebCore::WebGLTimerQueryEXT::create):
(WebCore::WebGLTimerQueryEXT::WebGLTimerQueryEXT):
* Source/WebCore/html/canvas/WebGLTimerQueryEXT.h:
* Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:
(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
* Source/WebCore/html/canvas/WebGLTransformFeedback.h:
* Source/WebCore/html/canvas/WebG
[webkit-changes] [WebKit/WebKit] 586340: [WPE] Meta gardening API tests for bots: API tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 586340916fef21ba828f1d214e3400a75c9c760a https://github.com/WebKit/WebKit/commit/586340916fef21ba828f1d214e3400a75c9c760a Author: Amanda Falke Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [WPE] Meta gardening API tests for bots: API tests cache, zoom-level Unreviewed test gardening. /webkit/WebKitWebsiteData/cache has been failing in debug and release bots, crashing and failing locally in debug tests, and passing locally in release tests consistently over time. Gardened and filed bug b/260524 with details and initial findings. /webkit/WebKitWebView/zoom-level fails in debug and release bots, and locally for both debug and release tests. Gardened and filed bug b/260535 with details and initial findings. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/267182@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
