[webkit-changes] [WebKit/WebKit] 015533: Remove obsolete SVGPathElement members

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 015533966bd738b8d2392a8ff5f6c92f63ba1085
  
https://github.com/WebKit/WebKit/commit/015533966bd738b8d2392a8ff5f6c92f63ba1085
  Author: Anne van Kesteren 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/svg/SVGPathElement.h
M Source/WebCore/svg/SVGPathElement.idl

  Log Message:
  ---
  Remove obsolete SVGPathElement members
https://bugs.webkit.org/show_bug.cgi?id=200459
rdar://114517026

Reviewed by Said Abou-Hallawa.

Both of these already return null so removing them should be fine. The
remaining two require more work.

* Source/WebCore/svg/SVGPathElement.h:
* Source/WebCore/svg/SVGPathElement.idl:

Canonical link: https://commits.webkit.org/267446@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6086dd: Make URL's protocol setter forbid changing a speci...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6086dd01a4d2685802d4d0e243972dc992b38a90
  
https://github.com/WebKit/WebKit/commit/6086dd01a4d2685802d4d0e243972dc992b38a90
  Author: Anne van Kesteren 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol-expected.txt
M LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html
M 
LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt
M LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
M 
LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_include=file-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_include=file-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.worker-expected.txt
M Source/WTF/wtf/URL.cpp
M Source/WTF/wtf/URLParser.cpp

  Log Message:
  ---
  Make URL's protocol setter forbid changing a special URL to a non-special URL
https://bugs.webkit.org/show_bug.cgi?id=260854
rdar://114624048

Reviewed by Alex Christensen.

Both Chromium and Gecko forbid changing a special URL to a non-special
URL through the protocol setter, although only Chromium does so if the
URL's scheme is "file".

Matching this improves our Interop 2023 score and reduces the number of
differences between engines.

For now we leave changing a non-special URL to a special URL alone as
other browsers continue to have bad non-special URL support.

In order to be able to use URLParser::isSpecialScheme I had to change
URLParser::maybeCanonicalizeScheme to also remove any tab or newline
code points. I suspect that all callers already expect that behavior
from an operation with canonicalize in its name and it used to not
return a string potentially containing whitespace until 261017@main
changed it.

* LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol-expected.txt:
* LayoutTests/fast/dom/DOMURL/set-href-attribute-protocol.html:
* 
LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt:
* LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html:
* LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json:
* LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters-a-area.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_exclude=(file_javascript_mailto)-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any.worker_include=file-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_exclude=(file_javascript_mailto)-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/url-setters.any_include=file-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.js:
(test):
* 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-delete.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.js:
(test):
* 
LayoutTests/imported/w3c/web-platform-tests/url/urlsearchparams-has.any.worker-expected.txt:
* Source/WTF/wtf/URL.cpp:
(WTF::URL::setProtocol):
* Source/WTF/wtf/UR

[webkit-changes] [WebKit/WebKit] a18312: Move off of UIKit SPI: -[UIContextMenuInteraction ...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a183125d0e0a93e8117d4cc129c9dacae103fe07
  
https://github.com/WebKit/WebKit/commit/a183125d0e0a93e8117d4cc129c9dacae103fe07
  Author: Wenson Hsieh 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Move off of UIKit SPI: -[UIContextMenuInteraction 
gestureRecognizerForFailureRelationships]
https://bugs.webkit.org/show_bug.cgi?id=260887
rdar://114330991

Reviewed by Tim Horton.

Use a combination of `-name` and `-view` to identify gestures used to add 
failure requirements for
context menu interactions on `WKContentView`.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:

Remove the now-unused declaration.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _isContextMenuGestureRecognizerForFailureRelationships:]):
(-[WKContentView gestureRecognizer:shouldRequireFailureOfGestureRecognizer:]):
(-[WKContentView gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]):
(-[WKContentView 
deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):

Canonical link: https://commits.webkit.org/267444@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b79cd: [visionOS] Find overlay is missing behind find bar

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b79cd47f0ad395d40922b70a9068c48a1c73c97
  
https://github.com/WebKit/WebKit/commit/8b79cd47f0ad395d40922b70a9068c48a1c73c97
  Author: Aditya Keerthi 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp
M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  [visionOS] Find overlay is missing behind find bar
https://bugs.webkit.org/show_bug.cgi?id=260815
rdar://107376322

Reviewed by Wenson Hsieh.

On visionOS, the find bar appears in the scroll view's inset area. Currently,
WebKit does not display a find overlay in the inset area, as the overlay is
tied to the web content. Specifically, the find overlay is a `PageOverlay` in
the web process, since the overlay must appear behind the highlights (which are
drawn in Web process).

To fix, add another overlay layer to the scroll view, designed to cover the
inset area. The UI process-side overlay is inserted behind the content view, to
avoid a double overlay, while still covering the inset area. Additionally,
the overlay is sized to match the scroll view's bounds, and its position is
adjusted as the scroll view is scrolled, to avoid creating an unnecessarily
large layer. In order to synchronize the animation between the `PageOverlay`
originated layer, and the new UI process-originated layer, existing SPI is
leveraged, and the animation is fully driven from the UI process.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView _frameOrBoundsMayHaveChanged]):
(-[WKWebView _animationForFindOverlay:]):
(-[WKWebView _updateFindOverlayPosition]):

Update the overlay whenever the scroll position or scroll view size changes.

(-[WKWebView _showFindOverlay]):

Some clients may attempt to show an overlay when one is already visible. Handle
that scenario by cancelling any existing animations.

(-[WKWebView _hideFindOverlay]):

Only remove layers after the animation is complete.

(-[WKWebView _didAddLayerForFindOverlay:]):
(-[WKWebView _didRemoveLayerForFindOverlay]):
(-[WKWebView _removeLayerForFindOverlay]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didEndTextSearchOperation): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView didBeginTextSearchOperation]):
(-[WKContentView didEndTextSearchOperation]):
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::didEndTextSearchOperation): Deleted.
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didEndTextSearchOperation): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/267443@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4be308: [Gardening]: rdar://114674858 (REGRESSION (262629@...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4be30896a2f463c46d2999f3ee8571f93ccd5523
  
https://github.com/WebKit/WebKit/commit/4be30896a2f463c46d2999f3ee8571f93ccd5523
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: rdar://114674858 (REGRESSION (262629@main): [ Sonoma wk2 ] 
printing/print-with-media-query-destory.html is a constant failure)
rdar://114674858

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/267442@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6bfbe: Weave the InteractionRegion layers into the conten...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6bfbe1b58219e8ce3d8a546248a62730168ce1c
  
https://github.com/WebKit/WebKit/commit/b6bfbe1b58219e8ce3d8a546248a62730168ce1c
  Author: Etienne Segonzac 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/interaction-region/full-page-overlay-expected.txt
M LayoutTests/interaction-region/full-page-overlay.html
M LayoutTests/interaction-region/interaction-layers-culling-expected.txt
M LayoutTests/interaction-region/layer-tree-expected.txt
M LayoutTests/interaction-region/layer-tree.html
M LayoutTests/interaction-region/overlay-expected.txt
M LayoutTests/interaction-region/position-only-update-expected.txt
M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
M Source/WebCore/page/InteractionRegion.cpp
M Source/WebCore/page/scrolling/ScrollingStateNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateNode.h
M Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNodeCocoa.h
M Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNodeCocoa.mm
M 
Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.h
M 
Source/WebCore/page/scrolling/cocoa/ScrollingTreeOverflowScrollProxyNodeCocoa.mm
M Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.h
M Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.mm
M Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNodeCocoa.h
M Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNodeCocoa.mm
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm

  Log Message:
  ---
  Weave the InteractionRegion layers into the content layer tree
https://bugs.webkit.org/show_bug.cgi?id=260386


Reviewed by Tim Horton.

InteractionRegion layers lived in a "duplicated", always-on-top, layer tree.
This patch merges them back into the content's layer tree. This makes
for an overall lighter tree, but the main goal is to let content layers
partially occlude the glow effects.
When a compositing layer has Interaction Regions, we create and insert an
InteractionRegions container as one of its sublayers. *Positioning is key!*
It's always positioned below the first sublayer that contains other
Interaction Regions.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
(WebKit::applyCommonPropertiesToLayer): Deleted.
(WebKit::applyInteractionRegionsHierarchyUpdate): Deleted.
Remove the "duplicated" layer tree code paths.
(WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
Signal the RemoteLayerTreeNode when an hierarchy update happened.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
Remove the code that was keeping the "duplicated" InteractionRegion layer
tree always on top.

* 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::isAnyInteractionRegionLayer): Deleted.
(WebKit::insertInteractionRegionLayersForLayer): Deleted.
Remove the code that was maintaining the "duplicated" InteractionRegion
layer tree.
(WebKit::updateLayersForInteractionRegions):
Remove the InteractionRegions container from the node when it contains no
Interaction Region.
Re-introduce the HashSet preventing duplicated layers with the same
rect.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
(WebKit::RemoteLayerTreeNode::interactionRegionsLayer const): Deleted.
Rename the node's `interactionRegionsLayer` as
`interactionRegionsContainer`.
Change the API so that it's lazily created when needed.
(WebKit::RemoteLayerTreeNode::hasInteractionRegionsDescendant const):
(WebKit::RemoteLayerTreeNode::setHasInteractionRegionsDescendant):
Introduce a new `hasInteractionRegionsDescendant` flag.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::~RemoteLayerTreeNode):
Remove the InteractionRegions container, if any, in the destructor.
(WebKit::RemoteLayerTreeNode::detachFromParent):
Remove the InteractionRegions container, if any, when detaching.
(WebKit::RemoteLayerTreeNode::initializeLayer):
Set layers as `hitTestsConten

[webkit-changes] [WebKit/WebKit] a33d2c: updateRendering() gets stuck at the wrong framerat...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a33d2c717ecb2870f364d3952bd340b4f54728a7
  
https://github.com/WebKit/WebKit/commit/a33d2c717ecb2870f364d3952bd340b4f54728a7
  Author: Tim Horton 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm

  Log Message:
  ---
  updateRendering() gets stuck at the wrong framerate when thermal throttling 
changes
https://bugs.webkit.org/show_bug.cgi?id=260846
rdar://112799115

Reviewed by Wenson Hsieh and Simon Fraser.

It turns out that `maximumRefreshRate` is actually "the maximum frame rate you 
can
achieve given current throttling behaviors", not "the frame rate of the 
display".
That means that, when throttling states change, maximumRefreshRate can change 
too.

We currently do not respond to changes in maximumRefreshRate. This means that we
can get stuck with an incorrect `maximumRefreshRate` (and 
`preferredFramesPerSecond`,
which is downstream of it).

* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm:
(-[WKDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[WKDisplayLinkHandler invalidate]):
(-[WKDisplayLinkHandler observeValueForKeyPath:ofObject:change:context:]):
(-[WKDisplayLinkHandler didChangeNominalFramesPerSecond]):
When the CADisplayLink's CADisplay's `refreshRate` changes, reconfigure the 
display, which
results in communicating the new maximum frame rate back to WebCore and also 
(indirectly)
updating the CADisplayLink's `preferredFramesPerSecond`.

* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
Add CADisplay SPI.

Canonical link: https://commits.webkit.org/267440@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6845d6: [Gardening]: [ New Test ] (265975@main): [ macOS w...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6845d64faf12490d4cc74d368aa45752de55865e
  
https://github.com/WebKit/WebKit/commit/6845d64faf12490d4cc74d368aa45752de55865e
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: [ New Test ] (265975@main): [ macOS wk1 Ventura+ ] 
media/track/track-user-stylesheet-override.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=260888
rdar://114672159

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/267439@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 375815: html/infrastructure/safe-passing-of-structured-dat...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37581529c158c4dc4e3dbf2f9393c393f0b108bc
  
https://github.com/WebKit/WebKit/commit/37581529c158c4dc4e3dbf2f9393c393f0b108bc
  Author: Chris Dumez 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-and-failure.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/nested-sharedworker-success.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.sharedworker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-coop-coep.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.serviceworker.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-idb.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any.serviceworker.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-failure.https.sub-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-failure.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-iframe-messagechannel.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-messagechannel-success.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure.https-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success.https-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-failure.https.sub-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-iframe-messagechannel.https-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any-expected.txt
M LayoutTests/platform/mac-wk1/TestExpecta

[webkit-changes] [WebKit/WebKit] 610cae: [css-typed-om] Add factory functions for all font ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 610cae50c66f3163e78598bc74bf27c267efbacb
  
https://github.com/WebKit/WebKit/commit/610cae50c66f3163e78598bc74bf27c267efbacb
  Author: Tim Nguyen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length.html
M Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl

  Log Message:
  ---
  [css-typed-om] Add factory functions for all font relative units
https://bugs.webkit.org/show_bug.cgi?id=260760
rdar://114482930

Reviewed by Darin Adler.

Add new font and root font relative lengths to CSSNumericFactory.

Houdini issue: https://github.com/w3c/css-houdini-drafts/issues/1106

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/factory-font-relative-length.html:
 Added.
* Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl:

Canonical link: https://commits.webkit.org/267437@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4cde64: Obscured input fields are not obscured in the keyb...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cde644bbab2419c9590436ba32925208bb90aa6
  
https://github.com/WebKit/WebKit/commit/4cde644bbab2419c9590436ba32925208bb90aa6
  Author: Megan Gardner 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  Obscured input fields are not obscured in the keyboard on visionOS.
https://bugs.webkit.org/show_bug.cgi?id=260838
rdar://113924534

Reviewed by Wenson Hsieh.

We need to look at the flag that is set on input fields that indicates that
they are obscured and use that information to determine if we should
emit all the of text. We started emitting text in
https://github.com/WebKit/WebKit/commit/e1c274e43bdde86eea8fdd34ccc7789fdc279511
so that we would show password in the keyboard field on visionOS,
but if the isAutoFilledAndObscured flag is set, we do not want to display
that information in the keyboard. We look at the start and end of the selected 
range,
and if either one is in an obscured input field, we do not emit all text.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):

Canonical link: https://commits.webkit.org/267436@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c8232: Re-import workers WPT

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c82329db32ed791145d8b7edf1aa6a502b28c96
  
https://github.com/WebKit/WebKit/commit/1c82329db32ed791145d8b7edf1aa6a502b28c96
  Author: Tim Nguyen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
LayoutTests/http/wpt/workers/modules/dedicated-worker-import-csp-expected.txt
M LayoutTests/http/wpt/workers/modules/dedicated-worker-import-csp.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/WorkerNavigator_userAgentData.https.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_cross_origin_security_err-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_cross_origin_security_err.htm
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_dispatchEvent_ErrorEvent-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_dispatchEvent_ErrorEvent.htm
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_script_mimetype-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/Worker_script_mimetype.htm
A 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/SharedWorker-constructor-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/SharedWorker-constructor.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/same-origin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/same-origin.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/SharedWorker/w3c-import.log
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/AbstractWorker.onerror.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/same-origin-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/constructors/Worker/same-origin.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime_local.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime_local.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime_local.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime_local.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/workers/importscripts_mime_local.any.worker.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/navigator/007.js
A 
LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/navigator/008.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/navigator/008.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/navigator/008.worker.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/navigator/w3c-import.log
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-csp.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url-cross-origin.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-data-url.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-failure-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-failure.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-meta-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-meta.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-data-url-cross-origin.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-data-url.window.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-failure-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-failure.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-parse-error-failure.html
M 
LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker.js
M 
LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/002.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platf

[webkit-changes] [WebKit/WebKit] 455220: [Gardening]: New Test (266162@main): [ macOS ] med...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4552204d4d73d48b9d3a3760a0c992d3f093f350
  
https://github.com/WebKit/WebKit/commit/4552204d4d73d48b9d3a3760a0c992d3f093f350
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: New Test (266162@main): [ macOS ] 
media/media-source/media-source-paint-after-display-none.html is a consistent 
crash/failure/timeout.
https://bugs.webkit.org/show_bug.cgi?id=259712
rdar://113233606

Unreviewed test gardening.

Modify test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/267434@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7aea8b: [libpas] PGM Documentation

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7aea8b03c8ef694767d4bde6dba8b0352468432c
  
https://github.com/WebKit/WebKit/commit/7aea8b03c8ef694767d4bde6dba8b0352468432c
  Author: Brandon Stewart 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c
M 
Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h

  Log Message:
  ---
  [libpas] PGM Documentation
https://bugs.webkit.org/show_bug.cgi?id=260882

Reviewed by David Kilzer and Mark Lam.

Clarify how the activation and probabilistic functions work in PGM.
Also, add the documentation on PGM back into the code as it was buried deep
in Phil's Internal explanation and was not super easy to find without searching.

* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_initialize_pgm):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:

Canonical link: https://commits.webkit.org/267433@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 461748: [Gardening]: REGRESSION (259326@main): [ macOS wk1...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46174895dd42f768919b64f0f8851f6b53c51714
  
https://github.com/WebKit/WebKit/commit/46174895dd42f768919b64f0f8851f6b53c51714
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (259326@main): [ macOS wk1 ] 
inspector/timeline/timeline-recording.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=260883
rdar://114665822

Unreviewed test gardening.

Modify test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/267432@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46e9c0: Rename DisplayList::DisplayListItem to DisplayList...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e9c071bff4d625b0d214b50e06c48c5ce542fa
  
https://github.com/WebKit/WebKit/commit/46e9c071bff4d625b0d214b50e06c48c5ce542fa
  Author: Said Abou-Hallawa 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/displaylists/DisplayList.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayList.h
A Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp
A Source/WebCore/platform/graphics/displaylists/DisplayListItem.h
M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h
M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h
M Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h
M Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp

  Log Message:
  ---
  Rename DisplayList::DisplayListItem to DisplayList::Item and move it to a 
separate file
https://bugs.webkit.org/show_bug.cgi?id=260668
rdar://114391530

Reviewed by Kimmo Kinnunen.

Remove the redundancy in the name and create dedicated source and header files
for the DisplayList::Item. Move its existing functions from DisplayListItems.cpp
and DisplayListReplayer.cpp to the new files.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::append):
(WebCore::DisplayList::DisplayList::asText const):
(WebCore::DisplayList::DisplayList::dump const):
* Source/WebCore/platform/graphics/displaylists/DisplayList.h:
(WebCore::DisplayList::DisplayList::items const):
(WebCore::DisplayList::DisplayList::items):
* Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp: Copied 
from Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp.
(WebCore::DisplayList::isValid):
(WebCore::DisplayList::applyImageBufferItem):
(WebCore::DisplayList::applyNativeImageItem):
(WebCore::DisplayList::applySourceImageItem):
(WebCore::DisplayList::applySetStateItem):
(WebCore::DisplayList::applyDrawGlyphs):
(WebCore::DisplayList::applyDrawDecomposedGlyphs):
(WebCore::DisplayList::applyItem):
(WebCore::DisplayList::shouldDumpItem):
(WebCore::DisplayList::dumpItem):
(WebCore::DisplayList::operator<<):
* Source/WebCore/platform/graphics/displaylists/DisplayListItem.h: Added.
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::shouldDumpDisplayListItem): Deleted.
(WebCore::DisplayList::dumpDisplayListItem): Deleted.
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::isValid): Deleted.
(WebCore::DisplayList::operator<<): Deleted.
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
(WebCore::DisplayList::RecorderImpl::append):
* Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::Replayer):
(WebCore::DisplayList::Replayer::replay):
(WebCore::DisplayList::applyImageBufferItem): Deleted.
(WebCore::DisplayList::applyNativeImageItem): Deleted.
(WebCore::DisplayList::applySourceImageItem): Deleted.
(WebCore::DisplayList::applySetStateItem): Deleted.
(WebCore::DisplayList::applyDrawGlyphs): Deleted.
(WebCore::DisplayList::applyDrawDecomposedGlyphs): Deleted.
(WebCore::DisplayList::Replayer::applyItem): Deleted.
* Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h:
* Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267431@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 40fc75: Update test expectations for renamed W3C tests

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40fc75c0fdcd71130944a25cd4b2624174247fca
  
https://github.com/WebKit/WebKit/commit/40fc75c0fdcd71130944a25cd4b2624174247fca
  Author: David Kilzer 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Update test expectations for renamed W3C tests
https://bugs.webkit.org/show_bug.cgi?id=260881


Unreviewed test gardening.

* LayoutTests/TestExpectations:
- Remove old test paths and add bug links to moved tests.
* LayoutTests/platform/mac/TestExpectations:
- Update test that was moved out of the tentative/ folder.

Canonical link: https://commits.webkit.org/267430@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 787859: Deploy more smart pointers in Source/WebKit/UIProc...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 787859b64949f59ccd36f91c0504fbf18523fcba
  
https://github.com/WebKit/WebKit/commit/787859b64949f59ccd36f91c0504fbf18523fcba
  Author: Ryosuke Niwa 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp

  Log Message:
  ---
  Deploy more smart pointers in Source/WebKit/UIProcess/Extensions
https://bugs.webkit.org/show_bug.cgi?id=260845

Reviewed by Brian Weinstein.

Deployed more smart pointers.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::removePermissionMatchPatterns):
(WebKit::WebExtensionContext::addInjectedContent):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::addPage):
(WebKit::WebExtensionController::removePage):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp:
(WebKit::WebExtensionContext::processes const):

Canonical link: https://commits.webkit.org/267429@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d6f0fe: [run-webkit-tests] Surpress exception when termina...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6f0fede47d017f957b83b47e0bbe53464f39a20
  
https://github.com/WebKit/WebKit/commit/d6f0fede47d017f957b83b47e0bbe53464f39a20
  Author: Jonathan Bedard 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  ---
  [run-webkit-tests] Surpress exception when terminating settings app
https://bugs.webkit.org/show_bug.cgi?id=260860
rdar://114626133

Reviewed by Ryan Haddad.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.is_usable): Combine exit codes from starting and stopping 
Settings app.

Canonical link: https://commits.webkit.org/267428@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc1741: Let the compiler generate more operator==() in WTF/

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc1741dbad51fcbfcc7b2a85387c97e29caaa03b
  
https://github.com/WebKit/WebKit/commit/fc1741dbad51fcbfcc7b2a85387c97e29caaa03b
  Author: Chris Dumez 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WTF/wtf/Bag.h
M Source/WTF/wtf/CodePtr.h
M Source/WTF/wtf/CompactPointerTuple.h
M Source/WTF/wtf/CountingLock.h
M Source/WTF/wtf/DateMath.h
M Source/WTF/wtf/FixedBitVector.h
M Source/WTF/wtf/FunctionPtr.h
M Source/WTF/wtf/GenericTimeMixin.h
M Source/WTF/wtf/LikelyDenseUnsignedIntegerSet.h
M Source/WTF/wtf/ListHashSet.h
M Source/WTF/wtf/OptionSet.h
M Source/WTF/wtf/OrderMaker.h
M Source/WTF/wtf/Range.h
M Source/WTF/wtf/RefVector.h
M Source/WTF/wtf/ReferenceWrapperVector.h
M Source/WTF/wtf/Seconds.h
M Source/WTF/wtf/SentinelLinkedList.h
M Source/WTF/wtf/SingleRootGraph.h
M Source/WTF/wtf/TimeWithDynamicClockType.h
M Source/WTF/wtf/UUID.h
M Source/WTF/wtf/UniqueRefVector.h
M Source/WTF/wtf/text/CodePointIterator.h
M Source/WTF/wtf/text/OrdinalNumber.h
M Source/WTF/wtf/text/TextBreakIterator.h
M Source/WTF/wtf/text/TextPosition.h

  Log Message:
  ---
  Let the compiler generate more operator==() in WTF/
https://bugs.webkit.org/show_bug.cgi?id=260840

Reviewed by Alan Baradlay and Darin Adler.

Let the compiler generate more operator==() in WTF/ now that we allow C++20.

* Source/WTF/wtf/Bag.h:
* Source/WTF/wtf/CodePtr.h:
(WTF::CodePtr::operator== const): Deleted.
* Source/WTF/wtf/CompactPointerTuple.h:
* Source/WTF/wtf/CountingLock.h:
* Source/WTF/wtf/DateMath.h:
(WTF::LocalTimeOffset::operator== const): Deleted.
* Source/WTF/wtf/FixedBitVector.h:
(WTF::FixedBitVector::operator== const): Deleted.
* Source/WTF/wtf/FunctionPtr.h:
* Source/WTF/wtf/GenericTimeMixin.h:
(WTF::GenericTimeMixin::operator== const): Deleted.
* Source/WTF/wtf/LikelyDenseUnsignedIntegerSet.h:
(WTF::LikelyDenseUnsignedIntegerSet::iterator::operator== const): Deleted.
* Source/WTF/wtf/ListHashSet.h:
(WTF::ListHashSetIterator::operator== const): Deleted.
* Source/WTF/wtf/OptionSet.h:
(WTF::OptionSet::Iterator::operator== const): Deleted.
(WTF::OptionSet::operator==): Deleted.
* Source/WTF/wtf/OrderMaker.h:
(WTF::OrderMaker::iterator::operator== const): Deleted.
* Source/WTF/wtf/Range.h:
(WTF::Range::operator== const): Deleted.
* Source/WTF/wtf/RefVector.h:
(WTF::RefVectorIterator::operator== const): Deleted.
(WTF::RefVectorConstIterator::operator== const): Deleted.
* Source/WTF/wtf/ReferenceWrapperVector.h:
(WTF::ReferenceWrapperVectorIterator::operator== const): Deleted.
(WTF::ReferenceWrapperVectorConstIterator::operator== const): Deleted.
* Source/WTF/wtf/Seconds.h:
* Source/WTF/wtf/SentinelLinkedList.h:
(WTF::SentinelLinkedList::BaseIterator::operator== const): Deleted.
* Source/WTF/wtf/SingleRootGraph.h:
(WTF::SingleRootGraphNode::operator== const): Deleted.
* Source/WTF/wtf/TimeWithDynamicClockType.h:
* Source/WTF/wtf/UUID.h:
(WTF::UUID::operator== const): Deleted.
* Source/WTF/wtf/UniqueRefVector.h:
(WTF::UniqueRefVectorIterator::operator== const): Deleted.
(WTF::UniqueRefVectorConstIterator::operator== const): Deleted.
* Source/WTF/wtf/text/CodePointIterator.h:
(WTF::CodePointIterator::operator== const): Deleted.
* Source/WTF/wtf/text/OrdinalNumber.h:
(WTF::OrdinalNumber::operator== const): Deleted.
* Source/WTF/wtf/text/TextPosition.h:
(WTF::TextPosition::operator== const): Deleted.

Canonical link: https://commits.webkit.org/267427@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e2ae47: Deploy more smart pointers in Source/WebKit/UIProc...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2ae472c61f4b41fc3a9724afbf0336f3977f940
  
https://github.com/WebKit/WebKit/commit/e2ae472c61f4b41fc3a9724afbf0336f3977f940
  Author: Ryosuke Niwa 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
M Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp
M Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.cpp
M Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h

  Log Message:
  ---
  Deploy more smart pointers in Source/WebKit/UIProcess/
https://bugs.webkit.org/show_bug.cgi?id=260847

Reviewed by Chris Dumez.

Deployed more smart pointers.

* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updatePreferences):
* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::viewBecameInactive):
* Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.cpp:
(WebKit::HighPerformanceGraphicsUsageSampler::timerFired):
* Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h:

Canonical link: https://commits.webkit.org/267426@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] df817d: Include ObjC class name of decode failures in cras...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df817dbe1509e0452f469f5a0b603d2f34ef2ed7
  
https://github.com/WebKit/WebKit/commit/df817dbe1509e0452f469f5a0b603d2f34ef2ed7
  Author: Alex Christensen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm

  Log Message:
  ---
  Include ObjC class name of decode failures in crash logs' register values
https://bugs.webkit.org/show_bug.cgi?id=260871
rdar://114119254

Reviewed by David Kilzer.

Logs in rdar://113527046 indicate something occasionally crashes here, but we 
don't know what.
This will help gather information about what occasionally crashes.

* Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(checkIfClassIsAllowed):

Canonical link: https://commits.webkit.org/267425@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a959ac: TransformationMatrix::Recompose() and Decompose() ...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a959acfc6f159ea4ada5c4dd6483170b6d0f
  
https://github.com/WebKit/WebKit/commit/a959acfc6f159ea4ada5c4dd6483170b6d0f
  Author: Matt Woodrow 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp

  Log Message:
  ---
  TransformationMatrix::Recompose() and Decompose() incorrectly transpose 
rotation.
https://bugs.webkit.org/show_bug.cgi?id=220856


Reviewed by Dean Jackson.

The computation of quaternions during matrix decomposition appeared
to be based off of the matrix transpose. Indexing in the quaternion
calculation is consistent with row-major ordering; however, the "rows"
variable is actually column major order (goes back to the original
implementation of unmatrix in Graphics Gems II).  The rotation matrix
constructed from the quaternions also appeared to be assuming row-major
ordering. These discrepancies were mostly corrected for by flipping the
direction of the quaternion when extracting from the matrix.

This is a (partial) cherry-pick from Blink:
  - https://chromium-review.googlesource.com/c/chromium/src/+/2489727

* Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose4):
(WebCore::slerp):
(WebCore::accumulateQuaternion):
(WebCore::TransformationMatrix::recompose4):

Canonical link: https://commits.webkit.org/267424@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 616b80: Deploy more smart pointers in DownloadProxy and Do...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 616b80d26c47d65020839c1912717feacd899e75
  
https://github.com/WebKit/WebKit/commit/616b80d26c47d65020839c1912717feacd899e75
  Author: Ryosuke Niwa 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h

  Log Message:
  ---
  Deploy more smart pointers in DownloadProxy and DownloadProxyMap
https://bugs.webkit.org/show_bug.cgi?id=260844

Reviewed by Chris Dumez.

Deployed more smart pointers.

* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::willSendRequest):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::protectedProcess):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::invalidate):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h:

Canonical link: https://commits.webkit.org/267423@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 491458: WebGL DEPTH and STENCIL_ATTACHMENT overwrite delet...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 491458f894ee187a16daa0824656b2752ce614a6
  
https://github.com/WebKit/WebKit/commit/491458f894ee187a16daa0824656b2752ce614a6
  Author: Kimmo Kinnunen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
LayoutTests/webgl/resources/webgl_test_files/conformance2/renderbuffers/framebuffer-object-attachment.html
M Source/WebCore/html/canvas/WebGLFramebuffer.cpp
M Source/WebCore/html/canvas/WebGLFramebuffer.h
M Source/WebCore/html/canvas/WebGLObject.cpp
M Source/WebCore/html/canvas/WebGLObject.h

  Log Message:
  ---
  WebGL DEPTH and STENCIL_ATTACHMENT overwrite deletes DEPTH_STENCIL_ATTACHMENT 
object prematurely
https://bugs.webkit.org/show_bug.cgi?id=260606
rdar://problem/114317226

Reviewed by Dan Glastonbury.

In WebGL2, DEPTH_STENCIL_ATTACHMENT attachment point is simulated
and changes DEPTH_ATTACHMENT and STENCIL_ATTACHMENT.
WebGLFramebuffer would store the attachment to
 - DEPTH_STENCIL_ATTACHMENT
 - DEPTH_ATTACHMENT
 - STENCIL_ATTACHMENT
However, it would call onAttached() only for the first one.
If the attachments would be modified with DEPTH_ATTACHMENT
or STENCIL_ATTACHMENT, the modification would result in
onDetached for these modifications. This imbalance of attach/detach
would leave the attachment counters inconsistent.

The bug would be observable when attaching a renderbuffer or texture and
then deleting it (orphaning). In this case the imbalanced detach would
delete the object, and queries about the object name through the framebuffer
attachment point would return "not found", since the object was really
deleted and not only orphaned.

* 
LayoutTests/webgl/resources/webgl_test_files/conformance2/renderbuffers/framebuffer-object-attachment.html:
This will be upstreamed to the CTS later.
Test that DEPTH_STENCIL_ATTACHMENT behavior with normal buffers are
the same as with orphaned buffers.

* Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentInternal):
(WebCore::WebGLFramebuffer::removeAttachmentInternal):
(WebCore::WebGLFramebuffer::hasStencilBuffer const): Deleted.
Delete unused function.

* Source/WebCore/html/canvas/WebGLFramebuffer.h:
* Source/WebCore/html/canvas/WebGLObject.cpp:
(WebCore::WebGLObject::onDetached):
(WebCore::WebGLObject::detach): Deleted.
Delete unused function.

* Source/WebCore/html/canvas/WebGLObject.h:

Canonical link: https://commits.webkit.org/267422@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 48fb05: [CSS Container Queries] Container for ::part pseud...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48fb05f652fabe37e6b455c8c06d6b680f808b98
  
https://github.com/WebKit/WebKit/commit/48fb05f652fabe37e6b455c8c06d6b680f808b98
  Author: Antti Koivisto 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt
M Source/WebCore/style/ContainerQueryEvaluator.cpp
M Source/WebCore/style/ContainerQueryEvaluator.h
M Source/WebCore/style/ElementRuleCollector.cpp
M Source/WebCore/style/ElementRuleCollector.h

  Log Message:
  ---
  [CSS Container Queries] Container for ::part pseudo-element should be 
selected from originating element tree
https://bugs.webkit.org/show_bug.cgi?id=260861
rdar://114626579

Reviewed by Alan Baradlay.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt:
* Source/WebCore/style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::selectContainer):

Add separate selection mode for ::part pseudo-element where we never look for 
container in the current tree.

* Source/WebCore/style/ContainerQueryEvaluator.h:
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::matchPartPseudoElementRulesForScope):

Pass a bit via MatchRequest to indicate we are matching ::part pseudo-elements.

(WebCore::Style::ElementRuleCollector::containerQueriesMatch):
* Source/WebCore/style/ElementRuleCollector.h:

Canonical link: https://commits.webkit.org/267421@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e69358: WebCore\DerivedSources\JSReadableStreamSource.cpp:...

[Ian]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e693585f93abd942ea70668feb1ca483234b25b9
  
https://github.com/WebKit/WebKit/commit/e693585f93abd942ea70668feb1ca483234b25b9
  Author: Ian Grunert 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WTF/wtf/Compiler.h

  Log Message:
  ---
  WebCore\DerivedSources\JSReadableStreamSource.cpp: warning: unused function 
'jsReadableStreamSource_controller'
https://bugs.webkit.org/show_bug.cgi?id=260376

Reviewed by Fujii Hironori.

Emit UNUSED_PARAM for the attributeGetterName to prevent compiler
warning in clang-cl.

* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterTrampolineDefinition):

Canonical link: https://commits.webkit.org/267420@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5ea662: [Gardening]: REGRESSION (265657@main): [ macOS Ven...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ea6622ba41a32817ff2e01ba888d62ca466cbc7
  
https://github.com/WebKit/WebKit/commit/5ea6622ba41a32817ff2e01ba888d62ca466cbc7
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (265657@main): [ macOS Ventura+ ] 
imported/w3c/web-platform-tests/svg/import/metadata-example-01-t-manual.svg is 
a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=260870
rdar://114649622

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/267419@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 779cc0: [GStreamer] Document the mess that is MediaPlayerP...

[Alicia Boya García]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 779cc0077bb016c05b1869181c0166e1a8fe5ae9
  
https://github.com/WebKit/WebKit/commit/779cc0077bb016c05b1869181c0166e1a8fe5ae9
  Author: Alicia Boya Garcia 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

  Log Message:
  ---
  [GStreamer] Document the mess that is MediaPlayerPrivateGStreamer::m_isPaused
https://bugs.webkit.org/show_bug.cgi?id=260385

Reviewed by Xabier Rodriguez-Calvar.

Documentation patch, adding a FIXME for known issues.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Canonical link: https://commits.webkit.org/267418@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 609a27: [GStreamer] Fix build without USE(GSTREAMER_GL)

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 609a277690c890f5c19930966198329507c12801
  
https://github.com/WebKit/WebKit/commit/609a277690c890f5c19930966198329507c12801
  Author: Olivier Blin 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Fix build without USE(GSTREAMER_GL)
https://bugs.webkit.org/show_bug.cgi?id=260786

Reviewed by Philippe Normand.

PlatformDisplayGStreamer was conditionally built for USE(GSTREAMER_GL)
before the GStreamer sources unification in 264829@main, it needs to
be guarded.

* Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:

Canonical link: https://commits.webkit.org/267417@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f5059: [motion-path] Refactor various parts of path opera...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f5059d542cf81542755719fab60d75462d24768
  
https://github.com/WebKit/WebKit/commit/3f5059d542cf81542755719fab60d75462d24768
  Author: Nikolaos Mouchtaris 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp
A Source/WebCore/rendering/MotionPath.cpp
A Source/WebCore/rendering/MotionPath.h
M Source/WebCore/rendering/PathOperation.cpp
M Source/WebCore/rendering/PathOperation.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/svg/SVGGraphicsElement.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  [motion-path] Refactor various parts of path operation and RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=260818
rdar://114584136

Reviewed by Simon Fraser.

This refactoring addresses a few issues with the current motion path design. 
First,
for paths that need additional data including its containing block rect or the 
element's
offset from its containing block, it is not correct to use the path operation 
to hold
these values, as the path operation is supposed to represent just the path 
specified by the
css. Instead, pass down these necessary values through a TransformOperationData 
struct.
Also added a test for this case to ensure that style sharing is not broken 
after this change.
Also, factor out some of the code related to computing the ray path into the 
new MotionPath
class, which now also includes applyMotionPathTransform.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html:
 Added.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeTransformedExtentViaMatrix const):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computedTransform):
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/rendering/PathOperation.cpp:
(WebCore::RayPathOperation::create):
(WebCore::RayPathOperation::clone const):
(WebCore::RayPathOperation::getPath const):
(WebCore::RayPathOperation::lengthForPath const): Deleted.
(WebCore::RayPathOperation::lengthForContainPath const): Deleted.
* Source/WebCore/rendering/PathOperation.h:
(WebCore::PathOperation::getPath): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::applyTransform const):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateTransform):
(WebCore::RenderLayer::setReferenceBoxForPathOperations): Deleted.
* Source/WebCore/rendering/RenderLayer.h:
* Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::applySVGTransform const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform const):
(WebCore::RenderStyle::applyCSSTransform const):
(WebCore::getTraversalStateAtDistance): Deleted.
(WebCore::RenderStyle::applyMotionPathTransform const): Deleted.
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/267416@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb4faa: python autoinstaller is broken with python 3.12

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb4faa2a3ee38601f41c1d60fcac002a83cec4ff
  
https://github.com/WebKit/WebKit/commit/cb4faa2a3ee38601f41c1d60fcac002a83cec4ff
  Author: Michael Catanzaro 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py

  Log Message:
  ---
  python autoinstaller is broken with python 3.12
https://bugs.webkit.org/show_bug.cgi?id=260726

Reviewed by Jonathan Bedard.

Currently git-webkit is broken with python 3.12 due to various problems
with dependencies that are already fixed in newer upstream versions. So,
update a few things.

Unfortunately, the newer library versions are incompatible with other
Python versions, so this means more conditional versions.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:

Canonical link: https://commits.webkit.org/267415@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cfd564: [WPE] Bump internal Cog commit

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfd564becff8fafc7101926efcb65c35b9360762
  
https://github.com/WebKit/WebKit/commit/cfd564becff8fafc7101926efcb65c35b9360762
  Author: Philippe Normand 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/PlatformWPE.cmake

  Log Message:
  ---
  [WPE] Bump internal Cog commit
https://bugs.webkit.org/show_bug.cgi?id=260849

Reviewed by Michael Catanzaro.

The list of changes since the previous version is:
9e2dc0a launcher: Add command-line option for controlling autoplay behavior
7a33249 drm: Fix logic error in indexing when using find_crtc_for_encoder
95d0aaf Update platform/drm/cog-platform-drm.c
689e7a6 Update platform/drm/cog-platform-drm.c
47dee03 drm: Fix crash on imx6 when no current encoder+crtc is bound
51e0951 gtk4: Prefix a scheme if none provided
7489ca5 Meson: check file sys/mman.h in order to define HAVE_MEMFD_CREATE
705e46d Fix maybe-uninitialized warning
5976f59 launcher: Handle GApplication::activate
da64b4a Add support for weston 13 protocols
7a60bda launcher: Add CLI flag to disable built-in key bindings
48fdd6e Fix compilation warning in i386
7b7c10b core: Move key binding handling into CogView
0606be4 launcher: Remove handling of plain WPE backends
7eb8ffb core: Add a fallback CogPlatform implementation
9001a8d core: Introduce a new CogView class
023fbb0 wl: fix blurry rendering in some compositors
f8ae0e6 core: Add missing underscore to environment variable names
0a9405c core: Move platform selection logic into the library
8e1acd3 webkit-utils: Check if the media engine will show the resource
c51d94e headless: Move frame tick source to platform object
a6d2321 launcher: Simplify by using global CogPlatform
9df4a77 drm: ignore key event if no xkb context is available
af5789c docs: Fix gi-docgen wrong type for GKeyFile warning

* Tools/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/267414@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a76f3: [Gardening]: [ macOS wk2 arm64 ] fast/scrolling/ma...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a76f3fb4ec96341d493fe700824027574fc2fea
  
https://github.com/WebKit/WebKit/commit/4a76f3fb4ec96341d493fe700824027574fc2fea
  Author: Ben Schwartz 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ macOS wk2 arm64 ] 
fast/scrolling/mac/adjust-scroll-snap-during-gesture.html is a flaky failure
rdar://92127014
https://bugs.webkit.org/show_bug.cgi?id=239627

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/267413@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 281b7e: [Gardening]: REGRESSION(267279@main): [ macOS wk2 ...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 281b7e80b1ea43c6ebce6ee8a9e543940cd53c71
  
https://github.com/WebKit/WebKit/commit/281b7e80b1ea43c6ebce6ee8a9e543940cd53c71
  Author: Ben Schwartz 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(267279@main): [ macOS wk2 ] 
fast/canvas/webgl/texImage2D-mse-flipY-false.html is a consistent text failure.
rdar://114642707
https://bugs.webkit.org/show_bug.cgi?id=260867

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/267412@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83db13: [CSS] @font-palette-values family-name supports mu...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83db139305cad9bc26aae1844c44a43b12e5d986
  
https://github.com/WebKit/WebKit/commit/83db139305cad9bc26aae1844c44a43b12e5d986
  Author: Matthieu Dubet 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt
M Source/WebCore/css/CSSFontPaletteValuesRule.cpp
M Source/WebCore/css/CSSFontSelector.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/StyleRule.h
M Source/WebCore/css/parser/CSSParserImpl.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h

  Log Message:
  ---
  [CSS] @font-palette-values family-name supports multiple values
https://bugs.webkit.org/show_bug.cgi?id=252569
rdar://105975619

Reviewed by Tim Nguyen.

This patch allows @font-palette-values family-name descriptor to have
a list of family names (per spec).

https://drafts.csswg.org/css-fonts-4/#family-name-syntax

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36-ref.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-palette-36.html: 
Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid-expected.txt:
* Source/WebCore/css/CSSFontPaletteValuesRule.cpp:
(WebCore::CSSFontPaletteValuesRule::fontFamily const):
(WebCore::CSSFontPaletteValuesRule::cssText const):
(WebCore::CSSFontPaletteValuesRule::~CSSFontPaletteValuesRule): Deleted.
* Source/WebCore/css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontPaletteValuesRule):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleFontPaletteValues::create):
(WebCore::StyleRuleFontPaletteValues::StyleRuleFontPaletteValues):
* Source/WebCore/css/StyleRule.h:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeFontFeatureValuesRule):
(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFamilyNameListRaw):
(WebCore::CSSPropertyParserHelpers::consumeFamilyNameList):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:

Canonical link: https://commits.webkit.org/267411@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f57745: Reland 267124@main: Refactor mouse and keyboard ha...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f577450e9d1eee5c221c223ccb95fc00f9c7dcc5
  
https://github.com/WebKit/WebKit/commit/f577450e9d1eee5c221c223ccb95fc00f9c7dcc5
  Author: Charlie Wolfe 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  Reland 267124@main: Refactor mouse and keyboard handling in the web process 
to be frame specific
https://bugs.webkit.org/show_bug.cgi?id=260821
rdar://114586213

Reviewed by Alex Christensen.

Reland 267124@main after fixing mouse events on Windows and rebasing after 
267293@main.

This change was initially incorrectly calling 
WebFrame::handleContextMenuEvent() instead
of EventHandler::sendContextMenuEvent().

Also added a mainFrame null check on WebPageProxy::handleMouseEvent() since the 
same null
check was added to WebPageProxy::processNextQueuedMouseEvent().

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::dispatchWheelEventWithoutScrolling):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyContextMenuAtPointInWindow):
* Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::dispatchWheelEvent):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::isContextClick):
(WebKit::WebFrame::handleContextMenuEvent):
(WebKit::WebFrame::handleMouseEvent):
(WebKit::WebFrame::handleKeyEvent):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextMenuAtPointInWindow):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::handleWheelEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::dispatchWheelEventWithoutScrolling):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::simulateMouseDown):
(WebKit::WebPage::simulateMouseUp):
(WebKit::WebPage::simulateMouseMotion):
(WebKit::isContextClick): Deleted.
(WebKit::handleContextMenuEvent): Deleted.
(WebKit::handleMouseEvent): Deleted.
(WebKit::handleKeyEvent): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/267410@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e7fc91: Adjust webkitcorepy changes to match changes on ma...

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: e7fc913c06a2cda779749ccb09742214388d4c1a
  
https://github.com/WebKit/WebKit/commit/e7fc913c06a2cda779749ccb09742214388d4c1a
  Author: Michael Catanzaro 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py

  Log Message:
  ---
  Adjust webkitcorepy changes to match changes on main branch

This syncs 2.42 branch with https://github.com/WebKit/WebKit/pull/17076

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:

Canonical link: https://commits.webkit.org/266719.27@webkitglib/2.42


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5aaf70: Cherry-pick 260527.430@eng/2.40-WPE-Fix-build-with...

[Olivier Blin]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: 5aaf70fede8acf290deea468a4e45de77c691341
  
https://github.com/WebKit/WebKit/commit/5aaf70fede8acf290deea468a4e45de77c691341
  Author: Olivier Blin 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/cmake/OptionsWPE.cmake

  Log Message:
  ---
  Cherry-pick 260527.430@eng/2.40-WPE-Fix-build-without-USE-GBM (5375e5bb05a7). 


[WPE] Fix build without USE(GBM)

Reviewed by Michael Catanzaro.

There was a USE_GBM leftover, while it is now a conditional option.

Cherry-picks 263069@main ("[GTK][WPE] Unify USE(GBM) and USE(LIBGBM)")
and 263491@main ("[WPE] Make libgbm and libdrm conditional dependencies")
have been applied in a different order than in main branch.

Canonical link: https://commits.webkit.org/260527.430@webkitglib/2.40

Canonical link: https://commits.webkit.org/260527.431@webkitglib/2.40


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f8bf4f: python autoinstaller is broken with python 3.12

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.40
  Home:   https://github.com/WebKit/WebKit
  Commit: f8bf4f0e316b81b8197ed17e1f85eda838a836bb
  
https://github.com/WebKit/WebKit/commit/f8bf4f0e316b81b8197ed17e1f85eda838a836bb
  Author: Michael Catanzaro 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py

  Log Message:
  ---
  python autoinstaller is broken with python 3.12
https://bugs.webkit.org/show_bug.cgi?id=260726

Reviewed by NOBODY (OOPS!).

Currently git-webkit is broken with python 3.12 due to various problems
with dependencies that are already fixed in newer upstream versions. So,
update a few things.

Unfortunately, the newer library versions are incompatible with other
Python versions, so this means more conditional versions.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:

Canonical link: https://commits.webkit.org/260527.430@webkitglib/2.40


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f045b: [git-webkit] Correctly parse EWS data in PR body

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f045b69d7e04e7acf9f0ebef9b8c2ab9106ea6d
  
https://github.com/WebKit/WebKit/commit/9f045b69d7e04e7acf9f0ebef9b8c2ab9106ea6d
  Author: Jonathan Bedard 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py
M 
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py

  Log Message:
  ---
  [git-webkit] Correctly parse EWS data in PR body
https://bugs.webkit.org/show_bug.cgi?id=260831
rdar://114593055

Reviewed by Aakash Jain.

Exclude EWS data when parsing PR bodies.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
(PullRequest): Expand regexes to match EWS data.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/267409@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4e9bc: Add IDL skeleton for WebTransport

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4e9bc6fb756d57c2e3bad540d3330aa7d45fd19
  
https://github.com/WebKit/WebKit/commit/a4e9bc6fb756d57c2e3bad540d3330aa7d45fd19
  Author: Alex Christensen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/imported/w3c/web-platform-tests/webtransport/META.yml
A LayoutTests/imported/w3c/web-platform-tests/webtransport/README.md
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection-ccns.https.tentative.window-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection-ccns.https.tentative.window.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection-ccns.https.tentative.window.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection.https.window-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection.https.window.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-closed-webtransport-connection.https.window.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection-ccns.https.tentative.window-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection-ccns.https.tentative.window.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection-ccns.https.tentative.window.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection.https.window-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection.https.window.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/back-forward-cache-with-open-webtransport-connection.https.window.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/bidirectional-cancel-crash.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/bidirectional-cancel-crash.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.serviceworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/close.https.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.serviceworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/connect.https.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.serviceworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.serviceworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.sharedworker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.sharedworker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webtransport/constructor.https.any.worker-expected.txt

[webkit-changes] [WebKit/WebKit] 443d49: [IFC] LayoutState::destroyBlock/InlineFormattingSt...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 443d49efd65f29752d18b140d9272894030e523e
  
https://github.com/WebKit/WebKit/commit/443d49efd65f29752d18b140d9272894030e523e
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/layout/LayoutState.cpp

  Log Message:
  ---
  [IFC] LayoutState::destroyBlock/InlineFormattingState functions use the wrong 
map
https://bugs.webkit.org/show_bug.cgi?id=260862

Reviewed by Antti Koivisto.

* Source/WebCore/layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::destroyBlockFormattingState):
(WebCore::Layout::LayoutState::destroyInlineFormattingState):

Canonical link: https://commits.webkit.org/267407@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ed26b: Revert [267386@main] [Gardening]: REGRESSION: [ So...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ed26b91e481dcec2159ed691ccf6a1042e2bad4
  
https://github.com/WebKit/WebKit/commit/3ed26b91e481dcec2159ed691ccf6a1042e2bad4
  Author: Karl Rackler 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
R 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt
R 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt
R 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt
R 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt
R 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt
R 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt

  Log Message:
  ---
  Revert [267386@main] [Gardening]: REGRESSION: [ Sonoma wk1 ] 3 
compositing/repaint/iframes/compositing-iframe tests are a consistent failure
rdar://114098037

Unreviewed revert

This reverts because is caused the tests to constantly fail.

* 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
 Removed.
* 
LayoutTests/platform/mac-ventura-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
 Removed.
* 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt:
 Removed.
* 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt:
 Removed.
* 
LayoutTests/platform/mac/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/267406@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d1c532: SharedWorker referrer policy should default to its...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1c532b691d6db1eadb2cf717c22e25e943b0506
  
https://github.com/WebKit/WebKit/commit/d1c532b691d6db1eadb2cf717c22e25e943b0506
  Author: Youenn Fablet 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt
M Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp

  Log Message:
  ---
  SharedWorker referrer policy should default to its context referrer policy if 
none is provided in its script http response
https://bugs.webkit.org/show_bug.cgi?id=260858
rdar://114625126

Reviewed by Chris Dumez.

As per https://github.com/w3c/webappsec-referrer-policy, we should default to 
the context initiating the first load as of referrer policy.
Implement this for SharedWorker in SharedWorkerScriptLoader.

* 
LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-referrer-expected.txt:
* Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):

Canonical link: https://commits.webkit.org/267405@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8124fd: [Tools][GTK][WPE] Add missing 'mesa-common-dev' de...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8124fd9a748e43f40956b338fc58f132d145bfab
  
https://github.com/WebKit/WebKit/commit/8124fd9a748e43f40956b338fc58f132d145bfab
  Author: Diego Pino Garcia 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Tools/Scripts/generate-bundle
M Tools/glib/dependencies/apt

  Log Message:
  ---
  [Tools][GTK][WPE] Add missing 'mesa-common-dev' dependency
https://bugs.webkit.org/show_bug.cgi?id=260496

Reviewed by Carlos Alberto Lopez Perez.

267186@main requires dri.pkg but this file is only available if
'mesa-common-dev' is installed.

Besides, Debian 12 reported a runtime error because the file
'dri.pkg' no longer defines the variable 'libdir'. In case 'libdir' doesn't
exist, set 'libdir' to the parent dir of 'dridriverdir' fixes the issue.

* Tools/Scripts/generate-bundle:
* Tools/glib/dependencies/apt:

Canonical link: https://commits.webkit.org/267404@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f4520: Resync WPT WebCodec tests up to 1a42a93

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f452076307266fc0ecfae2d0828ea2eb176af79
  
https://github.com/WebKit/WebKit/commit/5f452076307266fc0ecfae2d0828ea2eb176af79
  Author: Youenn Fablet 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/encodedVideoChunk-serialization.crossAgentCluster.helper.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/encodedVideoChunk-serialization.crossAgentCluster.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/encodedVideoChunk-serialization.crossAgentCluster.https.html
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/per-frame-qp-encoding.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/serialization.crossAgentCluster.serviceworker.js
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/utils.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_baseline-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_high-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_main-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_baseline-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_high-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_main-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.serviceworker.js
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log
M LayoutTests/platform/glib/TestExpectations
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_baseline-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_high-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any.worker_main-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_baseline-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_high-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-h264.https.any_main-expected.txt

  Log Message:
  ---
  Resync WPT WebCodec tests up to 1a42a93
https://bugs.webkit.org/show_bug.cgi?id=260710
rdar://114446894

Reviewed by Tim Nguyen.

Resyncing tests.
Rebasing some expectations and marking some tests as pass/fail in glib 
(probably needs rebasing).

* LayoutTests/imported/w3c/resources/resource-files.json:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js:
(validButUnsupportedConfigs.forEach.entry.promise_test.async t):
(validConfigs.forEach.config.promise_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/encoded

[webkit-changes] [WebKit/WebKit] a0de58: [IFC] Pass in ConstraintsForInlineContent to both ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0de58ae0af19178325e728b6c7022b4c2b4a76a
  
https://github.com/WebKit/WebKit/commit/a0de58ae0af19178325e728b6c7022b4c2b4a76a
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h

  Log Message:
  ---
  [IFC] Pass in ConstraintsForInlineContent to both display line and box 
builders
https://bugs.webkit.org/show_bug.cgi?id=260811

Reviewed by Antti Koivisto.

This is in preparation for static position out-of-flow content where the 
containing block
start (ignoring intrusive floats etc) is the start position for certain type of 
out-of-flow boxes.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLine):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::InlineDisplayContentBuilder):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
(WebCore::Layout::InlineDisplayContentBuilder::constraints const):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::InlineDisplayLineBuilder):
(WebCore::Layout::InlineDisplayLineBuilder::build const):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h:
(WebCore::Layout::InlineDisplayLineBuilder::constraints const):

Canonical link: https://commits.webkit.org/267402@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 506eeb: [IFC] Add Line::Run::isContentfulOrHasDecoration

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 506eebf66fe61f22a66873261267e3833f5c2b43
  
https://github.com/WebKit/WebKit/commit/506eebf66fe61f22a66873261267e3833f5c2b43
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  ---
  [IFC] Add Line::Run::isContentfulOrHasDecoration
https://bugs.webkit.org/show_bug.cgi?id=260809

Reviewed by Antti Koivisto.

This is in preparation for static position out-of-flow box computation where the
static (logical) vertical position depends on whether the out-of-flow box has a 
previous
sibling with content and/or decoration.
(This also addresses the box-decoration case for spanning line boxes.)

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::lineHasVisuallyNonEmptyContent const):
(WebCore::Layout::Line::Run::isContentfulOrHasDecoration):
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):

Canonical link: https://commits.webkit.org/267401@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e912b8: [IFC] Replaced box behaves like any other inline l...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e912b884f5c73bb246f916ae3c979cea8b4cb27b
  
https://github.com/WebKit/WebKit/commit/e912b884f5c73bb246f916ae3c979cea8b4cb27b
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h

  Log Message:
  ---
  [IFC] Replaced box behaves like any other inline level box as far as Line 
building is concerned
https://bugs.webkit.org/show_bug.cgi?id=260808

Reviewed by Antti Koivisto.

// FIXME: Surely replaced boxes behave differently.
Nope. At least not in the process of line breaking.

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::append):
(WebCore::Layout::Line::appendGenericInlineLevelBox):
(WebCore::Layout::Line::appendNonReplacedInlineLevelBox): Deleted.
(WebCore::Layout::Line::appendReplacedInlineLevelBox): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:

Canonical link: https://commits.webkit.org/267400@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e47e6: REGRESSION(263118@main): [CoordinatedGraphics] Inc...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e47e6d0c366be710c81c8b594d0aa33d1096400
  
https://github.com/WebKit/WebKit/commit/3e47e6d0c366be710c81c8b594d0aa33d1096400
  Author: Carlos Garcia Campos 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h
M Source/WebKit/UIProcess/DrawingAreaProxy.messages.in
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in

  Log Message:
  ---
  REGRESSION(263118@main): [CoordinatedGraphics] Incomplete rendering after 10s 
inactivity without hardware acceleration
https://bugs.webkit.org/show_bug.cgi?id=260505

Reviewed by Michael Catanzaro.

When the backing store is discarded in the UI process we need to notify
the web process to reset the dirty region to the entire web view and
ensure next update is not partial. This avoids flickering and ensures a
full update of the view when a new backing store is created. We should
also avoid flickering when forcing an update, by waiting for the Update
message synchronously.

* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::paint):
(WebKit::DrawingAreaProxyCoordinatedGraphics::forceUpdateIfNeeded):
(WebKit::DrawingAreaProxyCoordinatedGraphics::incorporateUpdate):
(WebKit::DrawingAreaProxyCoordinatedGraphics::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyCoordinatedGraphics::discardBackingStore):
* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:
* Source/WebKit/UIProcess/DrawingAreaProxy.messages.in:
* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updateGeometry):
(WebKit::DrawingAreaCoordinatedGraphics::didDiscardBackingStore):
* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
* Source/WebKit/WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didDiscardBackingStore):
* Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in:

Canonical link: https://commits.webkit.org/267399@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd1a9e: [IFC] Let text content hyphenate even when there's...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd1a9e72db7c12f61da7f6d47e30768e127f9cd9
  
https://github.com/WebKit/WebKit/commit/bd1a9e72db7c12f61da7f6d47e30768e127f9cd9
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp

  Log Message:
  ---
  [IFC] Let text content hyphenate even when there's an opaque inline item 
in-between them
https://bugs.webkit.org/show_bug.cgi?id=260806

Reviewed by Antti Koivisto.

It addresses cases like in 
imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-out-of-flow-002.html.

* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::tryHyphenationAcrossOverflowingInlineTextItems
 const):

Canonical link: https://commits.webkit.org/267398@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] da7c3d: [LFC] Add ElementBox::hasOutOfFlowChild

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da7c3de5c71a1013450a77feadb9d4dcaccc1800
  
https://github.com/WebKit/WebKit/commit/da7c3de5c71a1013450a77feadb9d4dcaccc1800
  Author: Alan Baradlay 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/layouttree/LayoutElementBox.cpp
M Source/WebCore/layout/layouttree/LayoutElementBox.h

  Log Message:
  ---
  [LFC] Add ElementBox::hasOutOfFlowChild
https://bugs.webkit.org/show_bug.cgi?id=260805

Reviewed by Antti Koivisto.

This is in preparation for out-of-flow box static position (we need to know if 
the IFC should need to run inflow layout).

* Source/WebCore/layout/layouttree/LayoutElementBox.cpp:
(WebCore::Layout::ElementBox::hasOutOfFlowChild const):
* Source/WebCore/layout/layouttree/LayoutElementBox.h:

Canonical link: https://commits.webkit.org/267397@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 07db15: [GStreamer][WebCodecs] Reduce AudioConverter alloc...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07db15006984734250aa29f30c49170d3ec25a25
  
https://github.com/WebKit/WebKit/commit/07db15006984734250aa29f30c49170d3ec25a25
  Author: Philippe Normand 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebCodecs] Reduce AudioConverter allocations
https://bugs.webkit.org/show_bug.cgi?id=260800

Reviewed by Xabier Rodriguez-Calvar.

It's not un-common to convert a stream of AudioData to another format, for 
instance when the
destination involves WebAudio, so allocate only one converter per 
source-destination format
combination.

* Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp:
(WebCore::getAudioConvertedForFormat):
(WebCore::PlatformRawAudioData::copyTo):

Canonical link: https://commits.webkit.org/267396@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1d0cf3: [WPE][GTK] `WebKitWebsiteData/cache` is crashing i...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d0cf34fdae6143b31c0ce57cee0272c7a55f0d7
  
https://github.com/WebKit/WebKit/commit/1d0cf34fdae6143b31c0ce57cee0272c7a55f0d7
  Author: Vitaly Dyachkov 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp
M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  ---
  [WPE][GTK] `WebKitWebsiteData/cache` is crashing in debug builds
https://bugs.webkit.org/show_bug.cgi?id=260524

Reviewed by Michael Catanzaro.

In `WebProcessProxy::platformGetLaunchOptions()` we evaluate if
`websiteDataStore()` is `NULL`, which is true for prewarmed processes.

But there is an assert in it, so this call will crash in debug builds.

* Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/267395@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7e433: WebGL rendering contexts have redundant framebuffe...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7e4339d34a867f39dad1f7cd37ac46ef5982749
  
https://github.com/WebKit/WebKit/commit/c7e4339d34a867f39dad1f7cd37ac46ef5982749
  Author: Kimmo Kinnunen 
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h

  Log Message:
  ---
  WebGL rendering contexts have redundant framebuffer functions, TexImageSource 
typedef
https://bugs.webkit.org/show_bug.cgi?id=260381
rdar://problem/114072108

Reviewed by Dan Glastonbury.

Remove the unused functions and duplicated TexImageSource typedef.

Move ensureNotNull to a translation unit local free function.

* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getReadFramebufferBinding): Deleted.
(WebCore::WebGL2RenderingContext::restoreCurrentFramebuffer): Deleted.
* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::root):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::ensureNotNull):
(WebCore::root):
(WebCore::WebGLRenderingContextBase::getReadFramebufferBinding): Deleted.
(WebCore::WebGLRenderingContextBase::ensureNotNull const): Deleted.
(WebCore::WebGLRenderingContextBase::enableOrDisable): Deleted.
(WebCore::WebGLRenderingContextBase::restoreCurrentFramebuffer): Deleted.
(WebCore::WebGLRenderingContextBase::restoreCurrentTexture2D): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: https://commits.webkit.org/267394@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes