[webkit-changes] [WebKit/WebKit] 643f0a: Align const member functions of CheckedRef/Checked...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 643f0a10c60b19057c260f790290b9d56ecb7de1 https://github.com/WebKit/WebKit/commit/643f0a10c60b19057c260f790290b9d56ecb7de1 Author: Ryosuke Niwa Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/wtf/CheckedPtr.h M Source/WTF/wtf/CheckedRef.h Log Message: --- Align const member functions of CheckedRef/CheckedPtr with Ref/RefPtr https://bugs.webkit.org/show_bug.cgi?id=261001 Reviewed by Chris Dumez. Make const members of CheckedRef/CheckedPtr return mutable T&/T* instead of const T/&T* to match the corresponding functions in Ref/RefPtr. * Source/WTF/wtf/CheckedPtr.h: (WTF::CheckedPtr::operator bool const): (WTF::CheckedPtr::operator! const): Deleted. (WTF::CheckedPtr::get const): (WTF::CheckedPtr::get): Deleted. (WTF::CheckedPtr::operator* const): (WTF::CheckedPtr::operator*): Deleted. (WTF::CheckedPtr::operator-> const): (WTF::CheckedPtr::operator->): Deleted. * Source/WTF/wtf/CheckedRef.h: (WTF::CheckedRef::ptr const): (WTF::CheckedRef::ptr): Deleted. (WTF::CheckedRef::get const): (WTF::CheckedRef::get): Deleted. (WTF::CheckedRef::operator-> const): (WTF::CheckedRef::operator->): Deleted. (WTF::CheckedRef::operator T& const): (WTF::CheckedRef::operator const T& const): Deleted. (WTF::CheckedRef::operator bool const): (WTF::CheckedRef::operator! const): Deleted. (WTF::CheckedRef::operator T&): Deleted. Canonical link: https://commits.webkit.org/267543@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b332b3: [CMake] rewrite-compile-commands reports a lot of ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b332b310db505e67e0cc8561fcdb47bd3117b79a https://github.com/WebKit/WebKit/commit/b332b310db505e67e0cc8561fcdb47bd3117b79a Author: Fujii Hironori Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Tools/Scripts/rewrite-compile-commands Log Message: --- [CMake] rewrite-compile-commands reports a lot of warning messages "Failed to find ..." https://bugs.webkit.org/show_bug.cgi?id=260841 Reviewed by Don Olmstead. rewrite-compile-commands scripts reported a lot of warning messages of missing derived sources for the build-webkit first invocation. We don't have a nice solution yet. And, derived sources don't have to be included in compile_commands.json because we don't directly edit them. Let's just ignore the missing derived sources at the moment. * Tools/Scripts/rewrite-compile-commands: Canonical link: https://commits.webkit.org/267542@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6566fb: [Fast text codepath] CharactersTreatedAsSpace is o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6566fb8f9216aae136892c5f32e6e50367de2969 https://github.com/WebKit/WebKit/commit/6566fb8f9216aae136892c5f32e6e50367de2969 Author: Myles C. Maxfield Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/ios/tables/layering/paint-test-layering-1-expected.txt M LayoutTests/platform/ios/tables/layering/paint-test-layering-2-expected.txt M LayoutTests/platform/ios/tables/mozilla/bugs/bug4427-expected.txt M LayoutTests/platform/ios/tables/mozilla_expected_failures/other/test4-expected.txt M Source/WebCore/platform/graphics/WidthIterator.cpp Log Message: --- [Fast text codepath] CharactersTreatedAsSpace is overly prescriptive https://bugs.webkit.org/show_bug.cgi?id=260843 rdar://114607926 Reviewed by Cameron McCormack. When we lay out web content, we make multiple passes over the text, chopping it up multiple different ways. Because of this, we have an invariant that the width of a space can't change depending on the bounds of how we're chopping up the text. Kerning can affect the width of a space, so we enforce the invariant by having a postprocess that we perform after shaping to retroactively go back and adjust the width of any glyphs associated with space characters, to reset their widths. This is called "CharactersTreatedAsSpace." However, CharactersTreatedAsSpace actually does something else, too: it also adjusts the width of the character directly before the space to be whatever it was before shaping. However, this is kind of bogus - it's totally valid for shaping to adjust the width of whichever character happens to be before the space. Now that we're trying to make the fast text codepath handle complex character clusters, we're hitting the case more often where shaping is adjusting the non-space glyphs to be correct, but then our postprocess is coming along and messing them up. This patch removes that logic, just for the glyphs before the space characters. The logic about trying to reset the space characters' width is still there. * Source/WebCore/platform/graphics/WidthIterator.cpp: (WebCore::OriginalAdvancesForCharacterTreatedAsSpace::OriginalAdvancesForCharacterTreatedAsSpace): (WebCore::WidthIterator::applyFontTransforms): (WebCore::WidthIterator::advanceInternal): Canonical link: https://commits.webkit.org/267541@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19378f: [css-fonts] Implement `font-variant-emoji` CSS pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19378f7d7d7dc8af96607511ee1cf490ae4ae404 https://github.com/WebKit/WebKit/commit/19378f7d7d7dc8af96607511ee1cf490ae4ae404 Author: Tim Nguyen Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/css/font-property-priority-expected.txt M LayoutTests/fast/css/font-shorthand-expected.txt M LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-serialization-prevention-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-subproperties-reset-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-emoji-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-emoji-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/font-shorthand-serialization-expected.txt M LayoutTests/imported/w3c/web-platform-tests/editing/run/removeformat-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/CSSValueKeywords.in M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/ShorthandSerializer.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/platform/graphics/FontCascade.cpp M Source/WebCore/platform/graphics/FontCascadeCache.h M Source/WebCore/platform/graphics/FontCascadeDescription.h M Source/WebCore/platform/graphics/FontDescription.cpp M Source/WebCore/platform/graphics/FontDescription.h M Source/WebCore/platform/text/TextFlags.h Log Message: --- [css-fonts] Implement `font-variant-emoji` CSS property https://bugs.webkit.org/show_bug.cgi?id=246911 rdar://101722745 Reviewed by Myles C. Maxfield. This builds off existing code that Myles wrote in bug 259139 for platform support. font-variant-emoji: normal | text | emoji | unicode https://drafts.csswg.org/css-fonts-4/#font-variant-emoji-prop * LayoutTests/TestExpectations: * LayoutTests/fast/css/font-property-priority-expected.txt: * LayoutTests/fast/css/font-shorthand-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-serialization-prevention-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/font-shorthand-subproperties-reset-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-emoji-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-variant-emoji-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-vari
[webkit-changes] [WebKit/WebKit] 2e3f11: [visionOS] Find in HTML note obscures matches when...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e3f11b2736f256ef25d919e5a7ebb7294ac9be9 https://github.com/WebKit/WebKit/commit/2e3f11b2736f256ef25d919e5a7ebb7294ac9be9 Author: Aditya Keerthi Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm Log Message: --- [visionOS] Find in HTML note obscures matches when they are at the top https://bugs.webkit.org/show_bug.cgi?id=260982 rdar://109165939 Reviewed by Wenson Hsieh. On visionOS, the find bar initially appears in the scroll view's inset area. As the scroll view is scrolled, the find bar's frame is adjusted to ensure it is always at the top of the currently visible rect. Both these behaviors are implemented by UIKit. When matches are found, scrolling is performed to make them visible. This is achieved by using `-[WKWebView _scrollToRect:origin:minimumScrollDistance:]`. However, that method always enforces a minimum content offset of (0, 0). This is incompatible with the find bar's position, since for matches at the top of the scroll view, a scroll to (0, 0) is forced, even when match is already visible. The forced scroll to (0, 0) then ends up obscuring the match, as the find bar's position is adjusted to keep it at the top. Fix by accounting for content insets when determining the minimum content offset for targeted scrolling. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _initialContentOffsetForScrollView]): (constrainContentOffset): (-[WKWebView _scrollToRect:origin:minimumScrollDistance:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm: (TEST): Use a 500ms delay to ensure that scrolling did not occur. Waiting for two presentation updates is unfortunately insufficient. Canonical link: https://commits.webkit.org/267539@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86bdc4: [IFC] Add support for out-of-flow static positioni...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86bdc446a589be89d1762044237b660ea79564fb https://github.com/WebKit/WebKit/commit/86bdc446a589be89d1762044237b660ea79564fb Author: Alan Baradlay Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/ios/fast/block/positioning/auto/vertical-lr/006-expected.txt M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h Log Message: --- [IFC] Add support for out-of-flow static positioning in bidi content https://bugs.webkit.org/show_bug.cgi?id=260832 Reviewed by Antti Koivisto. * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: (WebCore::Layout::InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::printReason): (WebCore::LayoutIntegration::canUseForChild): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: Canonical link: https://commits.webkit.org/267538@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f288b: [git-webkit] Dupe CCed bug when racing bug importer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f288bbe5ec0dcff5c1cb7fba8a3a36789f99b1d https://github.com/WebKit/WebKit/commit/0f288bbe5ec0dcff5c1cb7fba8a3a36789f99b1d Author: Jonathan Bedard Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Tools/Scripts/libraries/webkitbugspy/setup.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py M Tools/Scripts/libraries/webkitscmpy/setup.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py Log Message: --- [git-webkit] Dupe CCed bug when racing bug importer https://bugs.webkit.org/show_bug.cgi?id=260747 rdar://114272849 Reviewed by Aakash Jain. In some situations, git-webkit ends up racing our bug importer. In that case, take the radar created by our bug importer and dupe it to the radar provided by the contributor. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: (Tracker.populate): Populate bug dupe status. (Tracker.set): Allow for bug to be closed as a dupe. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: (Tracker.set): Link closed bug to a dupe, if applicable. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: (Issue.__init__): Add _original value. (Issue.close): Allow caller to close bug as a duplicate. (Issue.original): Return the original bug, if closed as a dupe. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py: (Bugzilla._issue): Support duping. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py: (RadarModel.__init__): Support duping. (RadarModel.commit_changes): Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py: (Tracker.populate): Populate bug dupe status. (Tracker.set): Allow for bug to be closed as a dupe. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py: (TestBugzilla.test_duplicate): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py: (TestGitHub.test_duplicate): * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py: (TestRadar.test_duplicate): * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py: (Branch.main): If the cced radar and provided radar don't match, close the cced radar as a dupe of the provided radar. Canonical link: https://commits.webkit.org/267537@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb81fb: [WPE] LayoutTests/fast/block/positioning passing u...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb81fbb250e1155e83ece2f3488d34c1857446ab https://github.com/WebKit/WebKit/commit/eb81fbb250e1155e83ece2f3488d34c1857446ab Author: Amanda Falke Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A LayoutTests/platform/glib/fast/block/positioning/056-expected.txt R LayoutTests/platform/gtk/fast/block/positioning/056-expected.txt R LayoutTests/platform/wpe/fast/block/positioning/056-expected.txt Log Message: --- [WPE] LayoutTests/fast/block/positioning passing unexpectedly Unreviewed test gardening. This test was failing as expected in all ports (see webkit.org/b/230593, and 243008@main where we added this test expectation as failing in all ports of WebKit due to lack of IFC support regarding gaps between glyphs when kerning is on, particularly when content spans across multiple inline boxes like this test). At some point, the WPE expectations were updated, but the GTK and WPE expectation files for this test should be matching. Moved GTK expectation up to GLib expectations; now WPE fails - as GTK did (and does) - as expected. * LayoutTests/platform/glib/fast/block/positioning/056-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/056-expected.txt. * LayoutTests/platform/wpe/fast/block/positioning/056-expected.txt: Removed. Canonical link: https://commits.webkit.org/267536@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0dcc7a: WebGLFramebuffer uses renderbuffer and texture att...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0dcc7a680e6c5e7bf96006e9c3bd17d185861520 https://github.com/WebKit/WebKit/commit/0dcc7a680e6c5e7bf96006e9c3bd17d185861520 Author: Kimmo Kinnunen Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGLFramebuffer.cpp M Source/WebCore/html/canvas/WebGLFramebuffer.h M Source/WebCore/html/canvas/WebGLObject.h M Source/WebCore/html/canvas/WebGLRenderbuffer.h M Source/WebCore/html/canvas/WebGLRenderingContext.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLTexture.h Log Message: --- WebGLFramebuffer uses renderbuffer and texture attachments via WebGLObject https://bugs.webkit.org/show_bug.cgi?id=260955 rdar://114750589 Reviewed by Dan Glastonbury. Framebuffer attachments can be 2d textures, 3d texture layers or renderbuffers. Use std::variant to encode this instead of a virtual base class. This removes a lot of unneeded complexity in the code. This also enables future bugfixes related to non-typesafe handling of these variants. When obtaining a pointer to the attached object, use std::variant instead of WebGLObject*. This way future commits may break the dependency to a common base class. The objects do not have intrinsic polymorphic operations, rather their types are always known at the invocation site, from JS through WebGLRenderingContextBase. * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::framebufferTextureLayer): (WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter): * Source/WebCore/html/canvas/WebGLFramebuffer.cpp: (WebCore::entryAddMembersToOpaqueRoots): (WebCore::entryDetachAndClear): (WebCore::entryAttach): (WebCore::entryContextSetAttachment): (WebCore::entryObject): (WebCore::entryHasObject): (WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer): (WebCore::WebGLFramebuffer::getAttachmentObject const): (WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer): (WebCore::WebGLFramebuffer::deleteObjectImpl): (WebCore::WebGLFramebuffer::drawBuffersIfNecessary): (WebCore::WebGLFramebuffer::addMembersToOpaqueRoots): (WebCore::WebGLFramebuffer::setAttachmentInternal): (WebCore::WebGLFramebuffer::TextureAttachment::operator== const): (WebCore::WebGLFramebuffer::TextureLayerAttachment::operator== const): (): Deleted. (WebCore::WebGLFramebuffer::attach): Deleted. (WebCore::WebGLFramebuffer::getAttachment const): Deleted. (WebCore::WebGLFramebuffer::removeAttachmentInternal): Deleted. * Source/WebCore/html/canvas/WebGLFramebuffer.h: * Source/WebCore/html/canvas/WebGLObject.h: (WebCore::WebGLObject::isRenderbuffer const): Deleted. (WebCore::WebGLObject::isTexture const): Deleted. * Source/WebCore/html/canvas/WebGLRenderbuffer.h: * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::framebufferRenderbuffer): (WebCore::WebGLRenderingContextBase::framebufferTexture2D): * Source/WebCore/html/canvas/WebGLTexture.h: Canonical link: https://commits.webkit.org/267535@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e803ed: [Gardening]: [ macOS wk2 ] swipe/pushState-cached-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e803ed36e11d0a0d37f23143b6b9ba45f55ce9b9 https://github.com/WebKit/WebKit/commit/e803ed36e11d0a0d37f23143b6b9ba45f55ce9b9 Author: Ben Schwartz Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ macOS wk2 ] swipe/pushState-cached-back-swipe.html is a flaky timeout / text failure. rdar://114797952 https://bugs.webkit.org/show_bug.cgi?id=261005 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/267534@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d0e5a: [PlayStation] Enable variation fonts experimentally
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d0e5aebe06eca31e00687fd7474b2db135355ea https://github.com/WebKit/WebKit/commit/4d0e5aebe06eca31e00687fd7474b2db135355ea Author: Don Olmstead Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Enable variation fonts experimentally https://bugs.webkit.org/show_bug.cgi?id=260987 Reviewed by Fujii Hironori. Check the versions of freetype, harfbuzz and fontconfig to see if its possible to turn on `ENABLE_VARIATION_FONTS`. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/267533@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 075685: [JSC] Reland wyhash in StringImpl for MacOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0756854fafd4312b8f0126de111792e39db106ef https://github.com/WebKit/WebKit/commit/0756854fafd4312b8f0126de111792e39db106ef Author: Yijia Huang Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/JavaScriptCore/create_hash_table M Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp.in M Source/JavaScriptCore/runtime/JSCell.cpp M Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/tools/VMInspector.cpp M Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py M Source/JavaScriptCore/yarr/hasher.py M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt M Source/WTF/wtf/Hasher.h M Source/WTF/wtf/text/CString.cpp M Source/WTF/wtf/text/StringHash.h M Source/WTF/wtf/text/StringHasher.h A Source/WTF/wtf/text/StringHasherInlines.h M Source/WTF/wtf/text/StringImpl.h A Source/WTF/wtf/text/SuperFastHash.h A Source/WTF/wtf/text/WYHash.h M Source/WTF/wtf/unicode/UTF8Conversion.cpp M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/Hasher.pm M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp M Source/WebCore/contentextensions/DFAMinimizer.cpp M Source/WebCore/contentextensions/HashableActionList.h M Source/WebCore/platform/SharedStringHash.cpp M Source/WebCore/platform/graphics/WidthCache.h M Tools/TestWebKitAPI/CMakeLists.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp A Tools/TestWebKitAPI/Tests/WTF/SuperFastHash.cpp A Tools/TestWebKitAPI/Tests/WTF/WYHash.cpp Log Message: --- [JSC] Reland wyhash in StringImpl for MacOS https://bugs.webkit.org/show_bug.cgi?id=260957 rdar://114755168 Reviewed by Yusuke Suzuki. Previously, we reverted the wyhash patch (landed at 266929@main and reverted at 267004@main) which causes regressions on iOS devices. This patch only enable wyhash for macOS. * Source/JavaScriptCore/create_hash_table: * Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp.in: * Source/JavaScriptCore/runtime/JSCell.cpp: (JSC::reportZappedCellAndCrash): * Source/JavaScriptCore/runtime/TemplateObjectDescriptor.h: (JSC::TemplateObjectDescriptor::calculateHash): * Source/JavaScriptCore/tools/JSDollarVM.cpp: * Source/JavaScriptCore/tools/VMInspector.cpp: (JSC::VMInspector::dumpSubspaceHashes): * Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py: (PropertyData.createAndDumpHashTable.createAndDumpHashTableHelper): (PropertyData.createAndDumpHashTable): * Source/JavaScriptCore/yarr/hasher.py: (stringHash): (avalancheBits): (maskTop8BitsAndAvoidZero): (superFastHash): (wyhash): (wyhash.add64): (wyhash.multi64): (wyhash.wymum): (wyhash.wymix): (wyhash.convert32BitTo64Bit): (wyhash.convert16BitTo32Bit): (wyhash.c2i): (wyhash.wyr8): (wyhash.wyr4): (wyhash.wyr2): (ceilingToPowerOf2): (createHashTable): (createHashTable.createHashTableHelper): * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/CMakeLists.txt: * Source/WTF/wtf/Hasher.h: * Source/WTF/wtf/text/CString.cpp: (WTF::CString::hash const): * Source/WTF/wtf/text/StringHash.h: (WTF::ASCIICaseInsensitiveHash::hash): * Source/WTF/wtf/text/StringHasher.h: (WTF::StringHasher::finalize): (WTF::StringHasher::finalizeAndMaskTop8Bits): (WTF::StringHasher::addCharactersAssumingAligned): Deleted. (WTF::StringHasher::addCharacter): Deleted. (WTF::StringHasher::addCharacters): Deleted. (WTF::StringHasher::hashWithTop8BitsMasked const): Deleted. (WTF::StringHasher::hash const): Deleted. (WTF::StringHasher::computeHashAndMaskTop8Bits): Deleted. (WTF::StringHasher::computeHash): Deleted. (WTF::StringHasher::computeLiteralHash): Deleted. (WTF::StringHasher::computeLiteralHashAndMaskTop8Bits): Deleted. (WTF::StringHasher::calculateWithRemainingLastCharacter): Deleted. (WTF::StringHasher::calculateWithTwoCharacters): Deleted. (WTF::StringHasher::computeHashImpl): Deleted. (WTF::StringHasher::processPendingCharacter const): Deleted. * Source/WTF/wtf/text/StringHasherInlines.h: Added. (WTF::StringHasher::computeHashAndMaskTop8Bits): (WTF::StringHasher::computeLiteralHashAndMaskTop8Bits): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hashWithTop8BitsMasked): * Source/WTF/wtf/text/StringImpl.h: * Source/WTF/wtf/text/SuperFastHash.h: Copied from Source/WTF/wtf/text/StringHasher.h. (WTF::SuperFastHash::addCharactersAssumingAligned): (WTF::SuperFastHash::addCharacter): (WTF::SuperFastHash::addCharacters): (WTF::SuperFastHash::hashWithTop8BitsMasked const): (WTF::SuperFastHash::hash const): (WTF::SuperFastHash::computeHashAndMaskTop8Bits): (WTF::SuperFastHash::computeHash): (WTF::SuperFastHash::computeLiteralHash): (WTF::SuperFastHash::computeLiteralHashAndMaskTop8Bits): (WTF::SuperFastHash::addChara
[webkit-changes] [WebKit/WebKit] 41f7a3: [CSS] Always serialize implicit nesting selector/rule
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41f7a301e412e75355904d8aa98393810cd91e3a https://github.com/WebKit/WebKit/commit/41f7a301e412e75355904d8aa98393810cd91e3a Author: Matthieu Dubet Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing.html M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/serialize-group-rules-with-decls-expected.txt M LayoutTests/inspector/css/getMatchedStylesForNodeNestingStyleGrouping-expected.txt M Source/WebCore/css/CSSGroupingRule.cpp M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/parser/CSSParserSelector.cpp M Source/WebCore/css/parser/CSSParserSelector.h M Source/WebCore/css/parser/CSSSelectorParser.cpp Log Message: --- [CSS] Always serialize implicit nesting selector/rule https://bugs.webkit.org/show_bug.cgi?id=260707 rdar://112900363 Reviewed by Patrick Angle and Antti Koivisto. https://drafts.csswg.org/css-nesting/#cssom "When serializing a relative selector in a nested style rule, the selector must be absolutized, with the implied nesting selector inserted. When serializing a nested group rule, it must serialize solely with child rules." This patch moves the code which build the selector with the implicit & added from rule set building time to parsing time. * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/serialize-group-rules-with-decls-expected.txt: * LayoutTests/inspector/css/getMatchedStylesForNodeNestingStyleGrouping-expected.txt: * Source/WebCore/css/CSSGroupingRule.cpp: (WebCore::CSSGroupingRule::cssTextForDeclsAndRules const): * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * Source/WebCore/css/parser/CSSParserSelector.cpp: (WebCore::CSSParserSelector::hasExplicitNestingParent const): * Source/WebCore/css/parser/CSSParserSelector.h: (WebCore::CSSParserSelector::selector const): * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeNestedComplexSelector): (WebCore::CSSSelectorParser::resolveNestingParent): Canonical link: https://commits.webkit.org/267531@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b90f5: [Gardening]: [ macOS ] media/video-orientation-can...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b90f500d404d08cca15168eaa57fdf54dbebdbe https://github.com/WebKit/WebKit/commit/3b90f500d404d08cca15168eaa57fdf54dbebdbe Author: Ben Schwartz Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ macOS ] media/video-orientation-canvas.html is a flaky text failure. rdar://114793358 https://bugs.webkit.org/show_bug.cgi?id=261000 Unreviewed test gardening. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/267530@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73f6c6: Do not allow container units in DOMMatrix() and DO...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73f6c6d69991fded4847d7d8fdf9153859f3189d https://github.com/WebKit/WebKit/commit/73f6c6d69991fded4847d7d8fdf9153859f3189d Author: Tim Nguyen Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/geometry/DOMMatrix-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/geometry/DOMMatrix-001.html M Source/WebCore/css/CSSPrimitiveValueMappings.h Log Message: --- Do not allow container units in DOMMatrix() and DOMMatrixReadOnly() https://bugs.webkit.org/show_bug.cgi?id=260988 rdar://114759860 Reviewed by Simon Fraser. Prevent a nullptr deref by forbidding container unit usage in DOMMatrix(). * LayoutTests/imported/w3c/web-platform-tests/css/geometry/DOMMatrix-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/geometry/DOMMatrix-001.html: * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::convertingToLengthHasRequiredConversionData const): Canonical link: https://commits.webkit.org/267529@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc3286: Deploy more smart pointers in Source/WebKit/UIProc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc328646ce2fb251e968f41ac2c54f5dac601358 https://github.com/WebKit/WebKit/commit/dc328646ce2fb251e968f41ac2c54f5dac601358 Author: Ryosuke Niwa Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp M Source/WebKit/UIProcess/Notifications/WebNotificationProvider.cpp M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm Log Message: --- Deploy more smart pointers in Source/WebKit/UIProcess/Notifications and Source/WebKit/UIProcess/PDF https://bugs.webkit.org/show_bug.cgi?id=260952 Reviewed by Chris Dumez. Deployed more smart pointers as found by clang static analyzer. * Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp: (WebKit::WebNotificationManagerProxy::sharedServiceWorkerManager): (WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): * Source/WebKit/UIProcess/Notifications/WebNotificationProvider.cpp: (WebKit::WebNotificationProvider::notificationPermissions): * Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm: (-[WKPDFHUDView hitTest:]): (-[WKPDFHUDView _performActionForControl:]): Canonical link: https://commits.webkit.org/267528@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1b8732: [JSC] Use MonotonicTime for SamplingProfiler JSON ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1b8732286c537bc76aac6dd482134c7029aefbf8 https://github.com/WebKit/WebKit/commit/1b8732286c537bc76aac6dd482134c7029aefbf8 Author: Yusuke Suzuki Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp M Source/JavaScriptCore/runtime/SamplingProfiler.cpp M Source/JavaScriptCore/runtime/SamplingProfiler.h M Source/WTF/wtf/Stopwatch.h Log Message: --- [JSC] Use MonotonicTime for SamplingProfiler JSON dump timestamp https://bugs.webkit.org/show_bug.cgi?id=260998 rdar://114791556 Reviewed by Justin Michaud. Replace timestamp of SamplingProfiler JSON dump from Stopwatch's elapsedTime to MonotonicTime to easily sync it with the system wide samples. * Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp: (Inspector::buildSamples): (Inspector::InspectorScriptProfilerAgent::trackingComplete): * Source/JavaScriptCore/runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::timerLoop): (JSC::SamplingProfiler::takeSample): (JSC::SamplingProfiler::processUnverifiedStackTraces): (JSC::SamplingProfiler::noticeVMEntry): (JSC::SamplingProfiler::stackTracesAsJSON): * Source/JavaScriptCore/runtime/SamplingProfiler.h: * Source/WTF/wtf/Stopwatch.h: (WTF::Stopwatch::elapsedTime const): (WTF::Stopwatch::elapsedTimeAndTimestamp const): (WTF::Stopwatch::create): Deleted. (WTF::Stopwatch::isActive const): Deleted. (WTF::Stopwatch::Stopwatch): Deleted. Canonical link: https://commits.webkit.org/267527@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3a4a4: [JSC] LLInt slow path of op_iterator_next doesn't ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3a4a487b56ade502613ebf7e0136f35ba68fa84 https://github.com/WebKit/WebKit/commit/b3a4a487b56ade502613ebf7e0136f35ba68fa84 Author: Alexey Shvayka Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A JSTests/stress/regress-260980.js M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp Log Message: --- [JSC] LLInt slow path of op_iterator_next doesn't always check m_done value https://bugs.webkit.org/show_bug.cgi?id=260980 Reviewed by Mark Lam. Before this change, if `iteratorResult.done` wasn't of boolean type, its value wasn't checked. This patch adds ToBoolean coercion and the missing check, aligning JSC with V8 and SpiderMonkey. * Source/JavaScriptCore/llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * JSTests/stress/regress-260980.js: Added. Canonical link: https://commits.webkit.org/267526@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ec729: Sync css/css-contain from WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ec72902380925a43ae13e914d08fe8386d43b8d https://github.com/WebKit/WebKit/commit/8ec72902380925a43ae13e914d08fe8386d43b8d Author: Rob Buis Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-085.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-086-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-086.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-088-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-088.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-089-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-089.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-path-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-path.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-rect-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-rect.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-text-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-text.html M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/counter-scoping-001.html Log Message: --- Sync css/css-contain from WPT https://bugs.webkit.org/show_bug.cgi?id=260992 Reviewed by Tim Nguyen. >From WPT revision 3d46d558a0. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-085.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-086-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-086.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-088-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-088.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-089-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-089.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-090.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-path-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-path.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-rect-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-rect.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-text-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-svg-text.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/counter-scoping-001.html: Canonical link: https://commits.webkit.org/267525@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c377f2: [motion-path] Update "" implementation ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c377f2da36eb80d46bc851a8090f020bab79752f https://github.com/WebKit/WebKit/commit/c377f2da36eb80d46bc851a8090f020bab79752f Author: Nikolaos Mouchtaris Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/MotionPath.cpp M Source/WebCore/rendering/MotionPath.h M Source/WebCore/rendering/PathOperation.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- [motion-path] Update "" implementation for offset-path https://bugs.webkit.org/show_bug.cgi?id=260944 rdar://110938788 Reviewed by Tim Nguyen. Update coord-box to use the containing block's bounding rect if it exists. We also need to take into account the containing block's border radius. * LayoutTests/TestExpectations: * Source/WebCore/rendering/MotionPath.cpp: (WebCore::offsetFromContainer): (WebCore::MotionPath::motionPathDataForRenderer): * Source/WebCore/rendering/PathOperation.cpp: (WebCore::BoxPathOperation::getPath const): * Source/WebCore/rendering/PathOperation.h: Canonical link: https://commits.webkit.org/267524@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2aa0c: Use memcpy in SVGPathByteStreamSource::readType
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2aa0c20fc47b29231c6e5413347d827c36d4186 https://github.com/WebKit/WebKit/commit/e2aa0c20fc47b29231c6e5413347d827c36d4186 Author: Chris Dumez Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/svg/SVGPathByteStream.h M Source/WebCore/svg/SVGPathByteStreamBuilder.cpp M Source/WebCore/svg/SVGPathByteStreamBuilder.h M Source/WebCore/svg/SVGPathByteStreamSource.h Log Message: --- Use memcpy in SVGPathByteStreamSource::readType https://bugs.webkit.org/show_bug.cgi?id=250676 rdar://104552389 Reviewed by Ryosuke Niwa. Use memcpy in SVGPathByteStreamSource::readType and simplify the SVGPathByteStreamBuilder::writeType() logic. * Source/WebCore/svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::append): (): Deleted. * Source/WebCore/svg/SVGPathByteStreamBuilder.cpp: (WebCore::SVGPathByteStreamBuilder::moveTo): (WebCore::SVGPathByteStreamBuilder::lineTo): (WebCore::SVGPathByteStreamBuilder::lineToHorizontal): (WebCore::SVGPathByteStreamBuilder::lineToVertical): (WebCore::SVGPathByteStreamBuilder::curveToCubic): (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth): (WebCore::SVGPathByteStreamBuilder::curveToQuadratic): (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth): (WebCore::SVGPathByteStreamBuilder::arcTo): (WebCore::SVGPathByteStreamBuilder::closePath): * Source/WebCore/svg/SVGPathByteStreamBuilder.h: * Source/WebCore/svg/SVGPathByteStreamSource.h: Canonical link: https://commits.webkit.org/267523@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 589a9d: Add support for Web Extension windows APIs.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 589a9da68d4ea19dffeee69c65375b872cca7c1b https://github.com/WebKit/WebKit/commit/589a9da68d4ea19dffeee69c65375b872cca7c1b Author: Timothy Hatcher Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Extensions/WebExtensionEventListenerType.serialization.in A Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h A Source/WebKit/Shared/Extensions/WebExtensionTabParameters.h A Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h A Source/WebKit/Shared/Extensions/WebExtensionWindowParameters.h M Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTabCreationOptionsInternal.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindow.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptions.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptionsInternal.h A Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsEventCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindows.h M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindowsEvent.h M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIWindows.idl M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionTab.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionWindow.mm M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm Log Message: --- Add support for Web Extension windows APIs. https://bugs.webkit.org/show_bug.cgi?id=260155 rdar://problem/114736173 Reviewed by Brian Weinstein. Fully plumbs the windows API from JavaScript up to the Objective-C API. * Source/WebKit/DerivedSources-input.xcfilelist: Addeed new files. * Source/WebKit/DerivedSources.make: Added new files. * Source/WebKit/Scripts/webkit/messages.py: Added new extension types. (serialized_identifiers): (types_that_cannot_be_forward_declared): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: Updated with make command mentioned in messages.py comment. (IPC::serializedIdentifiers): * Source/WebKit/Shared/Extensions/WebExtensionEventListenerType.serialization.in: * Source/WebKit/Shared/Extensions/WebExtensionTab.serialization.in: Added. * Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h: (WebKit::isNone): Added. (WebKit::isValid): Added. (WebKit::toWebExtensionTabIdentifier): Added. (WebKit::toWebAPI): Added. * Source/WebKit/Shared/Extensions/WebExtensionTabParameters.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindowCreationOptionsInternal.h. * Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in: Added. * Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h: (WebKit::isNone): Added. (WebKit::isCurrent): Added. (WebKit::isValid): Added. (WebKit::toWebExtensionWindowIdentifier): Added. (WebKit::toWebAPI): Added. * Source/WebKit/Shared/Extensions/WebExtensionWindowParameters.h: Copied from Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h. * Source/WebKit/Shared/Extensions/_WKWebExtensionUtilities.mm: (classToClassString): Use dot-syntax. (+[_WKWebExtensionUtilities validateContentsOfDictionary:requiredKeys:optionalKeys:keyToExpectedValueType:outExceptionString:]): Added support for NSSet input, where any class or
[webkit-changes] [WebKit/WebKit] f6b1fa: Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab https://github.com/WebKit/WebKit/commit/f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab Author: Don Olmstead Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/cmake/WebKitCommon.cmake M Tools/Scripts/webkitdirs.pm Log Message: --- Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS https://bugs.webkit.org/show_bug.cgi?id=260666 Reviewed by Michael Catanzaro. In 266947@main a target `RewriteCompileCommands` was added for unified builds where `CMAKE_EXPORT_COMPILE_COMMANDS` is `ON`. However this is only valid for Makefile and Ninja generators. On Visual Studio it is ignored so the target will always fail to build which was found out because its always set to `ON` within `build-webkit`. Move the logic for turning it `ON` into the CMake code and base it on the `CMAKE_GENERATOR`. * Source/cmake/WebKitCommon.cmake * Tools/Scripts/webkitdirs.pm Canonical link: https://commits.webkit.org/267521@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff53b2: [JSC] Refactor and restrict IC operations are only...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff53b2cbf74de112c510f533ab39366ca1366606 https://github.com/WebKit/WebKit/commit/ff53b2cbf74de112c510f533ab39366ca1366606 Author: Yusuke Suzuki Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/JITOperations.h Log Message: --- [JSC] Refactor and restrict IC operations are only called from IC https://bugs.webkit.org/show_bug.cgi?id=260937 rdar://114736570 Reviewed by Keith Miller and Justin Michaud. In this patch, we refactor operations used by IC and others. The goal of this patch is that we ensure that IC operations are called only from IC. We would like to make these operations assuming more, like, it always has StructureStubInfo so that it does not need to set CallSiteIndex in the caller side in the future. This is really nice since we can remove get_by_id's Slow path in Baseline JIT code for example later, and making slow path of get_by_id one shared one, this will be set up later for handler IC. So, handler IC can just always call this slow path handler which calls operations, and operations are aware that they are called from IC, and CallSiteIndex etc. are appropriately set up from passed StructureStubInfo*. So we can make this entrance similar to the fast path IC, which removes a lot of weird stub code necessary for handler IC. We also resolve many naming inconsistencies in these operations. We have solid rule now about Optimize, Generic, Megamorphic, MegamorphicGeneric, and GaveUp suffixes. * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::appropriateGetByOptimizeFunction): (JSC::appropriateGetByGaveUpFunction): (JSC::tryCacheGetBy): (JSC::repatchGetBy): (JSC::repatchGetBySlowPathCall): (JSC::repatchArrayGetByVal): (JSC::appropriatePutByGaveUpFunction): (JSC::repatchPutBySlowPathCall): (JSC::appropriatePutByOptimizeFunction): (JSC::tryCachePutBy): (JSC::repatchPutBy): (JSC::repatchArrayPutByVal): (JSC::repatchDeleteBy): (JSC::appropriateInByOptimizeFunction): (JSC::appropriateInByGaveUpFunction): (JSC::repatchInBy): (JSC::repatchHasPrivateBrand): (JSC::repatchCheckPrivateBrand): (JSC::repatchSetPrivateBrand): (JSC::repatchInstanceOf): (JSC::resetGetBy): (JSC::resetInBy): (JSC::appropriateOptimizingGetByFunction): Deleted. (JSC::appropriateGetByFunction): Deleted. (JSC::appropriateGenericPutByFunction): Deleted. (JSC::appropriateOptimizingPutByFunction): Deleted. (JSC::appropriateOptimizingInByFunction): Deleted. (JSC::appropriateGenericInByFunction): Deleted. * Source/JavaScriptCore/bytecode/StructureStubInfo.h: (JSC::appropriateGetByIdOptimizeFunction): (JSC::appropriateGetByIdGenericFunction): (JSC::appropriatePutByIdOptimizeFunction): (JSC::appropriateOptimizingGetByIdFunction): Deleted. (JSC::appropriateGenericGetByIdFunction): Deleted. * Source/JavaScriptCore/dfg/DFGOperations.cpp: (JSC::DFG::putByVal): Deleted. (JSC::DFG::putByValInternal): Deleted. * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileDeleteById): (JSC::DFG::SpeculativeJIT::compileDeleteByVal): (JSC::DFG::SpeculativeJIT::compilePutByVal): (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::compileGetByVal): (JSC::DFG::SpeculativeJIT::compileGetByValWithThis): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::compileGetByVal): (JSC::DFG::SpeculativeJIT::compileGetByIdMegamorphic): (JSC::DFG::SpeculativeJIT::compileGetByIdWithThisMegamorphic): (JSC::DFG::SpeculativeJIT::compileGetByValMegamorphic): (JSC::DFG::SpeculativeJIT::compileGetByValWithThisMegamorphic): (JSC::DFG::SpeculativeJIT::compilePutByIdMegamorphic): (JSC::DFG::SpeculativeJIT::compilePutByValMegamorphic): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetById): (JSC::FTL::DFG::LowerDFGToB3::compileGetByIdMegamorphic): (JSC::FTL::DFG::LowerDFGToB3::compileGetByValMegamorphic): (JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThisMegamorphic): (JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThisMegamorphic): (JSC::FTL::DFG::LowerDFGToB3::compileGetPrivateName): (JSC::FTL::DFG::LowerDFGToB3::compilePutByValMega
[webkit-changes] [WebKit/WebKit] 53a54c: [CMake] Turn off pkg-config on PlayStation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53a54cd39755b3ea25db0a1064f102f920f16236 https://github.com/WebKit/WebKit/commit/53a54cd39755b3ea25db0a1064f102f920f16236 Author: Don Olmstead Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [CMake] Turn off pkg-config on PlayStation https://bugs.webkit.org/show_bug.cgi?id=260983 Reviewed by Michael Catanzaro. The CMake find modules use pkg-config to get hints for a library's location. With a Windows host it can pick up .pc files in the perl install accidentally. PlayStation isn't using .pc files so just turn it completely off. Prevent the find module from running and override `pkg_check_modules` so it doesn't return anything. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/267519@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c379c0: Cleanup code for shorthand parsing and font-varian...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c379c056f604bb93b731e512c76d7011dca13096 https://github.com/WebKit/WebKit/commit/c379c056f604bb93b731e512c76d7011dca13096 Author: Tim Nguyen Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp Log Message: --- Cleanup code for shorthand parsing and font-variant computed style https://bugs.webkit.org/show_bug.cgi?id=260985 rdar://114780529 Reviewed by Myles C. Maxfield. * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): (WebCore::fontVariantPositionPropertyValue): Deleted. (WebCore::fontVariantCapsPropertyValue): Deleted. The toCSSValueID methods in CSSPrimitiveValueMappings.h allow us to remove this redundant code. * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeFontVariantShorthand): (WebCore::CSSPropertyParser::consumeListStyleShorthand): This is consistent with style used for the columns property. Canonical link: https://commits.webkit.org/267518@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fab917: Reduce the amount of SVGElement::updateRelativeLen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fab91723ea6b142820bc5c7186672e122391f272 https://github.com/WebKit/WebKit/commit/fab91723ea6b142820bc5c7186672e122391f272 Author: Chris Dumez Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/svg/SVGElement.cpp Log Message: --- Reduce the amount of SVGElement::updateRelativeLengthsInformation() calls https://bugs.webkit.org/show_bug.cgi?id=260971 Reviewed by Ryosuke Niwa. Reduce the amount of SVGElement::updateRelativeLengthsInformation() calls. In SVGElement::removedFromAncestor(), if `removalType.disconnectedFromDocument` was true, we would call `updateRelativeLengthsInformation(false, *this)` to remove the element from m_elementsWithRelativeLengths and from our ancestor's map. However, when SVGElement::removedFromAncestor() gets called, we know that the element either doesn't have a parent or that it's parent is not connected (I added an assertion to this effect). As a result, recursively calling `updateRelativeLengthsInformation(false, element)` on the ancestors had no effect, since the function would early return at the `!isConnected()` check. As a result, it is sufficient to clear m_elementsWithRelativeLengths in SVGElement::removedFromAncestor(), without calling `updateRelativeLengthsInformation(false, *this)` or worrying about the ancestors. * Source/WebCore/svg/SVGElement.cpp: (WebCore::SVGElement::removedFromAncestor): Canonical link: https://commits.webkit.org/267517@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b214f: Migrate macOS Sonoma test expectations to OpenSour...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b214fee9054bb69614243f6c6a2ea66a26f354f https://github.com/WebKit/WebKit/commit/3b214fee9054bb69614243f6c6a2ea66a26f354f Author: Dawn Flores Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/mac-monterey-wk1/TestExpectations A LayoutTests/platform/mac-monterey-wk1/editing/inserting/caret-position-expected.txt A LayoutTests/platform/mac-monterey-wk1/editing/mac/input/caret-primary-bidi-expected.txt A LayoutTests/platform/mac-monterey-wk1/editing/mac/input/firstrectforcharacterrange-plain-expected.txt A LayoutTests/platform/mac-monterey-wk1/editing/mac/input/firstrectforcharacterrange-styled-expected.txt A LayoutTests/platform/mac-monterey-wk1/editing/selection/5825350-2-expected.txt A LayoutTests/platform/mac-monterey-wk1/editing/selection/mixed-editability-10-expected.txt A LayoutTests/platform/mac-monterey-wk1/media/media-can-play-mpeg4-video-expected.txt A LayoutTests/platform/mac-monterey-wk1/media/video-source-type-params-expected.txt M LayoutTests/platform/mac-monterey-wk2/TestExpectations A LayoutTests/platform/mac-monterey-wk2/composting/backing/inline-block-no-backing-expected.txt A LayoutTests/platform/mac-monterey-wk2/composting/backing/whitespace-nodes-no-backing-expected.txt A LayoutTests/platform/mac-monterey-wk2/composting/fixed-image-loading-expected.txt A LayoutTests/platform/mac-monterey-wk2/composting/tilling/huge-layer-img-expected.txt A LayoutTests/platform/mac-monterey-wk2/composting/visibility/visibility-image-layers-dynamic-expected.txt A LayoutTests/platform/mac-monterey-wk2/editing/caret/caret-at-the-edge-of-contenteditable-expected.txt A LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/fetch/content-length/api-and-duplicate-headers.any-expected.txt A LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/fetch/content-length/api-and-duplicate-headers.any.worker-expected.txt A LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/fetch/range/non-matching-range-response-expected.txt A LayoutTests/platform/mac-monterey-wk2/imported/w3c/web-platform-tests/mimesniff/media/media-sniff.window-expected.txt A LayoutTests/platform/mac-monterey-wk2/media/media-can-play-mpeg4-video-expected.txt A LayoutTests/platform/mac-monterey-wk2/media/video-source-type-params-expected.txt A LayoutTests/platform/mac-monterey-wk2/scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-non-cb-overflow-expected.txt A LayoutTests/platform/mac-monterey-wk2/scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow-expected.txt A LayoutTests/platform/mac-monterey-wk2/scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-nested-overflow2-expected.txt M LayoutTests/platform/mac-monterey/TestExpectations A LayoutTests/platform/mac-monterey/css1/box_properties/acid_test-expected.txt A LayoutTests/platform/mac-monterey/css2.1/t09-c5526c-display-00-e-expected.txt A LayoutTests/platform/mac-monterey/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt A LayoutTests/platform/mac-monterey/editing/input/caret-at-the-edge-of-contenteditable-expected.txt A LayoutTests/platform/mac-monterey/editing/input/caret-at-the-edge-of-input-expected.txt A LayoutTests/platform/mac-monterey/editing/input/editable-container-with-word-wrap-normal-expected.txt A LayoutTests/platform/mac-monterey/editing/inserting/before-after-input-element-expected.txt A LayoutTests/platform/mac-monterey/editing/inserting/multiple-lines-selected-expected.txt A LayoutTests/platform/mac-monterey/editing/pasteboard/4806874-expected.txt A LayoutTests/platform/mac-monterey/editing/pasteboard/input-field-1-expected.txt A LayoutTests/platform/mac-monterey/editing/pasteboard/interchange-newline-2-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/3690703-2-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/3690703-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/3690719-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/4895428-3-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/4975120-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/block-cursor-overtype-mode-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/caret-in-empty-inline-1-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/caret-in-empty-inline-2-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/drag-select-1-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/internal-caret-rect-expected.txt A LayoutTests/platform/mac-monterey/editing/selection/select-from-textfield-outwards-expect
[webkit-changes] [WebKit/WebKit] 7d6cd5: [GStreamer] Video not resized with playbin3 on i.M...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d6cd5e4b26870a15004fe75d6d163bdd3539a0d https://github.com/WebKit/WebKit/commit/7d6cd5e4b26870a15004fe75d6d163bdd3539a0d Author: Marek Vasut Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer] Video not resized with playbin3 on i.MX8M Plus and COG https://bugs.webkit.org/show_bug.cgi?id=260482 Reviewed by Philippe Normand. When using WEBKIT_GST_USE_PLAYBIN3=1 and cog to open h264 video (e.g. Big Buck Bunny h264 1920x1080 mp4), then only single message is delivered to MediaPlayerPrivateGStreamer::handleStreamCollectionMessage() . The current workaround check would bail out since the message source is decodebin3, while the m_source is filesrc . This prevents player->updateTracks from being called, and thus m_hasVideo from being set, and thus hasVideo() in MediaPlayerPrivateGStreamer::naturalSize() returns false and MediaPlayerPrivateGStreamer::naturalSize returns FloatSize() size, which is 0x0. The resulting video element in the browser has minimum height set and is not correctly resized. Limit the MediaPlayerPrivateGStreamer::handleStreamCollectionMessage() workaround only to non-filesrc, since filesrc is not generating the stream-collection events. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage): Canonical link: https://commits.webkit.org/267515@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3e388: [WPE] IFC : fast/text/whitespace/nowrap-clear-floa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3e388e446c42ff7578a5725c2a58705481fe546 https://github.com/WebKit/WebKit/commit/f3e388e446c42ff7578a5725c2a58705481fe546 Author: Amanda Falke Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A LayoutTests/platform/glib/fast/text/whitespace/nowrap-clear-float-expected.png A LayoutTests/platform/glib/fast/text/whitespace/nowrap-clear-float-expected.txt R LayoutTests/platform/gtk/fast/text/whitespace/nowrap-clear-float-expected.png R LayoutTests/platform/gtk/fast/text/whitespace/nowrap-clear-float-expected.txt R LayoutTests/platform/wpe/fast/text/whitespace/nowrap-clear-float-expected.txt Log Message: --- [WPE] IFC : fast/text/whitespace/nowrap-clear-float.html passes unexpectedly Unreviewed test gardening. In 254439@main when IFC intrusive floats were introduced, webkit.org/b/245080 was filed, marking failing expectations for all ports for this test. Since then, the expectations were updated for WPE only in large meta-gardening patches very recently, but this test in WPE should continue to fail, as in GTK and in all other ports, until webkit.org/b/245080 is addressed wrt line wrapping and intrusive floats. Removed WPE expectations, and moved GTK expectations and png up to GLib dir; now WPE fails (as GTK, and all other ports do), as expected. * LayoutTests/platform/glib/fast/text/whitespace/nowrap-clear-float-expected.png: Renamed from LayoutTests/platform/gtk/fast/text/whitespace/nowrap-clear-float-expected.png. * LayoutTests/platform/glib/fast/text/whitespace/nowrap-clear-float-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/whitespace/nowrap-clear-float-expected.txt. * LayoutTests/platform/wpe/fast/text/whitespace/nowrap-clear-float-expected.txt: Removed. Canonical link: https://commits.webkit.org/267514@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b680f8: Add general quirk for canvas2d fingerprinting
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b680f873f60959c6077d9a9297ab933a35d7bbf4 https://github.com/WebKit/WebKit/commit/b680f873f60959c6077d9a9297ab933a35d7bbf4 Author: Matthew Finkel Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h M Source/WebCore/platform/Logging.h M Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm Log Message: --- Add general quirk for canvas2d fingerprinting https://bugs.webkit.org/show_bug.cgi?id=260842 rdar://113039941 Reviewed by Wenson Hsieh. In 266400@main I added a quirk for canvas fingerprinting that targeted specific pages on two specific domains. As a follow up to that, this patch expands the application of that quirk broadly by comparing attributes of the script instead of looking at the specific document URL. This step is important because we know protections against canvas fingerprinting cause breakage on some sites, and there is likely more greater impact than we're aware at this time. Similar to the current behavior, this patch relies on matching the last drawn text string. In addition, it compares the dimensions of the canvas and the size of the script. These characteristics seem sufficiently descriptive that we can safely use them for identifying the target script. This patch also introduces the CanvasFingerprintingQuirkEnabled preference for controlling whether the quirk is available. It also adapts the existing API test. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toDataURL): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::advancedPrivacyProtectionSubstituteDataURLForScriptWithFeatures const): (WebCore::Quirks::shouldEnableCanvas2DAdvancedPrivacyProtectionQuirk const): Deleted. (WebCore::Quirks::advancedPrivacyProtectionSubstituteDataURLForText const): Deleted. * Source/WebCore/page/Quirks.h: * Source/WebCore/platform/Logging.h: * Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/267513@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 32a30d: Let the compiler generate more comparison operator...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 32a30dfe6ffb0b6380bca678439c115b60da5be9 https://github.com/WebKit/WebKit/commit/32a30dfe6ffb0b6380bca678439c115b60da5be9 Author: Chris Dumez Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/Modules/highlight/AppHighlightRangeData.h M Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.h M Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h M Source/WebCore/Modules/mediasession/MediaPositionState.h M Source/WebCore/Modules/permissions/PermissionDescriptor.h M Source/WebCore/Modules/webaudio/BaseAudioContext.h M Source/WebCore/PAL/pal/SessionID.h M Source/WebCore/contentextensions/ContentExtensionActions.cpp M Source/WebCore/contentextensions/ContentExtensionActions.h M Source/WebCore/contentextensions/ContentExtensionRule.h M Source/WebCore/contentextensions/NFAToDFA.cpp M Source/WebCore/contentextensions/Term.h M Source/WebCore/css/CSSCounterStyleDescriptors.h M Source/WebCore/css/CSSCounterStyleRegistry.cpp M Source/WebCore/css/CSSCustomPropertyValue.h M Source/WebCore/css/CSSFontFace.h M Source/WebCore/css/CSSGradientValue.cpp M Source/WebCore/css/CSSGradientValue.h Log Message: --- Let the compiler generate more comparison operators in WebCore https://bugs.webkit.org/show_bug.cgi?id=260943 Reviewed by Timothy Hatcher, Ryosuke Niwa and Darin Adler. Let the compiler generate more comparison operators in WebCore now that we support C++20. * Source/WebCore/Modules/highlight/AppHighlightRangeData.h: (WebCore::AppHighlightRangeData::NodePathComponent::operator== const): Deleted. * Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.h: (WebCore::IDBDatabaseIdentifier::operator== const): Deleted. * Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h: (WebCore::IDBResourceIdentifier::operator== const): Deleted. * Source/WebCore/Modules/mediasession/MediaPositionState.h: (WebCore::MediaPositionState::operator== const): Deleted. * Source/WebCore/Modules/permissions/PermissionDescriptor.h: (WebCore::PermissionDescriptor::operator== const): Deleted. * Source/WebCore/Modules/webaudio/BaseAudioContext.h: * Source/WebCore/PAL/pal/SessionID.h: (PAL::SessionID::operator== const): Deleted. * Source/WebCore/contentextensions/ContentExtensionActions.cpp: (WebCore::ContentExtensions::ModifyHeadersAction::operator== const): Deleted. (WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::operator== const): Deleted. (WebCore::ContentExtensions::RedirectAction::operator== const): Deleted. (WebCore::ContentExtensions::RedirectAction::URLTransformAction::operator== const): Deleted. (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::operator== const): Deleted. (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::operator== const): Deleted. * Source/WebCore/contentextensions/ContentExtensionActions.h: (WebCore::ContentExtensions::ActionWithoutMetadata::operator== const): Deleted. (WebCore::ContentExtensions::ActionWithStringMetadata::operator== const): Deleted. * Source/WebCore/contentextensions/ContentExtensionRule.h: (WebCore::ContentExtensions::Trigger::operator== const): Deleted. (WebCore::ContentExtensions::Action::operator== const): Deleted. (WebCore::ContentExtensions::ContentExtensionRule::operator== const): Deleted. * Source/WebCore/contentextensions/NFAToDFA.cpp: * Source/WebCore/contentextensions/Term.h: (WebCore::ContentExtensions::Term::CharacterSet::operator== const): Deleted. (WebCore::ContentExtensions::Term::Group::operator== const): Deleted. * Source/WebCore/css/CSSCounterStyleDescriptors.h: (WebCore::CSSCounterStyleDescriptors::operator== const): (WebCore::CSSCounterStyleDescriptors::Symbol::operator== const): Deleted. (WebCore::CSSCounterStyleDescriptors::Pad::operator== const): Deleted. (WebCore::CSSCounterStyleDescriptors::NegativeSymbols::operator== const): Deleted. * Source/WebCore/css/CSSCounterStyleRegistry.cpp: (WebCore::CSSCounterStyleRegistry::operator== const): * Source/WebCore/css/CSSCustomPropertyValue.h: * Source/WebCore/css/CSSFontFace.h: * Source/WebCore/css/CSSGradientValue.cpp: (WebCore::CSSLinearGradientValue::Angle::operator==): (WebCore::CSSPrefixedLinearGradientValue::operator==): (WebCore::CSSRadialGradientValue::operator==): (WebCore::CSSPrefixedRadialGradientValue::operator==): (WebCore::CSSConicGradientValue::operator==): * Source/WebCore/css/CSSGradientValue.h: (WebCore::CSSGradientColorInterpolationMethod::legacyMethod): (WebCore::operator==): Canonical link: https://commits.webkit.org/267512@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a9106: [32 bit] DFG graph generation: intrinsic getters a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a9106c7a56f0cd97901a535361ba5418900e058 https://github.com/WebKit/WebKit/commit/7a9106c7a56f0cd97901a535361ba5418900e058 Author: Joseph Griego Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A JSTests/stress/typed-array-intrinsic-getter-with-conflicting-value-profile.js M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp Log Message: --- [32 bit] DFG graph generation: intrinsic getters are fallible https://bugs.webkit.org/show_bug.cgi?id=260908 Reviewed by Yusuke Suzuki. On 32-bit, unlike 64-bit, some of the DFG intrinsic getters (really, the TypedArray ones) are _fallible_: if the SpeculatedType doesn't match our expecations (a non-strict subset of SpecInt32Only), we refuse to generate code. [1] However, DFG::ByteCodeParser::handleGetById doesn't appear to handle this case gracefully--if `handleIntrinsicGetter` fails, we attempt to generate a call to the getter, but in the case of TypedArray intrinsics, we won't have the necessary CallLinkStatus and while attempting to do so, we crash. To fix this, I've added a bit of code that handles the failure from handleIntrinsicGetter and emits an ordinary `GetById` node instead of trying to inline anything for this op. I've added a test that demonstrates the current behavior (a segfault) on armv7 and passes with tihs patch. [1] For what it's worth, maybe this shouldn't be the case: it does seem like we should still be able to generate code in these cases anyhow, but it's simpler to just cope with the failure. * JSTests/stress/typed-array-intrinsic-getter-with-conflicting-value-profile.js: Added. (foo): (i.null.foo.Object.create): (i.42.foo): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleGetById): Canonical link: https://commits.webkit.org/267511@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65b402: Remove PerformanceResourceTimingSensitivePropertie...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65b4029558faf9fbcbe7add5ea24465b1a448bc6 https://github.com/WebKit/WebKit/commit/65b4029558faf9fbcbe7add5ea24465b1a448bc6 Author: Anne van Kesteren Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/page/PerformanceResourceTiming.idl Log Message: --- Remove PerformanceResourceTimingSensitivePropertiesEnabled preference https://bugs.webkit.org/show_bug.cgi?id=260963 rdar://114763113 Reviewed by Alex Christensen. Simplify the code by removing a preference that no longer has a purpose. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/page/PerformanceResourceTiming.idl: Canonical link: https://commits.webkit.org/267510@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] af90c2: [prepare-ChangeLog] Handle versioned Perl/Python s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: af90c2a471d7f1ccacf90d1877db64452a124680 https://github.com/WebKit/WebKit/commit/af90c2a471d7f1ccacf90d1877db64452a124680 Author: Sam Sneddon Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Tools/Scripts/prepare-ChangeLog Log Message: --- [prepare-ChangeLog] Handle versioned Perl/Python shebangs https://bugs.webkit.org/show_bug.cgi?id=260918 Reviewed by Alexey Proskuryakov. * Tools/Scripts/prepare-ChangeLog: (get_function_line_ranges): Canonical link: https://commits.webkit.org/267509@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 762ed2: [Gardening]: REGRESSION(267119@main): [ macOS wk2 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 762ed20888ea28e0d7fe28e39e1a751472d6d429 https://github.com/WebKit/WebKit/commit/762ed20888ea28e0d7fe28e39e1a751472d6d429 Author: Ben Schwartz Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(267119@main): [ macOS wk2 release ] fast/repaint/placeholder-after-caps-lock-hidden.html is a constant timeout. rdar://114772162 https://bugs.webkit.org/show_bug.cgi?id=260974 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/267508@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f2410: [JSC] Make JSON.parse even faster with identifier-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f24101561da7ba92edc5b8efab210af2393c7a6 https://github.com/WebKit/WebKit/commit/1f24101561da7ba92edc5b8efab210af2393c7a6 Author: Yusuke Suzuki Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A JSTests/microbenchmarks/todomvc-javascript-es5-json-parse.js A JSTests/microbenchmarks/todomvc-javascript-es6-webpack-json-parse.js A JSTests/stress/ensure-json-put-does-not-see-may-be-prototype.js M Source/JavaScriptCore/runtime/JSObject.cpp M Source/JavaScriptCore/runtime/JSObject.h M Source/JavaScriptCore/runtime/JSObjectInlines.h M Source/JavaScriptCore/runtime/LiteralParser.cpp M Source/JavaScriptCore/runtime/LiteralParser.h M Source/JavaScriptCore/runtime/StructureInlines.h Log Message: --- [JSC] Make JSON.parse even faster with identifier-hint and putDirect fast path https://bugs.webkit.org/show_bug.cgi?id=260921 rdar://114715367 Reviewed by Keith Miller. This patch accelerates JSON.parse even more by introducing two optimizations. 1. We add IndeitiferHint to JSON.parse's lexing fast path. This slightly changes how we scan the string, given the information that this will be used as an identifier for objects. We swap the ordering of comparison for UChar JSON.parse in isSafeStringCharacterForIdentifier, since identifier is, in almost all cases, ASCII! 2. We found that `putDirect` function call in JSON.parse fast path is costly, and if we can inline the fast cases of this, we can get performance boost. Given that this is JSON.parse's fast path for JSObject creation, we know that a. The object is definitely JSFinalObject. b. The object rarely has duplicate properties. c. Many same-shaped objects would be created from JSON. Thus very likely, there is already an existing Structure. Based on this observation, we add super fast path in JSON.parse which does existing Structure transition quickly. 3. Added JSON.parse microbenchmarks extracted from Speedometer3.0. ToT Patched todomvc-javascript-es5-json-parse 58.1822+-0.2031 ^ 52.2885+-0.3449^ definitely 1.1127x faster vanilla-es2015-babel-webpack-todomvc-json-parse 57.4813+-0.5289 ^ 54.7597+-0.1805^ definitely 1.0497x faster todomvc-javascript-es6-webpack-json-parse 89.5463+-0.5104 ^ 83.3758+-0.5923^ definitely 1.0740x faster vanilla-es2015-todomvc-json-parse 57.2404+-0.4405 ^ 54.6702+-0.1448^ definitely 1.0470x faster vanilla-todomvc-json-parse 42.4967+-0.2446 ^ 40.6605+-0.0723^ definitely 1.0452x faster * JSTests/microbenchmarks/todomvc-javascript-es5-json-parse.js: Added. (test): * JSTests/microbenchmarks/todomvc-javascript-es6-webpack-json-parse.js: Added. (test): * Source/JavaScriptCore/runtime/JSObject.cpp: (JSC::JSObject::putDirectForJSONSlow): * Source/JavaScriptCore/runtime/JSObject.h: * Source/JavaScriptCore/runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal): * Source/JavaScriptCore/runtime/LiteralParser.cpp: (JSC::isJSONWhiteSpace): (JSC::LiteralParser::Lexer::lex): (JSC::LiteralParser::Lexer::next): (JSC::LiteralParser::Lexer::nextMaybeIdentifier): (JSC::isSafeStringCharacterForIdentifier): (JSC::LiteralParser::Lexer::lexString): (JSC::LiteralParser::parseRecursively): * Source/JavaScriptCore/runtime/LiteralParser.h: * Source/JavaScriptCore/runtime/StructureInlines.h: (JSC::Structure::addPropertyTransitionToExistingStructureImpl): Canonical link: https://commits.webkit.org/267507@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a902c: [IFC][BiDi] Fix fast/scrolling/rtl-scrollbars-elem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a902cee37d868ca599244e5343052dfd25bb300 https://github.com/WebKit/WebKit/commit/2a902cee37d868ca599244e5343052dfd25bb300 Author: Alan Baradlay Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp Log Message: --- [IFC][BiDi] Fix fast/scrolling/rtl-scrollbars-elementFromPoint-static.html https://bugs.webkit.org/show_bug.cgi?id=260964 Reviewed by Antti Koivisto. Vertical scrollbar on the left (user preference) imposes an offset on LTR content. e.g. _ | |This left to right content has | |scrollbar on the left. | | |_|| * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateInlineContentConstraints): Canonical link: https://commits.webkit.org/267506@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 416515: [Cocoa] VideoFullscreenInterfaceContext::m_manager...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4165157020d8e4b60062b5d144279c06b8c6c0ab https://github.com/WebKit/WebKit/commit/4165157020d8e4b60062b5d144279c06b8c6c0ab Author: Andy Estes Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Log Message: --- [Cocoa] VideoFullscreenInterfaceContext::m_manager should be a WeakPtr https://bugs.webkit.org/show_bug.cgi?id=260873 rdar://114654278 Reviewed by Jer Noble. Changed VideoFullscreenInterfaceContext::m_manager from a VideoFullscreenManager* to a WeakPtr. * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h: (WebKit::VideoFullscreenInterfaceContext::invalidate): Deleted. * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenInterfaceContext::VideoFullscreenInterfaceContext): (WebKit::VideoFullscreenManager::~VideoFullscreenManager): (WebKit::VideoFullscreenManager::removeContext): Canonical link: https://commits.webkit.org/267505@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd6d24: Unreviewed, fix cloop build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd6d24eb821c56b879594e5599f5a56246db https://github.com/WebKit/WebKit/commit/dd6d24eb821c56b879594e5599f5a56246db Author: Michael Catanzaro Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/JavaScriptCore/b3/air/testair.cpp Log Message: --- Unreviewed, fix cloop build https://bugs.webkit.org/show_bug.cgi?id=260966 * Source/JavaScriptCore/b3/air/testair.cpp: Canonical link: https://commits.webkit.org/267504@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 855a2c: [GTK][WPE] Do not use epoxy PlatformDisplay::creat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 855a2ca13f6a85b0aacb0576fbbc9a926e646b2e https://github.com/WebKit/WebKit/commit/855a2ca13f6a85b0aacb0576fbbc9a926e646b2e Author: Carlos Garcia Campos Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/PlatformDisplay.cpp Log Message: --- [GTK][WPE] Do not use epoxy PlatformDisplay::create|destroyEGLImage https://bugs.webkit.org/show_bug.cgi?id=260968 Reviewed by Michael Catanzaro. libepoxy needs a current context to work, but creating EGL images doesn't need any context, it's display API. * Source/WebCore/platform/graphics/PlatformDisplay.cpp: (WebCore::PlatformDisplay::createEGLImage const): (WebCore::PlatformDisplay::destroyEGLImage const): Canonical link: https://commits.webkit.org/267503@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d4251: Move test that are directly under fast/ to subdire...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d425142d355653ac95b46d152e46db2c2c12a2d https://github.com/WebKit/WebKit/commit/2d425142d355653ac95b46d152e46db2c2c12a2d Author: Antti Koivisto Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: R LayoutTests/fast/check-layout-error-no-attributes-expected.txt R LayoutTests/fast/check-layout-error-no-attributes.html A LayoutTests/fast/css/check-layout-error-no-attributes-expected.txt A LayoutTests/fast/css/check-layout-error-no-attributes.html A LayoutTests/fast/css/has-sibling-without-parent-crash-expected.html A LayoutTests/fast/css/has-sibling-without-parent-crash.html R LayoutTests/fast/has-sibling-without-parent-crash-expected.html R LayoutTests/fast/has-sibling-without-parent-crash.html Log Message: --- Move test that are directly under fast/ to subdirectories https://bugs.webkit.org/show_bug.cgi?id=260948 rdar://114746451 Unreviewed test moving. * LayoutTests/fast/css/check-layout-error-no-attributes-expected.txt: Renamed from LayoutTests/fast/check-layout-error-no-attributes-expected.txt. * LayoutTests/fast/css/check-layout-error-no-attributes.html: Renamed from LayoutTests/fast/check-layout-error-no-attributes.html. * LayoutTests/fast/css/has-sibling-without-parent-crash-expected.html: Renamed from LayoutTests/fast/has-sibling-without-parent-crash-expected.html. * LayoutTests/fast/css/has-sibling-without-parent-crash.html: Renamed from LayoutTests/fast/has-sibling-without-parent-crash.html. Canonical link: https://commits.webkit.org/267502@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 778f6c: [GTK] Remove webkitWebViewBaseMakeGLContextCurrent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 778f6cd65a7ad987dfbb6eab18927339f6536b9c https://github.com/WebKit/WebKit/commit/778f6cd65a7ad987dfbb6eab18927339f6536b9c Author: Carlos Garcia Campos Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStore.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.h M Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp Log Message: --- [GTK] Remove webkitWebViewBaseMakeGLContextCurrent https://bugs.webkit.org/show_bug.cgi?id=260965 Reviewed by Michael Catanzaro. This is a leftover from the nested wayland compositor and it's now unused. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseMakeGLContextCurrent): Deleted. * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/gtk/AcceleratedBackingStore.h: (WebKit::AcceleratedBackingStore::unrealize): (WebKit::AcceleratedBackingStore::makeContextCurrent): Deleted. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::makeContextCurrent): Deleted. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.h: * Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp: (WebKit::WebPageProxy::makeGLContextCurrent): Deleted. Canonical link: https://commits.webkit.org/267501@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 630bb6: Add some libwebrtc logging in case of packet loss ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 630bb64e52ef650fa4d6c60b9ea3547db20d31e5 https://github.com/WebKit/WebKit/commit/630bb64e52ef650fa4d6c60b9ea3547db20d31e5 Author: Youenn Fablet Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/send_side_bandwidth_estimation.cc Log Message: --- Add some libwebrtc logging in case of packet loss triggering bandwidth estimation reduction https://bugs.webkit.org/show_bug.cgi?id=260950 rdar://problem/114747794 Reviewed by Jean-Yves Avenard. In case of ex excessive packet loss, bandwidth gets reduced, we now log this at info level. * Source/ThirdParty/libwebrtc/Source/webrtc/modules/congestion_controller/goog_cc/send_side_bandwidth_estimation.cc: Canonical link: https://commits.webkit.org/267500@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ea25d: Further migrate some scripts in WPT workers/module...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ea25d9b008d180395413d471014af97d79c2589 https://github.com/WebKit/WebKit/commit/9ea25d9b008d180395413d471014af97d79c2589 Author: Youenn Fablet Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-credentials-checker-worker.sub.js M LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-script-worker.sub.js M LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/static-import-remote-origin-credentials-checker-worker.sub.js M LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/static-import-remote-origin-script-worker.sub.js M LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt Log Message: --- Further migrate some scripts in WPT workers/module from domains[www1] to hosts[alt][] https://bugs.webkit.org/show_bug.cgi?id=260901 rdar://114696293 Reviewed by Tim Nguyen. This allows properly running the tests in Cocoa test infrastructure as they would pass from wpt.live. We remove some GTK/WPE test expectations since they are now the same as the global ones. * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-credentials-checker-worker.sub.js: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/dynamic-import-remote-origin-script-worker.sub.js: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/static-import-remote-origin-credentials-checker-worker.sub.js: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/resources/static-import-remote-origin-script-worker.sub.js: * LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import.any.worker-expected.txt: Removed. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt: Removed. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt: Removed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt: Removed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/workers/modules/shared-worker-import.window-expected.txt: Removed. Canonical link: https:/
[webkit-changes] [WebKit/WebKit] 94fe30: Correct dynamic handling of elements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94fe30e306b57acc3a62e6bd75351fee3a393972 https://github.com/WebKit/WebKit/commit/94fe30e306b57acc3a62e6bd75351fee3a393972 Author: Anne van Kesteren Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/fetch/fetch-url-serialization-expected.txt M LayoutTests/fetch/fetch-urls.json A LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-data-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-data.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-javascript-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-javascript.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element-origin.js M LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element.js M Source/WebCore/dom/Document.cpp M Source/WebCore/html/HTMLBaseElement.cpp Log Message: --- Correct dynamic handling of elements https://bugs.webkit.org/show_bug.cgi?id=260959 rdar://114756660 Reviewed by Chris Dumez. Document::processBaseElement did not call Document::updateBaseURL when there was something wrong with the new base URL. However, that meant that a newly inserted "blocked" would not impact the document base URL and instead whatever was the prior document base URL would continue to be used. This goes against the HTML standard which requires the first element to be used at all times and if that is "blocked" the fallback base URL would have to be used (typically the document's URL). Tests are upstreamed via https://github.com/web-platform-tests/wpt/pull/41731. Chromium matches our failure, but given that it's an edge case I don't foresee any issues. While we're in the general area, stop invoking Document::processBaseElement for elements not connected to a document as that results in a no-op tree traversal. * LayoutTests/fetch/fetch-url-serialization-expected.txt: * LayoutTests/fetch/fetch-urls.json: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-data-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-data.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-javascript-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base-javascript.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element-origin.js: (runURLTests): * LayoutTests/imported/w3c/web-platform-tests/url/resources/a-element.js: * Source/WebCore/dom/Document.cpp: (WebCore::Document::processBaseElement): * Source/WebCore/html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::attributeChanged): Canonical link: https://commits.webkit.org/267498@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8ea32: Use an enum class for SVGPathSegType
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8ea32b01fdae3f7c9373634db5ea6c6764b7575 https://github.com/WebKit/WebKit/commit/f8ea32b01fdae3f7c9373634db5ea6c6764b7575 Author: Chris Dumez Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/bindings/js/JSSVGPathSegCustom.cpp M Source/WebCore/svg/SVGPathBlender.cpp M Source/WebCore/svg/SVGPathByteStream.h M Source/WebCore/svg/SVGPathByteStreamBuilder.cpp M Source/WebCore/svg/SVGPathByteStreamBuilder.h M Source/WebCore/svg/SVGPathByteStreamSource.cpp M Source/WebCore/svg/SVGPathByteStreamSource.h M Source/WebCore/svg/SVGPathParser.cpp M Source/WebCore/svg/SVGPathParser.h M Source/WebCore/svg/SVGPathSeg.h M Source/WebCore/svg/SVGPathSeg.idl M Source/WebCore/svg/SVGPathSegImpl.h M Source/WebCore/svg/SVGPathSegListSource.cpp M Source/WebCore/svg/SVGPathStringViewSource.cpp Log Message: --- Use an enum class for SVGPathSegType https://bugs.webkit.org/show_bug.cgi?id=260930 Reviewed by Ryosuke Niwa. Use an enum class for SVGPathSegType instead of an old enum. Use uint8_t as underlying type and update SVGPathByteStreamBuilder & SVGPathByteStreamSource to encode/decode it as a uint8_t instead of an `unsigned short`. * Source/WebCore/svg/SVGPathBlender.cpp: (WebCore::coordinateModeOfCommand): (WebCore::isSegmentEqual): (WebCore::SVGPathBlender::canBlendPaths): (WebCore::SVGPathBlender::blendAnimatedPath): * Source/WebCore/svg/SVGPathByteStreamBuilder.cpp: (WebCore::SVGPathByteStreamBuilder::moveTo): (WebCore::SVGPathByteStreamBuilder::lineTo): (WebCore::SVGPathByteStreamBuilder::lineToHorizontal): (WebCore::SVGPathByteStreamBuilder::lineToVertical): (WebCore::SVGPathByteStreamBuilder::curveToCubic): (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth): (WebCore::SVGPathByteStreamBuilder::curveToQuadratic): (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth): (WebCore::SVGPathByteStreamBuilder::arcTo): (WebCore::SVGPathByteStreamBuilder::closePath): * Source/WebCore/svg/SVGPathByteStreamBuilder.h: * Source/WebCore/svg/SVGPathParser.cpp: (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parsePathData): * Source/WebCore/svg/SVGPathParser.h: * Source/WebCore/svg/SVGPathSeg.h: * Source/WebCore/svg/SVGPathSegListSource.cpp: (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseLineToHorizontalSegment): (WebCore::SVGPathSegListSource::parseLineToVerticalSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSegment): (WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathSegListSource::parseArcToSegment): * Source/WebCore/svg/SVGPathStringViewSource.cpp: (WebCore::nextCommandHelper): (WebCore::SVGPathStringViewSource::parseSVGSegmentType): Canonical link: https://commits.webkit.org/267497@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93f874: Fix removed-in-Python-3.12 deprecations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93f8745ec911a80187109e33a70172e08fdd6583 https://github.com/WebKit/WebKit/commit/93f8745ec911a80187109e33a70172e08fdd6583 Author: Sam Sneddon Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebKit/Scripts/webkit/parser_unittest.py M Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py M Tools/Scripts/webkitpy/benchmark_runner/utils.py M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py M Tools/Scripts/webkitpy/common/prettypatch_unittest.py M Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py R Tools/Scripts/webkitpy/common/webkitunittest.py M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py M Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py M Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py M Tools/Scripts/webkitpy/tool/commands/commandtest.py M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py Log Message: --- Fix removed-in-Python-3.12 deprecations https://bugs.webkit.org/show_bug.cgi?id=260878 Reviewed by Michael Catanzaro. This largely just deals with the long-deprecated unittest deprecations: * assertRegexpMatches -> assertRegex * assertNotRegexpMatches -> assertNotRegex * assertRaisesRegexp -> assertRaisesRegex * assertEquals -> assertEqual Additionally, this gets rid of usage of distutils (gone in Python 3.12) and imp (also gone in Python 3.12). * Source/WebKit/Scripts/webkit/parser_unittest.py: (UnsupportedPrecompilerDirectiveTest.assertRaisesRegex): (UnsupportedPrecompilerDirectiveTest.test_error_at_else): (UnsupportedPrecompilerDirectiveTest.test_error_at_elif): * Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: (BenchmarkResultsTest.assertRaisesRegex): (BenchmarkResultsTest.test_init): * Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: * Tools/Scripts/webkitpy/benchmark_runner/utils.py: (load_source): (load_subclasses): * Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (SCMTest.assertRegex): (SCMTest): (SCMTest.assertNotRegex): (SCMTest._shared_test_diff_for_revision): (test_commit_logs): (GitTest.test_create_patch): (GitTest.test_create_patch_with_git_index): (GitTest.test_rename_files): (GitSVNTest.test_delete_branch): (GitSVNTest.test_remote_merge_base): (GitSVNTest.test_commit_with_message_working_copy_only): (GitSVNTest.test_commit_with_message): (GitSVNTest.test_commit_with_message_git_commit): (GitSVNTest.test_commit_with_message_git_commit_range): (GitSVNTest.test_commit_with_message_only_local_commit): (GitSVNTest.test_commit_with_message_multiple_local_commits_and_working_copy): (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash): (GitSVNTest.test_commit_with_message_multiple_local_commits): (GitSVNTest.test_commit_with_message_not_synced): (GitSVNTest.test_create_patch_local_plus_working_copy): (GitSVNTest.test_create_patch): (GitSVNTest.test_create_patch_after_merge): (GitSVNTest.test_create_patch_with_changed_files): (GitSVNTest.test_create_patch_git_commit): (GitSVNTest.test_create_patch_git_commit_range): (GitSVNTest.test_create_patch_working_copy_only): (GitSVNTest.test_create_patch_multiple_local_commits): (GitSVNTest.test_create_patch_not_synced): (GitSVNTest.test_create_binary_patch): * Tools/Scripts/webkitpy/common/prettypatch_unittest.py: (PrettyPatchTest.check_ruby): * Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: (WatchListParserTest): (WatchListParserTest.setUp): * Tools/Scripts/webkitpy/common/webkitunittest.py: Removed. * Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: * Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.assertRaisesRegex): (XvfbDriverTest.test_xvfb_not_replying): * Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: (ApplyWatchListLocalTest.assertRaisesRegex): (test_args_parsing_with_two_bugs): * Tools/Scripts/webkitpy/tool/commands/commandtest.py: (CommandsTest): * Tools/Scripts/webkitpy/w3c/test_converter_unittest.py: (verify_test_harness_paths): Canonical link: https://commits.webkit.org/267496@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a2b1a: [IFC] Do not try to measure text content across In...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a2b1a5111fec39251c05deff1f97ae9d5849354 https://github.com/WebKit/WebKit/commit/1a2b1a5111fec39251c05deff1f97ae9d5849354 Author: Alan Baradlay Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: A LayoutTests/fast/text/complex-text-with-bidi-boundary-crash-expected.txt A LayoutTests/fast/text/complex-text-with-bidi-boundary-crash.html M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp Log Message: --- [IFC] Do not try to measure text content across InlineItems https://bugs.webkit.org/show_bug.cgi?id=260935 Reviewed by Antti Koivisto. This happens when ubidi_getLogicalRun makes us split inside a cluster (bug?) producing multiple InlineItems. (simplifiedMinimumInstrinsicWidthBreak extra check is added to mirror what we already do at the slow codepath) * LayoutTests/fast/text/complex-text-with-bidi-boundary-crash-expected.txt: Added. * LayoutTests/fast/text/complex-text-with-bidi-boundary-crash.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp: (WebCore::Layout::InlineContentBreaker::simplifiedMinimumInstrinsicWidthBreak const): * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::firstUserPerceivedCharacterLength): Canonical link: https://commits.webkit.org/267495@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 734bc0: [IFC][out-of-flow bidi] Fix fast/block/positioning...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 734bc0ccb57e1b4e5cc80d8474769f85c8f0ec5d https://github.com/WebKit/WebKit/commit/734bc0ccb57e1b4e5cc80d8474769f85c8f0ec5d Author: Alan Baradlay Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/rendering/RenderInline.cpp Log Message: --- [IFC][out-of-flow bidi] Fix fast/block/positioning/absolute-in-inline-rtl(3).html https://bugs.webkit.org/show_bug.cgi?id=260940 Reviewed by Antti Koivisto. Add missing RTL support in RenderInline::innerPaddingBoxWidth. * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::innerPaddingBoxWidth const): Canonical link: https://commits.webkit.org/267494@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3b8ad: Addressing review feedback from 267490@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3b8ad19792f0ebd4418dd1dab3b76ff4b752ea1 https://github.com/WebKit/WebKit/commit/c3b8ad19792f0ebd4418dd1dab3b76ff4b752ea1 Author: Myles C. Maxfield Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/wtf/text/TextStream.cpp M Source/WTF/wtf/text/TextStream.h M Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp Log Message: --- Addressing review feedback from 267490@main https://bugs.webkit.org/show_bug.cgi?id=260956 rdar://114751994 Reviewed by Simon Fraser. Addressing review feedback from https://github.com/WebKit/WebKit/pull/17269#pullrequestreview-1603946683 * Source/WTF/wtf/text/TextStream.cpp: (WTF::TextStream::operator<<): * Source/WTF/wtf/text/TextStream.h: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp: (TEST): Canonical link: https://commits.webkit.org/267493@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ebb0e: [Cocoa] Slightly improve text shaping logging
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ebb0e8d48f4262ebf64f5f3bcc0a080c2d83c11 https://github.com/WebKit/WebKit/commit/3ebb0e8d48f4262ebf64f5f3bcc0a080c2d83c11 Author: Myles C. Maxfield Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp Log Message: --- [Cocoa] Slightly improve text shaping logging https://bugs.webkit.org/show_bug.cgi?id=260942 rdar://114742142 Reviewed by Cameron McCormack. This additional logging helped me fix a bug I was investigating. No test because there is no behavior change. * Source/WebCore/platform/graphics/coretext/FontCoreText.cpp: (WebCore::Font::applyTransforms const): Canonical link: https://commits.webkit.org/267492@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aed2f1: Don’t open “details” when interacting with interac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aed2f1dba4a42f57914f579efc8f76b7c9fe8f3e https://github.com/WebKit/WebKit/commit/aed2f1dba4a42f57914f579efc8f76b7c9fe8f3e Author: Michael[tm] Smith Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html M Source/WebCore/html/HTMLSummaryElement.cpp Log Message: --- Don’t open “details” when interacting with interactive “summary” descendants https://bugs.webkit.org/show_bug.cgi?id=218758 Reviewed by Tim Nguyen. This change ensures that interacting with (clicking/pressing/etc.) any interactive descendants of a “summary” element will trigger the activation behavior of those descendants themselves — rather than instead triggering the “summary” element’s “details” parent to open. Otherwise, without this change, the activation behavior of interactive content within a “summary” element will get triggered only if that interactive content is a direct child of the “summary” element. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html: Added. * Source/WebCore/html/HTMLSummaryElement.cpp: (WebCore::isInSummaryInteractiveContent): (WebCore::HTMLSummaryElement::defaultEventHandler): (WebCore::isClickableControl): Deleted. Canonical link: https://commits.webkit.org/267491@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a65bf7: Allow hex() to be used with LOG_WITH_STREAM()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a65bf781e6e6cb1dbc09b0686b44c940f276823d https://github.com/WebKit/WebKit/commit/a65bf781e6e6cb1dbc09b0686b44c940f276823d Author: Myles C. Maxfield Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/wtf/text/TextStream.cpp M Source/WTF/wtf/text/TextStream.h M Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp Log Message: --- Allow hex() to be used with LOG_WITH_STREAM() https://bugs.webkit.org/show_bug.cgi?id=260945 rdar://114742843 Reviewed by Simon Fraser. TextStream just needs to be able to use the return type of hex(). * Source/WTF/wtf/text/TextStream.cpp: (WTF::TextStream::operator<<): * Source/WTF/wtf/text/TextStream.h: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp: (TEST): Canonical link: https://commits.webkit.org/267490@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40a802: Remove ReferrerPolicyAttributeEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40a802ea75efb7a7fdbc874411b02696fd571aeb https://github.com/WebKit/WebKit/commit/40a802ea75efb7a7fdbc874411b02696fd571aeb Author: Anne van Kesteren Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/html/HTMLAnchorElement.idl M Source/WebCore/html/HTMLAreaElement.idl M Source/WebCore/html/HTMLIFrameElement.cpp M Source/WebCore/html/HTMLIFrameElement.idl M Source/WebCore/html/HTMLImageElement.cpp M Source/WebCore/html/HTMLImageElement.idl M Source/WebCore/html/HTMLLinkElement.cpp M Source/WebCore/html/HTMLLinkElement.idl M Source/WebCore/html/HTMLScriptElement.cpp M Source/WebCore/html/HTMLScriptElement.idl M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h Log Message: --- Remove ReferrerPolicyAttributeEnabled preference https://bugs.webkit.org/show_bug.cgi?id=260905 rdar://114702566 Reviewed by Youenn Fablet. This enables the referrerpolicy attribute in WK1 as having additional branching isn't beneficial for this feature. And it removes the corresponding preference at the same time. WKPreferencesSetReferrerPolicyAttributeEnabled and WKPreferencesGetReferrerPolicyAttributeEnabled are deprecated, but not removed to retain binary compatibility. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::referrerPolicy const): * Source/WebCore/html/HTMLAnchorElement.idl: * Source/WebCore/html/HTMLAreaElement.idl: * Source/WebCore/html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::referrerPolicy const): * Source/WebCore/html/HTMLIFrameElement.idl: * Source/WebCore/html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attributeChanged): (WebCore::HTMLImageElement::referrerPolicy const): * Source/WebCore/html/HTMLImageElement.idl: * Source/WebCore/html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::referrerPolicy const): * Source/WebCore/html/HTMLLinkElement.idl: * Source/WebCore/html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::referrerPolicy const): * Source/WebCore/html/HTMLScriptElement.idl: * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetReferrerPolicyAttributeEnabled): (WKPreferencesGetReferrerPolicyAttributeEnabled): * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences referrerPolicyAttributeEnabled]): Deleted. (-[WebPreferences setReferrerPolicyAttributeEnabled:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/267489@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5959d: Web Inspector: support OffscreenCanvas for Canvas ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5959d78adc403bde81fdad57864ec9fcf73fa21 https://github.com/WebKit/WebKit/commit/b5959d78adc403bde81fdad57864ec9fcf73fa21 Author: Devin Rousso Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M LayoutTests/inspector/canvas/create-context-2d-expected.txt M LayoutTests/inspector/canvas/create-context-2d.html M LayoutTests/inspector/canvas/create-context-bitmaprenderer-expected.txt M LayoutTests/inspector/canvas/create-context-bitmaprenderer.html M LayoutTests/inspector/canvas/create-context-webgl-expected.txt M LayoutTests/inspector/canvas/create-context-webgl.html M LayoutTests/inspector/canvas/create-context-webgl2-expected.txt M LayoutTests/inspector/canvas/create-context-webgl2.html M LayoutTests/inspector/canvas/resources/create-context-utilities.js A LayoutTests/inspector/canvas/resources/worker.js M Source/JavaScriptCore/inspector/protocol/Canvas.json M Source/JavaScriptCore/inspector/protocol/Recording.json M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/CanvasBase.h M Source/WebCore/inspector/InspectorCanvas.cpp M Source/WebCore/inspector/InspectorController.cpp M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/InstrumentingAgents.h M Source/WebCore/inspector/WorkerInspectorController.cpp M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp M Source/WebCore/inspector/agents/InspectorCanvasAgent.h A Source/WebCore/inspector/agents/page/PageCanvasAgent.cpp A Source/WebCore/inspector/agents/page/PageCanvasAgent.h A Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.cpp A Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.h M Source/WebCore/workers/WorkerConsoleClient.cpp M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js M Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js M Source/WebInspectorUI/UserInterface/Models/Canvas.js M Source/WebInspectorUI/UserInterface/Models/Geometry.js M Source/WebInspectorUI/UserInterface/Models/Recording.js M Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js M Source/WebInspectorUI/UserInterface/Protocol/CanvasObserver.js M Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js Log Message: --- Web Inspector: support OffscreenCanvas for Canvas related operations https://bugs.webkit.org/show_bug.cgi?id=180833 Reviewed by Patrick Angle. * Source/JavaScriptCore/inspector/protocol/Canvas.json: * Source/JavaScriptCore/inspector/protocol/Recording.json: Expose the entire domain (minus a few commands/events) to the `"worker"` target. * Source/WebCore/inspector/InspectorController.cpp: (WebCore::InspectorController::createLazyAgents): * Source/WebCore/inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::createLazyAgents): * Source/WebCore/inspector/agents/InspectorCanvasAgent.h: * Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp: (WebCore::InspectorCanvasAgent::InspectorCanvasAgent): (WebCore::InspectorCanvasAgent::enable): (WebCore::InspectorCanvasAgent::disable): (WebCore::InspectorCanvasAgent::enabled const): Added. (WebCore::InspectorCanvasAgent::internalEnable): Added. (WebCore::InspectorCanvasAgent::internalDisable): Added. (WebCore::InspectorCanvasAgent::didChangeCanvasSize): Added. (WebCore::InspectorCanvasAgent::didChangeCanvasMemory): (WebCore::InspectorCanvasAgent::unbindCanvas): (WebCore::InspectorCanvasAgent::requestNode): Deleted. (WebCore::InspectorCanvasAgent::requestClientNodes): Deleted. (WebCore::InspectorCanvasAgent::frameNavigated): Deleted. (WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes): Deleted. * Source/WebCore/inspector/agents/page/PageCanvasAgent.h: Added. * Source/WebCore/inspector/agents/page/PageCanvasAgent.cpp: Added. (WebCore::PageCanvasAgent::PageCanvasAgent): (WebCore::PageCanvasAgent::enabled const): (WebCore::PageCanvasAgent::internalEnable): (WebCore::PageCanvasAgent::internalDisable): (WebCore::PageCanvasAgent::requestNode): (WebCore::PageCanvasAgent::requestClientNodes): (WebCore::PageCanvasAgent::frameNavigated): (WebCore::PageCanvasAgent::didChangeCSSCanvasClientNodes): (WebCore::PageCanvasAgent::matchesCurrentContext const): * Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.h: Added. * Source/WebCore/inspector/agents/worker/WorkerCanvasAgent.cpp: Added. (WebCore::WorkerCanvasAgent::WorkerCanvasAgent): (WebCore::WorkerCanvasAgent::requestNode): (WebCore::WorkerCanvasAgent::requestClientNodes): (WebCore::WorkerCanvasAgent::matchesCurrentContext const): Split `InspectorCanvasAgent` into `PageCanvasAgent` and `WorkerCan
