[webkit-changes] [WebKit/WebKit] 1f4519: Compare pointers first in CSSCustomPropertyValue::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f4519fc48941d23c7d19b67abe97afbd9aa638e https://github.com/WebKit/WebKit/commit/1f4519fc48941d23c7d19b67abe97afbd9aa638e Author: Simon Fraser Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/css/CSSCustomPropertyValue.cpp Log Message: --- Compare pointers first in CSSCustomPropertyValue::equals() https://bugs.webkit.org/show_bug.cgi?id=261057 rdar://114854431 Reviewed by Chris Dumez. When CSSCustomPropertyValue holds a variant type that is a pointer, do pointer comparison first before comparing values. This avoids calls to the expensive `CSSVariableData::operator==`, which gives a measurable perf boost on some Speedometer 3 subtests with lots of custom properties. * Source/WebCore/css/CSSCustomPropertyValue.cpp: (WebCore::CSSCustomPropertyValue::equals const): Canonical link: https://commits.webkit.org/267578@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1dc257: Some code incorrectly compares Document objects us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dc257f3194c1771300e2b81f8edce1f41cd7e62 https://github.com/WebKit/WebKit/commit/1dc257f3194c1771300e2b81f8edce1f41cd7e62 Author: Chris Dumez Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/editing/cocoa/EditorCocoa.mm M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.cpp Log Message: --- Some code incorrectly compares Document objects using CSSParserContext's comparison operator https://bugs.webkit.org/show_bug.cgi?id=261044 Reviewed by Ryosuke Niwa and Darin Adler. Use a named operator==() in CSSParserContext to avoid so that can no longer happen and fix code doing bad comparisons. * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::operator==): Deleted. * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/editing/cocoa/EditorCocoa.mm: (WebCore::Editor::replaceNodeFromPasteboard): * Source/WebCore/html/HTMLElement.cpp: (WebCore::checkPopoverValidity): * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation const): Canonical link: https://commits.webkit.org/267577@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9dc842: Deploy more smart pointers in Source/WebKit/UIProc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9dc842ed6c6bdb25124016c8614de1f2bbbe3a23 https://github.com/WebKit/WebKit/commit/9dc842ed6c6bdb25124016c8614de1f2bbbe3a23 Author: Ryosuke Niwa Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp M Source/WebKit/UIProcess/API/APIContentWorld.cpp M Source/WebKit/UIProcess/API/APIContentWorld.h M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/C/WKInspector.cpp M Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp M Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.h M Source/WebKit/UIProcess/Inspector/InspectorTargetProxy.cpp M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp M Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h M Source/WebKit/UIProcess/Inspector/WebPageInspectorAgentBase.h M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h M Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp M Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm M Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp Log Message: --- Deploy more smart pointers in Source/WebKit/UIProcess/Inspector https://bugs.webkit.org/show_bug.cgi?id=260848 Reviewed by Chris Dumez. This PR addresses clang static analyzer warnings for smart pointers. * Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp: (API::ContentRuleListStore::defaultStore): * Source/WebKit/UIProcess/API/APIContentWorld.cpp: (API::ContentWorld::~ContentWorld): (API::ContentWorld::addAssociatedUserContentControllerProxy): (API::ContentWorld::userContentControllerProxyDestroyed): * Source/WebKit/UIProcess/API/APIContentWorld.h: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::delaysWebProcessLaunchUntilFirstLoad const): * Source/WebKit/UIProcess/API/C/WKInspector.cpp: (WKInspectorGetPage): * Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.cpp: (WebKit::InspectorBrowserAgent::enabled const): (WebKit::InspectorBrowserAgent::enable): (WebKit::InspectorBrowserAgent::disable): * Source/WebKit/UIProcess/Inspector/Agents/InspectorBrowserAgent.h: * Source/WebKit/UIProcess/Inspector/InspectorTargetProxy.cpp: (WebKit::InspectorTargetProxy::create): * Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp: (WebKit::RemoteWebInspectorUIProxy::protectedInspectorPage): (WebKit::RemoteWebInspectorUIProxy::setDiagnosticLoggingAvailable): (WebKit::RemoteWebInspectorUIProxy::initialize): (WebKit::RemoteWebInspectorUIProxy::showConsole): (WebKit::RemoteWebInspectorUIProxy::showResources): (WebKit::RemoteWebInspectorUIProxy::sendMessageToFrontend): (WebKit::RemoteWebInspectorUIProxy::frontendDidClose): (WebKit::RemoteWebInspectorUIProxy::setInspectorPageDeveloperExtrasEnabled): (WebKit::RemoteWebInspectorUIProxy::sendMessageToBackend): (WebKit::RemoteWebInspectorUIProxy::createFrontendPageAndWindow): (WebKit::RemoteWebInspectorUIProxy::closeFrontendPageAndWindow): * Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h: (): Deleted. * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp: (WebKit::WebInspectorUIProxy::inspectionLevel const): (WebKit::WebInspectorUIProxy::inspectorPagePreferences const): (WebKit::WebInspectorUIProxy::createFrontendPage): (WebKit::WebInspectorUIProxy::openLocalInspectorFrontend): (WebKit::WebInspectorUIProxy::closeFrontendPageAndWindow): (WebKit::WebInspectorUIProxy::sendMessageToBackend): (WebKit::WebInspectorUIProxy::frontendLoaded): (WebKit::WebInspectorUIProxy::attachAvailabilityChanged): (WebKit::WebInspectorUIProxy::setDeveloperPreferenceOverride): (WebKit::WebInspectorUIProxy::setEmulatedConditions): (WebKit::WebInspectorUIProxy::evaluateInFrontendForTesting): * Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h: (WebKit::WebInspectorUIProxy::inspectedPage const): (WebKit::WebInspectorUIProxy::inspectorPage const): * Source/WebKit/UIProcess/Inspector/WebPageInspectorAgentBase.h: * Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp: (WebKit::WebPageInspectorController::protectedInspectedPage): (WebKit::WebPageInspectorController::init): (WebKit::WebPageInspectorController::connectFrontend): (WebKit::WebPageInspectorController::disconnectFrontend): (WebKit::WebPageInspectorController::disconnectAllFrontends): (WebKit::WebPageInspectorController::setIndicating): (WebKit::WebPageInspectorController::createInspectorTarget):
[webkit-changes] [WebKit/WebKit] 301208: nullptr dereference in WebCore::WebSocket::close()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30120862ed93a186f9e5b364f4bf090caa7f35f0 https://github.com/WebKit/WebKit/commit/30120862ed93a186f9e5b364f4bf090caa7f35f0 Author: David Kilzer Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/Modules/websockets/WebSocket.cpp Log Message: --- nullptr dereference in WebCore::WebSocket::close() https://bugs.webkit.org/show_bug.cgi?id=261037 Reviewed by Alex Christensen. * Source/WebCore/Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::close): - Add `nullptr` check for `m_channel`. Canonical link: https://commits.webkit.org/267575@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2848e7: Import webvtt/api WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2848e7016e7337f3b4365a42d73e51d05935cea6 https://github.com/WebKit/WebKit/commit/2848e7016e7337f3b4365a42d73e51d05935cea6 Author: Kohei Ueno Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/categories.json A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/common.js A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/constructor-exceptions-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/constructor-exceptions.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/constructor-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/constructor.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/lineAlign-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/lineAlign.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/position-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/position.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/positionAlign-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/positionAlign.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/region-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/region.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/constructor-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/constructor.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/id-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/id.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/lines-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/lines.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/non-visible-cue-with-region-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/non-visible-cue-with-region.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/regionAnchorX-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/regionAnchorX.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/regionAnchorY-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/regionAnchorY.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/scroll-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/scroll.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/viewportAnchorX-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/viewportAnchorX.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/viewportAnchorY-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/viewportAnchorY.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/width-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/width.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/categories.json A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical.html A
[webkit-changes] [WebKit/WebKit] b10b93: [Gardening]: [ macOS ] Removing outdated crash exp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b10b93f73f62c9c26cba9abbf562e2f265a13755 https://github.com/WebKit/WebKit/commit/b10b93f73f62c9c26cba9abbf562e2f265a13755 Author: Ben Schwartz Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ macOS ] Removing outdated crash expectations. rdar://83591040 rdar://83592102 Unreviewed test gardening: removed two sets of test crash expectations as they are no longer crashing. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/267573@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f6c2e: Expose platform specific initialization of GPU Pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f6c2e880164c1d4dac1234d14b0dbee33c99dae https://github.com/WebKit/WebKit/commit/4f6c2e880164c1d4dac1234d14b0dbee33c99dae Author: Don Olmstead Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/GPUProcess/GPUProcess.h M Source/WebKit/GPUProcess/glib/GPUProcessGLib.cpp M Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp M Source/WebKit/GPUProcess/win/GPUProcessWin.cpp Log Message: --- Expose platform specific initialization of GPU Process https://bugs.webkit.org/show_bug.cgi?id=257895 Reviewed by Myles C. Maxfield. Expose the method `GPUProcess::platformInitializeGPUProcess` for all ports to do any platform specific routines at start up. This mirrors the behavior of the Web and Network process. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::initializeGPUProcess): * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/glib/GPUProcessGLib.cpp: (WebKit::GPUProcess::platformInitializeGPUProcess): * Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp: (WebKit::GPUProcess::platformInitializeGPUProcess): * Source/WebKit/GPUProcess/win/GPUProcessWin.cpp: (WebKit::GPUProcess::platformInitializeGPUProcess): Canonical link: https://commits.webkit.org/267572@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 607f89: [Gardening]: REGRESSION(267516@main): [ macOS ] ed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 607f89ab88cf9b681a684fd3f624978710181f38 https://github.com/WebKit/WebKit/commit/607f89ab88cf9b681a684fd3f624978710181f38 Author: Ben Schwartz Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: R LayoutTests/platform/mac/editing/selection/context-menu-text-selection-lookup-expected.txt Log Message: --- [Gardening]: REGRESSION(267516@main): [ macOS ] editing/selection/context-menu-text-selection-lookup.html is a constant text failure. rdar://114848071 https://bugs.webkit.org/show_bug.cgi?id=261054 Unreviewed test gardening: remove platform-specific re-baseline as it is outdated. * LayoutTests/platform/mac/editing/selection/context-menu-text-selection-lookup-expected.txt: Removed. Canonical link: https://commits.webkit.org/267571@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 636ff0: REGRESSION(266896@main): html/semantics/embedded-c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 636ff0602d4c8b7ad8cea04bc604078647569f25 https://github.com/WebKit/WebKit/commit/636ff0602d4c8b7ad8cea04bc604078647569f25 Author: Ryosuke Niwa Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/platform/ThreadTimers.cpp Log Message: --- REGRESSION(266896@main): html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html is flaky https://bugs.webkit.org/show_bug.cgi?id=260929 Reviewed by Simon Fraser. The flakiness is probably caused by the inconsistent use of MonotonicTime vs ApproximateTime in EventLoop::run and ThreadTimers::sharedTimerFiredInternal. Always use ApproximateTime so that these two checks become consistent. * Source/WebCore/platform/ThreadTimers.cpp: (WebCore::ThreadTimers::sharedTimerFiredInternal): Canonical link: https://commits.webkit.org/267570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 481c8c: [JSC] Remove Wasm BBQ Air code generator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 481c8cf69ba4af4bf8f52f164b6cc44c7f6262cf https://github.com/WebKit/WebKit/commit/481c8cf69ba4af4bf8f52f164b6cc44c7f6262cf Author: Yusuke Suzuki Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M JSTests/wasm.yaml M JSTests/wasm/gc/bug252719.js M JSTests/wasm/regress/242294.js M JSTests/wasm/stress/simd-unreachable.js M JSTests/wasm/stress/tail-call.js M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/Sources.txt M Source/JavaScriptCore/interpreter/StackVisitor.cpp M Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp M Source/JavaScriptCore/jit/PCToCodeOriginMap.h M Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h M Source/JavaScriptCore/llint/WebAssembly.asm M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h R Source/JavaScriptCore/wasm/WasmAirIRGenerator.h R Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp R Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp R Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp M Source/JavaScriptCore/wasm/WasmB3IRGenerator.h M Source/JavaScriptCore/wasm/WasmBBQDisassembler.cpp M Source/JavaScriptCore/wasm/WasmBBQDisassembler.h M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.h M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmBBQPlan.h M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmCalleeGroup.cpp M Source/JavaScriptCore/wasm/WasmCalleeGroup.h M Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp M Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp M Source/JavaScriptCore/wasm/WasmOMGPlan.h M Source/JavaScriptCore/wasm/WasmOSREntryData.h M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp M Source/JavaScriptCore/wasm/WasmOSREntryPlan.h M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.cpp M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/WasmOperations.h M Source/JavaScriptCore/wasm/WasmSIMDOpcodes.h M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.h M Source/JavaScriptCore/wasm/WasmThunks.cpp M Source/JavaScriptCore/wasm/WasmThunks.h M Source/JavaScriptCore/wasm/WasmTierUpCount.cpp M Source/JavaScriptCore/wasm/WasmTierUpCount.h M Source/JavaScriptCore/wasm/WasmTypeDefinition.h M Source/WTF/wtf/PlatformEnable.h M Source/cmake/WebKitFeatures.cmake M Tools/Scripts/run-jsc-stress-tests Log Message: --- [JSC] Remove Wasm BBQ Air code generator https://bugs.webkit.org/show_bug.cgi?id=261042 rdar://114832639 Reviewed by Keith Miller. This patch removes Wasm BBQ Air code generator. We landed new single pass WasmBBQJIT 6 months ago, and it already gets stabilized. Many code already started assuming this new WasmBBQJIT, and new features (like, WasmGC etc.) are only implemented / tested on new WasmBBQJIT now. Also, this significantly reduces JSTests variations since it has many conditions running tests with Wasm Air flag, which mode is not used in ARM64 / x64 anymore. We also remove many Wasm BBQ Air code generator related flags, and rename useSinglePassBBQJIT to useBBQJIT since now this new WasmBBQJIT is the only canonical BBQJIT. * JSTests/wasm/gc/bug252719.js: (testIntFields): * JSTests/wasm/regress/242294.js: * JSTests/wasm/stress/simd-unreachable.js: * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/Sources.txt: * Source/JavaScriptCore/interpreter/StackVisitor.cpp: (JSC::StackVisitor::readInlinableNativeCalleeFrame): * Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp: * Source/JavaScriptCore/jit/PCToCodeOriginMap.h: * Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/runtime/Options.cpp: (JSC::Options::notifyOptionsChanged): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/wasm/WasmAirIRGenerator.h: Removed. * Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp: Removed. * Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp: Removed. * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: Removed. * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: * Source/JavaScriptCore/wasm/WasmB3IRGenerator.h: * Source/JavaScriptCore/wasm/WasmBBQDisassembler.cpp: *
[webkit-changes] [WebKit/WebKit] 91a13f: [Gardening]: REGRESSION(267516@main): [ macOS wk2 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91a13f2631d3c2c300c10007b652f6d58cad5124 https://github.com/WebKit/WebKit/commit/91a13f2631d3c2c300c10007b652f6d58cad5124 Author: Ben Schwartz Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations R LayoutTests/platform/mac/accessibility/mac/iframe-pdf-expected.txt Log Message: --- [Gardening]: REGRESSION(267516@main): [ macOS wk2 ] accessibility/mac/iframe-pdf.html is a constant text failure. rdar://114840159 https://bugs.webkit.org/show_bug.cgi?id=261048 Unreviewed test gardening. Remove platform-specific re-baseline as it is outdated. * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/accessibility/mac/iframe-pdf-expected.txt: Removed. Canonical link: https://commits.webkit.org/267568@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37da04: [Gardening]: [ macOS ] editing/mac/dictionary-look...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37da045c5ae4bac68c977979a35e2ad8f7506676 https://github.com/WebKit/WebKit/commit/37da045c5ae4bac68c977979a35e2ad8f7506676 Author: Ben Schwartz Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: R LayoutTests/platform/mac/editing/mac/dictionary-lookup/dictionary-lookup-expected.txt Log Message: --- [Gardening]: [ macOS ] editing/mac/dictionary-lookup/dictionary-lookup.html is a constant text failure. rdar://114846802 https://bugs.webkit.org/show_bug.cgi?id=261052 Unreviewed test gardening: remove platform-specific re-baseline as it is outdated. * LayoutTests/platform/mac/editing/mac/dictionary-lookup/dictionary-lookup-expected.txt: Removed. Canonical link: https://commits.webkit.org/267567@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79256d: [motion-path] Implement coord-box for ray
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79256d79a14c7bf6a0cd1b8ad56b3652669c48c7 https://github.com/WebKit/WebKit/commit/79256d79a14c7bf6a0cd1b8ad56b3652669c48c7 Author: Nikolaos Mouchtaris Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-005-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt M Source/WebCore/css/CSSRayValue.cpp M Source/WebCore/css/CSSRayValue.h M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/rendering/MotionPath.cpp M Source/WebCore/rendering/PathOperation.cpp M Source/WebCore/rendering/PathOperation.h M Source/WebCore/style/StyleBuilderConverter.h Log Message: --- [motion-path] Implement coord-box for ray https://bugs.webkit.org/show_bug.cgi?id=260814 rdar://114577300 Reviewed by Tim Nguyen. Parse coord-box when included with ray, and use it to determine the correct containg block box rect. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-005-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt: * Source/WebCore/css/CSSRayValue.cpp: (WebCore::CSSRayValue::customCSSText const): (WebCore::CSSRayValue::equals const): * Source/WebCore/css/CSSRayValue.h: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::valueForPathOperation): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeBasicShapeRayOrBox): (WebCore::CSSPropertyParserHelpers::consumePathOperation): (WebCore::CSSPropertyParserHelpers::consumeBasicShapeOrBox): Deleted. * Source/WebCore/rendering/MotionPath.cpp: (WebCore::offsetFromContainer): (WebCore::MotionPath::motionPathDataForRenderer): (WebCore::MotionPath::computePathForBox): * Source/WebCore/rendering/PathOperation.h: (WebCore::PathOperation::setReferenceBox): (WebCore::PathOperation::referenceBox const): (WebCore::PathOperation::PathOperation): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertRayPathOperation): (WebCore::Style::BuilderConverter::convertPathOperation): Canonical link: https://commits.webkit.org/267566@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c17719: Add mutation events tests for ContainerNode::repla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c177199a72c0d38878dcffa142e64ffe263e822e https://github.com/WebKit/WebKit/commit/c177199a72c0d38878dcffa142e64ffe263e822e Author: Ryosuke Niwa Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: A LayoutTests/fast/dom/replace-children-mutation-events-expected.txt A LayoutTests/fast/dom/replace-children-mutation-events.html M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h Log Message: --- Add mutation events tests for ContainerNode::replaceChildren and refactor the code https://bugs.webkit.org/show_bug.cgi?id=261016 Reviewed by Chris Dumez. Added some tests for mutating DOM during replaceChildren's tree mutating operations. Also refactor the code in ContainerNode::replaceChildren by merging some aspects of Node::convertNodesOrStringsIntoNode into the function so that all node removal & insertion the logic will be in one place. * LayoutTests/fast/dom/replace-children-mutation-events-expected.txt: Added. * LayoutTests/fast/dom/replace-children-mutation-events.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChildren): * Source/WebCore/dom/Node.cpp: (WebCore::Node::convertNodesOrStringsIntoNodeVector): Extracted from convertNodesOrStringsIntoNode. (WebCore::Node::convertNodesOrStringsIntoNode): * Source/WebCore/dom/Node.h: Canonical link: https://commits.webkit.org/267565@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb1274: Update project submission metadata
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb1274371441d2a2a4c3c2ee9b6354cfe184092a https://github.com/WebKit/WebKit/commit/fb1274371441d2a2a4c3c2ee9b6354cfe184092a Author: Dan Robson Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: A .submitproject Log Message: --- Update project submission metadata rdar://114650948 (Update project submission metadata) Reviewed by Jonathan Bedard. * .submitproject: Added. Canonical link: https://commits.webkit.org/267564@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 256613: Small optimization of FloatPoint serialization in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 256613d5471864884f5520800eba1bc934978ee5 https://github.com/WebKit/WebKit/commit/256613d5471864884f5520800eba1bc934978ee5 Author: Chris Dumez Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/svg/SVGPathByteStreamBuilder.cpp M Source/WebCore/svg/SVGPathByteStreamBuilder.h M Source/WebCore/svg/SVGPathByteStreamSource.h Log Message: --- Small optimization of FloatPoint serialization in SVGPathByteStream https://bugs.webkit.org/show_bug.cgi?id=261034 Reviewed by Timothy Hatcher and Ryosuke Niwa. Serialize FloatPoint directly as a FloatPoint instead of doing is as two separate floats. Since we end up appending to a byte Vector, it helps to know how many bytes we're going to append in advance. A FloatPoint only has 2 float data members anyway. * Source/WebCore/svg/SVGPathByteStreamBuilder.h: * Source/WebCore/svg/SVGPathByteStreamSource.h: Canonical link: https://commits.webkit.org/267563@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a36f0d: AX: Sometimes web content becomes inaccessible to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a36f0d120d303e9829d17eb394a29c5769ebecfb https://github.com/WebKit/WebKit/commit/a36f0d120d303e9829d17eb394a29c5769ebecfb Author: Andres Gonzalez Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- AX: Sometimes web content becomes inaccessible to VoiceOver https://bugs.webkit.org/show_bug.cgi?id=261006 rdar://113994918 Reviewed by Tyler Wilcock. The problem is caused by the following sequence of events: 1. An AXObjectCache and AXIsolatedTree exist for the current page. 2. When the page is reloaded, the cache is destroyed and the isolated tree ActivityState is set to an empty set. The isolated tree is also queued to be destroyed. 3. VoiceOver queries for the focus off the main thread, but no isolated tree with focus is found sin the ActivityState is now empty or the tree was completely removed at that point. 4. A new AXObjectcache is created, but no new isolated object is created because this new AXObjectCache does not receive any request for the focus, which is one of the triggers of creating a new isolated tree. The solution in this patch is to dispatch to the main thread the request for the focus in this scenario, which will result in the creation of a new isolated tree. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::accessibilityFocusedUIElement): Canonical link: https://commits.webkit.org/267562@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c8b6f: [Gardening]: REGRESSION(267516@main): [ macOS wk2 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c8b6f1dbf9a40ae1841289cc75a076df80c60e3 https://github.com/WebKit/WebKit/commit/6c8b6f1dbf9a40ae1841289cc75a076df80c60e3 Author: Ben Schwartz Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(267516@main): [ macOS wk2 ] accessibility/mac/basic-embed-pdf-accessibility.html is a constant failure. rdar://114831888 https://bugs.webkit.org/show_bug.cgi?id=261041 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/267561@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb7a34: [JSC] Unreviewed RISCV64 build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb7a34a9631ccf0d34eedc78ac0de137916ef390 https://github.com/WebKit/WebKit/commit/bb7a34a9631ccf0d34eedc78ac0de137916ef390 Author: Žan Doberšek Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h Log Message: --- [JSC] Unreviewed RISCV64 build fix Fix the RISCV64 build of JavaScriptCore. In MacroAssemblerRISCV64, the supportsCountPopulation() static function is added, returning false, since the underlying RISC-V functions are only available with certain extensions we currently can't hard-depend on. No-op templates are added for two related count-population methods. * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::supportsCountPopulation): Canonical link: https://commits.webkit.org/267560@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79b9a6: Add support for Web Extension windows events.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79b9a6a2b9eccc5a1cd49365b4c5b1178c7c0d92 https://github.com/WebKit/WebKit/commit/79b9a6a2b9eccc5a1cd49365b4c5b1178c7c0d92 Author: Timothy Hatcher Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm Log Message: --- Add support for Web Extension windows events. https://bugs.webkit.org/show_bug.cgi?id=261015 rdar://problem/114806907 Reviewed by Brian Weinstein. Implements the browser.windows.onCreated, onRemoved, and onFocusChanged events. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm: (WebKit::WebExtensionContext::fireWindowsEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::didOpenWindow): (WebKit::WebExtensionContext::didCloseWindow): (WebKit::WebExtensionContext::didFocusWindow): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm: (WebKit::WebExtensionWindow::parameters const): (WebKit::WebExtensionWindow::minimalParameters const): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm: (WebKit::toWindowTypeFilter): (WebKit::WebExtensionContextProxy::dispatchWindowsEvent): * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWindows.mm: (TestWebKitAPI::TEST): Added CreatedEvent, RemovedEvent, and FocusChangedEvent tests. Canonical link: https://commits.webkit.org/267559@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ade70b: SyntaxWarning when running 'git-webkit pr'
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ade70bdb664e933e1244458b55965b877df48e51 https://github.com/WebKit/WebKit/commit/ade70bdb664e933e1244458b55965b877df48e51 Author: Michael Catanzaro Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Tools/Scripts/webkitpy/common/checkout/checkout.py Log Message: --- SyntaxWarning when running 'git-webkit pr' https://bugs.webkit.org/show_bug.cgi?id=260729 Reviewed by Jonathan Bedard. The backslashes here are python string escapes, but they were intended to be regex escapes. Each \ would need to be replaced with \\ for them to function as regex escapes. We can use raw string notation to avoid this problem. * Tools/Scripts/webkitpy/common/checkout/checkout.py: (Checkout): Canonical link: https://commits.webkit.org/267558@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27a583: Clean up existing Web Extension event dispatch code.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27a58322fcf6bc0e8d0b6ec3cfece6f38d20374c https://github.com/WebKit/WebKit/commit/27a58322fcf6bc0e8d0b6ec3cfece6f38d20374c Author: Timothy Hatcher Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionController.h M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIAlarmsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIPermissionsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebNavigationCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h Log Message: --- Clean up existing Web Extension event dispatch code. https://bugs.webkit.org/show_bug.cgi?id=261017 rdar://problem/114807244 Reviewed by Brian Weinstein. Have the alarms, permissions, and webNavigation event dispatch code match in style to the windows event dispatch code. Use a switch on the event type and combine the event messages into a single message for webNavigation. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm: (WebKit::WebExtensionContext::fireAlarmsEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm: (WebKit::WebExtensionContext::firePermissionsEventListenerIfNecessary): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::didStartProvisionalLoadForFrame): (WebKit::WebExtensionController::didCommitLoadForFrame): (WebKit::WebExtensionController::didFinishLoadForFrame): (WebKit::WebExtensionController::didFailLoadForFrame): * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIAlarmsCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchAlarmsEvent): (WebKit::WebExtensionContextProxy::dispatchAlarmEvent): Deleted. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIPermissionsCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchPermissionsEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebNavigationCocoa.mm: (WebKit::WebExtensionAPIWebNavigation::getAllFrames): (WebKit::WebExtensionAPIWebNavigation::getFrame): (WebKit::WebExtensionAPIWebNavigation::onBeforeNavigate): (WebKit::WebExtensionAPIWebNavigation::onCommitted): (WebKit::WebExtensionAPIWebNavigation::onDOMContentLoaded): (WebKit::WebExtensionAPIWebNavigation::onCompleted): (WebKit::WebExtensionAPIWebNavigation::onErrorOccurred): (WebKit::WebExtensionContextProxy::dispatchWebNavigationEvent): * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchPermissionsEvent): Deleted. (WebKit::WebExtensionContextProxy::dispatchWebNavigationOnBeforeNavigateEvent): Deleted. (WebKit::WebExtensionContextProxy::dispatchWebNavigationOnCommittedEvent): Deleted. (WebKit::WebExtensionContextProxy::dispatchWebNavigationOnDOMContentLoadedEvent): Deleted. (WebKit::WebExtensionContextProxy::dispatchWebNavigationOnCompletedEvent): Deleted. (WebKit::WebExtensionContextProxy::dispatchWebNavigationOnErrorOccurredEvent): Deleted. * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h: * Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in: * Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h: Canonical link: https://commits.webkit.org/267557@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c26ae: [motion-path] Update "" implementatio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c26aeef463837637ee7d33492845821ae276e25 https://github.com/WebKit/WebKit/commit/5c26aeef463837637ee7d33492845821ae276e25 Author: Nikolaos Mouchtaris Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-001.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-004.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-005.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-001.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-003.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-004.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-ellipse-005.html R LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-polygon-001.html R LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape.html M Source/WebCore/rendering/MotionPath.cpp M Source/WebCore/rendering/PathOperation.h Log Message: --- [motion-path] Update "" implementation for offset-path https://bugs.webkit.org/show_bug.cgi?id=259994 rdar://110565070 Reviewed by Tim Nguyen. Update ShapePathOperation to use the containing block's rect. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-shape-circle-001.html: * Source/WebCore/rendering/PathOperation.h: (WebCore::PathOperation::setContainingBlockReferenceRect): (WebCore::PathOperation::PathOperation): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::setReferenceBoxForPathOperations): Canonical link: https://commits.webkit.org/267556@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75e372: [css-color] Clamp lab/lch/oklab/oklch components t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75e3721606f8008cf933ce01d3858672e7c49b3b https://github.com/WebKit/WebKit/commit/75e3721606f8008cf933ce01d3858672e7c49b3b Author: Tim Nguyen Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.html R LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp Log Message: --- [css-color] Clamp lab/lch/oklab/oklch components to appropriate ranges https://bugs.webkit.org/show_bug.cgi?id=261019 rdar://114808444 Reviewed by Antti Koivisto. According to the spec: - Lightness for lab/lch should be clamped to a max of 100% (percentage) or 100 (number) https://drafts.csswg.org/css-color/#specifying-lab-lch - Lightness for oklab/oklch should be clamped to a max of 100% (percentage) or 1 (number) https://drafts.csswg.org/css-color/#specifying-oklab-oklch Apply that maximum and also fix some relative color syntax tests that weren't expecting the clamping. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-lab-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-mix-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.html: Removed. * LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: Removed. * LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::parseLabParametersRaw): (WebCore::CSSPropertyParserHelpers::parseLCHParametersRaw): Canonical link: https://commits.webkit.org/267555@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb79b7: Fix some guards for USE(THEME_ADWAITA)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb79b7552ad6879edf58b5fd1c05342295176644 https://github.com/WebKit/WebKit/commit/eb79b7552ad6879edf58b5fd1c05342295176644 Author: Don Olmstead Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp M Source/WebCore/rendering/RenderThemeAdwaita.cpp Log Message: --- Fix some guards for USE(THEME_ADWAITA) https://bugs.webkit.org/show_bug.cgi?id=261003 Reviewed by Michael Catanzaro. Miscellaneous fixes to make `USE_THEME_ADWAITA` work more cross platform. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::layoutTraitsClassName const): * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::systemColor const): Canonical link: https://commits.webkit.org/267554@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 268201: COOP header breaks back/forward behavior when clie...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 268201eb1e9423b0fd8356e2071457334a48418f https://github.com/WebKit/WebKit/commit/268201eb1e9423b0fd8356e2071457334a48418f Author: Chris Dumez Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm Log Message: --- COOP header breaks back/forward behavior when client-side redirects are involved https://bugs.webkit.org/show_bug.cgi?id=250781 rdar://104659192 Reviewed by Brent Fulgham. FrameLoader::loadPostRequest() was failing to set forward the LockBackForwardList flag from the FrameLoadRequest to the NavigationAction. As a result, the UIProcess would not be made aware and would fail to lock the back/forward list in case of process-swap (e.g. due to the COOP HTTP header). * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPostRequest): * Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm: (-[WKBackForwardNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]): (TEST): Canonical link: https://commits.webkit.org/267553@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d94691: Ensure AutoInstall.install_everything succeeds wit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d94691e07a310e6ec6c27db6cc76acb16bc27221 https://github.com/WebKit/WebKit/commit/d94691e07a310e6ec6c27db6cc76acb16bc27221 Author: Sam Sneddon Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py Log Message: --- Ensure AutoInstall.install_everything succeeds with implicit_deps https://bugs.webkit.org/show_bug.cgi?id=260997 Reviewed by Jonathan Bedard. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: (AutoInstall.install_everything): Canonical link: https://commits.webkit.org/267552@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a52f0: hs85je...@gmail.com needs to update github username
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a52f01ab9678ccab17103d2feefe91be7fdae9a https://github.com/WebKit/WebKit/commit/8a52f01ab9678ccab17103d2feefe91be7fdae9a Author: Hunseop Jeong Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M metadata/contributors.json Log Message: --- hs85je...@gmail.com needs to update github username https://bugs.webkit.org/show_bug.cgi?id=261029 Reviewed by Jonathan Bedard. * metadata/contributors.json: Canonical link: https://commits.webkit.org/267551@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c76046: [GStreamer] registerAppsinkWithWorkaroundsIfNeeded...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c760465095dda52270369a1f4f620a253bc320d8 https://github.com/WebKit/WebKit/commit/c760465095dda52270369a1f4f620a253bc320d8 Author: Philippe Normand Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/platform/AudioDecoder.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp Log Message: --- [GStreamer] registerAppsinkWithWorkaroundsIfNeededCallOnce() should be callable from non-main threads https://bugs.webkit.org/show_bug.cgi?id=260711 Reviewed by Alicia Boya Garcia. Remove un-needed ASSERT, nothing should prevent to call gst_element_register() from a non-main thread. * Source/WebCore/platform/AudioDecoder.cpp: (WebCore::AudioDecoder::isCodecSupported): * Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp: (WebCore::registerAppsinkWithWorkaroundsIfNeededCallOnce): Canonical link: https://commits.webkit.org/267550@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cfe18: [CSS] Allow nesting style rule with relaxed syntax
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cfe184f6dbee766aefa51db1de3e613c185b0fb https://github.com/WebKit/WebKit/commit/2cfe184f6dbee766aefa51db1de3e613c185b0fb Author: Matthieu Dubet Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing-expected.txt M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/css/parser/CSSParserImpl.h M Source/WebCore/css/parser/CSSSelectorParser.cpp Log Message: --- [CSS] Allow nesting style rule with relaxed syntax https://bugs.webkit.org/show_bug.cgi?id=260812 rdar://113475843 Reviewed by Antti Koivisto. https://drafts.csswg.org/css-nesting/#nesting The CSS nesting spec now allows having identifier as the first token in the nested style rule selector. This implementation follows the spec algorithm of first trying to parse a declaration, then a nested style rule, otherwise it goes to error recovery (until next semicolon). * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/cssom-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/parsing-expected.txt: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeStyleRule): (WebCore::CSSParserImpl::consumeBlockContent): (WebCore::CSSParserImpl::consumeDeclarationListInNewNestingContext): (WebCore::CSSParserImpl::consumeDeclarationList): (WebCore::CSSParserImpl::consumeStyleBlock): (WebCore::CSSParserImpl::consumeDeclaration): (WebCore::CSSParserImpl::consumeDeclarationListOrStyleBlockHelper): Deleted. * Source/WebCore/css/parser/CSSParserImpl.h: * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumeNestedSelectorList): Canonical link: https://commits.webkit.org/267549@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e829b0: [GStreamer] Improve a debug message
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e829b016db55bb336f68cb3198129b06bf432a1c https://github.com/WebKit/WebKit/commit/e829b016db55bb336f68cb3198129b06bf432a1c Author: Michael Catanzaro Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp Log Message: --- [GStreamer] Improve a debug message https://bugs.webkit.org/show_bug.cgi?id=260993 Reviewed by Philippe Normand. Fix: "Running GStreamer GStreamer 1.22.5, the bug fix is was" * Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp: (WebCore::BaseSinkPositionFlushWorkaroundProbe::checkIsNeeded): Canonical link: https://commits.webkit.org/267548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b91561: [content-visibility] Sync visibility bits in Rende...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9156186f52f48059654cca9eb179ce656cd86db https://github.com/WebKit/WebKit/commit/b9156186f52f48059654cca9eb179ce656cd86db Author: Rob Buis Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp Log Message: --- [content-visibility] Sync visibility bits in RenderLayer with content skipping https://bugs.webkit.org/show_bug.cgi?id=251614 Reviewed by Simon Fraser. Sync visibility bits in RenderLayer with content skipping by making sure skipped content layers have m_hasVisibleContent and m_hasVisibleDescendant set to false, and have m_hasVisibleDescendant set to false for layers created by content-visibility: hidden (layer here is forced because of the implicitly enabled layout containment). This enables any hidden layer optimizations to apply to skipped content. This change also removes some unneeded changes from r256186 and fixes the content-visibility-video.html WPT test. * LayoutTests/TestExpectations: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateDescendantDependentFlags): (WebCore::RenderLayer::computeHasVisibleContent const): (WebCore::RenderLayer::paintList): undo old change (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterDescendants): undo old change * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::canBeComposited const): Canonical link: https://commits.webkit.org/267547@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 276241: Worker/SharedWorker should fire Event instead of E...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 276241243511562a30091c9cfb1170c9e87642d0 https://github.com/WebKit/WebKit/commit/276241243511562a30091c9cfb1170c9e87642d0 Author: Youenn Fablet Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import.http-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import.http-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.http-rp/worker-src-wildcard/sharedworker-import.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import.http-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.meta/script-src-wildcard/sharedworker-import.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import.http-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.meta/worker-src-wildcard/sharedworker-import.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/esm-integration/worker.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/wasm/webapi/esm-integration/worker.tentative.html M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-import-blob-url.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/dedicated-worker-parse-error-failure-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-import-blob-url.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/workers/modules/shared-worker-parse-error-failure-expected.txt M Source/WebCore/workers/Worker.cpp M Source/WebCore/workers/Worker.h M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerGlobalScope.h M Source/WebCore/workers/WorkerMessagingProxy.cpp M Source/WebCore/workers/WorkerMessagingProxy.h M Source/WebCore/workers/WorkerReportingProxy.h M Source/WebCore/workers/WorkerThread.cpp M Source/WebCore/workers/service/context/ServiceWorkerThread.cpp M Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp M Source/WebCore/workers/shared/SharedWorkerObjectConnection.h M Source/WebCore/workers/shared/context/SharedWorkerContextManager.h M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.messages.in M Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp M Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.h M Source/WebKit/WebProcess/Storage/WebSharedWorkerObjectConnection.messages.in Log Message: --- Worker/SharedWorker should fire Event instead of ErrorEvent in case of parsing error https://bugs.webkit.org/show_bug.cgi?id=260900 rdar://problem/114694487 Reviewed by Chris Dumez. In case of parsing error, there is no exception information, so we should not fire an ErrorEvent but an Error as per spec. In WorkerThread, we are now separating the code path. In DedicatedWorker, we are using a specific code path so as to continue adding a message log. In SharedWorker case, we reuse the current code path and use a boolean to tell whether to use ErrorEvent or Error. We update mported/w3c/web-platform-tests/wasm/webapi/esm-integration/worker.tentative.html to not make it timeout and instead fail. This aligns the behavior for this test with Chrome and Firefox. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/gen/top.http-rp/script-src-wildcard/sharedworker-import.http-expected.txt: *
[webkit-changes] [WebKit/WebKit] ab6979: Move WebCodecs VideoFrame serialisation out of age...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab6979eff99f1aa2cfe73ad7cf3c66fcad26c02c https://github.com/WebKit/WebKit/commit/ab6979eff99f1aa2cfe73ad7cf3c66fcad26c02c Author: Youenn Fablet Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html A LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.https.html Log Message: --- Move WebCodecs VideoFrame serialisation out of agent cluster tests to a separate file https://bugs.webkit.org/show_bug.cgi?id=260954 rdar://114750260 Reviewed by Tim Nguyen. As per https://github.com/web-platform-tests/wpt/issues/41635, we split tests in two so as to move the crossAgentCluster tests out of Interop 2023. Move tests from videoFrame-serialization.crossAgentCluster.https.html to videoFrame-serialization.https.html. For all tests, we are making sure to close the frame explicityl at the end of the test so that the frame does not get gced unclosed. The remaining tests should be changed to accept transfer/serialization but that can be done as a follow-up. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.https-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.https.html: Added. Canonical link: https://commits.webkit.org/267545@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec9f0d: [css-color] Fix serialization of infinity & -infin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec9f0db07e3e874124a4f065eea8472c8ddf2c22 https://github.com/WebKit/WebKit/commit/ec9f0db07e3e874124a4f065eea8472c8ddf2c22 Author: Tim Nguyen Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt M Source/WebCore/platform/graphics/ColorSerialization.cpp Log Message: --- [css-color] Fix serialization of infinity & -infinity in colors https://bugs.webkit.org/show_bug.cgi?id=261018 rdar://114808320 Reviewed by Timothy Hatcher. We serialize to values like `lch(50 Infinity 0)` which are invalid at parse-time. Serialize infinity to `calc(infinity)` instead, which is valid in CSS. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-color-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-lab-expected.txt: * Source/WebCore/platform/graphics/ColorSerialization.cpp: (WebCore::numericComponent): (WTF::StringTypeAdapter::StringTypeAdapter): Deleted. (WTF::StringTypeAdapter::length const): Deleted. (WTF::StringTypeAdapter::is8Bit const): Deleted. (WTF::StringTypeAdapter::writeTo const): Deleted. (WTF::StringTypeAdapter::buffer const): Deleted. Canonical link: https://commits.webkit.org/267544@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
