[webkit-changes] [WebKit/WebKit] 76fdca: resetFontRangeIfNeeded() accidentally copies its i...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76fdcab415eae53442a8c12755ee3fbcbfd75c28
  
https://github.com/WebKit/WebKit/commit/76fdcab415eae53442a8c12755ee3fbcbfd75c28
  Author: Myles C. Maxfield 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/platform/graphics/WidthIterator.cpp

  Log Message:
  ---
  resetFontRangeIfNeeded() accidentally copies its inout param, rather than 
taking it by reference
https://bugs.webkit.org/show_bug.cgi?id=260687
rdar://114416548

Reviewed by Cameron McCormack.

resetFontRangeIfNeeded() attempts to reset the TextIterator that's passed into 
it, except it
accidentally copies the TextIterator, thereby having no effect on the caller.

This patch needs a test.

* Source/WebCore/platform/graphics/WidthIterator.cpp:
(WebCore::resetFontRangeIfNeeded):

Canonical link: https://commits.webkit.org/267981@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2440e9: backface-visibility:hidden should create a stackin...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2440e9efc74d6acbb62f9e024daa7f731e394759
  
https://github.com/WebKit/WebKit/commit/2440e9efc74d6acbb62f9e024daa7f731e394759
  Author: Matt Woodrow 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.tentative-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.tentative-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-005.tentative.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-animated-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-animated-002.html
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  ---
  backface-visibility:hidden should create a stacking context and containing 
block.
https://bugs.webkit.org/show_bug.cgi?id=261532


Reviewed by Simon Fraser.

As of https://github.com/w3c/csswg-drafts/pull/9348, backface-visibility:hidden 
should create a containing block and stacking context, if the element 
participates in a 3D rendering context.

This adds a new preference for this change (currently disabled, until other 
engines are ready to ship the change), and makes the code changes.

It also removes old WPTs that relied on the previous behaviour, and replaces 
them with new ones testing the new spec.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002-expected.html:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-expected.html:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative-expected.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-003.tentative.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004-expected.html:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-002.tentative-expected.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-hidden-004.html:
 Added.
* 
La

[webkit-changes] [WebKit/WebKit] 2a1879: [Cocoa] Teach CDMInstanceSessionFairPlayStreamingA...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a187984c01077d29f3963a2bb935cd6a8b70420
  
https://github.com/WebKit/WebKit/commit/2a187984c01077d29f3963a2bb935cd6a8b70420
  Author: Andy Estes 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
A Source/WebCore/PAL/pal/graphics/cocoa/WebAVContentKeyReportGroupExtras.h
M Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/encryptedmedia/CDMInstanceSession.h
A Source/WebCore/platform/encryptedmedia/CDMKeyGroupingStrategy.h
M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp
M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
A 
Source/WebCore/platform/graphics/avfoundation/objc/ContentKeyGroupFactoryAVFObjC.h
A 
Source/WebCore/platform/graphics/avfoundation/objc/ContentKeyGroupFactoryAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
A Source/WebCore/platform/graphics/avfoundation/objc/WebContentKeyGroup.h
A Source/WebCore/platform/graphics/avfoundation/objc/WebContentKeyGroup.mm
M Source/WebCore/platform/graphics/cocoa/IOSurface.mm
M Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp
M Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.h
M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm
M Source/WebCore/testing/MockCDMFactory.cpp
M Source/WebCore/testing/MockCDMFactory.h
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.h
M Source/WebKit/GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteCDMInstanceSession.h

  Log Message:
  ---
  [Cocoa] Teach CDMInstanceSessionFairPlayStreamingAVFObjC to create a built-in 
content key group behind an off-by-default setting
https://bugs.webkit.org/show_bug.cgi?id=261522
rdar://115440398

Reviewed by Jer Noble.

Added a new, unstable (i.e. off-by-default) web preference named
BuiltInCDMKeyGroupingStrategyEnabled. When this preference is enabled,
CDMInstanceSessionFairPlayStreamingAVFObjC will create a WebContentKeyGroup 
instead of an
AVContentKeyReportGroup for managing CDM key reporting groups. 
WebContentKeyGroup is currently just
a stub but will gain a full implementation in follow-on commits.

No new tests; no change in behavior.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::keyGroupingStrategy const):
* Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/graphics/cocoa/WebAVContentKeyReportGroupExtras.h: 
Copied from Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h.
* Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/encryptedmedia/CDMInstanceSession.h:
* Source/WebCore/platform/encryptedmedia/CDMKeyGroupingStrategy.h: Copied from 
Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h.
* Source/WebCore/platform/encryptedmedia/CDMMediaKeyGroupingStrategy.h: Copied 
from Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h.
* Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMInstanceSessionClearKey::requestLicense):
* Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSessionOrGroup):
* 
Source/WebCore/platform/graphics/avfoundation/objc/ContentKeyGroupFactoryAVFObjC.h:
 Copied from Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h.
* 
Source/WebCore/platform/graphics/avfoundation/objc/Conten

[webkit-changes] [WebKit/WebKit] 6f6557: Move off of UIKit SPI: `_UISheetDetent`

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f6557cd266c66f828329c38ff521fc8e2005752
  
https://github.com/WebKit/WebKit/commit/6f6557cd266c66f828329c38ff521fc8e2005752
  Author: Megan Gardner 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm

  Log Message:
  ---
  Move off of UIKit SPI: `_UISheetDetent`
https://bugs.webkit.org/show_bug.cgi?id=261540
rdar://115331913

Reviewed by Wenson Hsieh.

These deprecated SPIs have existing public API replacements:

• `_UISheetDetent` -> `UISheetPresentationControllerDetent`
• `_UISheetPresentationController` -> `UISheetPresentationController`
• `+_mediumDetent` -> `+mediumDetent`
• `+_largeDetent` -> `+largeDetent`
• `_widthFollowsPreferredContentSizeWhenBottomAttached` -> 
`widthFollowsPreferredContentSizeWhenEdgeAttached`
• `_wantsBottomAttachedInCompactHeight` -> `prefersEdgeAttachedInCompactHeight`

Therefore, we can simply adopt these 1-1 replacements and remove their 
declarations in SPI headers.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectMultiplePicker configurePresentation]):

Canonical link: https://commits.webkit.org/267978@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b8442: Add prominent https://webkit.org/ link to Readme

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b8442460f23db484bdd953987aa60213a072de3
  
https://github.com/WebKit/WebKit/commit/9b8442460f23db484bdd953987aa60213a072de3
  Author: Michael[tm] Smith 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M ReadMe.md

  Log Message:
  ---
  Add prominent https://webkit.org/ link to Readme
https://bugs.webkit.org/show_bug.cgi?id=261011

Reviewed by Timothy Hatcher.

* ReadMe.md:

Canonical link: https://commits.webkit.org/267977@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] da370a: [JSC] Make all slow-path calls for IC thunk in Bas...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da370a1c5ebf5a65bc2a9f730088e292eaadaec1
  
https://github.com/WebKit/WebKit/commit/da370a1c5ebf5a65bc2a9f730088e292eaadaec1
  Author: Yusuke Suzuki 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/JavaScriptCore/jit/JIT.h
M Source/JavaScriptCore/jit/JITCall.cpp
M Source/JavaScriptCore/jit/JITInlines.h
M Source/JavaScriptCore/jit/JITOpcodes.cpp

  Log Message:
  ---
  [JSC] Make all slow-path calls for IC thunk in BaselineJIT DataIC
https://bugs.webkit.org/show_bug.cgi?id=261480
rdar://115392198

Reviewed by Mark Lam.

Now we aligned all register usage in BaselineJIT DataIC. So we can just use 
DataIC
slow path thunk in all places including more complicated opcodes.

1. instanceof should have slow path thunk in the same way to the other IC. Just 
doing it.
2. iterator_next / iterator_open includes some complicated get_by_id ops inside 
it.
   Let's use get_by_id's slow path thunk in the slow path of them. This is 
totally OK since
   they are using the same registers to get_by_id.

* Source/JavaScriptCore/jit/JIT.h:
* Source/JavaScriptCore/jit/JITCall.cpp:
(JSC::JIT::emit_op_iterator_open):
(JSC::JIT::emitSlow_op_iterator_open):
(JSC::JIT::emit_op_iterator_next):
(JSC::JIT::emitSlow_op_iterator_next):
* Source/JavaScriptCore/jit/JITInlines.h:
(JSC::JIT::emitValueProfilingSite):
* Source/JavaScriptCore/jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::slow_op_instanceof_callSlowOperationThenCheckExceptionGenerator):

Canonical link: https://commits.webkit.org/267976@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3fa12a: Update my info for contributors.json

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fa12a1b0c5d4be171d8824ad8fd765ffd22ac57
  
https://github.com/WebKit/WebKit/commit/3fa12a1b0c5d4be171d8824ad8fd765ffd22ac57
  Author: Pascoe 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Update my info for contributors.json
https://bugs.webkit.org/show_bug.cgi?id=261536
rdar://115457932

Unreviewed.

Updates out of date info.

Canonical link: https://commits.webkit.org/267975@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c8f60: LinkDecorationFilteringData should use the new ser...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c8f60c068a856727cdc79ac2bff45c70a20d230
  
https://github.com/WebKit/WebKit/commit/8c8f60c068a856727cdc79ac2bff45c70a20d230
  Author: Charlie Wolfe 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/page/LinkDecorationFilteringData.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  LinkDecorationFilteringData should use the new serialization format
https://bugs.webkit.org/show_bug.cgi?id=261520
rdar://115437892

Reviewed by Aditya Keerthi.

Also a drive by fix to remove the unnecessary header for the 
`RemoteMouseEventData` struct above.

* Source/WebCore/page/LinkDecorationFilteringData.h:
(WebCore::LinkDecorationFilteringData::operator=):
(WebCore::LinkDecorationFilteringData::encode const): Deleted.
(WebCore::LinkDecorationFilteringData::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/267974@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c0f868: Use more smart pointers in rendering code

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0f8683a027790d6bc3887dcd0f0b2637f4c789c
  
https://github.com/WebKit/WebKit/commit/c0f8683a027790d6bc3887dcd0f0b2637f4c789c
  Author: Chris Dumez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WTF/wtf/WeakListHashSet.h
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h
M Source/WebCore/rendering/InlineBoxPainter.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/PaintInfo.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderFragmentContainer.cpp
M Source/WebCore/rendering/RenderFragmentContainer.h
M Source/WebCore/rendering/RenderFragmentedFlow.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h
M Source/WebCore/rendering/RenderLineBoxList.cpp
M Source/WebCore/rendering/RenderMultiColumnFlow.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
M Source/WebCore/rendering/RenderTableSection.h

  Log Message:
  ---
  Use more smart pointers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=261490

Reviewed by Alan Baradlay.

* Source/WTF/wtf/WeakListHashSet.h:
* 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paint):
* 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h:
* Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paint):
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::containingFragment const):
* Source/WebCore/rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::clientBoxRectInFragment const):
(WebCore::RenderBox::borderBoxRectInFragment const):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::initializeMarginTrimState):
(WebCore::RenderFlexibleBox::isChildEligibleForMarginTrim const):
(WebCore::RenderFlexibleBox::trimMainAxisMarginStart):
(WebCore::RenderFlexibleBox::trimMainAxisMarginEnd):
(WebCore::RenderFlexibleBox::trimCrossAxisMarginStart):
(WebCore::RenderFlexibleBox::trimCrossAxisMarginEnd):
(WebCore::RenderFlexibleBox::cacheChildMainSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion const):
(WebCore::RenderFragmentContainer::fragmentedFlowContentRectangle const):
(WebCore::RenderFragmentContainer::fragmentRectsForFlowContentRect const):
(WebCore::RenderFragmentContainer::detachFragment):
(WebCore::RenderFragmentContainer::ensureOverflowForBox const):
(WebCore::RenderFragmentContainer::visualOverflowRectForBox const):
(WebCore::RenderFragmentContainer::overflowRectForFragmentedFlowPortion): 
Deleted.
(WebCore::RenderFragmentContainer::fragmentedFlowContentRectangle): Deleted.
(WebCore::RenderFragmentContainer::fragmentRectsForFlowContentRect): Deleted.
(WebCore::RenderFragmentContainer::ensureOverflowForBox): Deleted.
(WebCore::RenderFragmentContainer::visualOverflowRectForBox): Deleted.
* Source/WebCore/rendering/RenderFragmentContainer.h:
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::removeFragmentFromThread):
(WebCore::RenderFragmentedFlow::validateFragments):
(WebCore::RenderFragmentedFlow::updateLogicalWidth):
(WebCore::RenderFragmentedFlow::computeLogicalHeight const):
(WebCore::RenderFragmentedFlow::repaintRectangleInFragments const):
(WebCore::RenderFragmentedFlow::absoluteQuadsForBox const):
(WebCore::RenderFragmentedFlow::fragmentAtBlockOffset const):
(WebCore::RenderFragmentedFlow::removeRenderBoxFragmentInfo):
(WebCore::RenderFragmentedFlow::logicalWidthChangedInFragmentsForBlock):
(WebCore::RenderFragmentedFlow::firstFragment const):
(WebCore::RenderFragmentedFlow::lastFragment const):
(WebCore::RenderFragmentedFlow::clearRenderBoxFragmentInfoAndCustomStyle):
(WebCore::RenderFragmentedFlow::getFragmentRangeForBoxFromCachedInfo const):
(WebCore::RenderFragmentedFlow::getFragmentRangeForBox const):
(WebCore::RenderFragmentedFlow::computedFragmentRangeForBox const):
(WebCore::RenderFragmen

[webkit-changes] [WebKit/WebKit] de3681: [NEW TEST] [ macOS ] API tests brings up a "There ...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de368161de23d936f4881b3b92433f4d096fa8b8
  
https://github.com/WebKit/WebKit/commit/de368161de23d936f4881b3b92433f4d096fa8b8
  Author: Robert Jenner 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm

  Log Message:
  ---
  [NEW TEST] [ macOS ] API tests brings up a "There is no application set to 
open the URL callback:playing." dialogue box
rdar://115450715
https://bugs.webkit.org/show_bug.cgi?id=261529

Unreviewed test gardening.

Disabling test that causes a dialogue box to appear that could cause problems 
with testing on the bots.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm:
(TEST):

Canonical link: https://commits.webkit.org/267972@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a89fc: Remove WebPushD related asserts

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a89fcf5e36283edefba5d2b71db23cf6952
  
https://github.com/WebKit/WebKit/commit/2a89fcf5e36283edefba5d2b71db23cf6952
  Author: Brady Eidson 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M 
Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm

  Log Message:
  ---
  Remove WebPushD related asserts
https://bugs.webkit.org/show_bug.cgi?id=261530

Reviewed by Chris Dumez.

Most engineers working with ToT WebKit are not also going to take the step to 
use ToT webpushd.
Their app instead connects to the System install of webpushd.

It's fine that web push doesn't *work* in this config, but not fine that these 
ASSERTs fire.

Remove the nuisance!

* 
Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
(WebKit::WebPushD::Connection::performSendWithAsyncReplyWithoutUsingIPCConnection
 const):

Canonical link: https://commits.webkit.org/267971@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81f1e7: [Gardening]: REGRESSION (266974@main): [ macOS ] f...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81f1e7dff3da7ad4f5b20079e6bbbafa09b3410d
  
https://github.com/WebKit/WebKit/commit/81f1e7dff3da7ad4f5b20079e6bbbafa09b3410d
  Author: Karl Rackler 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (266974@main): [ macOS ] five 
imported/w3c/web-platform-tests/css/css-transforms/ tests are a constant image 
failure
https://bugs.webkit.org/show_bug.cgi?id=261531
rdar://115453880

Unreviewed test gardening.

Add tests expectations.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/267970@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 599c09: Regression(262976@main) Images do not show in Micr...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 599c092f0fc9b57c1a68f5f35208d722adc762cb
  
https://github.com/WebKit/WebKit/commit/599c092f0fc9b57c1a68f5f35208d722adc762cb
  Author: Chris Dumez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WTF/wtf/text/Base64.cpp
M Source/WTF/wtf/text/Base64.h
M Source/WebCore/loader/ResourceLoader.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/platform/network/DataURLDecoder.cpp
M Source/WebCore/platform/network/DataURLDecoder.h
M Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp

  Log Message:
  ---
  Regression(262976@main) Images do not show in Microsoft Word Online
https://bugs.webkit.org/show_bug.cgi?id=261524
rdar://114573089

Reviewed by Brent Fulgham.

Images do not show in Microsoft Word Online since the data URL change in 
262976@main.
It is a surprising since 262976@main was meant to align us with other browsers 
and yet
images show correctly in Chrome & Firefox.

After some investigation, I found that the data URL used by Word Online for 
images in
Safari have incorrect padding, while the ones it uses in Chrome have correct 
padding.
As a result, it doesn't appear to be a WebKit bug but rather Safari getting 
served
different content than Chrome for some reason.

To address the issue, I am introducing a quirk to disable padding validation in 
data
URLs on Microsoft Word Online.

* Source/WTF/wtf/text/Base64.cpp:
(WTF::base64DecodeInternal):
* Source/WTF/wtf/text/Base64.h:
* Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldDisableDataURLPaddingValidation const):
* Source/WebCore/page/Quirks.h:
* Source/WebCore/platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::DecodeTask::DecodeTask):
(WebCore::DataURLDecoder::createDecodeTask):
(WebCore::DataURLDecoder::decodeSynchronously):
(WebCore::DataURLDecoder::decode):
* Source/WebCore/platform/network/DataURLDecoder.h:

Canonical link: https://commits.webkit.org/267969@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f15b34: Use more smart pointers in WebUserContentController

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f15b34787013cca3a6dfe0d11983eac2b415a62d
  
https://github.com/WebKit/WebKit/commit/f15b34787013cca3a6dfe0d11983eac2b415a62d
  Author: Chris Dumez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp
M Source/WebKit/WebProcess/UserContent/WebUserContentController.h

  Log Message:
  ---
  Use more smart pointers in WebUserContentController
https://bugs.webkit.org/show_bug.cgi?id=261515

Reviewed by Brent Fulgham.

* Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::userContentControllers):
(WebKit::worldMap):
(WebKit::WebUserContentController::worldForIdentifier):
(WebKit::WebUserContentController::addContentWorld):
(WebKit::WebUserContentController::addUserScripts):
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeAllUserScripts):
(WebKit::WebUserContentController::addUserStyleSheets):
(WebKit::WebUserContentController::removeUserStyleSheet):
(WebKit::WebUserContentController::removeAllUserStyleSheets):
(WebKit::WebUserContentController::addUserScriptMessageHandlers):
(WebKit::WebUserContentController::removeUserScriptMessageHandler):
(WebKit::WebUserContentController::removeAllUserScriptMessageHandlersForWorlds):
* Source/WebKit/WebProcess/UserContent/WebUserContentController.h:

Canonical link: https://commits.webkit.org/267968@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 97f8f5: WPT lint tool fails if run from outside the repo.

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97f8f55121164c5fc2b8f7630c1360a22c8f88cf
  
https://github.com/WebKit/WebKit/commit/97f8f55121164c5fc2b8f7630c1360a22c8f88cf
  Author: Matt Woodrow 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/Scripts/webkitpy/w3c/wpt_linter.py

  Log Message:
  ---
  WPT lint tool fails if run from outside the repo.
https://bugs.webkit.org/show_bug.cgi?id=261488


Reviewed by Tim Nguyen.

Running export-w3c-tests fails for me with a bunch of lint errors of the form 
'file matches an ignore filter in .gitignore'.

It seems that for some reason it ends up passing our new test files to `git 
check-ignore --stdin' such that the contents of the test file is interpreted as 
a list of files to check against the ignore list.

Using the web-platform-tests directory as the CWD fixes this issue.

* Tools/Scripts/webkitpy/w3c/wpt_linter.py:
(WPTLinter.__init__):
(WPTLinter.lint):

Canonical link: https://commits.webkit.org/267967@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 797447: Fix error when PR number is None in DetermineLabel...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79744779ccbb65a7642237c4e0e5e79585901689
  
https://github.com/WebKit/WebKit/commit/79744779ccbb65a7642237c4e0e5e79585901689
  Author: Brianna 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Fix error when PR number is None in DetermineLabelOwner
https://bugs.webkit.org/show_bug.cgi?id=261527
rdar://115447713

Reviewed by Jonathan Bedard and Aakash Jain.

Updated property name and added error handling for empty PR numbers.

Canonical link: https://commits.webkit.org/267966@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9946be: Unreviewed, update xcfilelist files

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9946be559f7de24bb17ff25092674af769b459ee
  
https://github.com/WebKit/WebKit/commit/9946be559f7de24bb17ff25092674af769b459ee
  Author: Chris Dumez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist

  Log Message:
  ---
  Unreviewed, update xcfilelist files
https://bugs.webkit.org/show_bug.cgi?id=261526
rdar://115447378

* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:

Canonical link: https://commits.webkit.org/267965@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31eb0b: Propagate mouse events to site-isolated frames

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31eb0baafdee9f427762f3fe7fbd8049663c6882
  
https://github.com/WebKit/WebKit/commit/31eb0baafdee9f427762f3fe7fbd8049663c6882
  Author: Charlie Wolfe 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/page/AutoscrollController.cpp
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/FrameView.h
A Source/WebCore/page/HandleMouseEventResult.h
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/RemoteFrameView.h
A Source/WebCore/page/RemoteMouseEventData.h
M Source/WebCore/page/ios/EventHandlerIOS.mm
M Source/WebCore/page/mac/EventHandlerMac.mm
M Source/WebCore/page/win/EventHandlerWin.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/WebMouseEvent.h
M Source/WebKit/UIProcess/RemotePageProxy.cpp
M Source/WebKit/UIProcess/RemotePageProxy.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  Propagate mouse events to site-isolated frames
https://bugs.webkit.org/show_bug.cgi?id=260875
rdar://114656583

Reviewed by Alex Christensen.

This patch makes changes to propagate mouse down, up, and move events to 
site-isolated frames.

When a hit test leads to a remote frame, the web process will send IPC to the 
UI process
containing the target frame ID and the transformed coordinates relative to the 
remote frame’s
parent. The UI process then sends the mouse event with the corrected 
coordinates to the specified
frame.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::subframeForHitTestResult):
(WebCore::EventHandler::subframeForTargetNode):

Change these functions to return a `Frame` so we can later check if the target 
subframe is a
remote frame.

(WebCore::documentPointForWindowPoint):

`documentPointForWindowPoint()` should take a Frame so we can use it to 
transform mouse coordinates
to be sent to a remote frame.

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::passMouseMovedEventToScrollbars):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

Update these functions to check when a remote frame is the target frame. If so, 
return
`RemoteMouseEventData`.

* Source/WebCore/page/HandleMouseEventResult.h: Added.
(WebCore::HandleMouseEventResult::HandleMouseEventResult):
(WebCore::HandleMouseEventResult::wasHandled):
(WebCore::HandleMouseEventResult::setHandled):
(WebCore::HandleMouseEventResult::remoteMouseEventData):

Add `HandleMouseEventResult` to replace to bool used as the return type for 
mouse events.

* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/RemoteFrameView.h:

Create a virtual `frame()` function on FrameView.

* Source/WebCore/page/RemoteMouseEventData.h: Added.

Add `RemoteMouseEventData` to store the target remote frame and the transformed 
coordinates that is
sent to the UI process.

* Source/WebKit/Shared/WebMouseEvent.h:
(WebKit::WebMouseEvent::setPosition):

Add a `setPosition()` function that is used to correct the position of the 
propagated mouse event.

* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::remotePageProxy):
* Source/WebKit/UIProcess/WebFrameProxy.h:

Add an accessor for a RemotePageProxy.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEventReply):
(WebKit::WebPageProxy::sendMouseEvent):
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
* Source/WebKit/UIProcess/WebPageProxy.h:

Add functions to propagate the mouse event to the frame specified in the 
completion handler in
`RemoteMouseEventData`.

* Source/WebCore/page/AutoscrollController.cpp:
(WebCore::AutoscrollController::stopAutoscrollTimer):
* Source/WebCore/page/ContextMenuController.cpp:
* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::tryToBeginDragAtPoint):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(

[webkit-changes] [WebKit/WebKit] 08a37f: WebCodecs AudioEncoder implementation

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08a37f0893cdc5a25ccc5eadb855f7751949635a
  
https://github.com/WebKit/WebKit/commit/08a37f0893cdc5a25ccc5eadb855f7751949635a
  Author: Philippe Normand 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-codec-specific.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.worker-expected.txt
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/webcodecs/AacEncoderConfig.h
A Source/WebCore/Modules/webcodecs/AacEncoderConfig.idl
A Source/WebCore/Modules/webcodecs/FlacEncoderConfig.h
A Source/WebCore/Modules/webcodecs/FlacEncoderConfig.idl
A Source/WebCore/Modules/webcodecs/OpusEncoderConfig.h
A Source/WebCore/Modules/webcodecs/OpusEncoderConfig.idl
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.idl
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderSupport.h
A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderSupport.idl
A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkMetadata.h
A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkMetadata.idl
A 
Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkOutputCallback.h
A 
Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkOutputCallback.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/WebCoreBuiltinNames.h
M Source/WebCore/dom/EventTargetFactory.in
A Source/WebCore/platform/AudioEncoder.cpp
A Source/WebCore/platform/AudioEncoder.h
A Source/WebCore/platform/AudioEncoderActiveConfiguration.h
M Source/WebCore/platform/PlatformScreen.cpp
M Source/WebCore/platform/SourcesGStreamer.txt
M Source/WebCore/platform/audio/PlatformRawAudioData.h
A Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp
A Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.h
M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp

  Log Message:
  ---
  WebCodecs AudioEncoder implementation
https://bugs.webkit.org/show_bug.cgi?id=261107

Reviewed by Youenn Fablet.

This patch exposes AudioEncoder and its implementation for ports enabling the 
WebCodecsAudioEnabled
setting.

Canonical link: https://commits.webkit.org/267963@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ab7171: Remove special renderer based IFC ruby code

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab71719ed2ffeac0a2ce51fb6e10d5b4c40f20f3
  
https://github.com/WebKit/WebKit/commit/ab71719ed2ffeac0a2ce51fb6e10d5b4c40f20f3
  Author: Antti Koivisto 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h

  Log Message:
  ---
  Remove special renderer based IFC ruby code
https://bugs.webkit.org/show_bug.cgi?id=261496
rdar://115413576

Reviewed by Alan Baradlay.

We are going to implement proper IFC ruby.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::inlineItemWidth const):
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalBorderBoxForAtomicInlineLevelBox const):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateLayoutBoxDimensions):
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::rubyAdjustments const): Deleted.
(WebCore::Layout::Box::setRubyAdjustments): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.h:

Canonical link: https://commits.webkit.org/267962@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d9124: InteractionRegion masked corners don't always rese...

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d9124497dac3ad6b649cb79ea7025ade9045536
  
https://github.com/WebKit/WebKit/commit/5d9124497dac3ad6b649cb79ea7025ade9045536
  Author: Etienne Segonzac 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm

  Log Message:
  ---
  InteractionRegion masked corners don't always reset properly
https://bugs.webkit.org/show_bug.cgi?id=261506


Reviewed by Tim Horton.

When a layer goes from having some corners with a radius to all corners
with a radius we need to reset the `maskedCorners` property.

* 
Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::updateLayersForInteractionRegions):

Canonical link: https://commits.webkit.org/267961@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75e559: Add messages for debugging site isolation render t...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75e559f2af5884a784401aea5f0f8b5bfd12ae87
  
https://github.com/WebKit/WebKit/commit/75e559f2af5884a784401aea5f0f8b5bfd12ae87
  Author: Alex Christensen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h

  Log Message:
  ---
  Add messages for debugging site isolation render tree output failures
https://bugs.webkit.org/show_bug.cgi?id=261517
rdar://115433786

Reviewed by J Pascoe.

http/tests/site-isolation/basic-iframe-render-output.html is currently just a 
little flaky
and I'm not sure why.  This will help me see what is failing.  It will also be 
useful for
debugging future layout test failures.

* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::renderTreeAsText):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::renderTreeAsText):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::renderTreeAsText):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/267960@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71ab75: [Merge-Queue] Validate a committer added merge label

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71ab7597d8b49a51a82b4088421bf4833bee5330
  
https://github.com/WebKit/WebKit/commit/71ab7597d8b49a51a82b4088421bf4833bee5330
  Author: Brianna 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Merge-Queue] Validate a committer added merge label
https://bugs.webkit.org/show_bug.cgi?id=261478
rdar://115388421

Reviewed by Jonathan Bedard.

Adds DetermineLabelOwner step that pulls latest label author from GitHub.

Canonical link: https://commits.webkit.org/267959@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] edf1f7: [IFC][Partial layout] Re-parenting type of inserti...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: edf1f72b95dba4f47964544723f7d568661dcde2
  
https://github.com/WebKit/WebKit/commit/edf1f72b95dba4f47964544723f7d568661dcde2
  Author: Alan Baradlay 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
A 
LayoutTests/fast/inline/inline-re-parenting-crash-on-partial-layout-expected.txt
A LayoutTests/fast/inline/inline-re-parenting-crash-on-partial-layout.html
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  ---
  [IFC][Partial layout] Re-parenting type of insertion is not supported yet
https://bugs.webkit.org/show_bug.cgi?id=261510


Reviewed by Antti Koivisto.

When an inline box (e.g. ) with a subtree gets re-parented (remove and 
insert) due to render tree normalization we
get the insert call on the root renderer () only while missing the 
individual insert notifications on the subtree renderers.

* 
LayoutTests/fast/inline/inline-re-parenting-crash-on-partial-layout-expected.txt:
 Added.
* LayoutTests/fast/inline/inline-re-parenting-crash-on-partial-layout.html: 
Added.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):

Canonical link: https://commits.webkit.org/267958@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6940fc: Implement a Ed25519 key pair check during the JWK ...

[Javier Fernandez Garcia-Boente]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6940fc8a24d037525d6a83c817016ad79489e2a2
  
https://github.com/WebKit/WebKit/commit/6940fc8a24d037525d6a83c817016ad79489e2a2
  Author: Javier Fernandez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt
M Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp
M Source/WebCore/crypto/gcrypt/GCryptRFC7748.cpp
A Source/WebCore/crypto/gcrypt/GCryptRFC8032.cpp
A Source/WebCore/crypto/gcrypt/GCryptRFC8032.h
M Source/WebCore/platform/SourcesGCrypt.txt

  Log Message:
  ---
  Implement a Ed25519 key pair check during the JWK import
https://bugs.webkit.org/show_bug.cgi?id=261323

Reviewed by Žan Doberšek.

This change implemenets the logic to ensure they private and public
keys imported using JWK format are actually compatible, according to
the RFC8032 specification.

There are similar checks for the X25519, already implemented in both
the Mac and Gtk+ ports. The implementation of this check is also present
in the Mac port.

* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/okp_importKey_failures_Ed25519.https.any.worker-expected.txt:
* Source/WebCore/crypto/gcrypt/CryptoKeyOKPGCrypt.cpp:
(WebCore::CryptoKeyOKP::platformCheckPairedKeys):
* Source/WebCore/crypto/gcrypt/GCryptRFC7748.cpp:
* Source/WebCore/crypto/gcrypt/GCryptRFC8032.cpp: Added.
(WebCore::validateEd25519KeyPair):
* Source/WebCore/crypto/gcrypt/GCryptRFC8032.h: Added.
* Source/WebCore/platform/SourcesGCrypt.txt:

Canonical link: https://commits.webkit.org/267957@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1e7b93: Use more std::span in IPC::Decoder

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e7b936a641ccf787c0362a26d984a65463429ca
  
https://github.com/WebKit/WebKit/commit/1e7b936a641ccf787c0362a26d984a65463429ca
  Author: David Kilzer 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/WTF/wtf/Algorithms.h
M 
Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm
M Source/WebKit/Platform/IPC/Decoder.cpp
M Source/WebKit/Platform/IPC/Decoder.h
M Source/WebKit/Platform/IPC/JSIPCBinding.cpp
M Source/WebKit/Platform/IPC/JSIPCBinding.h
M Source/WebKit/Platform/IPC/StreamClientConnection.h
M Source/WebKit/Platform/IPC/StreamServerConnection.cpp
M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
M Source/WebKit/Platform/IPC/win/ConnectionWin.cpp
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageNames.h
M Source/WebKit/Shared/IPCTester.cpp
M Source/WebKit/UIProcess/LegacySessionStateCodingNone.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
M Source/WebKit/webpushd/WebPushDaemon.mm
M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.mm
M Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  ---
  Use more std::span in IPC::Decoder
https://bugs.webkit.org/show_bug.cgi?id=261228


Reviewed by Chris Dumez.

Switch IPC::Decoder to use DataReference (std::span).

Other changes of note:
- Add support for std::span when creating JSC::ArrayBuffer.
- Add a utility method for std::span to .
- Introduce MessageName::Invalid and initialize
  IPC::Decoder::m_message_name to that value.
- IPC::Decoder objects now fit in 64 bytes.
- IPC::Decoder now calls m_bufferDeallocator when marked invalid,
  and clears m_buffer.

* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::create): Add.
(JSC::ArrayBuffer::tryCreate): Add.
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::create): Add.
(JSC::ArrayBuffer::tryCreate): Add.

* Source/WTF/wtf/Algorithms.h:
(WTF::spanReinterpretCast): Add.

* 
Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
(WebKit::WebPushD::Connection::performSendWithAsyncReplyWithoutUsingIPCConnection
 const):
* Source/WebKit/Platform/IPC/Decoder.cpp:
(IPC::copyBuffer):
(IPC::Decoder::create):
- Remove duplicate code for one overloaded method.
(IPC::Decoder::Decoder):
- Delete default constructor.
(IPC::Decoder::~Decoder):
(IPC::Decoder::unwrapForTesting):
* Source/WebKit/Platform/IPC/Decoder.h:
(IPC::Decoder::buffer const): Switch to return DataReference.
(IPC::Decoder::currentBufferPosition const): Delete.
- Rename to currentBufferOffset() since this returns an offset from the
  start of the buffer.
(IPC::Decoder::currentBufferOffset const):
(IPC::Decoder::length const): Delete.
(IPC::Decoder::isValid const):
(IPC::Decoder::markInvalid):
- Now calls m_bufferDeallocator and clear m_buffer on invalidation.
(IPC::alignedBufferIsLargeEnoughToContain):
- Simplify logic because we are no longer using two pointer addresses.
(IPC::Decoder::decodeSpan):
* Source/WebKit/Platform/IPC/JSIPCBinding.cpp:
(IPC::putJSValueForDecodedArgumentAtIndexOrArrayBufferIfUndefined):
* Source/WebKit/Platform/IPC/JSIPCBinding.h:
(IPC::putJSValueForDecodeArgumentInArray):
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::trySendSyncStream):
* Source/WebKit/Platform/IPC/StreamServerConnection.cpp:
(IPC::StreamServerConnection::dispatchStreamMessages):
(IPC::StreamServerConnection::processSetStreamDestinationID):
(IPC::StreamServerConnection::dispatchStreamMessage):
(IPC::StreamServerConnection::dispatchOutOfStreamMessage):
* Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:
(IPC::createMessageDecoder):
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
* Source/WebKit/Platform/IPC/win/ConnectionWin.cpp:
(IPC::Connection::readEventHandler):
* Source/WebKit/Scripts/webkit/messages.py:
(generate_message_names_header):
- Add MessageName::Invalid.
* Source/WebKit/Scripts/webkit/tests/MessageNames.h: Ditto.
* Source/WebKit/Shared/IPCTester.cpp:
(WebKit::defaultTestDriver):
(WebKit::sendTestMessage):
* Source/WebKit/UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::decodeLegacySessionState):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shouldSendPendingMessage):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSMessageListener::didReceiveMessage):
(WebKit::IPCTestingAPI::JSMessageListener::willSendMessage):
* Source/WebKit/webpushd/WebPushDaemon.mm

[webkit-changes] [WebKit/WebKit] 2e6a38: AX: Fix failing WPT menu-roles test

[Hunseop Jeong]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e6a3871e57140c019de09c3aa2a4fdcfe46a9e0
  
https://github.com/WebKit/WebKit/commit/2e6a3871e57140c019de09c3aa2a4fdcfe46a9e0
  Author: Hunseop Jeong 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/accessibility/roles-computedRoleString.html
A 
LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/menu-roles-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/menu-roles.html
M 
LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  ---
  AX: Fix failing WPT menu-roles test
https://bugs.webkit.org/show_bug.cgi?id=261457
rdar://problem/115336495

Reviewed by Tyler Wilcock.

Currently, some of the WPT menu-roles tests[1] have failed. According to
the ARIA spec[2], if a menuitem has a group as first parent and a menu
or menubar as the second parent, it must be a menuitem role.

[1]: https://wpt.fyi/results/wai-aria/role/menu-roles.html
[2]: https://w3c.github.io/aria/#menu

* LayoutTests/accessibility/roles-computedRoleString.html:
* LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent const):

Canonical link: https://commits.webkit.org/267955@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 32c519: Remove FlowHasNonSupportedChild reason flag

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32c519120f0304330afc580eacf7e9bd53a876f1
  
https://github.com/WebKit/WebKit/commit/32c519120f0304330afc580eacf7e9bd53a876f1
  Author: Alan Baradlay 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h

  Log Message:
  ---
  Remove FlowHasNonSupportedChild reason flag
https://bugs.webkit.org/show_bug.cgi?id=261422

Reviewed by Antti Koivisto.

All of the different inline box types should be covered in canUseForChild by 
now.

* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForChild):
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:

Canonical link: https://commits.webkit.org/267954@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c4e648: Allow grandparent site-isolated iframe to be in sa...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4e648e277442a4ebd1f978cae940eea52890a53
  
https://github.com/WebKit/WebKit/commit/c4e648e277442a4ebd1f978cae940eea52890a53
  Author: Alex Christensen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/loader/DocumentLoader.cpp
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  Allow grandparent site-isolated iframe to be in same process as grandchild
https://bugs.webkit.org/show_bug.cgi?id=261507
rdar://115426049

Reviewed by J Pascoe.

Two small fixes are needed to make this case not crash.

1. In DocumentLoader::willSendRequest, we hit the case where there is no parent 
LocalFrame.
   In this case, just continue the load like we do in other cases in this 
function.
2. The transaction ID should only be incremented once per process, independent 
of how many
   root frames that process has.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267953@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 764233: REGRESSION(267786@main): Nullptr crash under resol...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7642333842d2e1878af6949a67fac4d8861b73f2
  
https://github.com/WebKit/WebKit/commit/7642333842d2e1878af6949a67fac4d8861b73f2
  Author: Antti Koivisto 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
A LayoutTests/fast/css/computed-style-no-render-tree-crash-expected.txt
A LayoutTests/fast/css/computed-style-no-render-tree-crash.html
M Source/WebCore/dom/Document.cpp

  Log Message:
  ---
  REGRESSION(267786@main): Nullptr crash under resolveComputedStyle when there 
is no render tree
https://bugs.webkit.org/show_bug.cgi?id=261509
rdar://115348354

Reviewed by Alan Baradlay.

* LayoutTests/fast/css/computed-style-no-render-tree-crash-expected.txt: Added.
* LayoutTests/fast/css/computed-style-no-render-tree-crash.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):

Render tree may not be present during navigations.

Canonical link: https://commits.webkit.org/267952@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 282624: Block SYS_sigaltstack in sandboxes

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2826247972777dec008c4111558f24b930e828fa
  
https://github.com/WebKit/WebKit/commit/2826247972777dec008c4111558f24b930e828fa
  Author: Per Arne Vollan 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Block SYS_sigaltstack in sandboxes
https://bugs.webkit.org/show_bug.cgi?id=261481
rdar://114840732

Reviewed by Brent Fulgham.

Block SYS_sigaltstack in sandboxes when ASAN is not enabled.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/267951@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7966e0: Disable opportunistic tasks until page load completes

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7966e09d3699967276d8214e84698fab778546f3
  
https://github.com/WebKit/WebKit/commit/7966e09d3699967276d8214e84698fab778546f3
  Author: Wenson Hsieh 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/OpportunisticTaskScheduler.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h

  Log Message:
  ---
  Disable opportunistic tasks until page load completes
https://bugs.webkit.org/show_bug.cgi?id=261489
rdar://115404985

Reviewed by Richard Robinson.

Adjust the opportunistic task scheduler to duck out of the way during page 
load, and also for web
pages that are not visible (or are not in the active window). This is a 
speculative mitigation for a
recent increase in memory use on Membuster5, which may have been caused by the 
adjustments in
.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::firePaintRelatedMilestonesIfNeeded):
* Source/WebCore/page/OpportunisticTaskScheduler.cpp:
(WebCore::OpportunisticTaskScheduler::runLoopObserverFired):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::didCommitLoad):
(WebCore::Page::didFinishLoad):
(WebCore::Page::didFirstMeaningfulPaint): Deleted.

Replace the "waiting for first meaningful paint" flag with a "waiting for page 
load" flag instead.

* Source/WebCore/page/Page.h:
(WebCore::Page::isWaitingForLoadToFinish const):
(WebCore::Page::isWaitingForFirstMeaningfulPaint const): Deleted.

Canonical link: https://commits.webkit.org/267950@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8bd4d: [GTK][WPE] Test `/webkit/WebKitWebExtension/form-s...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8bd4de0bf5cd9bc3ab89baed85fbc9eb0457f54
  
https://github.com/WebKit/WebKit/commit/b8bd4de0bf5cd9bc3ab89baed85fbc9eb0457f54
  Author: Vitaly Dyachkov 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebProcessExtensions.cpp
M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  ---
  [GTK][WPE] Test `/webkit/WebKitWebExtension/form-submission-steps` times out 
in the bots
https://bugs.webkit.org/show_bug.cgi?id=205333

Reviewed by Michael Catanzaro.

In this test, we submit a form on the same page twice. In some
circumstances, the first submission can cancel the second one.
When this happens, the test will time out.

The best way to prevent it is to reload the page before the second
submission.

Also, at the end of the test, we reload a page with no good reason.
This patch removes this piece of code.

* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebProcessExtensions.cpp:
(testWebProcessExtensionFormSubmissionSteps):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/267949@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3177aa: [Cocoa] Define a protocol to abstract FairPlay con...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3177aa7a71dc79d3fc1df0bfb4e8dc8facc872c9
  
https://github.com/WebKit/WebKit/commit/3177aa7a71dc79d3fc1df0bfb4e8dc8facc872c9
  Author: Andy Estes 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
A Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm

  Log Message:
  ---
  [Cocoa] Define a protocol to abstract FairPlay content key grouping
https://bugs.webkit.org/show_bug.cgi?id=261487
rdar://115396531

Reviewed by Eric Carlson.

In preparation for a new implementation of FairPlay content key grouping, 
define a protocol that
covers our use of AVContentKeyReportGroup SPI then extend 
AVContentKeyReportGroup to conform to the
protocol.

No new tests; no change in behavior.

* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/graphics/cocoa/WebContentKeyGrouping.h: Added.
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

Canonical link: https://commits.webkit.org/267948@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cc7750: [WebGPU] GPU process should not crash when shader ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc77505dc54cc15993d477ec88ce1d73014c7e72
  
https://github.com/WebKit/WebKit/commit/cc77505dc54cc15993d477ec88ce1d73014c7e72
  Author: Mike Wyrzykowski 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.h
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp

  Log Message:
  ---
  [WebGPU] GPU process should not crash when shader fails to compile
https://bugs.webkit.org/show_bug.cgi?id=261484


Reviewed by Dan Glastonbury.

Cleanup some invalid assertions and logic so we can open all
of the samples in a debug build without crashes or assertions triggering.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
Bind group creation can fail if resources are not valid, don't assert.

* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::vertexBufferIndexForBindGroup const):
Allow passing a maximum vertex buffer count for ICB commands.

* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::Device::createRenderBundleEncoder):
Settings inheritPipelineState to YES was wrong as setPipelineState
is called.

(WebGPU::RenderBundleEncoder::finish):
Ensure the pipeline state was set during ICB creation.

(WebGPU::RenderBundleEncoder::setBindGroup):
Use the max vertex buffer count instead of the default.

(WebGPU::RenderBundleEncoder::setPipeline):
Ensure the pipeline state is valid.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::createBindGroup):
Bind group creation can fail if resources are not valid, don't assert.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp:
(WebKit::RemoteRenderPassEncoder::setBindGroup):
Bind group creation can fail if resources are not valid, don't assert.

Canonical link: https://commits.webkit.org/267947@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc011e: [webkitpy] Detection of GTK4 is broken

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc011e53e91781e58ab5fc3a91795eba69d836ea
  
https://github.com/WebKit/WebKit/commit/bc011e53e91781e58ab5fc3a91795eba69d836ea
  Author: Claudio Saavedra 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Tools/Scripts/webkitpy/port/gtk.py
M Tools/Scripts/webkitpy/port/gtk_unittest.py

  Log Message:
  ---
  [webkitpy] Detection of GTK4 is broken
https://bugs.webkit.org/show_bug.cgi?id=261503

Reviewed by Adrian Perez de Castro.

The name of the current binary for the gtk4 library is different,
update the method to actually find all library binaries.

 * Tools/Scripts/webkitpy/port/gtk.py:
 (GtkPort._is_gtk4_build):
 * Tools/Scripts/webkitpy/port/gtk_unittest.py:
 (GtkPortTest.test_gtk4_expectations_binary_only):
 (GtkPortTest.test_gtk_expectations_both_binaries):

Canonical link: https://commits.webkit.org/267946@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd0e96: Use more smart pointers in Source/WebKit

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd0e96182943cd6e05b1f15f771ca926832e42d3
  
https://github.com/WebKit/WebKit/commit/bd0e96182943cd6e05b1f15f771ca926832e42d3
  Author: Chris Dumez 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp
M Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h
M 
Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h
M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp
M Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebValidationMessageClient.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebRemoteObjectRegistry.h
M Source/WebKit/WebProcess/WebPage/WebDocumentLoader.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Use more smart pointers in Source/WebKit
https://bugs.webkit.org/show_bug.cgi?id=261474

Reviewed by Brent Fulgham.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementChanged):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::closeWindow):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
(WebKit::WebChromeClient::contentsSizeChanged const):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::runOpenPanel):
(WebKit::WebChromeClient::didAssociateFormControls):
(WebKit::WebChromeClient::showPlaybackTargetPicker):
(WebKit::WebChromeClient::hasStorageAccess):
(WebKit::WebChromeClient::requestStorageAccess):
(WebKit::WebChromeClient::shouldAllowDeviceOrientationAndMotionAccess):
* Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
(WebKit::WebGeolocationClient::geolocationDestroyed):
(WebKit::WebGeolocationClient::startUpdating):
(WebKit::WebGeolocationClient::stopUpdating):
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::revokeAuthorizationToken):
(WebKit::WebGeolocationClient::cancelPermissionRequest):
* Source/WebKit/WebProcess/WebCoreSupport/WebGeolocationClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::didLoadFromRegistrableDomain):
(WebKit::WebLocalFrameLoaderClient::loadedSubresourceDomains const):
(WebKit::WebLocalFrameLoaderClient::detachedFromParent2):
(WebKit::WebLocalFrameLoaderClient::assignIdentifierToInitialRequest):
(WebKit::WebLocalFrameLoaderClient::dispatchWillSendRequest):
(WebKit::WebLocalFrameLoaderClient::shouldUseCredentialStorage):
(WebKit::WebLocalFrameLoaderClie

[webkit-changes] [WebKit/WebKit] 265cd3: [IFC] Add support for out-of-flow static positioni...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 265cd39402d438a688f3a5bd7d7b1d5018585a94
  
https://github.com/WebKit/WebKit/commit/265cd39402d438a688f3a5bd7d7b1d5018585a94
  Author: Alan Baradlay 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M 
LayoutTests/platform/ios/fast/block/positioning/auto/vertical-lr/006-expected.txt
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h

  Log Message:
  ---
  [IFC] Add support for out-of-flow static positioning in bidi content
https://bugs.webkit.org/show_bug.cgi?id=260832

Reviewed by Antti Koivisto.

Re-enable after 267924@main (bidi fix).

* 
LayoutTests/platform/ios/fast/block/positioning/auto/vertical-lr/006-expected.txt:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::printReason):
(WebCore::LayoutIntegration::canUseForChild):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:

Canonical link: https://commits.webkit.org/267944@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29bbd2: Re-merge 267109@main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29bbd2e51d5489a3fbc500300a2c5b1e2e20c6d5
  
https://github.com/WebKit/WebKit/commit/29bbd2e51d5489a3fbc500300a2c5b1e2e20c6d5
  Author: Alex Christensen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/page/scrolling/ScrollingStateNode.cpp
M Source/WebCore/page/scrolling/ScrollingStateNode.h
M Source/WebCore/page/scrolling/ScrollingStateTree.cpp
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h
A 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Re-merge 267109@main
https://bugs.webkit.org/show_bug.cgi?id=261466
rdar://115368009

Reviewed by Simon Fraser.

Well, he reviewed the original PR and told me in person that attaching the tree 
after
deserialization was an ok approach.

267109@main was reverted for good reason.  I introduced using the move 
constructor to create a
std::unique_ptr from a ScrollingStateTree&&, but I didn't 
update
ScrollingStateNode.m_scrollingStateTree, so it was pointing to freed memory.  
This version
updates that pointer and prepares for the next step, when I'll decode the 
ScrollingStateNodes
without the context of the tree then attach them all to the tree.

* Source/WebCore/page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
(WebCore::ScrollingStateNode::attachAfterDeserialization):
(WebCore::ScrollingStateNode::setPropertyChanged):
(WebCore::ScrollingStateNode::setPropertyChangesAfterReattach):
* Source/WebCore/page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::scrollingStateTree const):
* Source/WebCore/page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachDeserializedNodes):
* Source/WebCore/page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::scrollingNodeAdded):
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(encodeNodeAndDescendants):
(ArgumentCoder::encode):
(ArgumentCoder::decode):
(WebKit::RemoteScrollingCoordinatorTransaction::RemoteScrollingCoordinatorTransaction):
(WebKit::encodeNodeAndDescendants): Deleted.
(WebKit::RemoteScrollingCoordinatorTransaction::encode const): Deleted.
(WebKit::RemoteScrollingCoordinatorTransaction::decode): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree const):
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in:
 Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/267943@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 119022: Remove assertion in WebFrameLoaderClient::broadcas...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 119022bfe214985e45c50444d3d1b23b5fcd8fd2
  
https://github.com/WebKit/WebKit/commit/119022bfe214985e45c50444d3d1b23b5fcd8fd2
  Author: Alex Christensen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  Remove assertion in 
WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses
https://bugs.webkit.org/show_bug.cgi?id=261501
rdar://115421153

Reviewed by J Pascoe.

The assertion is hit during teardown sometimes when doing multiple reloads on a 
page with site-isolated iframes.
It is fine to do nothing if the page has already been torn down because there 
is no RemotePageProxy to send a message to,
and there are no other processes that have a frame that needs to be destroyed.

* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267942@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d68d5c: [Gardening] Unskip offset-path-shape-rect-003.html

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d68d5c148eb3616448ae8d8e28408c0340823181
  
https://github.com/WebKit/WebKit/commit/d68d5c148eb3616448ae8d8e28408c0340823181
  Author: Tim Nguyen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [Gardening] Unskip offset-path-shape-rect-003.html
https://bugs.webkit.org/show_bug.cgi?id=261500
rdar://115420712

Unreviewed test gardening.

This test passes.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/267941@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29573c: Move Blob registry partitioning to preview status

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29573cf303ad3f2a6a5390c183cfbb5ee784f5c2
  
https://github.com/WebKit/WebKit/commit/29573cf303ad3f2a6a5390c183cfbb5ee784f5c2
  Author: Matthew Finkel 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Move Blob registry partitioning to preview status
https://bugs.webkit.org/show_bug.cgi?id=261169
rdar://115001536

Reviewed by Chris Dumez.

Let's start testing this in preview.
Covered by existing tests.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/267940@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6c4458: [GStreamer] WebCodecs gardening

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c4458b35259a70d20146a0c511d72a538e5f670
  
https://github.com/WebKit/WebKit/commit/6c4458b35259a70d20146a0c511d72a538e5f670
  Author: Philippe Normand 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt

  Log Message:
  ---
  [GStreamer] WebCodecs gardening
https://bugs.webkit.org/show_bug.cgi?id=261499

Unreviewed, WebCodecs rebaseline and expectations updates.

* LayoutTests/platform/glib/TestExpectations: reconfiguring-encoder* tests 
passing after 267865@main
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt:
Rebaseline after 267403@main
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:
 Ditto

Canonical link: https://commits.webkit.org/267939@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8f552: Expose GraphicsClient through ScriptExecutionContext

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8f55217363bef328ce1a3a61003ce7ce4d4e2e3
  
https://github.com/WebKit/WebKit/commit/a8f55217363bef328ce1a3a61003ce7ce4d4e2e3
  Author: Kimmo Kinnunen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/html/CanvasBase.cpp
M Source/WebCore/html/CanvasBase.h
M Source/WebCore/html/ImageBitmap.cpp
M Source/WebCore/html/ImageBitmapBacking.cpp
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/platform/GraphicsClient.h
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/ImageBuffer.h
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebCore/workers/WorkerGlobalScope.h

  Log Message:
  ---
  Expose GraphicsClient through ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=261272
rdar://115108907

Reviewed by Matt Woodrow.

Expose GraphicsClient through ScriptExecutionContext

All DOM objects that construct graphics objects must do so via a
factory that is able to create graphics objects (either local or
remote). This factory interface is GraphicsClient.

The objects obtain the instance via ScriptExecutionContext, either:
- Document (via Chrome)
- WorkerGlobalScope (via WorkerClient)

Add ScriptExecutionContext::graphicsClient() to avoid doing various
error-prone downcasting sequences.

Make SerializedImageBuffer::sinkIntoImageBuffer() a similar function
to ImageBuffer::create(), where the polymorphism is added with
the GraphicsClient* and in-process variant is invoked if
the instance is nullptr.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::graphicsClient):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::graphicsClient):
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::allocateImageBuffer const):
(WebCore::CanvasBase::graphicsClient const): Deleted.
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createImageBuffer):
* Source/WebCore/html/ImageBitmapBacking.cpp:
(WebCore::ImageBitmapBacking::connect):
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::DetachedOffscreenCanvas::takeImageBuffer):
(WebCore::OffscreenCanvas::pushBufferToPlaceholder):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
* Source/WebCore/platform/GraphicsClient.h:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::SerializedImageBuffer::sinkIntoImageBuffer):
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::graphicsClient):
* Source/WebCore/workers/WorkerGlobalScope.h:

Canonical link: https://commits.webkit.org/267938@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 44bf0d: Basic support for CSS based Ruby in IFC

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44bf0d71007ce85571ea893edef23a9b3935f7a8
  
https://github.com/WebKit/WebKit/commit/44bf0d71007ce85571ea893edef23a9b3935f7a8
  Author: Antti Koivisto 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
A Source/WebCore/css/ruby.css
M Source/WebCore/html/RubyElement.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/UserAgentStyle.cpp
M Source/WebCore/style/UserAgentStyle.h

  Log Message:
  ---
  Basic support for CSS based Ruby in IFC
https://bugs.webkit.org/show_bug.cgi?id=261468
rdar://115370429

Reviewed by Alan Baradlay.

The current Ruby implementation uses special elements and renderers.

This patch implements basic support for CSS based ruby in IFC:
- Adds display property values 'ruby', 'block-ruby', 'ruby-base' and 
'ruby-text' but does not expose them outside the user
agent stylesheet.
- Adds render tree building support for these values.
- Sketches an IFC implementation that is able to generate annotation boxes in 
the simple case. Layout is not affected.

The feature is behind a flag and is disabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Add a setting.

* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::toCSSValueID):
(WebCore::fromCSSValueID):

Use switch for robustness and readability.

* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDisplay):

Pass the parsing mode so we can limit the new properties to the UA sheet.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/css/ruby.css: Added.

Add a UA stylesheet that sets the display property values for HTML ruby 
elements.

* Source/WebCore/html/RubyElement.cpp:
(WebCore::RubyElement::createElementRenderer):

Skip the special case renderer generation if enabled.

* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::collectInlineItems):

Skip over ruby annotation boxes when collecting inline items.
Ruby bases simply map to inline boxes.

* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendAssociatedRubyAnnotationBoxIfNeeded):

If an inline box has an associated ruby box it is actually a ruby base.
Generate an annotation box and place it above the base.

* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Place the annotation box renderer after layout.

* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isInlineLevelBox const):
(WebCore::Layout::Box::isInlineBox const):
(WebCore::Layout::Box::isBlockContainer const):
(WebCore::Layout::Box::isRubyAnnotationBox const):
(WebCore::Layout::Box::isInternalRubyBox const):
(WebCore::Layout::Box::associatedRubyAnnotationBox const):

Find the annotation if any.

* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isImage const):
(WebCore::Layout::Box::isInternalRubyBox cons

[webkit-changes] [WebKit/WebKit] b05463: Import WPT css/css-inline

[Karl Dubost]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b054636fffeffa0314914a11ce39725a3057131e
  
https://github.com/WebKit/WebKit/commit/b054636fffeffa0314914a11ce39725a3057131e
  Author: Karl Dubost 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/import-expectations.json
M LayoutTests/imported/w3c/resources/resource-files.json
A LayoutTests/imported/w3c/web-platform-tests/css/css-inline/META.yml
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/alignment-baseline-no-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/alignment-baseline-no-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/dominant-baseline-no-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/dominant-baseline-no-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/initial-letter-no-interpolation-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/initial-letter-no-interpolation.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-computed-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-computed.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-001-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-002-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-003-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-001.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-001.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-002.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-002.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-003.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-first-textarea-003.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-inline-box-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-inline-box-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-inline-box.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-invalid-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-invalid.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-001-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-002-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-003-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-003.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-textarea-001.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-textarea-001.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-textarea-002.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-source-last-textarea-002.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-inline/baseline-source/baseline-sourc

[webkit-changes] [WebKit/WebKit] f33e99: New test added in 265747@main hits assertion failu...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f33e99829e4f572a15eb8c2a6ca3d78fa227e9cc
  
https://github.com/WebKit/WebKit/commit/f33e99829e4f572a15eb8c2a6ca3d78fa227e9cc
  Author: Ryosuke Niwa 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ScriptDisallowedScope.h
M Source/WebCore/dom/ScriptElement.cpp

  Log Message:
  ---
  New test added in 265747@main hits assertion failure: 
ScriptDisallowedScope::InMainThread::isScriptAllowed()
https://bugs.webkit.org/show_bug.cgi?id=261305

Reviewed by Chris Dumez.

Disable these assertions in WebKit1 as we've done elsewhere.

* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts): Removed the check for 
isInWebProcess given
InMainThread::isScriptAllowed now checks that condition.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::dispatchFocusInEventIfNeeded): Ditto.
(WebCore::Element::dispatchFocusOutEventIfNeeded): Ditto.
* Source/WebCore/dom/ScriptDisallowedScope.h:
(WebCore::ScriptDisallowedScope::InMainThread::isEventDispatchAllowedInSubtree):
 Ditto.
(WebCore::ScriptDisallowedScope::InMainThread::isScriptAllowed): Make this 
function always return true in
WebKit1 to avoid hitting assertion failures.
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeClassicScript): Ditto for removing the check 
for isInWebProcess.

Canonical link: https://commits.webkit.org/267935@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f5c97: Move Context2D testing properties from HTMLCanvasE...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f5c97abe1092e1c087bdd5fffd3ba3c1c5fea33
  
https://github.com/WebKit/WebKit/commit/5f5c97abe1092e1c087bdd5fffd3ba3c1c5fea33
  Author: Kimmo Kinnunen 
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
M LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html
M Source/WebCore/html/CanvasBase.cpp
M Source/WebCore/html/CanvasBase.h
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLCanvasElement.h
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext.h
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h
M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  Move Context2D testing properties from HTMLCanvasElement to context options
https://bugs.webkit.org/show_bug.cgi?id=261404
rdar://115282259

Reviewed by Matt Woodrow.

Context2D testing options should be related to the rendering context,
not to the canvas element. Move the property
avoidIOSurfaceSizeCheckInWebProcess as general purpose context 2d
option "renderingMode". This enables testing the various backends
comprehensively in the future.

* LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html:
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::allocateImageBuffer const):
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer const):
(WebCore::HTMLCanvasElement::setAvoidIOSurfaceSizeCheckInWebProcessForTesting): 
Deleted.
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::createImageBuffer const):
* Source/WebCore/html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::adjustImageBufferOptionsForTesting):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::adjustImageBufferOptionsForTesting):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::avoidIOSurfaceSizeCheckInWebProcess): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/267934@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes