[webkit-changes] [WebKit/WebKit] f05766: ImageBuffer filter operations should return Native...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0576678c27689432df0e1cd90e77acf379af245 https://github.com/WebKit/WebKit/commit/f0576678c27689432df0e1cd90e77acf379af245 Author: Kimmo Kinnunen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/rendering/style/StyleFilterImage.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h Log Message: --- ImageBuffer filter operations should return NativeImage https://bugs.webkit.org/show_bug.cgi?id=261866 rdar://115829020 Reviewed by Antti Koivisto. ImageBuffer operates on NativeImages, WebCore::Image is a higher level type. The filter operations anyway flatten the results into a NativeImage, from which the WebCore::Image was always created. Construct the WebCore::Image at the caller if needed. Since this renames the function, move the GPUP implementation from the RemoteRenderingBackendProxy to the real caller which is the RemoteImageBufferProxy. The messages have already been moved previously. This is work towards simplifying ImageBuffer API use NativeImage only. * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::filteredNativeImage): (WebCore::ImageBuffer::filteredImage): Deleted. * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/rendering/style/StyleFilterImage.cpp: (WebCore::StyleFilterImage::image const): * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp: (WebKit::RemoteImageBuffer::filteredNativeImage): (WebKit::RemoteImageBuffer::getFilteredImage): Deleted. * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h: * Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteImageBufferProxy::sendSync): (WebKit::RemoteImageBufferProxy::filteredNativeImage): (WebKit::RemoteImageBufferProxy::filteredImage): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::getFilteredImage): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: Canonical link: https://commits.webkit.org/268301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 370d7a: IPInt should decode LEB for extended opcodes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 370d7ae576389f08b9d9e4ae477c35dff89e4d08 https://github.com/WebKit/WebKit/commit/370d7ae576389f08b9d9e4ae477c35dff89e4d08 Author: Keith Miller Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: A JSTests/wasm/stress/non-canonical-extended-ops.js M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp Log Message: --- IPInt should decode LEB for extended opcodes https://bugs.webkit.org/show_bug.cgi?id=261894 Reviewed by Yusuke Suzuki. Right now it assumes they are 1 byte, which 99.9% of the time they will be. It's technically correct, however, to non-canonically encode them as more than one byte. This patch adds a simple LEB UInt32 decoder to IPInt and uses it to decode the extended opcode. * JSTests/wasm/stress/non-canonical-extended-ops.js: Added. (instance): * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::truncSaturated): * Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp: (JSC::Wasm::IPIntGenerator::addMemoryFill): (JSC::Wasm::IPIntGenerator::addMemoryCopy): (JSC::Wasm::IPIntGenerator::truncSaturated): Canonical link: https://commits.webkit.org/268300@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8844e5: Enablement flag clean-ups
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8844e5028d10063aaf5ff4d20c3e96906ca7a18c https://github.com/WebKit/WebKit/commit/8844e5028d10063aaf5ff4d20c3e96906ca7a18c Author: Brent Fulgham Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WebCore/platform/ios/UserAgentIOS.mm Log Message: --- Enablement flag clean-ups https://bugs.webkit.org/show_bug.cgi?id=261843 Reviewed by Tim Horton and Elliott Williams. This patch moves a few more enablement flags into Open Source, and corrects some mistakes where some HAVE_ macros were placed in ENABLE_ header files. * Source/WTF/wtf/PlatformEnable.h: - Add WEBXR enablement flags for visionOS. - Move a Cocoa-specific feature flag to PlatformEnableCocoa.h * Source/WTF/wtf/PlatformEnableCocoa.h: - Move some visionOS HAVE_ macros to PlatformHave.h. - Move some visionOS ENABLE_ macros to this Open Source file. - Add ENABLE_IMAGE_ANALYSIS_ENHANCEMENTS flag from PlatformEnable.h * Source/WTF/wtf/PlatformHave.h: - Add HAVE_UI_FOCUS_EFFECT to Open Source. - Add visionOS HAVE_ macros previously in PlatformEnableCocoa.h * Source/WebCore/platform/ios/UserAgentIOS.mm: - Switch definition to ENABLE_STATIC_IPAD_USER_AGENT_VALUE, and move to Open Source. Canonical link: https://commits.webkit.org/268299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60da0a: Have RenderObject subclass CanMakeCheckedPtr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60da0af827823f29aa62dd74f9dc71deafab48f8 https://github.com/WebKit/WebKit/commit/60da0af827823f29aa62dd74f9dc71deafab48f8 Author: Chris Dumez Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- Have RenderObject subclass CanMakeCheckedPtr https://bugs.webkit.org/show_bug.cgi?id=261902 Reviewed by Simon Fraser. Have RenderObject subclass CanMakeCheckedPtr so that we can adopt CheckedPtr / CheckedRef in rendering code for safety. We were previously relying on WeakPtr but it turned out to be too costly and cause performance regressions. This tested as perf-neutral on Speedometer, Membuster and MotionMark. In order to do this without regressing Membuster, I had to re-order some data members and rely on PackedPtr<> to not increase the size of renderers. * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::RenderElement): (WebCore::RenderElement::attachRendererInternal): * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::firstChild const): (WebCore::RenderElement::lastChild const): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): * Source/WebCore/rendering/RenderObject.h: Canonical link: https://commits.webkit.org/268298@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15862c: Fix Win/PS debug builds after 268267@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15862cd768aa5327a686dd8c70ea7d02f188065d https://github.com/WebKit/WebKit/commit/15862cd768aa5327a686dd8c70ea7d02f188065d Author: Nikolaos Mouchtaris Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp Log Message: --- Fix Win/PS debug builds after 268267@main https://bugs.webkit.org/show_bug.cgi?id=261931 rdar://115872691 Unreviewed build fix. * Source/WebCore/page/scrolling/ScrollAnchoringController.cpp: (WebCore::ScrollAnchoringController::adjustScrollPositionForAnchoring): Canonical link: https://commits.webkit.org/268297@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 456666: EWordSide should be an enum class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45ee4e2dc383d138624c83e922838341d510 https://github.com/WebKit/WebKit/commit/45ee4e2dc383d138624c83e922838341d510 Author: Abrar Rahman Protyasha Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/TypingCommand.cpp M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/editing/VisibleUnits.cpp M Source/WebCore/editing/VisibleUnits.h Log Message: --- EWordSide should be an enum class https://bugs.webkit.org/show_bug.cgi?id=261770 rdar://115743034 Reviewed by Michael Catanzaro. This commit narrows down the underlying type of EWordSide and converts it to an enum class for type safety. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::startCharacterOffsetOfWord): (WebCore::AXObjectCache::endCharacterOffsetOfWord): (WebCore::AXObjectCache::previousWordStartCharacterOffset): (WebCore::AXObjectCache::nextWordEndCharacterOffset): (WebCore::AXObjectCache::leftWordRange): (WebCore::AXObjectCache::rightWordRange): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::positionOfLeftWord const): (WebCore::AccessibilityObject::positionOfRightWord const): * Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp: (WebCore::AccessibilityObjectAtspi::boundaryOffset const): * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::applyPendingCorrection): (WebCore::AlternativeTextController::timerFired): (WebCore::AlternativeTextController::respondToChangedSelection): * Source/WebCore/editing/Editor.cpp: (WebCore::didApplyAutocorrection): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::updateMarkersForWordsAffectedByEditing): (WebCore::Editor::editorUIUpdateTimerFired): * Source/WebCore/editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): * Source/WebCore/editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionRespectingGranularity): * Source/WebCore/editing/VisibleUnits.cpp: (WebCore::startOfWord): (WebCore::endOfWord): (WebCore::isStartOfWord): (WebCore::atBoundaryOfGranularity): (WebCore::withinTextUnitOfGranularity): (WebCore::nextWordBoundaryInDirection): (WebCore::enclosingTextUnitOfGranularity): * Source/WebCore/editing/VisibleUnits.h: Canonical link: https://commits.webkit.org/268296@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5aa322: REGRESSION (267539@main): [iOS] Webpage unexpected...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5aa322f6a3dd1e38efa13dfcc2d367b6a3f26e3a https://github.com/WebKit/WebKit/commit/5aa322f6a3dd1e38efa13dfcc2d367b6a3f26e3a Author: Aditya Keerthi Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm Log Message: --- REGRESSION (267539@main): [iOS] Webpage unexpectedly scrolls down while typing in the find bar https://bugs.webkit.org/show_bug.cgi?id=261913 rdar://115796405 Reviewed by Wenson Hsieh. 267539@main adjusted WKWebView's "scroll to target rect" logic to account for content insets, to ensure that content in the inset area does not hide the target rect. However, it did not account for `-[WKWebView _obscuredInsets]` Specifically, the targeted scrolling logic works by computing the scroll delta between the current unobscured offset, and a new offset which reveals the target. Following, 267539@main found matches at the top of the page, could have a negative target offset for content with insets, which was necessary to fix the issue described in that change. However, the unobscured offset is effectively clamped to (0, 0), as it comes from `-[WKWebView _contentRectForUserInteraction]`, which adds obscured insets prior to converting to content view coordinates. Consequently, a constant scroll delta of `-_obscuredInsets.top` is computed when the page is scrolled to the top, and there are obscured insets. This results in repeating scrolling as matches are found at the top of the page. Fix by accounting for the `_obscuredInsets` when determining the minimum scroll position. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _scrollToRect:origin:minimumScrollDistance:]): Add the obscured insets to the minimum content offset to determine a more accurate minimum scrolling position. The logic additionally enforces a maximum minimum content offset of (0, 0), as was the case before 267539@main. * Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm: (TEST): Canonical link: https://commits.webkit.org/268295@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7bd04: Fix build with DUMP_NODE_STATISTICS on after 26821...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7bd04fa23874aa8faf2bd4f23e86d2ac3e60119 https://github.com/WebKit/WebKit/commit/c7bd04fa23874aa8faf2bd4f23e86d2ac3e60119 Author: Alex Christensen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/dom/Node.cpp Log Message: --- Fix build with DUMP_NODE_STATISTICS on after 268215@main https://bugs.webkit.org/show_bug.cgi?id=261930 rdar://115872332 Unreviewed. * Source/WebCore/dom/Node.cpp: (WebCore::liveNodeSet): Canonical link: https://commits.webkit.org/268294@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc7b40: Re-import css/css-color WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc7b4068a20eea15711a34d0c2ee75cc059e6cd9 https://github.com/WebKit/WebKit/commit/cc7b4068a20eea15711a34d0c2ee75cc059e6cd9 Author: Tim Nguyen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-currentcolor-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-currentcolor-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-currentcolor.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-visited-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-visited-getcomputedstyle.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-visited-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-visited.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-004.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/lab-l-over-100-1.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/lab-l-over-100-2.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/lch-005-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/lch-005-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/lch-005.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklab-l-over-1-1-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklab-l-over-1-1.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklab-l-over-1-2-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklab-l-over-1-2.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/oklab-l-over-1-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-rgb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-rgb.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-hsl-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-hsl.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-hwb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-hwb.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-rgb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-rgb.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hsl-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hsl.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hwb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hwb.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-rgb-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-rgb.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/opacity-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/opacity-valid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut.html M Layo
[webkit-changes] [WebKit/WebKit] 6c07f7: Remove unused ImageBuffer DisplayList mode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c07f7d0f81ba191b45814151d181e6861403c17 https://github.com/WebKit/WebKit/commit/6c07f7d0f81ba191b45814151d181e6861403c17 Author: Tim Horton Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/PlatformImageBuffer.h R Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderLayerCompositor.h M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/MiniBrowser/mac/SettingsController.h M Tools/MiniBrowser/mac/SettingsController.m M Tools/MiniBrowser/mac/WK2BrowserWindowController.m M Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp Log Message: --- Remove unused ImageBuffer DisplayList mode https://bugs.webkit.org/show_bug.cgi?id=261908 rdar://115864109 Reviewed by Simon Fraser. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::create): * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/platform/graphics/PlatformImageBuffer.h: * Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Headers.cmake: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags): * Source/WebCore/rendering/RenderLayerCompositor.h: * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _displayListDrawingEnabled]): (-[WKPreferences _setDisplayListDrawingEnabled:]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences displayListDrawingEnabled]): (-[WebPreferences setDisplayListDrawingEnabled:]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: * Tools/MiniBrowser/mac/SettingsController.h: * Tools/MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu:]): (-[SettingsController validateMenuItem:]): (-[SettingsController toggleDisplayListDrawingEnabled:]): Deleted. (-[SettingsController displayListDrawingEnabled]): Deleted. * Tools/MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController didChangeSettings]): * Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp: (TestWebKitAPI::TEST): Remove this unused (except for two trivial tests) code. Canonical link: https://commits.webkit.org/268292@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 860ac0: CSS should never serialize to a single ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 860ac0eb3e1489df131094b3e8d94311a3c987bd https://github.com/WebKit/WebKit/commit/860ac0eb3e1489df131094b3e8d94311a3c987bd Author: Tim Nguyen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html M LayoutTests/fast/css/background-position-serialize-expected.txt M LayoutTests/fast/css/background-position-serialize.html M LayoutTests/fast/masking/parsing-mask-expected.txt M LayoutTests/fast/masking/parsing-mask.html M LayoutTests/fast/masking/parsing-webkit-mask-expected.txt M LayoutTests/fast/masking/parsing-webkit-mask.html M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values.html M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-anchor-parsing-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt M Source/WebCore/css/ShorthandSerializer.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp Log Message: --- CSS should never serialize to a single value https://bugs.webkit.org/show_bug.cgi?id=258585 rdar://111750372 Reviewed by Oriol Brufau and Simon Fraser. This was clarified in https://github.com/w3c/csswg-drafts/issues/8996 It's ambiguous in some cases, especially when followed by length. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: * LayoutTests/fast/css/background-position-serialize-expected.txt: * LayoutTests/fast/css/background-position-serialize.html: * LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: * LayoutTests/fast/masking/parsing-webkit-mask.html: * LayoutTests/fast/masking/parsing-mask-expected.txt: * LayoutTests/fast/masking/parsing-mask.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-anchor-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-parsing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-position-parsing-valid-expected.txt: * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeLayered const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumePosition): Canonical link: https://commits.webkit.org/268291@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a5b4e: export-w3c-test-changes: Add some --help hints for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a5b4e8f6cd97b45169cc3459430bdceaefbcfd3 https://github.com/WebKit/WebKit/commit/3a5b4e8f6cd97b45169cc3459430bdceaefbcfd3 Author: Gerald Squelart Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/Scripts/webkitpy/w3c/test_exporter.py Log Message: --- export-w3c-test-changes: Add some --help hints for 1st-time users https://bugs.webkit.org/show_bug.cgi?id=261921 rdar://problem/115868816 Reviewed by Tim Nguyen. Add a couple of hints: - WPT repo should be cloned beforehand. - URL where to generate oAuth token. * Tools/Scripts/webkitpy/w3c/test_exporter.py: (parse_args): Canonical link: https://commits.webkit.org/268290@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce3e6b: [Gardening]: REGRESSION(268267@main): [ macOS wk2 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce3e6b2adf42a504358179a1ba7d1adab0b02d95 https://github.com/WebKit/WebKit/commit/ce3e6b2adf42a504358179a1ba7d1adab0b02d95 Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(268267@main): [ macOS wk2 ] fast/scrolling/mac/programmatic-scroll-overrides-rubberband.html is consistently timing out. rdar://115869106 https://bugs.webkit.org/show_bug.cgi?id=261922 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268289@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6be92f: AX: AXPropertyName::IsExpanded becomes stale for c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6be92f9431b6b6e00ab92b7e82540e3e16a74cbc https://github.com/WebKit/WebKit/commit/6be92f9431b6b6e00ab92b7e82540e3e16a74cbc Author: Tyler Wilcock Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/accessibility/mac/expanded-notification-expected.txt M LayoutTests/accessibility/mac/expanded-notification.html M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp Log Message: --- AX: AXPropertyName::IsExpanded becomes stale for certain elements with the popovertarget attribute https://bugs.webkit.org/show_bug.cgi?id=261791 rdar://problem/115758014 Reviewed by Andres Gonzalez. Multiple elements can point at a single popover: Show popover Hide popover Popover content Currently, if #show-popover-btn is used to open the popover, its AXPropertyName::IsExpanded will be updated, but not #hide-popover-btn's. This can cause ATs to output stale information. This patch resolves this by introducing popover relations into AXRelationType, so that when a popover is shown or hidden, we can efficiently find the elements that point at it via popovertarget and update them. This patch also fixes a bug where we did not update AXPropertyName::SupportsExpanded and AXPropertyName::IsExpanded after the popovertarget attribute is changed dynamically. New testcases added to accessibility/mac/expanded-notification.html. * LayoutTests/accessibility/mac/expanded-notification-expected.txt: * LayoutTests/accessibility/mac/expanded-notification.html: * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::getOrCreate): (WebCore::AXObjectCache::onPopoverToggle): (WebCore::AXObjectCache::relationAttributes): (WebCore::AXObjectCache::symmetricRelation): (WebCore::AXObjectCache::attributeToRelationType): (WebCore::AXObjectCache::updateRelations): (WebCore::AXObjectCache::onPopoverTargetToggle): Deleted. * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::onPopoverToggle): (WebCore::AXObjectCache::onPopoverTargetToggle): Deleted. * Source/WebCore/accessibility/AccessibilityObjectInterface.h: (WebCore::AXCoreObject::popoverTargetedBy const): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::hidePopoverInternal): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::handlePopoverTargetAction const): Canonical link: https://commits.webkit.org/268288@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f79193: NEW TEST(265708@main): [ wk2 ] fast/mediastream/vi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f79193babb2b68c88447567c7aabf0b4a50dc608 https://github.com/WebKit/WebKit/commit/f79193babb2b68c88447567c7aabf0b4a50dc608 Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/platform/mac-monterey-wk2/TestExpectations M LayoutTests/platform/wk2/TestExpectations Log Message: --- NEW TEST(265708@main): [ wk2 ] fast/mediastream/video-srcObject-set-twice.html is a flaky ImageOnlyFailure. rdar://115868374 https://bugs.webkit.org/show_bug.cgi?id=261920 Unreviewed test gardening. * LayoutTests/platform/mac-monterey-wk2/TestExpectations: * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/268287@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46e648: Use more smart pointers in editing code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46e64865e4eda18aa70e6e8061ffd78359f57b63 https://github.com/WebKit/WebKit/commit/46e64865e4eda18aa70e6e8061ffd78359f57b63 Author: Chris Dumez Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/editing/ApplyBlockElementCommand.cpp M Source/WebCore/editing/ApplyBlockElementCommand.h M Source/WebCore/editing/ApplyStyleCommand.cpp M Source/WebCore/editing/ApplyStyleCommand.h M Source/WebCore/editing/BreakBlockquoteCommand.cpp M Source/WebCore/editing/BreakBlockquoteCommand.h M Source/WebCore/editing/ChangeListTypeCommand.h M Source/WebCore/editing/CompositeEditCommand.cpp M Source/WebCore/editing/CompositeEditCommand.h M Source/WebCore/editing/CreateLinkCommand.cpp M Source/WebCore/editing/CreateLinkCommand.h M Source/WebCore/editing/DeleteSelectionCommand.cpp M Source/WebCore/editing/DeleteSelectionCommand.h M Source/WebCore/editing/DictationCommand.cpp M Source/WebCore/editing/DictationCommand.h M Source/WebCore/editing/EditCommand.cpp M Source/WebCore/editing/EditCommand.h M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/Editor.h M Source/WebCore/editing/FormatBlockCommand.cpp M Source/WebCore/editing/FormatBlockCommand.h M Source/WebCore/editing/IndentOutdentCommand.cpp M Source/WebCore/editing/IndentOutdentCommand.h M Source/WebCore/editing/InsertLineBreakCommand.cpp M Source/WebCore/editing/InsertLineBreakCommand.h M Source/WebCore/editing/InsertListCommand.cpp M Source/WebCore/editing/InsertListCommand.h M Source/WebCore/editing/InsertNestedListCommand.h M Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp M Source/WebCore/editing/InsertParagraphSeparatorCommand.h M Source/WebCore/editing/InsertTextCommand.cpp M Source/WebCore/editing/InsertTextCommand.h M Source/WebCore/editing/ModifySelectionListLevel.cpp M Source/WebCore/editing/ModifySelectionListLevel.h M Source/WebCore/editing/RemoveFormatCommand.cpp M Source/WebCore/editing/RemoveFormatCommand.h M Source/WebCore/editing/ReplaceSelectionCommand.cpp M Source/WebCore/editing/ReplaceSelectionCommand.h M Source/WebCore/editing/SimplifyMarkupCommand.cpp M Source/WebCore/editing/SimplifyMarkupCommand.h M Source/WebCore/editing/SpellingCorrectionCommand.cpp M Source/WebCore/editing/TextInsertionBaseCommand.cpp M Source/WebCore/editing/TextInsertionBaseCommand.h M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/editing/TypingCommand.cpp M Source/WebCore/editing/TypingCommand.h M Source/WebCore/editing/UnlinkCommand.cpp M Source/WebCore/editing/UnlinkCommand.h M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/editing/cocoa/EditorCocoa.mm M Source/WebCore/editing/gtk/EditorGtk.cpp M Source/WebCore/editing/ios/DictationCommandIOS.cpp M Source/WebCore/editing/ios/DictationCommandIOS.h M Source/WebCore/editing/ios/EditorIOS.mm M Source/WebCore/editing/libwpe/EditorLibWPE.cpp M Source/WebCore/editing/mac/EditorMac.mm M Source/WebCore/editing/win/EditorWin.cpp Log Message: --- Use more smart pointers in editing code https://bugs.webkit.org/show_bug.cgi?id=261844 Reviewed by Brent Fulgham. * Source/WebCore/editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand): * Source/WebCore/editing/ApplyBlockElementCommand.h: * Source/WebCore/editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): * Source/WebCore/editing/ApplyStyleCommand.h: (WebCore::ApplyStyleCommand::create): * Source/WebCore/editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::BreakBlockquoteCommand): * Source/WebCore/editing/BreakBlockquoteCommand.h: (WebCore::BreakBlockquoteCommand::create): * Source/WebCore/editing/ChangeListTypeCommand.h: * Source/WebCore/editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::CompositeEditCommand): (WebCore::CompositeEditCommand::apply): (WebCore::CompositeEditCommand::ensureComposition): (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::insertParagraphSeparator): (WebCore::CompositeEditCommand::insertLineBreak): (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::deleteSelection): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphWithClones): (WebCore::CompositeEditCommand::moveParagraphs): * Source/WebCore/editing/CompositeEditCommand.h: * Source/WebCore/editi
[webkit-changes] [WebKit/WebKit] 63a48f: [Gardening]: [ macOS wk2 ] webanimations/frame-rat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63a48f8d2b4b5f3d76ab8b5b18bd21683542c709 https://github.com/WebKit/WebKit/commit/63a48f8d2b4b5f3d76ab8b5b18bd21683542c709 Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ macOS wk2 ] webanimations/frame-rate/animation-frame-rate-alignment-started-with-one-frame-separation.html is a flaky failure. rdar://115867501 https://bugs.webkit.org/show_bug.cgi?id=261919 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268285@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 562a85: [Gardening]: media/video-pause-while-seeking.html ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 562a8501721404696ce1a7eb8f5fb4437b7b129a https://github.com/WebKit/WebKit/commit/562a8501721404696ce1a7eb8f5fb4437b7b129a Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening]: media/video-pause-while-seeking.html is a flaky failure. rdar://115866903 https://bugs.webkit.org/show_bug.cgi?id=261916 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/268284@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7149a1: [Cocoa] MSE video playback disappears after system...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7149a1fcc02e960cb426c91a9aa5a1a391ed7d8a https://github.com/WebKit/WebKit/commit/7149a1fcc02e960cb426c91a9aa5a1a391ed7d8a Author: Jer Noble Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Log Message: --- [Cocoa] MSE video playback disappears after system interruption until pause/play https://bugs.webkit.org/show_bug.cgi?id=261834 rdar://113647070 Reviewed by Tim Horton and Dean Jackson. On some Cocoa platforms, the system will interrupt AVSampleBufferDisplayLayer rendering when the process is backgrounded until a flush operation. This is detectable on iOS through a specific error code, but API has been added for this purpose as well. Detect this state and, when the page again becomes visible, flush visible AVSBDLs and re-enqueue with video samples. Flushing the display layer has the paradoxical effect of pausing playback, as a display layer without a decoded sample will usually prevent playback from starting. In the case where we are re-enqueuing due to visibility change, note the reason for the flush in the MediaPlayerPrivate and do not pause playback in that case. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPageIsVisible): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldBePlaying const): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::effectiveRateChanged): * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::flushActiveSourceBuffersIfNeeded): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (-[WebAVSampleBufferErrorListener beginObservingLayer:]): (-[WebAVSampleBufferErrorListener layerRequiresFlushToResumeDecodingChanged:]): (WebCore::SourceBufferPrivateAVFObjC::flushIfNeeded): (WebCore::SourceBufferPrivateAVFObjC::layerRequiresFlushToResumeDecodingChanged): (WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples): Canonical link: https://commits.webkit.org/268283@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 39763b: [Filters] Filters with outsets have to repaint all...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 39763b0eba704c47027dffc65c907386376c8590 https://github.com/WebKit/WebKit/commit/39763b0eba704c47027dffc65c907386376c8590 Author: Said Abou-Hallawa Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: A LayoutTests/css3/filters/drop-shadow-target-clipped-expected.html A LayoutTests/css3/filters/drop-shadow-target-clipped.html M Source/WebCore/rendering/RenderLayerFilters.cpp M Source/WebCore/rendering/RenderLayerFilters.h Log Message: --- [Filters] Filters with outsets have to repaint all the filterRegion if GraphicsStyles are used https://bugs.webkit.org/show_bug.cgi?id=261856 rdar://115817290 Reviewed by Simon Fraser. The bounding box of a target element might all be clipped. But a filter effect, like drop shadow, may still be visible in the current viewport. If GraphicsStyles are used, we need to redraw the whole filterRegion. * LayoutTests/css3/filters/drop-shadow-target-clipped-expected.html: Added. * LayoutTests/css3/filters/drop-shadow-target-clipped.html: Added. * Source/WebCore/rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::needsRedrawSourceImage const): (WebCore::RenderLayerFilters::beginFilterEffect): * Source/WebCore/rendering/RenderLayerFilters.h: Canonical link: https://commits.webkit.org/268282@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e1f05: [macOS] Add syscall mig telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e1f054f956f635a44c0e9220eef8f4d7eb0007f https://github.com/WebKit/WebKit/commit/3e1f054f956f635a44c0e9220eef8f4d7eb0007f Author: Per Arne Vollan Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [macOS] Add syscall mig telemetry https://bugs.webkit.org/show_bug.cgi?id=261903 Reviewed by Brent Fulgham. Add syscall mig telemetry in the WebContent process on macOS to detect which are currently in use. * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/268281@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d0e31: [macOS] Add syscall mach telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d0e3132ca52cd47faac65af360a1078bbeeab3a https://github.com/WebKit/WebKit/commit/4d0e3132ca52cd47faac65af360a1078bbeeab3a Author: Per Arne Vollan Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [macOS] Add syscall mach telemetry https://bugs.webkit.org/show_bug.cgi?id=261888 Reviewed by Brent Fulgham. Add syscall mach telemetry in the WebContent process on macOS to detect which are currently in use. * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/268280@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 983620: [Gardening]: NEW TEST(267814@main): [ macOS ] medi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 98362012b7069d71bb1ee1bef3ffc2c57450a806 https://github.com/WebKit/WebKit/commit/98362012b7069d71bb1ee1bef3ffc2c57450a806 Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: NEW TEST(267814@main): [ macOS ] media/media-source/media-managedmse-seek.html is a flaky ImageOnlyFailure rdar://115865642 https://bugs.webkit.org/show_bug.cgi?id=261911 Unreviewed test gardening. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/268279@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 49c1df: Use more smart pointers in the HTML parsing code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 49c1df2a930925b51ca1d41734345aa4dbc5bf78 https://github.com/WebKit/WebKit/commit/49c1df2a930925b51ca1d41734345aa4dbc5bf78 Author: Chris Dumez Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/html/parser/HTMLConstructionSite.cpp M Source/WebCore/html/parser/HTMLConstructionSite.h M Source/WebCore/html/parser/HTMLDocumentParser.cpp M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Source/WebCore/html/parser/HTMLElementStack.h M Source/WebCore/html/parser/HTMLFormattingElementList.cpp M Source/WebCore/html/parser/HTMLFormattingElementList.h M Source/WebCore/html/parser/HTMLPreloadScanner.cpp M Source/WebCore/html/parser/HTMLResourcePreloader.cpp M Source/WebCore/html/parser/HTMLResourcePreloader.h M Source/WebCore/html/parser/HTMLStackItem.h M Source/WebCore/html/parser/HTMLTreeBuilder.cpp Log Message: --- Use more smart pointers in the HTML parsing code https://bugs.webkit.org/show_bug.cgi?id=261589 Reviewed by Brent Fulgham. * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::insert): (WebCore::executeReparentTask): (WebCore::executeTakeAllChildrenAndReparentTask): (WebCore::HTMLConstructionSite::attachLater): (WebCore::HTMLConstructionSite::HTMLConstructionSite): (WebCore::HTMLConstructionSite::protectedDocument const): (WebCore::HTMLConstructionSite::protectedAttachmentRoot const): (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded): (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): (WebCore::HTMLConstructionSite::setDefaultCompatibilityMode): (WebCore::HTMLConstructionSite::setCompatibilityMode): (WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype): (WebCore::HTMLConstructionSite::finishedParsing): (WebCore::HTMLConstructionSite::insertDoctype): (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnDocument): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertHTMLHeadElement): (WebCore::HTMLConstructionSite::insertHTMLBodyElement): (WebCore::HTMLConstructionSite::insertHTMLFormElement): (WebCore::HTMLConstructionSite::insertHTMLElement): (WebCore::HTMLConstructionSite::insertHTMLTemplateElement): (WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface): (WebCore::HTMLConstructionSite::insertCustomElement): (WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertForeignElement): (WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements): * Source/WebCore/html/parser/HTMLConstructionSite.h: (WebCore::HTMLConstructionSite::protectedCurrentNode const): (WebCore::HTMLConstructionSite::isTelephoneNumberParsingEnabled): * Source/WebCore/html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer): * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::parseCompleteInput): (WebCore::HTMLFastPathParser::parseChildren): (WebCore::HTMLFastPathParser::parseElementAfterTagName): * Source/WebCore/html/parser/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::swapTo): (WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): * Source/WebCore/html/parser/HTMLPreloadScanner.cpp: (WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest): (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): (WebCore::TokenPreloadScanner::StartTagScanner::resourceType const): * Source/WebCore/html/parser/HTMLResourcePreloader.cpp: (WebCore::HTMLResourcePreloader::preload): * Source/WebCore/html/parser/HTMLResourcePreloader.h: * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Canonical link: https://commits.webkit.org/268278@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e0343: [build.webkit.org] Use passwords.json instead of e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e0343960cafd78e5401985f6e487a305467d201 https://github.com/WebKit/WebKit/commit/6e0343960cafd78e5401985f6e487a305467d201 Author: Aakash Jain Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/CISupport/build-webkit-org/master.cfg Log Message: --- [build.webkit.org] Use passwords.json instead of environment variables https://bugs.webkit.org/show_bug.cgi?id=261907 Reviewed by Ryan Haddad. * Tools/CISupport/build-webkit-org/master.cfg: Canonical link: https://commits.webkit.org/268277@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2ff7d: [Gardening]: [ macOS wk2 ] imported/w3c/web-platfo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2ff7de26f4787d92b0a26ab0a6c8288662fad6b https://github.com/WebKit/WebKit/commit/c2ff7de26f4787d92b0a26ab0a6c8288662fad6b Author: Ben Schwartz Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: [ macOS wk2 ] imported/w3c/web-platform-tests/editing/run/forwarddelete.html?6001-last is consistently timing out. rdar://115862265 https://bugs.webkit.org/show_bug.cgi?id=261906 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268276@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50cfb6: Add STAT table to CanvasTest.ttf, to ensure macOS ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50cfb6afc83f9e6eb1b80c4a217b417648176145 https://github.com/WebKit/WebKit/commit/50cfb6afc83f9e6eb1b80c4a217b417648176145 Author: Gerald Squelart Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/imported/w3c/fonts/CanvasTest-ascent256.ttf M LayoutTests/imported/w3c/fonts/CanvasTest-descent0.ttf M LayoutTests/imported/w3c/fonts/CanvasTest.ttf M LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest-ascent256.ttf M LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest-descent0.ttf M LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest.ttf M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.draw.baseline.bottom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.draw.baseline.ideographic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.draw.baseline.middle-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.draw.baseline.top-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.baselines-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-low-ascent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-zero-descent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-reduced-ascent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-zero-descent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.bottom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.bottom.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.middle-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.middle.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.top-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.top.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.baselines-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.baselines.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights-low-ascent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights-low-ascent.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights-zero-descent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights-zero-descent.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.emHeights.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox-reduced-ascent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox-reduced-ascent.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox-zero-descent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox-zero-descent.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.fontBoundingBox.worker-expected.txt R LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic-expec
[webkit-changes] [WebKit/WebKit] e960cd: Cherry-pick 265870.333@safari-7616.1.27.10-branch ...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: e960cdca544708c5eb699635438bf5e73c977c51 https://github.com/WebKit/WebKit/commit/e960cdca544708c5eb699635438bf5e73c977c51 Author: Keith Miller Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: A JSTests/stress/getbyoffset-cse-consistency.js A JSTests/stress/multigetbyoffset-cse-consistency.js M Source/JavaScriptCore/dfg/DFGCSEPhase.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGHeapLocation.h Log Message: --- Cherry-pick 265870.333@safari-7616.1.27.10-branch (ab5c6119c469). https://bugs.webkit.org/show_bug.cgi?id=261544 Cherry-pick 47e039ffd689. rdar://115399657 clobberize needs to be more precise with the *ByOffset nodes https://bugs.webkit.org/show_bug.cgi?id=261544 rdar://115399657 Reviewed by Yusuke Suzuki and Mark Lam. CSE phase uses clobberize to figure out if it's safe to merge two operations that def the same HeapLocation. Since HeapLocation does not currently have a way to track the offset used by the various *ByOffset nodes it can get confused and think that two ByOffset instructions produce the same value even if they don't use the same offset. This patch solves this by adding a new field to HeapLocation, which takes the metadata associated with the corresponding *ByOffset node. If two *ByOffset operations don't share the same metadata then they cannot be CSEed. * Source/JavaScriptCore/dfg/DFGCSEPhase.cpp: * Source/JavaScriptCore/dfg/DFGClobberize.h: (JSC::DFG::clobberize): * Source/JavaScriptCore/dfg/DFGHeapLocation.h: (JSC::DFG::HeapLocation::HeapLocation): (JSC::DFG::HeapLocation::extraState const): (JSC::DFG::HeapLocation::hash const): Canonical link: https://commits.webkit.org/265870.558@safari-7616-branch Identifier: 265423.780@safari-7616.1.27.10-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a7c1b: Make the description for WKNavigationTypeLinkActiv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a7c1bfb98af1ae64e9dc59d5db8b7befc8f23d4 https://github.com/WebKit/WebKit/commit/2a7c1bfb98af1ae64e9dc59d5db8b7befc8f23d4 Author: Sanjana Aithal Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.h Log Message: --- Make the description for WKNavigationTypeLinkActivated more accurate https://bugs.webkit.org/show_bug.cgi?id=261850 rdar://113915052 Reviewed by Richard Robinson. Made desription for WKNavigationTypeLinkActivated more accurate by clarifying that navigations of this type do not necessarily need to be initiated by the user. * Source/WebKit/UIProcess/API/Cocoa/WKNavigationAction.h Canonical link: https://commits.webkit.org/268274@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dbba9e: [build.webkit.org] run-api-tests step should fail ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dbba9e878ad1cc2a7bc39f7b857fc85636a9b5ce https://github.com/WebKit/WebKit/commit/dbba9e878ad1cc2a7bc39f7b857fc85636a9b5ce Author: Aakash Jain Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] run-api-tests step should fail builds that exceed a predefined threshold of log lines https://bugs.webkit.org/show_bug.cgi?id=261839 Reviewed by Jonathan Bedard. * Tools/CISupport/build-webkit-org/steps.py: (RunAPITests): (RunAPITests.parseOutputLine): (RunAPITests.handleExcessiveLogging): (RunAPITests.getResultSummary): Canonical link: https://commits.webkit.org/268273@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbbe52: [CSS Masking] SVG masks are not working as 'mask-i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbbe5238d695fcf62431ab47772f5f4fe25a0559 https://github.com/WebKit/WebKit/commit/cbbe5238d695fcf62431ab47772f5f4fe25a0559 Author: Said Abou-Hallawa Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/css3/masking/mask-reference-png-fragment-expected.html A LayoutTests/css3/masking/mask-reference-png-fragment.html A LayoutTests/css3/masking/resources/red-100x100.png A LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment-expected.html A LayoutTests/http/tests/css/css-masking/mask-external-svg-fragment.html A LayoutTests/http/tests/css/css-masking/mask-external-svg-image-expected.html A LayoutTests/http/tests/css/css-masking/mask-external-svg-image.html A LayoutTests/http/tests/css/css-masking/mask-external-svg-mask-expected.html A LayoutTests/http/tests/css/css-masking/mask-external-svg-mask.html A LayoutTests/http/tests/css/css-masking/mask-inline-svg-image-expected.html A LayoutTests/http/tests/css/css-masking/mask-inline-svg-image.html A LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask-expected.html A LayoutTests/http/tests/css/css-masking/mask-inline-svg-mask.html A LayoutTests/http/tests/css/css-masking/resources/heart.svg A LayoutTests/http/tests/css/css-masking/resources/star-heart-fragments.svg A LayoutTests/http/tests/css/css-masking/resources/star-heart-masks.svg A LayoutTests/http/tests/css/css-masking/resources/star.svg M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/mask-image/mask-opacity-1d.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/wpe/TestExpectations M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSImageValue.cpp M Source/WebCore/platform/graphics/Image.cpp M Source/WebCore/platform/graphics/Image.h M Source/WebCore/rendering/BorderPainter.cpp M Source/WebCore/rendering/CSSFilter.cpp M Source/WebCore/rendering/InlineBoxPainter.cpp M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/ReferencedSVGResources.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/style/FillLayer.cpp M Source/WebCore/rendering/style/FillLayer.h M Source/WebCore/rendering/style/NinePieceImage.cpp M Source/WebCore/rendering/style/StyleCachedImage.cpp M Source/WebCore/rendering/style/StyleCachedImage.h M Source/WebCore/rendering/style/StyleImage.h M Source/WebCore/rendering/style/StyleMultiImage.cpp M Source/WebCore/rendering/style/StyleMultiImage.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp M Source/WebCore/rendering/svg/SVGResources.cpp M Source/WebCore/svg/graphics/SVGImage.cpp M Source/WebCore/svg/graphics/SVGImage.h A Source/WebCore/svg/graphics/SVGResourceImage.cpp A Source/WebCore/svg/graphics/SVGResourceImage.h Log Message: --- [CSS Masking] SVG masks are not working as 'mask-image' https://bugs.webkit.org/show_bug.cgi?id=260732 rdar://114465545 Reviewed by Simon Fraser. Implement CSS masking when it references an SVG masker. There seven cases for mask-image values that need to be considered: 1. Bitmap image 2. Bitmap image fragment 3. External SVG image 4. External SVG image fragment 5. External SVG image mask 6. Inline data URL image 7. Inline SVG image mask StyleCachedImage will be adjusted to take into account the seventh case. Functions like StyleCachedImage::isLoaded() and StyleCachedImage::canRender() will have to handle the new case where StyleCachedImage represents an inline referenced SVG masker. So isLoaded() needs to a take a RenderElement to be able to resolve the imageURL. A new super-class of GeneratedImage named SVGResourceImage will be introduced to handle drawing the SVG resource given its renderer. SVGResourceImage will handle the cases of external and inline SVG resources. We can't know whether the ID associated with an external image is a fragment ID or a mask ID in an SVGImage till the CachedImage is loaded. StyleCachedImage::image() is called only after the image is completely loaded. So it can decide to create an SVGResourceImage or to let the CachedImage creates its Image. * LayoutTests/TestExpectations: Some of the WPT tests have been marked as ImageOnlyFailure in this patch because the expected results are now working as expected but the tests are not. Unfortunately the tests and the expected results are both using mask-image. So without this change they match because they both draw nothi
[webkit-changes] [WebKit/WebKit] a636b4: [JSC] SyntaxError message for missing statement as...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a636b441f67ec94b63e31cc26fe293aa23e46951 https://github.com/WebKit/WebKit/commit/a636b441f67ec94b63e31cc26fe293aa23e46951 Author: Alexey Shvayka Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/js/parser-syntax-check-expected.txt M LayoutTests/js/script-tests/parser-syntax-check.js M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- [JSC] SyntaxError message for missing statement as the body of for-in / for-of has a typo https://bugs.webkit.org/show_bug.cgi?id=145765 Reviewed by Keith Miller and Justin Michaud. * LayoutTests/js/parser-syntax-check-expected.txt: * LayoutTests/js/script-tests/parser-syntax-check.js: * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseForStatement): Canonical link: https://commits.webkit.org/268271@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf1260: Add support for tabs.sendMessage to Web Extension ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf1260f203c173044feb28d2f481501ac8d313ee https://github.com/WebKit/WebKit/commit/cf1260f203c173044feb28d2f481501ac8d313ee Author: Timothy Hatcher Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Platform/cocoa/CocoaHelpers.h M Source/WebKit/Platform/cocoa/CocoaHelpers.mm M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp A Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h A Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.h A Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.serialization.in M Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h M Source/WebKit/Shared/Extensions/WebExtensionUtilities.h M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm M Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h M Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITabs.h M Source/WebKit/WebProcess/Extensions/Bindings/JSWebExtensionWrapper.h M Source/WebKit/WebProcess/Extensions/Bindings/Scripts/CodeGeneratorExtensions.pm M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITabs.idl M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- Add support for tabs.sendMessage to Web Extension content scripts. https://webkit.org/b/261842 rdar://problem/115805311 Reviewed by Brian Weinstein. * This adds support for browser.tabs.sendMessage, and browser.runtime.onMessage. * Cleans up JSON parsing/encoding with some helper functions. * Introduces WebExtensionFrameIdentifier with conversion to and from WebCore::FrameIdentifier. * Source/WebKit/DerivedSources-input.xcfilelist: Added WebExtensionMessageSenderParameters.serialization.in. * Source/WebKit/DerivedSources.make: Ditto. * Source/WebKit/Platform/cocoa/CocoaHelpers.h: * Source/WebKit/Platform/cocoa/CocoaHelpers.mm: (WebKit::parseJSON): Added. (WebKit::encodeJSONString): Added. (WebKit::encodeJSONData): Added. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): Added WebExtensionMessageSenderParameters. * Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h: Added. (WebKit::isMainFrame): (WebKit::toWebCoreFrameIdentifier): (WebKit::matchesFrame): (WebKit::toWebExtensionFrameIdentifier): (WebKit::toWebAPI): * Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.h: Copied from Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl. * Source/WebKit/Shared/Extensions/WebExtensionMessageSenderParameters.serialization.in: Added. * Source/WebKit/Shared/Extensions/WebExtensionTabIdentifier.h: (WebKit::toWebAPI): Added const. * Source/WebKit/Shared/Extensions/WebExtensionUtilities.h: * Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm: (WebKit::toWebAPI): Added. * Source/WebKit/Shared/Extensions/WebExtensionWindowIdentifier.h: (WebKit::toWebAPI): Added const. * Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm: (-[_WKWebExtensionLocalization _localizationDictionaryForWebExtension:withLocale:]): Drive-by cleanup. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm: (WebKit::WebExtensionContext::tabsSendMessage): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::WebExtension): Use JSON helper. (WebKit::WebExtension::parseManifest): Ditto. (WebKit::WebExtension::serializeManifest): Ditto. (WebKit::WebExtension::serializeLocalization): Ditto. (WebKit::WebExtension::resourc
[webkit-changes] [WebKit/WebKit] 530fa2: [webkitcorepy] Install tomli with setuptools_scm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 530fa2b998ab1224b81dfa8d45cd8ab909cd8a43 https://github.com/WebKit/WebKit/commit/530fa2b998ab1224b81dfa8d45cd8ab909cd8a43 Author: Jonathan Bedard Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/setup.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py M Tools/Scripts/webkitpy/autoinstalled/twisted.py Log Message: --- [webkitcorepy] Install tomli with setuptools_scm https://bugs.webkit.org/show_bug.cgi?id=261893 rdar://115851645 Reviewed by Aakash Jain. Newer versions of setuptools_scm depend on tomli. * Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Bump version, add tomli. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: (Package.install): Install tomli with setuptools dependencies. Canonical link: https://commits.webkit.org/268269@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c8c1c: [PlayStation] LLVM17 warning workaround for system...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c8c1cb79116b9d5ce4f27a97a8cbca3132a578e https://github.com/WebKit/WebKit/commit/8c8c1cb79116b9d5ce4f27a97a8cbca3132a578e Author: Stephan Szabo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] LLVM17 warning workaround for system macro redef https://bugs.webkit.org/show_bug.cgi?id=261896 Unreviewed build fix Turn off warning for system macro redefinition until we can stop undefining __cpp_char8_t because we have only limited support. * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/268268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 663964: Scroll anchoring: naive implementation of selectAn...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6639646de774d4333e28e4288a36c5627ac6388f https://github.com/WebKit/WebKit/commit/6639646de774d4333e28e4288a36c5627ac6388f Author: Nikolaos Mouchtaris Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/accessibility/visible-character-range-width-changes.html M LayoutTests/css3/scroll-snap/ios/scroll-snap-mainframe-pinch-out.html M LayoutTests/editing/execCommand/insert-line-break-no-scroll.html M LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset-2.html M LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset.html M LayoutTests/fast/dom/Element/body-scrollLeft-basics-quirks.html M LayoutTests/fast/dom/Element/body-scrollTop-basics-quirks.html M LayoutTests/fast/dom/Window/window-scroll-arguments.html M LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html M LayoutTests/fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll.html M LayoutTests/fast/dom/vertical-scrollbar-when-dir-change.html M LayoutTests/fast/events/no-scroll-on-input-text-selection.html M LayoutTests/fast/scrolling/ios/click-events-during-momentum-scroll-in-main-frame.html M LayoutTests/fast/scrolling/ios/key-command-scroll-to-bottom.html M LayoutTests/fast/scrolling/ios/key-command-scroll-to-top.html M LayoutTests/fast/scrolling/ios/scroll-to-beginning-and-end-of-document.html M LayoutTests/fast/scrolling/latching/latching-and-wheel-events.html M LayoutTests/fast/scrolling/latching/overflow-in-iframe-latching.html M LayoutTests/fast/scrolling/programmatic-document-rtl-scroll.html M LayoutTests/fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html M LayoutTests/fast/visual-viewport/rtl-zoomed-rects.html M LayoutTests/fullscreen/fullscreen-restore-scroll-position.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/abspos-contributes-to-static-parent-bounds-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/ancestor-change-heuristic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/anchoring-with-bounds-clamping-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/anonymous-block-box-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/descend-into-container-with-overflow-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/image-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/inline-block-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/inline-block-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/negative-layout-overflow-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-ib-split-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/reading-scroll-forces-anchoring-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/start-edge-in-block-layout-direction-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/subtree-exclusion-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/zero-scroll-offset-expected.txt M LayoutTests/jquery/offset.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/scrollingcoordinator/mac/latching/main-frame-back-swipe.html M LayoutTests/scrollingcoordinator/mac/latching/simple-page-rubberbands.html M Source/WebCore/dom/Document.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp M Source/WebCore/page/scrolling/ScrollAnchoringController.h M Source/WebCore/platform/ScrollableArea.h Log Message: --- Scroll anchoring: naive implementation of selectAnchorElement(), implement updateScrollPosition(), hookup to layout https://bugs.webkit.org/show_bug.cgi?id=243702 Reviewed by Simon Fraser. For selectAnchorElement(), select the deepest child element that is within the viewport bounds of the frame view, or the first fully contined by the viewport bounds. For updateScrollPosition() calculate the change in offset and set the scroll position of the frame view if necessary. Finally, in FrameViewLayoutContext::performLayout(), hookup
[webkit-changes] [WebKit/WebKit] 2aec77: [ews-app] Github ews status-bubble hover over mess...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2aec77b1f6f2accd80bb717e38dd79f1748ae310 https://github.com/WebKit/WebKit/commit/2aec77b1f6f2accd80bb717e38dd79f1748ae310 Author: Aakash Jain Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/CISupport/ews-build/events.py Log Message: --- [ews-app] Github ews status-bubble hover over message might be incorrect in case of failure https://bugs.webkit.org/show_bug.cgi?id=261897 Reviewed by Ryan Haddad. We limited the steps for which we send info from buildbot to django app in 261168@main. Various analyze-* steps were not included in that list, which cause djano app to pick incorrect step to generate hover-over message. To generate the hover-over message in case of failure,we uses the information from the last failed step. So missing the analyze-* step cause djano app to pick incorrect step. * Tools/CISupport/ews-build/events.py: Canonical link: https://commits.webkit.org/268266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a44970: REGRESSION(266134@main): 3D border-style have very...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4497016d608d8288e1921042b2ec71e6f538fe1 https://github.com/WebKit/WebKit/commit/a4497016d608d8288e1921042b2ec71e6f538fe1 Author: Tim Nguyen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp M Source/WebCore/rendering/BorderPainter.cpp Log Message: --- REGRESSION(266134@main): 3D border-style have very low contrast with very dark border-color https://bugs.webkit.org/show_bug.cgi?id=261847 rdar://115812372 Reviewed by Darin Adler. 266134@main made 3D border styles like groove, ridge, inset, and outset honor the border-color instead of hardcoding a gray color. Unfortunately, when a dark border-color is used, there is very little contrast between the light border and the dark border. To fix this, we follow Firefox's algorithm of special casing very dark colors by contrasting 2 lightened versions of the border-color. See Firefox's algorithm for reference: https://searchfox.org/mozilla-central/rev/077fc34d03b85b09add26b5f99f1a3a3a72c8720/gfx/wr/webrender/res/cs_border_segment.glsl#112-132 * Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp: (WebCore::Display::BorderPainter::calculateBorderStyleColor): * Source/WebCore/rendering/BorderPainter.cpp: (WebCore::BorderPainter::calculateBorderStyleColor): Canonical link: https://commits.webkit.org/268265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5faeb7: [Multicol][IFC] Support vertical writing modes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5faeb73b26d401045e76b6c5bad739a6084637db https://github.com/WebKit/WebKit/commit/5faeb73b26d401045e76b6c5bad739a6084637db Author: Antti Koivisto Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-multicol-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-multicol-003-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-multicol-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-multicol-003-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/fast/multicol/block-axis-horizontal-bt-expected.txt M LayoutTests/platform/ios/fast/multicol/block-axis-vertical-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/client-rects-spanners-complex-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/BottomToTop-bt-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/BottomToTop-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/LeftToRight-bt-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/LeftToRight-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/RightToLeft-bt-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/RightToLeft-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/TopToBottom-bt-expected.txt M LayoutTests/platform/ios/fast/multicol/pagination/TopToBottom-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/tall-image-behavior-lr-expected.txt M LayoutTests/platform/ios/fast/multicol/tall-image-behavior-lr-mixed-expected.txt M LayoutTests/platform/ios/fast/multicol/tall-image-behavior-rl-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/border-padding-pagination-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/column-count-with-rules-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/column-rules-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/float-avoidance-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/float-multicol-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/float-paginate-complex-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/float-paginate-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/nested-columns-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt M LayoutTests/platform/ios/fast/multicol/vertical-rl/float-multicol-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-multicol-003-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-align-baseline-multicol-003-expected.txt M LayoutTests/platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt M LayoutTests/platform/mac/fast/multicol/tall-image-behavior-lr-expected.txt M LayoutTests/platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt M LayoutTests/platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt M LayoutTests/platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.h M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- [Multicol][IFC] Support vertical writing modes https://bugs.webkit.org/show_bug.cgi?id=261817 rdar://115779405 Reviewed by Alan Baradlay. Enable vertical writing modes in IFC with multicolumn content. * LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/alignment/flex-align-baseline-multicol-002
[webkit-changes] [WebKit/WebKit] fcea4a: [WPE][GTK] Gardening API test `TestWebKit` `WebKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcea4a1eae73c77d22762a9a46583de86a134781 https://github.com/WebKit/WebKit/commit/fcea4a1eae73c77d22762a9a46583de86a134781 Author: Vitaly Dyachkov Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [WPE][GTK] Gardening API test `TestWebKit` `WebKit.MouseMoveAfterCrash` https://bugs.webkit.org/show_bug.cgi?id=261818 Unreviewed test gardening. Fixed in 268095@main. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/268263@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf9506: [JSC] SyntaxError message for function declaration...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf9506016a8f3e411bf6dcb62eae9177c56452c2 https://github.com/WebKit/WebKit/commit/bf9506016a8f3e411bf6dcb62eae9177c56452c2 Author: Alexey Shvayka Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/js/let-syntax-expected.txt M LayoutTests/js/parser-syntax-check-expected.txt M LayoutTests/js/script-tests/parser-syntax-check.js M Source/JavaScriptCore/parser/Parser.cpp Log Message: --- [JSC] SyntaxError message for function declaration duplicating lexical one is misleading https://bugs.webkit.org/show_bug.cgi?id=261863 Reviewed by Keith Miller. This change removes "in strict mode" from the error message since it occurs in any mode (please see Scope::declareFunction() implementation). * LayoutTests/js/let-syntax-expected.txt: * LayoutTests/js/parser-syntax-check-expected.txt: * LayoutTests/js/script-tests/parser-syntax-check.js: * Source/JavaScriptCore/parser/Parser.cpp: (JSC::Parser::parseFunctionDeclaration): (JSC::Parser::parseAsyncFunctionDeclaration): Canonical link: https://commits.webkit.org/268262@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c4d08: Remove check for space in REAL_NAME
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c4d08c5189ce738f08a6db98e0662bba15573de https://github.com/WebKit/WebKit/commit/4c4d08c5189ce738f08a6db98e0662bba15573de Author: Pascoe Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/Scripts/VCSUtils.pm Log Message: --- Remove check for space in REAL_NAME https://bugs.webkit.org/show_bug.cgi?id=261538 rdar://115458379 Reviewed by Jonathan Bedard. Not all real names contain spaces. * Tools/Scripts/VCSUtils.pm: (changeLogName): Remove check for space in name. Canonical link: https://commits.webkit.org/268261@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 928910: Regression(268215@main): imported/w3c/web-platform...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92891095fc280595f23ccd453d817f7cb958b867 https://github.com/WebKit/WebKit/commit/92891095fc280595f23ccd453d817f7cb958b867 Author: Chris Dumez Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/animation/DeclarativeAnimation.cpp M Source/WebCore/animation/DeclarativeAnimation.h Log Message: --- Regression(268215@main): imported/w3c/web-platform-tests/css/css-transitions/changing-while-transition-001.html is flakily crashing https://bugs.webkit.org/show_bug.cgi?id=261886 Unreviewed partial revert of 268215@main to address crashes on the bots. * Source/WebCore/animation/DeclarativeAnimation.cpp: (WebCore::DeclarativeAnimation::owningElement const): (WebCore::DeclarativeAnimation::initialize): (WebCore::DeclarativeAnimation::shouldFireDOMEvents const): * Source/WebCore/animation/DeclarativeAnimation.h: Canonical link: https://commits.webkit.org/268260@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9406e8: [JSC] Use Call-Ret for DataIC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9406e8ac287abb90fa86509ef0519cbdf4d71ed5 https://github.com/WebKit/WebKit/commit/9406e8ac287abb90fa86509ef0519cbdf4d71ed5 Author: Yusuke Suzuki Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/InlineAccess.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGInlineCacheWrapperInlines.h M Source/JavaScriptCore/dfg/DFGJITCode.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/BaselineJITRegisters.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITCall.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/jit/JITPropertyAccess.cpp M Source/JavaScriptCore/jit/RegisterSet.h Log Message: --- [JSC] Use Call-Ret for DataIC https://bugs.webkit.org/show_bug.cgi?id=261595 rdar://115542885 Reviewed by Keith Miller. This patch converts Baseline DataIC from farJump-based to call-ret based. Because we get rid of dependency on CodeBlock and make sp-adjustment work with JITData, now we can appropriately adjust sp without embedding CodeBlock's information. This makes each Data IC code independent from CodeBlock, and allowing us to use call-ret to jump to IC: this is the basis of handler IC. Now we see this Data IC as a large handler. We will split them and chain them with jumps so that we can minimize compilations and share code in Baseline. Baseline calls the IC code, and IC returns when it finds a result. And we jump to the slow path code finally, and slow path invokes operation, then return. [baseline code ] call | ^^ v ret |ret | [ IC code ] -> [ slow path ] call | ^ v ret | [ operation ] In this way, we can exercise return address predictor well, and sharing slow path code. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::setupWithUnlinkedBaselineCode): * Source/JavaScriptCore/bytecode/InlineAccess.cpp: (JSC::InlineAccess::resetStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccessNotUsingInlineAccess): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::succeed): (JSC::getByIdSlowPathCodeGenerator): (JSC::getByIdWithThisSlowPathCodeGenerator): (JSC::getByValSlowPathCodeGenerator): (JSC::getPrivateNameSlowPathCodeGenerator): (JSC::getByValWithThisSlowPathCodeGenerator): (JSC::putByIdSlowPathCodeGenerator): (JSC::putByValSlowPathCodeGenerator): (JSC::instanceOfSlowPathCodeGenerator): (JSC::delByIdSlowPathCodeGenerator): (JSC::delByValSlowPathCodeGenerator): (JSC::InlineCacheCompiler::generateSlowPathCode): (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::emitProxyObjectAccess): (JSC::InlineCacheCompiler::regenerate): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: * Source/JavaScriptCore/bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo): * Source/JavaScriptCore/bytecode/StructureStubInfo.h: * Source/JavaScriptCore/dfg/DFGInlineCacheWrapperInlines.h: (JSC::DFG::InlineCacheWrapper::finalize): * Source/JavaScriptCore/dfg/DFGJITCode.h: * Source/JavaScriptCore/jit/BaselineJITRegisters.h: * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::link): * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITCall.cpp: (JSC::JIT::emitSlow_op_iterator_open): (JSC::JIT::emit_op_iterator_next): (JSC::JIT::emitSlow_op_iterator_next): * Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp: (JSC::JITInlineCacheGenerator::finalize): (JSC::JITInlineCacheGenerator::generateBaselineDataICFastPath): (JSC::JITByIdGenerator::finalize): (JSC::generateGetByIdInlineAccess): (JSC::generatePutByIdInlineAccess): (JSC::JITDelByValGenerator::generateFastPath): (JSC::JITDelByValGenerator::finalize): (JSC::JITDelByIdGenerator::generateFastPath): (JSC::JITDelByIdGenerator::finalize): (JSC::JITInByValGenerator::generateFastPath): (JSC::JITInByValGenerator::finalize): (JSC::generateInByIdInlineAccess): (JSC::JITInstanceOfGenerator::generateFastPath): (JSC::JITInstanceOfGenerator::finalize): (JSC::JITGetByValGenerator::generateFas
[webkit-changes] [WebKit/WebKit] 480e2f: [WGSL] discard keyword is not supported
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 480e2fdea469702799f3956d852fba66b6548441 https://github.com/WebKit/WebKit/commit/480e2fdea469702799f3956d852fba66b6548441 Author: Tadeu Zagallo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/Parser.cpp Log Message: --- [WGSL] discard keyword is not supported https://bugs.webkit.org/show_bug.cgi?id=261862 rdar://115823568 Reviewed by Mike Wyrzykowski. Add support for discard statements according to the spec[1]. [1]: https://www.w3.org/TR/WGSL/#discard-statement * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseStatement): Canonical link: https://commits.webkit.org/268258@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc7919: [WGSL] Update test expectation after 268237@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc79194b362e02b75519d544302f061409c3d6d0 https://github.com/WebKit/WebKit/commit/cc79194b362e02b75519d544302f061409c3d6d0 Author: Tadeu Zagallo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebGPU/WGSL/tests/valid/local-constant-trivial.wgsl Log Message: --- [WGSL] Update test expectation after 268237@main https://bugs.webkit.org/show_bug.cgi?id=261879 rdar://115842090 Unreviewed, update test expectation after 268237@main as float numbers are now serialized with the trailing decimal point. * Source/WebGPU/WGSL/tests/valid/local-constant-trivial.wgsl: Canonical link: https://commits.webkit.org/268257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fc18d: AX: AXWebSessionID, AXIsMultiline, AXReadOnlyValue...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fc18de4dfcd6cff22179de72aa5f75a248f90fe https://github.com/WebKit/WebKit/commit/3fc18de4dfcd6cff22179de72aa5f75a248f90fe Author: Tyler Wilcock Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: R LayoutTests/accessibility/document-attributes-expected.txt R LayoutTests/accessibility/document-attributes.html M LayoutTests/accessibility/mac/document-attributes-expected.txt R LayoutTests/accessibility/mac/session-id-expected.txt R LayoutTests/accessibility/mac/session-id.html M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/DumpRenderTree/AccessibilityUIElement.cpp M Tools/DumpRenderTree/AccessibilityUIElement.h M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp Log Message: --- AX: AXWebSessionID, AXIsMultiline, AXReadOnlyValue, AXDocumentURIAttribute, and AXDocumentEncodingAttribute are unused by AX clients https://bugs.webkit.org/show_bug.cgi?id=261799 rdar://problem/115764193 Reviewed by Chris Fleizach and Andres Gonzalez. This patch removes the tests and code supporting these attributes. * LayoutTests/accessibility/document-attributes-expected.txt: Removed. * LayoutTests/accessibility/document-attributes.html: Removed. * LayoutTests/accessibility/mac/document-attributes-expected.txt: * LayoutTests/accessibility/mac/session-id-expected.txt: Removed. * LayoutTests/accessibility/mac/session-id.html: Removed. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::updateIsolatedTree): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::documentURI const): Deleted. (WebCore::AccessibilityObject::documentEncoding const): Deleted. (WebCore::AccessibilityObject::sessionID const): Deleted. * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/AccessibilityObjectInterface.h: (WebCore::AXCoreObject::ariaIsMultiline const): (WebCore::AXCoreObject::readOnlyValue const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::AXIsolatedObject): (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::sessionID const): Deleted. (WebCore::AXIsolatedObject::documentURI const): Deleted. (WebCore::AXIsolatedObject::documentEncoding const): Deleted. (WebCore::AXIsolatedObject::sessionIDAttributeValue const): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateNodeProperties): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Canonical link: https://commits.webkit.org/268256@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd38ff: Add the scripting property to the browser namespace
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd38ff3650973c7f09ba7fd1a8cf6a2abf131b58 https://github.com/WebKit/WebKit/commit/dd38ff3650973c7f09ba7fd1a8cf6a2abf131b58 Author: Kiara Rose Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources-output.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm A Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPermissions.h A Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIScripting.h M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl A Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIScripting.idl M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm Log Message: --- Add the scripting property to the browser namespace https://bugs.webkit.org/show_bug.cgi?id=259948 Reviewed by Timothy Hatcher. This patch adds initial support for `browser.scripting` by adding the APIs to the idl file and doing data validation in the Web Process. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources-output.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm: (WebKit::WebExtensionAPINamespace::scripting): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIScriptingCocoa.mm: Added. (WebKit::WebExtensionAPIScripting::executeScript): (WebKit::WebExtensionAPIScripting::insertCSS): (WebKit::WebExtensionAPIScripting::removeCSS): (WebKit::WebExtensionAPIScripting::registerContentScripts): (WebKit::WebExtensionAPIScripting::getRegisteredContentScripts): (WebKit::WebExtensionAPIScripting::updateContentScripts): (WebKit::WebExtensionAPIScripting::unregisterContentScripts): (WebKit::WebExtensionAPIScripting::validateScript): (WebKit::WebExtensionAPIScripting::validateTarget): (WebKit::WebExtensionAPIScripting::validateCSS): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPINamespace.h: * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPermissions.h: * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIScripting.h: Copied from Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIPermissions.h. * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm: * Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl: * Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIScripting.idl: Copied from Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPINamespace.idl. * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm: Added. (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/268255@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6d5c08: [ EWS macOS WK1 ] run-layout-tests-in-stress-mode ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6d5c08794a5719fc189eedd788b36df7fc9dc264 https://github.com/WebKit/WebKit/commit/6d5c08794a5719fc189eedd788b36df7fc9dc264 Author: Brianna Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/CISupport/ews-build/factories.py M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [ EWS macOS WK1 ] run-layout-tests-in-stress-mode always runs tests in WK2 (with WKTR) https://bugs.webkit.org/show_bug.cgi?id=261423 rdar://115672166 Reviewed by Aakash Jain and Jonathan Bedard. Sets flag for WK1 if LayoutTestClass == RunWebKit1Tests. * Tools/CISupport/ews-build/factories.py: (TestFactory.__init__): * Tools/CISupport/ews-build/steps.py: (RunWebKitTestsInStressMode.__init__): (RunWebKitTestsInStressMode.setLayoutTestCommand): * Tools/CISupport/ews-build/steps_unittest.py: (TestRunWebKitTestsInStressMode.test_success_wk1): Canonical link: https://commits.webkit.org/268254@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd754c: Block notifyd in experimental sandbox
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd754ccd63610779ff1a2700274ccf5bb0fcba36 https://github.com/WebKit/WebKit/commit/fd754ccd63610779ff1a2700274ccf5bb0fcba36 Author: Per Arne Vollan Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Block notifyd in experimental sandbox https://bugs.webkit.org/show_bug.cgi?id=261860 Reviewed by Chris Dumez. Block notifyd in experimental sandbox in the WebContent process. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/268253@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a5637e: Add atomics to IPInt
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a5637e2156cb073b5fb5c820ad02b9115c88e4d7 https://github.com/WebKit/WebKit/commit/a5637e2156cb073b5fb5c820ad02b9115c88e4d7 Author: Keith Miller Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/JavaScriptCore/llint/InPlaceInterpreter.asm M Source/JavaScriptCore/llint/InPlaceInterpreter.cpp M Source/JavaScriptCore/llint/InPlaceInterpreter.h M Source/JavaScriptCore/runtime/OptionsList.h M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp M Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp M Source/JavaScriptCore/wasm/WasmOperationsInlines.h M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmSlowPaths.h Log Message: --- Add atomics to IPInt https://bugs.webkit.org/show_bug.cgi?id=261855 Reviewed by Yusuke Suzuki. Add support for the wasm thread proposal's atomic instructions to IPInt. Right now this only works for arm64(e) as the IPInt seems to have other issues when running on X86_64. Although the structure of the atomic instructions should be implemented for X86_64. A lot of the instructions were implemented in the LLInt so they could be "straightforwardly" copied to the IPInt. The LLInt seems to do a decent amount of extra work that doesn't seem to be necessary (at least on ARM64E). For example, LLInt ands the low bits of the atomic RMW result even though the instructions zero extend anyway. Additionally, this patch fixes trapping from wasm. Previously, the callee save registers were not saved in the same order that the C++ code expects (in decreasing order). This was fine for IPInt code but broke when doing `genericUnwind`. Lastly, this patch adds an FunctionIPIntMetadataGenerator::addLength for wasm bytecodes that have variable length but no metatdata. This is currently only the extended opcodes since the extended instruction is encoded as a varUInt32 and can be non-canonically encoded as something longer than 1 byte. I believe the other extended bytecodes are incorrect but I will fix those in a follow up patch. * Source/JavaScriptCore/llint/InPlaceInterpreter.asm: * Source/JavaScriptCore/llint/InPlaceInterpreter.cpp: (JSC::IPInt::initialize): * Source/JavaScriptCore/llint/InPlaceInterpreter.h: * Source/JavaScriptCore/runtime/OptionsList.h: * Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.cpp: (JSC::Wasm::FunctionIPIntMetadataGenerator::addLength): * Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h: * Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp: (JSC::Wasm::IPIntGenerator::atomicLoad): (JSC::Wasm::IPIntGenerator::atomicStore): (JSC::Wasm::IPIntGenerator::atomicBinaryRMW): (JSC::Wasm::IPIntGenerator::atomicCompareExchange): (JSC::Wasm::IPIntGenerator::atomicWait): (JSC::Wasm::IPIntGenerator::atomicNotify): (JSC::Wasm::IPIntGenerator::atomicFence): * Source/JavaScriptCore/wasm/WasmOperationsInlines.h: (JSC::Wasm::memoryAtomicWait32): (JSC::Wasm::memoryAtomicWait64): * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL): * Source/JavaScriptCore/wasm/WasmSlowPaths.h: Canonical link: https://commits.webkit.org/268252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50a0c4: RemoteImageBufferProxy re-populates backend info a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50a0c40dacf6e455efea5a52a47bbb0112d25284 https://github.com/WebKit/WebKit/commit/50a0c40dacf6e455efea5a52a47bbb0112d25284 Author: Kimmo Kinnunen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/fast/canvas/image-buffer-backend-variants-expected.txt M LayoutTests/platform/ios/fast/canvas/image-buffer-backend-variants-expected.txt A LayoutTests/platform/mac-wk1/fast/canvas/image-buffer-backend-variants-expected.txt M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/platform/graphics/ImageBuffer.cpp A Source/WebCore/platform/graphics/NullImageBufferBackend.cpp A Source/WebCore/platform/graphics/NullImageBufferBackend.h M Source/WebCore/platform/graphics/PixelBuffer.h M Source/WebCore/platform/graphics/cg/PathCG.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp Log Message: --- RemoteImageBufferProxy re-populates backend info after getting the backend handle https://bugs.webkit.org/show_bug.cgi?id=261027 rdar://114816328 Reviewed by Matt Woodrow. Reland after revert with compile errors fixed. The code is structured as if it would make sense that Caller calls * RemoteImageBufferProxy::create * GPUP sends ShareableBitmap::Handle It is better that the backend type being used during ImageBuffer creation is respected during didCreateBackend. Implements error handling for cases where the allocation fails in GPUP. Before, the allocation failure would result in WP hang. This is work towards being able to create the backend during construction, so that most operations needing the backend would not block until the handle has been communicated. * LayoutTests/fast/canvas/image-buffer-iosurface-disabled-expected.txt: * LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html: Fix the test to ensure that the tested command, creating too big accelerated image buffer, would reach the GPUP within the test. Otherwise, failing to do so would result in failure of the next test, as this test would finish before its commands were run on GPUP. Next test is typically fast/canvas/image-object-in-canvas.html. * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::getPixelBuffer const): (WebCore::ImageBuffer::putPixelBuffer): * Source/WebCore/platform/graphics/ImageBufferBackend.h: (WebCore::ImageBufferBackend::toBackendCoordinates const): Deleted. * Source/WebCore/platform/graphics/PixelBuffer.h: * Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp: (WebCore::ImageBufferCairoSurfaceBackend::putPixelBuffer): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: (WebKit::RemoteDisplayListRecorder::create): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::didFailCreateImageBuffer): (WebKit::RemoteRenderingBackend::didCreateImageBuffer): (WebKit::RemoteRenderingBackend::createImageBuffer): (WebKit::RemoteRenderingBackend::releaseImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteImageBufferProxy::didCreateBackend): (WebKit::RemoteImageBufferProxy::getPixelBuffer const): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::createImageBuffer): Canonical link: https://commits.webkit.org/268251@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c6da1: [IFC][Ruby] Initial value of ruby-align is space-a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c6da1f2dc8bb323d15005a0b3f1ee5fdbd1f22e https://github.com/WebKit/WebKit/commit/9c6da1f2dc8bb323d15005a0b3f1ee5fdbd1f22e Author: Alan Baradlay Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLine.h M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h Log Message: --- [IFC][Ruby] Initial value of ruby-align is space-around. https://bugs.webkit.org/show_bug.cgi?id=261822 Reviewed by Antti Koivisto. "space-around: As for space-between except that there exists an extra justification opportunities whose space is distributed half before and half after the ruby content" https://drafts.csswg.org/css-ruby/#ruby-align-property 1. Move align logic to a dedicated function 2. Apply before/after spacing on the base runs on the line * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::layoutRubyBaseInlineAxis): Canonical link: https://commits.webkit.org/268250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 507f22: ImageBuffer has unused WebGL related functions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 507f2296f236c37f27baf4e3108990a996850fef https://github.com/WebKit/WebKit/commit/507f2296f236c37f27baf4e3108990a996850fef Author: Kimmo Kinnunen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/ImageBufferBackend.h Log Message: --- ImageBuffer has unused WebGL related functions https://bugs.webkit.org/show_bug.cgi?id=261865 rdar://115826789 Reviewed by Antti Koivisto. Remove the unused functions. * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::copyToPlatformTexture const): Deleted. * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/platform/graphics/ImageBufferBackend.h: (WebCore::ImageBufferBackend::copyToPlatformTexture): Deleted. Canonical link: https://commits.webkit.org/268249@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 967c25: Unreviewed, reverting 268244@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 967c25ec398aa7d54581dd137d9b7eac27bc2230 https://github.com/WebKit/WebKit/commit/967c25ec398aa7d54581dd137d9b7eac27bc2230 Author: Commit Queue Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/fast/canvas/image-buffer-backend-variants-expected.txt M LayoutTests/platform/ios/fast/canvas/image-buffer-backend-variants-expected.txt R LayoutTests/platform/mac-wk1/fast/canvas/image-buffer-backend-variants-expected.txt M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/platform/graphics/ImageBuffer.cpp R Source/WebCore/platform/graphics/NullImageBufferBackend.cpp R Source/WebCore/platform/graphics/NullImageBufferBackend.h M Source/WebCore/platform/graphics/PixelBuffer.h M Source/WebCore/platform/graphics/cg/PathCG.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp Log Message: --- Unreviewed, reverting 268244@main. https://bugs.webkit.org/show_bug.cgi?id=261875 Broke various builds Reverted changeset: "RemoteImageBufferProxy re-populates backend info after getting the backend handle" https://bugs.webkit.org/show_bug.cgi?id=261027 https://commits.webkit.org/268244@main Canonical link: https://commits.webkit.org/268248@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0e414d: [build.webkit.org] layout-tests step should fail b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e414dda15b582f8936991071d07605d850c9a3e https://github.com/WebKit/WebKit/commit/0e414dda15b582f8936991071d07605d850c9a3e Author: Aakash Jain Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] layout-tests step should fail builds that exceed a predefined threshold of log lines https://bugs.webkit.org/show_bug.cgi?id=261836 Reviewed by Jonathan Bedard. * Tools/CISupport/build-webkit-org/steps.py: (CompileWebKit.handleExcessiveLogging): (CompileWebKit.getResultSummary): (RunWebKitTests): (RunWebKitTests.parseOutputLine): (RunWebKitTests.getResultSummary): (RunWebKitTests.handleExcessiveLogging): (RunWebDriverTests.getResultSummary): (RunWebDriverTests.handleExcessiveLogging): Canonical link: https://commits.webkit.org/268247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fad639: NativePromise should be forward-declared in WTF/Fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fad6397d597a5f40e53052b85149b5f1e411b6ae https://github.com/WebKit/WebKit/commit/fad6397d597a5f40e53052b85149b5f1e411b6ae Author: Jean-Yves Avenard Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WTF/wtf/Forward.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithStreamMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandleMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h M Source/WebKit/Scripts/webkit/tests/TestWithoutUsingIPCConnectionMessages.h M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h Log Message: --- NativePromise should be forward-declared in WTF/Forwards.h https://bugs.webkit.org/show_bug.cgi?id=261864 rdar://115826365 Reviewed by Kimmo Kinnunen. Have NativePromise forward declaration in wtf/Forward.h * Source/WTF/wtf/Forward.h: * Source/WebKit/Scripts/webkit/messages.py: (generate_messages_header): (generate_messages_header.NativePromise): Deleted. * Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithStreamMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandleMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h: * Source/WebKit/Scripts/webkit/tests/TestWithoutUsingIPCConnectionMessages.h: * Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h: Canonical link: https://commits.webkit.org/268246@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3d505c: [WGSL] Add support for address-of and indirection ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3d505c75ee55d8c58313680465defe3e9a145d8d https://github.com/WebKit/WebKit/commit/3d505c75ee55d8c58313680465defe3e9a145d8d Author: Tadeu Zagallo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Constraints.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/Overload.cpp M Source/WebGPU/WGSL/Overload.h M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/generator/main.rb M Source/WebGPU/WGSL/tests/valid/overload.wgsl M Source/WebGPU/WGSL/tests/valid/pointers.wgsl Log Message: --- [WGSL] Add support for address-of and indirection operators https://bugs.webkit.org/show_bug.cgi?id=261833 Reviewed by Dan Glastonbury. Add the type declarations for address-of (&x, spec[1]) and indirection (*x, spec[2]) operators. This required introducing AbstractReference and AbstractPointer to the overload resolution algorithm and exposing them to the ruby DSL, as well as exposing address space and access mode, which was done by generalizing NumericVariables to use the underlying enum type. [1]: https://www.w3.org/TR/WGSL/#address-of-expr [2]: https://www.w3.org/TR/WGSL/#indirection-expr * Source/WebGPU/WGSL/Constraints.cpp: (WGSL::satisfies): (WGSL::satisfyOrPromote): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/Overload.cpp: (WGSL::OverloadResolver::OverloadResolver): (WGSL::OverloadResolver::materialize const): (WGSL::OverloadResolver::considerCandidate): (WGSL::OverloadResolver::calculateRank): (WGSL::OverloadResolver::unify): (WGSL::OverloadResolver::assign): (WGSL::OverloadResolver::resolve const): (WGSL::resolveOverloads): (WTF::printInternal): * Source/WebGPU/WGSL/Overload.h: * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/generator/main.rb: * Source/WebGPU/WGSL/tests/valid/overload.wgsl: * Source/WebGPU/WGSL/tests/valid/pointers.wgsl: Canonical link: https://commits.webkit.org/268245@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a76cf0: RemoteImageBufferProxy re-populates backend info a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a76cf096e26a991fd54bbffbad5b828a2bf368b3 https://github.com/WebKit/WebKit/commit/a76cf096e26a991fd54bbffbad5b828a2bf368b3 Author: Kimmo Kinnunen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/fast/canvas/image-buffer-backend-variants-expected.txt M LayoutTests/platform/ios/fast/canvas/image-buffer-backend-variants-expected.txt A LayoutTests/platform/mac-wk1/fast/canvas/image-buffer-backend-variants-expected.txt M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/platform/graphics/ImageBuffer.cpp A Source/WebCore/platform/graphics/NullImageBufferBackend.cpp A Source/WebCore/platform/graphics/NullImageBufferBackend.h M Source/WebCore/platform/graphics/PixelBuffer.h M Source/WebCore/platform/graphics/cg/PathCG.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp Log Message: --- RemoteImageBufferProxy re-populates backend info after getting the backend handle https://bugs.webkit.org/show_bug.cgi?id=261027 rdar://114816328 Reviewed by Matt Woodrow. The code is structured as if it would make sense that Caller calls * RemoteImageBufferProxy::create * GPUP sends ShareableBitmap::Handle It is better that the backend type being used during ImageBuffer creation is respected during didCreateBackend. Implements error handling for cases where the allocation fails in GPUP. Before, the allocation failure would result in WP hang. This is work towards being able to create the backend during construction, so that most operations needing the backend would not block until the handle has been communicated. * LayoutTests/fast/canvas/image-buffer-iosurface-disabled-expected.txt: * LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html: Fix the test to ensure that the tested command, creating too big accelerated image buffer, would reach the GPUP within the test. Otherwise, failing to do so would result in failure of the next test, as this test would finish before its commands were run on GPUP. Next test is typically fast/canvas/image-object-in-canvas.html. * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::getPixelBuffer const): (WebCore::ImageBuffer::putPixelBuffer): * Source/WebCore/platform/graphics/ImageBufferBackend.h: (WebCore::ImageBufferBackend::toBackendCoordinates const): Deleted. * Source/WebCore/platform/graphics/PixelBuffer.h: * Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp: (WebCore::ImageBufferCairoSurfaceBackend::putPixelBuffer): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: (WebKit::RemoteDisplayListRecorder::create): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::didFailCreateImageBuffer): (WebKit::RemoteRenderingBackend::didCreateImageBuffer): (WebKit::RemoteRenderingBackend::createImageBuffer): (WebKit::RemoteRenderingBackend::releaseImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/Scripts/webkit/messages.py: (types_that_must_be_moved): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp: (WebKit::RemoteImageBufferProxy::didCreateBackend): (WebKit::RemoteImageBufferProxy::getPixelBuffer const): * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::createImageBuffer): Canonical link: https://commits.webkit.org/268244@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 329f7d: ImageBufferBackend has three overlapping copy-like...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 329f7da0cc3778b668fd606736876062da438036 https://github.com/WebKit/WebKit/commit/329f7da0cc3778b668fd606736876062da438036 Author: Kimmo Kinnunen Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/CachedSubimage.cpp M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/ImageBufferBackend.cpp M Source/WebCore/platform/graphics/ImageBufferBackend.h M Source/WebCore/platform/graphics/SourceImage.cpp M Source/WebCore/platform/graphics/ca/cocoa/GraphicsLayerAsyncContentsDisplayDelegateCocoa.mm M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h M Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp M Source/WebCore/platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h M Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.mm M Source/WebKit/Shared/WebImage.cpp M Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp M Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.cpp M Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.h Log Message: --- ImageBufferBackend has three overlapping copy-like functions https://bugs.webkit.org/show_bug.cgi?id=261731 rdar://115718413 Reviewed by Matt Woodrow. ImageBuffer and -Backend function copyNativeImage(BackingStoreCopy) is actually two rather distinct functions: copy and a reference. copyNativeImageForDrawing() is equivalent to copyNativeImage(DontBackingStore) and certain custom logic needed for the call chain. Move the decision to do a copy for draw or a reference for draw into top-level GraphicsContext. This information will be also used in future when implementing more correct display list retaining of backing stores as well as removing the image buffer related remote drawing commands. Make a clear distinction between creating a copy and creating a reference to the backing store by calling the functions with different names. Use the function in more places that obtain a drawable NativeImage out of an ImageBuffer. Removes ImageBuffer::draw because it was a redudundant addition to the call-stack: GraphicsContext::drawImageBuffer ImageBuffer::draw Graphicscontext::drawNativeImageInternal This is work towards making the NativeImage the only image primitive being drawn from, where as currently also ImageBuffer is a pseudo-primitive. * Source/WebCore/platform/graphics/CachedSubimage.cpp: (WebCore::CachedSubimage::draw): * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::nativeImageForDrawing): (WebCore::GraphicsContext::drawImageBuffer): * Source/WebCore/platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::deferred const): * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::copyImageBufferToNativeImage): (WebCore::ImageBuffer::copyNativeImage const): (WebCore::ImageBuffer::createNativeImageReference const): (WebCore::ImageBuffer::copyNativeImageForDrawing const): Deleted. (WebCore::ImageBuffer::draw): Deleted. * Source/WebCore/platform/graphics/Imag
[webkit-changes] [WebKit/WebKit] a42888: Re-import canvas text tests and fonts
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4288839e210b8c3590e2b1dd67751bf7dfac11e https://github.com/WebKit/WebKit/commit/a4288839e210b8c3590e2b1dd67751bf7dfac11e Author: Gerald Squelart Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/fonts/CanvasTest-ascent256.ttf A LayoutTests/imported/w3c/fonts/CanvasTest-descent0.ttf M LayoutTests/imported/w3c/fonts/CanvasTest.ttf M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest-ascent256.ttf A LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest-descent0.ttf M LayoutTests/imported/w3c/web-platform-tests/fonts/CanvasTest.ttf M LayoutTests/imported/w3c/web-platform-tests/fonts/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.letterSpacing.measure.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.drawing.style.wordSpacing.measure.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.font.weight-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.font.weight.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps1-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps1.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps2-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps2.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps3-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps3.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps4-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps4.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps5-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps5.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps6-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.fontVariantCaps6.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-low-ascent-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-low-ascent.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-zero-descent-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights-zero-descent.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.emHeights.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-reduced-ascent-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-reduced-ascent.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-zero-descent-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox-zero-descent.html M LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/2d.text.measure.fontBoundingBox.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-1-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-1.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-2-expected-mismatch.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-2.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-3-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-3.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-4-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/text/fontVariantCaps-4.html R LayoutTests/imported/w3c/web-plat
[webkit-changes] [WebKit/WebKit] 9ed0cc: Introduce OptionSet to updateLayout
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ed0cc30d357eb9673342ff8bd1d8143485034c8 https://github.com/WebKit/WebKit/commit/9ed0cc30d357eb9673342ff8bd1d8143485034c8 Author: Rob Buis Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/html/HTMLPlugInElement.cpp M Source/WebCore/page/VisualViewport.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.mm M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMRange.mm M Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm M Source/WebKitLegacy/mac/DOM/DOM.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Introduce OptionSet to updateLayout https://bugs.webkit.org/show_bug.cgi?id=261105 Reviewed by Tim Nguyen. Introduce OptionSet to updateLayout to be able to specify its behaviour, i.e. whether to run post lasyout tasks and/or ignore stylesheets. * Source/WebCore/dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateLayout): * Source/WebCore/dom/Document.h: (WebCore::Document::updateLayout): (WebCore::Document::updateLayoutIgnorePendingStylesheets): * Source/WebCore/html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::renderWidgetLoadingPlugin const): * Source/WebCore/page/VisualViewport.cpp: (WebCore::VisualViewport::updateFrameLayout const): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::absoluteLineRectFromPoint): (WebCore::Internals::boundingBox): (WebCore::Internals::layoutViewportRect): (WebCore::Internals::visualViewportRect): (WebCore::Internals::lineIndexAfterPageBreak): (WebCore::Internals::recentSearches): (WebCore::Internals::nodesFromRect const): (WebCore::Internals::layerIDForElement): (WebCore:: const): (WebCore::Internals::scrollingStateTreeAsText const): (WebCore::Internals::scrollingTreeAsText const): (WebCore::Internals::haveScrollingTree const): (WebCore::Internals::setElementUsesDisplayListDrawing): (WebCore::Internals::setElementTracksDisplayListReplay): (WebCore::Internals::displayListForElement): (WebCore::Internals::replayDisplayListForElement): (WebCore::Internals::cachedGlyphDisplayListsForTextNode): (WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks): (WebCore::Internals::isSelectPopupVisible): (WebCore::Internals::pageOverlayLayerTreeAsText const): * Source/WebCore/testing/Internals.mm: (WebCore::Internals::rangeForDictionaryLookupAtLocation): * Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: (-[WKDOMNode textRects]): * Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: (-[WKDOMRange textRects]): * Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp: (WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::elementBoundsInFrame): (WebKit::WebPage::requestDocumentEditingContext): (WebKit::WebPage::focusTextInputContextAndPlaceCaret): * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::inlineVideoFrame): * Source/WebKitLegacy/mac/DOM/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode absoluteQuadAndInsideFixedPosition:]): (-[DOMNode boundingBoxUsingTransforms]): (-[DOMNode lineBoxQuads]): (-[DOMNode innerFrameQuad]): (-[DOMNode textRects]): (-[DOMRange boundingBox]): (-[DOMRange textRects]): * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView updateLayoutIgnorePendingStyleSheets]): Canonical link: https://commits.webkit.org/268241@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f997a9: Give ability for IPC calls to work with NativePromise
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f997a9edb80cd79caeb1d0a1b87610ffd7a56e88
https://github.com/WebKit/WebKit/commit/f997a9edb80cd79caeb1d0a1b87610ffd7a56e88
Author: Jean-Yves Avenard
Date: 2023-09-21 (Thu, 21 Sep 2023)
Changed paths:
M Source/WTF/wtf/NativePromise.h
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamMessages.h
M
Source/WebKit/Scripts/webkit/tests/TestWithStreamServerConnectionHandleMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h
M Source/WebKit/Scripts/webkit/tests/TestWithoutUsingIPCConnectionMessages.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.h
M Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp
M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp
Log Message:
---
Give ability for IPC calls to work with NativePromise
https://bugs.webkit.org/show_bug.cgi?id=261720
rdar://115704438
Reviewed by Kimmo Kinnunen.
Add the ability to send an asynchronous IPC message where the response
will be returned in the form of a NativePromise.
The NativePromise will be rejected with the IPC error if an error occurs.
Otherwise, the value returned is the value of the IPC response. Unlike the
CompletionHandler version sendWithAsyncReply, the returned value is only
wrapped in a std::tuple if more than 1 element is returned.
The Promise is defined for each asynchronous message generated like so:
```
class WaitForTarget {
public:
using Arguments = std::tuple;
static IPC::MessageName name() { return
IPC::MessageName::MediaSourcePrivateRemote_WaitForTarget; }
static constexpr bool isSync = false;
static constexpr bool canDispatchOutOfOrder = false;
static constexpr bool replyCanDispatchOutOfOrder = false;
static IPC::MessageName asyncMessageReplyName() { return
IPC::MessageName::MediaSourcePrivateRemote_WaitForTargetReply; }
static constexpr auto callbackThread =
WTF::CompletionHandlerCallThread::ConstructionThread;
using ReplyArguments = std::tuple;
using Promise = WTF::NativePromise;
explicit WaitForTarget(const WebCore::SeekTarget& target)
: m_arguments(target)
{
}
auto&& arguments()
{
return WTFMove(m_arguments);
}
private:
std::tuple m_arguments;
};
```
We need to introduce the concept of NativePromise::runSynchronouslyOnTarget
in order to ensure that processing of asynchronous results is kept in order
when mixing with the sendWithAsyncReply/CompletionHandler API.
Consider the following:
```
m_connectionToWebProcess->connection().sendWithPromisedReply(Messages::Message1,
m_identifier)
->whenSettled(RunLoop::main(), __func__, WTFMove(completionHandler1));
m_connectionToWebProcess->connection().sendWithAsyncReply(Messages::Message1,
WTFMove(completionHandler2), m_identifier);
```
In this example, it is expected that completionHandler1 is run before
completionHandler2 (in the same order the IPC results were received)
By default a NativePromise will always dispatch a task to run the resolve/reject
callback, and so in the example above completionHandler1 would be run after
completionHandler2 as sendWithAsyncReply immediately calls the
completionHandler.
By setting the NativePromise::Producer in RunSynchronouslyOnTarget mode,
it will immediately run the callback if already on the target thread.
Preserving the order of operations.
For the time being, RunSynchronouslyOnTarget is a response only to the
problem described above.
In the future we could imagine that it is up to the NativePromise consumer
to decide how the callbacks is to be run. But this is another problem for
another day.
API tests added for both IPC and NativePromise.
* Source/WTF/wtf/NativePromise.h:
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::sendWithPromisedReply):
(IPC::Connection::makeAsyncReplyHandler):
* Source/WebKit/Scripts/webkit/messages.py:
(message_to_struct_declaration):
(forward_declarations_and_headers):
* Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h:
* Source/WebKit/Scripts/webkit/tests/TestWithEnabledIfMessages.h:
* Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMe
[webkit-changes] [WebKit/WebKit] 42da7d: AX: AccessibilityObject::listMarkerTextForNodeAndP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42da7d77805d8e6dfa9eb5b35da5f603c6b41ff6 https://github.com/WebKit/WebKit/commit/42da7d77805d8e6dfa9eb5b35da5f603c6b41ff6 Author: Tyler Wilcock Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h Log Message: --- AX: AccessibilityObject::listMarkerTextForNodeAndPosition forces resolution of Position to VisiblePosition even when it's not used https://bugs.webkit.org/show_bug.cgi?id=261838 rdar://problem/115801743 Reviewed by Chris Fleizach. Converting a Position into a VisiblePosition can be very expensive, and listMarkerTextForNodeAndPosition was doing this when it was often not needed (because the given node is not a descendant of a list item). With this patch, we only do this work when in a list item. This saves ~10.1k samples of 84832 total main-thread samples in a popular web email client. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::listMarkerText): (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition): * Source/WebCore/accessibility/AccessibilityObject.h: Canonical link: https://commits.webkit.org/268239@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca2ac1: [WGSL] Add support for pointer types
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca2ac1200f9963da87fa7f437ef15c573464e04c https://github.com/WebKit/WebKit/commit/ca2ac1200f9963da87fa7f437ef15c573464e04c Author: Tadeu Zagallo Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WebGPU/WGSL/ConstantRewriter.cpp M Source/WebGPU/WGSL/Constraints.cpp M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeStore.cpp M Source/WebGPU/WGSL/TypeStore.h M Source/WebGPU/WGSL/Types.cpp M Source/WebGPU/WGSL/Types.h A Source/WebGPU/WGSL/tests/invalid/pointers.wgsl A Source/WebGPU/WGSL/tests/valid/pointers.wgsl Log Message: --- [WGSL] Add support for pointer types https://bugs.webkit.org/show_bug.cgi?id=261831 Reviewed by Dan Glastonbury. Add support for pointer types in the type system, which allows explicitly writing types of the form `ptr`. * Source/WebGPU/WGSL/ConstantRewriter.cpp: (WGSL::ConstantRewriter::materialize): * Source/WebGPU/WGSL/Constraints.cpp: (WGSL::satisfies): (WGSL::satisfyOrPromote): (WGSL::concretize): * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::bindingMemberForGlobal): (WGSL::RewriteGlobalVariables::usesOverride): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::emitPackedVector): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::TypeChecker): (WGSL::TypeChecker::allocateTextureStorageConstructor): (WGSL::TypeChecker::texelFormat): (WGSL::TypeChecker::accessMode): (WGSL::TypeChecker::addressSpace): * Source/WebGPU/WGSL/TypeStore.cpp: (WGSL::PointerKey::encode const): (WGSL::TypeStore::TypeStore): (WGSL::TypeStore::pointerType): * Source/WebGPU/WGSL/TypeStore.h: (WGSL::TypeStore::addressSpaceType const): * Source/WebGPU/WGSL/Types.cpp: (WGSL::Type::dump const): (WGSL::Type::size const): (WGSL::Type::alignment const): * Source/WebGPU/WGSL/Types.h: * Source/WebGPU/WGSL/tests/invalid/pointers.wgsl: Added. * Source/WebGPU/WGSL/tests/valid/pointers.wgsl: Added. Canonical link: https://commits.webkit.org/268238@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0a4e0: [WGSL] call to 'max' is ambiguous as decimal is no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0a4e0edfaa5e790d6d5c407e41110053958cc11 https://github.com/WebKit/WebKit/commit/e0a4e0edfaa5e790d6d5c407e41110053958cc11 Author: Mike Wyrzykowski Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WTF/wtf/dtoa.cpp M Source/WTF/wtf/dtoa.h M Source/WTF/wtf/dtoa/double-conversion.cc M Source/WTF/wtf/dtoa/double-conversion.h M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Tools/TestWebKitAPI/Tests/WGSL/MetalGenerationTests.cpp Log Message: --- [WGSL] call to 'max' is ambiguous as decimal is not added to floating point number https://bugs.webkit.org/show_bug.cgi?id=261854 Reviewed by Tadeu Zagallo. Make sure doubles contain a decimal point. Otherwise we will end up with compiler errors due to ambiguous function overloads like max(d, 0) where d is a double. * Source/WTF/wtf/dtoa.cpp: (WTF::numberToString): (WTF::numberToStringWithTrailingPoint): * Source/WTF/wtf/dtoa.h: * Source/WTF/wtf/dtoa/double-conversion.cc: * Source/WTF/wtf/dtoa/double-conversion.h: * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::visit): * Tools/TestWebKitAPI/Tests/WGSL/MetalGenerationTests.cpp: (TestWGSLAPI::TEST): Update test expectation Canonical link: https://commits.webkit.org/268237@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
