[webkit-changes] [WebKit/WebKit] 6f5dfe: Add operator bool() to NativePromiseRequest object

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f5dfe93bc251467650d446e7293613e576e4079
  
https://github.com/WebKit/WebKit/commit/6f5dfe93bc251467650d446e7293613e576e4079
  Author: Jean-Yves Avenard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WTF/wtf/NativePromise.h
M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp

  Log Message:
  ---
  Add operator bool() to NativePromiseRequest object
https://bugs.webkit.org/show_bug.cgi?id=262229
rdar://116150545

Reviewed by Dan Glastonbury.

The pattern:
```
if (m_request)
m_request.disconnect();
```

is a common idiom in the destructor of a class using a NativePromiseRequest.

Amend API test.

* Source/WTF/wtf/NativePromise.h:
* Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/268562@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eadc88: Avoid File::Find during IDL generation

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eadc88e2217f19653e8c73db5ac16c3939fce399
  
https://github.com/WebKit/WebKit/commit/eadc88e2217f19653e8c73db5ac16c3939fce399
  Author: Elliott Williams 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources.make
M Source/WebCore/WebCoreMacros.cmake
M Source/WebCore/bindings/scripts/CodeGenerator.pm
M Source/WebCore/bindings/scripts/generate-bindings-all.pl
M Source/WebCore/bindings/scripts/generate-bindings.pl
M Source/WebCore/testing/Internals.idl
M Tools/DumpRenderTree/DerivedSources-output.xcfilelist
M Tools/DumpRenderTree/DerivedSources.make
M Tools/Scripts/webkitpy/bindings/main.py
M Tools/TestRunnerShared/CMakeLists.txt
M Tools/WebKitTestRunner/CMakeLists.txt
M Tools/WebKitTestRunner/DerivedSources-output.xcfilelist
M Tools/WebKitTestRunner/DerivedSources.make

  Log Message:
  ---
  Avoid File::Find during IDL generation
https://bugs.webkit.org/show_bug.cgi?id=261364
rdar://99146531

Reviewed by Alexey Proskuryakov.

Replace the include mechanism of generate-bindings.pl, which was
performing a recursive directory search of WebCore on every invocation,
with a lookup based on a precomputed list of IDL names.

The Xcode-based build generates this list already, in
IDLFileNamesList.txt. The CMake build does not have an equivalent list,
because it invokes the generator in multiple batches (once for WebCore,
WebCoreTestSupport, etc.). Change it to generate a file based on the
IDLs it's generating plus any additional IDLs which must be looked up
but not generated.

On my M2 Max machine, this is a 21% speedup of WebCore's installhdrs
time, from

  Time (mean ± σ): 88.534 s ±  8.544 s[User: 6.732 s, System: 1.513 s]
  Range (min … max):   80.570 s … 100.172 s10 runs

to

  Time (mean ± σ): 73.320 s ± 10.335 s[User: 4.354 s, System: 1.363 s]
  Range (min … max):   66.565 s … 98.368 s10 runs

* Source/WebCore/CMakeLists.txt: MockWebAuthenticationConfiguration is
  imported but not generated; add it to WebCoreTestSupport.
* Source/WebCore/DerivedSources.make: Recognize and pass
  --idlFileNamesList instead of --include arguments.
* Source/WebCore/WebCoreMacros.cmake: Generate the IDL file names list.
* Source/WebCore/bindings/scripts/CodeGenerator.pm:
(new): Store path to IDL file names list.
(IDLFileForInterface): Read file names list instead of finding.
* Source/WebCore/bindings/scripts/generate-bindings-all.pl:
(buildDirectoryCache): Pass --idlFileNamesList argument.
* Source/WebCore/bindings/scripts/generate-bindings.pl:
(generateBindings): Ditto.
* Source/WebCore/testing/Internals.idl: Avoid having the IDL generator
  parse and look up attributes that require loading a bunch of
  additional IDLs. This prevents CMake builds from having to track all
  the Apple Pay IDLs in their WebCoreTestSupport, for instance.

* Tools/DumpRenderTree/DerivedSources-output.xcfilelist:
* Tools/DumpRenderTree/DerivedSources.make: Generate an
  IDLFileNamesList.txt and use it instead of includes.
* Tools/Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_from_idl):
(BindingsTests.generate_idl_file_names_list): Extracted logic, now
called twice: once to prepare a supplemental dependency file, once to
generate a list of all IDLs.
(BindingsTests):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.run_tests):
(BindingsTests.main):
* Tools/TestRunnerShared/CMakeLists.txt: Stop passing IDL_INCLUDES.
* Tools/WebKitTestRunner/CMakeLists.txt: Ditto.
* Tools/WebKitTestRunner/DerivedSources-output.xcfilelist:
* Tools/WebKitTestRunner/DerivedSources.make: Ditto DumpRenderTree
  changes.

Canonical link: https://commits.webkit.org/268561@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 50af8e: [Gardening]: REGRESSION(267579@main): [ Debug ] AS...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50af8e9215336b97ecb1222fc4712db4471427a2
  
https://github.com/WebKit/WebKit/commit/50af8e9215336b97ecb1222fc4712db4471427a2
  Author: Ben Schwartz 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm

  Log Message:
  ---
  [Gardening]: REGRESSION(267579@main): [ Debug ] ASSERTION FAILED: 
!m_pendingNavigationID causing 5 tests under TestWebKitAPI.WKBackForwardList to 
constantly timeout.
rdar://116090758
https://bugs.webkit.org/show_bug.cgi?id=262152

Unreviewed test gardening.

Re-enabling API tests disabled in https://commits.webkit.org/268489@main.

* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(TEST):

Canonical link: https://commits.webkit.org/268560@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9bad69: 'run-benchmark' should log Speedometer3 version

[dewei-zhu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bad69393c6280b5eb2d7e70023a1e51d6431f3d
  
https://github.com/WebKit/WebKit/commit/9bad69393c6280b5eb2d7e70023a1e51d6431f3d
  Author: Dewei Zhu 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py
M Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer3.plan

  Log Message:
  ---
  'run-benchmark' should log Speedometer3 version
https://bugs.webkit.org/show_bug.cgi?id=262234
rdar://116153728

Reviewed by Ryosuke Niwa.

Add 'git_repository' support to plan file and it's intended for the benchmark 
that has its
own repository like Speedometer3.

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Added support 
to checkout
a git repository specified by 'git_repository'.
(BenchmarkBuilder.__enter__):
(BenchmarkBuilder._clone_git_repository):
(BenchmarkBuilder._apply_patch): Updated code to avoid manually invoking 
os.chdir
* Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer3.plan: Updated 
plan file
to use 'git_repository'.

Canonical link: https://commits.webkit.org/268559@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b08052: Remove RefPtr::releaseConstNonNull

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b08052889f6e17a4ec33cbe934dbecdc1db4baf5
  
https://github.com/WebKit/WebKit/commit/b08052889f6e17a4ec33cbe934dbecdc1db4baf5
  Author: Ryan Reno 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WTF/wtf/RefPtr.h
M Tools/TestWebKitAPI/Tests/WTF/RefLogger.cpp
M Tools/TestWebKitAPI/Tests/WTF/RefLogger.h
M Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

  Log Message:
  ---
  Remove RefPtr::releaseConstNonNull
https://bugs.webkit.org/show_bug.cgi?id=262226
rdar://116146895

Reviewed by Dan Glastonbury.

There are no users of releaseConstNonNull anymore. We can use Ref's
templated move constructor to move from releaseNonNull's Ref to a
Ref which is the current pattern used by clients.

Adds a test to verify Ref can be constructed from
RefPtr::releaseNonNull.

* Source/WTF/wtf/RefPtr.h:
(WTF::RefPtr::releaseNonNull):
(WTF::RefPtr::releaseConstNonNull): Deleted.
* Tools/TestWebKitAPI/Tests/WTF/RefLogger.cpp:
(TestWebKitAPI::RefLogger::ref const):
(TestWebKitAPI::RefLogger::deref const):
(TestWebKitAPI::RefLogger::ref): Deleted.
(TestWebKitAPI::RefLogger::deref): Deleted.
* Tools/TestWebKitAPI/Tests/WTF/RefLogger.h:
* Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/268558@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 506097: Web Inspector: Sources: Sort resources without the...

[Jon Davis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5060974c125e844e2b23d23d10e895661cfdd002
  
https://github.com/WebKit/WebKit/commit/5060974c125e844e2b23d23d10e895661cfdd002
  Author: Jonathan Davis 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js

  Log Message:
  ---
  Web Inspector: Sources: Sort resources without the file extension first
https://bugs.webkit.org/show_bug.cgi?id=220437
rdar://72905353

Reviewed by Patrick Angle.

Sorting without the file extension first avoids comparing the dot (.) to
longer filenames with the same root string.
(e.g. styles.css and styles-dark.css)

* Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js:
(WI.ResourceTreeElement.compareResourceTreeElements.filenameWithoutExtention):
(WI.ResourceTreeElement.compareResourceTreeElements):

Canonical link: https://commits.webkit.org/268557@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c095d3: Store fewer raw pointers in containers in Source/W...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c095d300811b451846fb81f29255b82d4f76b938
  
https://github.com/WebKit/WebKit/commit/c095d300811b451846fb81f29255b82d4f76b938
  Author: Chris Dumez 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WTF/wtf/CheckedPtr.h
M Source/WTF/wtf/CheckedRef.h
M Source/WebCore/history/HistoryItem.h
M Source/WebKitLegacy/Storage/StorageNamespaceImpl.cpp
M Source/WebKitLegacy/Storage/StorageNamespaceImpl.h
M Source/WebKitLegacy/Storage/StorageThread.cpp
M Source/WebKitLegacy/Storage/StorageThread.h
M Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.cpp
M Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.h
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h
M Source/WebKitLegacy/mac/History/BackForwardList.h
M Source/WebKitLegacy/mac/History/WebBackForwardList.mm
M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm
M Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm

  Log Message:
  ---
  Store fewer raw pointers in containers in Source/WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=262188

Reviewed by Ryosuke Niwa.

* Source/WebCore/history/HistoryItem.h:
* Source/WebKitLegacy/Storage/StorageNamespaceImpl.cpp:
(WebKit::localStorageNamespaceMap):
(): Deleted.
* Source/WebKitLegacy/Storage/StorageNamespaceImpl.h:
* Source/WebKitLegacy/Storage/StorageThread.cpp:
(WebCore::activeStorageThreads):
(WebCore::StorageThread::start):
(WebCore::StorageThread::terminate):
(): Deleted.
* Source/WebKitLegacy/Storage/StorageThread.h:
* Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::storageNamespaceProviders):
(WebKit::WebStorageNamespaceProvider::WebStorageNamespaceProvider):
(WebKit::WebStorageNamespaceProvider::~WebStorageNamespaceProvider):
(WebKit::WebStorageNamespaceProvider::closeLocalStorage):
(WebKit::WebStorageNamespaceProvider::clearLocalStorageForAllOrigins):
(WebKit::WebStorageNamespaceProvider::clearLocalStorageForOrigin):
(WebKit::WebStorageNamespaceProvider::closeIdleLocalStorageDatabases):
(WebKit::WebStorageNamespaceProvider::syncLocalStorage):
(): Deleted.
* Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.h:
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::hostForURL):
(WebResourceLoadScheduler::scheduleLoad):
(WebResourceLoadScheduler::remove):
(WebResourceLoadScheduler::crossOriginRedirectReceived):
(WebResourceLoadScheduler::servePendingRequests):
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.h:
* Source/WebKitLegacy/mac/History/BackForwardList.h:
* Source/WebKitLegacy/mac/History/WebBackForwardList.mm:
(kit):
(-[WebBackForwardList initWithBackForwardList:]):
(-[WebBackForwardList dealloc]):
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm:
(-[WebHistoryItem dealloc]):
(-[WebHistoryItem copyWithZone:]):
(core):
(kit):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm:
(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::removeAllVisitedLinks):
* Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm:
(-[WebScriptWorld initWithWorld:]):
(-[WebScriptWorld dealloc]):
(+[WebScriptWorld findOrCreateWorld:]):

Canonical link: https://commits.webkit.org/268556@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec52f0: [JSC][armv7] Small fixes for DataIC address comput...

[jjgriego]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec52f0d00cbd1a7387bcd768bcd9377b8f454a33
  
https://github.com/WebKit/WebKit/commit/ec52f0d00cbd1a7387bcd768bcd9377b8f454a33
  Author: Joseph Griego 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp

  Log Message:
  ---
  [JSC][armv7] Small fixes for DataIC address computations
https://bugs.webkit.org/show_bug.cgi?id=262132

Reviewed by Yusuke Suzuki.

Fixes a great deal of the test suite.

`push {r7, lr}` uses 4 bytes, so the prologue size needs to be 6 and not 4.

Also, CodePtr::untaggedPtr produces a pointer suitable for jmp/call targets,
which for thumb code is off by 1--use `dataLocation()` instead for doing pointer
arithmetic--this change should affect nothing on other architectures.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::regenerate):

Canonical link: https://commits.webkit.org/268555@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] acb83c: REGRESSION(268551@main): Restore rendering/svg/leg...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acb83c08ddc28ae3f0e279b68f6a33801480
  
https://github.com/WebKit/WebKit/commit/acb83c08ddc28ae3f0e279b68f6a33801480
  Author: Fujii Hironori 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A 
Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h

  Log Message:
  ---
  REGRESSION(268551@main): Restore 
rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h
https://bugs.webkit.org/show_bug.cgi?id=262227

Unreviewed build fix.

* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h: 
Added.

Canonical link: https://commits.webkit.org/268554@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4c523: [JSC] Implement Annex B block-level function hoist...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4c5231dbae7cb9180fc5c02f8438bcce3f2cd52
  
https://github.com/WebKit/WebKit/commit/a4c5231dbae7cb9180fc5c02f8438bcce3f2cd52
  Author: Alexey Shvayka 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M JSTests/mozilla/ecma_3/Function/scope-001.js
M JSTests/mozilla/js1_5/Scope/regress-184107.js
M JSTests/mozilla/mozilla-tests.yaml
M 
JSTests/stress/can-declare-global-function-invoked-before-any-func-decl-is-hoisted-eval.js
A 
JSTests/stress/can-declare-global-function-invoked-before-any-func-decl-is-hoisted-global.js
M 
JSTests/stress/can-declare-global-var-invoked-before-any-func-decl-is-hoisted-eval.js
A 
JSTests/stress/can-declare-global-var-invoked-before-any-func-decl-is-hoisted-global.js
M 
JSTests/stress/can-declare-global-var-invoked-during-func-decl-hoisting-eval.js
A 
JSTests/stress/can-declare-global-var-invoked-during-func-decl-hoisting-global.js
A JSTests/stress/sloppy-mode-function-hoisting-global-code-2.js
A JSTests/stress/sloppy-mode-function-hoisting-global-code.js
M JSTests/stress/sloppy-mode-function-hoisting.js
M JSTests/test262/expectations.yaml
M LayoutTests/accessibility/insert-children-assert.html
M 
LayoutTests/fast/dom/MutationObserver/disconnect-observer-while-mutation-records-are-enqueued-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints.tentative-expected.txt
M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
M Source/JavaScriptCore/parser/Parser.cpp
M Source/JavaScriptCore/parser/Parser.h
M Source/JavaScriptCore/runtime/ProgramExecutable.cpp

  Log Message:
  ---
  [JSC] Implement Annex B block-level function hoisting for global scope
https://bugs.webkit.org/show_bug.cgi?id=163209


Reviewed by Yusuke Suzuki.

This change expands existing (and recently revamped) block-level function 
hoisting infrastructure
to global scope code, removing the extremely troublesome hack that used to 
unconditionally set the
scope of a block-level function declaration in global code to the top-level 
`var` scope instead of
lexical, which caused plenty of bug reports.

GlobalDeclarationInstantiation [1] implementation was tweaked to properly 
handle all the "phantom"
isSloppyModeHoistedFunction() variables, which are used merely to compute used 
/ captured variables,
and not treat them like `var`s to avoid throwing spec-noncompliant errors.

Since there is no way to account for lexical declarations from another 

[webkit-changes] [WebKit/WebKit] a13dcf: [PointerEvents] pressure property is not spec-comp...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a13dcf305bd1d474c02191d1e4c3c9a517bb6603
  
https://github.com/WebKit/WebKit/commit/a13dcf305bd1d474c02191d1e4c3c9a517bb6603
  Author: Abrar Rahman Protyasha 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers_mouse-expected.txt
M Source/WebCore/dom/PointerEvent.cpp
M Source/WebCore/dom/PointerEvent.h
M Source/WebKit/Shared/WebEventConversion.cpp
M Tools/DumpRenderTree/mac/EventSendingController.mm
M Tools/WebKitTestRunner/mac/EventSenderProxy.mm

  Log Message:
  ---
  [PointerEvents] pressure property is not spec-compliant when constructed from 
mouse event
https://bugs.webkit.org/show_bug.cgi?id=262159
rdar://116094696

Reviewed by Tim Nguyen.

Every PointerEvent object created from a backing MouseEvent object in
PointerCaptureController has an incorrect pressure value, namely 0. This
is the result of the coming together of a few issues:

1. We simply don't consult MouseEvent.force to initialize
   PointerEvent.pressure when creating a PointerEvent object from a
   backing MouseEvent. This is not the case when constructing from a
   PlatformTouchEvent, where we do correctly consult the force at given
   touch indices.
2. When creating a PointerEvent in a pressure insensitive context, we
   default to initializing the pressure property as zero, which is not
   compliant with the PointerEvents spec.
3. We don't populate the pressure attribute of NSEvent instances sent by
   EventSenderProxy, so even if we had consulted MouseEvent.force in
   the first issue, we would still be getting the wrong pressure values.

To address these issues, we define a helper static method
`PointerEvent::pressureForPressureInsensitiveInputDevices` that returns
the pressure value defined in the PointerEvents spec, conditioned on the
button currently being pressed. This method is then called if we are in
a pressure insensitive context (i.e. we're generating a PointerEvent
with Mouse pointer type, rather than Pen/Touch). However, if we're in a
pressure sensitive context, we simply consult the pressure attribute of
the backing event. Finally, to close the loop and plumb pressure values
from WKTR to generated pointer events, we make sure to supply the
appropriate pressure argument to NSEvent initializers for mouseDown
events.

This patch allows us to pass the following pressure-related assertion in
the pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse WPT.

```
FAIL mouse pointerdown.pressure value is valid assert_greater_than: pressure is 
greater than 0 with a button pressed expected a number greater than 0 but got 0
```

* 
LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers_mouse-expected.txt:

Update test expectations with newly passing assertion.

* Source/WebCore/dom/PointerEvent.cpp:
* Source/WebCore/dom/PointerEvent.h:
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
* Tools/DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseDown:withModifiers:]):
(-[EventSendingController contextClick]):
* Tools/WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):

Canonical link: https://commits.webkit.org/268552@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 200efb: Revert: (268472@main) because of the test breakages

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 200efb15d9bd2583532ad9e5345c5949480696d8
  
https://github.com/WebKit/WebKit/commit/200efb15d9bd2583532ad9e5345c5949480696d8
  Author: Karl Rackler 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
R 
Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h
M Tools/DumpRenderTree/mac/DumpRenderTree.mm
M Tools/DumpRenderTree/mac/ResourceLoadDelegate.h
M Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h

  Log Message:
  ---
  Revert: (268472@main) because of the test breakages
https://bugs.webkit.org/show_bug.cgi?id=262227
rdar://116147472

Unreviewed.

Reverting 268472@main because it caused test breakages.

* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h: 
Removed.
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(runTest):
* Tools/DumpRenderTree/mac/ResourceLoadDelegate.h:
* Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate 
webView:resource:didFailLoadingWithError:fromDataSource:]):
(-[ResourceLoadDelegate dealloc]): Deleted.
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPlatformWebView):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::createTestURL):
(WTR::TestController::runTest):
(WTR::pathSuitableForTestResult):
(WTR::TestController::didFailProvisionalNavigation): Deleted.
* Tools/WebKitTestRunner/TestController.h:

Canonical link: https://commits.webkit.org/268551@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 49f518: [CSS Fonts] The `from-font` value for CSS `font-si...

[ChangSeok Oh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 49f5188b5e8285f7c3b97cd7161b517ff0bd2886
  
https://github.com/WebKit/WebKit/commit/49f5188b5e8285f7c3b97cd7161b517ff0bd2886
  Author: ChangSeok Oh 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/platform/graphics/FontCascadeCache.h
M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
M Source/WebCore/platform/graphics/FontSizeAdjust.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleFontSizeFunctions.cpp
M Source/WebCore/style/StyleFontSizeFunctions.h

  Log Message:
  ---
  [CSS Fonts] The `from-font` value for CSS `font-size-adjust` is not computed 
correctly
https://bugs.webkit.org/show_bug.cgi?id=259551

Reviewed by Myles C. Maxfield.

When resolving styles, we used the parent-style font to compute the aspect ratio
for font-size-adjust: from-font because the first available font could not be
determined at that moment. Unfortunately, this causes the failure of
font-size-adjust-014.html. To make the test happy, we should defer resolving
the aspect value after determining a primary font. Also, FontDescriptionKey
should consider if the font-size-adjust has from-font, not simply checking if
it has a valid value when looking up a proper FontCascadeFonts.

* LayoutTests/TestExpectations:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontSizeAdjustFromStyle):
* Source/WebCore/platform/graphics/FontCascadeCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForCharacter):
* Source/WebCore/platform/graphics/FontSizeAdjust.h:
(WebCore::FontSizeAdjust::operator bool const):
(WebCore::FontSizeAdjust::resolve const):
(WebCore::add):
(WebCore::operator<<):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertFontSizeAdjust):
* Source/WebCore/style/StyleFontSizeFunctions.cpp:
(WebCore::Style::aspectValueOfPrimaryFont): Deleted.
* Source/WebCore/style/StyleFontSizeFunctions.h:

Canonical link: https://commits.webkit.org/268550@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e62b4: [Gardening]: REGRESSION(268472@main): 5 tests unde...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e62b48125358b04646168837459cc7e0e279203
  
https://github.com/WebKit/WebKit/commit/2e62b48125358b04646168837459cc7e0e279203
  Author: Ben Schwartz 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(268472@main): 5 tests under 
http/tests/contentextensions/ are consistently failing.
rdar://116143665
https://bugs.webkit.org/show_bug.cgi?id=262216

Unreviewed test gardening.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/268549@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b05ce: Use more smart pointers in editing code

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b05ce368eccb0c5c42dbdeb17e541e6418fbef8
  
https://github.com/WebKit/WebKit/commit/3b05ce368eccb0c5c42dbdeb17e541e6418fbef8
  Author: Chris Dumez 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/dom/Position.cpp
M Source/WebCore/dom/Position.h
M Source/WebCore/editing/AlternativeTextController.cpp
M Source/WebCore/editing/AlternativeTextController.h
M Source/WebCore/editing/AppendNodeCommand.cpp
M Source/WebCore/editing/AppendNodeCommand.h
M Source/WebCore/editing/ApplyBlockElementCommand.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/BreakBlockquoteCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.h
M Source/WebCore/editing/CreateLinkCommand.cpp
M Source/WebCore/editing/CustomUndoStep.cpp
M Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
M Source/WebCore/editing/DeleteFromTextNodeCommand.h
M Source/WebCore/editing/DeleteSelectionCommand.cpp
M Source/WebCore/editing/DeleteSelectionCommand.h
M Source/WebCore/editing/DictationCommand.cpp
M Source/WebCore/editing/DictationCommand.h
M Source/WebCore/editing/EditCommand.cpp
M Source/WebCore/editing/EditCommand.h
M Source/WebCore/editing/Editing.cpp
M Source/WebCore/editing/Editing.h
M Source/WebCore/editing/InsertListCommand.cpp
M Source/WebCore/editing/InsertListCommand.h
M Source/WebCore/editing/TypingCommand.cpp
M Source/WebCore/editing/VisibleSelection.cpp
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebCore/page/DragController.cpp
M Source/WebCore/page/EditorClient.h

  Log Message:
  ---
  Use more smart pointers in editing code
https://bugs.webkit.org/show_bug.cgi?id=262200

Reviewed by Brent Fulgham.

* Source/WebCore/dom/Position.cpp:
(WebCore::Position::protectedContainerText const):
* Source/WebCore/dom/Position.h:
* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::startAlternativeTextUITimer):
(WebCore::AlternativeTextController::stopPendingCorrection):
(WebCore::AlternativeTextController::isSpellingMarkerAllowed const):
(WebCore::AlternativeTextController::show):
(WebCore::AlternativeTextController::dismiss):
(WebCore::AlternativeTextController::dismissSoon):
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::handleAlternativeTextUIResult):
(WebCore::AlternativeTextController::canEnableAutomaticSpellingCorrection 
const):
(WebCore::AlternativeTextController::rootViewRectForRange const):
(WebCore::AlternativeTextController::respondToChangedSelection):
(WebCore::AlternativeTextController::editorClient):
(WebCore::AlternativeTextController::textChecker):
(WebCore::AlternativeTextController::recordAutocorrectionResponse):
(WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::alternativeTextClient):
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
(WebCore::AlternativeTextController::removeCorrectionIndicatorMarkers):
(WebCore::AlternativeTextController::insertDictatedText):
(WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
(WebCore::AlternativeTextController::dictationAlternativesForMarker):
(WebCore::AlternativeTextController::applyDictationAlternative):
* Source/WebCore/editing/AlternativeTextController.h:
(WebCore::AlternativeTextController::protectedDocument const):
* Source/WebCore/editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
* Source/WebCore/editing/AppendNodeCommand.h:
(WebCore::AppendNodeCommand::protectedParent const):
(WebCore::AppendNodeCommand::protectedNode const):
* Source/WebCore/editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
(WebCore::ApplyBlockElementCommand::formatSelection):
(WebCore::isNewLineAtPosition):
(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):
(WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded):
(WebCore::ApplyBlockElementCommand::endOfNextParagraphSplittingTextNodesIfNeeded):
(WebCore::ApplyBlockElementCommand::createBlockElement):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

[webkit-changes] [WebKit/WebKit] 3a3311: `generate-bundle` fails at installing `toml`

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a33119682b78d6fed5d8f6cffaf23a25aad2bda
  
https://github.com/WebKit/WebKit/commit/3a33119682b78d6fed5d8f6cffaf23a25aad2bda
  Author: Vitaly Dyachkov 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  ---
  `generate-bundle` fails at installing `toml`
https://bugs.webkit.org/show_bug.cgi?id=262184

Reviewed by Jonathan Bedard.

After `268269@main` `pyparsing` must be specified as a implicit
dependency of `toml`.

* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/268547@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c84297: [commits.webkit.org] Throttle repository sync on boot

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8429741370d12fd83f6abba27442d2a7269914e
  
https://github.com/WebKit/WebKit/commit/c8429741370d12fd83f6abba27442d2a7269914e
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
M Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py
M Tools/Scripts/libraries/reporelaypy/setup.py

  Log Message:
  ---
  [commits.webkit.org] Throttle repository sync on boot
https://bugs.webkit.org/show_bug.cgi?id=262221
rdar://116145049

Reviewed by Dewei Zhu.

Syncing the checkout in commits.webkit.org can be a CPU intensive
task. Allow the caller of Checkout.update_all to throttle it's own
call so that we leave CPU cycles available to respond to requests.

* Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:
(Checkout.update_all): Add option to throttle checkout update.

Canonical link: https://commits.webkit.org/268546@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 824b10: _WKHitTestResult should expose an elementType prop...

[Jeff Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 824b10f0e852a126afc79ec2093271a5eca869b6
  
https://github.com/WebKit/WebKit/commit/824b10f0e852a126afc79ec2093271a5eca869b6
  Author: Jeff Miller 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/rendering/HitTestResult.cpp
M Source/WebCore/rendering/HitTestResult.h
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h
M Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/Shared/WebHitTestResultData.serialization.in
M Source/WebKit/UIProcess/API/APIHitTestResult.h
M Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm

  Log Message:
  ---
  _WKHitTestResult should expose an elementType property
https://bugs.webkit.org/show_bug.cgi?id=262137
rdar://116078370

Reviewed by Aditya Keerthi and Wenson Hsieh.

Add a elementType property to _WKHitTestResult and plumbing to 
WebCore::HitTestResult and
WebKit::WebHitTestResultData to support it.

* Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::hasMediaElement const):
* Source/WebCore/rendering/HitTestResult.h:
Added hasMediaElement().
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
Added _WKHitTestResultElementType and elementType property.
* Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.mm:
(-[_WKHitTestResult elementType]):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::elementTypeFromHitTestResult):
Added, derives WebHitTestResultData::ElementType from WebCore::HitTestResult.
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
Add allowed values for WebHitTestResultData::ElementType and add elementType to 
WebHitTestResultData.
* Source/WebKit/UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::elementType const):
* Tools/TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Added HitTestResultElementTypeNone and HitTestResultElementTypeVideo tests to 
verify elementType
property is set correctly on _WKHitTestResult.

Canonical link: https://commits.webkit.org/268545@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b6ffb: Fix build issue

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b6ffb3ba3c6614fb40d71e1df10859d4fa3cc8c
  
https://github.com/WebKit/WebKit/commit/9b6ffb3ba3c6614fb40d71e1df10859d4fa3cc8c
  Author: Per Arne Vollan 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebKit/Configurations/GPUExtension.xcconfig
M Source/WebKit/Configurations/NetworkingExtension.xcconfig
M Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig
M Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig
M Source/WebKit/Configurations/WebContentExtension.xcconfig
M Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingExtension-Info.plist
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist

  Log Message:
  ---
  Fix build issue
https://bugs.webkit.org/show_bug.cgi?id=262217
rdar://116140701

Reviewed by Brent Fulgham.

Fix build issue related to WebKit extensions. Add required items to Info.plist.

* Source/WebKit/Configurations/GPUExtension.xcconfig:
* Source/WebKit/Configurations/NetworkingExtension.xcconfig:
* Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig:
* Source/WebKit/Configurations/WebContentCrashyExtension.xcconfig:
* Source/WebKit/Configurations/WebContentExtension.xcconfig:
* Source/WebKit/Shared/AuxiliaryProcessExtensions/GPUExtension-Info.plist:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingExtension-Info.plist:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-CaptivePortal-Info.plist:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Crashy-Info.plist:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/WebContentExtension-Info.plist:

Canonical link: https://commits.webkit.org/268544@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73e0d4: Create a combined GTK/WPE PlatformEnablement file

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73e0d4c74d1baaeb169b9bbc3f1adcfe71579bcc
  
https://github.com/WebKit/WebKit/commit/73e0d4c74d1baaeb169b9bbc3f1adcfe71579bcc
  Author: Brent Fulgham 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
A Source/WTF/wtf/PlatformEnableGlib.h
M Source/WTF/wtf/PlatformEnablePlayStation.h
M Source/WTF/wtf/PlatformEnableWinCairo.h
M Source/WebCore/platform/PlatformWheelEvent.h

  Log Message:
  ---
  Create a combined GTK/WPE PlatformEnablement file
https://bugs.webkit.org/show_bug.cgi?id=261960


Reviewed by Chris Dumez.

PlatformEnable.h is meant to hold the default state of compile-time feature 
enablement
flag. Specific platform-related files are meant to override these values.

No PlatformEnableGTK or PlatformEnableWPE file was ever created, leading to 
conditional
macros being added to the default file.

This patch moves the GTK and WPE-specific rules to their own file, to match 
other platforms.
It also corrects the alphabetical ordering of the files.

* Source/WTF/wtf/CMakeFiles.txt: Add new header file.
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformEnableGlib.h: Added.
* Source/WTF/wtf/PlatformEnablePlayStation.h:
* Source/WTF/wtf/PlatformEnableWinCairo.h:
* Source/WebCore/platform/PlatformWheelEvent.h: Correct the enum definition for 
the
case where KINETIC_SCROLLING has been enabled, but ASYNC_SCROLLING is not.

Canonical link: https://commits.webkit.org/268543@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d79fb: [webkitcorepy] Packaging requires pyparsing (Follo...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d79fbb31dcdab05bc29ead7c6a8d221056ea918
  
https://github.com/WebKit/WebKit/commit/7d79fbb31dcdab05bc29ead7c6a8d221056ea918
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  [webkitcorepy] Packaging requires pyparsing (Follow-up to 268523@main)
https://bugs.webkit.org/show_bug.cgi?id=262124
rdar://116062896

Reviewed by Elliott Williams.

Landed incorrect version of this change in 268523@main (5bae443a6845),
land the correctly reviewed version.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Install base libraries from a list instead naming them 
explicitly.
(AutoInstall): Centralize all libraries required by setup.py in a single list,
add pyparsing to that list.

Canonical link: https://commits.webkit.org/268542@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6ffab: Remove RenderBlockFlow::lineGridBox()

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6ffab2867fbf954b0a9c4b3f30b3354120b81af
  
https://github.com/WebKit/WebKit/commit/f6ffab2867fbf954b0a9c4b3f30b3354120b81af
  Author: Antti Koivisto 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderLayoutState.cpp

  Log Message:
  ---
  Remove RenderBlockFlow::lineGridBox()
https://bugs.webkit.org/show_bug.cgi?id=262197
rdar://116128479

Reviewed by Alan Baradlay.

We construct and maintain this LegacyRootInlineBox for the sole purpose of 
computing
some metrics for the line grid feature. We can just compute those things 
directly.

* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutLineBoxes):
* Source/WebCore/rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutLineGridBox): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::lineGridBox const): Deleted.
(WebCore::RenderBlockFlow::setLineGridBox): Deleted.
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::RenderLayoutState::computeLineGridPaginationOrigin):

Canonical link: https://commits.webkit.org/268541@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0564f1: [Gardening]: REGRESSION(267516@main): [ macOS ] 25...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0564f1d21bab8511b26a270358751fe956d7146f
  
https://github.com/WebKit/WebKit/commit/0564f1d21bab8511b26a270358751fe956d7146f
  Author: Ben Schwartz 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/mac-monterey-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION(267516@main): [ macOS ] 25 tests are constant 
failures following Sonoma OpenSource expectations migration.
rdar://115146287
https://bugs.webkit.org/show_bug.cgi?id=261306

Unreviewed test gardening.

* LayoutTests/platform/mac-monterey-wk2/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/268540@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a0085: [commits.webkit.org] Disable crawling on commits.w...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a00858352adede8de2078313986469f9429c3ad
  
https://github.com/WebKit/WebKit/commit/8a00858352adede8de2078313986469f9429c3ad
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
M Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py
M Tools/Scripts/libraries/reporelaypy/setup.py

  Log Message:
  ---
  [commits.webkit.org] Disable crawling on commits.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=262213
rdar://116141929

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py:
(robots_txt): Return robots.txt.

Canonical link: https://commits.webkit.org/268539@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b42df3: [ GARDENING ] ([ Mac WK1 ] 2x fast/scrolling/mac/s...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b42df3daaf62e844b95688ce910c03129194b2fb
  
https://github.com/WebKit/WebKit/commit/b42df3daaf62e844b95688ce910c03129194b2fb
  Author: Dawn Flores 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [ GARDENING ] ([ Mac WK1 ] 2x fast/scrolling/mac/scrollbars/* (layout-tests) 
are constant failures (262214))
rdar://116142185
https://bugs.webkit.org/show_bug.cgi?id=262214

Unreviewed test gardening.

* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/268538@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b5fdf: [UnifiedPDF] Factor loading code into PDFPluginBase

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b5fdf2f4127b8104c6fe6ccb0b7ec6fff661b30
  
https://github.com/WebKit/WebKit/commit/7b5fdf2f4127b8104c6fe6ccb0b7ec6fff661b30
  Author: Simon Fraser 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Factor loading code into PDFPluginBase
https://bugs.webkit.org/show_bug.cgi?id=262163
rdar://116099771

Reviewed by Tim Horton.

Loading code is common to PDFPlugin and UnifiedPDFPlugin, so move it into the 
base class.
Virtual methods are added to handle incremental loading, which will be migrated 
in a future PR.

Also add stubs to create and install the PDF document.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel):
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::incrementalPDFStreamDidFinishLoading):
(WebKit::PDFPlugin::incrementalPDFStreamDidReceiveData):
(WebKit::PDFPlugin::incrementalPDFStreamDidFail):
(WebKit::PDFPlugin::createPDFDocument):
(WebKit::PDFPlugin::addArchiveResource): Deleted.
(WebKit::PDFPlugin::streamDidFinishLoading): Deleted.
(WebKit::PDFPlugin::streamDidReceiveResponse): Deleted.
(WebKit::PDFPlugin::ensureDataBufferLength): Deleted.
(WebKit::PDFPlugin::streamDidReceiveData): Deleted.
(WebKit::PDFPlugin::streamDidFail): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::tryRunScriptsInPDFDocument):
(WebKit::PDFPluginBase::incrementalPDFStreamDidReceiveData):
(WebKit::PDFPluginBase::incrementalPDFStreamDidFinishLoading):
(WebKit::PDFPluginBase::incrementalPDFStreamDidFail):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::ensureDataBufferLength):
(WebKit::PDFPluginBase::streamDidReceiveResponse):
(WebKit::PDFPluginBase::streamDidReceiveData):
(WebKit::PDFPluginBase::streamDidFinishLoading):
(WebKit::PDFPluginBase::streamDidFail):
(WebKit::PDFPluginBase::addArchiveResource):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createPDFDocument):
(WebKit::UnifiedPDFPlugin::installPDFDocument):
(WebKit::UnifiedPDFPlugin::scaleFactor const):
(WebKit::UnifiedPDFPlugin::pdfDocumentForPrinting const):
(WebKit::UnifiedPDFPlugin::pdfDocumentSizeForPrinting const):
(WebKit::UnifiedPDFPlugin::streamDidReceiveResponse): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidReceiveData): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidFinishLoading): Deleted.
(WebKit::UnifiedPDFPlugin::streamDidFail): Deleted.

Canonical link: https://commits.webkit.org/268537@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f90c4a: [git-webkit] Support publication without a novel b...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f90c4a57393ff144f8ecc896a14c0382fb64ea24
  
https://github.com/WebKit/WebKit/commit/f90c4a57393ff144f8ecc896a14c0382fb64ea24
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/setup.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py

  Log Message:
  ---
  [git-webkit] Support publication without a novel branch
https://bugs.webkit.org/show_bug.cgi?id=262155
rdar://116092404

Reviewed by Elliott Williams.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/publish.py:
(Publish.main): Skip pushing branches if no branches need to be published.

Canonical link: https://commits.webkit.org/268536@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c31f4e: link@rel=stylesheet: Don’t load if bad MIME type, ...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c31f4e6a298d56fd8fee979fbef060b001c7674e
  
https://github.com/WebKit/WebKit/commit/c31f4e6a298d56fd8fee979fbef060b001c7674e
  Author: Michael[tm] Smith 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type-empty.css
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type-empty.css.headers
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type.css
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type.css.headers
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type.html
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type-expected.txt
M Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp

  Log Message:
  ---
  link@rel=stylesheet: Don’t load if bad MIME type, even if resource is empty
https://bugs.webkit.org/show_bug.cgi?id=261811

Reviewed by Chris Dumez.

When a resource from a  element has a non-CSS MIME
type and is also empty (has no body/data), this change ensures that
WebKit fully conforms to the requirement in the HTML standard at
https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet
that no “load” event is fired at the element.

The change also ensures that a “Did not parse stylesheet… because non
CSS MIME types are not allowed in strict mode” error is logged to the
Web Inspector console.

Otherwise, without this change, WebKit fires a “load” event in this case —
and so, doesn’t conform to the relevant requirement in the HTML standard —
and also logs no error to the Web Inspector console.

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type-empty.css:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type-empty.css.headers:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type.css:
 Added.
(body):
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet-bad-mime-type.css.headers:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type.html:
 Added.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-bad-mime-type-expected.txt:
 Added.
Changed expectations to have http://web-platform.test:8800 URL in console 
message, rather than http://localhost:8800
* Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::sheetText const):

Canonical link: https://commits.webkit.org/268535@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe54e5: Unreviewed build fix for Windows port

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe54e50383ada7a7d90719370efbc755173448d8
  
https://github.com/WebKit/WebKit/commit/fe54e50383ada7a7d90719370efbc755173448d8
  Author: Fujii Hironori 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp

  Log Message:
  ---
  Unreviewed build fix for Windows port

clang-cl release builds couldn't compile.

> JavaScriptCore\inspector\remote\socket\win\RemoteInspectorSocketWin.cpp(100,104):
>  warning: unused parameter 'debug' [-Wunused-parameter]

* 
Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp:
(Inspector::Socket::setOpt): Use UNUSED_PARAM for it.

Canonical link: https://commits.webkit.org/268534@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6be845: [ REBASLINE ] ([ WK1 Monterey ] http/tests/appcach...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6be8452d06627bfc46dce081e1e404e03a5eaee3
  
https://github.com/WebKit/WebKit/commit/6be8452d06627bfc46dce081e1e404e03a5eaee3
  Author: Dawn Flores 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A 
LayoutTests/platform/mac-monterey-wk1/http/tests/appcache/remove-cache-expected.txt

  Log Message:
  ---
  [ REBASLINE ] ([ WK1 Monterey ] http/tests/appcache/remove-cache.html needs a 
rebasline (262204))
rdar://116136809
https://bugs.webkit.org/show_bug.cgi?id=262204

Unreviewed test gardening.

* 
LayoutTests/platform/mac-monterey-wk1/http/tests/appcache/remove-cache-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/268533@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e0231: [ REBASLINE ] ([ Mac ] http/tests/appcache/fail-on...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e023120f6be1d46ca0d688301b6009cdfccbbe4
  
https://github.com/WebKit/WebKit/commit/4e023120f6be1d46ca0d688301b6009cdfccbbe4
  Author: Dawn Flores 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A LayoutTests/platform/mac/http/tests/appcache/fail-on-update-2-expected.txt

  Log Message:
  ---
  [ REBASLINE ] ([ Mac ] http/tests/appcache/fail-on-update-2.html needs a 
rebasline (262210)).
rdar://116139561

Unreviewed test gardening.

* LayoutTests/platform/mac/http/tests/appcache/fail-on-update-2-expected.txt: 
Added.

Canonical link: https://commits.webkit.org/268532@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6bef92: Fix build after 268500@main for case-insensitive f...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6bef92cf112d35641e59053f35d99a580ec710ed
  
https://github.com/WebKit/WebKit/commit/6bef92cf112d35641e59053f35d99a580ec710ed
  Author: Myles C. Maxfield 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
R 
Source/WebCore/rendering/svg/Legacy/LegacyRenderSVGResourceClipperInlines.h

  Log Message:
  ---
  Fix build after 268500@main for case-insensitive file systems
https://bugs.webkit.org/show_bug.cgi?id=262209
rdar://116139041

Reviewed by Tim Horton.

% diff Legacy/LegacyRenderSVGResourceClipperInlines.h 
legacy/LegacyRenderSVGResourceClipperInlines.h
%

This patch just deletes the erroneous Legacy directory.

* Source/WebCore/rendering/svg/Legacy/LegacyRenderSVGResourceClipperInlines.h: 
Removed.

Canonical link: https://commits.webkit.org/268531@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 112961: Site isolation process groups should be shared bet...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1129619cf58a4dafe4c40528c4c7c321a78c7e5b
  
https://github.com/WebKit/WebKit/commit/1129619cf58a4dafe4c40528c4c7c321a78c7e5b
  Author: Alex Christensen 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebKit/Sources.txt
M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
M Source/WebKit/UIProcess/API/APIPageConfiguration.h
A Source/WebKit/UIProcess/BrowsingContextGroup.cpp
A Source/WebKit/UIProcess/BrowsingContextGroup.h
M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h
M Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  Site isolation process groups should be shared between opener and openee
https://bugs.webkit.org/show_bug.cgi?id=262194
rdar://116126764

Reviewed by Pascoe.

Introduce a new abstraction that will map to 
https://html.spec.whatwg.org/#browsing-context-group
from which I got the name.  This allows us to put site isolated frames and 
navigations in the right
process even after a window.open.

* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::PageConfiguration):
(API::PageConfiguration::browsingContextGroup):
* Source/WebKit/UIProcess/API/APIPageConfiguration.h:
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp: Copied from 
Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h.
(WebKit::BrowsingContextGroup::processForDomain):
(WebKit::BrowsingContextGroup::addProcessForDomain):
* Source/WebKit/UIProcess/BrowsingContextGroup.h: Copied from 
Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h.
(WebKit::BrowsingContextGroup::create):
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* Source/WebKit/UIProcess/HighPerformanceGraphicsUsageSampler.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::m_browsingContextGroup):
(WebKit::WebPageProxy::addRemotePageProxy):
(WebKit::WebPageProxy::processForRegistrableDomain):
(WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const):
(WebKit::m_limitsNavigationsToAppBoundDomains): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::siteIsolatedViewAndDelegate):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/268530@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e120ba: Web Automation: Dispatched mouse events always hav...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e120ba1e5646832a96d479a7d6a629a1e7d639f2
  
https://github.com/WebKit/WebKit/commit/e120ba1e5646832a96d479a7d6a629a1e7d639f2
  Author: Abrar Rahman Protyasha 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/dom/PointerEvent.cpp
M Source/WebCore/dom/PointerEvent.h
M Source/WebCore/dom/ios/PointerEventIOS.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm

  Log Message:
  ---
  Web Automation: Dispatched mouse events always have `buttons` property set to 
zero
https://bugs.webkit.org/show_bug.cgi?id=262109
rdar://116049187

Reviewed by Wenson Hsieh.

Pointer events dispatched by WebAutomationSession uncondtionally have
their `buttons` property set to zero. This is because the `buttons`
property is assigned by consulting the `+[NSEvent pressedMouseButtons]`
method, which does not account for NSEvent objects created through
eventSender in our test harness, and as such always reports that we have
not pressed any mouse buttons.

To fix this, we keep track of the mouse button currently being pressed
down in WebAutomationSession, and reflect that in a swizzled
`+[NSEvent pressedMouseButtons]` definition.

Note that with this patch we now pass the following assertion in the
pointerevents/pointerevent_attributes_hoverable_pointers.html?mouse WPT:

```
mouse pointerdown.buttons attribute is 1 when left mouse button is pressed.
```

* Source/WebCore/dom/PointerEvent.cpp:
(WebCore::PointerEvent::PointerEvent):
* Source/WebCore/dom/PointerEvent.h:
* Source/WebCore/dom/ios/PointerEventIOS.cpp:
(WebCore::buttonsForType): Deleted.
* Source/WebKit/UIProcess/Automation/WebAutomationSession.h:
* Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):

Canonical link: https://commits.webkit.org/268529@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec3ecb: Do not perform sync IPC on notifyAccessibilityForS...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec3ecbd54ef898ab69b4877849fde26efa04e6ff
  
https://github.com/WebKit/WebKit/commit/ec3ecbd54ef898ab69b4877849fde26efa04e6ff
  Author: Yusuke Suzuki 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/editing/mac/FrameSelectionMac.mm

  Log Message:
  ---
  Do not perform sync IPC on notifyAccessibilityForSelectionChange when 
accessibilityEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=262151
rdar://problem/116088957

Reviewed by Ryosuke Niwa.

When notifyAccessibilityForSelectionChange is called from 
FrameSelection::updateAndRevealSelection, we are not checking this condition.
So this is happening regardless. We should guard this condition inside the 
function as the same to what it is doing in iOS.

* Source/WebCore/editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

Canonical link: https://commits.webkit.org/268528@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b84967: [IFC][Ruby] Annotation content box should use ruby...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b84967cb2563a769f69a24ad5c0ad6b688512886
  
https://github.com/WebKit/WebKit/commit/b84967cb2563a769f69a24ad5c0ad6b688512886
  Author: Alan Baradlay 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp

  Log Message:
  ---
  [IFC][Ruby] Annotation content box should use ruby-align: space-around
https://bugs.webkit.org/show_bug.cgi?id=262203

Reviewed by Antti Koivisto.

Let's distribute the extra space using ruby-align: space-around for annotation 
box content (also see FIXME).

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::applyRunExpansion):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::isEligibleForSimplifiedTextOnlyInlineLayout):

Canonical link: https://commits.webkit.org/268527@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05c27a: REGRESSION (268069@main): Date picker fails to pre...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05c27ae25006e9c39e40a712ac4bdf28611e2884
  
https://github.com/WebKit/WebKit/commit/05c27ae25006e9c39e40a712ac4bdf28611e2884
  Author: Wenson Hsieh 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A 
LayoutTests/fast/forms/ios/change-focus-from-text-field-to-date-input-expected.txt
A LayoutTests/fast/forms/ios/change-focus-from-text-field-to-date-input.html
M Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.h
M Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm
M Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm

  Log Message:
  ---
  REGRESSION (268069@main): Date picker fails to present when switching focus 
from a text field to a date input
https://bugs.webkit.org/show_bug.cgi?id=262144

Reviewed by Tim Horton and Aditya Keerthi.

After refactoring date pickers to use popover presentation controllers in 
268069@main, it's now
possible for the UI process to hang when presenting a date picker in the case 
where there's
insufficient space to present the popover, and autolayout code in UIKit takes 
(seemingly) forever
attempting to resize individual cells in the date picker view to make the view 
fit.

Avoid this problem by teaching `WKDatePickerPopoverController` to only present 
the popover in
directions that contain sufficient space to lay out the popover contents 
correctly. Additionally,
stop using `_contentRectForUserInteraction` when computing available space; 
this didn't really make
sense, since it considers the input view as part of the obscured inset area, 
despite the fact that
the popover can animate over the keyboard. Instead, just map the `targetRect` 
to window coordinates,
and use the containing window's bounds to compute available space.

See below for more details.

* 
LayoutTests/fast/forms/ios/change-focus-from-text-field-to-date-input-expected.txt:
 Added.
* LayoutTests/fast/forms/ios/change-focus-from-text-field-to-date-input.html: 
Added.

Add a layout test to exercise the change.

* Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.h:
* Source/WebKit/UIProcess/ios/forms/WKDatePickerPopoverController.mm:
(-[WKDatePickerPopoverView initWithDatePicker:]):

Use `-sizeToFit` to size the accessory view and date picker, and save the 
combined size here so that
we can estimate how much available space we need in order to present this 
popover.

(-[WKDatePickerPopoverView estimatedMaximumPopoverSize]):

Return an estimate of the maximum size of the content view when it's presented 
in a popover. Note
that we add some extra height here to ensure that the accessory view toolbar 
doesn't end up getting
clipped.

(-[WKDatePickerPopoverController presentInView:sourceRect:completion:]):
(-[WKDatePickerPopoverController 
presentInView:sourceRect:interactionBounds:completion:]): Deleted.

Use the estimated popover size above to set `permittedArrowDirections` to only 
the directions where
the popover has enough space to fully present, without either:

1. Hanging under autolayout code, or
2. Clipping the accessory view.

If there is not enough space to show the popover in *any* direction, instead of 
falling back to
`UIPopoverArrowDirectionAny`, we fall back to `0` (no permitted arrow 
directions), and set the
target rect to the entire bounds of the window, mapped into root view 
coordinates. This allows us to
simply present the popover in the center of the window with no arrow, which 
avoids the two issues
above.

* Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker showDateTimePicker]):

Canonical link: https://commits.webkit.org/268526@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 77e646: [JSC][armv7] Fix DFG {NewSet, NewMap} assertions

[jjgriego]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77e6461ff053676f9d8ffa976a45bf1980728d0c
  
https://github.com/WebKit/WebKit/commit/77e6461ff053676f9d8ffa976a45bf1980728d0c
  Author: Joseph Griego 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

  Log Message:
  ---
  [JSC][armv7] Fix DFG {NewSet,NewMap} assertions
https://bugs.webkit.org/show_bug.cgi?id=262181

Reviewed by Yusuke Suzuki.

These asserts seem to be useful only for `CPU(ARM64)` and they're not true on
32-bit; rather than make them portable, sink them to where they're needed.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

Canonical link: https://commits.webkit.org/268525@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b7cdf: REGRESSION(268517@main): Fix broken image link on ...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b7cdf448d06b8ff2be31a001bcf1d60c05909af
  
https://github.com/WebKit/WebKit/commit/4b7cdf448d06b8ff2be31a001bcf1d60c05909af
  Author: Ben Schwartz 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
A Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS17.png
R Tools/CISupport/build-webkit-org/public_html/dashboard/Images/iOS17.png

  Log Message:
  ---
  REGRESSION(268517@main): Fix broken image link on build.webkit.org dashboard.
rdar://116012814
https://bugs.webkit.org/show_bug.cgi?id=262065

Unreviewed file rename.

Renamed iOS17.png -> IOS17.png to fix iOS 17's image display on 
https://build.webkit.org/dashboard.

* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS17.png: 
Renamed from 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/iOS17.png.

Canonical link: https://commits.webkit.org/268524@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5bae44: [webkitcorepy] Packaging requires pyparsing

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5bae443a6845513422489bcb842a677ca61a2e4f
  
https://github.com/WebKit/WebKit/commit/5bae443a6845513422489bcb842a677ca61a2e4f
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/setup.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  [webkitcorepy] Packaging requires pyparsing
https://bugs.webkit.org/show_bug.cgi?id=262124
rdar://116062896

Reviewed by Elliott Williams.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Install pyparsing before packaging.

Canonical link: https://commits.webkit.org/268523@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 044182: [commits.webkit.org] Ignore requests for invalid refs

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0441827bd96ffc097aaa85a6af664efedf153260
  
https://github.com/WebKit/WebKit/commit/0441827bd96ffc097aaa85a6af664efedf153260
  Author: Jonathan Bedard 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py
M Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py
M 
Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py
M Tools/Scripts/libraries/reporelaypy/setup.py

  Log Message:
  ---
  [commits.webkit.org] Ignore requests for invalid refs
https://bugs.webkit.org/show_bug.cgi?id=262164
rdar://116099852

Reviewed by Dewei Zhu.

Requests which contain strings not valid in a git ref can be
rejected before checking the cache or checkout.

* Tools/Scripts/libraries/reporelaypy/setup.py: Bump version.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/__init__.py: Ditto.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py:
(CheckoutRoute): Add regex for valid refs.
(CheckoutRoute.commit): Ignore requests for invalid refs.
* 
Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:
(CheckoutRouteUnittest.test_json_invalid):

Canonical link: https://commits.webkit.org/268522@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf4b2d: [ macOS Debug ] ASSERTION FAILED: m_wrapper and te...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf4b2dd3b585e77561edbc98f822a7dcbef399c9
  
https://github.com/WebKit/WebKit/commit/cf4b2dd3b585e77561edbc98f822a7dcbef399c9
  Author: Sihui Liu 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/storage/indexeddb/cursor-request-cycle-expected.txt
M LayoutTests/storage/indexeddb/cursor-request-cycle-private-expected.txt
M LayoutTests/storage/indexeddb/resources/cursor-request-cycle.js
M LayoutTests/storage/indexeddb/resources/value-cursor-cycle.js
M Source/WebCore/Modules/indexeddb/IDBRequest.cpp
M Source/WebCore/Modules/indexeddb/IDBRequest.h
M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp
M Source/WebCore/Modules/indexeddb/IDBTransaction.h

  Log Message:
  ---
  [ macOS Debug ] ASSERTION FAILED: m_wrapper and text failures on 
storage/indexeddb/cursor-update.html
https://bugs.webkit.org/show_bug.cgi?id=259539
rdar://112943647

Reviewed by Chris Dumez.

IDBRequest generated from creating a IDBCursor will be re-used when the created 
cursor advances, i.e. the request's done
flag will become false again, and the request will receive event and result 
about the advancing operation. Therefore, we
need to keep wrapper of IDBRequest alive when the cursor can still advance, 
i.e. when transaction is still active and
cursor has not reached to end. We used to keep it alive only when the operation 
has already started, and IDBRequest and
its the wrapper go away before `IDBCursor.continue()` is called (as IDBCursor 
currently only holds weak reference to
IDBRequest).

* LayoutTests/storage/indexeddb/cursor-request-cycle-expected.txt:
* LayoutTests/storage/indexeddb/cursor-request-cycle-private-expected.txt:
* LayoutTests/storage/indexeddb/resources/cursor-request-cycle.js:
(onOpen.otherRequest.onsuccess.otherRequestSuccess.finalRequest.onsuccess):
(onOpen.otherRequest.onsuccess):
(onOpen):
(onTransactionComplete):
* LayoutTests/storage/indexeddb/resources/value-cursor-cycle.js:
* Source/WebCore/Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::virtualHasPendingActivity const):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::transactionTransitionedToFinishing):
* Source/WebCore/Modules/indexeddb/IDBRequest.h:
* Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::transitionedToFinishing):
(WebCore::IDBTransaction::addCursorRequest):
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::connectionClosedFromServer):
* Source/WebCore/Modules/indexeddb/IDBTransaction.h:

Canonical link: https://commits.webkit.org/268521@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4dfeaf: Fix serialization of “autocomplete” with “webauthn...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dfeafc934022d7c54e3777057f7046ba3430b00
  
https://github.com/WebKit/WebKit/commit/4dfeafc934022d7c54e3777057f7046ba3430b00
  Author: Michael[tm] Smith 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt
M Source/WebCore/html/Autofill.cpp

  Log Message:
  ---
  Fix serialization of “autocomplete” with “webauthn” token
https://bugs.webkit.org/show_bug.cgi?id=261808

Reviewed by Pascoe.

This change makes WebKit fully conform to the spec requirements at
https://html.spec.whatwg.org/#autofill-processing-model:attr-fe-autocomplete-webauthn
for serializing the value of the “autocomplete” attribute when it
contains a “webauthn” token.

Specifically, this change fixes handling for a condition in a substep of
that spec algorithm that checks against the maximum tokens allowed.
The code was comparing the number of tokens to the maximum number of
allowed tokens but instead needs to compare the value of a (decremented)
index counter to the maximum number of allowed tokens minus 1.

This change gets WebKit passing all cases in the WPT test at
https://wpt.fyi/results/html/semantics/forms/the-form-element/form-autocomplete.html

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
* Source/WebCore/html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):

Canonical link: https://commits.webkit.org/268520@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1cfc40: REGRESSION(266896@main): [ wk2 debug ] imported/w3...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cfc40dde59d41519e91dda02b8f21090ef2dd1c
  
https://github.com/WebKit/WebKit/commit/1cfc40dde59d41519e91dda02b8f21090ef2dd1c
  Author: Ryosuke Niwa 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/fetch/private-network-access/resources/support.sub.js
M LayoutTests/platform/wk2/TestExpectations

  Log Message:
  ---
  REGRESSION(266896@main): [ wk2 debug ] 
imported/w3c/web-platform-tests/fetch/private-network-access/iframe.tentative.https.window.html
 is a near-constant failure.
https://bugs.webkit.org/show_bug.cgi?id=262088

Reviewed by Chris Dumez.

Increase the timeout from 500ms to 2s, which is more consistent with other test 
cases, to make this test less flaky.

* 
LayoutTests/imported/w3c/web-platform-tests/fetch/private-network-access/resources/support.sub.js:

Canonical link: https://commits.webkit.org/268519@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 86301d: [GStreamer] Rework playback rates handling

[Xabier Rodríguez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86301d12f31fa6659af3ee6fc5c0ac8be73b73a7
  
https://github.com/WebKit/WebKit/commit/86301d12f31fa6659af3ee6fc5c0ac8be73b73a7
  Author: Xabier Rodriguez-Calvar 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/media/media-source/media-source-play-zero-playbackrate-expected.txt
A LayoutTests/media/media-source/media-source-play-zero-playbackrate.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp

  Log Message:
  ---
  [GStreamer] Rework playback rates handling
https://bugs.webkit.org/show_bug.cgi?id=259732

Reviewed by Alicia Boya Garcia.

There were some use cases in MSE where playback rate change was not working 
properly and it was decided that a better
idea would be to do a rework of the playback rate handling in the base class. 
The idea was to not do playback rate state
changes out of the updateStates functions (both regular and MSE) because 
calling that function should do what is
expected at any moment. In order to do that, we needed to switch the boolean 
variable representing if pipeline was
paused because of rate into something more reflecting the different states we 
could be in. We created a self explanatory
enum class (that also was comments to make it even more clear) and set that 
state when needed for updateStates to move
the pipeline if needed.

A fly-by fix was to make the paused function to return true when we are also 
moving to paused during an async state
change because the test we are introducing here arose this flaky bug more 
clearly. The bug was that the media element
went bananas could not realize the player was paused (or on its way to pause) 
and it was skipping state changes and
playback rate changes.

* LayoutTests/TestExpectations:
* 
LayoutTests/media/media-source/media-source-play-zero-playbackrate-expected.txt:
 Added.
* LayoutTests/media/media-source/media-source-play-zero-playbackrate.html: 
Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::paused const):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::play):
(WebCore::MediaPlayerPrivateGStreamerMSE::pause):
(WebCore::MediaPlayerPrivateGStreamerMSE::updateStates):

Canonical link: https://commits.webkit.org/268518@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3a939b: Bring up iOS 17, tvOS 17, watchOS 10, and Sonoma b...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a939b2fd2b9fb408fa532401ff2655893b67616
  
https://github.com/WebKit/WebKit/commit/3a939b2fd2b9fb408fa532401ff2655893b67616
  Author: Robert Jenner 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories_unittest.py
R Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS16.png
R 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS16Simulator.png
A 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS17Simulator.png
M 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice.png
M 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator.png
A Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Sonoma.png
R Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS16.png
R 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS16Simulator.png
A Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS17.png
A 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS17Simulator.png
A 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS10.png
R Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS9.png
A 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator10.png
R 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator9.png
A Tools/CISupport/build-webkit-org/public_html/dashboard/Images/iOS17.png
M 
Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js
M 
Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js
M Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css
M Tools/CISupport/build-webkit-org/wkbuild.py
M Tools/CISupport/build-webkit-org/wkbuild_unittest.py
M Websites/webkit.org/wp-content/themes/webkit/build-archives.php

  Log Message:
  ---
  Bring up iOS 17, tvOS 17, watchOS 10, and Sonoma builders and testers
https://bugs.webkit.org/show_bug.cgi?id=262065
rdar://116012814

Reviewed by Ryan Haddad.

Config change to bring up Sonoma and friends in the OpenSource infrastructure.

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS16.png: 
Removed.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS16Simulator.png:
 Removed.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOS17Simulator.png:
 Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSDevice.png:
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/IOSSimulator.png:
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/Sonoma.png: 
Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS16.png: 
Removed.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS16Simulator.png:
 Removed.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS17.png: 
Added.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/TvOS17Simulator.png:
 Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS10.png: 
Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOS9.png: 
Removed.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator10.png:
 Added.
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Images/WatchOSSimulator9.png:
 Removed.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Images/iOS17.png: 
Added.
* Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js:
* 
Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css:
(*):
(table.queue-grid tr.platform.ios-simulator-17 img.logo):
(table.queue-grid tr.platform.ios-17 img.logo):
(table.queue-grid tr.platform.tvos-simulator-17 img.logo):
(table.queue-grid tr.platform.tvos-17 img.logo):
(table.queue-grid tr.platform.watchos-simulator-10 img.logo):
(table.queue-grid tr.platform.watchos-10 img.logo):
(table.queue-grid tr.platform.macos-sonoma img.logo):
(table.queue-grid tr.platform.ios-simulator-16 img.logo): Deleted.
(table.queue-grid tr.platform.ios-16 img.logo): Deleted.
(table.queue-grid tr.platform.tvos-simulator-16 img.logo): Deleted.
(table.queue-grid tr.platform.tvos-16 img.logo): Deleted.
(table.queue-grid tr.platform.watchos-simulator-9 img.logo): Deleted.
(table.queue-grid tr.platform.watchos-9 img.logo): Deleted.
* Tools/CISupport/build-webkit-org/wkbuild.py:
(_should_file_trigger_build):
* Tools/CISupport/build-webkit-org/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
* 

[webkit-changes] [WebKit/WebKit] 196a65: Move IPInt slow paths to a new file

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 196a6557e7f4e12503fe4864e34c12fb06223658
  
https://github.com/WebKit/WebKit/commit/196a6557e7f4e12503fe4864e34c12fb06223658
  Author: Keith Miller 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/Sources.txt
A Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp
A Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h
M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp
M Source/JavaScriptCore/wasm/WasmSlowPaths.h

  Log Message:
  ---
  Move IPInt slow paths to a new file
https://bugs.webkit.org/show_bug.cgi?id=261963

Reviewed by Yusuke Suzuki.

This is a simple code cleanliness improvement. No code should be changed
with the exception that `doWasmCallIndirect` used the wrong CALLEE macro
for IPInt before.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.cpp: Added.
(JSC::LLInt::shouldJIT):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL):
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL_1P):
(JSC::LLInt::doWasmCall):
(JSC::LLInt::doWasmCallIndirect):
* Source/JavaScriptCore/wasm/WasmIPIntSlowPaths.h: Copied from 
Source/JavaScriptCore/wasm/WasmSlowPaths.h.
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL): Deleted.
(JSC::LLInt::WASM_IPINT_EXTERN_CPP_DECL_1P): Deleted.
* Source/JavaScriptCore/wasm/WasmSlowPaths.h:

Canonical link: https://commits.webkit.org/268516@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 06973c: Fix Contributors Meeting registration with a local...

[Jon Davis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06973c055345e5e6cf86acd7b9bccc6b4a1be81c
  
https://github.com/WebKit/WebKit/commit/06973c055345e5e6cf86acd7b9bccc6b4a1be81c
  Author: Jonathan Davis 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Websites/webkit.org/wp-content/plugins/meeting-registration/plugin.php

  Log Message:
  ---
  Fix Contributors Meeting registration with a local copy of contributors.json
https://bugs.webkit.org/show_bug.cgi?id=262189

Reviewed by Tim Nguyen.

Switching to using a local copy of contributors.json mitigates timeouts
caused by slow connections to GitHub hosted content.

* Websites/webkit.org/wp-content/plugins/meeting-registration/plugin.php:

Canonical link: https://commits.webkit.org/268515@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3642b: [IFC][Integration] Implement legacy -webkit-line-a...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3642b7d4d2b8b9c6f8f42542458058d250a1891
  
https://github.com/WebKit/WebKit/commit/e3642b7d4d2b8b9c6f8f42542458058d250a1891
  Author: Antti Koivisto 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/ios/fast/line-grid/line-align-left-edges-expected.txt
M 
LayoutTests/platform/ios/fast/line-grid/line-align-right-edges-expected.txt
M LayoutTests/platform/mac/fast/line-grid/line-align-left-edges-expected.txt
M 
LayoutTests/platform/mac/fast/line-grid/line-align-right-edges-expected.txt
M Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  [IFC][Integration] Implement legacy -webkit-line-align property
https://bugs.webkit.org/show_bug.cgi?id=262174


Reviewed by Alan Baradlay.

This property snaps line edges to a grid defined by an ancestor box.

* LayoutTests/platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
* LayoutTests/platform/mac/fast/line-grid/line-align-right-edges-expected.txt:

Floats are no longer aligned to the grid, just the actual line content.

* Source/WebCore/layout/formattingContexts/block/BlockLayoutState.h:
(WebCore::Layout::BlockLayoutState::BlockLayoutState):
(WebCore::Layout::BlockLayoutState::lineGrid const):

Add line grid data.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp:
(WebCore::Layout::InlineFormattingQuirks::adjustedRectForLineGridLineAlign):

Adjust the line rect.
This is based on the code in 
RenderBlock::adjustLogicalLeftOffsetForLine/adjustLogicalRightOffsetForLine

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
(WebCore::Layout::LineBuilder::floatConstrainedRect const):

The adjustment to the line rect is done after computing float constrains and 
has similar effect.

* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::isEligibleForSimplifiedTextOnlyInlineLayout):

Don't allow this property in simplified builder.

* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForBlockStyle):

Enable.

* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::lineGrid):
(WebCore::LayoutIntegration::LineLayout::layout):

Set up to the line grid to BlockLayoutState.

Canonical link: https://commits.webkit.org/268514@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aa46c0: [GTK][WPE] `jhbuild` fails to check out `aom`

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa46c0487af1acdb5f63b5f156c31bd16f0e4aca
  
https://github.com/WebKit/WebKit/commit/aa46c0487af1acdb5f63b5f156c31bd16f0e4aca
  Author: Vitaly Dyachkov 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/gstreamer/jhbuild.modules

  Log Message:
  ---
  [GTK][WPE] `jhbuild` fails to check out `aom`
https://bugs.webkit.org/show_bug.cgi?id=262185

Reviewed by Philippe Normand.

`tag` attribute must specify a git tag, not a commit hash.

* Tools/gstreamer/jhbuild.modules:

Canonical link: https://commits.webkit.org/268513@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 178cde: [IFC][Ruby] Resize annotation renderer after inlin...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 178cde2d00a372eef30bae7bc4c004e326e4ff75
  
https://github.com/WebKit/WebKit/commit/178cde2d00a372eef30bae7bc4c004e326e4ff75
  Author: Alan Baradlay 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  [IFC][Ruby] Resize annotation renderer after inline layout when needed
https://bugs.webkit.org/show_bug.cgi?id=262186

Reviewed by Antti Koivisto.

When annotation box gets resized during ruby layout (e.g. base stretches the 
ruby column) we have to
make sure the associated renderer gets resized too. We also need to initiate a 
layout on the annotation
content to ensure proper content alignment.
(This is a temporary workaround and generating inline boxes (and not 
inline-blocks) for annotations will render it redundant.)

* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/268512@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 232f97: Store fewer raw pointers in containers in Source/W...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 232f970e463d69bf7e6643e96bbc0d2c47040fac
  
https://github.com/WebKit/WebKit/commit/232f970e463d69bf7e6643e96bbc0d2c47040fac
  Author: Chris Dumez 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WTF/wtf/WeakHashSet.h
M Source/WebCore/loader/FormState.h
M Source/WebCore/page/FrameDestructionObserver.h
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/plugins/PluginInfoProvider.h

  Log Message:
  ---
  Store fewer raw pointers in containers in Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=262149

Reviewed by Darin Adler.

* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/page/FrameDestructionObserver.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::willDestroyCachedFrame):
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::~LocalFrame):
(WebCore::LocalFrame::addDestructionObserver):
(WebCore::LocalFrame::removeDestructionObserver):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::addEmbeddedObjectToUpdate):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::refreshPlugins):
* Source/WebCore/page/Page.h:
* Source/WebCore/plugins/PluginInfoProvider.h:

Canonical link: https://commits.webkit.org/268511@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c2e83f: [css-grid] adjustGridPositionsFromStyle should set...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2e83fc185932b1b09c3ef4d75468cf47b2515d2
  
https://github.com/WebKit/WebKit/commit/c2e83fc185932b1b09c3ef4d75468cf47b2515d2
  Author: Sammy Gill 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/style/GridPositionsResolver.cpp

  Log Message:
  ---
  [css-grid] adjustGridPositionsFromStyle should set a subgrid's indefinite 
span to use the null string
https://bugs.webkit.org/show_bug.cgi?id=260527
rdar://114271485

Reviewed by Matt Woodrow.

If a subgrid has an indefinite span in the subgridded dimension,
adjustGridPositionsFromStyle will attempt to set the span size based
on the the number of named lines that it has. This is done with a call
similar to span.setSpanPosition(std::max(1, lineCount - 1), emtpyString()).

This code presumably does not want to set the m_namedGridLine portion
of the GridPosition as we are not actually referencing a named grid
line. However, we should probably be using String() here instead of
emptyString() to set that value to the null string as the rest of the
code checks against !position.namedGridLine().isNull() when attempting
to use the named grid line. This change helps us avoid entering code
guarded by that type of logic when we probably do not want to.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/style/GridPositionsResolver.cpp:
(WebCore::adjustGridPositionsFromStyle):

Canonical link: https://commits.webkit.org/268510@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] faf719: `run-minibrowser` fails at installing `configparser`

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: faf71968c64b7cdd628866a64ec644a6d884c771
  
https://github.com/WebKit/WebKit/commit/faf71968c64b7cdd628866a64ec644a6d884c771
  Author: Vitaly Dyachkov 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  ---
  `run-minibrowser` fails at installing `configparser`
https://bugs.webkit.org/show_bug.cgi?id=262182

Reviewed by Jonathan Bedard.

After `268269@main` `pyparsing` must be specified as a implicit
dependency of `configparser`.

* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/268509@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1d3b4f: [IFC][Ruby] Annotation box should be (inline-axis)...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d3b4f3e24754bd71e656c2bd839170764e46839
  
https://github.com/WebKit/WebKit/commit/1d3b4f3e24754bd71e656c2bd839170764e46839
  Author: Alan Baradlay 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/layout/LayoutUnits.h
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  ---
  [IFC][Ruby] Annotation box should be (inline-axis) sized to the associated 
ruby column
https://bugs.webkit.org/show_bug.cgi?id=262153

Reviewed by Antti Koivisto.

This patch is in preparation for initiating another layout pass on annotation 
boxes when
they are stretched to the size of the ruby base.

* Source/WebCore/layout/LayoutUnits.h:
(WebCore::Layout::toLayoutSize):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendInterlinearRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendIntercharacterRubyAnnotationBox):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::sizeAnnotationBox):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/268508@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 77a5b5: Update serialization for InspectorFrontendClient a...

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77a5b5dffe62f0481c8315e7d723702f959a
  
https://github.com/WebKit/WebKit/commit/77a5b5dffe62f0481c8315e7d723702f959a
  Author: Simon Lewis 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/inspector/InspectorFrontendClient.h
M Source/WebCore/platform/graphics/PlatformTextTrack.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Update serialization for InspectorFrontendClient and PlatformTextTrackData
https://bugs.webkit.org/show_bug.cgi?id=262162
rdar://116098797

Reviewed by Alex Christensen.

* Source/WebCore/inspector/InspectorFrontendClient.h:
(WebCore::InspectorFrontendClient::SaveData::encode const): Deleted.
(WebCore::InspectorFrontendClient::SaveData::decode): Deleted.
* Source/WebCore/platform/graphics/PlatformTextTrack.h:
(WebCore::PlatformTextTrackData::decode): Deleted.
(WebCore::PlatformTextTrackData::encode const): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268507@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eab656: [IFC][Ruby] Move annotation borderBox top/left log...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eab6568c625b4c6e295a57e3330331377fc08991
  
https://github.com/WebKit/WebKit/commit/eab6568c625b4c6e295a57e3330331377fc08991
  Author: Alan Baradlay 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  ---
  [IFC][Ruby] Move annotation borderBox top/left logic to 
RubyFormattingContext:placeAnnotationBox
https://bugs.webkit.org/show_bug.cgi?id=262148

Reviewed by Antti Koivisto.

This is in preparation for sizing the annotation box.

* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendInterlinearRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendIntercharacterRubyAnnotationBox):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::annotationPosition): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/268506@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] abb7c5: Reimport WPT tests up to 5e3b0aa

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abb7c5d5bd0783f04b8c8411c3f862c004f487a3
  
https://github.com/WebKit/WebKit/commit/abb7c5d5bd0783f04b8c8411c3f862c004f487a3
  Author: Youenn Fablet 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/META.yml
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-codec-specific.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-codec-specific.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-flush.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-flush.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-flush.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-flush.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-flush.https.any.worker.html
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder.https.any.worker-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoDecoder-codec-specific.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-copyTo.any-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-copyTo.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-copyTo.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-odd-size.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-odd-size.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-odd-size.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-odd-size.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-odd-size.any.worker.html
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any.worker-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt

  Log Message:
  ---
  Reimport WPT tests up to 5e3b0aa
https://bugs.webkit.org/show_bug.cgi?id=262040
rdar://115992997

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/: Resynced.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any-expected.txt:
 Added.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-decoder.https.any.worker-expected.txt:
 Added.
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt:

Canonical link: 

[webkit-changes] [WebKit/WebKit] 9fdb10: [WGSL] Add support for atomic types

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fdb10ebb1ce6765e0d1dc4199ac5140edc4f434
  
https://github.com/WebKit/WebKit/commit/9fdb10ebb1ce6765e0d1dc4199ac5140edc4f434
  Author: Tadeu Zagallo 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/ConstantRewriter.cpp
M Source/WebGPU/WGSL/Constraints.cpp
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/TypeStore.cpp
M Source/WebGPU/WGSL/TypeStore.h
M Source/WebGPU/WGSL/Types.cpp
M Source/WebGPU/WGSL/Types.h
A Source/WebGPU/WGSL/tests/invalid/atomics.wgsl
A Source/WebGPU/WGSL/tests/valid/atomics.wgsl

  Log Message:
  ---
  [WGSL] Add support for atomic types
https://bugs.webkit.org/show_bug.cgi?id=262127
rdar://116064944

Reviewed by Mike Wyrzykowski.

Add support for atomic according to the spec[1].

[1]: https://www.w3.org/TR/WGSL/#atomic-types

* Source/WebGPU/WGSL/ConstantRewriter.cpp:
(WGSL::ConstantRewriter::materialize):
* Source/WebGPU/WGSL/Constraints.cpp:
(WGSL::concretize):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::bindingMemberForGlobal):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::TypeChecker):
* Source/WebGPU/WGSL/TypeStore.cpp:
(WGSL::TypeStore::TypeStore):
(WGSL::TypeStore::atomicType):
* Source/WebGPU/WGSL/TypeStore.h:
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::dump const):
(WGSL::Type::size const):
(WGSL::Type::alignment const):
* Source/WebGPU/WGSL/Types.h:
* Source/WebGPU/WGSL/tests/invalid/atomics.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/atomics.wgsl: Added.

Canonical link: https://commits.webkit.org/268504@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46510a: WebVTT Timestamp Object need one leading zero if t...

[Kohei Ueno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46510aee943163967d2d9f6d5f99e5e09ce95a52
  
https://github.com/WebKit/WebKit/commit/46510aee943163967d2d9f6d5f99e5e09ce95a52
  Author: Kohei Ueno 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt
M Source/WebCore/html/track/WebVTTParser.cpp

  Log Message:
  ---
  WebVTT Timestamp Object need one leading zero if the hours component is less 
than ten
https://bugs.webkit.org/show_bug.cgi?id=261201

Reviewed by Eric Carlson.

According to the spec, one leading zero is required if the hours
component is less than ten when timestamp construction. This commit updates
the WebVTT parser to follow the spec.

https://www.w3.org/TR/webvtt1/#dom-construction-rules

* 
LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/getCueAsHTML-expected.txt:
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::appendNumber):
(WebCore::serializeTimestamp):
(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

Canonical link: https://commits.webkit.org/268503@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8ff13: Annotate pointerevent_attributes_hoverable_pointer...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8ff13ed86104277ce75762e9bae65a27f3d93bb
  
https://github.com/WebKit/WebKit/commit/b8ff13ed86104277ce75762e9bae65a27f3d93bb
  Author: Abrar Rahman Protyasha 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Annotate pointerevent_attributes_hoverable_pointers.html?mouse expectation 
with Bugzilla ticket
https://bugs.webkit.org/show_bug.cgi?id=262173
rdar://116111833

Unreviewed test expectations annotation.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/268502@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67c706: [WGSL] Add support for while statements

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67c706376e768a8f5bf4495ca34e89e5fc1f662d
  
https://github.com/WebKit/WebKit/commit/67c706376e768a8f5bf4495ca34e89e5fc1f662d
  Author: Tadeu Zagallo 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/Parser.cpp
M Source/WebGPU/WGSL/ParserPrivate.h
M Source/WebGPU/WGSL/TypeCheck.cpp
A Source/WebGPU/WGSL/tests/invalid/while.wgsl
A Source/WebGPU/WGSL/tests/valid/while.wgsl

  Log Message:
  ---
  [WGSL] Add support for while statements
https://bugs.webkit.org/show_bug.cgi?id=262126
rdar://116064615

Reviewed by Mike Wyrzykowski.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseStatement):
(WGSL::Parser::parseWhileStatement):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/while.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/while.wgsl: Added.

Canonical link: https://commits.webkit.org/268501@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8f8952: Move RenderSVGResourceClipper into legacy

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f89524115a09d620e5a6eb1eddbbfc949c5b0e4
  
https://github.com/WebKit/WebKit/commit/8f89524115a09d620e5a6eb1eddbbfc949c5b0e4
  Author: Rob Buis 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/rendering/ReferencedSVGResources.cpp
M Source/WebCore/rendering/ReferencedSVGResources.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderLayer.cpp
A 
Source/WebCore/rendering/svg/Legacy/LegacyRenderSVGResourceClipperInlines.h
M Source/WebCore/rendering/svg/RenderSVGResource.cpp
R Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
R Source/WebCore/rendering/svg/RenderSVGResourceClipper.h
R Source/WebCore/rendering/svg/RenderSVGResourceClipperInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp
M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/svg/SVGRenderingContext.cpp
M Source/WebCore/rendering/svg/SVGResources.cpp
M Source/WebCore/rendering/svg/SVGResources.h
M Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp
A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp
A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h
A 
Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h
M Source/WebCore/svg/SVGClipPathElement.cpp

  Log Message:
  ---
  Move RenderSVGResourceClipper into legacy
https://bugs.webkit.org/show_bug.cgi?id=262114

Reviewed by Nikolas Zimmermann.

Move RenderSVGResourceClipper into legacy and rename it in order
to introduce LBSE RenderSVGResourceClipper variant, which will
offer stateless clipping for RenderLayer.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedClipperRenderer):
* Source/WebCore/rendering/ReferencedSVGResources.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hitTestClipPath const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::layerCreationAllowedForSubtree const):
* Source/WebCore/rendering/RenderLayer.cpp:
* Source/WebCore/rendering/svg/Legacy/LegacyRenderSVGResourceClipperInlines.h: 
Copied from Source/WebCore/rendering/svg/RenderSVGResourceClipperInlines.h.
(WebCore::LegacyRenderSVGResourceClipper::clipPathElement const):
(WebCore::LegacyRenderSVGResourceClipper::clipPathUnits const):
* Source/WebCore/rendering/svg/RenderSVGResource.cpp:
(WebCore::requestPaintingResource):
(WebCore::removeFromCacheAndInvalidateDependencies):
* Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::applyResource):
* Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp:
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources):
(WebCore::SVGRenderSupport::pointInClippingArea):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
(WebCore::writeResources):
* Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::setClipper):
* Source/WebCore/rendering/svg/SVGResources.h:
(WebCore::SVGResources::clipper const):
* Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: 
Renamed from Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp.
(WebCore::LegacyRenderSVGResourceClipper::LegacyRenderSVGResourceClipper):
(WebCore::LegacyRenderSVGResourceClipper::removeAllClientsFromCache):
(WebCore::LegacyRenderSVGResourceClipper::removeClientFromCache):
(WebCore::LegacyRenderSVGResourceClipper::applyResource):
(WebCore::LegacyRenderSVGResourceClipper::pathOnlyClipping):
(WebCore::LegacyRenderSVGResourceClipper::computeInputs):
(WebCore::LegacyRenderSVGResourceClipper::applyClippingToContext):
(WebCore::LegacyRenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::LegacyRenderSVGResourceClipper::calculateClipContentRepaintRect):
(WebCore::LegacyRenderSVGResourceClipper::hitTestClipContent):
(WebCore::LegacyRenderSVGResourceClipper::resourceBoundingBox):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: Renamed 
from Source/WebCore/rendering/svg/RenderSVGResourceClipper.h.
(WebCore::ClipperData::invalidate):
(isType):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h: 
Renamed from 

[webkit-changes] [WebKit/WebKit] f19946: [WGSL] Vector constants are incorrect

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f19946127d6320625b638893878aad89de7af7e1
  
https://github.com/WebKit/WebKit/commit/f19946127d6320625b638893878aad89de7af7e1
  Author: Tadeu Zagallo 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/ConstantRewriter.cpp
M Source/WebGPU/WGSL/ConstantValue.h
M Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl

  Log Message:
  ---
  [WGSL] Vector constants are incorrect
https://bugs.webkit.org/show_bug.cgi?id=262125
rdar://116063871

Reviewed by Mike Wyrzykowski.

The current implementation the constant vector constructor only works for the 
case
where the vector is constructor from N simple types (e.g. vec3(0,0)), but it 
doesn't
work when the constructor has to clone a single value (e.g. vec3(0)) or when the
constructor takes other vectors as an argument (e.g. vec3(vec2(0), 0) or 
vec3(vec3(0))).

This patch implements the constructor correctly, handling all of these cases. 
In order to
do, it also introduces the correct "zero values" for all types, according to 
the spec[1].

It also simplifies ConstantValue by removing the type from it, which wasn't 
necessary
and complicated the creation of values.

[1]: https://www.w3.org/TR/WGSL/#zero-value-builtin-function

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::constantPow):
(WGSL::zeroValue):
(WGSL::constantVector):
(WGSL::constantVector2):
(WGSL::constantVector3):
(WGSL::constantVector4):
* Source/WebGPU/WGSL/ConstantRewriter.cpp:
(WGSL::ConstantRewriter::ConstantRewriter):
(WGSL::ConstantRewriter::visit):
(WGSL::ConstantRewriter::evaluate):
(WGSL::ConstantRewriter::materialize):
* Source/WebGPU/WGSL/ConstantValue.h:
(WGSL::ConstantValue::toBool const):
(WGSL::ConstantValue::toInt const):
(WGSL::ConstantValue::toDouble const):
(WGSL::ConstantValue::ConstantValue): Deleted.
(WGSL::ConstantValue::constructDeletedValue): Deleted.
(WGSL::ConstantValue::isDeletedValue): Deleted.
* Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl:

Canonical link: https://commits.webkit.org/268499@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c2c3e6: [GTK][WPE] Gardening LayoutTests/webrtc/video-disa...

[Amanda Falke]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2c3e60de05fa77c39257724d1237e9585604f2e
  
https://github.com/WebKit/WebKit/commit/c2c3e60de05fa77c39257724d1237e9585604f2e
  Author: Amanda Falke 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations

  Log Message:
  ---
  [GTK][WPE] Gardening LayoutTests/webrtc/video-disabled-black.html

Unreviewed test gardening.

Test was gardened a couple of weeks ago in webkit.org/b/261024; and
webkit.org/b/254212 is also related to this test as a fix. Since
webkit.org/b/254212, test has been flaky; prior to that, it failed in bots.
Generally a flaky test as noted in 261024 which is still open.

Noted in existing bugs 261024, 254212; moved expectations up to glib.

* LayoutTests/platform/glib/TestExpectations: move expectation here for 
flakiness
* LayoutTests/platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/268498@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Carlos Garcia Campos]

  Branch: refs/tags/webkitgtk-2.42.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d39b3: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...

[Carlos Garcia Campos]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d39b37ad17857799921b8a39a40fdc1100550f4
  
https://github.com/WebKit/WebKit/commit/6d39b37ad17857799921b8a39a40fdc1100550f4
  Author: Carlos Garcia Campos 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for 2.42.1 release

* Source/WebKit/gtk/NEWS: Add release notes for 2.42.1.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c72c1: [Win] Ninja clang-cl and MSBuild clang-cl should u...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c72c18c1345de2fd7f98b39e2e6d85808a13592
  
https://github.com/WebKit/WebKit/commit/0c72c18c1345de2fd7f98b39e2e6d85808a13592
  Author: Fujii Hironori 
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
M Source/cmake/OptionsMSVC.cmake
M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  ---
  [Win] Ninja clang-cl and MSBuild clang-cl should use the same compiler 
warning flags
https://bugs.webkit.org/show_bug.cgi?id=262166

Reviewed by Ross Kirsling.

CMake Visual Studio generator ignores MSVC-style compiler warning
flags for clang-cl, for example /wd4100, while CMake Ninja generator
doesn't. They should be aligned.

Don't use MSVC-style compiler warning flags for clang-cl. Instead, use
GCC-style for it.

* Source/cmake/OptionsMSVC.cmake:
* Source/cmake/WebKitCompilerFlags.cmake:

Canonical link: https://commits.webkit.org/268497@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes