[webkit-changes] [WebKit/WebKit] ff5072: WebGPU should be exposed in DedicatedWorkers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff507241e7dd8c7bc6d01f11027c09e8e3f0dc1b https://github.com/WebKit/WebKit/commit/ff507241e7dd8c7bc6d01f11027c09e8e3f0dc1b Author: Mike Wyrzykowski Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/JavaScriptCore/inspector/protocol/Canvas.json M Source/WebCore/Modules/WebGPU/GPU.idl M Source/WebCore/Modules/WebGPU/GPUAdapter.idl M Source/WebCore/Modules/WebGPU/GPUAdapterInfo.idl M Source/WebCore/Modules/WebGPU/GPUBindGroup.idl M Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.idl M Source/WebCore/Modules/WebGPU/GPUBuffer.idl M Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl M Source/WebCore/Modules/WebGPU/GPUColorWrite.idl M Source/WebCore/Modules/WebGPU/GPUCommandBuffer.idl M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.idl M Source/WebCore/Modules/WebGPU/GPUCompilationInfo.idl M Source/WebCore/Modules/WebGPU/GPUCompilationMessage.idl M Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.idl M Source/WebCore/Modules/WebGPU/GPUComputePipeline.idl M Source/WebCore/Modules/WebGPU/GPUDevice.idl M Source/WebCore/Modules/WebGPU/GPUDeviceLostInfo.idl M Source/WebCore/Modules/WebGPU/GPUExternalTexture.idl M Source/WebCore/Modules/WebGPU/GPUInternalError.idl M Source/WebCore/Modules/WebGPU/GPUMapMode.idl M Source/WebCore/Modules/WebGPU/GPUOutOfMemoryError.idl M Source/WebCore/Modules/WebGPU/GPUPipelineLayout.idl M Source/WebCore/Modules/WebGPU/GPUQuerySet.idl M Source/WebCore/Modules/WebGPU/GPUQueue.idl M Source/WebCore/Modules/WebGPU/GPURenderBundle.idl M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.idl M Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.idl M Source/WebCore/Modules/WebGPU/GPURenderPipeline.idl M Source/WebCore/Modules/WebGPU/GPUSampler.idl M Source/WebCore/Modules/WebGPU/GPUShaderModule.idl M Source/WebCore/Modules/WebGPU/GPUShaderStage.idl M Source/WebCore/Modules/WebGPU/GPUSupportedFeatures.idl M Source/WebCore/Modules/WebGPU/GPUSupportedLimits.idl M Source/WebCore/Modules/WebGPU/GPUTexture.idl M Source/WebCore/Modules/WebGPU/GPUTextureUsage.idl M Source/WebCore/Modules/WebGPU/GPUTextureView.idl M Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.idl M Source/WebCore/Modules/WebGPU/GPUValidationError.idl M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/OffscreenCanvas.h M Source/WebCore/html/OffscreenCanvas.idl M Source/WebCore/html/canvas/GPUCanvasContext.idl M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm M Source/WebCore/inspector/InspectorCanvas.cpp M Source/WebCore/page/Chrome.cpp M Source/WebCore/page/Chrome.h M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/Navigator.cpp M Source/WebCore/page/WorkerNavigator.cpp M Source/WebCore/page/WorkerNavigator.h M Source/WebCore/platform/GraphicsClient.h M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUIdentifier.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebWorkerClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebWorkerClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm Log Message: --- WebGPU should be exposed in DedicatedWorkers https://bugs.webkit.org/show_bug.cgi?id=232542> Reviewed by Tadeu Zagallo. Allow WebGPU to render in a web worker. This patch is mostly mechanical and doesn't implement copying the buffer from OffscreenCavnas, so nothing is visible, but GPU frame capture indicates the expected results are rendered. * Source/JavaScriptCore/inspector/protocol/Canvas.json: * Source/WebCore/Modules/WebGPU/GPU.idl: * Source/WebCore/Modules/WebGPU/GPUAdapter.idl: * Source/WebCore/Modules/WebGPU/GPUAdapterInfo.idl: * Source/WebCore/Modules/WebGPU/GPUBindGroup.idl: * Source/WebCore/Modules/WebGPU/GPUBindGroupLayout.idl: * Source/WebCore/Modules/WebGPU/GPUBuffer.idl: * Source/WebCore/Modules/WebGPU/GPUBufferUsage.idl: * Source/WebCore/Modules/WebGPU/GPUColorWrite.idl: * Source/WebCore/Modules/WebGPU/GPUCommandBuffer.idl: * Source/WebCore/Modules/WebGPU/GPUCommandEncoder.idl: * Source/WebCore/Modules/WebGPU/GPUCompilationInfo.idl: * Source/WebCore/Modules/WebGPU/GPUCompilationMessage.idl: * Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.idl: * Source/WebCore/Modules/WebGPU/GPUComputePipeline.idl: * Source/WebCore/Modules/WebGPU/GPUDevice.idl: * Source/WebCore/Modules/WebGPU/GPUDeviceLostInfo.idl: * Source/WebCore/Modules/WebGPU/GPUExternalTexture.idl: * Source/WebCore/Modules/WebGPU/GPUInternalError.idl: * Source/WebCore/Modules/WebGPU/GPU
[webkit-changes] [WebKit/WebKit] 1001da: Have NativePromise takes an optional LogSiteIdenti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1001da37687abd8a91e11af93764908c35181323 https://github.com/WebKit/WebKit/commit/1001da37687abd8a91e11af93764908c35181323 Author: Jean-Yves Avenard Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WTF/wtf/Compiler.h M Source/WTF/wtf/Logger.h M Source/WTF/wtf/NativePromise.cpp M Source/WTF/wtf/NativePromise.h M Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp M Source/WebKit/Platform/IPC/Connection.h M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp M Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp Log Message: --- Have NativePromise takes an optional LogSiteIdentifier https://bugs.webkit.org/show_bug.cgi?id=262231 rdar://116151538 Reviewed by Eric Carlson. NativePromise and related methods now takes an optional LogSiteIdentifier for logging purposes created by default as `LogSiteIdentifier(__builtin_FUNCTION(), nullptr)` Ideally we would use `std::source_location::current().function_name()` however, clang used in EWS bots do not have it, and on XCode version 15 it's also broken, acting like `__func__` which isn't particularly useful where it's the caller's name that is of interest. Also changing logging to the more modern WebKit style and add a LogArgument specialisation for NativePromise. Makes for much more readable logging. * Source/WTF/wtf/Logger.h: Make NativePromise friend. * Source/WTF/wtf/NativePromise.cpp: (WTF::NativePromiseBase::logChannel): * Source/WTF/wtf/NativePromise.h: (WTF::NativePromiseBase::log): (WTF::invokeAsync): (WTF::LogArgument::toString): * Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp: (WebCore::AsyncAudioDecoder::decodeAsync): * Source/WebCore/Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::decodeAudioData): * Source/WebKit/Platform/IPC/Connection.h: (IPC::Connection::sendWithPromisedReply): (IPC::Connection::makeAsyncReplyHandler): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/IPC/MessageSenderTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp: (TestWebKitAPI::doFailAndReject): (TestWebKitAPI::TEST): (TestWebKitAPI::myMethod): (TestWebKitAPI::myMethodReturningThenCommand): (TestWebKitAPI::myMethodReturningProducer): Canonical link: https://commits.webkit.org/268692@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 912e5b: [WebGPU] CompositorIntegrationImpl should store We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 912e5b85f7e31b14718f25987cb965789148a334 https://github.com/WebKit/WebKit/commit/912e5b85f7e31b14718f25987cb965789148a334 Author: Mike Wyrzykowski Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h Log Message: --- [WebGPU] CompositorIntegrationImpl should store WebCore::IOSurface instances not IOSurfaceRef directly https://bugs.webkit.org/show_bug.cgi?id=262397 Reviewed by Dan Glastonbury. Now that we are in WebCore and not PAL, we can use WebCore::IOSurface instead of IOSurfaceRef. This will be used in a followup patch to support WebGPU in OffscreenCanvas. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp: (WebCore::WebGPU::CompositorIntegrationImpl::recreateRenderBuffers): (WebCore::WebGPU::toCFNumber): Deleted. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h: Canonical link: https://commits.webkit.org/268691@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f9e24: Use a WeakHashSet for Page::m_relevantUnpaintedRen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f9e2447e6bfaf0b44f32ddb63c7271cc39d61f8 https://github.com/WebKit/WebKit/commit/2f9e2447e6bfaf0b44f32ddb63c7271cc39d61f8 Author: Chris Dumez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/rendering/RenderEmbeddedObject.cpp M Source/WebCore/rendering/RenderHTMLCanvas.cpp M Source/WebCore/rendering/RenderImage.cpp M Source/WebCore/rendering/RenderVideo.cpp M Source/WebCore/rendering/TextBoxPainter.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp Log Message: --- Use a WeakHashSet for Page::m_relevantUnpaintedRenderObjects https://bugs.webkit.org/show_bug.cgi?id=262419 Reviewed by Alan Baradlay. Use a WeakHashSet for Page::m_relevantUnpaintedRenderObjects instead of storing raw pointers in a HashSet. * Source/WebCore/page/Page.cpp: (WebCore::Page::addRelevantRepaintedObject): (WebCore::Page::addRelevantUnpaintedObject): * Source/WebCore/page/Page.h: * Source/WebCore/rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paint): * Source/WebCore/rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): * Source/WebCore/rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): * Source/WebCore/rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced): * Source/WebCore/rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::paint): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paintForeground): * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paintObject): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp: (WebCore::LegacyRenderSVGRoot::paintReplaced): Canonical link: https://commits.webkit.org/268690@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c82031: [WebGPU] Buffer dynamic offsets are not implemented (
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c82031ffbbcbcc0b383b95d87c0fe0c6aa5e3fb4 https://github.com/WebKit/WebKit/commit/c82031ffbbcbcc0b383b95d87c0fe0c6aa5e3fb4 Author: Mike Wyrzykowski Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/WGSL.h M Source/WebGPU/WebGPU/BindGroupLayout.h M Source/WebGPU/WebGPU/BindGroupLayout.mm M Source/WebGPU/WebGPU/ComputePassEncoder.h M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/ComputePipeline.h M Source/WebGPU/WebGPU/ComputePipeline.mm M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/Device.mm M Source/WebGPU/WebGPU/PipelineLayout.h M Source/WebGPU/WebGPU/PipelineLayout.mm M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.h M Source/WebGPU/WebGPU/RenderPassEncoder.mm M Source/WebGPU/WebGPU/RenderPipeline.h M Source/WebGPU/WebGPU/RenderPipeline.mm M Source/WebGPU/WebGPU/ShaderModule.mm Log Message: --- [WebGPU] Buffer dynamic offsets are not implemented ( https://bugs.webkit.org/show_bug.cgi?id=262067 Reviewed by Tadeu Zagallo. Encode the dynamic offsets which are needed by the bind group layout and pass it to the WGSL::BindGroupLayout. * Source/WebGPU/WGSL/WGSL.h: * Source/WebGPU/WebGPU/BindGroupLayout.h: (WebGPU::BindGroupLayout::create): (WebGPU::BindGroupLayout::entries const): Add optional dynamic offsets. * Source/WebGPU/WebGPU/BindGroupLayout.mm: (WebGPU::createArgumentDescriptor): (WebGPU::Device::createBindGroupLayout): (WebGPU::BindGroupLayout::BindGroupLayout): (WebGPU::BindGroupLayout::sizeOfVertexDynamicOffsets const): (WebGPU::BindGroupLayout::sizeOfFragmentDynamicOffsets const): (WebGPU::BindGroupLayout::sizeOfComputeDynamicOffsets const): Compute space for the dynamic offsets. * Source/WebGPU/WebGPU/ComputePassEncoder.h: * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::executePreDispatchCommands): (WebGPU::ComputePassEncoder::dispatch): (WebGPU::ComputePassEncoder::dispatchIndirect): (WebGPU::ComputePassEncoder::setBindGroup): (WebGPU::ComputePassEncoder::setPipeline): Set the side buffer prior to executing any draw commands. * Source/WebGPU/WebGPU/ComputePipeline.h: * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::ComputePipeline::pipelineLayout const): Allow access to the pipeline layout. * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/Device.mm: (WebGPU::Device::maxBuffersPlusVertexBuffersForVertexStage const): (WebGPU::Device::maxBuffersForFragmentStage const): (WebGPU::Device::maxBuffersForComputeStage const): Encode the side buffer offsets in the last available buffer. * Source/WebGPU/WebGPU/PipelineLayout.h: * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::Device::createPipelineLayout): (WebGPU::addInitialOffset): (WebGPU::PipelineLayout::PipelineLayout): (WebGPU::returnTotalSize): (WebGPU::PipelineLayout::sizeOfVertexDynamicOffsets const): (WebGPU::PipelineLayout::sizeOfFragmentDynamicOffsets const): (WebGPU::PipelineLayout::sizeOfComputeDynamicOffsets const): (WebGPU::returnOffsetOfGroup0): (WebGPU::PipelineLayout::vertexOffsetForBindGroup const): (WebGPU::PipelineLayout::fragmentOffsetForBindGroup const): (WebGPU::PipelineLayout::computeOffsetForBindGroup const): (WebGPU::PipelineLayout::offsetVectorForBindGroup): (WebGPU::PipelineLayout::vertexOffsets): (WebGPU::PipelineLayout::fragmentOffsets): (WebGPU::PipelineLayout::computeOffsets): Add member functions for populating the dynamic offsets specified by setBindGroup * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::executePreDrawCommands): (WebGPU::RenderBundleEncoder::setBindGroup): (WebGPU::RenderBundleEncoder::setPipeline): To be implemented in https://bugs.webkit.org/show_bug.cgi?id=262208 * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::executePreDrawCommands): (WebGPU::RenderPassEncoder::draw): (WebGPU::RenderPassEncoder::drawIndexed): (WebGPU::RenderPassEncoder::drawIndexedIndirect): (WebGPU::RenderPassEncoder::drawIndirect): (WebGPU::RenderPassEncoder::setBindGroup): (WebGPU::RenderPassEncoder::setPipeline): Same as ComputePassEncoder. * Source/WebGPU/WebGPU/RenderPipeline.h: * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::pipelineLayout const): Allow access to the pipeline layout. * Source/WebGPU/WebGPU/ShaderModule.mm: (WebGPU::Device::createShaderModule): (WebGPU::ShaderModule::convertPipelineLayout): Pass the dynamic offsets to WGSL. Canonical link: https://commits.webkit.org/268689@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c44dcf: Begin implementing RemoteDOMWindow properties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c44dcfa19a644523ebdc60d75d94dbdcf8a71e4b https://github.com/WebKit/WebKit/commit/c44dcfa19a644523ebdc60d75d94dbdcf8a71e4b Author: Alex Christensen Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: A LayoutTests/http/tests/site-isolation/resources/window-properties-child.html A LayoutTests/http/tests/site-isolation/resources/window-properties-grandchild.html A LayoutTests/http/tests/site-isolation/window-properties-expected.txt A LayoutTests/http/tests/site-isolation/window-properties.html M Source/WebCore/page/FrameTree.cpp M Source/WebCore/page/RemoteDOMWindow.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Begin implementing RemoteDOMWindow properties https://bugs.webkit.org/show_bug.cgi?id=262327 rdar://116199379 Reviewed by Pascoe. A cross-origin iframe has some properties that can be queried without site isolation, and these properties need to continue to work with site isolation enabled. length is the number of subframes, which we can get from the frame tree. parent goes up in the frame tree by one frame top goes up in the frame tree all the way to ... the top Scoped children checks work a little differently with RemoteFrames and RemoteDOMWindows because we don't have a Document or a TreeScope from that Frame. For now, consider these in scope until removed by an incoming IPC message. This definition may need some refining later, but this makes these cases work as they used to without site isolation enabled. In order to get the test to finish successfully, I had to correct the conditions under which WebPage::DidFinishLoadInAnotherProcess would be sent. Instead of checking if the parent frame has a RemotePageProxy, we need to check if the frame is in a different process than its parent. This makes the test finish successfully when the grandchild is in the same process as the main frame (so it has no RemotePageProxy) but its parent is not. They are in different processes, so IPC is required to inform of the frame load completion. * LayoutTests/http/tests/site-isolation/resources/window-properties-child.html: Added. * LayoutTests/http/tests/site-isolation/resources/window-properties-grandchild.html: Added. * LayoutTests/http/tests/site-isolation/window-properties-expected.txt: Added. * LayoutTests/http/tests/site-isolation/window-properties.html: Added. * Source/WebCore/page/FrameTree.cpp: (WebCore::inScope): * Source/WebCore/page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::focus): (WebCore::RemoteDOMWindow::length const): (WebCore::RemoteDOMWindow::top const): (WebCore::RemoteDOMWindow::parent const): Canonical link: https://commits.webkit.org/268688@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3b218: rdar://89218473 ([ER] WebKitTestRunner and DumpRen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3b218402da7205aec197cdc863e9d3f63fc3b95 https://github.com/WebKit/WebKit/commit/b3b218402da7205aec197cdc863e9d3f63fc3b95 Author: Scott Marcy Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Tools/DumpRenderTree/DumpRenderTree.h M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/DumpRenderTree/mac/ResourceLoadDelegate.h M Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h Log Message: --- rdar://89218473 ([ER] WebKitTestRunner and DumpRenderTree should let the user know if loading a file or a url failed) Reviewed by David Kilzer (ddkilzer). This adds preflight checking for the existence of input files specified on the command line, as well as reporting of any URL loading errors. * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (runTest): * Tools/DumpRenderTree/mac/ResourceLoadDelegate.h: * Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate dealloc]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPlatformWebView): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::createTestURL): (WTR::TestController::runTest): (WTR::TestController::didFailProvisionalNavigation): (WTR::pathSuitableForTestResult): * Tools/WebKitTestRunner/TestController.h: Canonical link: https://commits.webkit.org/268687@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 101d1b: [Gardening]: [ Sonoma ] 4 tests under fast/forms a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 101d1b71bed2b4851446b70e289d06a077507b8b https://github.com/WebKit/WebKit/commit/101d1b71bed2b4851446b70e289d06a077507b8b Author: Ben Schwartz Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ Sonoma ] 4 tests under fast/forms are constantly failing. rdar://116268173 https://bugs.webkit.org/show_bug.cgi?id=262427 Unreviewed test gardening. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/268686@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c8170: [Gardening]: REGRESSION(268433@main): [ iOS17 Sono...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c8170822ba4ad0e001b75eb71fa57e099d9498f https://github.com/WebKit/WebKit/commit/1c8170822ba4ad0e001b75eb71fa57e099d9498f Author: Ben Schwartz Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION(268433@main): [ iOS17 Sonoma ] 5 tests under http/wpt/mediarecorder are constantly crashing. rdar://116267156 https://bugs.webkit.org/show_bug.cgi?id=262425 Unreviewed test gardening. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268685@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25fb6b: Have PluginDocument express its style through a st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25fb6b6518a0ba1f00dbdbeb0b630639db1b8aa0 https://github.com/WebKit/WebKit/commit/25fb6b6518a0ba1f00dbdbeb0b630639db1b8aa0 Author: Simon Fraser Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/html/PluginDocument.cpp Log Message: --- Have PluginDocument express its style through a stylesheet rather than inline style https://bugs.webkit.org/show_bug.cgi?id=262408 rdar://116257438 Reviewed by Tim Horton and Richard Robinson. In the plug-in document, create a `` element which contains a `
[webkit-changes] [WebKit/WebKit] 3c8f45: visionOS: Upstream SUPPORTED_PLATFORMS and TARGETE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c8f4550bd32758a4a14d552528d3226514684b6 https://github.com/WebKit/WebKit/commit/3c8f4550bd32758a4a14d552528d3226514684b6 Author: Tim Horton Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M PerformanceTests/DecoderTest/Configurations/Base.xcconfig M PerformanceTests/MediaTime/Configurations/Base.xcconfig M Source/JavaScriptCore/Configurations/Base.xcconfig M Source/ThirdParty/ANGLE/Configurations/Base.xcconfig M Source/ThirdParty/gtest/xcode/Config/General.xcconfig M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig M Source/WTF/Configurations/Base.xcconfig M Source/WebCore/Configurations/Base.xcconfig M Source/WebCore/PAL/Configurations/Base.xcconfig M Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig M Source/WebGPU/Configurations/Base.xcconfig M Source/WebInspectorUI/Configurations/Base.xcconfig M Source/WebKit/Configurations/Base.xcconfig M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig M Source/WebKit/SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig M Source/WebKitLegacy/mac/Configurations/Base.xcconfig M Source/bmalloc/Configurations/Base.xcconfig M Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig M Tools/MiniBrowser/Configurations/Base.xcconfig M Tools/MiniBrowserSwiftUI/Configurations/Base.xcconfig M Tools/MobileMiniBrowser/Configurations/Base.xcconfig M Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Configurations/Base.xcconfig M Tools/WebGPUPlayground/Configurations/Base.xcconfig M Tools/WebKitTestRunner/Configurations/Base.xcconfig Log Message: --- visionOS: Upstream SUPPORTED_PLATFORMS and TARGETED_DEVICE_FAMILY changes https://bugs.webkit.org/show_bug.cgi?id=262422 rdar://116264424 Reviewed by Dean Jackson. * PerformanceTests/DecoderTest/Configurations/Base.xcconfig: * PerformanceTests/MediaTime/Configurations/Base.xcconfig: * Source/JavaScriptCore/Configurations/Base.xcconfig: * Source/ThirdParty/ANGLE/Configurations/Base.xcconfig: * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: * Source/WTF/Configurations/Base.xcconfig: * Source/WebCore/Configurations/Base.xcconfig: * Source/WebCore/PAL/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig: * Source/WebGPU/Configurations/Base.xcconfig: * Source/WebInspectorUI/Configurations/Base.xcconfig: * Source/WebKit/Configurations/Base.xcconfig: * Source/WebKit/Configurations/BaseExtension.xcconfig: * Source/WebKit/SwiftOverlay/Configurations/WebKitSwiftOverlay.xcconfig: * Source/WebKit/SwiftOverlay/Configurations/WebKitSwiftOverlayTests.xcconfig: * Source/WebKitLegacy/mac/Configurations/Base.xcconfig: * Source/bmalloc/Configurations/Base.xcconfig: * Tools/DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: * Tools/MiniBrowser/Configurations/Base.xcconfig: * Tools/MiniBrowserSwiftUI/Configurations/Base.xcconfig: * Tools/MobileMiniBrowser/Configurations/Base.xcconfig: * Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Configurations/Base.xcconfig: * Tools/WebGPUPlayground/Configurations/Base.xcconfig: * Tools/WebKitTestRunner/Configurations/Base.xcconfig: Canonical link: https://commits.webkit.org/268683@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e36c7a: AX: Update accessibility/w3c-svg-name-calculation....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e36c7a7ca9f6647635c650df884b29b0f2102924 https://github.com/WebKit/WebKit/commit/e36c7a7ca9f6647635c650df884b29b0f2102924 Author: Andres Gonzalez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/accessibility/w3c-svg-name-calculation.html M LayoutTests/platform/glib/accessibility/w3c-svg-name-calculation-expected.txt M LayoutTests/platform/mac/accessibility/w3c-svg-name-calculation-expected.txt Log Message: --- AX: Update accessibility/w3c-svg-name-calculation.html to run faster. https://bugs.webkit.org/show_bug.cgi?id=262390 Reviewed by Tyler Wilcock. This test runs slowly, particularly in ITM, for the number of debug() calls. This cuts down the execution time by bufferring the output and writing it out at the end. Some code cleanup and update. * LayoutTests/accessibility/w3c-svg-name-calculation.html: * LayoutTests/platform/glib/accessibility/w3c-svg-name-calculation-expected.txt: * LayoutTests/platform/mac/accessibility/w3c-svg-name-calculation-expected.txt: Canonical link: https://commits.webkit.org/268682@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3879b0: Rebaseline two tracking prevention tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3879b0dcdb487af27e6daa50d22e975ef5f5f98b https://github.com/WebKit/WebKit/commit/3879b0dcdb487af27e6daa50d22e975ef5f5f98b Author: Matthew Finkel Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt M LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html M LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt M LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html A LayoutTests/platform/glib/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt A LayoutTests/platform/glib/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt A LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt A LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Rebaseline two tracking prevention tests https://bugs.webkit.org/show_bug.cgi?id=261989 rdar://115921610 Reviewed by John Wilander. In 251397@main, we aligned tracking prevention's client side cookie cap with other script-writable storage. Now let's update the macOS test expectations and re-enabled the tests. * LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt: * LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html: * LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt: * LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html: * LayoutTests/platform/glib/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt: Added. * LayoutTests/platform/glib/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt: Added. * LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt: Copied from LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-expected.txt. * LayoutTests/platform/mac-monterey/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt: Copied from LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-expected.txt. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268681@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbb5cd: Use `HashSet>` instead of `WeakH...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbb5cdba4811fd1d12b208c90cf2327de50a56ed https://github.com/WebKit/WebKit/commit/cbb5cdba4811fd1d12b208c90cf2327de50a56ed Author: Chris Dumez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h Log Message: --- Use `HashSet>` instead of `WeakHashSet` for Document::m_ranges https://bugs.webkit.org/show_bug.cgi?id=262407 Reviewed by Brent Fulgham. Use `HashSet>` instead of `WeakHashSet` for Document::m_ranges. The Range destructor takes care of removing itself from Document::m_ranges already so we don't need a WeakPtr. Using CheckedRef here is slightly more efficient. * Source/WebCore/dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::updateRangesAfterChildrenChanged): (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::parentlessNodeMovedToNewDocument): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit): * Source/WebCore/dom/Document.h: Canonical link: https://commits.webkit.org/268680@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de3b4d: visionOS: Fix the build for all BaseExtension-deri...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de3b4d47e4f79fa256c4808bd66691b0312ade25 https://github.com/WebKit/WebKit/commit/de3b4d47e4f79fa256c4808bd66691b0312ade25 Author: Tim Horton Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/Configurations/BaseExtension.xcconfig Log Message: --- visionOS: Fix the build for all BaseExtension-derived targets https://bugs.webkit.org/show_bug.cgi?id=262414 rdar://116261778 Reviewed by Dean Jackson. * Source/WebKit/Configurations/BaseExtension.xcconfig: Don't specify SUPPORTED_PLATFORMS here because: A) we get it via inheritance B) this comes *after* we import LocalOverrides (unlike Base.xcconfig, which is *before*), and thus overrides LocalOverrides' overrides, causing LocalOverrides to be unable to add the visionOS platform to SUPPORTED_PLATFORMS, and causing Xcode to choose a different platform to build for, at random (and, notably, one which it did not build the rest of WebKit for). Canonical link: https://commits.webkit.org/268679@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4da3e: REGRESSION (268511@main): Crash under ~LegacyRende...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4da3e2a9e8d553f4823a6c34e99aa4875a4414e https://github.com/WebKit/WebKit/commit/b4da3e2a9e8d553f4823a6c34e99aa4875a4414e Author: Chris Dumez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/page/Page.h Log Message: --- REGRESSION (268511@main): Crash under ~LegacyRenderSVGRoot() when loading nytimes.com https://bugs.webkit.org/show_bug.cgi?id=262413 rdar://116257845 Unreviewed, partial revert of 268511@main to address the crash on nytimes.com. * Source/WebCore/page/Page.h: Canonical link: https://commits.webkit.org/268678@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d206d1: Add _WKWebExtensionAction API to support web exten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d206d1764428e6838dd3240c7868c0762cd5541d https://github.com/WebKit/WebKit/commit/d206d1764428e6838dd3240c7868c0762cd5541d Author: Timothy Hatcher Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/Modules/OSX_Private.modulemap M Source/WebKit/Modules/iOS_Private.modulemap M Source/WebKit/Shared/API/APIObject.h M Source/WebKit/Shared/Cocoa/APIObject.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h A Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h A Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm A Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionActionInternal.h A Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionActionPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h A Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h A Source/WebKit/UIProcess/Extensions/WebExtensionAction.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewInspection.mm M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.h M Tools/TestWebKitAPI/cocoa/TestWebExtensionsDelegate.mm M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h Log Message: --- Add _WKWebExtensionAction API to support web extension actions. https://bugs.webkit.org/show_bug.cgi?id=262388 Reviewed by Brady Eidson. Added the initial support for action via _WKWebExtensionAction. This supports popups and all the properties of action that are supported by Safari. Only manifest dat is used currently, but support for per-tab action changes is supported and will be followed up by the JS API in https://webkit.org/b/260154. * Source/WebKit/Modules/OSX_Private.modulemap: * Source/WebKit/Modules/iOS_Private.modulemap: * Source/WebKit/Shared/API/APIObject.h: * Source/WebKit/Shared/Cocoa/APIObject.mm: (API::Object::newObject): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h: Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm: Added. (-[_WKWebExtensionAction dealloc]): (-[_WKWebExtensionAction isEqual:]): (-[_WKWebExtensionAction webExtensionContext]): (-[_WKWebExtensionAction associatedTab]): (-[_WKWebExtensionAction iconForSize:]): (-[_WKWebExtensionAction displayLabel]): (-[_WKWebExtensionAction badgeText]): (-[_WKWebExtensionAction isEnabled]): (-[_WKWebExtensionAction hasPopup]): (-[_WKWebExtensionAction popupWebView]): (-[_WKWebExtensionAction closePopupWebView]): (-[_WKWebExtensionAction _apiObject]): (-[_WKWebExtensionAction _webExtensionAction]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionActionInternal.h: Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionActionPrivate.h: Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext hasPermission:inTab:]): (-[_WKWebExtensionContext hasAccessToURL:inTab:]): (-[_WKWebExtensionContext permissionStatusForPermission:inTab:]): (-[_WKWebExtensionContext permissionStatusForURL:inTab:]): (-[_WKWebExtensionContext permissionStatusForMatchPattern:inTab:]): (-[_WKWebExtensionContext actionForTab:]): (-[_WKWebExtensionContext performActionForTab:]): (-[_WKWebExtensionContext userGesturePerformedInTab:]): (-[_WKWebExtensionContext hasActiveUserGestureInTab:]): (-[_WKWebExtensionContext clearUserGestureInTab:]): (toImplNullable): (-[_WKWebExtensionContext didActivateTab:previousActiveTab:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h: * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: Added. (-[_WKWebExtensionActionWebViewDelegate initWithWebExtensionAction:]): (-[_WKWebExtensionActionWebViewDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): (-[_WKWebExtensionActionWebViewDelegate webViewWebContentProcessDidTerminate:]): (-[_WKWebExtensionActionWebViewDelegate webViewDidClose:]): (-[_WKWebExtensionActionWebView initWithFrame:configuration:webExtensionAction:]): (-[_WKWebExtensionActionWebView invalidateIn
[webkit-changes] [WebKit/WebKit] 0d35c9: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk2 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d35c9b0eb60ca59d5af5605b860da65f42bdfcc https://github.com/WebKit/WebKit/commit/0d35c9b0eb60ca59d5af5605b860da65f42bdfcc Author: Karl Rackler Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk2 ] Flaky crash under com.apple.WebKit.WebContent.Development terminated https://bugs.webkit.org/show_bug.cgi?id=262411 rdar://116260837 Unreviewed test gardening. Add test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268676@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 372b9b: [GTK][WPE] WPT test html/semantics/embedded-conten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 372b9b336e3fa10d51240e52e0fb490fa21dbfa8 https://github.com/WebKit/WebKit/commit/372b9b336e3fa10d51240e52e0fb490fa21dbfa8 Author: Amanda Falke Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] WPT test html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-escalate-privileges.tentative.sub.window.html is a consistent failure Unreviewed test gardening. This test is a consistent failure in GTK and WPE; marked as such. Note that there are existing failing expectations in ios-wk2, mac-wk1 and mac-wk2 for this test as well. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/268675@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 74d5f7: Generate BlobPart serializer (with some minor refa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74d5f782ae368d11eb26bdb832be4bc5950121a3 https://github.com/WebKit/WebKit/commit/74d5f782ae368d11eb26bdb832be4bc5950121a3 Author: Brady Eidson Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/platform/network/BlobPart.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Generate BlobPart serializer (with some minor refactoring) https://bugs.webkit.org/show_bug.cgi?id=262396 rdar://116253299 Reviewed by Andy Estes. Love taking various informal "this should've been a variant<>" patterns and making them actually be variants. * Source/WebCore/platform/network/BlobPart.h: (WebCore::BlobPart::BlobPart): (WebCore::BlobPart::type const): (WebCore::BlobPart::moveData): (WebCore::BlobPart::url const): (WebCore::BlobPart::detachFromCurrentThread): (WebCore::BlobPart::data const): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/268674@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15b1d4: Enable CSS Highlights by default.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15b1d4e506419059a6b7cf0a88fd1138ec0bc63a https://github.com/WebKit/WebKit/commit/15b1d4e506419059a6b7cf0a88fd1138ec0bc63a Author: Megan Gardner Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Enable CSS Highlights by default. https://bugs.webkit.org/show_bug.cgi?id=262402 rdar://116255516 Reviewed by Tim Horton and Aditya Keerthi. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/268673@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bf860: Update sandbox for refactored media services
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bf860bb447c6724570b7f86702b3bad1b5a49f3 https://github.com/WebKit/WebKit/commit/3bf860bb447c6724570b7f86702b3bad1b5a49f3 Author: Brent Fulgham Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- Update sandbox for refactored media services https://bugs.webkit.org/show_bug.cgi?id=262400 Reviewed by Per Arne Vollan. Adopt finer-grained media services on relevant platforms. This doesn't expose new functionality, it's just adopting these more specific endpoints. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/268672@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e40427: [JSC] Duplicate lexical bindings should only be al...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4042719d2be336648b0e8f374903c07727ee5eb https://github.com/WebKit/WebKit/commit/e4042719d2be336648b0e8f374903c07727ee5eb Author: Alexey Shvayka Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/test262/expectations.yaml M LayoutTests/js/parser-syntax-check-expected.txt M LayoutTests/js/script-tests/parser-syntax-check.js M Source/JavaScriptCore/parser/Parser.h M Source/JavaScriptCore/parser/VariableEnvironment.h Log Message: --- [JSC] Duplicate lexical bindings should only be allowed for FunctionDeclarations https://bugs.webkit.org/show_bug.cgi?id=262394 Reviewed by Yusuke Suzuki. Per Annex B [1], duplicate lexical declarations are only allowed in sloppy mode and when bound by FunctionDeclaration parse nodes. Async / generator functions are defined using different nodes [2]. This patch introduces IsFunctionDeclaration bit to VariableEnvironmentEntry to differentiate pre-ES6 functions from generator / async functions and throw early errors when duplicate declarations include the latter ones. While the only observable change is: ```diff - if (strictMode() || !addResult.iterator->value.isFunction()) + if (strictMode() || !addResult.iterator->value.isFunctionDeclaration() || !isFunctionDeclaration) result |= DeclarationResult::InvalidDuplicateDeclaration; } + if (isFunctionDeclaration) + addResult.iterator->value.setIsFunctionDeclaration(); ``` isFunctionDeclaration parameter is only revelant when declareFunction() if called on a lexical scope, and the function has another boolean parameter that significantly impacts its behavior, so this patch also splits declareFunction() into two methods rather than degrading code quality even further. Aligns JSC with V8 and SpiderMonkey. [1]: https://tc39.es/ecma262/#sec-block-duplicates-allowed-static-semantics [2]: https://tc39.es/ecma262/#prod-GeneratorDeclaration * JSTests/test262/expectations.yaml: Mark 30 tests as passing. * LayoutTests/js/parser-syntax-check-expected.txt: * LayoutTests/js/script-tests/parser-syntax-check.js: * Source/JavaScriptCore/parser/Parser.h: (JSC::Scope::declareFunctionAsVar): (JSC::Scope::declareFunctionAsLet): (JSC::Parser::declareFunction): (JSC::Scope::declareFunction): Deleted. * Source/JavaScriptCore/parser/VariableEnvironment.h: (JSC::VariableEnvironmentEntry::isFunctionDeclaration const): (JSC::VariableEnvironmentEntry::setIsFunctionDeclaration): Canonical link: https://commits.webkit.org/268671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53ed98: [UnifiedPDF] Get basic PDF page layout working
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53ed985286a97c4ae32b699699de9eb7ff10b869 https://github.com/WebKit/WebKit/commit/53ed985286a97c4ae32b699699de9eb7ff10b869 Author: Simon Fraser Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm A Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h A Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.h M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h Log Message: --- [UnifiedPDF] Get basic PDF page layout working https://bugs.webkit.org/show_bug.cgi?id=262389 rdar://116249928 Reviewed by Tim Horton and Richard Robinson. Introduce PDFDocumentLayout for UnifiedPDF, which contains the logic to lay out the PDF pages, taking page size, rotation and the layout mode into account. Implement basic single column layout. Fix PDF page drawing to flip the context when drawing pages. Hook up an invalidate code path, so that we can repaint the plugin when the PDF loads. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::invalidateRect): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h: Added. (WebKit::PDFDocumentLayout::pdfDocument const): (WebKit::PDFDocumentLayout::layoutSize const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm: Added. (WebKit::PDFDocumentLayout::documentMargin): (WebKit::PDFDocumentLayout::pageMargin): (WebKit::PDFDocumentLayout::setPDFDocument): (WebKit::PDFDocumentLayout::hasPDFDocument const): (WebKit::PDFDocumentLayout::pageAtIndex const): (WebKit::PDFDocumentLayout::updateGeometry): (WebKit::PDFDocumentLayout::layoutPages): (WebKit::PDFDocumentLayout::layoutSingleColumn): (WebKit::PDFDocumentLayout::layoutTwoUpColumn): (WebKit::PDFDocumentLayout::pageCount const): (WebKit::PDFDocumentLayout::boundsForPageAtIndex const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::createPDFDocument): (WebKit::UnifiedPDFPlugin::installPDFDocument): (WebKit::UnifiedPDFPlugin::paint): * Source/WebKit/WebProcess/Plugins/PluginView.h: * Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h: Canonical link: https://commits.webkit.org/268670@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d5673: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma debug...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d567328df090af6800a5f79f7c308e69bd6c1cb https://github.com/WebKit/WebKit/commit/8d567328df090af6800a5f79f7c308e69bd6c1cb Author: Karl Rackler Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION ( Sonoma?): [ Sonoma debug wk2 ] ASSERTION FAILED: Unhandled message GPUConnectionToWebProcess_ReleaseGraphicsContextGL to 0 https://bugs.webkit.org/show_bug.cgi?id=262401 rdar://116254494 Unreviewed test gardening. Add test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/268669@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ea306: [JSC][armv7] Skip wasm/stress/simple-inline-stackt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ea306f30d73877433b5545e71f77fd1e64b1d9d https://github.com/WebKit/WebKit/commit/9ea306f30d73877433b5545e71f77fd1e64b1d9d Author: Joseph Griego Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js Log Message: --- [JSC][armv7] Skip wasm/stress/simple-inline-stacktrace-with-catch.js https://bugs.webkit.org/show_bug.cgi?id=262136 Reviewed by Yusuke Suzuki and Justin Michaud. This test is failing after https://commits.webkit.org/267656@main but we haven't been able to identify exactly what's wrong yet; skip in the interest of getting CI green, the extra stack frame seems somewhat benign. [Note that simple-inline-stacktrace.js is already skipped as of this commit] * JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js: Canonical link: https://commits.webkit.org/268668@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11a913: Add WKWebViewConfiguration to _WKWebExtensionContr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11a9133692954ea702fcef2e32bd890b4ae8a3a3 https://github.com/WebKit/WebKit/commit/11a9133692954ea702fcef2e32bd890b4ae8a3a3 Author: Timothy Hatcher Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm R Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfiguration.mm A Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtension.h M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.h M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIPortCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionControllerConfiguration.mm Log Message: --- Add WKWebViewConfiguration to _WKWebExtensionControllerConfiguration. https://webkit.org/b/262381 rdar://problem/116243665 Reviewed by Brian Weinstein. Clients will need to provide some base defaults for extension web views, like what process pool to use. This is best to do via a WKWebViewConfiguration property on _WKWebExtensionControllerConfiguration. Also fix some small drive-by issues. * Use protocolHostAndPort() instead of truncatedForUseAsBase() for the baseURL maps since truncatedForUseAsBase() will include the path still and this breaks some extensions that use directories in their paths. * Added relatedWebView to the configuration in prep for action popups. * Added a webExtensionController() helper method to WebPageProxy to return the strong or weak controller as a convenience. * Fixed an ASSERT in WebExtensionAPIPort that would fire on garbage collect if the port was already disconnected and removed. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm: (-[_WKWebExtensionControllerConfiguration encodeWithCoder:]): Encode webViewConfiguration. (-[_WKWebExtensionControllerConfiguration initWithCoder:]): Set webViewConfiguration. (-[_WKWebExtensionControllerConfiguration webViewConfiguration]): Added. (-[_WKWebExtensionControllerConfiguration setWebViewConfiguration:]): Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMessagePort.mm: (-[_WKWebExtensionMessagePort sendMessage:completionHandler:]): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::load): (WebKit::WebExtensionController::unload): (WebKit::WebExtensionController::extensionContext const): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm: Renamed from WebExtensionControllerConfiguration.mm to match conventions. (WebKit::WebExtensionControllerConfiguration::createStorageDirectoryPath): (WebKit::WebExtensionControllerConfiguration::copy const): (WebKit::WebExtensionControllerConfiguration::webViewConfiguration): Added. * Source/WebKit/UIProcess/Extensions/WebExtension.h: * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: * Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.cpp: (WebKit::WebExtensionControllerConfiguration::operator== const): (WebKit::WebExtensionControllerConfiguration::copy const): Deleted. * Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h: (WebKit::WebExtensionControllerConfiguration::setWebViewConfiguration): Added. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::webExtensionController): Added. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.cpp: (WebKit::WebExtensionControllerProxy::getOrCreate): (WebKit::WebExtension
[webkit-changes] [WebKit/WebKit] 613ac6: AX: Add debug description method for accessibility...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 613ac6287437622bdebdc84eadf4e068811b4bf4 https://github.com/WebKit/WebKit/commit/613ac6287437622bdebdc84eadf4e068811b4bf4 Author: Tyler Wilcock Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h Log Message: --- AX: Add debug description method for accessibility objects https://bugs.webkit.org/show_bug.cgi?id=262356 rdar://problem/116220179 Reviewed by Chris Fleizach. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::dbg const): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::dbg const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: Canonical link: https://commits.webkit.org/268666@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8ad41: Fix build issue when !ENABLE(FILTERS_LEVEL_2)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8ad412976d94ba6f1d0d1cceaea43e9a05ce0d8 https://github.com/WebKit/WebKit/commit/c8ad412976d94ba6f1d0d1cceaea43e9a05ce0d8 Author: Stephan Szabo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- Fix build issue when !ENABLE(FILTERS_LEVEL_2) https://bugs.webkit.org/show_bug.cgi?id=262384 Unreviewed build fix Add enable check around use of cssUnprefixedBackdropFilterEnabled * Source/WebCore/rendering/RenderLayer.cpp: Canonical link: https://commits.webkit.org/268665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 830fee: [JSC] Temporarily disable Call-Ret IC for iOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 830feef8951306e6aac326c255c06bfca6054354 https://github.com/WebKit/WebKit/commit/830feef8951306e6aac326c255c06bfca6054354 Author: Yusuke Suzuki Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/JavaScriptCore/bytecode/InlineAccess.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGJITCode.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JITCall.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/jit/JITPropertyAccess.cpp M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Temporarily disable Call-Ret IC for iOS https://bugs.webkit.org/show_bug.cgi?id=262378 rdar://116241225 Reviewed by Alexey Shvayka. We found that jump-based approach is faster only on iOS CPUs. For now, temporarily use jump-based approach on iOS, and continue doing handlerIC work only for macOS. * Source/JavaScriptCore/bytecode/InlineAccess.cpp: (JSC::InlineAccess::resetStubAsJumpInAccess): (JSC::InlineAccess::resetStubAsJumpInAccessNotUsingInlineAccess): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::useHandlerIC const): (JSC::InlineCacheCompiler::succeed): (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::emitProxyObjectAccess): (JSC::InlineCacheCompiler::regenerate): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: (JSC::InlineCacheCompiler::InlineCacheCompiler): * Source/JavaScriptCore/bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::addAccessCase): (JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo): (JSC::StructureStubInfo::initializeFromDFGUnlinkedStructureStubInfo): * Source/JavaScriptCore/bytecode/StructureStubInfo.h: * Source/JavaScriptCore/dfg/DFGJITCode.h: * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::link): * Source/JavaScriptCore/jit/JITCall.cpp: (JSC::JIT::emitSlow_op_iterator_open): (JSC::JIT::emitSlow_op_iterator_next): * Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp: (JSC::JITInlineCacheGenerator::generateBaselineDataICFastPath): (JSC::generateGetByIdInlineAccessBaselineDataIC): (JSC::generatePutByIdInlineAccessBaselineDataIC): (JSC::generateInByIdInlineAccessBaselineDataIC): * Source/JavaScriptCore/jit/JITInlineCacheGenerator.h: (JSC::JITInlineCacheGenerator::reportBaselineDataICSlowPathBegin): * Source/JavaScriptCore/jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_instanceof): * Source/JavaScriptCore/jit/JITPropertyAccess.cpp: (JSC::JIT::generateGetByValSlowCase): (JSC::JIT::emitSlow_op_get_private_name): (JSC::JIT::emitSlow_op_set_private_brand): (JSC::JIT::emitSlow_op_check_private_brand): (JSC::JIT::generatePutByValSlowCase): (JSC::JIT::emitSlow_op_put_private_name): (JSC::JIT::emitSlow_op_del_by_id): (JSC::JIT::emitSlow_op_del_by_val): (JSC::JIT::emitSlow_op_try_get_by_id): (JSC::JIT::emitSlow_op_get_by_id_direct): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id_with_this): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::emitSlow_op_in_by_id): (JSC::JIT::emitSlow_op_in_by_val): (JSC::JIT::emitHasPrivateSlow): (JSC::JIT::emitSlow_op_get_by_val_with_this): * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/268664@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 13307f: AX: accessibility/video-element-url-attribute.html...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 13307fb298e4d06b8d29d12668b44571818103b2 https://github.com/WebKit/WebKit/commit/13307fb298e4d06b8d29d12668b44571818103b2 Author: Tyler Wilcock Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/accessibility/video-element-url-attribute-expected.txt M LayoutTests/accessibility/video-element-url-attribute.html Log Message: --- AX: accessibility/video-element-url-attribute.html is a flakey timeout https://bugs.webkit.org/show_bug.cgi?id=262355 rdar://problem/116219239 Reviewed by Chris Fleizach. Seems like the readyState DOM API is flakey in layout tests, so switch to the accessibility-helper.js expectAsync function. We need to use expectAsync to wait asynchronously for the video to load in order to return the correct URL (which is what the readyState check tried to do before). * LayoutTests/TestExpectations: Remove timeout expectation. * LayoutTests/accessibility/video-element-url-attribute-expected.txt: * LayoutTests/accessibility/video-element-url-attribute.html: Re-write test. Canonical link: https://commits.webkit.org/268663@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe20f1: Improve rejection test for character-based SVG tex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe20f19cb92daa371c6c1f010f0e71e0c084e5b6 https://github.com/WebKit/WebKit/commit/fe20f19cb92daa371c6c1f010f0e71e0c084e5b6 Author: Ahmad Saleem Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/rendering/svg/SVGTextQuery.cpp Log Message: --- Improve rejection test for character-based SVG text queries https://bugs.webkit.org/show_bug.cgi?id=262373 Reviewed by Chris Dumez. Partial Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=177148 Perform an intersection of the involved ranges to reject fragments early, while still avoiding calls to mapStartEndPositionsIntoFragmentCoordinates. This gives a moderate speed-up - a few percent on test case. * Source/WebCore/rendering/svg/SVGTextQuery.cpp: (SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates): Canonical link: https://commits.webkit.org/268656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5381f2: Devirtualize more RenderObject type checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5381f2a7b3c66abac6a3d4e5d8694902daf45998 https://github.com/WebKit/WebKit/commit/5381f2a7b3c66abac6a3d4e5d8694902daf45998 Author: Chris Dumez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/editing/ReplaceSelectionCommand.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderFlexibleBox.cpp M Source/WebCore/rendering/RenderFlexibleBox.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderTable.h M Source/WebCore/rendering/RenderTextControl.cpp M Source/WebCore/rendering/RenderTextControl.h M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- Devirtualize more RenderObject type checks https://bugs.webkit.org/show_bug.cgi?id=262372 Reviewed by Ryosuke Niwa. Devirtualize more RenderObject type checks. I selected a few type checks that showed in profiles. * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForFlexLayout): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObject): (WebCore::RenderBlock::paintObject): * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::RenderBlockFlow): (WebCore::RenderBlockFlow::willCreateColumns const): (WebCore::RenderBlockFlow::adjustForUnsplittableChild): * Source/WebCore/rendering/RenderBlockFlow.h: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::isStretchingColumnFlexItem const): (WebCore::RenderBox::sizesLogicalWidthToFitContent const): (WebCore::RenderBox::computeInlineDirectionMargins const): (WebCore::RenderBox::cacheIntrinsicContentLogicalHeightForFlexItem const): * Source/WebCore/rendering/RenderBox.h: (WebCore::RenderBox::isFlexItem const): * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::isRenderFlexibleBox const): (WebCore::RenderElement::isRenderTextControl const): (WebCore::RenderObject::isRenderFlexibleBox const): (WebCore::RenderObject::isRenderTextControl const): * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::RenderFlexibleBox): * Source/WebCore/rendering/RenderFlexibleBox.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterLayout): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isFlexibleBoxIncludingDeprecated const): (WebCore::RenderObject::isTable const): (WebCore::RenderObject::isTextControl const): Deleted. (WebCore::RenderObject::isFlexibleBox const): Deleted. * Source/WebCore/rendering/RenderTable.h: * Source/WebCore/rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): * Source/WebCore/rendering/RenderTextControl.h: * Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp: (WebCore::RenderTreeBuilder::Block::attachIgnoringContinuation): * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::textRendererIsNeeded): Canonical link: https://commits.webkit.org/268662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6cba78: Generate a handful of serializers from WebCoreArgu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6cba786901b85de12e880a112b51730f7273d384 https://github.com/WebKit/WebKit/commit/6cba786901b85de12e880a112b51730f7273d384 Author: Brady Eidson Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Generate a handful of serializers from WebCoreArgumentCoders.h https://bugs.webkit.org/show_bug.cgi?id=262379 rdar://116242048 Reviewed by Alex Christensen. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/268661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 306860: Highlights are not repainted if associated live ra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 306860296d33ebc428b319f6d705faa3a51f6e33 https://github.com/WebKit/WebKit/commit/306860296d33ebc428b319f6d705faa3a51f6e33 Author: Megan Gardner Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: A LayoutTests/fast/repaint/highlight-paint-after-range-change-expected.txt A LayoutTests/fast/repaint/highlight-paint-after-range-change.html M Source/WebCore/Modules/highlight/Highlight.cpp M Source/WebCore/Modules/highlight/Highlight.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/Range.h Log Message: --- Highlights are not repainted if associated live ranges are changed. https://bugs.webkit.org/show_bug.cgi?id=262168 rdar://116108148 Reviewed by Wenson Hsieh. When a range is changed, we need to repaint the previous and the new range. Fortunately, we already had a mechanism to get Positions from the ranges so that we have the information we need at paint time. We can use these stale positions to know what the range was before updating, and repaint the old range, as well as the new range. Also a rename for more clarity around setting flags for highlights in Range. * LayoutTests/fast/repaint/highlight-paint-after-range-change-expected.txt: Added. * LayoutTests/fast/repaint/highlight-paint-after-range-change.html: Added. * Source/WebCore/Modules/highlight/Highlight.h: (WebCore::HighlightRange::HighlightRange): * Source/WebCore/dom/Document.cpp: (WebCore::Document::collectHighlightRangesFromRegister): (WebCore::repaintRange): (WebCore::Document::updateHighlightPositions): (WebCore::Document::collectRangeDataFromRegister): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/dom/Range.cpp: (WebCore::Range::updateAssociatedHighlight): (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::nodeChildrenChanged): (WebCore::Range::nodeChildrenWillBeRemoved): (WebCore::Range::nodeWillBeRemoved): (WebCore::Range::textInserted): (WebCore::Range::textRemoved): (WebCore::Range::textNodesMerged): (WebCore::Range::textNodeSplit): * Source/WebCore/dom/Range.h: Canonical link: https://commits.webkit.org/268660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38d1d7: Optimize LocalFrameView::incrementVisuallyNonEmpty...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38d1d72e3b8a4123450e4f2c2a2966bf83a66c01 https://github.com/WebKit/WebKit/commit/38d1d72e3b8a4123450e4f2c2a2966bf83a66c01 Author: Chris Dumez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h Log Message: --- Optimize LocalFrameView::incrementVisuallyNonEmptyCharacterCount() https://bugs.webkit.org/show_bug.cgi?id=262368 Reviewed by Ryosuke Niwa. Optimize LocalFrameView::incrementVisuallyNonEmptyCharacterCount(): - Add inline fast path when we've already reached the threshold. - Templatize nonWhitespaceLength() to avoid repeated branching on is8Bit() inside String::operator[]. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::nonWhitespaceLength): (WebCore::LocalFrameView::incrementVisuallyNonEmptyCharacterCountSlowCase): (WebCore::LocalFrameView::incrementVisuallyNonEmptyCharacterCount): Deleted. * Source/WebCore/page/LocalFrameView.h: (WebCore::LocalFrameView::incrementVisuallyNonEmptyCharacterCount): Canonical link: https://commits.webkit.org/268659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3febd4: ImageBitmap resize quality "low" is resolved to in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3febd45283e31b09b8a63c9739535f7109713eb2 https://github.com/WebKit/WebKit/commit/3febd45283e31b09b8a63c9739535f7109713eb2 Author: Kimmo Kinnunen Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/html/ImageBitmap.cpp Log Message: --- ImageBitmap resize quality "low" is resolved to incorrect implementation value https://bugs.webkit.org/show_bug.cgi?id=262361 rdar://116228900 Reviewed by Mike Wyrzykowski. Passing InterpolationQuality::Default as ImagePaintingOptions means "use context default", e.g. the same as if no option would be passed. The context default is typically "Default" which means "Use image should interpolate ? High : None" for Cocoa, "Medium" in Cairo. Use Low if the author asks for Low. * Source/WebCore/html/ImageBitmap.cpp: (WebCore::interpolationQualityForResizeQuality): Canonical link: https://commits.webkit.org/268658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 127b49: AX: aria-description/ariaDescription IDL harness t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 127b493dc96160d84b6fc59b22eb14468129f93a https://github.com/WebKit/WebKit/commit/127b493dc96160d84b6fc59b22eb14468129f93a Author: Ahmad Saleem Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/accessibility/ARIA-reflection-expected.txt M LayoutTests/accessibility/ARIA-reflection.html M LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-attribute-reflection-expected.txt M LayoutTests/imported/w3c/web-platform-tests/wai-aria/idlharness.window-expected.txt M Source/WebCore/accessibility/AriaAttributes.idl Log Message: --- AX: aria-description/ariaDescription IDL harness tests failing https://bugs.webkit.org/show_bug.cgi?id=257141 rdar://problem/109668891 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Blink / Chromium, Gecko / Firefox and Web-Specification [1]. [1] https://w3c.github.io/aria/#idl-interface This PR is to add missing 'ariaDescription' in IDL file to fix failing tests. * Source/WebCore/accessibility/AriaAttributes.idl: * LayoutTests/imported/w3c/web-platform-tests/html/dom/aria-attribute-reflection-expected.txt: Rebaselined * LayoutTests/imported/w3c/web-platform-tests/wai-aria/idlharness.window-expected.txt: Rebaselined * LayoutTests/accessibility/ARIA-reflection.html: Rebaselined * LayoutTests/accessibility/ARIA-reflection-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/268657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d29c2: Stop using -_contextMenuInteraction:styleForMenuWi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d29c2a7ed7792a2af1fdd9270eb9c86aa89d725 https://github.com/WebKit/WebKit/commit/5d29c2a7ed7792a2af1fdd9270eb9c86aa89d725 Author: Wenson Hsieh Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/SourcesCocoa.txt A Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.h A Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.mm M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm M Source/WebKit/UIProcess/mac/WKTextFinderClient.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Stop using -_contextMenuInteraction:styleForMenuWithConfiguration: in WKFileUploadPanel https://bugs.webkit.org/show_bug.cgi?id=262354 Reviewed by Richard Robinson. Introduce the `CompactContextMenuPresenter` helper class, which is used to present or dismiss a UIContextMenu using compact layout; additionally, deploy this helper class in `WKFileUploadPanel` to eliminate uses of both `-_contextMenuInteraction:styleForMenuWithConfiguration:` and `_UIContextMenuLayoutCompactMenu`. See below for more details. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.h: Added. * Source/WebKit/UIProcess/ios/CompactContextMenuPresenter.mm: Added. Implement a new helper class that encapsulates a hidden and non-interactable `UIButton`, as well as its corresponding `UIContextMenuInteraction`. This helper class is constructed with a context menu interaction delegate, to which the helper class forwards delegate method calls; this allows the delegate to influence the hidden button's compact context menu as if it were its own, but defers the compact layout to the button itself. This allows a `CompactContextMenuPresenter` to (functionally) act as a drop-in replacement for an actual `UIContextMenuInteraction`. (-[WKCompactContextMenuPresenterButton contextMenuInteraction:configurationForMenuAtLocation:]): (-[WKCompactContextMenuPresenterButton contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): (-[WKCompactContextMenuPresenterButton contextMenuInteraction:willDisplayMenuForConfiguration:animator:]): (-[WKCompactContextMenuPresenterButton contextMenuInteraction:willEndForConfiguration:animator:]): Forward delegate calls to the given external context menu delegate if applicable (see `WKFileUploadPanel` below). (WebKit::CompactContextMenuPresenter::CompactContextMenuPresenter): (WebKit::CompactContextMenuPresenter::~CompactContextMenuPresenter): (WebKit::CompactContextMenuPresenter::present): (WebKit::CompactContextMenuPresenter::interaction const): (WebKit::CompactContextMenuPresenter::dismiss): * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel dealloc]): Replace the existing `UIContextMenuInteraction`, `_documentContextMenuInteraction`, with a `CompactContextMenuPresenter` instead. * Source/WebKit/UIProcess/mac/WKTextFinderClient.mm: Unrelated unified source build fix. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/268655@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4de01: Revert page load performance regression
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4de01c167748e15abeaf9c7ba7f525432772df6 https://github.com/WebKit/WebKit/commit/e4de01c167748e15abeaf9c7ba7f525432772df6 Author: Per Arne Vollan Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/DrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm Log Message: --- Revert page load performance regression https://bugs.webkit.org/show_bug.cgi?id=261932 rdar://problem/116217509 Unreviewed revert of 267274@main. * Source/WebKit/WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::scheduleRenderingUpdate): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: (WebKit::RemoteLayerTreeDrawingArea::displayDidRefreshIsPending const): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer): (WebKit::RemoteLayerTreeDrawingArea::updateGeometry): (WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen): (WebKit::RemoteLayerTreeDrawingArea::forceRepaint): (WebKit::RemoteLayerTreeDrawingArea::setExposedContentRect): (WebKit::RemoteLayerTreeDrawingArea::startRenderingUpdateTimer): (WebKit::RemoteLayerTreeDrawingArea::triggerRenderingUpdate): (WebKit::RemoteLayerTreeDrawingArea::updateRendering): (WebKit::RemoteLayerTreeDrawingArea::displayDidRefresh): (WebKit::RemoteLayerTreeDrawingArea::activityStateDidChange): (WebKit::RemoteLayerTreeDrawingArea::dispatchAfterEnsuringDrawing): (WebKit::RemoteLayerTreeDrawingArea::scheduleRenderingUpdateTimerFired): (WebKit::RemoteLayerTreeDrawingArea::scheduleRenderingUpdate): * Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm: (WebKit::RemoteLayerTreeDrawingAreaMac::applyTransientZoomToPage): Canonical link: https://commits.webkit.org/268654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b3806: Unreviewed, test262 gardening related to AppleICU SPI
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b380679133fbbcd56a6fc64a1306d156e2f842b https://github.com/WebKit/WebKit/commit/4b380679133fbbcd56a6fc64a1306d156e2f842b Author: Yusuke Suzuki Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/test262/config.yaml Log Message: --- Unreviewed, test262 gardening related to AppleICU SPI https://bugs.webkit.org/show_bug.cgi?id=262376 rdar://116240679 * JSTests/test262/config.yaml: Canonical link: https://commits.webkit.org/268653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4c5c5: [build.webkit.org] download-built-product step fai...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4c5c55d46c169e9e4aa886d5d3591bda93a28bf https://github.com/WebKit/WebKit/commit/a4c5c55d46c169e9e4aa886d5d3591bda93a28bf Author: Aakash Jain Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Tools/CISupport/build-webkit-org/steps.py Log Message: --- [build.webkit.org] download-built-product step fails on uat instances https://bugs.webkit.org/show_bug.cgi?id=262371 Reviewed by Ryan Haddad. finished() was used in old-style steps. This step was changed to new-style step in 264202@main. * Tools/CISupport/build-webkit-org/steps.py: (DownloadBuiltProduct.run): Canonical link: https://commits.webkit.org/268652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb7764: [WGSL] Add code generation for all synchronization...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb776403dad825e8a62e236e9067cb555a696ee3 https://github.com/WebKit/WebKit/commit/fb776403dad825e8a62e236e9067cb555a696ee3 Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/WGSLShaderModule.h M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add code generation for all synchronization built-in functions https://bugs.webkit.org/show_bug.cgi?id=262304 rdar://116179474 Reviewed by Mike Wyrzykowski. Add code generation for storageBarrier, workgroupBarrier and workgroupUniformLoad. The last one requires detecting whether the program actually uses it in order to emit a helper, which is currently quite hacky, but we don't have a proper way of tracking whether the built-ins are being called (or a function that shadows them), so that will be improved on a later patch. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers): (WGSL::Metal::FunctionDefinitionWriter::serializeVariable): (WGSL::Metal::emitStorageBarrier): (WGSL::Metal::emitWorkgroupBarrier): (WGSL::Metal::emitWorkgroupUniformLoad): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/WGSLShaderModule.h: (WGSL::ShaderModule::usesWorkgroupUniformLoad const): (WGSL::ShaderModule::setUsesWorkgroupUniformLoad): (WGSL::ShaderModule::clearUsesWorkgroupUniformLoad): * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/268651@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e92f5f: NetworkProcessConnection.cpp: fix incomplete type ...
Branch: refs/heads/webkitglib/2.42
Home: https://github.com/WebKit/WebKit
Commit: e92f5f33fd267fc387efd7099bb6970e24e71afd
https://github.com/WebKit/WebKit/commit/e92f5f33fd267fc387efd7099bb6970e24e71afd
Author: Thomas Devoogdt
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
Log Message:
---
NetworkProcessConnection.cpp: fix incomplete type WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=262359
Reviewed by Michael Catanzaro.
webkitgtk-2.42.0/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:327:11:
error: incomplete type ‘WebCore::Page’ used in nested name specifier
327 | Page::forEachPage([&] (auto& page) {
| ^~~
Signed-off-by: Thomas Devoogdt
Canonical link:
https://commits.webkit.org/266719.77@bugfix/NetworkProcessConnection-2.42
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b75173: [GTK] fix USE_EGL checks when GBM renderer is used
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: b751733c75f724f9301cb828f7994af57605c52f https://github.com/WebKit/WebKit/commit/b751733c75f724f9301cb828f7994af57605c52f Author: Thomas Devoogdt Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStore.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.messages.in M Source/WebKit/WebProcess/WebPage/AcceleratedSurface.cpp M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.h M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.messages.in M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp Log Message: --- [GTK] fix USE_EGL checks when GBM renderer is used https://bugs.webkit.org/show_bug.cgi?id=262169 Reviewed by Michael Catanzaro. Regression since commit 81c064ddb4182a34a36def401025d223ca0d31ba. webkitgtk-2.42.0/Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:39:10: fatal error: epoxy/egl.h: No such file or directory 39 | #include | ^ Signed-off-by: Thomas Devoogdt Canonical link: https://commits.webkit.org/266719.76@bugfix/USE_EGL-2.42 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 78d90a: BoxDecorationPainter should not use InterpolationQ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78d90a8e53b2f787f468ac358bb024e4f7390ef2 https://github.com/WebKit/WebKit/commit/78d90a8e53b2f787f468ac358bb024e4f7390ef2 Author: Kimmo Kinnunen Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp Log Message: --- BoxDecorationPainter should not use InterpolationQuality::Default with ImagePaintingOptions https://bugs.webkit.org/show_bug.cgi?id=262360 rdar://116228654 Reviewed by Tim Nguyen. Passing "Default" in ImagePaintingOptions means "Use what is in GraphicsContext". It is the same as not passing anything. This is work towards removing ImagePaintingOptions::Default, as it does not mean what the developers think it means (platform default image quality). * Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp: (WebCore::Display::BoxDecorationPainter::paintFillLayer const): Canonical link: https://commits.webkit.org/268650@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d04b66: NetworkProcessConnection.cpp: fix incomplete type ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d04b6618938354065f045853e0943f9d7dc0b1de
https://github.com/WebKit/WebKit/commit/d04b6618938354065f045853e0943f9d7dc0b1de
Author: Thomas Devoogdt
Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths:
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
Log Message:
---
NetworkProcessConnection.cpp: fix incomplete type WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=262359
Reviewed by Michael Catanzaro.
webkitgtk-2.42.0/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:327:11:
error: incomplete type ‘WebCore::Page’ used in nested name specifier
327 | Page::forEachPage([&] (auto& page) {
| ^~~
Signed-off-by: Thomas Devoogdt
Canonical link: https://commits.webkit.org/268649@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c879b9: MediaPlayerPrivateAVFoundationObjC::paintWithImage...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c879b942c9a21906b12b0de5edc1805cbe9eafe1 https://github.com/WebKit/WebKit/commit/c879b942c9a21906b12b0de5edc1805cbe9eafe1 Author: Kimmo Kinnunen Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Log Message: --- MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator is an unused function https://bugs.webkit.org/show_bug.cgi?id=262363 rdar://116231020 Reviewed by Youenn Fablet. Remove the unused function. The function is bad because it sets up GraphicsContext state but then uses CG to draw a CGImage. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Deleted. Canonical link: https://commits.webkit.org/268648@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe5164: REGRESSION(268517@main): WPE Bot WPE-Linux-ARM32-b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe516495ebe1664c03134c4f3d63e22fe77f693d https://github.com/WebKit/WebKit/commit/fe516495ebe1664c03134c4f3d63e22fe77f693d Author: Carlos Alberto Lopez Perez Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Tools/CISupport/build-webkit-org/config.json Log Message: --- REGRESSION(268517@main): WPE Bot WPE-Linux-ARM32-bit-Release-Debian-Stable-Build got reassigned to the wrong worker https://bugs.webkit.org/show_bug.cgi?id=262366 Unreviewed follow-up config fix WPE-Linux-ARM32-bit-Release-Debian-Stable-Build should run on wpe-linux-bot-16 * Tools/CISupport/build-webkit-org/config.json: Canonical link: https://commits.webkit.org/268647@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4aad34: [GTK] Add a DisplayLink implementation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4aad349224a3cf6246969fef86972f191b280fc1 https://github.com/WebKit/WebKit/commit/4aad349224a3cf6246969fef86972f191b280fc1 Author: Alejandro G. Castro Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/SourcesGTK.txt M Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp R Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp R Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.h M Source/WebKit/PlatformGTK.cmake M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h M Source/WebKit/Shared/Extensions/WebExtensionAlarmParameters.h M Source/WebKit/Sources.txt M Source/WebKit/SourcesCocoa.txt M Source/WebKit/SourcesGTK.txt M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h A Source/WebKit/UIProcess/DisplayLink.cpp A Source/WebKit/UIProcess/DisplayLink.h A Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.cpp A Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.h M Source/WebKit/UIProcess/DrawingAreaProxy.cpp M Source/WebKit/UIProcess/DrawingAreaProxy.h M Source/WebKit/UIProcess/Extensions/WebExtensionAlarm.cpp M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/UIProcess/WebProcessProxy.messages.in A Source/WebKit/UIProcess/glib/DisplayLinkGLib.cpp A Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp A Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.h A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.h A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorTimer.cpp A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorTimer.h M Source/WebKit/UIProcess/gtk/ScreenManager.cpp M Source/WebKit/UIProcess/gtk/ScreenManager.h R Source/WebKit/UIProcess/mac/DisplayLink.cpp R Source/WebKit/UIProcess/mac/DisplayLink.h A Source/WebKit/UIProcess/mac/DisplayLinkMac.cpp R Source/WebKit/UIProcess/mac/DisplayLinkProcessProxyClient.cpp R Source/WebKit/UIProcess/mac/DisplayLinkProcessProxyClient.h M Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h M Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp M Source/WebKit/WebProcess/WebPage/EventDispatcher.h M Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in A Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.cpp A Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.h R Source/WebKit/WebProcess/WebPage/mac/DisplayRefreshMonitorMac.cpp R Source/WebKit/WebProcess/WebPage/mac/DisplayRefreshMonitorMac.h M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in Log Message: --- [GTK] Add a DisplayLink implementation https://bugs.webkit.org/show_bug.cgi?id=261673 Reviewed by Simon Fraser. Add DisplayLink implementation using DRM API when available to get the vblank signal from monitor. When DRM is not available we fallback to use a timer. The patch includes some refactorings needed to share the implementation with other ports for non-platform specific parts. The platform display ID is no longer generated based on the drawing area identifier, but assigned by the screen manager to every monitor. ThreadedDisplayRefreshMonitor and DisplayRefreshMonitorGtk are no longer needed now. * Source/WebCore/SourcesGTK.txt: * Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor): (WebCore::DisplayRefreshMonitor::requestRefreshCallback): * Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp: Removed. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/S
[webkit-changes] [WebKit/WebKit] 80daa4: Inline tree dump should be aligned with block cont...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80daa4aae22b0991403419b007c0989fef6ee95b https://github.com/WebKit/WebKit/commit/80daa4aae22b0991403419b007c0989fef6ee95b Author: Alan Baradlay Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp Log Message: --- Inline tree dump should be aligned with block content in showRenderTree https://bugs.webkit.org/show_bug.cgi?id=262353 Reviewed by Simon Fraser. 268411@main added 2 extra columns to block content. * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::showInlineContent): Canonical link: https://commits.webkit.org/268645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed93c3: Implement updated TextTrackCue constructor proposal
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed93c318ea694da22ab23080a68b7f6240ed997f https://github.com/WebKit/WebKit/commit/ed93c318ea694da22ab23080a68b7f6240ed997f Author: Marcos Caceres Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor.html M LayoutTests/inspector/model/remote-object/dom-expected.txt M LayoutTests/media/track/texttrackcue/texttrackcue-constructor-expected.txt M LayoutTests/media/track/texttrackcue/texttrackcue-constructor.html M Source/WebCore/html/HTMLAttributeNames.in M Source/WebCore/html/HTMLElement.idl M Source/WebCore/html/track/TextTrackCue.cpp Log Message: --- Implement updated TextTrackCue constructor proposal https://bugs.webkit.org/show_bug.cgi?id=262053 rdar://116002871 Reviewed by Eric Carlson. Implements spec changes suggested at: https://github.com/whatwg/html/pull/9771 Specifically: * supports `b` and `i` elements, to match WebVTT * drops support for allowing `img` in the cue fragment * implements more robust error checking to prevent malformed ::cue and :cuebackground hierarchies * As such, ::tagPseudoObjects() can now throw * Switch from InvalidStateError to InvalidNodeTypeError for when required attributes are missing * implements cuebackground and cue global attributes * LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html: * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor.html: * LayoutTests/inspector/model/remote-object/dom-expected.txt: * LayoutTests/media/track/texttrackcue/texttrackcue-constructor-expected.txt: * LayoutTests/media/track/texttrackcue/texttrackcue-constructor.html: * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/html/HTMLElement.idl: * Source/WebCore/html/track/TextTrackCue.cpp: (WebCore::isLegalNode): (WebCore::tagPseudoObjects): (WebCore::removePseudoAttributes): (WebCore::TextTrackCue::create): (WebCore::TextTrackCue::setPauseOnExit): (WebCore::cueAttributName): Deleted. (WebCore::cueBackgroundAttributName): Deleted. Canonical link: https://commits.webkit.org/268644@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5117f: ImageBuffer::copyImage is redundant, should use co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5117f4636f67c6f8f8efb3f4a6ca1ce0914866d https://github.com/WebKit/WebKit/commit/b5117f4636f67c6f8f8efb3f4a6ca1ce0914866d Author: Kimmo Kinnunen Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/html/CustomPaintCanvas.cpp M Source/WebCore/html/CustomPaintCanvas.h M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/GraphicsContextGL.cpp M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/ImageBuffer.h M Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp M Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp M Source/WebCore/platform/graphics/texmap/BitmapTexture.h M Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp M Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h M Source/WebCore/platform/graphics/texmap/TextureMapperTile.cpp M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm Log Message: --- ImageBuffer::copyImage is redundant, should use copyNativeImage instead https://bugs.webkit.org/show_bug.cgi?id=261944 rdar://115891269 Reviewed by Matt Woodrow. Remove ImageBuffer::copyImaage(). WebCore::Image is higher level type. Callers should call sinkIntoNativeImage and then convert the NativeImage into Image, if needed. Note: most callers should use NativeImage, as that is the lowest level source image. These are identical: copyImage(CopyBackingStore, PreserveResolution::Yes) -> copyNativeImage() copyImage(DontCopyBackingStore, PreserveResolution::No) + scale 1 -> createNativeImageReference() Other variants wouldn't have corresponding NativeImage call, but they do not exist. This is work towards simplifying ImageBuffer by making it operate with NativeImage as its primary primitive image source. * Source/WebCore/html/CustomPaintCanvas.cpp: (WebCore::CustomPaintCanvas::copiedImage const): Fix an issue where the code would nullptr deref if Context2D call would try to reset the transform to default. The idea of CanvasBase::baseTransform() is that it would return the transform to be set, but this cannot happen because ImageBuffer has not been created at the time of the call. The transform reset is recorded. * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::copiedImage const): * Source/WebCore/html/ImageBitmap.cpp: (WebCore::ImageBitmap::createCompletionHandler): * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::copiedImage const): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::texImageSource): (WebCore::WebGLRenderingContextBase::drawImageIntoBuffer): (WebCore::WebGLRenderingContextBase::videoFrameToImage): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawPattern): * Source/WebCore/platform/graphics/GraphicsContextGL.cpp: (WebCore::GraphicsContextGL::videoFrameToImage): * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::copyImage const): Deleted. * Source/WebCore/platform/graphics/ImageBuffer.h: * Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp: (Nicosia::CairoOperationRecorder::drawImageBuffer): (Nicosia::CairoOperationRecorder::drawFilteredImageBuffer): (Nicosia::CairoOperationRecorder::clipToImageBuffer): * Source/WebCore/platform/graphics/texmap/BitmapTexture.cpp: (WebCore::BitmapTexture::updateContents): * Source/WebCore/platform/graphics/texmap/BitmapTexture.h: * Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp: (WebCore::BitmapTextureGL::updateContents): * Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h: * Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm: (WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer): Canonical link: https://commits.webkit.org/268643@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18b61d: [WGSL] Add type declarations for all synchronizati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18b61d61e1052ebbaf7834ccf2c534e97d37dd5c https://github.com/WebKit/WebKit/commit/18b61d61e1052ebbaf7834ccf2c534e97d37dd5c Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Overload.cpp M Source/WebGPU/WGSL/Overload.h M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/WGSLEnums.cpp M Source/WebGPU/WGSL/WGSLEnums.h M Source/WebGPU/WGSL/generator/main.rb M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add type declarations for all synchronization built-in functions https://bugs.webkit.org/show_bug.cgi?id=262303 rdar://116179275 Reviewed by Mike Wyrzykowski. Add declarations for the 3 synchronization built-in functions from section 16.11 of the spec[1]. [1]: https://www.w3.org/TR/WGSL/#sync-builtin-functions * Source/WebGPU/WGSL/Overload.h: (WGSL::AbstractPointer::AbstractPointer): * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseVariableQualifier): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/WGSLEnums.cpp: (WGSL::defaultAccessModeForAddressSpace): * Source/WebGPU/WGSL/WGSLEnums.h: * Source/WebGPU/WGSL/generator/main.rb: * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/268642@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 28a68b: [WGSL] Add code generation for textureSampleLevel
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 28a68be349d587e00400e6a4cfa4bd5fd2399fde https://github.com/WebKit/WebKit/commit/28a68be349d587e00400e6a4cfa4bd5fd2399fde Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add code generation for textureSampleLevel https://bugs.webkit.org/show_bug.cgi?id=262306 rdar://116180196 Reviewed by Mike Wyrzykowski. Add the Metal code generation for textureSampleLevel, similar to the regular textureSample function, just marginally more complicated as it needs the `level()` wrapper around the level argument. * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::visitArguments): (WGSL::Metal::emitTextureSampleLevel): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/268641@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2b5f6: [WGSL] Add sampler_comparison and declarations for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2b5f644393e6c9579bbb4e72f0f6b9819687978 https://github.com/WebKit/WebKit/commit/e2b5f644393e6c9579bbb4e72f0f6b9819687978 Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/ConstantFunctions.h M Source/WebGPU/WGSL/ConstantRewriter.cpp M Source/WebGPU/WGSL/Constraints.cpp M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/TypeStore.cpp M Source/WebGPU/WGSL/TypeStore.h M Source/WebGPU/WGSL/Types.cpp M Source/WebGPU/WGSL/Types.h M Source/WebGPU/WGSL/generator/main.rb M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add sampler_comparison and declarations for all texture comparison functions https://bugs.webkit.org/show_bug.cgi?id=262302 rdar://116179097 Reviewed by Mike Wyrzykowski. Add the missing the sampler_comparison type and the missing texture comparison functions that depended on it: textureGatherCompare, textureSampleCompare and textureSampleCompareLevel * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::zeroValue): * Source/WebGPU/WGSL/ConstantRewriter.cpp: (WGSL::ConstantRewriter::materialize): * Source/WebGPU/WGSL/Constraints.cpp: (WGSL::satisfies): (WGSL::satisfyOrPromote): * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::bindingMemberForGlobal): (WGSL::RewriteGlobalVariables::usesOverride): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::emitPackedVector): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::TypeChecker): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/TypeStore.cpp: (WGSL::TypeStore::TypeStore): * Source/WebGPU/WGSL/TypeStore.h: (WGSL::TypeStore::samplerComparisonType const): * Source/WebGPU/WGSL/Types.cpp: (WGSL::Type::size const): (WGSL::Type::alignment const): * Source/WebGPU/WGSL/Types.h: * Source/WebGPU/WGSL/generator/main.rb: * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/268640@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81ab06: Implement keyboard events for site isolation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81ab068d217bd79ff4f6e841dfb8e7a854684ade https://github.com/WebKit/WebKit/commit/81ab068d217bd79ff4f6e841dfb8e7a854684ade Author: Charlie Wolfe Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: A LayoutTests/http/tests/site-isolation/key-events-expected.txt A LayoutTests/http/tests/site-isolation/key-events.html A LayoutTests/http/tests/site-isolation/resources/key-event-handler.html M LayoutTests/platform/ios/TestExpectations M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebFrame.cpp Log Message: --- Implement keyboard events for site isolation https://bugs.webkit.org/show_bug.cgi?id=262286 rdar://116167166 Reviewed by Alex Christensen. Currently, key events rely on `FocusController` in the web process to determine which frame should receive a key event. For site isolation, we should reference information on the focused frame stored in the UI process so we can send the key event directly to the web process hosting the focused frame. EventSenderProxyIOS::keyDown() is not implemented, so disable the test on iOS. * LayoutTests/http/tests/site-isolation/key-events-expected.txt: Added. * LayoutTests/http/tests/site-isolation/key-events.html: Added. * LayoutTests/http/tests/site-isolation/resources/key-event-handler.html: Added. * LayoutTests/platform/ios/TestExpectations: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::sendKeyEvent): (WebKit::WebPageProxy::handleKeyboardEvent): (WebKit::WebPageProxy::didReceiveEvent): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::handleKeyEvent): Canonical link: https://commits.webkit.org/268639@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4fd46a: Fix inconsistent test results for webvtt/paring tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4fd46adb8769322fc06e7d39b8d9cea72f6d01b6 https://github.com/WebKit/WebKit/commit/4fd46adb8769322fc06e7d39b8d9cea72f6d01b6 Author: Kohei Ueno Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align.html M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line.html M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines.html M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text.html M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical.html Log Message: --- Fix inconsistent test results for webvtt/paring tests https://bugs.webkit.org/show_bug.cgi?id=262010 Reviewed by Dan Glastonbury. Even though these tests have succeeded, they are labeled as failures due to the default setting not displaying the caption. To fix this issue, we should set the caption mode to `automatic` by the captionDisplayMode option. * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/align.html: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/line.html: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/snapToLines.html: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/text.html: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTCue/vertical.html: Canonical link: https://commits.webkit.org/268638@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1db59: [WGSL] Add more logging to constant rewriter and c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1db598cbd01a8635da27a489372bc5f945dd4e5 https://github.com/WebKit/WebKit/commit/b1db598cbd01a8635da27a489372bc5f945dd4e5 Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/ConstantRewriter.cpp Log Message: --- [WGSL] Add more logging to constant rewriter and clear evaluation result https://bugs.webkit.org/show_bug.cgi?id=262305 rdar://116179924 Reviewed by Mike Wyrzykowski. There was a bug in the constant rewriter where the wrong value would be returned for expressions. This is caused by the fact that the rewriter implementation is rather sparse at the moment, and we weren't cleaning the previous evaluation result, so a stale value was being returned. In order to identify the root cause of the issue more logging was required, and it felt appropriate to leave the logging in (behind the same flag already in use) for future debugging. * Source/WebGPU/WGSL/ConstantRewriter.cpp: (WGSL::ConstantRewriter::visit): (WGSL::ConstantRewriter::evaluate): (WGSL::ConstantRewriter::evaluated): (WGSL::ConstantRewriter::introduceVariable): Canonical link: https://commits.webkit.org/268637@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f97d3: [WGSL] Add code generation for textureStore
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f97d30ad96f61d01c88177d71783bf502752629 https://github.com/WebKit/WebKit/commit/5f97d30ad96f61d01c88177d71783bf502752629 Author: Tadeu Zagallo Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] Add code generation for textureStore https://bugs.webkit.org/show_bug.cgi?id=262301 rdar://116178725 Reviewed by Mike Wyrzykowski. Convert textureStore(texture, ...) into texture.write(...) * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::emitTextureStore): (WGSL::Metal::FunctionDefinitionWriter::visit): * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/268636@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b39d68: Update test262 09/29/2023
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b39d6850dab342b8a1f9c8919a6cd93dd7ec9919 https://github.com/WebKit/WebKit/commit/b39d6850dab342b8a1f9c8919a6cd93dd7ec9919 Author: Yusuke Suzuki Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/test262/expectations.yaml M JSTests/test262/harness/propertyHelper.js M JSTests/test262/harness/regExpUtils.js M JSTests/test262/harness/temporalHelpers.js M JSTests/test262/harness/testIntl.js M JSTests/test262/latest-changes-summary.txt A JSTests/test262/test/annexB/language/eval-code/direct/script-decl-lex-collision-in-sloppy-mode.js A JSTests/test262/test/annexB/language/eval-code/direct/script-decl-lex-no-collision-in-strict-mode.js A JSTests/test262/test/annexB/language/global-code/script-decl-lex-collision.js M JSTests/test262/test/built-ins/Array/fromAsync/this-constructor-operations.js M JSTests/test262/test/built-ins/Array/fromAsync/this-constructor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/resize/name.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/resize/nonconstructor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/slice/nonconstructor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/name.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transfer/nonconstructor.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transferToFixedLength/name.js M JSTests/test262/test/built-ins/ArrayBuffer/prototype/transferToFixedLength/nonconstructor.js M JSTests/test262/test/built-ins/Error/cause_property.js A JSTests/test262/test/built-ins/Iterator/prototype/drop/throws-typeerror-when-generator-is-running.js A JSTests/test262/test/built-ins/Iterator/prototype/filter/throws-typeerror-when-generator-is-running.js A JSTests/test262/test/built-ins/Iterator/prototype/flatMap/throws-typeerror-when-generator-is-running.js A JSTests/test262/test/built-ins/Iterator/prototype/map/throws-typeerror-when-generator-is-running.js M JSTests/test262/test/built-ins/Iterator/prototype/reduce/iterator-already-exhausted-no-initial-value.js M JSTests/test262/test/built-ins/Iterator/prototype/reduce/non-callable-reducer.js A JSTests/test262/test/built-ins/Iterator/prototype/take/throws-typeerror-when-generator-is-running.js M JSTests/test262/test/built-ins/NativeErrors/AggregateError/cause-property.js M JSTests/test262/test/built-ins/NativeErrors/cause_property_native_error.js A JSTests/test262/test/built-ins/Promise/withResolvers/ctx-ctor.js A JSTests/test262/test/built-ins/Promise/withResolvers/ctx-non-ctor.js A JSTests/test262/test/built-ins/Promise/withResolvers/ctx-non-object.js A JSTests/test262/test/built-ins/Promise/withResolvers/promise.js A JSTests/test262/test/built-ins/Promise/withResolvers/resolvers.js A JSTests/test262/test/built-ins/Promise/withResolvers/result.js A JSTests/test262/test/built-ins/RegExp/lookahead-quantifier-match-groups.js A JSTests/test262/test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-13.1.js A JSTests/test262/test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-14.0.js A JSTests/test262/test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-15.0.js A JSTests/test262/test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-15.1.js M JSTests/test262/test/built-ins/SharedArrayBuffer/prototype/grow/name.js M JSTests/test262/test/built-ins/SharedArrayBuffer/prototype/grow/nonconstructor.js M JSTests/test262/test/built-ins/SharedArrayBuffer/prototype/slice/nonconstructor.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/day/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/month/argument-builtin-calendar-no-array-iteration.js A JSTests/test262/test/built-ins/Temporal/Calendar/prototype/mon
[webkit-changes] [WebKit/WebKit] 133e01: [JSC] Block-level function declarations shouldn't ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 133e011511b5b82e015c005ac961fab21b4ce825 https://github.com/WebKit/WebKit/commit/133e011511b5b82e015c005ac961fab21b4ce825 Author: Alexey Shvayka Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/test262/expectations.yaml M LayoutTests/js/parser-syntax-check-expected.txt M LayoutTests/js/script-tests/parser-syntax-check.js M Source/JavaScriptCore/parser/Parser.h Log Message: --- [JSC] Block-level function declarations shouldn't be allowed to shadow `var` bindings https://bugs.webkit.org/show_bug.cgi?id=262330 Reviewed by Yusuke Suzuki and Justin Michaud. This change aligns non-`var` case of declareFunction() with declareLexicalVariable() to throw a SyntaxError if a block-level function declaration would shadow a `var` binding, previously declared in this or in a nested scope. The early error is specified here [1], while the fact of FunctionDeclaration being lexical is described here [2]. Aligns JSC with V8 and SpiderMonkey. [1]: https://tc39.es/ecma262/#sec-block-static-semantics-early-errors [2]: https://tc39.es/ecma262/#sec-static-semantics-lexicallydeclarednames * JSTests/test262/expectations.yaml: Mark 24 tests as passing. * LayoutTests/js/parser-syntax-check-expected.txt: * LayoutTests/js/script-tests/parser-syntax-check.js: * Source/JavaScriptCore/parser/Parser.h: (JSC::Scope::declareFunction): Canonical link: https://commits.webkit.org/268634@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff0134: [JSC] Align stringification algorithm of the Funct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff01344c4f58839cfc9b7381f6416307f9e1e1c5 https://github.com/WebKit/WebKit/commit/ff01344c4f58839cfc9b7381f6416307f9e1e1c5 Author: Alexey Shvayka Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M JSTests/ChakraCore/test/Lib/noargs_2.baseline-jsc M JSTests/stress/function-cache-with-parameters-end-position.js M JSTests/stress/function-constructor-name.js M JSTests/stress/function-constructor-semantics.js M JSTests/test262/expectations.yaml M LayoutTests/inspector/console/messageAdded-from-named-evaluations-expected.txt M LayoutTests/js/dom/function-names-expected.txt M LayoutTests/js/dom/script-start-end-locations-expected.txt M LayoutTests/js/dom/script-tests/function-names.js M Source/JavaScriptCore/API/tests/FunctionOverridesTest.cpp M Source/JavaScriptCore/API/tests/testapi.c M Source/JavaScriptCore/runtime/FunctionConstructor.cpp M Source/JavaScriptCore/runtime/FunctionConstructor.h M Source/WebCore/bindings/js/JSLazyEventListener.cpp M Source/WebCore/bindings/js/JSLazyEventListener.h Log Message: --- [JSC] Align stringification algorithm of the Function constructor with the spec https://bugs.webkit.org/show_bug.cgi?id=190501 Reviewed by Yusuke Suzuki. This change aligns stringification algorithm of the Function constructor with the spec [1]. In particular, fixes prefixes for (async) generator functions (steps 5 & 7), joins parameters by "," instead of ", " (step 10.d.iii), and adds a newline character after the last parameter (step 13). Since constructFunctionSkippingEvalEnabledCheck() is also being used for creating HTML attribute event listeners, which uses different stringification algorithm [2], this patch tweaks its signature to accept the source code instead, making bindings / disabled eval() code a little bit nicer. Aligns JSC with V8 and SpiderMonkey. [1]: https://tc39.es/ecma262/#sec-createdynamicfunction [2]: https://html.spec.whatwg.org/multipage/webappapis.html#getting-the-current-value-of-the-event-handler (step 9) * JSTests/ChakraCore/test/Lib/noargs_2.baseline-jsc: * JSTests/stress/function-cache-with-parameters-end-position.js: * JSTests/stress/function-constructor-name.js: * JSTests/stress/function-constructor-semantics.js: * JSTests/test262/expectations.yaml: Mark 12 tests as passing. * LayoutTests/inspector/console/messageAdded-from-named-evaluations-expected.txt: * LayoutTests/js/dom/function-names-expected.txt: * LayoutTests/js/dom/script-start-end-locations-expected.txt: * LayoutTests/js/dom/script-tests/function-names.js: * Source/JavaScriptCore/API/tests/FunctionOverridesTest.cpp: * Source/JavaScriptCore/API/tests/testapi.c: * Source/JavaScriptCore/runtime/FunctionConstructor.cpp: (JSC::stringifyFunction): (JSC::constructFunction): This change is careful to preserve "swallowing" an argument coercion error in case of disabled eval(), which is intentional since HostEnsureCanCompileStrings happens as early as on step 2 [1]. (JSC::constructFunctionSkippingEvalEnabledCheck): * Source/JavaScriptCore/runtime/FunctionConstructor.h: * Source/WebCore/bindings/js/JSLazyEventListener.cpp: (WebCore::functionParameters): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::initializeJSFunction const): (WebCore::eventParameterName): Deleted. * Source/WebCore/bindings/js/JSLazyEventListener.h: Co-authored-by: Keith Miller Canonical link: https://commits.webkit.org/268633@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 892491: Add smart pointers to ImageBuffer uses
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8924915b479332318589c9d627f38851276164e1 https://github.com/WebKit/WebKit/commit/8924915b479332318589c9d627f38851276164e1 Author: Gerald Squelart Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebCore/Modules/WebGPU/GPUQueue.cpp M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/OffscreenCanvas.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm M Source/WebCore/platform/graphics/filters/FilterImage.cpp M Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp M Source/WebCore/platform/graphics/filters/software/FEBlendSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEFloodSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEMergeSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FETileSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp Log Message: --- Add smart pointers to ImageBuffer uses https://bugs.webkit.org/show_bug.cgi?id=262267 rdar://problem/116161504 Reviewed by Ryosuke Niwa and Alex Christensen. Add explicit Ref/RefPtr (or similar measures) where needed to ensure that ImageBuffers cannot be deleted during function calls. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::GPUQueue::copyExternalImageToTexture): * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::toVideoFrame): * Source/WebCore/html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::commitToPlaceholderCanvas): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage): (WebCore::CanvasRenderingContext2DBase::needsPreparationForDisplay const): (WebCore::CanvasRenderingContext2DBase::getImageData const): (WebCore::CanvasRenderingContext2DBase::putImageData): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::texImageSource): (WebCore::WebGLRenderingContextBase::drawImageIntoBuffer): (WebCore::WebGLRenderingContextBase::videoFrameToImage): (WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawFilteredImageBuffer): * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::filteredImage): * Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm: (WebCore::SourceGraphicCoreImageApplier::apply const): * Source/WebCore/platform/graphics/filters/FilterImage.cpp: (WebCore::FilterImage::copyPixelBuffer): (WebCore::FilterImage::transformToColorSpace): * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp: (WebCore::FilterImageTargetSwitcher::endDrawSourceImage): * Source/WebCore/platform/graphics/filters/software/FEBlendSoftwareApplier.cpp: (WebCore::FEBlendSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp: (WebCore::FEColorMatrixSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp: (WebCore::FECompositeSoftwareApplier::applyNonArithmetic const): * Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp: (WebCore::FEDropShadowSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FEFloodSoftwareApplier.cpp: (WebCore::FEFloodSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.cpp: (WebCore::FEImageSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FEMergeSoftwareApplier.cpp: (WebCore::FEMergeSoftwareApplier::apply const): * Source/WebCore/platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp: (WebCore::FEOffsetSoftwareApplier::apply c
