[webkit-changes] [WebKit/WebKit] 86924d: Use a HashSet> for Page::m_...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86924d729527e6aa7eefc1f9c0c2f6269717639b
  
https://github.com/WebKit/WebKit/commit/86924d729527e6aa7eefc1f9c0c2f6269717639b
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Use a HashSet> for Page::m_rootFrames
https://bugs.webkit.org/show_bug.cgi?id=262721

Reviewed by Ryosuke Niwa.

Use a HashSet> for Page::m_rootFrames instead of a 
WeakHashSet.
This set is used in a hot code path and using a WeakHashSet is unnecessarily 
inefficient.

* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::LocalFrame):
(WebCore::LocalFrame::isRootFrame const):
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/Page.h:
(WebCore::Page::rootFrames const):
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::hasRootFrames):

Canonical link: https://commits.webkit.org/268974@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] af0791: Make GPUProcessCreationParameters use generated se...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af079110514e8e622fd464fb8b7097d88789b98a
  
https://github.com/WebKit/WebKit/commit/af079110514e8e622fd464fb8b7097d88789b98a
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
R Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp
M Source/WebKit/GPUProcess/GPUProcessCreationParameters.h
A Source/WebKit/GPUProcess/GPUProcessCreationParameters.serialization.in
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Make GPUProcessCreationParameters use generated serializations
https://bugs.webkit.org/show_bug.cgi?id=262754

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp: Removed.
* Source/WebKit/GPUProcess/GPUProcessCreationParameters.h:
* Source/WebKit/GPUProcess/GPUProcessCreationParameters.serialization.in: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/268973@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 269e77: Delete AppPrivacyReportTestingData.h

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 269e774808943be494fffdd4bbe2dacfdc18880f
  
https://github.com/WebKit/WebKit/commit/269e774808943be494fffdd4bbe2dacfdc18880f
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
R Source/WebKit/Shared/AppPrivacyReportTestingData.h

  Log Message:
  ---
  Delete AppPrivacyReportTestingData.h
https://bugs.webkit.org/show_bug.cgi?id=262763

Reviewed by Wenson Hsieh.

Delete this unused file.

* Source/WebKit/Shared/AppPrivacyReportTestingData.h: Removed.

Canonical link: https://commits.webkit.org/268972@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 105e0f: REGRESSION (266610@main): Download alert doesn’t r...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 105e0f1e80b0e8ff0be61f05cf8dd6e3f3926cb5
  
https://github.com/WebKit/WebKit/commit/105e0f1e80b0e8ff0be61f05cf8dd6e3f3926cb5
  Author: Wenson Hsieh 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKMouseInteraction.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm

  Log Message:
  ---
  REGRESSION (266610@main): Download alert doesn’t respond to trackpad clicks 
until after pointer hides
https://bugs.webkit.org/show_bug.cgi?id=262752
rdar://116206313

Reviewed by Megan Gardner.

After the refactoring in 266610@main, `WKMouseGestureRecognizer` was split into 
three total
gestures: two to passively observe mouse and pencil hover, and 
`WKMouseTouchGestureRecognizer`,
which observes mouse events while the mouse is down. Currently, this mouse 
touch gesture remains in
`Possible` state while receiving pointer events (i.e. `-touches*:withEvent:`). 
This means that if
any other pointer-only gesture has failure requirements to this gesture, it 
could be blocked
indefinitely while waiting for the subgraph to reset.

When clicking on a download link, Safari overlays native alert UI which 
obscures the entire web
view. Prior to the above refactoring, we would receive a call to the SPI method 
`-_hoverExited:`
when the user moves their mouse over the dialog, causing us to immediately 
transition the gesture to
Ended state. This no longer happens, since we stopped relying on that SPI hook. 
As a result, other
pointer gestures that have failure requirements to 
`WKMouseTouchGestureRecognizer` get stuck waiting
for a reset that never happens.

Fix this by transitioning the `WKMouseTouchGestureRecognizer` through the 
normal gesture recognizer
states under the touch event subclassing hooks: `Began` upon beginning touches, 
`Changed` when
dragging, and `Cancelled` or `Ended` upon releasing the mouse (or otherwise 
cancelling the pointer
interaction).

Note that we can end `WKMouseTouchGestureRecognizer` upon mouseup (as opposed 
to how the former
`WKMouseGestureRecognizer` only transitioned to Ended after exiting the view), 
since the new class
only needs to recognize while the pointer is down.

* Source/WebKit/UIProcess/ios/WKMouseInteraction.mm:
(-[WKMouseTouchGestureRecognizer touchesBegan:withEvent:]):
(-[WKMouseTouchGestureRecognizer touchesMoved:withEvent:]):
(-[WKMouseTouchGestureRecognizer touchesEnded:withEvent:]):
(-[WKMouseTouchGestureRecognizer touchesCancelled:withEvent:]):

Add state transitions; see above for more information.

(-[WKMouseInteraction initWithDelegate:]):

Drive-by fix: also give these gestures more descriptive names, to make 
descriptions more informative
when logging (and also so that the API test harness below can find 
`WKMouseTouchGestureRecognizer`).

* Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TestWebKitAPI::MouseEventTestHarness::MouseEventTestHarness):
(TestWebKitAPI::MouseEventTestHarness::mouseMove):
(TestWebKitAPI::MouseEventTestHarness::mouseDown):
(TestWebKitAPI::MouseEventTestHarness::mouseUp):
(TestWebKitAPI::MouseEventTestHarness::mouseCancel):

Refactor the test harness so that it calls into `UIGestureRecognizer` delegate 
methods when
simulating `mouseDown` or `mouseUp`, and additionally assert gesture recognizer 
states after doing
so.

(TestWebKitAPI::MouseEventTestHarness::activeTouches const):

Canonical link: https://commits.webkit.org/268971@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22dc25: Ensure file name is valid when saving web page res...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22dc25be180b6bfb18f6012b963885cc4e2797d1
  
https://github.com/WebKit/WebKit/commit/22dc25be180b6bfb18f6012b963885cc4e2797d1
  Author: Sihui Liu 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  ---
  Ensure file name is valid when saving web page resources to disk
https://bugs.webkit.org/show_bug.cgi?id=262642
rdar://116419303

Reviewed by Ryosuke Niwa.

We currently use the last component of URL as file name, and that could lead to 
file system error, because a valid URL
component may not be a valid file name. To fix that, we are going to generate 
valid file name based on last component
by:
1. encoding escape characters of file system.
2. ensuring length is smaller than 255 bytes.
3. appending sequence number when it's taken by other subresource file.
4. falling back to default file name when last component is empty.

Test: WebArchive.SaveResourcesValidFileName

* Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::generateValidFileName):
(WebCore::LegacyWebArchive::create):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/268970@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d7c9c0: [WebGPU] built-in arrayLength assumes all buffers ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7c9c0b30ecda84acf15d6f5c5430fecaa0f7e10
  
https://github.com/WebKit/WebKit/commit/d7c9c0b30ecda84acf15d6f5c5430fecaa0f7e10
  Author: Mike Wyrzykowski 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/WGSL.h
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/WebGPUExt.h

  Log Message:
  ---
  [WebGPU] built-in arrayLength assumes all buffers require an arrayLength, 
when it should not
https://bugs.webkit.org/show_bug.cgi?id=262728


Reviewed by Dan Glastonbury.

In 268884@main, a buffer length for all buffers was generated. This is not
really needed.

Instead, generate a buffer length only when it is needed in the shader.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::createArgumentDescriptor):
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::bufferSizeIndexForEntryIndex const):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::addPipelineLayouts):
* Source/WebGPU/WebGPU/WebGPUExt.h:

Canonical link: https://commits.webkit.org/268969@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a01e84: Make WebNavigationDataStore use generated serializ...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a01e84664acf3496126d0d3f1d151b08d683b086
  
https://github.com/WebKit/WebKit/commit/a01e84664acf3496126d0d3f1d151b08d683b086
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/WebNavigationDataStore.h
A Source/WebKit/Shared/WebNavigationDataStore.serialization.in

  Log Message:
  ---
  Make WebNavigationDataStore use generated serialization
https://bugs.webkit.org/show_bug.cgi?id=262737

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::encode const): Deleted.
(WebKit::WebNavigationDataStore::decode): Deleted.
* Source/WebKit/Shared/WebNavigationDataStore.serialization.in: Added.

Canonical link: https://commits.webkit.org/268968@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 145aa2: Make VisibleContentRectUpdateInfo use generated se...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 145aa2bfa77908606c5440709ddb1cdb588386df
  
https://github.com/WebKit/WebKit/commit/145aa2bfa77908606c5440709ddb1cdb588386df
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/VisibleContentRectUpdateInfo.cpp
M Source/WebKit/Shared/VisibleContentRectUpdateInfo.h
A Source/WebKit/Shared/VisibleContentRectUpdateInfo.serialization.in

  Log Message:
  ---
  Make VisibleContentRectUpdateInfo use generated serialization
https://bugs.webkit.org/show_bug.cgi?id=262739

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode const): Deleted.
(WebKit::VisibleContentRectUpdateInfo::decode): Deleted.
* Source/WebKit/Shared/VisibleContentRectUpdateInfo.h:
(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::layoutViewportRect const):
(WebKit::VisibleContentRectUpdateInfo::scrollVelocity const):
* Source/WebKit/Shared/VisibleContentRectUpdateInfo.serialization.in: Added.

Canonical link: https://commits.webkit.org/268967@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 14129a: Make AuxiliaryProcessCreationParameters use genera...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 14129a7e0dcd82566aa9eae626cd4d03ace15cbb
  
https://github.com/WebKit/WebKit/commit/14129a7e0dcd82566aa9eae626cd4d03ace15cbb
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
R Source/WebKit/Shared/AuxiliaryProcessCreationParameters.cpp
M Source/WebKit/Shared/AuxiliaryProcessCreationParameters.h
A Source/WebKit/Shared/AuxiliaryProcessCreationParameters.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Make AuxiliaryProcessCreationParameters use generated serializations
https://bugs.webkit.org/show_bug.cgi?id=262748

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/AuxiliaryProcessCreationParameters.cpp: Removed.
* Source/WebKit/Shared/AuxiliaryProcessCreationParameters.h:
* Source/WebKit/Shared/AuxiliaryProcessCreationParameters.serialization.in: 
Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/268966@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e2b53: Make FontInfo use generated serialization

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e2b5351f12b7747065ac8ffed4cd8ae1677ca61
  
https://github.com/WebKit/WebKit/commit/5e2b5351f12b7747065ac8ffed4cd8ae1677ca61
  Author: Ryosuke Niwa 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
R Source/WebKit/Shared/FontInfo.cpp
M Source/WebKit/Shared/FontInfo.h
A Source/WebKit/Shared/FontInfo.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Make FontInfo use generated serialization
https://bugs.webkit.org/show_bug.cgi?id=262747

Reviewed by Alex Christensen.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/FontInfo.cpp: Removed.
* Source/WebKit/Shared/FontInfo.h:
* Source/WebKit/Shared/FontInfo.serialization.in: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/268965@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f6444: Introduce 'rotateRadians' helper function and use ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f64447f2aa9d256ae17bd271e186aac0257f2f9
  
https://github.com/WebKit/WebKit/commit/3f64447f2aa9d256ae17bd271e186aac0257f2f9
  Author: Ahmad Saleem 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/html/canvas/CanvasPath.cpp
M Source/WebCore/platform/graphics/cg/PathCG.cpp
M Source/WebCore/platform/graphics/transforms/AffineTransform.cpp
M Source/WebCore/platform/graphics/transforms/AffineTransform.h
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp
M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h

  Log Message:
  ---
  Introduce 'rotateRadians' helper function and use across WebKit

https://bugs.webkit.org/show_bug.cgi?id=262718

Reviewed by Chris Dumez.

Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=167603 &
https://src.chromium.org/viewvc/blink?revision=168929&view=revision

Currently, rotate function takes an argument in only degrees.
In many cases, rotate function is often required radian value instead of degree 
value.
If we add new rotateRadians function, we will be able to reduce unnecessary 
operations.

 Before : rad -> rad2deg -> deg2rad -> calc sinNcos
 After  : rad   -> calc sinNcos

As a result, we can reduce two multiplication and two division.

Additionally, we can use it across WebCore source instead of 'rotate(rad2deg)'.

* Source/WebCore/platform/graphics/transforms/AffineTransform.cpp:
(AffineTransform::rotate):
(AffineTransform::rotateRadians):
(AffineTransform::rotateFromVector):
(AffineTransform::decompose):
* Source/WebCore/platform/graphics/transforms/AffineTransform.h: new 
'rotateRadians' function
* Source/WebCore/platform/graphics/cg/PathCG.cpp:
(PathCG::addEllipse):
* Source/WebCore/html/canvas/CanvasPath.cpp:
(CanvasPath::addEllipse):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:
(TransformationMatrix::rotateFromVector):
(TransformationMatrix::rotate):
(TransformationMatrix::rotateRadians):
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: new 
'rotateRadians' function

Canonical link: https://commits.webkit.org/268964@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 85cc8f: Remove some unused "slowPath" arguments in LLInt a...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85cc8f5233a0ac012b0716fae3cf46726d38a6a0
  
https://github.com/WebKit/WebKit/commit/85cc8f5233a0ac012b0716fae3cf46726d38a6a0
  Author: Mark Lam 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/llint/LowLevelInterpreter.asm
M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

  Log Message:
  ---
  Remove some unused "slowPath" arguments in LLInt asm macros.
https://bugs.webkit.org/show_bug.cgi?id=262717
rdar://116537174

Reviewed by Alexey Shvayka.

Just removing some obsolete dead code.

* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:

Canonical link: https://commits.webkit.org/268963@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 152b2c: Avoid heap-allocating a new BackingStoreFlusher fo...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 152b2c4306265d0bb3886a7ba6f306483d5cc25c
  
https://github.com/WebKit/WebKit/commit/152b2c4306265d0bb3886a7ba6f306483d5cc25c
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm

  Log Message:
  ---
  Avoid heap-allocating a new BackingStoreFlusher for each 
RemoteLayerTreeDrawingArea::updateRendering() call
https://bugs.webkit.org/show_bug.cgi?id=262735

Reviewed by Simon Fraser.

Avoid heap-allocating a new BackingStoreFlusher for each 
RemoteLayerTreeDrawingArea::updateRendering()
call. Reuse the same BackingStoreFlusher for each call since flushes cannot 
happen in parallel.

* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::hasPendingFlush 
const):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::markHasPendingFlush):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::hasFlushed const): 
Deleted.
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::BackingStoreFlusher):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):

Canonical link: https://commits.webkit.org/268962@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d67141: [SVG] Add ShapeType to LegacyRenderSVGShape

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6714182b3ab453ce39eee1ec18e3b5032dffec0
  
https://github.com/WebKit/WebKit/commit/d6714182b3ab453ce39eee1ec18e3b5032dffec0
  Author: Yusuke Suzuki 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/Path.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h

  Log Message:
  ---
  [SVG] Add ShapeType to LegacyRenderSVGShape
https://bugs.webkit.org/show_bug.cgi?id=262724
rdar://116538506

Reviewed by Simon Fraser.

This patch adds ShapeType to LegacyRenderSVGShape, which tells shape type of 
LegacyRenderSVGShape.
This enum will be used for efficient dispatch / behavior change for approximate 
repainting bounding box computation.

* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::isSingleDataLine const):
* Source/WebCore/platform/graphics/Path.h:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp:
(WebCore::LegacyRenderSVGEllipse::updateShapeFromElement):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp:
(WebCore::LegacyRenderSVGPath::updateShapeFromElement):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp:
(WebCore::LegacyRenderSVGRect::updateShapeFromElement):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::layout):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h:
(WebCore::LegacyRenderSVGShape::shapeType const):

Canonical link: https://commits.webkit.org/268961@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6dc509: [UnifedPDF] Change ENABLE_PDFKIT_PLUGIN to ENABLE_...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6dc5092597249356827c71dd1870d7b081be8a37
  
https://github.com/WebKit/WebKit/commit/6dc5092597249356827c71dd1870d7b081be8a37
  Author: Simon Fraser 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h
M Source/WebCore/html/HTMLPlugInImageElement.cpp
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm
M Source/WebKit/Shared/mac/PDFContextMenu.h
M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in
M Source/WebKit/UIProcess/PDF/WKPDFHUDView.h
M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h
M Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/FindController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm

  Log Message:
  ---
  [UnifedPDF] Change ENABLE_PDFKIT_PLUGIN to ENABLE_LEGACY_PDFKIT_PLUGIN
https://bugs.webkit.org/show_bug.cgi?id=262722
rdar://116538277

Reviewed by Tim Horton.

Bulk search/replace of ENABLE(PDFKIT_PLUGIN) to ENABLE(LEGACY_PDFKIT_PLUGIN).

Also introduce ENABLE_PDF_HUD which will be true on macOS.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
* Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::shouldBypassCSPForPDFPlugin const):
* Source/WebCore/loader/LocalFrameLoaderClient.h:us
* Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
* Source/WebKit/Shared/mac/PDFContextMenu.h:
* Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in:
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.h:
* Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::resetStateAfterProcessTermination):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
* Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:
(WKBundlePageGetPDFDocumentInFrame):
* Source/WebKit/WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
* Source/WebKit/

[webkit-changes] [WebKit/WebKit] 1832ad: Move fast character comparison functions from Java...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1832ad030f7dcd00a47615aaacc78cd351066f6f
  
https://github.com/WebKit/WebKit/commit/1832ad030f7dcd00a47615aaacc78cd351066f6f
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/KeywordLookupGenerator.py
M Source/JavaScriptCore/runtime/LiteralParser.cpp
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/text/FastCharacterComparison.h
M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp

  Log Message:
  ---
  Move fast character comparison functions from JavaScriptCore/KeywordLookup.h 
to WTF/
https://bugs.webkit.org/show_bug.cgi?id=262740

Reviewed by Yusuke Suzuki and Ryosuke Niwa.

Move fast character comparison functions from JavaScriptCore/KeywordLookup.h to 
WTF/text/FastCharacterComparison.h
and reuse them in the HTML fast parser.

I believe they may end up being useful in the trie we generate to parse element 
tag & attribute names.

* Source/JavaScriptCore/KeywordLookupGenerator.py:
(Trie.printSubTreeAsC):
* Source/JavaScriptCore/runtime/LiteralParser.cpp:
(JSC::LiteralParser::Lexer::lex):
(JSC::compare3Chars): Deleted.
(JSC::compare4Chars): Deleted.
* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/text/FastCharacterComparison.h: Added.
(WTF::compareCharacters):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanAttributeName):

Canonical link: https://commits.webkit.org/268959@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 16408a: Remove Masonry Align and Justify Tracks Test Cases

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16408a184624c8f2e25382a39498b09766f38335
  
https://github.com/WebKit/WebKit/commit/16408a184624c8f2e25382a39498b09766f38335
  Author: Brandon Stewart 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-multi-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/masonry-align-tracks-stretch-002.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/align-tracks/w3c-import.log
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-multi-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-001.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002-ref.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/justify-tracks/masonry-justify-tracks-stretch-002.html
R 
LayoutTests/imported/w3c/w

[webkit-changes] [WebKit/WebKit] 03824e: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk2 ]...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03824e18765010403cd63b78cb3c9747a547a426
  
https://github.com/WebKit/WebKit/commit/03824e18765010403cd63b78cb3c9747a547a426
  Author: Karl Rackler 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk2 ] fast/repaint/4776765.html 
is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=262753
rdar://116554252

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/268957@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b5334a: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma arm64...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5334a81ce49e539b29339af5ed3a861fa173d16
  
https://github.com/WebKit/WebKit/commit/b5334a81ce49e539b29339af5ed3a861fa173d16
  Author: Karl Rackler 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION ( Sonoma?): [ Sonoma arm64 ] 
css3/filters/effect-blur-hw.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=262750
rdar://116551869

Unreviewed test gardening.

Add test expectation.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/268956@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dea762: [iOS] Refactor some code around `UIWKTextInteracti...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dea762339998f966d7cda547c1c4e78527fd2274
  
https://github.com/WebKit/WebKit/commit/dea762339998f966d7cda547c1c4e78527fd2274
  Author: Wenson Hsieh 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/Platform/spi/ios/TextInputSPI.h
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  [iOS] Refactor some code around `UIWKTextInteractionAssistant`
https://bugs.webkit.org/show_bug.cgi?id=262725

Reviewed by Megan Gardner.

Refactor some SPI usage related to `UIWKTextInteractionAssistant`. See below 
for more details.

* Source/WTF/wtf/PlatformHave.h:

Remove `HAVE(TEXT_INTERACTION_WITH_CONTEXT_MENU_INTERACTION)`. This has been 
true for all platforms
where `USE(UICONTEXTMENU)` is also true, since iOS 16.

* Source/WebKit/Platform/spi/ios/TextInputSPI.h:
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:

Remove more SPI that's now unused.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:

Remove some unused typedefs, along with the `_contextMenuInteraction` ivar (see 
below).

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[UIGestureRecognizer _wk_isTapAndAHalf]):

Drop the `UI-` prefix when performing a class check for the tap-and-half 
gesture.

(-[WKContentView gestureRecognizer:canBePreventedByGestureRecognizer:]):

Greatly simplify this logic by removing logic to deal with the interaction 
assistant's
`-forcePressGesture`. This is `nil` for all iPad, iPhone (both 3D-touch-enabled 
and non-3D-touch
models), and Mac Catalyst, so there's no longer any need to consider this when 
checking for text
interaction gestures. Long pressing to select text now entirely relies on the 
variable loupe
gesture, whose name is `"UITextInteractionNameInteractiveRefinement"`.

(-[WKContentView 
gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):

Similarly, remove all uses of `-loupeGesture` and `-singleTapGesture`. Instead, 
cache these on the
content view as instance variables (based on gesture name) after adding them to 
the view under
`-setUpTextSelectionAssistant`.

(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView setUpTextSelectionAssistant]):

Also log a release error message in the case where either text interaction 
gestures can no longer be
found by iterating over the content view's gestures; this makes it a bit easier 
to determine when
(and if) this logic needs to be updated.

(-[WKContentView _translateForWebView:]):

Drive-by fix: remove a `-respondsToSelector` check that's no longer necessary.

(-[WKContentView 
changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView 
changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(logTextInteractionAssistantSelectionChange):
(-[WKContentView 
_selectPositionAtPoint:stayingWithinFocusedElement:completionHandler:]):
(-[WKContentView 
selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView moveSelectionAtBoundary:inDirection:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView beginSelectionInDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView 
updateSelectionWithExtentPoint:withBoundary:completionHandler:]):
(-[WKContentView _updateChangedSelection:]):

Remove logic to call into `-tintColorDidChange` on the selection view. 
`-selectionView` is actually
unconditionally `nil` on iOS 17 now, so this is just a no-op. I verified by 
manual testing (and also
by running the layout test 
`editing/caret/ios/caret-color-after-refocusing-input.html`) that this
caret-color bug remains fixed.

(-[WKContentView shouldDeferGestureDueToImageAnalysis:]):
(-[WKContentView 
deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
(-[WKContentView cancelActiveTextInteractionGestures]):
(-[WKContentView selectPositionAtPoint:withContextRequest:completionHandler:]):
(-[WKContentView contextMenuInteraction]):

Remove the `_contextMenuInteraction` ivar from the content view entirely. This 
is no longer
necessary because the context menu interaction in `WKWebView` is added 
indirectly by the text
interaction assistant, and is exposed via `-[UIWKTextInteractionAssistant 
contextMenuInteraction]`.

(-[WKContentView _registerPreview]):
(-[WKContentView _unregisterPreview]):
(-[WKContentView textInteractionAssistantContextMenuInteraction]): Deleted.

Canonical link: https://commits.webkit.org/268955@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-c

[webkit-changes] [WebKit/WebKit] e86597: REGRESSION(268913@main) clang requires std namespa...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8659754092e03a966c303b6367cb62a3b1b2cb8
  
https://github.com/WebKit/WebKit/commit/e8659754092e03a966c303b6367cb62a3b1b2cb8
  Author: Lauro Moura 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WTF/wtf/NativePromise.h

  Log Message:
  ---
  REGRESSION(268913@main) clang requires std namespace for nullptr_t
https://bugs.webkit.org/show_bug.cgi?id=262713

Reviewed by Fujii Hironori.

* Source/WTF/wtf/NativePromise.h: Add missing namespace.

Canonical link: https://commits.webkit.org/268954@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 325c99: [WGSL] Atomics should return the size and alignmen...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 325c996d6dc39c38f7cd41810a777f01da85c2d0
  
https://github.com/WebKit/WebKit/commit/325c996d6dc39c38f7cd41810a777f01da85c2d0
  Author: Mike Wyrzykowski 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/Types.cpp

  Log Message:
  ---
  [WGSL] Atomics should return the size and alignment of their underlying type
https://bugs.webkit.org/show_bug.cgi?id=262736


Reviewed by Tadeu Zagallo.

Return the size and alignment of the underlying type.

* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::size const):
(WGSL::Type::alignment const):

Canonical link: https://commits.webkit.org/268953@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29536d: [Gardening] http/tests/security/service-worker-net...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29536df45fc5aa5eb623a2d17480d8dfd32cb3f1
  
https://github.com/WebKit/WebKit/commit/29536df45fc5aa5eb623a2d17480d8dfd32cb3f1
  Author: Fujii Hironori 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [Gardening] http/tests/security/service-worker-network-load.html is randomly 
timing out since the beginning
https://bugs.webkit.org/show_bug.cgi?id=262734

Unreviewed test gardening.

* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/268952@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 76c4fe: Add Marta to contributors.json

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76c4fedb27e035c0ef4f2700117c9089e05e0e38
  
https://github.com/WebKit/WebKit/commit/76c4fedb27e035c0ef4f2700117c9089e05e0e38
  Author: Marta Darbinyan 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add Marta to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=262742
rdar://116546948

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/268951@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d644b6: Expose Tracking Protection TimeAdvanceForTesting i...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d644b6eb8b9cdca2e3308cb6555a4f5a7f08cef3
  
https://github.com/WebKit/WebKit/commit/d644b6eb8b9cdca2e3308cb6555a4f5a7f08cef3
  Author: Matthew Finkel 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  ---
  Expose Tracking Protection TimeAdvanceForTesting in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=262552
rdar://116404693

Reviewed by Alex Christensen.

The ability to advance time for testing Tracking Prevention behavior was added
in 252701@main, but it was only exposed in a way that API tests can use it.
This patch extends that functionality to layout tests.

* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::nowTime):
(WebKit::OperatingDate::today):
(WebKit::ResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsStore::resetParametersToDefaultValues):
(WebKit::ResourceLoadStatisticsStore::insertDomainRelationshipList):
(WebKit::ResourceLoadStatisticsStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsStore::setMostRecentWebPushInteractionTime):
(WebKit::ResourceLoadStatisticsStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
(WebKit::ResourceLoadStatisticsStore::appendSubStatisticList const):
(WebKit::ResourceLoadStatisticsStore::resourceToString const):
(WebKit::ResourceLoadStatisticsStore::hasStatisticsExpired const):
(WebKit::ResourceLoadStatisticsStore::insertExpiredStatisticForTesting):
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreSetResourceLoadStatisticsTimeAdvanceForTesting):
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setStatisticsTimeAdvanceForTesting):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::setStatisticsTimeAdvanceForTesting):
* Tools/WebKitTestRunner/TestController.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/268950@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d192ab: Avoid use of Vector::uncheckedAppend() in RemoteLa...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d192abf745ffb662d298d2fc84afc677f42ba031
  
https://github.com/WebKit/WebKit/commit/d192abf745ffb662d298d2fc84afc677f42ba031
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm

  Log Message:
  ---
  Avoid use of Vector::uncheckedAppend() in 
RemoteLayerTreeDrawingArea::updateRendering()
https://bugs.webkit.org/show_bug.cgi?id=262726

Reviewed by Ryosuke Niwa.

Avoid use of Vector::uncheckedAppend() in 
RemoteLayerTreeDrawingArea::updateRendering()
as this is hot code and uncheckedAppend() has recently become an alias to 
append().

* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):

Canonical link: https://commits.webkit.org/268949@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d038fb: Fix input[type=file] in vertical writing mode

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d038fb76fc05cd36a01f061093a659f7f550f08d
  
https://github.com/WebKit/WebKit/commit/d038fb76fc05cd36a01f061093a659f7f550f08d
  Author: Aditya Keerthi 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-computed-style-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-computed-style.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-horizontal.optional-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-horizontal.optional.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical-rtl.optional-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical-rtl.optional.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical.optional-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical.optional.html
M Source/WebCore/css/horizontalFormControls.css
M Source/WebCore/css/html.css
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFileUploadControl.h

  Log Message:
  ---
  Fix input[type=file] in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=248319
rdar://102651599

Reviewed by Alan Baradlay.

Update `RenderFileUploadControl` to use logical positions and sizes to support
vertical writing mode.

Added new web platform tests for file inputs, since they are unique from 
buttons.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-computed-style-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-computed-style.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-horizontal.optional-expected-mismatch.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-horizontal.optional.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical-rtl.optional-expected-mismatch.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical-rtl.optional.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical.optional-expected-mismatch.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/file-input-vertical.optional.html:
 Added.
* Source/WebCore/css/horizontalFormControls.css:
(@namespace "http://www.w3.org/1999/xhtml";;):
* Source/WebCore/css/html.css:
(select):
(select, input[type="file"]): Deleted.
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::nodeLogicalWidth):
(WebCore::nodeLogicalHeight):
(WebCore::RenderFileUploadControl::maxFilenameLogicalWidth const):
(WebCore::RenderFileUploadControl::paintControl):

Use the ascent/descent of the font to correctly position the text. If in
vertical writing mode, rotate the context prior to drawing the text.

(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths const):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
(WebCore::RenderFileUploadControl::fileTextValue const):
(WebCore::nodeWidth): Deleted.
(WebCore::nodeHeight): Deleted.
(WebCore::RenderFileUploadControl::maxFilenameWidth const): Deleted.
* Source/WebCore/rendering/RenderFileUploadControl.h:

Canonical link: https://commits.webkit.org/268948@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ebd030: [css-grid] Accumulate nested subgrids' margin, bor...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ebd030f9b8667698930ad2ffa5de7c56bbbab8cd
  
https://github.com/WebKit/WebKit/commit/ebd030f9b8667698930ad2ffa5de7c56bbbab8cd
  Author: Sammy Gill 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h

  Log Message:
  ---
  [css-grid] Accumulate nested subgrids' margin, border, and padding to base 
size of outer grid tracks.
https://bugs.webkit.org/show_bug.cgi?id=260531
rdar://114271839

Reviewed by Matt Woodrow.

Currently, if there is a subgrid we will take the sum of its margin,
border, and padding (mbp) at each edge and apply it to the track sizing
algorithm for the track the edge is in. This sum may then get applied to
the base size of the track if needed.

However, if there are nested subgrids, we need to take them into account
and accumulate their values as well so that any adjacent chunks of mbp
are considered as a single layer when sizing the track.

We can accomplish this by keeping track of a variable that stores the
accumulated value as we recurse through nested subgrids. This value will
first be set to 0 in the first call to accumulateIntrinsicSizesForTrack.
As we iterate over the track's items, if we find a subgrid we will
compute the margin, border, and padding values it contributes to the
track and add it to the variable we are using to store the accumulated
value and potentially update the track size.

The key idea is that when we recurse into a new level of a nested
subgrid we will pass along and use this updated accumulated value with
the subgrid's mbp, but as we traverse through subgrids within the same
level will: use the same accumulated value, add the subgrid's mbp to
the value, and then potentially update the track size.

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::computeSubgridMarginBorderPadding):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):
(WebCore::addSubgridMarginBorderPadding): Deleted.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:

Canonical link: https://commits.webkit.org/268947@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dd855a: Follow up fix to 268900@main

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd855a39bdd47718d622e72023390750c6bad489
  
https://github.com/WebKit/WebKit/commit/dd855a39bdd47718d622e72023390750c6bad489
  Author: Jonathan Bedard 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  Follow up fix to 268900@main
https://bugs.webkit.org/show_bug.cgi?id=262669
rdar://116428857

Reviewed by Dewei Zhu.

Broke Python 2 wheels.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archive.unpack): Conditionalize unpack logic on is_dir API in zipfile.

Canonical link: https://commits.webkit.org/268946@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e3abef: [MediaStream] Add support for ImageCapture.getPhot...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e3abeffd3a45dc0db29736fb462089f85c906a00
  
https://github.com/WebKit/WebKit/commit/e3abeffd3a45dc0db29736fb462089f85c906a00
  Author: Eric Carlson 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A LayoutTests/fast/mediastream/image-capture-get-photo-settings-expected.txt
A LayoutTests/fast/mediastream/image-capture-get-photo-settings.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources.make
M Source/WebCore/Headers.cmake
M Source/WebCore/Modules/mediastream/ImageCapture.cpp
M Source/WebCore/Modules/mediastream/ImageCapture.h
M Source/WebCore/Modules/mediastream/ImageCapture.idl
M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
M Source/WebCore/Modules/mediastream/MediaStreamTrack.h
A Source/WebCore/Modules/mediastream/PhotoSettings.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
A Source/WebCore/platform/mediastream/PhotoSettings.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp
M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h

  Log Message:
  ---
  [MediaStream] Add support for ImageCapture.getPhotoSettings
https://bugs.webkit.org/show_bug.cgi?id=262466
rdar://116322614

Reviewed by Youenn Fablet.

Add ImageCapture.getPhotoSettings and implement support in 
MockRealtimeVideoSource and
AVVideoCaptureSource.

* LayoutTests/fast/mediastream/image-capture-get-photo-settings-expected.txt: 
Added.
* LayoutTests/fast/mediastream/image-capture-get-photo-settings.html: Added.
* Source/WebCore/DerivedSources.make:

* Source/WebCore/Modules/mediastream/ImageCapture.cpp:
(WebCore::ImageCapture::getPhotoSettings):
* Source/WebCore/Modules/mediastream/ImageCapture.h:
* Source/WebCore/Modules/mediastream/ImageCapture.idl:

* Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::getPhotoSettings const):
* Source/WebCore/Modules/mediastream/MediaStreamTrack.h:

* Source/WebCore/Modules/mediastream/PhotoSettings.idl: Added.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::getPhotoSettings):
* Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h:

* Source/WebCore/platform/mediastream/PhotoSettings.h: Added.

* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::getPhotoSettings):
* Source/WebCore/platform/mediastream/RealtimeMediaSource.h:
(WebCore::PhotoSettingsOrError::PhotoSettingsOrError):
(WebCore::PhotoSettingsOrError::operator bool const):

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::toFillLightMode):
(WebCore::AVVideoCaptureSource::getPhotoSettings):

* Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::getPhotoSettings):
(WebCore::MockRealtimeVideoSource::settingsDidChange):
* Source/WebCore/platform/mock/MockRealtimeVideoSource.h:

* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):

* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::getPhotoSettings):
(WebKit::UserMediaCaptureManagerProxy::getPhotoSettings):
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:

* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
(WebKit::RemoteRealtimeMediaSource::getPhotoSettings):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h:

* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
(WebKit::RemoteRealtimeMediaSourceProxy::getPhotoSettings):
* Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:

Canonical link: https

[webkit-changes] [WebKit/WebKit] d386e1: [Gardening] REGRESSION ( Sonoma?): [ Sonoma ] fast...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d386e12701880dac480ddf17bcc730b736689357
  
https://github.com/WebKit/WebKit/commit/d386e12701880dac480ddf17bcc730b736689357
  Author: Marta Darbinyan <146287027+martadarbin...@users.noreply.github.com>
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening] REGRESSION ( Sonoma?): [ Sonoma ] 
fast/css/text-overflow-input.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=262732
rdar://116540882

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/268944@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75f8bb: Resync 'svg/text' tests from WPT upstream

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75f8bb0c2b8bbc26b237199283723ff219daff29
  
https://github.com/WebKit/WebKit/commit/75f8bb0c2b8bbc26b237199283723ff219daff29
  Author: Ahmad Saleem 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/imported/w3c/resources/resource-files.json
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/gradient-after-reposition-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/gradient-after-reposition-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/gradient-after-reposition.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-background-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-background-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-background.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-ref.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/opacity-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/opacity-ref.svg
A LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/opacity.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-clipped-offscreen-move-onscreen-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-huge-font-size-crash.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-001-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-001-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-001.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-002-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-002-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/text-transform-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change-root-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change-root-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change-root.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/transform-dynamic-change.html
M 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/writing-mode-dynamic-change-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/writing-mode-dynamic-change-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/writing-mode-dynamic-change.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/xml-lang-attribute-dynamic-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/xml-lang-attribute-dynamic.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/xml-lang-attribute-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/xml-lang-attribute.svg
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/scripted/getextentofchar-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/scripted/getextentofchar.html
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/scripted/getrotationofchar-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/svg/text/scripted/getrotationofchar.html
A 
Layout

[webkit-changes] [WebKit/WebKit] 7b193c: ScrollView::convertChildToSelf / convertSelfToChil...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b193c245074e736d83051b75490e4e6dfe0baa1
  
https://github.com/WebKit/WebKit/commit/7b193c245074e736d83051b75490e4e6dfe0baa1
  Author: Simon Fraser 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/ScrollView.cpp
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/Widget.cpp

  Log Message:
  ---
  ScrollView::convertChildToSelf / convertSelfToChild fail to take top content 
inset into account
https://bugs.webkit.org/show_bug.cgi?id=262585
rdar://116430905

Reviewed by Tim Horton.

ScrollView::convertChildToSelf() and convertSelfToChild() offset the point by 
the scroll position, but this
fails to take top content inset, and left-side scrollbars into account.

This code path isn't hit in general browsing, but future PDF plugin code needs 
it to work.

Move the implementations to the .cpp file, and use 
documentScrollPositionRelativeToViewOrigin()
instead of scrollPosition(). Pass the points by value.

* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::convertChildToSelf const):
(WebCore::ScrollView::convertSelfToChild const):
* Source/WebCore/platform/ScrollView.h:
(WebCore::ScrollView::convertChildToSelf const): Deleted.
(WebCore::ScrollView::convertSelfToChild const): Deleted.
* Source/WebCore/platform/Widget.cpp:
(WebCore::Widget::convertFromContainingView const): auto
(WebCore::Widget::convertToContainingView const): auto

Canonical link: https://commits.webkit.org/268942@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 76ad36: Align UA Stylesheet for `merror` in mathml.css

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76ad36c10382116e570ea836ac72bd0d37fcda54
  
https://github.com/WebKit/WebKit/commit/76ad36c10382116e570ea836ac72bd0d37fcda54
  Author: Ahmad Saleem 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
M LayoutTests/platform/glib/TestExpectations
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
M LayoutTests/platform/gtk/TestExpectations
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
R 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt
R 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
M 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
R 
LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
M 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt
A 
LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
R 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt
R 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
R 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt
R 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/embellished-operator-001-expected.txt
M LayoutTests/platform/mac/TestExpectations
A 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/margin-003-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt
M Source/WebCore/css/mathml.css

  Log Message:
  ---
  Align UA Stylesheet for `merror` in mathml.css

https://bugs.webkit.org/show_bug.cgi?id=262670

Reviewed by Tim Nguyen and Frédéric Wang.

This patch aligns WebKit with Web-Specification [1]:

[1] https://w3c.github.io/mathml-core/#error-message-merror

WebKit was using 'outline' rather than 'border' for `merror`, which is now 
updated in UA Stylesheet.

* Source/WebCore/css/mathml.css: As above
* 
LayoutTests/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt:
 Added Expectation File
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt:
 Rebaselined
* 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt:
 Removed
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expected.txt:
 Ditto
* 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/presentation-markup/mrow/merror-001-expecte

[webkit-changes] [WebKit/WebKit] b21509: [SVG] Add fast mode to repaintRectInLocalCoordinates

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b21509bc0fbc78ae8f1684d7211d041fbfb92038
  
https://github.com/WebKit/WebKit/commit/b21509bc0fbc78ae8f1684d7211d041fbfb92038
  Author: Yusuke Suzuki 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/svg/RenderSVGBlock.cpp
M Source/WebCore/rendering/svg/RenderSVGContainer.h
M Source/WebCore/rendering/svg/RenderSVGForeignObject.h
M Source/WebCore/rendering/svg/RenderSVGGradientStop.h
M Source/WebCore/rendering/svg/RenderSVGImage.h
M Source/WebCore/rendering/svg/RenderSVGInline.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.h
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/RenderSVGRoot.h
M Source/WebCore/rendering/svg/RenderSVGShape.h
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/RenderSVGText.h
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/rendering/svg/SVGRenderSupport.h
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h

  Log Message:
  ---
  [SVG] Add fast mode to repaintRectInLocalCoordinates
https://bugs.webkit.org/show_bug.cgi?id=262672
rdar://116499404

Reviewed by Said Abou-Hallawa.

This patch replaces repaintRectInLocalCoordinates calls with fast approximation 
version stubs. They are no difference at this point,
but approximation version will get implementation in a subsequent change.

1. This patch adds Fast and Accurate mode to repaintRectInLocalCoordinates. And 
replaces fastRepaintRectInLocalCoordinates with repaintRectInLocalCoordinates 
Fast mode.
2. We use repaintRectInLocalCoordinates Accurate mode in checkEnclosure / 
checkIntersection to keep the current behavior as is even after introducing 
approximation.
2. We add visibleRectContextForRenderTreeAsText to continue using 
repaintRectInLocalCoordinates Accurate mode for SVG RenderTreeAsText. This is 
having an option
   in VisibleRectContext and switch the calls based on this option.

* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::absoluteClippedOverflowRectForRenderTreeAsText const):
(WebCore::RenderObject::visibleRectContextForRenderTreeAsText):
* Source/WebCore/rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::clippedOverflowRect const):
* Source/WebCore/rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::fastRepaintRectInLocalCoordinates const):
(WebCore::RenderSVGInline::clippedOverflowRect const):
* Source/WebCore/rendering/svg/RenderSVGInline.h:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::addFocusRingRects const):
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::markerBoundaries const):
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
* Source/WebCore/rendering/svg/SVGRenderSupport.h:
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
* Source/WebCore/rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp:
(WebCore::LegacyRenderSVGContainer::addFocusRingRects const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp:
(WebCore::LegacyRenderSVGImage::paint):
(WebCore::LegacyRenderSVGImage::addFocusRingRects const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::LegacyRenderSVGModelObject::clippedOverflowRect const):
(WebCore::LegacyRenderSVGModelObject::outlineBoundsForRepaint const):
(WebCore::LegacyRenderSVGModelObject::absoluteFocusRingQuads):
(WebCore::LegacyRenderSVGModelObject::checkIntersection):
(WebCore::LegacyRenderSVGModelObject::checkEnclosure):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClippe

[webkit-changes] [WebKit/WebKit] 5e03ba: [safe-merge-queue] Update frequency of periodic sc...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e03ba326279956ab44d2006ff0b6b917401b64c
  
https://github.com/WebKit/WebKit/commit/5e03ba326279956ab44d2006ff0b6b917401b64c
  Author: Brianna Fan 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  [safe-merge-queue] Update frequency of periodic scheduler
https://bugs.webkit.org/show_bug.cgi?id=262632
rdar://116472019

Reviewed by Jonathan Bedard.

Updated the trigger period to 15 minutes.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/268939@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ab4ed2: Make GraphicsContextState use generated serialization

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab4ed2e78f90a5cf289cb1e49e7b7619c68e0c16
  
https://github.com/WebKit/WebKit/commit/ab4ed2e78f90a5cf289cb1e49e7b7619c68e0c16
  Author: Pascoe 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/GraphicsContextState.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Make GraphicsContextState use generated serialization
https://bugs.webkit.org/show_bug.cgi?id=262656
rdar://116488200

Reviewed by Ryosuke Niwa.

This patch starts to use generated serialization for GrahpicsContextState 
instead
of manually specifying ::encode and ::decode. There may have been a performance 
optimization
in the previous manually written encode, decode. If this is still required, we 
should generate
this serializer and create an option to replicate the optimization later.

* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::encode const): Deleted.
(WebCore::GraphicsContextState::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268938@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39c171: Save frameset resources to disk

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39c171e29d8e5b00086a7834b93784ca417bc955
  
https://github.com/WebKit/WebKit/commit/39c171e29d8e5b00086a7834b93784ca417bc955
  Author: Sihui Liu 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/editing/MarkupAccumulator.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm

  Log Message:
  ---
  Save frameset resources to disk
https://bugs.webkit.org/show_bug.cgi?id=262666
rdar://116492501

Reviewed by Ryosuke Niwa.

Add support for saving resources of frameset element to disk, like what we do 
for iframe element (268858@main).

Test: WebArchive.SaveResourcesFrame

* Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::frameForAttributeReplacement):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:

Canonical link: https://commits.webkit.org/268937@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d62f98: [JSC] Remove locking for profile updates

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d62f981d7a110a91b051ec431559dfc1972f7f8d
  
https://github.com/WebKit/WebKit/commit/d62f981d7a110a91b051ec431559dfc1972f7f8d
  Author: Yusuke Suzuki 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/ArrayProfile.cpp
M Source/JavaScriptCore/bytecode/ArrayProfile.h
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeBlock.h
M Source/JavaScriptCore/bytecode/LazyOperandValueProfile.cpp
M Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h
M Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.cpp
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/jit/JITOperations.cpp
M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
M Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp

  Log Message:
  ---
  [JSC] Remove locking for profile updates
https://bugs.webkit.org/show_bug.cgi?id=262689
rdar://116512260

Reviewed by Mark Lam.

1. ArrayProfile update actually does not need to have a lock. Let's just make 
it racy, and it is fine.
   Removing locking.
2. We use ConcurrentVector and storeStoreFence carefully to make 
LazyOperandValueProfile concurrently accessible.
   It is always added from the mutator, and read by the compiler threads. So we 
can ensure the accessible size
   by using storeStoreFence.

As a result, we no longer need to take a lock for profile update on 64bit (Note 
that valueProfileLock is NoLockingNecessary in 64bit).

* Source/JavaScriptCore/bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
* Source/JavaScriptCore/bytecode/ArrayProfile.h:
* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateAllLazyValueProfilePredictions):
(JSC::CodeBlock::updateAllArrayProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNowFromBaseline):
* Source/JavaScriptCore/bytecode/CodeBlock.h:
(JSC::CodeBlock::lazyOperandValueProfiles):
* Source/JavaScriptCore/bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::initialize):
(JSC::LazyOperandValueProfileParser::getIfPresent const):
(JSC::LazyOperandValueProfileParser::prediction const):
* Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:
* Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::emitReportValue const):
* Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):
* Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
(JSC::putByValOptimize):
(JSC::directPutByValOptimize):
* Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
* Source/JavaScriptCore/profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):

Canonical link: https://commits.webkit.org/268936@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c63f2: Change broadcastFocusedFrame to an enum

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c63f24665a5c3d41d24d8bb7ae9da82f11b1e8e
  
https://github.com/WebKit/WebKit/commit/4c63f24665a5c3d41d24d8bb7ae9da82f11b1e8e
  Author: Charlie Wolfe 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/FocusController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Change broadcastFocusedFrame to an enum
https://bugs.webkit.org/show_bug.cgi?id=262708
rdar://116529971

Reviewed by Simon Fraser.

* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):
* Source/WebCore/page/FocusController.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::frameWasFocusedInAnotherProcess):

Canonical link: https://commits.webkit.org/268935@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 47d449: Remove unused LineLayoutPath::ForcedLegacyPath enu...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47d44912c45b41835da1d291483845be40047299
  
https://github.com/WebKit/WebKit/commit/47d44912c45b41835da1d291483845be40047299
  Author: Antti Koivisto 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h

  Log Message:
  ---
  Remove unused LineLayoutPath::ForcedLegacyPath enum value
https://bugs.webkit.org/show_bug.cgi?id=262710
rdar://116531802

Reviewed by Alan Baradlay.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):
* Source/WebCore/rendering/RenderBlockFlow.h:

Canonical link: https://commits.webkit.org/268934@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 62e879: [git-webkit] Handle force pushed branch in checkout

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62e8794cc8f57c914afa1146ab1e3520915a7572
  
https://github.com/WebKit/WebKit/commit/62e8794cc8f57c914afa1146ab1e3520915a7572
  Author: Brianna Fan 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py

  Log Message:
  ---
  [git-webkit] Handle force pushed branch in checkout
https://bugs.webkit.org/show_bug.cgi?id=260874
rdar://114656165

Reviewed by Jonathan Bedard.

Resets the head of tracking branch to match remote.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.checkout):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:
(Checkout.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(TestLand.test_default):
(TestLand.test_canonicalize):
(TestLand.test_default_with_radar):
(TestLand.test_canonicalize_with_bugzilla):
(TestLandGitHub):

Canonical link: https://commits.webkit.org/268933@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3d35e: Add support for startup and installed events for w...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3d35ed194578765a4a11e2f2b3d40acea5b6010
  
https://github.com/WebKit/WebKit/commit/c3d35ed194578765a4a11e2f2b3d40acea5b6010
  Author: Timothy Hatcher 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h
M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h
M Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  ---
  Add support for startup and installed events for web extensions and
move Web Extension local storage (if base URL changed).
https://webkit.org/b/248889
https://webkit.org/b/248430
rdar://problem/105337393
rdar://problem/103261455

Reviewed by Brent Fulgham.

Added support for the runtime.onInstalled and runtime.onStartup events, as well 
as moving
the local storage if the base URL changes.

* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::fireRuntimeStartupEventIfNeeded):
(WebKit::WebExtensionContext::fireRuntimeInstalledEventIfNeeded):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::load):
(WebKit::WebExtensionContext::currentState const):
(WebKit::WebExtensionContext::readStateFromStorage):
(WebKit::WebExtensionContext::moveLocalStorageIfNeeded):
(WebKit::WebExtensionContext::loadBackgroundWebViewDuringLoad):
(WebKit::WebExtensionContext::queueStartupAndInstallEventsForExtensionIfNecessary):
(WebKit::WebExtensionContext::loadBackgroundPageListenersFromStorage):
(WebKit::WebExtensionContext::saveBackgroundPageListenersToStorage):
(WebKit::WebExtensionContext::performTasksAfterBackgroundContentLoads):
(WebKit::WebExtensionContext::queueEventToFireAfterBackgroundContentLoads):
(WebKit::WebExtensionContext::loadBackgroundPageListenersVersionNumberFromStorage):
 Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::storageDirectory const):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
(WebKit::WebExtensionContext::storageIsPersistent const):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp:
(WebKit::WebExtensionController::WebExtensionController):
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
(WebKit::WebExtensionController::isFreshlyCreated const):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm:
(WebKit::WebExtensionAPIRuntime::onInstalled):
(WebKit::WebExtensionAPIRuntime::onStartup):
(WebKit::toWebAPI):
(WebKit::WebExtensionContextProxy::dispatchRuntimeInstalledEvent):
(WebKit::WebExtensionContextProxy::dispatchRuntimeStartupEvent):
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIRuntime.h:
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIRuntime.idl:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.h:
* Source/WebKit/WebProcess/Extensions/WebExtensionContextProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionManager runForTimeInterval:]):

Canonical link: https://commits.webkit.org/268932@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3544bc: Mark RemoteLayerTreeDrawingArea virtual functions ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3544bc8736460afe5b00ae246b231df865a3c1cf
  
https://github.com/WebKit/WebKit/commit/3544bc8736460afe5b00ae246b231df865a3c1cf
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
M Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h

  Log Message:
  ---
  Mark RemoteLayerTreeDrawingArea virtual functions as `final` when possible
https://bugs.webkit.org/show_bug.cgi?id=262706

Reviewed by Brent Fulgham.

* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::willCommitLayerTree):
* Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h:

Canonical link: https://commits.webkit.org/268931@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b29ee: Remove redundant MediaEngineSupportParameters enco...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b2932af551052a4eca7daecfde18285e65e
  
https://github.com/WebKit/WebKit/commit/8b2932af551052a4eca7daecfde18285e65e
  Author: Gavin Phillips 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/MediaPlayer.h

  Log Message:
  ---
  Remove redundant MediaEngineSupportParameters encoder/decoder
https://bugs.webkit.org/show_bug.cgi?id=262695
rdar://116518636

Reviewed by Alex Christensen.

Clean up a redundant encoder/decoder pair for MediaEngineSupportParameters
which was left after a previous port.

* Source/WebCore/platform/graphics/MediaPlayer.h:
(WebCore::MediaEngineSupportParameters::encode const): Deleted.
(WebCore::MediaEngineSupportParameters::decode): Deleted.

Canonical link: https://commits.webkit.org/268930@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f76ee0: Remove unused "findSlope" in GeometryUtilities.cpp|h

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f76ee041e185992ac0b7bfbc749d17dfaa710af8
  
https://github.com/WebKit/WebKit/commit/f76ee041e185992ac0b7bfbc749d17dfaa710af8
  Author: Ahmad Saleem 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/GeometryUtilities.cpp
M Source/WebCore/platform/graphics/GeometryUtilities.h

  Log Message:
  ---
  Remove unused "findSlope" in GeometryUtilities.cpp|h

https://bugs.webkit.org/show_bug.cgi?id=262701

Reviewed by Alexey Proskuryakov.

This patch removes 'findSlope' function since it is unused.

* Source/WebCore/platform/graphics/GeometryUtilities.cpp:
(findSlope):
* Source/WebCore/platform/graphics/GeometryUtilities.h:

Canonical link: https://commits.webkit.org/268929@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 94edba: [css-grid] Consider sum of non-orthogonal nested s...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94edbaabbf368aa6ffa9a0d21601c668a0ba095a
  
https://github.com/WebKit/WebKit/commit/94edbaabbf368aa6ffa9a0d21601c668a0ba095a
  Author: Sammy Gill 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-005-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-006-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-007-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-008-expected.txt
M Source/WebCore/rendering/GridBaselineAlignment.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp

  Log Message:
  ---
  [css-grid] Consider sum of non-orthogonal nested subgrids' margin,
border,  and padding for first baseline alignment in the column axis.
https://bugs.webkit.org/show_bug.cgi?id=262605
rdar://problem/116443747

Reviewed by Matt Woodrow.

To compute the extra layer of margin for subridded items in this
scenario, we will simply walk up the subgrid ancestors until we reach
the outermost parent grid. For each subgrid, we will take its mbp and
add it to a cumulative offset value. By the time we reach the outermost
parent grid we should have a sum of all of the nested subgrid margin,
border, and padding values.

If at any point we run into an orthogonal subgrid we will return 0 to
fallback to previous behavior.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-005-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-006-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-007-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/subgrid/subgrid-baseline-008-expected.txt:
* Source/WebCore/rendering/GridBaselineAlignment.cpp:
(WebCore::GridBaselineAlignment::ascentForChild const):

Canonical link: https://commits.webkit.org/268928@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d0f46b: [IFC][Integration] Allow RenderView layout by IFC

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d0f46be6d47ee24ab4a015d8fcc577ea71c0062b
  
https://github.com/WebKit/WebKit/commit/d0f46be6d47ee24ab4a015d8fcc577ea71c0062b
  Author: Antti Koivisto 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/RenderView.h

  Log Message:
  ---
  [IFC][Integration] Allow RenderView layout by IFC
https://bugs.webkit.org/show_bug.cgi?id=262705
rdar://116525525

Reviewed by Alan Baradlay.

In some cases (like if the document element has display:inline) root content 
will be laid out by IFC.

We currently use the LFC initial containing block box as a place to parent 
subtrees that are not
fully connected via ancestor chain (because we don't yet create layout boxes 
for all blocks).
Because of this the natural solution of just making RenderView::layoutBox() 
same as
RenderView::initialContainBlock() does not work. Instead this patch makes 
RenderView::layoutBox()
return a separate box parented to the initial containing block box.

* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::BoxTree):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::~RenderView):

Ensure we delete line layout if it exits before we delete the initial 
containing block.

* Source/WebCore/rendering/RenderView.h:

Canonical link: https://commits.webkit.org/268927@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b80fb: Fix keyboard selection of RenderListBox in vertica...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b80fb7e578a41ef2510bc60c95b8e6543b93710
  
https://github.com/WebKit/WebKit/commit/8b80fb7e578a41ef2510bc60c95b8e6543b93710
  Author: Aditya Keerthi 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/html/HTMLSelectElement.cpp

  Log Message:
  ---
  Fix keyboard selection of RenderListBox in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=261804
rdar://115766451

Reviewed by Wenson Hsieh.

In horizontal writing mode, the down and up arrow keys can be used to select the
next and previous option respectively. Adjust the arrow keys used for vertical
writing mode.

The added test will pass once  is enabled under the vertical form 
controls feature.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html:
 Added.
* LayoutTests/platform/ios/TestExpectations:

`RenderListBox` is not used on iOS.

* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

`vertical-lr`: Right and left arrow keys can be used for next and previous 
respectively.
`vertical-rl`: Left and right arrow keys can be used for next and previous 
respectively.
Canonical link: https://commits.webkit.org/268926@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db838b: [Gardening]: REGRESSION (265615@main): [ Sonoma ] ...

[Karl Rackler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db838b42d907a89107d73971eec26e092170eee5
  
https://github.com/WebKit/WebKit/commit/db838b42d907a89107d73971eec26e092170eee5
  Author: Karl Rackler 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (265615@main): [ Sonoma ] 
fast/attachment/cocoa/wide-attachment-rendering.html is a constant failure
rdar://114294654

Unreviewed test gardening.

Adding test expectation to override the test directory expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/268925@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c63ed: AX: Missing type in AXIsolatedObject::setProperty.

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c63edf7c0def8f95ccd880fc19df0d73cb3a2c3
  
https://github.com/WebKit/WebKit/commit/0c63edf7c0def8f95ccd880fc19df0d73cb3a2c3
  Author: Andres Gonzalez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

  Log Message:
  ---
  AX: Missing type in AXIsolatedObject::setProperty.
https://bugs.webkit.org/show_bug.cgi?id=262702


Reviewed by Tyler Wilcock.

This causes a crash assert in debug builds. Adding the IntRect missing type to 
the switchOn call.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::setProperty):

Canonical link: https://commits.webkit.org/268924@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4905aa: Reduce indirection in Path / PathStream

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4905aa0e344500a0fcbbc873abed049ba6dd28c4
  
https://github.com/WebKit/WebKit/commit/4905aa0e344500a0fcbbc873abed049ba6dd28c4
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/graphics/Path.cpp
M Source/WebCore/platform/graphics/Path.h
M Source/WebCore/platform/graphics/PathImpl.h
M Source/WebCore/platform/graphics/PathStream.cpp
M Source/WebCore/platform/graphics/PathStream.h
M Source/WebCore/platform/graphics/cairo/PathCairo.cpp
M Source/WebCore/platform/graphics/cairo/PathCairo.h
M Source/WebCore/platform/graphics/cg/PathCG.cpp
M Source/WebCore/platform/graphics/cg/PathCG.h

  Log Message:
  ---
  Reduce indirection in Path / PathStream
https://bugs.webkit.org/show_bug.cgi?id=262623

Reviewed by Simon Fraser.

Reduce indirection in Path / PathStream. PathStream now olds the vector of
segments directly instead of using another heap-allocated refcounted object
to hold the segment vector. This refcounted object was used to facilitate
sharing and copy on write. However, we can achieve the same thing by having
the Path objects sharing the same PathStream and cloning the PathStream only
on write.

Path::ensureImpl() was showing as a big source of fastMalloc() in profiles
and this should help with that.

* Source/WebCore/platform/graphics/Path.cpp:
(WebCore::Path::Path):
(WebCore::Path::operator== const):
(WebCore::Path::setImpl):
(WebCore::Path::asImpl):
(WebCore::Path::asImpl const):
(WebCore::Path::operator=): Deleted.
* Source/WebCore/platform/graphics/Path.h:
* Source/WebCore/platform/graphics/PathImpl.h:
* Source/WebCore/platform/graphics/PathStream.cpp:
(WebCore::PathStream::create):
(WebCore::PathStream::PathStream):
(WebCore::PathStream::copy const):
(WebCore::PathStream::lastIfMoveTo const):
(WebCore::PathStream::applySegments const):
(WebCore::PathStream::applyElements const):
(WebCore::PathStream::transform):
(WebCore::PathStream::singleSegment const):
(WebCore::PathStream::isClosed const):
(WebCore::PathStream::currentPoint const):
(WebCore::PathStream::fastBoundingRect const):
(WebCore::PathStream::boundingRect const):
(WebCore::PathStream::clone const): Deleted.
(WebCore::PathStream::operator== const): Deleted.
(WebCore::PathStream::segments const): Deleted.
* Source/WebCore/platform/graphics/PathStream.h:
* Source/WebCore/platform/graphics/cg/PathCG.cpp:
(WebCore::PathCG::create):
(WebCore::PathCG::copy const):
(WebCore::PathCG::clone const): Deleted.
(WebCore::PathCG::operator== const): Deleted.
* Source/WebCore/platform/graphics/cg/PathCG.h:

Canonical link: https://commits.webkit.org/268923@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aff9d6: AX: AXIsolatedObject::objectAttributeValue should ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aff9d67b9c8fe4a6a0afe4b53207a9c5b46e7de0
  
https://github.com/WebKit/WebKit/commit/aff9d67b9c8fe4a6a0afe4b53207a9c5b46e7de0
  Author: Tyler Wilcock 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h

  Log Message:
  ---
  AX: AXIsolatedObject::objectAttributeValue should return an AXIsolatedObject
https://bugs.webkit.org/show_bug.cgi?id=262683
rdar://problem/116507428

Reviewed by Chris Fleizach.

This improves type safety, gives the optimizer more information to work with, 
and generally makes more
sense (an AXIsolatedObject should never be able to return the other 
AXCoreObject variant, AccessibilityObject).

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::cellForColumnAndRow):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::focusedUIElement const):
(WebCore::AXIsolatedObject::scrollBar):
(WebCore::AXIsolatedObject::accessibilityHitTest const):
(WebCore::AXIsolatedObject::objectAttributeValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:

Canonical link: https://commits.webkit.org/268922@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0b86d6: Reduce use of Vector::uncheckedAppend() in Source/...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b86d6fe93fb09acdf376295705fda5e709051ab
  
https://github.com/WebKit/WebKit/commit/0b86d6fe93fb09acdf376295705fda5e709051ab
  Author: Chris Dumez 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WebGPU/PipelineLayout.mm
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
M Source/WebKit/Platform/cocoa/CocoaHelpers.mm
M Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm
M Source/WebKit/Shared/API/c/WKArray.cpp
M Source/WebKit/Shared/APIWebArchive.mm
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm
M Source/WebKit/UIProcess/Cocoa/WKContactPicker.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm
M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
M Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
M Source/WebKit/UIProcess/WebBackForwardList.cpp
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebURLSchemeHandler.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderPassEncoderProxy.cpp
M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Reduce use of Vector::uncheckedAppend() in Source/WebKit
https://bugs.webkit.org/show_bug.cgi?id=262674

Reviewed by Timothy Hatcher.

Reduce use of Vector::uncheckedAppend() in Source/WebKit and use faster
alternatives now that uncheckedAppend() is an alias to append().

* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::Device::createPipelineLayout):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setCORSDisablingPatterns):
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::remove):
* Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp:
(WebKit::CacheStorageDiskStore::readAllRecordInfos):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
* Source/WebKit/Platform/cocoa/CocoaHelpers.mm:
(WebKit::toImpl):
* Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::floatQuads):
* Source/WebKit/Shared/API/c/WKArray.cpp:
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
* Source/WebKit/Shared/APIWebArchive.mm:
(API::WebArchive::WebArchive):
(API::WebArchive::subresources):
(API::WebArchive::subframeArchives):
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::createHandlesForResources):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _completeTextManipulation:completion:]):
(-[WKWebView _completeTextManipulationForItems:completion:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setCustomHeaderFields:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _getAllStorageAccessEntriesFor:completionHandler:]):
(-[WKWebsiteDataStore _appBoundDomains:]):
(-[WKWebsiteDataStore _appBoundSchemes:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(publicKeyCredentialParameters):
(authenticatorTransports):
(publicKeyCredentialDescriptors):
* Source/WebKit/UIProcess/Automation/SimulatedInputDispatcher.cpp:
(WebKit::SimulatedInputKeyFrame::keyFrameFromStateOfInputSources):
(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources):
* Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
* Source/WebKit/UIProcess/Cocoa/WKContactPicker.mm:
(-[WKContactPicker contactPicker:didSelectContacts:]):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm:
(WebKit::WebExtensionContext::alarmsGetAll):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::openWindows const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebEx

[webkit-changes] [WebKit/WebKit] bf1e12: Unreviewed, fix the internal iOS build after 26847...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf1e125be636b083adc5de7dab50585300074ffc
  
https://github.com/WebKit/WebKit/commit/bf1e125be636b083adc5de7dab50585300074ffc
  Author: Wenson Hsieh 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Unreviewed, fix the internal iOS build after 268470@main
https://bugs.webkit.org/show_bug.cgi?id=262006
rdar://114331777

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _asyncDragInteraction:prepareDragSession:completion:]):
(-[WKContentView 
_asyncDragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):

Rename these to conform to the underscore-prefixed protocol methods that were 
merged in rdar://112471706.

(-[WKContentView asyncDragInteraction:prepareDragSession:completion:]): Deleted.
(-[WKContentView 
asyncDragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]): 
Deleted.

Canonical link: https://commits.webkit.org/268920@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d49622: Make selection focus work with site isolation

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d496225829b3f96f82bce1d5bf2e847a7fab6769
  
https://github.com/WebKit/WebKit/commit/d496225829b3f96f82bce1d5bf2e847a7fab6769
  Author: Charlie Wolfe 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A LayoutTests/http/tests/site-isolation/resources/selected-text.html
A LayoutTests/http/tests/site-isolation/selection-focus-expected.html
A LayoutTests/http/tests/site-isolation/selection-focus.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/FocusController.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  ---
  Make selection focus work with site isolation
https://bugs.webkit.org/show_bug.cgi?id=262653
rdar://116486773

Reviewed by Alex Christensen.

In 268570@main I added `FocusController::updateFocusedFrame()` to avoid an IPC 
loop when broadcasting the
focused frame to other site-isolated frames. 
`FocusController::setFocusedFrame()` sets other things that
should also be kept up to date in all web processes such as selection focus, so 
we should just keep using
that. Avoid the IPC loop by adding a `broadcastFocusedFrame` bool that we set 
to false when we don’t need
to notify the UI process that a frame was updated.

* LayoutTests/http/tests/site-isolation/resources/selected-text.html: Added.
* LayoutTests/http/tests/site-isolation/selection-focus-expected.html: Added.
* LayoutTests/http/tests/site-isolation/selection-focus.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedFrame):
* Source/WebCore/page/FocusController.h:
(WebCore::FocusController::updateFocusedFrame): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::frameWasFocusedInAnotherProcess):

Canonical link: https://commits.webkit.org/268919@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 194c42: Implement window.location for site-isolated iframes

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 194c42fd694410278bc8a19d998239cfe043667f
  
https://github.com/WebKit/WebKit/commit/194c42fd694410278bc8a19d998239cfe043667f
  Author: Alex Christensen 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A 
LayoutTests/http/tests/site-isolation/resources/window-properties-child-2.html
M 
LayoutTests/http/tests/site-isolation/resources/window-properties-grandchild.html
M LayoutTests/http/tests/site-isolation/window-properties-expected.txt
M LayoutTests/http/tests/site-isolation/window-properties.html
M Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp
M Source/WebCore/bindings/js/JSDOMBindingSecurity.h
M Source/WebCore/page/DOMWindow.cpp
M Source/WebCore/page/DOMWindow.h
M Source/WebCore/page/DOMWindow.idl
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalDOMWindow.idl
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/Location.h
M Source/WebCore/page/RemoteDOMWindow.cpp
M Source/WebCore/page/RemoteDOMWindow.h
M Source/WebCore/page/RemoteDOMWindow.idl

  Log Message:
  ---
  Implement window.location for site-isolated iframes
https://bugs.webkit.org/show_bug.cgi?id=262634
rdar://116203895

Reviewed by Pascoe.

window.location needs to be accessible on a RemoteDOMWindow, but its accessors 
need to throw security exceptions.
However, setting the location should navigate the frame.  I added tests that 
verify this is the case.
I moved the Location getter and setter from LocalDOMWindow to DOMWindow to 
share code when possible.

* 
LayoutTests/http/tests/site-isolation/resources/window-properties-child-2.html: 
Added.
* 
LayoutTests/http/tests/site-isolation/resources/window-properties-grandchild.html:
* LayoutTests/http/tests/site-isolation/window-properties-expected.txt:
* LayoutTests/http/tests/site-isolation/window-properties.html:
* Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:
(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow):
* Source/WebCore/bindings/js/JSDOMBindingSecurity.h:
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::location):
(WebCore::root):
* Source/WebCore/page/DOMWindow.h:
* Source/WebCore/page/DOMWindow.idl:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::location): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalDOMWindow.idl:
* Source/WebCore/page/Location.cpp:
(WebCore::Location::Location):
(WebCore::Location::frame):
(WebCore::Location::frame const):
(WebCore::Location::url const):
(WebCore::Location::setProtocol):
(WebCore::Location::setHost):
(WebCore::Location::setHostname):
(WebCore::Location::setPort):
(WebCore::Location::setPathname):
(WebCore::Location::setSearch):
(WebCore::Location::setHash):
(WebCore::Location::replace):
(WebCore::Location::reload):
(WebCore::Location::setLocation):
* Source/WebCore/page/Location.h:
* Source/WebCore/page/RemoteDOMWindow.cpp:
(WebCore::RemoteDOMWindow::location const): Deleted.
* Source/WebCore/page/RemoteDOMWindow.h:
* Source/WebCore/page/RemoteDOMWindow.idl:

Canonical link: https://commits.webkit.org/268918@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ced838: Port MockMediaDevice & related to the new IPC seri...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ced8381ea44d67bb2493907afbe88a39e410ec03
  
https://github.com/WebKit/WebKit/commit/ced8381ea44d67bb2493907afbe88a39e410ec03
  Author: Gavin Phillips 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/platform/mock/MockMediaDevice.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Port MockMediaDevice & related to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=262692
rdar://116518406

Reviewed by Alex Christensen.

Port MockMediaDevice & related to the new IPC serialization format. This
includes:
- MockMicrophoneProperties
- MockSpeakerProperties
- MockCameraProperties
- MockDisplayProperties
- MockMediaDevice::Flag
- MockMediaDevice

* Source/WebCore/platform/mock/MockMediaDevice.h:
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMicrophoneProperties::encode const): Deleted.
(WebCore::MockMicrophoneProperties::decode): Deleted.
(WebCore::MockSpeakerProperties::encode const): Deleted.
(WebCore::MockSpeakerProperties::decode): Deleted.
(WebCore::MockCameraProperties::encode const): Deleted.
(WebCore::MockCameraProperties::decode): Deleted.
(WebCore::MockDisplayProperties::encode const): Deleted.
(WebCore::MockDisplayProperties::decode): Deleted.
(WebCore::MockMediaDevice::encode const): Deleted.
(WebCore::MockMediaDevice::decodeMockMediaDevice): Deleted.
(WebCore::MockMediaDevice::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268917@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac0a3c: Port WebPageNetworkParameters & ResourceLoadInfo t...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac0a3c8eb37a06b9941c6a774149e13fb4beeb92
  
https://github.com/WebKit/WebKit/commit/ac0a3c8eb37a06b9941c6a774149e13fb4beeb92
  Author: Gavin Phillips 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/ResourceLoadInfo.h
A Source/WebKit/Shared/ResourceLoadInfo.serialization.in
R Source/WebKit/Shared/WebPageNetworkParameters.cpp
M Source/WebKit/Shared/WebPageNetworkParameters.h
A Source/WebKit/Shared/WebPageNetworkParameters.serialization.in
M Source/WebKit/Sources.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Port WebPageNetworkParameters & ResourceLoadInfo to the new serialization 
format
https://bugs.webkit.org/show_bug.cgi?id=262659.
rdar://116489718

Reviewed by Alex Christensen.

Port WebPageNetworkParameters, ResourceLoadInfo & ResourceLoadInfo::Type
to the new serialization format.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/ResourceLoadInfo.h:
(WebKit::ResourceLoadInfo::encode const): Deleted.
(WebKit::ResourceLoadInfo::decode): Deleted.
* Source/WebKit/Shared/ResourceLoadInfo.serialization.in: Added.
* Source/WebKit/Shared/WebPageNetworkParameters.cpp: Removed.
* Source/WebKit/Shared/WebPageNetworkParameters.h:
* Source/WebKit/Shared/WebPageNetworkParameters.serialization.in: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/268916@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ca7809: Update serialization for types including RunJavaSc...

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca78091637abb9e8d44bd629de175c225ca9463e
  
https://github.com/WebKit/WebKit/commit/ca78091637abb9e8d44bd629de175c225ca9463e
  Author: Simon Lewis 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/PAL/pal/SessionID.h
M Source/WebCore/bindings/js/RunJavaScriptParameters.h
M Source/WebCore/platform/graphics/PlatformColorSpace.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Update serialization for types including RunJavaScriptParameters
https://bugs.webkit.org/show_bug.cgi?id=262662
rdar://116490225

Reviewed by Alex Christensen.

* Source/WebCore/PAL/pal/SessionID.h:
(PAL::SessionID::encode const): Deleted.
(PAL::SessionID::decode): Deleted.
* Source/WebCore/bindings/js/RunJavaScriptParameters.h:
(WebCore::RunJavaScriptParameters::RunJavaScriptParameters):
(WebCore::RunJavaScriptParameters::encode const): Deleted.
(WebCore::RunJavaScriptParameters::decode): Deleted.
* Source/WebCore/platform/graphics/PlatformColorSpace.h:
(WebCore::PlatformColorSpace::encode const): Deleted.
(WebCore::PlatformColorSpace::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268915@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71a0de: Detach InlineFormattingContext from FormattingCont...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71a0ded8866160e4f9ae799050094fc4d1856aa9
  
https://github.com/WebKit/WebKit/commit/71a0ded8866160e4f9ae799050094fc4d1856aa9
  Author: Alan Baradlay 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/FormattingContext.cpp
M Source/WebCore/layout/formattingContexts/FormattingContext.h
M Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
M Source/WebCore/layout/formattingContexts/inline/InlineQuirks.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  Detach InlineFormattingContext from FormattingContext base class
https://bugs.webkit.org/show_bug.cgi?id=262588

Reviewed by Antti Koivisto.

Different formatting contexts don't have much shared logic after all.
With this change, IFC is completely decoupled (context, geometry, quirk) from 
the rest of the LFC codebase.

* Source/WebCore/layout/formattingContexts/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
* Source/WebCore/layout/formattingContexts/FormattingContext.h:
(WebCore::Layout::FormattingContext::isBlockFormattingContext const):
(WebCore::Layout::FormattingContext::isInlineFormattingContext const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp:
(WebCore::Layout::InlineContentBalancer::initialize):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):
(WebCore::Layout::InlineFormattingContext::layout):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::layoutFloatContentOnly):
(WebCore::Layout::InlineFormattingContext::updateInlineLayoutStateWithLineLayoutResult):
(WebCore::Layout::InlineFormattingContext::createDisplayContentForInlineContent):
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLineFromCachedContent):
(WebCore::Layout::InlineFormattingContext::initializeInlineLayoutState):
(WebCore::Layout::isOkToAccessBoxGeometry):
(WebCore::Layout::InlineFormattingContext::geometryForBox const):
(WebCore::Layout::InlineFormattingContext::geometryForBox):
(WebCore::Layout::InlineFormattingContext::initializeLayoutState): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::root const):
(WebCore::Layout::InlineFormattingContext::layoutState):
(WebCore::Layout::InlineFormattingContext::layoutState const):
(WebCore::Layout::InlineFormattingContext::inlineLayoutState): Deleted.
(WebCore::Layout::InlineFormattingContext::inlineLayoutState const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::inlineLevelBoxAffectsLineBox const):
(WebCore::Layout::InlineFormattingUtils::initialLineHeight const):
(WebCore::Layout::InlineFormattingUtils::layoutState const):
(WebCore::Layout::InlineFormattingUtils::inlineLayoutState const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:
(WebCore::Layout::LineBoxBuilder::layoutState const):
(WebCore::Layout::LineBoxBuilder::blockLayoutState const):
(WebCore::Layout::LineBoxBuilder::inlineLayoutState const): Deleted.
* 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):
* 
Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.

[webkit-changes] [WebKit/WebKit] 93421f: NativePromise can't take callbacks defined with `a...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93421fec4bd155e1115459f55e01423771bf2c85
  
https://github.com/WebKit/WebKit/commit/93421fec4bd155e1115459f55e01423771bf2c85
  Author: Jean-Yves Avenard 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WTF/wtf/NativePromise.h
M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp

  Log Message:
  ---
  NativePromise can't take callbacks defined with `auto`
https://bugs.webkit.org/show_bug.cgi?id=262678
rdar://116505009

Reviewed by Youenn Fablet.

Use more modern C++ (C++17) to compute the arguments and prototype of the
lambdas passed to whenSettle/then.
This allows to use the simpler `auto` declaration.

Thanks to Gerald Squelart for providing the technical solution.

Fly-by fixes: rename the remaining ResolveReject reference to Settled

Added API tests to check that compilation works as expected.

* Source/WTF/wtf/NativePromise.h:
* Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/268913@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1fc26a: Terrible video quality when using TransformStream ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fc26a73bcc7fe0b58abd15422048e7023650dcc
  
https://github.com/WebKit/WebKit/commit/1fc26a73bcc7fe0b58abd15422048e7023650dcc
  Author: Youenn Fablet 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A LayoutTests/http/wpt/webrtc/video-script-transform-simulcast-expected.txt
A LayoutTests/http/wpt/webrtc/video-script-transform-simulcast.html
M LayoutTests/platform/glib/TestExpectations
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.h

  Log Message:
  ---
  Terrible video quality when using TransformStream with Simulcast
https://bugs.webkit.org/show_bug.cgi?id=257803
rdar://110395571

Reviewed by Jean-Yves Avenard.

The libwebrtc backend provides one callback per ssrc generated by a sender.
In non simulcast cases, there is only one callback.
In simulcast case, there is one callback per simulcast encoding.
Before the patch, we would use one callback for all video encoded frames, thus 
sending all simulcast streams in the same ssrc.
This would confuse receivers and would lead to decoding failures, leading to 
sending PLI/FIR, thus leading to bad video quality.

We are now storing these callbacks in a map, and use the callback associated to 
the ssrc of the frame.
This allows to correctly send each simulcast stream with its associated ssrc.

Covered by added test case.

* LayoutTests/http/wpt/webrtc/video-script-transform-simulcast-expected.txt: 
Added.
* LayoutTests/http/wpt/webrtc/video-script-transform-simulcast.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.cpp:
(WebCore::LibWebRTCRtpTransformBackend::addOutputCallback):
(WebCore::LibWebRTCRtpTransformBackend::removeOutputCallback):
(WebCore::LibWebRTCRtpTransformBackend::sendFrameToOutput):
(WebCore::LibWebRTCRtpTransformBackend::processTransformedFrame):
(WebCore::LibWebRTCRtpTransformBackend::Transform):
(WebCore::LibWebRTCRtpTransformBackend::RegisterTransformedFrameCallback):
(WebCore::LibWebRTCRtpTransformBackend::RegisterTransformedFrameSinkCallback):
(WebCore::LibWebRTCRtpTransformBackend::UnregisterTransformedFrameCallback):
(WebCore::LibWebRTCRtpTransformBackend::UnregisterTransformedFrameSinkCallback):
(WebCore::LibWebRTCRtpTransformBackend::setOutputCallback): Deleted.
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformBackend.h:

Canonical link: https://commits.webkit.org/268912@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 455093: https://wpt.fyi/results/mst-content-hint/RTCRtpSen...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 455093e8095681827e95fdb560bf42e9b25584d0
  
https://github.com/WebKit/WebKit/commit/455093e8095681827e95fdb560bf42e9b25584d0
  Author: Youenn Fablet 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference-expected.txt
M LayoutTests/webrtc/video-getParameters.html
M Source/WebCore/Modules/mediastream/RTCRtpSendParameters.h
M Source/WebCore/Modules/mediastream/RTCRtpSendParameters.idl
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp

  Log Message:
  ---
  
https://wpt.fyi/results/mst-content-hint/RTCRtpSendParameters-degradationEffect.html
 shows that degradationPreference is not unset initially
https://bugs.webkit.org/show_bug.cgi?id=262609
rdar://116454410

Reviewed by Jean-Yves Avenard.

Update the WebIDL according 
https://w3c.github.io/mst-content-hint/#dom-rtcdegradationpreference.
We remove the default value and make degradationPreference optional.

This improves some WPT tests, but we have to mark 
imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect.html
 as failing for now.
The failing messafge is changing everytime.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference-expected.txt:
* LayoutTests/webrtc/video-getParameters.html:
* Source/WebCore/Modules/mediastream/RTCRtpSendParameters.h:
(): Deleted.
* Source/WebCore/Modules/mediastream/RTCRtpSendParameters.idl:
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:
(WebCore::updateRTCRtpSendParameters):

Canonical link: https://commits.webkit.org/268911@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fa21df: [LFC][Floats] FloatingContext does not need to kno...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa21df0a49798a38ea8520f3550333950cc2324c
  
https://github.com/WebKit/WebKit/commit/fa21df0a49798a38ea8520f3550333950cc2324c
  Author: Alan Baradlay 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebCore/layout/floats/FloatingContext.cpp
M Source/WebCore/layout/floats/FloatingContext.h
M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  ---
  [LFC][Floats] FloatingContext does not need to know about the initiating 
FormattingContext
https://bugs.webkit.org/show_bug.cgi?id=262580

Reviewed by Antti Koivisto.

FloatingContext needs to know what the initiating root is (as the PlacedFloats 
may have a different root) and have access to containing block (box) geometry.
(This is also in preparation for detaching InlineFormattingContext from the 
base FormattingContext class).

* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::FloatingContext):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::constraints const):
(WebCore::Layout::FloatingContext::absoluteCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToPlacedFloatsRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToPlacedFloatsRoot
 const):
* Source/WebCore/layout/floats/FloatingContext.h:
(WebCore::Layout::FloatingContext::root const):
(WebCore::Layout::FloatingContext::containingBlockGeometries const):
(WebCore::Layout::FloatingContext::formattingContext const): Deleted.
* Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp:
(WebCore::Layout::FormattingGeometry::complicatedCases const):
* Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::usedContentHeight const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::layoutFloatContentOnly):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
(WebCore::Layout::InlineFormattingContext::floatingContext const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustOutsideListMarkersPosition):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::LineBuilder):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/268910@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c485e8: [WGSL] Pack nested structs

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c485e8898b6315153d2298a263f2c3ae95a33218
  
https://github.com/WebKit/WebKit/commit/c485e8898b6315153d2298a263f2c3ae95a33218
  Author: Tadeu Zagallo 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/WGSLShaderModule.h
M Source/WebGPU/WGSL/tests/valid/packing.wgsl

  Log Message:
  ---
  [WGSL] Pack nested structs
https://bugs.webkit.org/show_bug.cgi?id=262626
rdar://116467765

Reviewed by Mike Wyrzykowski.

We were failing to pack structs referenced by other packed structs. In order to
avoid excessive rewriting of the AST, we simply generate the packed structs, but
leave it up to the code generator to update the struct fields.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::pack):
(WGSL::RewriteGlobalVariables::packArrayResource):
(WGSL::RewriteGlobalVariables::packType):
(WGSL::RewriteGlobalVariables::packStructType):
(WGSL::RewriteGlobalVariables::packArrayType):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::usesPackedStructs const):
(WGSL::ShaderModule::setUsesPackedStructs):
(WGSL::ShaderModule::clearUsesPackedStructs):
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:

Canonical link: https://commits.webkit.org/268909@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8801e: NEW TEST(265708@main): [ wk2 ] fast/mediastream/vi...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8801edb72066c945f69d34863752f34cb56f2a9
  
https://github.com/WebKit/WebKit/commit/a8801edb72066c945f69d34863752f34cb56f2a9
  Author: Youenn Fablet 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
R LayoutTests/fast/mediastream/video-srcObject-set-twice-expected.html
A LayoutTests/fast/mediastream/video-srcObject-set-twice-expected.txt
M LayoutTests/fast/mediastream/video-srcObject-set-twice.html
M LayoutTests/platform/wk2/TestExpectations

  Log Message:
  ---
  NEW TEST(265708@main): [ wk2 ] 
fast/mediastream/video-srcObject-set-twice.html is a flaky ImageOnlyFailure.
https://bugs.webkit.org/show_bug.cgi?id=261920
rdar://115868374

Reviewed by Jean-Yves Avenard.

The flakiness comes from the fact that the canvas capture video frame is not 
always properly rendered.
While we should fix this, we can make the test no longer flaky by relying on 
the existing take snapshot test.
This keeps the current coverage of the test which is to check that setting 
twice srcObject will still allow rendering video.

* LayoutTests/fast/mediastream/video-srcObject-set-twice-expected.html: Removed.
* LayoutTests/fast/mediastream/video-srcObject-set-twice-expected.txt: Added.
* LayoutTests/fast/mediastream/video-srcObject-set-twice.html:
* LayoutTests/platform/wk2/TestExpectations:

Canonical link: https://commits.webkit.org/268908@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6edb28: [WebXR] Rename XRDeviceInfo::features to XRDeviceI...

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6edb28521a64317b8fb2da683f4d52feaeb21178
  
https://github.com/WebKit/WebKit/commit/6edb28521a64317b8fb2da683f4d52feaeb21178
  Author: Dan Glastonbury 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebKit/Shared/XR/XRDeviceInfo.cpp
M Source/WebKit/Shared/XR/XRDeviceInfo.h
M Source/WebKit/Shared/XR/XRDeviceProxy.cpp

  Log Message:
  ---
  [WebXR] Rename XRDeviceInfo::features to XRDeviceInfo::vrFeatures
https://bugs.webkit.org/show_bug.cgi?id=262676
rdar://116503942

Reviewed by Dean Jackson.

Rename XRDeviceInfo::features to XRDeviceInfo::vrFeatures to better signify this
list represents the supported features for immersive-vr sessions.

* Source/WebKit/Shared/XR/XRDeviceInfo.cpp:
(WebKit::XRDeviceInfo::encode const):
(WebKit::XRDeviceInfo::decode):
* Source/WebKit/Shared/XR/XRDeviceInfo.h:
* Source/WebKit/Shared/XR/XRDeviceProxy.cpp:
(WebKit::XRDeviceProxy::XRDeviceProxy):

Canonical link: https://commits.webkit.org/268907@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b12e77: [WGSL] Fix how globals are passed to callees

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b12e77a6e9e69bfe2332fcb32e28ee88c3002692
  
https://github.com/WebKit/WebKit/commit/b12e77a6e9e69bfe2332fcb32e28ee88c3002692
  Author: Tadeu Zagallo 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl

  Log Message:
  ---
  [WGSL] Fix how globals are passed to callees
https://bugs.webkit.org/show_bug.cgi?id=262627
rdar://116468140

Reviewed by Mike Wyrzykowski.

This patch fixes 3 issues on how globals are passed to callees:
- private variables were being passed by value, which effectively made them 
immutable
- for overrides without explicit type annotations, the inferred type of the 
initializer
  wasn't being updated with the concretized type
- the rewriter assumed that all globals would have type annotations, which is 
not
  necessarily true for overrides.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitCallee):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visitVariable):
* Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl:

Canonical link: https://commits.webkit.org/268906@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aba145: [WGSL] Initial support for override default values

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aba145921e47f46a0a8dcaf89813f41eaf3bc0a6
  
https://github.com/WebKit/WebKit/commit/aba145921e47f46a0a8dcaf89813f41eaf3bc0a6
  Author: Tadeu Zagallo 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/WGSL.h
M Source/WebGPU/WebGPU/Pipeline.mm

  Log Message:
  ---
  [WGSL] Initial support for override default values
https://bugs.webkit.org/show_bug.cgi?id=262622
rdar://116466820

Reviewed by Mike Wyrzykowski.

Pass the initializer expression to the API, which can later be evaluated with
the evaluation function introduced in 268833@main.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::usesOverride):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createConstantValues):

Canonical link: https://commits.webkit.org/268905@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e8585e: [WGSL] Incomplete function visiting in name mangli...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8585e2a185b30c39a2821360714a5b157bec1e0
  
https://github.com/WebKit/WebKit/commit/e8585e2a185b30c39a2821360714a5b157bec1e0
  Author: Tadeu Zagallo 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
M Source/WebGPU/WGSL/MangleNames.cpp

  Log Message:
  ---
  [WGSL] Incomplete function visiting in name mangling and global rewriting
https://bugs.webkit.org/show_bug.cgi?id=262621
rdar://116466577

Reviewed by Mike Wyrzykowski.

Both the name mangling pass and the global rewring pass were not visiting 
function
attributes. In order to make it less error prone, I changed it to use thet 
default
AST::Visitor implementation. Unfortunatelly, I couldn't find a way to test it 
with
our current infrastructure, but it's easily reproducible in the samples whenever
there is an override variable being used in the workgroup_size attribute.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::visit):

Canonical link: https://commits.webkit.org/268904@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 799e82: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 799e821af6a647559fb4fe51fbd1cbc920ad22e4
  
https://github.com/WebKit/WebKit/commit/799e821af6a647559fb4fe51fbd1cbc920ad22e4
  Author: Fujii Hironori 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations
M 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt
M 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-floating-expected.txt
M 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt
M 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:
* 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt:
* LayoutTests/platform/wincairo/fast/line-grid/line-grid-floating-expected.txt:
* 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt:
* 
LayoutTests/platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt:

Canonical link: https://commits.webkit.org/268903@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ae5b3: [ANGLE] Update ANGLE to 2023-10-04 (3d75b794df0fae...

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ae5b3e71ab1c476c5126e2055054c91c9b5c1b2
  
https://github.com/WebKit/WebKit/commit/4ae5b3e71ab1c476c5126e2055054c91c9b5c1b2
  Author: Dan Glastonbury 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/gn_isolate_map.pyl
M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Debug.h
M Source/ThirdParty/ANGLE/src/libANGLE/Texture.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Texture.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/renderer_utils.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/BufferVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/TextureVk.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_caps_utils.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_helpers.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_helpers.h
M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gl_3_autogen.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_2_0_autogen.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_3_0_autogen.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_ext_autogen.cpp
M Source/ThirdParty/ANGLE/src/tests/capture_replay_tests.py
M 
Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_multisample_test_expectations.txt
M 
Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_multisample_test_expectations.txt
M Source/ThirdParty/ANGLE/src/tests/gl_tests/FramebufferTest.cpp
M 
Source/ThirdParty/ANGLE/src/tests/gl_tests/RobustBufferAccessBehaviorTest.cpp
M Source/ThirdParty/ANGLE/src/tests/gl_tests/TransformFeedbackTest.cpp
M Source/ThirdParty/ANGLE/src/tests/py_utils/android_helper.py
M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.cpp
M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.h

  Log Message:
  ---
  [ANGLE] Update ANGLE to 2023-10-04 (3d75b794df0faee30b82ce9ef52b590ebf3511ae)
https://bugs.webkit.org/show_bug.cgi?id=262665
rdar://116491541

Reviewed by Dean Jackson and Kimmo Kinnunen

Contains upstream commits:
3d75b794df Vulkan: enable preferSubmitAtFBOBoundary for Virtio-GPU Venus
e109a092df Manual roll vulkan-deps from 89aea904c65f to f770c9936a5a (61 
revisions)
f8f9847771 Suppress VUID-VkRenderPassBeginInfo-renderPass-00904
276e0c7864 Also suppress VUID-VkGraphicsPipelineCreateInfo-pStages-00739
43abae130b Suppress VUID-VkGraphicsPipelineCreateInfo-pStages-00738
c17ea30184 Roll SwiftShader from 5b6f768198ce to 400ac3a175a6 (1 revision)
777a46bfcb Metal: Fix power function translation
ffb3238057 Vulkan: Fix device creation on multi-queue devices
1eccf863d3 Handle non-debuggable com.android.angle.test on device
f29f73d9f0 Add missed include 
7540918449 Revert "Add VMA version to logcat"
7f5143c292 Vulkan: Notify VAO when VBO's mBufferWithUserSize changed.
8b9500ae15 Enable multisample deqp tests on bots
e9719f5c3e Capture/Replay: Disable VK_EXT_host_image_copy during capture
d919870f04 Vulkan: Do host image copy without holding the share group lock
09706e1c22 Roll SwiftShader from 7f4d495c89c2 to 5b6f768198ce (1 revision)
16086afbc5 Roll Chromium from 8a3d372ccd3c to 07002c74826e (635 revisions)

Canonical link: https://commits.webkit.org/268902@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fae332: rename NativePromise resolveOrReject and createAnd...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fae33225167aa4756ae404ca04baa27925fa6110
  
https://github.com/WebKit/WebKit/commit/fae33225167aa4756ae404ca04baa27925fa6110
  Author: Jean-Yves Avenard 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Source/WTF/wtf/NativePromise.h
M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp

  Log Message:
  ---
  rename NativePromise resolveOrReject and createAndResolveOrReject
https://bugs.webkit.org/show_bug.cgi?id=262677
rdar://116504430

Reviewed by Youenn Fablet.

rename NativePromise::createAndResolveOrReject into createAndSettle()
and resolveOrReject into settle()
No new test, no functional changes

* Source/WTF/wtf/NativePromise.h:
* Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::myMethodReturningThenCommand):
(TestWebKitAPI::myMethodReturningProducer):

Canonical link: https://commits.webkit.org/268901@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e98470: Follow up fix for 'selenium' version bump.

[dewei-zhu]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e984700817499a22aa028f1c0564b313481fad0e
  
https://github.com/WebKit/WebKit/commit/e984700817499a22aa028f1c0564b313481fad0e
  Author: Dewei Zhu 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  ---
  Follow up fix for 'selenium' version bump.
https://bugs.webkit.org/show_bug.cgi?id=262669
rdar://116428857

Reviewed by Jonathan Bedard.

This change fixes two bugs in order to use 'selenium==4.12.0'.
First issue is that newer version of selenium need to be installed with 
'wheel=True'.
Second issue is autoinstalled uses ZipFile module to extract zipfile which does 
not
preserve file 'x' permissions. Add code to preserve the file 'x' permission 
during
zip and tar file extractions.

* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.Archive.unpack):
* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/268900@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bcd78c: Import WPT mst-content-hint tests up to dfda991

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bcd78ce36b23231fc94bfc5e2580dc6a8cb627da
  
https://github.com/WebKit/WebKit/commit/bcd78ce36b23231fc94bfc5e2580dc6a8cb627da
  Author: Youenn Fablet 
  Date:   2023-10-05 (Thu, 05 Oct 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect.html
A 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference.html
M 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.js
M 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/w3c-import.log
M LayoutTests/tests-options.json

  Log Message:
  ---
  Import WPT mst-content-hint tests up to dfda991
https://bugs.webkit.org/show_bug.cgi?id=262614
rdar://116460764

Reviewed by Tim Nguyen.

* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationEffect.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/RTCRtpSendParameters-degradationPreference.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/idlharness.window.js:
* LayoutTests/imported/w3c/web-platform-tests/mst-content-hint/w3c-import.log:
* LayoutTests/tests-options.json:

Canonical link: https://commits.webkit.org/268899@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes