[webkit-changes] [WebKit/WebKit] fa36eb: Adopt more smart pointers in the Document class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa36ebb5c3c7bffd7215478e377baeb89ebc86da https://github.com/WebKit/WebKit/commit/fa36ebb5c3c7bffd7215478e377baeb89ebc86da Author: Chris Dumez Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/bindings/js/ScriptController.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Node.cpp M Source/WebCore/fileapi/BlobURL.cpp M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/page/MemoryRelease.cpp M Source/WebCore/page/mac/PageMac.mm M Source/WebCore/rendering/HitTestResult.cpp M Source/WebCore/rendering/HitTestResult.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderView.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/workers/service/SWClientConnection.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- Adopt more smart pointers in the Document class https://bugs.webkit.org/show_bug.cgi?id=263342 Reviewed by Ryosuke Niwa. * Source/WebCore/dom/Document.cpp: (WebCore::CallbackForContainIntrinsicSize): (WebCore::printNavigationErrorMessage): (WebCore::Document::configureSharedLogger): (WebCore::Document::addToDocumentsMap): (WebCore::Document::allDocumentsMap): (WebCore::createCachedResourceLoader): (WebCore::m_frameIdentifier): (WebCore::Document::~Document): (WebCore::Document::commonTeardown): (WebCore::Document::setCompatibilityMode): (WebCore::Document::childrenChanged): (WebCore::createUpgradeCandidateElement): (WebCore::createHTMLElementWithNameValidation): (WebCore::Document::createCSSStyleDeclaration): (WebCore::createFallbackHTMLElement): (WebCore::Document::createElement): (WebCore::Document::documentEventTimingFromNavigationTiming): (WebCore::Document::setVisualUpdatesAllowed): (WebCore::Document::setCharset): (WebCore::Document::setDocumentElementLanguage): (WebCore::Document::protectedParser const): (WebCore::Document::setContent): (WebCore::Document::contentType const): (WebCore::Document::caretPositionFromPoint): (WebCore::Document::scrollingElement): (WebCore::canonicalizedTitle): (WebCore::Document::updateTitle): (WebCore::Document::updateTitleFromTitleElement): (WebCore::Document::setTitle): (WebCore::Document::protectedTitleElement const): (WebCore::Document::updateTitleElement): (WebCore::Document::resolveStyle): (WebCore::Document::updateLayout): (WebCore::Document::updateLayoutIfDimensionsOutOfDate): (WebCore::Document::isResolvingContainerQueriesForSelfOrAncestor const): (WebCore::Document::createRenderTree): (WebCore::Document::didBecomeCurrentDocumentInFrame): (WebCore::Document::willDetachPage): (WebCore::Document::attachToCachedFrame): (WebCore::Document::protectedDocumentElement const): (WebCore::Document::destroyRenderTree): (WebCore::Document::protectedUndoManager const): (WebCore::Document::willBeRemovedFromFrame): (WebCore::Document::protectedReportingScope const): (WebCore::Document::removeAllEventListeners): (WebCore::Document::axObjectCache const): (WebCore::Document::setVisuallyOrdered): (WebCore::Document::createParser): (WebCore::Document::appHighlightRegistry): (WebCore::Document::updateHighlightPositions): (WebCore::Document::openForBindings): (WebCore::Document::open): (WebCore::Document::isFullyActive const): (WebCore::Document::detachParser): (WebCore::Document::cancelParsing): (WebCore::Document::implicitOpen): (WebCore::Document::fontLoadRequest): (WebCore::Document::beginLoadingFontSoon): (WebCore::Document::setBodyOrFrameset): (WebCore::Document::explicitClose): (WebCore::Document::implicitClose): (WebCore::Document::setParsing): (WebCore::Document::enqueuePaintTimingEntryIfNeeded): (WebCore::Document::write): (WebCore::Document::minimumDOMTimerInterval const): (WebCore::Document::domTimerAlignmentInterval const): (WebCore::Document::urlForBindings const): (WebCore::Document::fallbackBaseURL const): (WebCore::Document::processBaseElement): (WebCore::Document::userAgent const): (WebCore::Document::disableEval): (WebCore::Document::disableWebAssembly): (WebCore::Document::idbConnectionProxy): (WebCore::Document::createRTCDataChannelRemoteHandlerConnection): (WebCore::Document::canNavigateInternal): (WebCore::Document::isNavigationBlockedByThirdPartyIFrameRedirectBlocking): (WebCore::Document::dispatchDisabledAdaptationsDidChangeForMainFrame): (WebCore::Document::viewportArguments const): (WebCore::Document::updateViewportArguments): (WebCore::Document::themeColorChanged): (WebCore::Document::processColorScheme): (WebCore::Document::metaElementColorSchemeChanged): (WebCore::Document::processWebAppOrientatio
[webkit-changes] [WebKit/WebKit] ac19d2: [WebGPU] stencilAttachmentPixelFormat is never set...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac19d2a124a3101488ca80831e529fc6f2543108 https://github.com/WebKit/WebKit/commit/ac19d2a124a3101488ca80831e529fc6f2543108 Author: Mike Wyrzykowski Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/RenderPipeline.mm Log Message: --- [WebGPU] stencilAttachmentPixelFormat is never set on the MTLDepthStencilDescriptor https://bugs.webkit.org/show_bug.cgi?id=263382 Reviewed by Dan Glastonbury. Need to set MTLDepthStencilDescriptor.stencilAttachmentPixelFormat for writes to the stencil buffer to function. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::Device::isStencilOnlyFormat): (WebGPU::CommandEncoder::beginRenderPass): (WebGPU::isStencilOnlyFormat): Deleted. * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): Canonical link: https://commits.webkit.org/269556@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 584e73: AX: Unnecessarily creating a SizedIteratorRange to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 584e735f831da15532bc76a6453f9b78931340b5 https://github.com/WebKit/WebKit/commit/584e735f831da15532bc76a6453f9b78931340b5 Author: Andres Gonzalez Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- AX: Unnecessarily creating a SizedIteratorRange to retrieve value of first item in HashMap. https://bugs.webkit.org/show_bug.cgi?id=263353 Reviewed by Chris Fleizach. Avoid creating unnecessarily a SizedIteratorRange to get the value of the first pair in the HashMap. Minor optimization/code cleanup, follow up to https://bugs.webkit.org/show_bug.cgi?id=262960. * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::accessibilityRelayProcessSuspended): Canonical link: https://commits.webkit.org/269555@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 339f49: [SVG] Fix ellipse hit testing in the non-circle case
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 339f49b72a953872fd41f36ac6f3a660b9c485f1 https://github.com/WebKit/WebKit/commit/339f49b72a953872fd41f36ac6f3a660b9c485f1 Author: Yusuke Suzuki Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/async-01-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/async-01.svg A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer-01-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer-01.svg A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer.js A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/ellipse-hittest-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/ellipse-hittest.html A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/log.py A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/module-01-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/module-01.svg A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-001.html A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-002.html A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-pointer-events-bbox-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-pointer-events-bbox.html A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-root-border-radius-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-root-border-radius.html A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-small-big-path-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/svg-small-big-path.html M LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/w3c-import.log M Source/WebCore/rendering/svg/RenderSVGEllipse.cpp M Source/WebCore/rendering/svg/RenderSVGEllipse.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.h Log Message: --- [SVG] Fix ellipse hit testing in the non-circle case https://bugs.webkit.org/show_bug.cgi?id=249764 rdar://103756227 Reviewed by Cameron McCormack. This is importing blink's fix for SVG ellipse hit-testing fix[1]. We are using fast path for SVG ellipse hit-testing. But this fast path only works for circle shape, and it does not work with the other ellipses. The reason why the current fast path does not work is that we are assuming that half-stroke-width is enough to compute hit-test with radius from the center-point. But this only works with circle and this does not work with ellipse. Now due to the previous improvement, we can detect ShapeType::Circle and ShapeType::Ellipse. We leverage this to limit the case using fast path. This fixes some WPT failures: web-platform-tests/svg/interact/scripted/ellipse-hittest.html. Previously they were failing, but now we pass with this change. [1]: https://chromium.googlesource.com/chromium/blink/+/fb46751341e395b641b691670c1c70e90bae30d4 * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/async-01-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/async-01.svg: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer-01-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer-01.svg: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/defer.js: Added. (t.step): * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/ellipse-hittest-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/ellipse-hittest.html: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/log.py: Added. (main): * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/module-01-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/module-01.svg: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-001-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/interact/scripted/rect-hittest-002-expected.txt: Added. * L
[webkit-changes] [WebKit/WebKit] 12630d: Enable calculating quota based on disk space in We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12630df61ee89415d3f76e3f96dc2799ab491ade https://github.com/WebKit/WebKit/commit/12630df61ee89415d3f76e3f96dc2799ab491ade Author: Sihui Liu Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/http/tests/IndexedDB/storage-limit-1.https.html M LayoutTests/http/tests/IndexedDB/storage-limit-2.https.html M LayoutTests/http/tests/IndexedDB/storage-limit.https.html M LayoutTests/http/wpt/cache-storage/cache-quota-add.any.js M LayoutTests/http/wpt/cache-storage/cache-quota-after-restart.any.js M LayoutTests/http/wpt/cache-storage/cache-quota.any.js M LayoutTests/http/wpt/cache-storage/quota-third-party.https.html M LayoutTests/storage/filesystemaccess/sync-access-handle-storage-limit-worker.html M LayoutTests/storage/indexeddb/resources/request-size-estimate.js M LayoutTests/storage/indexeddb/resources/storage-limit.js M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h M Source/WebKit/NetworkProcess/storage/OriginQuotaManager.cpp M Source/WebKit/NetworkProcess/storage/OriginQuotaManager.h M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp M Source/WebKit/NetworkProcess/storage/OriginStorageManager.h M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp Log Message: --- Enable calculating quota based on disk space in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=263323 rdar://117139033 Reviewed by Youenn Fablet. When originQuotaRatio and totalQuotaRatio of WebsiteDataStoreConfiguration are non-null, quota is calculated based on disk space and ratio values. Since 263250@main, these values are non-null by default, which means WebKit apps by default have quota calculated based on disk space instead of using a fixed quota value. To ensure quota-related tests run correctly, WebKitTestRunner currently still uses fixed quota, by explicitly setting originQuotaRatio and totalQuotaRatio to null (see TestController::configureWebsiteDataStoreTemporaryDirectories). This is not ideal as WebKit has different behavior in different quota mechanisms. For example, when origin quota is reached, in old mechanism (fixed quota), WebKit ask clients whether to increase quota before proceeding with storage task; in new mechanism (quota calculated based on disk space), task will fail directly. This difference has impacted our performance testing (run-perf-tests) -- in old mechanism, many IPCs may be sent when the storage is big. To make WebKitTestRunner test the new default behavior, this patch makes originQuotaRatio and totalQuotaRatio in WebKitTestRunner non-null. Some layout tests rely on the old quota mechanism. For example, they may want to check if quota error can be correctly thrown and handled with a small amount of data. To keep those tests working, this patch adds TestRunner::setOriginQuotaRatioEnabled that allows a test to ask for old quota mechanism: when originQuotaRatioEnabled is false, network process uses fixed quota. originQuotaRatioEnabled is reset to true between tests to make sure old quota mechanism are only used for tests that needs it. * LayoutTests/http/tests/IndexedDB/storage-limit-1.https.html: * LayoutTests/http/tests/IndexedDB/storage-limit-2.https.html: * LayoutTests/http/tests/IndexedDB/storage-limit.https.html: * LayoutTests/http/wpt/cache-storage/cache-quota-add.any.js: * LayoutTests/http/wpt/cache-storage/cache-quota-after-restart.any.js: * LayoutTests/http/wpt/cache-storage/cache-quota.any.js: * LayoutTests/http/wpt/cache-storage/quota-third-party.https.html: * LayoutTests/storage/filesystemaccess/sync-access-handle-storage-limit-worker.html: * LayoutTests/storage/indexeddb/resources/request-size-estimate.js: * LayoutTests/storage/indexeddb/resources/storage-limit.js: * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setOriginQuotaRatioEnabledForTesting): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::NetworkStorageManager::originQuotaManagerParameters): (WebKit::NetworkSt
[webkit-changes] [WebKit/WebKit] ed5ad7: [iOS] Add SYS_getxattr to the sandbox of network p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed5ad7e9d0c690ccbbb049c934291669fdf9a38c https://github.com/WebKit/WebKit/commit/ed5ad7e9d0c690ccbbb049c934291669fdf9a38c Author: Sihui Liu Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in Log Message: --- [iOS] Add SYS_getxattr to the sandbox of network process https://bugs.webkit.org/show_bug.cgi?id=263406 rdar://117222010 Reviewed by Brent Fulgham and Per Arne Vollan. Network process needs to know file protection class via xattr in FileSystem::isSafeToUseMemoryMapForPath. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Canonical link: https://commits.webkit.org/269552@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0e58a: Follow-up: [WebRTC] Add target for sdp_integration...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0e58a114febdf366376fd27a6f0af8579c3cd26 https://github.com/WebKit/WebKit/commit/c0e58a114febdf366376fd27a6f0af8579c3cd26 Author: David Kilzer Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/sdp_integration_fuzzer.cc M Source/ThirdParty/libwebrtc/WebKit/sdp_integration_fuzzer-libwebrtc.diff Log Message: --- Follow-up: [WebRTC] Add target for sdp_integration_fuzzer https://bugs.webkit.org/show_bug.cgi?id=263225 Unreviewed fuzzer coverage improvement. * Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/sdp_integration_fuzzer.cc: (webrtc::FuzzerTest::RunNegotiateCycle): - Add SdpType enum method argument instead of hard-coding a string. - Remove unused SdpParseError stack variable. - Call overload of CreateSessionDescription() that takes an SdpType enum value to avoid creating a std::string just to have it converted back to an SdpType enum later. (webrtc::FuzzOneInput): - If SDP_TYPE environment variable is set, run the fuzzer in single-SdpType mode based on the integer value of the variable, else use the first byte of input to determine the SdpType of the input. * Source/ThirdParty/libwebrtc/WebKit/sdp_integration_fuzzer-libwebrtc.diff: - Update patch to include changes to sdp_integration_fuzzer.cc. Canonical link: https://commits.webkit.org/269551@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79ceb5: [Gardening]: Restore test expectation while issue ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79ceb52cc4ec8092b542dbf6653a7945e7ef5f91 https://github.com/WebKit/WebKit/commit/79ceb52cc4ec8092b542dbf6653a7945e7ef5f91 Author: Ben Schwartz Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: Restore test expectation while issue is re-investigated. rdar://115192271 https://bugs.webkit.org/show_bug.cgi?id=261356 Unreviewed test gardening. Restoring the test expectation, as the issue persists following the fix landed in 268976@main. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269550@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62a58a: [Gardening]: REGRESSION (269411@main): [ Sonoma wk...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62a58a502b35430a435d2b7c213b8c64ba753a2e https://github.com/WebKit/WebKit/commit/62a58a502b35430a435d2b7c213b8c64ba753a2e Author: Marta Darbinyan Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (269411@main): [ Sonoma wk2 ] fast/selectors/text-field-selection-stroke-color.html is consistently failing https://bugs.webkit.org/show_bug.cgi?id=263407 rdar://117225774 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269549@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 32f022: [WebGPU] Implement dynamic buffer offsets for rend...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 32f02266555bda2527e0a5fc1b9126bd33555a8e https://github.com/WebKit/WebKit/commit/32f02266555bda2527e0a5fc1b9126bd33555a8e Author: Mike Wyrzykowski Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp M Source/WebGPU/WebGPU/RenderBundleEncoder.h M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/WebGPUExt.h Log Message: --- [WebGPU] Implement dynamic buffer offsets for render bundles https://bugs.webkit.org/show_bug.cgi?id=262208 Reviewed by Dan Glastonbury. Support dynamic offsets in RenderBundles / ICBs like they are supported in the RenderPassEncoder and ComputePassEncoder. * Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp: (WebCore::WebGPU::RenderBundleEncoderImpl::setBindGroup): * Source/WebGPU/WebGPU/RenderBundleEncoder.h: * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::addResource): (WebGPU::RenderBundleEncoder::executePreDrawCommands): (WebGPU::RenderBundleEncoder::draw): (WebGPU::RenderBundleEncoder::drawIndexed): (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): (WebGPU::RenderBundleEncoder::finish): (WebGPU::RenderBundleEncoder::setBindGroup): (WebGPU::RenderBundleEncoder::setPipeline): (wgpuRenderBundleEncoderSetBindGroup): (wgpuRenderBundleEncoderSetBindGroupWithDynamicOffsets): * Source/WebGPU/WebGPU/WebGPUExt.h: Canonical link: https://commits.webkit.org/269548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec2d23: Regression(269372@main) Crash under SVGPathElement...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec2d23a0902a7c2e65afbd221a275ce3040b9e1c https://github.com/WebKit/WebKit/commit/ec2d23a0902a7c2e65afbd221a275ce3040b9e1c Author: Chris Dumez Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/fast/svg/path-element-d-attribute-crash-memory-pressure-expected.txt A LayoutTests/fast/svg/path-element-d-attribute-crash-memory-pressure.html M Source/WebCore/svg/SVGPathElement.cpp Log Message: --- Regression(269372@main) Crash under SVGPathElement::attributeChanged() after memory pressure https://bugs.webkit.org/show_bug.cgi?id=263381 rdar://117176058 Reviewed by Said Abou-Hallawa. We were failing to reset pathSegListCacheSize to 0 after clearing the cache. As a result, SVGPathElement::attributeChanged() could get in a state where pathSegListCacheSize becomes greater than maxPathSegListCacheSize even though the cache map is empty. As a result, we would try to remove `cache.random()` which returns `cache.end()` when the cache is empty. I also moved the caching logic to a new class for better insulation / clarity. * LayoutTests/fast/svg/path-element-d-attribute-crash-memory-pressure-expected.txt: Added. * LayoutTests/fast/svg/path-element-d-attribute-crash-memory-pressure.html: Added. * Source/WebCore/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::attributeChanged): (WebCore::SVGPathElement::clearCache): Canonical link: https://commits.webkit.org/269547@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dff0f0: Layer contents are not invalidated when the GPUP c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dff0f0bbe2c58d24fb850b3f4caaa8fb019b73b4 https://github.com/WebKit/WebKit/commit/dff0f0bbe2c58d24fb850b3f4caaa8fb019b73b4 Author: Matt Woodrow Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- Layer contents are not invalidated when the GPUP crashes. https://bugs.webkit.org/show_bug.cgi?id=263211 Reviewed by Simon Fraser. GPUP crashes result in any remote image buffers have new backends created in the new process, but nothing currently notifies the rendering code that we need to repaint the pixel contents. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h: (WebKit::RemoteLayerBackingStoreCollection::gpuProcessConnectionWasDestroyed): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::gpuProcessConnectionWasDestroyed): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm: (WebKit::RemoteLayerTreeContext::gpuProcessConnectionWasDestroyed): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::gpuProcessConnectionWasDestroyed): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::gpuProcessConnectionWasDestroyed): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::gpuProcessConnectionClosed): Canonical link: https://commits.webkit.org/269546@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd9fc4: Unreviewed, remove stale assertion
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd9fc42579dc0b7307a9c1bb3f48a2115f1443c8 https://github.com/WebKit/WebKit/commit/cd9fc42579dc0b7307a9c1bb3f48a2115f1443c8 Author: Yusuke Suzuki Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/SVGRenderSupport.cpp Log Message: --- Unreviewed, remove stale assertion https://bugs.webkit.org/show_bug.cgi?id=263401 rdar://117223553 Since this function is called from NonScalingStroke path, this assertion is stale. Removed. * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::calculateApproximateStrokeBoundingBox): Canonical link: https://commits.webkit.org/269545@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 723eb8: AX: Submit Bug button on Bugzilla is not accessibl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 723eb83c4fdb24e0d50c664452328dc6188ca7dd https://github.com/WebKit/WebKit/commit/723eb83c4fdb24e0d50c664452328dc6188ca7dd Author: Tyler Wilcock Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/accessibility/aria-cellspans-with-native-cellspans-expected.txt M LayoutTests/accessibility/aria-table-attributes-expected.txt M LayoutTests/accessibility/aria-table-attributes.html M LayoutTests/accessibility/custom-elements/table-expected.txt M LayoutTests/accessibility/custom-elements/table.html A LayoutTests/accessibility/out-of-bounds-rowspan-aria-hidden-expected.txt A LayoutTests/accessibility/out-of-bounds-rowspan-aria-hidden.html A LayoutTests/accessibility/out-of-bounds-rowspan-display-none-expected.txt A LayoutTests/accessibility/out-of-bounds-rowspan-display-none.html A LayoutTests/accessibility/out-of-bounds-rowspan-expected.txt A LayoutTests/accessibility/out-of-bounds-rowspan-orphan-rows-expected.txt A LayoutTests/accessibility/out-of-bounds-rowspan-orphan-rows.html A LayoutTests/accessibility/out-of-bounds-rowspan-presentational-row-expected.txt A LayoutTests/accessibility/out-of-bounds-rowspan-presentational-row.html A LayoutTests/accessibility/out-of-bounds-rowspan.html M LayoutTests/platform/glib/accessibility/custom-elements/table-expected.txt A LayoutTests/platform/glib/accessibility/out-of-bounds-rowspan-aria-hidden-expected.txt A LayoutTests/platform/glib/accessibility/out-of-bounds-rowspan-display-none-expected.txt A LayoutTests/platform/glib/accessibility/out-of-bounds-rowspan-expected.txt A LayoutTests/platform/glib/accessibility/out-of-bounds-rowspan-orphan-rows-expected.txt A LayoutTests/platform/glib/accessibility/out-of-bounds-rowspan-presentational-row-expected.txt M LayoutTests/platform/ios/TestExpectations A LayoutTests/platform/ios/accessibility/out-of-bounds-rowspan-aria-hidden-expected.txt A LayoutTests/platform/ios/accessibility/out-of-bounds-rowspan-display-none-expected.txt A LayoutTests/platform/ios/accessibility/out-of-bounds-rowspan-expected.txt A LayoutTests/platform/ios/accessibility/out-of-bounds-rowspan-orphan-rows-expected.txt A LayoutTests/platform/ios/accessibility/out-of-bounds-rowspan-presentational-row-expected.txt M LayoutTests/resources/accessibility-helper.js M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilitySVGElement.cpp M Source/WebCore/accessibility/AccessibilityTable.cpp M Source/WebCore/accessibility/AccessibilityTableCell.cpp M Source/WebCore/accessibility/AccessibilityTableCell.h M Source/WebCore/accessibility/AccessibilityTableRow.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp Log Message: --- AX: Submit Bug button on Bugzilla is not accessible via VoiceOver VO-Right navigation https://bugs.webkit.org/show_bug.cgi?id=263162 rdar://115783249 Reviewed by Andres Gonzalez. This bug happens for two reasons: 1. Bugzilla represents its UI via HTML table, and separates rows into multiple different tbody elements 2. Some cells have rowspans that span out-of-bounds of their containing tbody due to display:none rows Per spec, rowspan is not allowed to escape the table section (tbody, thead, tfoot) that the cell is contained in, but our algorithm did not prevent that. The result was that all the cells following the rowspan cell were shifted inappropriately, with some being shifted out of the table entirely. This patch fixes the issue by implementing the downward-growing cell algorithm to expand rowspanned cells as much as necessary (and not any further). https://html.spec.whatwg.org/multipage/tables.html#algorithm-for-growing-downward-growing-cells This (along with necessary auxiliary changes) fix numerous bugs beyond the one described above: 1. Cells now track their "effective" rowspan, i.e. how many rows they actually expand in the final table layout. Previously, we took the author's provided rowspan as truth, despite it often not being accurate (because of AX-hidden rows, or because it was bigger than the entire number of rows in the rowgroup). This allows us to provide more accurate information to AT users (e.g. when VoiceOver reads "spans x rows"). 2. Properly handle implicit rowgroups in ARIA tables, the lack of which caused us to fail to expose content on real websites 3. We now properly ignore role="presentation" rows 4. We no longer perform a full `updateNode` for objects
[webkit-changes] [WebKit/WebKit] 90a2df: [ wk2 ] imported/w3c/web-platform-tests/webcodecs/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90a2dfe440a24e31efa88fad817b4802e2a0bbcc https://github.com/WebKit/WebKit/commit/90a2dfe440a24e31efa88fad817b4802e2a0bbcc Author: Youenn Fablet Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource.html M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt M LayoutTests/platform/wk2/TestExpectations Log Message: --- [ wk2 ] imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource.html is a flaky text failure. https://bugs.webkit.org/show_bug.cgi?id=260834 rdar://114596017 Reviewed by Chris Dumez. The test may try to create a VideoFrame from an image which has not finished loading. In that case, it will fail. To prevent this, we transform the test as promise_tests and we add a first promise_test which waits for the onload event to be fired. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource.html: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt: * LayoutTests/platform/wk2/TestExpectations: Canonical link: https://commits.webkit.org/269543@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7932ea: Fix compile issue with WebKit header module
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7932eaf523195b030b13cbecedbeff8117f5ce25 https://github.com/WebKit/WebKit/commit/7932eaf523195b030b13cbecedbeff8117f5ce25 Author: Per Arne Vollan Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/Modules/OSX_Private.modulemap M Source/WebKit/Modules/iOS_Private.modulemap M Source/WebKit/Shared/Cocoa/XPCEndpoint.h M Source/WebKit/Shared/Cocoa/XPCEndpointClient.h M Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Configurations/Base.xcconfig M Tools/TestWebKitAPI/Tests/WebKit/XPCEndpoint.mm Log Message: --- Fix compile issue with WebKit header module https://bugs.webkit.org/show_bug.cgi?id=263289 rdar://107568693 Reviewed by Elliott Williams and Brent Fulgham. WTF headers should not be included in header modules. Make the XPC endpoint headers project headers. * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Modules/OSX_Private.modulemap: * Source/WebKit/Modules/iOS_Private.modulemap: * Source/WebKit/Shared/Cocoa/XPCEndpoint.h: * Source/WebKit/Shared/Cocoa/XPCEndpointClient.h: * Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Configurations/Base.xcconfig: * Tools/TestWebKitAPI/Tests/WebKit/XPCEndpoint.mm: Canonical link: https://commits.webkit.org/269542@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20a293: [ Monterey+ WK2 ] http/wpt/service-workers/cache-m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20a293b6ecc6b41e0584b6162af45ffb7c09d2f8 https://github.com/WebKit/WebKit/commit/20a293b6ecc6b41e0584b6162af45ffb7c09d2f8 Author: Youenn Fablet Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html Log Message: --- [ Monterey+ WK2 ] http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html is a flaky TEXT failure https://bugs.webkit.org/show_bug.cgi?id=259382 rdar://112630912 Reviewed by Alex Christensen. sixth-script-async load is happening based on a timer of 1000 ms. There is a race between this load and the onload event, which is expected to happen roughly after 700ms. >From the bot results, sixth-script-async sometimes is triggered before the >onload event. Given we have loads that are triggered after the onload event and we ensure they have the correct cache mode, we do not really need sixth-script-async load check. Given it is flaky, let's remove it to make the test stable. * LayoutTests/http/wpt/service-workers/cache-mode-hard-reload-serviceworker.html: Canonical link: https://commits.webkit.org/269540@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38294b: Add canvas noise injection test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38294bd0b5d959b1c43be0caee0460d5cd3721a5 https://github.com/WebKit/WebKit/commit/38294bd0b5d959b1c43be0caee0460d5cd3721a5 Author: Matthew Finkel Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/canvas/canvas-noise-injection-expected.txt A LayoutTests/fast/canvas/canvas-noise-injection.html M Source/WebCore/html/CanvasBase.h M Source/WebCore/html/CanvasNoiseInjection.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl Log Message: --- Add canvas noise injection test https://bugs.webkit.org/show_bug.cgi?id=263094 rdar://116886810 Reviewed by Simon Fraser. Noise injection should only be applied when the feature is enabled (i.e., when a salt value is set), and it should not be applied when the canvas only contains bitmap data (e.g., drawImage, putImageData). This test fail the latter expectation, and that will be fixed in a follow-up patch. This patch exposes some internal state via Internals. * LayoutTests/TestExpectations: * LayoutTests/fast/canvas/canvas-noise-injection-expected.txt: Added. * LayoutTests/fast/canvas/canvas-noise-injection.html: Added. * Source/WebCore/html/CanvasBase.h: (WebCore::CanvasBase::setNoiseInjectionSalt): (WebCore::CanvasBase::havePendingCanvasNoiseInjection const): * Source/WebCore/html/CanvasNoiseInjection.h: (WebCore::CanvasNoiseInjection::haveDirtyRects const): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::setCanvasNoiseInjectionSalt): (WebCore::Internals::doesCanvasHavePendingCanvasNoiseInjection const): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: Canonical link: https://commits.webkit.org/269541@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bd79f: Crash in Vector::expandCapacity; WebCore::ISOFairP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bd79f324bc5a3aaf8d101087e277b5c611dfbf7 https://github.com/WebKit/WebKit/commit/5bd79f324bc5a3aaf8d101087e277b5c611dfbf7 Author: Jer Noble Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/iso/ISOBox.cpp Log Message: --- Crash in Vector::expandCapacity; WebCore::ISOFairPlayStreamingKeyContextBox::parse() https://bugs.webkit.org/show_bug.cgi?id=258712 rdar://71940 Reviewed by Youenn Fablet. In a number of cases, malformed or malicious boxes claim to have a size much larger than the memory passed to the parser. Cap the m_size parameter to the remaining size of the memory buffer to avoid situations where we attempt to create a vector big enough to hold MAX_INT entries. * Source/WebCore/platform/graphics/iso/ISOBox.cpp: (WebCore::ISOBox::peekBox): (WebCore::ISOBox::parse): Canonical link: https://commits.webkit.org/265870.2@safari-7616-branch Canonical link: https://commits.webkit.org/269539@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19432c: [ Ventura WK1 Release ] http/wpt/workers/modules/d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19432c811205d65e97b69c2bb60c4d316c46df4e https://github.com/WebKit/WebKit/commit/19432c811205d65e97b69c2bb60c4d316c46df4e Author: Youenn Fablet Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/http/wpt/workers/modules/resources/dynamic-import-remote-origin-script-worker.sub.js M LayoutTests/http/wpt/workers/modules/resources/static-import-remote-origin-script-worker.sub.js Log Message: --- [ Ventura WK1 Release ] http/wpt/workers/modules/dedicated-worker-import-csp.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=260111 rdar://113780242 Reviewed by Alex Christensen. This test is passing fine on internal bots but not public bots. A hunch is that the https://127.0.0.1:9443 subresource loads might sometimes be refused by DRT. Given https://localhost:9443 loads are accepted by DRT before running these tests, we migrate these subresource loads to https://localhost:9443. CSP checks are not related to 127.0.0.1 or localhost, so this does not change what is being tested. This is hypothetical fix since I was not able to reproduce locally. * LayoutTests/http/wpt/workers/modules/resources/dynamic-import-remote-origin-script-worker.sub.js: * LayoutTests/http/wpt/workers/modules/resources/static-import-remote-origin-script-worker.sub.js: Canonical link: https://commits.webkit.org/269538@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1556c6: REGRESSION(267193@main): [ Debug ] TestWebKitAPI.W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1556c6a51e8ce89e7c49ce444f75d977809f0325 https://github.com/WebKit/WebKit/commit/1556c6a51e8ce89e7c49ce444f75d977809f0325 Author: Youenn Fablet Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm Log Message: --- REGRESSION(267193@main): [ Debug ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturingAndCalling is a near-constant failure. https://bugs.webkit.org/show_bug.cgi?id=262145 rdar://116083315 Reviewed by Chris Dumez. We moved LibWebRTCCodecsProxy::createEncoder to be an async callback and updated the regular code path in LibWebRTCCodecs. But we forgot to update the GPUProcess crash code path. We introduce a routine that is used for both code paths. * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::createRemoteEncoder): (WebKit::LibWebRTCCodecs::createEncoderInternal): (WebKit::LibWebRTCCodecs::gpuProcessConnectionDidClose): * Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm: Canonical link: https://commits.webkit.org/269537@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 711e9d: Set a non-zero AAGUID for platform credentials whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 711e9d271fec39992f5febf9d1968fe45b1a955d https://github.com/WebKit/WebKit/commit/711e9d271fec39992f5febf9d1968fe45b1a955d Author: Pascoe Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html M Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h M Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h M Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.h M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm Log Message: --- Set a non-zero AAGUID for platform credentials where attestation=none https://bugs.webkit.org/show_bug.cgi?id=261340 rdar://115125044 Reviewed by Brent Fulgham. The other FIDO platform providers return non-zero values in this case, making us unique by having all zeros. This patch assigns a random, fixed, AAGUID instead. * LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.h * Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm * Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h * Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm * Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.h * Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm Canonical link: https://commits.webkit.org/269536@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 04eccf: [iOS] Adopt UIScrollView APIs to check for and sto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04eccfc4a2c7392fd27b9d44880e776cd784f68e https://github.com/WebKit/WebKit/commit/04eccfc4a2c7392fd27b9d44880e776cd784f68e Author: Wenson Hsieh Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm M Source/WebKit/UIProcess/ios/UIKitUtilities.h M Source/WebKit/UIProcess/ios/UIKitUtilities.mm Log Message: --- [iOS] Adopt UIScrollView APIs to check for and stop active scrolling/zooming animations https://bugs.webkit.org/show_bug.cgi?id=263345 rdar://114329712 Reviewed by Richard Robinson. Stop suppressing several deprecation warnings added in 269381@main; instead, adopt new UIScrollView API from UIKit, which implements the equivalent functionality: 1. `-_isAnimatingScroll` -> `-_isScrollAnimating`. 2. `-_isAnimatingZoom` -> `-_isZoomAnimating`. 3. `-_stopScrollingAndZoomingAnimations` -> `-stopScrollingAndZooming`. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _didCommitLoadForMainFrame]): (-[WKWebView _updateScrollViewForTransaction:]): (-[WKWebView _scrollToContentScrollPosition:scrollOrigin:animated:]): (-[WKWebView _viewStabilityState:]): Replace the `-_isScrollingToTop` check with a more encompassing `-isScrollAnimating` check when determining view stability. * Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::stopAnimatedScroll): (WebKit::ScrollingTreeScrollingNodeDelegateIOS::repositionScrollingLayers): * Source/WebKit/UIProcess/ios/UIKitUtilities.h: * Source/WebKit/UIProcess/ios/UIKitUtilities.mm: Add new category helpers on `UIScrollView`, which abstract away the complexity of deciding which APIs to use, depending on the SDK version and whether the new method and properties are available at runtime. Also, add temporary staging declarations so that we can fail gracefully when the new compile-time flag `HAVE(UI_SCROLL_VIEW_APIS_ADDED_IN_RADAR_112474145)` is enabled, but the requisite APIs are missing at runtime. (-[UIScrollView _wk_isScrollAnimating]): (-[UIScrollView _wk_isZoomAnimating]): (-[UIScrollView _wk_stopScrollingAndZooming]): Canonical link: https://commits.webkit.org/269535@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18a450: Simplify `skipOptionalSVGSpacesOrDelimiter` post 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18a4504a0de8c421869c219869894c4e4685e747 https://github.com/WebKit/WebKit/commit/18a4504a0de8c421869c219869894c4e4685e747 Author: Ahmad Saleem Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/svg/SVGParserUtilities.h Log Message: --- Simplify `skipOptionalSVGSpacesOrDelimiter` post 269478@main https://bugs.webkit.org/show_bug.cgi?id=263336 Reviewed by Said Abou-Hallawa. This patch is to address and add suggested changes by Said to further simplify `skipOptionalSVGSpacesOrDelimiter` function. * Source/WebCore/svg/SVGParserUtilities.h: (skipOptionalSVGSpacesOrDelimiter): Canonical link: https://commits.webkit.org/269532@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c73420: safe-merge-queue should gracefully handle network ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c73420e62f4042341b0dca43ba1d6f97567725b3 https://github.com/WebKit/WebKit/commit/c73420e62f4042341b0dca43ba1d6f97567725b3 Author: Brianna Fan Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- safe-merge-queue should gracefully handle network failures with github https://bugs.webkit.org/show_bug.cgi?id=263249 rdar://117172642 Reviewed by Jonathan Bedard. Adds error handling for when query returns None. * Tools/CISupport/ews-build/steps.py: (GitHubMixin.query_graph_ql): (RetrievePRDataFromLabel.run): Canonical link: https://commits.webkit.org/269534@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcbf06: [ iOS17 ] TestWebKitAPI.AutocorrectionTests.FontAt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcbf065e192954578678887bf38fd0175140f2b8 https://github.com/WebKit/WebKit/commit/fcbf065e192954578678887bf38fd0175140f2b8 Author: Wenson Hsieh Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm Log Message: --- [ iOS17 ] TestWebKitAPI.AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle is constantly failing. https://bugs.webkit.org/show_bug.cgi?id=263125 rdar://116924205 Reviewed by Richard Robinson. Make this test robust against minor differences in the size of text rects used for autocorrection when using `UICTFontTextStyle`. This test appears to fail with an autocorrection bubble width of 24 instead of 20 after recent EWS updates to iOS 17, though it still seems to pass (i.e. rect width = 20) when running locally. It's unclear what's causing this disparity. The purpose of this test isn't to check the specific autocorrection rect geometry in the first place, so we should just make this more robust and check that non-empty autocorrection rects appear. * Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm: (checkCGRectIsNotEmpty): (checkCGRectIsEqualToCGRectWithLogging): Deleted. Canonical link: https://commits.webkit.org/269533@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a80f9: [content-visibility] absolute positioned grid item...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a80f9c137b7e110b4d318880188644c931887d3 https://github.com/WebKit/WebKit/commit/7a80f9c137b7e110b4d318880188644c931887d3 Author: Rob Buis Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-093-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-093.html M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- [content-visibility] absolute positioned grid item does not take forced layout into account https://bugs.webkit.org/show_bug.cgi?id=263377 Reviewed by Tim Nguyen. Use isSkippedContentRootForLayout to take forced layout into account for absolute positioned grid items (like RenderBlock::layoutPositionedObject does). * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-093-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-093.html: Added. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutPositionedObject): Canonical link: https://commits.webkit.org/269531@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f47d7d: [safe-merge-queue] Pending checks are treated as p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f47d7dd889442f6ad80167e2ace321232029cbe0 https://github.com/WebKit/WebKit/commit/f47d7dd889442f6ad80167e2ace321232029cbe0 Author: Brianna Fan Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [safe-merge-queue] Pending checks are treated as passed https://bugs.webkit.org/show_bug.cgi?id=263350 rdar://117174907 Reviewed by Jonathan Bedard. Added additional check for pending checks. Turns out iOS tests don't show up at all. * Tools/CISupport/ews-build/steps.py: (CheckStatusOfPR.getQueueStatusFromList): Canonical link: https://commits.webkit.org/269530@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f010e6: [SVG] Use propagated RepaintRectCalculation more
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f010e6048d0b9463e6476cb3fb26ceef751a8469 https://github.com/WebKit/WebKit/commit/f010e6048d0b9463e6476cb3fb26ceef751a8469 Author: Yusuke Suzuki Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/svg/RenderSVGPath.cpp M Source/WebCore/rendering/svg/RenderSVGResource.h M Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp M Source/WebCore/rendering/svg/RenderSVGResourceFilter.h M Source/WebCore/rendering/svg/RenderSVGResourceGradient.h M Source/WebCore/rendering/svg/RenderSVGResourceMarker.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/rendering/svg/RenderSVGResourcePattern.h M Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.h M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.cpp M Source/WebCore/rendering/svg/SVGRenderSupport.h M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp Log Message: --- [SVG] Use propagated RepaintRectCalculation more https://bugs.webkit.org/show_bug.cgi?id=263360 rdar://117184769 Reviewed by Cameron McCormack. This patch more strictly propagating RepaintRectCalculation instead of using RepaintRectCalculation::Accurate. This makes the code places explicit that they are using RepaintRectCalculation::Accurate explicitly. The reason of this use is that they are confusing repaint bounding box and stroke bounding box and using RepaintRectCalculation::Accurate to get resource rects / marker rects. And we can easily see the code using RepaintRectCalculation::Accurate by just grepping it. This indicates that these places should use stroke bounding box correctly instead. Cameron and I discussed and agreed that we should remove RepaintRectCalculation::Accurate eventually. So these FloatRects for Accurate are temporary ones. By doing these use explicit, we can look into these things easily and remove them eventually. Basically use of Accurate is a sign of wrong implementations. * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/svg/RenderSVGResource.h: * Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::resourceBoundingBox): * Source/WebCore/rendering/svg/RenderSVGResourceFilter.h: * Source/WebCore/rendering/svg/RenderSVGResourceGradient.h: * Source/WebCore/rendering/svg/RenderSVGResourceMarker.h: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): (WebCore::RenderSVGResourceMasker::resourceBoundingBox): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/rendering/svg/RenderSVGResourcePattern.h: * Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::repaintRectInLocalCoordinates const): * Source/WebCore/rendering/svg/SVGBoundingBoxComputation.cpp: (WebCore::SVGBoundingBoxComputation::adjustBoxForClippingAndEffects const): * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerStrokeBoundingBox): (WebCore::SVGRenderSupport::intersectRepaintRectWithResources): * Source/WebCore/rendering/svg/SVGRenderSupport.h: * Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeResources): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp: (WebCore::LegacyRenderSVGContainer::repaintRectInLocalCoordinates const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: (WebCore::LegacyRenderSVGResourceClipper::removeAllClientsFromCache): (WebCore::LegacyRenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::LegacyRenderSVGResourceClipper::resourceBoundingBox): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp: (WebCore::LegacyRenderSVGRoot::repaintRectInLocalCoordinates const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp: (WebCore::LegacyRenderSVGShape::repaintRectInLocalCoordinates const): Canonical link: https://commits.webkit.org/269529@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinf
[webkit-changes] [WebKit/WebKit] 99edd9: [WebRTC] Add targets for rtp_packetizer_av1_fuzzer...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99edd951408b34706716b81be951764774eae101 https://github.com/WebKit/WebKit/commit/99edd951408b34706716b81be951764774eae101 Author: David Kilzer Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A Source/ThirdParty/libwebrtc/Configurations/rtp_depacketizer_av1_assemble_frame_fuzzer.xcconfig A Source/ThirdParty/libwebrtc/Configurations/rtp_packetizer_av1_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj Log Message: --- [WebRTC] Add targets for rtp_packetizer_av1_fuzzer and rtp_depacketizer_av1_assemble_frame_fuzzer https://bugs.webkit.org/show_bug.cgi?id=263358 Reviewed by Alex Christensen. * Source/ThirdParty/libwebrtc/Configurations/rtp_depacketizer_av1_assemble_frame_fuzzer.xcconfig: Add. * Source/ThirdParty/libwebrtc/Configurations/rtp_packetizer_av1_fuzzer.xcconfig: Add. * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: - Add targets for rtp_packetizer_av1_fuzzer and rtp_depacketizer_av1_assemble_frame_fuzzer. Canonical link: https://commits.webkit.org/269528@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42927f: [WASM-Function-References] Extend tables with init...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42927fcd77eacfe0e121f8ec1519d22dc8344468 https://github.com/WebKit/WebKit/commit/42927fcd77eacfe0e121f8ec1519d22dc8344468 Author: Asumu Takikawa Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A JSTests/wasm/function-references-spec-tests/table.wast.js A JSTests/wasm/function-references/table_init.js A JSTests/wasm/gc/table_init.js M Source/JavaScriptCore/wasm/WasmFormat.h M Source/JavaScriptCore/wasm/WasmOperationsInlines.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp Log Message: --- [WASM-Function-References] Extend tables with initializer expressions https://bugs.webkit.org/show_bug.cgi?id=251123 Reviewed by Justin Michaud. Add support for tables with initializer expressions. This entails extending TableInformation with initialization information, just as there is for globals. The same fast paths for initializer expressions are used for tables, except restricted to the ones that make sense for reference types. * JSTests/wasm/funcref-spec-harness/sync_index.js: * JSTests/wasm/function-references-spec-tests/table.wast.js: Added. * JSTests/wasm/function-references/table_init.js: Added. (module): (async testTableInitParsing): (async testTableInitRuntime): * JSTests/wasm/gc/table_init.js: Added. (testTableValidation): * Source/JavaScriptCore/wasm/WasmFormat.h: (JSC::Wasm::TableInformation::TableInformation): (JSC::Wasm::TableInformation::initType const): (JSC::Wasm::TableInformation::initialBitsOrImportNumber const): * Source/JavaScriptCore/wasm/WasmOperationsInlines.h: * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseTableHelper): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::initializeExports): Canonical link: https://commits.webkit.org/269527@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e359c: Add Dimitri Fourny as a contributor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e359c05816741af8157af9afbcd9fa0a61251d0 https://github.com/WebKit/WebKit/commit/8e359c05816741af8157af9afbcd9fa0a61251d0 Author: Jonathan Bedard Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M metadata/contributors.json Log Message: --- Add Dimitri Fourny as a contributor Unreviewed contributor addition. * metadata/contributors.json: Canonical link: https://commits.webkit.org/269526@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] baf976: [Gardening]: REGRESSION (Sonoma): [ Sonoma wk2 Rel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: baf976cf2d69ef379a762b957183e99361518b5a https://github.com/WebKit/WebKit/commit/baf976cf2d69ef379a762b957183e99361518b5a Author: Marta Darbinyan Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (Sonoma): [ Sonoma wk2 Release ] compositing/reflections/repaint-with-reflection.html is flaky https://bugs.webkit.org/show_bug.cgi?id=263347 rdar://117172843 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269525@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 453507: Font fallback should ignore generic families for c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4535075b56fdb33a076f51fe92cd0bb8832797c8 https://github.com/WebKit/WebKit/commit/4535075b56fdb33a076f51fe92cd0bb8832797c8 Author: Vitor Roriz Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA.html M LayoutTests/platform/mac/fast/text/softbank-emoji-expected.txt M LayoutTests/platform/wpe/fast/text/softbank-emoji-expected.txt M Source/WebCore/css/CSSFontSelector.cpp M Source/WebCore/platform/graphics/FontCascadeFonts.cpp M Source/WebCore/platform/graphics/FontRanges.cpp M Source/WebCore/platform/graphics/FontRanges.h M Source/WebCore/platform/graphics/WidthIterator.cpp M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp M Source/WebCore/platform/text/CharacterProperties.h Log Message: --- Font fallback should ignore generic families for codepoints in PUA https://bugs.webkit.org/show_bug.cgi?id=263261 rdar://115901340 Reviewed by Cameron McCormack. According to spec: https://drafts.csswg.org/css-fonts-4/#char-handling-issues "If a given character is a Private-Use Area Unicode codepoint, user agents must only match font families named in the font-family list that are not generic families. If none of the families named in the font-family list contain a glyph for that codepoint, user agents must display some form of missing glyph symbol for that character rather than attempting installed font fallback for that codepoint." We are currently not ignoring generic font families for font fallback when a code point is in the private-use area (PUA). This patch changes that. Now FontRanges has a flag to signal that the Font represented by the FontRanges object came from a generic family. That way, we can skip it during font fallback when finding the glyph data for a codepoint that is in the private-user area. After attempting all user-specified font-families, if we couldn't find a font that can represent such codepoint, we then use the .notdef glyph (glyph 0) and the last resource font of WebKit for it. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/matching/font-unicode-PUA.html: Added. * LayoutTests/platform/mac/fast/text/softbank-emoji-expected.txt: * LayoutTests/platform/wpe/fast/text/softbank-emoji-expected.txt: * Source/WebCore/css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::fontRangesForFamily): * Source/WebCore/platform/graphics/FontCascadeFonts.cpp: (WebCore::realizeNextFallback): (WebCore::FontCascadeFonts::glyphDataForVariant): (WebCore::FontCascadeFonts::glyphDataForCharacter): * Source/WebCore/platform/graphics/FontRanges.cpp: (WebCore::FontRanges::FontRanges): (WebCore::FontRanges::glyphDataForCharacter const): * Source/WebCore/platform/graphics/FontRanges.h: (WebCore::FontRanges::isGeneric const): * Source/WebCore/platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::advanceInternal): * Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp: (WebCore::FontCascade::fontForCombiningCharacterSequence const): * Source/WebCore/platform/text/CharacterProperties.h: (WebCore::isPrivateUseAreaCharacter): Canonical link: https://commits.webkit.org/269524@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3eea5b: Use more smart pointers in device motion / orienta...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3eea5b1c8625a9390ae0f3c6e73890e2a0e9dbe5 https://github.com/WebKit/WebKit/commit/3eea5b1c8625a9390ae0f3c6e73890e2a0e9dbe5 Author: Chris Dumez Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/dom/DeviceMotionEvent.cpp M Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp M Source/WebCore/dom/DeviceOrientationAndMotionAccessController.h M Source/WebCore/dom/DeviceOrientationEvent.cpp Log Message: --- Use more smart pointers in device motion / orientation classes https://bugs.webkit.org/show_bug.cgi?id=263339 Reviewed by Ryosuke Niwa. * Source/WebCore/dom/DeviceMotionEvent.cpp: (WebCore::DeviceMotionEvent::requestPermission): * Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp: (WebCore::DeviceOrientationAndMotionAccessController::accessState const): (WebCore::DeviceOrientationAndMotionAccessController::shouldAllowAccess): * Source/WebCore/dom/DeviceOrientationAndMotionAccessController.h: * Source/WebCore/dom/DeviceOrientationEvent.cpp: (WebCore::DeviceOrientationEvent::requestPermission): * Source/WebCore/page/FrameDestructionObserver.h: * Source/WebCore/page/FrameDestructionObserverInlines.h: (WebCore::FrameDestructionObserver::protectedFrame const): Canonical link: https://commits.webkit.org/269523@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9d6d0: [LBSE] Add RenderSVGResourceContainer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9d6d01a743c404d3c502d0bf663b87088cc3772 https://github.com/WebKit/WebKit/commit/a9d6d01a743c404d3c502d0bf663b87088cc3772 Author: Rob Buis Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h A Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp A Source/WebCore/rendering/svg/RenderSVGResourceContainer.h M Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h M Source/WebCore/svg/SVGDefsElement.cpp M Source/WebCore/svg/SVGGElement.cpp M Source/WebCore/svg/SVGSymbolElement.cpp Log Message: --- [LBSE] Add RenderSVGResourceContainer https://bugs.webkit.org/show_bug.cgi?id=261880 Reviewed by Nikolas Zimmermann. Add RenderSVGResourceContainer for LBSE which knows how to handle RenderLayer and will act for future LBSE specific SVG resources. Start keeping track of RenderSVGResourceContainer in ShadowRoot and adjust RenderObject to be able to distinguish between LBSE and legacy SVG resources. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::addSVGResource): (WebCore::TreeScope::removeSVGResource): (WebCore::TreeScope::svgResourceById const): * Source/WebCore/dom/TreeScope.h: * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isLegacySVGResourceContainer const): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h: (WebCore::RenderObject::isLegacySVGResourceContainer const): * Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h: * Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp: Added. (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::willBeDestroyed): (WebCore::RenderSVGResourceContainer::styleDidChange): (WebCore::RenderSVGResourceContainer::idChanged): (WebCore::RenderSVGResourceContainer::registerResource): * Source/WebCore/rendering/svg/RenderSVGResourceContainer.h: Added. * Source/WebCore/rendering/svg/SVGResourcesCycleSolver.cpp: (WebCore::SVGResourcesCycleSolver::resourceContainsCycles): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: * Source/WebCore/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::createElementRenderer): * Source/WebCore/svg/SVGGElement.cpp: (WebCore::SVGGElement::createElementRenderer): * Source/WebCore/svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::createElementRenderer): Canonical link: https://commits.webkit.org/269522@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 660a1c: [IFC] Handle floating RenderFrameSet in LineLayout...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 660a1c45c4e2c2d311985b20149b083cf35f1fbc https://github.com/WebKit/WebKit/commit/660a1c45c4e2c2d311985b20149b083cf35f1fbc Author: Alan Baradlay Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp Log Message: --- [IFC] Handle floating RenderFrameSet in LineLayout::updateInlineContentDimensions https://bugs.webkit.org/show_bug.cgi?id=263354 Reviewed by Antti Koivisto. Only floating type of RenderFrameSets get to IFC (no actual line layout). * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateInlineContentDimensions): Canonical link: https://commits.webkit.org/269521@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 069825: [IFC] Fall back to full layout when partial damage...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 069825f3ce317734abd055df260a2fbb9646fa96 https://github.com/WebKit/WebKit/commit/069825f3ce317734abd055df260a2fbb9646fa96 Author: Alan Baradlay Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp Log Message: --- [IFC] Fall back to full layout when partial damage offset does not match with freshly updated inline items https://bugs.webkit.org/show_bug.cgi?id=263346 Reviewed by Antti Koivisto. If the inline item list mismatches the previously computed damage offset (e.g. first inline item has the length of 3 while damage points to position 4) let's just do full layout. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::layoutRangeForContent): (WebCore::Layout::InlineFormattingContext::layout): (WebCore::Layout::InlineFormattingContext::computedIntrinsicSizes): Canonical link: https://commits.webkit.org/269520@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7356a: [IFC] Fallback to full invalidation when first-let...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7356ae7aaa308c9724a3cbff83e1f1344fb5cba https://github.com/WebKit/WebKit/commit/c7356ae7aaa308c9724a3cbff83e1f1344fb5cba Author: Alan Baradlay Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/fast/text/first-letter-partial-invalidation-crash-expected.txt A LayoutTests/fast/text/first-letter-partial-invalidation-crash.html M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC] Fallback to full invalidation when first-letter is present https://bugs.webkit.org/show_bug.cgi?id=263182 Reviewed by Antti Koivisto. RenderTreeUpdater::updateTextRenderer computes inconsistent values for the damage offset when first-letter is present which confuses inline layout invalidation. Let's disable partial layout for content with first-letter for now (enable is blocked by webkit.org/b/263343). * LayoutTests/fast/text/first-letter-partial-invalidation-crash-expected.txt: Added. * LayoutTests/fast/text/first-letter-partial-invalidation-crash.html: Added. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor): Canonical link: https://commits.webkit.org/269519@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd8b6c: Remove deadcode from SVGResourcesCache::clientStyl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd8b6c24edddb345943f0eca8c04a13a059f9672 https://github.com/WebKit/WebKit/commit/cd8b6c24edddb345943f0eca8c04a13a059f9672 Author: Rob Buis Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/SVGResourcesCache.cpp Log Message: --- Remove deadcode from SVGResourcesCache::clientStyleChanged https://bugs.webkit.org/show_bug.cgi?id=253403 Reviewed by Nikolas Zimmermann. Remove code that is never ran due to clientStyleChanged only being called by SVG renderers which are only associated with SVGElements, making the if statement always false. * Source/WebCore/rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged): Canonical link: https://commits.webkit.org/269518@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c2a7f: [web-animations] remove the WebAnimationsMutableTi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c2a7feebac7ceca545d08da8ed6fa731f8e2af3 https://github.com/WebKit/WebKit/commit/9c2a7feebac7ceca545d08da8ed6fa731f8e2af3 Author: Antoine Quint Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/animation/KeyframeAnimationOptions.idl M Source/WebCore/animation/WebAnimation.idl Log Message: --- [web-animations] remove the WebAnimationsMutableTimelinesEnabled flag https://bugs.webkit.org/show_bug.cgi?id=263365 Reviewed by Antti Koivisto. That flag has been enabled by default for well over a year (March 25, 2022) in 248874@main. It's outlived its purpose so we can remove it now. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/animation/KeyframeAnimationOptions.idl: * Source/WebCore/animation/WebAnimation.idl: Canonical link: https://commits.webkit.org/269517@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00f03d: Deeply nested SVG patterns can take log time to in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00f03d987c0cec7d2821e3d1086bdf15dc807c0d https://github.com/WebKit/WebKit/commit/00f03d987c0cec7d2821e3d1086bdf15dc807c0d Author: Said Abou-Hallawa Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/svg/custom/pattern-nested-reference-expected.txt A LayoutTests/svg/custom/pattern-nested-reference.html M Source/WebCore/rendering/svg/RenderSVGResource.cpp M Source/WebCore/rendering/svg/RenderSVGResource.h M Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp M Source/WebCore/rendering/svg/RenderSVGResourceFilter.h M Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp M Source/WebCore/rendering/svg/RenderSVGResourceGradient.h M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMarker.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp M Source/WebCore/rendering/svg/RenderSVGResourcePattern.h M Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h Log Message: --- Deeply nested SVG patterns can take log time to invalidate the target element https://bugs.webkit.org/show_bug.cgi?id=263349 (rdar://116532387) Reviewed by Simon Fraser. The resource's clients invalidation does not take account the visited renderers. With nested SVG resources this invalidation can have an exponential complexity. This leads to DoS since loading the SVG or modifying its resources can take minutes to finish. Skipping the visited renderers while invalidating the resource's clients should fix this problem. The complexity of the invalidation will be linear in this case. * LayoutTests/svg/custom/pattern-nested-reference-expected.txt: Added. * LayoutTests/svg/custom/pattern-nested-reference.html: Added. * Source/WebCore/rendering/svg/RenderSVGResource.cpp: (WebCore::RenderSVGResource::removeAllClientsFromCache): (WebCore::removeFromCacheAndInvalidateDependencies): (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidationIfNeeded): * Source/WebCore/rendering/svg/RenderSVGResource.h: * Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::removeAllClientsFromCacheIfNeeded): (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourceFilter.h: * Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::removeAllClientsFromCacheIfNeeded): (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourceGradient.h: * Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::removeAllClientsFromCacheIfNeeded): (WebCore::RenderSVGResourceMarker::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourceMarker.h: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::removeAllClientsFromCacheIfNeeded): (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::removeAllClientsFromCacheIfNeeded): (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/RenderSVGResourcePattern.h: * Source/WebCore/rendering/svg/RenderSVGResourceSolidColor.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: (WebCore::LegacyRenderSVGResourceClipper::removeAllClientsFromCacheIfNeeded): (WebCore::LegacyRenderSVGResourceClipper::removeAllClientsFromCache): Deleted. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.cpp: (WebCore::LegacyRenderSVGResourceContainer::markAllClientsForInvalidation): (WebCore::LegacyRenderSVGResourceContainer::markAllClientsForInvalidationIfNeeded): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceContainer.h: Canonical link: https://commits.webkit.org/269516@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2725c3: Cherry-pick 269255@main (db2f6b2a047a). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 2725c3d1aec9a9030841ec7e3cad9fcac11e2c57 https://github.com/WebKit/WebKit/commit/2725c3d1aec9a9030841ec7e3cad9fcac11e2c57 Author: Simon Fraser Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: A LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hit-test-expected.txt A LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hit-test.html M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- Cherry-pick 269255@main (db2f6b2a047a). https://bugs.webkit.org/show_bug.cgi?id=237308 Unable to scroll results.webkit.org results using the scrollbars https://bugs.webkit.org/show_bug.cgi?id=237308 rdar://89598421 Reviewed by Dan Glastonbury and Richard Robinson. If an overflow:scroll contained a composited, positioned descendant, then trying to click and drag an overlay scrollbar that overlapped that descendant would fail to work. This affected results.webkit.org, where the canvas elements caused the bug. This happened because when the hit-testing code tested whether the composited layer contained the point, it would use a backgroundClipRect that was not shrunk for the scrollbar. There was already a "FIXME" comment on a line of code that explicitly removed the `IncludeOverlayScrollbarSize` option, and removing this line fixes the bug. The code dates from when composited overflow scrolling was first implemented (112856@main). `IncludeOverlayScrollbarSize` is only ever specified when requesting clip rects for hit-testing, so it seems reasonable to assume the code was wrong. Do other whitespace cleanup in the hit-testing code, including fixing a line with bad indentation. * LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hit-test-expected.txt: Added. * LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hit-test.html: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::hitTestContentsForFragments const): (WebCore::RenderLayer::calculateClipRects const): Canonical link: https://commits.webkit.org/269255@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba2fb8: Cherry-pick 269223@main (5ce1ab0db72b). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: ba2fb8c6dcd1778d465a81388a08037505ddeb72 https://github.com/WebKit/WebKit/commit/ba2fb8c6dcd1778d465a81388a08037505ddeb72 Author: Carlos Garcia Campos Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/LegacyRenderSVGPath.cpp M Source/WebCore/rendering/svg/RenderSVGPath.cpp Log Message: --- Cherry-pick 269223@main (5ce1ab0db72b). https://bugs.webkit.org/show_bug.cgi?id=262475 Element application crashes in WebCore::Path::isEmpty() https://bugs.webkit.org/show_bug.cgi?id=262475 Reviewed by Said Abou-Hallawa. Check hasPath() before calling path(). * Source/WebCore/rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::isRenderingDisabled const): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: (WebCore::LegacyRenderSVGPath::isRenderingDisabled const): Canonical link: https://commits.webkit.org/269223@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf6b86: Cherry-pick 269169@main (f0755ec8caee). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: bf6b866723cc350bdb738739331a78ed023af6e7 https://github.com/WebKit/WebKit/commit/bf6b866723cc350bdb738739331a78ed023af6e7 Author: Michael Catanzaro Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/glib/UserAgentGLib.cpp Log Message: --- Cherry-pick 269169@main (f0755ec8caee). https://bugs.webkit.org/show_bug.cgi?id=262782 [WPE][GTK] Bump Safari version in user agent header https://bugs.webkit.org/show_bug.cgi?id=262782 Reviewed by Carlos Garcia Campos. * Source/WebCore/platform/glib/UserAgentGLib.cpp: (WebCore::buildUserAgentString): Canonical link: https://commits.webkit.org/269169@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87ade1: Cherry-pick 269068@main (d14f07282a9d). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 87ade166f1568ff994c34dee7e2c993d63b6fac9 https://github.com/WebKit/WebKit/commit/87ade166f1568ff994c34dee7e2c993d63b6fac9 Author: Philippe Normand Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- Cherry-pick 269068@main (d14f07282a9d). https://bugs.webkit.org/show_bug.cgi?id=261892 [GStreamer][MSE] video playback uses GstVA, except on YouTube https://bugs.webkit.org/show_bug.cgi?id=261892 Reviewed by Xabier Rodriguez-Calvar. Streams parsing is not needed for MediaStream cases because we do it upfront for incoming WebRTC MediaStreams. It is however needed for MSE, otherwise decodebin3 might not auto-plug hardware decoders. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): Canonical link: https://commits.webkit.org/269068@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fab679: Cherry-pick 268085@main (ab8e3bcac480). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: fab67902d6a54a746ae34f9239f905f4fb408957 https://github.com/WebKit/WebKit/commit/fab67902d6a54a746ae34f9239f905f4fb408957 Author: Claudio Saavedra Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/gtk/GtkUtilities.cpp M Source/WebKit/Shared/gtk/WebEventFactory.cpp Log Message: --- Cherry-pick 268085@main (ab8e3bcac480). https://bugs.webkit.org/show_bug.cgi?id=261674 [GTK4] NativeWebWheelEvent crashes on wheel event tests https://bugs.webkit.org/show_bug.cgi?id=261674 Reviewed by Michael Catanzaro. The GdkEvent API in GTK4 won't play ball when given a NULL event. When synthesizing wheel events we might pass a NULL event to the event factory, so make sure that the methods that call GDK API on it are NULL-safe. * Source/WebCore/platform/gtk/GtkUtilities.cpp: (WebCore::wallTimeForEvent): * Source/WebKit/Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent): Canonical link: https://commits.webkit.org/268085@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 270de1: Skip http/tests/site-isolation/draw-after-navigati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 270de1496aa1e006e8dc486c3cb09a72b13bbb4a https://github.com/WebKit/WebKit/commit/270de1496aa1e006e8dc486c3cb09a72b13bbb4a Author: Alex Christensen Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- Skip http/tests/site-isolation/draw-after-navigation.html on iOS https://bugs.webkit.org/show_bug.cgi?id=263371 Unreviewed. Skip this test for now like we do the other test that draws pixels from site-isolated iframes because the meta viewport size isn't hooked up right yet. The test was always failing on iOS. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/269515@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1dd5a: [GTK] `Tools/gtk/install-dependencies` fails to fi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1dd5aedd4c9d6e2983c74e4ae6b376f8a61c932 https://github.com/WebKit/WebKit/commit/e1dd5aedd4c9d6e2983c74e4ae6b376f8a61c932 Author: Vitaly Dyachkov Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Tools/gtk/dependencies/apt Log Message: --- [GTK] `Tools/gtk/install-dependencies` fails to find `libgl1-mesa-glx` on Ubuntu 23.10 https://bugs.webkit.org/show_bug.cgi?id=263320 Reviewed by Adrian Perez de Castro. Install it only if it's available. * Tools/gtk/dependencies/apt: Canonical link: https://commits.webkit.org/269514@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9b28d: import-w3c-tests should display the WPT Upstream c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9b28dc7ce071a1002f715f988f732a471b222ee https://github.com/WebKit/WebKit/commit/c9b28dc7ce071a1002f715f988f732a471b222ee Author: Karl Dubost Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Tools/Scripts/webkitpy/w3c/test_downloader.py M Tools/Scripts/webkitpy/w3c/test_importer.py Log Message: --- import-w3c-tests should display the WPT Upstream commit ID https://bugs.webkit.org/show_bug.cgi?id=248445 rdar://103141678 Reviewed by Jonathan Bedard. Collect the WPT upstream ID to copy/paste in the import PR when importing wpt tests into WebKit. * Tools/Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.__init__): (TestDownloader.checkout_test_repository): * Tools/Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): (TestImporter.do_import): (TestImporter.import_tests): Canonical link: https://commits.webkit.org/269513@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dabfee: Narrow attachment sends load event when its icon i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dabfeeb4daebcc58cea4207a19bf6a330a39ae2e https://github.com/WebKit/WebKit/commit/dabfeeb4daebcc58cea4207a19bf6a330a39ae2e Author: Gerald Squelart Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/fast/attachment/attachment-icon-from-file-extension-expected.html M LayoutTests/fast/attachment/attachment-icon-from-file-extension.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/html/HTMLAttachmentElement.cpp M Source/WebCore/html/HTMLAttachmentElement.h Log Message: --- Narrow attachment sends load event when its icon is set, test listens https://bugs.webkit.org/show_bug.cgi?id=262978 rdar://116764174 Reviewed by Aditya Keerthi. Some tests like attachment-icon-from-file-extension.html fail with an image error because the attachment icon is not set yet, especially when the icon request is done is a separate process. Similar to https://commits.webkit.org/266144@main where the wide-layout attachment would dispatch a load event when its image element was set, narrow attachments now dispatch the same load event when its icon image gets set. This can be listened to in tests, so that they know when the attachment is stable and a screenshot may be taken. This patch also fixes attachment-icon-from-file-extension.html as a proof of concept. More tests will be fixed in subsequent patches. A downside to this fix is that "reftest-wait" seems to prevent painting the attachement on wk1, so for now this test is skipped there, to be investigated in https://bugs.webkit.org/show_bug.cgi?id=263367. * LayoutTests/fast/attachment/attachment-icon-from-file-extension-expected.html: * LayoutTests/fast/attachment/attachment-icon-from-file-extension.html: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/html/HTMLAttachmentElement.cpp: (WebCore::HTMLAttachmentElement::updateIconForNarrowLayout): (WebCore::HTMLAttachmentElement::requestIconWithSize): (WebCore::HTMLAttachmentElement::requestIconWithSize const): Deleted. * Source/WebCore/html/HTMLAttachmentElement.h: Canonical link: https://commits.webkit.org/269512@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2f962: Fix break with LAYER_BASED_SVG_ENGINE disabled aft...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2f96217de848269bb771621e1c49a3323e65974 https://github.com/WebKit/WebKit/commit/b2f96217de848269bb771621e1c49a3323e65974 Author: Yousuke Kimoto Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/rendering/svg/SVGRenderSupport.cpp Log Message: --- Fix break with LAYER_BASED_SVG_ENGINE disabled after 269492@main https://bugs.webkit.org/show_bug.cgi?id=263362 Reviewed by Ross Kirsling. When LAYER_BASED_SVG_ENGINE is disabled, RenderSVGShape is used in SVGRenderSupport::calculateApproximateStrokeBoundingBox() and the class is defined with LAYER_BASED_SVG_ENGINE enabled. Also an inline error occurs in SVGRenderSupport.cpp. To fix the build break, it needs to add a conditional code for LAYER_BASED_SVG_ENGINE and add include a header file to refer RenderSVGShape. * Source/WebCore/rendering/svg/SVGRenderSupport.cpp: Add include LegacyRenderSVGShapeInlines.h (WebCore::SVGRenderSupport::calculateApproximateStrokeBoundingBox): Add a condtional macro for LAYER_BASED_SVG_ENGINE Canonical link: https://commits.webkit.org/269511@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c64f97: [WPE][GTK] Gardening `fast/writing-mode` after 267...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c64f97a4afc2aa3f73f74f59630410234ca8a659 https://github.com/WebKit/WebKit/commit/c64f97a4afc2aa3f73f74f59630410234ca8a659 Author: Vitaly Dyachkov Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/platform/glib/fast/html/details-writing-mode-expected.txt M LayoutTests/platform/glib/fast/html/details-writing-mode-mixed-expected.txt M LayoutTests/platform/glib/fast/writing-mode/border-image-horizontal-bt-expected.txt M LayoutTests/platform/glib/fast/writing-mode/box-shadow-horizontal-bt-expected.txt M LayoutTests/platform/glib/fast/writing-mode/english-bt-text-expected.txt M LayoutTests/platform/gtk/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt M LayoutTests/platform/wpe/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt Log Message: --- [WPE][GTK] Gardening `fast/writing-mode` after 267729@main Unreviewed test gardening. * LayoutTests/platform/glib/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/glib/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/border-image-horizontal-bt-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/box-shadow-horizontal-bt-expected.txt: * LayoutTests/platform/glib/fast/writing-mode/english-bt-text-expected.txt: * LayoutTests/platform/gtk/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt: * LayoutTests/platform/wpe/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt: Canonical link: https://commits.webkit.org/269510@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5603d6: [CoordinatedGraphics] CompositingCoordinator doesn...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5603d66937036498bba6f4127730ab430fcd8322 https://github.com/WebKit/WebKit/commit/5603d66937036498bba6f4127730ab430fcd8322 Author: Carlos Garcia Campos Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h Log Message: --- [CoordinatedGraphics] CompositingCoordinator doesn't need to implement GraphicsLayerClient https://bugs.webkit.org/show_bug.cgi?id=263319 Reviewed by Alejandro G. Castro. The compositing coordinator is passed as the client of the root layer, which doesn't have backing store and it's handled manually, so every time it changes we are already scheduling a layer flush. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::sizeDidChange): (WebKit::CompositingCoordinator::notifyFlushRequired): Deleted. (WebKit::CompositingCoordinator::deviceScaleFactor const): Deleted. (WebKit::CompositingCoordinator::pageScaleFactor const): Deleted. (WebKit::CompositingCoordinator::deviceOrPageScaleFactorChanged): Deleted. (WebKit::CompositingCoordinator::renderNextFrame): Deleted. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp: (WebKit::LayerTreeHost::deviceOrPageScaleFactorChanged): (WebKit::LayerTreeHost::renderNextFrame): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h: Canonical link: https://commits.webkit.org/269509@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f51048: Sync css/css-contain from WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f510482360d06ffa2273854c0f1d04330c36fd8e https://github.com/WebKit/WebKit/commit/f510482360d06ffa2273854c0f1d04330c36fd8e Author: Rob Buis Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-091-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-091.html M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-g-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-g.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-root-svg-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-root-svg.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/grid-dynamic.html M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/w3c-import.log Log Message: --- Sync css/css-contain from WPT https://bugs.webkit.org/show_bug.cgi?id=263318 Reviewed by Tim Nguyen. >From WPT revision 3fcbc81e2a.. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-091.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-g-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-g.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-root-svg-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-on-root-svg.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/grid-dynamic.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/crashtests/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/w3c-import.log: Canonical link: https://commits.webkit.org/269508@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ff06e: [Gardening] REGRESSION (r203142): Layout test js/r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ff06e582825160cf42469f7abe9ee332dd9d284 https://github.com/WebKit/WebKit/commit/0ff06e582825160cf42469f7abe9ee332dd9d284 Author: Fujii Hironori Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] REGRESSION (r203142): Layout test js/regress-139548.html is 10x slower. https://bugs.webkit.org/show_bug.cgi?id=160017 Unreviewed test gardeing. No ports are failing these days. Unmarked it. * LayoutTests/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269507@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
