[webkit-changes] [WebKit/WebKit] 6be143: Generate serializers for NSArray, NSDictionary, an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6be1434f578ebcb90ea96a1c71bca5348812e60a https://github.com/WebKit/WebKit/commit/6be1434f578ebcb90ea96a1c71bca5348812e60a Author: Brady Eidson Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm M Source/WebKit/Platform/IPC/Decoder.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCArray.h A Source/WebKit/Shared/Cocoa/CoreIPCArray.mm M Source/WebKit/Shared/Cocoa/CoreIPCArray.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCCFType.h M Source/WebKit/Shared/Cocoa/CoreIPCColor.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h A Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCFont.h A Source/WebKit/Shared/Cocoa/CoreIPCFont.mm M Source/WebKit/Shared/Cocoa/CoreIPCFont.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.h M Source/WebKit/Shared/Cocoa/CoreIPCString.h M Source/WebKit/Shared/Cocoa/CoreIPCURL.h M Source/WebKit/Shared/cf/CoreIPCNumber.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Generate serializers for NSArray, NSDictionary, and NSFont https://bugs.webkit.org/show_bug.cgi?id=264696 Reviewed by Alex Christensen. Now that we have the base CoreIPCNSCFObject wrapper and .serialization.in files for fundamental NS types, we can: - Turn NSArray into a "Vector of CoreIPCNSCFObjects" - Turn NSDictionary into a "Vector of key/value pairs where the keys and values are CoreIPCNSCFObjects" - Directly serialize NSFont/UIFont, since we used an NSDictionary to do so before * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h: * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::isSerializableValue): (IPC::encodeObjectDirectly): Deleted. (IPC::decodeObjectDirectlyRequiringAllowedClasses): Deleted. (IPC::encodeObjectDirectly): Deleted. (IPC::id>>): Deleted. (IPC::decodeObjectDirectlyRequiringAllowedClasses): Deleted. (IPC::encodeObjectDirectly): Deleted. (IPC::decodeObjectDirectlyRequiringAllowedClasses): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCArray.h: (WebKit::CoreIPCArray::CoreIPCArray): (WebKit::CoreIPCArray::toID): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCArray.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h. (WebKit::CoreIPCArray::CoreIPCArray): (WebKit::CoreIPCArray::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCArray.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h: (WebKit::CoreIPCDictionary::CoreIPCDictionary): (WebKit::CoreIPCDictionary::toID): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h. (WebKit::CoreIPCDictionary::CoreIPCDictionary): (WebKit::CoreIPCDictionary::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCFont.h: (WebKit::CoreIPCFont::CoreIPCFont): (WebKit::CoreIPCFont::toID): Deleted. * Source/WebKit/Shared/Cocoa/CoreIPCFont.mm: Copied from Source/WebKit/Shared/Cocoa/CoreIPCArray.h. (WebKit::CoreIPCFont::toID const): * Source/WebKit/Shared/Cocoa/CoreIPCFont.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h: * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm: (WebKit::CoreIPCNSCFObject::valueIsAllowed): * Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in: * Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.h: (WebKit::CoreIPCSecureCoding::objectClass): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm: (operator==): (TEST): Canonical link: https://commits.webkit.org/270624@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53c6f5: [WebGPU] Queue::writeTexture is not implemented co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53c6f57a22b2c293c5645b3b51d94c6eae606a38 https://github.com/WebKit/WebKit/commit/53c6f57a22b2c293c5645b3b51d94c6eae606a38 Author: Mike Wyrzykowski Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Queue::writeTexture is not implemented correctly for compressed texture formats https://bugs.webkit.org/show_bug.cgi?id=263546 rdar://117368535 Reviewed by Dan Glastonbury. webgpu:api,operation,command_buffer,* passes locally after fixing this bug but the test times out run via WKTR so no expectations are added. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/270623@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41848d: Stop using Vector::unsafeAppendWithoutCapacityChec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41848d931422aa7edaeead93a1c57d44609fe022 https://github.com/WebKit/WebKit/commit/41848d931422aa7edaeead93a1c57d44609fe022 Author: Chris Dumez Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- Stop using Vector::unsafeAppendWithoutCapacityCheck() in WasmBBQJIT.cpp https://bugs.webkit.org/show_bug.cgi?id=264646 Reviewed by Darin Adler. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addSwitch): Canonical link: https://commits.webkit.org/270622@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b87ac: [MediaStream] Add support for ImageCapture.takePhoto
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b87ac816d8acb2ee9016d88e7a5d639b19e5818 https://github.com/WebKit/WebKit/commit/6b87ac816d8acb2ee9016d88e7a5d639b19e5818 Author: Eric Carlson Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: A LayoutTests/fast/mediastream/image-capture-take-photo-expected.txt A LayoutTests/fast/mediastream/image-capture-take-photo.html M Source/WebCore/Modules/mediastream/ImageCapture.cpp M Source/WebCore/Modules/mediastream/ImageCapture.h M Source/WebCore/Modules/mediastream/ImageCapture.idl M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrack.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/dom/TaskSource.h M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h M Source/WebCore/platform/mediastream/PhotoSettings.h M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp M Source/WebCore/platform/mediastream/RealtimeMediaSource.h M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h M Source/WebCore/platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp M Source/WebCore/platform/mock/MockRealtimeVideoSource.h M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp M Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h Log Message: --- [MediaStream] Add support for ImageCapture.takePhoto https://bugs.webkit.org/show_bug.cgi?id=262467 rdar://116322637 Reviewed by Youenn Fablet. Implement ImageCapture.takePhoto in AVVideoCaptureSource and MockRealtimeVideoSource. We reconfigure the capture source when asked for a photo larger than the current preset, so it always returns an image at least as large as the requested size, but it doesn't yet resize the image if the requested size doesn't exactly match the preset. Taking a photo is an asynchronous operation that can take an arbitrary amount of time, so we don't do it on the main thread. Because we may need to reconfigure the capture device to take a photo with the requested settings, we need to prevent the capture device from being reconfigured by `applyConstraints` while a photo is being generated. To do this we serialize calls to `takePhoto` and `applyConstraints` so they don't interfere with one another. * LayoutTests/fast/mediastream/image-capture-take-photo-expected.txt: Added. * LayoutTests/fast/mediastream/image-capture-take-photo.html: Added. * Source/WebCore/Modules/mediastream/ImageCapture.cpp: (WebCore::ImageCapture::takePhoto): * Source/WebCore/Modules/mediastream/ImageCapture.h: * Source/WebCore/Modules/mediastream/ImageCapture.idl: * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::stopTrack): (WebCore::MediaStreamTrack::queueAndProcessSerialAction): (WebCore::MediaStreamTrack::processNextSerialAction): (WebCore::MediaStreamTrack::takePhoto): (WebCore::MediaStreamTrack::applyConstraints): * Source/WebCore/Modules/mediastream/MediaStreamTrack.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp: (WebCore::MediaStreamTrackPrivate::takePhoto): * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h: * Source/WebCore/platform/mediastream/PhotoSettings.h: (WebCore::operator==): * Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::takePhoto): * Source/WebCore/platform/mediastream/RealtimeMediaSource.h: * Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp: (WebCore::RealtimeVideoCaptureSource::bestSupportedSizeFrameRateAndZoomConsideringObservers): (WebCore::RealtimeVideoCaptureSource::setSizeFrameRateAndZoom): (WebCore::RealtimeVideoCaptureSource::takePhotoInternal): (WebCore::RealtimeVideoCaptureSource::takePhoto): * Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h: * Source/WebCore/platform/mediastream/mac/AVVide
[webkit-changes] [WebKit/WebKit] a39795: [WebGPU] Expand metal capture to capture a number ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3979565d4436eb9d167edb50629feb7cfd223e4 https://github.com/WebKit/WebKit/commit/a3979565d4436eb9d167edb50629feb7cfd223e4 Author: Mike Wyrzykowski Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/Device.mm M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Expand metal capture to capture a number of calls to submit https://bugs.webkit.org/show_bug.cgi?id=264601 rdar://118237625 Reviewed by Dan Glastonbury. Some websites may call GPUQueue.submit several times per frame so to capture the entire list of submissions we need to allow the capture to continue across multiple calls to GPUQueue.submit. Allow specifying the state of CaptureFrame like so: notifyutil -s com.apple.WebKit.WebGPU.CaptureFrame 10 to capture 10 submit calls. * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/Device.mm: (WebGPU::GPUFrameCapture::registerForFrameCapture): (WebGPU::GPUFrameCapture::shouldStopCaptureAfterSubmit): (WebGPU::Device::shouldStopCaptureAfterSubmit): * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::submit): Canonical link: https://commits.webkit.org/270620@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8e81a: [Cocoa] Fix position of AutoFill buttons in vertic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8e81acd7ac4111a9cb94c4c037b8bf9d7c82c47 https://github.com/WebKit/WebKit/commit/c8e81acd7ac4111a9cb94c4c037b8bf9d7c82c47 Author: Aditya Keerthi Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/css/html.css M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- [Cocoa] Fix position of AutoFill buttons in vertical writing mode https://bugs.webkit.org/show_bug.cgi?id=264691 rdar://118265730 Reviewed by Tim Nguyen. Use logical properties to ensure correct positioning in vertical writing mode. * Source/WebCore/css/html.css: (input::-webkit-strong-password-auto-fill-button): (input::-webkit-credentials-auto-fill-button): (input::-webkit-contacts-auto-fill-button): (input::-webkit-credit-card-auto-fill-button): (input::-webkit-loading-auto-fill-button): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createInnerTextStyle): Canonical link: https://commits.webkit.org/270619@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9f3a6: Stop using Vector::unsafeAppendWithoutCapacityChec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9f3a660aa34d9f8b65b2aada77a27574a9a642e https://github.com/WebKit/WebKit/commit/c9f3a660aa34d9f8b65b2aada77a27574a9a642e Author: Chris Dumez Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmFunctionParser.h M Source/WTF/wtf/Vector.h Log Message: --- Stop using Vector::unsafeAppendWithoutCapacityCheck() in WasmFunctionParser's parse() https://bugs.webkit.org/show_bug.cgi?id=264652 Reviewed by Darin Adler. * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parse): * Source/WTF/wtf/Vector.h: (WTF::Malloc>::appendUsingFunctor): Canonical link: https://commits.webkit.org/270618@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1c357: Use dynamicDowncast more in the DOM
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1c357dd6e0f3eede4100c8152dc5be930a2b55d https://github.com/WebKit/WebKit/commit/b1c357dd6e0f3eede4100c8152dc5be930a2b55d Author: Chris Dumez Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/dom/ActiveDOMObject.cpp M Source/WebCore/dom/ComposedTreeIterator.cpp M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/ContainerNodeAlgorithms.cpp M Source/WebCore/dom/CustomElementRegistry.cpp M Source/WebCore/dom/DataTransfer.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/DocumentTouch.cpp M Source/WebCore/dom/Element.cpp Log Message: --- Use dynamicDowncast more in the DOM https://bugs.webkit.org/show_bug.cgi?id=264695 Reviewed by Ryosuke Niwa. Use dynamicDowncast more in the DOM instead of is() + downcast(). It is less error-prone and often results in more concise code. I am also hoping to have downcast<>() do a type check on release builds in the future. It is currently too expensive to do so but it may become affordable if we use dynamicDowncast() instead when possible. * Source/WebCore/dom/ActiveDOMObject.cpp: (WebCore::suitableScriptExecutionContext): * Source/WebCore/dom/ComposedTreeIterator.cpp: (WebCore::ComposedTreeIterator::ComposedTreeIterator): (WebCore::ComposedTreeIterator::initializeContextStack): (WebCore::ComposedTreeIterator::traverseNextInShadowTree): * Source/WebCore/dom/ContainerNode.cpp: (WebCore::makeChildChangeForInsertion): (WebCore::ContainerNode::cloneChildNodes): * Source/WebCore/dom/ContainerNodeAlgorithms.cpp: (WebCore::notifyNodeInsertedIntoDocument): (WebCore::notifyNodeInsertedIntoTree): (WebCore::notifyNodeRemovedFromDocument): (WebCore::notifyNodeRemovedFromTree): (WebCore::assertConnectedSubrameCountIsConsistent): (WebCore::collectFrameOwners): (WebCore::disconnectSubframes): * Source/WebCore/dom/CustomElementRegistry.cpp: (WebCore::CustomElementRegistry::upgrade): * Source/WebCore/dom/DataTransfer.cpp: (WebCore::DataTransfer::setDragImage): * Source/WebCore/dom/Document.cpp: (WebCore::Document::doctype const): (WebCore::Document::childrenChanged): (WebCore::Document::adoptNode): (WebCore::selectNewTitleElement): (WebCore::Document::updateLayoutIfDimensionsOutOfDate): (WebCore::Document::willBeRemovedFromFrame): (WebCore::Document::setFocusedElement): (WebCore::Document::focusNavigationStartingNode const): (WebCore::Document::getCSSCanvasContext): (WebCore::Document::serviceRequestVideoFrameCallbacks): (WebCore::Document::absoluteEventRegionForNode): (WebCore::eventTargetElementForDocument): (WebCore::Document::updateHoverActiveState): (WebCore::Document::dir const): (WebCore::Document::setDir): (WebCore::Document::keyframesRuleDidChange): (WebCore::Document::addTopLayerElement): (WebCore::Document::activeModalDialog const): (WebCore::Document::handlePopoverLightDismiss): (WebCore::Document::canvasChanged): (WebCore::Document::canvasDestroyed): * Source/WebCore/dom/DocumentTouch.cpp: (WebCore::DocumentTouch::createTouch): (WebCore::DocumentTouch::createTouchList): Deleted. * Source/WebCore/dom/Element.cpp: (WebCore::Element::cloneShadowTreeIfPossible): (WebCore::Element::synchronizeAllAttributes const): (WebCore::Element::synchronizeAttribute const): (WebCore::listBoxElementScrollIntoView): (WebCore::Element::absoluteEventBounds): (WebCore::listBoxElementBoundingBox): (WebCore::Element::removeAttribute): (WebCore::Element::setOuterHTML): (WebCore::Element::setInnerHTML): (WebCore::forEachRenderLayer): (WebCore::Element::resolveComputedStyle): (WebCore::Element::childShouldCreateRenderer const): (WebCore::Element::fastAttributeLookupAllowed const): (WebCore::Element::updateName): (WebCore::Element::updateId): (WebCore::Element::cloneAttributesFromElement): (WebCore::contextElementForInsertion): Canonical link: https://commits.webkit.org/270617@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5de63d: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5de63dbccbc45a3b261bc6ac4a5be1da5e33663f https://github.com/WebKit/WebKit/commit/5de63dbccbc45a3b261bc6ac4a5be1da5e33663f Author: Fujii Hironori Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270616@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f739f8: Deploy more smart pointers in ScriptExecutionConte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f739f845a11b1ba2b438d9e9b31e346f7cdc2f46 https://github.com/WebKit/WebKit/commit/f739f845a11b1ba2b438d9e9b31e346f7cdc2f46 Author: Ryosuke Niwa Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/dom/RejectedPromiseTracker.cpp M Source/WebCore/dom/ScriptExecutionContext.cpp M Source/WebCore/dom/ScriptExecutionContext.h M Source/WebCore/dom/ShadowRoot.cpp Log Message: --- Deploy more smart pointers in ScriptExecutionContext.cpp and RejectedPromiseTracker.cpp https://bugs.webkit.org/show_bug.cgi?id=264621 Reviewed by Chris Dumez. Deploy smart pointers as warned by the clang static analyzer. * Source/WebCore/dom/RejectedPromiseTracker.cpp: (WebCore::RejectedPromiseTracker::reportUnhandledRejections): (WebCore::RejectedPromiseTracker::reportRejectionHandled): * Source/WebCore/dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::reportUnhandledPromiseRejection): (WebCore::ScriptExecutionContext::dispatchErrorEvent): (WebCore::ScriptExecutionContext::protectedVM): Added. (WebCore::ScriptExecutionContext::ensureRejectedPromiseTrackerSlow): * Source/WebCore/dom/ScriptExecutionContext.h: * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::~ShadowRoot): Canonical link: https://commits.webkit.org/270615@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1ad99: [Site Isolation][macOS] Propagate drag events to i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1ad995cedf051ec5c280355b0a28696cdbba5d3 https://github.com/WebKit/WebKit/commit/a1ad995cedf051ec5c280355b0a28696cdbba5d3 Author: Charlie Wolfe Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/page/DragClient.h M Source/WebCore/page/DragController.cpp M Source/WebCore/page/DragController.h M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/EventHandler.h M Source/WebCore/page/HandleMouseEventResult.h R Source/WebCore/page/RemoteMouseEventData.h A Source/WebCore/page/RemoteUserInputEventData.h M Source/WebCore/platform/DragData.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/WebCoreSupport/WebDragClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebDragClient.h M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp M Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- [Site Isolation][macOS] Propagate drag events to isolated frames https://bugs.webkit.org/show_bug.cgi?id=264502 rdar://118184993 Reviewed by Wenson Hsieh. This follows the same pattern as mouse events, where IPC is sent between the UI process and web processes until the target frame is reached. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/loader/EmptyClients.cpp: * Source/WebCore/page/DragClient.h: * Source/WebCore/page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::doSystemDrag): (WebCore::DragController::dragEntered): Deleted. (WebCore::DragController::dragUpdated): Deleted. * Source/WebCore/page/DragController.h: There were several places in `DragController` where drag functions would always be called on the main frame’s event handler. This won’t work when the main frame is being hosted in another process. I changed these functions to pass the frame which the drag is happening in, and instead call functions on the event handler of that frame. There were also places where we were down casting frames to local when we didn’t need to. In `doSystemDrag()` and `tryDHTMLDrag()` all functions called on the main frame and main frame view are accessible even if the frame is out-of-process. `dragEntered()` and `dragUpdated()` didn’t seem like a useful abstraction, so I removed them. * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::mouseEventDataForRemoteFrame): (WebCore::EventHandler::dragSourceEndedAt): * Source/WebCore/page/EventHandler.h: I changed `dragSourceEndedAt()` to return a `FrameIdentifier` if the hit test leads to a remote frame. * Source/WebCore/page/HandleMouseEventResult.h: (WebCore::HandleMouseEventResult::HandleMouseEventResult): (WebCore::HandleMouseEventResult::remoteInputEventData): (WebCore::HandleMouseEventResult::remoteMouseEventData): Deleted. * Source/WebCore/page/RemoteUserInputEventData.h: Renamed from Source/WebCore/page/RemoteMouseEventData.h. I renamed `RemoteMouseEventData` to `RemoteUserInputEventData` since we can use the struct for things other than mouse events. I used it here for drag events, and can likely be used for touch events too. * Source/WebCore/platform/DragData.h: (WebCore::DragData::setClientPosition): I added `setClientPosition` to update the client positions coordinates on `DragData` when passing a drag event to a remote frame. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::determineDataOwner const): When dragging in a isolated frame, each of the `MESSAGE_CHECK_COMPLETION(dataOwner, completionHandler())` would fail. This is because `determineDataOwner()` is only checking for a `WebPageProxy` associated with the `WebProcessProxy`, which may n
[webkit-changes] [WebKit/WebKit] d53d6d: Move enums under WebCore/rendering/ to use the ser...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d53d6d23b888ad7f49bd058a9d8e233983e40f07 https://github.com/WebKit/WebKit/commit/d53d6d23b888ad7f49bd058a9d8e233983e40f07 Author: Mikhail R. Gadelha Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/rendering/Pagination.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderView.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h M Source/WebCore/style/StyleResolveForDocument.cpp M Source/WebCore/testing/Internals.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Move enums under WebCore/rendering/ to use the serializer https://bugs.webkit.org/show_bug.cgi?id=264623 Reviewed by Chris Dumez. This patch covers the enums in Pagination.h (WebCore::PaginationMode) and in RenderObject.h (WebCore::RepaintRectCalculation). The patch mostly just adds the necessary scopes given that the enums now are enum classes. The only exception is the EnumeratedArray in the rendering/svg/legacy/ headers, which needed an extra argument, the last value in the enum; without it EnumeratedArray tries to call EnumTraits::values::max> and fails * Source/WebCore/page/LocalFrameView.cpp: (WebCore::paginationModeForRenderStyle): * Source/WebCore/page/Page.cpp: (WebCore::Page::pageCount const): (WebCore::Page::pageCountAssumingLayoutIsUpToDate const): * Source/WebCore/rendering/Pagination.h: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange): * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::styleDidChange): (WebCore::RenderView::requiresColumns const): (WebCore::RenderView::paint): (WebCore::RenderView::pageNumberForBlockProgressionOffset const): (WebCore::RenderView::pageCount const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setColumnStylesFromPaginationMode): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h: * Source/WebCore/style/StyleResolveForDocument.cpp: (WebCore::Style::resolveForDocument): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::setPagination): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPaginationMode): (WKPageGetPaginationMode): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setPaginationMode): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/270613@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 723ded: [WPE][GTK][Debug] Crashes in imported/w3c/web-plat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 723ded32d95eedc80be4ba1b3bc66c5e245da795 https://github.com/WebKit/WebKit/commit/723ded32d95eedc80be4ba1b3bc66c5e245da795 Author: Philippe Normand Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/Modules/reporting/ReportingScope.cpp Log Message: --- [WPE][GTK][Debug] Crashes in imported/w3c/web-platform-tests/reporting https://bugs.webkit.org/show_bug.cgi?id=264709 Reviewed by Michael Catanzaro. The C++ standard doesn't define an order of evaluation for function arguments, so without forcing it when creating the report we might trigger a use-after-move. This was specially noticeable on GCC builds, not so much with clang. * Source/WebCore/Modules/reporting/ReportingScope.cpp: (WebCore::ReportingScope::generateTestReport): Canonical link: https://commits.webkit.org/270612@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c4764: [GStreamer][MSE][Debug] media/media-source/media-s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c47646d8429be663031e151df659552e75d73ae https://github.com/WebKit/WebKit/commit/0c47646d8429be663031e151df659552e75d73ae Author: Philippe Normand Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer][MSE][Debug] media/media-source/media-source-error-crash.html is flaky crash https://bugs.webkit.org/show_bug.cgi?id=264708 Unreviewed, garden the test. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/270611@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6288cd: [WPE][GTK] Layout tests gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6288cd3be4b3b00f6d8ef08e9047eedb7cd9096f https://github.com/WebKit/WebKit/commit/6288cd3be4b3b00f6d8ef08e9047eedb7cd9096f Author: Philippe Normand Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/cssom-view/range-bounding-client-rect-with-display-contents-expected.txt M LayoutTests/platform/gtk/TestExpectations Log Message: --- [WPE][GTK] Layout tests gardening https://bugs.webkit.org/show_bug.cgi?id=264701 Unreviewed, update of test expectations for WPE/GTK ports. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/cssom-view/range-bounding-client-rect-with-display-contents-expected.txt: Added. Canonical link: https://commits.webkit.org/270610@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e975c: [WPE][Debug] Garden more scrolling-related assert ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e975c79b0d4766d80b0421a6dedeae64ca84b63 https://github.com/WebKit/WebKit/commit/6e975c79b0d4766d80b0421a6dedeae64ca84b63 Author: Claudio Saavedra Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][Debug] Garden more scrolling-related assert crashes https://bugs.webkit.org/show_bug.cgi?id=264697 Unreviewed gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/270609@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
