[webkit-changes] [WebKit/WebKit] 481f55: [WebXR] Fullscreen AR immersive mode

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 481f557cdcb267e860b6563809cd6acee3be8126
  
https://github.com/WebKit/WebKit/commit/481f557cdcb267e860b6563809cd6acee3be8126
  Author: Dan Glastonbury 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h
M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm
M Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h
M Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm

  Log Message:
  ---
  [WebXR] Fullscreen AR immersive mode
https://bugs.webkit.org/show_bug.cgi?id=265297
rdar://118759729

Reviewed by Dean Jackson.

Implement gesture to exit AR immersive mode and display content fullscreen.

To correctly exit RenderLoop thread with out removing backing state, termination
handling has been re-written to ensure that the thread has shutdown before
switching state. This removes the need for the Terminating state, which has been
removed.

* Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h:
* Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm:
(WebKit::ARKitCoordinator::startSession):
(WebKit::ARKitCoordinator::endSessionIfExists):
(WebKit::ARKitCoordinator::endSession):
(WebKit::ARKitCoordinator::scheduleAnimationFrame):
(WebKit::ARKitCoordinator::submitFrame):
(WebKit::ARKitCoordinator::renderLoop):
(WebKit::ARKitCoordinator::currentSessionHasEnded): Deleted.
* Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h:
* Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm:
(-[_WKARPresentationSession initWithSession:descriptor:]):
(-[_WKARPresentationSession viewDidLoad]):
(-[_WKARPresentationSession _cancelAction:]):
(-[_WKARPresentationSession _enterFullscreen]):
(-[_WKARPresentationSession _exitFullscreen]):

Canonical link: https://commits.webkit.org/271188@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e5529d: AV1-in-MP4 codec string not shown in Show Media Stats

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5529dfe6aa499b1754bb7313a27f4d3dfe6f050
  
https://github.com/WebKit/WebKit/commit/e5529dfe6aa499b1754bb7313a27f4d3dfe6f050
  Author: Jer Noble 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebCore/platform/graphics/AV1Utilities.cpp
M Source/WebCore/platform/graphics/AV1Utilities.h
M 
Source/WebCore/platform/graphics/avfoundation/FormatDescriptionUtilities.cpp

  Log Message:
  ---
  AV1-in-MP4 codec string not shown in Show Media Stats
https://bugs.webkit.org/show_bug.cgi?id=265405
rdar://118850797

Reviewed by Eric Carlson.

Support extracting AV1 codec configuration information from the 
FormatDescription.

* Source/WebCore/platform/graphics/AV1Utilities.cpp:
(WebCore::parseAV1DecoderConfigurationRecord):
* Source/WebCore/platform/graphics/AV1Utilities.h:
* Source/WebCore/platform/graphics/avfoundation/FormatDescriptionUtilities.cpp:
(WebCore::codecFromFormatDescription):

Canonical link: https://commits.webkit.org/271187@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e1b3b6: [Win][Clang] WTF_CrossThreadTask.Basic is failing

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1b3b6883b8cea1667aaf74efa832e430b82879c
  
https://github.com/WebKit/WebKit/commit/e1b3b6883b8cea1667aaf74efa832e430b82879c
  Author: Fujii Hironori 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp

  Log Message:
  ---
  [Win][Clang] WTF_CrossThreadTask.Basic is failing
https://bugs.webkit.org/show_bug.cgi?id=265417

Reviewed by Ross Kirsling.

 added a workaround to the test case for
MSVC. However, clang-cl doesn't need it. Becuase Windows port is still
supporting both MSVC and clang-cl, clang-cl builds are enableing
WTF_COMPILER_MSVC macro at the moment.

* Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
clang-cl should take the code path of non-MSVC compiler.

Canonical link: https://commits.webkit.org/271186@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 174a34: [Win] StackTraceTest.StackTraceWorks fails

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 174a34634f2878c1815446c5ca5bcc1323a2ee5d
  
https://github.com/WebKit/WebKit/commit/174a34634f2878c1815446c5ca5bcc1323a2ee5d
  Author: Fujii Hironori 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WTF/StackTraceTest.cpp

  Log Message:
  ---
  [Win] StackTraceTest.StackTraceWorks fails
https://bugs.webkit.org/show_bug.cgi?id=265424

Reviewed by Ross Kirsling.

StackTraceTest.StackTraceWorks test was enabled only for Release build
on Windows. However, WTFGetBacktrace can't get function names for
Windows Release builds. The test case should be enabled only for Debug
build.

* Tools/TestWebKitAPI/Tests/WTF/StackTraceTest.cpp:

Canonical link: https://commits.webkit.org/271185@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bebb14: [JSC] Make CodeBlock destruction lazy

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bebb1488bc66c7d4a4b5b2837a3e8e163659b623
  
https://github.com/WebKit/WebKit/commit/bebb1488bc66c7d4a4b5b2837a3e8e163659b623
  Author: Yusuke Suzuki 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.cpp
M Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.h
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/MetadataTable.cpp
M Source/JavaScriptCore/bytecode/MetadataTable.h
M Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp
M Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h
M Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h
M Source/JavaScriptCore/heap/CodeBlockSet.cpp
M Source/JavaScriptCore/heap/CodeBlockSet.h
M Source/JavaScriptCore/heap/Heap.cpp
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/heap/JITStubRoutineSet.cpp
M Source/JavaScriptCore/heap/JITStubRoutineSet.h
M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp
M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h
M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp
M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h
M Source/JavaScriptCore/runtime/CachedTypes.cpp

  Log Message:
  ---
  [JSC] Make CodeBlock destruction lazy
https://bugs.webkit.org/show_bug.cgi?id=265361
rdar://118818460

Reviewed by Mark Lam.

This patch makes CodeBlock destruction lazy.

1. CodeBlockSet is relying on the fact that CodeBlock's destructor is called as 
soon as it gets dead.
   We wipe dead CodeBlocks instead in 
CodeBlockSet::clearCurrentlyExecutingAndRemoveDeadCodeBlocks.
2. JITStubRoutine has a possibility that, (1) now CodeBlock is dead but 
destructor is not called, (2) JITStubRoutine
   was not executed, but (3) because of conservativeness, once it is determined 
as non-executed but now it is conservatively
   seen as executed. In this case, we may mark already dead cells and cause the 
problem. In this patch, GCAwareJITStubRoutine
   now has owner cell (we already had this concept), and we maintain the 
liveness information of this owner cell.
   As a result, we can know that whether this JITStubRoutine is dead or not 
based on this owner cell's liveness and avoid the
   above race conditions.
3. CodeBlockJettisoningWatchpoint should check whether CodeBlock is still alive 
(via isLive), since it is possible that CodeBlock
   may be dead now but destructor is not called yet. This is well aligned to 
the other Watchpoint.
4. CodeBlock destructor should not touch UnlinkedCodeBlock since it may be 
already dead at this point. Previously it was OK since
   we are always sweeping CodeBlocks first before UnlinkedCodeBlock. But now 
this is not guaranteed. But only usage is didOptimize
   bit propagation. So we put this in UnlinkedMetadataTable instead. We may 
miss this propagation when MetadataTable is empty, but
   this is very rare and it happens only for super small functions, so it does 
not matter for the real world code.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
* Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
* Source/JavaScriptCore/bytecode/CodeBlockJettisoningWatchpoint.h:
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::regenerate):
* Source/JavaScriptCore/bytecode/MetadataTable.cpp:
(JSC::MetadataTable::sizeInBytesForGC):
* Source/JavaScriptCore/bytecode/MetadataTable.h:
(JSC::MetadataTable::forEachValueProfile):
(JSC::MetadataTable::valueProfileForOffset):
(JSC::MetadataTable::unlinkedMetadata const):
(JSC::MetadataTable::totalSize const):
* Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
* Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::didOptimize const):
(JSC::UnlinkedCodeBlock::setDidOptimize):
* Source/JavaScriptCore/bytecode/UnlinkedMetadataTable.h:
(JSC::UnlinkedMetadataTable::didOptimize const):
(JSC::UnlinkedMetadataTable::setDidOptimize):
* Source/JavaScriptCore/heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::clearCurrentlyExecutingAndRemoveDeadCodeBlocks):
(JSC::CodeBlockSet::clearCurrentlyExecuting): Deleted.
* Source/JavaScriptCore/heap/CodeBlockSet.h:
* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::runEndPhase):
(JSC::Heap::finalize):
* Source/JavaScriptCore/heap/JITStubRoutineSet.cpp:
(JSC::JITStubRoutineSet::~JITStubRoutineSet):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
* Source/JavaScriptCore/heap/JITStubRoutineSet.h:
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
* Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine

[webkit-changes] [WebKit/WebKit] 36791c: [Wasm-GC] Allow sequential global use in constexprs

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36791c2dd454d42383079aeefb3587d623a19e85
  
https://github.com/WebKit/WebKit/commit/36791c2dd454d42383079aeefb3587d623a19e85
  Author: Asumu Takikawa 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M JSTests/wasm/gc/const-exprs.js
M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp
M Source/JavaScriptCore/wasm/WasmSectionParser.cpp

  Log Message:
  ---
  [Wasm-GC] Allow sequential global use in constexprs
https://bugs.webkit.org/show_bug.cgi?id=264616

Reviewed by Yusuke Suzuki.

The GC proposal allows constant expressions in globals to be read sequentially
(previously defined globals are ok). For tables, only imported globals. For
other contexts, any globals are fine.

See https://github.com/WebAssembly/gc/pull/481

* JSTests/wasm/gc/const-exprs.js:
(async testConstExprGlobalOrdering):
* Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp:
(JSC::Wasm::ConstExprGenerator::getGlobal):
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseInitExpr):

Canonical link: https://commits.webkit.org/271183@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 897eff: [WebRTC] Add targets for vp[89]_{depacketizer, qp_p...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 897eff3c78674ce9b816706b59e7a884b79f2665
  
https://github.com/WebKit/WebKit/commit/897eff3c78674ce9b816706b59e7a884b79f2665
  Author: David Kilzer 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
A 
Source/ThirdParty/libwebrtc/Configurations/vp8_depacketizer_fuzzer.xcconfig
A Source/ThirdParty/libwebrtc/Configurations/vp8_qp_parser_fuzzer.xcconfig
A 
Source/ThirdParty/libwebrtc/Configurations/vp9_depacketizer_fuzzer.xcconfig
A Source/ThirdParty/libwebrtc/Configurations/vp9_qp_parser_fuzzer.xcconfig
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

  Log Message:
  ---
  [WebRTC] Add targets for vp[89]_{depacketizer,qp_parser}_fuzzer
https://bugs.webkit.org/show_bug.cgi?id=265412


Reviewed by Eric Carlson.

* Source/ThirdParty/libwebrtc/Configurations/vp8_depacketizer_fuzzer.xcconfig: 
Add.
* Source/ThirdParty/libwebrtc/Configurations/vp8_qp_parser_fuzzer.xcconfig: Add.
* Source/ThirdParty/libwebrtc/Configurations/vp9_depacketizer_fuzzer.xcconfig: 
Add.
* Source/ThirdParty/libwebrtc/Configurations/vp9_qp_parser_fuzzer.xcconfig: Add.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
- Add new files and new targets.

Canonical link: https://commits.webkit.org/271182@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a3ec5: Add setting for WebKit process management

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a3ec595251fd4e917bb71e73a8c1af26ebfa61c
  
https://github.com/WebKit/WebKit/commit/8a3ec595251fd4e917bb71e73a8c1af26ebfa61c
  Author: Per Arne Vollan 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  ---
  Add setting for WebKit process management
https://bugs.webkit.org/show_bug.cgi?id=265337
rdar://118789596

Reviewed by Brent Fulgham.

Add setting to manage WebKit processes as extensions. This setting is not 
enabled by default.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:

Canonical link: https://commits.webkit.org/271181@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a9bd8c: [Gardening]: REGRESSION (270602@main): [ Ventura+ ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a9bd8c3d8d2a43198efad1b1b92623bd2dc12703
  
https://github.com/WebKit/WebKit/commit/a9bd8c3d8d2a43198efad1b1b92623bd2dc12703
  Author: Marta Darbinyan 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (270602@main): [ Ventura+ wk2 ] 
imported/w3c/web-platform-tests/accname/name/comp_host_language_label.html is a 
constant failure
https://bugs.webkit.org/show_bug.cgi?id=265414
rdar://118857276

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/271180@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 126af4: [macOS] Enable WEBCONTENT_GPU_SANDBOX_EXTENSIONS_B...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 126af484ebb42fd5aae84fbfdb17993530cd6566
  
https://github.com/WebKit/WebKit/commit/126af484ebb42fd5aae84fbfdb17993530cd6566
  Author: Per Arne Vollan 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  [macOS] Enable WEBCONTENT_GPU_SANDBOX_EXTENSIONS_BLOCKING
https://bugs.webkit.org/show_bug.cgi?id=265076
rdar://114834841

Reviewed by Brent Fulgham.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/271179@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7617.1.4.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7617.1.4.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59faa9: Versioning.

[Jonathan Bedard]

  Branch: refs/heads/safari-7617.1.4-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 59faa99cbd6cca9f135b1471d7590813ce4f69f9
  
https://github.com/WebKit/WebKit/commit/59faa99cbd6cca9f135b1471d7590813ce4f69f9
  Author: Russell Epstein 
  Date:   2023-08-07 (Mon, 07 Aug 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.1.4

Canonical link: https://commits.webkit.org/266623.1@safari-7617.1.4-branch


  Commit: b6652e0f625c76bf72167ec7b8a24d1fcc295406
  
https://github.com/WebKit/WebKit/commit/b6652e0f625c76bf72167ec7b8a24d1fcc295406
  Author: Myah Cobbs 
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.1.4.1

Identifier: 266246.379@safari-7617.1.4-branch


  Commit: 1a97755c8b2a5bf4d56d5a02de55ce2520a77559
  
https://github.com/WebKit/WebKit/commit/1a97755c8b2a5bf4d56d5a02de55ce2520a77559
  Author: Frances Cornwall 
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/FindBanner.js

  Log Message:
  ---
  Cherry-pick 6d291b6825cc. rdar://problem/113714342

Web Inspector: No search results
https://bugs.webkit.org/show_bug.cgi?id=259843

Reviewed by Devin Rousso.

Web Inspector search is not working due to _inputFieldSearch(event) not
being triggered.

Replace incremental with throttle and replace "search" with "input".

Import Throttler class to add _inputFieldInputThrottler function to handle 
throttler for "input" using fire function.
Incorporate 250 ms delay.

In _inputFieldKeyDown use findBannerRevealPreviousResult and 
findBannerRevealNextResult for shift and enter key presses
replacing _searchBackwards and _searchForwards.

Delete _inputFieldKeyUp.

Delete _searchBackwards and _searchForwards in _inputFieldInput(event).

* Source/WebInspectorUI/UserInterface/Views/FindBanner.js:
(WI.FindBanner.prototype._inputFieldKeyDown):
(WI.FindBanner.prototype._inputFieldInput):
(WI.FindBanner.prototype._inputFieldKeyUp): Deleted.
(WI.FindBanner.prototype._inputFieldSearch): Deleted.

Canonical link: https://commits.webkit.org/266783@main

Identifier: 266246.380@safari-7617.1.4-branch


  Commit: 73de84f5a74ab410ac8d7e3e164ee319ee591a28
  
https://github.com/WebKit/WebKit/commit/73de84f5a74ab410ac8d7e3e164ee319ee591a28
  Author: Frances Cornwall 
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/FilterBar.js

  Log Message:
  ---
  Cherry-pick 5df588e41bbd. rdar://problem/113722805

Web Inspector: Incremental in FilterBar
https://bugs.webkit.org/show_bug.cgi?id=260043

Reviewed by Devin Rousso.

The filter bar was not working correctly due to "search" being removed.

Replace incremental with throttler. Delete incremental getter and setter.

Switch eventlistener to "input" instead of "search".

Rename "_handleFilterSearched" to "_handleFilterInput"

Delete unused "_handleFilterInputEvent"

* Source/WebInspectorUI/UserInterface/Views/FilterBar.js:
(WI.FilterBar.prototype.set filters):
(WI.FilterBar.prototype.addFilterBarButton):
(WI.FilterBar.prototype._handleFilterButtonToggled):
(WI.FilterBar.prototype._handleFilterInputEvent):
(WI.FilterBar.prototype.get incremental): Deleted.
(WI.FilterBar.prototype.set incremental): Deleted.
(WI.FilterBar.prototype._handleFilterChanged): Deleted.
(WI.FilterBar.prototype._handleFilterInputEvent): Deleted.

Canonical link: https://commits.webkit.org/266802@main

Identifier: 266246.381@safari-7617.1.4-branch


  Commit: 4b244f41be7f01e4981c836dd5d8b742464d5032
  
https://github.com/WebKit/WebKit/commit/4b244f41be7f01e4981c836dd5d8b742464d5032
  Author: Frances Cornwall 
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

  Log Message:
  ---
  Cherry-pick f02cdaa8457c. rdar://problem/113762463

Web Inspector: Incremental in SearchSidebarPanel
https://bugs.webkit.org/show_bug.cgi?id=260047

Reviewed by Devin Rousso.

Replace "search" with "change" to fix search functionality

* Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel):

Canonical link: https://commits.webkit.org/266820@main

Identifier: 266246.382@safari-7617.1.4-branch


  Commit: f216ab480ac7e8fb6e3471f044792960ae4341da
  
https://github.com/WebKit/WebKit/commit/f216ab480ac7e8fb6e3471f044792960ae4341da
  Author: Dan Robson 
  Date:   2023-08-18 (Fri, 18 Aug 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.1.4.3

Identifier: 266623.6@safari-7617.1.4-branch


Compare: https://github.com/WebKit/WebKit/compare/59faa99cbd6c%5E...f216ab480a

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7617.1.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.24.10.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.24.10.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ddc960: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.24.10-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: ddc96078ad70e72c268344e41ffec6b2b2382072
  
https://github.com/WebKit/WebKit/commit/ddc96078ad70e72c268344e41ffec6b2b2382072
  Author: Dan Robson 
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.24.10.1

Identifier: 265870.85@safari-7616.1.24.10-branch


  Commit: 1b27c4bf71fbdb2dfb8c8ee9190e7dc6879eb512
  
https://github.com/WebKit/WebKit/commit/1b27c4bf71fbdb2dfb8c8ee9190e7dc6879eb512
  Author: Dan Glastonbury 
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageSenderInlines.h
M Source/WebKit/Platform/IPC/StreamClientConnection.h
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h

  Log Message:
  ---
  Cherry-pick 5d3f12cc83da. rdar://problem/111895837

[IPC] Don't unwrap invalid SendSyncResult replies
https://bugs.webkit.org/show_bug.cgi?id=259301
rdar://111895837

Reviewed by Dean Jackson.

We have a number of crash reports from an assert firing in std::optional 
when
unwrapping the result of a synchronous IPC call. This assert hints that we 
have
received a result where `succeeded()` returns true, yet we don't have a 
reply
payload in replyArguments. This is a violation of the prerequisites for
`ConnectionSendSyncReply`. This issue has been causes by improper handling 
of
`decoder` failure and has been fixed piecemeal, for example in
https://bugs.webkit.org/show_bug.cgi?id=259006.

This change extends the succeeded check to include checking for non-none
replyArguments to avoid asserting when using `if (sendResult.succeeded()) {
... = sendResult.reply(); }` pattern.

As an extra level of protection, the new ConnecttionSendSyncResult will set
error to Error::Unspecified if passed replyArguments that are none.

* Source/WebKit/Platform/IPC/Connection.h:
(IPC::ConnectionSendSyncResult::ConnectionSendSyncResult):
(IPC::ConnectionSendSyncResult::succeeded const):
(IPC::Connection::sendSync):
* Source/WebKit/Platform/IPC/MessageSenderInlines.h:
(IPC::MessageSender::sendSync):
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::sendSync):
(IPC::StreamClientConnection::trySendSyncStream):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
(WebKit::AuxiliaryProcessProxy::sendSync):

Canonical link: https://commits.webkit.org/266147@main


  Commit: 6b8164118c886918336236087be28ec5692d3233
  
https://github.com/WebKit/WebKit/commit/6b8164118c886918336236087be28ec5692d3233
  Author: Russell Epstein 
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.24.10.2

Identifier: 265870.87@safari-7616.1.24.10-branch


Compare: https://github.com/WebKit/WebKit/compare/ddc96078ad70%5E...6b8164118c88
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.22
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.22.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b77856: Cherry-pick 660682ad1542. rdar://problem/111444264

[MyahCobbs]

  Branch: refs/heads/safari-7616.1.22-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: b7785632013bb36e28d3a5897044685f16948a5b
  
https://github.com/WebKit/WebKit/commit/b7785632013bb36e28d3a5897044685f16948a5b
  Author: Gerald Squelart 
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp

  Log Message:
  ---
  Cherry-pick 660682ad1542. rdar://problem/111444264

Connection::sendSyncMessage changes NoError to Unspecified if there is no 
decoder
https://bugs.webkit.org/show_bug.cgi?id=258793
rdar://111444264

Reviewed by Kimmo Kinnunen.

If sendSyncMessage return a null decoder along with NoError, callers may 
think the call succeeded and try to access the return value, which is actually 
an empty optional.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendSyncMessage):

Canonical link: https://commits.webkit.org/265736@main

Identifier: 265693.1@safari-7616.1.22-branch


  Commit: fee925e06d7d385ae8307ce72a675c641a1c6ebd
  
https://github.com/WebKit/WebKit/commit/fee925e06d7d385ae8307ce72a675c641a1c6ebd
  Author: Robert Jenner 
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
M Source/WebCore/DerivedSources.make
M Source/WebCore/Scripts/generate-derived-sources.sh

  Log Message:
  ---
  Cherry-pick b305f64a67e2. rdar://problem/111710849

Revert [265608@main] gperf generated files include absolute path to Xcode
https://bugs.webkit.org/show_bug.cgi?id=258634
rdar://30168

Unreviewed revert.

* Source/WebCore/DerivedSources.make:
* Source/WebCore/Scripts/generate-derived-sources.sh:

Canonical link: https://commits.webkit.org/265738@main

Identifier: 265693.2@safari-7616.1.22-branch


  Commit: de752545351f8d6406def264171089f83b7a2541
  
https://github.com/WebKit/WebKit/commit/de752545351f8d6406def264171089f83b7a2541
  Author: Tim Nguyen 
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
M Source/WebCore/html/shadow/attachmentElementShadow.css

  Log Message:
  ---
  Cherry-pick 7fc4f613d53e. rdar://problem/111697949

REGRESSION(265615@main):  icon is stretched
https://bugs.webkit.org/show_bug.cgi?id=258832
rdar://111697949

Reviewed by Wenson Hsieh.

Using  by default will stretch the icon, adding `object-fit: contain` 
makes sure the original image aspect ratio is honored, restoring the old 
behavior.

* Source/WebCore/html/shadow/attachmentElementShadow.css:
(img#attachment-icon):

Canonical link: https://commits.webkit.org/265742@main

Identifier: 265693.3@safari-7616.1.22-branch


  Commit: a45033dd727c70b1555acf8510ee3a77ab7cca90
  
https://github.com/WebKit/WebKit/commit/a45033dd727c70b1555acf8510ee3a77ab7cca90
  Author: Justin Michaud 
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/jit/RegisterSet.h

  Log Message:
  ---
  Cherry-pick 40df48799883. rdar://problem/110382994

Add additional assertions to InlineCacheCompiler
rdar://110382994

Reviewed by Mark Lam.

We are sometimes finding ourselves in an inconsistent state where
we have allocated stack space but have no live registers to preserve.
Let's add some additional assertions to make it easier to find the root 
cause.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::preserveLiveRegistersToStackForCall):

(JSC::InlineCacheCompiler::preserveLiveRegistersToStackForCallWithoutExceptions):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
(JSC::InlineCacheCompiler::setSpillStateForJSCall):
(JSC::InlineCacheCompiler::spillStateForJSCall const):

Canonical link: https://commits.webkit.org/265759@main

Identifier: 265693.4@safari-7616.1.22-branch


  Commit: 5ea04995822155c168f2945d512acaa2813b70c0
  
https://github.com/WebKit/WebKit/commit/5ea04995822155c168f2945d512acaa2813b70c0
  Author: Commit Queue 
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
M Source/WebCore/rendering/RenderHTMLCanvas.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerBacking.h
M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  ---
  Cherry-pick 00331836746a. rdar://problem/111711710

Unreviewed, reverting 265587@main.
https://bugs.webkit.org/show_bug.cgi?id=258858

Broke PDF display in Mail ()

Reverted changeset:

"Avoid evaluating layer backing store contents twice per update"
https://bugs.webkit.org/show_bug.cgi?id=258579
https://commits.webkit.org/265587@main

Canonical link: https://commits.webkit.org/265757@main

Identifier: 265693.5@safari-7616.1.22-branch


  Commit: 06c4319c8e1b425659960a75fdad4fe54988c9e3
  
https://github.com/WebK

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.21.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 531333: Versioning.

[MyahCobbs]

  Branch: refs/heads/safari-7616.1.21-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 53146b57efbe2c97197307b45c801b55aae3
  
https://github.com/WebKit/WebKit/commit/53146b57efbe2c97197307b45c801b55aae3
  Author: Russell Epstein 
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.21

Canonical link: https://commits.webkit.org/265500.1@safari-7616.1.21-branch


  Commit: 055a74191a3e9275077b1ab80cfcc68e97b91310
  
https://github.com/WebKit/WebKit/commit/055a74191a3e9275077b1ab80cfcc68e97b91310
  Author: Chris Dumez 
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  ---
  Cherry-pick 0ba9e6c4473f. rdar://problem/61160

WebPage_LoadRequest IPC fails decoding in PingDuoDuo app
https://bugs.webkit.org/show_bug.cgi?id=258486
rdar://61160

Reviewed by Tim Horton.

WebPage_LoadRequest IPC was failing decoding in PingDuoDuo app.
The issue was due to getting a WKSecureCodingURLWrapper instead
of a NSURL when decoding the baseURL of a NSURL.

I am not sure how we ended up in this situation but I made the
bug go away by simplifying the code. The coder used to encode
the URL in two parts:
1. The baseURL
2. The bytes from the URL's relative string

Then it would decode the URL in 2 parts:
1. The baseURL
2. The bytes from the URL's relative string

It would then call CFURLCreateAbsoluteURLWithBytes() with those
2 parts, which would result in an *absolute* URL. The information
about baseURL / relative string would be lost.

As a result, I have decided to simply encode the URL in one part,
the absolute URL bytes. The decoding results ends up being the
same (an absolute URL). It simplifies both coding and decoding
and makes the bug go away since it was about decoding baseURLs.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(-[WKSecureCodingURLWrapper encodeWithCoder:]):
(-[WKSecureCodingURLWrapper initWithCoder:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

Canonical link: https://commits.webkit.org/265529@main

Canonical link: https://commits.webkit.org/265500.2@safari-7616.1.21-branch


  Commit: eb558de512214f96fc2687c5b07fd6b49970262f
  
https://github.com/WebKit/WebKit/commit/eb558de512214f96fc2687c5b07fd6b49970262f
  Author: Per Arne Vollan 
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  Cherry-pick b2a27f1fe286. rdar://problem/111347166

Fix null pointer dereference
https://bugs.webkit.org/show_bug.cgi?id=258529
rdar://111347166

Reviewed by Brent Fulgham.

The 'configuration' parameter to WebViewImpl::WebViewImpl has been moved at 
this point. Use the configuration from the page instead.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):

Canonical link: https://commits.webkit.org/265528@main
Identifier: 265423.80@safari-7616.1.21-branch


  Commit: 69354feb53560e265a9f10d859232363e2014eae
  
https://github.com/WebKit/WebKit/commit/69354feb53560e265a9f10d859232363e2014eae
  Author: Alex Christensen 
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
M Source/WTF/wtf/ThreadSafeWeakPtr.h

  Log Message:
  ---
  Cherry-pick 883a699fc0cf. rdar://problem/111409234

Revert unnecessary part of 265344@main
https://bugs.webkit.org/show_bug.cgi?id=258636
rdar://111409234

Reviewed by Chris Dumez.

265344@main made it so we can make weak references during the destructor 
safely.
I also tried to do the same thing we do in RefCounted and 
ThreadSafeRefCounted
and make it so we can safely make strong references, however 
m_strongReferenceCount
is also used in weakDeref so it caused the control block to be leaked if 
there
are weak references when the destructor is called.  As a minimum risk fix,
revert that unneeded part of last week's PR.

* Source/WTF/wtf/ThreadSafeWeakPtr.h:
(WTF::ThreadSafeWeakPtrControlBlock::strongDeref const):

Canonical link: https://commits.webkit.org/265598@main
Identifier: 265423.81@safari-7616.1.21-branch


  Commit: d0c88b64e7472c7a8df0f600a95c0f73fbba2b06
  
https://github.com/WebKit/WebKit/commit/d0c88b64e7472c7a8df0f600a95c0f73fbba2b06
  Author: Myah Cobbs 
  Date:   2023-06-29 (Thu, 29 Jun 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.21.1

Identifier: 265423.82@safari-7616.1.21-branch


  Commit: b689b631e5ff6586f9d4f80ff08e3c2bff4332a4
  
https://github.com/WebKit/WebKit/commit/b689b631e5ff6586f9d4f80ff08e3c2bff4332a4
  Author: Yusuke Suzuki 
  Date:   2023-06-30 (Fri,

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.21
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.21.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a6517: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.20.10-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a6517c05864090f4552deb9d7040943aef06667
  
https://github.com/WebKit/WebKit/commit/9a6517c05864090f4552deb9d7040943aef06667
  Author: Myah Cobbs 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.20.1

Identifier: 265377.1@safari-7616.1.20-branch


  Commit: b067c6e91cfab45a4b3a5d44ff2df0debbc3cc8d
  
https://github.com/WebKit/WebKit/commit/b067c6e91cfab45a4b3a5d44ff2df0debbc3cc8d
  Author: Eric Carlson 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Source/WebCore/rendering/RenderVTTCue.cpp

  Log Message:
  ---
  Cherry-pick b33adedfb117. rdar://problem/93689838

ASSERTION FAILED: firstChild():[ macOS ] media/track/track-cues-missed.html 
is a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=258183
rdar://110876540

Reviewed by Andy Estes.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::isOutside const): Return early if firstChild() 
return null.
(WebCore::RenderVTTCue::isOverlapping const): Ditto.
(WebCore::RenderVTTCue::overlappingObject const): Ditto.
(WebCore::RenderVTTCue::moveIfNecessaryToKeepWithinContainer): Ditto.
(WebCore::RenderVTTCue::findNonOverlappingPosition const): Ditto.

Canonical link: https://commits.webkit.org/265420@main
Identifier: 265377.2@safari-7616.1.20-branch


  Commit: b92693566eb2c935d505396539cea60ac09c953e
  
https://github.com/WebKit/WebKit/commit/b92693566eb2c935d505396539cea60ac09c953e
  Author: Eric Carlson 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp

  Log Message:
  ---
  Cherry-pick b9047adba096. rdar://problem/110455790

[macOS] Support WebM files with no track ID
https://bugs.webkit.org/show_bug.cgi?id=258402
rdar://110455790

Reviewed by Andy Estes and David Kilzer.

Although WebM track ID is a required header field some otherwise valid files
don't have them. MediaTrackReader requires a track ID, so create an ID when
a file doesn't have one.

* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::didParseTracks):

Canonical link: https://commits.webkit.org/265425@main
Identifier: 265377.3@safari-7616.1.20-branch


  Commit: 93957a67d0df39654b3e51c69546f3f81e020ca5
  
https://github.com/WebKit/WebKit/commit/93957a67d0df39654b3e51c69546f3f81e020ca5
  Author: Tyler Wilcock 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Source/WebCore/accessibility/AccessibilitySVGElement.cpp

  Log Message:
  ---
  Cherry-pick e4715d95b3a1. rdar://problem/39655

AX: AccessibilitySVGElement::computeAccessibilityIsIgnored() should 
null-check its renderer before using it
https://bugs.webkit.org/show_bug.cgi?id=258407
rdar://39655

Reviewed by Chris Fleizach.

This patch adds a null-check of m_renderer before dereferencing it, as
failing to do so causes a crash in some scenarios.

* Source/WebCore/accessibility/AccessibilitySVGElement.cpp:
(WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const):

Canonical link: https://commits.webkit.org/265434@main
Identifier: 265377.4@safari-7616.1.20-branch


  Commit: 4b570635323e694772bd5a15359f566519ffe1c9
  
https://github.com/WebKit/WebKit/commit/4b570635323e694772bd5a15359f566519ffe1c9
  Author: Abrar Rahman Protyasha 
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm

  Log Message:
  ---
  Cherry-pick 46b03afa5a23. rdar://problem/110501313

WebPageProxy::setToolTip accesses a null PageClient
https://bugs.webkit.org/show_bug.cgi?id=258313
rdar://110501313

Reviewed by Chris Dumez and Wenson Hsieh.

In 264455@main, we introduced
`WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously`, which asks
to perform `WebPageProxy::mouseDidMoveOverElement` at a future time. It
turns out there's a null access on `m_pageClient` when we then call into
`WebPageProxy::setToolTip`, which happens because we hold a
`WeakPtr` instance to the `PageClient` object, meaning there
are no guarantees on the PageClient instance's lifetime.

To avoid this null dereference, we should only inform the web page about
a `MouseMove` event upon consulting whether the web page is closed
through `WebPageProxy::isClosed()`.

We also add an API test that crashes without this mitigation in place.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(+[TestEventMonitor addLocalMonitorForEventsMatc

[webkit-changes] [WebKit/WebKit] 7be432: [WebRTC] Minor improvements for webrtc fuzzers

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7be4320b24295ef2421e86eca0c9c66ff5ccc4e2
  
https://github.com/WebKit/WebKit/commit/7be4320b24295ef2421e86eca0c9c66ff5ccc4e2
  Author: David Kilzer 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/rtp_packetizer_av1_fuzzer.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/utils/rtp_replayer.cc
A 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Minor-improvements-for-webrtc-fuzzers.patch

  Log Message:
  ---
  [WebRTC] Minor improvements for webrtc fuzzers
https://bugs.webkit.org/show_bug.cgi?id=265110


Reviewed by Eric Carlson.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/rtp_packetizer_av1_fuzzer.cc:
- Send generated packets through depacketizer.
* Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/utils/rtp_replayer.cc:
- Only set payload type frequency when it is zero.

* 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Minor-improvements-for-webrtc-fuzzers.patch:
 Add.

Canonical link: https://commits.webkit.org/271178@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8651a5: Cherry-pick c9a65a407c6b. rdar://problem/109790387

[MyahCobbs]

  Branch: refs/heads/safari-7616.1.17-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 8651a560be06290e09ce8b0da3be36ce3b134bb2
  
https://github.com/WebKit/WebKit/commit/8651a560be06290e09ce8b0da3be36ce3b134bb2
  Author: Elliott Williams 
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
M Source/WebKit/Configurations/SandboxProfiles.xcconfig
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Cherry-pick c9a65a407c6b. rdar://problem/109790387

Restore iOS sandbox profile generation in engineering builds
https://bugs.webkit.org/show_bug.cgi?id=257276
rdar://109790387

Reviewed by Alexey Proskuryakov.

264752@main (6f04c95bf8f3) stopped preprocessing iOS sandbox profiles
unconditionally during at-desk builds. The logic was that the profiles
are only used during WebKit's production build, so there was no need to
generate them locally. However, it's helpful for engineers to be able to
manually test the sandbox profiles outside of a production build
environment.

When building for iOS, make WebKit depend on the "Sandbox Profiles"
target. Change that target to install sandbox profiles to
BUILT_PRODUCTS_DIR in non-install builds. Add a dependency on WTF, since
Platform headers are used to preprocess the sandbox profiles and the
target needs to be scheduled after they are available.

The result is that sandbox profiles are preprocessed at their old
DerivedSources location, and are copied to a path like

WebKitBuild/Debug-iphoneos/usr/local/share/sandbox/...

Also, remove the old "Copy iOS Sandbox Profiles for Manual Sandboxing"
script phase, which was an unused workflow.

* Source/WebKit/Configurations/SandboxProfiles.xcconfig: Declare a path
  variable used to install profiles into BUILT_PRODUCTS_DIR in
  non-install builds. Add $(BUILT_PRODUCTS_DIR)/usr/local/include to the
  search path, to pick up WTF headers during engineering builds.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/264904@main

Canonical link: https://commits.webkit.org/264854.1@safari-7616.1.17-branch


  Commit: 4307e2ee9baf802bc175cc7c7cc43fd3577242d1
  
https://github.com/WebKit/WebKit/commit/4307e2ee9baf802bc175cc7c7cc43fd3577242d1
  Author: Youenn Fablet 
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm

  Log Message:
  ---
  Cherry-pick 5129c74d949f. rdar://problem/110139703

LocalSampleBufferDisplayLayer crops frames with a rotation of 90 degrees
https://bugs.webkit.org/show_bug.cgi?id=257747
rdar://110139703

Reviewed by Eric Carlson.

We broke the computation of bounds and position in case of rotations in 
https://github.com/WebKit/WebKit/commit/0e0d7976dfe09316e3cb57a4786defeb5c5d7eb6.
We update the code to be back to the previous version.

* 
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::updateRootLayerBoundsAndPosition):

Canonical link: https://commits.webkit.org/264930@main

Canonical link: https://commits.webkit.org/264854.2@safari-7616.1.17-branch


  Commit: fb994f0b12070ef302bad9a3565acb7b7e9b9b54
  
https://github.com/WebKit/WebKit/commit/fb994f0b12070ef302bad9a3565acb7b7e9b9b54
  Author: Jer Noble 
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm

  Log Message:
  ---
  Cherry-pick 580bf6c28d2b. rdar://problem/110320059

REGRESSION (264795@main) Twitter.com: Video blank/black while scrolling
https://bugs.webkit.org/show_bug.cgi?id=257805
rdar://110320059

Reviewed by Eric Carlson.

Use videoInlineSize() rather than presentationSize() to determine whether 
or not a layer should
be created in MediaPlayerPrivateMediaSourceAVFObjC. And to ensure the layer 
does get created when
videoInlineSize() changes, override setVideoInlineSizeFenced() in that 
class, and call it from
RemoteMediaPlayerProxy::setVideoInlineSizeFenced().

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoInlineSizeFenced):
* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeFenced):

Canonical link: https://commits.webkit.org/264949@main

Canoni

[webkit-changes] [WebKit/WebKit] 10b1c1: Versioning.

[MyahCobbs]

  Branch: refs/heads/safari-7616.1.14.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 10b1c1a40933e8b2dc73527c5056f3918a071963
  
https://github.com/WebKit/WebKit/commit/10b1c1a40933e8b2dc73527c5056f3918a071963
  Author: Russell Epstein 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

Identifier: 262728.1070@safari-7616.1.14.11-branch


  Commit: aa29b14404cd7244a710f6b95c44dfbbb4cf911f
  
https://github.com/WebKit/WebKit/commit/aa29b14404cd7244a710f6b95c44dfbbb4cf911f
  Author: Eric Carlson 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h

  Log Message:
  ---
  Cherry-pick 9fd6c7e3607b. rdar://problem/109162122

[macOS] Update ScreenCaptureKitSPI.h
https://bugs.webkit.org/show_bug.cgi?id=256605
rdar://109162122

Reviewed by Jer Noble.

* Source/WebCore/PAL/pal/spi/mac/ScreenCaptureKitSPI.h: Include new header.

Canonical link: https://commits.webkit.org/263927@main

Identifier: 263769.30@safari-7616.1.14.11-branch


  Commit: c55f2b970a4d959422cfc39b7e44a72d4c5c3cae
  
https://github.com/WebKit/WebKit/commit/c55f2b970a4d959422cfc39b7e44a72d4c5c3cae
  Author: Sammy Gill 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Cherry-pick ff409be22993. rdar://problem/109170495

[css-grid][masonry] Containing block for items in a masonry columns grid 
should be the grid's content box logical width
https://bugs.webkit.org/show_bug.cgi?id=256611
rdar://109170495

Reviewed by Matt Woodrow.

The masonry spec states, "The containing block for a grid item is
formed by its grid area in the grid axis and the grid container’s
content-box in the masonry axis."

This means that for a grid that has masonry columns specified, the
masonry axis will be in the logical width direction of the grid. The
items should have their containing block set to the content box logical
box of the grid.

We can modify GridTrackSizingAlgorithm::gridAreaBreadthForChild to
return this value when the grid is a masonry columns grid since normally
the grid area would be used as the containing block in non-masonry
grids. This allows the rest of the code to use the grid area sizes of
the containing block in both masonry and non-masonry scenarios.
Previously, this function would have attempted to compute the
value by iterating over the tracks in the specified direction, but there
are no tracks in the masonry direction so we use the logic specified by
the masonry spec instead.

However, in order for this change to work properly we had to make a
change in RenderGrid::layoutMasonry by removing code that was
incorrectly overriding the logical width of the grid. The previous code
was attempting to set the logical width of the grid to the masonry
content size when the grid had masonry columns specified and an auto
logical width. There were 2 main issues with this piece of code:
1.) m_masonryLayout.gridContentSize() will always return 0 since we
actually haven't performed masonry layout at this point
2.) The grid shouldn't be overriding its logical width like this anyways
and it should instead be set by sized by the rules of the formatting
context it is participating in (e.g. block or inline layout).

By removing this code we can get the actual width of the grid later on
when we call m_renderGrid->contentLogicalWidth() rather than the
incorrect 0 value that it was being set to.

The following example highlights the changes that were made.

grid {
display: grid;
grid-template-columns:masonry;
grid-template-rows: auto;
}





By removing the extra code in RenderGrid::layoutMasonry, the grid will
get sizes as a block level box in the block formatting context it is
participating in, giving it a logical width that takes up its available
space. The svg's containing block logical width is set to its value so
it is able to resolve its percentage width to the correct value whereas
before the containing block logical width would have been 0px.

https://drafts.csswg.org/css-grid-3/#containing-block

* LayoutTests/TestExpectations:
* 
LayoutTests/i

[webkit-changes] [WebKit/WebKit] 47212f: Versioning.

[Jonathan Bedard]

  Branch: refs/heads/safari-7616.1.14.10-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 47212f0dff65964ca103a313655c176c172d9f74
  
https://github.com/WebKit/WebKit/commit/47212f0dff65964ca103a313655c176c172d9f74
  Author: Myah Cobbs 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

Identifier: 263769.29@safari-7616.1.14.10-branch


  Commit: eca1876e391623dd11a48c7edd2952de8c5fc07e
  
https://github.com/WebKit/WebKit/commit/eca1876e391623dd11a48c7edd2952de8c5fc07e
  Author: Sammy Gill 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M LayoutTests/TestExpectations
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/RenderGrid.cpp

  Log Message:
  ---
  Cherry-pick ff409be22993. rdar://problem/109170495

[css-grid][masonry] Containing block for items in a masonry columns grid 
should be the grid's content box logical width
https://bugs.webkit.org/show_bug.cgi?id=256611
rdar://109170495

Reviewed by Matt Woodrow.

The masonry spec states, "The containing block for a grid item is
formed by its grid area in the grid axis and the grid container’s
content-box in the masonry axis."

This means that for a grid that has masonry columns specified, the
masonry axis will be in the logical width direction of the grid. The
items should have their containing block set to the content box logical
box of the grid.

We can modify GridTrackSizingAlgorithm::gridAreaBreadthForChild to
return this value when the grid is a masonry columns grid since normally
the grid area would be used as the containing block in non-masonry
grids. This allows the rest of the code to use the grid area sizes of
the containing block in both masonry and non-masonry scenarios.
Previously, this function would have attempted to compute the
value by iterating over the tracks in the specified direction, but there
are no tracks in the masonry direction so we use the logic specified by
the masonry spec instead.

However, in order for this change to work properly we had to make a
change in RenderGrid::layoutMasonry by removing code that was
incorrectly overriding the logical width of the grid. The previous code
was attempting to set the logical width of the grid to the masonry
content size when the grid had masonry columns specified and an auto
logical width. There were 2 main issues with this piece of code:
1.) m_masonryLayout.gridContentSize() will always return 0 since we
actually haven't performed masonry layout at this point
2.) The grid shouldn't be overriding its logical width like this anyways
and it should instead be set by sized by the rules of the formatting
context it is participating in (e.g. block or inline layout).

By removing this code we can get the actual width of the grid later on
when we call m_renderGrid->contentLogicalWidth() rather than the
incorrect 0 value that it was being set to.

The following example highlights the changes that were made.

grid {
display: grid;
grid-template-columns:masonry;
grid-template-rows: auto;
}





By removing the extra code in RenderGrid::layoutMasonry, the grid will
get sizes as a block level box in the block formatting context it is
participating in, giving it a logical width that takes up its available
space. The svg's containing block logical width is set to its value so
it is able to resolve its percentage width to the correct value whereas
before the containing block logical width would have been 0px.

https://drafts.csswg.org/css-grid-3/#containing-block

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width-expected.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-columns-item-containing-block-is-grid-content-width.html:
 Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutMasonry):

Canonical link: https://commits.webkit.org/264011@main

Identifier: 

[webkit-changes] [WebKit/WebKit] f23885: Compile declarativeNetRequest rules and load them ...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f23885142bfbfa43aa5ccecaffd0b094b3bb7611
  
https://github.com/WebKit/WebKit/commit/f23885142bfbfa43aa5ccecaffd0b094b3bb7611
  Author: Brian Weinstein 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h
M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  ---
  Compile declarativeNetRequest rules and load them into the proper user 
content controllers
https://bugs.webkit.org/show_bug.cgi?id=265399


Reviewed by Timothy Hatcher.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::unload): Remove the compiled rules from all 
userContentControllers.
(WebKit::WebExtensionContext::setHasAccessInPrivateBrowsing): Add or remove 
declarativeNetRequest rules from private browsing
user content controllers.
(WebKit::WebExtensionContext::declarativeNetRequestRuleStore): Returns the rule 
store.
(WebKit::WebExtensionContext::removeDeclarativeNetRequestRules): Removes the 
compiled rules for this extension from all userContentControllers.
(WebKit::WebExtensionContext::addDeclarativeNetRequestRulesToPrivateUserContentControllers):
 Adds the compiled rules for this extension to all
private browsing userContentControllers.
(WebKit::WebExtensionContext::compileDeclarativeNetRequestRules): Translate the 
NSData given to us into rules in the WebKit content blocker format
and compile them. When the compilation finishes, add the compiled content rule 
lists to the needed userContentControllers.
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRules): Add a bug number 
to a FIXME.
* 
Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm:
(WebKit::WebExtensionControllerConfiguration::declarativeNetRequestStoreDirectory):
 Generate the directory to store these content blockers in.
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestTranslator.mm:
(+[_WKWebExtensionDeclarativeNetRequestTranslator 
jsonObjectsFromData:errorStrings:]): Allow fragments when parsing the JSON. 
This is needed
because the top level object of a DNR rule set is an array. We also make sure 
we were given an array.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h:
* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST): Add tests that DNR rules are blocking content in both 
regular and private browsing.

Canonical link: https://commits.webkit.org/271177@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dbf8d1: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7616.1.14-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: dbf8d153deec667c6e6b79c73895d916eee534a6
  
https://github.com/WebKit/WebKit/commit/dbf8d153deec667c6e6b79c73895d916eee534a6
  Author: Russell Epstein 
  Date:   2023-05-15 (Mon, 15 May 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

Identifier: 262728.1070@safari-7616.1.14-branch


  Commit: f47282a27ecab308b94b68965a32b3af61abd659
  
https://github.com/WebKit/WebKit/commit/f47282a27ecab308b94b68965a32b3af61abd659
  Author: Russell Epstein 
  Date:   2023-05-16 (Tue, 16 May 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7616.1.14.6

Canonical link: https://commits.webkit.org/263769.30@safari-7616.1.14-branch


Compare: https://github.com/WebKit/WebKit/compare/35ebdfa44671...f47282a27eca
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.14.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 62cce4: Revert 259842c7afc2. rdar://problem/112205623

[MyahCobbs]

  Branch: refs/heads/safari-7615.3.12.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 62cce4bd7341d7f1280106ea318ab8ac9e504f6b
  
https://github.com/WebKit/WebKit/commit/62cce4bd7341d7f1280106ea318ab8ac9e504f6b
  Author: Myah Cobbs 
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/dom/UserGestureIndicator.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm

  Log Message:
  ---
  Revert 259842c7afc2. rdar://problem/112205623

Identifier: 259548.867@safari-7615.3.12.11-branch


  Commit: 1ca98b99f1161c882aca8a931761c46be92b7f16
  
https://github.com/WebKit/WebKit/commit/1ca98b99f1161c882aca8a931761c46be92b7f16
  Author: Myah Cobbs 
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.3.12.11.3

Identifier: 259548.868@safari-7615.3.12.11-branch


  Commit: 7db474f7a0868b36341bebbb7ff6f83319bd611f
  
https://github.com/WebKit/WebKit/commit/7db474f7a0868b36341bebbb7ff6f83319bd611f
  Author: Myah Cobbs 
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
M Source/WebCore/bindings/js/RunJavaScriptParameters.h
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.h
M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M 
Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp

  Log Message:
  ---
  Revert 465b681115e6. rdar://problem/112231965

Identifier: 259548.869@safari-7615.3.12.11-branch


  Commit: 5bd4f787a19289d536bf94fc3bcc193799611ea8
  
https://github.com/WebKit/WebKit/commit/5bd4f787a19289d536bf94fc3bcc193799611ea8
  Author: Myah Cobbs 
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
M Source/WebCore/bindings/js/RunJavaScriptParameters.h
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.h
M Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M 
Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp

  Log Message:
  ---
  Revert "Revert 465b681115e6. rdar://problem/112231965"

This reverts commit 7db474f7a0868b36341bebbb7ff6f83319bd611f.

Identifier: 259548.870@safari-7615.3.12.11-branch


  Commit: ea6a1355e6ceb6cd4c81273602844548d2aa
  
https://github.com/WebKit/WebKit/commit/ea6a1355e6ceb6cd4c81273602844548d2aa
  Author: Myah Cobbs 
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebCore/dom/UserGestureIndicator.cpp
M Source/WebCore/dom/UserGestureIndicator.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm

  Log Message:
  ---
  Revert "Revert 259842c7afc2. rdar://problem/112205623"

This reverts commit 62cce4bd7341d7f1280106ea318ab8ac9e504f6b.

Identifier: 259548.871@safari-7615.3.12.11-branch


  Commit: 2a0187c2a5ec3824418e4850c9a94693216807f1
  
https://github.com/WebKit/WebKit/commit/2a0187c2a5ec3824418e4850c9a94693216807f1
  Author: Myah Cobbs 
  Date:   2023-09-14 (Thu, 14 Sep 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7615.3.12.11.4

Identifier: 259548.872@safari-7615.3.12.11-branch


  Commit: 60b4ab15e9dc850111950b62f98c1a84cd7e3a99
  
https://github.com/WebKit/WebKit/commit/60b4ab15e9dc850111950b62f98c1a84cd7e3a99
  Author: Keith Miller 
  Date:   2023-09-14 (Thu, 14 Sep 2023)

  Changed paths:
A JSTests/stress/getbyoffset-cse-consistency.js
A JSTests/stress/multigetbyoffset-cse-consistency.js
M Source/JavaScriptCore/dfg/DFGCSEPhase.cpp
M Source/JavaScriptCore/dfg/DFGClobberize.h
M Source/JavaScriptCore/dfg/DFGHeapLocation.h

  Log Message:
  ---
  Cherry-pick 47e039ffd689. rdar://115399657

clobberize needs to be more precise with the *ByOffset nodes
https://bugs.webkit.org/show_bug.cgi?id=261544
rdar://115399657

Reviewed by Yusuke Suzuki and Mark Lam.

CSE phase uses clobberize to figure out if it's safe to merge two 
operations that
def the same HeapLocation. Since HeapLocation does not currently have a way 
to
track the offset used by the various *ByOffset nodes it can get confused and
think that two ByOffset instructions produce the same value even if they 
don't
use the same offset. This patch solves this by 

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.3.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a5122: Cherry-pick r294012. rdar://problem/92425915

[Russell Epstein]

  Branch: refs/heads/safari-7613.3.2.0-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a5122b5f8f7066a26cd322e06fbe6610240ba7c
  
https://github.com/WebKit/WebKit/commit/6a5122b5f8f7066a26cd322e06fbe6610240ba7c
  Author: Alan Coon 
  Date:   2022-05-18 (Wed, 18 May 2022)

  Changed paths:
M LayoutTests/ChangeLog
M LayoutTests/imported/w3c/ChangeLog
A 
LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html
A 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  ---
  Cherry-pick r294012. rdar://problem/92425915

Fix inertness of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=239831

Reviewed by Antti Koivisto.

When we adjust style for a pseudo-element, `m_element` and 
`document().activeModalDialog()` are both null. So we accidentally reset 
inertness to false in those cases.

Fix this by making checking for m_element's existence too.

LayoutTests/imported/w3c:

* web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
* web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.

Source/WebCore:

Test: 
imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html

* style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

LayoutTests:

* 
platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/250446@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294012 
268f45cc-cd09-0410-ab3c-d52691b4dbfc

Canonical link: https://commits.webkit.org/245886.580@safari-613-branch
git-svn-id: 
https://svn.webkit.org/repository/webkit/branches/safari-613-branch@294305 
268f45cc-cd09-0410-ab3c-d52691b4dbfc


  Commit: 905f5f3707de69202a783dfc2292a169f0ea1e45
  
https://github.com/WebKit/WebKit/commit/905f5f3707de69202a783dfc2292a169f0ea1e45
  Author: Alan Coon 
  Date:   2022-05-28 (Sat, 28 May 2022)

  Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/accessibility/dialog-properties-expected.txt
A LayoutTests/accessibility/dialog-properties.html
A LayoutTests/fast/dom/set-dom-window-without-page-expected.txt
A LayoutTests/fast/dom/set-dom-window-without-page.html
M LayoutTests/inspector/model/dom-node-expected.txt
M LayoutTests/inspector/model/dom-node.html
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/b3/B3ReduceStrength.cpp
M Source/JavaScriptCore/inspector/protocol/DOM.json
M Source/ThirdParty/libwebrtc/ChangeLog
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/bindings/js/WindowProxy.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/cache/CachedImage.cpp
M Source/WebCore/page/AutoscrollController.cpp
M Source/WebCore/page/AutoscrollController.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/Frame.cpp
M Source/WebCore/platform/graphics/BitmapImage.cpp
M Source/WebCore/platform/graphics/BitmapImage.h
M Source/WebCore/platform/graphics/ImageSource.cpp
M Source/WebCore/platform/graphics/ImageSource.h
M Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebKit/ChangeLog
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  ---
  Unreviewed build fix. rdar://problem/91519558

./rendering/RenderElement.cpp:723:21:|error: out-of-line definition of 
'moveLayers' does not match any declaration in 'WebCore::RenderElement'

Canonical link: https://commits.webkit.org/245886.581@safari-613-branch
git-svn-id: 
https://svn.webkit.org/repository/webkit/branches/safari-613-branch@295003 
268f45cc-cd09-0410-ab3c-d52691b4dbfc


  Commit: ebce3a645629929dd60749d77b6be6686d52bcf8
  
https://github.com/Web

[webkit-changes] [WebKit/WebKit] 1e3555: Investigate the possibility of replacing twisted h...

[James Carter Bohan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e3555d85962434a8f26aae28cd16815ab5412b8
  
https://github.com/WebKit/WebKit/commit/1e3555d85962434a8f26aae28cd16815ab5412b8
  Author: James Bohan 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/README.md
M Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py
A 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py
M 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py

  Log Message:
  ---
  Investigate the possibility of replacing twisted http server in run-benchmark 
with python3 http.server
https://bugs.webkit.org/show_bug.cgi?id=259835

Reviewed by Stephanie Lewis.

This is an implementation of the python 3 http.server library as the server 
hosting benchmark requests. This would possibly replace the implementation 
where the http server is being run through the externl library, twisted.
Running the http server is behind the new optional flag "--http-server-type" 
which takes in arguments "twisted" or "base" and will launch the http server 
when you put in as the argument. If the flag is not used it will default to 
using the twisted http server.
Requirements for if twisted is installed will only be checked for when running 
the twisted http server.

* Tools/Scripts/webkitpy/benchmark_runner/README.md:
* Tools/Scripts/webkitpy/benchmark_runner/generic_factory.py:
(GenericFactory.create):
* 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py:
 Added.
(Handler):
(Handler.__init__):
(Handler.server_shutdown):
(Handler.log_message):
(Handler.do_GET):
(Handler.do_POST):
* 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.__init__):
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.set_http_server_type):
(SimpleHTTPServerDriver._ensure_http_server_dependencies):
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
(WebServerBenchmarkRunner):

Canonical link: https://commits.webkit.org/271176@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f6040: Unreviewed, reverting 271152@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f6040100f23e26a62d18e65a553215cb4fc7a47
  
https://github.com/WebKit/WebKit/commit/7f6040100f23e26a62d18e65a553215cb4fc7a47
  Author: Commit Queue 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Unreviewed, reverting 271152@main.
https://bugs.webkit.org/show_bug.cgi?id=265409

Introduced crash

Reverted changeset:

"Change install location of WebKit extension processes"
https://bugs.webkit.org/show_bug.cgi?id=265075
https://commits.webkit.org/271152@main

Canonical link: https://commits.webkit.org/271175@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.3.1.0.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cbfb2e: REGRESSION (270359@main): [ macOS wk1 ] ASSERTION ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbfb2e47625c751835cde6af25d35d0d31757510
  
https://github.com/WebKit/WebKit/commit/cbfb2e47625c751835cde6af25d35d0d31757510
  Author: Chris Dumez 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebCore/bindings/js/ScriptController.cpp

  Log Message:
  ---
  REGRESSION (270359@main): [ macOS wk1 ] ASSERTION FAILED: 
ownerDocument->loader() 
/Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Source/WebCore/bindings/js/ScriptController.cpp
https://bugs.webkit.org/show_bug.cgi?id=265403
rdar://118850236

Unreviewed, very partial revert of 270359@main to address the regression.

* Source/WebCore/bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeJavaScriptURL):

Canonical link: https://commits.webkit.org/271174@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.1.2-macOS-10.11.6
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.1-macOS-10.11.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.0.2-macOS-10.11.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.0.1-macOS-10.11.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9-macOS-10.11
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-8.0.7-macOS-10.10.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-7.0.6-macOS-10.9.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-7-macOS-10.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-6-macOS-10.8.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-6-macOS-10.8
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.2.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.4.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.6
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.14.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.14.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.3.9.10.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.3.5.10.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.3.5.10.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.12
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.3.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.4.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.2.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.21.10.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.26.10.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.3.12.10.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.19
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.18.8
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.16.1.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.18.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7614.4.4.1.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.7.1.0.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7614.2.9.0.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7614.1.19
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7615.1.10
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.7.1.0.11
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.7.1.0.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7614.1.12.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7613.7.1.0.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c68f7c: Generate serialization of webrtc::WebKitEncodedFra...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c68f7caf5b378de2ea3e9b95e9745ada7df61203
  
https://github.com/WebKit/WebKit/commit/c68f7caf5b378de2ea3e9b95e9745ada7df61203
  Author: Alex Christensen 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm
M Source/WebKit/Shared/RTCNetwork.serialization.in

  Log Message:
  ---
  Generate serialization of webrtc::WebKitEncodedFrameInfo
https://bugs.webkit.org/show_bug.cgi?id=265398
rdar://118845948

Reviewed by Chris Dumez.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
(webrtc::WebKitEncodedFrameInfo::decode): Deleted.
(webrtc::WebKitEncodedFrameInfo::encode const): Deleted.
* Source/WebKit/Shared/RTCNetwork.serialization.in:

Canonical link: https://commits.webkit.org/271173@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f33d80: Improve Web Extension errors for array types.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f33d80a274e056398ef6b83a60daee41f6ec2ca5
  
https://github.com/WebKit/WebKit/commit/f33d80a274e056398ef6b83a60daee41f6ec2ca5
  Author: Timothy Hatcher 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.messages.in
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm

  Log Message:
  ---
  Improve Web Extension errors for array types.
https://webkit.org/b/265201
rdar://problem/118691550

Reviewed by Brian Weinstein.

Always include the sub-type expected for the array, and be consistent in the 
wording.
Also improve type strings for numbers and JSValues by outputting specific type 
strings.

* Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm:
(WebKit::constructExpectedMessage):
(WebKit::valueToTypeString): Added.
(WebKit::validateSingleObject): Use valueToTypeString.
(WebKit::validateArray): Improve errors.
(WebKit::validateSet): Use valueToTypeString.
* Source/WebKit/UIProcess/Extensions/WebExtensionController.messages.in:
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm:
(WebKit::WebExtensionAPIAction::setIcon):
(WebKit::isValidDimensionKey): Deleted.
* 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebNavigationURLFilter.mm:
(-[_WKWebExtensionWebNavigationURLPredicate 
initWithTypeString:value:outErrorMessage:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271172@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.1.2-macOS-10.11.6
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.1-macOS-10.11.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.0.2-macOS-10.11.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9-macOS-10.11
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-9.0.1-macOS-10.11.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e8b8f7: Stop using SPI: -_scrollView:adjustedOffsetForOffs...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8b8f75b41b3d873fb5aadda2df4da3f1d744f8d
  
https://github.com/WebKit/WebKit/commit/e8b8f75b41b3d873fb5aadda2df4da3f1d744f8d
  Author: Wenson Hsieh 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm
A Source/WebKit/UIProcess/ios/WKAxisLockingScrollView.h
A Source/WebKit/UIProcess/ios/WKAxisLockingScrollView.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Stop using SPI: 
-_scrollView:adjustedOffsetForOffset:translation:startPoint:horizontalVelocity:verticalVelocity:
https://bugs.webkit.org/show_bug.cgi?id=265215
rdar://118696702

Reviewed by Megan Gardner.

Move off of the private `UIScrollViewDelegate` method 
`-_scrollView:adjustedOffsetForOffset:…:`,
which allows clients to retarget the would-be target content offset right 
before a pan gesture (or
pan-gesture-induced momentum scrolling). We currently use this to implement 
`touch-action: pan-x|y`
by retargeting the content offset such that the `x` or `y` offsets are locked 
to their initial
values at the start of scrolling, which has the effect of locking 
pan-gesture-based scrolling to a
single axis.

To achieve the same effect without adopting any scroll view SPI, we can instead 
create and deploy a
new scroll view subclass, `WKAxisLockingScrollView`, which allows clients, in 
the form of a
`WKAxisLockingScrollViewDelegate`, to choose which axis to prevent scrolling 
during a pan gesture by
returning `UIAxisHorizontal` and/or `UIAxisVertical` in a new internal delegate 
method. For example,
we return `UIAxisVertical` to prevent scrolling in the y-axis, when `pan-x` is 
specified (and vice-
versa for `pan-y`).

To implement this subclass, we:

1.  Add our own pan gesture recognizer (the "axis locking pan gesture") to the 
scroll view, right as
UIKit is about to add the built-in `UIScrollViewPanGestureRecognizer`. The 
order in which these
two gestures are added to the scroll view is important, since this 
guarantees that the gesture
action for the axis locking pan gesture will always fire right before the 
scroll view's default
scrolling pan gesture.

2.  We build on this by calling out to the axis locking delegate to get the set 
of axes to prevent
scrolling and use this information to call `-[UIPanGestureRecognizer 
setTranslation:inView:]` on
the scroll view's built-in pan gesture recognizer, zeroing out either the 
`x` or `y` component
of the translation (depending on what the delegate method returned). This 
allows us to make
UIKit behave as if the user was scrolling perfectly along the x or y axis 
upon converting the
pan gesture translation amount into scroll deltas, using the built-in pan 
gesture recognizer.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setupScrollAndContentViews]):
(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
(-[WKWebView axesToPreventScrollingForPanGestureInScrollView:]):
(-[WKWebView 
_scrollView:adjustedOffsetForOffset:translation:startPoint:locationInView:horizontalVelocity:verticalVelocity:]):
 Deleted.

Delete this SPI delegate method implementation, and instead move the 
corresponding logic into the
new `-axesToPreventScrollingForPanGestureInScrollView:` delegate method.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:

Make `WKChildScrollView` subclass the new `WKAxisLockingScrollView`.

* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate 
scrollViewWillEndDragging:withVelocity:targetContentOffset:]):

Because the new `-axesToPreventScrollingForPanGestureInScrollView:` delegate 
method isn't called
after scrolling ends, we need a separate mechanism in order to limit momentum 
scrolling to the
locked scrolling axis. Achieve this by keeping track of the axes where we 
prevented scrolling in the
`WKAxisLockingScrollView` during the pan gesutre, and then use public scroll 
view delegate API to
retarget the default scrolling destination to the current offset value, 
effectively canceling out
any momentum scrolling in that axis.

(-[WKScrollingNodeScrollViewDelegate 
axesToPreventScrollingForPanGestureInScrollView:]):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren):
(-[WKScrollingNodeScrollViewDelegate 
_scrollView:adjustedOffsetForOffset:translation:startPoint:locationIn

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-8.0.7-macOS-10.10.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-6-macOS-10.8.1
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-7-macOS-10.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.2.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-7.0.6-macOS-10.9.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.5
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.9
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.6.6
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/releases/Apple/Safari-6-macOS-10.8
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/tags/WebKit-7616.1.4.4
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes