[webkit-changes] [WebKit/WebKit] 25a4ff: Add Element/ShadowRoot's setHTMLUnsafe() and Docum...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25a4ff15329b263c8d8550dbda463e09d2d5e41b
  
https://github.com/WebKit/WebKit/commit/25a4ff15329b263c8d8550dbda463e09d2d5e41b
  Author: Anne van Kesteren 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-encoding-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-encoding.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-style-attribute-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-style-attribute.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-base-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-base-pushstate-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-base-pushstate.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-base.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-moretests-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-moretests.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-pushstate-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url-pushstate.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe-url.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Document-parseHTMLUnsafe.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Element-setHTMLUnsafe-04-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/Element-setHTMLUnsafe-04.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-iframe-base-pushstate.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-iframe-base.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-iframe-pushstate.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-iframe.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-iframe.js
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/parseHTMLUnsafe-url-tests.js
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/resources/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/setHTMLUnsafe-CEReactions-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/setHTMLUnsafe-CEReactions.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/setHTMLUnsafe-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/setHTMLUnsafe-xml-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/html-unsafe-methods/setHTMLUnsafe-xml.html
A 

[webkit-changes] [WebKit/WebKit] 0bfa98: Add outlineBoundsRect to RepaintRects

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bfa98376d7330aae32fffe27eff473b21693152
  
https://github.com/WebKit/WebKit/commit/0bfa98376d7330aae32fffe27eff473b21693152
  Author: Simon Fraser 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp

  Log Message:
  ---
  Add outlineBoundsRect to RepaintRects
https://bugs.webkit.org/show_bug.cgi?id=265695
rdar://119049099

Reviewed by Alan Baradlay.

Another step towards computing clippedOverflowRect and outlineBoundsRect in the 
same
ancestor traversal is adding an optioal outlineBoundsRect to RepaintRects. Note
that this isn't clipped by the `intersect` functions, replicating the unclipped
behavior of `outlineBoundsForRepaint()`.

No-one sets the outlineBoundsRect yet.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollPosition const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RepaintRects::transform):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::RepaintRects::RepaintRects):
(WebCore::RenderObject::RepaintRects::move):
(WebCore::RenderObject::RepaintRects::moveBy):
(WebCore::RenderObject::RepaintRects::expand):
(WebCore::RenderObject::RepaintRects::encloseToIntRects):
(WebCore::RenderObject::RepaintRects::unite):
(WebCore::RenderObject::RepaintRects::flipForWritingMode):
(WebCore::RenderObject::RepaintRects::intersect):
(WebCore::RenderObject::RepaintRects::edgeInclusiveIntersect):
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::applyCachedClipAndScrollPosition const):

Canonical link: https://commits.webkit.org/271422@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 992f87: [Wasm-GC] Fix array.new_data & array.new_elem for ...

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 992f87e27f7f214ec2e85607449dd5da87a39f1c
  
https://github.com/WebKit/WebKit/commit/992f87e27f7f214ec2e85607449dd5da87a39f1c
  Author: Asumu Takikawa 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M JSTests/wasm/gc/array_new_data.js
M JSTests/wasm/gc/array_new_elem.js
M Source/JavaScriptCore/wasm/WasmFunctionParser.h
M Source/JavaScriptCore/wasm/WasmOperationsInlines.h

  Log Message:
  ---
  [Wasm-GC] Fix array.new_data & array.new_elem for recursive array types
https://bugs.webkit.org/show_bug.cgi?id=265677

Reviewed by Justin Michaud.

Use helper functions to correctly handle recursive type cases in array.new_data
& new_elem.

* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::parseExpression):
* Source/JavaScriptCore/wasm/WasmOperationsInlines.h:
(JSC::Wasm::arrayNewData):
(JSC::Wasm::arrayNewElem):

Canonical link: https://commits.webkit.org/271421@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b02c88: [Wasm-GC] Add tests for 262863

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b02c88c35d2f810359826473149956b30ea9b225
  
https://github.com/WebKit/WebKit/commit/b02c88c35d2f810359826473149956b30ea9b225
  Author: Asumu Takikawa 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A JSTests/wasm/gc/bug262863.js

  Log Message:
  ---
  [Wasm-GC] Add tests for 262863
https://bugs.webkit.org/show_bug.cgi?id=262863

Reviewed by Justin Michaud.

The originally reported crash is no longer reproducible. This commit just adds
a test for it, updated for the latest opcodes.

* JSTests/wasm/gc/bug262863.js: Added.
(module):

Canonical link: https://commits.webkit.org/271420@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b3ffcc: MediaSample should use integer as track id rather ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3ffcc0a9df7ef521eebfd10f5da302fbbb2180c
  
https://github.com/WebKit/WebKit/commit/b3ffcc0a9df7ef521eebfd10f5da302fbbb2180c
  Author: Jean-Yves Avenard 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
M Source/WebCore/Modules/mediasource/SourceBuffer.h
M Source/WebCore/html/track/AudioTrack.cpp
M Source/WebCore/html/track/AudioTrack.h
M Source/WebCore/html/track/AudioTrackList.cpp
M Source/WebCore/html/track/AudioTrackList.h
M Source/WebCore/html/track/InbandTextTrack.cpp
M Source/WebCore/html/track/InbandTextTrack.h
M Source/WebCore/html/track/TextTrack.cpp
M Source/WebCore/html/track/TextTrack.h
M Source/WebCore/html/track/TextTrackList.cpp
M Source/WebCore/html/track/TextTrackList.h
M Source/WebCore/html/track/TrackBase.cpp
M Source/WebCore/html/track/TrackBase.h
M Source/WebCore/html/track/TrackListBase.h
M Source/WebCore/html/track/VideoTrack.cpp
M Source/WebCore/html/track/VideoTrack.h
M Source/WebCore/html/track/VideoTrackList.cpp
M Source/WebCore/html/track/VideoTrackList.h
M Source/WebCore/platform/MediaSample.h
M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp
M Source/WebCore/platform/graphics/InbandTextTrackPrivate.h
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.h
M Source/WebCore/platform/graphics/TrackPrivateBase.cpp
M Source/WebCore/platform/graphics/TrackPrivateBase.h
M Source/WebCore/platform/graphics/TrackPrivateBaseClient.h
M Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h
M Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm
M Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h
M 
Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp
M 
Source/WebCore/platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h
M Source/WebCore/platform/graphics/avfoundation/VideoTrackPrivateAVF.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp
M 
Source/WebCore/platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h
M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp
M 
Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.cpp
M Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp
M Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.h
M Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourceTrackGStreamer.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h
M 

[webkit-changes] [WebKit/WebKit] e14fcc: [WebGPU] Enable several passing CTS tests and add ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e14fccd71bf7601319d6bd4dacc4446f6dc7caf1
  
https://github.com/WebKit/WebKit/commit/e14fccd71bf7601319d6bd4dacc4446f6dc7caf1
  Author: Mike Wyrzykowski 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/render/dynamic_state-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/render/state_tracking-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/api/operation/queue/submit-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pass/resolve-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pass/storeOp-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/render_pass/storeop2-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/basic-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/color_target_state-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/depth-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/texture_view/format_reinterpretation-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/validation/buffer/destroy-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/submit-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/validation/queue/writeBuffer-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/validation/texture/rg11b10ufloat_renderable-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/af_comparison-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/bitwise-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/bitwise_shift-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/bool_logical-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_addition-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_comparison-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_division-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_matrix_addition-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_matrix_scalar_multiplication-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_matrix_vector_multiplication-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_multiplication-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/f32_subtraction-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/i32_comparison-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/binary/u32_comparison-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/all-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/any-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicAdd-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicLoad-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicMax-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicMin-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicOr-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicStore-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicSub-expected.txt
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/atomics/atomicXor-expected.txt

  Log Message:
  ---
  [WebGPU] Enable several passing CTS tests and add their expectations
https://bugs.webkit.org/show_bug.cgi?id=264210


Reviewed by Tadeu Zagallo.

All these tests are passing locally on Apple Silicon without source changes so 
enable them.

Inspected all expectations and they read pass with no failures.

Its possible there are some failures on Intel or AMD devices, will validate 
with EWS.

* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/copyTextureToTexture-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/render/dynamic_state-expected.txt:
* 

[webkit-changes] [WebKit/WebKit] 237465: Add additional release asserts to ensure we not no...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 237465e1ea2208b605a0ddbf0b0375ce96917476
  
https://github.com/WebKit/WebKit/commit/237465e1ea2208b605a0ddbf0b0375ce96917476
  Author: Megan Gardner 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Add additional release asserts to ensure we not not calling SPI when using 
the Async input delegate.
https://bugs.webkit.org/show_bug.cgi?id=265604
rdar://119001813

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView webSelectionRects]):
(-[WKContentView clearSelection]):
(-[WKContentView _allowAnimatedUpdateSelectionRectViews]):
(-[WKContentView selectionRange]):
(-[WKContentView replaceRangeWithTextWithoutClosingTyping:replacementText:]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView setBottomBufferHeight:]):
(-[WKContentView automaticallySelectedOverlay]):
(-[WKContentView metadataDictionariesForDictationResults]):
(-[WKContentView hasContent]):
(-[WKContentView selectAll]):
(-[WKContentView hasSelection]):
(-[WKContentView takeTraitsFrom:]):

Canonical link: https://commits.webkit.org/271417@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b738ab: Fix shadow repaint issue in vertical-rl mode

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b738ab355f6e5ca1450ef7c5cbfdff9430857a42
  
https://github.com/WebKit/WebKit/commit/b738ab355f6e5ca1450ef7c5cbfdff9430857a42
  Author: Ahmad Saleem 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A LayoutTests/fast/box-shadow/shadow-box-resize-expected.txt
A LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt
A LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode.html
A LayoutTests/fast/box-shadow/shadow-box-resize.html
M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  ---
  Fix shadow repaint issue in vertical-rl mode

https://bugs.webkit.org/show_bug.cgi?id=258740
rdar://problem/111915460

Reviewed by Alan Baradlay.

Merge: https://src.chromium.org/viewvc/blink?revision=177246=revision

The original code erroneously flipped the shadow edges when the box is
in vertical-rl writing mode, causing incorrect visual overflow and
repaint rects.

Our actual painting code for shadow is correct. The bug is just about
incorrect invalidation rects.

As per Web Specification [1], the writing-mode should not affect 'box-shadow'
and 'text-shadow' offsets due to purely being physical.

[1] https://drafts.csswg.org/css-writing-modes-3/#physical-only

* Source/WebCore/rendering/RenderBox.cpp:
(RenderBox::applyVisualEffectOverflow):
* LayoutTests/fast/box-shadow/shadow-box-resize.html: Add Test Case
* LayoutTests/fast/box-shadow/shadow-box-resize-expected.txt: Add Test Case 
Expectation
* LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode.html: Add Test Case
* LayoutTests/fast/box-shadow/shadow-box-resize-writing-mode-expected.txt: Add 
Test Case Expectation

Canonical link: https://commits.webkit.org/271416@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53b6a4: REGRESSION(265596@main): [Cocoa] In-band captions ...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53b6a4522e456da88f5fde66f7687d2f24335994
  
https://github.com/WebKit/WebKit/commit/53b6a4522e456da88f5fde66f7687d2f24335994
  Author: Jer Noble 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A LayoutTests/media/content/test-inband-captions.mp4
A LayoutTests/media/track/track-in-band-layout-expected.txt
A LayoutTests/media/track/track-in-band-layout.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/html/track/InbandGenericTextTrack.cpp
M Source/WebCore/html/track/TextTrackCueGeneric.cpp
M Source/WebCore/html/track/TextTrackCueGeneric.h
M Source/WebCore/html/track/VTTCue.h
M Source/WebCore/platform/graphics/InbandGenericCue.cpp
M Source/WebCore/platform/graphics/InbandGenericCue.h
M 
Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  REGRESSION(265596@main): [Cocoa] In-band captions generate large, 
line-wrapped cues
https://bugs.webkit.org/show_bug.cgi?id=265635
rdar://119024855

Reviewed by Eric Carlson.

When modernizing VTTCue, TextTrackCueGeneric was not sufficiently updated to 
take advantage
of the correct layout implemented by VTTCue. Specifically, TextTrackCueGeneric 
still queried
VTTCueBox::fontSizeFromCaptionUserPrefs(), which was no longer set, and caused 
the cue width
to be incorrectly set to zero.

Remove that dead method, and remove most of the implementation of
TextTrackCueGenericBoxElement::applyCSSProperties, relying instead upon 
VTTCueBoxElement's
implementation.

In order to correctly position TextTrackCueGeneric objects created from 
AVFoundation, set
the resulting cue's positionAlign() to "Center" by way of GenericCueData. This 
causes VTTCue
to position the cue relative to the cue's center point, which is the same way 
AVFoundation
represents the cue's position.

* LayoutTests/media/content/test-inband-captions.mp4: Added.
* LayoutTests/media/track/track-in-band-layout-expected.txt: Added.
* LayoutTests/media/track/track-in-band-layout.html: Added.
* Source/WebCore/html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::updateCueFromCueData):
* Source/WebCore/html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
(WebCore::TextTrackCueGeneric::setBaseFontSizeRelativeToVideoHeight):
(WebCore::TextTrackCueGeneric::setFontSizeMultiplier):
(WebCore::TextTrackCueGeneric::setFontSize): Deleted.
* Source/WebCore/html/track/TextTrackCueGeneric.h:
* Source/WebCore/html/track/VTTCue.h:
(WebCore::VTTCueBox::setFontSizeFromCaptionUserPrefs): Deleted.
(WebCore::VTTCueBox::fontSizeFromCaptionUserPrefs const): Deleted.
* Source/WebCore/platform/graphics/InbandGenericCue.cpp:
(WebCore::InbandGenericCue::toJSONString const):
* Source/WebCore/platform/graphics/InbandGenericCue.h:
(WebCore::GenericCueData::GenericCueData):
(WebCore::InbandGenericCue::positionAlign const):
(WebCore::InbandGenericCue::setPositionAlign):
* Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/271415@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ded506: Implement declarativeNetRequest.isRegexSupported

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ded5062ffb2601dac60ce1cfc4e3e1b99ae1fb34
  
https://github.com/WebKit/WebKit/commit/ded5062ffb2601dac60ce1cfc4e3e1b99ae1fb34
  Author: Brian Weinstein 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm
M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  ---
  Implement declarativeNetRequest.isRegexSupported
https://bugs.webkit.org/show_bug.cgi?id=265701
rdar://118940110

Reviewed by Timothy Hatcher.

* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionAPIDeclarativeNetRequest::isRegexSupported):
* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271414@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1f2ed7: [Gardening]: REGRESSION (271011@main): [ Ventura+ ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f2ed7417192654a6184df413a1afea8677ebd02
  
https://github.com/WebKit/WebKit/commit/1f2ed7417192654a6184df413a1afea8677ebd02
  Author: Marta Darbinyan 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/platform/wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (271011@main): [ Ventura+ x86_64 wk2 ] 
webrtc/multi-video.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=265700
rdar://119051908

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/wk2/TestExpectations:

Canonical link: https://commits.webkit.org/271413@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ecc5b3: Add IPV6 support to built-in server for run-benchm...

[James Carter Bohan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecc5b337e0f999d49c89eba273e15483d9231015
  
https://github.com/WebKit/WebKit/commit/ecc5b337e0f999d49c89eba273e15483d9231015
  Author: James Bohan 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py

  Log Message:
  ---
  Add IPV6 support to built-in server for run-benchmarks
https://bugs.webkit.org/show_bug.cgi?id=265402

Reviewed by Dewei Zhu.

Using socket.getaddrinfo() allows us to determine if the address is IPv4 or 
IPv6, and we can then adjust the address family in HTTPServer accordingly.

* 
Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/builtin_http_server.py:

Canonical link: https://commits.webkit.org/271412@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 93216f: Unreviewed, reverting 271405@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93216fee625c6675f5fc0c8d0d8449b4c08b6388
  
https://github.com/WebKit/WebKit/commit/93216fee625c6675f5fc0c8d0d8449b4c08b6388
  Author: Commit Queue 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/NavigationActionData.h
M Source/WebKit/Shared/NavigationActionData.serialization.in
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  ---
  Unreviewed, reverting 271405@main.
https://bugs.webkit.org/show_bug.cgi?id=265699

broke macOS build

Reverted changeset:

"Call into WKApplicationUtilities when handling certain types of links"
https://bugs.webkit.org/show_bug.cgi?id=265172
https://commits.webkit.org/271405@main

Canonical link: https://commits.webkit.org/271411@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dc8ef5: Implement declarativeNetRequest.updateEnabledRulesets

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc8ef58782b8f08276f8731a52ebbdb54d08ac9d
  
https://github.com/WebKit/WebKit/commit/dc8ef58782b8f08276f8731a52ebbdb54d08ac9d
  Author: Brian Weinstein 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A 
Source/WebKit/Shared/Extensions/WebExtensionDeclarativeNetRequestConstants.h
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIDeclarativeNetRequest.h
M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  ---
  Implement declarativeNetRequest.updateEnabledRulesets
https://bugs.webkit.org/show_bug.cgi?id=265616
rdar://118940027

Reviewed by Timothy Hatcher.

When an extension calls updateEnabledRulesets - the following happens:
1) We validate the arguments in the WebProcess to make sure they are of the 
correct format
2) We call into the UI process to perform the work
3) The UI process makes sure all of the passed identifiers exist, and if they 
do, we attempt to perform the update

To do this, we modify the enabled state of the given rulesets, and attempt to 
load the declarativeNetRequest rules again.

If this succeeds, we write the updated state to disk. If it fails, we revert 
the changes that were made (and will continue to use
the old DNR rules).

This patch also adds tests for getEnabledRulesets and updateEnabledRulesets.

* Source/WebKit/Shared/Extensions/WebExtensionDeclarativeNetRequestConstants.h: 
Copied from 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm.
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRulesetStateFromStorage):
 Read the modified state of rulesets from State.plist
and apply it.
(WebKit::WebExtensionContext::saveDeclarativeNetRequestRulesetStateToStorage): 
Merge the given dictionary with the existing one and
save it to disk.
(WebKit::WebExtensionContext::declarativeNetRequestValidateRulesetIdentifiers): 
Make sure all of the ruleset identifiers exist and throw
an error if any don't.
(WebKit::WebExtensionContext::declarativeNetRequestEnabledRulesetCount): Get 
the count of enabled rulesets.
(WebKit::WebExtensionContext::declarativeNetRequestToggleRulesets): Set the 
state of the given rulesets.
(WebKit::WebExtensionContext::declarativeNetRequestUpdateEnabledRulesets): 
Perform the logic described in steps 3+ earlier in the commit message.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::populateDeclarativeNetRequestPropertiesIfNeeded): Adopt 
a few constants.
(WebKit::WebExtension::declarativeNetRequestRulesets): These ruleset objects 
can be changed, so don't return const.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::load): Call 
loadDeclarativeNetRequestRulesetStateFromStorage at startup. We don't want to 
call this each time that the
loadDeclarativeNetRequestRules is called, because we might be attempting to 
update the enabled rulesets and in that case we don't want to consult storage
yet.
(WebKit::WebExtensionContext::queueStartupAndInstallEventsForExtensionIfNecessary):
 Clear any customized rulesets upon update.
(WebKit::WebExtensionContext::compileDeclarativeNetRequestRules): Add a 
completion handler.
(WebKit::WebExtensionContext::loadDeclarativeNetRequestRules): Ditto.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.messages.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionAPIDeclarativeNetRequest::updateEnabledRulesets): Perform 
argument validation.
* 
Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIDeclarativeNetRequest.h:
(WebKit::WebExtensionAPIDeclarativeNetRequest::maxNumberOfStaticRulesets 
const): Use a constant.
(WebKit::WebExtensionAPIDeclarativeNetRequest::maxNumberOfEnabledRulesets 
const): Ditto.
(WebKit::WebExtensionAPIDeclarativeNetRequest::maxNumberOfDynamicAndSessionRules
 const): Ditto.

Canonical link: https://commits.webkit.org/271410@main


___
webkit-changes 

[webkit-changes] [WebKit/WebKit] c91bcb: [run-webkit-tests] Avoid generating then deleting ...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c91bcbda38e9cd8f6eb699d6c602782603610eaa
  
https://github.com/WebKit/WebKit/commit/c91bcbda38e9cd8f6eb699d6c602782603610eaa
  Author: Sam Sneddon 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
R 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py
M 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
M 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

  Log Message:
  ---
  [run-webkit-tests] Avoid generating then deleting several JSON files
https://bugs.webkit.org/show_bug.cgi?id=265553

Reviewed by Jonathan Bedard.

webkitpy.layout_tests.controllers.manager ends up creating both
incremental_results.json and times_ms.json just to immediately delete
them. We should simplify our code by simply not generating them.

Now not generating them, we can delete a lot of now dead code.

* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._save_json_files):
* 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
 Removed.
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(write_json):
(add_path_to_trie):
(_add_perf_metric_for_test):
(perf_metrics_for_test):
(convert_trie_to_flat_paths): Deleted.
(test_timings_trie): Deleted.
(TestResult): Deleted.
(TestResult.__init__): Deleted.
(TestResult.fixable): Deleted.
(JSONResultsGenerator): Deleted.
(JSONResultsGenerator.__init__): Deleted.
(JSONResultsGenerator.generate_json_output): Deleted.
(JSONResultsGenerator.generate_times_ms_file): Deleted.
(JSONResultsGenerator.get_json): Deleted.
(JSONResultsGenerator.set_archived_results): Deleted.
(JSONResultsGenerator._get_test_timing): Deleted.
(JSONResultsGenerator._get_failed_test_names): Deleted.
(JSONResultsGenerator._get_modifier_char): Deleted.
(JSONResultsGenerator._get_result_char): Deleted.
(JSONResultsGenerator._insert_failure_summaries): Deleted.
(JSONResultsGenerator._insert_item_into_raw_list): Deleted.
(JSONResultsGenerator._insert_item_run_length_encoded): Deleted.
(JSONResultsGenerator._insert_test_time_and_result): Deleted.
(JSONResultsGenerator._populate_results_and_times_json): Deleted.
(JSONResultsGenerator._create_results_for_builder_json): Deleted.
* 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_strip_json_wrapper):
(JSONGeneratorTest.test_perf_metrics_for_test):
(JSONGeneratorTest._test_json_generation): Deleted.
(JSONGeneratorTest._verify_json_results): Deleted.
(JSONGeneratorTest._find_test_in_trie): Deleted.
(JSONGeneratorTest.test_json_generation): Deleted.
(JSONGeneratorTest.test_hierarchical_json_generation): Deleted.
(JSONGeneratorTest.test_test_timings_trie): Deleted.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

Canonical link: https://commits.webkit.org/271409@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f784ae: Reduce exposure of ImageBuffer's backend implement...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f784aeef6e0a7be2725bf8e003511a7501683081
  
https://github.com/WebKit/WebKit/commit/f784aeef6e0a7be2725bf8e003511a7501683081
  Author: Tim Horton 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/ImageBuffer.h
M Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm
M Source/WebKit/Shared/WebImage.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.mm
M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
M Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h

  Log Message:
  ---
  Reduce exposure of ImageBuffer's backend implementation detail
https://bugs.webkit.org/show_bug.cgi?id=265623

Reviewed by Matt Woodrow.

In preparation for an ImageBuffer subclass that owns multiple backends,
try to reduce non-ImageBuffer code's ability to get ahold of the backend 
directly.

To do this:
- rename ensureBackendCreated() to ensureBackend(); it still creates and 
returns the backend
- add ensureBackendCreated(), which creates but does not return the backend
- remove takeBackend(), which is unused
- add toBackendSharing(), which just delegates to the backend internally
- add transferToNewContext(), which just delegates to the backend internally
- add hasBackend(), which just returns the existence of the backend but does 
not expose it
- make backend() and ensureBackend() protected, entirely isolating the backend 
from the rest of WebCore

There is definitely more cleanup to be done; it seems prudent to eventually 
further
hide the backend from ImageBuffer clients (but we still have e.g. 
ensureBackendCreated
and hasBackend,  and the whole ImageBufferBackendSharing class structure
unnecessarily uses the "Backend" naming).

* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::flushDrawingContext):
(WebCore::ImageBuffer::copyNativeImage const):
(WebCore::ImageBuffer::createNativeImageReference const):
(WebCore::ImageBuffer::sinkIntoNativeImage):
(WebCore::ImageBuffer::filteredNativeImage):
(WebCore::ImageBuffer::createCairoSurface):
(WebCore::ImageBuffer::convertToLuminanceMask):
(WebCore::ImageBuffer::transformToColorSpace):
(WebCore::ImageBuffer::getPixelBuffer const):
(WebCore::ImageBuffer::putPixelBuffer):
(WebCore::ImageBuffer::isInUse const):
(WebCore::ImageBuffer::releaseGraphicsContext):
(WebCore::ImageBuffer::setVolatile):
(WebCore::ImageBuffer::setNonVolatile):
(WebCore::ImageBuffer::volatilityState const):
(WebCore::ImageBuffer::setVolatilityState):
(WebCore::ImageBuffer::createFlusher):
(WebCore::ImageBuffer::toBackendSharing):
(WebCore::ImageBuffer::transferToNewContext):
(WebCore::ImageBuffer::takeBackend): Deleted.
* Source/WebCore/platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::ensureBackendCreated const):
(WebCore::ImageBuffer::hasBackend):
(WebCore::ImageBuffer::backend const):
(WebCore::ImageBuffer::ensureBackend const):
* Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp:
(WebKit::ImageBufferShareableAllocator::createImageBuffer const):
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::didCreateImageBuffer):
(WebKit::RemoteRenderingBackend::moveToImageBuffer):
(WebKit::handleFromBuffer):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode const):
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::collectBackingStoreBufferIdentifiersToMarkVolatile):
* Source/WebKit/Shared/WebImage.cpp:
(WebKit::WebImage::bitmap const):
(WebKit::WebImage::createHandle const):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::ensureBackend const):
(WebKit::RemoteImageBufferProxy::prepareForBackingStoreChange):
(WebKit::RemoteImageBufferProxy::sinkIntoSerializedImageBuffer):
(WebKit::RemoteImageBufferProxy::ensureBackendCreated const): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
* 

[webkit-changes] [WebKit/WebKit] 31af7c: Hook up Web Extension context menus to WKWebView o...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31af7ceffae9edab123477a13b7ddadbaef44f02
  
https://github.com/WebKit/WebKit/commit/31af7ceffae9edab123477a13b7ddadbaef44f02
  Author: Timothy Hatcher 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h
M Source/WebKit/Shared/Extensions/WebExtensionMenuItem.serialization.in
M Source/WebKit/Shared/Extensions/WebExtensionMenuItemContextParameters.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.cpp
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h
M 
Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm
M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl
M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm

  Log Message:
  ---
  Hook up Web Extension context menus to WKWebView on macOS.
https://webkit.org/b/265591
rdar://problem/118995365

Reviewed by Brian Weinstein.

Include Web Extension context menus to WKWebViews that use the extension 
controller
and when the extension has permission to the page or activeTab.

* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::truncatedStringForMenuItem): Change from a static to export it for 
WebKit to use.
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h:
(WebKit::toWebExtensionFrameIdentifier): Added.
* Source/WebKit/Shared/Extensions/WebExtensionMenuItem.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionMenuItemContextParameters.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::addItemsToContextMenu): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::addItemsToContextMenu): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm:
(WebKit::WebExtensionMenuItem::WebExtensionMenuItem):
(WebKit::WebExtensionMenuItem::update):
(WebKit::WebExtensionMenuItem::platformMenuItem const):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.cpp:
(WebKit::WebExtensionMenuItem::matches const):
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::useContextMenuItems):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm:
(WebKit::WebExtensionContextProxy::dispatchMenusClickedEvent):
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm:
(WebKit::debugString): Move up, support functions.
(WebKit::WebExtensionAPITest::log): Support object logging as JSON.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h:
* Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm:
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl:
* Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271407@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 382b6c: Mark http/tests/site-isolation/basic-iframe-render...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 382b6c8cb841e093e3a85257e0db880f4d725f91
  
https://github.com/WebKit/WebKit/commit/382b6c8cb841e093e3a85257e0db880f4d725f91
  Author: Alex Christensen 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  Mark http/tests/site-isolation/basic-iframe-render-output.html as flaky on iOS
https://bugs.webkit.org/show_bug.cgi?id=265691

Unreviewed.

It's been somewhat reliable, but mark it as flaky to prevent any false EWS 
negatives.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/271406@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 040d74: Call into WKApplicationUtilities when handling cer...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 040d74b4188067ac84d941cc83a85dab997015f4
  
https://github.com/WebKit/WebKit/commit/040d74b4188067ac84d941cc83a85dab997015f4
  Author: Ben Nham 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/NavigationActionData.h
M Source/WebKit/Shared/NavigationActionData.serialization.in
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  ---
  Call into WKApplicationUtilities when handling certain types of links
https://bugs.webkit.org/show_bug.cgi?id=265172
rdar://118667681

Reviewed by Brent Fulgham and Elliott Williams.

In order to implement a particular feature, we need to call into 
WKApplicationUtilities when
handling certain types of navigation actions. This then calls a Swift-only API. 
To do this, we copy
WKApplicationUtilities.swift from WebKitAddition's include location to WebKit's 
DerivedSources. We
use EXCLUDED_SOURCE_FILES to exclude that file on platforms and SDKs where it 
doesn't exist.

This also requires us to know the top frame's origin at the point of 
navigation, and I couldn't find
any good way of accessing that state in decidePolicyForNavigationAction. So I 
modified
NavigationActionData to carry the topOrigin state.

* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI):
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

Canonical link: https://commits.webkit.org/271405@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b74f37: [Gardening]: NEW TEST (271377@main): [ Sonoma ] ht...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b74f37620e580ceca5c263a5dfc5defd1fa4904a
  
https://github.com/WebKit/WebKit/commit/b74f37620e580ceca5c263a5dfc5defd1fa4904a
  Author: Marta Darbinyan 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: NEW TEST (271377@main): [ Sonoma ] 
http/wpt/webcodecs/encoder-task-failing.html is constant failure
https://bugs.webkit.org/show_bug.cgi?id=265685
rdar://119043575

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/271404@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e810cd: [UnifiedPDF] Implement snapshotting

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e810cde0dcadb06b50af157ea3486eb36bfa7d46
  
https://github.com/WebKit/WebKit/commit/e810cde0dcadb06b50af157ea3486eb36bfa7d46
  Author: Tim Horton 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp

  Log Message:
  ---
  [UnifiedPDF] Implement snapshotting
https://bugs.webkit.org/show_bug.cgi?id=265630


Reviewed by Richard Robinson.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::shouldCreateTransientPaintingSnapshot const):
(WebKit::PDFPluginBase::snapshot):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paint):
(WebKit::UnifiedPDFPlugin::snapshot): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot const):
Implement paint() in terms of paintContents() and disable the unnecessary
indirection of PDFPlugin's ShareableBitmap snapshotting for UnifiedPDFPlugin.

paint() is only called during snapshotting.

Canonical link: https://commits.webkit.org/271403@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3fc682: REGRESSION (270847@main): Typing three '.' adds ex...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fc6828f05499081fc602ef98715349aa167e5bd
  
https://github.com/WebKit/WebKit/commit/3fc6828f05499081fc602ef98715349aa167e5bd
  Author: Wenson Hsieh 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A 
LayoutTests/editing/input/ios/autocorrection-replaces-three-dots-with-ellipsis-expected.txt
A 
LayoutTests/editing/input/ios/autocorrection-replaces-three-dots-with-ellipsis.html
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  REGRESSION (270847@main): Typing three '.' adds extra periods instead of 
combining
https://bugs.webkit.org/show_bug.cgi?id=265671
rdar://118971986

Reviewed by Tim Horton and Megan Gardner.

After the changes in 270847@main, typing three `"."` characters results in the 
string `"..…"`,
instead of just a single ellipsis character. This is because UIKit now obtains 
a reinsertion string
when calling `-_expandSelectionToBackwardDeletionClusterWithReinsertionOut:`, 
underneath
`-[UIKeyboardImpl 
_deleteBackwardAndNotify:reinsertText:overrideOriginalContextBeforeInputWith:]`.
However, because we don't support synchronous calls to `-setSelectedRange:` 
with these new relative
ranges, UIKit's text reinsertion logic breaks, resulting in both the 
reinsertion string, `".."`, as
well as the replacement string, `"…"`, being inserted into the document.

To fix this in the short term, we conditionalize this `WKRelativeTextRange` 
refactoring (as well as
moving away from `-_characterInRelationToCaretSelection:`) on async text input 
enablement. The real
fix will require UIKit changes — i.e., refactoring keyboard code to handle 
async text inputs that
return non-null `-textRangeFromPosition:toPosition:`, but (crucially) don't 
support calls to
`-setSelectedTextRange:` that are expected to synchronously update document 
state.

Test: editing/input/ios/autocorrection-replaces-three-dots-with-ellipsis.html

* 
LayoutTests/editing/input/ios/autocorrection-replaces-three-dots-with-ellipsis-expected.txt:
 Added.
* 
LayoutTests/editing/input/ios/autocorrection-replaces-three-dots-with-ellipsis.html:
 Added.

Add a new layout test to exercise this scenario.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _characterInRelationToCaretSelection:]):

Restore this private method implementation, but call directly into the 
superclass implementation
instead of relying on our custom logic, in the case where async text input is 
enabled.

(-[WKContentView textRangeFromPosition:toPosition:]):
(-[WKContentView positionFromPosition:offset:]):

Revert to returning `nil`, in the case where async text input is disabled.

Canonical link: https://commits.webkit.org/271402@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0adc9c: Move some window functions from WebProcessProxy to...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0adc9c766fb1391a789d379cfbf86bc13a1a3d19
  
https://github.com/WebKit/WebKit/commit/0adc9c766fb1391a789d379cfbf86bc13a1a3d19
  Author: Charlie Wolfe 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/RemotePageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h
M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  ---
  Move some window functions from WebProcessProxy to WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=265608
rdar://119003812

Reviewed by Alex Christensen.

To resolve 'FIXME: This, postMessageToRemote, renderTreeAsText, etc. should be 
messages to the
WebPageProxy instead of the process. They are more the page doing things than 
the process.'

* Source/WebKit/UIProcess/RemotePageProxy.h:
(WebKit::RemotePageProxy::sendSync):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendToWebPage):
(WebKit::WebPageProxy::sendSyncToProcessContainingFrame):
I added helper functions to support sending synchronous IPC messages to a 
process containing a
specified frame.

(WebKit::WebPageProxy::closeRemoteFrame):
(WebKit::WebPageProxy::focusRemoteFrame):
(WebKit::WebPageProxy::postMessageToRemote):
(WebKit::WebPageProxy::renderTreeAsText):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::postMessageToRemote): Deleted.
(WebKit::WebProcessProxy::closeRemoteFrame): Deleted.
(WebKit::WebProcessProxy::focusRemoteFrame): Deleted.
(WebKit::WebProcessProxy::renderTreeAsText): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::postMessageToRemote):
(WebKit::WebRemoteFrameClient::renderTreeAsText):
(WebKit::WebRemoteFrameClient::close):
(WebKit::WebRemoteFrameClient::focus):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
(WebKit::WebPage::remotePostMessage):
(WebKit::WebPage::renderTreeAsText):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::remotePostMessage): Deleted.
(WebKit::WebProcess::renderTreeAsText): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
This change removed the remaining synchronous IPC messages going to 
`WebProcess`. As a result, the
`didReceiveSyncWebProcessMessage()` function declaration was no longer 
generated.

* Source/WebKit/WebProcess/WebProcess.messages.in:

Canonical link: https://commits.webkit.org/271401@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aadb70: [WebGPU] webgpu:api, operation, resource_init, textur...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aadb70808c6df2024e980f0053bc3d524fd16488
  
https://github.com/WebKit/WebKit/commit/aadb70808c6df2024e980f0053bc3d524fd16488
  Author: Mike Wyrzykowski 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/command_buffer/image_copy-expected.txt
M 
LayoutTests/http/tests/webgpu/webgpu/api/operation/resource_init/texture_zero-expected.txt
M Source/WebGPU/WebGPU/CommandEncoder.h
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/PresentationContextCoreAnimation.mm
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/Queue.h
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebGPU/WebGPU/TextureView.h
M Source/WebGPU/WebGPU/TextureView.mm

  Log Message:
  ---
  [WebGPU] webgpu:api,operation,resource_init,texture_zero:* does not pass
https://bugs.webkit.org/show_bug.cgi?id=265430


Reviewed by Tadeu Zagallo.

Textures are not cleared by default and we don't want to incur
the cost of clearing them on creation, so track if they are loaded
or copied prior to being cleared and clear if needed.

Also resolve ambiguitiy that 'discard' on a render target should
clear the render target, which does not seem obvious, but per
https://github.com/gpuweb/gpuweb/issues/4398 is intentional.

* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(-[TextureAndResolve initWithTexture:resolveTexture:]):
(WebGPU::createSimplePso):
(WebGPU::CommandEncoder::runClearEncoder):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::clearTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):
(WebGPU::CommandEncoder::copyTextureToTexture):
* Source/WebGPU/WebGPU/PresentationContextCoreAnimation.mm:
(WebGPU::PresentationContextCoreAnimation::Configuration::generateCurrentFrameState):
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::clearTexture):
(WebGPU::Queue::writeTexture):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::RenderPassEncoder):
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::endPass):
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::setScissorRect):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::createView):
(WebGPU::Texture::previouslyCleared const):
(WebGPU::Texture::setPreviouslyCleared):
* Source/WebGPU/WebGPU/TextureView.h:
(WebGPU::TextureView::create):
(WebGPU::TextureView::createInvalid):
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::TextureView):
(WebGPU::m_parentTexture):
(WebGPU::TextureView::previouslyCleared const):
(WebGPU::TextureView::setPreviouslyCleared):
(WebGPU::TextureView::width const):
(WebGPU::TextureView::height const):
(WebGPU::m_device): Deleted.

Canonical link: https://commits.webkit.org/271400@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 26cb4d: [WASM-Function-References] Add br_on_null/on_non_n...

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26cb4d1f6cc3c3d343f81c21c427b92d753cdefb
  
https://github.com/WebKit/WebKit/commit/26cb4d1f6cc3c3d343f81c21c427b92d753cdefb
  Author: Asumu Takikawa 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A JSTests/wasm/function-references-spec-tests/br_on_non_null.wast.js
A JSTests/wasm/function-references-spec-tests/br_on_null.wast.js
A JSTests/wasm/function-references/br_on_null.js
M JSTests/wasm/wasm.json
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
M Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp
M Source/JavaScriptCore/wasm/WasmFunctionParser.h
M Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp
M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp
M Source/JavaScriptCore/wasm/wasm.json

  Log Message:
  ---
  [WASM-Function-References] Add br_on_null/on_non_null instructions
https://bugs.webkit.org/show_bug.cgi?id=251038

Reviewed by Justin Michaud.

Add br_on_null/non-null instructions from the typed funcref proposal.

The underlying operation added to generators is `addBranchNull`. While it's
tempting to try to call `addRefIsNull` and `addBranch` to implement this, it
doesn't work well due to the requirements of data gets left on the stack or
thrown via the branch.

Also fixes an existing typo in `checkBranchTarget`.

* JSTests/wasm/function-references-spec-tests/br_on_non_null.wast.js: Added.
* JSTests/wasm/function-references-spec-tests/br_on_null.wast.js: Added.
* JSTests/wasm/function-references/br_on_null.js: Added.
(module):
(async br_on_null):
(async br_on_non_null):
* JSTests/wasm/wasm.json:
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addBranchNull):
(JSC::Wasm::B3IRGenerator::addExternConvertAny): Deleted.
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addBranchNull):
(JSC::Wasm::BBQJIT::addSwitch):
(JSC::Wasm::BBQJIT::addExternConvertAny): Deleted.
* Source/JavaScriptCore/wasm/WasmConstExprGenerator.cpp:
(JSC::Wasm::ConstExprGenerator::addExternConvertAny): Deleted.
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::checkBranchTarget):
(JSC::Wasm::FunctionParser::parseExpression):
(JSC::Wasm::FunctionParser::parseUnreachableExpression):
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::addBranch):
(JSC::Wasm::IPIntGenerator::addExternConvertAny): Deleted.
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addBranch):
(JSC::Wasm::LLIntGenerator::addBranchNull):
(JSC::Wasm::LLIntGenerator::addExternConvertAny): Deleted.
* Source/JavaScriptCore/wasm/wasm.json:

Canonical link: https://commits.webkit.org/271399@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00352d: Cherry-pick b0a755e34426. https://bugs.webkit.org/...

[Russell Epstein]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: 00352dd86bfa102b6e4b792120e3ef3498a27d1e
  
https://github.com/WebKit/WebKit/commit/00352dd86bfa102b6e4b792120e3ef3498a27d1e
  Author: Russell Epstein 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/Structure.cpp

  Log Message:
  ---
  Cherry-pick b0a755e34426. https://bugs.webkit.org/show_bug.cgi?id=265067

Race condition between JSObject::getDirectConcurrently users and 
Structure::flattenDictionaryStructure
https://bugs.webkit.org/show_bug.cgi?id=265067
rdar://118548733

Reviewed by Justin Michaud and Mark Lam.

Like Array shift/unshift, flattenDictionaryStructure is the other code 
which can shrink butterfly for named properties (no other code does it).
Compiler threads rely on the fact that normally named property storage 
never shrunk. And we should catch this exceptional case by taking a cellLock
in the compiler thread. But flattenDictionaryStructure is not taking 
cellLock correctly.

This patch computes afterOutOfLineCapacity first to detect that whether 
this flattening will shrink the butterfly.
And if it is, then we take a cellLock. We do not need to take it if we do 
not shrink the butterfly.

* Source/JavaScriptCore/runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):

Canonical link: https://commits.webkit.org/267815.577@safari-7617-branch

Canonical link: 
https://commits.webkit.org/265870.632@safari-7616.2.9.10-branch


  Commit: 64c92ce9b94f1e6f8a132b41ea4dff3aa5c31ad1
  
https://github.com/WebKit/WebKit/commit/64c92ce9b94f1e6f8a132b41ea4dff3aa5c31ad1
  Author: Russell Epstein 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/b3/B3LowerToAir.cpp
M Source/JavaScriptCore/b3/air/AirValidate.cpp

  Log Message:
  ---
  Cherry-pick 49ba637c4abb. 

Extr can overflow when imm=64, allowing a random register to be read
rdar://118515062

Reviewed by Yusuke Suzuki.

Extr can overflow when imm=64, allowing a random register to be read.

* Source/JavaScriptCore/b3/B3LowerToAir.cpp:
* Source/JavaScriptCore/b3/air/AirValidate.cpp:

Canonical link: https://commits.webkit.org/267815.574@safari-7617-branch

Canonical link: 
https://commits.webkit.org/265870.630@safari-7616.2.9.10-branch


Compare: https://github.com/WebKit/WebKit/compare/44aeb48d175d...64c92ce9b94f
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 95e0aa: [scroll-animations] `ViewTimeline` should be a sub...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95e0aa587869fa4b2b26a192f645769761e1afa1
  
https://github.com/WebKit/WebKit/commit/95e0aa587869fa4b2b26a192f645769761e1afa1
  Author: Antoine Quint 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/animation/ViewTimeline.h
M Source/WebCore/animation/ViewTimeline.idl

  Log Message:
  ---
  [scroll-animations] `ViewTimeline` should be a subclass of `ScrollTimeline`
https://bugs.webkit.org/show_bug.cgi?id=265668

Reviewed by Dean Jackson.

When we added `ViewTimeline` in bug 264411 we overlooked how in the spec it was 
specified as
a `ScrollTimeline` subclass. We now fix this and remove the ScrollAxis member 
in `ViewTimeline`
since it exists already on `ScrollTimeline`.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt:
* Source/WebCore/animation/ScrollTimeline.h:
(WebCore::ScrollTimeline::ScrollTimeline):
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::ViewTimeline):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/animation/ViewTimeline.idl:

Canonical link: https://commits.webkit.org/271398@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ec49d: [scroll-animations] WPT test scroll-animations/css...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ec49d8dfd302f174cf23b2b28f2099757c16f80
  
https://github.com/WebKit/WebKit/commit/3ec49d8dfd302f174cf23b2b28f2099757c16f80
  Author: Antoine Quint 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-shorthand-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-shorthand.html

  Log Message:
  ---
  [scroll-animations] WPT test 
scroll-animations/css/view-timeline-shorthand.html has incorrect contraction 
tests
https://bugs.webkit.org/show_bug.cgi?id=265673

Reviewed by Dean Jackson.

The last three tests of this WPT test are wrong in the same way that the 
equivalent `scroll-timeline` shorthand tests
were and which got fixed in 271190@main after discussion at 
https://github.com/web-platform-tests/wpt/issues/43336.
Indeed, while parsing, the longhands should be trimmed to match the length of 
`view-timeline-name`.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-shorthand-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-shorthand.html:

Canonical link: https://commits.webkit.org/271397@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 647c89: [run-webkit-tests] Include test configuration in f...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 647c89210b17d2f0e009bf51737077879c19c769
  
https://github.com/WebKit/WebKit/commit/647c89210b17d2f0e009bf51737077879c19c769
  Author: Sam Sneddon 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
M Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py

  Log Message:
  ---
  [run-webkit-tests] Include test configuration in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=265491

Reviewed by Jonathan Bedard.

It's often useful to be able to determine what we were actually running
when looking at results, especially for scripts such as
update-test-expectations-from-bugzilla (which currently guessing the
port based on the bot name).

To acheieve this, add a small amount of metadata to full_results.json
about the run.

Pedantically, this doesn't suffice as we might run tests in a variety of
different configurations (e.g., we might run some on an iPhone and some
on an iPad), but this is relatively rare, and we don't believe this will
often cause problems.

* Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(SummarizedResultsTest.test_summarized_results_world_leaks_disabled):
(SummarizedResultsTest):
(SummarizedResultsTest.test_summarized_run_metadata):

Canonical link: https://commits.webkit.org/271396@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eaa3fc: [Wasm-GC] Fix subtyping for nullref

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eaa3fcf1d383d5c6bc58c2502b5d6fcd7e28b62f
  
https://github.com/WebKit/WebKit/commit/eaa3fcf1d383d5c6bc58c2502b5d6fcd7e28b62f
  Author: Asumu Takikawa 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A JSTests/wasm/gc/subtyping.js
M Source/JavaScriptCore/wasm/WasmFormat.h

  Log Message:
  ---
  [Wasm-GC] Fix subtyping for nullref
https://bugs.webkit.org/show_bug.cgi?id=265628

Reviewed by Justin Michaud.

* JSTests/wasm/gc/subtyping.js: Added.
(module):
(testNone):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::isInternalref):

Canonical link: https://commits.webkit.org/271395@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e95888: Add com.apple.developer.kernel.extended-virtual-ad...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9588823e875dce419b8cc8653b77dd7746d2a91
  
https://github.com/WebKit/WebKit/commit/e9588823e875dce419b8cc8653b77dd7746d2a91
  Author: Mark Lam 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/Scripts/process-entitlements.sh

  Log Message:
  ---
  Add com.apple.developer.kernel.extended-virtual-addressing entitlement 
explicitly.
https://bugs.webkit.org/show_bug.cgi?id=265669
rdar://118356747

Reviewed by Per Arne Vollan.

This entitlement used to be implicit with the JIT entitlement.  This will no 
longer be
the case, and we need to make it explicit.

* Source/WebKit/Scripts/process-entitlements.sh:

Canonical link: https://commits.webkit.org/271394@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 52f1f9: Fix Lexer build with -Werror=type-limits

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52f1f953c77c19fc87019d0a8d50d08d6cbaa02e
  
https://github.com/WebKit/WebKit/commit/52f1f953c77c19fc87019d0a8d50d08d6cbaa02e
  Author: Olivier Blin 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/parser/Lexer.cpp

  Log Message:
  ---
  Fix Lexer build with -Werror=type-limits
https://bugs.webkit.org/show_bug.cgi?id=265676

Reviewed by Darin Adler.

After 271373@main which uses char32_t instead of UChar32, build of
Lexer.cpp was broken with -Werror=type-limits

codePoint is now always positive, remove the assert.

* Source/JavaScriptCore/parser/Lexer.cpp:
(JSC::Lexer::recordUnicodeCodePoint):

Canonical link: https://commits.webkit.org/271393@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e4ff5: [WPE] Fix build without journald after 271330@main

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e4ff5c33c288c3b15384a57cf228962f181aa95
  
https://github.com/WebKit/WebKit/commit/0e4ff5c33c288c3b15384a57cf228962f181aa95
  Author: Olivier Blin 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WTF/wtf/PlatformGTK.cmake
M Source/WTF/wtf/PlatformWPE.cmake
M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt

  Log Message:
  ---
  [WPE] Fix build without journald after 271330@main
https://bugs.webkit.org/show_bug.cgi?id=265663

Reviewed by Michael Catanzaro.

* Source/WTF/wtf/PlatformGTK.cmake:
* Source/WTF/wtf/PlatformWPE.cmake:

Drive-by fix to use ENABLE_JOURNALD_LOG instead of Journald_FOUND.

* Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt:

The Journald::Journald target should not be used if journald support
is not enabled.

Canonical link: https://commits.webkit.org/271392@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0abd65: Disable AX iOS code for Catalyst

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0abd65ce942464b62c5558494ac35b15322d845f
  
https://github.com/WebKit/WebKit/commit/0abd65ce942464b62c5558494ac35b15322d845f
  Author: Per Arne Vollan 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Disable AX iOS code for Catalyst
https://bugs.webkit.org/show_bug.cgi?id=265675
rdar://118837513

Reviewed by Chris Dumez.

The change in  was not intended for 
Catalyst.

* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerWithAccessibility):

Canonical link: https://commits.webkit.org/271391@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ec18a: Fix WebLocalFrameLoaderClient debug build with gcc

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ec18aaa5cc946575294254b8880fab689898f6e
  
https://github.com/WebKit/WebKit/commit/6ec18aaa5cc946575294254b8880fab689898f6e
  Author: Olivier Blin 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  ---
  Fix WebLocalFrameLoaderClient debug build with gcc
https://bugs.webkit.org/show_bug.cgi?id=265320

Reviewed by Darin Adler.

* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
Fix the following -Werror=format build error with gcc:

error: format '%hhu' expects argument of type 'int', but argument 10 has type 
'WebCore::FrameState'
Canonical link: https://commits.webkit.org/271390@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6ce372: [WPE] WPE Platform: fix a typo in headless and DRM...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ce37246c1d1381cf951a29289cfa2b048ea386b
  
https://github.com/WebKit/WebKit/commit/6ce37246c1d1381cf951a29289cfa2b048ea386b
  Author: Carlos Garcia Campos 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.h
M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.h
M Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.h
M Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.h

  Log Message:
  ---
  [WPE] WPE Platform: fix a typo in headless and DRM headers
https://bugs.webkit.org/show_bug.cgi?id=265670

Reviewed by Michael Catanzaro.

Fix copy paste error.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.h:
* Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.h:
* Source/WebKit/WPEPlatform/wpe/headless/WPEDisplayHeadless.h:
* Source/WebKit/WPEPlatform/wpe/headless/WPEViewHeadless.h:

Canonical link: https://commits.webkit.org/271389@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb2d6f: Remove a couple of clippedOverflowRect() overrides

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb2d6fa3441d2365a572a523c7299d2053688691
  
https://github.com/WebKit/WebKit/commit/cb2d6fa3441d2365a572a523c7299d2053688691
  Author: Simon Fraser 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/rendering/RenderLineBreak.h
M Source/WebCore/rendering/svg/RenderSVGGradientStop.h
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp

  Log Message:
  ---
  Remove a couple of clippedOverflowRect() overrides
https://bugs.webkit.org/show_bug.cgi?id=265627
rdar://119016913

Reviewed by Alan Baradlay.

Don't override `clippedOverflowRect()` when we can instead override 
`localRectForRepaint()`, which
is true for RenderLineBreak and RenderSVGGradientStop.

Fix SVGRenderSupport::clippedOverflowRectForRepaint() to use 
`isInsideEntirelyHiddenLayer()`
which we use elsewhere.

* Source/WebCore/rendering/RenderLineBreak.h:
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):

Canonical link: https://commits.webkit.org/271388@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4c0d4e: Address review feedback in https://github.com/WebK...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c0d4ed56f2ebdecef74dc96c0d7126c242ff36b
  
https://github.com/WebKit/WebKit/commit/4c0d4ed56f2ebdecef74dc96c0d7126c242ff36b
  Author: Per Arne Vollan 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm

  Log Message:
  ---
  Address review feedback in https://github.com/WebKit/WebKit/pull/21133
https://bugs.webkit.org/show_bug.cgi?id=265664
rdar://119032805

Unreviewed, address previous review feedback.

Add constexpr.

* Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
(WebKit::LaunchServicesDatabaseManager::waitForDatabaseUpdate):

Canonical link: https://commits.webkit.org/271387@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6052e4: [IFC][Ruby] Don't let display:ruby-text through to...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6052e4dcacd49e052b1681410e1f4d6d48d312e1
  
https://github.com/WebKit/WebKit/commit/6052e4dcacd49e052b1681410e1f4d6d48d312e1
  Author: Antti Koivisto 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp

  Log Message:
  ---
  [IFC][Ruby] Don't let display:ruby-text through to IFC if the parent box is 
not display:ruby
https://bugs.webkit.org/show_bug.cgi?id=265657
rdar://119028775

Reviewed by Alan Baradlay.

fast/ruby/ruby-text-before-child-split.html
fast/ruby/ruby-overhang-crash.html

* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::adjustStyleIfNeeded):

Continuations may cause annotations to get through into surpring places but IFC 
doesn't deal with it.

Canonical link: https://commits.webkit.org/271386@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b2ed5a: REGRESSION (269598@main?): [ macOS Debug ] ASSERTI...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2ed5aecee27ad7088dc72a0b871f56f61ac456c
  
https://github.com/WebKit/WebKit/commit/b2ed5aecee27ad7088dc72a0b871f56f61ac456c
  Author: Sihui Liu 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  REGRESSION (269598@main?): [ macOS Debug ] ASSERTION FAILED: 
m_networkProcessToKeepAliveUntilDataStoreIsCreated == networkProcess.ptr() in 
TestWebKitAPI.WKWebsiteDataStoreConfiguration.TotalQuotaRatio result of 
constant crash
https://bugs.webkit.org/show_bug.cgi?id=265489
rdar://118904784

Reviewed by Per Arne Vollan and Chris Dumez.

The assertion fails because m_networkProcessToKeepAliveUntilDataStoreIsCreated 
still points to old default network
process after it exits. The reason why WebProcessProxy has 
m_networkProcessToKeepAliveUntilDataStoreIsCreated is that
WebProcessProxy needs to launch network process and hold it alive for sending 
LaunchServicesDatabase to web process,
when there is no WebsiteDataStore (i.e. the web process is prewarmed). This 
patch removes
m_networkProcessToKeepAliveUntilDataStoreIsCreated from WebProcessProxy and 
delays the LaunchServicesDatabase sending
to when WebProcessProxy is assigned a WebsiteDataStore. In that case, 
WebProcessProxy could use the network process of
the WebsiteDataStore.

This patch also has a fix to clear m_connection of XPCEndpointClient when 
remote process is terminated, so web process
can accept new connection from the relaunched network process.

* Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm:
(WebKit::XPCEndpointClient::setEndpoint):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::didFinishLaunching):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/271385@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 74dab6: REGRESSION (270354@main?): [ macOS Release x86_64 ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74dab6364fd5764cab0b524f0a4377967de2ddee
  
https://github.com/WebKit/WebKit/commit/74dab6364fd5764cab0b524f0a4377967de2ddee
  Author: Jean-Yves Avenard 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

  Log Message:
  ---
  REGRESSION (270354@main?): [ macOS Release x86_64 wk2 ] 
media/media-source/mock-managedmse-bufferedchange.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=265549
rdar://118951399

Reviewed by Youenn Fablet.

In 270354@main, an incorrect assumption was made that the duplicated code found 
in the
SourceBufferPrivateAVFObjC destructor and 
SourceBufferPrivateAVFObjC::removedFromMediaSource
could be removed.
However, destructing the AVSampleBufferDisplayLayer in the SourceBuffer 
destructor is causing
a deadlock in the AVSampleBufferDisplayLayer as its waiting for all the 
CoreMedia threads to
shutdown; most of those threads waiting on a sync dispatch to the main thread.
As a result, the GPU process was getting killed after a few seconds. This 
explained the like
of backtrace or crashlog despite the process being shown as "crashed".

Fly-by:
- the SourceBufferPrivate::m_mediaSource doesn't need to be cleared from the
MediaSourcePrivate destructor. It is a weak pointer and it will be set to zero 
automatically.
- Correct the SourceBufferPrivate::removedFromMediaSource comment. The 
SourceBufferClient owns
the last reference to the SourceBufferPrivate, as such we don't need to take a 
strong ref. Which
would be problematic anyway should it be called from the destructor.

This code is in need of a refactoring to avoid the back and forth re-entrancy 
between all the related objects.

Covered by existing tests.

* LayoutTests/platform/wk2/TestExpectations:
* Source/WebCore/platform/graphics/MediaSourcePrivate.cpp:
(WebCore::MediaSourcePrivate::~MediaSourcePrivate): Deleted.
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::removedFromMediaSource):
* Source/WebCore/platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::clearMediaSource): Deleted.
* 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource):

Canonical link: https://commits.webkit.org/271384@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f82091: Add a MiniBrowser menu item to dump a WKWebView im...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8209111eace23050256e1f89d66cc8fb5dc962b
  
https://github.com/WebKit/WebKit/commit/f8209111eace23050256e1f89d66cc8fb5dc962b
  Author: Tim Horton 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Tools/MiniBrowser/mac/BrowserWindowController.h
M Tools/MiniBrowser/mac/BrowserWindowController.m
M Tools/MiniBrowser/mac/MainMenu.xib
M Tools/MiniBrowser/mac/WK1BrowserWindowController.m
M Tools/MiniBrowser/mac/WK2BrowserWindowController.m

  Log Message:
  ---
  Add a MiniBrowser menu item to dump a WKWebView image snapshot
https://bugs.webkit.org/show_bug.cgi?id=265629

Reviewed by Aditya Keerthi.

* Tools/MiniBrowser/mac/BrowserWindowController.h:
* Tools/MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController saveAsImage:]):
* Tools/MiniBrowser/mac/MainMenu.xib:
* Tools/MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController validateMenuItem:]):
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController saveAsPDF:]):
(-[WK2BrowserWindowController saveAsImage:]):
(-[WK2BrowserWindowController saveAsWebArchive:]):
Add a menu item for takeSnapshot like we have for createPDF and 
createWebArchive.

Canonical link: https://commits.webkit.org/271383@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e32c6f: [GTK][a11y] /WebKitGTK/TestWebKitAccessibility:/we...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e32c6f904bc634513e801cafcf7b34f2772e92c8
  
https://github.com/WebKit/WebKit/commit/e32c6f904bc634513e801cafcf7b34f2772e92c8
  Author: Vitaly Dyachkov 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp

  Log Message:
  ---
  [GTK][a11y] 
/WebKitGTK/TestWebKitAccessibility:/webkit/WebKitAccessibility/accessible/children-changed
 is failing
https://bugs.webkit.org/show_bug.cgi?id=246501

Reviewed by Carlos Garcia Campos.

Since 254418@main, setting a `role` of an element causes its
accessibility node to be removed and recreated with the new role.

* Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
(AccessibilityTest::startEventMonitor):
(testAccessibleChildrenChanged):

Canonical link: https://commits.webkit.org/271382@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c11dcc: [CMake] Fix the build with LOWERCASE_CMAKE_SYSTEM_...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c11dcca38c80c71aa45b015744432ab19cdfe409
  
https://github.com/WebKit/WebKit/commit/c11dcca38c80c71aa45b015744432ab19cdfe409
  Author: Adrian Perez de Castro 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/cmake/WebKitCommon.cmake

  Log Message:
  ---
  [CMake] Fix the build with LOWERCASE_CMAKE_SYSTEM_PROCESSOR=powerpc
https://bugs.webkit.org/show_bug.cgi?id=265633

Reviewed by Michael Catanzaro.

* Source/cmake/WebKitCommon.cmake: Also check for "powerpc" as a
  possible value for LOWERCASE_CMAKE_SYSTEM_PROCESSOR.

Canonical link: https://commits.webkit.org/271381@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91ff5d: Sync 'RTCRtpScriptTransform.idl' with WebIDL Speci...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91ff5d82ae24524495857a0097aede353ffa00f4
  
https://github.com/WebKit/WebKit/commit/91ff5d82ae24524495857a0097aede353ffa00f4
  Author: Youenn Fablet 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
A LayoutTests/http/wpt/webrtc/no-options-transform-worker.js
A LayoutTests/http/wpt/webrtc/script-transform-no-options-expected.txt
A LayoutTests/http/wpt/webrtc/script-transform-no-options.html
M 
LayoutTests/imported/w3c/web-platform-tests/interfaces/webrtc-encoded-transform.idl
A 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window.html
A 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window.js
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.h
M Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl
M Source/WebCore/dom/EventTargetFactory.in

  Log Message:
  ---
  Sync 'RTCRtpScriptTransform.idl' with WebIDL Specification
https://bugs.webkit.org/show_bug.cgi?id=264905
rdar://118728503

Reviewed by Jean-Yves Avenard.

Update IDL definition according spec.
Remove EventTarget RTCRtpScriptTransform related code.

Add a test for the case where options is not set.
Resync WPT webrtc-encoded-transform WebIDL tests.

* LayoutTests/http/wpt/webrtc/no-options-transform-worker.js: Added.
(onrtctransform):
* LayoutTests/http/wpt/webrtc/script-transform-no-options-expected.txt: Added.
* LayoutTests/http/wpt/webrtc/script-transform-no-options.html: Added.
* 
LayoutTests/imported/w3c/web-platform-tests/interfaces/webrtc-encoded-transform.idl:
* 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/webrtc-encoded-transform/idlharness.https.window.js:
 Added.
(async idlArray):
* Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.h:
* Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl:
* Source/WebCore/dom/EventTargetFactory.in:

Canonical link: https://commits.webkit.org/271380@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7e2c70: [GTK] Release unused buffers when the view is hidden

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e2c70f8fafe4a8bea17c4ba84676cf826bb6cc0
  
https://github.com/WebKit/WebKit/commit/7e2c70f8fafe4a8bea17c4ba84676cf826bb6cc0
  Author: Carlos Garcia Campos 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/AcceleratedSurface.h
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp
M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h

  Log Message:
  ---
  [GTK] Release unused buffers when the view is hidden
https://bugs.webkit.org/show_bug.cgi?id=265655

Reviewed by Alejandro G. Castro.

Set a timer to release the free buffers when the view is not visible.

* Source/WebKit/WebProcess/WebPage/AcceleratedSurface.h:
(WebKit::AcceleratedSurface::visibilityDidChange):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::pauseRendering):
(WebKit::LayerTreeHost::resumeRendering):
* Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp:
(WebKit::AcceleratedSurfaceDMABuf::AcceleratedSurfaceDMABuf):
(WebKit::AcceleratedSurfaceDMABuf::SwapChain::releaseUnusedBuffers):
(WebKit::AcceleratedSurfaceDMABuf::visibilityDidChange):
(WebKit::AcceleratedSurfaceDMABuf::releaseUnusedBuffersTimerFired):
(WebKit::AcceleratedSurfaceDMABuf::didCreateCompositingRunLoop):
(WebKit::AcceleratedSurfaceDMABuf::willDestroyCompositingRunLoop):
* Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h:

Canonical link: https://commits.webkit.org/271379@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b251e5: Resync WPT webcodec tests up to 0808db6

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b251e58b95dd400646e73fec5947292e6d47c2e9
  
https://github.com/WebKit/WebKit/commit/b251e58b95dd400646e73fec5947292e6d47c2e9
  Author: Youenn Fablet 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/META.yml
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.js
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_annexb-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_avc-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h265_annexb-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h265_hevc-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_vp8-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_vp9_p0-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_vp9_p2-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_av1-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_annexb-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h264_avc-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h265_annexb-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_h265_hevc-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp8-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp9_p0-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp9_p2-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/transfering.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/transfering.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/transfering.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/transfering.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/transfering.https.any.worker.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-content-hint.https.any-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-content-hint.https.any.html
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-content-hint.https.any.js
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-content-hint.https.any.worker-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/video-encoder-content-hint.https.any.worker.html
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/w3c-import.log
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_vp9_p2-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any_vp9_p2-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/transfering.https.any-expected.txt
A 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/transfering.https.any.worker-expected.txt

  Log Message:
  ---
  Resync WPT webcodec tests up to 0808db6
https://bugs.webkit.org/show_bug.cgi?id=265364
rdar://118823698

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/META.yml:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any.js:
(async checkEncodingError):
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.js:
(async runFullCycleTest):
(promise_test.async t):
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_av1-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_annexb-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h264_avc-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h265_annexb-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/webcodecs/full-cycle-test.https.any.worker_h265_hevc-expected.txt:
* 

[webkit-changes] [WebKit/WebKit] 279e75: [Cocoa] Remote video codecs should surface any err...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 279e75f6851c27fc51dc6ed4e36641f5d354bc40
  
https://github.com/WebKit/WebKit/commit/279e75f6851c27fc51dc6ed4e36641f5d354bc40
  Author: Youenn Fablet 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/http/wpt/webcodecs/encoder-task-failing-expected.txt
A LayoutTests/http/wpt/webcodecs/encoder-task-failing.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm
M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoEncoder.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.mm
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in
M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm
M Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h
M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in

  Log Message:
  ---
  [Cocoa] Remote video codecs should surface any error happening during 
encoding to web pages
https://bugs.webkit.org/show_bug.cgi?id=265307
rdar://118770776

Reviewed by Eric Carlson.

We were not exposing the encoder errors to JavaScript, while the spec asks us 
to do so.
We add to H264 and HEVC encoders a way to be notified of any error, and update 
the code so that,
either the success or error callback is called for every encoding task.

We update LibWebRTCCodecs to make encoding and flush IPC messages with a 
response handler.
This allows to call the WebCodecs encoding task completion handler with the 
result of the encoding task.
We use NativePromise for both as a convenience and we make sure that the order 
of messages is guaranteed.

Covered by a new test which triggers an encoding error by using a low H264 
encoding level with large video frames.
This should in theory be handled at configure step but we are not yet checking 
precisely enough this.
When we do this, we will need to change the test and it will probably be pass 
for all platforms as the checking code might be in WebKit and not below.
This test is only passing in Sonoma since below, the underlying encoder is not 
triggering an encoding error.

* LayoutTests/TestExpectations:
* LayoutTests/http/wpt/webcodecs/encoder-task-failing-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/encoder-task-failing.html: Added.
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:
(-[WK_RTCLocalVideoH264H265Encoder setErrorCallback:]):
(webrtc::createLocalEncoder):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/base/RTCVideoEncoder.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 setErrorCallback:]):
(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH264 
frameWasEncoded:flags:sampleBuffer:codecSpecificInfo:width:height:renderTimeMs:timestamp:duration:rotation:isKeyFrameRequired:]):
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH265.mm:
(-[RTCVideoEncoderH265 setErrorCallback:]):
(-[RTCVideoEncoderH265 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH265 
frameWasEncoded:flags:sampleBuffer:width:height:renderTimeMs:timestamp:rotation:]):
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
* Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::createEncoder):
(WebKit::LibWebRTCCodecsProxy::encodeFrame):
(WebKit::LibWebRTCCodecsProxy::notifyEncoderResult):
(WebKit::LibWebRTCCodecsProxy::flushEncoder):
* Source/WebKit/WebProcess/GPU/media/RemoteVideoCodecFactory.cpp:
(WebKit::RemoteVideoEncoderCallbacks::close):
(WebKit::RemoteVideoEncoder::encode):
(WebKit::RemoteVideoEncoderCallbacks::notifyEncodedChunk):

[webkit-changes] [WebKit/WebKit] a2701c: [WPE] Unreviewed, build fix for Ubuntu LTS after 2...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2701c1ad6e43d17a6f0470ca243808ac5aa
  
https://github.com/WebKit/WebKit/commit/a2701c1ad6e43d17a6f0470ca243808ac5aa
  Author: Diego Pino Garcia 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp

  Log Message:
  ---
  [WPE] Unreviewed, build fix for Ubuntu LTS after 271330@main
https://bugs.webkit.org/show_bug.cgi?id=265286

* Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt:
* Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp:

Canonical link: https://commits.webkit.org/271376@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 861888: Various tests have incorrect webkit-test-runner op...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86188827f3481487ee31f9336c85e9d7ab9b4860
  
https://github.com/WebKit/WebKit/commit/86188827f3481487ee31f9336c85e9d7ab9b4860
  Author: Kimmo Kinnunen 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M 
LayoutTests/editing/selection/character-granularity-select-text-with-click-handler.html
M 
LayoutTests/editing/selection/character-granularity-selected-range-after-dismissing-selection.html
M LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset-2.html
M LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset.html
M LayoutTests/fast/forms/ios/file-upload-panel-accept.html
M LayoutTests/fast/forms/ios/file-upload-panel-capture.html
M LayoutTests/fast/forms/ios/file-upload-panel.html
M LayoutTests/webgl/offscreen-webgl-errors-to-console.html

  Log Message:
  ---
  Various tests have incorrect webkit-test-runner option separator
https://bugs.webkit.org/show_bug.cgi?id=265579
rdar://118985702

Reviewed by Antti Koivisto.

Option "true," is parsed as false.

* 
LayoutTests/editing/selection/character-granularity-select-text-with-click-handler.html:
* 
LayoutTests/editing/selection/character-granularity-selected-range-after-dismissing-selection.html:
* LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset-2.html:
* LayoutTests/editing/selection/ios/autoscroll-with-top-content-inset.html:
* LayoutTests/fast/forms/ios/file-upload-panel-accept.html:
* LayoutTests/fast/forms/ios/file-upload-panel-capture.html:
* LayoutTests/fast/forms/ios/file-upload-panel.html:
* LayoutTests/webgl/offscreen-webgl-errors-to-console.html:

Canonical link: https://commits.webkit.org/271375@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0143c1: [GStreamer][MSE] media/media-source/media-source-w...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0143c180fd5aa389275e1e453c35f2b2e33fb559
  
https://github.com/WebKit/WebKit/commit/0143c180fd5aa389275e1e453c35f2b2e33fb559
  Author: Philippe Normand 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  ---
  [GStreamer][MSE] 
media/media-source/media-source-webm-configuration-framerate.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=264663

Reviewed by Xabier Rodriguez-Calvar.

Check the m_source GRefPtr is non-null when handling the stream-collection 
message. It might be
cleared while the player is getting disposed. The whole method cannot be called 
from a WeakPtr
player without causing deadlocks, sadly.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

Canonical link: https://commits.webkit.org/271374@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c3f904: Adopt char32_t instead of UChar32 to sidestep ambi...

[Darin Adler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3f90442cf07394271cef85c2e1d18dab8f2f800
  
https://github.com/WebKit/WebKit/commit/c3f90442cf07394271cef85c2e1d18dab8f2f800
  Author: Darin Adler 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/parser/Lexer.cpp
M Source/JavaScriptCore/parser/Lexer.h
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/StringPrototype.cpp
M Source/JavaScriptCore/yarr/YarrCanonicalize.h
M Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.cpp
M Source/JavaScriptCore/yarr/YarrCanonicalizeUCS2.js
M Source/JavaScriptCore/yarr/YarrInterpreter.cpp
M Source/JavaScriptCore/yarr/YarrInterpreter.h
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/JavaScriptCore/yarr/YarrJIT.h
M Source/JavaScriptCore/yarr/YarrParser.h
M Source/JavaScriptCore/yarr/YarrPattern.cpp
M Source/JavaScriptCore/yarr/YarrPattern.h
M Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp
M Source/JavaScriptCore/yarr/generateYarrCanonicalizeUnicode
M Source/JavaScriptCore/yarr/generateYarrUnicodePropertyTables.py
M Source/WTF/wtf/ASCIICType.h
M Source/WTF/wtf/PrintStream.cpp
M Source/WTF/wtf/PrintStream.h
M Source/WTF/wtf/URLHelpers.cpp
M Source/WTF/wtf/URLParser.cpp
M Source/WTF/wtf/URLParser.h
M Source/WTF/wtf/text/AtomString.cpp
M Source/WTF/wtf/text/CodePointIterator.h
M Source/WTF/wtf/text/StringBuilder.h
M Source/WTF/wtf/text/StringConcatenate.h
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/StringView.h
M Source/WTF/wtf/text/WTFString.cpp
M Source/WTF/wtf/text/WTFString.h
M Source/WTF/wtf/unicode/CharacterNames.h
M Source/WTF/wtf/unicode/UTF8Conversion.cpp
M Source/WTF/wtf/unicode/UTF8Conversion.h
M Source/WebCore/PAL/pal/text/EncodingTables.cpp
M Source/WebCore/PAL/pal/text/EncodingTables.h
M Source/WebCore/PAL/pal/text/TextCodec.cpp
M Source/WebCore/PAL/pal/text/TextCodec.h
M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp
M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp
M Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp
M Source/WebCore/contentextensions/URLFilterParser.cpp
M Source/WebCore/css/CSSFontFace.cpp
M Source/WebCore/css/CSSFontFace.h
M Source/WebCore/css/CSSFontFaceSet.cpp
M Source/WebCore/css/CSSMarkup.cpp
M Source/WebCore/css/CSSUnicodeRangeValue.h
M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp
M Source/WebCore/css/parser/CSSTokenizer.cpp
M Source/WebCore/css/parser/CSSTokenizer.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/ReplaceSelectionCommand.cpp
M Source/WebCore/editing/SmartReplace.cpp
M Source/WebCore/editing/SmartReplace.h
M Source/WebCore/editing/SmartReplaceCF.cpp
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/editing/TypingCommand.cpp
M Source/WebCore/editing/VisiblePosition.cpp
M Source/WebCore/editing/VisiblePosition.h
M Source/WebCore/editing/VisibleUnits.cpp
M Source/WebCore/editing/VisibleUnits.h
M Source/WebCore/html/parser/HTMLEntityParser.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h
M Source/WebCore/mathml/MathMLOperatorDictionary.cpp
M Source/WebCore/mathml/MathMLOperatorDictionary.h
M Source/WebCore/mathml/MathMLOperatorElement.h
M Source/WebCore/mathml/MathMLTokenElement.cpp
M Source/WebCore/mathml/MathMLTokenElement.h
M Source/WebCore/platform/graphics/ComplexTextController.cpp
M Source/WebCore/platform/graphics/ComplexTextController.h
M Source/WebCore/platform/graphics/ComposedCharacterClusterTextIterator.h
M Source/WebCore/platform/graphics/Font.cpp
M Source/WebCore/platform/graphics/Font.h
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/platform/graphics/FontRanges.cpp
M Source/WebCore/platform/graphics/FontRanges.h
M Source/WebCore/platform/graphics/GlyphPage.h
M Source/WebCore/platform/graphics/Latin1TextIterator.h
M Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.h
M Source/WebCore/platform/graphics/WidthIterator.cpp
M Source/WebCore/platform/graphics/WidthIterator.h
M 

[webkit-changes] [WebKit/WebKit] 920ba0: Include arch-specific headers in BiquadDSPKernel

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 920ba07bf75fc5f066853531d29bcd7ecac8062d
  
https://github.com/WebKit/WebKit/commit/920ba07bf75fc5f066853531d29bcd7ecac8062d
  Author: Olivier Blin 
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp

  Log Message:
  ---
  Include arch-specific headers in BiquadDSPKernel
https://bugs.webkit.org/show_bug.cgi?id=265372

Reviewed by Darin Adler.

Commit 270669@main for bug 264488 added usage of arch-specific
intrinsics, by backporting a Chromium patch, but it did not include
the matching headers. Build could fail on some ARM platforms.

* Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::hasConstantValue):

Include arch-specific headers, and use WebKit-style macros.

Canonical link: https://commits.webkit.org/271372@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 02b2f8: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02b2f8b7a253140d82f59e38a68257431139d2e7
  
https://github.com/WebKit/WebKit/commit/02b2f8b7a253140d82f59e38a68257431139d2e7
  Author: Fujii Hironori 
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations
M 
LayoutTests/platform/wincairo/css1/text_properties/letter_spacing-expected.txt

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:
* 
LayoutTests/platform/wincairo/css1/text_properties/letter_spacing-expected.txt:

Canonical link: https://commits.webkit.org/271371@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes