[webkit-changes] [WebKit/WebKit] c6fb01: RenderLayer::recursiveUpdateLayerPositions() no lo...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6fb0168de49b784a40b3f4d9a843dd408ad0869
  
https://github.com/WebKit/WebKit/commit/c6fb0168de49b784a40b3f4d9a843dd408ad0869
  Author: Simon Fraser 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  ---
  RenderLayer::recursiveUpdateLayerPositions() no longer needs a 
RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=265821
rdar://119153457

Reviewed by Alan Baradlay.

Now that we no longer call `outlineBoundsForRepaint()` in 
`RenderLayer::computeRepaintRects()`
we don't need to pass a RenderGeometryMap around, which means that it's more 
efficient for
`recursiveUpdateLayerPositions()` to just not create and maintain one (the 
pushing and popping
is not free).

This is a minor progression on some MotionMark subtests.

* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterStyleChange):
(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::recursiveUpdateLayerPositions):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterOverflowScroll):
(WebCore::RenderLayer::updateLayerPositionsAfterDocumentScroll):
(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
* Source/WebCore/rendering/RenderLayer.h:
(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):

Canonical link: https://commits.webkit.org/271541@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73cbb9: [WebGPU] Device::createRenderPipeline will crash (...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73cbb938bbc59d02975fb9ac87395d096cc87527
  
https://github.com/WebKit/WebKit/commit/73cbb938bbc59d02975fb9ac87395d096cc87527
  Author: Mike Wyrzykowski 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  ---
  [WebGPU] Device::createRenderPipeline will crash (MTLReportFailure) if 
fragmentDescriptor.targetCount > 8
https://bugs.webkit.org/show_bug.cgi?id=265851


Reviewed by Dan Glastonbury.

Further validation will be added but this prevents a crash
while running the CTS when more than 8 color targets are used.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::validateRenderPipeline):

Canonical link: https://commits.webkit.org/271540@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53d6c3: [WebGPU] Crash in Buffer::getMappedRange if size is 0

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53d6c3698548446f66f32ace8fdf610bd324ec78
  
https://github.com/WebKit/WebKit/commit/53d6c3698548446f66f32ace8fdf610bd324ec78
  Author: Mike Wyrzykowski 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebGPU/WebGPU/Buffer.mm

  Log Message:
  ---
  [WebGPU] Crash in Buffer::getMappedRange if size is 0
https://bugs.webkit.org/show_bug.cgi?id=265850


Reviewed by Dan Glastonbury.

Buffer::getMappedRange should return a valid pointer
even if validation fails, so ensure that size is >= 1
otherwise the pointer will not be valid.

* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Device::createBuffer):
Remove redundant validation call.
(WebGPU::Buffer::getMappedRange):

Canonical link: https://commits.webkit.org/271539@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 454a4a: [Cocoa] Fullscreen on dailymotion.com: Scrubbing o...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 454a4a2f6f9f9f74f635f396c62ebc9dc1620b45
  
https://github.com/WebKit/WebKit/commit/454a4a2f6f9f9f74f635f396c62ebc9dc1620b45
  Author: Jer Noble 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  ---
  [Cocoa] Fullscreen on dailymotion.com: Scrubbing on seekbar switches apps
https://bugs.webkit.org/show_bug.cgi?id=265816
rdar://118026820

Reviewed by Tim Horton.

Ensure the bottom safeAreaInset is avoided by setting the WKWebView's 
_obscuredInsetEdgesAffectedBySafeArea
to UIRectEdgeAll. (The default is every edge except UIRectEdgeBottom.)

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(WebKit::WKWebViewState::applyTo):
(WebKit::WKWebViewState::store):

Canonical link: https://commits.webkit.org/271538@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4fbba7: [WebGPU] CTS test never completes - https://gpuweb...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fbba703681a09a7d1965bf412436b18dbb8ea9f
  
https://github.com/WebKit/WebKit/commit/4fbba703681a09a7d1965bf412436b18dbb8ea9f
  Author: Mike Wyrzykowski 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp

  Log Message:
  ---
  [WebGPU] CTS test never completes - 
https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,buffer,mapping:mapAsync,state,mappingPending:*
https://bugs.webkit.org/show_bug.cgi?id=265808


Reviewed by Dan Glastonbury.

GPUBuffer.mapAsync should always either reject or resolve
its Promise, otherwise an async await call will never return.

* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::mapAsync):

Canonical link: https://commits.webkit.org/271537@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bed0c2: [Cocoa] Fullscreen on vice.com: CC font size is ex...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bed0c2a8cb8ae071886d43295d004058a17188a0
  
https://github.com/WebKit/WebKit/commit/bed0c2a8cb8ae071886d43295d004058a17188a0
  Author: Jer Noble 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css

  Log Message:
  ---
  [Cocoa] Fullscreen on vice.com: CC font size is extremely large in portrait 
view
https://bugs.webkit.org/show_bug.cgi?id=265817
rdar://118030141

Reviewed by Simon Fraser.

When a landscape video is presented in portrait mode (with large letterboxes), 
this causes the font size of the
associated text tracks to be absurdly large. Filed a spec issue on WebVTT 
(https://github.com/w3c/webvtt/issues/522)
to change the default font size be `5vmin` rather than `5vh`, but proceeding 
with changing WebKit's default
font size to be `5cqh` in the meantime.

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
(::-webkit-media-text-track-region):

Canonical link: https://commits.webkit.org/271536@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 634bc0: [iPad] Fullscreening a Youtube video while in Ligh...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 634bc0b60bf0013b8d061f8e1dd3faeeb93653e4
  
https://github.com/WebKit/WebKit/commit/634bc0b60bf0013b8d061f8e1dd3faeeb93653e4
  Author: Jer Noble 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/fullscreen/full-screen-document-background-color-expected.txt
M LayoutTests/fullscreen/full-screen-document-background-color.html
A LayoutTests/fullscreen/resources/backdrop-green.html
A LayoutTests/fullscreen/resources/backdrop-red-on-green.html
M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  ---
  [iPad] Fullscreening a Youtube video while in Light Mode causes a white bar 
across the top and bottom of the screen
https://bugs.webkit.org/show_bug.cgi?id=264985
rdar://118530255

Reviewed by Tim Nguyen.

Tests updated: fullscreen/full-screen-document-background-color.html

Take the :fullscreen::backdrop element into account when calculating the 
documentBackgroundColor.
This will be black by default, so even for websites that have a clear 
background color on their
fullscreen element, the documentBackgroundColor should usually calculate to 
black. (Unless they
override the backdrop color, in which case this would the site's preferred 
behavior).

* LayoutTests/fullscreen/full-screen-document-background-color-expected.txt:
* LayoutTests/fullscreen/full-screen-document-background-color.html:
* LayoutTests/fullscreen/resources/backdrop-green-on-red.html: Added.
* LayoutTests/fullscreen/resources/backdrop-green.html: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::documentBackgroundColor const):

Canonical link: https://commits.webkit.org/271535@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 47c33f: Update rapidfuzz to 3.4.0

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47c33f8d6a4786d1fa135242ec54a6254d258fae
  
https://github.com/WebKit/WebKit/commit/47c33f8d6a4786d1fa135242ec54a6254d258fae
  Author: Sam Sneddon 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py

  Log Message:
  ---
  Update rapidfuzz to 3.4.0
https://bugs.webkit.org/show_bug.cgi?id=265809
rdar://problem/119145927

Reviewed by Jonathan Bedard.

We keep on finding bots which need rapidfuzz to be reinstalled because
the macOS universal2 wheel was broken
(c.f. https://github.com/WebKit/WebKit/pull/19835). Let's mitigate this
entire problem by just forcing rapidfuzz to be re-installed everywhere
by upgrading it.

I also found that 268494@main (ca3f26ebbb57) added pyparsing as an
implicit_dep, which should actually be on packaging, as that's where the
requirement actually is.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py:

Canonical link: https://commits.webkit.org/271534@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81e000: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81e000640e0bd17d927fb50527ca4c75a95fa063
  
https://github.com/WebKit/WebKit/commit/81e000640e0bd17d927fb50527ca4c75a95fa063
  Author: Fujii Hironori 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/271533@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a0077: Add menu item and keyCommand support to Web Extens...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a0077acd04eba49f32538cd85b7682d95d0253b
  
https://github.com/WebKit/WebKit/commit/2a0077acd04eba49f32538cd85b7682d95d0253b
  Author: Timothy Hatcher 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommandPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm

  Log Message:
  ---
  Add menu item and keyCommand support to Web Extension commands.
https://webkit.org/b/265772
rdar://problem/119111895

Reviewed by Brian Weinstein.

Adds a menuItem and keyCommand property to _WKWebExtensionCommand for macOS and 
iOS.
Also adds performCommandForEvent: and commandForEvent: to 
_WKWebExtensionContext for macOS.
Adds a private _shortcut to _WKWebExtensionCommand for use by Safari.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommand.mm:
(-[_WKWebExtensionCommand menuItem]): Added.
(-[_WKWebExtensionCommand keyCommand]): Added.
(-[_WKWebExtensionCommand _shortcut]): Added.
(-[_WKWebExtensionCommand _matchesEvent:]): Added.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionCommandPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:
(-[_WKWebExtensionContext performCommandForEvent:]): Added.
(-[_WKWebExtensionContext commandForEvent:]): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm:
(+[_WKWebExtensionKeyCommand 
commandWithTitle:image:input:modifierFlags:handler:]): Added.
(-[_WKWebExtensionKeyCommand copyWithZone:]):
(-[_WKWebExtensionKeyCommand _resolvedTargetFromFirstTarget:]):
(-[_WKWebExtensionKeyCommand _performWebExtensionKeyCommand:]):
(WebKit::WebExtensionCommand::platformMenuItem const): Added.
(WebKit::WebExtensionCommand::keyCommand const): Added.
(WebKit::WebExtensionCommand::matchesEvent const): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::performCommand): Added.
(WebKit::WebExtensionContext::command): Added.
(WebKit::WebExtensionContext::performMenuItem): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm:
(-[_WKWebExtensionMenuItem initWithTitle:handler:]):
(-[_WKWebExtensionMenuItem copyWithZone:]): Added.
(-[_WKWebExtensionMenuItem _performAction:]):
* Source/WebKit/UIProcess/Extensions/WebExtensionCommand.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271532@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 46fcc2: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46fcc22d0c8b078a3e006f6e8af0e3885697341f
  
https://github.com/WebKit/WebKit/commit/46fcc22d0c8b078a3e006f6e8af0e3885697341f
  Author: Fujii Hironori 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/271531@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f97723: [IFC][Ruby] RubyFormattingContext::overhangForAnno...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f97723ea087241f30f5e81219dddf22fc5b8f757
  
https://github.com/WebKit/WebKit/commit/f97723ea087241f30f5e81219dddf22fc5b8f757
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  ---
  [IFC][Ruby] RubyFormattingContext::overhangForAnnotationAfter should take a 
base range
https://bugs.webkit.org/show_bug.cgi?id=265770

Reviewed by Antti Koivisto.

Use WTF::Range instead of passing in start/end individually (and some 
renames).

* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::baseContentIndex):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationBefore):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationAfter):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271530@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 12198a: RemoteLayerBackingStoreCollection doesn't support ...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12198a179de6bbb9c9e7da80441dfe77a3d71c27
  
https://github.com/WebKit/WebKit/commit/12198a179de6bbb9c9e7da80441dfe77a3d71c27
  Author: Matt Woodrow 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm
A 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h
A 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm
A 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.h
A 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStore.mm
R 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h
R 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm

  Log Message:
  ---
  RemoteLayerBackingStoreCollection doesn't support mixing remote rendering 
with in process rendering.
https://bugs.webkit.org/show_bug.cgi?id=265617


Reviewed by Tim Horton.

We currently have a polymorphic RemoteLayerBackingStoreCollection object, which
 requires an upfront decision about whether in-process or remote rendering will
be used.

We should instead have a single RemoteLayerBackingStoreCollection which supports
mixing in-process and remote RemoteLayerBackingStore objects as needed.

This merges RemoteLayerBackingStoreCollection with the 'WithRemoteRendering' 
variant,
and the resulting code checks the type of each backing stores and handles them
separately (for functions that require it).

RemoteLayerBackingStore is split to have two subclasses ('Remote' and 
'InProcess'),
and code that only applies to that situation is moved out of the base class.

We still currently only create a single type of backing store based on the 
global
flag, but mixing types should now be supported.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::isRemoteLayerWithRemoteRenderingBackingStore 
const):
(WebKit::RemoteLayerBackingStore::isRemoteLayerWithInProcessRenderingBackingStore
 const):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer): Deleted.
(WebKit::RemoteLayerBackingStore::applySwappedBuffers): Deleted.
(WebKit::RemoteLayerBackingStore::prepareToDisplay): Deleted.
(WebKit::RemoteLayerBackingStore::prepareBuffers): Deleted.
(WebKit::RemoteLayerBackingStore::setBufferVolatile): Deleted.
(WebKit::RemoteLayerBackingStore::setBufferNonVolatile): Deleted.
(WebKit::RemoteLayerBackingStore::setFrontBufferNonVolatile): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
(WebKit::RemoteLayerBackingStoreCollection::layerTreeContext const):
(WebKit::RemoteLayerBackingStoreCollection::markInProcessBackingStoreVolatile):
(WebKit::RemoteLayerBackingStoreCollection::gpuProcessConnectionWasDestroyed): 
Deleted.
(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatile): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::RemoteLayerBackingStoreCollection):
(WebKit::RemoteLayerBackingStoreCollection::prepareBackingStoresForDisplay):
(WebKit::RemoteLayerBackingStoreCollection::createRemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStoreCollection::markInProcessBackingStoreVolatile):
(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatileAfterReachabilityChange):
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatile):
(WebKit::RemoteLayerBackingStoreCollection::tryMarkAllBackingStoreVolatile):
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileFromTimer):
(WebKit::RemoteLayerBackingStoreCollection::gpuProcessConnectionWasDestroyed):
(WebKit::RemoteLayerBackingStoreCollection::collectRemoteRenderingBackingStoreBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerBackingStoreCollection::collectAllRemoteRenderingBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerBackingStoreCollection::sendMarkBuffersVolatile):
(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatile): Deleted.
(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore): 
Deleted.
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.h:
 

[webkit-changes] [WebKit/WebKit] b3ccba: [UnifiedPDF] UnifiedPDFPlugin should be able to qu...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3ccba3d047d8f956609df0364fd5b7b95a71efa
  
https://github.com/WebKit/WebKit/commit/b3ccba3d047d8f956609df0364fd5b7b95a71efa
  Author: Abrar Rahman Protyasha 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] UnifiedPDFPlugin should be able to query PDFKit for annotations 
under a page point
https://bugs.webkit.org/show_bug.cgi?id=265810
rdar://119147700

Reviewed by Tim Horton.

We currently don't perform the required transformations to map a point
from the root view to the page space, and as such cannot perform
hit-testing to get the PDFAnnotation objects of interest under a page
point.

This commit introduces the required coordinate space plumbing so that
UnifiedPDFPlugin is able to reason in the PDFPage space. This allows us
to query PDFPage for annotations under a given point, which we need in
anticipation of getting cursor updates to work correctly over text and
other annotation types.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
(WebKit::PDFDocumentLayout::displayMode const):

Make displayMode publicly accessible.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.mm:
(WebKit::PDFDocumentLayout::updateLayout):
(WebKit::PDFDocumentLayout::layoutSingleColumn):
(WebKit::PDFDocumentLayout::layoutTwoUpColumn):
(WebKit::PDFDocumentLayout::documentMargin): Deleted.
(WebKit::PDFDocumentLayout::pageMargin): Deleted.

Move these to just be static constexpr properties on PDFDocumentLayout,
and adopt the change at call-sites.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::convertFromPluginToDocument const):
(WebKit::UnifiedPDFPlugin::nearestPageIndexForDocumentPoint const):
(WebKit::UnifiedPDFPlugin::convertFromDocumentToPage const):
(WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const):

Introduce functions that return the data reflected by their names, all
to be consumed by pdfElementTypesForPluginPoint in anticipation of
cursor updates.

(WebKit::UnifiedPDFPlugin::performContextMenuAction const):
(WebKit::UnifiedPDFPlugin::handleContextMenuEvent):

Drive-by fix, make `#endif` scopes clearer.

Canonical link: https://commits.webkit.org/271528@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 34288c: [Wasm-GC] Fix exception validation when using GC

[Asumu Takikawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34288ce1365e496e4fb45fdd8919917413d660f1
  
https://github.com/WebKit/WebKit/commit/34288ce1365e496e4fb45fdd8919917413d660f1
  Author: Asumu Takikawa 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
A JSTests/wasm/gc/exception.js
M Source/JavaScriptCore/wasm/WasmFormat.h
M Source/JavaScriptCore/wasm/WasmFunctionParser.h
M Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp

  Log Message:
  ---
  [Wasm-GC] Fix exception validation when using GC
https://bugs.webkit.org/show_bug.cgi?id=265678

Reviewed by Justin Michaud.

Adjusts checking of throw arguments and also LLInt catch generation to
work in the presence of GC types.

* JSTests/wasm/gc/exception.js: Added.
(module):
(testExceptionsWithGC):
* Source/JavaScriptCore/wasm/WasmFormat.h:
(JSC::Wasm::isSubtype):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser::parseExpression):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::addCatchToUnreachable):

Canonical link: https://commits.webkit.org/271527@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bbe1fd: Fix performance regression after 271209@main

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bbe1fd08c84508af0e8824856b928da3f641879e
  
https://github.com/WebKit/WebKit/commit/bbe1fd08c84508af0e8824856b928da3f641879e
  Author: Alex Christensen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp

  Log Message:
  ---
  Fix performance regression after 271209@main
https://bugs.webkit.org/show_bug.cgi?id=265826
rdar://118948980

Reviewed by Per Arne Vollan.

271209@main introduced a CompletionHandler to 
SpeculativeLoad::willSendRedirectedRequest.
Before that change, we would just destroy the NetworkLoad and be done.
After that change, we call the redirect completion handler with an empty 
ResourceRequest
before destroying the NetworkLoad, which calls updateRequest and 
didCompleteWithError.
This PR changes calling the completion handler to after the call to 
SpeculativeLoad::didComplete
which destroys the NetworkLoad.  That way, the lambda at the end of the function
NetworkLoad::willPerformHTTPRedirection just finds a null weakThis and does 
none of this
unnecessary work.  I verified that this is what is going on on the sites in the 
radar
that showed a performance regression, and I verified that this change removes 
that unnecessary
work when not following redirects.

* Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):

Canonical link: https://commits.webkit.org/271526@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db9ae6: [WebAuthn] Start migrating to using modern Authent...

[Pascoe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db9ae698e3a18e4abfd0b2c8a54753de4b7407c3
  
https://github.com/WebKit/WebKit/commit/db9ae698e3a18e4abfd0b2c8a54753de4b7407c3
  Author: J Pascoe 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformHave.h
A 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h
A 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h
A 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp
M 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  [WebAuthn] Start migrating to using modern AuthenticationServices API
https://bugs.webkit.org/show_bug.cgi?id=265703
rdar://113571336

Reviewed by Brent Fulgham.

These AuthenticationServicesCore endpoints are becoming deprecated now that
you can perform requests through AuthenticationServices. This patch is to
start migrating WebKit to using the modern AuthenticationServices API.

This patch implements modal requests. Conditional meditation will be handled
in a follow-up patch.

The legacy AuthenticationServicesCore may still be used depending on
the WebAuthenticationASEnabled flag.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(getAllLocalAuthenticatorCredentialsImpl):
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesForwardDeclarations.h:
 Added.
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.h:
 Added.
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticationServicesSoftLink.mm:
 Added.
* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(-[_WKASDelegate initWithPage:completionHandler:]):
(-[_WKASDelegate presentationAnchorForAuthorizationController:]):
(-[_WKASDelegate authorizationController:didCompleteWithAuthorization:]):
(-[_WKASDelegate authorizationController:didCompleteWithError:]):
(WebKit::toASUserVerificationPreference):
(WebKit::toAttestationConveyancePreference):
(WebKit::toASResidentKeyPreference):
(WebKit::toASAuthorizationSecurityKeyPublicKeyCredentialDescriptorTransport):
(WebKit::WebAuthenticatorCoordinatorProxy::constructASController):
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForRegisteration):
(WebKit::WebAuthenticatorCoordinatorProxy::requestsForAssertion):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
(WebKit::toExceptionCode):
(WebKit::configureRegistrationRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::contextForRequest):
(WebKit::continueAfterRequest):
* 
Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
* Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271525@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b1d31: Add optimization for monospace font's content meas...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b1d31668fbca9ba382333b287d5ed2c97f3212d
  
https://github.com/WebKit/WebKit/commit/8b1d31668fbca9ba382333b287d5ed2c97f3212d
  Author: Yusuke Suzuki 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/wtf/unicode/CharacterNames.h
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/platform/graphics/Font.h
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/FontCascadeFonts.cpp
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/platform/graphics/WidthIterator.cpp
M Source/WebCore/platform/graphics/WidthIterator.h
M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
M Tools/TestWebKitAPI/CMakeLists.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebCore/MonospaceFontTests.cpp

  Log Message:
  ---
  Add optimization for monospace font's content measuring
https://bugs.webkit.org/show_bug.cgi?id=265787
rdar://119124314

Reviewed by Alan Baradlay.

This patch adds an optimization path for monospace fonts when measuring text 
width.
One of the problem is that a lot of monospace fonts are lying and we cannot 
simply believe that
this is actually monospace. Thus, our current approach is,

1. When they are monospace fonts from the system, we know that they are 
actually monospace (by ensuring
   it in our tests). Thus, we can safely assume that their characters are 
monospace. Only exception is
   "Courier New", which has many strange characters. For now, we disable this 
optimization for "Courier New".
2. We list up more format category unicode characters in 
characterCanUseSimplifiedTextMeasuring to avoid using
   monospace fast path for these characters. They are kind of control 
characters and we do not expect that they
   will appear in texts which should be rendered in a fast path.

* Source/WTF/wtf/unicode/CharacterNames.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::fixedPitchWidth):
(WebCore::Layout::TextUtil::width):
* Source/WebCore/platform/graphics/Font.h:
(WebCore::Font::canTakeFixedPitchFastContentMeasuring const):
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::letterSpacing const): Deleted.
(WebCore::FontCascade::wordSpacing const): Deleted.
* Source/WebCore/platform/graphics/FontCascade.h:
(WebCore::FontCascade::canTakeFixedPitchFastContentMeasuring const):
(WebCore::FontCascade::letterSpacing const):
(WebCore::FontCascade::wordSpacing const):
* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::determineCanTakeFixedPitchFastContentMeasuring):
* Source/WebCore/platform/graphics/FontCascadeFonts.h:
(WebCore::FontCascadeFonts::isFixedPitch):
(WebCore::FontCascadeFonts::canTakeFixedPitchFastContentMeasuring):
* Source/WebCore/platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::characterCanUseSimplifiedTextMeasuring):
* Source/WebCore/platform/graphics/WidthIterator.h:
* Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:
(WebCore::extractBoolean):
(WebCore::Font::determinePitch):
* Tools/TestWebKitAPI/CMakeLists.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebCore/MonospaceFontTests.cpp: Added.
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/271524@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5aefb4: [IFC][Ruby] Apply ruby-align on line content

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5aefb4085f13a387a6a4c11ef2d8f7b437889070
  
https://github.com/WebKit/WebKit/commit/5aefb4085f13a387a6a4c11ef2d8f7b437889070
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  ---
  [IFC][Ruby] Apply ruby-align on line content
https://bugs.webkit.org/show_bug.cgi?id=265768

Reviewed by Antti Koivisto.

Move ruby-align adjustment to where we also apply text-align: justify (end of 
line handling).

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::applyRunExpansion):
(WebCore::Layout::Line::moveBy):
(WebCore::Layout::Line::expandBy):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::moveRunsBy): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::hasRubyContent const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::applyRubyAlignOnBaseContent):
(WebCore::Layout::RubyFormattingContext::applyRubyAlign):
(WebCore::Layout::RubyFormattingContext::layoutRubyBaseInlineAxis): This is 
dead code now. About to be removed.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271523@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 206fc1: Optimize use of WeakPtr with RenderObject types

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 206fc19611d7c0b49d5d67a7e0bed5c3051cab3d
  
https://github.com/WebKit/WebKit/commit/206fc19611d7c0b49d5d67a7e0bed5c3051cab3d
  Author: Chris Dumez 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/wtf/CheckedRef.h
M Source/WTF/wtf/WeakHashCountedSet.h
M Source/WTF/wtf/WeakPtr.h
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/editing/TextIterator.h
M Source/WebCore/html/CustomPaintImage.h
M Source/WebCore/inspector/agents/InspectorDOMAgent.h
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h
M Source/WebCore/loader/ImageLoader.h
M Source/WebCore/loader/LinkPreloadResourceClients.h
M Source/WebCore/loader/cache/CachedImage.h
M Source/WebCore/loader/cache/CachedResource.cpp
M Source/WebCore/loader/cache/CachedResource.h
M Source/WebCore/loader/cache/CachedResourceClient.h
M Source/WebCore/loader/cache/CachedResourceClientWalker.h
M Source/WebCore/page/AutoscrollController.h
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/Page.h
M Source/WebCore/platform/PODInterval.h
M Source/WebCore/rendering/AccessibilityRegionContext.h
M Source/WebCore/rendering/AncestorSubgridIterator.cpp
M Source/WebCore/rendering/AncestorSubgridIterator.h
M Source/WebCore/rendering/BaselineAlignment.h
M Source/WebCore/rendering/FloatingObjects.cpp
M Source/WebCore/rendering/FloatingObjects.h
M Source/WebCore/rendering/Grid.h
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
M Source/WebCore/rendering/LayerAncestorClippingStack.h
M Source/WebCore/rendering/LegacyInlineBox.cpp
M Source/WebCore/rendering/LegacyInlineBox.h
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M Source/WebCore/rendering/LegacyRootInlineBox.h
M Source/WebCore/rendering/PaintInfo.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderBoxModelObject.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderButton.h
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderFragmentContainer.h
M Source/WebCore/rendering/RenderFragmentedFlow.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderHighlight.h
M Source/WebCore/rendering/RenderImageResource.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerBacking.h
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h
M Source/WebCore/rendering/RenderLayoutState.h
M Source/WebCore/rendering/RenderLineBoxList.cpp
M Source/WebCore/rendering/RenderListItem.h
M Source/WebCore/rendering/RenderListMarker.h
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/rendering/RenderMultiColumnFlow.h
M Source/WebCore/rendering/RenderMultiColumnSpannerPlaceholder.h
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableSection.cpp
M Source/WebCore/rendering/RenderTableSection.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderTextFragment.h
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/RenderView.h
M Source/WebCore/rendering/line/LineLayoutState.h
M Source/WebCore/rendering/mathml/RenderMathMLFenced.h
M Source/WebCore/rendering/style/StyleGeneratedImage.h
M Source/WebCore/rendering/svg/RenderSVGRoot.h
M Source/WebCore/rendering/svg/RenderSVGViewportContainer.h
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/rendering/svg/SVGRenderSupport.h
M Source/WebCore/rendering/svg/SVGResources.cpp
M Source/WebCore/rendering/svg/SVGResources.h
M 

[webkit-changes] [WebKit/WebKit] ba9a57: `showRenderTreeForThis` should output `PseudoId`

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba9a57c567bd7e2881f93430b1296f988d4af8e9
  
https://github.com/WebKit/WebKit/commit/ba9a57c567bd7e2881f93430b1296f988d4af8e9
  Author: Tim Nguyen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
  `showRenderTreeForThis` should output `PseudoId`
https://bugs.webkit.org/show_bug.cgi?id=265769
rdar://119109505

Reviewed by Simon Fraser.

Saves countless time debugging anonymous renderers.

Sample output:
```
(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, 
(F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, 
hasLayer(S)crollableArea, (C)omposited, Content-visibility:(H)idden/(A)uto, 
(S)kipped content, (+)Dirty style, (+)Dirty layout
B---YGLSC-- -+  RenderView at (0,0) size 1420x763 renderer (0x117000ac0) layout 
box (0x0) layout->[normal child]
B-LS--- -+HTML RenderBlock at (0,0) size 1420x84 renderer (0x117001e80) 
layout box (0x0) node (0x117001700) layout->[normal child]
B-- -+  BODY RenderBody at (8,16) size 1404x52 renderer 
(0x117002110) layout box (0x0) node (0x117001940) layout->[normal child]
B-- -+DIV RenderBlock at (0,0) size 1404x52 renderer 
(0x117003a50) layout box (0x0) node (0x117003740) layout->[normal child]
BX--YGL --*   RenderBlock (::view-transition) at (0,0) size 1420x763 
renderer (0x117004c90) layout box (0x1170076c0)
-- --  line at (0.00,0.00) size (1420.00x0.00) baseline (0.00) 
enclosing top (0.00) bottom (0.00)
-- --Root inline box at (0.00,-14.00) size (0.00x18.00)
-- --Run(s):
BA--YGL --  RenderBlock (::view-transition-group) at (200,200) size 
100x100 renderer (0x117004f20) layout box (0x117007770)
-- --line at (0.00,0.00) size (100.00x0.00) baseline (0.00) 
enclosing top (0.00) bottom (0.00)
-- --  Root inline box at (0.00,-14.00) size (0.00x18.00)
-- --  Run(s):
BA--YGL --RenderBlock (::view-transition-image-pair) at (0,0) size 
50x50 renderer (0x1170051b0) layout box (0x1170078d0)
-- --  line at (0.00,0.00) size (50.00x0.00) baseline (0.00) 
enclosing top (0.00) bottom (0.00)
-- --Root inline box at (0.00,-14.00) size (0.00x18.00)
-- --Run(s):
BA--YGL --  RenderBlock (::view-transition-old) at (0,0) size 20x20 
renderer (0x117005440) layout box (0x117008910)
BA--YGL --  RenderBlock (::view-transition-new) at (0,0) size 20x20 
renderer (0x1170056d0) layout box (0x1170089c0)
BA--YGL --  RenderBlock (::view-transition-group) at (500,500) size 
100x100 renderer (0x117005960) layout box (0x117007820)
-- --line at (0.00,0.00) size (100.00x0.00) baseline (0.00) 
enclosing top (0.00) bottom (0.00)
-- --  Root inline box at (0.00,-14.00) size (0.00x18.00)
-- --  Run(s):
BA--YGL --RenderBlock (::view-transition-image-pair) at (0,0) size 
50x50 renderer (0x117005bf0) layout box (0x117009150)
-- --  line at (0.00,0.00) size (50.00x0.00) baseline (0.00) 
enclosing top (0.00) bottom (0.00)
-- --Root inline box at (0.00,-14.00) size (0.00x18.00)
-- --Run(s):
BA--YGL --  RenderBlock (::view-transition-old) at (0,0) size 20x20 
renderer (0x117005e80) layout box (0x1170098e0)
BA--YGL --  RenderBlock (::view-transition-new) at (0,0) size 20x20 
renderer (0x117006110) layout box (0x117009990)
```

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::outputRenderObject const):

Canonical link: https://commits.webkit.org/271521@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d15db7: [Gardening]: REGRESSION (271426@main): [ Monterey ...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d15db7f8e9e3a9bb60f2ca3b63fcdb182039c5e1
  
https://github.com/WebKit/WebKit/commit/d15db7f8e9e3a9bb60f2ca3b63fcdb182039c5e1
  Author: Marta Darbinyan 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (271426@main): [ Monterey / Ventura Debug  ] 
ASSERTION FAILED with void WebCore::ViewTransition::callUpdateCallback() result 
of multiple tests constant crash
https://bugs.webkit.org/show_bug.cgi?id=265834
rdar://119158623

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/271520@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ff620: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ff6202a14d4b8cd2be2e997c5dbd65eea973d4f
  
https://github.com/WebKit/WebKit/commit/9ff6202a14d4b8cd2be2e997c5dbd65eea973d4f
  Author: Fujii Hironori 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/271519@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a7afa: [IFC][Ruby] Generate annotation display boxes for ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a7afa1ea1ff078e0856c604cc572aa47d35f2eb
  
https://github.com/WebKit/WebKit/commit/1a7afa1ea1ff078e0856c604cc572aa47d35f2eb
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h

  Log Message:
  ---
  [IFC][Ruby] Generate annotation display boxes for nested ruby content
https://bugs.webkit.org/show_bug.cgi?id=265766

Reviewed by Antti Koivisto.

1. Move annotation box sizing/placing to processRubyBase()
2. Make processRubyBase() handle nested ruby content (recursive content 
processing)

* LayoutTests/TestExpectations:
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::insertRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyBase):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

Canonical link: https://commits.webkit.org/271518@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bdce1d: [scroll-anchoring] A scroll anchoring adjustment d...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdce1d6d1b68d8c04c45c4128a257a5778f6fcbd
  
https://github.com/WebKit/WebKit/commit/bdce1d6d1b68d8c04c45c4128a257a5778f6fcbd
  Author: Nikolaos Mouchtaris 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
A 
LayoutTests/fast/scrolling/ios/scroll-anchoring-momentum-scroll-expected.txt
A LayoutTests/fast/scrolling/ios/scroll-anchoring-momentum-scroll.html
M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp

  Log Message:
  ---
  [scroll-anchoring] A scroll anchoring adjustment during a momentum scroll 
stops the scroll
https://bugs.webkit.org/show_bug.cgi?id=264898
rdar://118476758

Reviewed by Simon Fraser.

On iOS, _scrollToContentScrollPosition calls [_scrollView 
_wk_stopScrollingAndZooming], which
means when we issue a programmatic scroll, it would stop a current user scroll 
(rdar://115703492).
For scroll anchoring, this isn't great as a scroll anchoring adjustment could 
kill a user scroll.
To mitigate this, ignore scroll anchoring adjustments on scrollable areas that 
have an ongoing
user scroll. Ideally, we would add the delta to the ongoing momentum scroll to 
compensate for layout
changes during user scrolls, which requires a fix for rdar://115703492.

* LayoutTests/resources/js-test.js:
(getOrCreate):
(description):
(debug):
* Source/WebCore/page/scrolling/ScrollAnchoringController.cpp:
(WebCore::ScrollAnchoringController::adjustScrollPositionForAnchoring):
* Source/WebCore/platform/mac/ScrollingEffectsController.mm:
(WebCore::ScrollingEffectsController::handleWheelEvent):

Canonical link: https://commits.webkit.org/271517@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] af3e89: [MSE] remove MonitorSourceBuffer method from Media...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af3e8935efa5f9b1755cff5ef9f4f77b111f717d
  
https://github.com/WebKit/WebKit/commit/af3e8935efa5f9b1755cff5ef9f4f77b111f717d
  Author: Jean-Yves Avenard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h

  Log Message:
  ---
  [MSE] remove MonitorSourceBuffer method from MediaSourcePrivateClient()
https://bugs.webkit.org/show_bug.cgi?id=265780
rdar://119116250

Reviewed by Youenn Fablet.

No change in observable behaviour, removing dead code.

* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/platform/graphics/MediaSourcePrivateClient.h:
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::monitorSourceBuffers): Deleted.
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h:

Canonical link: https://commits.webkit.org/271516@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea623f: Switch from fontForCaretSelection to returning the...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea623fe8675130f284b0f115793dcbbf53bf6987
  
https://github.com/WebKit/WebKit/commit/ea623fe8675130f284b0f115793dcbbf53bf6987
  Author: Megan Gardner 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Switch from fontForCaretSelection to returning the information in the 
stylingDictionary to remove more SPI.
https://bugs.webkit.org/show_bug.cgi?id=265708
rdar://119057964

Reviewed by Wenson Hsieh.

In our continued effort to move off of SPI, remove this call and instead return 
the information in a API path.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView fontForCaretSelection]): Deleted.

Canonical link: https://commits.webkit.org/271515@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] adb77f: [MSE] Remove need for SourceBufferPrivate to query...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adb77f8a601c3110242d8262cf2da0407fff971c
  
https://github.com/WebKit/WebKit/commit/adb77f8a601c3110242d8262cf2da0407fff971c
  Author: Jean-Yves Avenard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/mediasource/MediaSource.cpp
M Source/WebCore/Modules/mediasource/MediaSource.h
M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp
M Source/WebCore/platform/graphics/MediaSourcePrivate.h
M Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp
M Source/WebCore/platform/graphics/SourceBufferPrivate.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h
M 
Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp
M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp
M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h

  Log Message:
  ---
  [MSE] Remove need for SourceBufferPrivate to query MediaSource duration
https://bugs.webkit.org/show_bug.cgi?id=265778
rdar://119114938

Reviewed by Youenn Fablet.

We notify each SourceBufferPrivate that the MediaSource duration has changed
and use this cache value instead.

Covered by existing tests, no change in observable behaviour.

* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::hasFutureTime):
(WebCore::MediaSource::setDurationInternal):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/platform/graphics/MediaSourcePrivate.cpp:
(WebCore::MediaSourcePrivate::hasFutureTime const):
We don't need to pass the duration nor the buffered range as the 
MediaSourcePrivate owns this information anyway.
(WebCore::MediaSourcePrivate::duration const):
(WebCore::MediaSourcePrivate::durationChanged):
* Source/WebCore/platform/graphics/MediaSourcePrivate.h:
* Source/WebCore/platform/graphics/MediaSourcePrivateClient.h:
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::mediaSourceDuration const):
Rename duration() to mediaSourceDuration() to remove ambiguity as to which 
duration this is related to.
(WebCore::SourceBufferPrivate::append):
(WebCore::SourceBufferPrivate::duration const): Deleted.
* Source/WebCore/platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::setMediaSourceDuration):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTimeMayProgress 
const):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::durationChanged):
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::buffered const):
(WebCore::MediaPlayerPrivateGStreamerMSE::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamerMSE::isTimeBuffered const):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
* 
Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
 remove need to keep reference to MediaSourcePrivateClient,
it was an API violation for the MediaPlayerPrivate to talk to the 
MediaSourcePrivateClient, this interface is reserved for the MediaSourcePrivate 
to talk to the MediaSource.
The MediaPlayerPrivateGStreamerMSE already contains a strong reference to the 
MediaSourcePrivate so we query it directly instead.
(The MediaSourcePrivateClient would have queried its private anyway)
(WebCore::MediaPlayerPrivateGStreamerMSE::mediaSourcePrivateClient): Deleted.
* Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::currentMediaTimeMayProgress const):
* Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:
(WebCore::MockMediaSourcePrivate::durationChanged):
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.cpp:
(WebKit::RemoteMediaSourceProxy::durationChanged):
(WebKit::RemoteMediaSourceProxy::duration const): Deleted.
* Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h:

Canonical link: https://commits.webkit.org/271514@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7b924: Use Host Architecture as Fallback Architecture in ...

[Chris Gibb]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7b924825a747a3526b8734c6bc0c6e7377705e8
  
https://github.com/WebKit/WebKit/commit/c7b924825a747a3526b8734c6bc0c6e7377705e8
  Author: Chris Gibb 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/run-javascriptcore-tests

  Log Message:
  ---
  Use Host Architecture as Fallback Architecture in JavascriptCore Tests
https://bugs.webkit.org/show_bug.cgi?id=265681
rdar://119040784

Reviewed by Jonathan Bedard and Alexey Proskuryakov.

Allow for running JSC stress tests on macOS hosts that do not have Xcode 
installed.

* Tools/Scripts/run-javascriptcore-tests:

Canonical link: https://commits.webkit.org/271513@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 591cf1: [iOS] Adopt API replacements for returning an "act...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 591cf102f2e83039b430ad5a8b78e3992f17895b
  
https://github.com/WebKit/WebKit/commit/591cf102f2e83039b430ad5a8b78e3992f17895b
  Author: Wenson Hsieh 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm
M Source/WebKit/UIProcess/ios/WKBaseScrollView.h
M Source/WebKit/UIProcess/ios/WKBaseScrollView.mm

  Log Message:
  ---
  [iOS] Adopt API replacements for returning an "acting parent UIScrollView"
https://bugs.webkit.org/show_bug.cgi?id=265801
rdar://119141181

Reviewed by Aditya Keerthi and Megan Gardner.

Adopt a soon-to-be API replacement for this SPI scroll view delegate method:

```
-[UIScrollViewDelegate _actingParentScrollViewForScrollView:]
```

The replacement is just a subclassing hook on `UIScrollView` directly, which we 
can easily route
through our own `WKBaseScrollViewDelegate`, which allows us to share an 
implementation with the
legacy `-_actingParentScrollViewForScrollView:` delegate method.

* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
(-[WKScrollingNodeScrollViewDelegate _actingParentScrollViewForScrollView:]):
(-[WKScrollingNodeScrollViewDelegate actingParentScrollViewForScrollView:]):
* Source/WebKit/UIProcess/ios/WKBaseScrollView.h:
* Source/WebKit/UIProcess/ios/WKBaseScrollView.mm:
(-[WKBaseScrollView _actingParentScrollView]):

Canonical link: https://commits.webkit.org/271512@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 906329: [WPE] Fix build with GLib older than 2.74

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 906329430eb27e345bf525433f393e8a3912936a
  
https://github.com/WebKit/WebKit/commit/906329430eb27e345bf525433f393e8a3912936a
  Author: Adrian Perez de Castro 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp

  Log Message:
  ---
  [WPE] Fix build with GLib older than 2.74
https://bugs.webkit.org/show_bug.cgi?id=265286

Unreviewed build fix.

While 271376@main attempted to fix g_io_unix_fd_list_get() being
undefined with versions of GLib older than 2.74, it still resulted
in build issues in some cases. This changes the included header
to the  one listed in the documentation.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSessionLogind.cpp: Include
  gio/gunixfdlist.h as per the documentation instead of glib-unix.h.

Canonical link: https://commits.webkit.org/271511@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e4ad7f: REGRESSION(268561@main): generate-bindings-all.pl:...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4ad7f1cf28ae4d1d53426d48c4d854442500079
  
https://github.com/WebKit/WebKit/commit/e4ad7f1cf28ae4d1d53426d48c4d854442500079
  Author: Fujii Hironori 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/bindings/scripts/generate-bindings-all.pl

  Log Message:
  ---
  REGRESSION(268561@main): generate-bindings-all.pl: [CMake] doesn't account 
for certain IDL changes
https://bugs.webkit.org/show_bug.cgi?id=265749

Reviewed by Michael Catanzaro.

Implicit dependency of IDL files didn't work for CMake builds.
generate-bindings-all.pl didn't process .dep files correctly after
268561@main.

$directoryCache should be a hash of a filename to the path, not of the
reverse.

* Source/WebCore/bindings/scripts/generate-bindings-all.pl:

Canonical link: https://commits.webkit.org/271510@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b93687: Fold IOSurfaceImageBuffer into ImageBuffer

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9368743dc7a35dcd9f8d53113162bcb18d0f6f3
  
https://github.com/WebKit/WebKit/commit/b9368743dc7a35dcd9f8d53113162bcb18d0f6f3
  Author: Tim Horton 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/wtf/cocoa/TollFreeBridging.h
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/ImageBuffer.cpp
M Source/WebCore/platform/graphics/ImageBuffer.h
M Source/WebCore/platform/graphics/ImageBufferBackend.h
R Source/WebCore/platform/graphics/cg/IOSurfaceImageBuffer.h
M Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h
M Source/WebCore/platform/graphics/coreimage/FilterImageCoreImage.mm
M 
Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm

  Log Message:
  ---
  Fold IOSurfaceImageBuffer into ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=265698
rdar://119050705

Reviewed by Said Abou-Hallawa.

IOSurfaceImageBuffer complicates adding new non-backend-specific ImageBuffer
subclasses, which seems more valuable than using a whole subclass to expose
backend-specific methods.

Remove it in favor of a failable getter on ImageBuffer.

Also fix up a questionable cast (assuming all accelerated image buffers
contain ImageBufferIOSurfaceBackend if IOSurface is enabled seems ill-advised).

* Source/WTF/wtf/cocoa/TollFreeBridging.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::create):
(WebCore::ImageBuffer::surface):
* Source/WebCore/platform/graphics/ImageBuffer.h:
* Source/WebCore/platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::isImageBufferIOSurfaceBackend const):
* Source/WebCore/platform/graphics/cg/IOSurfaceImageBuffer.h: Removed.
* Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
(isType):
* Source/WebCore/platform/graphics/coreimage/FilterImageCoreImage.mm:
(WebCore::FilterImage::imageBufferFromCIImage):
* Source/WebCore/platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm:
(WebCore::SourceGraphicCoreImageApplier::apply const):

Canonical link: https://commits.webkit.org/271509@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0bc5d3: [CSS] :scope matching for multiple scoping roots

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bc5d3ab92365420fc03f522bc29a6e8c6f9025c
  
https://github.com/WebKit/WebKit/commit/0bc5d3ab92365420fc03f522bc29a6e8c6f9025c
  Author: Matthieu Dubet 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/css/scope-at-rule-expected.html
M LayoutTests/fast/css/scope-at-rule.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-container-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-evaluation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-focus-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-hover-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-implicit-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-invalidation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-layer-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-media-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-nesting-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-supports-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-visited-cssom-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/style/ElementRuleCollector.cpp
M Source/WebCore/style/ElementRuleCollector.h

  Log Message:
  ---
  [CSS] :scope matching for multiple scoping roots
https://bugs.webkit.org/show_bug.cgi?id=265288
rdar://118748899

Reviewed by Antti Koivisto.

https://drafts.csswg.org/css-cascade-6/#scope-limits

This patch generates multiple matched rules, one for each scoping root.
They will all participate in the selector matching with a distinct :scope, and 
will be selected
based on specificity (and proximity in a future patch).

* LayoutTests/TestExpectations:
* LayoutTests/fast/css/scope-at-rule-expected.html:
* LayoutTests/fast/css/scope-at-rule.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-container-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-evaluation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-focus-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-hover-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-implicit-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-invalidation-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-layer-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-media-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-nesting-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-supports-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-visited-cssom-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):

Remove the assumption that :scope always means :root outside of SelectorQuery

* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::ruleMatches):
(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::Style::ElementRuleCollector::scopeRulesMatch):
* Source/WebCore/style/ElementRuleCollector.h:

Canonical link: https://commits.webkit.org/271508@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b8666: Switch from textColorForCaretSelection to returnin...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b86660db5ace3ad3e53cc2f731201bb0cef2a8e
  
https://github.com/WebKit/WebKit/commit/7b86660db5ace3ad3e53cc2f731201bb0cef2a8e
  Author: Megan Gardner 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Switch from textColorForCaretSelection to returning the information in the 
stylingDictionary to remove more SPI.
https://bugs.webkit.org/show_bug.cgi?id=265706
rdar://119057506

Reviewed by Wenson Hsieh.

In our continued effort to move off of SPI, remove this call and instead return 
the information in a API path.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView textColorForCaretSelection]): Deleted.

Canonical link: https://commits.webkit.org/271507@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d7b45: Document UnifiedPDFPlugin coordinate spaces

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d7b457377a96e583c9371882ed98ac6bd44e6ed
  
https://github.com/WebKit/WebKit/commit/7d7b457377a96e583c9371882ed98ac6bd44e6ed
  Author: Tim Horton 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h

  Log Message:
  ---
  Document UnifiedPDFPlugin coordinate spaces
https://bugs.webkit.org/show_bug.cgi?id=265803

Reviewed by Wenson Hsieh and Richard Robinson.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:

Canonical link: https://commits.webkit.org/271506@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 42db72: Make has_json_wrapper and strip_json_wrapper private

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42db72e3286bd02966fb16ea679d33e4e49ade3e
  
https://github.com/WebKit/WebKit/commit/42db72e3286bd02966fb16ea679d33e4e49ade3e
  Author: Sam Sneddon 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/webkitpy/common/net/resultsjsonparser.py
M 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
M 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
M Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py

  Log Message:
  ---
  Make has_json_wrapper and strip_json_wrapper private
https://bugs.webkit.org/show_bug.cgi?id=265692

Reviewed by Jonathan Bedard.

This makes it very obvious nothing is actually using these, and allows
us to have the confidence both JSON and JSONP work everywhere.

* Tools/Scripts/webkitpy/common/net/resultsjsonparser.py:
(ParsedJSONResults.__init__):
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(_has_json_wrapper):
(_strip_json_wrapper):
(load_json):
(load_jsons):
(has_json_wrapper): Deleted.
(strip_json_wrapper): Deleted.
* 
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_load_jsons):
(JSONGeneratorTest.test_strip_json_wrapper): Deleted.
* Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(RebaselineTestTest.test_gather_baselines):

Canonical link: https://commits.webkit.org/271505@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f8df16: [Cocoa] MediaCapabilities spatial rendering checks...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8df1646f208282f5b000bf105beebd2e536a798
  
https://github.com/WebKit/WebKit/commit/f8df1646f208282f5b000bf105beebd2e536a798
  Author: Eric Carlson 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.cpp
M Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.h
M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h
M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h
M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
M Source/WebCore/PAL/pal/spi/cocoa/AudioToolboxSPI.h
M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
M Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.h
M Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm
M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
M 
Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp
M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp
M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h
M Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp
M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp
M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h
M 
Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.messages.in

  Log Message:
  ---
  [Cocoa] MediaCapabilities spatial rendering checks fail on capable HW with 
built-in sound output
https://bugs.webkit.org/show_bug.cgi?id=265614
rdar://114214068

Reviewed by Jer Noble.

On macOS, use SPI got get spatial audio preferences to see if spatial audio 
playback is
supported. On iOS, switch from using the shared audio presentation output 
context to
AVAudioSession, which makes it possible to see if the currently audio route has 
a port
that supports spatial playback.

* Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/AudioToolboxSoftLink.h:
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/AudioToolboxSPI.h:
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setSupportsSpatialAudioPlayback):
(WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlaybackForConfiguration):
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::supportsSpatialAudioPlayback):
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h:
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::MediaSessionManagerCocoa):
(WebCore::MediaSessionManagerCocoa::updateSessionState):
(WebCore::MediaSessionManagerCocoa::supportsSpatialAudioPlaybackForConfiguration):
* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.h:
* Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:
(MediaSessionHelper::activeAudioRouteSupportsSpatialPlaybackDidChange):
(MediaSessionHelper::updateActiveAudioRouteSupportsSpatialPlayback):
(MediaSessionHelper::setActiveAudioRouteSupportsSpatialPlayback):
(-[WebMediaSessionHelper initWithCallback:]):
(-[WebMediaSessionHelper spatialPlaybackCapabilitiesChanged:]):
* Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h:
* Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::activeAudioRouteSupportsSpatialPlaybackDidChange):
(WebCore::MediaSessionManagerCocoa::supportsSpatialAudioPlaybackForConfiguration):
* 
Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::computeMediaCapabilitiesInfo):
* Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp:
(WebKit::RemoteMediaSessionHelperProxy::activeAudioRouteSupportsSpatialPlaybackDidChange):
* Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.h:
* Source/WebKit/Shared/mac/MediaFormatReader/CoreMediaWrapped.cpp:
(WebKit::wrapperVTable):
* Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp:
(WebKit::RemoteMediaSessionHelper::activeAudioRouteSupportsSpatialPlaybackDidChange):
* Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h:
* Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.messages.in:

Canonical link: https://commits.webkit.org/271504@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fb8f99: [IFC][Ruby] Can't add interlinear annotation displ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb8f991e77edc6302663831bc094bf8d6869b919
  
https://github.com/WebKit/WebKit/commit/fb8f991e77edc6302663831bc094bf8d6869b919
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h

  Log Message:
  ---
  [IFC][Ruby] Can't add interlinear annotation display box until bidi content 
is processed
https://bugs.webkit.org/show_bug.cgi?id=265759

Reviewed by Antti Koivisto.

This patch is in preparation for supporting bidi content in ruby.

* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
Move annotation box construction to a later time when we finished constructing 
all the display boxes. It ensures
such annotation boxes get to their correct _visual_ positions.

(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineDisplayBoxAtBidiBoundary):
(WebCore::Layout::InlineDisplayContentBuilder::insertRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
(WebCore::Layout::InlineDisplayContentBuilder::handleInlineBoxEnd): Deleted.
(WebCore::Layout::InlineDisplayContentBuilder::appendRubyAnnotationBox): 
Deleted.
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:

Canonical link: https://commits.webkit.org/271503@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b523a1: Move some WebKit code to WebKit framework

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b523a179f5bba6c054576ceaa5b724ec6120c226
  
https://github.com/WebKit/WebKit/commit/b523a179f5bba6c054576ceaa5b724ec6120c226
  Author: Per Arne Vollan 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift
A Source/WebKit/Shared/Cocoa/WKProcessExtension.h
A Source/WebKit/Shared/Cocoa/WKProcessExtension.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Move some WebKit code to WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=265324
rdar://118776213

Reviewed by Brent Fulgham.

Move some WebKit code related to WebKit process extensions to WebKit framework. 
This change enables
us to use new assertion API to take out an assertion on the Networking process 
when holding locked
files, which is also included in this patch.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setIsHoldingLockedFiles):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::aqcuireLockedFileGrant):
(WebKit::NetworkProcess::invalidateGrant):
(WebKit::NetworkProcess::hasAcquiredGrant const):
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift:
(Grant.invalidate):
(NetworkingProcessExtension.grant(_:name:)):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271502@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1d980c: [UnifiedPDF] Implement pinch-zooming (macOS)

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1d980c4592b05f24494e5fd86640b4289f2e01e5
  
https://github.com/WebKit/WebKit/commit/1d980c4592b05f24494e5fd86640b4289f2e01e5
  Author: Tim Horton 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ViewGestureController.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  [UnifiedPDF] Implement pinch-zooming (macOS)
https://bugs.webkit.org/show_bug.cgi?id=265760


Reviewed by Simon Fraser.

Implement pinch zooming (not HUD zooming or etc.) for the UnifiedPDFPlugin for 
macOS.

* Source/WebKit/UIProcess/ViewGestureController.cpp:
(WebKit::ViewGestureController::didCollectGeometryForMagnificationGesture):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBeginMagnificationGesture):
(WebKit::WebPageProxy::didEndMagnificationGesture):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Let the WebContent process know when we start a gesture (we already send the 
matching "end").

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::installPDFDocument):
(WebKit::PDFPlugin::deviceScaleFactorChanged):
(WebKit::PDFPlugin::geometryDidChange):
(WebKit::PDFPlugin::setPageScaleFactor):
(WebKit::PDFPlugin::notifyContentScaleFactorChanged):
(WebKit::PDFPlugin::contentsScaleFactorChanged): Deleted.
(WebKit::PDFPlugin::handlesPageScaleFactor const): Deleted.
Two small changes to the legacy PDFPlugin:
- rename contentsScaleFactorChanged to deviceScaleFactorChanged since that's 
what it's used for.
- Adopt the new `origin` parameter on setPageScaleFactor instead of using the 
"last mouse position".

This makes us match Preview and Web Content behavior when using the keyboard to 
zoom
(around the center of the view, not around the mouse!), and avoids the need to 
store
the last mouse position in UnifiedPDFPlugin (there remains one use in legacy 
PDFPlugin).

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::deviceScaleFactorChanged):
(WebKit::PDFPluginBase::didBeginMagnificationGesture):
(WebKit::PDFPluginBase::didEndMagnificationGesture):
(WebKit::PDFPluginBase::contentsScaleFactorChanged): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::handlesPageScaleFactor const):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::topContentInsetDidChange):
(WebKit::PluginView::didBeginMagnificationGesture):
(WebKit::PluginView::didEndMagnificationGesture):
(WebKit::PluginView::setPageScaleFactor):
(WebKit::PluginView::setDeviceScaleFactor):
(WebKit::PluginView::pageScaleFactorDidChange): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
(WebKit::WebPage::scalePage):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::didBeginMagnificationGesture):
(WebKit::WebPage::didEndMagnificationGesture):
Plumb beginning and end of magnification gestures, and the gesture origin, to 
the plugin.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
Mark our root layer as "the one that applies the page scale" if we're the whole 
main frame.

(WebKit::UnifiedPDFPlugin::paintContents):
(WebKit::UnifiedPDFPlugin::pageScaleFactor const):
(WebKit::UnifiedPDFPlugin::didBeginMagnificationGesture):
(WebKit::UnifiedPDFPlugin::didEndMagnificationGesture):
Keep track of when we're inside a magnification gesture, and tickle the layers
when the gesture ends.

(WebKit::UnifiedPDFPlugin::setPageScaleFactor):
Scale the contents layer with page scale, and counter-scroll to keep the
gesture origin in the same position.

For now, until we have async painting, we avoid updating the tiles until
the gesture ends.

(WebKit::UnifiedPDFPlugin::documentSize const):

[webkit-changes] [WebKit/WebKit] 4cf9ed: [scroll-animations] some WPT tests fail due to `Re...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cf9ed5d7e76a7cf7f956fd51d0a66c87a8fa0f9
  
https://github.com/WebKit/WebKit/commit/4cf9ed5d7e76a7cf7f956fd51d0a66c87a8fa0f9
  Author: Antoine Quint 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-ignored.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-multiple-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-none-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-scroll-functional-notation.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/progress-based-animation-animation-longhand-properties.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/progress-based-animation-timeline-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-axis-writing-mode-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-sampling-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-lookup-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/animation-events-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/web-animations/testcommon.js

  Log Message:
  ---
  [scroll-animations] some WPT tests fail due to `ReferenceError: Can't find 
variable: runAndWaitForFrameUpdate`
https://bugs.webkit.org/show_bug.cgi?id=265784

Reviewed by Tim Nguyen.

Update imported/w3c/web-platform-tests/web-animations/testcommon.js which 
contains a function used
by scroll-animations tests. This matches revision 
5ddf095c380db657c17e46dfebc45e93f682 of the
WPT repository.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-ignored.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-multiple-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-none-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-scroll-functional-notation.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/progress-based-animation-animation-longhand-properties.tentative-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/progress-based-animation-timeline-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-axis-writing-mode-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-sampling-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-lookup-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/animation-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/testcommon.js:
(assert_phase):
(async waitForCompositorReady):
* LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/271500@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f0f457: [WGSL] Explicit type conversion should not check f...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0f4573a7ded9af3e7e471119cb17cee0f25a0d1
  
https://github.com/WebKit/WebKit/commit/f0f4573a7ded9af3e7e471119cb17cee0f25a0d1
  Author: Tadeu Zagallo 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  ---
  [WGSL] Explicit type conversion should not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=265688
rdar://119044778

Reviewed by Mike Wyrzykowski.

When converting values to a different type (e.g. u32(i32)), we should not 
perform
the same overflow checks as when a type is implicitly converted (e.g. from 
AbstractInt
to i32).

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::convertValue):
(WGSL::constantConstructor):
(WGSL::constantVector):
(WGSL::constantMatrix):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::chooseOverload):
(WGSL::TypeChecker::convertValue):
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:

Canonical link: https://commits.webkit.org/271499@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7d887f: Have VTTCue use LoggerHelper

[danae404]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d887fc6d028bb20f3499c9169ff7057292600d5
  
https://github.com/WebKit/WebKit/commit/7d887fc6d028bb20f3499c9169ff7057292600d5
  Author: Dana Estra 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/html/track/VTTCue.h

  Log Message:
  ---
  Have VTTCue use LoggerHelper
https://bugs.webkit.org/show_bug.cgi?id=265466
rdar://118889015

Reviewed by Richard Robinson and Jer Noble.

Bring VTTCue's logging up to date by using INFO_LOG() and ERROR_LOG() instead 
of LOG().

* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::setTrack):
(WebCore::VTTCue::setCueSettings):
(WebCore::VTTCue::logIdentifier const):
(WebCore::VTTCue::logChannel const):
(WebCore::VTTCue::logger const):
* Source/WebCore/html/track/VTTCue.h:

Canonical link: https://commits.webkit.org/271498@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a61b53: AX: Roll back a retracted ARIA change: default ari...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a61b5328717137fe8cae16b24355504c75326a00
  
https://github.com/WebKit/WebKit/commit/a61b5328717137fe8cae16b24355504c75326a00
  Author: Joshua Hoffman 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt
M LayoutTests/accessibility/heading-level-expected.txt
M LayoutTests/accessibility/heading-level.html
M LayoutTests/accessibility/ios-simulator/heading-text-updates-expected.txt
M LayoutTests/accessibility/mac/heading-text-updates-expected.txt
M LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
M LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt
M 
LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  ---
  AX: Roll back a retracted ARIA change: default aria-level for heading role 
should not randomly be 2.
https://bugs.webkit.org/show_bug.cgi?id=265713
rdar://119059172

Reviewed by Chris Fleizach.

This patch rolls back a change that made the default aria-level for headings = 
2. This default value
was removed in ARIA 1.2 https://www.w3.org/TR/wai-aria-1.2/#heading.

The expectation for mac/heading-text-updates.html was also updated as a result 
of this revert.

* LayoutTests/accessibility/gtk/xml-roles-exposed-expected.txt:
* LayoutTests/accessibility/heading-level-expected.txt:
* LayoutTests/accessibility/heading-level.html:
* LayoutTests/accessibility/ios-simulator/heading-text-updates-expected.txt:
* LayoutTests/accessibility/mac/heading-text-updates-expected.txt:
* LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt:
* 
LayoutTests/platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::headingLevel const):

Canonical link: https://commits.webkit.org/271497@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bcde08: CMSampleBufferGetSampleAttachmentsArray return val...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bcde08d1581e66f651880e5903c782332fa5bc67
  
https://github.com/WebKit/WebKit/commit/bcde08d1581e66f651880e5903c782332fa5bc67
  Author: Brent Fulgham 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm

  Log Message:
  ---
  CMSampleBufferGetSampleAttachmentsArray return value is not checked for 
nullptr
https://bugs.webkit.org/show_bug.cgi?id=262650


Reviewed by Jer Noble.

CMSampleBufferGetSampleAttachmentsArray declares that its return value as 
CM_NULLABLE,
to warn users that a nullptr value might be returned.

This patch adds the missing nullptr check.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::createNonDisplayingCopy const):

Canonical link: https://commits.webkit.org/271496@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b08857: When repainting after layout, compute the outline ...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b088578e1f36d5fb9ce91269eab482bbc52be91d
  
https://github.com/WebKit/WebKit/commit/b088578e1f36d5fb9ce91269eab482bbc52be91d
  Author: Simon Fraser 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
LayoutTests/fast/repaint/hidpi-transform-on-subpixel-repaintrect-expected.txt
M LayoutTests/svg/repaint/mask-object-bounding-box-shrink-expected.txt
M Source/WebCore/rendering/LayoutRepainter.cpp
M Source/WebCore/rendering/LayoutRepainter.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderInline.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLineBreak.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/rendering/RenderReplaced.h
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableCell.h
M Source/WebCore/rendering/RenderTableCol.cpp
M Source/WebCore/rendering/RenderTableCol.h
M Source/WebCore/rendering/RenderTableRow.cpp
M Source/WebCore/rendering/RenderTableRow.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/svg/RenderSVGBlock.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.h
M Source/WebCore/rendering/svg/RenderSVGGradientStop.h
M Source/WebCore/rendering/svg/RenderSVGInline.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.h
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h

  Log Message:
  ---
  When repainting after layout, compute the outline bounds in the same pass as 
the clipped overflow rect
https://bugs.webkit.org/show_bug.cgi?id=265761
rdar://119101912

Reviewed by Alan Baradlay.

Currently repaints originating in RenderElement::repaintAfterLayoutIfNeeded() 
are computing using two rectangles:
the clippedOverflowRect, and the outlineBoundsForRepaint. These are computed in 
two separate ancestor traversals,
but we can make things more efficient by computing them at the same time.

The core functions that compute both rects, `computeRects()` and the virtual 
`computeVisibleRectsInContainer()`
that it calls were updated in previous commits (271364@main, 271422@main) to 
handle both rectangles. These
are generic functions that compute rectangles both for repaint, and other 
purposes.

Here we add a new, repaint-specific wrapper, `rectsForRepaintingAfterLayout()`, 
which returns both rectangles
via RepaintRects. Unfortunately, a number of classes specialize the calling 
function, `clippedOverflowRect()`,
so we need `rectsForRepaintingAfterLayout()` overrides in those classes to 
replicate their special behavior.

The previous `localRectForRepaint()` becomes `localRectsForRepaint()` to return 
the pair of rects,
optionally including the outline bounds rect.

RenderText and RenderInline are special becuase they never cares about the 
outline bounds rect. RenderTableRow and
RenderTableCol are special, and SVG has some special-case behavior in the 
non-LBSE code path.

LayoutRepainter now stores a RepaintsRect, and knows that the outline bounds is 
not needed if this is a full repaint.

RenderElement::repaintAfterLayoutIfNeeded() is adjusted to do the border radius 
computation using the outline
bounds rect (as a proxy for the border box size). Doing this computation in the 
clipped rect didn't make much sense.

RenderLayer no longer needs its own RepaintRects class. Also remove the 
assertions about invalid repaint rects;
they fired too often, and didn't clearly reflect real bugs.

There is a minor behavior change here that affects two tests: the results of 
the outline bounds rect computation
are snapped to device pixels, which did not happen before. This turns some full 
repaints into non-full repaints,
affecting fast/repaint/hidpi-transform-on-subpixel-repaintrect.html and 
svg/repaint/mask-object-bounding-box-shrink.html.
Testing shows that the former still repaints correctly. The latter fails to 
repaint, but I think that reflects
the fact that SVG should probably treat all post-layout repaints as full 
repaints (webkit.org/b/265723).

* LayoutTests/fast/repaint/hidpi-transform-on-subpixel-repaintrect-expected.txt:
* 

[webkit-changes] [WebKit/WebKit] 51b3b4: Call into WKApplicationUtilities when handling cer...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51b3b46f8e0b52d6dd39584f124a627127d32bc9
  
https://github.com/WebKit/WebKit/commit/51b3b46f8e0b52d6dd39584f124a627127d32bc9
  Author: Ben Nham 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/NavigationActionData.h
M Source/WebKit/Shared/NavigationActionData.serialization.in
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp

  Log Message:
  ---
  Call into WKApplicationUtilities when handling certain types of links
https://bugs.webkit.org/show_bug.cgi?id=265172
rdar://118667681

Reviewed by Brent Fulgham and Elliott Williams.

Trying to re-land now that build system fix is in (rdar://119075401).

In order to implement a particular feature, we need to call into 
WKApplicationUtilities when
handling certain types of navigation actions. This then calls a Swift-only API. 
To do this, we copy
WKApplicationUtilities.swift from WebKitAddition's include location to WebKit's 
DerivedSources. We
use EXCLUDED_SOURCE_FILES to exclude that file on platforms and SDKs where it 
doesn't exist.

This also requires us to know the top frame's origin at the point of 
navigation, and I couldn't find
any good way of accessing that state in decidePolicyForNavigationAction. So I 
modified
NavigationActionData to carry the topOrigin state.

* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/NavigationActionData.h:
* Source/WebKit/Shared/NavigationActionData.serialization.in:
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI):
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

Canonical link: https://commits.webkit.org/271494@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 10d1e7: Begin moving functions from LocalFrameView to Fram...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10d1e7485040a2f6ec54279ad9d7fe6dad7b5c44
  
https://github.com/WebKit/WebKit/commit/10d1e7485040a2f6ec54279ad9d7fe6dad7b5c44
  Author: Charlie Wolfe 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/Frame.h
A Source/WebCore/page/FrameView.cpp
M Source/WebCore/page/FrameView.h
M Source/WebCore/page/InteractionRegion.cpp
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/RemoteFrameView.cpp
M Source/WebCore/page/RemoteFrameView.h

  Log Message:
  ---
  Begin moving functions from LocalFrameView to FrameView
https://bugs.webkit.org/show_bug.cgi?id=265709
rdar://119058105

Reviewed by Alex Christensen.

* Source/WebCore/Sources.txt:
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::ownerRenderer const):
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/FrameView.cpp: Added.
(WebCore::FrameView::headerHeight const):
(WebCore::FrameView::footerHeight const):
(WebCore::FrameView::topContentInset const):
(WebCore::FrameView::visibleContentScaleFactor const):
(WebCore::FrameView::isActive const):
(WebCore::FrameView::enclosingScrollableArea const):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::forceUpdateScrollbarsOnMainThreadForPerformanceTesting 
const):
(WebCore::FrameView::scrollableAreaBoundingBox const):
(WebCore::FrameView::hostWindow const):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::scrollAnimatorEnabled const):
(WebCore::FrameView::convertFromRendererToContainingView const):
(WebCore::FrameView::convertFromContainingViewToRenderer const):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::ownerRenderer const): Deleted.
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::invalidateRect): Deleted.
(WebCore::LocalFrameView::headerHeight const): Deleted.
(WebCore::LocalFrameView::footerHeight const): Deleted.
(WebCore::LocalFrameView::topContentInset const): Deleted.
(WebCore::LocalFrameView::hostWindow const): Deleted.
(WebCore::LocalFrameView::isActive const): Deleted.
(WebCore::LocalFrameView::forceUpdateScrollbarsOnMainThreadForPerformanceTesting
 const): Deleted.
(WebCore::LocalFrameView::visibleContentScaleFactor const): Deleted.
(WebCore::LocalFrameView::enclosingScrollableArea const): Deleted.
(WebCore::LocalFrameView::scrollableAreaBoundingBox const): Deleted.
(WebCore::LocalFrameView::scrollbarStyleChanged): Deleted.
(WebCore::LocalFrameView::scrollAnimatorEnabled const): Deleted.
(WebCore::LocalFrameView::convertFromRendererToContainingView const): Deleted.
(WebCore::LocalFrameView::convertFromContainingViewToRenderer const): Deleted.
(WebCore::LocalFrameView::convertToContainingView const): Deleted.
(WebCore::LocalFrameView::convertFromContainingView const): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/RemoteFrameView.cpp:
(WebCore::RemoteFrameView::invalidateRect): Deleted.
(WebCore::RemoteFrameView::isActive const): Deleted.
(WebCore::RemoteFrameView::forceUpdateScrollbarsOnMainThreadForPerformanceTesting
 const): Deleted.
(WebCore::RemoteFrameView::enclosingScrollableArea const): Deleted.
(WebCore::RemoteFrameView::scrollableAreaBoundingBox const): Deleted.
(WebCore::RemoteFrameView::hostWindow const): Deleted.
* Source/WebCore/page/RemoteFrameView.h:

Canonical link: https://commits.webkit.org/271493@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fce14d: [WebGPU] API passing byte offsets for dynamic offs...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fce14d4cac88209826ea414bd8cd2e441e3b1aef
  
https://github.com/WebKit/WebKit/commit/fce14d4cac88209826ea414bd8cd2e441e3b1aef
  Author: Mike Wyrzykowski 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  ---
  [WebGPU] API passing byte offsets for dynamic offsets to the compiler which 
assumed they were indices
https://bugs.webkit.org/show_bug.cgi?id=265684


Reviewed by Dan Glastonbury.

Easier for the API to pass indices rather than byte offsets, so divide
by size of the index (uint).

* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::convertPipelineLayout):

Canonical link: https://commits.webkit.org/271492@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2699f1: Adopt alternatives for scroll view SPI: -_scrollVi...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2699f14fcf782b29a5906b9ba8e4059d5503718a
  
https://github.com/WebKit/WebKit/commit/2699f14fcf782b29a5906b9ba8e4059d5503718a
  Author: Wenson Hsieh 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm
M Source/WebKit/UIProcess/ios/PageClientImplIOS.h
M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
R Source/WebKit/UIProcess/ios/WKAxisLockingScrollView.h
R Source/WebKit/UIProcess/ios/WKAxisLockingScrollView.mm
A Source/WebKit/UIProcess/ios/WKBaseScrollView.h
A Source/WebKit/UIProcess/ios/WKBaseScrollView.mm
M Source/WebKit/UIProcess/ios/WKScrollView.mm
M Source/WebKit/UIProcess/ios/WKVelocityTrackingScrollView.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
M Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm

  Log Message:
  ---
  Adopt alternatives for scroll view SPI: 
-_scrollView:asynchronouslyHandleScrollEvent:completion:
https://bugs.webkit.org/show_bug.cgi?id=265732
rdar://114330492

Reviewed by Richard Robinson.

Refactor support for handling async wheel events in WebKit, when scrolling via 
trackpad on iPadOS.
In place of these private scroll view delegate methods, we now have subclassing 
hooks on
`UIScrollView` that provide equivalent functionality.

To achieve this, we add async scroll event support to a common base class 
between `WKScrollView` and
`WKChildScrollView`. We rename this base class (currently, 
`WKAxisLockingScrollView`) into
`WKBaseScrollView` to reflect its new responsibility, and implement the new 
async scroll event
methods on `WKScrollingNodeScrollViewDelegate` and `WKWebView`.

For the legacy private delegate methods, we conditionalize their 
implementations on a new compile-
time flag (if `UISCROLLVIEW_ASYNCHRONOUS_SCROLL_EVENT_SUBCLASS_HOOKS` is off), 
and call through to
the new `WKBaseScrollViewDelegate` method.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setupScrollAndContentViews]):

Move the `-_setAllowsAsyncScrollEvent:` call into `WKBaseScrollView`, only when 
the
`UISCROLLVIEW_ASYNCHRONOUS_SCROLL_EVENT_SUBCLASS_HOOKS` flag isn't set.

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
(-[WKWebView _scrollView:asynchronouslyHandleScrollEvent:completion:]):

Implement these legacy methods only when 
`UISCROLLVIEW_ASYNCHRONOUS_SCROLL_EVENT_SUBCLASS_HOOKS` is
not set.

(-[WKWebView scrollView:handleScrollEvent:completion:]):

Implement the new `WKBaseScrollView` delegate method for handling async scroll 
events.

(-[WKWebView axesToPreventScrollingForPanGestureInScrollView:]):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[WKChildScrollView initWithFrame:]):
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm:
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::scrollView const):
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollView const):
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreePluginScrollingNodeIOS.mm:
(WebKit::ScrollingTreePluginScrollingNodeIOS::scrollView const):
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
* 
Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

[webkit-changes] [WebKit/WebKit] 396b08: [IFC][Cleanup] Fix typos in Line, LineBuilder and ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 396b0829dcdd19597dd45a3e7fed2c47601d55ee
  
https://github.com/WebKit/WebKit/commit/396b0829dcdd19597dd45a3e7fed2c47601d55ee
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp

  Log Message:
  ---
  [IFC][Cleanup] Fix typos in Line, LineBuilder and TextUtil
https://bugs.webkit.org/show_bug.cgi?id=265758

Reviewed by Tim Nguyen.

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::removeOverflowingOutOfFlowContent):
(WebCore::Layout::Line::removeOverflowingOurOfFlowContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::hasTrailingSoftWrapOpportunity):
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::computedExpansions):

Canonical link: https://commits.webkit.org/271490@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e46f3: Unreviewed, reverting 271478@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e46f32d908f6b9b515ae056b474b0592513392a
  
https://github.com/WebKit/WebKit/commit/0e46f32d908f6b9b515ae056b474b0592513392a
  Author: Commit Queue 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift
R Source/WebKit/Shared/Cocoa/WKProcessExtension.h
R Source/WebKit/Shared/Cocoa/WKProcessExtension.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Unreviewed, reverting 271478@main.
https://bugs.webkit.org/show_bug.cgi?id=265795

Potential build issue

Reverted changeset:

"Move some WebKit code to WebKit framework"
https://bugs.webkit.org/show_bug.cgi?id=265324
https://commits.webkit.org/271478@main

Canonical link: https://commits.webkit.org/271489@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea214e: Remove ServerTimingEnabled preference

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea214e26778ceb84102fb5159cd896d6b35d5e40
  
https://github.com/WebKit/WebKit/commit/ea214e26778ceb84102fb5159cd896d6b35d5e40
  Author: Anne van Kesteren 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/loader/ResourceTiming.cpp
M Source/WebCore/page/DeprecatedGlobalSettings.h
M Source/WebCore/page/PerformanceResourceTiming.idl
M Source/WebCore/page/PerformanceServerTiming.idl
M Source/WebKit/UIProcess/API/C/WKPreferences.cpp
M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h

  Log Message:
  ---
  Remove ServerTimingEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=265747

Reviewed by Alex Christensen.

This was enabled by default over a year ago in 254940@main and we
already removed the preference that was enabled at the same time.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::populateServerTiming const):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setServerTimingEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::serverTimingEnabled): Deleted.
* Source/WebCore/page/PerformanceResourceTiming.idl:
* Source/WebCore/page/PerformanceServerTiming.idl:
* Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetServerTimingEnabled):
(WKPreferencesGetServerTimingEnabled):
* Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(-[WebPreferences serverTimingEnabled]):
(-[WebPreferences setServerTimingEnabled:]):
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:

Canonical link: https://commits.webkit.org/271488@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0dc58: [IFC][Ruby] Offset ruby base end inline item with ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0dc58c6d70ea710009978fe1902d03baa639cdb
  
https://github.com/WebKit/WebKit/commit/a0dc58c6d70ea710009978fe1902d03baa639cdb
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  ---
  [IFC][Ruby] Offset ruby base end inline item with overflowing interlinear 
annotation box
https://bugs.webkit.org/show_bug.cgi?id=265756

Reviewed by Antti Koivisto.

While annotation boxes don't participate in inline layout, when placing the 
associated base content
on the line, we have to make sure the base inline box end "covers" any 
overflowing interlinear annotation.

e.g.
"base contentthis is a long annotationafter ruby content" 
does not produce this:

[this is a long annotation]
[base content][after ruby content]  <- line content.

but something along the lines of

[this is a long annotation]
[base content] [after ruby content]

(ignore ruby base alignment for now)

* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::candidateContentForLine):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::baseLogicalWidthFromRubyBaseEnd):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271487@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b191b: Re-enable imported/w3c/html-templates/parsing-html...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b191bdb2a9109b291ddec697e8ce7f31c13edb6
  
https://github.com/WebKit/WebKit/commit/4b191bdb2a9109b291ddec697e8ce7f31c13edb6
  Author: Anne van Kesteren 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/ios-device/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Re-enable 
imported/w3c/html-templates/parsing-html-templates/creating-an-element-for-the-token/template-owner-document.html
 and friends
https://bugs.webkit.org/show_bug.cgi?id=151469
rdar://23622739

Reviewed by Tim Nguyen.

See if enough time has passed for the crasher to "disappear" as we
should not have an active HTML parser crasher.

Also remove some likely bogus iOS skips.

* LayoutTests/platform/ios-device/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/271486@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3acbb6: Borders, backgrounds, and other table cell propert...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3acbb664bd93438447218221d223c3466cdfa63c
  
https://github.com/WebKit/WebKit/commit/3acbb664bd93438447218221d223c3466cdfa63c
  Author: Wenson Hsieh 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
M Source/WebCore/PAL/pal/PlatformMac.cmake
M Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h
A Source/WebCore/PAL/pal/spi/mac/NSTextTableSPI.h
M Source/WebCore/editing/cocoa/AttributedString.mm
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm

  Log Message:
  ---
  Borders, backgrounds, and other table cell properties are lost when pasting 
tables into TextEdit
https://bugs.webkit.org/show_bug.cgi?id=265712
rdar://119035264

Reviewed by Richard Robinson.

Even after the fixes in 266700@main and 269265@main, attributed string 
serialization is still lossy.
In the process of preserving table structure in `reconstructStyle` by 
recreating any
`NSTextTableBlock` instances that point to separate tables but (originally) 
belonged to the same
`NSTextTable` upon encoding, we end up discarding the decoded 
`NSTextTableBlock`, and only carry
over some aspects of the block (i.e., row and column information).

This causes us to lose information about the style and layout of these tables, 
on various bits of
state on `NSTextTableBlock` that are populated in `HTMLConverter::_fillInBlock`.

To fix this, we adopt a UIFoundation SPI, `-_takeValuesFromTextBlock:`, that 
allows us to copy
across the entire state of the `NSTextTableBlock` in a way that preserves style 
and layout
information, without changing the containing `NSTextTable`, or any of the 
row/column values.

* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/PlatformMac.cmake:
* Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:
* Source/WebCore/PAL/pal/spi/mac/NSTextTableSPI.h: Added.
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::reconstructStyle):

Implement the main fix here, by using `-_takeValuesFromTextBlock:` to copy all 
layout and
presentational attributes from the original, decoded text block over to the new 
one that points to
the correct text table.

* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:

Canonical link: https://commits.webkit.org/271485@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e694f6: resync CSS selector parsing tests

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e694f63e91aad88d879b8730a588972b8f4a0ec2
  
https://github.com/WebKit/WebKit/commit/e694f63e91aad88d879b8730a588972b8f4a0ec2
  Author: Keith Cirkel 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log

  Log Message:
  ---
  resync CSS selector parsing tests
https://bugs.webkit.org/show_bug.cgi?id=265785

Reviewed by Tim Nguyen.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/5ddf095c380db657c17e46dfebc45e93f682

* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has-expected.txt:
 Rebaselined.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-disallow-nesting-has-inside-has.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-expected.txt:
 Rebaselined.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has-forgiving-selector.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-has.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-slotted.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state-expected.txt:
 Rebaselined.
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-state.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/w3c-import.log:

Canonical link: https://commits.webkit.org/271484@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7097e3: [view-transitions] Implement "capture new state" a...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7097e3442fce1622b1104d3bbc6b9040a05672ca
  
https://github.com/WebKit/WebKit/commit/7097e3442fce1622b1104d3bbc6b9040a05672ca
  Author: Tim Nguyen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-capture-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start-expected.txt
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h

  Log Message:
  ---
  [view-transitions] Implement "capture new state" algorithm
https://bugs.webkit.org/show_bug.cgi?id=265715
rdar://119068808

Reviewed by Simon Fraser.

This commit:
- makes the "named elements" map use a custom built ordered map, since 
insertion order will be important when building the pseudo elements and 
rendering them
The pseudo element construction will be done in: 
https://github.com/WebKit/WebKit/pull/21205

- implements the "capture new state" algorithm which simply re-validates the 
"named elements" map and throws an error if needed
- fixes error handling for the "capture old state" algorithm.

Spec:
- capture old state: 
https://drafts.csswg.org/css-view-transitions/#capture-old-state-algorithm
- capture new state: 
https://drafts.csswg.org/css-view-transitions/#capture-new-state-algorithm
- named elements: 
https://drafts.csswg.org/css-view-transitions/#viewtransition-named-elements

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-capture-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start-expected.txt:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupViewTransition):
(WebCore::effectiveViewTransitionName):
(WebCore::checkDuplicateViewTransitionName):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::activateViewTransition):
* Source/WebCore/dom/ViewTransition.h:
(WebCore::OrderedNamedElementsMap::contains const):
(WebCore::OrderedNamedElementsMap::add):
(WebCore::OrderedNamedElementsMap::remove):
(WebCore::OrderedNamedElementsMap::keys const):
(WebCore::OrderedNamedElementsMap::find):
(WebCore::ViewTransition::namedElements const):

Canonical link: https://commits.webkit.org/271483@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 01a600: [UIAsyncTextInput] Keyboard sometimes autocapitali...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01a600b1bfc9dba31c408eadc2900e28e1a63389
  
https://github.com/WebKit/WebKit/commit/01a600b1bfc9dba31c408eadc2900e28e1a63389
  Author: Wenson Hsieh 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
A LayoutTests/editing/input/ios/typing-with-inline-predictions-expected.txt
A LayoutTests/editing/input/ios/typing-with-inline-predictions.html
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  [UIAsyncTextInput] Keyboard sometimes autocapitalizes incorrectly while 
typing an inline completion
https://bugs.webkit.org/show_bug.cgi?id=265764
rdar://119084774

Reviewed by Richard Robinson.

After adopting `-invalidateTextEntryContext` in place of `-[UIKeyboardImpl 
layoutHasChanged]` when
the async text input codepath is enabled, the keyboard sometimes unexpectedly 
autocapitalizes when
typing while showing inline predictions in Mail compose.

This is because the replacement API (`-invalidateTextEntryContext`) now 
additionally updates text
context in addition to updating the layout and positioning of input method UI 
(i.e. when using
Chinese or Japanese input). This is meant to only be done only once, when 
initially starting IME
composition, in order to give certain web apps (e.g. Google Docs) a chance to 
reposition any
offscreen, hidden editable containers such that the input method UI and 
candidates bar shows up in
the right place — to achieve this, we set a `_candidateViewNeedsUpdate` flag 
upon setting any marked
text where the marked text range is previously empty, and clear out the flag 
after the next
selection change.

In iOS 17+, inline predictions also exercise this same marked text codepath; 
however, instead of
maintaining a persistent marked text string, inline predictions continuously 
clear out and reinsert
marked text as the prediction is regenerated while typing, which causes the
`_candidateViewNeedsUpdate` flag to be continuously set (and therefore, causes 
us to continuously
invoke `-invalidateTextEntryContext` while typing).

The combination of the above causes the keyboard to occasionally lose context 
while typing, which
results in the keyboard becoming erroneously autoshifted after typing a space. 
To fix this, we make
this logic more nuanced, such that we only `-invalidateTextEntryContext` if 
there's an active IME
session (excluding marked text, set by inline predictions).

Test: editing/input/ios/typing-with-inline-predictions.html

* LayoutTests/editing/input/ios/typing-with-inline-predictions-expected.txt: 
Added.
* LayoutTests/editing/input/ios/typing-with-inline-predictions.html: Added.

Add a layout test to exercise the change.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:

Introduce a new flag, `_isDeferringKeyEventsToInputMethod`, to track whether or 
not we have an
active IME session.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpInteraction]):
(-[WKContentView canPerformActionForWebView:withSender:]):

Drive-by fix: replace some internal calls to `-hasContent` with an internal 
version instead,
`-_hasContent`, to avoid self-induced release assertions after 271417@main.

(-[WKContentView _setMarkedText:underlines:highlights:selectedRange:]):
(-[WKContentView unmarkText]):

Unset the new flag when committing marked text.

(-[WKContentView _internalHandleKeyWebEvent:withCompletionHandler:]):

Set the new flag, `_isDeferringKeyEventsToInputMethod`, if we've actually 
deferred key event
handling to system IME.

(-[WKContentView hasContent]):
(-[WKContentView _hasContent]):

See drive-by fix above.

Canonical link: https://commits.webkit.org/271482@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1838f3: [WebRTC] RtpPacketizer::SplitAboutEqually() should...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1838f3eb70b2990d4dbdd0aeb5bd5189ef87d87d
  
https://github.com/WebKit/WebKit/commit/1838f3eb70b2990d4dbdd0aeb5bd5189ef87d87d
  Author: David Kilzer 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format.cc
A 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-RtpPacketizer-SplitAboutEqually-should-return-empty-std-vector.patch

  Log Message:
  ---
  [WebRTC] RtpPacketizer::SplitAboutEqually() should return an empty 
std::vector when payload_len is 0
https://bugs.webkit.org/show_bug.cgi?id=265711


Reviewed by Youenn Fablet.

* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format.cc:
(webrtc::RtpPacketizer::SplitAboutEqually):
- Return empty std::vector when payload_len is 0 so that various
  ::NumPackets() methods return 0 when there are no packets to create.

* 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-RtpPacketizer-SplitAboutEqually-should-return-empty-std-vector.patch:
 Add.

Canonical link: https://commits.webkit.org/271481@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b3c62: Adopt -[UIScrollView showScrollIndicatorsForConten...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b3c6264047e1aba121521b83cf2a7e72c0435c5
  
https://github.com/WebKit/WebKit/commit/4b3c6264047e1aba121521b83cf2a7e72c0435c5
  Author: Wenson Hsieh 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/ios/UIKitUtilities.h
M Source/WebKit/UIProcess/ios/UIKitUtilities.mm
M Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm

  Log Message:
  ---
  Adopt -[UIScrollView showScrollIndicatorsForContentOffsetChanges:] for 
animated keyboard scrolling
https://bugs.webkit.org/show_bug.cgi?id=265765
rdar://119105952

Reviewed by Richard Robinson.

Stop using `-_flashScrollIndicatorsForAxes:persistingPreviousFlashes:` to show 
scroll indicators
after programmatically changing the content offset during animated keyboard 
scrolling; instead,
adopt `-showScrollIndicatorsForContentOffsetChanges:`, if available; with this 
new API, UIKit will
show scroll indicators on any axes that are programmatically scrolled during 
the call to the given
ObjC block, automatically persisting previous flashes.

* Source/WebKit/UIProcess/ios/UIKitUtilities.h:
* Source/WebKit/UIProcess/ios/UIKitUtilities.mm:
(axesForDelta):
(-[UIScrollView _wk_setContentOffsetAndShowScrollIndicators:animated:]):
* Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
(axesForDelta): Deleted.

Canonical link: https://commits.webkit.org/271480@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b9f202: [WPE] Fix missing initializer warning for member w...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9f2021a494c6be647ce1fe01ffc1a62d81b3bc1
  
https://github.com/WebKit/WebKit/commit/b9f2021a494c6be647ce1fe01ffc1a62d81b3bc1
  Author: Lauro Moura 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp
M Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp

  Log Message:
  ---
  [WPE] Fix missing initializer warning for member 
wl_pointer_listener::axis_relative_direction and related issues
https://bugs.webkit.org/show_bug.cgi?id=265767

Reviewed by Michael Catanzaro and Žan Doberšek.

Move axis_relative_direction from wl_surface_listener to wl_pointer_listener

* Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:
* Source/WebKit/WPEPlatform/wpe/wayland/WPEWaylandSeat.cpp:

Canonical link: https://commits.webkit.org/271479@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 676f48: Move some WebKit code to WebKit framework

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 676f48d6af5f4b9101395ad4ee76f64d23317e18
  
https://github.com/WebKit/WebKit/commit/676f48d6af5f4b9101395ad4ee76f64d23317e18
  Author: Per Arne Vollan 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift
A Source/WebKit/Shared/Cocoa/WKProcessExtension.h
A Source/WebKit/Shared/Cocoa/WKProcessExtension.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Move some WebKit code to WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=265324
rdar://118776213

Reviewed by Brent Fulgham.

Move some WebKit code related to WebKit process extensions to WebKit framework. 
This change enables
us to use new assertion API to take out an assertion on the Networking process 
when holding locked
files, which is also included in this patch.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setIsHoldingLockedFiles):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::aqcuireLockedFileGrant):
(WebKit::NetworkProcess::invalidateGrant):
(WebKit::NetworkProcess::hasAcquiredGrant const):
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h:
* 
Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift:
(Grant.invalidate):
(NetworkingProcessExtension.grant(_:name:)):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271478@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4eceb1: [scroll-animations] add parsing support for the `s...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4eceb1199abdee3b067ad3675692c8036917332c
  
https://github.com/WebKit/WebKit/commit/4eceb1199abdee3b067ad3675692c8036917332c
  Author: Antoine Quint 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/css/CSSProperties.json
A Source/WebCore/css/CSSScrollValue.cpp
A Source/WebCore/css/CSSScrollValue.h
M Source/WebCore/css/CSSToStyleMap.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/platform/animation/Animation.cpp
M Source/WebCore/platform/animation/Animation.h
M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

  Log Message:
  ---
  [scroll-animations] add parsing support for the `scroll()` notation of the 
`animation-timeline` property
https://bugs.webkit.org/show_bug.cgi?id=265786

Reviewed by Antti Koivisto.

We now add parsing support for the `scroll()` notation of the 
`animation-timeline` property using a new
`CSSValue` subclass: `CSSScrollValue`. This will yield an anonymous 
`ScrollTimeline`.

* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::createFromCSSValue):
(WebCore::ScrollTimeline::ScrollTimeline):
(WebCore::ScrollTimeline::toCSSValue const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSScrollValue.cpp: Added.
(WebCore::CSSScrollValue::customCSSText const):
(WebCore::CSSScrollValue::equals const):
* Source/WebCore/css/CSSScrollValue.h: Added.
* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimeline):
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isScrollValue const):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForAnimationTimeline):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleAnimationTimeline):
(WebCore::CSSPropertyParserHelpers::consumeAnimationTimelineScroll):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/animation/Animation.h:
* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: https://commits.webkit.org/271477@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 94ac29: Remove redundant Cocoa-specific EnumTraits special...

[Žan Doberšek]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94ac298a5aff06bc81c7eb4395875f857991b3c5
  
https://github.com/WebKit/WebKit/commit/94ac298a5aff06bc81c7eb4395875f857991b3c5
  Author: Žan Doberšek 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
M Source/WebCore/platform/ios/SelectionGeometry.h

  Log Message:
  ---
  Remove redundant Cocoa-specific EnumTraits specializations under 
WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=265448

Reviewed by Chris Dumez.

Remove the EnumTraits specializations for 
MediaPlayerPrivateAVFoundation::MediaRenderingMode
and SelectionRenderingBehavior enumerations. The former is not needed and the
latter already has an IPC serialization specification available.

* 
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* Source/WebCore/platform/ios/SelectionGeometry.h:

Canonical link: https://commits.webkit.org/271476@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 589e42: Generate IPC serialization for PlatformCAAnimation...

[Žan Doberšek]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 589e429f93fa0a826f6393f782e232a0bc55664b
  
https://github.com/WebKit/WebKit/commit/589e429f93fa0a826f6393f782e232a0bc55664b
  Author: Žan Doberšek 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M Source/WebCore/platform/graphics/ca/PlatformCAAnimation.cpp
M Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h
M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.h

  Log Message:
  ---
  Generate IPC serialization for PlatformCAAnimation enums
https://bugs.webkit.org/show_bug.cgi?id=265439

Reviewed by Chris Dumez.

Rework the enumerations in the PlatformCAAnimation header to enable providing
IPC serialization specification and removing the accompanying EnumTraits
specializations.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::createSpringAnimation):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
* Source/WebCore/platform/graphics/ca/PlatformCAAnimation.cpp:
(WebCore::operator<<):
(WebCore::PlatformCAAnimation::isBasicAnimation const):
* Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h:
(WebCore::PlatformCAAnimation::PlatformCAAnimation):
(): Deleted.
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
(WebCore::toCAFillModeType):
(WebCore::fromCAFillModeType):
(WebCore::toCAValueFunctionType):
(WebCore::fromCAValueFunctionType):
(WebCore::PlatformCAAnimationCocoa::PlatformCAAnimationCocoa):
(WebCore::PlatformCAAnimationCocoa::copy const):
(WebCore::PlatformCAAnimationCocoa::keyPath const):
(WebCore::PlatformCAAnimationCocoa::setTimingFunction):
(WebCore::PlatformCAAnimationCocoa::isAdditive const):
(WebCore::PlatformCAAnimationCocoa::setAdditive):
(WebCore::PlatformCAAnimationCocoa::valueFunction const):
(WebCore::PlatformCAAnimationCocoa::setValueFunction):
(WebCore::PlatformCAAnimationCocoa::setValues):
(WebCore::PlatformCAAnimationCocoa::copyValuesFrom):
(WebCore::PlatformCAAnimationCocoa::setAnimations):
(WebCore::PlatformCAAnimationCocoa::copyAnimationsFrom):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::copy const):
(WebKit::PlatformCAAnimationRemote::setFromValue):
(WebKit::PlatformCAAnimationRemote::setToValue):
(WebKit::PlatformCAAnimationRemote::setValues):
(WebKit::createAnimation):
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.h:

Canonical link: https://commits.webkit.org/271475@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a57a8: [git-webkit pr] Make Terminal prompting more intui...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a57a82da90d310062a29618eb876155ca3baeaa
  
https://github.com/WebKit/WebKit/commit/0a57a82da90d310062a29618eb876155ca3baeaa
  Author: Jonathan Bedard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  ---
  [git-webkit pr] Make Terminal prompting more intuitive (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=265697
rdar://119050672

Unreviewed follow-up fix.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pre_pr_checks): Continue with upload if user says "Yes" to 
ignoring checker errors.

Canonical link: https://commits.webkit.org/271474@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d20819: [IFC][Ruby] Add support for breakable ruby bases

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d208198da1375a939e90e0416615e054e76107a4
  
https://github.com/WebKit/WebKit/commit/d208198da1375a939e90e0416615e054e76107a4
  Author: Alan Baradlay 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
M 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
M Source/WebCore/layout/layouttree/LayoutBox.h

  Log Message:
  ---
  [IFC][Ruby] Add support for breakable ruby bases
https://bugs.webkit.org/show_bug.cgi?id=265752

Reviewed by Antti Koivisto.

Let's be more relaxed about where we can have a line break opportunity inside 
ruby boxes.

before/after ruby box -> yes (see FIXME for some special characters)
between ruby start/end and ruby base star/end -> no
between ruby start/end and adjacent ruby content -> no (this is similar to 
no_break)
inside ruby base -> yes
between ruby bases -> yes

In this patch
- remove code for old behavior where ruby bases where handled atomic from line 
breaking point of view
- ensure we don't break when annotation would overflow (see 
minimumRequiredWidth)

* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::reset):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::minimumRequiredWidth 
const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::setMinimumRequiredWidth):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::isAtSoftWrapOpportunity):
(WebCore::Layout::InlineFormattingUtils::nextWrapOpportunity):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::continuousContent const):
(WebCore::Layout::LineCandidate::InlineContent::appendtrailingWordBreakOpportunity):
(WebCore::Layout::LineCandidate::InlineContent::isEmpty const):
(WebCore::Layout::LineCandidate::InlineContent::setMinimumRequiredWidth):
(WebCore::Layout::LineCandidate::InlineContent::reset):
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineCandidate::InlineContent::rubyContainerRange const): 
Deleted.
(WebCore::Layout::LineCandidate::InlineContent::appendRubyContainerRange): 
Deleted.
(WebCore::Layout::LineCandidate::InlineContent::isRuby const): Deleted.
(WebCore::Layout::LineBuilder::handleRubyContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
* 
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::isAtSoftWrapOpportunity):
(WebCore::Layout::RubyFormattingContext::annotationBoxLogicalWidth):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isRubyInlineBox const):

Canonical link: https://commits.webkit.org/271473@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Carlos Garcia Campos]

  Branch: refs/tags/webkitgtk-2.43.2
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9f150: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9f1501e75032bbecb195fa3717d0719fb2040a3
  
https://github.com/WebKit/WebKit/commit/c9f1501e75032bbecb195fa3717d0719fb2040a3
  Author: Carlos Garcia Campos 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for 2.43.2 release

* Source/WebKit/gtk/NEWS: Add release notes for 2.43.2.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Canonical link: https://commits.webkit.org/271472@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf1801: Unreviewed. Fix non-unified build

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf1801072821c610df90f784250fcb33618d2e88
  
https://github.com/WebKit/WebKit/commit/cf1801072821c610df90f784250fcb33618d2e88
  Author: Carlos Garcia Campos 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/heap/CodeBlockSet.cpp
M Source/JavaScriptCore/heap/JITStubRoutineSet.cpp
M Source/JavaScriptCore/jit/JITCall.cpp
M Source/WebCore/dom/InvokeEvent.h
M Source/WebCore/dom/ViewTransition.h
M Source/WebCore/html/canvas/WebGLShaderPrecisionFormat.h
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/page/OpportunisticTaskScheduler.cpp
M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp
M 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
M Source/WebCore/rendering/RenderLayerInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/svg/SVGClipPathElement.cpp
M Source/WebCore/xml/DOMParser.cpp

  Log Message:
  ---
  Unreviewed. Fix non-unified build

* Source/JavaScriptCore/heap/CodeBlockSet.cpp:
* Source/JavaScriptCore/heap/JITStubRoutineSet.cpp:
* Source/JavaScriptCore/jit/JITCall.cpp:
* Source/WebCore/dom/InvokeEvent.h:
* Source/WebCore/dom/ViewTransition.h:
* Source/WebCore/html/canvas/WebGLShaderPrecisionFormat.h:
* 
Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp:
* Source/WebCore/page/OpportunisticTaskScheduler.cpp:
* Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
* 
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
* Source/WebCore/rendering/RenderLayerInlines.h:
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
* Source/WebCore/svg/SVGClipPathElement.cpp:
* Source/WebCore/xml/DOMParser.cpp:

Canonical link: https://commits.webkit.org/271471@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Adrian Perez]

  Branch: refs/tags/wpewebkit-2.42.3
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 69d023: Cherry-pick 271350@main (48684d06eb78). https://bu...

[Adrian Perez]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: 69d0233392c01bc7c2b066ed6bb0e2b0479ec1c8
  
https://github.com/WebKit/WebKit/commit/69d0233392c01bc7c2b066ed6bb0e2b0479ec1c8
  Author: David Degazio 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp
M Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h

  Log Message:
  ---
  Cherry-pick 271350@main (48684d06eb78). 
https://bugs.webkit.org/show_bug.cgi?id=265469

Fix race condition in ARM64 disassembler initialization
https://bugs.webkit.org/show_bug.cgi?id=265469
rdar://118890976

Reviewed by Mark Lam and Yusuke Suzuki.

Moves A64DOpcode::init() inside a std::call_once to ensure it is
not called simultaneously from more than one thread.

* Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcode::A64DOpcode):

Canonical link: https://commits.webkit.org/271350@main


  Commit: a4a3639c04684544d04bf4b5282e6d84a2935f79
  
https://github.com/WebKit/WebKit/commit/a4a3639c04684544d04bf4b5282e6d84a2935f79
  Author: Jonathan Bedard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/setup.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M Tools/Scripts/webkitpy/autoinstalled/twisted.py

  Log Message:
  ---
  Cherry-pick 268269@main (530fa2b998ab). 
https://bugs.webkit.org/show_bug.cgi?id=261893

[webkitcorepy] Install tomli with setuptools_scm
https://bugs.webkit.org/show_bug.cgi?id=261893
rdar://115851645

Reviewed by Aakash Jain.

Newer versions of setuptools_scm depend on tomli.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
Bump version, add tomli.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Install tomli with setuptools dependencies.

Canonical link: https://commits.webkit.org/268269@main


  Commit: ec8517df881fb7e91576623a7ddaa4cceaf23fce
  
https://github.com/WebKit/WebKit/commit/ec8517df881fb7e91576623a7ddaa4cceaf23fce
  Author: Sam Sneddon 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  Cherry-pick 267552@main (d94691e07a31). 
https://bugs.webkit.org/show_bug.cgi?id=260997

Ensure AutoInstall.install_everything succeeds with implicit_deps
https://bugs.webkit.org/show_bug.cgi?id=260997

Reviewed by Jonathan Bedard.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall.install_everything):

Canonical link: https://commits.webkit.org/267552@main


  Commit: 8e297435dc63c98338454557fc4bb76ecd318e96
  
https://github.com/WebKit/WebKit/commit/8e297435dc63c98338454557fc4bb76ecd318e96
  Author: Jonathan Bedard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/setup.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  Cherry-pick 268523@main (5bae443a6845). 
https://bugs.webkit.org/show_bug.cgi?id=262124

[webkitcorepy] Packaging requires pyparsing
https://bugs.webkit.org/show_bug.cgi?id=262124
rdar://116062896

Reviewed by Elliott Williams.

* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Install pyparsing before packaging.

Canonical link: https://commits.webkit.org/268523@main


  Commit: 5f94d58124c5e6fc8ee96a7dfed2168c4e1f8e92
  
https://github.com/WebKit/WebKit/commit/5f94d58124c5e6fc8ee96a7dfed2168c4e1f8e92
  Author: Jonathan Bedard 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  ---
  Cherry-pick 268542@main (7d79fbb31dcd). 
https://bugs.webkit.org/show_bug.cgi?id=262124

[webkitcorepy] Packaging requires pyparsing (Follow-up to 268523@main)
https://bugs.webkit.org/show_bug.cgi?id=262124
rdar://116062896

Reviewed by Elliott Williams.

Landed incorrect version of this change in 268523@main (5bae443a6845),
land the correctly reviewed version.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Install base libraries from a list instead naming them 
explicitly.
(AutoInstall): Centralize all libraries required by setup.py in a single 
list,
add pyparsing to that list.

Canonical link: 

[webkit-changes] [WebKit/WebKit] fccd8d: [Cocoa] Enable VP9 profile 2 for WebCodecs and WebRTC

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fccd8d04b7864e66ab57a7c90f9e343d9097dd03
  
https://github.com/WebKit/WebKit/commit/fccd8d04b7864e66ab57a7c90f9e343d9097dd03
  Author: Youenn Fablet 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [Cocoa] Enable VP9 profile 2 for WebCodecs and WebRTC
https://bugs.webkit.org/show_bug.cgi?id=265661
rdar://119032039

Reviewed by Eric Carlson.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/271470@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a824b: error: '_setAllowsAsyncScrollEvent:' is deprecated

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a824b6da5a8a7936c22eb57e4b51b1a72c19072
  
https://github.com/WebKit/WebKit/commit/5a824b6da5a8a7936c22eb57e4b51b1a72c19072
  Author: Antoine Quint 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm

  Log Message:
  ---
  error: '_setAllowsAsyncScrollEvent:' is deprecated
https://bugs.webkit.org/show_bug.cgi?id=265781
rdar://119118191

Unreviewed build fix.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[WKChildScrollView initWithFrame:]):

Canonical link: https://commits.webkit.org/271469@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1750bf: [IFC][Ruby] Disable fast/ruby/ruby-line-height.htm...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1750bfb07c80e5cc302083b43931e630d17adf4c
  
https://github.com/WebKit/WebKit/commit/1750bfb07c80e5cc302083b43931e630d17adf4c
  Author: Antti Koivisto 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [IFC][Ruby] Disable fast/ruby/ruby-line-height.html on WK1
https://bugs.webkit.org/show_bug.cgi?id=265783
rdar://119121706

Unreviewed test gardening.

It uses



but that leaks to other tests on WK1 because the setting affects the global UA 
sheet. WK2 knows to swap the process.

* LayoutTests/platform/mac-wk1/TestExpectations:

Skip for now.

Canonical link: https://commits.webkit.org/271468@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3aecf2: Update ANGLE to 2023-12-01 (ab992c3efe0f574e5547d0...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3aecf2aea6c4db18c61d1e0281d201e78d59c046
  
https://github.com/WebKit/WebKit/commit/3aecf2aea6c4db18c61d1e0281d201e78d59c046
  Author: Kimmo Kinnunen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/AUTHORS
M Source/ThirdParty/ANGLE/BUILD.gn
M Source/ThirdParty/ANGLE/Compiler.cmake
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesGL_autogen.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesMtl_autogen.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M 
Source/ThirdParty/ANGLE/include/platform/autogen/FrontendFeatures_autogen.h
M Source/ThirdParty/ANGLE/include/platform/frontend_features.json
M Source/ThirdParty/ANGLE/include/platform/gl_features.json
M Source/ThirdParty/ANGLE/include/platform/mtl_features.json
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Metal_default_shaders.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json
M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py
M Source/ThirdParty/ANGLE/scripts/roll_aosp.sh
M Source/ThirdParty/ANGLE/src/common/platform.h
M Source/ThirdParty/ANGLE/src/compiler.gni
M Source/ThirdParty/ANGLE/src/compiler/translator/StaticType.h
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorGLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.cpp
A 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/PreTransformTextureCubeGradDerivatives.cpp
A 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/PreTransformTextureCubeGradDerivatives.h
A Source/ThirdParty/ANGLE/src/image_util/LoadToNative_unittest.cpp
M Source/ThirdParty/ANGLE/src/image_util/loadimage.inc
M Source/ThirdParty/ANGLE/src/libANGLE/Compiler.h
M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Context.h
M Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/EGLSync.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/EGLSync.h
M Source/ThirdParty/ANGLE/src/libANGLE/GLES1Renderer.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/MemoryProgramCache.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/MemoryProgramCache.h
M Source/ThirdParty/ANGLE/src/libANGLE/MemoryShaderCache.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/MemoryShaderCache.h
M Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Program.h
M Source/ThirdParty/ANGLE/src/libANGLE/ProgramExecutable.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Shader.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/State.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/queryutils.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/queryutils.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/EGLImplFactory.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/EGLReusableSync.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/EGLReusableSync.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/EGLSyncImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/ProgramD3D.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/Query11.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/ProgramGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/QueryGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/QueryGL.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/ShaderGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/egl/DisplayEGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/egl/DisplayEGL.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/egl/SyncEGL.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/egl/SyncEGL.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.h
M 

[webkit-changes] [WebKit/WebKit] 3fb2a4: [WebXR] Port enum classes to new serialization format

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fb2a422f959942a00e037541091558e8c3b18ed
  
https://github.com/WebKit/WebKit/commit/3fb2a422f959942a00e037541091558e8c3b18ed
  Author: Claudio Saavedra 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/platform/xr/PlatformXR.h
M Source/WebKit/Shared/XR/XRSystem.serialization.in

  Log Message:
  ---
  [WebXR] Port enum classes to new serialization format
https://bugs.webkit.org/show_bug.cgi?id=265665

Reviewed by Dan Glastonbury.

Move the XR enums to the new serialization format to be able to get
rid of the enum traits for them.

 * Source/WebCore/platform/xr/PlatformXR.h:
 * Source/WebKit/Shared/XR/XRSystem.serialization.in:

Canonical link: https://commits.webkit.org/271466@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d82458: Unreviewed. Fix GTK distcheck

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d82458954d7854a338e1410668406c9fcffe0b0e
  
https://github.com/WebKit/WebKit/commit/d82458954d7854a338e1410668406c9fcffe0b0e
  Author: Carlos Garcia Campos 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebCore/PlatformWPE.cmake

  Log Message:
  ---
  Unreviewed. Fix GTK distcheck

Move wpe specific header from common cmake file to the platform specific
ones.

* Source/WebCore/Headers.cmake:
* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/PlatformWPE.cmake:

Canonical link: https://commits.webkit.org/271465@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d7706a: NEW TEST (271087@main): [ macOS x86_64 wk2 ] 2 tes...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7706a47e954ecbc56a077d10c10842d4b7745de
  
https://github.com/WebKit/WebKit/commit/d7706a47e954ecbc56a077d10c10842d4b7745de
  Author: Youenn Fablet 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.js

  Log Message:
  ---
  NEW TEST (271087@main): [ macOS x86_64 wk2 ] 2 tests in http/wpt/webcodecs 
are a constant failure
https://bugs.webkit.org/show_bug.cgi?id=265483
rdar://118901410

Reviewed by Jean-Yves Avenard.

x86_64 VTB encoder does not like some low resolutions, increase to 200x200 to 
handle this correctly..
In the future, https://github.com/WebKit/WebKit/pull/20876 will surface such 
errors instead of silently failing.

* LayoutTests/http/wpt/webcodecs/h264-encoder-default-config.https.any.js:
(async encoderTest):

Canonical link: https://commits.webkit.org/271464@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81c7a2: [scroll-animations] add initial parsing support fo...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81c7a2680aef817d7d0bdccabc2bb3baf36e6e96
  
https://github.com/WebKit/WebKit/commit/81c7a2680aef817d7d0bdccabc2bb3baf36e6e96
  Author: Antoine Quint 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-duration-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-shorthand-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-in-keyframe-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-named-scroll-progress-timeline.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-scroll-functional-notation.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-view-functional-notation.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/get-animations-inactive-timeline-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/named-range-keyframes-with-document-timeline.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/progress-based-animation-animation-longhand-properties.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-document-scroller-quirks-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-in-container-query-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-multi-pass.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-nearest-dirty-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-nearest-with-absolute-positioned-element-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-paused-animations-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-range-animation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-responsiveness-from-endpoint-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/scroll-timeline-root-dirty-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-range-name-offset-in-keyframes.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-animation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-animation-range-update.tentative-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-dynamic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-range-animation-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-used-values-expected.txt
M 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
M 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSToStyleMap.cpp
M Source/WebCore/css/CSSToStyleMap.h
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M 

[webkit-changes] [WebKit/WebKit] abc235: 2D context get/putImageData cache should be aware ...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: abc23583c3fded932dce57b3a4cdfa547d771464
  
https://github.com/WebKit/WebKit/commit/abc23583c3fded932dce57b3a4cdfa547d771464
  Author: Kimmo Kinnunen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebCore/html/ImageData.cpp
M Source/WebCore/html/ImageData.h
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
M Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp
M Source/WebCore/platform/graphics/PixelBuffer.cpp
M Source/WebCore/platform/graphics/PixelBuffer.h
M Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.cpp

  Log Message:
  ---
  2D context get/putImageData cache should be aware of empty contents
https://bugs.webkit.org/show_bug.cgi?id=264930
rdar://118499949

Reviewed by Cameron McCormack.

Avoid real ImageBuffer::getPixelBuffer when getImageData is called
for a new 2D context. Track the transparent contents state and
just return zero filled ImageData buffer.

Hardens ImageData to ensure the data buffer is not created too big.
The buffer size is limited with PixelBuffer max size.
This would be caught with test
fast/canvas/canvas-getImageData-invalid-result-buffer-crash.html

Fixes a bug where CG path of text drawing would not mark the canvas
as modified. This would be caught with test
fast/canvas/gradient-text-with-shadow.html

Fixes a bug where focus drawing would not mark the canvas as modified.
This would be caught with test
fast/canvas/draw-focus-if-needed-with-path.html
fast/canvas/draw-focus-if-needed.html

* Source/WebCore/html/ImageData.cpp:
(WebCore::ImageData::create):
* Source/WebCore/html/ImageData.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::reset):
(WebCore::CanvasRenderingContext2DBase::didDraw):
(WebCore::CanvasRenderingContext2DBase::evictCachedImageData):
(WebCore::CanvasRenderingContext2DBase::CachedContentsImageData::CachedContentsImageData):
(WebCore::CanvasRenderingContext2DBase::cacheImageDataIfPossible):
(WebCore::CanvasRenderingContext2DBase::makeImageDataIfContentsCached const):
(WebCore::CanvasRenderingContext2DBase::getImageData const):
(WebCore::CanvasRenderingContext2DBase::putImageData):
(WebCore::CanvasRenderingContext2DBase::CachedImageData::CachedImageData): 
Deleted.
(WebCore::CanvasRenderingContext2DBase::takeCachedImageDataIfPossible const): 
Deleted.
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:

Canonical link: https://commits.webkit.org/271462@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bdc1a3: WebGLContextAttributes are used for GraphicsContextGL

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdc1a360d76f9dace3ce823d750c0231d3af7244
  
https://github.com/WebKit/WebKit/commit/bdc1a360d76f9dace3ce823d750c0231d3af7244
  Author: Kimmo Kinnunen 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash-expected.txt
M LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/HTMLCanvasElement.h
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
M Source/WebCore/html/canvas/WebGL2RenderingContext.h
M Source/WebCore/html/canvas/WebGLContextAttributes.h
M Source/WebCore/html/canvas/WebGLContextAttributes.idl
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/html/canvas/WebGLRenderingContext.h
M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h
M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
M Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp
M 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  WebGLContextAttributes are used for GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=265519
rdar://118931301

Reviewed by Dan Glastonbury and Antti Koivisto.

Separate WebGLContextAttributes and GraphicsContextGLAttributes.
This makes it easier to move the default framebuffer implementation from
GraphicsContextGL to WebGLRenderingContext.

This is work towards fixing premultipliedAlpha=false compositing.

* LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash-expected.txt:
* LayoutTests/webgl/webgl-fail-platform-context-creation-no-crash.html:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toWebGLVersion):
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::createContextWebGL):
* Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::create):
* Source/WebCore/html/canvas/WebGL2RenderingContext.h:
* Source/WebCore/html/canvas/WebGLContextAttributes.h:
* Source/WebCore/html/canvas/WebGLContextAttributes.idl:
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
* Source/WebCore/html/canvas/WebGLRenderingContext.h:
* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::resolveGraphicsContextGLAttributes):
(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::initializeContextState):
(WebCore::WebGLRenderingContextBase::addActivityStateChangeObserverIfNecessary):
(WebCore::WebGLRenderingContextBase::getContextAttributes):
(WebCore::WebGLRenderingContextBase::makeXRCompatible):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::isHighPerformanceContext): Deleted.
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::creationAttributes const):
(WebCore::WebGLRenderingContextBase::isXRCompatible const):
* Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h:
(WebCore::GraphicsContextGLAttributes::effectivePowerPreference const): Deleted.
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::initialize):
* Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::initializeEGLDisplay):
(WebCore::GraphicsContextGLCocoa::platformInitializeContext):
(WebCore::GraphicsContextGLCocoa::platformInitialize):
* Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLGBM::platformInitializeContext):
* 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitializeContext):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::requestedGPU):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/271461@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4182b4: Make more HTML pseudo-class selector tests run on iOS

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4182b4f08764c58085e16a52617999200c2545b4
  
https://github.com/WebKit/WebKit/commit/4182b4f08764c58085e16a52617999200c2545b4
  Author: Anne van Kesteren 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt
M LayoutTests/platform/ios-device/TestExpectations
R 
LayoutTests/platform/ios-wk2/fast/forms/label/readwrite-readonly-expected.txt
M 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt
M LayoutTests/platform/ios/TestExpectations
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt
R 
LayoutTests/platform/mac-wk2/fast/forms/label/readwrite-readonly-expected.txt
R 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt
R 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt
R 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt

  Log Message:
  ---
  Make more HTML pseudo-class selector tests run on iOS
https://bugs.webkit.org/show_bug.cgi?id=265745

Reviewed by Tim Nguyen.

Also attempt to shift expectations around so less platform-specific
expectations are required.

Furthermore, remove some platform-specific leftover expectation files.

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
 Removed.
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
 Removed.
* LayoutTests/platform/ios-device/TestExpectations:
* 
LayoutTests/platform/ios-wk2/fast/forms/label/readwrite-readonly-expected.txt: 
Removed.
* 
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
* LayoutTests/platform/ios/TestExpectations:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
 Copied from 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt.
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
 Renamed from 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt.
* 
LayoutTests/platform/mac-wk2/fast/forms/label/readwrite-readonly-expected.txt: 
Removed.
* 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
 Removed.
* 
LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/271460@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6b6465: error: '_setAllowsAsyncScrollEvent:' is deprecated

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b6465da32c693b98766b201278a15af0bdda879
  
https://github.com/WebKit/WebKit/commit/6b6465da32c693b98766b201278a15af0bdda879
  Author: Antoine Quint 
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  ---
  error: '_setAllowsAsyncScrollEvent:' is deprecated
https://bugs.webkit.org/show_bug.cgi?id=265781
rdar://119118191

Unreviewed build fix.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setupScrollAndContentViews]):

Canonical link: https://commits.webkit.org/271459@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes