[webkit-changes] [WebKit/WebKit] efe351: Correct iOS focus ring
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: efe35104221863220f85ae234adc7081454180a0 https://github.com/WebKit/WebKit/commit/efe35104221863220f85ae234adc7081454180a0 Author: Anne van Kesteren Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeIOS.h M Source/WebCore/rendering/RenderThemeIOS.mm Log Message: --- Correct iOS focus ring https://bugs.webkit.org/show_bug.cgi?id=266281 rdar://119555352 Reviewed by Aditya Keerthi. Make RenderThemeIOS build on ControlStyle::State rather than ControlStates::States. The ControlStates architecture is dated, does not account for shadow hosts, and should probably be disappeared entirely. This is an incremental step towards that goal. Then provide the switch's thumb painting code has access to the system outline color. And ensure that by default we don't draw an outline for a switch on iOS. Web developers can override this by using a non-auto outline-style value, but that will not draw the outline around the thumb. * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::extractControlStyleStatesForRendererInternal const): (WebCore::adjustRendererForAppearance): (WebCore::RenderTheme::extractControlStyleStatesForRenderer const): (WebCore::RenderTheme::extractControlStyleForRenderer const): * Source/WebCore/rendering/RenderTheme.h: * Source/WebCore/rendering/RenderThemeIOS.h: * Source/WebCore/rendering/RenderThemeIOS.mm: (WebCore::renderThemePaintSwitchThumb): (WebCore::renderThemePaintSwitchTrack): (WebCore::RenderThemeIOS::adjustSwitchStyle const): (WebCore::RenderThemeIOS::paintSwitchThumb): (WebCore::RenderThemeIOS::paintSwitchTrack): (WebCore::RenderThemeIOS::checkboxRadioBorderColor): (WebCore::RenderThemeIOS::checkboxRadioBackgroundColor): (WebCore::RenderThemeIOS::checkboxRadioBackgroundGradient): (WebCore::RenderThemeIOS::checkboxRadioIndicatorColor): (WebCore::RenderThemeIOS::paintCheckboxRadioInnerShadow): (WebCore::RenderThemeIOS::paintCheckbox): (WebCore::RenderThemeIOS::paintRadio): Canonical link: https://commits.webkit.org/272020@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01f617: Null check page in FrameLoader::updateFirstPartyFo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01f61795972ef4402a7517266d16789a185d5a1e https://github.com/WebKit/WebKit/commit/01f61795972ef4402a7517266d16789a185d5a1e Author: Alex Christensen Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp Log Message: --- Null check page in FrameLoader::updateFirstPartyForCookies https://bugs.webkit.org/show_bug.cgi?id=266388 rdar://119634195 Reviewed by Pascoe. In 270267@main I introduced a null dereference that introduced a possible crash. Covered by the test in the radar. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateFirstPartyForCookies): Canonical link: https://commits.webkit.org/272019@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6a7b7: Adopt the ServiceExtensions framework for async te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6a7b742d24d37554294e235e5026cd9b86abc04 https://github.com/WebKit/WebKit/commit/e6a7b742d24d37554294e235e5026cd9b86abc04 Author: Wenson Hsieh Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/ios/WebEvent.mm M Source/WebCore/platform/ios/WebEventPrivate.h A Source/WebCore/platform/ios/WebSEDefinitions.h M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/Shared/DocumentEditingContext.h M Source/WebKit/Shared/DocumentEditingContext.mm M Source/WebKit/UIProcess/API/ios/WKSEDefinitions.h M Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/ios/WKExtendedTextInputTraits.h M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.h M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm M Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.h M Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- Adopt the ServiceExtensions framework for async text input support https://bugs.webkit.org/show_bug.cgi?id=266302 rdar://119568570 Reviewed by Tim Horton. Adopt `WKSE*`-prefixed objects, which are aliased to the new classes, protocols, or types and constants exposed from the ServiceExtensions framework (if available), or otherwise aliased to the `UIAsync*` SPI names. No change in behavior; see below for more details. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/ios/WebEvent.mm: (webEventType): (isChangingKeyModifiers): (-[WebEvent initWithKeyEvent:]): (-[WebEvent originalKeyEvent]): (-[WebEvent initWithUIKeyEvent:]): Deleted. (-[WebEvent originalUIKeyEvent]): Deleted. * Source/WebCore/platform/ios/WebEventPrivate.h: * Source/WebCore/platform/ios/WebSEDefinitions.h: Copied from Source/WebKit/UIProcess/API/ios/WKSEDefinitions.h. * Source/WebKit/Platform/spi/ios/UIKitSPI.h: * Source/WebKit/Shared/DocumentEditingContext.h: * Source/WebKit/Shared/DocumentEditingContext.mm: (WebKit::setOptionalEditingContextProperties): (WebKit::DocumentEditingContext::toLegacyPlatformContext): (WebKit::DocumentEditingContext::toPlatformContext): * Source/WebKit/UIProcess/API/ios/WKSEDefinitions.h: * Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _updateRuntimeProtocolConformanceIfNeeded]): (-[WKContentView textInteractionGesture:shouldBeginAtPoint:]): (toGestureType): (toWKSEGestureType): (toSelectionTouch): (toWKSESelectionTouch): (toWKSESelectionFlags): (toSelectionFlags): (selectionChangedWithGesture): (selectionChangedWithTouch): (-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]): (-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]): (-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]): (-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]): (logTextInteraction): (-[WKContentView insertTextSuggestion:]): (shiftKeyState): (-[WKContentView _deferKeyEventToInputMethodEditing:]): (-[WKContentView _interpretKeyEvent:isCharEvent:]): (-[WKContentView dataListTextSuggestions]): (-[WKContentView setDataListTextSuggestions:]): (-[WKContentView updateTextSuggestionsForInputDelegate]): (-[WKContentView _provideSuggestionsToInputDelegate:]): (-[WKContentView _provideUITextSuggestionsToInputDelegate:]): (toWebRequest): (-[WKContentView requestDocumentContext:completionHandler:]): Make the completion handler here take an `NSObject`, representing either a `UIWKDocumentRequest` or the replacement class from ServiceExtensions. This allows us to maintain both binary and source compatibility in all the following cases: - Against iOS 17, which doesn't have async text input support at all, or against versions of iOS 17 that have `UIAsyncTextInput` but not the replacement APIs in ServiceExtensions. We fall back to `UIWKDocumentContext` here. - Building/running against versions of iOS 17 that have both `UIAsyncTextInput` and the requisite APIs in ServiceExtensions, but have `UIKit/async_text_input` disabled by default — here, we use the new ServiceExtensions API objects and flags (which, for the most part, maintain binary compatibility), with the exception of `WKSETextDocumentRequest`. In the completion handler, if async text input is disabled,
[webkit-changes] [WebKit/WebKit] be53e5: [Wasm-GC] select operation should subtype check it...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be53e5fb7d969d9c062114ce9b472afc870a869e https://github.com/WebKit/WebKit/commit/be53e5fb7d969d9c062114ce9b472afc870a869e Author: Asumu Takikawa Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A JSTests/wasm/gc/bug266056.js M Source/JavaScriptCore/wasm/WasmFunctionParser.h Log Message: --- [Wasm-GC] select operation should subtype check its arguments https://bugs.webkit.org/show_bug.cgi?id=266056 Reviewed by Justin Michaud. Use subtyping instead of type equality for annotated select arguments. * JSTests/wasm/gc/bug266056.js: Added. * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::FunctionParser::parseExpression): Canonical link: https://commits.webkit.org/272017@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 456ffa: [Wasm-GC] Typedef unrolling cache should hold valu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 456ffae07aa82edcd3063baea83d87a83f75df2e https://github.com/WebKit/WebKit/commit/456ffae07aa82edcd3063baea83d87a83f75df2e Author: Asumu Takikawa Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A JSTests/wasm/gc/bug265721.js M Source/JavaScriptCore/wasm/WasmParser.h M Source/JavaScriptCore/wasm/WasmSectionParser.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp M Source/JavaScriptCore/wasm/WasmTypeDefinition.h Log Message: --- [Wasm-GC] Typedef unrolling cache should hold values strongly https://bugs.webkit.org/show_bug.cgi?id=265721 Reviewed by Justin Michaud. This patch fixes two related issues. The main issue is that there is a cache for type definition unrollings that didn't hold the values strongly, and since these values are not held by the Wasm instance they could get de-allocated. This could cause correctness issues or crashes. That bug was in practice hard to trigger (though it did trigger on some large compiled-to-wasm examples), because it was hidden by a second bug. The placeholders in recursive types (used to delay type expansion to cut off infinite expansion of recursive types) were also not held strongly by the TypeInformation store, so they could also get de-allocated when an instance gets collected. This bug makes memoization less effective but didn't affect correctness. This patch makes the placeholders held by the TypeInformation store itself, similar to how special type signatures are held by the store. They are also only allocated via a helper function now, which ensures the store holds the typedef. It also fixes the cache by using RefPtr for the value type. * JSTests/wasm/gc/typedef.js: * Source/JavaScriptCore/wasm/WasmParser.h: (JSC::Wasm::Parser::parseValueType): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseSubtype): * Source/JavaScriptCore/wasm/WasmTypeDefinition.cpp: (JSC::Wasm::TypeInformation::getPlaceholderProjection): * Source/JavaScriptCore/wasm/WasmTypeDefinition.h: Canonical link: https://commits.webkit.org/272016@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23026a: Stop using CheckedPtr / CheckedRef in TreeScopeOrd...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23026ae16e81f45dc1e4ecdac96c24eeb905e7a6 https://github.com/WebKit/WebKit/commit/23026ae16e81f45dc1e4ecdac96c24eeb905e7a6 Author: Chris Dumez Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/dom/TreeScope.cpp M Source/WebCore/dom/TreeScope.h M Source/WebCore/dom/TreeScopeOrderedMap.cpp M Source/WebCore/dom/TreeScopeOrderedMap.h Log Message: --- Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h https://bugs.webkit.org/show_bug.cgi?id=266370 Reviewed by Ryosuke Niwa. Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h. Use WeakPtr / WeakRef instead to generate more actionable crashes. This tested as performance neutral on Speedometer 2 & 3. * Source/WebCore/dom/TreeScope.cpp: (WebCore::TreeScope::getAllElementsById const): (WebCore::TreeScope::labelElementsForId): * Source/WebCore/dom/TreeScope.h: * Source/WebCore/dom/TreeScopeOrderedMap.cpp: (WebCore::TreeScopeOrderedMap::add): (WebCore::TreeScopeOrderedMap::remove): (WebCore::TreeScopeOrderedMap::get const): (WebCore::TreeScopeOrderedMap::getAll const): (WebCore::TreeScopeOrderedMap::getElementsByLabelForAttribute const): (WebCore::TreeScopeOrderedMap::getAllElementsById const): * Source/WebCore/dom/TreeScopeOrderedMap.h: Canonical link: https://commits.webkit.org/272015@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15a1de: REGRESSION (271966@main): Netflix playback fails o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15a1de2814bc521c737a4370fc2eef779005398c https://github.com/WebKit/WebKit/commit/15a1de2814bc521c737a4370fc2eef779005398c Author: Andy Estes Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm Log Message: --- REGRESSION (271966@main): Netflix playback fails on iPadOS after adopting AVSampleBufferAttachContentKey https://bugs.webkit.org/show_bug.cgi?id=266375 rdar://119345487 Reviewed by Jer Noble. On iOS a key may be usable for decryption even when its status isn't KeyStatus::Usable. Accounted for this by reusing the logic in CDMInstanceFairPlayStreamingAVFObjC::isAnyKeyUsable to determine if a key is usable. Also asserted that there is no usable key whenever CDMInstanceSessionFairPlayStreamingAVFObjC::contentKeyForSample returns nil. * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::isPotentiallyUsableKeyStatus): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::isAnyKeyUsable const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::isAnyKeyUsable const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::contentKeyForSample): Canonical link: https://commits.webkit.org/272014@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8f8ed: [JSC] Add --top-bytecode-count and --top-function-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8f8ed69cb2cc84af4d6820bd1a13710a6e164c8 https://github.com/WebKit/WebKit/commit/c8f8ed69cb2cc84af4d6820bd1a13710a6e164c8 Author: Yusuke Suzuki Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/Scripts/display-sampling-profiler-output Log Message: --- [JSC] Add --top-bytecode-count and --top-function-count options to display-sampling-profiler-output https://bugs.webkit.org/show_bug.cgi?id=266327 rdar://119597908 Reviewed by Justin Michaud. Add --top-bytecode-count and --top-function-count options to display-sampling-profiler-output to see more information easily. * Tools/Scripts/display-sampling-profiler-output: Canonical link: https://commits.webkit.org/272013@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa62ce: BYTECODE_HELPER_ID LLint opcodes need look up for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa62ce7b905994f278e4661ae4c7425ce400be01 https://github.com/WebKit/WebKit/commit/aa62ce7b905994f278e4661ae4c7425ce400be01 Author: Mark Lam Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/JavaScriptCore/llint/LLIntOpcode.h M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp Log Message: --- BYTECODE_HELPER_ID LLint opcodes need look up for wide versions. https://bugs.webkit.org/show_bug.cgi?id=266294 rdar://119563251 Reviewed by Justin Michaud. FOR_EACH_BYTECODE_HELPER_ID was mistakenly lumped in with FOR_EACH_LLINT_NATIVE_HELPER, which does not populate their entries in g_opcodeMapWide16 and g_opcodeMapWide32. This patch fixes that. This was causing CLoop runs to crash on nullptr derefs on these non-initialized entries. * Source/JavaScriptCore/llint/LLIntOpcode.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.cpp: (JSC::CLoop::execute): Canonical link: https://commits.webkit.org/272012@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54eb10: Cherry-pick 272009@main (fcd69249c493). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 54eb108128256d04616cf518d19285a45a0515a9 https://github.com/WebKit/WebKit/commit/54eb108128256d04616cf518d19285a45a0515a9 Author: Miguel Gomez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp M Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp Log Message: --- Cherry-pick 272009@main (fcd69249c493). https://bugs.webkit.org/show_bug.cgi?id=265990 [GTK][WPE] Random incorrect image displayed as the background of a div https://bugs.webkit.org/show_bug.cgi?id=265990 Reviewed by Žan Doberšek. Add an unique ID to cairo surfaces created in ImageBackingStoreCairo. This unique ID allows us to differentiate when the cairo surface that's backing an image has changed, so we are sure that we're not using an incorrect value cached inside some ImageBackingStore. * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::attachSurfaceUniqueID): (WebCore::getSurfaceUniqueID): * Source/WebCore/platform/graphics/cairo/CairoUtilities.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): * Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp: (WebCore::ImageBackingStore::image const): Canonical link: https://commits.webkit.org/272009@main Canonical link: https://commits.webkit.org/266719.202@webkitglib/2.42 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcb3a4: [IFC][Ruby] Incorrect preferred width computation ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcb3a49fe8cd08528fae2b9cc6a34fcb3c091697 https://github.com/WebKit/WebKit/commit/fcb3a49fe8cd08528fae2b9cc6a34fcb3c091697 Author: Alan Baradlay Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- [IFC][Ruby] Incorrect preferred width computation when is present https://bugs.webkit.org/show_bug.cgi?id=266357 Reviewed by Antti Koivisto. Let's hold on to ruby base min/max width and make sure the associated annotation box's min/max values are taken into account. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): Canonical link: https://commits.webkit.org/272011@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a598c: [Test Gardening] css-contain/contain-size-block-00...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a598c84d4d6fd610d63fdf1b4d1d9a091765ea8 https://github.com/WebKit/WebKit/commit/9a598c84d4d6fd610d63fdf1b4d1d9a091765ea8 Author: Sammy Gill Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/gtk/TestExpectations Log Message: --- [Test Gardening] css-contain/contain-size-block-003.html and css-contain/contain-size-inline-block-003.html only fail on GTK. https://bugs.webkit.org/show_bug.cgi?id=266345 rdar://problem/119617786 Unreviewed, test gardening. * LayoutTests/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/272010@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcd692: [GTK][WPE] Random incorrect image displayed as the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcd69249c4936e186feea896bdfe27d9be97faab https://github.com/WebKit/WebKit/commit/fcd69249c4936e186feea896bdfe27d9be97faab Author: Miguel Gomez Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp M Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp Log Message: --- [GTK][WPE] Random incorrect image displayed as the background of a div https://bugs.webkit.org/show_bug.cgi?id=265990 Reviewed by Žan Doberšek. Add an unique ID to cairo surfaces created in ImageBackingStoreCairo. This unique ID allows us to differentiate when the cairo surface that's backing an image has changed, so we are sure that we're not using an incorrect value cached inside some ImageBackingStore. * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::attachSurfaceUniqueID): (WebCore::getSurfaceUniqueID): * Source/WebCore/platform/graphics/cairo/CairoUtilities.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly): * Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp: (WebCore::ImageBackingStore::image const): Canonical link: https://commits.webkit.org/272009@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 791a42: Unreviewed, reverting 271984@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 791a42d94c356ca3929c2df3cef0778f425b2c32 https://github.com/WebKit/WebKit/commit/791a42d94c356ca3929c2df3cef0778f425b2c32 Author: Commit Queue Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Unreviewed, reverting 271984@main. https://bugs.webkit.org/show_bug.cgi?id=266376 Introduced perf regression Reverted changeset: "Unreviewed, reverting 271900@main." https://bugs.webkit.org/show_bug.cgi?id=266340 https://commits.webkit.org/271984@main Canonical link: https://commits.webkit.org/272008@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9de8c8: Unreviewed, reverting 272006@main and 272001@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9de8c84f9f9dc6b8a1559cbbc070d024c82f86df https://github.com/WebKit/WebKit/commit/9de8c84f9f9dc6b8a1559cbbc070d024c82f86df Author: Ryan Haddad Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- Unreviewed, reverting 272006@main and 272001@main https://bugs.webkit.org/show_bug.cgi?id=266374 rdar://119632464 Broke the TestWebKitAPI build Unreviewed build fix. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Canonical link: https://commits.webkit.org/272007@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f563a7: Unreviewed build fix after 272001@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f563a7603aeee616ff1bce435d629465f1cfce4f https://github.com/WebKit/WebKit/commit/f563a7603aeee616ff1bce435d629465f1cfce4f Author: Chris Dumez Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- Unreviewed build fix after 272001@main. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Canonical link: https://commits.webkit.org/272006@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 976e63: VTTScanner should copy the string it is parsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 976e6341b4a89ea4c8a4f27185d0219af1ac3189 https://github.com/WebKit/WebKit/commit/976e6341b4a89ea4c8a4f27185d0219af1ac3189 Author: Eric Carlson Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/html/track/VTTScanner.cpp M Source/WebCore/html/track/VTTScanner.h Log Message: --- VTTScanner should copy the string it is parsing https://bugs.webkit.org/show_bug.cgi?id=266355 rdar://119621360 Reviewed by Chris Dumez. Store the String to be parsed in a member variable instead of only storing pointers to the start and end of the String to avoid crashes like the one caused by caused by 270868@main. * Source/WebCore/html/track/VTTScanner.cpp: (WebCore::VTTScanner::VTTScanner): * Source/WebCore/html/track/VTTScanner.h: Canonical link: https://commits.webkit.org/272005@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f4e684: [JSC] Do not fallback to slow C++ JSBoundFunction ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f4e684d4ff33534862ab452e73691e49a36f8ed3 https://github.com/WebKit/WebKit/commit/f4e684d4ff33534862ab452e73691e49a36f8ed3 Author: Yusuke Suzuki Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/JITOperations.h M Source/JavaScriptCore/jit/ThunkGenerators.cpp M Source/JavaScriptCore/runtime/VM.cpp Log Message: --- [JSC] Do not fallback to slow C++ JSBoundFunction code https://bugs.webkit.org/show_bug.cgi?id=266311 rdar://119582604 Reviewed by Justin Michaud. Let's not fallback to slow C++ JSBoundFunction code, which invokes function through interpreter again. We can just materialize JIT code from JSBoundFunction thunk and continue running from JS world instead of jumping to C++ and jumping back to JS. * Source/JavaScriptCore/jit/JITOperations.cpp: (JSC::materializeTargetCode): (JSC::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/jit/JITOperations.h: * Source/JavaScriptCore/jit/ThunkGenerators.cpp: (JSC::boundFunctionCallGenerator): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::thunkGeneratorForIntrinsic): Canonical link: https://commits.webkit.org/272004@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 424d67: [Gardening]: NEW TEST: [ Ventura+ wk2 Release x86_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 424d67c3b4a64d35ec434c7a0d362de6e0f40c37 https://github.com/WebKit/WebKit/commit/424d67c3b4a64d35ec434c7a0d362de6e0f40c37 Author: Marta Darbinyan Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST: [ Ventura+ wk2 Release x86_64 ] media/video-audio-session-mode.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=265954 rdar://119265443 Unreviewed test gardening. Updating test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272003@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 236cc5: Unreviewed, reverting 271998@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 236cc5b3746dde681f8eca64f7f1a66cd9b1a328 https://github.com/WebKit/WebKit/commit/236cc5b3746dde681f8eca64f7f1a66cd9b1a328 Author: Robert Jenner Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Unreviewed, reverting 271998@main rdar://119629801 rdar://119629801 [ Build Failure ] revokeLaunchServicesSandboxExtension is an undeclared identifier Reverted change: Register application in the WebProcess on Catalyst https://bugs.webkit.org/show_bug.cgi?id=266350 rdar://119217913 https://commits.webkit.org/271998@main Canonical link: https://commits.webkit.org/272002@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f550d: REGRESSION (270199@main?): [ iOS Debug ] ASSERTION...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f550dd5c82dcb458bd95678869855f8b7657528 https://github.com/WebKit/WebKit/commit/1f550dd5c82dcb458bd95678869855f8b7657528 Author: Marta Darbinyan Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- REGRESSION (270199@main?): [ iOS Debug ] ASSERTION FAILED: _maximumUnobscuredSizeOverride in TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen result of constant crash https://bugs.webkit.org/show_bug.cgi?id=265068 rdar://118579209 Unreviewed test gardening. Disabling crashing API-Test. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: (DISABLED_ElementFullscreen): (loadPictureInPicture): Deleted. (TEST): Deleted. Canonical link: https://commits.webkit.org/272001@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a95216: [results.webkit.org] Differentiate each minor SDK ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a95216e886d0f460ed4cd026ed831063a2c4a4dc https://github.com/WebKit/WebKit/commit/a95216e886d0f460ed4cd026ed831063a2c4a4dc Author: Jonathan Bedard Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js M Tools/Scripts/libraries/resultsdbpy/setup.py Log Message: --- [results.webkit.org] Differentiate each minor SDK release https://bugs.webkit.org/show_bug.cgi?id=266315 rdar://119585201 Reviewed by Aakash Jain. Append a letter release family to every version name with a compliant SDK string. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/__init__.py: Bump version. * Tools/Scripts/libraries/resultsdbpy/setup.py: Ditto. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js: (Configuration.releaseForSDK): Convert a SDK to the release family. (Configuration.prototype.toParams): Strip release family from the version_name. Canonical link: https://commits.webkit.org/272000@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a01245: Build fix: Update libvpx up to M120
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a01245bb7fddee0123ec23272e7cb61d9e1bcd7d
https://github.com/WebKit/WebKit/commit/a01245bb7fddee0123ec23272e7cb61d9e1bcd7d
Author: David Kilzer
Date: 2023-12-13 (Wed, 13 Dec 2023)
Changed paths:
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Log Message:
---
Build fix: Update libvpx up to M120
https://bugs.webkit.org/show_bug.cgi?id=265864
rdar://119184902
Unreviewed build fix.
Remove unused source files to fix builds that don't strip symbols.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
- Let Xcode have its way with the project file by re-ordering files from
41AB330F2B1F8D7700CEC7AE to 41AB33172B1F8D7700CEC7AE.
- Remove vp9_firstpass.{c,h} as this code is unused with
CONFIG_REALTIME_ONLY=1.
- Remove vpx_convolve8_neon_asm.{c,h} since they create duplicate
symbols for vpx_convolve8_neon.{c,h}.
- Remove vpx_convolve8_*_neon.asm files since we don't build assembly
sources (using yasm) for Apple silicon architectures.
Canonical link: https://commits.webkit.org/271999@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab5696: Register application in the WebProcess on Catalyst
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab569688e977b669f375202d1ab5228f6e1b60f4 https://github.com/WebKit/WebKit/commit/ab569688e977b669f375202d1ab5228f6e1b60f4 Author: Per Arne Vollan Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Register application in the WebProcess on Catalyst https://bugs.webkit.org/show_bug.cgi?id=266350 rdar://119217913 Reviewed by Brent Fulgham. Call _RegisterApplication on Catalyst while holding a XPC sandbox extension. Calling this function without the sandbox extension will crash. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Canonical link: https://commits.webkit.org/271998@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6094b6: Cherry-pick 64bcd93cbc55.
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 6094b6c0b3c2a00d3d26d9ed1b4ba7f834f0a9a8 https://github.com/WebKit/WebKit/commit/6094b6c0b3c2a00d3d26d9ed1b4ba7f834f0a9a8 Author: Dan Robson Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A LayoutTests/storage/indexeddb/abort-index-rename-crash-expected.txt A LayoutTests/storage/indexeddb/abort-index-rename-crash.html M Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIndex.h M Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h Log Message: --- Cherry-pick 64bcd93cbc55. jsc_fuz/wktr: heap-use-after-free in WebCore::IDBServer::MemoryObjectStore::takeIndexByIdentifier(unsigned long long) MemoryObjectStore.cpp:128. https://bugs.webkit.org/show_bug.cgi?id=264180. rdar://117463447. Reviewed by Sihui Liu. MemoryIndex now keeps WeakPtr to MemoryObjectStore 'm_objectStore' and checks it's validity before using it. Also RefPtr conversion from WekPtr using get() API as applicable. * LayoutTests/storage/indexeddb/abort-index-rename-crash-expected.txt: Added the test expected file. * LayoutTests/storage/indexeddb/abort-index-rename-crash.html: Added the test case. * Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp: Checks the validity of MemoryObjectStore pointer before using. (WebCore::IDBServer::MemoryBackingStoreTransaction::objectStoreDeleted): (WebCore::IDBServer::MemoryBackingStoreTransaction::indexRenamed): (WebCore::IDBServer::MemoryBackingStoreTransaction::abort): * Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp: Changed direct reference to WeakPtr. Also used RefPtr conversion using get() API as applicable. (WebCore::IDBServer::MemoryIndex::objectStoreCleared): (WebCore::IDBServer::MemoryIndex::clearIndexValueStore): (WebCore::IDBServer::MemoryIndex::replaceIndexValueStore): (WebCore::IDBServer::MemoryIndex::getResultForKeyRange const): (WebCore::IDBServer::MemoryIndex::getAllRecords const): * Source/WebCore/Modules/indexeddb/server/MemoryIndex.h: Changed direct reference to WeakPtr. (WebCore::IDBServer::MemoryIndex::objectStore): * Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp: Used RefPtr conversion using get() API for MemoryIndex based MemoryObjectStore object. (WebCore::IDBServer::MemoryIndexCursor::currentData): * Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h: Canonical link: https://commits.webkit.org/267815.545@safari-7617-branch Identifier: 267815.546@safari-7617.1.17.10-branch Canonical link: https://commits.webkit.org/266719.149@webkitglib/2.42 Commit: f4cbd6103a089eb7886b4aec53aa788111adfeb8 https://github.com/WebKit/WebKit/commit/f4cbd6103a089eb7886b4aec53aa788111adfeb8 Author: Dan Robson Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/multicol/last-set-crash-expected.txt A LayoutTests/fast/multicol/last-set-crash.html M Source/WebCore/rendering/RenderMultiColumnFlow.cpp M Source/WebCore/rendering/RenderMultiColumnFlow.h Log Message: --- Cherry-pick f524a15d0633. https://bugs.webkit.org/show_bug.cgi?id=264327 WTFCrashWithSecurityImplication in WebCore::RenderFragmentedFlow::removeLineFragmentInfo() https://bugs.webkit.org/show_bug.cgi?id=264327 rdar://114559559 Reviewed by Alan Baradlay. * LayoutTests/TestExpectations: Skip test on debug due to some assertion failures. * LayoutTests/fast/multicol/last-set-crash-expected.txt: Added. * LayoutTests/fast/multicol/last-set-crash.html: Added. * Source/WebCore/rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::fragmentAtBlockOffset const): Tree mutations may have made m_lastSetWorkedOn cache invalid by moving the multicolumn set under a different multicolumn flow. Check for this. * Source/WebCore/rendering/RenderMultiColumnFlow.h: Also make it use WeakPtr. Canonical link: https://commits.webkit.org/267815.546@safari-7617-branch Identifier: 267815.547@safari-7617.1.17.10-branch Canonical link: https://commits.webkit.org/266719.150@webkitglib/2.42 Commit: 257bccb2532b64ea1b40023299c29053f891188b https://github.com/WebKit/WebKit/commit/257bccb2532b64ea1b40023299c29053f891188b Author: Myah Cobbs Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/loader/SubresourceLoader.cpp M Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp M Source/WebCore/loader/cache/CachedCSSStyleSheet.h Log Message: --- Cherry-pick 4c3430842100. https://bugs.webkit.org/show_bug.cgi?id=264979
[webkit-changes] [WebKit/WebKit] 2e312e: Test for "[WASM] ASSERTION FAILED: subRTT.has_valu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e312e1da48b80ea7a9da2539d556c3aecd015cf https://github.com/WebKit/WebKit/commit/2e312e1da48b80ea7a9da2539d556c3aecd015cf Author: Asumu Takikawa Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A JSTests/wasm/gc/bug258128.js Log Message: --- Test for "[WASM] ASSERTION FAILED: subRTT.has_value() && parentRTT.has_value() in JSC::Wasm::isSubtypeIndex(TypeIndex, TypeIndex)" https://bugs.webkit.org/show_bug.cgi?id=258128 Reviewed by Justin Michaud. Adds test for fixed bug. * JSTests/wasm/gc/bug258128.js: Added. (module): Canonical link: https://commits.webkit.org/271997@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79238b: REGRESSION(264666@main): Layout of the ele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79238bc8e2d67087ed83ed550931b4c76964aa2a https://github.com/WebKit/WebKit/commit/79238bc8e2d67087ed83ed550931b4c76964aa2a Author: Nikolas Zimmermann Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A LayoutTests/platform/glib/svg/text/textLength-tspan-in-textPath-expected.txt A LayoutTests/platform/ios/svg/text/textLength-tspan-in-textPath-expected.txt A LayoutTests/platform/mac/svg/text/textLength-tspan-in-textPath-expected.png A LayoutTests/platform/mac/svg/text/textLength-tspan-in-textPath-expected.txt A LayoutTests/svg/text/textLength-tspan-in-textPath.html M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp Log Message: --- REGRESSION(264666@main): Layout of the elements inside a is incorrect https://bugs.webkit.org/show_bug.cgi?id=264184 Reviewed by Said Abou-Hallawa. Revision 264666@main broke behavior on elements. The logic added to fix the intra-character spacing, wasn't intended for text path layout, where each character by definition is placed in its own box. Fix the MDN regression by disabling the new code paths for text-on-path layout. Covered by new test in svg/text/textLength-tspan-in-textPath.html. Unfortunately it's hard to make a cross-platform reftest, given the nature of the kind of test, and the missing way to layout text along a path in HTML/CSS. * LayoutTests/platform/glib/svg/text/textLength-tspan-in-textPath-expected.txt: Added. * LayoutTests/platform/ios/svg/text/textLength-tspan-in-textPath-expected.txt: Added. * LayoutTests/platform/mac/svg/text/textLength-tspan-in-textPath-expected.png: Added. * LayoutTests/platform/mac/svg/text/textLength-tspan-in-textPath-expected.txt: Added. * LayoutTests/svg/text/textLength-tspan-in-textPath.html: Added. * Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): Canonical link: https://commits.webkit.org/271996@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] efb0cb: [css-flex] Flex layout should not invalidate prefe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: efb0cb853cc0218e2a987af1a313ec360ea1419c https://github.com/WebKit/WebKit/commit/efb0cb853cc0218e2a987af1a313ec360ea1419c Author: Sammy Gill Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/nested-flex-image-loading-invalidates-intrinsic-sizes-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/nested-flex-image-loading-invalidates-intrinsic-sizes.html M Source/WebCore/rendering/RenderFlexibleBox.cpp Log Message: --- [css-flex] Flex layout should not invalidate preferred width bits of flex items at the end of layout. https://bugs.webkit.org/show_bug.cgi?id=264303 rdar://117181858 Reviewed by Alan Baradlay. In certain situations flex layout will invalidate the preferred widths bits of flex items towards the end of layout (in layoutAndPlaceChildren), with a call to updateBlockChildDirtyBitsBeforeLayout. This is incorrect since by the time we reach layoutAndPlaceChildren flex layout will not compute the preferred widths of these items again. This leaves the render tree in a bad state where we may compute the preferred widths of a flex item at some point during layout, dirty this bit later, and exit layout with this bit dirtied. In this state we may not be able to correctly invalidate the ancestor chain of a flex item in certain situations like in the added test case. When the image is loaded in the test case we will be unable to invalidate the preferred widths bits of its ancestor chain since the item had already been dirtied so we assume the rest of the chain has already been handled. Instead, we should be performing this type of invalidation in one of the following scenarios: 1.) The content of a flex item changes 2.) Certain style changes on the flex item that would impact the preferred widths computations of its items. One example of this is a flex item with an aspect ratio since the aspect ratio could impact its "content based minimum size," if the flexbox's cross size size changes in a specific way: https://drafts.csswg.org/css-flexbox-1/#content-based-minimum-size This patch focuses on correcting flex layout to more closely follow the principles in 2. updateFlexItemDirtyBitsBeforeLayout was added to replace the call to updateBlockChildDirtyBitsBeforeLayout so that we can continue to dirty flex items for layout without dirtying their preferred widths bits as well. Instead, in RenderFlexibleBox::styleDidChange we can call needsPreferredWidthsRecalculation on each flex item to determine if we should dirty the preferred widths bit of it. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/nested-flex-image-loading-invalidates-intrinsic-sizes-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/nested-flex-image-loading-invalidates-intrinsic-sizes.html: Added. * Source/WebCore/rendering/RenderFlexibleBox.cpp: (WebCore::updateFlexItemDirtyBitsBeforeLayout): (WebCore::RenderFlexibleBox::styleDidChange): (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Canonical link: https://commits.webkit.org/271995@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e64e4c: Rename resourceRequest to originalRequest in Navig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e64e4c46e67e6018c8b8cc1afe80fe05a6273e2a https://github.com/WebKit/WebKit/commit/e64e4c46e67e6018c8b8cc1afe80fe05a6273e2a Author: Sihui Liu Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/loader/NavigationAction.cpp M Source/WebCore/loader/NavigationAction.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp Log Message: --- Rename resourceRequest to originalRequest in NavigationAction https://bugs.webkit.org/show_bug.cgi?id=266054 rdar://119354060 Reviewed by Alex Christensen. The resourceRequest in NavigationAction is the original request of the action, which is not necessarily the ongoing or final request of the action (for example, server redirection will change request of the navigation), so this patch updates the name for clarity. * Source/WebCore/loader/NavigationAction.cpp: (WebCore::NavigationAction::NavigationAction): * Source/WebCore/loader/NavigationAction.h: (WebCore::NavigationAction::isEmpty const): (WebCore::NavigationAction::url const): (WebCore::NavigationAction::originalRequest const): (WebCore::NavigationAction::resourceRequest const): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): Canonical link: https://commits.webkit.org/271994@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d680c: [scroll-anchoring] YouTube.com jittering in commen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d680c19811737d2f07264bb02add5a612aca841 https://github.com/WebKit/WebKit/commit/7d680c19811737d2f07264bb02add5a612aca841 Author: Nikolaos Mouchtaris Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/focused-element-in-excluded-subtree-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/focused-element-in-excluded-subtree.html M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp Log Message: --- [scroll-anchoring] YouTube.com jittering in comments and Channel pages https://bugs.webkit.org/show_bug.cgi?id=266303 rdar://problem/119568843 Reviewed by Simon Fraser. We should check if a priority candidate is part of an excluded subtree before selecting it as our anchor node. * LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/focused-element-in-excluded-subtree-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/focused-element-in-excluded-subtree.html: Added. * Source/WebCore/page/scrolling/ScrollAnchoringController.cpp: (WebCore::ScrollAnchoringController::didFindPriorityCandidate): Canonical link: https://commits.webkit.org/271993@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 808b11: [Gardening]: REGRESSION (271863@main): [ macOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 808b11c3608efcd480aa6bea370a57ea5366a3a4 https://github.com/WebKit/WebKit/commit/808b11c3608efcd480aa6bea370a57ea5366a3a4 Author: Marta Darbinyan Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (271863@main): [ macOS iOS ] imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=266356 rdar://119621367 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/271992@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 77bc20: [ews-build.webkit.org] Declare macOS Monterey to b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 77bc20ab969bbf0357cc17607f20f037e4e3c0f0 https://github.com/WebKit/WebKit/commit/77bc20ab969bbf0357cc17607f20f037e4e3c0f0 Author: Jonathan Bedard Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/CISupport/ews-build/config.json Log Message: --- [ews-build.webkit.org] Declare macOS Monterey to be x86_64 architecture https://bugs.webkit.org/show_bug.cgi?id=266352 rdar://119618915 Reviewed by Elliott Williams. * Tools/CISupport/ews-build/config.json: Only build macOS Monterey for x86_64. Canonical link: https://commits.webkit.org/271991@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5db99: [build-webkit] Pass --architecture instead of ARCH...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5db997cee8a97d435eb0e886f8827ec3b2e59b2 https://github.com/WebKit/WebKit/commit/c5db997cee8a97d435eb0e886f8827ec3b2e59b2 Author: Jonathan Bedard Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/steps_unittest.py M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py Log Message: --- [build-webkit] Pass --architecture instead of ARCHS to build-webkit https://bugs.webkit.org/show_bug.cgi?id=266344 rdar://119617514 Reviewed by Elliott Williams. * Tools/CISupport/build-webkit-org/steps.py: (CompileWebKit.start): Use --architecture instead of ARCHS. * Tools/CISupport/build-webkit-org/steps_unittest.py: (TestCompileWebKit.test_success_architecture): Test that architecture is correctly set. * Tools/CISupport/ews-build/steps.py: (CompileWebKit.start): Use --architecture instead of ARCHS. * Tools/CISupport/ews-build/steps_unittest.py: (TestCompileWebKit.test_success_architecture): Test that architecture is correctly set. Canonical link: https://commits.webkit.org/271990@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0dd51c: [CSS] Fix @supports nested with declarations
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0dd51c9b2c6dbfba7603249bfb0f16abf4a9b2bd
https://github.com/WebKit/WebKit/commit/0dd51c9b2c6dbfba7603249bfb0f16abf4a9b2bd
Author: Matthieu Dubet
Date: 2023-12-13 (Wed, 13 Dec 2023)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048.html
M Source/WebCore/css/parser/CSSParserImpl.cpp
Log Message:
---
[CSS] Fix @supports nested with declarations
https://bugs.webkit.org/show_bug.cgi?id=259752
rdar://113652033
Reviewed by Antti Koivisto.
Unfortunately, the parser code use local member variables
(m_parsedProperties/m_parsedRules)
to store parsing results instead of using return values and the programming
language builtin stack.
This patch uses the existing stack mecanism
CSSParserImpl::runInNewNestingContext()
to isolate the parsing of the @supports(...) prelude declaration
from the rest of the parsing (specifically, from declarations before or after
this @supports rule at the same nesting level)
This fixes code like:
div {
color: green;
@supports() {
}
}
where the `color: green` declaration was being ignored.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-conditional/at-supports-048.html:
Added.
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::supportsDeclaration):
Canonical link: https://commits.webkit.org/271989@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3b432: REGRESSION (270691@main): test262 test/built-ins/T...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3b43220734e87c869665cd41a495586acf9e274 https://github.com/WebKit/WebKit/commit/d3b43220734e87c869665cd41a495586acf9e274 Author: Yijia Huang Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h Log Message: --- REGRESSION (270691@main): test262 test/built-ins/TypedArray/prototype/sort/sort-tonumber.js: Underlying ArrayBuffer has been detached from the view or out-of-bounds https://bugs.webkit.org/show_bug.cgi?id=266245 rdar://119506259 Reviewed by Yusuke Suzuki. There is no need to to check detached buffer and throw TypeError after comparator function being executed for %TypedArray%.prototype.sort. See steps 6-10 in [1]. [1] https://tc39.es/ecma262/#sec-%typedarray%.prototype.sort * Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h: (JSC::validateTypedArray): * Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h: (JSC::genericTypedArrayViewProtoFuncSortImpl): (JSC::genericTypedArrayViewProtoFuncSort): Canonical link: https://commits.webkit.org/271988@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b75950: Port WebCore::FilterFunction to the new IPC serial...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b75950841cfe38e8cca6f30196545ad0127199a0 https://github.com/WebKit/WebKit/commit/b75950841cfe38e8cca6f30196545ad0127199a0 Author: Chris Dumez Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/filters/FEBlend.h M Source/WebCore/platform/graphics/filters/FEColorMatrix.h M Source/WebCore/platform/graphics/filters/FEComponentTransfer.h M Source/WebCore/platform/graphics/filters/FEComposite.h M Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h M Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h M Source/WebCore/platform/graphics/filters/FEDisplacementMap.h M Source/WebCore/platform/graphics/filters/FEDropShadow.h M Source/WebCore/platform/graphics/filters/FEFlood.h M Source/WebCore/platform/graphics/filters/FEGaussianBlur.h M Source/WebCore/platform/graphics/filters/FEImage.h M Source/WebCore/platform/graphics/filters/FEMerge.h M Source/WebCore/platform/graphics/filters/FEMorphology.h M Source/WebCore/platform/graphics/filters/FEOffset.h M Source/WebCore/platform/graphics/filters/FESpecularLighting.h M Source/WebCore/platform/graphics/filters/FETile.h M Source/WebCore/platform/graphics/filters/FETurbulence.h M Source/WebCore/platform/graphics/filters/FilterEffect.h M Source/WebCore/platform/graphics/filters/FilterFunction.h M Source/WebCore/platform/graphics/filters/SourceAlpha.h M Source/WebCore/platform/graphics/filters/SourceGraphic.h M Source/WebCore/rendering/CSSFilter.h M Source/WebCore/svg/graphics/filters/SVGFilter.h M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port WebCore::FilterFunction to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266116 Reviewed by Brady Eidson. * Source/WebCore/platform/graphics/filters/FEBlend.h: * Source/WebCore/platform/graphics/filters/FEColorMatrix.h: * Source/WebCore/platform/graphics/filters/FEComponentTransfer.h: * Source/WebCore/platform/graphics/filters/FEComposite.h: * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h: * Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h: * Source/WebCore/platform/graphics/filters/FEDisplacementMap.h: * Source/WebCore/platform/graphics/filters/FEDropShadow.h: * Source/WebCore/platform/graphics/filters/FEFlood.h: * Source/WebCore/platform/graphics/filters/FEGaussianBlur.h: * Source/WebCore/platform/graphics/filters/FEImage.h: * Source/WebCore/platform/graphics/filters/FEMerge.h: * Source/WebCore/platform/graphics/filters/FEMorphology.h: * Source/WebCore/platform/graphics/filters/FEOffset.h: * Source/WebCore/platform/graphics/filters/FESpecularLighting.h: * Source/WebCore/platform/graphics/filters/FETile.h: * Source/WebCore/platform/graphics/filters/FETurbulence.h: * Source/WebCore/platform/graphics/filters/FilterEffect.h: * Source/WebCore/platform/graphics/filters/FilterFunction.h: * Source/WebCore/platform/graphics/filters/SourceAlpha.h: * Source/WebCore/platform/graphics/filters/SourceGraphic.h: * Source/WebCore/rendering/CSSFilter.h: (isType): Deleted. * Source/WebCore/svg/graphics/filters/SVGFilter.h: (isType): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271987@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f36572: [build-webkit] Add --architecture argument
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f365728120173dcc6b3c786bc1b70b2fd6c55730 https://github.com/WebKit/WebKit/commit/f365728120173dcc6b3c786bc1b70b2fd6c55730 Author: Jonathan Bedard Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/Scripts/build-webkit M Tools/Scripts/webkitdirs.pm Log Message: --- [build-webkit] Add --architecture argument https://bugs.webkit.org/show_bug.cgi?id=266342 rdar://119615600 Reviewed by Ryan Haddad. Add a '--architecture' argument to 'build-webkit' which allows the caller to override the architecutre used by 'build-webkit', and appropriately sets 'ONLY_ACTIVE_ARCH=NO' if '--architecture' is specified. * Tools/Scripts/build-webkit: Add documentation of '--architecture' option. * Tools/Scripts/webkitdirs.pm: (determineArchitecture): Parse the '--architecture' option and set didUserSpecifyArchitecture. (XcodeOptions): Set ONLY_ACTIVE_ARCH=NO if '--architecutre' was passed. Canonical link: https://commits.webkit.org/271986@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 816628: [ews] macOS tester queues are failing to download ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81662800f1e4176871b60575e891194c1debe327 https://github.com/WebKit/WebKit/commit/81662800f1e4176871b60575e891194c1debe327 Author: Aakash Jain Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Tools/CISupport/ews-build/config.json Log Message: --- [ews] macOS tester queues are failing to download archives https://bugs.webkit.org/show_bug.cgi?id=266339 Reviewed by Jonathan Bedard and Ryan Haddad. We do not need to explicitly state the architecture in triggered queues, they automatically get it from the parent queue through the trigger step. It is better to let it be handled automatically, so that when we change architecture for builder queues, tester queues get it automatically. * Tools/CISupport/ews-build/config.json: Canonical link: https://commits.webkit.org/271985@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38f5a8: Unreviewed, reverting 271900@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38f5a8729c778af95eb5804758346a62ec0970d8 https://github.com/WebKit/WebKit/commit/38f5a8729c778af95eb5804758346a62ec0970d8 Author: Commit Queue Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Unreviewed, reverting 271900@main. https://bugs.webkit.org/show_bug.cgi?id=266340 Reland 271784@main Reverted changeset: "Unreviewed, reverting 271784@main." https://bugs.webkit.org/show_bug.cgi?id=266252 https://commits.webkit.org/271900@main Canonical link: https://commits.webkit.org/271984@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d6f50: Make JSC stress tests CLoop aware.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d6f500cb8b4c840a8eb76305c2ae7c0ec75af59 https://github.com/WebKit/WebKit/commit/4d6f500cb8b4c840a8eb76305c2ae7c0ec75af59 Author: Mark Lam Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M JSTests/stress/codeblock-destructor-access-unlinkedcodeblock.js M Tools/Scripts/run-javascriptcore-tests M Tools/Scripts/run-jsc-stress-tests Log Message: --- Make JSC stress tests CLoop aware. https://bugs.webkit.org/show_bug.cgi?id=266336 rdar://119612009 Reviewed by Justin Michaud. Add a --cloop option to run-javascriptcore-tests and run-jsc-stress-tests. This should be used when running the JSC tests on a CLoop build. --cloop automatically implies --no-jit. Skip JIT tests and Wasm tests when running cloop. Also skip JSTests/stress/codeblock-destructor-access-unlinkedcodeblock.js when running CLoop. It is too slow for CLoop builds. * JSTests/stress/codeblock-destructor-access-unlinkedcodeblock.js: * Tools/Scripts/run-javascriptcore-tests: (runJSCStressTests): * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/271983@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c56da: Speed up use of WeakPtr with EventTarget objects (...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c56da25ced28ccc63d3d4e45c4f8451c1c67e5e https://github.com/WebKit/WebKit/commit/4c56da25ced28ccc63d3d4e45c4f8451c1c67e5e Author: Chris Dumez Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/Modules/cookie-store/CookieStore.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.h M Source/WebCore/Modules/permissions/MainThreadPermissionObserver.cpp M Source/WebCore/Modules/permissions/MainThreadPermissionObserver.h M Source/WebCore/Modules/permissions/PermissionStatus.cpp M Source/WebCore/Modules/permissions/PermissionStatus.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h M Source/WebCore/dom/BroadcastChannel.cpp M Source/WebCore/dom/EventTarget.h M Source/WebCore/dom/MessagePort.cpp M Source/WebCore/dom/MessagePort.h M Source/WebCore/html/OffscreenCanvas.h Log Message: --- Speed up use of WeakPtr with EventTarget objects (such as Node) https://bugs.webkit.org/show_bug.cgi?id=265878 Reviewed by Darin Adler. Speed up use of WeakPtr with EventTarget objects (such as Node) by using a single thread ref count instead of ThreadSafeRefCounted for the WeakPtr implementation object, like we did for RenderObjects. Most of the EventTarget didn't need a thread-safe WeakPtr impl. For the subclasses that did, I either: - Updated the logic to avoid ref'ing / deref'ing the WeakPtr on a different thread. - Had the subclass inherit ThreadSafeRefCountedAndCanMakeThreadSafeWeakPtr and used ThreadSafeWeakPtr instead of WeakPtr. This tested as a small Speedometer progression (~0.3% on M1 with 98% confidence). More importantly, this will help us convert more CheckedPtr into WeakPtr without hurting performance. * Source/WebCore/Modules/cookie-store/CookieStore.cpp: (WebCore::CookieStore::MainThreadBridge::detach): (WebCore::CookieStore::~CookieStore): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: (WebCore::processFrame): (WebCore::RTCRtpSFrameTransform::initializeTransformer): (WebCore::transformFrame): (WebCore::RTCRtpSFrameTransform::createStreams): * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.h: * Source/WebCore/Modules/permissions/MainThreadPermissionObserver.cpp: (WebCore::MainThreadPermissionObserver::MainThreadPermissionObserver): (WebCore::MainThreadPermissionObserver::stateChanged): * Source/WebCore/Modules/permissions/MainThreadPermissionObserver.h: * Source/WebCore/Modules/permissions/PermissionStatus.cpp: (WebCore::PermissionStatus::PermissionStatus): (WebCore::PermissionStatus::virtualHasPendingActivity const): * Source/WebCore/Modules/permissions/PermissionStatus.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::WebCodecsAudioDecoder::configure): * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::WebCodecsAudioEncoder::configure): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: (WebCore::WebCodecsVideoDecoder::configure): * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.h: * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: (WebCore::WebCodecsVideoEncoder::configure): (WebCore::WebCodecsVideoEncoder::encode): (WebCore::WebCodecsVideoEncoder::flush): * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.h: * Source/WebCore/dom/BroadcastChannel.cpp: (WebCore::BroadcastChannel::MainThreadBridge::detach): (WebCore::BroadcastChannel::~BroadcastChannel): * Source/WebCore/dom/EventTarget.h: * Source/WebCore/dom/MessagePort.cpp: (WebCore::WTF_REQUIRES_LOCK): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::ref const): Deleted. (WebCore::MessagePort::deref const): Deleted. * Source/WebCore/dom/MessagePort.h: * Source/WebCore/html/OffscreenCanvas.h: Canonical link: https://commits.webkit.org/271982@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31ed84: Unreviewed, reverting 271948@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31ed84288fae42106c5664f44aeca0c748b18a11 https://github.com/WebKit/WebKit/commit/31ed84288fae42106c5664f44aeca0c748b18a11 Author: Commit Queue Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebKit/Platform/IPC/ArgumentCoders.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.h M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Source/WebKit/Shared/Cocoa/CoreIPCAVOutputContext.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCArray.h M Source/WebKit/Shared/Cocoa/CoreIPCArray.mm M Source/WebKit/Shared/Cocoa/CoreIPCArray.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCCFType.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCColor.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCContacts.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCDDActionContext.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCDDScannerResult.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCDate.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.h M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.mm M Source/WebKit/Shared/Cocoa/CoreIPCDictionary.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCFont.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCLocale.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.h M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.mm M Source/WebKit/Shared/Cocoa/CoreIPCNSCFObject.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCString.serialization.in M Source/WebKit/Shared/Cocoa/CoreIPCURL.h M Source/WebKit/Shared/Cocoa/CoreIPCURL.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/cf/ArgumentCodersCF.cpp M Source/WebKit/Shared/cf/ArgumentCodersCF.h M Source/WebKit/Shared/cf/CFTypes.serialization.in M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm Log Message: --- Unreviewed, reverting 271948@main. https://bugs.webkit.org/show_bug.cgi?id=266338 Caused a massive memory and page load time regression Reverted changeset: "Use existing Array/Date/Dictionary/URL wrappers for their CF types" https://bugs.webkit.org/show_bug.cgi?id=266288 https://commits.webkit.org/271948@main Canonical link: https://commits.webkit.org/271981@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4b989: [IFC][Ruby] Fix fast/ruby/bopomofo-rl.html
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4b989cedbce1e46b64ab0a6f7726aedacf9a9f0 https://github.com/WebKit/WebKit/commit/b4b989cedbce1e46b64ab0a6f7726aedacf9a9f0 Author: Alan Baradlay Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h Log Message: --- [IFC][Ruby] Fix fast/ruby/bopomofo-rl.html https://bugs.webkit.org/show_bug.cgi?id=266335 Reviewed by Antti Koivisto. Annotation box alignment should follow ruby base alignment flow: 1. run justify alignment after line breaking (using Line::Runs) 2. offset justified runs (space-around) during display content building * Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp: (WebCore::Layout::InlineContentAligner::applyRubyAnnotationAlignmentOffset): (WebCore::Layout::InlineContentAligner::applyRubyAlignOnAnnotationBox): Deleted. * Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.h: * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::layoutInlineContent): (WebCore::Layout::LineBuilder::placeInlineAndFloatContent): * Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processRubyContent): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::applyRubyAlignOnAnnotationBox): (WebCore::Layout::RubyFormattingContext::applyAnnotationAlignmentOffset): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h: Canonical link: https://commits.webkit.org/271980@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfd107: REGRESSION(271819@main): Build fails due to undecl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfd1072e60148eabe7a9f8dc2ea692f4321fb6f9 https://github.com/WebKit/WebKit/commit/cfd1072e60148eabe7a9f8dc2ea692f4321fb6f9 Author: Adrian Perez de Castro Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/JavaScriptCore/bytecode/InlineCallFrameSet.h Log Message: --- REGRESSION(271819@main): Build fails due to undeclared identifier InlineCallFrameMalloc https://bugs.webkit.org/show_bug.cgi?id=266331 Reviewed by Justin Michaud. * Source/JavaScriptCore/bytecode/InlineCallFrameSet.h: Remove usage of InlineCallFrameMalloc, which is not defined anywhere. Canonical link: https://commits.webkit.org/271979@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d36e7: [IFC][Ruby] Fix fast/ruby/ruby-expansion-cjk-4.html
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d36e7f1415f2e0f3ee726d8ac784a8c7ac191b1 https://github.com/WebKit/WebKit/commit/7d36e7f1415f2e0f3ee726d8ac784a8c7ac191b1 Author: Alan Baradlay Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp Log Message: --- [IFC][Ruby] Fix fast/ruby/ruby-expansion-cjk-4.html https://bugs.webkit.org/show_bug.cgi?id=266308 Reviewed by Antti Koivisto. This change fixes nested ruby bases (e.g. baseannotationnested base...) where the nested base would not get aligned properly. * Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp: (WebCore::Layout::shiftRubyBaseContentByAlignmentOffset): pass up the accumulated offset to the parent ruby. (WebCore::Layout::InlineContentAligner::applyRubyBaseAlignmentOffset): * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::applyRubyAlignOnBaseContent): do not skip nested ruby bases. Canonical link: https://commits.webkit.org/271978@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 614099: [GStreamer] ASSERTION FAILED: !HashTranslator::equ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 614099ee0c66874843bf378aa7b61e340b8f8c11 https://github.com/WebKit/WebKit/commit/614099ee0c66874843bf378aa7b61e340b8f8c11 Author: Vitaly Dyachkov Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) https://bugs.webkit.org/show_bug.cgi?id=266333 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/271977@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cc92b: GraphicsContext::drawNativeImage has redundant ima...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cc92b72254026fac7ef2f8dfe91745a43ec986d https://github.com/WebKit/WebKit/commit/8cc92b72254026fac7ef2f8dfe91745a43ec986d Author: Kimmo Kinnunen Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h M Source/WebCore/platform/graphics/BitmapImage.cpp M Source/WebCore/platform/graphics/GraphicsContext.cpp M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/GraphicsContextGL.cpp M Source/WebCore/platform/graphics/NativeImage.h M Source/WebCore/platform/graphics/NullGraphicsContext.h M Source/WebCore/platform/graphics/SourceImage.cpp M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h M Source/WebCore/platform/graphics/cairo/NativeImageCairo.cpp M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/GraphicsContextCG.h M Source/WebCore/platform/graphics/cg/NativeImageCG.cpp M Source/WebCore/platform/graphics/cocoa/IconCocoa.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm M Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp M Source/WebCore/platform/graphics/cv/VideoFrameCV.mm M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp M Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h M Source/WebCore/platform/graphics/filters/software/FEImageSoftwareApplier.cpp M Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp M Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp M Source/WebKit/Shared/API/c/cg/WKImageCG.cpp M Source/WebKit/Shared/DisplayListArgumentCoders.serialization.in M Source/WebKit/Shared/ShareableBitmap.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm M Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp M Tools/TestWebKitAPI/Tests/WebCore/cg/GraphicsContextCGTests.mm Log Message: --- GraphicsContext::drawNativeImage has redundant imageSize parameter https://bugs.webkit.org/show_bug.cgi?id=266279 rdar://119551804 Reviewed by Matt Woodrow. NativeImage knows its size. The GraphicsContext::drawNativeImage has FloatRect sourceRect parameter to define the portion of the full size to use. The IntRect imageSize is probably a legacy argument used for partial images before sourceRect was introduced. All callsites but one use the full NativeImage size as the imageSize. The only non-full image draw in BitmapImage uses the same rect as the source rect. The function can be further simplified, but to make this patch easier to review make minimal compatible changes to GraphicsContextCG::drawNativeImageInternal. * Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp: (WebCore::WebGPU::GPUImpl::paintToCanvas): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::videoFrameToImage): * Source/WebCore/platform/graphics/BifurcatedGraph
[webkit-changes] [WebKit/WebKit] 8cac4a: [MSE] Remove MANAGED_MEDIA_SOURCE guards
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cac4a32fbd675549de8ac52eed6b4d5c7125ac5 https://github.com/WebKit/WebKit/commit/8cac4a32fbd675549de8ac52eed6b4d5c7125ac5 Author: Philippe Normand Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp M Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp M Source/WebCore/Modules/mediasource/BufferedChangeEvent.h M Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl M Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp M Source/WebCore/Modules/mediasource/ManagedMediaSource.h M Source/WebCore/Modules/mediasource/ManagedMediaSource.idl M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.cpp M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.h M Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl M Source/WebCore/Modules/mediasource/MediaSource.cpp M Source/WebCore/Modules/mediasource/MediaSource.h M Source/WebCore/Modules/mediasource/SourceBuffer.cpp M Source/WebCore/Modules/mediasource/SourceBuffer.h M Source/WebCore/bindings/js/JSMediaSourceCustom.cpp M Source/WebCore/bindings/js/JSSourceBufferCustom.cpp M Source/WebCore/dom/EventNames.in M Source/WebCore/dom/EventTargetFactory.in M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp M Source/WebKit/Shared/WebPreferencesDefaultValues.h M Source/cmake/GStreamerDefinitions.cmake M Source/cmake/OptionsMac.cmake M Source/cmake/WebKitFeatures.cmake M Tools/Scripts/webkitperl/FeatureList.pm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm Log Message: --- [MSE] Remove MANAGED_MEDIA_SOURCE guards https://bugs.webkit.org/show_bug.cgi?id=266174 Reviewed by Jean-Yves Avenard and Xabier Rodriguez-Calvar. The build with MANAGED_MEDIA_SOURCE disabled was unfixable. ManagedMediaSource is soon going to be merged in the MSE spec, so there is no reason to keep those build guards. The runtime preference is kept though. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::sourceType const): * Source/WebCore/Modules/mediasource/BufferedChangeEvent.cpp: * Source/WebCore/Modules/mediasource/BufferedChangeEvent.h: * Source/WebCore/Modules/mediasource/BufferedChangeEvent.idl: * Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp: * Source/WebCore/Modules/mediasource/ManagedMediaSource.h: * Source/WebCore/Modules/mediasource/ManagedMediaSource.idl: * Source/WebCore/Modules/mediasource/ManagedSourceBuffer.cpp: * Source/WebCore/Modules/mediasource/ManagedSourceBuffer.h: * Source/WebCore/Modules/mediasource/ManagedSourceBuffer.idl: * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::addSourceBuffer): (WebCore::MediaSource::memoryPressure): * Source/WebCore/Modules/mediasource/MediaSource.h: * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::sourceBufferPrivateBufferedChanged): (WebCore::SourceBuffer::memoryPressure): * Source/WebCore/Modules/mediasource/SourceBuffer.h: * Source/WebCore/bindings/js/JSMediaSourceCustom.cpp: (WebCore::toJSNewlyCreated): * Source/WebCore/bindings/js/JSSourceBufferCustom.cpp: (WebCore::toJSNewlyCreated): * Source/WebCore/dom/EventNames.in: * Source/WebCore/dom/EventTargetFactory.in: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::hasManagedMediaSource const): (WebCore::HTMLMediaElement::mediaState const): (WebCore::HTMLMediaElement::setBufferingPolicy): (WebCore::HTMLMediaElement::purgeBufferedDataIfPossible): * Source/WebKit/Shared/WebPreferencesDefaultValues.cpp: * Source/WebKit/Shared/WebPreferencesDefaultValues.h: * Source/cmake/GStreamerDefinitions.cmake: * Source/cmake/OptionsMac.cmake: * Source/cmake/WebKitFeatures.cmake: * Tools/Scripts/webkitperl/FeatureList.pm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPageHasMediaStreamingActivity.mm: Canonical link: https://commits.webkit.org/271975@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 601843: Make `WriteRichTextDataWhenCopyingOrDragging` defa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60184379683caa98c767e52cda3a3179955692e2 https://github.com/WebKit/WebKit/commit/60184379683caa98c767e52cda3a3179955692e2 Author: Wenson Hsieh Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/Shared/WebPreferencesDefaultValues.h M Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm Log Message: --- Make `WriteRichTextDataWhenCopyingOrDragging` default to async text input enablement https://bugs.webkit.org/show_bug.cgi?id=266321 Reviewed by Megan Gardner and Abrar Rahman Protyasha. Make `UIKit/async_text_input` enablement state also influence whether or not we attempt to write RTF/attributed string data to the pasteboard when copying or dragging. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/Shared/WebPreferencesDefaultValues.h: * Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::defaultWriteRichTextDataWhenCopyingOrDragging): Canonical link: https://commits.webkit.org/271974@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23553b: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23553be8043a0b4d102a6b32cc58ba4a1b4c925e https://github.com/WebKit/WebKit/commit/23553be8043a0b4d102a6b32cc58ba4a1b4c925e Author: Fujii Hironori Date: 2023-12-13 (Wed, 13 Dec 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/271973@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
