[webkit-changes] [WebKit/WebKit] 44d1da: Building gtest causes a warning related to CFBundl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44d1da6908643128a74d810b046e68cc01843fc5 https://github.com/WebKit/WebKit/commit/44d1da6908643128a74d810b046e68cc01843fc5 Author: Kimmo Kinnunen Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/ThirdParty/gtest/xcode/Config/General.xcconfig M Source/ThirdParty/gtest/xcode/Resources/Info.plist Log Message: --- Building gtest causes a warning related to CFBundleIdentifier https://bugs.webkit.org/show_bug.cgi?id=266404 rdar://119660379 Reviewed by Elliott Williams. warning: User-supplied CFBundleIdentifier value 'com.google.gtest' in the Info.plist must be the same as the PRODUCT_BUNDLE_IDENTIFIER build setting value ''. Add the bundle identifier to the build configuration and use it in Info.plist. * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/gtest/xcode/Resources/Info.plist: Canonical link: https://commits.webkit.org/272097@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bb617: Add ShadowRoot clonable attribute
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bb617ff68ef4a758e79ee85f5bea77e220f015f https://github.com/WebKit/WebKit/commit/9bb617ff68ef4a758e79ee85f5bea77e220f015f Author: Ryosuke Niwa Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/fast/shadow-dom/cloneable-shadow-root.html M Source/WebCore/dom/ShadowRoot.idl Log Message: --- Add ShadowRoot clonable attribute https://bugs.webkit.org/show_bug.cgi?id=266227 Reviewed by Chris Dumez. Added the attribute proposed in https://github.com/whatwg/dom/pull/1237. * LayoutTests/fast/shadow-dom/cloneable-shadow-root.html: * Source/WebCore/dom/ShadowRoot.idl: Canonical link: https://commits.webkit.org/272096@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 470d68: Stop using CheckedRef with TypingCommand
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 470d68747cd2cf75a4e31a301ba0678aed4820a9 https://github.com/WebKit/WebKit/commit/470d68747cd2cf75a4e31a301ba0678aed4820a9 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/editing/TypingCommand.cpp M Source/WebCore/editing/TypingCommand.h Log Message: --- Stop using CheckedRef with TypingCommand https://bugs.webkit.org/show_bug.cgi?id=266457 Reviewed by Ryosuke Niwa. Stop using CheckedRef with TypingCommand. Use WeakRef instead to make crashes more actionable. * Source/WebCore/editing/TypingCommand.cpp: * Source/WebCore/editing/TypingCommand.h: Canonical link: https://commits.webkit.org/272095@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1251f3: Stop using CheckedPtr with MessagePortChannel
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1251f3ceb887a017ea8cccdf388cebe51e66a7c6 https://github.com/WebKit/WebKit/commit/1251f3ceb887a017ea8cccdf388cebe51e66a7c6 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WTF/wtf/WeakRef.h M Source/WebCore/dom/messageports/MessagePortChannel.h M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h Log Message: --- Stop using CheckedPtr with MessagePortChannel https://bugs.webkit.org/show_bug.cgi?id=266451 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with MessagePortChannel. Use WeakPtr instead to generate more actionable crashes. * Source/WTF/wtf/WeakRef.h: (WTF::WeakRef::ptrAllowingHashTableEmptyValue const): * Source/WebCore/dom/messageports/MessagePortChannel.h: * Source/WebCore/dom/messageports/MessagePortChannelRegistry.h: Canonical link: https://commits.webkit.org/272094@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bfda1: Mitigate crashes under Quirks::advancedPrivacyProt...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1bfda19669abc863671034e16c5808ae0bacf848
https://github.com/WebKit/WebKit/commit/1bfda19669abc863671034e16c5808ae0bacf848
Author: Wenson Hsieh
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
M Source/WebCore/page/Quirks.cpp
Log Message:
---
Mitigate crashes under
Quirks::advancedPrivacyProtectionSubstituteDataURLForScriptWithFeatures()
https://bugs.webkit.org/show_bug.cgi?id=266380
rdar://118479646
Reviewed by Yusuke Suzuki.
Even after the mitigations in 269984@main, we're still sometimes crashing when
attempting to
determine whether or not we should apply hard-coded canvas fingerprinting
mitigations when advanced
privacy protections are enabled. From discussing with JSC folks, this seems to
be due to the way in
which we're currently trying to walk the stack by traversing `callerFrame()`s:
```
while (!codeBlock) {
callFrame = callFrame->callerFrame();
if (!callFrame)
break;
codeBlock = callFrame->codeBlock();
}
```
Instead of implementing it this way, the JSC team recommended using
`StackVisitor::visit` instead to
walk the stack, which is the de-facto mechanism used to perform similar stack
traversals elsewhere
in the codebase. In addition, I'm also rearranging this check, so that we only
ever attempt this
relatively more expensive stack walk in the case where the `lastDrawnText`,
`canvasWidth` and
`canvasHeight` all match their expected values for the quirk.
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::advancedPrivacyProtectionSubstituteDataURLForScriptWithFeatures
const):
In my manual testing, I found that the source code length on some of the
affected sites has been
changed slightly; adjust this quirk to match.
Canonical link: https://commits.webkit.org/272093@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a28659: [WebGPU] CTS validation/debugMarker test does not ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a286596dc032931aa847f49664c70082632aecf6 https://github.com/WebKit/WebKit/commit/a286596dc032931aa847f49664c70082632aecf6 Author: Mike Wyrzykowski Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/http/tests/webgpu/webgpu/api/validation/debugMarker-expected.txt M Source/WebGPU/WebGPU/CommandEncoder.h M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/ComputePassEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- [WebGPU] CTS validation/debugMarker test does not pass https://bugs.webkit.org/show_bug.cgi?id=266420 Reviewed by Dan Glastonbury. Correct validation for debugMarkers and add passing expectations. * LayoutTests/http/tests/webgpu/webgpu/api/validation/debugMarker-expected.txt: * Source/WebGPU/WebGPU/CommandEncoder.h: (WebGPU::CommandEncoder::makeInvalid): * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::validateFinish const): * Source/WebGPU/WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::endPass): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::endPass): Canonical link: https://commits.webkit.org/272092@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aac4cb: ARM64EHash should be using the PAC DA key instead ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aac4cb050d4e9641f427de285f145034c317456f
https://github.com/WebKit/WebKit/commit/aac4cb050d4e9641f427de285f145034c317456f
Author: Mark Lam
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
M Source/JavaScriptCore/assembler/AssemblerBuffer.h
M Source/WTF/wtf/PtrTag.h
Log Message:
---
ARM64EHash should be using the PAC DA key instead of DB.
https://bugs.webkit.org/show_bug.cgi?id=262938
rdar://116679398
Reviewed by Justin Michaud.
Currently, it uses the PAC DB key. However, the PAC DB key is already used by
for the
PACCage for protecting TypedArray vector pointers. Using the PAC DA key
instead would
ensure that there is no collision between the "namespace"s of PACCage pointers
and
ARM64EHash intermediate values.
* Source/JavaScriptCore/assembler/AssemblerBuffer.h:
(JSC::ARM64EHash::nextValue):
(JSC::ARM64EHash::currentHash):
(JSC::ARM64EHash::setUpdatedHash):
* Source/WTF/wtf/PtrTag.h:
(WTF::untagInt):
(WTF::tagInt):
Originally-landed-as: 267815.228@safari-7617-branch (4eda4ebd52c1).
rdar://11959
Canonical link: https://commits.webkit.org/272087@main
Commit: 3a900e192fe7c22dccc007fde344d3a373476175
https://github.com/WebKit/WebKit/commit/3a900e192fe7c22dccc007fde344d3a373476175
Author: Mark Lam
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
M LayoutTests/fast/storage/serialized-script-value.html
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
Log Message:
---
An Array index in CloneSerializer and CloneDeserializer can be confused for
NonIndexPropertiesTag.
https://bugs.webkit.org/show_bug.cgi?id=262616
rdar://116034413
Reviewed by Keith Miller, Sihui Liu and Chris Dumez.
CloneSerializer and CloneDeserializer were previously using
NonIndexPropertiesTag as the terminator of
the indexed property section of an Array. However, NonIndexPropertiesTag's
encoding is 0xFFFD,
which is less than MAX_ARRAY_INDEX (0xFFFE) i.e. an index of 0xFFFD can
be confused for the
NonIndexPropertiesTag, resulting type confusion.
This patch changes the structure of a serialized Array to always terminate its
indexed property section
with a TerminatorTag (0x) first before looking for either a
NonIndexPropertiesTag or another
TerminatorTag. The presence of a NonIndexPropertiesTag after the 1st
TerminatorTag indicates the
presence of a non-indexed properties section. The presense of a TerminatorTag
immediately after the
1st TerminatorTag indicates that the non-indexed properties section is empty.
Also updated the comment describing the shape of a serialized Array, and
rebased a test.
* LayoutTests/fast/storage/serialized-script-value.html:
* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):
Originally-landed-as: 267815.202@safari-7617-branch (401705903095).
rdar://119592509
Canonical link: https://commits.webkit.org/272088@main
Commit: 71fb0a3d44470a2bd8bcfe161c2e3ba71577f090
https://github.com/WebKit/WebKit/commit/71fb0a3d44470a2bd8bcfe161c2e3ba71577f090
Author: Nisha Jain
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
A LayoutTests/cssom/crash-font-family-invalid-expected.html
A LayoutTests/cssom/crash-font-family-invalid.html
M Source/WebCore/style/StyleBuilderCustom.h
Log Message:
---
jsc_fuz/wktr: segfault with .attributeStyleMap.set('font-family', new
CSSKeywordValue('x'))
https://bugs.webkit.org/show_bug.cgi?id=262487
rdar://115283280
Reviewed by Chris Dumez.
Invalid CSS value for CSS "Font-family" property has to be handled by returning
instead of causing ASSERT.
Test: cssom/crash-font-family-invalid.html
* Source/WebCore/style/StyleBuilderCustom.h:
(BuilderCustom::applyValueFontFamily) : Replaced 'ASSERT' with 'return' while
handling "Font-family" property.
* LayoutTests/cssom/crash-font-family-invalid-expected.html: Added test case
expected file.
* LayoutTests/cssom/crash-font-family-invalid.html: Added test case.
Originally-landed-as: 267815.169@safari-7617-branch (6834321e777d).
rdar://119592492
Canonical link: https://commits.webkit.org/272089@main
Commit: f97d0403a8c4581558a9fd80424f4c404f090f19
https://github.com/WebKit/WebKit/commit/f97d0403a8c4581558a9fd80424f4c404f090f19
Author: Alan Baradlay
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
A LayoutTests/fast/text/hyphen-with-overflowing-out-of-flow-expected.txt
A LayoutTests/fast/text/hyphen-with-overflowing-out-of-flow.html
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
Log Message:
---
[IFC] An opaque inline item should never be an overflowing run candidate
https://bugs.webkit.org/show_bug.cgi?id=262341
Reviewed by Simon Fraser.
An opaque inline item (e.g. out-of-flow box) should never be considered as the
[webkit-changes] [WebKit/WebKit] cb966f: Notify the WebExtensionsController when a provisio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb966fb5714c81e8ee1cf2c7128f7aebaed507e5 https://github.com/WebKit/WebKit/commit/cb966fb5714c81e8ee1cf2c7128f7aebaed507e5 Author: Brian Weinstein Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm Log Message: --- Notify the WebExtensionsController when a provisional load fails for a frame https://bugs.webkit.org/show_bug.cgi?id=266444 Reviewed by Alex Christensen. This patch also adds a test verifying this behavior. * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::dispatchDidFailProvisionalLoad): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebNavigation.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272086@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf2a98: REGRESSION(261003@main): [css-contain][css-grid] S...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf2a9868136a77126003c51af66e7e1b13220ae4 https://github.com/WebKit/WebKit/commit/cf2a9868136a77126003c51af66e7e1b13220ae4 Author: Sammy Gill Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-stretches-auto-rows-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-stretches-auto-rows.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-stretches-auto-rows-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-stretches-auto-rows.html M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp Log Message: --- REGRESSION(261003@main): [css-contain][css-grid] Size containment is not allowing the track sizing algorithm to distribute extra space to auto tracks https://bugs.webkit.org/show_bug.cgi?id=260201 rdar://problem/113915953 Reviewed by Brent Fulgham. Size containment is supposed to size a box as if it had no content, so for the purposes of grid layout this would mean that we would want to skip parts of the algorithm that take into consideration the content. The "Stretch auto Tracks," portion of the grid track sizing algorithm should not be skipped, however, as it has nothing to do with the content of the grid. We should be able to distribute any definite free space that we computed up to this point. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-stretches-auto-rows-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-grid-stretches-auto-rows.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-stretches-auto-rows-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-size-grid-stretches-auto-rows.html: Added. * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::run): Canonical link: https://commits.webkit.org/272085@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c025b: REGRESSION (268616@main): No context menu preview ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c025b25b577af2f5489f1af12efa8da92eb5eb7 https://github.com/WebKit/WebKit/commit/8c025b25b577af2f5489f1af12efa8da92eb5eb7 Author: Wenson Hsieh Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/fast/events/touch/ios/long-press-on-link-in-ephemeral-session-expected.txt A LayoutTests/fast/events/touch/ios/long-press-on-link-in-ephemeral-session.html M LayoutTests/resources/ui-helper.js M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm Log Message: --- REGRESSION (268616@main): No context menu preview appears for data detected links in Notes https://bugs.webkit.org/show_bug.cgi?id=266431 rdar://119524150 Reviewed by Megan Gardner. Make a couple of minor adjustments to fix context menu previews for data detected links in HTML Notes, after the changes in 268616@main. See below for more details. Test: fast/events/touch/ios/long-press-on-link-in-ephemeral-session.html * LayoutTests/fast/events/touch/ios/long-press-on-link-in-ephemeral-session-expected.txt: Added. * LayoutTests/fast/events/touch/ios/long-press-on-link-in-ephemeral-session.html: Added. Add a layout test to cover the changes in 264553@main, as well as the changes in this bug, by verifying that in an ephemeral browsing session: 1. The context menu preview for an app store link is not full height (where "full height" is just represented by an arbitrary height cutoff of the preview platter view). 2. The context menu preview for a regular HTTP link is full height. * LayoutTests/resources/ui-helper.js: (window.UIHelper.contextMenuPreviewRect): * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView dataDetectionContextForPositionInformation:]): Limit the logic to avoid showing previews in ephemeral browsing (or when advanced privacy is enabled) to iTunes Store links only. This data detectors codepath is the default way to preview links for `WKWebView` clients that don't otherwise provide a custom menu configuration (e.g. Safari). As such, the changes in 268616@main actually caused links in ephemeral browsing sessions outside of Safari to lose their previews. This patch restores the iTunes Store check to bring back shipping behavior. (-[WKContentView _createTargetedContextMenuHintPreviewIfPossible]): After we stopped using `UIContextMenuStyle` to show a compact menu for data-detected links, the preview is now shown with a transparent background in Notes, since Notes makes their web view transparent, such that the estimated background color is transparent black. This looks really ugly on iOS in the context of the preview platter's background, since the text in the text indicator is barely legible in light mode, on top of the backdrop filter. To mitigate this, fall back to `+[UIColor systemBackgroundColor]` instead of transparent black for text indicator previews, in the case where the estimated background color for the text indicator is transparent black. * Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * Tools/TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::contextMenuPreviewRect const): * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (swizzledAppStoreURL): (WTR::TestController::cocoaPlatformInitialize): Swizzle out `-[NSURL iTunesStoreURL]` to: 1. Make it work on iOS simulator, in the same way as it does on device (for the link in the new test). 2. Make it work in a consistent manner, to ensure stability when testing. * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h: * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::contextMenuPreviewRect const): Add a new testing helper to retrieve the bounds of the context menu preview platter. Canonical link: https://commits.webkit.org/272084@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 240675: Update ANGLE to 2023-12-14 (8f96655927701421009415...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 240675958a5e5070430bf951f1b7822734123064 https://github.com/WebKit/WebKit/commit/240675958a5e5070430bf951f1b7822734123064 Author: Kimmo Kinnunen Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/ThirdParty/ANGLE/.clang-format M Source/ThirdParty/ANGLE/.gitignore M Source/ThirdParty/ANGLE/.gitmodules M Source/ThirdParty/ANGLE/ANGLE.plist M Source/ThirdParty/ANGLE/DEPS M Source/ThirdParty/ANGLE/OWNERS M Source/ThirdParty/ANGLE/WATCHLISTS M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h M Source/ThirdParty/ANGLE/WebKit/angle_commit.h M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/doc/ContributingCode.md M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md M Source/ThirdParty/ANGLE/doc/Orientation.md M Source/ThirdParty/ANGLE/doc/dEQP.md M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesMtl_autogen.h M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h M Source/ThirdParty/ANGLE/include/platform/mtl_features.json M Source/ThirdParty/ANGLE/include/platform/vk_features.json M Source/ThirdParty/ANGLE/infra/config/OWNERS M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_WGL_loader.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GLenum_value_to_string_map.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/interpreter_utils.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/proc_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json M Source/ThirdParty/ANGLE/scripts/registry_xml.py M Source/ThirdParty/ANGLE/scripts/roll_aosp.sh M Source/ThirdParty/ANGLE/src/common/vulkan/BUILD.gn R Source/ThirdParty/ANGLE/src/common/vulkan/vk_google_filtering_precision.h M Source/ThirdParty/ANGLE/src/common/vulkan/vulkan_icd.cpp M Source/ThirdParty/ANGLE/src/common/vulkan/vulkan_icd.h M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.h M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.h M Source/ThirdParty/ANGLE/src/compiler/translator/ValidateTypeSizeLimitations.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/VariablePacker.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/ConstantNames.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/Pipeline.h M Source/ThirdParty/ANGLE/src/compiler/translator/msl/ProgramPrelude.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/ProgramPrelude.h M Source/ThirdParty/ANGLE/src/compiler/translator/msl/RewritePipelines.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.h M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/RescopeGlobalVariables.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/spirv/EmulateYUVBuiltIns.cpp M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/spirv/ReswizzleYUVOps.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Context_gles_ext_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Display.h M Source/ThirdParty/ANGLE/src/libANGLE/EGLSync.cpp M Source/ThirdParty/ANGLE/src/libANGLE/EGLSync.h M Source/ThirdParty/ANGLE/src/libANGLE/State.cpp M Source/ThirdParty/ANGLE/src/libANGLE/State.h M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.cpp M Source/ThirdParty/ANGLE/src/libANGLE/capture/OWNERS M Source/ThirdParty/ANGLE/src/libANGLE/capture/serialize.cpp M Source/ThirdParty/ANGLE/src/libANGLE/context_private_call_gles.cpp M Source/ThirdParty/ANGLE/src/libANGLE/gles_extensions_autogen.cpp M Source/ThirdParty/ANGLE/src/libANGLE/gles_extensions_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/queryutils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/TextureStorage11.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/OWNERS M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm M
[webkit-changes] [WebKit/WebKit] 866fc9: Stop using CheckedPtr with CSSStyleDeclaration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 866fc9912f51aad5517bc60adee453cff2b77140 https://github.com/WebKit/WebKit/commit/866fc9912f51aad5517bc60adee453cff2b77140 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/css/CSSStyleDeclaration.h M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp Log Message: --- Stop using CheckedPtr with CSSStyleDeclaration https://bugs.webkit.org/show_bug.cgi?id=266425 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with CSSStyleDeclaration. Use WeakPtr instead to generate more actionable crashes. * Source/WebCore/css/CSSStyleDeclaration.h: * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp: (WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate): (WebKit::InjectedBundleCSSStyleDeclarationHandle::~InjectedBundleCSSStyleDeclarationHandle): Canonical link: https://commits.webkit.org/272082@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15dc72: [TextureMapper] shrinked blur radius of drop-shado...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15dc72ca9521ce9b61a9d91e4e8749482c59bd4c https://github.com/WebKit/WebKit/commit/15dc72ca9521ce9b61a9d91e4e8749482c59bd4c Author: Fujii Hironori Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/compositing/filters/drop-shadow-large-blur-radius-expected.html A LayoutTests/compositing/filters/drop-shadow-large-blur-radius.html M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp Log Message: --- [TextureMapper] shrinked blur radius of drop-shadow shouldn't exceed GaussianBlurMaxRadius https://bugs.webkit.org/show_bug.cgi?id=265659 Reviewed by Michael Catanzaro. TextureMapper::applyDropShadowFilter shrinks a source texture and a blur radius of drop-shadow before applying a blur filter. The downscaling ratio is based on the blur radius so that the shrinked blur radius doesn't exceed GaussianBlurMaxRadius. However, the calculation wasn't correct. it could slightly exceed GaussianBlurMaxRadius if a blur radius is very large. * LayoutTests/compositing/filters/drop-shadow-large-blur-radius-expected.html: Added. * LayoutTests/compositing/filters/drop-shadow-large-blur-radius.html: Added. * Source/WebCore/platform/graphics/texmap/TextureMapper.cpp: Use std::min to radius as well as TextureMapper::applyBlurFilter does. Canonical link: https://commits.webkit.org/272081@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 682140: Stop using CheckedPtr with StyleSheetContents
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 682140aa71c79cd53d1f77fa687f93c3267768eb https://github.com/WebKit/WebKit/commit/682140aa71c79cd53d1f77fa687f93c3267768eb Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/css/StyleSheetContents.cpp M Source/WebCore/css/StyleSheetContents.h M Source/WebCore/style/StyleInvalidator.cpp M Source/WebCore/style/StyleInvalidator.h M Source/WebCore/style/StyleScope.cpp M Source/WebCore/style/StyleScope.h Log Message: --- Stop using CheckedPtr with StyleSheetContents https://bugs.webkit.org/show_bug.cgi?id=266430 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with StyleSheetContents. We can just use Ref / RefPtr as CheckedPtr was only used for storing in a short-lived Vector. * Source/WebCore/css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::StyleSheetContents): * Source/WebCore/css/StyleSheetContents.h: * Source/WebCore/style/StyleInvalidator.cpp: (WebCore::Style::shouldDirtyAllStyle): (WebCore::Style::Invalidator::Invalidator): * Source/WebCore/style/StyleInvalidator.h: * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::analyzeStyleSheetChange): * Source/WebCore/style/StyleScope.h: Canonical link: https://commits.webkit.org/272080@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 573543: Use CheckedPtr less for non-stack objects
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5735433340880c963594a5cb10f20f6af5623889 https://github.com/WebKit/WebKit/commit/5735433340880c963594a5cb10f20f6af5623889 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityNodeObject.h M Source/WebCore/css/CSSStyleSheet.h M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/MutationObserverRegistration.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/TemplateContentDocumentFragment.h M Source/WebCore/html/parser/HTMLConstructionSite.h M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp M Source/WebCore/xml/XSLStyleSheet.h M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp Log Message: --- Use CheckedPtr less for non-stack objects https://bugs.webkit.org/show_bug.cgi?id=266416 Reviewed by Brent Fulgham. Use CheckedPtr less for non-stack objects. Use WeakPtr instead in order to generate more actionable crashes. This tested as performance neutral on Speedometer 2 & 3. * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/dom/MutationObserverRegistration.h: * Source/WebCore/dom/Node.cpp: (WebCore::liveNodeSet): (WebCore::Node::dumpStatistics): (WebCore::Node::trackForDebugging): (WebCore::Node::~Node): * Source/WebCore/dom/TemplateContentDocumentFragment.h: * Source/WebCore/html/parser/HTMLConstructionSite.h: * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: * Source/WebCore/xml/XSLStyleSheet.h: * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::getOrCreate): (WebKit::InjectedBundleNodeHandle::~InjectedBundleNodeHandle): (WebKit::InjectedBundleNodeHandle::stop): Canonical link: https://commits.webkit.org/272079@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ddf4be: [Filters] GraphicsContext filters have to apply cl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ddf4bec3e947abd7bf96aa06ec84f91e1a32d162 https://github.com/WebKit/WebKit/commit/ddf4bec3e947abd7bf96aa06ec84f91e1a32d162 Author: Said Abou-Hallawa Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/css3/filters/drop-shadow-filter-overflow-expected.html A LayoutTests/css3/filters/drop-shadow-filter-overflow.html M Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp M Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h M Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.cpp M Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.h M Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerFilters.cpp M Source/WebCore/rendering/RenderLayerFilters.h Log Message: --- [Filters] GraphicsContext filters have to apply clipping to the target context before drawing https://bugs.webkit.org/show_bug.cgi?id=266383 rdar://118522654 Reviewed by Simon Fraser. Before applying the filter style and calling `beginTransparencyLayer()`, the clipping rectangle of the target element has to be applied to the destination GraphicsContext. Otherwise the hidden overflow drawing will appear once the `endTransparencyLayer()` is called. RenderLayer::paintLayerContents() needs to calculate the clipping rectangle before calling setupFilters() so it can be passed to FilterStyleTargetSwitcher. beginClipAndDrawSourceImage() and endClipAndDrawSourceImage() will be called when applying CSSFilter. beginDrawSourceImage() and endDrawSourceImage() will be called when applying the top-level SVGFilter since we clip to the bounding rectangle of the root element. * LayoutTests/css3/filters/drop-shadow-filter-overflow-expected.html: Added. * LayoutTests/css3/filters/drop-shadow-filter-overflow.html: Added. * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.cpp: (WebCore::FilterImageTargetSwitcher::beginClipAndDrawSourceImage): * Source/WebCore/platform/graphics/filters/FilterImageTargetSwitcher.h: * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.cpp: (WebCore::FilterStyleTargetSwitcher::beginClipAndDrawSourceImage): * Source/WebCore/platform/graphics/filters/FilterStyleTargetSwitcher.h: * Source/WebCore/platform/graphics/filters/FilterTargetSwitcher.h: (WebCore::FilterTargetSwitcher::beginClipAndDrawSourceImage): Deleted. (WebCore::FilterTargetSwitcher::endClipAndDrawSourceImage): Deleted. (WebCore::FilterTargetSwitcher::beginDrawSourceImage): Deleted. (WebCore::FilterTargetSwitcher::endDrawSourceImage): Deleted. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::setupFilters): (WebCore::RenderLayer::applyFilters): (WebCore::RenderLayer::paintLayerContents): * Source/WebCore/rendering/RenderLayer.h: * Source/WebCore/rendering/RenderLayerFilters.cpp: (WebCore::RenderLayerFilters::beginFilterEffect): * Source/WebCore/rendering/RenderLayerFilters.h: Canonical link: https://commits.webkit.org/272078@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c553c8: Define guard for WKWindowProxyProperty
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c553c8ec6dc384b5285fd524253923de0c44c10d https://github.com/WebKit/WebKit/commit/c553c8ec6dc384b5285fd524253923de0c44c10d Author: Ben Nham Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h Log Message: --- Define guard for WKWindowProxyProperty https://bugs.webkit.org/show_bug.cgi?id=266435 rdar://119684456 Reviewed by Timothy Hatcher. We need to define a guard that clients of WKWindowProxyProperty can consume so that embedders that use both old and new SDKs can use the enum. * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: Canonical link: https://commits.webkit.org/272077@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e37575: Link decoration filtering should be able to be con...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e375751b5b526c89d630ddccad2e4f2df3ac0d2a https://github.com/WebKit/WebKit/commit/e375751b5b526c89d630ddccad2e4f2df3ac0d2a Author: Charlie Wolfe Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h M Source/WebCore/page/LinkDecorationFilteringData.h M Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm Log Message: --- Link decoration filtering should be able to be conditional on URL path https://bugs.webkit.org/show_bug.cgi?id=266382 rdar://89162 Reviewed by Wenson Hsieh. There are situations where we want query parameter removal to only happen for particular URL paths. This patch adds support to do so. Since link decoration filtering is now conditional on domains and paths, I removed `m_domainScopedLinkDecorationFilteringData` and made `m_linkDecorationFilteringData` map from query parameter to the domain and path conditionals. I also made changes so that our API tests support testing link decoration filtering by domain and path. * Source/WebCore/PAL/pal/spi/cocoa/WebPrivacySPI.h: * Source/WebCore/page/LinkDecorationFilteringData.h: (WebCore::LinkDecorationFilteringData::LinkDecorationFilteringData): (WebCore::LinkDecorationFilteringData::operator=): (WebCore::LinkDecorationFilteringData::linkDecoration): Deleted. * Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm: (WebKit::LinkDecorationFilteringController::updateStrings): (WebKit::requestLinkDecorationFilteringData): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::applyLinkDecorationFilteringWithResult): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setLinkDecorationFilteringData): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Tools/TestWebKitAPI/Tests/WebKit/AdvancedPrivacyProtections.mm: (TestWebKitAPI::makeQueryParameterRequestHandler): (TestWebKitAPI::QueryParameterRequestSwizzler::QueryParameterRequestSwizzler): (TestWebKitAPI::QueryParameterRequestSwizzler::update): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272076@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e669e9: [Gardening]: REGRESSION (271863@main): [ macOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e669e9394d5a2ce3e19ec266826579572ed82b08 https://github.com/WebKit/WebKit/commit/e669e9394d5a2ce3e19ec266826579572ed82b08 Author: Marta Darbinyan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/platform/mac-monterey-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (271863@main): [ macOS iOS ] imported/w3c/web-platform-tests/video-rvfc/request-video-frame-callback-webrtc.https.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=266356 rdar://119621367 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-monterey-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272075@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d2a203: Stop using CheckedPtr with DataTransfer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d2a2036689180e1fced3a9d890d753e666f36300 https://github.com/WebKit/WebKit/commit/d2a2036689180e1fced3a9d890d753e666f36300 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/dom/DataTransfer.cpp M Source/WebCore/dom/DataTransfer.h M Source/WebCore/dom/DataTransferItemList.h Log Message: --- Stop using CheckedPtr with DataTransfer https://bugs.webkit.org/show_bug.cgi?id=266434 Reviewed by Ryosuke Niwa. Stop using CheckedPtr with DataTransfer. Use WeakPtr instead to generate more actionable crashes. * Source/WebCore/dom/DataTransfer.cpp: * Source/WebCore/dom/DataTransfer.h: * Source/WebCore/dom/DataTransferItemList.h: Canonical link: https://commits.webkit.org/272074@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f20be: Stop using CheckedPtrs with Geolocation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f20be81cbe14a49cbe37658ed39fdb9bb384bc5 https://github.com/WebKit/WebKit/commit/1f20be81cbe14a49cbe37658ed39fdb9bb384bc5 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/Modules/geolocation/Geolocation.h M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h Log Message: --- Stop using CheckedPtrs with Geolocation https://bugs.webkit.org/show_bug.cgi?id=266422 Reviewed by Ryosuke Niwa. Stop using CheckedPtrs with Geolocation. Geolocation is refcounted so we can use RefPtr for stack variables and we should be using WeakPtr for storing as data members or in containers. * Source/WebCore/Modules/geolocation/Geolocation.h: * Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation): * Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h: Canonical link: https://commits.webkit.org/272073@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b22cc9: Stop using CheckedPtr with DOMWrapperWorld
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b22cc9a66eeaa34e1c4d48bba25e7ea6d1793c3d https://github.com/WebKit/WebKit/commit/b22cc9a66eeaa34e1c4d48bba25e7ea6d1793c3d Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/bindings/js/DOMWrapperWorld.h M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp M Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm Log Message: --- Stop using CheckedPtr with DOMWrapperWorld https://bugs.webkit.org/show_bug.cgi?id=266424 Reviewed by Ryosuke Niwa. Use WeakPtr instead to get more actionable crashes. * Source/WebCore/bindings/js/DOMWrapperWorld.h: * Source/WebKit/WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: (WebKit::InjectedBundleScriptWorld::InjectedBundleScriptWorld): (WebKit::InjectedBundleScriptWorld::~InjectedBundleScriptWorld): * Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm: Canonical link: https://commits.webkit.org/272072@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a45406: Unreviewed, reverting 272008@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a45406a1c9eeb714cd85fdaeec0e8e4cbf7aafe0 https://github.com/WebKit/WebKit/commit/a45406a1c9eeb714cd85fdaeec0e8e4cbf7aafe0 Author: Commit Queue Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/WebProcessPool.cpp Log Message: --- Unreviewed, reverting 272008@main. https://bugs.webkit.org/show_bug.cgi?id=266441 Reland 271984@main Reverted changeset: "Unreviewed, reverting 271984@main." https://bugs.webkit.org/show_bug.cgi?id=266376 https://commits.webkit.org/272008@main Canonical link: https://commits.webkit.org/272071@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2382dd: [WebGPU] CTS validation/createPipelineLayout test ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2382ddd99eb5a12bdaac86c66a819e415b250aab https://github.com/WebKit/WebKit/commit/2382ddd99eb5a12bdaac86c66a819e415b250aab Author: Mike Wyrzykowski Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/http/tests/webgpu/webgpu/api/validation/createPipelineLayout-expected.txt M Source/WebGPU/WebGPU/BindGroupLayout.h M Source/WebGPU/WebGPU/BindGroupLayout.mm M Source/WebGPU/WebGPU/PipelineLayout.mm Log Message: --- [WebGPU] CTS validation/createPipelineLayout test is failing https://bugs.webkit.org/show_bug.cgi?id=266390 Reviewed by Dan Glastonbury. Add passing expectations and validate pipeline creation. * LayoutTests/http/tests/webgpu/webgpu/api/validation/createPipelineLayout-expected.txt: * Source/WebGPU/WebGPU/BindGroupLayout.h: (WebGPU::BindGroupLayout::create): * Source/WebGPU/WebGPU/BindGroupLayout.mm: (WebGPU::Device::createBindGroupLayout): (WebGPU::BindGroupLayout::BindGroupLayout): (WebGPU::BindGroupLayout::dynamicUniformBuffers const): (WebGPU::BindGroupLayout::dynamicStorageBuffers const): * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::Device::createPipelineLayout): Canonical link: https://commits.webkit.org/272070@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9941ce: REGRESSION: Black banners on webpage, sometimes co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9941ce56b7a17396d18b9328222046d86d300551 https://github.com/WebKit/WebKit/commit/9941ce56b7a17396d18b9328222046d86d300551 Author: Matt Woodrow Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h Log Message: --- REGRESSION: Black banners on webpage, sometimes content doesn't fully render when tab switching. https://bugs.webkit.org/show_bug.cgi?id=266429 Reviewed by Tim Horton. If we're forcing a full display due to the existing front buffer being volatile and purged, then we also need to reset the dirty region to the full bounds of the layer. This stops us attempting a copy-forward from the old (purged) front buffer, and also makes sure we clip to the full bounds, not what the web process thought the dirty region would be. When the front buffer is potentially volatile, the web process always synchronously waits for the response of this code, so the dirty region on that side should be updated correctly already. * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: (WebKit::RemoteImageBufferSet::ensureBufferForDisplay): * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h: Canonical link: https://commits.webkit.org/272069@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f147f3: Delete some unused GraphicsContextCG and Dynamic C...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f147f387538df7a313191a0c17404ec5784c841d https://github.com/WebKit/WebKit/commit/f147f387538df7a313191a0c17404ec5784c841d Author: Tim Horton Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h M Source/WebCore/platform/graphics/GraphicsContext.h M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/GraphicsContextCG.h M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.h M Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.mm Log Message: --- Delete some unused GraphicsContextCG and Dynamic Content Scaling code https://bugs.webkit.org/show_bug.cgi?id=266364 rdar://119627950 Reviewed by Wenson Hsieh. * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp: (WebCore::BifurcatedGraphicsContext::needsCachedNativeImageInvalidationWorkaround): Deleted. * Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h: * Source/WebCore/platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::needsCachedNativeImageInvalidationWorkaround): Deleted. * Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContextCG::needsCachedNativeImageInvalidationWorkaround): Deleted. * Source/WebCore/platform/graphics/cg/GraphicsContextCG.h: * Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.h: * Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingImageBufferBackend.mm: (WebKit::DynamicContentScalingAcceleratedImageBufferBackend::create): Deleted. (WebKit::DynamicContentScalingAcceleratedImageBufferBackend::DynamicContentScalingAcceleratedImageBufferBackend): Deleted. Canonical link: https://commits.webkit.org/272068@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35c85b: [WPEWebKit] Fix build issue with ENABLE_GPU_PROCES...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35c85be5a2436eedd83bc1b3603f0de37de4e648 https://github.com/WebKit/WebKit/commit/35c85be5a2436eedd83bc1b3603f0de37de4e648 Author: Pablo Saavedra Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/platform/TextureMapper.cmake Log Message: --- [WPEWebKit] Fix build issue with ENABLE_GPU_PROCESS=ON https://bugs.webkit.org/show_bug.cgi?id=266400 Reviewed by Carlos Garcia Campos. ... by adding a missing WebCore private header TextureMapperFlags.h previously added in 270051@main (bcb36a613468): [TextureMapper] Use OptionSet for TextureMapperFlags https://bugs.webkit.org/show_bug.cgi?id=264033 * Source/WebCore/platform/TextureMapper.cmake: Canonical link: https://commits.webkit.org/272067@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e97f8: Some build/link cleanup
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e97f894b076c23c78e14ca6e9e842ec64126a7c https://github.com/WebKit/WebKit/commit/8e97f894b076c23c78e14ca6e9e842ec64126a7c Author: Brady Eidson Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Some build/link cleanup https://bugs.webkit.org/show_bug.cgi?id=266304 rdar://119575178 Reviewed by Alex Christensen. - Two getClass<> implementations were double defined - ArgumentCodersCocoa.mm was somehow being included to build twice * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::getClass): Deleted. (IPC::getClass): Deleted. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/272066@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f99c19: [CSS] Implement :scope in @scope prelude
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f99c196be2946f17e35e52ff6e4355643943df9b https://github.com/WebKit/WebKit/commit/f99c196be2946f17e35e52ff6e4355643943df9b Author: Matthieu Dubet Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-evaluation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-invalidation-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-nesting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-visited-cssom-expected.txt M Source/WebCore/style/ElementRuleCollector.cpp Log Message: --- [CSS] Implement :scope in @scope prelude https://bugs.webkit.org/show_bug.cgi?id=266405 rdar://119661541 Reviewed by Antti Koivisto. :scope in represents the outter scoping root, :scope in represents the inner scoping root. https://drafts.csswg.org/css-cascade-6/#scope-limits * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-evaluation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-invalidation-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-nesting-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/scope-visited-cssom-expected.txt: * Source/WebCore/style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::scopeRulesMatch): Canonical link: https://commits.webkit.org/272065@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1228ba: Unreviewed build fix after 272060@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1228bad2ca40c4b21e079960ad09dffedbd3f1d3 https://github.com/WebKit/WebKit/commit/1228bad2ca40c4b21e079960ad09dffedbd3f1d3 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/loader/FrameLoader.cpp Log Message: --- Unreviewed build fix after 272060@main. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateFirstPartyForCookies): Canonical link: https://commits.webkit.org/272064@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 065788: Open source build fix for "[Xcode] Symlink to miss...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0657884b0ee81915a1aa46826d77cfeee7700a95 https://github.com/WebKit/WebKit/commit/0657884b0ee81915a1aa46826d77cfeee7700a95 Author: Elliott Williams Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj Log Message: --- Open source build fix for "[Xcode] Symlink to missing headers and check in missing TBDs, instead of mutating the public SDK" https://bugs.webkit.org/show_bug.cgi?id=259831 rdar://problem/113764577 Unreviewed build fix. Re-apply https://commits.webkit.org/267370@main because it got undone in a libwebrtc sync. * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: Originally-landed-as: 267370@main (4ee5a0c63c10). https://bugs.webkit.org/show_bug.cgi?id=266423 Canonical link: https://commits.webkit.org/272063@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3096c5: Samesite=Lax is not always working in Safari
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3096c561acce0ee5b181cd3d16339273d870ebcd https://github.com/WebKit/WebKit/commit/3096c561acce0ee5b181cd3d16339273d870ebcd Author: Youenn Fablet Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h Log Message: --- Samesite=Lax is not always working in Safari https://bugs.webkit.org/show_bug.cgi?id=265634 rdar://119362503 Reviewed by Brent Fulgham and Alex Christensen. We were not setting isSameSite correctly when reading it from disk cache, which was then triggering different cookies being sent between speculative loads and the actual would be loads. Websites could use Vary Cookie headers to handle that case, but they do not tend to. * Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h: (WebKit::NetworkCache::SubresourceInfo::SubresourceInfo): Canonical link: https://commits.webkit.org/272062@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02546e: [Gardening]: [Test Gardening] css-contain/contain-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02546e6e406e0cd7c5910814ea08a90aef32c3e2 https://github.com/WebKit/WebKit/commit/02546e6e406e0cd7c5910814ea08a90aef32c3e2 Author: Marta Darbinyan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: [Test Gardening] css-contain/contain-size-block-003.html and css-contain/contain-size-inline-block-003.html only fail on GTK https://bugs.webkit.org/show_bug.cgi?id=266345 rdar://119617786 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/272061@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 23c371: Make Page refcounted and replace CheckedPtr with R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23c37146256e9c7382894cda4d929cda2a5b78c6 https://github.com/WebKit/WebKit/commit/23c37146256e9c7382894cda4d929cda2a5b78c6 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/Modules/permissions/MainThreadPermissionObserver.cpp M Source/WebCore/Modules/permissions/MainThreadPermissionObserver.h M Source/WebCore/Modules/permissions/PermissionController.h M Source/WebCore/Modules/permissions/PermissionObserver.h M Source/WebCore/Modules/permissions/PermissionStatus.cpp M Source/WebCore/Modules/permissions/PermissionStatus.h M Source/WebCore/Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb M Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebCore/dom/BroadcastChannel.cpp M Source/WebCore/dom/ConstantPropertyMap.cpp M Source/WebCore/dom/DataTransfer.cpp M Source/WebCore/dom/DeviceOrientationAndMotionAccessController.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/DocumentMarkerController.cpp M Source/WebCore/dom/DocumentStorageAccess.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/ExtensionStyleSheets.cpp M Source/WebCore/dom/ImageOverlay.cpp M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/PseudoElement.cpp M Source/WebCore/dom/ScriptedAnimationController.cpp M Source/WebCore/dom/VisitedLinkState.cpp M Source/WebCore/dom/WindowEventLoop.h M Source/WebCore/dom/mac/ImageControlsMac.cpp M Source/WebCore/editing/ReplaceSelectionCommand.cpp M Source/WebCore/editing/SelectionGeometryGatherer.cpp M Source/WebCore/editing/SpellChecker.cpp M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm M Source/WebCore/editing/markup.cpp M Source/WebCore/editing/markup.h M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLSelectElement.cpp M Source/WebCore/inspector/InspectorFrontendAPIDispatcher.h M Source/WebCore/inspector/InspectorFrontendClientLocal.h M Source/WebCore/inspector/InspectorFrontendHost.h M Source/WebCore/inspector/PageDebugger.cpp M Source/WebCore/loader/DocumentThreadableLoader.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/SubframeLoader.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/ImageAnalysisQueue.h M Source/WebCore/page/ImageOverlayController.h M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalDOMWindow.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/OpportunisticTaskScheduler.cpp M Source/WebCore/page/OpportunisticTaskScheduler.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebCore/page/PageGroup.h M Source/WebCore/page/PageOverlay.h M Source/WebCore/page/SettingsBase.h M Source/WebCore/page/UserContentProvider.h M Source/WebCore/page/VisitedLinkStore.h M Source/WebCore/page/ios/EventHandlerIOS.mm M Source/WebCore/page/mac/EventHandlerMac.mm M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/platform/mac/DataDetectorHighlight.h M Source/WebCore/plugins/PluginInfoProvider.h M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/svg/graphics/SVGImage.cpp M Source/WebCore/svg/graphics/SVGImage.h M Source/WebCore/testing/InternalSettings.h M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp M Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKitLegacy/Storage/WebStorageNamespaceProvider.h M Source/WebKitLegacy/WebCoreSupport/PageStorageSessionProvider.h M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h M Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.h M Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/mac/WebView/WebViewData.h Log Message: --- Make Page refcounted and replace CheckedPtr with RefPtr
[webkit-changes] [WebKit/WebKit] 5ea583: High CPU usage may occur due to infinite loop in W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ea58380f09490bd9a91cc1ab713e5c7a067e4d2 https://github.com/WebKit/WebKit/commit/5ea58380f09490bd9a91cc1ab713e5c7a067e4d2 Author: Chris Dumez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: R LayoutTests/platform/gtk/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/WebNavigationState.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h Log Message: --- High CPU usage may occur due to infinite loop in WebProcessPool::processForNavigation() https://bugs.webkit.org/show_bug.cgi?id=266389 rdar://118280525 Reviewed by Alex Christensen. >From the profile in the radar, we can see that we can end up in a state where: 1. WebProcessPool::processForNavigation() send the AddAllowedFirstPartyForCookies IPC to the network process 2. Once we received the IPC response from the network process, we check if the destination WebProcess is still running. 3. We notice that the WebProcess is no longer running so we call WebProcessPool::processForNavigation() -> Back to step 1. We end up in an infinite loop (with an AddAllowedFirstPartyForCookies async IPC in the middle) because we determine over and over that the destination process for the navigation is no longer running, likely because processForNavigation() keeps selecting the same WebProcess. To make sure this can no longer happen, I made the following changes: 1. Add a cache to NetworkProcessProxy to avoid sending the AddAllowedFirstPartyForCookies async IPC unnecessarily. It is common for navigations to happen within the same process when the registrable domain doesn't change. In this case, there is no point in sending the IPC again. 2. Make sure processForNavigationInternal() never returns a terminated process by adding a couple of missing checks. 3. Move the AddAllowedFirstPartyForCookies handshake to a new function named prepareProcessForNavigation(). This function calls itself recursively when the destination process is no longer running, like we used to. However, I now make sure to fall back to calling prepareProcessForNavigation() with a fresh new WebProcess. Also, we attempt this fall back 3 times at most to guarantee no infinite looping can occur. * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::addAllowedFirstPartyForCookies): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/WebNavigationState.cpp: (WebKit::WebNavigationState::navigation): Drop assertion that required the navigationID to be present in the map when calling navigation(navigationID). I changed timing by avoiding the async IPC handshake with the network process in some cases. This timing change caused the ProcessSwap.ConcurrentHistoryNavigations API test to hit this assertion in didStartProvisionalLoad(). The API test purposefully starts parallel / competing navigations. We used to get lucky and the navigation would get cancelled before receiving the response from the network process. Now the cancellation happens after the navigation has started in the provisional process. * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): (WebKit::WebProcessPool::prepareProcessForNavigation): (WebKit::WebProcessPool::processForNavigationInternal): * Source/WebKit/UIProcess/WebProcessPool.h: Canonical link: https://commits.webkit.org/272059@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 615525: macOS: Window close button is disabled in full screen
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6155253262477130676a815be88bb12ed3e6f559 https://github.com/WebKit/WebKit/commit/6155253262477130676a815be88bb12ed3e6f559 Author: Conrad Shultz Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- macOS: Window close button is disabled in full screen https://bugs.webkit.org/show_bug.cgi?id=266369 rdar://118018678 Reviewed by Jer Noble. We need to mark the full screen window as closable for the traffic light to be enabled. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::fullScreenWindow): Canonical link: https://commits.webkit.org/272058@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0cb03: upload-file-to-s3 fails because of webkitpy autoin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0cb037063a252e2b157a7cecbbe61e4dbccebe6 https://github.com/WebKit/WebKit/commit/a0cb037063a252e2b157a7cecbbe61e4dbccebe6 Author: Aakash Jain Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Tools/Scripts/upload-file-to-url Log Message: --- upload-file-to-s3 fails because of webkitpy autoinstaller failing with error No archives for six-1.16 found https://bugs.webkit.org/show_bug.cgi?id=266411 Reviewed by Jonathan Bedard. Ignore webkitpy errors while trying to import. We are only importing it to auto-install requests module, which might already be present. * Tools/Scripts/upload-file-to-url: Canonical link: https://commits.webkit.org/272057@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4893ab: REGRESSION (270199@main?): [ iOS Debug ] ASSERTION...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4893ab05c93b2595ebcaf128ff89436c00f5d470 https://github.com/WebKit/WebKit/commit/4893ab05c93b2595ebcaf128ff89436c00f5d470 Author: Marta Darbinyan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm Log Message: --- REGRESSION (270199@main?): [ iOS Debug ] ASSERTION FAILED: _maximumUnobscuredSizeOverride in TestWebKitAPI.WKWebViewCloseAllMediaPresentations.ElementFullscreen result of constant crash https://bugs.webkit.org/show_bug.cgi?id=265068 rdar://118579209 Reviewed by Ryan Disabling crashing API test. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: (TEST): Canonical link: https://commits.webkit.org/272056@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11d1cd: [web-animations] rename and move KeyframeList
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11d1cdb0666c38b6daf52511b645db1b8d89b793 https://github.com/WebKit/WebKit/commit/11d1cdb0666c38b6daf52511b645db1b8d89b793 Author: Antoine Quint Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/animation/BlendingKeyframes.cpp A Source/WebCore/animation/BlendingKeyframes.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/KeyframeEffect.h M Source/WebCore/animation/KeyframeInterpolation.h M Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp M Source/WebCore/platform/animation/AcceleratedEffect.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerBacking.h M Source/WebCore/rendering/RenderLayerModelObject.cpp M Source/WebCore/rendering/RenderLayerModelObject.h R Source/WebCore/rendering/style/KeyframeList.cpp R Source/WebCore/rendering/style/KeyframeList.h M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleResolver.h Log Message: --- [web-animations] rename and move KeyframeList https://bugs.webkit.org/show_bug.cgi?id=266409 rdar://119663662 Reviewed by Antti Koivisto. The `KeyframeList` class is used almost exclusively in the animation code, so we move it under the "animation" directory. We also refer to such keyframes as "blending keyframes" in the animation code, so we take this opportunity to also rename `KeyframeList` as `BlendingKeyframes` and `KeyframeValue` as `BlendingKeyframe`. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/animation/BlendingKeyframes.cpp: Renamed from Source/WebCore/rendering/style/KeyframeList.cpp. (WebCore::BlendingKeyframes::clear): (WebCore::BlendingKeyframes::operator== const): (WebCore::BlendingKeyframes::insert): (WebCore::BlendingKeyframes::hasImplicitKeyframes const): (WebCore::BlendingKeyframes::copyKeyframes): (WebCore::zeroPercentKeyframe): (WebCore::hundredPercentKeyframe): (WebCore::BlendingKeyframes::fillImplicitKeyframes): (WebCore::BlendingKeyframes::containsAnimatableCSSProperty const): (WebCore::BlendingKeyframes::containsDirectionAwareProperty const): (WebCore::BlendingKeyframes::usesContainerUnits const): (WebCore::BlendingKeyframes::addProperty): (WebCore::BlendingKeyframes::containsProperty const): (WebCore::BlendingKeyframes::usesRelativeFontWeight const): (WebCore::BlendingKeyframes::hasCSSVariableReferences const): (WebCore::BlendingKeyframes::hasColorSetToCurrentColor const): (WebCore::BlendingKeyframes::hasPropertySetToCurrentColor const): (WebCore::BlendingKeyframes::propertiesSetToInherit const): (WebCore::BlendingKeyframes::updatePropertiesMetadata): (WebCore::BlendingKeyframe::addProperty): (WebCore::BlendingKeyframe::animatesProperty const): * Source/WebCore/animation/BlendingKeyframes.h: Renamed from Source/WebCore/rendering/style/KeyframeList.h. (WebCore::BlendingKeyframes::BlendingKeyframes): (WebCore::BlendingKeyframes::animationName const): (WebCore::BlendingKeyframes::properties const): (WebCore::BlendingKeyframes::isEmpty const): (WebCore::BlendingKeyframes::size const): (WebCore::BlendingKeyframes::operator[] const): (WebCore::BlendingKeyframes::begin const): (WebCore::BlendingKeyframes::end const): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::copyPropertiesFromSource): (WebCore::KeyframeEffect::getKeyframes): (WebCore::KeyframeEffect::updateBlendingKeyframes): (WebCore::KeyframeEffect::setBlendingKeyframes): (WebCore::KeyframeEffect::computeCSSAnimationBlendingKeyframes): (WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes): (WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): (WebCore::KeyframeEffect::timingFunctionForBlendingKeyframe const): (WebCore::KeyframeEffect::applyPendingAcceleratedActions): (WebCore::KeyframeEffect::timingFunctionForKeyframe const): * Source/WebCore/animation/KeyframeEffect.h: * Source/WebCore/animation/KeyframeInterpolation.h: (WebCore::KeyframeInterpolation::Keyframe::isBlendingKeyframe const): (WebCore::KeyframeInterpolation::Keyframe::isKeyframeValue const): Deleted. * Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp: * Source/WebCore/platform/animation/AcceleratedEffect.cpp: * Source/WebCore/rendering/RenderElement.h: (WebCore::RenderElement::startAnimation): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::startAnimation): * Source/WebCore/rendering/RenderLayerModelObject.h: * Source/WebCore/style/StyleResolver.cpp: (WebCore::Style::Resolver::styleForKeyframe):
[webkit-changes] [WebKit/WebKit] 260dbd: AX: Serve relatedObjectIdsFor off of the main thread
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 260dbd54ddc991eb4da22ade56c40a850e31fe81 https://github.com/WebKit/WebKit/commit/260dbd54ddc991eb4da22ade56c40a850e31fe81 Author: Joshua Hoffman Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/accessibility/mac/table-headers-attribute.html M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: Serve relatedObjectIdsFor off of the main thread https://bugs.webkit.org/show_bug.cgi?id=266268 rdar://116133758 Reviewed by Tyler Wilcock. Before this patch, we would have to go to the main thread to retrieve relations from the cache whenever they were dirty inside AXIsolatedTree::relatedObjectIdsFor. This patch removes that necessity by caching relations, which is performed only when they are dirty. Taking advantage of the new deferred node updates logic, we now cache relations from the AXObjectCache only if the m_relationsNeedUpdate flag is set when processQueuedNodeUpdates is fired, rather than caching lazily in relatedObjectIdsFor. This allows AXIsolatedTree::relatedObjectIdsFor to use the cached m_relations. One test was made async to reflect this change. * LayoutTests/accessibility/mac/table-headers-attribute.html: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::relationsNeedUpdate): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::create): (WebCore::AXIsolatedTree::updateRelations): (WebCore::AXIsolatedTree::relatedObjectIDsFor): (WebCore::AXIsolatedTree::processQueuedNodeUpdates): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/272054@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff8bb9: Unreviewed, reverting 271641@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff8bb9f3e473eccc7f779b6260bc922504c5c7ff https://github.com/WebKit/WebKit/commit/ff8bb9f3e473eccc7f779b6260bc922504c5c7ff Author: Marta Darbinyan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/fullscreen/full-screen-layer-dump-expected.txt Log Message: --- Unreviewed, reverting 271641@main https://bugs.webkit.org/show_bug.cgi?id=265957 rdar://119268470 https://bugs.webkit.org/show_bug.cgi?id=265957 REGRESSION (271535@main): [ macOS Release wk2 ] fullscreen/full-screen-layer-dump.html is frequent failure Reverting the rebaseline as it didn't fix the test * LayoutTests/fullscreen/full-screen-layer-dump-expected.txt: Canonical link: https://commits.webkit.org/272053@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3be6d4: upload-file-to-s3 should retry when the request fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3be6d4ae5ddb6b67a9caea84ac256468892ac032 https://github.com/WebKit/WebKit/commit/3be6d4ae5ddb6b67a9caea84ac256468892ac032 Author: Aakash Jain Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Tools/Scripts/upload-file-to-url Log Message: --- upload-file-to-s3 should retry when the request fails with status_code 503 https://bugs.webkit.org/show_bug.cgi?id=266419 Reviewed by Jonathan Bedard. We added retry in 271774@main to upload-file-to-s3. However, that doesn't retry in the case when the request fails with non 200 status_code. We should retry in those cases as well. * Tools/Scripts/upload-file-to-url: (upload): Canonical link: https://commits.webkit.org/272052@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b39f2e: [JSC] Refactoring: use baseIndexWithProvenValue in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b39f2eca846a895dc126443bf682df7c73d3cd0e https://github.com/WebKit/WebKit/commit/b39f2eca846a895dc126443bf682df7c73d3cd0e Author: Yijia Huang Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp Log Message: --- [JSC] Refactoring: use baseIndexWithProvenValue in FTLLowerDFGToB3.cpp https://bugs.webkit.org/show_bug.cgi?id=266365 rdar://119628641 Reviewed by Mark Lam. This patch has two things done: 1. Rename `baseIndex` function to `baseIndexWithProvenValue` to explicitly indicate that this function uses `provenValue`. 2. Apply `baseIndexWithProvenValue` on all applicable code sites. * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileGetByValImpl): (JSC::FTL::DFG::LowerDFGToB3::compilePutByVal): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharAtImpl): (JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt): (JSC::FTL::DFG::LowerDFGToB3::compileStringCodePointAt): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): Canonical link: https://commits.webkit.org/272051@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 455c80: Work around build error caused by weak linking and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 455c80625db0021ae482d684e5c116712666378a https://github.com/WebKit/WebKit/commit/455c80625db0021ae482d684e5c116712666378a Author: Justin Michaud Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/JavaScriptCore/jit/ExecutableAllocator.cpp Log Message: --- Work around build error caused by weak linking and the direct call attribute https://bugs.webkit.org/show_bug.cgi?id=266414 rdar://119669705 Reviewed by Wenson Hsieh. Work around build error caused by weak linking and the direct call attribute * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::initializeJITPageReservation): Canonical link: https://commits.webkit.org/272050@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 06ddd6: [WASM] SEGV in JSC::Wasm::FunctionParser
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 06ddd6593c2d8c55ebbb70ff1433eba574b81bb7 https://github.com/WebKit/WebKit/commit/06ddd6593c2d8c55ebbb70ff1433eba574b81bb7 Author: Asumu Takikawa Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A JSTests/wasm/gc/bug260516.js Log Message: --- [WASM] SEGV in JSC::Wasm::FunctionParser::parseExpression https://bugs.webkit.org/show_bug.cgi?id=260516 Reviewed by Justin Michaud. Adds test for already-fixed bug. * JSTests/wasm/gc/bug260516.js: Added. (module): Canonical link: https://commits.webkit.org/272049@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f437eb: [webkitpy] Remove AbstractTestResults
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f437eb526ebbbc92ea03357fb95dd8236072f255 https://github.com/WebKit/WebKit/commit/f437eb526ebbbc92ea03357fb95dd8236072f255 Author: Sam Sneddon Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: R Tools/Scripts/webkitpy/common/net/abstracttestresults.py R Tools/Scripts/webkitpy/common/net/abstracttestresults_unittest.py M Tools/Scripts/webkitpy/common/net/layouttestresults.py M Tools/Scripts/webkitpy/test/main.py Log Message: --- [webkitpy] Remove AbstractTestResults https://bugs.webkit.org/show_bug.cgi?id=266122 Reviewed by Jonathan Bedard. AbstractTestResults now has a single subclass, LayoutTestResults, so it may as well not exist. * Tools/Scripts/webkitpy/common/net/abstracttestresults.py: Removed. * Tools/Scripts/webkitpy/common/net/abstracttestresults_unittest.py: Removed. * Tools/Scripts/webkitpy/common/net/layouttestresults.py: (LayoutTestResults): * Tools/Scripts/webkitpy/test/main.py: (main): Canonical link: https://commits.webkit.org/272048@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26e5ef: WPT sync /css/css-writing-modes/forms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26e5ef86df71a6858f0d1c19c6327077c0a50a0b https://github.com/WebKit/WebKit/commit/26e5ef86df71a6858f0d1c19c6327077c0a50a0b Author: Anne van Kesteren Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-lr.optional-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-rl.optional-expected-mismatch.html M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html M LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt Log Message: --- WPT sync /css/css-writing-modes/forms https://bugs.webkit.org/show_bug.cgi?id=266412 Reviewed by Aditya Keerthi. Imports https://github.com/web-platform-tests/wpt/pull/43664 and changes made before. This resulted in some surrounding cleanup, presumably due to import-w3c-tests not being used last time around. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-lr.optional-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-rl.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. Canonical link: https://commits.webkit.org/272047@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b23ed: [WPE] Update Cog version for the WebKit build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b23edce907ac6d759763d409743619947e70ad0 https://github.com/WebKit/WebKit/commit/8b23edce907ac6d759763d409743619947e70ad0 Author: Carlos Alberto Lopez Perez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Tools/PlatformWPE.cmake Log Message: --- [WPE] Update Cog version for the WebKit build https://bugs.webkit.org/show_bug.cgi?id=266351 Reviewed by Philippe Normand and Michael Catanzaro. This updates Cog for the WPE build to the last one (0~0.19.1-1-g843f874) This fixes an issue with the DRM plugin for the RPi4 that causes Cog to not output anything on the screen. Cog now depends on libportal, that dependency was added to the Flatpak SDK in 272033@main * Tools/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/272046@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 512102: [WebGPU] Fix redundant move in return statement in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 512102a14ecc30ddde7126b52bd5156ed2e1849b https://github.com/WebKit/WebKit/commit/512102a14ecc30ddde7126b52bd5156ed2e1849b Author: Pablo Saavedra Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp Log Message: --- [WebGPU] Fix redundant move in return statement in expansion of macro WTFMove https://bugs.webkit.org/show_bug.cgi?id=266398 Reviewed by Mike Wyrzykowski. This change fix a trivial build error in WPEWebKit and WebKitGTK when ENABLE_GPU_PROCESS=ON. * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp: (WebKit::WebGPU::RemoteCommandEncoderProxy::beginRenderPass): (WebKit::WebGPU::RemoteCommandEncoderProxy::beginComputePass): Canonical link: https://commits.webkit.org/272045@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdbd1e: Refactor Scrollbar to hold NSScrollerImp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdbd1e818def7f92e7c7e410229619c18d419d08 https://github.com/WebKit/WebKit/commit/fdbd1e818def7f92e7c7e410229619c18d419d08 Author: Nikolaos Mouchtaris Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/page/scrolling/mac/ScrollingStateScrollingNodeMac.mm M Source/WebCore/platform/Scrollbar.cpp M Source/WebCore/platform/Scrollbar.h M Source/WebCore/platform/ScrollbarTheme.h A Source/WebCore/platform/mac/ScrollbarMac.h A Source/WebCore/platform/mac/ScrollbarMac.mm M Source/WebCore/platform/mac/ScrollbarThemeMac.h M Source/WebCore/platform/mac/ScrollbarThemeMac.mm M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm Log Message: --- Refactor Scrollbar to hold NSScrollerImp https://bugs.webkit.org/show_bug.cgi?id=264014 rdar://117770817 Reviewed by Simon Fraser. Decouple creation of NSScrollerImps from the global map in ScrollbarThemeMac. Instead, create ScrollbarMac to hold a reference to the NSScrollerImp, and change the map to a set of scrollbars (which is still necessary due to the WebScrollbarPrefsObserver stuff). * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/Scrollbar.cpp: (WebCore::Scrollbar::createNativeScrollbar): * Source/WebCore/platform/mac/ScrollbarMac.h: Added. (WebCore::ScrollbarMac::~ScrollbarMac): * Source/WebCore/platform/mac/ScrollbarMac.mm: Added. (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::painterForScrollbar): (WebCore::ScrollbarMac::createNSScrollerImp): (WebCore::macScrollbarTheme): (WebCore::ScrollbarMac::updateNSScrollerImpState): (WebCore::ScrollbarMac::setNewPainterForScrollbar): * Source/WebCore/platform/mac/ScrollbarThemeMac.h: * Source/WebCore/platform/mac/ScrollbarThemeMac.mm: (WebCore::scrollbarMap): (+[WebScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::ScrollbarThemeMac::registerScrollbar): (WebCore::ScrollbarThemeMac::unregisterScrollbar): (WebCore::ScrollbarThemeMac::painterForScrollbar): (WebCore::ScrollbarThemeMac::hasThumb): (WebCore::ScrollbarThemeMac::minimumThumbLength): (WebCore::ScrollbarThemeMac::updateEnabledState): (WebCore::paintScrollbar): (WebCore::ScrollbarThemeMac::setNewPainterForScrollbar): Deleted. * Source/WebCore/platform/mac/ScrollbarsControllerMac.mm: (WebCore::ScrollbarsControllerMac::updateScrollerStyle): Canonical link: https://commits.webkit.org/272044@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de121a: [Gardening]: REGRESSION (271535@main): [ macOS Rel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de121adf537edde348382384fd6e9506d0bfb943 https://github.com/WebKit/WebKit/commit/de121adf537edde348382384fd6e9506d0bfb943 Author: Marta Darbinyan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (271535@main): [ macOS Release wk2 ] fullscreen/full-screen-layer-dump.html is a frequent failure https://bugs.webkit.org/show_bug.cgi?id=265957 rdar://119268470 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/272043@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ab52a: [Nicosia] Adapt RemoteGraphicsContextGLProxyGBM to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ab52a6c425450f5a640db5940a6e4ccd02e6226 https://github.com/WebKit/WebKit/commit/7ab52a6c425450f5a640db5940a6e4ccd02e6226 Author: Pablo Saavedra Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp Log Message: --- [Nicosia] Adapt RemoteGraphicsContextGLProxyGBM to the Nicosa latest changes https://bugs.webkit.org/show_bug.cgi?id=266401 Reviewed by Carlos Garcia Campos. This change fixes the build with GPUProcess enabled by adapting the RemoteGraphicsContextGLProxyGBM according with the changes made in 269998@main (ee8fbcb55b4a): Fix GBM GPU: [Nicosia] Simplify NicosiaPlatformLayer https://bugs.webkit.org/show_bug.cgi?id=263775 * Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp: (WebKit::NicosiaDisplayDelegate::NicosiaDisplayDelegate): (WebKit::NicosiaDisplayDelegate::swapBuffersIfNeeded): Canonical link: https://commits.webkit.org/272042@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f798b: REGRESSION(iOS17): [ iOS17 wk2 ] accessibility/ios...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f798b86786a69fa32a8d351effc50b343cbc325 https://github.com/WebKit/WebKit/commit/7f798b86786a69fa32a8d351effc50b343cbc325 Author: Anne van Kesteren Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/accessibility/ios-simulator/input-type-time-expected.txt M LayoutTests/accessibility/ios-simulator/input-type-time.html M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- REGRESSION(iOS17): [ iOS17 wk2 ] accessibility/ios-simulator/input-type-time.html is a constant failure. https://bugs.webkit.org/show_bug.cgi?id=263048 rdar://116837628 Reviewed by Chris Fleizach. CLDR 42 replaced U+0020 with U+202F when formatting dates. That does not seem like a sustainable change, but here it is. As such nothing regressed with regards to what this test was testing. * LayoutTests/accessibility/ios-simulator/input-type-time-expected.txt: * LayoutTests/accessibility/ios-simulator/input-type-time.html: * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272041@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e44bf5: [IFC][Ruby] fix web-platform-tests/editing/run/ins...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e44bf50fe7914190924a7ed97458bbaf443cf6b9 https://github.com/WebKit/WebKit/commit/e44bf50fe7914190924a7ed97458bbaf443cf6b9 Author: Antti Koivisto Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/editing/Editing.cpp Log Message: --- [IFC][Ruby] fix web-platform-tests/editing/run/inserthorizontalrule.html https://bugs.webkit.org/show_bug.cgi?id=266397 rdar://119659338 Reviewed by Alan Baradlay. with display:inline-block should not have special treatment in editing code. This gets hit in this test because inlinification of content. * Source/WebCore/editing/Editing.cpp: (WebCore::isRenderedAsNonInlineTableImageOrHR): Canonical link: https://commits.webkit.org/272040@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f59e18: [JSC] Assertion in JSC::Yarr::Interpreter
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f59e18069da6a713ae24f085a29d4759bc0a4b3f https://github.com/WebKit/WebKit/commit/f59e18069da6a713ae24f085a29d4759bc0a4b3f Author: Michael Saboff Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M JSTests/stress/regexp-lookbehind.js M Source/JavaScriptCore/yarr/YarrInterpreter.cpp Log Message: --- [JSC] Assertion in JSC::Yarr::Interpreter::InputStream::uncheckInput called from backtrackPatternCasedCharacter https://bugs.webkit.org/show_bug.cgi?id=266373 rdar://119187095 Reviewed by Justin Michaud. When backtracking a lookbehind atom to its starting position we need to set the input pointer to the starting position. All other character based atoms had this right, except backtrackPatternCasedCharacter(). * JSTests/stress/regexp-lookbehind.js: Added a new test case. * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter): Canonical link: https://commits.webkit.org/272039@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bda9e: [WGSL] frexp should support f16
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bda9ebbdfb9ab974ce39d7396e6cad533b71a4f https://github.com/WebKit/WebKit/commit/9bda9ebbdfb9ab974ce39d7396e6cad533b71a4f Author: Tadeu Zagallo Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebGPU/WGSL/ConstantFunctions.h M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/generator/main.rb M Source/WebGPU/WGSL/tests/valid/overload.wgsl Log Message: --- [WGSL] frexp should support f16 https://bugs.webkit.org/show_bug.cgi?id=266348 rdar://119618161 Reviewed by Mike Wyrzykowski. Frexp was implemented before we support f16, and I forgot to implement it when f16 landed. * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::CONSTANT_FUNCTION): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/generator/main.rb: * Source/WebGPU/WGSL/tests/valid/overload.wgsl: Canonical link: https://commits.webkit.org/272038@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 643ae9: remove "display" folder in the WebCore Xcode project
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 643ae9d8459bdffdaea987f6f2c70309147465f9 https://github.com/WebKit/WebKit/commit/643ae9d8459bdffdaea987f6f2c70309147465f9 Author: Antoine Quint Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- remove "display" folder in the WebCore Xcode project https://bugs.webkit.org/show_bug.cgi?id=266407 rdar://119662851 Reviewed by Tim Nguyen. These files were removed in 271264@main. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/272037@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a1e34: [iOS] Enable SampleBufferContentKeySessionSupportE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a1e342eb47141b4128ab2700e66a8996a9338bc https://github.com/WebKit/WebKit/commit/4a1e342eb47141b4128ab2700e66a8996a9338bc Author: Andy Estes Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm M Source/WebKit/Scripts/process-entitlements.sh M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm Log Message: --- [iOS] Enable SampleBufferContentKeySessionSupportEnabled by default https://bugs.webkit.org/show_bug.cgi?id=266377 rdar://118244664 Reviewed by Jer Noble. Enabled SampleBufferContentKeySessionSupportEnabled by default on iOS-family platforms. For configurations where AVSampleBufferAttachContentKey is not supported, added a fallback path to calling add/removeContentKeyRecipient. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp: (WTF::processIsExtensionValue): (WTF::processIsExtension): (WTF::setProcessIsExtension): * Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::supportsAttachContentKey): (WebCore::shouldAddContentKeyRecipients): (WebCore::SourceBufferPrivateAVFObjC::destroyRenderers): (WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled): (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance): (WebCore::SourceBufferPrivateAVFObjC::enqueueSample): (WebCore::SourceBufferPrivateAVFObjC::enqueueSampleBuffer): (WebCore::SourceBufferPrivateAVFObjC::attachContentKeyToSampleIfNeeded): (WebCore::SourceBufferPrivateAVFObjC::setVideoLayer): * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::platformInitialize): Canonical link: https://commits.webkit.org/272036@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 861cce: Add namespace qualifiers to a bunch of jsc types
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 861cce42f1988e8ac5b7269dbe43a8e54cd79c62 https://github.com/WebKit/WebKit/commit/861cce42f1988e8ac5b7269dbe43a8e54cd79c62 Author: Justin Michaud Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.cpp M Source/JavaScriptCore/b3/air/AirOpcode.opcodes M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/CodeBlock.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp M Source/JavaScriptCore/dfg/DFGJITCompiler.h M Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp M Source/JavaScriptCore/dfg/DFGJITFinalizer.h M Source/JavaScriptCore/dfg/DFGOSREntry.cpp M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGPlan.cpp M Source/JavaScriptCore/dfg/DFGPlan.h M Source/JavaScriptCore/ftl/FTLJITFinalizer.h M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/ftl/FTLState.h M Source/JavaScriptCore/heap/AbstractSlotVisitor.h M Source/JavaScriptCore/heap/AbstractSlotVisitorInlines.h M Source/JavaScriptCore/heap/AlignedMemoryAllocator.cpp M Source/JavaScriptCore/heap/AllocatingScope.h M Source/JavaScriptCore/heap/AllocatorInlines.h M Source/JavaScriptCore/heap/BlockDirectory.cpp M Source/JavaScriptCore/heap/CellContainer.h M Source/JavaScriptCore/heap/CellContainerInlines.h M Source/JavaScriptCore/heap/CollectingScope.h M Source/JavaScriptCore/heap/CompleteSubspace.cpp M Source/JavaScriptCore/heap/ConservativeRoots.cpp M Source/JavaScriptCore/heap/ConservativeRoots.h M Source/JavaScriptCore/heap/DeferGC.h M Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp M Source/JavaScriptCore/heap/EdenGCActivityCallback.h M Source/JavaScriptCore/heap/FullGCActivityCallback.cpp M Source/JavaScriptCore/heap/FullGCActivityCallback.h M Source/JavaScriptCore/heap/GCActivityCallback.cpp M Source/JavaScriptCore/heap/Heap.cpp M Source/JavaScriptCore/heap/Heap.h M Source/JavaScriptCore/heap/HeapCell.h M Source/JavaScriptCore/heap/HeapCellInlines.h M Source/JavaScriptCore/heap/HeapInlines.h M Source/JavaScriptCore/heap/HeapIterationScope.h M Source/JavaScriptCore/heap/HeapUtil.h M Source/JavaScriptCore/heap/IncrementalSweeper.cpp M Source/JavaScriptCore/heap/IsoSubspace.cpp M Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp M Source/JavaScriptCore/heap/LocalAllocator.cpp M Source/JavaScriptCore/heap/LocalAllocatorInlines.h M Source/JavaScriptCore/heap/MarkStackMergingConstraint.cpp M Source/JavaScriptCore/heap/MarkStackMergingConstraint.h M Source/JavaScriptCore/heap/MarkedBlock.cpp M Source/JavaScriptCore/heap/MarkedBlock.h M Source/JavaScriptCore/heap/MarkedBlockInlines.h M Source/JavaScriptCore/heap/MarkedSpace.cpp M Source/JavaScriptCore/heap/MarkedSpace.h M Source/JavaScriptCore/heap/MarkedSpaceInlines.h M Source/JavaScriptCore/heap/MarkingConstraintSet.cpp M Source/JavaScriptCore/heap/MarkingConstraintSet.h M Source/JavaScriptCore/heap/MarkingConstraintSolver.h M Source/JavaScriptCore/heap/PreciseAllocation.cpp M Source/JavaScriptCore/heap/PreciseAllocation.h M Source/JavaScriptCore/heap/PreventCollectionScope.h M Source/JavaScriptCore/heap/ReleaseHeapAccessScope.h M Source/JavaScriptCore/heap/RunningScope.h M Source/JavaScriptCore/heap/SlotVisitor.cpp M Source/JavaScriptCore/heap/SpaceTimeMutatorScheduler.cpp M Source/JavaScriptCore/heap/SpaceTimeMutatorScheduler.h M Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.cpp M Source/JavaScriptCore/heap/StochasticSpaceTimeMutatorScheduler.h M Source/JavaScriptCore/heap/Subspace.cpp M Source/JavaScriptCore/heap/SweepingScope.h M Source/JavaScriptCore/heap/VerifierSlotVisitor.cpp M Source/JavaScriptCore/heap/WeakBlock.cpp M Source/JavaScriptCore/heap/WeakSet.cpp M Source/JavaScriptCore/heap/WeakSet.h M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/interpreter/Interpreter.h M Source/JavaScriptCore/interpreter/InterpreterInlines.h M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp M Source/JavaScriptCore/jit/JITCode.h M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITMathIC.h M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/jit/JITThunks.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/llint/LLIntData.h M Source/JavaScriptCore/runtime/EvalExecutable.h M Source/JavaScriptCore/runtime/ExecutableBase.h M
[webkit-changes] [WebKit/WebKit] 7e46f5: [WPE][GTK] Add libportal to the Flatpak SDK
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7e46f5efc03c369e1b2bfaebe0c42f6f7448e53f https://github.com/WebKit/WebKit/commit/7e46f5efc03c369e1b2bfaebe0c42f6f7448e53f Author: Philippe Normand Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Tools/buildstream/elements/freedesktop-sdk.bst M Tools/buildstream/elements/qt5/qtbase.bst M Tools/buildstream/elements/sdk-platform.bst M Tools/buildstream/elements/sdk/adwaita-icon-theme.bst R Tools/buildstream/elements/sdk/gtk+-3.bst A Tools/buildstream/elements/sdk/libportal.bst A Tools/buildstream/patches/fdo-0001-gtk3-Include-changes-from-downstream-WebKit-SDK.patch Log Message: --- [WPE][GTK] Add libportal to the Flatpak SDK https://bugs.webkit.org/show_bug.cgi?id=266360 Reviewed by Carlos Alberto Lopez Perez. Our gtk3 recipe was somehow colliding with the one provided by the FDO SDK, so we now patch the FDO junction with our changes instead. The libportal recipe from Carlos Lopez is adapted with build fixes. * Tools/buildstream/elements/freedesktop-sdk.bst: * Tools/buildstream/elements/qt5/qtbase.bst: * Tools/buildstream/elements/sdk-platform.bst: * Tools/buildstream/elements/sdk/adwaita-icon-theme.bst: * Tools/buildstream/elements/sdk/gtk+-3.bst: Removed. * Tools/buildstream/elements/sdk/libportal.bst: Added. * Tools/buildstream/patches/fdo-0001-gtk3-Include-changes-from-downstream-WebKit-SDK.patch: Added. Canonical link: https://commits.webkit.org/272033@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3f2a6: Inline some functions used in copyCompactAndLinkCode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3f2a6f91ba48a9da351d92f82cd28f37a087f07 https://github.com/WebKit/WebKit/commit/e3f2a6f91ba48a9da351d92f82cd28f37a087f07 Author: Justin Michaud Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/JavaScriptCore/assembler/ARM64Assembler.h M Source/JavaScriptCore/assembler/AssemblerBuffer.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h Log Message: --- Inline some functions used in copyCompactAndLinkCode https://bugs.webkit.org/show_bug.cgi?id=266362 rdar://119627634 Reviewed by Mark Lam. Inline some functions used in copyCompactAndLinkCode, since we want to minimize register spilling there. * Source/JavaScriptCore/assembler/ARM64Assembler.h: (JSC::ARM64Assembler::buffer): (JSC::ARM64Assembler::LinkRecord::from const): (JSC::ARM64Assembler::LinkRecord::setFrom): (JSC::ARM64Assembler::LinkRecord::to const): (JSC::ARM64Assembler::LinkRecord::type const): (JSC::ARM64Assembler::LinkRecord::linkType const): (JSC::ARM64Assembler::LinkRecord::branchType const): (JSC::ARM64Assembler::LinkRecord::setLinkType): (JSC::ARM64Assembler::LinkRecord::condition const): (JSC::ARM64Assembler::LinkRecord::is64Bit const): (JSC::ARM64Assembler::LinkRecord::isThunk const): (JSC::ARM64Assembler::LinkRecord::bitNumber const): (JSC::ARM64Assembler::LinkRecord::compareRegister const): * Source/JavaScriptCore/assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::putInt): (JSC::AssemblerBuffer::releaseAssemblerData): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::MacroAssemblerARM64): (JSC::MacroAssemblerARM64::jumpsToLink): (JSC::MacroAssemblerARM64::canCompact): (JSC::MacroAssemblerARM64::computeJumpType): (JSC::MacroAssemblerARM64::jumpSizeDelta): (JSC::MacroAssemblerARM64::isCompactPtrAlignedAddressOffset): Canonical link: https://commits.webkit.org/272034@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/wpewebkit-2.42.4 Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b5580: Unreviewed. Non-unified build fix.
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 4b55803d6c93c990ebb70d73c31577e3b3bd https://github.com/WebKit/WebKit/commit/4b55803d6c93c990ebb70d73c31577e3b3bd Author: Adrian Perez de Castro Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/rendering/svg/RenderSVGResource.h Log Message: --- Unreviewed. Non-unified build fix. * Source/WebCore/rendering/svg/RenderSVGResource.h: Add missing wtf/WeakHashSet.h header inclusion. Canonical link: https://commits.webkit.org/266719.203@webkitglib/2.42 Commit: 179c9a37278e84ffe7df60250f7c3e036b892a4d https://github.com/WebKit/WebKit/commit/179c9a37278e84ffe7df60250f7c3e036b892a4d Author: Adrian Perez de Castro Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebKit/wpe/NEWS M Source/cmake/OptionsWPE.cmake Log Message: --- Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.42.4 release * Source/WebKit/wpe/NEWS: Add release notes for 2.42.4. * Source/cmake/OptionsWPE.cmake: Bump version numbers. Canonical link: https://commits.webkit.org/266719.204@webkitglib/2.42 Compare: https://github.com/WebKit/WebKit/compare/54eb10812825...179c9a37278e ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ababa: [WebGPU] CTS test validation/createBindGroup.html ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ababab1ace6f68c5e15c1bb8556b380a3fadc34 https://github.com/WebKit/WebKit/commit/8ababab1ace6f68c5e15c1bb8556b380a3fadc34 Author: Mike Wyrzykowski Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/http/tests/webgpu/webgpu/api/validation/createBindGroup-expected.txt M LayoutTests/http/tests/webgpu/webgpu/api/validation/createBindGroupLayout-expected.txt M Source/WebCore/Modules/WebGPU/GPUStorageTextureAccess.h M Source/WebCore/Modules/WebGPU/GPUStorageTextureAccess.idl M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUStorageTextureAccess.h M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp M Source/WebGPU/WGSL/WGSL.h M Source/WebGPU/WebGPU/BindGroup.mm M Source/WebGPU/WebGPU/BindGroupLayout.h M Source/WebGPU/WebGPU/BindGroupLayout.mm M Source/WebGPU/WebGPU/Buffer.h M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/ComputePipeline.mm M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/PipelineLayout.mm M Source/WebGPU/WebGPU/RenderPipeline.mm M Source/WebGPU/WebGPU/Sampler.mm M Source/WebGPU/WebGPU/ShaderModule.mm M Source/WebGPU/WebGPU/Texture.h M Source/WebGPU/WebGPU/Texture.mm M Source/WebGPU/WebGPU/TextureView.h M Source/WebGPU/WebGPU/TextureView.mm M Source/WebGPU/WebGPU/WebGPU.h Log Message: --- [WebGPU] CTS test validation/createBindGroup.html and validation/createBindGroupLayout.html are failing https://bugs.webkit.org/show_bug.cgi?id=266318 Reviewed by Tadeu Zagallo. Add validation such tat createBindGroupLayout.html passes and add the passing expectation. Add passing expectations for validation/createBindGroup.html and add some validation so that the CTS test passes. * LayoutTests/http/tests/webgpu/webgpu/api/validation/createBindGroup-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/createBindGroupLayout-expected.txt: * Source/WebCore/Modules/WebGPU/GPUStorageTextureAccess.h: (WebCore::convertToBacking): * Source/WebCore/Modules/WebGPU/GPUStorageTextureAccess.idl: * Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp: (WebCore::WebGPU::ConvertToBackingContext::convertToBacking): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp: (WebCore::WebGPU::DeviceImpl::createSampler): (WebCore::WebGPU::DeviceImpl::createBindGroup): * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUStorageTextureAccess.h: * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::convertAccess): (WGSL::bindingMemberForGlobal): * Source/WebGPU/WGSL/WGSL.h: * Source/WebGPU/WebGPU/BindGroup.mm: (WebGPU::hasProperUsageFlags): (WebGPU::hasBinding): (WebGPU::formatType): (WebGPU::formatIsFloat): (WebGPU::formatIsDepth): (WebGPU::formatIsSignedInt): (WebGPU::formatIsUnsignedInt): (WebGPU::validateTextureSampleType): (WebGPU::validateTextureViewDimension): (WebGPU::validateStorageTextureViewFormat): (WebGPU::validateSamplerType): (WebGPU::Device::createBindGroup): * Source/WebGPU/WebGPU/BindGroupLayout.h: (WebGPU::BindGroupLayout::create): (WebGPU::BindGroupLayout::createInvalid): * Source/WebGPU/WebGPU/BindGroupLayout.mm: (WebGPU::createArgumentDescriptor): (WebGPU::Device::createBindGroupLayout): (WebGPU::BindGroupLayout::BindGroupLayout): (WebGPU::BindGroupLayout::uniformBuffersPerStage const): (WebGPU::BindGroupLayout::storageBuffersPerStage const): (WebGPU::BindGroupLayout::samplersPerStage const): (WebGPU::BindGroupLayout::texturesPerStage const): (WebGPU::BindGroupLayout::storageTexturesPerStage const): (WebGPU::BindGroupLayout::device const): (WebGPU::BindGroupLayout::isAutoGenerated const): * Source/WebGPU/WebGPU/Buffer.h: * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Buffer::isDestroyed const): * Source/WebGPU/WebGPU/ComputePipeline.mm: (WebGPU::createComputePipelineState): (WebGPU::returnInvalidComputePipeline): (WebGPU::Device::createComputePipeline): (WebGPU::Device::createComputePipelineAsync): * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::Device::createPipelineLayout): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::convertToMTLCompare): (WebGPU::convertAccess): (WebGPU::convertFormat): (WebGPU::Device::addPipelineLayouts): (WebGPU::returnInvalidRenderPipeline): (WebGPU::Device::createRenderPipeline): (WebGPU::Device::createRenderPipelineAsync): * Source/WebGPU/WebGPU/Sampler.mm: (WebGPU::compareFunction): * Source/WebGPU/WebGPU/ShaderModule.mm: (WebGPU::wgslAccess): (WebGPU::wgslFormat): (WebGPU::convertBindingLayout): * Source/WebGPU/WebGPU/Texture.h: * Source/WebGPU/WebGPU/Texture.mm:
[webkit-changes] [WebKit/WebKit] 2dbd2d: [IFC] ASSERTION FAILED inlineItem.layoutBox().isIn...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2dbd2d584b693ef9ca876f7f403609b8ee974a82 https://github.com/WebKit/WebKit/commit/2dbd2d584b693ef9ca876f7f403609b8ee974a82 Author: Alan Baradlay Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/fast/inline/inline-content-with-out-of-flow-assert-expected.txt A LayoutTests/fast/inline/inline-content-with-out-of-flow-assert.html M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp Log Message: --- [IFC] ASSERTION FAILED inlineItem.layoutBox().isInlineLevelBox() in InlineFormattingUtils::inlineItemWidth https://bugs.webkit.org/show_bug.cgi?id=266387 Reviewed by Antti Koivisto. Do not try to measure out-of-flow content while rebuilding the line due to "revert to last breaking position" type of content. * LayoutTests/fast/inline/inline-content-with-out-of-flow-assert-expected.txt: Added. * LayoutTests/fast/inline/inline-content-with-out-of-flow-assert.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::rebuildLineWithInlineContent): Canonical link: https://commits.webkit.org/272031@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aeda79: [WPE][Tools] cross-toolchain-helper: add libbacktr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aeda796b741149873575615d8e79224a7b264ef5 https://github.com/WebKit/WebKit/commit/aeda796b741149873575615d8e79224a7b264ef5 Author: Carlos Alberto Lopez Perez Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A Tools/yocto/meta-openembedded_backport-libbacktrace-patch-to-mickledore-branch.patch M Tools/yocto/riscv/manifest.xml M Tools/yocto/rpi/manifest.xml M Tools/yocto/targets.conf Log Message: --- [WPE][Tools] cross-toolchain-helper: add libbacktrace, libportal and change CPU frequency governor for RPis https://bugs.webkit.org/show_bug.cgi?id=266353 Reviewed by Philippe Normand. This updates the Yocto layers used for the RPi build with the following major changes: - meta-webkit: include libbacktrace and libportal into the base build. libbacktrace is required by the default build of WPE now and libportal is required by Cog since bug 266351 - meta-raspberrypi: stop setting "powersave" as the default CPU frequency governor and use "schedutil" instead. This will likely mean a big change in the performance results of all tests. See https://github.com/agherzan/meta-raspberrypi/pull/1243 for context. - poky, meta-openembedded: just update to the last version of the Mickledore branch - backport a change landed in meta-openembedded master to the Mickledore branch that updates libbacktrace to allow building it on riscv64. * Tools/yocto/meta-openembedded_backport-libbacktrace-patch-to-mickledore-branch.patch: Added. * Tools/yocto/riscv/manifest.xml: * Tools/yocto/rpi/manifest.xml: * Tools/yocto/targets.conf: Canonical link: https://commits.webkit.org/272030@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb5c6b: Switch to libwebrtc new DNS resolver interface
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb5c6b1cd67e74114df904d35df8bfcfba6c144c https://github.com/WebKit/WebKit/commit/fb5c6b1cd67e74114df904d35df8bfcfba6c144c Author: Youenn Fablet Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj A Source/WebKit/WebProcess/Network/webrtc/LibWebRTCDnsResolverFactory.cpp A Source/WebKit/WebProcess/Network/webrtc/LibWebRTCDnsResolverFactory.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.h M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h M Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp Log Message: --- Switch to libwebrtc new DNS resolver interface https://bugs.webkit.org/show_bug.cgi?id=265791 rdar://119133276 Reviewed by Eric Carlson. Migrate code from deprecated webrtc::AsyncResolverFactory to webrtc::AsyncDnsResolverFactory. This in particular simplifies how we do memory management, since the peer connection factory is now owned by the peer connection. We keep using a map of WeakPtr to allow to handle IPC responses from network process. We work around a header conflict between SDK and libwebrtc by isolating absl::InvokeCall in LibWebRTCDnsResolverFactory.cpp. * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp: (WebCore::LibWebRTCProvider::createPeerConnection): * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h: * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCDnsResolverFactory.cpp: Added. (WebKit::LibWebRTCDnsResolverFactory::CreateAndResolve): (WebKit::LibWebRTCDnsResolverFactory::Create): (WebKit::LibWebRTCDnsResolverFactory::Resolver::Start): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCDnsResolverFactory.h: Added. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp: (WebKit::LibWebRTCProvider::createPeerConnection): (WebKit::RTCSocketFactory::CreateAsyncDnsResolver): (WebKit::RTCSocketFactory::CreateAsyncResolver): Deleted. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.cpp: (WebKit::LibWebRTCResolver::~LibWebRTCResolver): (WebKit::LibWebRTCResolver::start): (WebKit::LibWebRTCResolver::result const): (WebKit::LibWebRTCResolver::setResolvedAddress): (WebKit::LibWebRTCResolver::setError): (WebKit::LibWebRTCResolver::Start): Deleted. (WebKit::LibWebRTCResolver::Destroy): Deleted. (WebKit::LibWebRTCResolver::doDestroy): Deleted. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.h: * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp: (WebKit::LibWebRTCSocketFactory::createAsyncDnsResolver): (WebKit::LibWebRTCSocketFactory::createAsyncResolver): Deleted. * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocketFactory.h: (WebKit::LibWebRTCSocketFactory::resolver): (WebKit::LibWebRTCSocketFactory::removeResolver): (WebKit::LibWebRTCSocketFactory::takeResolver): Deleted. * Source/WebKit/WebProcess/Network/webrtc/WebRTCResolver.cpp: (WebKit::WebRTCResolver::setResolvedAddress): (WebKit::WebRTCResolver::resolvedAddressError): Canonical link: https://commits.webkit.org/272029@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad1525: REGRESSION(271921@main): [GStreamer] ASSERTION FAI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad15255ae7caa863e7d7ad5c975ce266ebece5de https://github.com/WebKit/WebKit/commit/ad15255ae7caa863e7d7ad5c975ce266ebece5de Author: Philippe Normand Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h Log Message: --- REGRESSION(271921@main): [GStreamer] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) https://bugs.webkit.org/show_bug.cgi?id=266333 Reviewed by Xabier Rodriguez-Calvar. HashMap doesn't like to store key that evaluate to false, so a TrackID with value 0 would trigger an ASSERT. So switch back to unordered_map for tracks storage, and avoid std::views for access, which is not available in clang-14. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::startPlaybackIfHasAllTracks): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource): (WebCore::SourceBufferPrivateGStreamer::flush): (WebCore::SourceBufferPrivateGStreamer::enqueueSample): (WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples): (WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples): (WebCore::SourceBufferPrivateGStreamer::allSamplesInTrackEnqueued): (WebCore::SourceBufferPrivateGStreamer::precheckInitializationSegment): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: Canonical link: https://commits.webkit.org/272028@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b780dc: Many PaymentRequest tests are now passing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b780dcec56a9366a46589888b7ad9f807abaf610 https://github.com/WebKit/WebKit/commit/b780dcec56a9366a46589888b7ad9f807abaf610 Author: Abrar Rahman Protyasha Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-monterey-wk2/TestExpectations M LayoutTests/platform/mac-ventura-wk2/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Many PaymentRequest tests are now passing https://bugs.webkit.org/show_bug.cgi?id=266330 rdar://119599179 Unreviewed test expectations gardening. A lot of tests under `http/tests/paymentrequest/` were previously skipped on both macOS and iOS because they tested for features yet to be available in public versions of PassKit. This is no longer the case, so we can safely unskip these tests. The only kink comes from having to single out some tests to skip on macOS Monterey. These tests happen to be testing features available from macOS Ventura-onwards only. Some more tests still do not require the DumpJSConsoleLogInStdErr classification, either because they are not producing JS console logs or because their expectations have been rebaselined to reflect the console log. We also unskip these tests. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac-monterey-wk2/TestExpectations: * LayoutTests/platform/mac-ventura-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272027@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 845bcf: [GTK][WPE] Require 'wayland' 1.20 after 272021@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 845bcf162b240d28851bc92da33a0fb5e84f11e0 https://github.com/WebKit/WebKit/commit/845bcf162b240d28851bc92da33a0fb5e84f11e0 Author: Diego Pino Garcia Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/gtk/jhbuild.modules M Tools/jhbuild/jhbuild-minimal.modules M Tools/wpe/jhbuild.modules Log Message: --- [GTK][WPE] Require 'wayland' 1.20 after 272021@main https://bugs.webkit.org/show_bug.cgi?id=266394 Reviewed by Carlos Garcia Campos. Fixes linking error. Symbol 'wl_proxy_marshal_flags' is only defined since wayland 1.20. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/gtk/jhbuild.modules: * Tools/jhbuild/jhbuild-minimal.modules: * Tools/wpe/jhbuild.modules: Canonical link: https://commits.webkit.org/272026@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f3ddc: REGRESSION (271514@main): MSE Live playback fails ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f3ddc119f3ec5ccf79bf50cc76d3e81f03b1cba https://github.com/WebKit/WebKit/commit/9f3ddc119f3ec5ccf79bf50cc76d3e81f03b1cba Author: Jean-Yves Avenard Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/media/media-source/media-source-append-buffer-durationchange-expected.txt A LayoutTests/media/media-source/media-source-append-buffer-durationchange.html M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp M Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp Log Message: --- REGRESSION (271514@main): MSE Live playback fails on umediaserver.net https://bugs.webkit.org/show_bug.cgi?id=266385 rdar://119615258 Reviewed by Jer Noble. Changes in 271514@main exposed an underlying existing issue. The MediaSource's duration was initialised to NaN but the GPU process one was initialised to 0. Following 271514@main the inital value would be identical. If the media source duration was set prior any sourcebuffer being created, we wouldn't set the SourceBuffer initial duration, and the step `If the media segment contains data beyond the current duration, then run the duration change algorithm with new duration set to the maximum of the current duration and the [[group end timestamp]].` would always be skipped. We set the initial duration to the sourceBuffer when created. Add tests. * LayoutTests/media/media-source/media-source-append-buffer-durationchange-expected.txt: Added. * LayoutTests/media/media-source/media-source-append-buffer-durationchange.html: Added. * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer): * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::addSourceBuffer): * Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp: (WebCore::MockMediaSourcePrivate::addSourceBuffer): Canonical link: https://commits.webkit.org/272025@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c68a38: Duplicate requests due to speculative parsing with...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c68a38f2d6ebefb7a1d63d53ee6e5456327dd34a https://github.com/WebKit/WebKit/commit/c68a38f2d6ebefb7a1d63d53ee6e5456327dd34a Author: Youenn Fablet Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/http/wpt/service-workers/resources/serviceworker-and-preloads-iframe.html A LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-img.png A LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-img.png.headers A LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-script.js A LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-script.js.headers A LayoutTests/http/wpt/service-workers/serviceworker-and-preloads-expected.txt A LayoutTests/http/wpt/service-workers/serviceworker-and-preloads-worker.js A LayoutTests/http/wpt/service-workers/serviceworker-and-preloads.html M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/loader/cache/CachedResourceLoader.h Log Message: --- Duplicate requests due to speculative parsing with active service worker https://bugs.webkit.org/show_bug.cgi?id=250454 rdar://104377727 Reviewed by Chris Dumez. In case a service worker is located in the same process as a controlled document, they both share the same memory cache. Before the patch, in case of preloads triggered byt he speculative parser and the preloads are not cacheable, the following would happen: - Trigger a preload, which gets registered in the memory cache. - Let the service worker handle the preload, which triggers a fetch of the same resource. - This fetch will remove the preload resource from the memory cache and do the actual network load. - The real load of the HTML resource kicks in and tries to load the resource from the memory cache. - Given the resource is not a preload and is not reusable according the HTTP headers, a new load is triggered. This makes it so that two loads are happening for the same resource (one for the preload and one for the actual load). To resolve the issue, we do not add the service worker fetch resource in the memory cache in the following case: - There is an existing cached resource, which is a preload, and not a service worker request. - The new request is a service worker request. This ensures that we keep the preload cached resource in the memory cache which allows reuse when the actual load happens. * LayoutTests/http/wpt/service-workers/resources/serviceworker-and-preloads-iframe.html: Added. * LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-img.png: Added. * LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-img.png.headers: Added. * LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-script.js: Added. * LayoutTests/http/wpt/service-workers/resources/serviceworker-preload-script.js.headers: Added. * LayoutTests/http/wpt/service-workers/serviceworker-and-preloads-expected.txt: Added. * LayoutTests/http/wpt/service-workers/serviceworker-and-preloads-worker.js: Added. * LayoutTests/http/wpt/service-workers/serviceworker-and-preloads.html: Added. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest): (WebCore::computeShouldAddToMemoryCache): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::loadResource): * Source/WebCore/loader/cache/CachedResourceLoader.h: Canonical link: https://commits.webkit.org/272024@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 735eaa: Register application in the WebProcess on Catalyst
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 735eaa9151f8e86163800991b2e65f5ed5c8acfd https://github.com/WebKit/WebKit/commit/735eaa9151f8e86163800991b2e65f5ed5c8acfd Author: Per Arne Vollan Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Register application in the WebProcess on Catalyst https://bugs.webkit.org/show_bug.cgi?id=266350 rdar://119217913 Reviewed by Brent Fulgham. Call _RegisterApplication on Catalyst while holding a XPC sandbox extension. Calling this function without the sandbox extension will crash. * Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm * Source/WebKit/WebProcess/WebProcess.h * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): Canonical link: https://commits.webkit.org/272023@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ab17c: [web-animations] percentage transform values are i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ab17cf692e2176ae76cd00a44e48fb608faaf46 https://github.com/WebKit/WebKit/commit/6ab17cf692e2176ae76cd00a44e48fb608faaf46 Author: Antoine Quint Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height.html M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/KeyframeEffect.h Log Message: --- [web-animations] percentage transform values are incorrect if `width` and `height` are animated https://bugs.webkit.org/show_bug.cgi?id=211986 rdar://63309680 Reviewed by Simon Fraser. When animating the `transform` or `translate` property, we resolve percentage values for translate operations to fixed values. However, if the element also has an animation of `width` or `height`, the resolved translation values will no longer be correct while the animation is in flight. In that case, we need to detect such a case and turn off acceleration support. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height-separate.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/transform-percent-with-width-and-height.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height-separate.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/animation/translate-percent-with-width-and-height.html: Added. * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::setBlendingKeyframes): (WebCore::KeyframeEffect::canBeAccelerated const): (WebCore::KeyframeEffect::applyPendingAcceleratedActions): (WebCore::KeyframeEffect::computeHasSizeDependentTransform): * Source/WebCore/animation/KeyframeEffect.h: Canonical link: https://commits.webkit.org/272022@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f164e: [GTK][WPE] Require wayland-protocols 1.24 after 27...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f164e0610840a6127b54cc3c9c47e72c69f1983 https://github.com/WebKit/WebKit/commit/3f164e0610840a6127b54cc3c9c47e72c69f1983 Author: Diego Pino Garcia Date: 2023-12-14 (Thu, 14 Dec 2023) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/gtk/jhbuild.modules M Tools/jhbuild/jhbuild-minimal.modules M Tools/wpe/jhbuild.modules Log Message: --- [GTK][WPE] Require wayland-protocols 1.24 after 271330@main https://bugs.webkit.org/show_bug.cgi?id=266278 Reviewed by Carlos Garcia Campos. Changeset 271330@main makes use of function 'zwp_linux_dmabuf_v1_get_surface_feeback', which is only available since wayland-protocols v1.24. Also, update 'wayland' to 1.18 since it's the version available in the oldest system supported at this time, Ubuntu 20.04. Update JHBuild modules accordingly. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/gtk/jhbuild.modules: * Tools/jhbuild/jhbuild-minimal.modules: * Tools/wpe/jhbuild.modules: Canonical link: https://commits.webkit.org/272021@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
