[webkit-changes] [WebKit/WebKit] 842bf5: Adjust PreciseAllocation alignment offset to also ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 842bf586330dbf74f9e2d09d50c818ca3f792988 https://github.com/WebKit/WebKit/commit/842bf586330dbf74f9e2d09d50c818ca3f792988 Author: Mark Lam Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/JavaScriptCore/heap/PreciseAllocation.cpp M Source/JavaScriptCore/heap/PreciseAllocation.h Log Message: --- Adjust PreciseAllocation alignment offset to also factor in cache line alignment requirements. https://bugs.webkit.org/show_bug.cgi?id=262011 rdar://115959633 Reviewed by Keith Miller. We should ensure that the JSObject header word and its butterfly are always in the same cache line. See radar for details. All JSObjects are either allocated out of a MarkedBlock or as a PreciseAllocation. All MarkedBlock allocations are aligned on 16 byte boundaries (the MarkedBlock::atomSize). This means that it’s impossible to get this condition with a MarkedBlock allocated object. For PreciseAllocations, each allocation is preceded by a PreciseAllocation header (which is currently 96 bytes in size), and a 8 to 16 byte padding depending on what is need to get the resultant object start address to start on an odd 8 byte boundary (i.e. but 3 is set). With PreciseAllocations, depending on the size of the allocation and what memory slot the allocation comes from, there is a way to get the JSObject header and butterfly to span across a cache line boundary. This patch prevents this by dynamically adjusting the alignment padding at the start of the PreciseAllocation to ensure that the start address of the JSObject always lands at a spot where the header and butterfly does not span a cache line boundary. * Source/JavaScriptCore/heap/PreciseAllocation.cpp: (JSC::dataCacheLineSize): (JSC::isAlignedForPreciseAllocation): (JSC::isCacheAlignedForPreciseAllocation): (JSC::PreciseAllocation::tryCreate): (JSC::PreciseAllocation::tryReallocate): (JSC::PreciseAllocation::tryCreateForLowerTier): (JSC::PreciseAllocation::reuseForLowerTier): (JSC::PreciseAllocation::PreciseAllocation): * Source/JavaScriptCore/heap/PreciseAllocation.h: (JSC::PreciseAllocation::headerSize): (JSC::PreciseAllocation::basePointer const): Originally-landed-as: 267815.112@safari-7617-branch (6ea412c32f09). rdar://119594413 Canonical link: https://commits.webkit.org/272254@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0fa56e: Scoped Arguements needs to alias between named and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0fa56ec28b9251f4d6b73e7e963f27838c828bf6 https://github.com/WebKit/WebKit/commit/0fa56ec28b9251f4d6b73e7e963f27838c828bf6 Author: Michael Saboff Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A JSTests/stress/arrow-function-captured-arguments-aliased.js M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/GetPutInfo.h M Source/JavaScriptCore/runtime/ScopedArguments.h M Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp M Source/JavaScriptCore/runtime/ScopedArgumentsTable.h M Source/JavaScriptCore/runtime/SymbolTable.cpp M Source/JavaScriptCore/runtime/SymbolTable.h Log Message: --- Scoped Arguements needs to alias between named and unnamed accesses and across nested scopes https://bugs.webkit.org/show_bug.cgi?id=261934 rdar://114925088 Reviewed by Yusuke Suzuki. Fixed issue where an access to a named argument and a seperate access via its argument[i] counterpart weren't recognized throughout all JIT tiers as accesses to the same scoped value. The DFG bytecode parser can unknowingly constant fold the read access. Added aliasing via the SymbolTable and its ScopedArgumentsTable for both types of accesses of such values. related objects Added watchpoints for scoped arguments, and shared the watchpoint from the SymbolTableEntry for the named parameter with the ScopedArgument entry for the matching index. Tagged op_put_to_scope bytecodes with a new ScopedArgumentInitialization initialization type in GetPutInfo to signify this shared watchpoint case. Since currently all tiers write to scoped arguments via ScopedArguments::setIndexQuickly(), that is where we fire its watchpoint. Added a new test. * JSTests/stress/arrow-function-captured-arguments-aliased.js: New test. (createOptAll): (createOpt500): (createOpt2000): (createOpt5000): (main): * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::finishCreation): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/GetPutInfo.h: (JSC::initializationModeName): (JSC::isInitialization): * Source/JavaScriptCore/runtime/ScopedArguments.h: * Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp: (JSC::ScopedArgumentsTable::tryCreate): (JSC::ScopedArgumentsTable::tryClone): (JSC::ScopedArgumentsTable::trySetLength): (JSC::ScopedArgumentsTable::trySetWatchpointSet): * Source/JavaScriptCore/runtime/ScopedArgumentsTable.h: * Source/JavaScriptCore/runtime/SymbolTable.h: Originally-landed-as: 267815.345@safari-7617-branch (99b8814b73d1). rdar://119594814 Canonical link: https://commits.webkit.org/272253@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f9ac8: [WPE] WPE Platform: add stride parameter to WPEBuf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f9ac8dd937e4d715a84f4a6c5d6fdfec5704cd8 https://github.com/WebKit/WebKit/commit/1f9ac8dd937e4d715a84f4a6c5d6fdfec5704cd8 Author: Carlos Garcia Campos Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.h M Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp Log Message: --- [WPE] WPE Platform: add stride parameter to WPEBufferSHM constructor https://bugs.webkit.org/show_bug.cgi?id=266572 Reviewed by Adrian Perez de Castro. And use a explicit stride for the custom cursors API too. * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::setCursor): * Source/WebKit/UIProcess/wpe/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::didCreateBufferSHM): * Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp: (wpeBufferSHMGetProperty): (wpe_buffer_shm_class_init): (wpe_buffer_shm_new): (wpe_buffer_shm_get_stride): * Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.h: * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_set_cursor_from_bytes): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.cpp: (WPE::DRM::Cursor::updateBuffer): (WPE::DRM::Cursor::setFromName): (WPE::DRM::Cursor::setFromBytes): * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMCursor.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEViewDRM.cpp: (wpeViewDRMSetCursorFromBytes): * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (sharedMemoryBufferCreate): (createWaylandBufferSHM): Canonical link: https://commits.webkit.org/272252@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d9001: jsc_fuz/wktr: null ptr deref in WebCore::invokeWri...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d900198ca1e68cca80a4b2f0d4251d661a41361 https://github.com/WebKit/WebKit/commit/8d900198ca1e68cca80a4b2f0d4251d661a41361 Author: Erica Li Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/streams/writable-stream-create-within-multiple-workers-crash-expected.txt A LayoutTests/streams/writable-stream-create-within-multiple-workers-crash.html M Source/WebCore/bindings/js/InternalWritableStream.cpp M Tools/DumpRenderTree/mac/DumpRenderTree.mm Log Message: --- jsc_fuz/wktr: null ptr deref in WebCore::invokeWritableStreamFunction(...) (InternalWritableStream.cpp:49) https://bugs.webkit.org/show_bug.cgi\?id\=262865 rdar://116465595 Reviewed by Mark Lam. Return early when worker is terminated while trying to get function from globalObject. Set useDollarVM in test option initialization for cases when useDollarVM will be reset before injectInternalsObject is called in DRT. * LayoutTests/streams/writable-stream-create-within-multiple-workers-crash-expected.txt: Added. * LayoutTests/streams/writable-stream-create-within-multiple-workers-crash.html: Added. * Source/WebCore/bindings/js/InternalWritableStream.cpp: (WebCore::invokeWritableStreamFunction): * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (testOptionsForTest): Originally-landed-as: 267815.398@safari-7617-branch (f11c81a103a8). rdar://119596601 Canonical link: https://commits.webkit.org/272251@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a94a8a: Restrict the length of requested web locks names
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a94a8a66a84945d4356362880cd19e17b2a0cc7b https://github.com/WebKit/WebKit/commit/a94a8a66a84945d4356362880cd19e17b2a0cc7b Author: Chris Dumez Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/http/wpt/web-locks/lock-name-length-restriction.https-expected.txt A LayoutTests/http/wpt/web-locks/lock-name-length-restriction.https.html M Source/WebCore/Headers.cmake M Source/WebCore/Modules/web-locks/WebLock.h M Source/WebCore/Modules/web-locks/WebLockManager.cpp M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebKit/UIProcess/WebLockRegistryProxy.cpp Log Message: --- Restrict the length of requested web locks names https://bugs.webkit.org/show_bug.cgi?id=262920 rdar://116189077 Reviewed by Brent Fulgham. Restrict the length of requested web locks names to prevent abuse. * LayoutTests/http/wpt/web-locks/lock-name-length-restriction.https-expected.txt: Added. * LayoutTests/http/wpt/web-locks/lock-name-length-restriction.https.html: Added. * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/web-locks/WebLock.h: * Source/WebCore/Modules/web-locks/WebLockManager.cpp: (WebCore::WebLockManager::request): * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebKit/UIProcess/WebLockRegistryProxy.cpp: (WebKit::WebLockRegistryProxy::requestLock): Originally-landed-as: 267815.246@safari-7617-branch (85aba6be5983). rdar://119577065 Canonical link: https://commits.webkit.org/272250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b3d60d: [UIAsyncTextInput] Edit menu no longer appears aft...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3d60d3c58c67657877e68a71974f2f982e33a93 https://github.com/WebKit/WebKit/commit/b3d60d3c58c67657877e68a71974f2f982e33a93 Author: Wenson Hsieh Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm Log Message: --- [UIAsyncTextInput] Edit menu no longer appears after selecting text in Books https://bugs.webkit.org/show_bug.cgi?id=266612 rdar://119843215 Reviewed by Megan Gardner. Disable async text input by default in Books for the time being, until Books moves off of `UIWKInteractionViewProtocol` in rdar://119836700. * Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::defaultUseAsyncUIKitInteractions): Canonical link: https://commits.webkit.org/272249@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57feb7: Devirtualize more RenderObject type checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57feb7424beb442bf5df7ca404f4439bbad72717 https://github.com/WebKit/WebKit/commit/57feb7424beb442bf5df7ca404f4439bbad72717 Author: Ryosuke Niwa Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderImage.cpp M Source/WebCore/rendering/RenderImage.h M Source/WebCore/rendering/RenderMedia.cpp M Source/WebCore/rendering/RenderMedia.h M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderReplaced.cpp M Source/WebCore/rendering/RenderReplaced.h M Source/WebCore/rendering/RenderWidget.cpp M Source/WebCore/rendering/RenderWidget.h M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp Log Message: --- Devirtualize more RenderObject type checks https://bugs.webkit.org/show_bug.cgi?id=266592 Reviewed by Chris Dumez. This PR adds more RenderElementType flags to devirtualize more type check functions. Also add Flag suffix to LegacyRenderSVGContainer and RenderSVGContainer for consistency. Also delete isMultiColumnBlockFlow(), which is never used. * Source/WebCore/rendering/RenderBlockFlow.h: * Source/WebCore/rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): * Source/WebCore/rendering/RenderImage.h: * Source/WebCore/rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): * Source/WebCore/rendering/RenderMedia.h: * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::isRenderMedia const): (WebCore::RenderObject::isRenderImage const): (WebCore::RenderObject::isRenderWidget const): (WebCore::RenderObject::isRenderSVGContainer const): (WebCore::RenderObject::isLegacyRenderSVGContainer const): (WebCore::RenderObject::isMultiColumnBlockFlow const): Deleted. * Source/WebCore/rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): * Source/WebCore/rendering/RenderReplaced.h: (WebCore::RenderReplaced::RenderReplaced): * Source/WebCore/rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): * Source/WebCore/rendering/RenderWidget.h: (WebCore::RenderWidget::isRenderWidget): Deleted. * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp: (WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer): Canonical link: https://commits.webkit.org/272248@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e2912: REGRESSION(272224@main): [Win] ERROR: Received an ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e291227dab70f63312aeacb9a17ac31d54695a1 https://github.com/WebKit/WebKit/commit/6e291227dab70f63312aeacb9a17ac31d54695a1 Author: Fujii Hironori Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp Log Message: --- REGRESSION(272224@main): [Win] ERROR: Received an invalid message 'GPUConnectionToWebProcess_CreateRenderingBackend' from WebContent process 10, requesting for it to be terminated. https://bugs.webkit.org/show_bug.cgi?id=266597 Unreviewed crash fix for Windows port. After 272224@main changed DrawingArea creation time, RemoteImageBufferSetProxy wasn't properly constructed in DrawingAreaWC constructor. Creating a RemoteImageBufferSetProxy should be deferred. * Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp: Canonical link: https://commits.webkit.org/272247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 034582: Verifying user gestures doesn’t work when opening ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0345820aee4313ca1a9ec8f7d9e77ebe92c7dd4c https://github.com/WebKit/WebKit/commit/0345820aee4313ca1a9ec8f7d9e77ebe92c7dd4c Author: Charlie Wolfe Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/page/EventHandler.cpp M Source/WebKit/Shared/WebEventConversion.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm Log Message: --- Verifying user gestures doesn’t work when opening a window on a key event https://bugs.webkit.org/show_bug.cgi?id=266590 rdar://119826688 Reviewed by Pascoe. We weren’t passing the authorization token to `UserGestureIndicator` and it was lost when converting the event to a platform key event. Also remove a redundant call to `recordUserGestureAuthorizationToken()`. It’s called in `sendKeyEvent()` * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::internalKeyEvent): * Source/WebKit/Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleKeyboardEvent): * Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272246@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c9f8f: Gamepad's getGamepads() should return an empty arr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c9f8fb6a98d5c005105f19b3930b022b5fafaec https://github.com/WebKit/WebKit/commit/9c9f8fb6a98d5c005105f19b3930b022b5fafaec Author: Marcos Caceres Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/gamepad/gamepad-non-fully-active-expected.txt A LayoutTests/gamepad/gamepad-non-fully-active.html M Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp Log Message: --- Gamepad's getGamepads() should return an empty array when not fully active. https://bugs.webkit.org/show_bug.cgi?id=266450 rdar://119702262 Reviewed by Youenn Fablet. Now checks if document is fully active. Aligns with other browsers, specially Firefox, and the spec. * LayoutTests/gamepad/gamepad-non-fully-active-expected.txt: Added. * LayoutTests/gamepad/gamepad-non-fully-active.html: Added. * Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp: (WebCore::NavigatorGamepad::getGamepads): Canonical link: https://commits.webkit.org/272245@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5a6f7: [commits.webkit.org] Individually push commits to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5a6f77e96c84a92eb3983a3203dafd70bc4385f https://github.com/WebKit/WebKit/commit/c5a6f77e96c84a92eb3983a3203dafd70bc4385f Author: Jonathan Bedard Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py Log Message: --- [commits.webkit.org] Individually push commits to mirrored repositories https://bugs.webkit.org/show_bug.cgi?id=266595 rdar://119830188 Reviewed by Alexey Proskuryakov. * Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py: (Checkout.push_update): If less than 50 commits are being synced, push them individually. Canonical link: https://commits.webkit.org/272244@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d53053: Port PopupMenuSize to the new IPC serialization fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d53053272d0deb10e08ef4a5cf0a01cdea69a692 https://github.com/WebKit/WebKit/commit/d53053272d0deb10e08ef4a5cf0a01cdea69a692 Author: Claudio Saavedra Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/PopupMenuStyle.h M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/Shared/PlatformPopupMenuData.h M Source/WebKit/Shared/PlatformPopupMenuData.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm Log Message: --- Port PopupMenuSize to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266584 Reviewed by Aditya Keerthi. Remove the EnumTraits for PopupMenuSize and also take the chance to rename the enum to remove redundance, both in its name and their elements. * Source/WebCore/platform/PopupMenuStyle.h: (WebCore::PopupMenuStyle::PopupMenuStyle): (WebCore::PopupMenuStyle::menuSize const): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::popupMenuSize const): * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::popupMenuSize const): * Source/WebKit/Shared/PlatformPopupMenuData.h: * Source/WebKit/Shared/PlatformPopupMenuData.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::showPopupMenu): * Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::show): Canonical link: https://commits.webkit.org/272243@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc5c0b: [UIAsyncTextInput] Respect UIKit/async_text_input_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc5c0bf1476ad4be35974c83d93b4586fc77fda7 https://github.com/WebKit/WebKit/commit/cc5c0bf1476ad4be35974c83d93b4586fc77fda7 Author: Wenson Hsieh Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm Log Message: --- [UIAsyncTextInput] Respect UIKit/async_text_input_(iphone|ipad) after rdar://119688719 https://bugs.webkit.org/show_bug.cgi?id=266586 rdar://119818867 Reviewed by Richard Robinson. UIKit is splitting the `async_text_input` feature flag out into `async_text_input_iphone` and `async_text_input_ipad` in rdar://119688719. To keep async text input enabled after this change, we need to tweak our enablement logic to match these new names. * Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm: (WebKit::isAsyncTextInputFeatureFlagEnabled): Pull this feature flag check out into a common helper method, and also continue checking against the old `UIKit/async_text_input` name to make sure we don't inadvertently disable the feature on current versions of UIKit in the build. (WebKit::defaultUseAsyncUIKitInteractions): (WebKit::defaultWriteRichTextDataWhenCopyingOrDragging): Canonical link: https://commits.webkit.org/272242@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9f68a: [JHBuild] Update libvpx to v1.11.0
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9f68ae584fa9e2012ff092b0f23163df12d0f21 https://github.com/WebKit/WebKit/commit/b9f68ae584fa9e2012ff092b0f23163df12d0f21 Author: Max Schmitt Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/jhbuild/jhbuild-minimal.modules Log Message: --- [JHBuild] Update libvpx to v1.11.0 https://bugs.webkit.org/show_bug.cgi?id=266515 Reviewed by Philippe Normand. This makes WebKit with JHBuild compile under clang 17. * Tools/jhbuild/jhbuild-minimal.modules: Canonical link: https://commits.webkit.org/272241@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 52b154: TestWebKitAPI.WKWebExtensionAPITabs.ActiveTab is f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 52b154a911f1b2450d8d73569b70599a6b6e9974 https://github.com/WebKit/WebKit/commit/52b154a911f1b2450d8d73569b70599a6b6e9974 Author: Timothy Hatcher Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm Log Message: --- TestWebKitAPI.WKWebExtensionAPITabs.ActiveTab is flaky. https://webkit.org/b/266594 rdar://119346255 Reviewed by Brian Weinstein. The URL does not change for tabs during the provisional load, and saying it was changing was causing the onChanged event to fire too soon for this test to be accurate. Also tweak how we check for properties in the changeInfo object to be consistent. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm: (-[TestWebExtensionTab webView:didStartProvisionalNavigation:]): (-[TestWebExtensionTab webView:didReceiveServerRedirectForProvisionalNavigation:]): (-[TestWebExtensionTab webView:didFailNavigation:withError:]): Canonical link: https://commits.webkit.org/272240@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c19e45: [Gardening]: [Debug] compositing/layer-creation/sc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c19e455188982687ea6671e17c5035d73aaf40ad https://github.com/WebKit/WebKit/commit/c19e455188982687ea6671e17c5035d73aaf40ad Author: Marta Darbinyan Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening]: [Debug] compositing/layer-creation/scale-rotation-transition-overlap.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=266477 rdar://119719565 Unreviewed test gardening. Adding test expectation * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/272239@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5d367b: [Gardening]: REGRESSION (263917@main?): [ Sonoma D...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5d367b09ef696d944cfb6af376ec48ca3c964794 https://github.com/WebKit/WebKit/commit/5d367b09ef696d944cfb6af376ec48ca3c964794 Author: Marta Darbinyan Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (263917@main?): [ Sonoma Debug wk2 x86_64 ] 3 tests in inspector/timeline are flaky crash with ASSERTION FAILED in void WebCore::InspectorTimelineAgent::didCompleteCurrentRecord(TimelineRecordType) https://bugs.webkit.org/show_bug.cgi?id=266591 rdar://119828743 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272238@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dcd6c4: WKWebExtensionAPITabs.RemovedEvent is flaky (somet...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dcd6c460a0327bcd8a2efef461ba9280bb7a7090 https://github.com/WebKit/WebKit/commit/dcd6c460a0327bcd8a2efef461ba9280bb7a7090 Author: Timothy Hatcher Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- WKWebExtensionAPITabs.RemovedEvent is flaky (sometimes wrong tab ID). https://webkit.org/b/261848 rdar://problem/115809590 Unreviewed test gardening. Enable the WKWebExtensionAPITabs.RemovedEvent test, since it no longer fails after hundreds of iterations. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272237@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdd1ff: REGRESSION (271259@main?): [ iOS Sonoma Debug arm6...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdd1ff775c0c2b996e545ddf82b564f31c575227 https://github.com/WebKit/WebKit/commit/fdd1ff775c0c2b996e545ddf82b564f31c575227 Author: Timothy Hatcher Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- REGRESSION (271259@main?): [ iOS Sonoma Debug arm64 ] TestWebKitAPI.WKWebExtensionAPITabs.SendMessageWithPromiseReply timeout https://webkit.org/b/266518 rdar://problem/119740501 Reviewed by Brian Weinstein. Adopt EagerCallbackAggregator for the reply handler. This was added on the UIProcess side for the message sending in 271636@main. It can also be used here, with the help of an ObjC wrapper object that can keep the aggregator in scope for the required blocks. We can't use BlockPtr for these since the JSValue ObjC translation requires blocks to have a signature to translate them into JavaScript functions, which is only for compiled blocks. Without this, the aggregator falls out of scope and is released. Added additional tests to make sure async replies work in addition to sync replies. Also adopted optional chaining for some tests since an exception is thrown when response is null. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm: (-[_WKReplyCallbackAggregator initWithAggregator:]): Added. (-[_WKReplyCallbackAggregator aggregator]): Added. (WebKit::WebExtensionContextProxy::internalDispatchRuntimeMessageEvent): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/272236@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df351d: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df351d09b73840cdb1b36cba19f7a87504347516 https://github.com/WebKit/WebKit/commit/df351d09b73840cdb1b36cba19f7a87504347516 Author: Fujii Hironori Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/272235@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41c56e: [WebGPU] Remove old samples under Websites/webkit....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41c56ede89a5ebd7742ce3937a1bd0d7be2846ac https://github.com/WebKit/WebKit/commit/41c56ede89a5ebd7742ce3937a1bd0d7be2846ac Author: Mike Wyrzykowski Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Websites/webkit.org/demos/webgpu/index.html A Websites/webkit.org/demos/webgpu/resources/animometer.png R Websites/webkit.org/demos/webgpu/resources/babylon-helmet.png R Websites/webkit.org/demos/webgpu/resources/babylon-sphere.png A Websites/webkit.org/demos/webgpu/resources/bitonic-sort.png M Websites/webkit.org/demos/webgpu/resources/compute-blur.png M Websites/webkit.org/demos/webgpu/resources/compute-boids.png M Websites/webkit.org/demos/webgpu/resources/hello-cube.png M Websites/webkit.org/demos/webgpu/resources/hello-triangle.png R Websites/webkit.org/demos/webgpu/resources/motionmark.jpeg A Websites/webkit.org/demos/webgpu/resources/photon-mapping.png M Websites/webkit.org/demos/webgpu/resources/textured-cube.png A Websites/webkit.org/demos/webgpu/resources/video-uploading.png R Websites/webkit.org/demos/webgpu/resources/webkit-logo.png Log Message: --- [WebGPU] Remove old samples under Websites/webkit.org/demos/webgpu/ https://bugs.webkit.org/show_bug.cgi?id=265432 Reviewed by Dan Glastonbury. https://webkit.org/demos/webgpu/ was pointing to old samples which do not function as they were built against outdated versions of the specification. Update index.html to direct to the publically maintained GitHub samples which function in ToT builds of WebKit. * Websites/webkit.org/demos/webgpu/index.html: * Websites/webkit.org/demos/webgpu/resources/animometer.png: Added. * Websites/webkit.org/demos/webgpu/resources/babylon-helmet.png: Removed. * Websites/webkit.org/demos/webgpu/resources/babylon-sphere.png: Removed. * Websites/webkit.org/demos/webgpu/resources/bitonic-sort.png: Added. * Websites/webkit.org/demos/webgpu/resources/compute-blur.png: * Websites/webkit.org/demos/webgpu/resources/compute-boids.png: * Websites/webkit.org/demos/webgpu/resources/hello-cube.png: * Websites/webkit.org/demos/webgpu/resources/hello-triangle.png: * Websites/webkit.org/demos/webgpu/resources/motionmark.jpeg: Removed. * Websites/webkit.org/demos/webgpu/resources/photon-mapping.png: Added. * Websites/webkit.org/demos/webgpu/resources/textured-cube.png: * Websites/webkit.org/demos/webgpu/resources/video-uploading.png: Added. * Websites/webkit.org/demos/webgpu/resources/webkit-logo.png: Removed. Canonical link: https://commits.webkit.org/272234@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 043e71: [iOS] Prepare API tests for async text input enabl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 043e71bfb0158320e9539bfb750d7e74bd9f5d7b https://github.com/WebKit/WebKit/commit/043e71bfb0158320e9539bfb750d7e74bd9f5d7b Author: Wenson Hsieh Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: R Source/WebKit/UIProcess/API/ios/WKSEDefinitions.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm A Source/WebKit/UIProcess/ios/WKSEDefinitions.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm M Tools/TestWebKitAPI/Tests/ios/EnterKeyHintTests.mm M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm M Tools/TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm M Tools/TestWebKitAPI/Tests/ios/TextServicesTests.mm M Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm M Tools/TestWebKitAPI/cocoa/TestWKWebView.h M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm M Tools/WebKitTestRunner/Configurations/Base.xcconfig M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm Log Message: --- [iOS] Prepare API tests for async text input enablement https://bugs.webkit.org/show_bug.cgi?id=266578 rdar://119816733 Reviewed by Aditya Keerthi. Prepare our API tests for async text input enablement on iOS, many of which currently call into legacy SPI methods that crash with the feature flag enabled. To avoid these release assertions, we refactor all tests which explicitly call into these codepaths, such that they'll invoke their `UIAsyncTextInput` counterparts when `UIKit/async_text_input` is enabled. See below for more details. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView moveInDirection:byGranularity:]): (-[WKContentView extendInDirection:byGranularity:]): Also drive-by fix an actual bug that was caught by `SelectionTests.ModifyByParagraphBoundary`. Instead of just moving backward or forward by paragraph granularity in the `UIAsyncTextInput` method `-extendInDirection:byGranularity:`, we need to additionally move backwards or forwards by character before doing so in order to maintain parity with `-_moveToEndOfParagraph:withHistory:` and `_moveToStartOfParagraph:withHistory:`. * Source/WebKit/UIProcess/ios/WKSEDefinitions.h: Renamed from Source/WebKit/UIProcess/API/ios/WKSEDefinitions.h. Also move `WKSEDefinitions.h` to `UIProcess/ios` instead of `UIProcess/API/ios`, since the latter just holds iOS-specific files related to WebKit API objects (in this case, only `WKWebView`). Putting this in `UIProcess/ios` seems more appropriate, and also allows us to include it directly in WebKitTestRunner. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestRunnerShared/spi/UIKitSPIForTesting.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]): Deleted. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm: (TestWebKitAPI::simulateEditContextMenuAppearance): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: (TestWebKitAPI::simulateEditContextMenuAppearance): * Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm: (-[TestWKWebView autocorrectionRectsForString:]): Deleted. (-[TestWKWebView synchronouslyRequestAutocorrectionContext]): Deleted. * Tools/TestWebKitAPI/Tests/ios/EnterKeyHintTests.mm: (-[TestWKWebView test:enterKeyHint:returnKeyType:]): * Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: * Tools/TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm: * Tools/TestWebKitAPI/Tests/ios/TextServicesTests.mm: * Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm: * Tools/TestWebKitAPI/cocoa/TestWKWebView.h: * Tools/TestWebKitAPI/cocoa/TestWKWebView.mm: Add a bunch of new category helpers on `WKWebView`, which replace many of the direct calls into `WKContentView` in our API tests when exercising various `UIWKInteractionViewProtocol` SPIs. These helper methods will call directly into these legacy SPIs when async text input is disabled, but will call into their new `UIAsyncTextInput` counterparts when async text input is enabled. (-[WKWebView defineSelection]): (-[WKWebView shareSelection]): (-[WKWebView hasAsyncTextInput]): (-[WKWebView selectionClipRect]): (-[WKWebView moveSelectionToStartOfParagraph]): (-[WKWebView extendSelectionToStartOfParagraph]): (-[WKW
[webkit-changes] [WebKit/WebKit] d3ed62: [css-grid] Fix broken link in RenderGrid
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3ed6221dc410ffaaac9adec51f019242ebb3c36 https://github.com/WebKit/WebKit/commit/d3ed6221dc410ffaaac9adec51f019242ebb3c36 Author: Brandon Stewart Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderGrid.cpp Log Message: --- [css-grid] Fix broken link in RenderGrid https://bugs.webkit.org/show_bug.cgi?id=266585 Reviewed by Tim Nguyen. Link to spec was broken; fixed it. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid): Canonical link: https://commits.webkit.org/272232@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53683c: Adding last resort font to System Font fallback se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53683ca2146f70a7f63c8757f6a7106bfa53effe https://github.com/WebKit/WebKit/commit/53683ca2146f70a7f63c8757f6a7106bfa53effe Author: Russell Epstein Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/fonts/font-cache-memory-pressure-crash-expected.txt A LayoutTests/fonts/font-cache-memory-pressure-crash.html M Source/WebCore/platform/graphics/FontCascadeFonts.cpp Log Message: --- Adding last resort font to System Font fallback set for PUA characters https://bugs.webkit.org/show_bug.cgi?id=264737 rdar://117805319 Reviewed by Brent Fulgham. Until now, when we are purging inactive font data, we would just clear the glyph page cache if we had to purge system fallback font. This means that we consider glyph page cache would only point to fonts from system fonts fallback. When we are handling unicode's in the Private-User-Area (PUA) block, we shouldn't fallback to system fonts searching for a font that can render it, per spec: https://www.w3.org/TR/css-fonts-4/#char-handling-issues Instead, we render the glyph 0 with the last resort font. However, this font is just added to the custom font cache, and its font pointer in the Glyph Page cache is not cleared during memory pressure. We should add this font to the system font fallback set, to make sure that the associated font pointer is removed from the glyph page cache during memory pressure. * LayoutTests/fonts/font-cache-memory-pressure-crash.html: Added. * Source/WebCore/platform/graphics/FontCascadeFonts.cpp: (WebCore::FontCascadeFonts::glyphDataForVariant): * LayoutTests/fonts/font-cache-memory-pressure-crash-expected.txt: Added. Originally-landed-as: a595ddd8348d. rdar://119598929 Canonical link: https://commits.webkit.org/272231@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7ea15: Add a test for mouse event user gesture verificati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7ea1558b098508ff973b6f825b5b9e4a24f8a02 https://github.com/WebKit/WebKit/commit/d7ea1558b098508ff973b6f825b5b9e4a24f8a02 Author: Charlie Wolfe Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/TestWebKitAPI/SourcesCocoa.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm Log Message: --- Add a test for mouse event user gesture verification for window.open() https://bugs.webkit.org/show_bug.cgi?id=266562 rdar://119793659 Reviewed by Pascoe. Add a test to make sure the feature `verifyWindowOpenUserGestureFromUIProcess` works correctly when a mouse event is used to open a window. The import in WKWebExtensionAPIDeclarativeNetRequest.mm is needed for unified sources. * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/VerifyUserGestureFromUIProcess.mm: Added. (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm: Canonical link: https://commits.webkit.org/272230@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a5a2d: REGRESSION (UI-side compositing): Unable to scroll...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a5a2dc6d7b110ce9ee677a6f033b51343b1ddb0 https://github.com/WebKit/WebKit/commit/3a5a2dc6d7b110ce9ee677a6f033b51343b1ddb0 Author: Simon Fraser Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/view-gestures/smart-magnify/double-tap-zoom-scroll-above-top-expected.html A LayoutTests/view-gestures/smart-magnify/double-tap-zoom-scroll-above-top.html M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm Log Message: --- REGRESSION (UI-side compositing): Unable to scroll to top of page after double tapping trackpad causes page to scroll down https://bugs.webkit.org/show_bug.cgi?id=266529 rdar://116419609 Reviewed by Tim Horton. The smart magnify gesture (two-finger double tap on the trackpad) results in some combination of scrolling and zooming. `RemoteLayerTreeDrawingAreaProxyMac::commitTransientZoom()` uses a CAAnimation to animate to the final state, but the completion handler of that animation put the transform directly onto the `layerForPageScale`. That's OK if the gesture results in a scale change; that transform will get replaced by one that comes from the web process. However, if a gesture just resulted in a scroll with no scale change, we never get a new transform from the web process, so we leave that transform on `layerForPageScale`. This transform has a translation baked in, so this causes a permanent scroll offset. So we have to stop shoving the transform onto this layer. This revealed an issue where there was a jump when the animation was removed. Fixing this just requires two things: 1. Delay removing the transient zoom animations until we know the web process has committed the new scale and scroll position (via a `callAfterNextPresentationUpdate()`). 2. Override any scroll position changes that come from the web process before this by adding a CAAnimation onto the scrolled contents layer which overrides the `position` property. If we don't do this, scroll position changes cause a flash of offset content. This requires tracking m_pageScrollingLayerID, but that information was already in the transaction for banner hookup. * LayoutTests/view-gestures/smart-magnify/double-tap-zoom-scroll-above-top-expected.html: Added. * LayoutTests/view-gestures/smart-magnify/double-tap-zoom-scroll-above-top.html: Added. * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::didCommitLayerTree): (WebKit::fillFowardsAnimationWithKeyPath): (WebKit::transientZoomTransformOverrideAnimation): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::applyTransientZoomToLayer): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::removeTransientZoomFromLayer): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::commitTransientZoom): (WebKit::RemoteLayerTreeDrawingAreaProxyMac::sendCommitTransientZoom): Canonical link: https://commits.webkit.org/272229@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc7eb6: [PlayStation] Downgrade curl to 7.85.0
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc7eb618e38637aa88ce789c16716bd9309f58cf https://github.com/WebKit/WebKit/commit/cc7eb618e38637aa88ce789c16716bd9309f58cf Author: Ross Kirsling Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/network/curl/CurlContext.cpp M Source/WebCore/platform/network/curl/CurlRequest.cpp M Source/cmake/OptionsPlayStation.cmake Log Message: --- [PlayStation] Downgrade curl to 7.85.0 https://bugs.webkit.org/show_bug.cgi?id=266583 Reviewed by Don Olmstead. Build fix -- revert 263486@main and 263783@main for PlayStation. * Source/WebCore/platform/network/curl/CurlContext.cpp: (WebCore::CurlHandle::enableHttp): * Source/WebCore/platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::didReceiveHeader): (WebCore::CurlRequest::didReceiveData): * Source/cmake/OptionsPlayStation.cmake: Canonical link: https://commits.webkit.org/272228@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 03bbe6: [Ruby] fast/ruby/ruby-expansion-cjk-*-expected.htm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03bbe6785b7dea8461f0b1203a1284f063860363 https://github.com/WebKit/WebKit/commit/03bbe6785b7dea8461f0b1203a1284f063860363 Author: Alan Baradlay Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/fast/ruby/ruby-expansion-cjk-2-expected.html M LayoutTests/fast/ruby/ruby-expansion-cjk-2.html M LayoutTests/fast/ruby/ruby-expansion-cjk-3-expected.html M LayoutTests/fast/ruby/ruby-expansion-cjk-3.html M LayoutTests/fast/ruby/ruby-expansion-cjk-5-expected.html M LayoutTests/fast/ruby/ruby-expansion-cjk-5.html M LayoutTests/fast/ruby/ruby-expansion-cjk-expected.html M LayoutTests/fast/ruby/ruby-expansion-cjk.html M LayoutTests/fast/ruby/ruby-justification-expected.html M LayoutTests/fast/ruby/ruby-justification.html Log Message: --- [Ruby] fast/ruby/ruby-expansion-cjk-*-expected.html content is just a set of out-of-flow boxes https://bugs.webkit.org/show_bug.cgi?id=266580 Reviewed by Antti Koivisto. Replace this visual tree dump with slightly more flexible, inline content. * LayoutTests/TestExpectations: * LayoutTests/fast/ruby/ruby-expansion-cjk-2-expected.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-2.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-3-expected.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-3.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-5-expected.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-5.html: * LayoutTests/fast/ruby/ruby-expansion-cjk-expected.html: * LayoutTests/fast/ruby/ruby-expansion-cjk.html: * LayoutTests/fast/ruby/ruby-justification-expected.html: * LayoutTests/fast/ruby/ruby-justification.html: Canonical link: https://commits.webkit.org/272227@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3015bb: [Wasm-GC] Module linking should take subtyping int...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3015bbe0e8abf05249481775c75b494e3548fd74 https://github.com/WebKit/WebKit/commit/3015bbe0e8abf05249481775c75b494e3548fd74 Author: Asumu Takikawa Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M JSTests/wasm/gc-spec-tests/type-subtyping.wast.js A JSTests/wasm/gc/linking.js M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp Log Message: --- [Wasm-GC] Module linking should take subtyping into account https://bugs.webkit.org/show_bug.cgi?id=260039 Reviewed by Justin Michaud. Use subtyping for module linking in general. Also add and re-enable more tests about linking. Note: we don't add subtyping for exception tags for now, because the exception proposal is in flux. * JSTests/wasm/gc-spec-tests/type-subtyping.wast.js: * JSTests/wasm/gc/linking.js: Added. (testLinking): * Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp: (JSC::WebAssemblyModuleRecord::initializeImports): Canonical link: https://commits.webkit.org/272226@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eea16f: [ews] Develop orange status-bubble equivalent in G...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eea16f7ff6cd7188f8f46d04ff7659bb210707b7 https://github.com/WebKit/WebKit/commit/eea16f7ff6cd7188f8f46d04ff7659bb210707b7 Author: Aakash Jain Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Tools/CISupport/ews-app/ews/common/github.py Log Message: --- [ews] Develop orange status-bubble equivalent in Github status-bubbles https://bugs.webkit.org/show_bug.cgi?id=244054 Reviewed by Jonathan Bedard. * Tools/CISupport/ews-app/ews/common/github.py: (GitHubEWS): Canonical link: https://commits.webkit.org/272225@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 764b42: Page and DrawingArea's root frame collections shou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 764b4263af17c189ca7ed6f197f3a216f4d9d96b https://github.com/WebKit/WebKit/commit/764b4263af17c189ca7ed6f197f3a216f4d9d96b Author: Alex Christensen Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/bindings/js/WindowProxy.cpp M Source/WebCore/loader/EmptyClients.h M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/FocusController.h M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp M Source/WebKit/WebProcess/WebPage/DrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h Log Message: --- Page and DrawingArea's root frame collections should be updated with LocalFrame lifetime https://bugs.webkit.org/show_bug.cgi?id=266105 rdar://116202445 Reviewed by Pascoe. Before this PR we were calling addRootFrame in an ad-hoc manner, and we weren't calling remoteRootFrame at all except confusingly in the LocalFrame constructor, which was quite incorrect. This caused memory leaks and crashes when site isolation was enabled. To fix this, I call addRootFrame in the LocalFrame constructor and removeRootFrame in the LocalFrame destructor. During the destructor call, we can't reliably check the parent frame because it may have also been destroyed, so I cache the value of whether the LocalFrame is a root frame using a const bool member function. I use the ChromeClient to tell the WebPage's DrawingArea about the creation and destruction of root frames. In order to successfully draw after this root frame lifetime management change, I needed the WebPage to already have a DrawingArea when the main frame is constructed, which required moving it up in the list of constructed members of the WebPage. When I did this, though, the calls to WebPage::corePage in the DrawingArea constructors returned null because the DrawingArea was being constructed before the WebCore::Page. To fix this, I just moved the settings update code from the DrawingArea constructors to the WebPage constructor after creating the WebCore::Page. Additionally, a few members needed to be initialized before the DrawingArea constructor might use them, so I moved them around, and the call to TiledCoreAnimationDrawingArea::setViewExposedRect needs the main frame to have been initialized, so I moved that to after the main frame was initialized. I need the Frame to be destroyed when it transitions between LocalFrame and RemoteFrame, and FocusController was keeping it alive sometimes, which caused crashes. I changed FocusController to have a WeakPtr instead of a RefPtr keeping the Frame alive. When the Frame is destroyed after having called Frame::takeWindowProxyFrom on it, it does some teardown on its WindowProxy. To make that teardown not happen on a WindowProxy that is still being used by another Frame, I added a call to frame.resetWindowProxy() but without the detachFromFrame() call. This is needed to keep the WindowProxy pointing to the right Frame and DOMWindow after the transition when the Frame lifetime is managed better. * Source/WebCore/loader/EmptyClients.h: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/FrameTree.h: (WebCore::FrameTree::thisFrame const): * Source/WebCore/page/LocalFrame.cpp: (WebCore::isRootFrame): (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::~LocalFrame): (WebCore::LocalFrame::isRootFrame const): * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/Page.cpp: (WebCore::createMainFrame): (WebCore::Page::addRootFrame): (WebCore::Page::removeRootFrame): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::rootFrameAdded): (WebKit::WebChromeClient::rootFrameRemoved): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp: (WebKit::DrawingAreaCoordinatedGraphics::DrawingAreaCoordinatedGraphics): * Source/WebKit/WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::removeRootFrame): (WebKit::DrawingArea::shouldForceCompositingMode const): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/Remot
[webkit-changes] [WebKit/WebKit] 6f3389: Add test for Geolocation WatchID
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f33895ab672a2532b6f679301fb2c1d54aa635d https://github.com/WebKit/WebKit/commit/6f33895ab672a2532b6f679301fb2c1d54aa635d Author: Matthew Finkel Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document-expected.txt A LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document.html A LayoutTests/http/tests/security/resources/popup-watchid.html Log Message: --- Add test for Geolocation WatchID https://bugs.webkit.org/show_bug.cgi?id=263277 rdar://8731258 Reviewed by David Kilzer. Add a test that confirms the Geolocation WatchID is unique per document. * LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document-expected.txt: Added. * LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document.html: Added. * LayoutTests/http/tests/security/resources/popup-watchid.html: Added. Originally-landed-as: 267815.490@safari-7617-branch (837e69390e41). rdar://119595145 Canonical link: https://commits.webkit.org/272220@main Commit: 9c58e7a622e8b97a50654fe6404562614e38dca8 https://github.com/WebKit/WebKit/commit/9c58e7a622e8b97a50654fe6404562614e38dca8 Author: Tyler Wilcock Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm Log Message: --- -[WebAccessibilityObjectWrapperIOS _accessibilitySetFocus] needs to take the WebThreadLock rdar://116882220 Reviewed by Ryosuke Niwa. Use -[WebAccessibilityObjectWrapperIOS _prepareAccessibilityCall] to ensure the WebThreadLock is taken before running this function. * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper _accessibilitySetFocus:]): Originally-landed-as: 267815.307@safari-7617-branch (fdc510244825). rdar://119595084 Canonical link: https://commits.webkit.org/272221@main Commit: a0e24518e376536852236303ca67e26f706eb249 https://github.com/WebKit/WebKit/commit/a0e24518e376536852236303ca67e26f706eb249 Author: Chris Dumez Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp Log Message: --- Fix bad capture by reference in CDMInstanceSessionClearKey::loadSession() https://bugs.webkit.org/show_bug.cgi?id=263254 rdar://117061886 Reviewed by Brent Fulgham. Fix bad capture by reference in an asynchronous callback in CDMInstanceSessionClearKey::loadSession(). * Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp: (WebCore::CDMInstanceSessionClearKey::loadSession): Originally-landed-as: 267815.314@safari-7617-branch (80d2fe008437). rdar://119595029 Canonical link: https://commits.webkit.org/27@main Commit: 7736ce7fe69a564cac39dd0c2020a0a9d3416a3c https://github.com/WebKit/WebKit/commit/7736ce7fe69a564cac39dd0c2020a0a9d3416a3c Author: Yusuke Suzuki Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/JavaScriptCore/b3/B3ReduceStrength.cpp M Source/JavaScriptCore/b3/testb3.h M Source/JavaScriptCore/b3/testb3_1.cpp M Source/JavaScriptCore/b3/testb3_5.cpp Log Message: --- [JSC] Wrong B3 range analysis on 64-bit values https://bugs.webkit.org/show_bug.cgi?id=262224 rdar://115897433 Reviewed by Mark Lam. This patch fixes B3's range analysis. When using 64bit value, we should use INT64_MIN / INT64_MAX instead of INT_MIN / INT_MAX. We use std::numeric_limits to make it work. We also adjust `+ 1` check to avoid potential UB. * Source/JavaScriptCore/b3/B3ReduceStrength.cpp: * Source/JavaScriptCore/b3/testb3.h: * Source/JavaScriptCore/b3/testb3_1.cpp: (run): * Source/JavaScriptCore/b3/testb3_5.cpp: (testCheckAdd64Range): Originally-landed-as: 267815.118@safari-7617-branch (3e7f362d98b7). rdar://119594339 Canonical link: https://commits.webkit.org/272223@main Compare: https://github.com/WebKit/WebKit/compare/629d6a1da6c4...7736ce7fe69a ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 629d6a: HTMLDocument::isCaseSensitiveAttribute() misses di...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 629d6a1da6c465da365f378d4c741305476467b5 https://github.com/WebKit/WebKit/commit/629d6a1da6c465da365f378d4c741305476467b5 Author: Anne van Kesteren Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.js A LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/w3c-import.log M Source/WebCore/html/HTMLDocument.cpp Log Message: --- HTMLDocument::isCaseSensitiveAttribute() misses direction attribute https://bugs.webkit.org/show_bug.cgi?id=265719 rdar://119432066 Reviewed by Tim Nguyen. Add the missing attribute. New tests are upstreamed here: https://github.com/web-platform-tests/wpt/pull/43709 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/values.window.js: Added. (forEach.attributeName.forEach): * LayoutTests/imported/w3c/web-platform-tests/html/semantics/selectors/case-sensitivity/w3c-import.log: Added. * Source/WebCore/html/HTMLDocument.cpp: (WebCore::HTMLDocument::isCaseSensitiveAttribute): Canonical link: https://commits.webkit.org/272219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20d6a4: Remove cruft from ThemeMac
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20d6a4967eff10b34ccdda0fd124f549b363afee https://github.com/WebKit/WebKit/commit/20d6a4967eff10b34ccdda0fd124f549b363afee Author: Anne van Kesteren Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/Theme.h M Source/WebCore/platform/mac/ThemeMac.h M Source/WebCore/platform/mac/ThemeMac.mm M Source/WebCore/rendering/RenderThemeMac.mm Log Message: --- Remove cruft from ThemeMac https://bugs.webkit.org/show_bug.cgi?id=266539 Reviewed by Aditya Keerthi. At this point in its life ThemeMac is mainly responsible for determining the sizing of a couple of form controls as the GPU process has taken over most of the theming aspects. And to determine the sizing of these form controls no cells are needed so all that code can be removed. And then we also remove some code that eventually does not do anything, such as StyleAppearance::ColorWell which do to not having the correct bezel style (which is itself a concept that can be removed) never ends up being impacted by inflateControlPaintRect(). * Source/WebCore/platform/Theme.h: (WebCore::Theme::inflateControlPaintRect const): * Source/WebCore/platform/mac/ThemeMac.h: * Source/WebCore/platform/mac/ThemeMac.mm: (WebCore::radioSize): (WebCore::ThemeMac::inflateControlPaintRect const): (WebCore::setControlSize): Deleted. (WebCore::updateStates): Deleted. (WebCore::configureToggleButton): Deleted. (WebCore::createToggleButtonCell): Deleted. (WebCore::sharedRadioCell): Deleted. (WebCore::sharedCheckboxCell): Deleted. (WebCore::buttonCell): Deleted. (WebCore::setUpButtonCell): Deleted. (WebCore::button): Deleted. * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Canonical link: https://commits.webkit.org/272218@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58de43: Address several HTMLAreaElement issues
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58de43fa036103b85219dd3bea560d1708ffdbb4 https://github.com/WebKit/WebKit/commit/58de43fa036103b85219dd3bea560d1708ffdbb4 Author: Anne van Kesteren Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/support/hit-test.js M Source/WebCore/html/HTMLAreaElement.cpp M Source/WebCore/html/HTMLAreaElement.h Log Message: --- Address several HTMLAreaElement issues https://bugs.webkit.org/show_bug.cgi?id=257229 rdar://110028213 Reviewed by Chris Dumez. web-platform-tests did not have adequate coverage for the shape attribute being missing due to a typo. Despite that, WebKit was alone in inferring the shape from the coords attribute. So remove that logic and firmly establish Shape::Rect as the default. (This also matches the HTML Standard.) Then, WebKit failed a test for not using the even-odd winding rule for hit testing. The HTML Standard requires that with this sentence: > The shape is a polygon whose vertices are given by the coordinates, > and whose interior is established using the even-odd rule. And then finally, we clean up the code by turning m_shape into an enum class and generally tidying up. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/support/hit-test.js: (onload): * Source/WebCore/html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::HTMLAreaElement): (WebCore::HTMLAreaElement::attributeChanged): (WebCore::HTMLAreaElement::mapMouseEvent): (WebCore::HTMLAreaElement::computePath const): (WebCore::HTMLAreaElement::computePathForFocusRing const): (WebCore::HTMLAreaElement::getRegion const): * Source/WebCore/html/HTMLAreaElement.h: Canonical link: https://commits.webkit.org/272217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d8c46: Fix build issue after rename
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d8c46480d08880e1e83b3c5a59128637dda1aca https://github.com/WebKit/WebKit/commit/0d8c46480d08880e1e83b3c5a59128637dda1aca Author: Per Arne Vollan Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift Log Message: --- Fix build issue after rename https://bugs.webkit.org/show_bug.cgi?id=266020 rdar://problem/119339780 Reviewed by Brent Fulgham. * Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingProcessExtension.swift: (NetworkingProcessExtension.grant(_:name:)): Canonical link: https://commits.webkit.org/272216@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ccf559: Allow all table cells in hasSimpleStaticPositionFo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ccf559313bf6240ea8d959c4ab7664afc416dc8a https://github.com/WebKit/WebKit/commit/ccf559313bf6240ea8d959c4ab7664afc416dc8a Author: Antti Koivisto Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- Allow all table cells in hasSimpleStaticPositionForOutOfFlowChildren https://bugs.webkit.org/show_bug.cgi?id=266570 Reviewed by Alan Baradlay. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::hasSimpleStaticPositionForOutOfFlowChildren): There should be no reason not to. Table cell instrinsic padding is included in paddingBefore(). Canonical link: https://commits.webkit.org/272215@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1903db: Disable launching WebKit processes as extensions f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1903db9a3c06bd69e3baaa80a7fad30dba0f2689 https://github.com/WebKit/WebKit/commit/1903db9a3c06bd69e3baaa80a7fad30dba0f2689 Author: Per Arne Vollan Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/Configurations/WebKit.xcconfig Log Message: --- Disable launching WebKit processes as extensions for newer OS versions https://bugs.webkit.org/show_bug.cgi?id=266544 Reviewed by Chris Dumez. Temporarily disable launching WebKit processes as extensions for newer OS versions due to sdk issue. * Source/WebKit/Configurations/BaseExtension.xcconfig: * Source/WebKit/Configurations/WebKit.xcconfig: Canonical link: https://commits.webkit.org/272214@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb36a7: [SOUP] GTask soup_session_send_async finalized wit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb36a7875fee34c8749e73f992401625dbb684fa https://github.com/WebKit/WebKit/commit/bb36a7875fee34c8749e73f992401625dbb684fa Author: Vitaly Dyachkov Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [SOUP] GTask soup_session_send_async finalized without ever returning https://bugs.webkit.org/show_bug.cgi?id=266280 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/272213@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 821b73: Stop using Vector::unsafeAppendWithoutCapacityChec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 821b7338d17759a5fb5a690d72a5237cc3da338e https://github.com/WebKit/WebKit/commit/821b7338d17759a5fb5a690d72a5237cc3da338e Author: Chris Dumez Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmEntryPlan.cpp Log Message: --- Stop using Vector::unsafeAppendWithoutCapacityCheck() in Warm::EntryPlan::prepare() https://bugs.webkit.org/show_bug.cgi?id=266556 Reviewed by Darin Adler. * Source/JavaScriptCore/wasm/WasmEntryPlan.cpp: (JSC::Wasm::EntryPlan::prepare): Canonical link: https://commits.webkit.org/272212@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e3a44: [WPE][GStreamer] GLib-ERROR: Creating pipes for GW...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e3a44d34039e0c091a037f7727a5ca5e879b56e https://github.com/WebKit/WebKit/commit/9e3a44d34039e0c091a037f7727a5ca5e879b56e Author: Vitaly Dyachkov Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][GStreamer] GLib-ERROR: Creating pipes for GWakeup: Too many open files https://bugs.webkit.org/show_bug.cgi?id=266577 Unreviewed test gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/272211@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89fc5a: Use Vector::unsafeAppendWithoutCapacityCheck() les...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89fc5a6200bbdd6812591eb7d14636ac4ef73db0 https://github.com/WebKit/WebKit/commit/89fc5a6200bbdd6812591eb7d14636ac4ef73db0 Author: Chris Dumez Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmSectionParser.cpp Log Message: --- Use Vector::unsafeAppendWithoutCapacityCheck() less in WasmSectionParser.cpp https://bugs.webkit.org/show_bug.cgi?id=266542 Reviewed by Justin Michaud. This tested as performance neutral on JetStream. * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseFunctionType): (JSC::Wasm::SectionParser::parseStructType): (JSC::Wasm::SectionParser::parseCustom): Canonical link: https://commits.webkit.org/272210@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66e588: [WPE][GStreamer] GStreamer-CRITICAL: gst_poll_writ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66e588f048716fd097cd276c288a866df833e5b1 https://github.com/WebKit/WebKit/commit/66e588f048716fd097cd276c288a866df833e5b1 Author: Vitaly Dyachkov Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][GStreamer] GStreamer-CRITICAL: gst_poll_write_control: assertion 'set != NULL' failed https://bugs.webkit.org/show_bug.cgi?id=266573 Unreviewed test gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/272209@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f24813: [JSC] Adjust inlining options
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f24813dedb83ca8d8fe4339fc1a97668683e20ea https://github.com/WebKit/WebKit/commit/f24813dedb83ca8d8fe4339fc1a97668683e20ea Author: Yusuke Suzuki Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGCapabilities.cpp M Source/JavaScriptCore/dfg/DFGCapabilities.h M Source/JavaScriptCore/heap/LocalAllocatorInlines.h M Source/JavaScriptCore/jit/JITPlan.h M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h Log Message: --- [JSC] Adjust inlining options https://bugs.webkit.org/show_bug.cgi?id=266563 rdar://119795209 Reviewed by Justin Michaud. This patch extends JSC to have different inlining options for DFG and FTL. This is great since DFG and FTL have different purpose and we would like to make DFG smaller-compilation and faster and keeping FTL heavy and highly optimized. And then, we adjust these numbers based on benchmarks. 1. DFG inlining heuristics becomes 80. 2. FTL call inlining heuristics becomes 125. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::setupWithUnlinkedBaselineCode): (JSC::CodeBlock::computeCapabilityLevel): (JSC::CodeBlock::noticeIncomingCall): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::inliningCost): (JSC::DFG::ByteCodeParser::getInliningBalance): * Source/JavaScriptCore/dfg/DFGCapabilities.cpp: (JSC::DFG::mightInlineFunctionForCall): (JSC::DFG::mightInlineFunctionForClosureCall): (JSC::DFG::mightInlineFunctionForConstruct): * Source/JavaScriptCore/dfg/DFGCapabilities.h: (JSC::DFG::mightInlineFunctionForCall): (JSC::DFG::mightInlineFunctionForClosureCall): (JSC::DFG::mightInlineFunctionForConstruct): (JSC::DFG::functionForCallCapabilityLevel): (JSC::DFG::functionForConstructCapabilityLevel): (JSC::DFG::inlineFunctionForCallCapabilityLevel): (JSC::DFG::inlineFunctionForClosureCallCapabilityLevel): (JSC::DFG::inlineFunctionForConstructCapabilityLevel): (JSC::DFG::mightInlineFunctionFor): (JSC::DFG::mightInlineFunction): (JSC::DFG::inlineFunctionForCapabilityLevel): * Source/JavaScriptCore/heap/LocalAllocatorInlines.h: (JSC::LocalAllocator::allocate): * Source/JavaScriptCore/jit/JITPlan.h: (JSC::JITPlan::jitType const): * Source/JavaScriptCore/runtime/Options.cpp: (JSC::overrideDefaults): * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/272208@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
webkit-changes@lists.webkit.org
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 471790cb5501c5ede43abf6e9b9a056092184d3a https://github.com/WebKit/WebKit/commit/471790cb5501c5ede43abf6e9b9a056092184d3a Author: Vitaly Dyachkov Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] ASSERTION FAILED: m_thread.ptr() == &Thread::current() https://bugs.webkit.org/show_bug.cgi?id=266571 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/272207@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b60dc7: [WebCore] Include EnumTraits.h in the generated No...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b60dc7f2172b5e2e0362259958c3d9b09c60c7ee https://github.com/WebKit/WebKit/commit/b60dc7f2172b5e2e0362259958c3d9b09c60c7ee Author: Žan Doberšek Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/dom/make_names.pl Log Message: --- [WebCore] Include EnumTraits.h in the generated NodeName.h header https://bugs.webkit.org/show_bug.cgi?id=266565 Unreviewed, adding the EnumTraits.h inclusion to the NodeName.h header generated by make_names.pl, which is needed for recently-adopted usage of the enumToUnderlyingType function. This should avoid depending on the EnumTraits header being included indirectly somewhere else in the translation unit. * Source/WebCore/dom/make_names.pl: (printNodeNameHeaderFile): Canonical link: https://commits.webkit.org/272206@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24dc37: NEW TEST (271377@main): [ Sonoma x86_64 ] http/wpt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24dc374004d3b30be7622ef2dae7b796c94a18e8 https://github.com/WebKit/WebKit/commit/24dc374004d3b30be7622ef2dae7b796c94a18e8 Author: Youenn Fablet Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/http/wpt/webcodecs/encoder-task-failing-expected.txt M LayoutTests/http/wpt/webcodecs/encoder-task-failing.html M LayoutTests/platform/mac/TestExpectations Log Message: --- NEW TEST (271377@main): [ Sonoma x86_64 ] http/wpt/webcodecs/encoder-task-failing.html is constant failure https://bugs.webkit.org/show_bug.cgi?id=265685 rdar://119043575 Reviewed by Eric Carlson. Some encoders will not error in case of large frame with low profile. Update the test to cope with this, the important thing being that either the output or error callback is called. We enable the test for Ventura but not MontereWe enable the test for Ventura but not Montereyy * LayoutTests/http/wpt/webcodecs/encoder-task-failing-expected.txt: * LayoutTests/http/wpt/webcodecs/encoder-task-failing.html: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/272205@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dcd42a: Increase usage of dynamicDowncast in Accessibility...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dcd42ae35333b577043cbe9e3eda1c4a5c66a471 https://github.com/WebKit/WebKit/commit/dcd42ae35333b577043cbe9e3eda1c4a5c66a471 Author: Anne van Kesteren Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/rendering/RenderThemeMac.h Log Message: --- Increase usage of dynamicDowncast in AccessibilityRenderObject https://bugs.webkit.org/show_bug.cgi?id=266553 Reviewed by Chris Dumez. Also sprinkle some RefPtr around, but not too much as many methods in this part of the code are not prepared to handle them. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::isInlineWithContinuation): (WebCore::startOfContinuations): (WebCore::firstChildIsInlineContinuation): (WebCore::AccessibilityRenderObject::setValue): (WebCore::AccessibilityRenderObject::widget const): (WebCore::AccessibilityRenderObject::documentLinks): (WebCore::AccessibilityRenderObject::accessibilityHitTest const): (WebCore::AccessibilityRenderObject::renderObjectIsObservable const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): (WebCore::AccessibilityRenderObject::inheritsPresentationalRole const): (WebCore::AccessibilityRenderObject::addImageMapChildren): (WebCore::AccessibilityRenderObject::addTextFieldChildren): (WebCore::AccessibilityRenderObject::remoteSVGRootElement const): (WebCore::AccessibilityRenderObject::addNodeOnlyChildren): (WebCore::AccessibilityRenderObject::setAccessibleName): (WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable const): (WebCore::AccessibilityRenderObject::scrollTo const): * Source/WebCore/rendering/RenderThemeMac.h: Drive-by fix to remove some no longer used class members. Canonical link: https://commits.webkit.org/272204@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 008a70: NEW TEST (264478@main): [ Monterey+ wk2 x86_64 ] h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 008a70ec8d675026b885b5eb7ff9991d3ce97e02 https://github.com/WebKit/WebKit/commit/008a70ec8d675026b885b5eb7ff9991d3ce97e02 Author: Youenn Fablet Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M LayoutTests/http/wpt/mediarecorder/record-context-created-late.html M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- NEW TEST (264478@main): [ Monterey+ wk2 x86_64 ] http/wpt/mediarecorder/record-context-created-late.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=264783 rdar://problem/118396753 Reviewed by Eric Carlson. The video compressor used by MediaRecorder may buffer video frames before outputting video frames. This would prevent to generate any data. To work around this, we trigger multiple video frame generation by the canvas track. * LayoutTests/http/wpt/mediarecorder/record-context-created-late.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/272203@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
