[webkit-changes] [WebKit/WebKit] ec4f49: AX: Relative frames for RenderTables aren't being ...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec4f4923b19d0ed56921d6b5b0aadb69ada735eb
  
https://github.com/WebKit/WebKit/commit/ec4f4923b19d0ed56921d6b5b0aadb69ada735eb
  Author: Joshua Hoffman 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  ---
  AX: Relative frames for RenderTables aren't being cached
https://bugs.webkit.org/show_bug.cgi?id=267913
rdar://problem/121417745

Reviewed by Tyler Wilcock.

We had not been caching the relative frame of RenderTables on paint since they 
override RenderBlock::paintObject.

This starts caching those frames on paint.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):

Canonical link: https://commits.webkit.org/273394@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c0655: Implement event firing from the web process for we...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c0655a175613f58168c7f30652e989cc0fe2736
  
https://github.com/WebKit/WebKit/commit/0c0655a175613f58168c7f30652e989cc0fe2736
  Author: Brian Weinstein 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
M 
Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
M Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestEventCocoa.mm
M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebRequestEvent.h
M 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebRequestFilter.h
M 
Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebRequestFilter.mm
M 
Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPIWebRequestEvent.idl
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIWebRequest.mm

  Log Message:
  ---
  Implement event firing from the web process for webRequest events and add 
tests
https://bugs.webkit.org/show_bug.cgi?id=267963
rdar://114823223

Reviewed by Timothy Hatcher.

The tests exposed a few issues that were also fixed here:
1) The network process wasn't calling into WebPageProxy when running the tests 
because the
page didn't have a resource load delegate. To fix this, also call into the 
WebPageProxy when
the page has an extension controller.
2) There was a copy/paste-o in 
WebExtensionContext::resourceLoadDidPerformHTTPRedirection where
the wrong events were being sent.
3) When just a filter was being passed to webRequest.event.addListener, it was 
being treated as the extraInfoSpec because
we weren't being specific enough about the type.

This PR also changed _WKWebExtensionWebRequestFilter to deal with 
WebKit::ResourceLoadInfo instead of _WKResourceLoadInfo.

* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters): Add a 
new pageHasExtensionController parameter.
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldSendResourceLoadMessages const): Check 
both pageHasResourceLoadClient and pageHasExtensionController.
(WebKit::NetworkResourceLoader::startNetworkLoad): Adopt 
shouldSendResourceLoadMessages.
(WebKit::NetworkResourceLoader::didReceiveResponse): Ditto.
(WebKit::NetworkResourceLoader::didFinishLoading): Ditto.
(WebKit::NetworkResourceLoader::didFailLoading): Ditto.
(WebKit::NetworkResourceLoader::didReceiveChallenge): Ditto.
(WebKit::NetworkResourceLoader::continueWillSendRequest): Ditto.
* Source/WebKit/NetworkProcess/NetworkResourceLoader.h:
* Source/WebKit/Shared/Extensions/WebExtensionFrameIdentifier.h:
(WebKit::toWebExtensionFrameIdentifier): Add a new flavor of this method.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::resourceLoadDidPerformHTTPRedirection): Make sure 
we are calling the correct events here.
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestCocoa.mm:
(WebKit::convertRequestBodyToWebExtensionFormat): Convert the request body to 
the format extensions expect.
(WebKit::webRequestDetailsForResourceLoad): Generate a dictionary of 
information about the resource load conforming to the webRequest spec.
(WebKit::convertHeaderFieldsToWebExtensionFormat): Convert the header fields to 
an array of dictionaries.
(WebKit::headersReceivedDetails): Convert the NSHTTPURLResponse information 
into a dictionary conforming to the webRequest spec.
(WebKit::WebExtensionContextProxy::resourceLoadDidSendRequest): Call the 
correct events.
(WebKit::WebExtensionContextProxy::resourceLoadDidPerformHTTPRedirection): 
Ditto.
(WebKit::WebExtensionContextProxy::resourceLoadDidReceiveChallenge): Ditto.
(WebKit::WebExtensionContextProxy::resourceLoadDidReceiveResponse): Ditto.
(WebKit::WebExtensionContextProxy::resourceLoadDidCompleteWithError): Ditto.
* 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWebRequestEventCocoa.mm:
(WebKit::WebExtensionAPIWebRequestEvent::invokeListenersWithArgument): Check 
the filter and invoke the correct listeners.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWebRequestEvent.h:
* Source/WebKit/WebProcess/Extensions/Cocoa/_WKWebExtensionWebRequestFilter.h:
* Source/

[webkit-changes] [WebKit/WebKit] a80fbc: [Win] Remove unused method ChromeClient::setLastSe...

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a80fbc53323b3e5d5ca1f805c14076c4f78f3fde
  
https://github.com/WebKit/WebKit/commit/a80fbc53323b3e5d5ca1f805c14076c4f78f3fde
  Author: Ross Kirsling 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/loader/EmptyClients.h
M Source/WebCore/page/ChromeClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h

  Log Message:
  ---
  [Win] Remove unused method ChromeClient::setLastSetCursorToCurrentCursor
https://bugs.webkit.org/show_bug.cgi?id=267983

Reviewed by Fujii Hironori.

Seems like this method was used in old WKL Win plugins code, but it's now just 
dead code.

* Source/WebCore/loader/EmptyClients.h:
* Source/WebCore/page/ChromeClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:

Canonical link: https://commits.webkit.org/273392@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e183df: [threaded-animation-resolution] Schedule animation...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e183df84221ef46786e71200591e6ef284ebc4d0
  
https://github.com/WebKit/WebKit/commit/e183df84221ef46786e71200591e6ef284ebc4d0
  Author: Matt Woodrow 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h
M 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm

  Log Message:
  ---
  [threaded-animation-resolution] Schedule animation updates from 
RemoteLayerTreeEventDispatcher on the scrolling thread.
https://bugs.webkit.org/show_bug.cgi?id=266026


Reviewed by Simon Fraser.

RemoteLayerTreeEventDispatcher can update the current set of animations at the
same time it applies any asynchronous scrolls.

This should align them with rendering updates (when scroll synchronisation
succeeds), and make it simpler to integrate scroll-linked animations

iOS doesn't use RemoteLayerTreeEventDispatcher/scrolling thread, so will
need a separate solution to schedule animation updates.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm:
(WebKit::RemoteAcceleratedEffectStack::initEffectsFromMainThread):
(WebKit::RemoteAcceleratedEffectStack::applyEffectsFromScrollingThread const):
(WebKit::RemoteAcceleratedEffectStack::clear):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
(WebKit::RemoteLayerTreeDrawingAreaProxy::animationCurrentTime const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTreeTransaction):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::animationCurrentTime const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h:
(WebKit::RemoteLayerTreeNode::effectStack const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm:
(WebKit::RemoteLayerTreeNode::~RemoteLayerTreeNode):
(WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.cpp:
(WebKit::RemoteLayerTreeEventDispatcher::startOrStopDisplayLinkOnMainThread):
(WebKit::RemoteLayerTreeEventDispatcher::didRefreshDisplay):
(WebKit::RemoteLayerTreeEventDispatcher::delayedRenderingUpdateDetectionTimerFired):
(WebKit::RemoteLayerTreeEventDispatcher::waitForRenderingUpdateCompletionOrTimeout):
(WebKit::RemoteLayerTreeEventDispatcher::scrollingTreeWasRecentlyActive):
(WebKit::RemoteLayerTreeEventDispatcher::lockForAnimationChanges):
(WebKit::RemoteLayerTreeEventDispatcher::unlockForAnimationChanges):
(WebKit::RemoteLayerTreeEventDispatcher::animationsWereAddedToNode):
(WebKit::RemoteLayerTreeEventDispatcher::animationsWereRemovedFromNode):
(WebKit::RemoteLayerTreeEventDispatcher::updateAnimations):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.h:
(WebKit::RemoteLayerTreeEventDispatcher::animationsLock):
* 
Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm:
(WebKit::RemoteScrollingCoordinatorProxyMac::willCommitLayerAndScrollingTrees):
(WebKit::RemoteScrollingCoordinatorProxyMac::didCommitLayerAndScrollingTrees):

Canonical link: https://commits.webkit.org/273391@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 811873: WebFrameLoaderClient::dispatchDecidePolicyForNavig...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81187347e9481e1f439edf53ceada596bda788c4
  
https://github.com/WebKit/WebKit/commit/81187347e9481e1f439edf53ceada596bda788c4
  Author: Alex Christensen 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyFrameLoaderClient.h
M Source/WebCore/loader/FrameLoaderClient.h
M Source/WebCore/loader/PolicyChecker.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm

  Log Message:
  ---
  WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction shouldn't 
interact with a DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=267975
rdar://116202776

Reviewed by Brady Eidson.

The Frame could be a RemoteFrame, in which case there is no DocumentLoader.

This is progress towards untangling the loaders and navigation flow.

* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebCore/loader/EmptyFrameLoaderClient.h:
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::changeLocation):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Canonical link: https://commits.webkit.org/273390@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a9e1a: [JSC] Remove CagedPtr's Data PAC tagging since it ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a9e1a58f9fe0fcd03a9aa350ea5bd4fdc352f6e
  
https://github.com/WebKit/WebKit/commit/8a9e1a58f9fe0fcd03a9aa350ea5bd4fdc352f6e
  Author: Yusuke Suzuki 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
A JSTests/microbenchmarks/segmentation.js
M Source/JavaScriptCore/API/MarkedJSValueRefArray.h
M Source/JavaScriptCore/assembler/testmasm.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/jit/AssemblyHelpers.h
M Source/JavaScriptCore/llint/InPlaceInterpreter.asm
M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
M Source/JavaScriptCore/llint/WebAssembly.asm
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/JavaScriptCore/runtime/ArrayBufferView.cpp
M Source/JavaScriptCore/runtime/ArrayBufferView.h
M Source/JavaScriptCore/runtime/BufferMemoryHandle.cpp
M Source/JavaScriptCore/runtime/BufferMemoryHandle.h
M Source/JavaScriptCore/runtime/CachedTypes.cpp
M Source/JavaScriptCore/runtime/CagedBarrierPtr.h
M Source/JavaScriptCore/runtime/DirectArguments.cpp
M Source/JavaScriptCore/runtime/DirectArguments.h
M Source/JavaScriptCore/runtime/GenericArgumentsInlines.h
M Source/JavaScriptCore/runtime/JSArrayBufferView.cpp
M Source/JavaScriptCore/runtime/JSArrayBufferView.h
M Source/JavaScriptCore/runtime/JSBigInt.cpp
M Source/JavaScriptCore/runtime/JSBigInt.h
M Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp
M Source/JavaScriptCore/runtime/ScopedArgumentsTable.h
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
M Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp
M Source/JavaScriptCore/wasm/WasmBinding.cpp
M Source/JavaScriptCore/wasm/WasmInstance.h
M Source/JavaScriptCore/wasm/js/JSToWasm.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp
M Source/WTF/wtf/CagedPtr.h
M Source/WTF/wtf/CagedUniquePtr.h

  Log Message:
  ---
  [JSC] Remove CagedPtr's Data PAC tagging since it is not adding values
https://bugs.webkit.org/show_bug.cgi?id=267961
rdar://121473792

Reviewed by Mark Lam.

This patch removes CagedPtr's Data PAC tagging since,

1. From attacking patterns, this does not add values. Right now, we continue 
using Gigacage, but not using Data PAC here.
2. We found that Data PAC is extremely slow. Attached benchmark showed 11.5% 
difference.

   ToT Patched

segmentation128.8931+-0.3854 ^115.6124+-0.1073^ 
definitely 1.1149x faster

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::generateWithGuard):
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::newTypedArrayWithSize):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpForTypedArrayIsDetachedIfOutOfBounds):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::emitNewTypedArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::cageWithoutUntagging):
(JSC::AssemblyHelpers::cageConditionallyAndUntag):
* Source/JavaScriptCore/jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::toBigInt64):
* Source/JavaScriptCore/llint/InPlaceInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
* Source/JavaScriptCore/runtime/ArrayBufferView.h:
* Source/JavaScriptCore/runtime/BufferMemoryHandle.h:
* Source/JavaScriptCore/runtime/CagedBarrierPtr.h:
* Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::JSArrayBufferView):
* Source/JavaScriptCore/runtime/JSArrayBufferView.h:
* Source/JavaScriptCore/runtime/JSBigInt.h:
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::reloadMemoryRegistersFromInstance):
(JSC::Wasm::B3IRGenerator::emitIndirectCall):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::loadWebAssemblyGlobalState):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp:
(JSC::Wasm::BBQJITImpl::BBQJIT::restoreWebAssemblyGlobalStateAfterWasmCall):
* Source/JavaScriptCore/wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* Source/JavaScriptCore/wasm/WasmInstance.

[webkit-changes] [WebKit/WebKit] 9a9aef: Make sure simulators have correct bundle ID

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a9aef3921444c4ae209f0b75e9acbda461ec83a
  
https://github.com/WebKit/WebKit/commit/9a9aef3921444c4ae209f0b75e9acbda461ec83a
  Author: Per Arne Vollan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/Configurations/GPUService.xcconfig
M Source/WebKit/Configurations/NetworkService.xcconfig
M Source/WebKit/Configurations/WebContentService.xcconfig

  Log Message:
  ---
  Make sure simulators have correct bundle ID
https://bugs.webkit.org/show_bug.cgi?id=267964
rdar://121474403

Reviewed by Brent Fulgham.

Make sure simulators have correct bundle ID for all platforms.

* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:

Canonical link: https://commits.webkit.org/273388@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 86fd60: Adopt more smart pointers in AuxiliaryProcessProxy...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86fd607f2316a05d067e78a829e96ab4fad54667
  
https://github.com/WebKit/WebKit/commit/86fd607f2316a05d067e78a829e96ab4fad54667
  Author: Chris Dumez 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

  Log Message:
  ---
  Adopt more smart pointers in AuxiliaryProcessProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=267958

Reviewed by Darin Adler.

* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::~AuxiliaryProcessProxy):
(WebKit::AuxiliaryProcessProxy::terminate):
(WebKit::AuxiliaryProcessProxy::sendMessage):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
(WebKit::AuxiliaryProcessProxy::shutDownProcess):
(WebKit::AuxiliaryProcessProxy::setProcessSuppressionEnabled):
(WebKit::AuxiliaryProcessProxy::checkForResponsiveness):

Canonical link: https://commits.webkit.org/273387@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 408e8e: [UnifiedPDF] PDF Plugin methods on WebPage should ...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 408e8ec982b719e359bae2fe750882a751cc24da
  
https://github.com/WebKit/WebKit/commit/408e8ec982b719e359bae2fe750882a751cc24da
  Author: Abrar Rahman Protyasha 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  [UnifiedPDF] PDF Plugin methods on WebPage should be called behind enablement 
flags only
https://bugs.webkit.org/show_bug.cgi?id=267917
rdar://121424071

Reviewed by Tim Horton.

There are a couple of instances inside WebPage where we unconditionally
call the WebPage class's PDF plugin methods. These examples still
compiled because the offending callsites were behind PLATFORM(MAC),
which meant at least one PDF plugin type was implemented, but let's
guard our calls behind the right conditions.

This patch also performs a drive-by fix of providing a Cocoa definition
for WebPage::pdfDocumentForPrintingFrame. Previously, it was only
defined for PLATFORM(MAC), which worked because no other Cocoa platform
was calling into it, but that will change when we implement
computePagesForPrintingDocument in WebPageIOS.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pdfDocumentForPrintingFrame):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getStringSelectionForPasteboard):

Canonical link: https://commits.webkit.org/273386@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d42ea8: [Gardening]: NEW TEST (272922@main): [ iOS17 ]ASSE...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d42ea857b0269d7c01f1a1414bbaebd5858bdac8
  
https://github.com/WebKit/WebKit/commit/d42ea857b0269d7c01f1a1414bbaebd5858bdac8
  Author: Marta Darbinyan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: NEW TEST (272922@main): [ iOS17 ]ASSERTION FAILED:void 
WTR::UIScriptContext::asyncTaskComplete(unsigned int) for 
fast/forms/ios/dismiss-date-picker-on-rotation.html result of flaky timeout 
crash
https://bugs.webkit.org/show_bug.cgi?id=267974
rdar://121480560

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/273385@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a059cc: [Gardening]: [ iOS ] fast/forms/ios/show-and-dismi...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a059cc8fbfa9dc2adee0a1b393d7e749f5ee4ba6
  
https://github.com/WebKit/WebKit/commit/a059cc8fbfa9dc2adee0a1b393d7e749f5ee4ba6
  Author: Marta Darbinyan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ iOS ] 
fast/forms/ios/show-and-dismiss-date-input-in-landscape.html(layout-tests) is a 
flaky failure
https://bugs.webkit.org/show_bug.cgi?id=264296
rdar://118359766

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/273384@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 07c648: Remove PolicyCheckIdentifier

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07c6482ec70803d4c375260d8910d9dec6956836
  
https://github.com/WebKit/WebKit/commit/07c6482ec70803d4c375260d8910d9dec6956836
  Author: Alex Christensen 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/loader/EmptyFrameLoaderClient.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/FrameLoaderClient.h
M Source/WebCore/loader/FrameLoaderTypes.h
M Source/WebCore/loader/LocalFrameLoaderClient.h
M Source/WebCore/loader/PolicyChecker.cpp
M Source/WebCore/loader/PolicyChecker.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm

  Log Message:
  ---
  Remove PolicyCheckIdentifier
https://bugs.webkit.org/show_bug.cgi?id=267942
rdar://121462648

Reviewed by Charlie Wolfe.

It was useful before we had C++ lambdas.  It is no longer useful.

Its one use was to make it so that if a navigation is initiated immediately
after navigating to a JS URL, then we should not proceed with the navigation
to the JS URL.  This is accomplished by just incrementing an integer instead
of hashing, allocating a map, and hashing again.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
* Source/WebCore/loader/EmptyFrameLoaderClient.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkContentPolicy):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebCore/loader/FrameLoaderTypes.h:
* Source/WebCore/loader/LocalFrameLoaderClient.h:
* Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
(WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy):
(WebCore::FrameLoader::PolicyChecker::stopCheck):
* Source/WebCore/loader/PolicyChecker.h:
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebLocalFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::changeLocation):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::setUpPolicyListener):
(WebKit::WebFrame::didReceivePolicyDecision):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::setUpPolicyListener):
(-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
(-[WebFramePolicyListener 
initWithFrame:policyFunction:defaultPolicy:appLinkURL:referrerURL:]):
(-[WebFramePolicyListener invalidate]):
(-[WebFramePolicyListener dealloc]):
(-[WebFramePolicyListener receivedPolicyDecision:]):
(-[WebFramePolicyListener 
initWithFrame:identifier:policyFunction:defaultPolicy:]): Deleted.
(-[WebFramePolicyListener 
initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:referrerURL:]):
 Deleted.

Canonical link: https://commits.webkit.org/273383@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listi

[webkit-changes] [WebKit/WebKit] a08c41: [WebXR] Runtime reachability of WebXR IPC endpoints

[Dan Glastonbury]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a08c416bdc77ff4dbf291402a8199f2f77f7802f
  
https://github.com/WebKit/WebKit/commit/a08c416bdc77ff4dbf291402a8199f2f77f7802f
  Author: Dan Glastonbury 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp
M Source/WebKit/UIProcess/XR/PlatformXRSystem.h
M Source/WebKit/UIProcess/XR/PlatformXRSystem.messages.in
M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp
M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h
M Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.messages.in

  Log Message:
  ---
  [WebXR] Runtime reachability of WebXR IPC endpoints
https://bugs.webkit.org/show_bug.cgi?id=267903
rdar://121410997

Reviewed by Alex Christensen and Tim Horton.

This change uses [EnabledIf=""] attribute to enable reachability to WebXR
IPC endpoints on when WebXREnabled preference is enabled. This allows runtime
control over handling of messages, with any messages received when disabled
being dropped.

* Source/WebKit/UIProcess/XR/PlatformXRSystem.cpp:
(WebKit::PlatformXRSystem::webXREnabled const):
* Source/WebKit/UIProcess/XR/PlatformXRSystem.h:
* Source/WebKit/UIProcess/XR/PlatformXRSystem.messages.in:
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.cpp:
(WebKit::PlatformXRSystemProxy::webXREnabled const):
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.h:
* Source/WebKit/WebProcess/XR/PlatformXRSystemProxy.messages.in:

Canonical link: https://commits.webkit.org/273382@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b5ca19: Unreviewed, reverting 273373@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5ca19520145efbb2a9ee1c51aa4a0676e390957
  
https://github.com/WebKit/WebKit/commit/b5ca19520145efbb2a9ee1c51aa4a0676e390957
  Author: Commit Queue 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

  Log Message:
  ---
  Unreviewed, reverting 273373@main.
https://bugs.webkit.org/show_bug.cgi?id=267960

Revert unneeded sandbox change

Reverted changeset:

"Allow querying team ID in the WebContent process"
https://bugs.webkit.org/show_bug.cgi?id=267935
https://commits.webkit.org/273373@main

Canonical link: https://commits.webkit.org/273381@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c6f39e: [Gardening]: REGRESSION: [ Ventura+ wk 2 ] http/wp...

[Jean-saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6f39e449917ba84dd579949d4d27b0527a2e4f5
  
https://github.com/WebKit/WebKit/commit/c6f39e449917ba84dd579949d4d27b0527a2e4f5
  Author: Jay saintfleur 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION: [ Ventura+ wk 2 ] 
http/wpt/webrtc/video-script-transform.html is a flaky text failure
rdar://121470460
https://bugs.webkit.org/show_bug.cgi?id=267953

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/273380@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f1f9f0: Remove non-standard `KeyboardEvent.altGraphKey`

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1f9f0045afe3ae23d359d72658b600e4a623ac5
  
https://github.com/WebKit/WebKit/commit/f1f9f0045afe3ae23d359d72658b600e4a623ac5
  Author: Ahmad Saleem 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M 
LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt
M LayoutTests/fast/events/constructors/keyboard-event-constructor.html
M 
LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt
M LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html
M 
LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt
M LayoutTests/fast/events/constructors/mouse-event-getModifierState.html
M LayoutTests/fast/events/init-event-clears-capslock-expected.txt
M LayoutTests/fast/events/init-event-clears-capslock.html
M LayoutTests/fast/events/init-events-expected.txt
M LayoutTests/fast/events/init-events.html
M LayoutTests/fast/forms/tabs-with-modifiers-expected.txt
M LayoutTests/fast/forms/tabs-with-modifiers.html
M Source/WebCore/dom/KeyboardEvent.cpp
M Source/WebCore/dom/KeyboardEvent.h
M Source/WebCore/dom/KeyboardEvent.idl
M Source/WebCore/dom/UIEventWithKeyState.cpp
M Source/WebCore/dom/UIEventWithKeyState.h
M Source/WebCore/html/HTMLSelectElementWin.cpp
M Source/WebCore/page/EventHandler.cpp
M 
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm

  Log Message:
  ---
  Remove non-standard `KeyboardEvent.altGraphKey`

https://bugs.webkit.org/show_bug.cgi?id=248394

Reviewed by Chris Dumez.

This pach aligns WebKit with Gecko / Firefox and Blink / Chromium
by removing non-standard KeyboardEvent.altGraphKey.

It is not in web-specification [1].

[1] https://www.w3.org/TR/uievents/

It was never shipped in Gecko / Firefox while removed in Blink
in 2014 and with commit [2]:

[2] https://src.chromium.org/viewvc/blink?view=revision&revision=179545

> Files modified:
* Source/WebCore/dom/KeyboardEvent.cpp:
(KeyboardEvent::initKeyboardEvent):
* Source/WebCore/dom/KeyboardEvent.h:
* Source/WebCore/dom/KeyboardEvent.idl:
* Source/WebCore/dom/UIEventWithKeyState.cpp:
(UIEventWithKeyState::getModifierState):
(UIEventWithKeyState::setModifierKeys):
* Source/WebCore/dom/UIEventWithKeyState.h:
* Source/WebCore/html/HTMLSelectElementWin.cpp:
(HTMLSelectElement::platformHandleKeydownEvent):
* Source/WebCore/page/EventHandler.cpp:
(EventHandler::defaultPageUpDownEventHandler):
(EventHandler::defaultHomeEndEventHandler):
(EventHandler::defaultArrowEventHandler():
(EventHandler::defaultTabEventHandler):
* 
Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp:
(webkit_dom_keyboard_event_init_keyboard_event):
(webkit_dom_keyboard_event_get_alt_graph_key):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(PDFPluginTextAnnotation::value):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebPage::handleKeyEventByRelinquishingFocusToChrome):
* Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm:
((BOOL)altGraphKey):
((void)initKeyboardEvent):

> Tests Rebaselined / Updated:
* LayoutTests/fast/forms/tabs-with-modifiers.html:
* LayoutTests/fast/forms/tabs-with-modifiers-expected.txt:
* LayoutTests/fast/events/init-events.html:
* LayoutTests/fast/events/init-events-expected.txt:
* LayoutTests/fast/events/init-event-clears-capslock.html:
* LayoutTests/fast/events/init-event-clears-capslock-expected.txt:
* LayoutTests/fast/events/constructors/mouse-event-getModifierState.html:
* 
LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt:
* LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html:
* 
LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt:
* LayoutTests/fast/events/constructors/keyboard-event-constructor.html:
* LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt:

Canonical link: https://commits.webkit.org/273379@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea8a71: Increase adoption of dynamicDowncast

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea8a714eff317f73a618443745ea65228523
  
https://github.com/WebKit/WebKit/commit/ea8a714eff317f73a618443745ea65228523
  Author: Anne van Kesteren 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/page/DOMTimer.cpp
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/page/NavigatorBase.cpp
M Source/WebCore/page/PerformanceMark.cpp
M Source/WebCore/page/PerformanceObserver.cpp
M Source/WebCore/page/PerformanceUserTiming.cpp
M Source/WebCore/workers/WorkerMessagingProxy.cpp
M Source/WebCore/workers/service/ServiceWorkerContainer.cpp
M Source/WebCore/xml/XMLHttpRequest.cpp

  Log Message:
  ---
  Increase adoption of dynamicDowncast
https://bugs.webkit.org/show_bug.cgi?id=267861

Reviewed by Chris Dumez.

And cleanup some nearby code while there.

* Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::computeIntersectionState const):
(WebCore::IntersectionObserver::nowTimestamp const):
* Source/WebCore/page/NavigatorBase.cpp:
* Source/WebCore/page/PerformanceMark.cpp:
(WebCore::performanceNow):
* Source/WebCore/page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::PerformanceObserver):
(WebCore::PerformanceObserver::supportedEntryTypes):
* Source/WebCore/page/PerformanceUserTiming.cpp:
(WebCore::PerformanceUserTiming::mark):
* Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::willSettleRegistrationPromise):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):
(WebCore::ServiceWorkerContainer::contextIdentifier):
* Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::prepareToSend):

Canonical link: https://commits.webkit.org/273378@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d29576: Revert "[Cocoa] objectForEqualityCheck() is no lon...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2957647a0af6c363cf6fe108021a11330d6fc84
  
https://github.com/WebKit/WebKit/commit/d2957647a0af6c363cf6fe108021a11330d6fc84
  Author: Vitor Roriz 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/platform/graphics/FontPlatformData.h
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm

  Log Message:
  ---
  Revert "[Cocoa] objectForEqualityCheck() is no longer necessary"
https://bugs.webkit.org/show_bug.cgi?id=263136
rdar://116934547

Reviewed by Cameron McCormack.

This reverts commit dc989b3ef737547949c45f39dc996f0850fe862f.

267312@main [1] broke the following test:
imported/w3c/web-platform-tests/css/css-text/line-break/line-break-anywhere-overrides-uax-behavior-011.html

Before [1] we used to define a derived object from the Fonts we were trying to 
compare,
because we considered that CFEqual() would do a shallow comparison.

Since it is possible to generate two font objects (with different pointers) 
representing
the same font object, a shallow comparison wouldn’t work for us.

[1] states that CFEqual() "now” does a deep comparison, and
the derived object would have no use anymore.

However, at 
Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:
ComplexTextController::collectComplexTextRunsForCharacters:

We observe that the comparisons before and after [1] produce different results,
for the specific test that is failing. More specifically we can reduce it to
the render of “X͏”:

-> Without [1] the following is never true:
 if (!safeCFEqual(runFontEqualityObject.get(), 
font->platformData().objectForEqualityCheck().get()))

This means that the fonts are considered equal. However:

-> With [1] the following is always true:
 if (!safeCFEqual(runCTFont, font->platformData().ctFont()))

This means that the run’s font, acquired after shaping is not the same as the 
font passed,
so we will try to add it to the fallback font list.

* Source/WebCore/platform/graphics/FontPlatformData.h:
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformData::objectForEqualityCheck):
(WebCore::FontPlatformData::objectForEqualityCheck const):
* Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

Canonical link: https://commits.webkit.org/273377@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7123a9: Rename `RenderStyle::styleType()` and `RenderStyle...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7123a96b5b715c6ffbc976e83d30a29560dd0ce9
  
https://github.com/WebKit/WebKit/commit/7123a96b5b715c6ffbc976e83d30a29560dd0ce9
  Author: Tim Nguyen 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ElementInlines.h
M Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderInline.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/line/LineWidth.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp
M Source/WebCore/style/MatchedDeclarationsCache.cpp
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/Styleable.cpp

  Log Message:
  ---
  Rename `RenderStyle::styleType()` and `RenderStyle::setStyleType()`
https://bugs.webkit.org/show_bug.cgi?id=267915
rdar://121419574

Reviewed by Antti Koivisto.

Use `pseudoElementType()` / `setPseudoElementType()` to clarify what this is.

* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::resolvePseudoElementStyle):
* Source/WebCore/dom/ElementInlines.h:
(WebCore::isInTopLayerOrBackdrop):
* Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::adjustLineRectForInitialLetterIfApplicable):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::checkFloatInCleanLine):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest const):
(WebCore::RenderBlock::getFirstLetter):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):
(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::lowestInitialLetterLogicalBottom const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::planCounter):
(WebCore::RenderCounter::updateCounter):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRect const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::outputRenderObject const):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeContent const):
(WebCore::RenderObject::isAfterContent const):
(WebCore::RenderObject::isAnonymousBlock const):
* Source/WebCore/rendering/line/LineWidth.cpp:
(WebCore::newFloatShrinksLine):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hasUniquePseudoStyle const):
(WebCore::RenderStyle::getCachedPseudoStyle const):
(WebCore::RenderStyle::addCachedPseudoStyle):
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::pseudoElementType const):
(WebCore::RenderStyle::setPseudoElementType):
(WebCore::RenderStyle::styleType const): Deleted.
(WebCore::RenderStyle::setStyleType): Deleted.
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::hasEffectiveContentNone const):
* Source/WebCore/rendering/style/Re

[webkit-changes] [WebKit/WebKit] 4bc7c5: Avoid conversion to UTF-8 in ContentSecurityPolicy...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bc7c5b5bdd351c52e5b5d810ec2a95c7973c747
  
https://github.com/WebKit/WebKit/commit/4bc7c5b5bdd351c52e5b5d810ec2a95c7973c747
  Author: Ryosuke Niwa 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/page/csp/ContentSecurityPolicy.cpp

  Log Message:
  ---
  Avoid conversion to UTF-8 in ContentSecurityPolicy::allowInlineStyle when no 
algorithm is specified
https://bugs.webkit.org/show_bug.cgi?id=267916

Reviewed by Darin Adler.

When there is no CSP policy in place, we don't need to convert the string to 
UTF-8 for no good reason.

* Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::generateHashesForContent):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers const):
(WebCore::ContentSecurityPolicy::allowScriptWithNonce const):
(WebCore::ContentSecurityPolicy::allowStyleWithNonce const):
(WebCore::ContentSecurityPolicy::allowNonParserInsertedScripts const):
(WebCore::ContentSecurityPolicy::allowInlineScript const):
(WebCore::ContentSecurityPolicy::allowInlineStyle const):
(WebCore::ContentSecurityPolicy::allowEval const):
(WebCore::ContentSecurityPolicy::allowFrameAncestors const):
(WebCore::ContentSecurityPolicy::allowPluginType const):
(WebCore::ContentSecurityPolicy::allowObjectFromSource const):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource const):
(WebCore::ContentSecurityPolicy::allowResourceFromSource const):
(WebCore::ContentSecurityPolicy::allowWorkerFromSource const):
(WebCore::ContentSecurityPolicy::allowScriptFromSource const):
(WebCore::ContentSecurityPolicy::allowStyleFromSource const):
(WebCore::ContentSecurityPolicy::allowConnectToSource const):
(WebCore::ContentSecurityPolicy::allowBaseURI const):

Canonical link: https://commits.webkit.org/273375@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 47d87c: Fix layout tests in simulator

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 47d87cd99fd28559352bec7d539b9a2d0a984121
  
https://github.com/WebKit/WebKit/commit/47d87cd99fd28559352bec7d539b9a2d0a984121
  Author: Per Arne Vollan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/Configurations/BaseExtension.xcconfig
M Source/WebKit/Configurations/BaseXPCService.xcconfig
M Source/WebKit/Configurations/GPUExtension.xcconfig
M Source/WebKit/Configurations/GPUService.xcconfig
M Source/WebKit/Configurations/NetworkService.xcconfig
M Source/WebKit/Configurations/NetworkingExtension.xcconfig
M Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig
M Source/WebKit/Configurations/WebContentExtension.xcconfig
M Source/WebKit/Configurations/WebContentService.xcconfig
M Source/WebKit/Scripts/process-entitlements.sh
M 
Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtension.entitlements
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements

  Log Message:
  ---
  Fix layout tests in simulator
rdar://121324669
https://bugs.webkit.org/show_bug.cgi?id=267822

Reviewed by Brent Fulgham.

Fix an issue where the Simulator entitlements are not actually applied. Also 
use the same bundle ID
for WebKit extensions on Simulator as on device. Additionally, the test runner 
app needs an extra
entitlement for launching extensions to succeed. This patch changes the bundle 
IDs for the XPC
services on Simulator where extension based launch is enabled. Otherwise, these 
bundle IDs will
conflict with the extension bundle IDs.

* Source/WebKit/Configurations/BaseExtension.xcconfig:
* Source/WebKit/Configurations/BaseXPCService.xcconfig:
* Source/WebKit/Configurations/GPUExtension.xcconfig:
* Source/WebKit/Configurations/GPUService.xcconfig:
* Source/WebKit/Configurations/NetworkingExtension.xcconfig:
* Source/WebKit/Configurations/NetworkService.xcconfig:
* Source/WebKit/Configurations/WebContentCaptivePortalExtension.xcconfig:
* Source/WebKit/Configurations/WebContentService.xcconfig:
* Source/WebKit/Configurations/WebContentExtension.xcconfig:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createNewWebProcess):
* Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:

Canonical link: https://commits.webkit.org/273374@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0ebf83: Cherry-pick 267815.623@safari-7617-branch (430d474...

[Dan Robson]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ebf8393b3e433292c2c281576b7578eaf64e671
  
https://github.com/WebKit/WebKit/commit/0ebf8393b3e433292c2c281576b7578eaf64e671
  Author: Mark Lam 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
A 
LayoutTests/js/structuredClone/structured-clone-validation-with-big-int-expected.txt
A 
LayoutTests/js/structuredClone/structured-clone-validation-with-big-int.html
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  ---
  Cherry-pick 267815.623@safari-7617-branch (430d474531c0). 
https://bugs.webkit.org/show_bug.cgi?id=265975

CloneSerializer/Deserializer's objectPool should match.
https://bugs.webkit.org/show_bug.cgi?id=265975
rdar://118868470

Reviewed by Chris Dumez and Sihui Liu

CloneSerializer and CloneDeserializer uses m_gcBuffer for multiple purposes:
1. As an object pool that ObjectReferenceTag refers back to i.e. the order 
of its
   entries need to be consistent between CloneSerializer and 
CloneDeserializer.
2. As a keep alive buffer to protect some objects use in the serialization 
effort.

Purpose (2) conflicts with purpose (1), which can lead to bugs.  This patch 
disambiguates
between these 2 purposes by introducing m_objectPool for purpose (1), and 
m_keepAliveBuffer
for purpose (2).

Changes made:
1. Renamed m_objectPool to m_objectPoolMap.
2. Renamed m_gcBuffer to m_objectPool: for tracking the list of objects 
that ObjectReferenceTag
   can refer to.
3. Added m_keepAliveBuffer to CloneSerializer: for keeping miscellaneous 
objects alive from the GC.

4. Renamed some method names for clarity:
   CloneSerializer::checkForDuplicate --> 
CloneSerializer::writeObjectReferenceIfDupe
   CloneSerializer::recordObject --> CloneSerializer::addToObjectPool
   CloneSerializer::startObjectInternal --> 
CloneSerializer::addToObjectPoolIfNotDupe

5. Used CloneSerializer::addToObjectPoolIfNotDupe instead of the following:
   CloneSerializer::startObject
   CloneSerializer::startArray
   CloneSerializer::startSet
   CloneSerializer::startMap

   The clients of addToObjectPoolIfNotDupe now indicate what object types 
(indicated by their
   SerializationTags) they are adding.  This makes it easier to compare the 
serialization and
   deserialization code and make sure that they are equivalent.

   This enables us to audit the type of object being added and provide a 
sanity check that
   it's also added on the deserializer side.

6. Introduced CloneDeserializer::addToObjectPool() so that we can tag which 
object type (as
   indicated by its SerializationTag) we're adding to the m_objectPool 
(instead of calling
   appendWithCrashOnOverflow() on it directly to add objects).

   This enables us to audit the type of object being added and provide a 
sanity check that
   it's also added on the serializer side.

7. Removed 3 calls to m_gcBuffer.appendWithCrashOnOverflow in the BigIntTag 
case in
   CloneDeserializer::readBigInt().  This was a bug.

8. Removed the following calls to m_gcBuffer.appendWithCrashOnOverflow in 
CloneSerializer::serialize:
   a. redundant adding of the JSMap object.  It was already added by 
startMap(), now addToObjectPoolIfNotDupe().
   b. keep alive of the JSMapIterator object.  It does not need to be in 
m_objectPool.
   c. keep alive of a map entry value.
   d. redundant adding of the JSSet object.  It was already added by 
startSet(), now addToObjectPoolIfNotDupe().
   e. keep alive of the JSSetIterator object.  It does not need to be in 
m_objectPool.

   These were bugs.

9. Renamed the mapObjectStartState and setObjectStartState labels in the 
deserializer to match the
   mapStartState and setStartState labels in the serializer.  This makes it 
easier to check the
   equivalency of the operations in the two.

10. Added a validator (see validateSerializedResult()) in the serializer.

   The validator works by running a deserialization pass on the output of 
the serializer.
   After that, it compares the m_objectPoolTags of the 2 passes, and their 
entries should
   match.  This ensures that the serializer and deserializer will catch any 
bugs in the
   serialization / deserialization order of objects.

   a. The validator is only enabled on Debug builds (not built in on 
Release builds).
   b. The validator is only run when 
JSC::Options::validateSerializedValue() is true.
   c. The validator is only run when the object graph to be serialized and 
deserialized
  does not contain any complicated / complex objects.  "complex" here 
means that
  serialization of such objects cannot be validated this way.
   d. The validator is only 

[webkit-changes] [WebKit/WebKit] cbce58: Allow querying team ID in the WebContent process

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbce58b2e8147a1038aec6c742cbd9bd5676049d
  
https://github.com/WebKit/WebKit/commit/cbce58b2e8147a1038aec6c742cbd9bd5676049d
  Author: Per Arne Vollan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

  Log Message:
  ---
  Allow querying team ID in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=267935
rdar://120378775

Reviewed by Brent Fulgham.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

Canonical link: https://commits.webkit.org/273373@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c1c299: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1c299b9a56c31d543b85256e74a833e9f2d8dfa
  
https://github.com/WebKit/WebKit/commit/c1c299b9a56c31d543b85256e74a833e9f2d8dfa
  Author: Fujii Hironori 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/273372@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6156d4: Adopt more smart pointers in ChildListMutationAccu...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6156d4819317b2d66450cc7b9e95abbd515cfa7e
  
https://github.com/WebKit/WebKit/commit/6156d4819317b2d66450cc7b9e95abbd515cfa7e
  Author: Chris Dumez 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/dom/ChildListMutationScope.cpp
M Source/WebCore/dom/ChildListMutationScope.h

  Log Message:
  ---
  Adopt more smart pointers in ChildListMutationAccumulator
https://bugs.webkit.org/show_bug.cgi?id=267925

Reviewed by Darin Adler.

This tested as performance neutral on Speedometer 2 & 3.

* Source/WebCore/dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator):
(WebCore::ChildListMutationAccumulator::~ChildListMutationAccumulator):
(WebCore::ChildListMutationAccumulator::getOrCreate):
(WebCore::ChildListMutationAccumulator::childAdded):
(WebCore::ChildListMutationAccumulator::willRemoveChild):
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):
* Source/WebCore/dom/ChildListMutationScope.h:

Canonical link: https://commits.webkit.org/273371@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 543068: Allow building for QNX

[elahav]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5430681aa4dbb12b14005add4336b49f2064c398
  
https://github.com/WebKit/WebKit/commit/5430681aa4dbb12b14005add4336b49f2064c398
  Author: Elad Lahav 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/JavaScriptCore/heap/BlockDirectory.cpp
M Source/JavaScriptCore/runtime/MachineContext.h
M Source/WTF/wtf/InlineASM.h
M Source/WTF/wtf/MemoryPressureHandler.cpp
M Source/WTF/wtf/MemoryPressureHandler.h
M Source/WTF/wtf/PlatformHave.h
M Source/WTF/wtf/PlatformOS.h
M Source/WTF/wtf/PlatformRegisters.h
M Source/WTF/wtf/StackBounds.cpp
M Source/WTF/wtf/posix/ThreadingPOSIX.cpp
M Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp
M Source/WebCore/platform/network/DNS.cpp
M Source/cmake/WebKitCommon.cmake
M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  ---
  Allow building for QNX
https://bugs.webkit.org/show_bug.cgi?id=267864
rdar://problem/121381408

 Reviewed by Justin Michaud.

 The commit adds support for building on and for QNX systems:
 1. Add QNX OS definitions
 2. Recognize the QCC compiler as a front-end to GCC
 3. Implement QNX support in OS- and machine-specific code

* Source/JavaScriptCore/heap/BlockDirectory.cpp:
(JSC::BlockDirectory::updatePercentageOfPagedOutPages):
* Source/JavaScriptCore/runtime/MachineContext.h:
(JSC::MachineContext::framePointerImpl):
(JSC::MachineContext::instructionPointerImpl):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::llintInstructionPointer):
* Source/WTF/wtf/InlineASM.h:
* Source/WTF/wtf/MemoryPressureHandler.cpp:
(WTF::MemoryPressureHandler::MemoryPressureHandler):
* Source/WTF/wtf/MemoryPressureHandler.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/PlatformOS.h:
* Source/WTF/wtf/PlatformRegisters.h:
* Source/WTF/wtf/StackBounds.cpp:
(WTF::StackBounds::newThreadStackBounds):
* Source/WTF/wtf/posix/ThreadingPOSIX.cpp:
* Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:
(WTF::processMemoryUsage):
* Source/WebCore/platform/network/DNS.cpp:
* Source/cmake/WebKitCommon.cmake:
* Source/cmake/WebKitCompilerFlags.cmake:

Canonical link: https://commits.webkit.org/273370@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4a18e: Use more smart pointers under WebCore/css/parser

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4a18ee4b8d7b456de7cd8f2bc6c4dc53826819e
  
https://github.com/WebKit/WebKit/commit/a4a18ee4b8d7b456de7cd8f2bc6c4dc53826819e
  Author: Chris Dumez 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/css/parser/CSSParser.h
M Source/WebCore/css/parser/CSSParserFastPaths.cpp
M Source/WebCore/css/parser/CSSParserImpl.cpp
M Source/WebCore/css/parser/CSSParserImpl.h
M Source/WebCore/css/parser/CSSParserObserverWrapper.h
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp
M Source/WebCore/dom/StyledElement.cpp
M Source/WebCore/inspector/InspectorStyleSheet.cpp

  Log Message:
  ---
  Use more smart pointers under WebCore/css/parser
https://bugs.webkit.org/show_bug.cgi?id=267902

Reviewed by Brent Fulgham.

* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleScope::setStyleSheetContents):
* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSheetForInspector):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::color):
(WebCore::CSSParser::parseSingleValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyValue):
(WebCore::CSSParser::parseInlineStyleDeclaration):
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::parseSimpleTransformValue):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::parseValue):
(WebCore::CSSParserImpl::parseCustomPropertyValue):
(WebCore::createStyleProperties):
(WebCore::CSSParserImpl::parseInlineStyleDeclaration):
(WebCore::CSSParserImpl::parseStyleSheetForInspector):
(WebCore::CSSParserImpl::protectedStyleSheet const):
(WebCore::CSSParserImpl::consumeNestedGroupRules):
(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):
(WebCore::CSSParserImpl::consumePageRule):
(WebCore::CSSParserImpl::consumeScopeRule):
(WebCore::CSSParserImpl::consumeStyleRule):
(WebCore::CSSParserImpl::consumeBlockContent):
* Source/WebCore/css/parser/CSSParserImpl.h:
(WebCore::CSSParserImpl::tokenizer const):
* Source/WebCore/css/parser/CSSParserObserverWrapper.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyInitialValue):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::consumeCSSWideKeyword):
(WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax):
(WebCore::CSSPropertyParser::parseCounterStyleDescriptor):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::parsePropertyDescriptor):
(WebCore::CSSPropertyParser::parseFontPaletteValuesDescriptor):
(WebCore::CSSPropertyParser::consumeTextDecorationSkip):
(WebCore::CSSPropertyParser::consumeFontSynthesis):
(WebCore::CSSPropertyParser::consumeBorderSpacing):
(WebCore::CSSPropertyParser::consume2ValueShorthand):
(WebCore::CSSPropertyParser::consume4ValueShorthand):
(WebCore::CSSPropertyParser::consumeLegacyBreakProperty):
(WebCore::CSSPropertyParser::consumeGridItemPositionShorthand):
(WebCore::CSSPropertyParser::consumeGridAreaShorthand):
(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSPropertyParser::consumeGridTemplateShorthand):
(WebCore::CSSPropertyParser::consumePlaceContentShorthand):
(WebCore::CSSPropertyParser::consumePlaceItemsShorthand):
(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
(WebCore::CSSPropertyParser::consumeOverscrollBehaviorShorthand):
(WebCore::CSSPropertyParser::consumeContainerShorthand):
(WebCore::CSSPropertyParser::consumeContainIntrinsicSizeShorthand):
(WebCore::CSSPropertyParser::consumePrefixedPerspective):
(WebCore::CSSPropertyParser::consumeScrollTimelineShorthand):
(WebCore::CSSPropertyParser::consumeViewTimelineShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeCalcRawWithKnownTokenTypeFunction):
(WebCore::CSSPropertyParserHelpers::IntegerTypeRawKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::NumberRawKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::PercentRawKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::LengthRawKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::AngleRawKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::ImageSetTypeCSSPrimitiveValueKnownTokenTypeFunctionConsumer::consume):
(WebCore::CSSPropertyParserHelpers::consumeNumberOrPercent):
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParser

[webkit-changes] [WebKit/WebKit] 83caf0: [Gardening]: REGRESSION (259678@main): [ iOS17 ] A...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83caf051d60359ae951092a030e7c355b8b28def
  
https://github.com/WebKit/WebKit/commit/83caf051d60359ae951092a030e7c355b8b28def
  Author: Marta Darbinyan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/platform/ios-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (259678@main): [ iOS17 ] ASSERTION FAILED: 
task.callback for 
fast/dom/Orientation/no-orientation-change-event-when-unparenting-view.html 
result of a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=267934
rdar://121454476

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/273368@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b0d92: WebKit API should support loading file reference URLs

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b0d92f22315da25f50c27276c875f14a5502adc
  
https://github.com/WebKit/WebKit/commit/4b0d92f22315da25f50c27276c875f14a5502adc
  Author: Per Arne Vollan 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

  Log Message:
  ---
  WebKit API should support loading file reference URLs
https://bugs.webkit.org/show_bug.cgi?id=267928
rdar://120389511

Reviewed by Brent Fulgham.

WebKit API should support loading file reference URLs with the form 
file:///.file/id=...
A file reference URL can be resolved to the actual file with the NSURL method 
filePathURL.

* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::consume):
(WebKit::resolvePathForSandboxExtension):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandleForReadByAuditToken):
(WebKit::SandboxExtension::createHandleForIOKitClassExtension):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):

Canonical link: https://commits.webkit.org/273367@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 274376: Adopt dynamicDowncast<> in ReplaceSelectionCommand

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2743761833d208e88e6cce0382060b4978a0efb4
  
https://github.com/WebKit/WebKit/commit/2743761833d208e88e6cce0382060b4978a0efb4
  Author: Anne van Kesteren 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/editing/ReplaceSelectionCommand.cpp

  Log Message:
  ---
  Adopt dynamicDowncast<> in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=267701
rdar://121433017

Reviewed by Chris Dumez.

Partially revert a change made in 273354@main. Using RefPtr as
argument causes reference churn.

* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::shouldMerge):

Canonical link: https://commits.webkit.org/273366@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 265b18: Synchronize css/css-pseudo WPT

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 265b18256bed47a9e31b83f3427a498cf30e88c6
  
https://github.com/WebKit/WebKit/commit/265b18256bed47a9e31b83f3427a498cf30e88c6
  Author: Anne van Kesteren 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-011-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-012-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-014-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-016-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-018-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-021-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-025-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-027-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-031-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-031.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/active-selection-041-expected-mismatch.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/backdrop-animate-002.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/cascade-highlight-005-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/chrome-first-letter-inside-replaced-crash.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-float-expected-mismatch.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-float.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-digraph-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-digraph.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-with-preceding-new-line-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-with-preceding-new-line.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-float-mapped-attribute-crash.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-no-transition-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-no-transition-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-no-transition.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-transition-crash.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-with-transition-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-with-transition-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-inherited-with-transition.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-input-image-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-002-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-002-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-002.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-007-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-007.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-008-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-008-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-008.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-009-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-cascade-009.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-painting-properties-001-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-painting-properties-001-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-painting-properties-001.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-painting-properties-002-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-painting-proper

[webkit-changes] [WebKit/WebKit] 8343db: Build for Apple Silicon for EWS

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8343db4cbb469d4f12731d839d64545d264e44a6
  
https://github.com/WebKit/WebKit/commit/8343db4cbb469d4f12731d839d64545d264e44a6
  Author: Robert Jenner 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  Build for Apple Silicon for EWS
https://bugs.webkit.org/show_bug.cgi?id=267927
rdar://121446379

Reviewed by Jonathan Bedard.

Building for Apple Silicon architecture in EWS so we can test on Apple Silicon 
in the future.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/273364@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0c2cff: Versioning.

[MyahCobbs]

  Branch: refs/heads/safari-7617.2.4.12-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: 0c2cff22952c5323f2b61b64023b1e3ba691a9c1
  
https://github.com/WebKit/WebKit/commit/0c2cff22952c5323f2b61b64023b1e3ba691a9c1
  Author: Dan Robson 
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-617.2.4.12.1

Canonical link: https://commits.webkit.org/267815.657@safari-7617.2.4.12-branch


  Commit: ee59b4604ac2a83c5f7f2f8d8486eb37402a70b2
  
https://github.com/WebKit/WebKit/commit/ee59b4604ac2a83c5f7f2f8d8486eb37402a70b2
  Author: Myah Cobbs 
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.2.4.12.2

Identifier: 267815.658@safari-7617.2.4.12-branch


Compare: https://github.com/WebKit/WebKit/compare/0c2cff22952c%5E...ee59b4604ac2
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b54a0e: Versioning.

[Jonathan Bedard]

  Branch: refs/heads/safari-7617.2.4.13-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: b54a0ed55c15689649e1c787bbf2dbb3c6058e93
  
https://github.com/WebKit/WebKit/commit/b54a0ed55c15689649e1c787bbf2dbb3c6058e93
  Author: Dan Robson 
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-617.2.4.13.1

Canonical link: https://commits.webkit.org/267815.657@safari-7617.2.4.13-branch


  Commit: 0259f6a78fec9fe72016a5dc26d32f582c070a28
  
https://github.com/WebKit/WebKit/commit/0259f6a78fec9fe72016a5dc26d32f582c070a28
  Author: Myah Cobbs 
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.2.4.13.2

Identifier: 267815.658@safari-7617.2.4.13-branch


  Commit: 8ea511cad86b9eaf409495886245cab178b2b6d8
  
https://github.com/WebKit/WebKit/commit/8ea511cad86b9eaf409495886245cab178b2b6d8
  Author: Dan Robson 
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-617.2.4.13.3

Canonical link: https://commits.webkit.org/267815.659@safari-7617.2.4.13-branch


  Commit: ca5fbf3edccd3a2468a7a4bebed0a4a38e6d442a
  
https://github.com/WebKit/WebKit/commit/ca5fbf3edccd3a2468a7a4bebed0a4a38e6d442a
  Author: Dan Robson 
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGGraph.cpp

  Log Message:
  ---
  Apply patch. rdar://120564724

Canonical link: https://commits.webkit.org/267815.660@safari-7617.2.4.13-branch


Compare: https://github.com/WebKit/WebKit/compare/b54a0ed55c15%5E...ca5fbf3edccd
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 78ed1f: Rename VideoFullscreenInterfaceAVKit to VideoFulls...

[danae404]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 78ed1f1974b1a600f57bba1b75cc714d53548034
  
https://github.com/WebKit/WebKit/commit/78ed1f1974b1a600f57bba1b75cc714d53548034
  Author: Dana Estra 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/platform/graphics/PlatformVideoFullscreenInterface.h
R Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
R Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
A Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.h
A Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  ---
  Rename VideoFullscreenInterfaceAVKit to VideoFullscreenInterfaceIOS
https://bugs.webkit.org/show_bug.cgi?id=267884
rdar://121399424

Reviewed by Andy Estes.

Rename VideoFullscreenInterfaceAVKit to VideoFullscreenInterfaceIOS for future
refactoring.

* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/html/HTMLMediaElement.cpp:
* Source/WebCore/platform/graphics/PlatformVideoFullscreenInterface.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.h: Renamed from 
Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h.
* Source/WebCore/platform/ios/VideoFullscreenInterfaceIOS.mm: Renamed from 
Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm.
(clearUIColor):
(boolString):
(-[WebAVPlayerViewControllerDelegate fullscreenInterface]):
(-[WebAVPlayerViewControllerDelegate setFullscreenInterface:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerWillStartPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerDidStartPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewController:failedToStartPictureInPictureWithError:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerWillStopPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerDidStopPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerShouldAutomaticallyDismissAtPictureInPictureStart:]):
(convertToExitFullScreenReason):
(-[WebAVPlayerViewControllerDelegate 
playerViewController:shouldExitFullScreenWithReason:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewController:restoreUserInterfaceForPictureInPictureStopWithCompletionHandler:]):
(-[WebAVPlayerViewControllerDelegate 
playerViewControllerShouldStartPictureInPictureFromInlineWhenEnteringBackground:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureControllerWillStartPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureControllerDidStartPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureController:failedToStartPictureInPictureWithError:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureControllerWillStopPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureControllerDidStopPictureInPicture:]):
(-[WebAVPlayerViewControllerDelegate 
pictureInPictureController:restoreUserInterfaceForPictureInPictureStopWithCompletionHandler:]):
(WebAVPictureInPictureContentViewController_initWithController):
(WebAVPictureInPictureContentViewController_controller):
(WebAVPictureInPictureContentViewController_playerLayer):
(WebAVPictureInPictureContentViewController_setPlayerLayer):
(WebAVPictureInPictureContentViewController_viewWillLayoutSubviews):
(WebAVPictureInPictureContentViewController_dealloc):
(allocWebAVPictureInPictureContentViewControllerInstance):
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController 
configurePlayerViewControllerWithFullscreenInterface:]):
(-[WebAVPlayerViewController dealloc]):
(-[WebAVPlayerViewController playerViewControllerShouldHandleDoneButtonTap:]):
(-[WebAVPlayerViewController 
setWebKitOverrideRouteSharingPolicy:routingContextUID:]):
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVPlayerViewController initObserver]):
(-[WebAVPlayerViewController removeObserver]):
(-[WebAVPlayerViewController MY_NO_RETURN]):
(-[WebAVPlayerViewController isPictureInPicturePossible]):
(-[WebAVPlayerViewController isPictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]):
(-[WebAVPlayerViewController view]):
(-[WebAVPlayerViewController flashPlaybac

[webkit-changes] [WebKit/WebKit] 4191fa: Remove unused handwritten decoder for WebCore::App...

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4191facdbfa026c3355647638a8dab5f6a7ca4c6
  
https://github.com/WebKit/WebKit/commit/4191facdbfa026c3355647638a8dab5f6a7ca4c6
  Author: Simon Lewis 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.h

  Log Message:
  ---
  Remove unused handwritten decoder for WebCore::ApplePayError
https://bugs.webkit.org/show_bug.cgi?id=267737
rdar://121220118

Reviewed by Aditya Keerthi.

WebCore::ApplePayError is declared in WebCoreArgumentCoders.serialization.in.

* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder>::encode): Deleted.
(IPC::ArgumentCoder>::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:

Canonical link: https://commits.webkit.org/273362@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 74e3ec: Generate serialization for WebCore::TextRecognitio...

[Simon Lewis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74e3ec78b8b5f071640c0e4e5fd10232ed6ea001
  
https://github.com/WebKit/WebKit/commit/74e3ec78b8b5f071640c0e4e5fd10232ed6ea001
  Author: Simon Lewis 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/platform/TextRecognitionResult.h
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.h
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Generate serialization for WebCore::TextRecognitionDataDetector
https://bugs.webkit.org/show_bug.cgi?id=267641
rdar://121125342

Reviewed by Alex Christensen.

* Source/WebCore/platform/TextRecognitionResult.h:
(WebCore::TextRecognitionDataDetector::TextRecognitionDataDetector):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder::encodePlatformData): 
Deleted.
(IPC::ArgumentCoder::decodePlatformData): 
Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/273361@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2887ee: Implement experimental allow="private-token" permi...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2887eed67e7d43da879523f2b3f8a9b3aee2a406
  
https://github.com/WebKit/WebKit/commit/2887eed67e7d43da879523f2b3f8a9b3aee2a406
  Author: Matthew Finkel 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
M Source/WebCore/html/FeaturePolicy.cpp
M Source/WebCore/html/FeaturePolicy.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/platform/network/ResourceRequestBase.cpp
M Source/WebCore/platform/network/ResourceRequestBase.h
M Source/WebCore/platform/network/cf/ResourceRequest.h
M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm
M Source/WebKit/NetworkProcess/NetworkProcess.cpp
M Source/WebKit/NetworkProcess/NetworkProcess.h
M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/NetworkSession.cpp
M Source/WebKit/NetworkProcess/NetworkSession.h
M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
M 
Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in
M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm

  Log Message:
  ---
  Implement experimental allow="private-token" permissions policy
https://bugs.webkit.org/show_bug.cgi?id=266549
rdar://107854094

Reviewed by Youenn Fablet.

This patch implements a new experimental permissions policy that provides
third-party contexts with access to using Private Tokens, as described in the
explainer [0]. If a third-party context is not granted the permission, then it
is not allowed to interact in the specified HTTP Authorization [1] flow. If the
context is given permission, then that interaction happens at a lower layer
than WebKit on Cocoa platforms.

[0] https://github.com/WebKit/explainers/tree/main/ThirdPartyPrivateTokens
[1] https://datatracker.ietf.org/doc/draft-ietf-privacypass-auth-scheme/

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/html/FeaturePolicy.cpp:
(WebCore::policyTypeName):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):
* Source/WebCore/html/FeaturePolicy.h:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::updateRequestAndAddExtraFields):
* Source/WebCore/platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setAsIsolatedCopy):
(WebCore::ResourceRequestBase::setIsPrivateTokenUsageByThirdPartyAllowed):
* Source/WebCore/platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::RequestData::RequestData):
(WebCore::ResourceRequestBase::isPrivateTokenUsageByThirdPartyAllowed const):
* Source/WebCore/platform/network/cf/ResourceRequest.h:
* Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::getResourceRequestPlatformData const):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setShouldSendPrivateTokenIPCForTesting const):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::setShouldSendPrivateTokenIPCForTesting):
* Source/WebKit/NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::shouldSendPrivateTokenIPCForTesting const):
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* 
Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteD

[webkit-changes] [WebKit/WebKit] a615ee: Cherry-pick 271942@main (31a74b0f44c2). https://bu...

[Aditya Keerthi]

  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: a615eea726cdbbc553375961be0fa5ab9b207291
  
https://github.com/WebKit/WebKit/commit/a615eea726cdbbc553375961be0fa5ab9b207291
  Author: Vitaly Dyachkov 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  ---
  Cherry-pick 271942@main (31a74b0f44c2). 
https://bugs.webkit.org/show_bug.cgi?id=266067

[GTK][Debug] `accessibility/aria-combobox-control-owns-elements.html` is a 
constant crash
https://bugs.webkit.org/show_bug.cgi?id=266067

Reviewed by Tyler Wilcock.

In `AXObjectCache::getOrCreate(Node*, IsRelationTarget)`, we might
update relatons while evaluating `isDescendantOfRelationTarget(*node)`.

If the node has relation attributes, associated `AccessibilityObject`
will be created and cached. In this case, we must return the cached object.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):

Canonical link: https://commits.webkit.org/271942@main


  Commit: 2fea3c3decb7c318de82d3c63eb26834c84f8372
  
https://github.com/WebKit/WebKit/commit/2fea3c3decb7c318de82d3c63eb26834c84f8372
  Author: Elliott Williams 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb
M Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb

  Log Message:
  ---
  Cherry-pick 271640@main (97b3a2dd3db7). 
https://bugs.webkit.org/show_bug.cgi?id=265729

[offlineasm] Incremental build failure when generator is interrupted
https://bugs.webkit.org/show_bug.cgi?id=265729
rdar://119079705

Reviewed by Alexey Proskuryakov.

offlineasm writes headers non-atomically, so if the script is
interrupted due to a build failure in a parallel task, it leaves a
partially-written header. The build system can't tell that this header
is incomplete, so its presence breaks subsequent rebuilds.

Fix by writing to a temporary file in the same directory (or
TARGET_TEMP_DIR in Xcode), and `rename`-ing once generation is complete.

* Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:
* Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:

Canonical link: https://commits.webkit.org/271640@main


  Commit: a5a3b71329aa10f7e1c31c0c48135702e026261e
  
https://github.com/WebKit/WebKit/commit/a5a3b71329aa10f7e1c31c0c48135702e026261e
  Author: Mark Lam 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/b3/B3ReduceStrength.cpp
M Source/JavaScriptCore/b3/testb3.h
M Source/JavaScriptCore/b3/testb3_1.cpp
M Source/JavaScriptCore/b3/testb3_7.cpp

  Log Message:
  ---
  Cherry-pick 271580@main (ab0808f76fdb). 
https://bugs.webkit.org/show_bug.cgi?id=265730

Fix nullptr deref in B3::ReduceStrength's handling of Trunc for double 
constants.
https://bugs.webkit.org/show_bug.cgi?id=265730
rdar://116459635

Reviewed by Yusuke Suzuki.

We cannot run asInt64() on a ConstDoubleValue.  This patch fixes this by 
handling
ConstDoubleValue separately and running asDouble() on it instead.

* Source/JavaScriptCore/b3/B3ReduceStrength.cpp:

Canonical link: https://commits.webkit.org/271580@main


  Commit: 766e782517d4e6d0015a24f16a382da6a1c2bcc0
  
https://github.com/WebKit/WebKit/commit/766e782517d4e6d0015a24f16a382da6a1c2bcc0
  Author: Jacek Piszczek 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Source/JavaScriptCore/runtime/UGPRPair.h

  Log Message:
  ---
  Cherry-pick 271440@main (5d40427dff12). 
https://bugs.webkit.org/show_bug.cgi?id=265342

Fixed UGPRPair for big endian cpus
https://bugs.webkit.org/show_bug.cgi?id=265342

Reviewed by Yusuke Suzuki.

Fixes up the order at which the registers are packed into a  UGPRPair on 
CPU(BIG_ENDIAN).

* Source/JavaScriptCore/runtime/UGPRPair.h:
(JSC::makeUGPRPair):

Canonical link: https://commits.webkit.org/271440@main


  Commit: 96e017a6c83991b7a32fabb672972ee2a10edb15
  
https://github.com/WebKit/WebKit/commit/96e017a6c83991b7a32fabb672972ee2a10edb15
  Author: Michael Catanzaro 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp
M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp

  Log Message:
  ---
  Cherry-pick 271013@main (bcd2223c9362). 
https://bugs.webkit.org/show_bug.cgi?id=195908

[SOUP] webkit_web_context_allow_tls_certificate_for_host() fails for IPv6 
URIs produced by SoupURI
https://bugs.webkit.org/show_bug.cgi?id=195908

Reviewed by Carlos Garcia Campos.

Nowadays SoupURI has been replaced by GUri, but the underlying problem
remains: IPv6 addresses in URLs have to be surrounde

[webkit-changes] [WebKit/WebKit] e2264e: Versioning.

[Russell Epstein]

  Branch: refs/heads/safari-7617.2.4.11-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: e2264e53553ad93a2d56b2f77113cddd6c970aa8
  
https://github.com/WebKit/WebKit/commit/e2264e53553ad93a2d56b2f77113cddd6c970aa8
  Author: Dan Robson 
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-617.2.4.11.1

Canonical link: https://commits.webkit.org/267815.657@safari-7617.2.4.11-branch


  Commit: 670a4adb29bf7be4a2564a5730afff199701aa5f
  
https://github.com/WebKit/WebKit/commit/670a4adb29bf7be4a2564a5730afff199701aa5f
  Author: Russell Epstein 
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7617.2.4.11.2

Canonical link: https://commits.webkit.org/267815.658@safari-7617.2.4.11-branch


  Commit: 8699d5fa7a975f4ab0c8bb10db77967d2b9fb962
  
https://github.com/WebKit/WebKit/commit/8699d5fa7a975f4ab0c8bb10db77967d2b9fb962
  Author: Dan Robson 
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-617.2.4.11.3

Canonical link: https://commits.webkit.org/267815.659@safari-7617.2.4.11-branch


  Commit: b80a293b367b728053857f91999335a22abc64a1
  
https://github.com/WebKit/WebKit/commit/b80a293b367b728053857f91999335a22abc64a1
  Author: Dan Robson 
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
M Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp
M Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp
M 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp
M 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm

  Log Message:
  ---
  Cherry-pick 2bee8872e3b9. rdar://118004786

REGRESSION (233845@main): Crash in 
MediaKeySystemRequest::~MediaKeySystemRequest
https://bugs.webkit.org/show_bug.cgi?id=266619
rdar://118004786

Reviewed by Jean-Yves Avenard.

In 233845@main, NavigatorEME::requestMediaKeySystemAccess moved the task 
that creates the CDM
instance into a completion handler that's called asynchronously once the 
client allows media key
access. The completion handler captured a raw pointer to the document, 
leading to a crash if the
document is destroyed before the completion handler is called. Debug builds 
would also assert in
CompletionHandler::~CompletionHandler because 
ActiveDOMObject::queueTaskInEventLoop would not
invoke the task queued by MediaKeySystemRequest::allow - which captured a 
CompletionHandler - when
scriptExecutionContext is null.

Addressed the crash by capturing document as a WeakPtr and null-checking it 
prior to calling
Document::postTask in NavigatorEME::requestMediaKeySystemAccess's allow 
callback. Addressed the
assertion failure by removing the unnecessary asynchronous 
CompletionHandler from
Messages::WebPage::MediaKeySystemWasGranted.

* Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp:
(WebCore::MediaKeySystemRequest::allow):
* Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h:
* Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp:
(WebCore::NavigatorEME::requestMediaKeySystemAccess):
* Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp:
(WebKit::MediaKeySystemPermissionRequestManagerProxy::grantRequest):
* 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp:
(WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasGranted):
* 
Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mediaKeySystemWasGranted):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm:
(WebMediaKeySystemClient::requestMediaKeySystem):

Canonical link: https://commits.webkit.org/267815.655@safari-7617-branch

Canonical link: https://commits.webkit.org/267815.660@safari-7617.2.4.11-branch


  Commit: 2b8379635f5e78119596fa059511847592056789
  
https://github.com/WebKit/WebKit/commit/2b8379635f5e78119596fa059511847592056789
  Author: Dan Robson 
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

  Log Message:
  -

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/heads/safari-7617.2.4-branch
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/heads/safari-7617.2.3-branch
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Jonathan Bedard]

  Branch: refs/heads/safari-7617.2.1-branch
  Home:   https://github.com/WebKit/WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05bdeb: [WebRTC] Handle empty H264 packets on bad input

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05bdebfadc98c92d512b857341bd816ff1dd4dcc
  
https://github.com/WebKit/WebKit/commit/05bdebfadc98c92d512b857341bd816ff1dd4dcc
  Author: David Kilzer 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M 
Source/ThirdParty/libwebrtc/Source/webrtc/docs/native-code/development/README.md
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/BUILD.gn
A 
Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/rtp_format_h264_fuzzer.cc
M Source/ThirdParty/libwebrtc/Source/webrtc/whitespace.txt
R 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Release-assertion-in-webrtc-RtpPacketizerH264-PacketizeSingleNalu.patch
R 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Release-assertion-in-webrtc-RtpPacketizerH264.patch

  Log Message:
  ---
  [WebRTC] Handle empty H264 packets on bad input
https://bugs.webkit.org/show_bug.cgi?id=267906


Reviewed by Youenn Fablet.

Merge upstream webrtc fix:
  Add H264 packetizer fuzzer
  


Also revert these changes as they're not needed:
  
  

* 
Source/ThirdParty/libwebrtc/Source/webrtc/docs/native-code/development/README.md:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/BUILD.gn:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/rtp_format_h264_fuzzer.cc:
 Add.
* Source/ThirdParty/libwebrtc/Source/webrtc/whitespace.txt:

* 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Release-assertion-in-webrtc-RtpPacketizerH264-PacketizeSingleNalu.patch:
 Remove.
* 
Source/ThirdParty/libwebrtc/WebKit/0001-WebRTC-Release-assertion-in-webrtc-RtpPacketizerH264.patch:
 Remove.

Canonical link: https://commits.webkit.org/273359@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d17d9f: Add target for h264_bitstream_parser_fuzzer

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d17d9faa12da09836a1259e79ffbc5449ca4b336
  
https://github.com/WebKit/WebKit/commit/d17d9faa12da09836a1259e79ffbc5449ca4b336
  Author: David Kilzer 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
A 
Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig
M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

  Log Message:
  ---
  Add target for h264_bitstream_parser_fuzzer
https://bugs.webkit.org/show_bug.cgi?id=267896


Reviewed by Youenn Fablet.

* 
Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig:
 Add.
* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
- Add h264_bitstream_parser_fuzzer.cc to the project.
- Add target for h264_bitstream_parser_fuzzer.
- Add h264_bitstream_parser_fuzzer target to "Fuzzers (libwebrtc)" target.

Canonical link: https://commits.webkit.org/273358@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 83e647: [UnifiedPDF] Printing a main frame containing a PD...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83e647adbd3621ba3de4e883189ebb4c0c4ea500
  
https://github.com/WebKit/WebKit/commit/83e647adbd3621ba3de4e883189ebb4c0c4ea500
  Author: Abrar Rahman Protyasha 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  ---
  [UnifiedPDF] Printing a main frame containing a PDF should print the PDF and 
not the plugin
https://bugs.webkit.org/show_bug.cgi?id=267898
rdar://119632457

Reviewed by Tim Horton.

UnifiedPDFPlugin returns a nil PDFDocumentRef (and an empty size) when a
print is initiated, which means that a print operation on a main frame
PDF yields unexpected results.

This patch addresses the issue by devirtualizing the
pdfDocument[size]forPrinting family of functions, and instead letting
both PDF plugin implementations share the definition now housed in
PDFPluginBase.

Furthermore, we remove some conditional code in WebPage and WKBundlePage
that avoided querying the UnifiedPDF plugin for the associated PDF
document size and reference.

* Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:
(WKBundlePageGetPDFDocumentInFrame):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentSizeForPrinting const): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::pdfDocumentForPrinting const):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::pdfDocumentSizeForPrinting const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::pdfDocumentForPrinting const): Deleted.
(WebKit::UnifiedPDFPlugin::pdfDocumentSizeForPrinting const): Deleted.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::getPDFFirstPageSize):

Canonical link: https://commits.webkit.org/273357@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f272a: AX: Remove dead code from AXIsolatedObject::getOrR...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f272ab1ac5c945207d05662cd3248df6f0604ec
  
https://github.com/WebKit/WebKit/commit/7f272ab1ac5c945207d05662cd3248df6f0604ec
  Author: Andres Gonzalez 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  ---
  AX: Remove dead code from AXIsolatedObject::getOrRetrievePropertyValue.
https://bugs.webkit.org/show_bug.cgi?id=267894


Reviewed by Tyler Wilcock.

Removed the lazy retrieval of the AccessibilityText property that is now cached 
eagerly, making this switch case unnecessary.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::getOrRetrievePropertyValue):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Removed unused enumerators.

Canonical link: https://commits.webkit.org/273356@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d8dc3: Use a smart pointer for RemoteLayerTreeHost::m_dra...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d8dc32fa51b3809870a01954ac019de3f6de688
  
https://github.com/WebKit/WebKit/commit/9d8dc32fa51b3809870a01954ac019de3f6de688
  Author: Alex Christensen 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm

  Log Message:
  ---
  Use a smart pointer for RemoteLayerTreeHost::m_drawingArea
https://bugs.webkit.org/show_bug.cgi?id=267770
rdar://121264073

Reviewed by Chris Dumez.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h:
(WebKit::RemoteLayerTreeHost::drawingArea const): Deleted.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::drawingArea const):

Canonical link: https://commits.webkit.org/273355@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7b69f: Adopt dynamicDowncast<> in ReplaceSelectionCommand

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7b69f5ea804100eb22e0a312c074a59425d4453
  
https://github.com/WebKit/WebKit/commit/f7b69f5ea804100eb22e0a312c074a59425d4453
  Author: Anne van Kesteren 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/editing/ReplaceSelectionCommand.cpp

  Log Message:
  ---
  Adopt dynamicDowncast<> in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=267701

Reviewed by Ryosuke Niwa.

* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
(WebCore::ReplacementFragment::removeInterchangeNodes):
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::shouldMerge):
(WebCore::fragmentNeedsColorTransformed):
(WebCore::ReplaceSelectionCommand::inverseTransformColor):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace const):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::mergeTextNodesAroundPosition):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

Canonical link: https://commits.webkit.org/273354@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 15c6ce: Make the SVG parser interpret `form feed` as white...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15c6cea827c0761eb8c1b8638fc12568bf4170b3
  
https://github.com/WebKit/WebKit/commit/15c6cea827c0761eb8c1b8638fc12568bf4170b3
  Author: Ahmad Saleem 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
A LayoutTests/svg/transforms/svg-formFeed-as-whitespace-expected.html
A LayoutTests/svg/transforms/svg-formFeed-as-whitespace.html
A 
LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace-expected.html
A LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace.html
M Source/WebCore/svg/SVGParserUtilities.cpp
M Source/WebCore/svg/SVGParserUtilities.h
M Source/WebCore/svg/SVGStringList.cpp

  Log Message:
  ---
  Make the SVG parser interpret `form feed` as whitespace

https://bugs.webkit.org/show_bug.cgi?id=77755
rdar://problem/95488677

Reviewed by Anne van Kesteren.

This patch is to align WebKit with Chromium / Blink, Gecko / Firefox and Web 
Specification [1]:

[1] https://lists.w3.org/Archives/Public/public-svg-wg/2014AprJun/0068.html

This patch uses 'isASCIIWhite' across SVG Parser and code base to enable it to 
handle 'form feed'.

It is inspired by following change in Blink, which enables 'leading' and 
'trailing' whitespace
in SVG Attributes [2]:

[2] https://src.chromium.org/viewvc/blink?view=revision&revision=175785

Credits to Jacob Goldstein   for 'test case'.

* Source/WebCore/svg/SVGParserUtilities.cpp:
(parseGlyphName):
* Source/WebCore/svg/SVGParserUtilities.h:
(isSVGSpace): Deleted
(isSVGSpaceOrComma): Updated
(skipOptionalSVGSpaces):
(skipOptionalSVGSpacesOrDelimiter): Both templates
* Source/WebCore/svg/SVGStringList.cpp:
(SVGStringList::parse):
* LayoutTests/svg/transforms/svg-formFeed-as-whitespace.html: Add Test Case
* LayoutTests/svg/transforms/svg-formFeed-as-whitespace-expected.html: Add Test 
Case Expectation
* LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace.html: Add 
Test Case
* 
LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace-expected.html: 
Add Test Case Expectation

Canonical link: https://commits.webkit.org/273353@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 842a65: Update web-platform-tests/mediacapture-insertable-...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 842a65665da8006ce56e5135cad3d52e8b4258a2
  
https://github.com/WebKit/WebKit/commit/842a65665da8006ce56e5135cad3d52e8b4258a2
  Author: Youenn Fablet 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/META.yml
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-service-worker.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-service-worker.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-shared-worker.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-shared-worker.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-worker.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-in-worker.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-pipes-data-in-worker.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-pipes-data-in-worker.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-audio.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-audio.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-backpressure.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-backpressure.https.html
M 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-maxBufferSize.worker.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-video.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-video.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/MediaStreamTrackProcessor-worker.js
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.https-expected.txt
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/VideoTrackGenerator.https.html
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/dedicated-worker.js
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/service-worker.js
R 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/shared-worker.js
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-audio.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-audio.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-service-worker.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-service-worker.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-shared-worker.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-shared-worker.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-worker.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-in-worker.https.html
A 
LayoutTests/imported/w3c/web-platform-tests/mediacapture-insertable-streams/tentative/MediaStreamTrackGenerator-pipes-data-in-worker.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/

[webkit-changes] [WebKit/WebKit] bfcf9b: [@starting-style] Add parsing support

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bfcf9bf5da23fd0e272fa6b63fd1f6830322a576
  
https://github.com/WebKit/WebKit/commit/bfcf9bf5da23fd0e272fa6b63fd1f6830322a576
  Author: Antti Koivisto 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-name-defining-rules-expected.txt
R 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-transitions/starting-style-name-defining-rules-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/StyleRule.h
M Source/WebCore/css/StyleRuleType.h
M Source/WebCore/css/StyleSheetContents.cpp
M Source/WebCore/css/parser/CSSAtRuleID.cpp
M Source/WebCore/css/parser/CSSAtRuleID.h
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/css/parser/CSSParserImpl.cpp
M Source/WebCore/css/parser/CSSParserImpl.h
M Source/WebCore/inspector/InspectorStyleSheet.cpp
M Source/WebCore/style/ElementRuleCollector.cpp
M Source/WebCore/style/MatchResult.h
M Source/WebCore/style/PropertyCascade.cpp
M Source/WebCore/style/PropertyCascade.h
M Source/WebCore/style/RuleData.cpp
M Source/WebCore/style/RuleData.h
M Source/WebCore/style/RuleSet.cpp
M Source/WebCore/style/RuleSetBuilder.cpp
M Source/WebCore/style/RuleSetBuilder.h

  Log Message:
  ---
  [@starting-style] Add parsing support
https://bugs.webkit.org/show_bug.cgi?id=267855
rdar://121373181

Reviewed by Matthieu Dubet.

Add support for parsing @starting-style rules.

https://drafts.csswg.org/css-transitions-2/#at-ruledef-starting-style

The styles are not actually used yet.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-name-defining-rules-expected.txt:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Add a setting. Not enabled yet.

* Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleBase::visitDerived):
(WebCore::StyleRuleBase::createCSSOMWrapper const):
(WebCore::StyleRuleScope::styleSheetContents const):
(WebCore::StyleRuleScope::setStyleSheetContents):
(WebCore::StyleRuleStartingStyle::create):
(WebCore::StyleRuleStartingStyle::StyleRuleStartingStyle):

Add a StyleRule.

* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRuleBase::isGroupRule const):
(WebCore::StyleRuleBase::isStartingStyleRule const):
(isType):
* Source/WebCore/css/StyleRuleType.h:
* Source/WebCore/css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::traverseSubresources const):
* Source/WebCore/css/parser/CSSAtRuleID.cpp:
(WebCore::cssAtRuleID):
* Source/WebCore/css/parser/CSSAtRuleID.h:
* Source/WebCore/css/parser/CSSParserContext.cpp:
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeStartingStyleRule):

Parse the rule. This is simple as there are no arguments to parse.

* Source/WebCore/css/parser/CSSParserImpl.h:
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::flatteningStrategyForStyleRuleType):
* Source/WebCore/style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::transferMatchedRules):
* Source/WebCore/style/MatchResult.h:
(WebCore::Style::operator==):
(WebCore::Style::add):

Pass if a given declaration belongs to starting-style.

* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::addMatch):

Skip @starting-style rules unless we are building a before-change RenderStyle.
With this patch we always skip.

* Source/WebCore/style/PropertyCascade.h:
* Source/WebCore/style/RuleData.cpp:
(WebCore::Style::RuleData::RuleData):
* Source/WebCore/style/RuleData.h:
(WebCore::Style::RuleData::isStartingStyle const):

Remember if the rule is part of a starting-style.

* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addChildRule):

Gather child rules from @starting-style.

(WebCore::Style::RuleSetBuilder::addStyleRuleWithSelectorList):
* Source/WebCore/style/RuleSetBuilder.h:

Canonical link: https://commits.webkit.org/273351@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f1b26b: Document::Document shouldn't construct Editor object

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1b26b939f9dc33b507fdb601c65cb518e3c6b59
  
https://github.com/WebKit/WebKit/commit/f1b26b939f9dc33b507fdb601c65cb518e3c6b59
  Author: Ryosuke Niwa 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  ---
  Document::Document shouldn't construct Editor object
https://bugs.webkit.org/show_bug.cgi?id=267901

Reviewed by Yusuke Suzuki and Cameron McCormack.

Don't create Editor object inside Document::Document. This was getting 
triggered via
shouldAlwaysUseDirectionalSelection inside FrameSelection::FrameSelection.

Also added a bunch of assertions to ensure we don't initialize these lazily 
constructed
objects at the end of Document::Document.

* Source/WebCore/dom/Document.cpp:
(WebCore::m_frameIdentifier):
(WebCore::Document::ensureQuirks):
(WebCore::Document::ensureCachedResourceLoader):
(WebCore::Document::ensureExtensionStyleSheets):
(WebCore::Document::ensureMarkers):
(WebCore::Document::ensureVisitedLinkState):
(WebCore::Document::ensureFullscreenManager):
(WebCore::Document::fontLoader):
(WebCore::Document::ensureFontLoader):
(WebCore::Document::ensureFontSelector):
(WebCore::Document::ensureUndoManager):
(WebCore::Document::ensureEditor):
(WebCore::Document::ensureReportingScope):
(WebCore::Document::originIdentifierForPasteboard const):
(WebCore::Document::isDNSPrefetchEnabled const):
(WebCore::Document::parseDNSPrefetchControlHeader):
* Source/WebCore/dom/Document.h:
(WebCore::Document::isDNSPrefetchEnabled const): Deleted.
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::shouldAlwaysUseDirectionalSelection):

Canonical link: https://commits.webkit.org/273350@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e9a06d: Initialize `m_hasViewTransitionPseudoElementTree` ...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9a06d26c2c4999ee2f445e3a415f4a9390a7fd6
  
https://github.com/WebKit/WebKit/commit/e9a06d26c2c4999ee2f445e3a415f4a9390a7fd6
  Author: Tim Nguyen 
  Date:   2024-01-23 (Tue, 23 Jan 2024)

  Changed paths:
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/ViewTransition.h

  Log Message:
  ---
  Initialize `m_hasViewTransitionPseudoElementTree` to false
https://bugs.webkit.org/show_bug.cgi?id=267914
rdar://121419584

Reviewed by Cameron McCormack.

* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/273349@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes