[webkit-changes] [WebKit/WebKit] e739d6: Simplify compiler flags checking in Source/ThirdPa...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e739d6576a590c7211f9438c5fa9d54fd4cb1ee6
https://github.com/WebKit/WebKit/commit/e739d6576a590c7211f9438c5fa9d54fd4cb1ee6
Author: Adrian Perez de Castro
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M Source/ThirdParty/skia/CMakeLists.txt
M Source/cmake/WebKitCompilerFlags.cmake
Log Message:
---
Simplify compiler flags checking in Source/ThirdParty/skia/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=270162
Reviewed by Michael Catanzaro.
Add new WEBKIT_CHECK_COMPILER_FLAGS and WEBKIT_ADD_COMPILER_FLAGS
functions, which split the existing functionality of the existing
WEBKIT_ADD_TARGET_{C,CXX}_FLAGS macros, making them more generic.
The old macros are kept for now, but implemented in terms of the
new functions.
While at it, the WEBKIT_ADD_COMPILER_FLAGS function was augmented to
support applying flags to SOURCE files and DIRECTORY paths, and a
tweak added to ensure results of checks for flags containing equals
characters (=) are properly cached by CMake to save some time in CMake
re-runs.
* Source/ThirdParty/skia/CMakeLists.txt: Make use of the new
WEBKIT_CHECK_COMPILER_FLAGS and WEBKIT_ADD_COMPILER_FLAGS functions.
* Source/cmake/WebKitCompilerFlags.cmake: Split and improve
functionality from the WEBKIT_ADD_TARGET_{C,CXX}_FLAGS macros into
a new function to check flags and another generic function to apply
flags to targets, sources, or directories.
Canonical link: https://commits.webkit.org/275430@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 373e74: [CMake] Use imported targets in find module for WP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 373e7435c3ccae2153b19a41f3c09f4bd4bcc8ef https://github.com/WebKit/WebKit/commit/373e7435c3ccae2153b19a41f3c09f4bd4bcc8ef Author: Adrian Perez de Castro Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/PlatformWPE.cmake M Source/WebKit/PlatformWPE.cmake A Source/cmake/FindWPEBackendFDO.cmake R Source/cmake/FindWPEBackend_fdo.cmake M Source/cmake/GStreamerChecks.cmake M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt M Tools/TestWebKitAPI/PlatformWPE.cmake M Tools/TestWebKitAPI/glib/PlatformWPE.cmake M Tools/WebKitTestRunner/PlatformWPE.cmake M Tools/wpe/backends/PlatformWPE.cmake Log Message: --- [CMake] Use imported targets in find module for WPEBackend-fdo https://bugs.webkit.org/show_bug.cgi?id=270167 Reviewed by Michael Catanzaro. Rename WPEBackend-fdo find module to WPEBackendFDO, make it define a WPE::FDO imported target, and change the rest of the CMake build system to use it. Simplify along the way and sprinkle a few changes from _LIBRARIES to _PRIVATE_LIBRARIES. * Source/WebCore/PlatformWPE.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/cmake/FindWPEBackendFDO.cmake: Added. * Source/cmake/FindWPEBackend_fdo.cmake: Removed. * Source/cmake/GStreamerChecks.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/CMakeLists.txt: * Tools/TestWebKitAPI/PlatformWPE.cmake: * Tools/TestWebKitAPI/glib/PlatformWPE.cmake: * Tools/WebKitTestRunner/PlatformWPE.cmake: * Tools/wpe/backends/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/275429@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cae1b4: [Gardening]: [ MacOS Debug ] fast/text/emoji-num-g...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cae1b453a115813489ac2cb8aefa3d92cfe94cf3 https://github.com/WebKit/WebKit/commit/cae1b453a115813489ac2cb8aefa3d92cfe94cf3 Author: Jay Stfleur Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ MacOS Debug ] fast/text/emoji-num-glyphs.html is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=123720564 rdar://123720564 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275428@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3108fc: Remove gender-differentiating test expectations fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3108fccd7c8ae9b1cedc0d23e9868808a093c0d9 https://github.com/WebKit/WebKit/commit/3108fccd7c8ae9b1cedc0d23e9868808a093c0d9 Author: Elika Etemad Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: R LayoutTests/fast/text/emoji-single-parent-family-3-expected-mismatch.html R LayoutTests/fast/text/emoji-single-parent-family-3.html R LayoutTests/fast/text/emoji-single-parent-family-expected-mismatch.html R LayoutTests/fast/text/emoji-single-parent-family.html M LayoutTests/platform/gtk/TestExpectations Log Message: --- Remove gender-differentiating test expectations for family emoji. https://bugs.webkit.org/show_bug.cgi?id=269947 rdar://122569544 Reviewed by Anne van Kesteren. Unicode ESC's latest recommendations are to render all gendered family emoji as gender-neutral, see: - https://www.unicode.org/L2/L2022/22276-family-emoji-guidelines.pdf - https://www.unicode.org/L2/L2023/23029-family-emoji.pdf Therefore our tests requiring that they mismatch need to be removed. * LayoutTests/fast/text/emoji-single-parent-family-3-expected-mismatch.html: Removed. * LayoutTests/fast/text/emoji-single-parent-family-expected-mismatch.html: Removed. * LayoutTests/platform/gtk/TestExpectations: Remove corresponding skip line. Canonical link: https://commits.webkit.org/275427@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 139616: [UnifiedPDF] Drop support for "Search in Spotlight...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1396165ddee4a1cbc4fc20d14cde7a9a9b39f49e https://github.com/WebKit/WebKit/commit/1396165ddee4a1cbc4fc20d14cde7a9a9b39f49e Author: Abrar Rahman Protyasha Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm Log Message: --- [UnifiedPDF] Drop support for "Search in Spotlight" context menu item https://bugs.webkit.org/show_bug.cgi?id=269320 rdar://122911045 Reviewed by Tim Horton. This hasn't worked in a while (cf. rdar://56416395), is missing in PDFView-based context menu items, and its value is marginal. Let's drop the plumbing so it's squarely a no-op for now. Note that we can't get rid of the delegate method implementation since PDFLayerController calls into it unconditionally, but that can be fixed at a later point. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (-[WKPDFLayerControllerDelegate performSpotlightSearch:]): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::performSpotlightSearch): Deleted. Canonical link: https://commits.webkit.org/275426@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26302c: [JSC] emitReturn() should load `this` value from a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26302cf8d239273b6b659e4e746829b8322a83b5 https://github.com/WebKit/WebKit/commit/26302cf8d239273b6b659e4e746829b8322a83b5 Author: Alexey Shvayka Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: A JSTests/stress/regress-268864.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp Log Message: --- [JSC] emitReturn() should load `this` value from arrow function lexical environment prior to TDZ check https://bugs.webkit.org/show_bug.cgi?id=268864 Reviewed by Justin Michaud. This change: 1) Hoists first TDZ check of emitReturn() up to FunctionNode::emitBytecode(), and refactors it leveraging semantically equivalent ensureThis(), which makes automatically-inserted return equivalent to `return this`. I confirmed this to be the only call site of emitReturn() with unchecked thisRegister() as `src`. This is non-observable. 2) Adds missing emitLoadThisFromArrowFunctionLexicalEnvironment() before second TDZ check, and refactors it using ensureThis(). This is an observable change that prevents ReferenceError being thrown on totally valid and rather sane code of calling super() inside an arrow function before explicit `return`. Aligns JSC with the spec [1], V8, and SpiderMonkey. 3) Since when `from == ReturnFrom::Finally` is true, `src` is always completionValueRegister(), meaning the check ^^ is useless. Removes it altogether with BytecodeGenerator::ReturnFrom. [1]: https://tc39.es/ecma262/#sec-ecmascript-function-objects-construct-argumentslist-newtarget (step 12) * JSTests/stress/regress-268864.js: Added. * JSTests/test262/expectations.yaml: Mark 6 tests as passing. * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitReturn): (JSC::BytecodeGenerator::emitFinallyCompletion): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::FunctionNode::emitBytecode): Canonical link: https://commits.webkit.org/275425@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d13ee4: [UnifiedPDF] After zooming, subframe/embed PDFs ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d13ee4fd5e921444182d76a7a5d7a098174be736 https://github.com/WebKit/WebKit/commit/d13ee4fd5e921444182d76a7a5d7a098174be736 Author: Simon Fraser Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/TiledBacking.h M Source/WebCore/platform/graphics/ca/TileController.cpp M Source/WebCore/platform/graphics/ca/TileController.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp Log Message: --- [UnifiedPDF] After zooming, subframe/embed PDFs are messed up https://bugs.webkit.org/show_bug.cgi?id=270211 rdar://123731682 Reviewed by Tim Horton. The tile caching logic assumed that page scale factor (i.e. what scaleFactor() returns) is the exact inverse of the scale factor that TiledBacking uses to map between tile coordinates and painting coordinates. This is true for main-frame PDFs, where the plugin takes over page scale, but for subframes, page scale exists on some ancestor GraphicsLayer, yet the plugin's TiledBacking is aware of this scale, because it's tracked through the GraphicsLayers. TileController accumulates the scale on all ancestors in order to keep tiles at 512x512 in screen space. So replace the uses of pageScaleFactor with `tilingScaleFactor` that we get from the TiledBacking. This fixes computations that map from tile coordinates to painting coordinates, including fixing blurry tiles, and missing tiles. Also add a TiledBackingClient function that allows us to bump our configuration identifier when the tiling scale factor changes, so we don't use stale tiles when the main frame is zoomed. * Source/WebCore/platform/graphics/TiledBacking.h: * Source/WebCore/platform/graphics/ca/TileController.cpp: (WebCore::TileController::setContentsScale): (WebCore::TileController::tilingScaleFactor const): * Source/WebCore/platform/graphics/ca/TileController.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::tilingScaleFactorDidChange): (WebKit::AsyncPDFRenderer::tileToPaintingTransform): (WebKit::AsyncPDFRenderer::paintingToTileTransform): (WebKit::AsyncPDFRenderer::enqueuePaintWithClip): (WebKit::AsyncPDFRenderer::paintPDFIntoBuffer): (WebKit::AsyncPDFRenderer::transferBufferToMainThread): (WebKit::AsyncPDFRenderer::paintTilesForPage): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPageCoverage.mm: (WebKit::operator<<): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::pageCoverageForRect const): (WebKit::UnifiedPDFPlugin::paintPDFContent): Canonical link: https://commits.webkit.org/275424@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f42d30: REGRESSION (259678@main): [ iOS17 ] ASSERTION FAIL...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f42d30f8697a7cd944595f799249949d2d66e43f https://github.com/WebKit/WebKit/commit/f42d30f8697a7cd944595f799249949d2d66e43f Author: Chris Dumez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm Log Message: --- REGRESSION (259678@main): [ iOS17 ] ASSERTION FAILED: task.callback for fast/dom/Orientation/no-orientation-change-event-when-unparenting-view.html result of a consistent crash https://bugs.webkit.org/show_bug.cgi?id=267934 rdar://121454476 Reviewed by Ryosuke Niwa. Make sure we clear the `rotationDidEndCallback` delegate on the WKWebView once it has been called. Otherwise, we may end up trying to call the callback several times, which would hit the assertion we were seeing. * Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::simulateRotation): Canonical link: https://commits.webkit.org/275423@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a69a5: Minor refactoring to avoid redundant functions cal...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a69a5010e0f688e8f0f5aa47a389060b2cbdc2e https://github.com/WebKit/WebKit/commit/9a69a5010e0f688e8f0f5aa47a389060b2cbdc2e Author: Ahmad Saleem Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/editing/ApplyBlockElementCommand.cpp M Source/WebCore/editing/IndentOutdentCommand.cpp Log Message: --- Minor refactoring to avoid redundant functions calls in Editing code https://bugs.webkit.org/show_bug.cgi?id=270202 Reviewed by Ryosuke Niwa. Merge: https://chromium.googlesource.com/chromium/blink/+/27d47607bcb998d4ca3d4e0452341bde77c74f98 This patch do minor refactoring to avoid redundant function calls. Also, it also remove unused `nodeAfterStart` variable. * Source/WebCore/editing/ApplyBlockElementCommand.cpp: (ApplyBlockElementCommand::formatSelection): * Source/WebCore/editing/IndentOutdentCommand.cpp: (IndentOutdentCommand::indentIntoBlockquote): (IndentOutdentCommand::outdentRegion): Canonical link: https://commits.webkit.org/275422@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68e60b: [ MacOS ] TestWebKitAPI.PrivateClickMeasurement.SK...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68e60b96d1368a95fc0aff1fc3d30a015886c986 https://github.com/WebKit/WebKit/commit/68e60b96d1368a95fc0aff1fc3d30a015886c986 Author: Charlie Wolfe Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm Log Message: --- [ MacOS ] TestWebKitAPI.PrivateClickMeasurement.SKAdNetwork is a constant timeout https://bugs.webkit.org/show_bug.cgi?id=270188 rdar://123712160 Reviewed by Alex Christensen. Opening app links causes the test to time out. * Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275421@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c5820: [Gardening] Enable some view-transition test that ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c582037a107bdf7ad254e9860eca03b9d81e3be https://github.com/WebKit/WebKit/commit/4c582037a107bdf7ad254e9860eca03b9d81e3be Author: Matt Woodrow Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] Enable some view-transition test that no longer crash. https://bugs.webkit.org/show_bug.cgi?id=270014 Reviewed by Tim Nguyen. These got fixed by 75312@main. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275420@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bfc7a: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bfc7a132be7e254295ea6031befc01b467f81bb https://github.com/WebKit/WebKit/commit/3bfc7a132be7e254295ea6031befc01b467f81bb Author: Fujii Hironori Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/text/embed-at-end-of-pre-wrap-line-expected.txt M LayoutTests/platform/wincairo/fast/text/whitespace/pre-wrap-line-test-expected.txt M LayoutTests/platform/wincairo/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: * LayoutTests/platform/wincairo/fast/text/whitespace/pre-wrap-line-test-expected.txt: * LayoutTests/platform/wincairo/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Canonical link: https://commits.webkit.org/275419@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6fcc39: Make openTemporaryFile return file handle
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6fcc39010e1efaba89120aecf868f3057c1d9ab8 https://github.com/WebKit/WebKit/commit/6fcc39010e1efaba89120aecf868f3057c1d9ab8 Author: Sihui Liu Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/WTF/wtf/FileSystem.cpp M Source/WTF/wtf/FileSystem.h M Source/WTF/wtf/cocoa/FileSystemCocoa.mm M Source/WTF/wtf/posix/FileSystemPOSIX.cpp M Source/WTF/wtf/win/FileSystemWin.cpp M Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm M Source/WebCore/bindings/js/GCController.cpp M Source/WebCore/contentextensions/SerializedNFA.cpp M Source/WebCore/platform/graphics/cg/ImageUtilitiesCG.cpp M Source/WebCore/platform/network/BlobRegistryImpl.cpp M Source/WebCore/testing/Internals.cpp M Source/WebKit/Shared/WebMemorySampler.cpp M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp M Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp M Tools/TestWebKitAPI/Tests/WebCore/PushDatabase.cpp M Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp M Tools/TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp M Tools/TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm Log Message: --- Make openTemporaryFile return file handle https://bugs.webkit.org/show_bug.cgi?id=269968 rdar://123489546 Reviewed by Justin Michaud. This will make code more clean as callers do not need to pass in a file handle reference. Also, add a new createTemporaryFile function so callers do not need to close the file handle if they only want the path. * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/WTF/wtf/FileSystem.cpp: (WTF::FileSystemImpl::createTemporaryFile): * Source/WTF/wtf/FileSystem.h: (WTF::FileSystemImpl::openTemporaryFile): (WTF::FileSystemImpl::createTemporaryFile): * Source/WTF/wtf/cocoa/FileSystemCocoa.mm: (WTF::FileSystemImpl::openTemporaryFile): * Source/WTF/wtf/posix/FileSystemPOSIX.cpp: (WTF::FileSystemImpl::openTemporaryFile): * Source/WTF/wtf/win/FileSystemWin.cpp: (WTF::FileSystemImpl::openTemporaryFile): * Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderUSD.mm: (WebCore::writeToTemporaryFile): * Source/WebCore/bindings/js/GCController.cpp: (WebCore::GCController::dumpHeap): * Source/WebCore/contentextensions/SerializedNFA.cpp: (WebCore::ContentExtensions::SerializedNFA::serialize): * Source/WebCore/platform/graphics/cg/ImageUtilitiesCG.cpp: (WebCore::transcodeImage): * Source/WebCore/platform/network/BlobRegistryImpl.cpp: (WebCore::BlobRegistryImpl::writeBlobsToTemporaryFilesForIndexedDB): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::createTemporaryFile): * Source/WebKit/Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::initializeTempLogFile): * Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp: (API::compiledToFile): * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp: (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: * Tools/TestWebKitAPI/Tests/WebCore/PushDatabase.cpp: (TestWebKitAPI::makeTemporaryDatabasePath): * Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: * Tools/TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: (TestWebKitAPI::FragmentedSharedBufferTest::SetUp): * Tools/TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm: (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]): (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]): (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]): Canonical link: https://commits.webkit.org/275418@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 797bcc: [git-webkit] Support repositories where commit sig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 797bcc905aa6fcba0033710f3f384fa91bbedadc https://github.com/WebKit/WebKit/commit/797bcc905aa6fcba0033710f3f384fa91bbedadc Author: Jonathan Bedard Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py Log Message: --- [git-webkit] Support repositories where commit signing enabled https://bugs.webkit.org/show_bug.cgi?id=270029 rdar://123539145 Reviewed by Dewei Zhu. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: (Git.commit_signing_enabled): Check if commit.gpgsign is set. (Git.rebase): Re-sign commits when setting committer. (Git.pull): Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/canonicalize/__init__.py: (Canonicalize.main): Re-sign commits when adding identifier. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py: (Land.main): Re-sign commits when adding reviewer. Canonical link: https://commits.webkit.org/275417@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be36ac: Get rid of downcast<>() in ContainerNode::rootNode()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be36acd769261df22b97655ff0579f150596ffcc https://github.com/WebKit/WebKit/commit/be36acd769261df22b97655ff0579f150596ffcc Author: Chris Dumez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/ContainerNode.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/html/HTMLFormElement.cpp M Source/WebCore/html/HTMLImageElement.cpp Log Message: --- Get rid of downcast<>() in ContainerNode::rootNode() https://bugs.webkit.org/show_bug.cgi?id=270144 Reviewed by Ryosuke Niwa. Get rid of downcast<>() in ContainerNode::rootNode(), for performance reasons. * Source/WebCore/dom/ContainerNode.h: (WebCore::ContainerNode::rootNode const): (WebCore::ContainerNode::protectedRootNode const): Canonical link: https://commits.webkit.org/275416@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7be7a6: WebKit.GPU using an average of 57% CPU (2.0W estim...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7be7a65a49c17c990afe62c11528e99ef6ccfaf4 https://github.com/WebKit/WebKit/commit/7be7a65a49c17c990afe62c11528e99ef6ccfaf4 Author: Jean-Yves Avenard Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Log Message: --- WebKit.GPU using an average of 57% CPU (2.0W estimated impact) for 2.1 hrs [+7%/hr] https://bugs.webkit.org/show_bug.cgi?id=270154 rdar://122916282 Reviewed by Eric Carlson. When the AVSampleBufferDisplaLayer notified the SourceBufferPrivateAVObjC that is was ready for more data, we checked via SourceBufferPrivate::isReadyForMoreSamples(). If we had previously been interrupted with a layerRequiresFlushToResumeDecodingChanged error, and until we flushed the renderer, isReadyForMoreSamples() would have returned false and iwe would then immediately request the layer to notify us when ready again. Prior 268283@main, requesting the AVSBDL to notify us if it was ready for more sample was the right thing to do. However, now that there's a flush pending, what it would do is make the AVSBDL call us immediately. This caused the code to run in an unlimited loop. We add a check if flushing is required and abort early if so. The ability to reproduce the case and to simulate is not possible with the current infrastructure. Problem was found through log analysis and code review only. * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::flushIfNeeded): Add logging for when we are actually flushing the SourceBuffer. Not having logging made the investigation difficult as we had log that the AVSBDL required flushing, but no information about if we had log flushed or not (which can happen in two cases: page became visible again, or play() was called) (WebCore::SourceBufferPrivateAVFObjC::notifyClientWhenReadyForMoreSamples): Canonical link: https://commits.webkit.org/275415@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d691e4: Password manager UI can cause conditional requests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d691e4579511b2fe0f916d9da1746f98b0519036 https://github.com/WebKit/WebKit/commit/d691e4579511b2fe0f916d9da1746f98b0519036 Author: Pascoe Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Password manager UI can cause conditional requests to pause https://bugs.webkit.org/show_bug.cgi?id=270135 rdar://123659147 Reviewed by Charlie Wolfe and Chris Dumez. The API for autofill assisted passkey requests only allows one request ongoing per UI process. In order to handle this behavior, we currently pause requests whenever their page is not active and resume them whenever the page becomes active. However, bringing up password manager UI as part of an conditional mediation may cause the page to become not active, therefore pausing the request the user is selecting a credential for in the UI. To fix this issue, we don't pause requests whenever a page becomes inactive. Instead we pause the active request whenever another page becomes active. This will result in no pause when brining up password manager UI. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::pauseConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::makeActiveConditionalAssertion): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest): * Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchActivityStateChange): Canonical link: https://commits.webkit.org/275414@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fbb03: [UnifiedPDF] Don't show the form hover highlight f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fbb03ee1c6210c79779d6fa1a9e7290daa746d1 https://github.com/WebKit/WebKit/commit/5fbb03ee1c6210c79779d6fa1a9e7290daa746d1 Author: Sammy Gill Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Don't show the form hover highlight for non-fillable forms https://bugs.webkit.org/show_bug.cgi?id=270184 rdar://123667854 Reviewed by Tim Horton. If the plugin does not support forms, because it is not a main frame or iframe plugin, then we should not start tracking the text widget annotations. This will make sure that we do not keep around any state that would be used later on for painting the hover indicator. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::paintHoveredAnnotationOnPage): (WebKit::UnifiedPDFPlugin::handleMouseEvent): Canonical link: https://commits.webkit.org/275413@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a053c: Unreviewed, suppress a couple of warnings when com...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a053cfb431bd70d5017ba881a39f004e52effc2 https://github.com/WebKit/WebKit/commit/6a053cfb431bd70d5017ba881a39f004e52effc2 Author: Wenson Hsieh Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm Log Message: --- Unreviewed, suppress a couple of warnings when compiling against newer SDKs rdar://123705222 Suppress `-Wobjc-method-access` here. * Source/WebCore/platform/mediastream/mac/AVCaptureDeviceManager.mm: (WebCore::AVCaptureDeviceManager::registerForDeviceNotifications): Canonical link: https://commits.webkit.org/275412@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7d90b: [UnifiedPDF] Annotation hover rectangle is wrong o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7d90be9008dcb5f27fab671a887cccab006e1cc https://github.com/WebKit/WebKit/commit/a7d90be9008dcb5f27fab671a887cccab006e1cc Author: Sammy Gill Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Annotation hover rectangle is wrong on rotated pages https://bugs.webkit.org/show_bug.cgi?id=270191 rdar://122931284 Reviewed by Simon Fraser. This appears to be the same issue that 275351@main fixed for selections but this time for annotations. To make sure that our painting code displays the blue rectangle properly we need to factor out the rotation that is implicit in bounds of the annotation that we get back from PDFKit. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::paintPDFContent): Canonical link: https://commits.webkit.org/275411@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 492140: [Unified Text Replacement] Show the swap character...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 492140d27dbe1825cf987015a9f6edda9a0d05fc https://github.com/WebKit/WebKit/commit/492140d27dbe1825cf987015a9f6edda9a0d05fc Author: Richard Robinson Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- [Unified Text Replacement] Show the swap characters view when the selection is changed on macOS https://bugs.webkit.org/show_bug.cgi?id=270181 rdar://123270972 Reviewed by Aditya Keerthi. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::selectionDidChange): (WebKit::WebViewImpl::selectedRange): Canonical link: https://commits.webkit.org/275410@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f3f2d: UnifiedPDF: Cursor hover shows for hidden pages
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f3f2d5df5ff99d94e8abd6739bcf388dcb6ef87 https://github.com/WebKit/WebKit/commit/6f3f2d5df5ff99d94e8abd6739bcf388dcb6ef87 Author: Tim Horton Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- UnifiedPDF: Cursor hover shows for hidden pages https://bugs.webkit.org/show_bug.cgi?id=270183 rdar://123192912 Reviewed by Simon Fraser. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleMouseEvent): Don't handle mouse events on invisible pages. Reset the cursor to the default. Canonical link: https://commits.webkit.org/275409@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73e3ce: Check for domain youtube-nocookie.com in shouldDis...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73e3ced774ed4605defd284e348418b879646bf9 https://github.com/WebKit/WebKit/commit/73e3ced774ed4605defd284e348418b879646bf9 Author: Dana Estra Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Check for domain youtube-nocookie.com in shouldDisableElementFullscreenQuirk() https://bugs.webkit.org/show_bug.cgi?id=270177 rdar://122918249 Reviewed by Jer Noble. Some webpages embed YouTube videos using the domain youtube-nocookie.com, which we fail To account for when disabling element fullscreen for embedded YouTube videos on iPhone. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::isYoutubeEmbedDomain const): (WebCore::Quirks::shouldDisableElementFullscreenQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/275408@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 781831: Drop downcast<>() use in StyleOriginatedAnimation:...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 781831e539eed6b2c258f3b3a0edcf0c0ff7786b https://github.com/WebKit/WebKit/commit/781831e539eed6b2c258f3b3a0edcf0c0ff7786b Author: Chris Dumez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/animation/StyleOriginatedAnimation.cpp Log Message: --- Drop downcast<>() use in StyleOriginatedAnimation::initialize() https://bugs.webkit.org/show_bug.cgi?id=270141 Reviewed by Ryosuke Niwa and Darin Adler. * Source/WebCore/animation/StyleOriginatedAnimation.cpp: (WebCore::StyleOriginatedAnimation::initialize): Canonical link: https://commits.webkit.org/275407@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0cd0a7: [Gardening]: Multiple queues experiencing sporadic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0cd0a70db386c2102b8af4ad156a5b5bec43328d https://github.com/WebKit/WebKit/commit/0cd0a70db386c2102b8af4ad156a5b5bec43328d Author: Karl Rackler Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: Multiple queues experiencing sporadic 0.01% ImageOnlyFailures. https://bugs.webkit.org/show_bug.cgi?id=267869 rdar://121384093 Unreviewed test gardening. Adding test expectations in lieu of temporarily relaxed pixel tolerance. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275406@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 177863: Eliminate calls to bundleForClass: at auxiliary pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 17786394fdc1af61ab7521d9cd8322b848a7ce1a https://github.com/WebKit/WebKit/commit/17786394fdc1af61ab7521d9cd8322b848a7ce1a Author: Ben Nham Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/Configurations/BaseTarget.xcconfig M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm M Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm M Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm M Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm Log Message: --- Eliminate calls to bundleForClass: at auxiliary process launch time https://bugs.webkit.org/show_bug.cgi?id=269874 rdar://120925002 Reviewed by Per Arne Vollan. Some perf folks want us to eliminate calls to `+[NSBundle bundleForClass:]` that we do at auxiliary process launch time. To do this, pass the bundle version to the compiler via a preprocessor macro rather than looking it up dynamically via NSBundle at runtime. * Source/WebKit/Configurations/BaseTarget.xcconfig: * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm: (WebKit::AuxiliaryProcess::isSystemWebKit): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::checkFrameworkVersion): * Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm: (WebKit::AuxiliaryProcess::isSystemWebKit): Deleted. * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::ProcessLauncher::finishLaunchingProcess): * Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::shouldAllowNonValidInjectedCode const): Canonical link: https://commits.webkit.org/275405@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 153655: WebsiteDataStore::setTrackingPreventionEnabled sho...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15365541a8138ba8f48a423fec7fc52acd5ce2fe https://github.com/WebKit/WebKit/commit/15365541a8138ba8f48a423fec7fc52acd5ce2fe Author: Sihui Liu Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp Log Message: --- WebsiteDataStore::setTrackingPreventionEnabled should not resolve directories https://bugs.webkit.org/show_bug.cgi?id=270148 rdar://123669767 Reviewed by Brent Fulgham. When investigating a performance issue, I noticed WebsiteDataStore::setTrackingPreventionEnabled spent a long time on file operations. It turns out setTrackingPreventionEnabled tries to resolve directories, which is unnecessary for this operation -- it does not need directory information at all. * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::setTrackingPreventionEnabled): Canonical link: https://commits.webkit.org/275404@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 782a6e: [UnifiedPDF] Cursor should be an I-beam while drag...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 782a6e1f8520f8fdaa31a7c279076616a8910bc3 https://github.com/WebKit/WebKit/commit/782a6e1f8520f8fdaa31a7c279076616a8910bc3 Author: Abrar Rahman Protyasha Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Cursor should be an I-beam while dragging a selection https://bugs.webkit.org/show_bug.cgi?id=270158 rdar://123634420 Reviewed by Sammy Gill. This patch ensures that when we're dragging a selection, the cursor is frozen to an I-beam, which is a better visual experience than potentially seeing a pointer because a selection drag was initiated over blank space. We do not cache the last cursor type before freezing because the cursor most certainly does not end up at the same spot the selection drag was initiated from, so unfreezing the cursor to that old type could be inaccurate. Instead, we choose to hit test again when unfreezing the cursor. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleMouseEvent): (WebKit::UnifiedPDFPlugin::beginTrackingSelection): (WebKit::UnifiedPDFPlugin::freezeCursorDuringSelectionDragIfNeeded): (WebKit::UnifiedPDFPlugin::unfreezeCursorAfterSelectionDragIfNeeded): (WebKit::UnifiedPDFPlugin::continueTrackingSelection): (WebKit::UnifiedPDFPlugin::stopTrackingSelection): Canonical link: https://commits.webkit.org/275403@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc42f3: REGRESSION(275377@main): [Win] GLContext::makeCont...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cc42f3bc02dcbb775285515187d926faf241c2f7
https://github.com/WebKit/WebKit/commit/cc42f3bc02dcbb775285515187d926faf241c2f7
Author: Fujii Hironori
Date: 2024-02-27 (Tue, 27 Feb 2024)
Changed paths:
M
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h
Log Message:
---
REGRESSION(275377@main): [Win] GLContext::makeContextCurrent calls purecall
for WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=270186
Unreviewed crash fix.
275377@main introduced GLContextWrapper class to track the current GL
context. ~GLContextWrapper unsets the current context if it is `this`
context.
GraphicsContextGLTextureMapperANGLE class inherits both
GraphicsContextGLANGLE and GLContextWrapper classes in the following
order.
> class GraphicsContextGLTextureMapperANGLE : public GraphicsContextGLANGLE,
> public GLContextWrapper {
Thus, destructors are called in the following order
1. ~GraphicsContextGLTextureMapperANGLE
2. ~GLContextWrapper
3. ~GraphicsContextGLANGLE
~GLContextWrapper unsets the current context, but
~GraphicsContextGLANGLE makes `this` context current again.
GLContextWrapper base class should be before GraphicsContextGLANGLE.
* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
Canonical link: https://commits.webkit.org/275402@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31bc3d: Unreviewed, fix a dependency cycle when building t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31bc3d0e8ff9cade2795e9b2bd059c30748e9c41 https://github.com/WebKit/WebKit/commit/31bc3d0e8ff9cade2795e9b2bd059c30748e9c41 Author: Wenson Hsieh Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Unreviewed, fix a dependency cycle when building the "Only WebKit" scheme Reorder the `WebKitSwift` target after `Frameworks, XPC Services, Extensions and Daemons` to avoid this dependency cycle, now that WebKitSwift links against WebKit: ``` Generate Unified Sources → Unlock Keychain → WebKitSwift → WebKit → Generate Unified Sources ``` * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275401@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a6208: REGRESSION (275180@main): [Sonoma wk1] imported/w3...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a6208ebbec7bdaf149885f30bed442b5d779ed8 https://github.com/WebKit/WebKit/commit/7a6208ebbec7bdaf149885f30bed442b5d779ed8 Author: Andres Gonzalez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt Log Message: --- REGRESSION (275180@main): [Sonoma wk1] imported/w3c/web-platform-tests/accname/name/comp_host_language_label.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270133 rdar://123657917 Reviewed by Chris Fleizach. Needed to reset the expectation for this test in WK1 since there are test cases that were failing before and now pass. * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/accname/name/comp_host_language_label-expected.txt: Canonical link: https://commits.webkit.org/275400@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b506e3: Stop reading UnifiedOriginStorageLevel value from ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b506e37e5c4ab345d37a4b84d298d8518bebd50d https://github.com/WebKit/WebKit/commit/b506e37e5c4ab345d37a4b84d298d8518bebd50d Author: Sihui Liu Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Log Message: --- Stop reading UnifiedOriginStorageLevel value from disk https://bugs.webkit.org/show_bug.cgi?id=270179 rdar://123700856 Reviewed by Chris Dumez. Based on profiling, this could take some time as it might involve disk operation. We used to read the value defaults to facilitate debugging at runtime; now the feature has been shipped for a while, we don't need it any more. * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::defaultUnifiedOriginStorageLevel): Canonical link: https://commits.webkit.org/275399@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8393b6: [git-webkit revert] Fix AttributeError when reason...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8393b67886c2a40837b06c4e82e9a39016304cf1 https://github.com/WebKit/WebKit/commit/8393b67886c2a40837b06c4e82e9a39016304cf1 Author: Brianna Fan Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py Log Message: --- [git-webkit revert] Fix AttributeError when reason is passed in https://bugs.webkit.org/show_bug.cgi?id=270174 rdar://problem/123698369 Reviewed by Jonathan Bedard. Error handling for an incorrect issue link should occur *after* checking if it is None. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert.get_issue_info): Canonical link: https://commits.webkit.org/275398@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1decf3: [git-webkit revert] Default should not upload a PR
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1decf3d3beafe159c5cfcaa6e0005bcd36bf8ece https://github.com/WebKit/WebKit/commit/1decf3d3beafe159c5cfcaa6e0005bcd36bf8ece Author: Brianna Fan Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py Log Message: --- [git-webkit revert] Default should not upload a PR https://bugs.webkit.org/show_bug.cgi?id=270129 rdar://problem/123655661 Reviewed by Jonathan Bedard. Sets PR argument default to False. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert.parser): (Revert.main): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py: (test_update): (test_pr): Canonical link: https://commits.webkit.org/275397@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e3439: REGRESSION (271515@main): Bold and Italic keyboard...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e343906838f775714988ac2c3d6be7d7ef157a3 https://github.com/WebKit/WebKit/commit/9e343906838f775714988ac2c3d6be7d7ef157a3 Author: Wenson Hsieh Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm Log Message: --- REGRESSION (271515@main): Bold and Italic keyboard bar button items in the UCB never update https://bugs.webkit.org/show_bug.cgi?id=270169 rdar://123328041 Reviewed by Tim Horton. The changes in 271515@main were meant to merge functionality in both the public API delegate method `-textStylingAtPosition:inDirection:` and the UIKit IPI `-fontForCaretSelection` into just the public API. However, this removed logic for setting symbolic traits on the font descriptor (bold, italic) with no replacement. Fix this by reinstating this code, and augmenting an existing API test to exercise this logic. Test: AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView textStylingAtPosition:inDirection:]): * Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm: (-[UIFont _test_systemFontWithSize:traits:]): Canonical link: https://commits.webkit.org/275396@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4bf1cd: Crash due to large MACH messages which could happe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4bf1cda6899f2fdac94396c7a75459511e66 https://github.com/WebKit/WebKit/commit/4bf1cda6899f2fdac94396c7a75459511e66 Author: Nisha Jain Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm Log Message: --- Crash due to large MACH messages which could happen during fuzz testing. https://bugs.webkit.org/show_bug.cgi?id=270025 rdar://121960150. Reviewed by David Kilzer. During Fuzz testing, large MACH messages could be used in IPC which causes crash. Log info for large MACH messages and return, instead of a crash. * Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm: (IPC::Connection::sendMessage): Canonical link: https://commits.webkit.org/275395@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a2855: Use-after-move in `WebExtensionController::getData...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a28553ef6fda9139227d766b5ed3ca0867d64f4 https://github.com/WebKit/WebKit/commit/8a28553ef6fda9139227d766b5ed3ca0867d64f4 Author: Charlie Wolfe Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm Log Message: --- Use-after-move in `WebExtensionController::getDataRecord()` https://bugs.webkit.org/show_bug.cgi?id=270151 rdar://123674682 Reviewed by David Kilzer. Fix a use-after-move on the completion handler and use explicit smart pointer types. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::getDataRecord): Canonical link: https://commits.webkit.org/275394@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbcae5: Remove unused `type` function from `BarProp.cpp|h`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbcae553570809f2c48cbe4faab29e9a80ff8ba3 https://github.com/WebKit/WebKit/commit/cbcae553570809f2c48cbe4faab29e9a80ff8ba3 Author: Ahmad Saleem Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/page/BarProp.cpp M Source/WebCore/page/BarProp.h Log Message: --- Remove unused `type` function from `BarProp.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=270157 Reviewed by Charlie Wolfe. This patch removes unused function 'type' from `BarProp.cpp|h`. * Source/WebCore/page/BarProp.cpp: (BarProp::type): Deleted * Source/WebCore/page/BarProp.h: Canonical link: https://commits.webkit.org/275393@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aef6a7: WebCodecs remote video encoders get timestamps in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aef6a763596ad4bd9e007a52b373eb1b423e1f84 https://github.com/WebKit/WebKit/commit/aef6a763596ad4bd9e007a52b373eb1b423e1f84 Author: Youenn Fablet Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp Log Message: --- WebCodecs remote video encoders get timestamps in microseconds and not nanoseconds rdar://123684436 https://bugs.webkit.org/show_bug.cgi?id=270159 Reviewed by Eric Carlson. In WebRTC code path, we are getting a microsecond timestamp. We were converting it to a MediaTime in LibWebRTCCodecs which was then converted back to a nanosecond timestamp in LibWebRTCCodecsProxy. A factor of 1000 was applied in LibWebRTCCodecs and handled correctly on LibWebRTCCodecsProxy. The WebCodecs path is getting a MediaTime directly but without the 1000 factor. This was causing the timestamps given to WebCodecs encoder to be in microseconds and not nanoseconds. This can have an impact on encoders in some circumstances. We fix this by using Seconds/MediaTime routines on WebProcess WebRTC side (this removes the 1000 factor), and we update LibWebRTCCodecsProxy to do the same. * Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm: (WebKit::LibWebRTCCodecsProxy::encodeFrame): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::LibWebRTCCodecs::encodeFrame): Canonical link: https://commits.webkit.org/275392@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75b646: Add NSPopover to _WKWebExtensionAction.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75b646bd8fd82fcc3457d7c99efb23206a3617ca https://github.com/WebKit/WebKit/commit/75b646bd8fd82fcc3457d7c99efb23206a3617ca Author: Timothy Hatcher Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/Platform/spi/mac/AppKitSPI.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h M Tools/Scripts/webkitpy/style/checkers/cpp.py M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm Log Message: --- Add NSPopover to _WKWebExtensionAction. https://webkit.org/b/270126 rdar://problem/123655122 Reviewed by Jeff Miller. Also remove the ContentSizeDidChange and DidClose notifications, since those things and handled internally now with the UIViewController and NSPopover paths. Rename closePopupWebView to closePopup to also better align with the new approach. * Source/WebKit/Platform/spi/mac/AppKitSPI.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionAction.mm: (-[_WKWebExtensionAction popupPopover]): (-[_WKWebExtensionAction closePopup]): (-[_WKWebExtensionAction closePopupWebView]): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm: (-[_WKWebExtensionActionWebViewDelegate webViewWebContentProcessDidTerminate:]): (-[_WKWebExtensionActionWebViewDelegate webViewDidClose:]): (-[_WKWebExtensionActionViewController _viewControllerDismissalTransitionDidEnd:]): (-[_WKWebExtensionActionPopover initWithWebExtensionAction:]): (-[_WKWebExtensionActionPopover dealloc]): (-[_WKWebExtensionActionPopover popoverWillClose:]): (-[_WKWebExtensionActionPopover popoverDidClose:]): (-[_WKWebExtensionActionPopover _otherPopoverWillShow:]): (WebKit::WebExtensionAction::clearCustomizations): (WebKit::WebExtensionAction::setPopupPath): (WebKit::WebExtensionAction::popupPopover): (WebKit::WebExtensionAction::setPopupPopoverAppearance): (WebKit::WebExtensionAction::detectPopoverColorScheme): (WebKit::WebExtensionAction::popupWebView): (WebKit::WebExtensionAction::readyToPresentPopup): (WebKit::WebExtensionAction::popupSizeDidChange): (WebKit::WebExtensionAction::closePopup): (WebKit::WebExtensionAction::popupDidClose): Deleted. (WebKit::WebExtensionAction::closePopupWebView): Deleted. * Source/WebKit/UIProcess/Extensions/WebExtensionAction.h: (WebKit::WebExtensionAction::popupPopoverAppearance const): * Tools/Scripts/webkitpy/style/checkers/cpp.py: (check_identifier_name_in_declaration): Make an exception for _WK prefixed classes. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275391@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f82b26: [Unified Text Replacement] Add support for undo-in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f82b26d2a0b7a540106b0bf407999ead4bba426c https://github.com/WebKit/WebKit/commit/f82b26d2a0b7a540106b0bf407999ead4bba426c Author: Richard Robinson Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h Log Message: --- [Unified Text Replacement] Add support for undo-ing all replacements https://bugs.webkit.org/show_bug.cgi?id=270138 rdar://123620291 Reviewed by Aditya Keerthi and Megan Gardner. * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.cpp: (WebKit::UnifiedTextReplacementController::didEndTextReplacementSession): (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveEditAction): * Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h: Canonical link: https://commits.webkit.org/275390@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 793932: Web Inspector: Font Panel: CSS font property value...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 793932ceb15afa7dcbcfa99af428131244f7a15d https://github.com/WebKit/WebKit/commit/793932ceb15afa7dcbcfa99af428131244f7a15d Author: Frances Cornwall Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Models/FontStyles.js Log Message: --- Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls. https://bugs.webkit.org/show_bug.cgi?id=258975 Reviewed by Devin Rousso. If a CSS class has a !important tag on a property the slider does not work correctly. This is due to us modifying the inline style, and the inline style is being overriden by the css class !important property. We can address this by checking if the !important property is being applied already during _computeProperty(), and then if it is then append !important in the writeFontVariation(). Rename resultProperties to resultProperty inside of _computeProperty() because there is a single property being handled. Delete _effectivePropertyValueForName function since it is not in use and create it in _computeProperty instead to be used for resultProperty.isImportant. * Source/WebInspectorUI/UserInterface/Models/FontStyles.js: (WI.FontStyles.prototype.writeFontVariation): (WI.FontStyles): Canonical link: https://commits.webkit.org/275389@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 931ae3: WebKit engineering builds intermittently fail on n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 931ae3fdc8f2cc076722f94e32697bfdcf5700c2 https://github.com/WebKit/WebKit/commit/931ae3fdc8f2cc076722f94e32697bfdcf5700c2 Author: Wenson Hsieh Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- WebKit engineering builds intermittently fail on newer SDK versions https://bugs.webkit.org/show_bug.cgi?id=269879 rdar://123426004 Reviewed by Andy Estes. Statically link against the WebKit framework from WebKitSwift to make the dependency between WebKitSwift and WebKit explicit in engineering builds. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275388@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b8fdc: Support using higher priority for a _WKDataTask
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b8fdcea34c1605cef7514e07df1d8c649af41b0 https://github.com/WebKit/WebKit/commit/5b8fdcea34c1605cef7514e07df1d8c649af41b0 Author: Chris Dumez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/NetworkProcess/NetworkProcess.cpp M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/UIProcess/API/APIDataTask.cpp M Source/WebKit/UIProcess/API/APIDataTask.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h Log Message: --- Support using higher priority for a _WKDataTask https://bugs.webkit.org/show_bug.cgi?id=270112 rdar://121960086 Reviewed by Tim Horton. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::cancelDataTask): * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/UIProcess/API/APIDataTask.cpp: (API::DataTask::cancel): (API::DataTask::networkProcessCrashed): (API::DataTask::DataTask): (API::m_client): (API::DataTask::didCompleteWithError): * Source/WebKit/UIProcess/API/APIDataTask.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _dataTaskWithRequest:runAtForegroundPriority:completionHandler:]): (-[WKWebView _dataTaskWithRequest:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h: * Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::dataTaskWithRequest): (WebKit::NetworkProcessProxy::dataTaskDidCompleteWithError): (WebKit::NetworkProcessProxy::cancelDataTask): * Source/WebKit/UIProcess/Network/NetworkProcessProxy.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dataTaskWithRequest): * Source/WebKit/UIProcess/WebPageProxy.h: Canonical link: https://commits.webkit.org/275387@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 606b5e: Get rid of downcast<>() in ComposedTreeAncestorIte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 606b5ed559adb503da70b7c010895501879f128a https://github.com/WebKit/WebKit/commit/606b5ed559adb503da70b7c010895501879f128a Author: Chris Dumez Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/dom/ComposedTreeAncestorIterator.h Log Message: --- Get rid of downcast<>() in ComposedTreeAncestorIterator https://bugs.webkit.org/show_bug.cgi?id=270142 Reviewed by Ryosuke Niwa. Get rid of downcast<>() in ComposedTreeAncestorIterator for performance reasons. m_current is now an `Element*` instead of a `Node*`. It also calls Element::shadowRoot() which is slightly more efficient than Node::shadowRoot(). * Source/WebCore/dom/ComposedTreeAncestorIterator.h: (WebCore::ComposedTreeAncestorIterator::operator++): (WebCore::ComposedTreeAncestorIterator::get): (WebCore::ComposedTreeAncestorIterator::ComposedTreeAncestorIterator): (WebCore::ComposedTreeAncestorIterator::traverseParent): (WebCore::ComposedTreeAncestorAdapter::begin): Canonical link: https://commits.webkit.org/275386@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1afa64: Using a predefined path to find PALSwift.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1afa64a2afde294bb941e72924dce6d126a185b0 https://github.com/WebKit/WebKit/commit/1afa64a2afde294bb941e72924dce6d126a185b0 Author: nmahendru Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/Configurations/WebCore.xcconfig M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- Using a predefined path to find PALSwift.h rdar://123514935 Reviewed by Elliott Williams. The earilier shell script implementation is rather slow and incorrect as it makes assumptions on where the source is checked out. This should be faster and better. Based on excellent suggestions from Elliot Williams. * Source/WebCore/Configurations/WebCore.xcconfig: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275385@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe6c3c: [WebGPU] wgslLanguageFeatures is missing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe6c3c14a428fce7d84dd2959d91b94a79832c30 https://github.com/WebKit/WebKit/commit/fe6c3c14a428fce7d84dd2959d91b94a79832c30 Author: Mike Wyrzykowski Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Modules/WebGPU/GPU.cpp M Source/WebCore/Modules/WebGPU/GPU.h M Source/WebCore/Modules/WebGPU/GPU.idl A Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.cpp A Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.h A Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.idl M Source/WebCore/Modules/credentialmanagement/DigitalIdentity.cpp M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h Log Message: --- [WebGPU] wgslLanguageFeatures is missing https://bugs.webkit.org/show_bug.cgi?id=269994 Reviewed by Dan Glastonbury. WGSLLaanguageFeatures can be empty but the specification expects an empty set in that case. We don't currenlty support any language features. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Modules/WebGPU/GPU.cpp: (WebCore::GPU::GPU): (WebCore::GPU::getPreferredCanvasFormat const): (WebCore::GPU::wgslLanguageFeatures const): (WebCore::GPU::getPreferredCanvasFormat): Deleted. * Source/WebCore/Modules/WebGPU/GPU.h: * Source/WebCore/Modules/WebGPU/GPU.idl: * Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.cpp: Copied from Source/WebCore/Modules/WebGPU/GPU.idl. (WebCore::WGSLLanguageFeatures::initializeSetLike const): * Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.h: Copied from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.cpp. (WebCore::WGSLLanguageFeatures::create): * Source/WebCore/Modules/WebGPU/WGSLLanguageFeatures.idl: Copied from Source/WebCore/Modules/WebGPU/GPU.idl. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: Canonical link: https://commits.webkit.org/275384@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b866cc: [WGSL] Add new language features
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b866cccd7a08edce14641d81ee3cca8a66717f4f https://github.com/WebKit/WebKit/commit/b866cccd7a08edce14641d81ee3cca8a66717f4f Author: Tadeu Zagallo Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebGPU/WGSL/Parser.cpp M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/WGSLEnums.h Log Message: --- [WGSL] Add new language features https://bugs.webkit.org/show_bug.cgi?id=270097 rdar://123637623 Reviewed by Mike Wyrzykowski. Since the original implementation 3 new language features/extensions were added to the spec[1]. We already implemented most of them, two of them, so it was just a matter of adding them to the enum, but `pointer_composite_access` had to be implemented, which in short allows accessing pointers to composite types in the same way as references. [1]: https://www.w3.org/TR/WGSL/#language-extensions-sec * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser::parseRequireDirective): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/WGSLEnums.h: Canonical link: https://commits.webkit.org/275383@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f0496: Unreviewed, reverting 275367@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f0496ad0e8237ac0c77c835596a1914546ac4a9 https://github.com/WebKit/WebKit/commit/1f0496ad0e8237ac0c77c835596a1914546ac4a9 Author: Jonathan Bedard Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/MigratedHeaders-input.xcfilelist M Source/WebKit/MigratedHeaders-output.xcfilelist M Source/WebKit/Modules/OSX_Private.modulemap M Source/WebKit/Modules/iOS_Private.modulemap M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h M Source/WebKitLegacy/SourcesCocoa.txt M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Misc/WebCache.mm A Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCache.h A Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCache.mm A Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCacheInternal.h A Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCacheQuotaManager.h A Source/WebKitLegacy/mac/WebCoreSupport/WebApplicationCacheQuotaManager.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOriginPrivate.h M Source/WebKitLegacy/mac/WebKit.exp M Source/WebKitLegacy/mac/WebView/WebDataSource.mm M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h M Source/WebKitLegacy/mac/WebView/WebView.mm M Tools/DumpRenderTree/TestRunner.cpp M Tools/DumpRenderTree/TestRunner.h M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/DumpRenderTree/mac/TestRunnerMac.mm M Tools/DumpRenderTree/mac/UIDelegate.mm M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Log Message: --- Unreviewed, reverting 275367@main https://bugs.webkit.org/show_bug.cgi?id=270165 rdar://123689477 275367@main broke Apple Internal builds Reverted change: Remove ApplicationCache code from WebKitLegacy and TestRunner https://bugs.webkit.org/show_bug.cgi?id=270120 rdar://123651735 https://commits.webkit.org/275367@main Canonical link: https://commits.webkit.org/275382@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f4bd5: Non-unified build fixes, late February 2024 edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f4bd57a7ba1532a3e48df585f56e6e998acdb2e https://github.com/WebKit/WebKit/commit/3f4bd57a7ba1532a3e48df585f56e6e998acdb2e Author: Adrian Perez de Castro Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/JavaScriptCore/assembler/PerfLog.cpp M Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.cpp M Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.h M Source/WebCore/Modules/mediasource/SourceBuffer.cpp M Source/WebCore/Modules/mediasource/SourceBufferList.cpp M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp M Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp M Source/WebCore/Modules/mediastream/RTCRtpSender.cpp M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp M Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp M Source/WebCore/animation/WebAnimationUtilities.h M Source/WebCore/bindings/js/GCController.h M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/dom/FragmentDirectiveGenerator.cpp M Source/WebCore/dom/FragmentDirectiveGenerator.h M Source/WebCore/editing/VisibleSelection.cpp M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/page/PointerLockController.cpp M Source/WebCore/page/Quirks.h M Source/WebCore/platform/MediaDescription.h M Source/WebCore/rendering/RenderViewTransitionCapture.cpp M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp M Source/WebCore/style/Styleable.cpp M Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp M Source/WebKit/Shared/WebCompiledContentRuleListData.cpp M Source/WebKit/Shared/gtk/WebEventFactory.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp Log Message: --- Non-unified build fixes, late February 2024 edition https://bugs.webkit.org/show_bug.cgi?id=270156 Unreviewed non-unified build fixes. * Source/JavaScriptCore/assembler/PerfLog.cpp: Add missing inclusions of Options.h and wtf/StringPrintStream.h. * Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.cpp: Add missing inclusions of SourceBufferList.h and TimeRanges.h. * Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.h: Add missing forward declaration for the WebCore::MediaSource type. * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: Remove unused ExponentialMovingAverageCoefficient constant. * Source/WebCore/Modules/mediasource/SourceBufferList.cpp: Add missing ContextDestructionObserverInlines.h header. * Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp: Ditto, plus wtf/IsoMallocInlines.h. * Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp: Add missing ContextDestructionObserverInlines.h. * Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: Ditto * Source/WebCore/Modules/mediastream/RTCRtpSender.cpp: Ditto. * Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp: Ditto, plus move all inclusions into ENABLE(SPEECH_SYNTHESIS). * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: Add missing ContextDestructionObserverInlines.h inclusion. * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: Ditto. * Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: Ditto. * Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: Ditto. * Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp: Add missing Node.h inclusion. * Source/WebCore/animation/WebAnimationUtilities.h: Add missing forward declarations for WebCore::Document and WebCore::Style::PseudoElementIdentifier. * Source/WebCore/bindings/js/GCController.h: Add missing forward declaration for the JSC::VM type. * Source/WebCore/css/parser/CSSSelectorParser.cpp: Add missing CSSTokenizer.h inclusion. * Source/WebCore/dom/FragmentDirectiveGenerator.cpp: Add missing Document.h inclusion. * Source/WebCore/dom/FragmentDirectiveGenerator.h: Add missing wtf/URL.h inclusion, add missing WebCore::SimpleRange forward declaration, and remove the unneeded WebCore::Range one. * Source/WebCore/editing/VisibleSelection.cpp: Replace Element.h inclusion with ElementInlines.h. * Source/WebCore/html/MediaElementSession.cpp: Add missing Navigator.h inclusion. * Source/WebCore/loader/cache/CachedResourceRequest.cpp: Add missing Quirks.h inclusion. * Source/WebCore/page/PointerLockController.cpp: Add missing DocumentInlines.h inclusion. * Source/WebC
[webkit-changes] [WebKit/WebKit] bbf768: [GPUP][MSE] RemoteSourceBufferProxy::EvictCodedFra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbf768df7ba799771f882dc739c09034f7a92934 https://github.com/WebKit/WebKit/commit/bbf768df7ba799771f882dc739c09034f7a92934 Author: Jean-Yves Avenard Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M LayoutTests/media/media-source/live-rewind-seek-and-evict.html M LayoutTests/media/media-source/media-source-append-before-last-range-no-quota-exceeded.html M LayoutTests/media/media-source/media-source-append-buffer-full-evict-prior-to-end.html M LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-onstart.html M LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error.html M LayoutTests/media/media-source/media-source-evict-codedframe-after-seek.html M LayoutTests/media/media-source/media-source-evict-codedframe-large-currenttime.html M LayoutTests/media/media-source/media-source-monitor-playing-event.html M Source/WebCore/Modules/mediasource/SourceBuffer.cpp M Source/WebCore/Modules/mediasource/SourceBuffer.h M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp M Source/WebCore/platform/graphics/SourceBufferPrivate.h M Source/WebCore/platform/graphics/SourceBufferPrivateClient.h M Source/WebCore/platform/graphics/TrackBuffer.cpp M Source/WebCore/platform/graphics/TrackBuffer.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemoteMessageReceiver.messages.in Log Message: --- [GPUP][MSE] RemoteSourceBufferProxy::EvictCodedFrames shouldn't be a sync call https://bugs.webkit.org/show_bug.cgi?id=265079 rdar://118783504 Reviewed by Youenn Fablet. Sync calls should be avoided under most circumstances, however with MSE, the prepare append algorithm is only made of synchronous steps and the synchronous call was made into a sendSync call to the GPU process for expediency. The only reason this call had to be synchronous was to determine if a new appendBuffer call was going to succeed even if we were running out of space and after an eviction. Instead, we calculate following each source buffer operation the amount of evictable data based on the currentTime. When the SourceBuffer needs to append a new buffer, we will then now immediately if: 1- there's enough space to accept the new buffer as-is 2- if there's not enough space and we evict content then the data would fit. If either 1 or 2 fails, then we are to throw a QuotaExceededError. In the case of 1) there's nothing to do, we can avoid the call to EvictCodedFrame altogher. If 2) we can run the EvictCodedFrame algorithm asynchronously and don't need to wait for the result of the operation: we know the next append will succeed. For 100% spec-compliance, should we fire QuotaExceededError, we want the eviction to run and be completed. Some browsers (Firefox in particular), do not fullfill this requirement: the SourceBuffer will throw, and eviction will still be done asynchronously; which is arguably a better and simpler behaviour from an implementer point of view. While the evictable amount of data would change over time as playback progress, for our case we don't need to update it at regular interval as we will conservatively run the eviction step which will always then free more memory than we expected we could. In practice, it means that the only time we will fire a sync call to the GPU process is if the append buffer operation will fail as we have run out of space, and we will not be able to make sufficient room. Covered by existing tests, no change in observable behaviour. * LayoutTests/media/media-source/live-rewind-seek-and-evict.html: * LayoutTests/media/media-source/media-source-append-before-last-range-no-quota-exceeded.html: * LayoutTests/media/media-source/media-source-append-buffer-full-evict-prior-to-end.html: * LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error-onstart.html: * LayoutTests/media/media-source/media-source-append-buffer-full-quota-exceeded-error.html: * LayoutTests/media/media-source/media-source-evict-codedframe-after-seek.html: * LayoutTests/media/media-source/media-source-monitor-playing-event.html: * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::m_logIdentifier): (WebCore::SourceBuffer::appendBufferInternal): (WebCore::SourceBuffer::maximumB
[webkit-changes] [WebKit/WebKit] 1a3492: [Skia] Stop using ScopedGLContextCurrent to make t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a34924425e4d87f83bd33db586ee4f7a9a56a95 https://github.com/WebKit/WebKit/commit/1a34924425e4d87f83bd33db586ee4f7a9a56a95 Author: Carlos Garcia Campos Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp Log Message: --- [Skia] Stop using ScopedGLContextCurrent to make the Skia GL context current https://bugs.webkit.org/show_bug.cgi?id=270082 Reviewed by Miguel Gomez. In most of the cases we are setting anf unsetting the same context all the time. If there's WebGL content, ANGLE graphics context will make the ANGLE context current on every operation that requires it. * Source/WebCore/platform/graphics/skia/GraphicsContextGLSkia.cpp: (WebCore::GraphicsContextGLImageExtractor::extractImage): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): (WebCore::ImageBufferSkiaAcceleratedBackend::getPixelBuffer): (WebCore::ImageBufferSkiaAcceleratedBackend::putPixelBuffer): * Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp: (WebCore::encodeAcceleratedImage): * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImage::singlePixelSolidColor const): * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: (WebCore::PlatformDisplay::skiaGLContext): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: (WebCore::SkiaAcceleratedBufferPool::~SkiaAcceleratedBufferPool): (WebCore::SkiaAcceleratedBufferPool::releaseUnusedBuffersTimerFired): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): Canonical link: https://commits.webkit.org/275379@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 877ae8: [GStreamer] Fix trimming of track IDs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 877ae86c324a8559600afb44da0b12b067c91c4e https://github.com/WebKit/WebKit/commit/877ae86c324a8559600afb44da0b12b067c91c4e Author: Vivienne Watermeier Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp Log Message: --- [GStreamer] Fix trimming of track IDs https://bugs.webkit.org/show_bug.cgi?id=270100 Reviewed by Xabier Rodriguez-Calvar. Use StringView::find() to trim zeroes instead of ::trim(), to not remove trailing zeroes. See previous PR: https://github.com/WebKit/WebKit/pull/23668 * Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: (WebCore::trimStreamId): fix implementation Canonical link: https://commits.webkit.org/275378@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d009eb: [TextureMapper] Add GLContextWrapper to handle the...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d009eb90543f0e25ee70cfb6eef3db2b0ec64d62 https://github.com/WebKit/WebKit/commit/d009eb90543f0e25ee70cfb6eef3db2b0ec64d62 Author: Carlos Garcia Campos Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/PlatformWin.cmake M Source/WebCore/SourcesGTK.txt M Source/WebCore/SourcesWPE.txt M Source/WebCore/platform/graphics/angle/PlatformDisplayANGLE.cpp M Source/WebCore/platform/graphics/egl/GLContext.cpp M Source/WebCore/platform/graphics/egl/GLContext.h A Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp A Source/WebCore/platform/graphics/egl/GLContextWrapper.h M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h Log Message: --- [TextureMapper] Add GLContextWrapper to handle the current GL context https://bugs.webkit.org/show_bug.cgi?id=270078 Reviewed by Miguel Gomez. We currently have GLContext handling the current context, but it doesn't always work. For example, if there's WebGL content, after ANGLE context is made current. This is not problematic with Cairo because only ANGLE is making it context current in the main thread, but with Skia there's another GL context that is made current in the main thread when using the GPU renderer. GLContextWrapper is a new class to handle the current GL context, implemented by GLContext and GraphicsContextGLTextureMapperANGLE. * Source/WebCore/Headers.cmake: * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/PlatformWin.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/SourcesWPE.txt: * Source/WebCore/platform/graphics/egl/GLContext.cpp: (WebCore::GLContext::~GLContext): (WebCore::GLContext::makeCurrentImpl): (WebCore::GLContext::unmakeCurrentImpl): (WebCore::GLContext::makeContextCurrent): (WebCore::GLContext::unmakeContextCurrent): (WebCore::GLContext::current): (WebCore::GLContext::ScopedGLContext::ScopedGLContext): (WebCore::GLContext::ScopedGLContext::~ScopedGLContext): (WebCore::GLContext::ScopedGLContextCurrent::ScopedGLContextCurrent): (WebCore::GLContext::ScopedGLContextCurrent::~ScopedGLContextCurrent): (): Deleted. * Source/WebCore/platform/graphics/egl/GLContext.h: (WebCore::GLContext::display const): Deleted. (WebCore::GLContext::config const): Deleted. * Source/WebCore/platform/graphics/egl/GLContextWrapper.cpp: Added. (WebCore::GLContextWrapper::~GLContextWrapper): (WebCore::GLContextWrapper::currentContext): (WebCore::GLContextWrapper::makeCurrent): (WebCore::GLContextWrapper::unmakeCurrent): * Source/WebCore/platform/graphics/egl/GLContextWrapper.h: Added. * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: (WebCore::GraphicsContextGLANGLE::makeContextCurrent): (WebCore::GraphicsContextGLTextureMapperANGLE::makeCurrentImpl): (WebCore::GraphicsContextGLTextureMapperANGLE::unmakeCurrentImpl): * Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: Canonical link: https://commits.webkit.org/275377@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd25a0: Regression (Safari 17 vs 16.5, 261003@main): heigh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd25a04355e3584bf5615720b1e48f90796b6c1e https://github.com/WebKit/WebKit/commit/dd25a04355e3584bf5615720b1e48f90796b6c1e Author: Rob Buis Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderGrid.h Log Message: --- Regression (Safari 17 vs 16.5, 261003@main): height collapsing on auto-height image when container-type set on parent https://bugs.webkit.org/show_bug.cgi?id=268874 Reviewed by Alan Baradlay. In r261003 isComputingSizeOrInlineSizeContainment was used which did not consider grid track sizing direction. Fix that by using shouldCheckExplicitIntrinsicInnerLogicalSize which will take the direction into account. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html: Added. * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const): * Source/WebCore/rendering/RenderGrid.h: Canonical link: https://commits.webkit.org/275376@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a24a25: Back identifier tokens in custom properties with s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a24a25b87e86c3c62d9e4ca0cc1e8f4d3939c8eb https://github.com/WebKit/WebKit/commit/a24a25b87e86c3c62d9e4ca0cc1e8f4d3939c8eb Author: Antti Koivisto Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/css/CSSVariableData.cpp M Source/WebCore/css/parser/CSSParserToken.cpp M Source/WebCore/css/parser/CSSParserToken.h Log Message: --- Back identifier tokens in custom properties with string literals https://bugs.webkit.org/show_bug.cgi?id=269986 rdar://123506269 Reviewed by Cameron McCormack. Tokens don't own the underlying string so we construct a separate backing string for tokens that need it. Identifier tokens can in mosts cases be backed by their string literals, saving memory and work. * Source/WebCore/css/CSSVariableData.cpp: (WebCore::CSSVariableData::updateBackingStringsInTokens): (WebCore::CSSVariableData::CSSVariableData): Point the string backing to a literal if possible. * Source/WebCore/css/parser/CSSParserToken.cpp: (WebCore::CSSParserToken::id const): (WebCore::CSSParserToken::functionId const): (WebCore::CSSParserToken::identOrFunctionId const): (WebCore::CSSParserToken::tryUseStringLiteralBacking): Known identifier tokens can use literal backing if cases match (usually all lowercase). (WebCore::CSSParserToken::copyWithUpdatedString const): Deleted. Remove unsed function. * Source/WebCore/css/parser/CSSParserToken.h: (WebCore::CSSParserToken::isBackedByStringLiteral const): (WebCore::CSSParserToken::initValueFromStringView): * Source/WebCore/css/parser/CSSParserToken.h: Canonical link: https://commits.webkit.org/275375@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c4f60: [WGSL] shader, validation, parse, align:parsing:* is ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c4f60e281a8922446c5bec68a6012f654953476 https://github.com/WebKit/WebKit/commit/7c4f60e281a8922446c5bec68a6012f654953476 Author: Tadeu Zagallo Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebGPU/WGSL/AttributeValidator.cpp M Source/WebGPU/WGSL/TypeCheck.cpp Log Message: --- [WGSL] shader,validation,parse,align:parsing:* is failing https://bugs.webkit.org/show_bug.cgi?id=270098 rdar://123638061 Reviewed by Mike Wyrzykowski. There two bugs in the validation of `@align`: - the value has to be bigger than 0, but we allowed 0 before. - the constant values of attributes were not being concretized * Source/WebGPU/WGSL/AttributeValidator.cpp: (WGSL::AttributeValidator::visit): * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): (WGSL::TypeChecker::check): Canonical link: https://commits.webkit.org/275374@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8529f0: [WGSL] shader, validation, expression, unary, address_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8529f0139b931464e17a5441db507b544d6a9926 https://github.com/WebKit/WebKit/commit/8529f0139b931464e17a5441db507b544d6a9926 Author: Tadeu Zagallo Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/TypeDeclarations.rb M Source/WebGPU/WGSL/TypeStore.cpp M Source/WebGPU/WGSL/TypeStore.h M Source/WebGPU/WGSL/Types.h Log Message: --- [WGSL] shader,validation,expression,unary,address_of_and_indirection:* is failing https://bugs.webkit.org/show_bug.cgi?id=270095 rdar://123636841 Reviewed by Mike Wyrzykowski. Move the logic for address of and indirection from a type declaration into the type checker in order to separate it from the arithmetic operators, and implement the additional validation: - don't allow taking the address of a vector component - don't allow taking the address of textures and samplers * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): * Source/WebGPU/WGSL/TypeDeclarations.rb: * Source/WebGPU/WGSL/TypeStore.cpp: (WGSL::ReferenceKey::encode const): (WGSL::TypeStore::referenceType): * Source/WebGPU/WGSL/TypeStore.h: * Source/WebGPU/WGSL/Types.h: Canonical link: https://commits.webkit.org/275373@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3211e5: [WGSL] shader, validation, expression, binary, bitwise...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3211e5848f89a9c1f885c09cecd848fc45d4f4dc https://github.com/WebKit/WebKit/commit/3211e5848f89a9c1f885c09cecd848fc45d4f4dc Author: Tadeu Zagallo Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebGPU/WGSL/ConstantFunctions.h Log Message: --- [WGSL] shader,validation,expression,binary,bitwise_shift:* is failing https://bugs.webkit.org/show_bug.cgi?id=270094 rdar://123636621 Reviewed by Mike Wyrzykowski. Add missing validation on the shift value. * Source/WebGPU/WGSL/ConstantFunctions.h: (WGSL::CONSTANT_FUNCTION): Canonical link: https://commits.webkit.org/275372@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30e6ec: [MSE] Fix build without release log
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30e6ecfa20b57adb816e2ea34c674afeda48c9e0 https://github.com/WebKit/WebKit/commit/30e6ecfa20b57adb816e2ea34c674afeda48c9e0 Author: Olivier Blin Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp Log Message: --- [MSE] Fix build without release log https://bugs.webkit.org/show_bug.cgi?id=270093 Reviewed by Alexey Proskuryakov. Commit 274853@main added the usage of logger in MediaSource, but it missed one place for the RELEASE_LOG_DISABLED check. * Source/WebCore/Modules/mediasource/MediaSource.cpp: Canonical link: https://commits.webkit.org/275371@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e8541: [UnifiedPDF] Word selections should not be generat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e854117d8ef01e6220c7379134324f75f21742a https://github.com/WebKit/WebKit/commit/6e854117d8ef01e6220c7379134324f75f21742a Author: Abrar Rahman Protyasha Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Word selections should not be generated when clicking on annotations https://bugs.webkit.org/show_bug.cgi?id=270140 rdar://123666112 Reviewed by Tim Horton. We are unnecessarily overriding the current selection in lookupTextAtLocation(). This manifests itself in the creation of stray word selections when clicking on annotations, and also in the brief flash of a blue highlight over words when simply clicking on them. The former is more apparent because we don't immediately reset the erroneously set selection with an empty one, but both are a result of WebPage calling into lookupTextAtLocation() as part of immediate action hit testing. This patch addresses the issue by simply not overriding the tracked selection from within lookupTextAtLocation(). * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::lookupTextAtLocation): Canonical link: https://commits.webkit.org/275370@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
