[webkit-changes] [WebKit/WebKit] 456247: [Gardening]: REGRESSION (271943@main): [ MacOS Deb...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 456247760b3335cf2921f6327268e3683f068386
  
https://github.com/WebKit/WebKit/commit/456247760b3335cf2921f6327268e3683f068386
  Author: Jay Stfleur 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (271943@main): [ MacOS Debug ] 
imported/w3c/web-platform-tests/scroll-animations/css/animation-fill-outside-range-test.html
 is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=123798031
rdar://123798031

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/275481@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73271d: (REGRESSION 275453@main) Broke clean cmake builds

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73271df67cecac670d2b19afefec29d0b6c20e1b
  
https://github.com/WebKit/WebKit/commit/73271df67cecac670d2b19afefec29d0b6c20e1b
  Author: Lauro Moura 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/XR/PlatformXRSystem.h

  Log Message:
  ---
  (REGRESSION 275453@main) Broke clean cmake builds
https://bugs.webkit.org/show_bug.cgi?id=270239

Reviewed by Don Olmstead.

Fix entry for file that was moved to cocoa-specific directory.

* Source/WebKit/UIProcess/XR/PlatformXRSystem.h: Drive-by non-unified
  fix that was breaking unified WPE build on flatpak
* Source/WebKit/Sources.txt:
* Source/WebKit/SourcesCocoa.txt:

Canonical link: https://commits.webkit.org/275480@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f0b5e: [Gardening]: [ MacOS Debug ] imported/w3c/web-plat...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f0b5ecf4b09e354557c94c62b8a7d1bf7e23ea7
  
https://github.com/WebKit/WebKit/commit/7f0b5ecf4b09e354557c94c62b8a7d1bf7e23ea7
  Author: Jay Stfleur 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: [ MacOS Debug ] 
imported/w3c/web-platform-tests/scroll-animations/css/animation-inactive-outside-range-test.html
 is a a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=123797319
rdar://123797319

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/275479@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 100477: [WebGPU] WebGPU::setUncapturedScopeCallback may cr...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1004779ce3c402ed769206fca5fe2cc835723a1d
  
https://github.com/WebKit/WebKit/commit/1004779ce3c402ed769206fca5fe2cc835723a1d
  Author: Mike Wyrzykowski 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  ---
  [WebGPU] WebGPU::setUncapturedScopeCallback may crash if repeatedly invoked
https://bugs.webkit.org/show_bug.cgi?id=270244


Reviewed by Dan Glastonbury.

We can only call this once, so null-out the callback
after it has been called.

* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::generateAValidationError):

Canonical link: https://commits.webkit.org/275478@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4adc88: [Win] run-bindings-tests doesn't work with a envir...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4adc8868a3aab588c005b7b6e10796f3a4e58191
  
https://github.com/WebKit/WebKit/commit/4adc8868a3aab588c005b7b6e10796f3a4e58191
  Author: Fujii Hironori 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/bindings/scripts/preprocessor.pm

  Log Message:
  ---
  [Win] run-bindings-tests doesn't work with a environment variable CC=clang-cl
https://bugs.webkit.org/show_bug.cgi?id=270245

Reviewed by Ross Kirsling.

preprocessor.pm didn't work as expected with CC=clang-cl. It specifies
`/EP` flag. but clang-cl doesn't work with only `/EP` flag.
WebKitCompilerFlags.cmake is specifying `/nologo /EP /TP` flags for
preprocessing on Windows.

* Source/WebCore/bindings/scripts/preprocessor.pm:
Changed the preprocessor flags on Windows.

Canonical link: https://commits.webkit.org/275477@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 08b992: Support moving a Web Extension tab to and from WIN...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 08b9923002071e6d00a4a90607710fa07b61676d
  
https://github.com/WebKit/WebKit/commit/08b9923002071e6d00a4a90607710fa07b61676d
  Author: Timothy Hatcher 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h
M Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm

  Log Message:
  ---
  Support moving a Web Extension tab to and from WINDOW_ID_NONE.
https://webkit.org/b/270260
rdar://123102191

Reviewed by Brian Weinstein.

Safari needs to move tabs to and from WINDOW_ID_NONE when switching Tab Groups.
The existing didMoveTab:fromIndex:inWindow: method needed updated to support 
this,
and properly fire the tabs events.

Updated existing testing support to allow assigning nil to a tab's window.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:
(-[_WKWebExtensionContext didMoveTab:fromIndex:inWindow:]): Handle NSNotFound.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::didMoveTab): Enumerate all the possible move 
combos
when logging, and fire the appropriate events for for each possibility.
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TEST(WKWebExtensionAPITabs, DetachAndAttachToWindowIDNone)): Added.
(TEST(WKWebExtensionAPITabs, DetachAndAttachFromWindowIDNone)): Added.
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.h:
* Tools/TestWebKitAPI/cocoa/WebExtensionUtilities.mm:
(-[TestWebExtensionTab assignWindow:]): Added.
(-[TestWebExtensionTab setWindow:]): Added. Call didMoveTab:::.
(-[TestWebExtensionWindow removeTab:]): Added.
(-[TestWebExtensionWindow insertTab:atIndex:]): Added.
(-[TestWebExtensionWindow moveTab:toIndex:]): Use assignWindow:. And pass self
when the tab is moving in the same window.

Canonical link: https://commits.webkit.org/275476@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8ec200: [Win] built-product-archive should work without WE...

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ec200dbd45df59fffbda714a9e4b8d1ccc6ceb3
  
https://github.com/WebKit/WebKit/commit/8ec200dbd45df59fffbda714a9e4b8d1ccc6ceb3
  Author: Fujii Hironori 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/built-product-archive

  Log Message:
  ---
  [Win] built-product-archive should work without WEBKIT_LIBRARIES environment 
variable
https://bugs.webkit.org/show_bug.cgi?id=270149

Reviewed by Ross Kirsling.

Use "WebKitLibraries/win" as the default directory if WEBKIT_LIBRARIES
isn't set

* Tools/CISupport/built-product-archive:

Canonical link: https://commits.webkit.org/275475@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 768116: [JSC] Remove ArrayPatternNode::emitDirectBinding()

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76811693b10007dba19a08e3395e0c072c4bc0be
  
https://github.com/WebKit/WebKit/commit/76811693b10007dba19a08e3395e0c072c4bc0be
  Author: Alexey Shvayka 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M JSTests/microbenchmarks/default-value-destructuring-array.js
R JSTests/microbenchmarks/destructuring-array-literal.js
M JSTests/microbenchmarks/destructuring-swap.js
M JSTests/test262/expectations.yaml
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/parser/Nodes.h

  Log Message:
  ---
  [JSC] Remove ArrayPatternNode::emitDirectBinding()
https://bugs.webkit.org/show_bug.cgi?id=187085


Reviewed by Yusuke Suzuki.

This patch removes special bytecode generation path for code like `[a, b] = [b, 
a]` that wasn't
spec-compliant: it skipped invocation of iterator protocol, which was 
observable when built-ins like
`Array.prototype[Symbol.iterator]` were modified.

There is no way to guard the special code path with some sort of built-ins 
check without bloating
the bytecode size: we would still need to emit regular iterator protocol code, 
which actually
isn't even slower after DFG / FTL, as demonstated by existing microbenchmark.

Only very obscure / synthetic tests are recorded to be slower after this change.
This patch was A/B tested not to affect JS3, SP2, and SP3.
Aligns JSC with the spec, V8, and SpiderMonkey.

  ToT patch

destructuring-swap  53.4546+-0.1895 ^ 
51.3538+-0.2101^ definitely 1.0409x faster
default-value-destructuring-array   36.5455+-0.4078 !
105.0089+-0.4452! definitely 2.8734x slower

* JSTests/microbenchmarks/default-value-destructuring-array.js:
* JSTests/microbenchmarks/destructuring-array-literal.js:
Removed, it was very synthetic test targeting emitDirectBinding().

* JSTests/microbenchmarks/destructuring-swap.js:
* JSTests/test262/expectations.yaml: Mark 24 tests as passing.
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::DestructuringAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding): Deleted.
* Source/JavaScriptCore/parser/Nodes.h:
(JSC::DestructuringPatternNode::isRestParameter const):
(JSC::DestructuringPatternNode::emitDirectBinding): Deleted.

Canonical link: https://commits.webkit.org/275474@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ab87d: Add fantasai to WebKit committers.

[fantasai]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ab87dcfa7518807452ec9844f6a66537bdca87e
  
https://github.com/WebKit/WebKit/commit/3ab87dcfa7518807452ec9844f6a66537bdca87e
  Author: Elika Etemad 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add fantasai to WebKit committers.
https://bugs.webkit.org/show_bug.cgi?id=270267
rdar://problem/123792952

Reviewed by Sammy Gill.

Adds committer status to fantasai's entry in contributors.json

* metadata/contributors.json: Add committer status.

Canonical link: https://commits.webkit.org/275473@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f6fe8: [ews-build] Reduce duration to keep buildbot logs ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f6fe8dd5f940a6c609a80b8a00779f3c1f178bc
  
https://github.com/WebKit/WebKit/commit/9f6fe8dd5f940a6c609a80b8a00779f3c1f178bc
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews-build] Reduce duration to keep buildbot logs to 30 days
https://bugs.webkit.org/show_bug.cgi?id=270255

Reviewed by Jonathan Bedard.

old buildbot logs on EWS aren't much usable. Most of the PRs are already landed 
and even
if they aren't, people should rebase on ToT and re-run EWS for latest results.

Note that this does not affect GitHub status-bubbles or bugzilla 
status-bubbles. The builds
will still be there, links will still work from GitHub status-bubbles, just 
that the detailed
logs wouldn't be available for older builds.

* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/275472@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf3a77: [Unified Text Replacement] Only show swap characte...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf3a7793eba614aa930b5ef9eeaac069c25d7deb
  
https://github.com/WebKit/WebKit/commit/cf3a7793eba614aa930b5ef9eeaac069c25d7deb
  Author: Richard Robinson 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  [Unified Text Replacement] Only show swap characters view when web view is 
editable
https://bugs.webkit.org/show_bug.cgi?id=270231
rdar://123762150

Reviewed by Aditya Keerthi.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):

Canonical link: https://commits.webkit.org/275471@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 16d05a: Use privacyPreservingDescription() and always log ...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16d05a3d74c72c170b84a8826c5121c680d2e23c
  
https://github.com/WebKit/WebKit/commit/16d05a3d74c72c170b84a8826c5121c680d2e23c
  Author: Timothy Hatcher 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm

  Log Message:
  ---
  Use privacyPreservingDescription() and always log NSErrors as %{public}@.
https://webkit.org/b/270234
rdar://problem/123771246

Reviewed by Brian Weinstein.

Use privacyPreservingDescription() wherever we log an NSError, and switch it to 
be %{public}@.
Also change some error strings in dNR to %{public}@ since they are not private 
error messages.

* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::updateDeclarativeNetRequestRulesInStorage):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeOpenOptionsPage):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm:
(WebKit::WebExtensionContext::tabsCreate):
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm:
(WebKit::WebExtensionContext::windowsCreate):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate 
webView:didFailProvisionalNavigation:withError:]):
(-[_WKWebExtensionActionWebViewDelegate webView:didFailNavigation:withError:]):
(WebKit::WebExtensionAction::detectPopoverColorScheme):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::recordError):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::readStateFromPath):
(WebKit::WebExtensionContext::writeStateToStorage const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm:
(WebKit::WebExtensionTab::setParentTab):
(WebKit::WebExtensionTab::pin):
(WebKit::WebExtensionTab::unpin):
(WebKit::WebExtensionTab::toggleReaderMode):
(WebKit::WebExtensionTab::mute):
(WebKit::WebExtensionTab::unmute):
(WebKit::WebExtensionTab::setZoomFactor):
(WebKit::WebExtensionTab::detectWebpageLocale):
(WebKit::WebExtensionTab::captureVisibleWebpage):
(WebKit::WebExtensionTab::loadURL):
(WebKit::WebExtensionTab::reload):
(WebKit::WebExtensionTab::reloadFromOrigin):
(WebKit::WebExtensionTab::goBack):
(WebKit::WebExtensionTab::goForward):
(WebKit::WebExtensionTab::activate):
(WebKit::WebExtensionTab::select):
(WebKit::WebExtensionTab::deselect):
(WebKit::WebExtensionTab::duplicate):
(WebKit::WebExtensionTab::close):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm:
(WebKit::WebExtensionWindow::setState):
(WebKit::WebExtensionWindow::focus):
(WebKit::WebExtensionWindow::setFrame):
(WebKit::WebExtensionWindow::close):

Canonical link: https://commits.webkit.org/275470@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aef779: [Gardening]: NEW TEST[ MacOS arm64 ] media/mediaca...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aef779cbd46da8588edfb9e8dc24f208307e9e98
  
https://github.com/WebKit/WebKit/commit/aef779cbd46da8588edfb9e8dc24f208307e9e98
  Author: Jay Stfleur 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: NEW TEST[ MacOS arm64 ] media/mediacapabilities/vp9-hw.html is a 
constant failure
https://bugs.webkit.org/show_bug.cgi?id=123790055
rdar://123790055

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/275469@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff897c: Extract a portion of NodeIteratorBase::acceptNode...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff897caf5ad29704726b6551c955396a4775631e
  
https://github.com/WebKit/WebKit/commit/ff897caf5ad29704726b6551c955396a4775631e
  Author: Ryosuke Niwa 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/dom/Traversal.cpp
M Source/WebCore/dom/Traversal.h
M Source/WebCore/dom/TreeWalker.cpp

  Log Message:
  ---
   Extract a portion of NodeIteratorBase::acceptNode which checks bit flags 
into its own function
https://bugs.webkit.org/show_bug.cgi?id=270210


Reviewed by Chris Dumez.

Extracted matchesWhatToShow out of acceptNode and deployed in 
TreeWalker::nextNode and
TreeWalker::previousNode.

* Source/WebCore/dom/Traversal.cpp:
(WebCore::NodeIteratorBase::acceptNodeSlowCase):
* Source/WebCore/dom/Traversal.h:
(WebCore::NodeIteratorBase::acceptNode):
(WebCore::NodeIteratorBase::matchesWhatToShow):
* Source/WebCore/dom/TreeWalker.cpp:
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):

Canonical link: https://commits.webkit.org/275468@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9530e9: Gathering resource load statistics resumes suspend...

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9530e9a8df9ca849d688eb79159296a2300614b6
  
https://github.com/WebKit/WebKit/commit/9530e9a8df9ca849d688eb79159296a2300614b6
  Author: Ben Nham 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  ---
  Gathering resource load statistics resumes suspended WebContent processes
https://bugs.webkit.org/show_bug.cgi?id=270201
rdar://problem/123724907

Reviewed by Alex Christensen.

Right now, gathering all resource load statistics (via ` 
_getResourceLoadStatisticsDataSummary:`)
sends an async IPC with a completion handler to all WebContent processes. This 
causes a background
activity to run which causes all suspended WebContent processes to resume just 
to handle this IPC.

This process resume isn't necessary because WebProcess already flushes all 
pending resource load
statistics to NetworkProcess at suspend time (see the call to 
`flushResourceLoadStatistics` in
`WebContent::prepareToSuspend`). So we can avoid the process resume by just not 
sending this IPC to
suspended WebContent processes.

* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::sendResourceLoadStatisticsDataImmediately):

Canonical link: https://commits.webkit.org/275467@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] be2916: [WebAuthn] Overrelease in error for multi-origin c...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be2916dac989bfb95ddfe2acb75c9631f1d00959
  
https://github.com/WebKit/WebKit/commit/be2916dac989bfb95ddfe2acb75c9631f1d00959
  Author: Pascoe 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

  Log Message:
  ---
  [WebAuthn] Overrelease in error for multi-origin credentials
rdar://123357813
https://bugs.webkit.org/show_bug.cgi?id=269942

Reviewed by Chris Dumez.

There's evidence for crashes being caused by the over-release of the dictionary 
inside
userInfo[NSUnderlyingErrorKey] for the error returned for multi-origin 
credentials. This
patch is to use RetainPtr in WebKit for this dictionary. I have not been able 
to reproduce
the crash, so this is speculative.

* 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):

Canonical link: https://commits.webkit.org/275466@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e336a8: Avoid calling SynchronousLoadData CompletionHandle...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e336a8ca8c960b36c8a74aece5e5a16d08274960
  
https://github.com/WebKit/WebKit/commit/e336a8ca8c960b36c8a74aece5e5a16d08274960
  Author: Matthew Finkel 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

  Log Message:
  ---
  Avoid calling SynchronousLoadData CompletionHandler more than once
https://bugs.webkit.org/show_bug.cgi?id=270030
rdar://109257007

Reviewed by Chris Dumez.

In some situations, a NetworkResourceLoader may call its SynchronousLoadData's
delayedReply CompletionHandler more than once. This change returns early if we
hit that case. I'm leaving the debug assertion so we investigate if this starts
happening frequently.

* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::sendReplyToSynchronousRequest):

Canonical link: https://commits.webkit.org/275465@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a6f3a: Update Abrar Rahman Protyasha's contributor status...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a6f3a4c697316243e2cba1509b1d6a4321f56a0
  
https://github.com/WebKit/WebKit/commit/8a6f3a4c697316243e2cba1509b1d6a4321f56a0
  Author: Abrar Rahman Protyasha 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Update Abrar Rahman Protyasha's contributor status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=270248
rdar://123786081

Reviewed by Aditya Keerthi.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/275464@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 415bdd: Further remove support for "Search with Spotlight"...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 415bdd37cb7467e4a5798e192a94cf8a6b1d3648
  
https://github.com/WebKit/WebKit/commit/415bdd37cb7467e4a5798e192a94cf8a6b1d3648
  Author: Tim Horton 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/ContextMenuClient.h
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/platform/ContextMenuItem.cpp
M Source/WebCore/platform/ContextMenuItem.h
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm
M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp
M Source/WebKit/Shared/API/c/WKSharedAPICast.h
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
M Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultContextMenuDelegate.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm
M Source/WebKitLegacy/mac/WebView/WebViewInternal.h

  Log Message:
  ---
  Further remove support for "Search with Spotlight" context menu item
https://bugs.webkit.org/show_bug.cgi?id=270242

Reviewed by Megan Gardner.

This context menu item was removed in Snow Leopard timeframe, and the 
functionality
behind it was broken by sandboxing later on (but still many years ago).

Remove our support, but leave the API in place.

* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/ContextMenuClient.h:
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/platform/ContextMenuItem.cpp:
(WebCore::isValidContextMenuAction):
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::contextMenuItemTagSearchInSpotlight): Deleted.
* Source/WebKit/Shared/API/c/WKContextMenuItem.cpp:
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::searchWithSpotlight): Deleted.
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::searchWithSpotlight): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithSpotlight): Deleted.
* Source/WebKitLegacy/mac/DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::searchWithSpotlight): Deleted.
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(toAction):
(toTag):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _searchWithSpotlightFromMenu:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewInternal.h:

Canonical link: https://commits.webkit.org/275463@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cc0a3e: Cherry-pick 275381@main (3f4bd57a7ba1). https://bu...

[Don Olmstead]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: cc0a3ee3258d24d3a2d20875fca357b6553e1098
  
https://github.com/WebKit/WebKit/commit/cc0a3ee3258d24d3a2d20875fca357b6553e1098
  Author: Adrian Perez de Castro 
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/PerfLog.cpp
M Source/WebCore/Modules/mediasource/SourceBuffer.cpp
M Source/WebCore/Modules/mediasource/SourceBufferList.cpp
M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp
M Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp
M Source/WebCore/Modules/mediastream/RTCRtpSender.cpp
M Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp
M Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp
M Source/WebCore/animation/WebAnimationUtilities.h
M Source/WebCore/bindings/js/GCController.h
M Source/WebCore/css/parser/CSSSelectorParser.cpp
M Source/WebCore/editing/VisibleSelection.cpp
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/loader/cache/CachedResourceRequest.cpp
M Source/WebCore/page/PointerLockController.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/platform/MediaDescription.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/style/Styleable.cpp
M Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp
M Source/WebKit/Shared/WebCompiledContentRuleListData.cpp
M Source/WebKit/Shared/gtk/WebEventFactory.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp

  Log Message:
  ---
  Cherry-pick 275381@main (3f4bd57a7ba1). 
https://bugs.webkit.org/show_bug.cgi?id=270156

Non-unified build fixes, late February 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=270156

Unreviewed non-unified build fixes.

* Source/JavaScriptCore/assembler/PerfLog.cpp: Add missing inclusions of
Options.h and wtf/StringPrintStream.h.
* Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.cpp:
Add missing inclusions of SourceBufferList.h and TimeRanges.h.
* Source/WebCore/Modules/mediasource/MediaSourceInterfaceMainThread.h:
Add missing forward declaration for the WebCore::MediaSource type.
* Source/WebCore/Modules/mediasource/SourceBuffer.cpp: Remove unused
ExponentialMovingAverageCoefficient constant.
* Source/WebCore/Modules/mediasource/SourceBufferList.cpp: Add missing
ContextDestructionObserverInlines.h header.
* Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.cpp:
Ditto, plus wtf/IsoMallocInlines.h.
* Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp: Add missing
ContextDestructionObserverInlines.h.
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp: Ditto
* Source/WebCore/Modules/mediastream/RTCRtpSender.cpp: Ditto.
* Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp: Ditto,
plus move all inclusions into ENABLE(SPEECH_SYNTHESIS).
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: Add
missing ContextDestructionObserverInlines.h inclusion.
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: Ditto.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp: Ditto.
* Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp: Ditto.
* Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp: Add
missing Node.h inclusion.
* Source/WebCore/animation/WebAnimationUtilities.h: Add missing forward
declarations for WebCore::Document and 
WebCore::Style::PseudoElementIdentifier.
* Source/WebCore/bindings/js/GCController.h: Add missing forward
declaration for the JSC::VM type.
* Source/WebCore/css/parser/CSSSelectorParser.cpp: Add missing
CSSTokenizer.h inclusion.
* Source/WebCore/dom/FragmentDirectiveGenerator.cpp: Add missing
Document.h inclusion.
* Source/WebCore/dom/FragmentDirectiveGenerator.h: Add missing wtf/URL.h
inclusion, add missing WebCore::SimpleRange forward declaration, and
remove the unneeded WebCore::Range one.
* Source/WebCore/editing/VisibleSelection.cpp: Replace Element.h
inclusion with ElementInlines.h.
* Source/WebCore/html/MediaElementSession.cpp: Add missing Navigator.h
inclusion.
* Source/WebCore/loader/cache/CachedResourceRequest.cpp: Add missing
Quirks.h inclusion.
* Source/WebCore/page/PointerLockController.cpp: Add missing
DocumentInlines.h inclusion.
* Source/WebCore/page/Quirks.h: Add missing

[webkit-changes] [WebKit/WebKit] a1ec0a: Bump the QoS of the IPC receive queue in the UIPro...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1ec0afd089816638d36426a46298c019ae12246
  
https://github.com/WebKit/WebKit/commit/a1ec0afd089816638d36426a46298c019ae12246
  Author: Chris Dumez 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp

  Log Message:
  ---
  Bump the QoS of the IPC receive queue in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=270178
rdar://120745771

Reviewed by Geoffrey Garen and Sihui Liu.

Bump the QoS of the IPC receive queue in the UIProcess. The IPC receive queue 
was
running at a much lower QoS than the main thread, potentially causing delay in
some performance-sensitive tasks. We've seen examples (see radar) of the main
thread hanging, waiting on the IPC receive queue to release a lock for e.g.

This tested as performance-neutral on most benchmarks. However, this tested as
a ~0.7% progression on PLT5 on Apple Silicon.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::createServerConnection):
(IPC::Connection::Connection):
* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):

Canonical link: https://commits.webkit.org/275462@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53b1e6: 1Password fails to load popup after focusing a for...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53b1e6b7f02bbbc8a252792659963244ee04620f
  
https://github.com/WebKit/WebKit/commit/53b1e6b7f02bbbc8a252792659963244ee04620f
  Author: Timothy Hatcher 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm
M 
Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm

  Log Message:
  ---
  1Password fails to load popup after focusing a form field on a page.
https://webkit.org/b/270233
rdar://123423266

Reviewed by Jeff Miller and Brian Weinstein.

Once the input field is focused, 1Password creates an iframe with an extension 
document in the
tab. This causes two processes to have listeners for the runtime.onMessage 
event. That then
causes a race when sending messages, and the tab frame wins since the 
background replies async
after doing some work.

This was happening because the reply aggregator in the web process was sending 
a default null
reply, since the completion handler is always called, which was 
indistinguishable from a real
reply. Now we always send either null for default or at minimum an empty string 
for the JSON
reply, and the UI process skips the replies that are null strings. The 
aggregator on the UI
process side will then get the real reply or default to null later once it goes 
out of scope.

* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContext::runtimeSendMessage): Don't call 
callbackAggregator for null string.
(WebKit::WebExtensionContext::runtimeWebPageSendMessage): Ditto.
* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm:
(WebKit::WebExtensionContextProxy::internalDispatchRuntimeMessageEvent): Ensure 
a real reply is
never null, so the completionHandler can make the distinction. Send default 
replies as null.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:
(TEST(WKWebExtensionAPIRuntime, SendMessageWithTabFrameAndAsyncReply)): Added.
(TEST(WKWebExtensionAPIRuntime, 
SendMessageFromWebPageWithTabFrameAndAsyncReply)): Added.

Canonical link: https://commits.webkit.org/275461@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04e0a6: Refactor MediaSessionManagerCocoa::nowPlayingEligi...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04e0a64601921fa8f768610f715769c44d3ad712
  
https://github.com/WebKit/WebKit/commit/04e0a64601921fa8f768610f715769c44d3ad712
  Author: Youenn Fablet 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/Modules/mediasession/MediaSession.cpp
M Source/WebCore/Modules/mediasession/MediaSession.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/MediaElementSession.cpp
M Source/WebCore/html/MediaElementSession.h
M Source/WebCore/platform/audio/PlatformMediaSession.cpp
M Source/WebCore/platform/audio/PlatformMediaSession.h
M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
M Source/WebCore/platform/audio/PlatformMediaSessionManager.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm

  Log Message:
  ---
  Refactor MediaSessionManagerCocoa::nowPlayingEligibleSession to allow non 
HTMLMediaElement eligible sessions
https://bugs.webkit.org/show_bug.cgi?id=270090
rdar://123632916

Reviewed by Jean-Yves Avenard.

We want to allow AudioContext to be used as media playback with AudioSession 
API.
For that, it needs to be on par with HTMLMediaElement, and for instance trigger 
NowPlayingInfo updates.
This patch is refactoring code to untie a bit HTMLMediaElement and 
NowPlayingInfo computation.
It should not have any impact on behavior since this patch is not adding code 
to actually allow
AudioContext to be handled like HTMLMediaElement (for instance pay/pause from 
the control center).

We introduce MediaSession::updateNowPlayingInfo and 
NavigatorMediaSession::mediaSessionIfExists to
allow updating NowPlayingInfo according MediaSession from either 
HTMLMediaElement or other media producers.

We introduce getters for nowPlayingInfo and isNowPlayingEligible on 
PlatformMediaSession which are being forwarded to each client.
We update HTMLMediaElement/MediaElementSession implementation accordingly.

We introduce PlatformMediaSessionManager::bestEligibleSessionForRemoteControls 
to filter sessions according presentation types.
We then get two lists of media sessions, one of web audio and one of media 
(HTMLMediaElement basically).
If the HTMLMediaElement list is empty, we look at WebAudio sessions, otherwise 
we look at HTMLMediaElement sessions.

We introduce selectBestMediaSession so that sorting is done by each session 
subtype.

This allows to fix the layering violation from 
MediaSessionManagerCocoa::nowPlayingEligibleSession.:

* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::updateNowPlayingInfo):
* Source/WebCore/Modules/mediasession/MediaSession.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::bestMediaElementForRemoteControls):
(WebCore::HTMLMediaElement::nowPlayingInfo const):
(WebCore::HTMLMediaElement::selectBestMediaSession):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::hasNowPlayingInfo const):
(WebCore::MediaElementSession::computeNowPlayingInfo const):
(WebCore::MediaElementSession::nowPlayingInfo const): Deleted.
* Source/WebCore/html/MediaElementSession.h:
* Source/WebCore/platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::nowPlayingInfo const):
(WebCore::PlatformMediaSession::isNowPlayingEligible const):
(WebCore::PlatformMediaSession::selectBestMediaSession):
(WebCore::PlatformMediaSessionClient::nowPlayingInfo const):
* Source/WebCore/platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSessionClient::isNowPlayingEligible const):
(WebCore::PlatformMediaSessionClient::selectBestMediaSession):
* Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::bestEligibleSessionForRemoteControls):
* Source/WebCore/platform/audio/PlatformMediaSessionManager.h:
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h:
* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::nowPlayingEligibleSession):
(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):

Canonical link: https://commits.webkit.org/275460@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2f4677: Some more adoption of dynamicDowncast<> in layout ...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f4677a0ea4557844e43e5d3f60f7ddcb857d2e6
  
https://github.com/WebKit/WebKit/commit/2f4677a0ea4557844e43e5d3f60f7ddcb857d2e6
  Author: Anne van Kesteren 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/layout/formattingContexts/block/BlockMarginCollapse.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp

  Log Message:
  ---
  Some more adoption of dynamicDowncast<> in layout code
https://bugs.webkit.org/show_bug.cgi?id=270039

Reviewed by Alan Baradlay.

For security and performance.

* Source/WebCore/layout/formattingContexts/block/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockMarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore
 const):
(WebCore::Layout::BlockMarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter
 const):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp:
(WebCore::Layout::containsTrailingSoftHyphen):
(WebCore::Layout::containsPreservedTab):
(WebCore::Layout::InlineContentBalancer::shouldTrimLeading const):
(WebCore::Layout::InlineContentBalancer::shouldTrimTrailing const):
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::isWhitespaceOnlyContent):
(WebCore::Layout::InlineContentBreaker::tryHyphenationAcrossOverflowingInlineTextItems
 const):
(WebCore::Layout::InlineContentBreaker::processOverflowingContentWithText 
const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::inlineItemWidth const):
(WebCore::Layout::InlineFormattingUtils::isAtSoftWrapOpportunity const):
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::buildBidiParagraph):
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendLineBreak):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::hasTrailingSoftWrapOpportunity):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::trailingPunctuationOrStopOrCommaWidthForLineCandiate
 const):
(WebCore::Layout::LineBuilder::candidateContentForLine):
(WebCore::Layout::LineBuilder::isLastLineWithInlineContent const):
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
(WebCore::Layout::TextOnlySimpleLineBuilder::placeInlineTextContent):
(WebCore::Layout::TextOnlySimpleLineBuilder::placeNonWrappingInlineTextContent):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:
(WebCore::InlineIterator::LineBox::ellipsisSelectionState const):

Canonical link: https://commits.webkit.org/275459@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6a2c8: Some Overlay Regions are missing for fixed elements

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6a2c84bcb5e069688d976fff1e57953741c7f47
  
https://github.com/WebKit/WebKit/commit/b6a2c84bcb5e069688d976fff1e57953741c7f47
  Author: Etienne Segonzac 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
A LayoutTests/overlay-region/overlay-element-expected.txt
A LayoutTests/overlay-region/overlay-element-overflow-expected.txt
A LayoutTests/overlay-region/overlay-element-overflow.html
A LayoutTests/overlay-region/overlay-element.html
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

  Log Message:
  ---
  Some Overlay Regions are missing for fixed elements
https://bugs.webkit.org/show_bug.cgi?id=270224


Reviewed by Mike Wyrzykowski.

We can't filter Overlay Regions based on size. Instead, when
looking at regions from parent ScrollViews, only keep regions
originating from layers that draw above the selected ScrollView.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(addOverlayEventRegions):
When traversing fixed layer hierarchies, stop at ScrollView boundaries.
The issue wasn't with solid background colors layers, they don't have
Event Regions. But when a scroller is `position: fixed` we don't want to
generate Overlay Regions for all its descendants (like the scrolled
content layer, which always has an Event Region).
(configureScrollViewWithOverlayRegionsIDs):
(-[WKWebView _updateOverlayRegions:destroyedLayers:]):
Only keep regions from layers that draw above the selected ScrollView.
Remove the size check for Overlay Regions.

* LayoutTests/overlay-region/overlay-element-expected.txt: Added.
* LayoutTests/overlay-region/overlay-element-overflow-expected.txt: Added.
* LayoutTests/overlay-region/overlay-element-overflow.html: Added.
* LayoutTests/overlay-region/overlay-element.html: Added.
Add new test cases for the "full page overlay" scenario.

Canonical link: https://commits.webkit.org/275458@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] df5862: [Gardening]: [ MacOS Debug x86_64 ] webgl/pending/...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df58622d92d5bc6a9f2ead9404b6e12e35c0d36e
  
https://github.com/WebKit/WebKit/commit/df58622d92d5bc6a9f2ead9404b6e12e35c0d36e
  Author: Jay Stfleur 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [Gardening]: [ MacOS Debug x86_64 ] 
webgl/pending/conformance/glsl/misc/shader-with-reserved-words-2.html is a 
consistent time out
https://bugs.webkit.org/show_bug.cgi?id=123771546
rdar://123771546

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/275457@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ffe50c: [Gardening]: REGRESSION (272891@main): [ Sonoma wk...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffe50cdcd057377509d72a4f5a29f066ecc646cf
  
https://github.com/WebKit/WebKit/commit/ffe50cdcd057377509d72a4f5a29f066ecc646cf
  Author: Marta Darbinyan 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (272891@main): [ Sonoma wk1 ] 5 tests in 
imported/w3c/web-platform-tests/css/filter-effects are constant failures
https://bugs.webkit.org/show_bug.cgi?id=270199
rdar://123723468

Unreviewed test gardening.

Adding test expectation

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/275456@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59e1c1: [ews] Load passwords.json from ews-build directory...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59e1c186c9fdf9ce0896b9d6a59b1d5286dccfba
  
https://github.com/WebKit/WebKit/commit/59e1c186c9fdf9ce0896b9d6a59b1d5286dccfba
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg
M Tools/CISupport/ews-build/utils.py

  Log Message:
  ---
  [ews] Load passwords.json from ews-build directory for all masters
https://bugs.webkit.org/show_bug.cgi?id=270232

Reviewed by Jonathan Bedard.

Load passwords.json from ews-build directory for all masters, so that all 
masters
load same passwords.json without need to create a symlink.

* Tools/CISupport/ews-build/utils.py:
* Tools/CISupport/build-webkit-org/master.cfg: Similar change for 
build.webkit.org for future use.

Canonical link: https://commits.webkit.org/275455@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d2091f: Web Extension popup can present too soon.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2091f38fe857c747e7eb84f0e2d7fe19aa6fd1c
  
https://github.com/WebKit/WebKit/commit/d2091f38fe857c747e7eb84f0e2d7fe19aa6fd1c
  Author: Timothy Hatcher 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm

  Log Message:
  ---
  Web Extension popup can present too soon.
https://webkit.org/b/270185
rdar://problem/123711867

Reviewed by Brian Weinstein.

Instead of starting the timer that presented the popup on the start of the load,
we should start it after the document has loaded and rendering will begin.

This prevents us from showing the popup while it might still be loading, and
causing it to resize mid-animation in most instances.

Also connect delegate methods for load fails to close the popup, so the web view
doesn't stick around indefinitely. Some API tests were failing to load because 
the
popup.html resource was missing.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionWebViewDelegate 
webView:didFailProvisionalNavigation:withError:]):
(-[_WKWebExtensionActionWebViewDelegate webView:didFailNavigation:withError:]):
(-[_WKWebExtensionActionWebViewDelegate 
_webView:navigationDidFinishDocumentLoad:]):
(WebKit::WebExtensionAction::presentPopupWhenReady):
(WebKit::WebExtensionAction::popupDidFinishDocumentLoad):
(WebKit::WebExtensionAction::readyToPresentPopup):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/275454@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 110619: Model Process CA layer hosting

[eddydas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11061972c7486a8ddd132affabbc3396aa2ca961
  
https://github.com/WebKit/WebKit/commit/11061972c7486a8ddd132affabbc3396aa2ca961
  Author: Eddy Wong 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/Modules/model-element/HTMLModelElement.cpp
M Source/WebCore/Modules/model-element/HTMLModelElement.h
M Source/WebCore/Modules/model-element/ModelPlayer.h
M Source/WebCore/Modules/model-element/ModelPlayerClient.h
M Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp
M Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.h
M Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.h
M Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.mm
M Source/WebCore/platform/graphics/GraphicsLayer.h
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.cpp
R Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.cpp
R Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.h
R Source/WebKit/ModelProcess/ModelProcessModelPlayerProxy.messages.in
A Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h
A Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in
A Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm
M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Model.sb.in
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.h
M Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in
M Source/WebKit/WebProcess/Model/ModelProcessModelPlayerManager.cpp
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.mm
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm

  Log Message:
  ---
  Model Process CA layer hosting
rdar://123273873
https://bugs.webkit.org/show_bug.cgi?id=269762

Reviewed by Tim Horton.

Hosts a dummy green CALayer in Model process and display it for
 tag, as a precursor to actually hosting the 3D model.

The hosting mechanism utilizes the same PlatformCALayerRemoteCustom
as that used by HTMLVideoElement, with some minor generalization.

We have created a new ContentsLayerPurpose::HostedModel to
distinguish between the existing in-process Model path and the
Model process path, as a temporary measure.

* Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::layerHostingContextIdentifier const):
(WebCore::HTMLModelElement::didUpdateLayerHostingContextIdentifier):
The hosting context identifier comes back in an async manner, so this
callback will ultimately re-create the correct hosting layer
pointing to this new hosting context identifier.

* Source/WebCore/Modules/model-element/HTMLModelElement.h:
* Source/WebCore/Modules/model-element/ModelPlayer.h:
* Source/WebCore/Modules/model-element/ModelPlayerClient.h:
* Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp:
(WebCore::DummyModelPlayer::layerHostingContextIdentifier):
* Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.h:
* Source/WebCore/platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setContentsToPlatformLayerCustom):
A generic way to utilize a PlatformLayerCustom with any
given hosting context identifier and purpose.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayerCustom):
(WebCore::GraphicsLayerCA::setContentsToPlatformLayerCustom):
A platformCALayerCustom essentially does one thing - hosts
another CALayer in another process. So this fits our purpose
well.

(WebCore::GraphicsLayerCA::purposeNameForInnerLayer const):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
The handling for the existing "Model" layer purpose is quite
distinct from what we are going to do. So let's introduce
a new "HostedModel" layer purpose for the time being. We could
remove the old "Model" one once

[webkit-changes] [WebKit/WebKit] 4e8b5c: [ wk2 Debug ] loader/stateobjects/pushstate-size-i...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e8b5c1a05ae111def3a5754f16af81ff19ae3a0
  
https://github.com/WebKit/WebKit/commit/4e8b5c1a05ae111def3a5754f16af81ff19ae3a0
  Author: Chris Dumez 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/loader/stateobjects/pushstate-size-iframe-expected.txt
M LayoutTests/loader/stateobjects/pushstate-size-iframe.html
M LayoutTests/loader/stateobjects/resources/pushstate-iframe.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/page/History.cpp
M Source/WebCore/page/History.h
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl

  Log Message:
  ---
  [ wk2 Debug ] loader/stateobjects/pushstate-size-iframe.html is very slow, 
usually times out
https://bugs.webkit.org/show_bug.cgi?id=268836
rdar://122401579

Reviewed by Ryosuke Niwa.

This test was slow, especially in debug because it had to reach the 64MB size 
limit by doing
repeated history.pushState() calls. This would obviously take a while. To 
address the issue,
I am introducing a new window.internals API to override this limit. In the 
test, we now
lower this limit to 4MB, which makes the test run a lot faster.

* LayoutTests/loader/stateobjects/pushstate-size-iframe-expected.txt:
* LayoutTests/loader/stateobjects/pushstate-size-iframe.html:
* LayoutTests/loader/stateobjects/resources/pushstate-iframe.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/page/History.cpp:
(WebCore::History::totalStateObjectPayloadLimit const):
(WebCore::History::stateObjectAdded):
* Source/WebCore/page/History.h:
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHistoryTotalStateObjectPayloadLimitOverride):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/275452@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 956d3e: Silence warning about missing runningboard entitle...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 956d3e42ecc8e62c122425a0cdb38fa27ac25e8f
  
https://github.com/WebKit/WebKit/commit/956d3e42ecc8e62c122425a0cdb38fa27ac25e8f
  Author: Chris Dumez 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebProcessPool.cpp
M Source/WebKit/UIProcess/WebProcessPool.h

  Log Message:
  ---
  Silence warning about missing runningboard entitlement for the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=270214
rdar://123740093

Reviewed by Andy Estes.

Silence warning about missing runningboard entitlement for the UIProcess. Only
try and take the MediaPlayback process assertion on the UIProcess if it has the
proper entitlement.

* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::updateAudibleMediaAssertions):
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/275451@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b521ef: Use dynamicDowncast in NavigationAction

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b521ef5df5cfd6ccc54b34ffbae697905a209455
  
https://github.com/WebKit/WebKit/commit/b521ef5df5cfd6ccc54b34ffbae697905a209455
  Author: Anne van Kesteren 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/dom/EventContext.cpp
M Source/WebCore/dom/EventDispatcher.cpp
M Source/WebCore/loader/NavigationAction.cpp

  Log Message:
  ---
  Use dynamicDowncast in NavigationAction
https://bugs.webkit.org/show_bug.cgi?id=270227

Reviewed by Chris Dumez.

For security & performance.

In EventContext we move up some of the boolean conditions up such that
there should be less downcasting during event dispatch.

* Source/WebCore/dom/EventContext.cpp:
(WebCore::EventContext::handleLocalEvents const):
* Source/WebCore/dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
* Source/WebCore/loader/NavigationAction.cpp:
(WebCore::mouseEventDataForFirstMouseEvent):

Canonical link: https://commits.webkit.org/275450@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f98f5f: [iOS] http/tests/IndexedDB/collect-IDB-objects.htt...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f98f5f2c1804c13633a127c3b9ca191d3754ed3d
  
https://github.com/WebKit/WebKit/commit/f98f5f2c1804c13633a127c3b9ca191d3754ed3d
  Author: Sihui Liu 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html

  Log Message:
  ---
  [iOS] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=270143
rdar://116426402

Reviewed by Youenn Fablet.

The test flakily fails on bots with guard malloc enabled, so this patch adds 
more frames and invokes gc more times in
the test in order to increase the chance of frame being garbage collected, 
according to 224541@main.

* LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html:

Canonical link: https://commits.webkit.org/275449@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a3c23e: Adopt dynamicDowncast<> in GPUProcess and NetworkP...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3c23e4126f468c23a1787a0fa48c4f108e2dad6
  
https://github.com/WebKit/WebKit/commit/a3c23e4126f468c23a1787a0fa48c4f108e2dad6
  Author: Anne van Kesteren 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp

  Log Message:
  ---
  Adopt dynamicDowncast<> in GPUProcess and NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=270164

Reviewed by Chris Dumez.

For security & performance.

* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::drawSystemImage):
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::createAudioSourceProvider):
* Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp:
(WebKit::LocalStorageManager::hasDataInMemory const):
(WebKit::LocalStorageManager::clearDataInMemory):
(WebKit::LocalStorageManager::clearDataOnDisk):
(WebKit::LocalStorageManager::close):
(WebKit::LocalStorageManager::handleLowMemoryWarning):
(WebKit::LocalStorageManager::syncLocalStorage):
(WebKit::LocalStorageManager::connectToLocalStorageArea):
(WebKit::LocalStorageManager::connectToTransientLocalStorageArea):

Canonical link: https://commits.webkit.org/275448@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd792c: Adopt dynamicDowncast<> in WebKit/Shared

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd792cf72092af5479252d3203ffcf11fa1855ae
  
https://github.com/WebKit/WebKit/commit/fd792cf72092af5479252d3203ffcf11fa1855ae
  Author: Anne van Kesteren 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm
M 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebImage.cpp
M Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  Adopt dynamicDowncast<> in WebKit/Shared
https://bugs.webkit.org/show_bug.cgi?id=270216

Reviewed by Chris Dumez.

For security & performance.

* 
Source/WebKit/Shared/RemoteLayerTree/DynamicContentScalingBifurcatedImageBuffer.mm:
(WebKit::DynamicContentScalingBifurcatedImageBuffer::dynamicContentScalingDisplayList):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatile):
* 
Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithInProcessRenderingBackingStore.mm:
(WebKit::handleFromBuffer):
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):

Includes a drive-by fix to adopt is.

* Source/WebKit/Shared/WebImage.cpp:
(WebKit::WebImage::bitmap const):
(WebKit::WebImage::createHandle const):
* Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleByteRange.cpp:
(WebKit::MediaSampleByteRange::presentationSize const):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

This is a drive-by fix to adopt is. As
isOverTextInsideFormControlElement() already does its own null check on
innerNode() there's no need to do that twice.

Canonical link: https://commits.webkit.org/275447@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5592c3: [Navigation] Implement NavigationAPIMethodTracker

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5592c3df7e5002c0018419e8b8694341206ba7ad
  
https://github.com/WebKit/WebKit/commit/5592c3df7e5002c0018419e8b8694341206ba7ad
  Author: Patrick Griffis 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/Navigation.h

  Log Message:
  ---
  [Navigation] Implement NavigationAPIMethodTracker
https://bugs.webkit.org/show_bug.cgi?id=269930

Reviewed by Alex Christensen.

This creates a NavigationAPIMethodTracker struct per:
https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigation-api-method-tracker

As well as the maybeSetUpcomingNonTraversalTracker() method per:
https://html.spec.whatwg.org/multipage/nav-history-apis.html#maybe-set-the-upcoming-non-traverse-api-method-tracker

* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::serializeState):
(WebCore::Navigation::maybeSetUpcomingNonTraversalTracker):
(WebCore::Navigation::reload):
(WebCore::Navigation::navigate):
* Source/WebCore/page/Navigation.h:
(WebCore::NavigationAPIMethodTracker::create):
(WebCore::NavigationAPIMethodTracker::NavigationAPIMethodTracker):

Canonical link: https://commits.webkit.org/275446@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 801286: [CSS Container Queries][Style queries] Update styl...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 801286aa3dcb9720da3f98e6d25ce5e1ab5b79bb
  
https://github.com/WebKit/WebKit/commit/801286aa3dcb9720da3f98e6d25ce5e1ab5b79bb
  Author: Antti Koivisto 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change-expected.txt
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/style/RuleSet.cpp
M Source/WebCore/style/RuleSet.h
M Source/WebCore/style/StyleScopeRuleSets.cpp
M Source/WebCore/style/StyleScopeRuleSets.h
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/StyleTreeResolver.h

  Log Message:
  ---
  [CSS Container Queries][Style queries] Update style correctly for 
non-inherited custom property mutations
https://bugs.webkit.org/show_bug.cgi?id=270110
rdar://123645196

Reviewed by Alan Baradlay.

Mutating a custom property referenced in a style query needs to re-evaluate 
descendant styles or potential
style containers. This needs to happen also when the custom property is 
non-inherited.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change-expected.txt:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::customPropertyValueEqual const):

Add a helper.

* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::containerQueryRules const):
* Source/WebCore/style/RuleSet.h:
* Source/WebCore/style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::collectFeatures const):
(WebCore::Style::ScopeRuleSets::customPropertyNamesInStyleContainerQueries 
const):

Collect all the property names used in style queries.

* Source/WebCore/style/StyleScopeRuleSets.h:
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::computeDescendantsToResolve const):

Check if we have property dependent style queries and if so see if their value 
has changed.
If it has we need to re-resolve the descendants.

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::computeDescendantsToResolve): Deleted.
* Source/WebCore/style/StyleTreeResolver.h:

Canonical link: https://commits.webkit.org/275445@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0687b6: Factor out WEBKIT_{APPEND, PREPEND}_GLOBAL_{C, CXX}_...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0687b6d53df56a1b54cc5fe71323ba1b8fe64bbd
  
https://github.com/WebKit/WebKit/commit/0687b6d53df56a1b54cc5fe71323ba1b8fe64bbd
  Author: Adrian Perez de Castro 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/cmake/OptionsCommon.cmake
M Source/cmake/WebKitCompilerFlags.cmake

  Log Message:
  ---
  Factor out WEBKIT_{APPEND,PREPEND}_GLOBAL_{C,CXX}_COMPILER_FLAGS
https://bugs.webkit.org/show_bug.cgi?id=270220

Reviewed by Michael Catanzaro.

Add a new WEBKIT_VAR_ADD_COMPILER_FLAGS() CMake function which can
append, prepend, or set supported C or C++ compiler flags into a
variable. The macros that modify the global flag variables
(CMAKE_C_FLAGS and CMAKE_CXX_FLAGS) are rewritten in terms of the
new function.

For completeness, change one remaining use of check_cxx_compiler_flag()
so ultimately every compiler flag check goes through the
WEBKIT_CHECK_COMPILER_FLAGS() function, which ensures all the checks
go through the same point that ensures the check results get propery
cached.

* Source/cmake/OptionsCommon.cmake: Use WEBKIT_CHECK_COMPILER_FLAGS()
  instead of check_cxx_compiler_flag().
* Source/cmake/WebKitCompilerFlags.cmake: Refactor.

Canonical link: https://commits.webkit.org/275444@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dc7bb7: Safari unable to play YouTube content fast enough....

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc7bb79ca72bfc056244eb5d31e0d5844f8faa61
  
https://github.com/WebKit/WebKit/commit/dc7bb79ca72bfc056244eb5d31e0d5844f8faa61
  Author: Jean-Yves Avenard 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h
M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp

  Log Message:
  ---
  Safari unable to play YouTube content fast enough. Content window spins and 
plays only after 25-30 seconds
https://bugs.webkit.org/show_bug.cgi?id=270205
rdar://123528095

Reviewed by Eric Carlson.

Both MSE and MediaSourceRemote and RemoteMediaResourceLoader WorkQueue were 
created using QOS::Background priority.
Trace shows that when a task is being run on those WorkQueues, they are either 
being pre-empted or yielded and sometimes
it takes over 10s for a task to even complete.

We change the priority to the default, the same as what the IPC's WorkQueue is 
using.

* Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h:
* Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp:
(WebKit::MediaSourcePrivateRemote::queue):

Canonical link: https://commits.webkit.org/275443@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 86a7cc: The DigitalIdentity interface should be renamed Di...

[Marcos Cáceres]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86a7cc9223d3f1634215b1e48dac48b07407d79f
  
https://github.com/WebKit/WebKit/commit/86a7cc9223d3f1634215b1e48dac48b07407d79f
  Author: Marcos Caceres 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Modules/credentialmanagement/BasicCredential.cpp
M Source/WebCore/Modules/credentialmanagement/BasicCredential.h
M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp
M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h
A Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp
A Source/WebCore/Modules/credentialmanagement/DigitalCredential.h
A Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl
R Source/WebCore/Modules/credentialmanagement/DigitalIdentity.cpp
R Source/WebCore/Modules/credentialmanagement/DigitalIdentity.h
R Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSBasicCredentialCustom.cpp
M Source/WebCore/bindings/js/WebCoreBuiltinNames.h

  Log Message:
  ---
  The DigitalIdentity interface should be renamed DigitalCredential
https://bugs.webkit.org/show_bug.cgi?id=270197
rdar://123747961

Reviewed by Anne van Kesteren.

Renamed interface to reflect spec change:
https://github.com/WICG/digital-identities/pull/79/

* 
LayoutTests/http/wpt/credential-management/setDigitalIdentityEnable.https.html:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/credentialmanagement/BasicCredential.cpp:
(WebCore::BasicCredential::type const):
* Source/WebCore/Modules/credentialmanagement/BasicCredential.h:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp:
* Source/WebCore/Modules/credentialmanagement/CredentialsContainer.h:
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp: Renamed 
from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.cpp.
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.h: Renamed from 
Source/WebCore/Modules/credentialmanagement/DigitalIdentity.h.
* Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl: Renamed 
from Source/WebCore/Modules/credentialmanagement/DigitalIdentity.idl.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSBasicCredentialCustom.cpp:
(WebCore::toJSNewlyCreated):
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:

Canonical link: https://commits.webkit.org/275442@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1eceb0: [Skia] Implement VideoFrame::fromNativeImage

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1eceb04bb62bd87bd1ea725094111e06727a8790
  
https://github.com/WebKit/WebKit/commit/1eceb04bb62bd87bd1ea725094111e06727a8790
  Author: Carlos Garcia Campos 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

  Log Message:
  ---
  [Skia] Implement VideoFrame::fromNativeImage
https://bugs.webkit.org/show_bug.cgi?id=270217

Reviewed by Philippe Normand.

* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::VideoFrame::fromNativeImage):

Canonical link: https://commits.webkit.org/275441@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22d619: [ews] Disable buildbot-profiler

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22d619a9cd36f08eda8abfa49ccd9cdefb6da071
  
https://github.com/WebKit/WebKit/commit/22d619a9cd36f08eda8abfa49ccd9cdefb6da071
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build-webserver/master.cfg
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews] Disable buildbot-profiler
https://bugs.webkit.org/show_bug.cgi?id=270221

Unreviewed infrastructure maintenance.

Do not need it currently.

* Tools/CISupport/ews-build-webserver/master.cfg:
* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/275440@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 222378: View transition new captures apply the transform t...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22237898bafcf2f2a364d4a42c89215c27916af0
  
https://github.com/WebKit/WebKit/commit/22237898bafcf2f2a364d4a42c89215c27916af0
  Author: Matt Woodrow 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  ---
  View transition new captures apply the transform twice.
https://bugs.webkit.org/show_bug.cgi?id=270209


Reviewed by Tim Nguyen.

The transform is added to the ::view-transform-group element
as a generated style, so we need to clear it from the reparented
GraphicsLayer.

* LayoutTests/TestExpectations:
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):

Canonical link: https://commits.webkit.org/275439@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 44a5e9: Add logic to determine hasUAVisualTransition value

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a
  
https://github.com/WebKit/WebKit/commit/44a5e909d5d7fc8de0c7aa834670a5c5e1a3a33a
  Author: Rob Buis 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt
A LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/PopStateEvent.h
M Source/WebCore/page/Page.h
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  ---
  Add logic to determine hasUAVisualTransition value
https://bugs.webkit.org/show_bug.cgi?id=264748

Reviewed by Simon Fraser.

Add logic to determine hasUAVisualTransition value for PopStateEvent when 
swiping on navigation and add a test to verify this.

Rename FreezeLayerTreeDueToSwipeAnimation/UnfreezeLayerTreeDueToSwipeAnimation 
messages to the more generic
SwipeAnimationDidStart/swipeAnimationDidEnd, since now it needs to handle both 
layer tree freezing as well
as detecting the swipe on the Page for hasUAVisualTransition determination.

* LayoutTests/swipe/pushState-back-swipe-verify-ua-transition-expected.txt: 
Added.
* LayoutTests/swipe/pushState-back-swipe-verify-ua-transition.html: Added.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::dispatchPopstateEvent):
* Source/WebCore/dom/PopStateEvent.h:
* Source/WebCore/page/Page.h:
(WebCore::Page::setIsInSwipeAnimation):
(WebCore::Page::isInSwipeAnimation const):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::swipeAnimationDidEnd):
(WebKit::ProvisionalPageProxy::unfreezeLayerTreeDueToSwipeAnimation): Deleted.
* Source/WebKit/UIProcess/ProvisionalPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::navigationGestureWillEnd):
(WebKit::WebPageProxy::navigationGestureDidEnd):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::swipeAnimationDidStart):
(WebKit::WebPage::swipeAnimationDidEnd):
(WebKit::WebPage::freezeLayerTreeDueToSwipeAnimation): Deleted.
(WebKit::WebPage::unfreezeLayerTreeDueToSwipeAnimation): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/275438@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71de23: DigitalCredentialRequestOptions doesn't need an ab...

[Marcos Cáceres]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71de231b1df27e6a4fff8905938ad0f8a8ed767f
  
https://github.com/WebKit/WebKit/commit/71de231b1df27e6a4fff8905938ad0f8a8ed767f
  Author: Marcos Caceres 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M 
Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.h
M 
Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.idl

  Log Message:
  ---
  DigitalCredentialRequestOptions doesn't need an abort signal
https://bugs.webkit.org/show_bug.cgi?id=270212
rdar://123735008

Reviewed by Anne van Kesteren.

Removed signal member as per latest Digital Credentials spec.

* Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.h:
* 
Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.idl:

Canonical link: https://commits.webkit.org/275437@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f4ba33: Adopt dynamicDowncast<> in WebProcess

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4ba3301200f4e7388a3ec6c6a6e27a8db5c6690
  
https://github.com/WebKit/WebKit/commit/f4ba3301200f4e7388a3ec6c6a6e27a8db5c6690
  Author: Anne van Kesteren 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm
M 
Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp
M Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp
M Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm

  Log Message:
  ---
  Adopt dynamicDowncast<> in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=270166

Reviewed by Chris Dumez.

For performance & security.

* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::clearNativeImageMap):
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::cdmInstanceAttached):
(WebKit::MediaPlayerPrivateRemote::cdmInstanceDetached):
(WebKit::MediaPlayerPrivateRemote::attemptToDecryptWithInstance):
* Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::writeBuffer):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm:
(WebKit::PDFPluginBase::isFullFramePlugin const):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
(WebKit::PDFPluginPasswordField::handleEvent):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::handleEvent):
* 
Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmap):
* Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::showDataDetectorsUIForElement):

Canonical link: https://commits.webkit.org/275436@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2fd823: Fix Web Inspector: WI.ScopeBar.Event.SelectionChan...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fd8234498119dd0369e13d87c7d7512b6d785be
  
https://github.com/WebKit/WebKit/commit/2fd8234498119dd0369e13d87c7d7512b6d785be
  Author: Qianlang Chen 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/ScopeBar.js

  Log Message:
  ---
  Fix Web Inspector: WI.ScopeBar.Event.SelectionChanged is fired four times 
whenever selecting an item (242705)
https://bugs.webkit.org/show_bug.cgi?id=242705
rdar://96963052

Reviewed by Devin Rousso.

The bug report refers to an issue that happens with the components
ScopeBar and MultipleScopeBarItem, which is used across multiple
places in the inspector's frontend. This commit fixes the issue for both
components, such that the event `ScopeBar.Event.SelectionChanged` is
always only fired once, no matter whether MultipleScopeBarItem is
involved (like in the Sources tab) or not (like in the Console tab).

However, the solution to solving the bug for either component is
independent and different:
  - The class MultipleScopeBarItem already does well to suppress
multiple echos of the SelectionChanged event with the help of
`_ignoreItemSelectedEvent` (see 
https://github.com/WebKit/WebKit/blob/6d51d579af47028306a003653150ade5d395f942/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js#L211-L212)
However, in the original code, ScopeBar did not make use of this
benefit and still listens to SelectionChanged from the individual
items. When MultipleScopeBarItem is used, this commit makes ScopeBar
listen to MultipleScopeBarItem instead.
  - When MultipleScopeBarItem is not used, ScopeBar in the original code
did not do anything to protect against echos (i.e. events caused by
the ScopeBar itself as a result of deselecting its ScopeBarItems).
This commit mimics the fix from MultipleScopeBarItem and introduces
the same boolean flag to bypass echos caused by the ScopeBar itself.

* Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:
(WI.ScopeBar.prototype._populate):
  - Listen to SelectionChanged events from MultipleScopeBarItem instead
of the individual ScopeBarItems.
(WI.ScopeBar.prototype._itemSelectionDidChange):
  - Guard against echos by ignoring events caused by
`item.selected = ...` statements within the handler itself.
  - Rewrite the deselecting logic to be more readable.

Canonical link: https://commits.webkit.org/275435@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd09e2: REGRESSION (275173@main): [ MacOS wk2 Debug] webrt...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd09e2f7f97f13339f4e61c291d60308a42990e4
  
https://github.com/WebKit/WebKit/commit/cd09e2f7f97f13339f4e61c291d60308a42990e4
  Author: Youenn Fablet 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M 
Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.cc
M 
Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.h
M 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm

  Log Message:
  ---
  REGRESSION (275173@main): [ MacOS wk2 Debug] webrtc/h265.html is a constant 
timeout
rdar://123637394
https://bugs.webkit.org/show_bug.cgi?id=270096

Reviewed by Eric Carlson.

We were using the SPS sps_max_num_reorder_pics to compute the reorder window 
size.
But it appears from testing and from Chrome source code that we should instead 
use the VPS vps_max_num_reorder_pics.
We should probably get the VPS from PPS -> SPS -> VPS chain but for now, we use 
the first VPS available.

We add VPS parsing up to vps_max_num_reorder_pics.
We make use of it for computing the reorder window size for both HVCC and 
AnnexB cases.

Covered by LayoutTests/webrtc/h265.html and LayoutTests/http/tests/webcodecs/ 
HEVC tests.

* LayoutTests/platform/mac-wk2/TestExpectations:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.cc:
* Source/ThirdParty/libwebrtc/Source/webrtc/common_video/h265/h265_vps_parser.h:
* 
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm:
(vpsDataFromHvcc):
(ComputeH265ReorderSizeFromVPS):
(ComputeH265ReorderSizeFromHVCC):
(ComputeH265ReorderSizeFromAnnexB):
(spsDataFromHvcc): Deleted.
(ComputeH265ReorderSizeFromSPS): Deleted.

Canonical link: https://commits.webkit.org/275434@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d4af38: [JSC] Stress tests have bogus asserts due to incor...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4af38db11471f70862112152e92ffed9443
  
https://github.com/WebKit/WebKit/commit/d4af38db11471f70862112152e92ffed9443
  Author: Alexey Shvayka 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M JSTests/ChakraCore/test/Array/array_splice.js
M JSTests/ChakraCore/test/Array/array_splice_double.js
M JSTests/stress/dfg-get-private-name-by-id-generic.js
M JSTests/stress/dfg-get-private-name-by-id-osr-bad-identifier.js
M JSTests/stress/dfg-get-private-name-by-offset-osr-bad-identifier.js
M JSTests/stress/dfg-get-private-name-by-offset-osr-bad-structure.js
M JSTests/stress/dfg-get-private-name-by-val-generic.js
M JSTests/stress/dfg-put-private-name-check-barrier-insertion.js
M JSTests/stress/dfg-put-private-name-compiled-as-put-by-id-direct.js
M JSTests/stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js
M JSTests/stress/get-private-name-with-primitive.js
M JSTests/stress/invalidate-array-iterator-prototype-next.js
M JSTests/stress/private-method-and-field-named-constructor.js
M JSTests/stress/private-method-check-structure-miss.js
M JSTests/stress/private-method-invalid-multiple-brand-installation.js
M JSTests/stress/private-method-invalidate-compiled-with-constant-symbol.js
M JSTests/stress/private-method-polymorphic-with-constant-symbol.js
M JSTests/stress/private-method-untyped-use.js
M 
JSTests/stress/put-private-name-by-id-set-do-not-add-structure-trasition.js
M JSTests/stress/put-private-name-invalid-define.js
M JSTests/stress/put-private-name-invalid-store.js
M 
JSTests/stress/put-private-name-invalidate-compiled-with-constant-symbol.js
M JSTests/stress/put-private-name-untyped-use.js
M JSTests/stress/put-private-name-with-primitive.js
M JSTests/stress/regexp-with-runtime-syntax-errors.js
M JSTests/stress/spread-calling.js

  Log Message:
  ---
  [JSC] Stress tests have bogus asserts due to incorrectly negating 
`instanceof` operator
https://bugs.webkit.org/show_bug.cgi?id=261815


Reviewed by Mark Lam.

Relational operators in JavaScript, including `instanceof`, have lower 
precedence than
logical negation, meaning `!err instanceof TypeError` evaluates as `false 
instanceof TypeError`
if `err` is an object.

This change fixes asserts in our tests to actually validate error constructors, 
which exposed
that one test had wrong expectation of `TypeError` instead of `ReferenceError`: 
JSC, V8, and
SpiderMonkey all throw `ReferenceError` for that code.

* JSTests/ChakraCore/test/Array/array_splice.js:
* JSTests/ChakraCore/test/Array/array_splice_double.js:
* JSTests/stress/dfg-get-private-name-by-id-generic.js:
* JSTests/stress/dfg-get-private-name-by-id-osr-bad-identifier.js:
* JSTests/stress/dfg-get-private-name-by-offset-osr-bad-identifier.js:
* JSTests/stress/dfg-get-private-name-by-offset-osr-bad-structure.js:
* JSTests/stress/dfg-get-private-name-by-val-generic.js:
* JSTests/stress/dfg-put-private-name-check-barrier-insertion.js:
* JSTests/stress/dfg-put-private-name-compiled-as-put-by-id-direct.js:
* JSTests/stress/dfg-put-private-name-compiled-as-put-private-name-by-id.js:
* JSTests/stress/get-private-name-with-primitive.js:
* JSTests/stress/invalidate-array-iterator-prototype-next.js:
* JSTests/stress/private-method-and-field-named-constructor.js:
* JSTests/stress/private-method-check-structure-miss.js:
* JSTests/stress/private-method-invalid-multiple-brand-installation.js:
* JSTests/stress/private-method-invalidate-compiled-with-constant-symbol.js:
* JSTests/stress/private-method-polymorphic-with-constant-symbol.js:
* JSTests/stress/private-method-untyped-use.js:
* JSTests/stress/put-private-name-by-id-set-do-not-add-structure-trasition.js:
* JSTests/stress/put-private-name-invalid-define.js:
* JSTests/stress/put-private-name-invalid-store.js:
* JSTests/stress/put-private-name-invalidate-compiled-with-constant-symbol.js:
* JSTests/stress/put-private-name-untyped-use.js:
* JSTests/stress/put-private-name-with-primitive.js:
* JSTests/stress/regexp-with-runtime-syntax-errors.js:
* JSTests/stress/spread-calling.js:

Canonical link: https://commits.webkit.org/275433@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 832bcc: [Skia] Make sure the Skia GL context is current wh...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 832bcc5229f97a3f10f2387c9b9da94723ce9834
  
https://github.com/WebKit/WebKit/commit/832bcc5229f97a3f10f2387c9b9da94723ce9834
  Author: Carlos Garcia Campos 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h
M 
Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp
M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp
M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h
M 
Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp
M Source/WebCore/platform/graphics/skia/PathSkia.cpp
M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp
M 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp

  Log Message:
  ---
  [Skia] Make sure the Skia GL context is current when calling SkCanvas draw 
operations for 2D canvas
https://bugs.webkit.org/show_bug.cgi?id=269984

Reviewed by Nikolas Zimmermann.

When rendering layer contents, we make the Skia GL context current
before rendering the layer contents and it remains current, but in the
case of 2D canvas, we can't make sure the context is current when the
draw operations are called. This is causing rendering issues in some
cases that only happen with the GL renderer. This patch adds RenderingMode
and RenderingPurpose parameters to GraphicsContextSkia, and a helper
function makeGLContextCurrentIfNeeded() that makes the Skia GL context
current when the RenderingMode is Accelerated and RenderingPurpose is Canvas.

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::GraphicsContextSkia):
(WebCore::GraphicsContextSkia::makeGLContextCurrentIfNeeded):
(WebCore::GraphicsContextSkia::drawRect):
(WebCore::GraphicsContextSkia::drawNativeImageInternal):
(WebCore::GraphicsContextSkia::drawLine):
(WebCore::GraphicsContextSkia::drawEllipse):
(WebCore::GraphicsContextSkia::fillPath):
(WebCore::GraphicsContextSkia::strokePath):
(WebCore::GraphicsContextSkia::fillRect):
(WebCore::GraphicsContextSkia::beginTransparencyLayer):
(WebCore::GraphicsContextSkia::endTransparencyLayer):
(WebCore::GraphicsContextSkia::clearRect):
(WebCore::GraphicsContextSkia::strokeRect):
(WebCore::GraphicsContextSkia::fillRoundedRectImpl):
(WebCore::GraphicsContextSkia::fillRectWithRoundedHole):
(WebCore::GraphicsContextSkia::drawPattern):
(WebCore::GraphicsContextSkia::renderingMode const): Deleted.
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h:
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp:
(WebCore::ImageBufferSkiaAcceleratedBackend::ImageBufferSkiaAcceleratedBackend):
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp:
(WebCore::ImageBufferSkiaSurfaceBackend::ImageBufferSkiaSurfaceBackend):
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h:
* Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp:
(WebCore::ImageBufferSkiaUnacceleratedBackend::ImageBufferSkiaUnacceleratedBackend):
* Source/WebCore/platform/graphics/skia/PathSkia.cpp:
(WebCore::PathSkia::strokeContains const):
(WebCore::PathSkia::strokeBoundingRect const):
* Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp:
(WebCore::ShareableBitmap::createGraphicsContext):
* 
Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
(WebCore::CoordinatedGraphicsLayer::paintTile):
(WebCore::CoordinatedGraphicsLayer::paintImage):

Canonical link: https://commits.webkit.org/275432@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ee1d49: [WebGPU] copyToDestinationFormat copies too many b...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee1d490ee70c84af0993d2420bb77088c760a0b2
  
https://github.com/WebKit/WebKit/commit/ee1d490ee70c84af0993d2420bb77088c760a0b2
  Author: Mike Wyrzykowski 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp

  Log Message:
  ---
  [WebGPU] copyToDestinationFormat copies too many bytes for Rg32float
https://bugs.webkit.org/show_bug.cgi?id=270203


Reviewed by Dan Glastonbury.

This code will go away when https://bugs.webkit.org/show_bug.cgi?id=263692 is
implemented but for now fix the out of bounds access which was caught
by ASAN.

* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::copyToDestinationFormat):

Canonical link: https://commits.webkit.org/275431@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes