[webkit-changes] [WebKit/WebKit] 3451ab: Unreviewed, reverting 275690@main and 275706@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3451abb11ae972d02bb8cf6490d6404a2a62bc70 https://github.com/WebKit/WebKit/commit/3451abb11ae972d02bb8cf6490d6404a2a62bc70 Author: Commit Queue Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/__init__.py M Tools/Scripts/webkitpy/api_tests/manager.py M Tools/Scripts/webkitpy/autoinstalled/buildbot.py M Tools/Scripts/webkitpy/autoinstalled/twisted.py M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py M Tools/Scripts/webkitpy/common/checkout/__init__.py M Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/__init__.py M Tools/Scripts/webkitpy/common/checkout/scm/git.py M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/svn.py M Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py M Tools/Scripts/webkitpy/common/net/bugzilla/bug.py M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py M Tools/Scripts/webkitpy/common/net/buildbot/__init__.py M Tools/Scripts/webkitpy/common/net/credentials_unittest.py M Tools/Scripts/webkitpy/common/net/file_uploader.py M Tools/Scripts/webkitpy/common/net/resultsjsonparser.py M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py M Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py M Tools/Scripts/webkitpy/common/system/logutils_unittest.py M Tools/Scripts/webkitpy/common/system/path.py M Tools/Scripts/webkitpy/common/system/path_unittest.py M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py M Tools/Scripts/webkitpy/common/system/systemhost.py M Tools/Scripts/webkitpy/common/system/user.py M Tools/Scripts/webkitpy/common/system/user_mock.py M Tools/Scripts/webkitpy/featuredefines/search.py M Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py M Tools/Scripts/webkitpy/layout_tests/servers/websocket_server_unittest.py M Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py M Tools/Scripts/webkitpy/port/__init__.py M Tools/Scripts/webkitpy/port/factory.py M Tools/Scripts/webkitpy/port/gtk_unittest.py M Tools/Scripts/webkitpy/port/headlessdriver.py M Tools/Scripts/webkitpy/port/ios_simulator_unittest.py M Tools/Scripts/webkitpy/port/mac_unittest.py M Tools/Scripts/webkitpy/port/port_testcase.py M Tools/Scripts/webkitpy/port/server_process.py M Tools/Scripts/webkitpy/port/simulator_process.py M Tools/Scripts/webkitpy/port/visionos_simulator_unittest.py M Tools/Scripts/webkitpy/port/watch_simulator_unittest.py M Tools/Scripts/webkitpy/port/westondriver.py M Tools/Scripts/webkitpy/port/westondriver_unittest.py M Tools/Scripts/webkitpy/port/win.py M Tools/Scripts/webkitpy/port/win_unittest.py M Tools/Scripts/webkitpy/port/wpe_unittest.py M Tools/Scripts/webkitpy/port/xvfbdriver.py M Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py M Tools/Scripts/webkitpy/static_analysis/results_unittest.py M Tools/Scripts/webkitpy/style/checker_unittest.py M Tools/Scripts/webkitpy/style/checkers/contributors.py M Tools/Scripts/webkitpy/style/checkers/featuredefines.py M Tools/Scripts/webkitpy/style/checkers/png.py M Tools/Scripts/webkitpy/style/checkers/xcscheme.py M Tools/Scripts/webkitpy/style/error_handlers.py M Tools/Scripts/webkitpy/style/error_handlers_unittest.py M Tools/Scripts/webkitpy/style/filereader.py M Tools/Scripts/webkitpy/test/main.py M Tools/Scripts/webkitpy/test/runner.py M Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py M Tools/Scripts/webkitpy/tool/steps/__init__.py M Tools/Scripts/webkitpy/w3c/test_converter.py M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py M Tools/Scripts/webkitpy/w3c/test_downloader.py M Tools/Scripts/webkitpy/w3c/test_importer.py M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py M Tools/Scripts/webkitpy/w3c/wpt_github.py M Tools/Scripts/webkitpy/w3c/wpt_github_mock.py M Tools/Script
[webkit-changes] [WebKit/WebKit] 503f7e: Add additional WKWebView SPI to extract rendered t...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 503f7e1ff8cef2d718e4dfa3612e1d9907d81e67
https://github.com/WebKit/WebKit/commit/503f7e1ff8cef2d718e4dfa3612e1d9907d81e67
Author: Wenson Hsieh
Date: 2024-03-05 (Tue, 05 Mar 2024)
Changed paths:
A
LayoutTests/fast/text-extraction/extract-rendered-text-with-subframe-expected.txt
A LayoutTests/fast/text-extraction/extract-rendered-text-with-subframe.html
A LayoutTests/fast/text-extraction/resources/subframe.html
M LayoutTests/resources/ui-helper.js
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebCore/page/text-extraction/TextExtraction.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm
Log Message:
---
Add additional WKWebView SPI to extract rendered text for a given CSS
selector in the main frame
https://bugs.webkit.org/show_bug.cgi?id=270544
Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.
Add another `WKWebView` SPI method to extract rendered text from an element in
the main frame, given
a CSS selector. This flattens all text content in the element subtree
(including subframes) into a
single string, sorted in block layout direction order by the root view bounds
of each rendered text
node.
Test: fast/text-extraction/extract-rendered-text-with-subframe.html
*
LayoutTests/fast/text-extraction/extract-rendered-text-with-subframe-expected.txt:
Added.
* LayoutTests/fast/text-extraction/extract-rendered-text-with-subframe.html:
Added.
Add a layout test to exercise this SPI.
* LayoutTests/fast/text-extraction/resources/subframe.html: Added.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.requestTextExtraction):
(window.UIHelper.requestRenderedTextForSelector):
Add a testing hook to exercise the new SPI from layout tests.
(window.UIHelper):
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractRenderedText):
Implement the main logic here, by recursively traversing through the render
tree to accumulate text
in a `Vector` of offsets (based on block writing direction — e.g. y-offsets, in
top-down LTR text)
and strings, filtered to only contain letters (including non-Latin script) and
numbers. We also
represent replaced renderers with `{w,h}`, representing the size of the
renderer in root view
coordinates.
The final output is a space-separated string of extracted tokens.
* Source/WebCore/page/text-extraction/TextExtraction.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestRenderedTextForElementSelector:completionHandler:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestTextExtraction):
(WebKit::WebPageProxy::requestRenderedTextForElementSelector):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestRenderedTextForElementSelector):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::requestRenderedTextForSelector):
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
* Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
(WTR::UIScriptControllerCocoa::requestRenderedTextForSelector):
Canonical link: https://commits.webkit.org/275728@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d583f1: [Unified PDF] Form control partial repaint for "re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d583f18ce8eded8a598b3aafd181c9f1864fd3f6 https://github.com/WebKit/WebKit/commit/d583f18ce8eded8a598b3aafd181c9f1864fd3f6 Author: Sammy Gill Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [Unified PDF] Form control partial repaint for "related" fields is broken, results in fields getting stuck. https://bugs.webkit.org/show_bug.cgi?id=270539 rdar://123637341 Reviewed by Abrar Rahman Protyasha and Tim Horton. In order to avoid repainting the world we attempt to perform very targeted repaints. For annotations this generally means we need to find the bounds for the annotation and provide the geometry of the area to the async renderer to that it can repaint the affected area. However, certain annotations may also have an effect on a set of related annotations. For example, when interacting with radio buttons in the same group we want to make sure that not only is the newly selected radio button displayed as active but also that the previously selected one is no longer active. For these annotations we want to make sure that those get repainted as well in order to properly display the state changes. Since we already have an observer that listens for form field changes that are sent by the document, we can use the same notification to tell the plugin of the field that changed and get the geometry of the annotations. We can take the field name given by the observer and ask the document for all of the annotations associated with this field name through IPI. In order for the repainting to happen correctly we had to slightly change how the async renderer handled requests for tile repaints. Previously, it would check to see if a repaint request for a particular tile had already been enqueued and drop the current request if it had. This approach was too conservative since multiple annotations may need to get repainted within a tile and observer gets notified of multiple fields independently (e.g. a button action that resets form fields sends a separate notification for each field in the form). Now the async observer will drop the request if: 1.) There is not a clip rect provided for the request (to match current behavior) 2.) The tile rect clip for the repaint request is already contained completely within the tile rect clip for the enqueued tile update If a repaint request comes in for the same tile but it is not being handled by an enqueued tile update then we will take the existing update's tile rect, combine it with the rect in the new request, and update the enqueued tile update. As we complete the tile update we will check to see if the area that was repainted is the same as the one that was enqueued. If it is not this means that the tile update was updated with a new rect so we do not proceed to cache the tile. * Source/WebKit/Platform/spi/Cocoa/PDFKitSPI.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::didCompleteTileUpdateRender): (WebKit::AsyncPDFRenderer::updateTilesForPaintingRect): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (-[WKPDFFormMutationObserver formChanged:]): (WebKit::UnifiedPDFPlugin::repaintAnnotationsForFormField): Canonical link: https://commits.webkit.org/275727@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f7604: [iOS] Avoid transcoding images on file inputs unle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f76043f78527099a8af73cff7e76c489fd79568 https://github.com/WebKit/WebKit/commit/0f76043f78527099a8af73cff7e76c489fd79568 Author: Aditya Keerthi Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm Log Message: --- [iOS] Avoid transcoding images on file inputs unless the set of image types is explicitly restricted https://bugs.webkit.org/show_bug.cgi?id=267277 rdar://106763672 Reviewed by Abrar Rahman Protyasha. On iOS, when using an `` that supports images or videos, the user has the option to select content from their photo library. Historically, in WebKit, selected content has always been transcoded to JPEG (for images) and H.264 (for video). However, this can be undesirable for users that want to provide the image in its original form. In particular, this is important for photo editing applications. Furthermore, macOS does not have this general transcoding behavior. This patch changes the behavior on iOS so that transcoding to the compatible format for images is only performed if the `accept` attribute restricts the set of image types. Videos remain exempted from this behavior change due to known compatibility issues. Note that this change does have non-zero compatibility risk. However, it is more correct, and resolves known issues on image editing applications. Sites that want a compatibile representation are expected to use the `accept` attribute to indicate their need. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Introduce a setting so the new behavior can easily be toggled off for testing. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView fileUploadPanelPhotoPickerPrefersOriginalImageFormat:]): * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h: * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _preferredAssetRepresentationMode]): Disable transcoding by the picker if the set of restricted types is empty, or contains all image types. (-[WKFileUploadPanel _showPhotoPicker]): (-[WKFileUploadPanel picker:didFinishPicking:]): Continue to transcode video, when the picker does not perform transcoding, for compatibility. Canonical link: https://commits.webkit.org/275726@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a4b87: Render tags in Model process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a4b871eeecd5ca8e2001f76f417c739209a8c4f https://github.com/WebKit/WebKit/commit/8a4b871eeecd5ca8e2001f76f417c739209a8c4f Author: Eddy Wong Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Model.sb.in M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Render tags in Model process rdar://124051126 https://bugs.webkit.org/show_bug.cgi?id=270504 Reviewed by Tim Horton. Model process rendering path now uses the same WKSeparatedModelLayer class as the in-process path to actually render the 3D model. Also added required entitlement and sandbox rules to support rendering in Model process. * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm: (WebKit::ModelProcessModelPlayerProxy::createLayer): (WebKit::ModelProcessModelPlayerProxy::loadModel): * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Model.sb.in: * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/275725@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e936ac: NEW TEST [ iOS Debug ] TestWebKitAPI.Fullscreen.Re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e936ac78d2812779552425a8e777618a407d9364 https://github.com/WebKit/WebKit/commit/e936ac78d2812779552425a8e777618a407d9364 Author: Aditya Keerthi Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm Log Message: --- NEW TEST [ iOS Debug ] TestWebKitAPI.Fullscreen.ResizeEventOrder is a constant crash https://bugs.webkit.org/show_bug.cgi?id=270527 rdar://124078618 Reviewed by Tim Horton. Remove incorrect assertions. In WebKit, `_minimumUnobscuredSizeOverride` and `_maximumUnobscuredSizeOverride` are only read in fullscreen code, and the values are unused, unless `_hasOverriddenLayoutParameters` is also true. Furthermore, SPI clients are free to use these methods as they wish, in which case the lack of overridden layout parameters is already gracefully handled. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _minimumLayoutSizeOverride]): (-[WKWebView _minimumUnobscuredSizeOverride]): (-[WKWebView _maximumUnobscuredSizeOverride]): Canonical link: https://commits.webkit.org/275724@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45c65b: Always use process launch fallback for Simulator o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45c65b492d2e9e881fcf0149ff141fe157f4a69d https://github.com/WebKit/WebKit/commit/45c65b492d2e9e881fcf0149ff141fe157f4a69d Author: Per Arne Vollan Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm Log Message: --- Always use process launch fallback for Simulator on older OS versions https://bugs.webkit.org/show_bug.cgi?id=270518 rdar://124070357 Reviewed by Chris Dumez and Brady Eidson. For performance reasons, there is no need to try the main process launch path on Simulator for older OS versions, since it will fail in that case. * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::launchWithExtensionKit): Canonical link: https://commits.webkit.org/275723@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 978f83: REGRESSION: [Ventura] http/tests/workers/service/s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 978f836eb161e5935c773e7ecaa2c76ac59b0ec2 https://github.com/WebKit/WebKit/commit/978f836eb161e5935c773e7ecaa2c76ac59b0ec2 Author: Chris Dumez Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- REGRESSION: [Ventura] http/tests/workers/service/shownotification-allowed.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=253343 rdar://106210992 Unreviewed, unskip the test as it no longer appears to be flaky. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275722@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 540d08: [JSC] Use handler IC for single stateless AccessCase
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 540d08d37e29127fa5eeefa78d2b849561771fe8 https://github.com/WebKit/WebKit/commit/540d08d37e29127fa5eeefa78d2b849561771fe8 Author: Yusuke Suzuki Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/AccessCase.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h M Source/JavaScriptCore/jit/JITPropertyAccess.cpp Log Message: --- [JSC] Use handler IC for single stateless AccessCase https://bugs.webkit.org/show_bug.cgi?id=270497 rdar://124047629 Reviewed by Keith Miller. This patch enables Handler IC only for very specific case: single stateless AccessCase. For example, ArrayLength, IndexedContiguousLoad etc. does not care about Structure. They only care about the input's type. So the underlying code can be reused in different places completely. And if AccessCase is only one, the generated code can be reused in various places. And surprisingly this is relatively frequently happening. 1. This patch categorizes stateless AccessCases. They do not require Structure etc. state of the heap. 2. We clean up InlineCacheCompiler implementation about accessing to StructureStubInfo* to figure out what is the values changing the generated code from StructureStubInfo. 3. We clean up InlineCacheCompiler's information collection code from vector of AccessCase so that we can easily see what information is collected. 4. We extend SharedJITStubSet to store stateless stubs. Previously it was only storing megamorphic stubs since they are stateless. But now it gets extended to accept all stateless stubs. * Source/JavaScriptCore/bytecode/AccessCase.h: * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::isStateless): (JSC::InlineCacheCompiler::regenerate): (WTF::printInternal): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: * Source/JavaScriptCore/bytecode/StructureStubInfo.cpp: (JSC::SharedJITStubSet::getStatelessStub const): (JSC::SharedJITStubSet::setStatelessStub): (JSC::SharedJITStubSet::getMegamorphic const): Deleted. (JSC::SharedJITStubSet::setMegamorphic): Deleted. * Source/JavaScriptCore/bytecode/StructureStubInfo.h: Canonical link: https://commits.webkit.org/275721@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e323dc: Add ability to settle a NativePromise with a funct...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e323dca2b77f79cb09bfc9f457f721deac22c845 https://github.com/WebKit/WebKit/commit/e323dca2b77f79cb09bfc9f457f721deac22c845 Author: Jean-Yves Avenard Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WTF/wtf/NativePromise.h M Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp Log Message: --- Add ability to settle a NativePromise with a function which will be run on the dispatcher given to then/whenSettled https://bugs.webkit.org/show_bug.cgi?id=270282 rdar://123830373 Reviewed by Youenn Fablet. We add a settleWithFunction method to NativePromiseProducer. For convenience, you can also pass the Function to settle(). The function provided will be run for in listener's dispatcher and the result be then passed to the callback. Fly-by: Make accessing the promise's result more explicit (such as when is the result accessed by reference or being moved) Added API tests. * Source/WTF/wtf/NativePromise.h: * Tools/TestWebKitAPI/Tests/WTF/NativePromise.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275720@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 145e1e: Proof-read German translation update
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 145e1ec015f35b23540936f1695bbad97ce3b77d https://github.com/WebKit/WebKit/commit/145e1ec015f35b23540936f1695bbad97ce3b77d Author: Michael Catanzaro Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/platform/gtk/po/de.po Log Message: --- Proof-read German translation update https://bugs.webkit.org/show_bug.cgi?id=270542 Unreviewed translation update. * Source/WebCore/platform/gtk/po/de.po: Canonical link: https://commits.webkit.org/275719@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bc323: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1bc32353d4bac8f73924c2ba528cd9feb42cf334 https://github.com/WebKit/WebKit/commit/1bc32353d4bac8f73924c2ba528cd9feb42cf334 Author: Karl Rackler Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: R LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-actual.txt R LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt R LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-actual.txt Log Message: --- [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ] Three compositing/repaint/iframes/compositing-iframe tests are consistent failures https://bugs.webkit.org/show_bug.cgi?id=262340 rdar://116206941 Unreviewed test gardening. Remove actual that were replaced with expected files. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-actual.txt: Removed. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt: Removed. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-actual.txt: Removed. Canonical link: https://commits.webkit.org/275718@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f4af1f: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f4af1f9d733005c2bb212d5d17bba648fbd3200a https://github.com/WebKit/WebKit/commit/f4af1f9d733005c2bb212d5d17bba648fbd3200a Author: Karl Rackler Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt M LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt M LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt Log Message: --- [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ] Three compositing/repaint/iframes/compositing-iframe tests are consistent failures https://bugs.webkit.org/show_bug.cgi?id=262340 rdar://116206941 Unreviewed test gardening. Rename rebaseline expected files. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt: * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt: * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-expected.txt: Canonical link: https://commits.webkit.org/275717@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c90c0b: ASSERTION FAILED: Unhandled message WebExtensionCo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c90c0bf192dde554a4fa459549851f7603e4b11f https://github.com/WebKit/WebKit/commit/c90c0bf192dde554a4fa459549851f7603e4b11f Author: Timothy Hatcher Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h Log Message: --- ASSERTION FAILED: Unhandled message WebExtensionController_DidStartProvisionalLoadForFrame to 17. https://webkit.org/b/270543 rdar://124098768 Reviewed by Brady Eidson. Return early for these messages if there are no extension contexts. * Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionControllerProxyCocoa.mm: (WebKit::WebExtensionControllerProxy::didStartProvisionalLoadForFrame): (WebKit::WebExtensionControllerProxy::didCommitLoadForFrame): (WebKit::WebExtensionControllerProxy::didFinishLoadForFrame): (WebKit::WebExtensionControllerProxy::didFailLoadForFrame): * Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h: Canonical link: https://commits.webkit.org/275716@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 970353: [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 970353585dec7e4b8eb1e53e70e318d0d6a1bb1a https://github.com/WebKit/WebKit/commit/970353585dec7e4b8eb1e53e70e318d0d6a1bb1a Author: Karl Rackler Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations A LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-actual.txt A LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt A LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-actual.txt Log Message: --- [Gardening]: REGRESSION ( Sonoma?): [ Sonoma wk1 ] Three compositing/repaint/iframes/compositing-iframe tests are consistent failures https://bugs.webkit.org/show_bug.cgi?id=262340 rdar://116206941 Unreviewed test gardening. Removing test expectation. Rebaseline tests. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-actual.txt: Added. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-scroll-repaint-actual.txt: Added. * LayoutTests/platform/mac-wk1/compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint-actual.txt: Added. Canonical link: https://commits.webkit.org/275715@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e176fe: build-and-collect-pgo-profiles script should be up...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e176fe28ba1e968d28c125454ef137234ffdf238 https://github.com/WebKit/WebKit/commit/e176fe28ba1e968d28c125454ef137234ffdf238 Author: Hysu Xiong Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/build-and-collect-pgo-profiles Log Message: --- build-and-collect-pgo-profiles script should be updated to use run-benchmarks' built-in HTTP server by default https://bugs.webkit.org/show_bug.cgi?id=270530 rdar://124083240 Reviewed by Stephanie Lewis and Dewei Zhu. Update build-and-collect-pgo-profiles script to use run-benchmarks' built-in HTTP server mode. This helps reduce our dependency on Twisted. * Tools/Scripts/build-and-collect-pgo-profiles: Canonical link: https://commits.webkit.org/275714@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8b8f9: [ Sonoma+ WK1 ] 2X imported/w3c/web-platform-tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8b8f96af30ce6909fc2f7ece6c5575072463b7f https://github.com/WebKit/WebKit/commit/f8b8f96af30ce6909fc2f7ece6c5575072463b7f Author: Abrar Rahman Protyasha Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [ Sonoma+ WK1 ] 2X imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive test are constant failures https://bugs.webkit.org/show_bug.cgi?id=270326 rdar://123867011 Unreviewed test expectation adjustment. The two tests... imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-wheel-event-listener-on-div.html imported/w3c/web-platform-tests/dom/events/non-cancelable-when-passive/passive-mousewheel-event-listener-on-div.html ... have been consistently timing out on WK1 (not only Sonoma+), and they should have been skipped as part of the test expectation adjustment following webkit.org/b/263441. This patch makes that correction. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275713@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2bcded: Unified PDF: HUD zoom buttons don't work on embedd...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2bcded219334d8aa6965b3ccb3ce6c52282f3732 https://github.com/WebKit/WebKit/commit/2bcded219334d8aa6965b3ccb3ce6c52282f3732 Author: Tim Horton Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h Log Message: --- Unified PDF: HUD zoom buttons don't work on embedded pdfs https://bugs.webkit.org/show_bug.cgi?id=270536 rdar://122034458 Reviewed by Abrar Rahman Protyasha. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: Document the scale factors. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::ensureLayers): Always apply the "page scale" (which is actually determined by us, not the page) to the root layer, even for embedded plugins. (WebKit::UnifiedPDFPlugin::setScaleFactor): (WebKit::UnifiedPDFPlugin::performContextMenuAction): (WebKit::UnifiedPDFPlugin::zoomIn): (WebKit::UnifiedPDFPlugin::zoomOut): (WebKit::UnifiedPDFPlugin::resetZoom): (WebKit::UnifiedPDFPlugin::updateLayout): Factor setScaleFactor (for the UnifiedPDF-owned scale) out, and adopt it internally. (WebKit::UnifiedPDFPlugin::setPageScaleFactor): For actual page scale changes, bail if we are an embedded plugin. We don't want the PDF content to follow page scale changes for embeds, only for the main frame, where page scale and UnifiedPDF-scale are synchronized. * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::setPageScaleFactor): (WebKit::PluginView::pluginScaleFactorDidChange): Factor pluginScaleFactorDidChange out of setPageScaleFactor so that we can call it from setScaleFactor in UnifiedPDFPlugin instead of having to round-trip through PluginView::setPageScaleFactor, which allows us to correctly identify UnifiedPDFPlugin-originated scales vs. changes to the main frame page scale. * Source/WebKit/WebProcess/Plugins/PluginView.h: Canonical link: https://commits.webkit.org/275712@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0e1cd: [WebAuthn] Navigator matches excludedCredentials f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0e1cd6ea54e260139397056ccc5cf2f199aa7f0 https://github.com/WebKit/WebKit/commit/c0e1cd6ea54e260139397056ccc5cf2f199aa7f0 Author: Pascoe Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm Log Message: --- [WebAuthn] Navigator matches excludedCredentials for deleted passkeys in 30 day grace period https://bugs.webkit.org/show_bug.cgi?id=264097 rdar://118182303 Reviewed by Charlie Wolfe. In order to avoid matching recently deleted passkeys in the local authenticator, we match only against the group "com.apple.webkit.webauthn." This works because recently deleted passkeys are moved to another group, "com.apple.webkit.webauthn-recently-deleted." * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::getExistingCredentials): Canonical link: https://commits.webkit.org/275711@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e896e: AX: AXPropertyName::{ColumnIndexRange, RowIndexRan...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6e896e7e4003b348fe2ec155f70b986d057d099d
https://github.com/WebKit/WebKit/commit/6e896e7e4003b348fe2ec155f70b986d057d099d
Author: Tyler Wilcock
Date: 2024-03-05 (Tue, 05 Mar 2024)
Changed paths:
A LayoutTests/accessibility/dynamic-aria-hidden-cell-expected.txt
A LayoutTests/accessibility/dynamic-aria-hidden-cell.html
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityTable.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
Log Message:
---
AX: AXPropertyName::{ColumnIndexRange, RowIndexRange} properties are never
updated
https://bugs.webkit.org/show_bug.cgi?id=270496
rdar://problem/124046227
Reviewed by Chris Fleizach.
This can cause ATs to miss table content if they use the rowIndexRange and
columnIndexRange APIs
as inputs to the cellForColumnAndRow API. Fix this by posting a notification
when table cells
modify their row / column index.
This patch also adds a new postNotification overload to avoid unnecessary
null-checking and verbosity
of passing a hardcoded `nullptr Document*` argument to
postNotification(AccessibilityObject*, Document*, AXNotification, PostTarget =
PostTarget::Element).
Existing notifications AXColumnIndexChanged and AXRowIndexChanged are
repurposed to report this dynamic change,
and two new notifications (AXARIAColumnIndexChanged and AXARIARowIndexChanged)
are added to support what the former
two notifications used to do (as they were only fired when aria-colindex and
aria-rowindex changed).
* LayoutTests/accessibility/dynamic-aria-hidden-cell-expected.txt: Added.
* LayoutTests/accessibility/dynamic-aria-hidden-cell.html: Added.
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::valueChanged):
(WebCore::AXObjectCache::columnIndexChanged):
(WebCore::AXObjectCache::rowIndexChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::onTextSecurityChanged):
(WebCore::AXObjectCache::onTitleChange):
(WebCore::AXObjectCache::onValidityChange):
(WebCore::AXObjectCache::handleRoleChanged):
Take a reference rather than a pointer as all callsites have access to a
reference.
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
(WebCore::AXObjectCache::selectedTextRangeTimerFired):
(WebCore::AXObjectCache::onWidgetVisibilityChanged):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateRole):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::recomputeIsExposable):
(WebCore::AccessibilityTable::columnCount):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::setRowIndex):
(WebCore::AccessibilityTableCell::setColumnIndex):
* Source/WebCore/accessibility/AccessibilityTableCell.h:
(WebCore::AccessibilityTableCell::setRowIndex): Deleted.
(WebCore::AccessibilityTableCell::setColumnIndex): Deleted.
Canonical link: https://commits.webkit.org/275710@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1c9c2: compare-results should be updated to support Motio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1c9c2d867f25527bf685106d4f47f72ee4eb970 https://github.com/WebKit/WebKit/commit/a1c9c2d867f25527bf685106d4f47f72ee4eb970 Author: Hysu Xiong Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/compare-results Log Message: --- compare-results should be updated to support MotionMark 1.3 https://bugs.webkit.org/show_bug.cgi?id=270529 rdar://124081628 Reviewed by Stephanie Lewis. Add MotionMark 1.3 support to compare-results * Tools/Scripts/compare-results: (motionMarkBreakdown): (detectMotionMark1_2): (detectMotionMark1_3): (motionMarkResults): (detectBenchmark): (biggerIsBetter): (main): Canonical link: https://commits.webkit.org/275709@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8a892: REGRESSION(273523@main): A test case in html/seman...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8a8923dfc32ea4b1ed9310a8e510c0167161946 https://github.com/WebKit/WebKit/commit/d8a8923dfc32ea4b1ed9310a8e510c0167161946 Author: Ryosuke Niwa Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-disconnected-group-owner-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-disconnected-group-owner.html M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- REGRESSION(273523@main): A test case in html/semantics/forms/the-input-element/radio-disconnected-group-owner.html fails https://bugs.webkit.org/show_bug.cgi?id=270478 Reviewed by Chris Dumez. Add the input element to tree scope's radio group after insertion if it didn't result in becoming connected. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-disconnected-group-owner-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-disconnected-group-owner.html: Added. * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::insertedIntoAncestor): Canonical link: https://commits.webkit.org/275708@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e604d7: PDFPlugin hangs in deallocation when data load con...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e604d7c70127a9d0abd95421c65a2ca594df690e https://github.com/WebKit/WebKit/commit/e604d7c70127a9d0abd95421c65a2ca594df690e Author: Chris Dumez Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: A LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction-expected.txt A LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction.html M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.h M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm Log Message: --- PDFPlugin hangs in deallocation when data load contends with waiting for thread completion https://bugs.webkit.org/show_bug.cgi?id=246454 rdar://101147811 Reviewed by Tim Horton. When `PDFPlugin::teardown()` would get called (on the main thread), it would wait for the PDF thread to complete. However, if loading is still going on, the PDF thread might be blocked on `dataSemaphore.wait()` in PDFIncrementalLoader::dataProviderGetBytesAtPosition(). The `dataSemaphore` is supposed to get signaled on a task dispatched to the main thread but this task won't run if the main thread is blocked on waiting for the thread to exit. To address the issue, PDFIncrementalLoader::clear() now signals the pending dataSemaphores before waiting for the thread to exit and sets a flag indicating we want the thread to exit. This flag is then checked on the PDF thread to make sure we don't queue additional work / semaphores. * LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction-expected.txt: Added. * LayoutTests/compositing/plugins/pdf/pdf-plugin-hang-during-destruction.html: Added. I took the test from Erica Li's earlier PR that got reverted. * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.h: (WebKit::PDFIncrementalLoader::SemaphoreWrapper::create): (WebKit::PDFIncrementalLoader::SemaphoreWrapper::wait): (WebKit::PDFIncrementalLoader::SemaphoreWrapper::signal): (WebKit::PDFIncrementalLoader::WTF_GUARDED_BY_LOCK): * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm: (WebKit::PDFIncrementalLoader::clear): (WebKit::PDFIncrementalLoader::dataProviderGetBytesAtPosition): (WebKit::PDFIncrementalLoader::dataProviderGetByteRanges): (WebKit::PDFIncrementalLoader::threadEntry): Canonical link: https://commits.webkit.org/275707@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6fda5: REGRESSION(275690@main): [webkitpy][Win] NameError...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6fda5d30717d28374a2a45f9604e87ae826f271 https://github.com/WebKit/WebKit/commit/e6fda5d30717d28374a2a45f9604e87ae826f271 Author: Fujii Hironori Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/port/win.py Log Message: --- REGRESSION(275690@main): [webkitpy][Win] NameError: name '_winreg' is not defined https://bugs.webkit.org/show_bug.cgi?id=270534 Unreviewed fix for Windows port. * Tools/Scripts/webkitpy/port/win.py: Rename _winreg to winreg. Canonical link: https://commits.webkit.org/275706@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b30f8: Update trusted fonts in lockdown mode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b30f8d02ef6f1d244c7879ec60d5121f2460fdb https://github.com/WebKit/WebKit/commit/9b30f8d02ef6f1d244c7879ec60d5121f2460fdb Author: Vitor Roriz Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/loader/cache/TrustedFonts.cpp Log Message: --- Update trusted fonts in lockdown mode https://bugs.webkit.org/show_bug.cgi?id=270501 rdar://123658932 Reviewed by Brent Fulgham. Update list of trusted fonts with fonts requested by mobile version of facebook.com * Source/WebCore/loader/cache/TrustedFonts.cpp: (WebCore::trustedFontHashesInLockdownMode): Canonical link: https://commits.webkit.org/275705@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 308a69: [threaded-animation-resolution] explicitly obtain ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 308a69c33af35975cea167db50a89e7c29fb06a4 https://github.com/WebKit/WebKit/commit/308a69c33af35975cea167db50a89e7c29fb06a4 Author: Antoine Quint Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/platform/animation/AcceleratedEffect.cpp Log Message: --- [threaded-animation-resolution] explicitly obtain ref-counted properties as references when blending https://bugs.webkit.org/show_bug.cgi?id=270455 Reviewed by Dean Jackson. Several properties of `AcceleratedEffectValues` are ref-counted and we access those when blending in `AcceleratedEffect`. We don't currently mark those as references, so we should make it explicit since we don't want to increase the ref-counting. * Source/WebCore/platform/animation/AcceleratedEffect.cpp: (WebCore::blend): Canonical link: https://commits.webkit.org/275704@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 839318: [git-webkit pr] Should prompt user if radar and bu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 839318cccbdf7616b0658a3729f5f65ba8a56b27 https://github.com/WebKit/WebKit/commit/839318cccbdf7616b0658a3729f5f65ba8a56b27 Author: Brianna Fan Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py Log Message: --- [git-webkit pr] Should prompt user if radar and bugs do not match https://bugs.webkit.org/show_bug.cgi?id=270314 rdar://123852726 Reviewed by Jonathan Bedard. Adds prompt for user to stop or continue the process when a radar and bug do not match. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py: (Tracker.cc_radar): Will throw an exception if radar and bug do not match and user inputs No. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.create_pull_request): Catches the exception from cc_radar and halts. Canonical link: https://commits.webkit.org/275703@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a78e4b: [LBSE] Fix MotionMark repaint issues
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a78e4b31c4407220c6b34773a707e9880c713edd https://github.com/WebKit/WebKit/commit/a78e4b31c4407220c6b34773a707e9880c713edd Author: Nikolas Zimmermann Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-and-object-creation-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-creation-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-pattern-and-object-creation-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/marker-orient-auto-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/non-scaling-stroke-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-deep-referencing-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-incorrect-tiling-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaled-pattern-space-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaling-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-skew-transformed-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-with-transformation-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/shapes-supporting-markers-expected.png A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/transformed-pattern-clamp-svg-root-expected.png M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/foreign-object-repainting-after-modifying-container-transform-repaint-rects-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/foreign-object-repainting-after-modifying-transform-repaint-rects-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/image-repainting-after-modifying-container-transform-repaint-rects-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/image-repainting-after-modifying-transform-repaint-rects-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/shape-repainting-after-modifying-container-transform-repaint-rects-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/repaint/shape-repainting-after-modifying-transform-repaint-rects-expected.txt M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h Log Message: --- [LBSE] Fix MotionMark repaint issues https://bugs.webkit.org/show_bug.cgi?id=270103 Reviewed by Rob Buis. In LBSE transform changes do not result in relayouts, instead repaints are triggered. That failed to repaint the old position of an object before the transform change, only the new position - fix that. Covered by existing tests, when LBSE is active. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-and-object-creation-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-creation-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-pattern-and-object-creation-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/marker-orient-auto-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/non-scaling-stroke-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-deep-referencing-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-incorrect-tiling-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Copied from LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/js-late-marker-and-object-creation-expected.png. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-rotate-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaled-pattern-space-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-scaling-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-skew-transformed-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-with-transformation-expected.png: Added. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/shapes-supporting-markers-expected.png: * LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/transformed-pattern-clamp-svg-root-expected.png: Added. * LayoutTests/platform/mac-sonoma-w
[webkit-changes] [WebKit/WebKit] 0960ed: Fix invisible scrollbars on webkit.org
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0960edb5f34c825f84edc406484850030c2eda4a https://github.com/WebKit/WebKit/commit/0960edb5f34c825f84edc406484850030c2eda4a Author: Jonathan Davis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Websites/webkit.org/wp-content/themes/webkit/header.php M Websites/webkit.org/wp-content/themes/webkit/style.css Log Message: --- Fix invisible scrollbars on webkit.org https://bugs.webkit.org/show_bug.cgi?id=270528 Reviewed by Timothy Hatcher. * Websites/webkit.org/wp-content/themes/webkit/header.php: * Websites/webkit.org/wp-content/themes/webkit/style.css: (:root): (@media(prefers-color-scheme:dark) :root): (body): (header): (footer): Canonical link: https://commits.webkit.org/275701@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b87dc9: Adjust byline styles to wrap author names and impr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b87dc9e7b7b2a19caf6806522f0c8adf853536a0 https://github.com/WebKit/WebKit/commit/b87dc9e7b7b2a19caf6806522f0c8adf853536a0 Author: Jonathan Davis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Websites/webkit.org/wp-content/themes/webkit/style.css Log Message: --- Adjust byline styles to wrap author names and improve vertical rhythm https://bugs.webkit.org/show_bug.cgi?id=270524 Reviewed by Anne van Kesteren. * Websites/webkit.org/wp-content/themes/webkit/style.css: (article .byline): (article .byline p): (article .byline .date): (article .byline .author): Deleted. Canonical link: https://commits.webkit.org/275700@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 381e04: [css-transitions] imported/w3c/web-platform-tests/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 381e0452f7dd2db7488e23ebd21f74f9fda93c1c https://github.com/WebKit/WebKit/commit/381e0452f7dd2db7488e23ebd21f74f9fda93c1c Author: Antoine Quint Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [css-transitions] imported/w3c/web-platform-tests/css/css-transitions/properties-value-001.html and imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001.html are flaky failures https://bugs.webkit.org/show_bug.cgi?id=203305 Reviewed by Antti Koivisto. These tests are no longer flaky. What's more, had they not been marked as flaky, bots would have caught bug 269848. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-transitions/properties-value-inherit-001-expected.txt: Added. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275699@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c1956: Add missing grid styling to HTML switch demo
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c1956a6198fcdf7b36881d7080b13829848df54 https://github.com/WebKit/WebKit/commit/4c1956a6198fcdf7b36881d7080b13829848df54 Author: Anne van Kesteren Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Websites/webkit.org/demos/html-switch/index.html Log Message: --- Add missing grid styling to HTML switch demo https://bugs.webkit.org/show_bug.cgi?id=270520 Reviewed by Tim Nguyen. The demo started rendering incorrectly due to 273078@main. * Websites/webkit.org/demos/html-switch/index.html: Canonical link: https://commits.webkit.org/275698@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c792c0: Adopt dynamicDowncast<> in even more accessibility...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c792c0e220b690ac5f6852e9c66af91ca62b99fe https://github.com/WebKit/WebKit/commit/c792c0e220b690ac5f6852e9c66af91ca62b99fe Author: Anne van Kesteren Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityImageMapLink.cpp M Source/WebCore/accessibility/AccessibilityImageMapLink.h M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp M Source/WebCore/accessibility/AccessibilityMenuListPopup.h M Source/WebCore/accessibility/AccessibilitySVGElement.cpp M Source/WebCore/accessibility/AccessibilitySVGRoot.cpp M Source/WebCore/accessibility/AccessibilitySlider.cpp M Source/WebCore/accessibility/AccessibilitySpinButton.cpp M Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm Log Message: --- Adopt dynamicDowncast<> in even more accessibility code https://bugs.webkit.org/show_bug.cgi?id=270512 Reviewed by Chris Dumez and Tyler Wilcock. For security & performance. This also takes care of some minor cleanup as well as removing asserts that are now redundant with downcast<> or checkedDowncast<>. * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::Accessibility::findChild): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleChildrenChanged): * Source/WebCore/accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::imageMapLinkRenderer const): * Source/WebCore/accessibility/AccessibilityImageMapLink.h: (isType): * Source/WebCore/accessibility/AccessibilityMathMLElement.cpp: (WebCore::AccessibilityMathMLElement::isMathFenceOperator const): (WebCore::AccessibilityMathMLElement::isMathSeparatorOperator const): (WebCore::AccessibilityMathMLElement::mathLineThickness const): * Source/WebCore/accessibility/AccessibilityMenuListPopup.h: (isType): * Source/WebCore/accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::targetForUseElement const): * Source/WebCore/accessibility/AccessibilitySVGRoot.cpp: (WebCore::AccessibilitySVGRoot::hasAccessibleContent const): * Source/WebCore/accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect const): * Source/WebCore/accessibility/AccessibilitySpinButton.cpp: (WebCore::AccessibilitySpinButtonPart::press): * Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp: (WebCore::AccessibilityTableHeaderContainer::addChildren): * Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::accessibilitySecureFieldLength): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityIsWebInteractiveVideo]): (-[WebAccessibilityObjectWrapper interactiveVideoDescription]): (-[WebAccessibilityObjectWrapper accessibilityIsMediaPlaying]): (-[WebAccessibilityObjectWrapper accessibilityIsMediaMuted]): (-[WebAccessibilityObjectWrapper accessibilityToggleMuteForMedia]): (-[WebAccessibilityObjectWrapper accessibilityVideoEnterFullscreen]): (-[WebAccessibilityObjectWrapper accessibilityValue]): * Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm: (WebCore::AXIsolatedObject::remoteParentObject const): Canonical link: https://commits.webkit.org/275697@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15aaec: [JSC] Destroy LinkBuffer in compiler thread
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15aaecdc0805096996f25abacbb59c509a1a6986 https://github.com/WebKit/WebKit/commit/15aaecdc0805096996f25abacbb59c509a1a6986 Author: Yusuke Suzuki Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/JavaScriptCore/assembler/LinkBuffer.cpp M Source/JavaScriptCore/assembler/LinkBuffer.h M Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp M Source/JavaScriptCore/dfg/DFGJITFinalizer.h M Source/JavaScriptCore/dfg/DFGLazyJSValue.cpp M Source/JavaScriptCore/dfg/DFGLazyJSValue.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/ftl/FTLCompile.cpp M Source/JavaScriptCore/ftl/FTLJITFinalizer.cpp M Source/JavaScriptCore/ftl/FTLJITFinalizer.h M Source/JavaScriptCore/ftl/FTLLink.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/ftl/FTLPatchpointExceptionHandle.cpp M Source/JavaScriptCore/ftl/FTLState.cpp M Source/JavaScriptCore/ftl/FTLState.h M Source/JavaScriptCore/jit/BaselineJITPlan.cpp M Source/JavaScriptCore/jit/BaselineJITPlan.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITCode.cpp M Source/JavaScriptCore/jit/JITPlan.cpp M Source/JavaScriptCore/jit/JITPlan.h M Source/JavaScriptCore/jit/JITSizeStatistics.cpp M Source/JavaScriptCore/jit/JITSizeStatistics.h M Source/JavaScriptCore/runtime/ScriptExecutable.cpp Log Message: --- [JSC] Destroy LinkBuffer in compiler thread https://bugs.webkit.org/show_bug.cgi?id=270503 rdar://124050058 Reviewed by Keith Miller. We are keeping LinkBuffer only because m_mainThreadFinalizationTasks exists. That's not great since LinkBuffer destruction is relatively costly operation. So we should do it in the compiler thread instead of the main thread. This patch moves m_mainThreadFinalizationTasks to JITPlan and run it appropriately in JITPlan so that we can destroy LinkBuffer in the compiler thread. * Source/JavaScriptCore/assembler/LinkBuffer.cpp: (JSC::LinkBuffer::runMainThreadFinalizationTasks): Deleted. * Source/JavaScriptCore/assembler/LinkBuffer.h: (JSC::LinkBuffer::addMainThreadFinalizationTask): Deleted. * Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp: (JSC::DFG::JITFinalizer::JITFinalizer): (JSC::DFG::JITFinalizer::codeSize): (JSC::DFG::JITFinalizer::finalize): * Source/JavaScriptCore/dfg/DFGJITFinalizer.h: * Source/JavaScriptCore/dfg/DFGLazyJSValue.cpp: (JSC::DFG::LazyJSValue::emit const): * Source/JavaScriptCore/dfg/DFGLazyJSValue.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compile): (JSC::DFG::SpeculativeJIT::compileFunction): (JSC::DFG::SpeculativeJIT::runSlowPathGenerators): (JSC::DFG::SpeculativeJIT::compileCurrentBlock): * Source/JavaScriptCore/ftl/FTLCompile.cpp: (JSC::FTL::compile): * Source/JavaScriptCore/ftl/FTLJITFinalizer.cpp: (JSC::FTL::JITFinalizer::codeSize): (JSC::FTL::JITFinalizer::finalize): * Source/JavaScriptCore/ftl/FTLJITFinalizer.h: (JSC::FTL::OutOfLineCodeInfo::OutOfLineCodeInfo): Deleted. * Source/JavaScriptCore/ftl/FTLLink.cpp: (JSC::FTL::link): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileLazyJSConstant): * Source/JavaScriptCore/ftl/FTLPatchpointExceptionHandle.cpp: (JSC::FTL::PatchpointExceptionHandle::scheduleExitCreationForUnwind): * Source/JavaScriptCore/ftl/FTLState.cpp: (JSC::FTL::State::dumpDisassembly): * Source/JavaScriptCore/ftl/FTLState.h: (JSC::FTL::State::dumpDisassembly): * Source/JavaScriptCore/jit/BaselineJITPlan.cpp: (JSC::BaselineJITPlan::compileInThreadImpl): (JSC::BaselineJITPlan::compileSync): (JSC::BaselineJITPlan::codeSize const): (JSC::BaselineJITPlan::finalize): * Source/JavaScriptCore/jit/BaselineJITPlan.h: * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::compileAndLinkWithoutFinalizing): (JSC::JIT::finalizeOnMainThread): (JSC::JIT::compileSync): (JSC::JIT::privateCompile): Deleted. * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITCode.cpp: (JSC::JITCodeWithCodeRef::size): * Source/JavaScriptCore/jit/JITPlan.cpp: (JSC::JITPlan::runMainThreadFinalizationTasks): * Source/JavaScriptCore/jit/JITPlan.h: (JSC::JITPlan::addMainThreadFinalizationTask): * Source/JavaScriptCore/jit/JITSizeStatistics.cpp: (JSC::JITSizeStatistics::markEnd): * Source/JavaScriptCore/jit/JITSizeStatistics.h: * Source/JavaScriptCore/runtime/ScriptExecutable.cpp: (JSC::setupJIT): Canonical link: https://commits.webkit.org/275696@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f3f881: REGRESSION (274894@main): [ iOS Debug ] accessibil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3f8811670c3ddc142478ac045c2ad0d9d131d35 https://github.com/WebKit/WebKit/commit/f3f8811670c3ddc142478ac045c2ad0d9d131d35 Author: Charlie Wolfe Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXObjectCache.cpp Log Message: --- REGRESSION (274894@main): [ iOS Debug ] accessibility/text-marker/text-marker-range-stale-node-crash.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=270477 rdar://124030130 Reviewed by Chris Dumez. Node may have started destruction by the time the RefPtr is created. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::characterOffsetForTextMarkerData): Canonical link: https://commits.webkit.org/275695@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8f281: AX: NULL attributed string returned for text marke...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8f281f89e750d8fea2e45ce43f2a955f989543b https://github.com/WebKit/WebKit/commit/a8f281f89e750d8fea2e45ce43f2a955f989543b Author: Joshua Hoffman Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: A LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html A LayoutTests/platform/mac/accessibility/mac/selected-text-range-unconnected-object-expected.txt M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: NULL attributed string returned for text markers that contain unconnected nodes https://bugs.webkit.org/show_bug.cgi?id=270499 rdar://122451549 Reviewed by Tyler Wilcock. If a node is unconnected and we queue up a node change for it, nothing will happen, since shouldCreateNodeChange will return false. This means that if we request a text marker range that points to a stale, unconnected node, we may get a null attributed string since the range being requested is invalid. This change adds a new condition to shouldCreateNodeChange for unconnected nodes, and adds a new test to verify this behavior. * LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html: Added. * LayoutTests/platform/mac/accessibility/mac/selected-text-range-unconnected-object-expected.txt: Added. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::shouldCreateNodeChange): (WebCore::AXIsolatedTree::addUnconnectedNode): (WebCore::AXIsolatedTree::removeSubtreeFromNodeMap): (WebCore::shouldCreateNodeChange): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/275694@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0414c: AX: AccessibilityText is not updated when static t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0414c435ce6f20b01a4f4e0e7abc657220615fb https://github.com/WebKit/WebKit/commit/c0414c435ce6f20b01a4f4e0e7abc657220615fb Author: Tyler Wilcock Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: A LayoutTests/accessibility/dynamic-text-expected.txt A LayoutTests/accessibility/dynamic-text.html A LayoutTests/platform/glib/accessibility/dynamic-text-expected.txt M LayoutTests/platform/ios/TestExpectations A LayoutTests/platform/ios/accessibility/dynamic-text-expected.txt M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h Log Message: --- AX: AccessibilityText is not updated when static text descendant changes https://bugs.webkit.org/show_bug.cgi?id=270356 rdar://123741292 Reviewed by Chris Fleizach. Add a new TextUnderElementChanged notification to represent this scenario so we can make precise updates to the isolated tree. * LayoutTests/accessibility/dynamic-text-expected.txt: Added. * LayoutTests/accessibility/dynamic-text.html: Added. * LayoutTests/platform/ios/accessibility/dynamic-text-expected.txt: Added. * LayoutTests/platform/ios/TestExpectations: Enable new test. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleTextChanged): (WebCore::AXObjectCache::updateIsolatedTree): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::visibleText const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::dependsOnTextUnderElement const): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateNodeProperties): (WebCore::AXIsolatedTree::updateDependentProperties): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: (WebCore::AXIsolatedTree::updateNodeProperty): Canonical link: https://commits.webkit.org/275693@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 247ec3: Create a faster cache of _WKWebExtensionTabs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 247ec3b89c5405e9dd3c3ef431513b64d38136c0 https://github.com/WebKit/WebKit/commit/247ec3b89c5405e9dd3c3ef431513b64d38136c0 Author: Brian Weinstein Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- Create a faster cache of _WKWebExtensionTabs https://bugs.webkit.org/show_bug.cgi?id=270488 rdar://123959934 Reviewed by Timothy Hatcher. Instead of iterating over all of the tabs in m_tabMap and checking to see if their delegates match, create a new data structure that is a map table from the delegate to the identifier. This way, we can just do one O(1) lookup instead of an O(n) iteration. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::WebExtensionContext): (WebKit::WebExtensionContext::getOrCreateTab const): (WebKit::WebExtensionContext::forgetTab const): * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: Canonical link: https://commits.webkit.org/275692@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b39a83: [Cocoa] Tell AVFoundation to not log urls in priva...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b39a8381cc14da138f10ddd6f4d32ed855c0ac1c https://github.com/WebKit/WebKit/commit/b39a8381cc14da138f10ddd6f4d32ed855c0ac1c Author: Eric Carlson Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Log Message: --- [Cocoa] Tell AVFoundation to not log urls in private browsing mode https://bugs.webkit.org/show_bug.cgi?id=270476 rdar://118855410 Reviewed by Jer Noble. Add a key to the options dictionary passed to the AVURLAsset constructor when WebKit is in private browsing mode so it knows to never log urls. * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: Define new constant string. * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Make the code the same on iOS as on every other platform. * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::loadWithNextMediaEngine): Update name of instance variable. (WebCore::MediaPlayer::setPrivateBrowsingMode): Ditto. * Source/WebCore/platform/graphics/MediaPlayer.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Add new key to options dictionary when in private browsing mode. Canonical link: https://commits.webkit.org/275691@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e66ebf: [webkitpy] Removed unused imports
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e66ebfa9ad50885625e738f00492fec380dabeba https://github.com/WebKit/WebKit/commit/e66ebfa9ad50885625e738f00492fec380dabeba Author: Sam Sneddon Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/__init__.py M Tools/Scripts/webkitpy/api_tests/manager.py M Tools/Scripts/webkitpy/autoinstalled/buildbot.py M Tools/Scripts/webkitpy/autoinstalled/twisted.py M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py M Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py M Tools/Scripts/webkitpy/common/checkout/__init__.py M Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/__init__.py M Tools/Scripts/webkitpy/common/checkout/scm/git.py M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/svn.py M Tools/Scripts/webkitpy/common/net/bugzilla/attachment.py M Tools/Scripts/webkitpy/common/net/bugzilla/bug.py M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py M Tools/Scripts/webkitpy/common/net/buildbot/__init__.py M Tools/Scripts/webkitpy/common/net/credentials_unittest.py M Tools/Scripts/webkitpy/common/net/file_uploader.py M Tools/Scripts/webkitpy/common/net/resultsjsonparser.py M Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py M Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py M Tools/Scripts/webkitpy/common/system/logutils_unittest.py M Tools/Scripts/webkitpy/common/system/path.py M Tools/Scripts/webkitpy/common/system/path_unittest.py M Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py M Tools/Scripts/webkitpy/common/system/systemhost.py M Tools/Scripts/webkitpy/common/system/user.py M Tools/Scripts/webkitpy/common/system/user_mock.py M Tools/Scripts/webkitpy/featuredefines/search.py M Tools/Scripts/webkitpy/generate_xcfilelists_lib/generators.py M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py M Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py M Tools/Scripts/webkitpy/layout_tests/servers/websocket_server_unittest.py M Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py M Tools/Scripts/webkitpy/port/__init__.py M Tools/Scripts/webkitpy/port/factory.py M Tools/Scripts/webkitpy/port/gtk_unittest.py M Tools/Scripts/webkitpy/port/headlessdriver.py M Tools/Scripts/webkitpy/port/ios_simulator_unittest.py M Tools/Scripts/webkitpy/port/mac_unittest.py M Tools/Scripts/webkitpy/port/port_testcase.py M Tools/Scripts/webkitpy/port/server_process.py M Tools/Scripts/webkitpy/port/simulator_process.py M Tools/Scripts/webkitpy/port/visionos_simulator_unittest.py M Tools/Scripts/webkitpy/port/watch_simulator_unittest.py M Tools/Scripts/webkitpy/port/westondriver.py M Tools/Scripts/webkitpy/port/westondriver_unittest.py M Tools/Scripts/webkitpy/port/win.py M Tools/Scripts/webkitpy/port/win_unittest.py M Tools/Scripts/webkitpy/port/wpe_unittest.py M Tools/Scripts/webkitpy/port/xvfbdriver.py M Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py M Tools/Scripts/webkitpy/static_analysis/results_unittest.py M Tools/Scripts/webkitpy/style/checker_unittest.py M Tools/Scripts/webkitpy/style/checkers/contributors.py M Tools/Scripts/webkitpy/style/checkers/featuredefines.py M Tools/Scripts/webkitpy/style/checkers/png.py M Tools/Scripts/webkitpy/style/checkers/xcscheme.py M Tools/Scripts/webkitpy/style/error_handlers.py M Tools/Scripts/webkitpy/style/error_handlers_unittest.py M Tools/Scripts/webkitpy/style/filereader.py M Tools/Scripts/webkitpy/test/main.py M Tools/Scripts/webkitpy/test/runner.py M Tools/Scripts/webkitpy/thirdparty/BeautifulSoup.py M Tools/Scripts/webkitpy/tool/steps/__init__.py M Tools/Scripts/webkitpy/w3c/test_converter.py M Tools/Scripts/webkitpy/w3c/test_converter_unittest.py M Tools/Scripts/webkitpy/w3c/test_downloader.py M Tools/Scripts/webkitpy/w3c/test_importer.py M Tools/Scripts/webkitpy/w3c/test_parser_unittest.py M Tools/Scripts/webkitpy/w3c/wpt_github.py M Tools/Scripts/webkitpy/w3c/wpt_github_mock.py M Tools/Scripts
[webkit-changes] [WebKit/WebKit] e1b6c5: [CSS Container Queries][Style queries] Resolve con...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1b6c5a12f892f3dee434dab3b6764a9fd7115ae https://github.com/WebKit/WebKit/commit/e1b6c5a12f892f3dee434dab3b6764a9fd7115ae Author: Antti Koivisto Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt M Source/WebCore/css/query/ContainerQueryFeatures.cpp Log Message: --- [CSS Container Queries][Style queries] Resolve container units in style queries correctly https://bugs.webkit.org/show_bug.cgi?id=270511 rdar://124058441 Reviewed by Antoine Quint. * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt: * Source/WebCore/css/query/ContainerQueryFeatures.cpp: Provide the context element so container units can be resolved. Canonical link: https://commits.webkit.org/275689@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75f6f3: [EWS] Skip upload of WPE Skia builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75f6f39cead3a40b6b7974dc019c3434af9445cf https://github.com/WebKit/WebKit/commit/75f6f39cead3a40b6b7974dc019c3434af9445cf Author: Claudio Saavedra Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/CISupport/ews-build/config.json M Tools/CISupport/ews-build/factories.py M Tools/CISupport/ews-build/loadConfig.py Log Message: --- [EWS] Skip upload of WPE Skia builds https://bugs.webkit.org/show_bug.cgi?id=270515 Reviewed by Jonathan Bedard. Due to an oversight, WPE Skia build products are getting uploaded to the same directory than cairo builds, which is causing some of the cairo-builds to be overwritten and used in the test runners. Create a new WPE Skia factory that explicitly skips the upload step, since we are not testing Skia builds yet, and when we do, we will most likely use the WPE factory and do away with cairo testing in a similar way. * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories.py: (WPESkiaBuildFactory): * Tools/CISupport/ews-build/loadConfig.py: Canonical link: https://commits.webkit.org/275688@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c28bce: Implement the `require-trusted-types-for` pre-navi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c28bce0ecd22a5a41b3b0f9c8958be13880e5f64 https://github.com/WebKit/WebKit/commit/c28bce0ecd22a5a41b3b0f9c8958be13880e5f64 Author: Luke Warlow Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-report-only-support.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-navigation-expected.txt M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h Log Message: --- Implement the `require-trusted-types-for` pre-navigation check https://bugs.webkit.org/show_bug.cgi?id=267695 Reviewed by Youenn Fablet. When the 'require-trusted-types-for' CSP directive is present javascript URLs are now passed through a default policy or rejected if one doesn't exist. Spec: https://w3c.github.io/trusted-types/dist/spec/#require-trusted-types-for-pre-navigation-check * LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-report-only-support.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-navigation-expected.txt: * Source/WebCore/bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeJavaScriptURL): * Source/WebCore/dom/TrustedType.cpp: (WebCore::requireTrustedTypesForPreNavigationCheckPasses): * Source/WebCore/dom/TrustedType.h: Canonical link: https://commits.webkit.org/275687@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0fc6d0: [Digital Identity]: Digital identity API files and...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0fc6d0fc8c7ca44976bbbdefd8122a099fd30173 https://github.com/WebKit/WebKit/commit/0fc6d0fc8c7ca44976bbbdefd8122a099fd30173 Author: Marcos Caceres Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: R LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https-expected.txt R LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https.html A LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https-expected.txt A LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake R Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp R Source/WebCore/Modules/credentialmanagement/DigitalCredential.h R Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl R Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.h R Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.idl R Source/WebCore/Modules/credentialmanagement/IdentityCredentialProtocol.h R Source/WebCore/Modules/credentialmanagement/IdentityCredentialProtocol.idl R Source/WebCore/Modules/credentialmanagement/IdentityRequestProvider.h R Source/WebCore/Modules/credentialmanagement/IdentityRequestProvider.idl A Source/WebCore/Modules/identity/DigitalCredential.cpp A Source/WebCore/Modules/identity/DigitalCredential.h A Source/WebCore/Modules/identity/DigitalCredential.idl A Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.h A Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.idl A Source/WebCore/Modules/identity/IdentityCredentialProtocol.h A Source/WebCore/Modules/identity/IdentityCredentialProtocol.idl A Source/WebCore/Modules/identity/IdentityRequestProvider.h A Source/WebCore/Modules/identity/IdentityRequestProvider.idl M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj Log Message: --- [Digital Identity]: Digital identity API files and tests should be moved their own modules folder https://bugs.webkit.org/show_bug.cgi?id=269166 rdar://123185171 Reviewed by Alex Christensen. Moved files related to Digital credential API to the "identity" folder. * LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https-expected.txt: Renamed from LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https-expected.txt. * LayoutTests/http/wpt/identity/setDigitalCredentialsEnable.https.html: Renamed from LayoutTests/http/wpt/credential-management/setDigitalCredentialsEnable.https.html. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/identity/DigitalCredential.cpp: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalCredential.cpp. * Source/WebCore/Modules/identity/DigitalCredential.h: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalCredential.h. * Source/WebCore/Modules/identity/DigitalCredential.idl: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalCredential.idl. * Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.h: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.h. * Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.idl: Renamed from Source/WebCore/Modules/credentialmanagement/DigitalCredentialRequestOptions.idl. * Source/WebCore/Modules/identity/IdentityCredentialProtocol.h: Renamed from Source/WebCore/Modules/credentialmanagement/IdentityCredentialProtocol.h. * Source/WebCore/Modules/identity/IdentityCredentialProtocol.idl: Renamed from Source/WebCore/Modules/credentialmanagement/IdentityCredentialProtocol.idl. * Source/WebCore/Modules/identity/IdentityRequestProvider.h: Renamed from Source/WebCore/Modules/credentialmanagement/IdentityRequestProvider.h. * Source/WebCore/Modules/identity/IdentityRequestProvider.idl: Renamed from Source/WebCore/Modules/credentialmanagement/IdentityRequestProvider.idl. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275686@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab0993: Use InvalidStateError if user gesture is missing f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab0993157de8494aed1b5a222f08b740e3dc00c1 https://github.com/WebKit/WebKit/commit/ab0993157de8494aed1b5a222f08b740e3dc00c1 Author: Youenn Fablet Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/fast/mediastream/screencapture-user-gesture.html M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-iframe-audio-transfer.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-iframe-transfer.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-transfer.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/parallel-capture-requests.https-expected.txt M Source/WebCore/Modules/mediastream/MediaDevices.cpp Log Message: --- Use InvalidStateError if user gesture is missing for getDisplayMedia https://bugs.webkit.org/show_bug.cgi?id=251906 rdar://105167105 Reviewed by Jean-Yves Avenard. * LayoutTests/fast/mediastream/screencapture-user-gesture.html: * LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-iframe-audio-transfer.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-iframe-transfer.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/MediaStreamTrack-transfer.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/mediacapture-streams/parallel-capture-requests.https-expected.txt: * Source/WebCore/Modules/mediastream/MediaDevices.cpp: (WebCore::MediaDevices::getDisplayMedia): Canonical link: https://commits.webkit.org/275685@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b96e2: [WPE] WPE Platform: Opaque region support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b96e27c62baf1a2d8040ec73bb71c4c4e847030 https://github.com/WebKit/WebKit/commit/6b96e27c62baf1a2d8040ec73bb71c4c4e847030 Author: Carlos Garcia Campos Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp M Source/WebKit/WPEPlatform/CMakeLists.txt A Source/WebKit/WPEPlatform/wpe/WPERectangle.cpp A Source/WebKit/WPEPlatform/wpe/WPERectangle.h M Source/WebKit/WPEPlatform/wpe/WPEView.cpp M Source/WebKit/WPEPlatform/wpe/WPEView.h M Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp M Source/WebKit/WPEPlatform/wpe/wpe-platform.h Log Message: --- [WPE] WPE Platform: Opaque region support https://bugs.webkit.org/show_bug.cgi?id=267705 Reviewed by Alejandro G. Castro. Add API to set the opaque region on a WPEView and use it from WebKit to set the web view region as opaque when the background color is opaque. * Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp: (webkit_web_view_set_background_color): * Source/WebKit/WPEPlatform/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/WPERectangle.cpp: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. (wpe_rectangle_copy): (wpe_rectangle_free): * Source/WebKit/WPEPlatform/wpe/WPERectangle.h: Copied from Source/WebKit/WPEPlatform/wpe/wpe-platform.h. * Source/WebKit/WPEPlatform/wpe/WPEView.cpp: (wpe_view_set_opaque_rectangles): * Source/WebKit/WPEPlatform/wpe/WPEView.h: * Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp: (wpeViewWaylandConstructed): (wpeViewWaylandSetOpaqueRectangles): (wpe_view_wayland_class_init): * Source/WebKit/WPEPlatform/wpe/wpe-platform.h: Canonical link: https://commits.webkit.org/275684@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6dc9c6: [LBSE] Fix svg/repaint/image-with-clip-path.svg
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dc9c6a25c09a9b226ac1d692b4dcad6b29be15b https://github.com/WebKit/WebKit/commit/6dc9c6a25c09a9b226ac1d692b4dcad6b29be15b Author: Rob Buis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- [LBSE] Fix svg/repaint/image-with-clip-path.svg https://bugs.webkit.org/show_bug.cgi?id=270187 Reviewed by Nikolas Zimmermann. On a transform change from identity matrix to non-identity matrix the render layer needs to become a stacking context without relying on a style update in the case of LBSE. Add logic for this in repaintOrRelayoutAfterSVGTransformChange. Also add a correction to only call updateLayerTransform once in repaintOrRelayoutAfterSVGTransformChange. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderLayerModelObject::repaintOrRelayoutAfterSVGTransformChange): Canonical link: https://commits.webkit.org/275683@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 880753: [LBSE] Support outlines
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88075355648c45f1260590232b05804af2ea95b6 https://github.com/WebKit/WebKit/commit/88075355648c45f1260590232b05804af2ea95b6 Author: Rob Buis Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations M Source/WebCore/rendering/svg/RenderSVGContainer.cpp M Source/WebCore/rendering/svg/RenderSVGImage.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGModelObject.h M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp Log Message: --- [LBSE] Support outlines https://bugs.webkit.org/show_bug.cgi?id=269917 Reviewed by Nikolas Zimmermann. Support outline painting by adding and using RenderSVGModelObject::paintSVGOutline as well as using default LayoutRepainter mode of including outlines in repaint rectangle calculations. * LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations: * Source/WebCore/rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): * Source/WebCore/rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::paintSVGOutline): * Source/WebCore/rendering/svg/RenderSVGModelObject.h: * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::layout): (WebCore::RenderSVGShape::paint): Canonical link: https://commits.webkit.org/275682@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ff489: [GStreamer] Build without WebAudio support is broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ff489b643f769c62518c80e2b2d04808efd651f https://github.com/WebKit/WebKit/commit/1ff489b643f769c62518c80e2b2d04808efd651f Author: Philippe Normand Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp M Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h Log Message: --- [GStreamer] Build without WebAudio support is broken https://bugs.webkit.org/show_bug.cgi?id=270449 Reviewed by Xabier Rodriguez-Calvar. This most likely started failing after the GStreamer source units were unified. * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::createAudioSourceProvider): * Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp: * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp: * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp: * Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h: Canonical link: https://commits.webkit.org/275681@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 341dd7: [Crash in com.apple.WebKit.WebContent] WTF::Detail...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 341dd78efbba51d3c1c6a5bc21a1282c42cb2357 https://github.com/WebKit/WebKit/commit/341dd78efbba51d3c1c6a5bc21a1282c42cb2357 Author: Jean-Yves Avenard Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp Log Message: --- [Crash in com.apple.WebKit.WebContent] WTF::Detail::CallableWrapper::call https://bugs.webkit.org/show_bug.cgi?id=270506 rdar://123748005 Reviewed by Youenn Fablet. MediaSourcePrivateRemote::m_gpuConnection is a ThreadSafeWeakPtr which can become null before isGPURunning() returns true (such as if the GPU process crashed or was terminated). Add null test. * Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.cpp: (WebKit::MediaSourcePrivateRemote::addSourceBuffer): (WebKit::MediaSourcePrivateRemote::durationChanged): (WebKit::MediaSourcePrivateRemote::bufferedChanged): (WebKit::MediaSourcePrivateRemote::markEndOfStream): (WebKit::MediaSourcePrivateRemote::unmarkEndOfStream): (WebKit::MediaSourcePrivateRemote::setMediaPlayerReadyState): (WebKit::MediaSourcePrivateRemote::setTimeFudgeFactor): Canonical link: https://commits.webkit.org/275680@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acf3bc: Adopt dynamicDowncast<> in JSC inspector code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acf3bc87ab82cf75ba7a6a9a74a468abc960a51c https://github.com/WebKit/WebKit/commit/acf3bc87ab82cf75ba7a6a9a74a468abc960a51c Author: Anne van Kesteren Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp M Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp M Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm M Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm Log Message: --- Adopt dynamicDowncast<> in JSC inspector code https://bugs.webkit.org/show_bug.cgi?id=270457 Reviewed by Devin Rousso. For security & performance. * Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.cpp: (Inspector::RemoteConnectionToTarget::setup): * Source/JavaScriptCore/inspector/remote/RemoteInspector.cpp: (Inspector::RemoteInspector::listingForTarget const): * Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm: (Inspector::RemoteConnectionToTarget::setup): * Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm: (Inspector::RemoteInspector::receivedIndicateMessage): Canonical link: https://commits.webkit.org/275679@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
