[webkit-changes] [WebKit/WebKit] 264120: Handle custom property applying in Style::Builder

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 264120dc6a7eede1bfa2399da6db11f255b0efa9
  
https://github.com/WebKit/WebKit/commit/264120dc6a7eede1bfa2399da6db11f255b0efa9
  Author: Antti Koivisto 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/css/process-css-properties.py
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
M Source/WebCore/style/StyleBuilderCustom.h
M Source/WebCore/style/StyleBuilderGenerated.h
M Source/WebCore/style/StyleBuilderState.h

  Log Message:
  ---
  Handle custom property applying in Style::Builder
https://bugs.webkit.org/show_bug.cgi?id=270581
rdar://124149638

Reviewed by Alan Baradlay.

Move it outside the giant switch. This simplifies the code.

* Source/WebCore/css/process-css-properties.py:

Generate switch instead of a series of ifs for value/initial/inherit.

* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyProperty):

We no longer need to pass the registered property to the normal apply function.
Also pass the value/initial/inherit as a three-value enum rather than as 
separate bits (which were mutually exclusive).

(WebCore::Style::Builder::applyCustomPropertyValue):

Apply custom properties here.

* Source/WebCore/style/StyleBuilder.h:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialCustomProperty): Deleted.
(WebCore::Style::BuilderCustom::applyInheritCustomProperty): Deleted.
(WebCore::Style::BuilderCustom::applyValueCustomProperty): Deleted.
* Source/WebCore/style/StyleBuilderGenerated.h:
* Source/WebCore/style/StyleBuilderState.h:

Canonical link: https://commits.webkit.org/275774@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d57f1: REGRESSION (iOS 17): Animation flicker with multip...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d57f1f6519a812dda9dbb476a24ce8ed73c976c
  
https://github.com/WebKit/WebKit/commit/9d57f1f6519a812dda9dbb476a24ce8ed73c976c
  Author: Antoine Quint 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
A 
LayoutTests/webanimations/accelerated-animation-immediate-prevetion-direction-reverse-expected.txt
A 
LayoutTests/webanimations/accelerated-animation-immediate-prevetion-direction-reverse.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/animation/KeyframeEffectStack.cpp

  Log Message:
  ---
  REGRESSION (iOS 17): Animation flicker with multiple accelerated animations 
and direction change
https://bugs.webkit.org/show_bug.cgi?id=263996
rdar://117815004

Reviewed by Dean Jackson.

While we have a mechanism to deal with changes in ability to accelerate effects 
based on logic ran
at the KeyframeEffect level (see `KeyframeEffect::canBeAccelerated()`) we do 
not have anything
specific in place to deal with the inability to accelerate effects at the 
GraphicsLayerCA level.

In the case of reversed animations, or any playback rate other than 1, we 
reject acceleration
in GraphicsLayerCA in the static function `animationCanBeAccelerated()`. This 
happens while
accelerated actions are applied throughout a keyframe effect stack. With the 
existing system
in place, this would result in preventing acceleration in the next animation 
frame. This bug
showed this with animations being in an incorrect state for one single frame.

We now check in `KeyframeEffectStack::applyPendingAcceleratedActions()` whether 
the application
of pending accelerated actions resulted in an effect preventing acceleration of 
the effect
stack and now immediately stop all effects in that stack.

The newly added test would reliably fail prior to this patch.

* LayoutTests/platform/glib/TestExpectations:
* 
LayoutTests/webanimations/accelerated-animation-immediate-prevetion-direction-reverse-expected.txt:
 Added.
* 
LayoutTests/webanimations/accelerated-animation-immediate-prevetion-direction-reverse.html:
 Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::effectStackNoLongerAllowsAccelerationDuringAcceleratedActionApplication):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyPendingAcceleratedActions const):

Canonical link: https://commits.webkit.org/275773@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 055511: PresentationContextIOSurface::configure should che...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 055511d1aab8adce779b45c6dff36d74e3b8d381
  
https://github.com/WebKit/WebKit/commit/055511d1aab8adce779b45c6dff36d74e3b8d381
  Author: Alex Christensen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/fast/webgpu/invalid-surface-height-expected.txt
A LayoutTests/fast/webgpu/invalid-surface-height.html
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm

  Log Message:
  ---
  PresentationContextIOSurface::configure should check for invalid height 
before creating MTLTexture
https://bugs.webkit.org/show_bug.cgi?id=270608
rdar://124143113

Reviewed by Mike Wyrzykowski.

* LayoutTests/fast/webgpu/invalid-surface-height-expected.txt: Added.
* LayoutTests/fast/webgpu/invalid-surface-height.html: Added.
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):

Canonical link: https://commits.webkit.org/275772@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e644c8: Align criteria for isAlignedForUnder.

[lericaa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e644c808ec390094ac7cc6701b45156ad6ef38e5
  
https://github.com/WebKit/WebKit/commit/e644c808ec390094ac7cc6701b45156ad6ef38e5
  Author: Erica Li 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A 
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash-expected.txt
A 
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash.html
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/style/InlineTextBoxStyle.cpp
M Source/WebCore/style/InlineTextBoxStyle.h

  Log Message:
  ---
  Align criteria for isAlignedForUnder.
https://bugs.webkit.org/show_bug.cgi?id=270431

Reviewed by Alan Baradlay.

The criteria of isAlignedForUnder is not aligned between 
RenderStyle::changeAffectsVisualOverflow from and isAlignedForUnder in 
InlineTextBoxStyle.

* 
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash-expected.txt:
 Added.
* 
LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-computed-underline-offset-crash.html:
 Added.
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::isAlignedForUnder):
* Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/275771@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 88b3ec: Null check buffer in GPUCanvasContextCocoa::drawBu...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88b3ecbe50b9c2b2fb330ede40e092d730a8a365
  
https://github.com/WebKit/WebKit/commit/88b3ecbe50b9c2b2fb330ede40e092d730a8a365
  Author: Alex Christensen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/fast/webgpu/draw-null-buffer-to-canvas-expected.txt
A LayoutTests/fast/webgpu/draw-null-buffer-to-canvas.html
A 
LayoutTests/platform/ios/fast/webgpu/draw-null-buffer-to-canvas-expected.txt
M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm

  Log Message:
  ---
  Null check buffer in GPUCanvasContextCocoa::drawBufferToCanvas
https://bugs.webkit.org/show_bug.cgi?id=270599
rdar://124143249

Reviewed by Mike Wyrzykowski.

* LayoutTests/fast/webgpu/draw-null-buffer-to-canvas-expected.txt: Added.
* LayoutTests/fast/webgpu/draw-null-buffer-to-canvas.html: Added.
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm:
(WebCore::GPUCanvasContextCocoa::drawBufferToCanvas):

Canonical link: https://commits.webkit.org/275770@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e23f17: [Text Extraction] Ignore transparent (or nearly-tr...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e23f17abb853a4aab8361f679ed5ca467d6e46fa
  
https://github.com/WebKit/WebKit/commit/e23f17abb853a4aab8361f679ed5ca467d6e46fa
  Author: Wenson Hsieh 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M LayoutTests/fast/text-extraction/basic-text-extraction.html
M Source/WebCore/page/text-extraction/TextExtraction.cpp

  Log Message:
  ---
  [Text Extraction] Ignore transparent (or nearly-transparent) elements when 
extracting text
https://bugs.webkit.org/show_bug.cgi?id=270598
rdar://124102506

Reviewed by Megan Gardner and Abrar Rahman Protyasha.

When extracting visible text, ignore subtrees where the renderer is transparent 
(or nearly
transparent). To do this, we adjust `extractItemData` to return an enum 
(`SkipExtraction`)
indicating whether we should skip text extraction for just the current node, or 
for the entire
subtree; we then use this to skip subtrees where there is either no renderer 
(i.e. `display: none;`)
or the opacity is near 0.

* LayoutTests/fast/text-extraction/basic-text-extraction.html:
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::extractItemData):
(WebCore::TextExtraction::extractRecursive):
(WebCore::TextExtraction::extractRenderedText):

Canonical link: https://commits.webkit.org/275769@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 97e744: Reload without content blockers may not appear for...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97e744cbfdca05fad698f53a482b5c00c3c38a58
  
https://github.com/WebKit/WebKit/commit/97e744cbfdca05fad698f53a482b5c00c3c38a58
  Author: Elijah Sawyers 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  ---
  Reload without content blockers may not appear for extensions that use DNR
https://webkit.org/b/270552
rdar://124033486

Reviewed by Timothy Hatcher.

Clients need to be aware of whether or not a web extension context has any
content modification rules rules. This patch adds a new property to expose
that information.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:
(-[_WKWebExtensionContext hasContentModificationRules]):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::hasContentModificationRules):
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:

Canonical link: https://commits.webkit.org/275768@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1ca2cd: Remove ApplicationCache related sandbox rules

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ca2cd7cc3255c93766ce7bb031fb865430d0f48
  
https://github.com/WebKit/WebKit/commit/1ca2cd7cc3255c93766ce7bb031fb865430d0f48
  Author: Sihui Liu 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Remove ApplicationCache related sandbox rules
https://bugs.webkit.org/show_bug.cgi?id=270603
rdar://124166462

Reviewed by Per Arne Vollan.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/275767@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2b86d3: REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b86d34a461912629b0f2d3af7fc57b3da047933
  
https://github.com/WebKit/WebKit/commit/2b86d34a461912629b0f2d3af7fc57b3da047933
  Author: Pascoe 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  ---
  REGRESSION (275711@main): [ iOS ] 6x 
TestWebKitAPI.WebAuthenticationPanel.MakeCredential (API-Tests) are constant 
failures
https://bugs.webkit.org/show_bug.cgi?id=270590
rdar://124156975

Unreviewed, test gardening.

These tests fail because WKTR doesn't have access to the real access group for 
passkeys,
they will be re-enabled after test development to use a different group in 
tests.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/275766@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e74b0: B3::ReduceStrength is overly conservative at apply...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e74b00e473fe2a37662b206e4615c97d85a456f
  
https://github.com/WebKit/WebKit/commit/3e74b00e473fe2a37662b206e4615c97d85a456f
  Author: Keith Miller 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/JavaScriptCore/b3/B3ReduceStrength.cpp

  Log Message:
  ---
  B3::ReduceStrength is overly conservative at applying specializeSelect
https://bugs.webkit.org/show_bug.cgi?id=270577
rdar://124146878

Reviewed by Justin Michaud.

Right now it only applies if both outputs from a select are constant. The 
comment
and testing indicates this is profitable as long as one of the two outputs is a 
constant.
This looks like a 1.7% speedup on JS3.

* Source/JavaScriptCore/b3/B3ReduceStrength.cpp:

Canonical link: https://commits.webkit.org/275765@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb6155: Simplify use of sendWithPromisedReplyOnDispatcher

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb615544285886057ad79e074fefe6bbf68c2292
  
https://github.com/WebKit/WebKit/commit/bb615544285886057ad79e074fefe6bbf68c2292
  Author: Jean-Yves Avenard 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp

  Log Message:
  ---
  Simplify use of sendWithPromisedReplyOnDispatcher
https://bugs.webkit.org/show_bug.cgi?id=270320
rdar://123857833

Reviewed by Kimmo Kinnunen.

We can remove Connection::sendWithPromiseReplyOnDisPatcher and have 
Connection::sendWithPromisedReply perform the dispatching automatically.

Using NativePromiseProducer::settleWithFunction we can set the callback that 
will decode the IPC's message and pass it to its listener
on the thread the listener is asking to be called on.

We can remove the RefPtr from the 
AsyncReplyWithDispatcher structure and move the
dispatching logic directly into the AsyncReplyHandler's CompletionHandler which 
will now receive a std::unique_ptr instead of a
raw pointer.

No change in observable behaviour, covered by existing tests.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessageWithAsyncReplyWithDispatcher):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::addAsyncReplyHandlerWithDispatcher):
(IPC::Connection::cancelAsyncReplyHandlers):
(IPC::CompletionHandlerhttps://commits.webkit.org/275764@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 24260b: Add a quirk to store third-party cookies in partit...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24260b1c915eded6dcd704ae8dd8dc05723c2d75
  
https://github.com/WebKit/WebKit/commit/24260b1c915eded6dcd704ae8dd8dc05723c2d75
  Author: Sihui Liu 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieJarCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp
M Source/WebKit/WebProcess/WebPage/WebCookieJar.h

  Log Message:
  ---
  Add a quirk to store third-party cookies in partitioned storage
https://bugs.webkit.org/show_bug.cgi?id=270494
rdar://113830141

Reviewed by Chris Dumez.

cagreatamerica.com does not display correctly because an iframe from 
queue-it.net checks to cookie storage access from
script, and third-party cookies are fully blocked when ITP is enabled. To fix 
that, allow queue-it.net to read and write
cookies in partitioned storage. Note the storage is partitioned by top-level 
domain, so quirked domain cannot perform
cross-site tracking. Also the storage currently resides in the memory of web 
process, so the cookies are not applied to
network tasks.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldUseEphemeralPartitionedStorageForDOMCookies const):
* Source/WebCore/page/Quirks.h:
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebCookieJarCocoa.mm: Added.
(WebKit::policyProperties):
(WebKit::WebCookieJar::cookiesInPartitionedCookieStorage const):
(WebKit::WebCookieJar::setCookiesInPartitionedCookieStorage):
(WebKit::WebCookieJar::ensurePartitionedCookieStorage):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::setCookies):
(WebKit::WebCookieJar::cookiesInPartitionedCookieStorage const):
(WebKit::WebCookieJar::setCookiesInPartitionedCookieStorage):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/275763@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c3f22: AX: AXPropertyName::{ColumnIndex, RowIndex} are no...

[Joshua Hoffman]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c3f222f4f9644de8d8aa2a72aebaec90f45c03d
  
https://github.com/WebKit/WebKit/commit/1c3f222f4f9644de8d8aa2a72aebaec90f45c03d
  Author: Joshua Hoffman 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/accessibility/dynamic-table-row-column-indices-expected.txt
A LayoutTests/accessibility/dynamic-table-row-column-indices.html
A LayoutTests/accessibility/table-insert-second-thead-expected.txt
A LayoutTests/accessibility/table-insert-second-thead.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityTableColumn.cpp
M Source/WebCore/accessibility/AccessibilityTableColumn.h
M Source/WebCore/accessibility/AccessibilityTableRow.cpp
M Source/WebCore/accessibility/AccessibilityTableRow.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  ---
  AX: AXPropertyName::{ColumnIndex, RowIndex} are not updated on the isolated 
tree
https://bugs.webkit.org/show_bug.cgi?id=270535
rdar://118240861

Reviewed by Tyler Wilcock.

These properties, ColumnIndex and RowIndex, were never updated on isolated 
objects
after being initialized. This can cause issues as ATs rely on these properties 
to
accurately navigate tables.

Two tests were added to flex this behavior. table-insert-second-thead.html also
tests that we are resilient to authoring errors with respect to multiple table
header elements.

* LayoutTests/accessibility/dynamic-table-row-column-indices-expected.txt: 
Added.
* LayoutTests/accessibility/dynamic-table-row-column-indices.html: Added.
* LayoutTests/accessibility/table-insert-second-thead-expected.txt: Added.
* LayoutTests/accessibility/table-insert-second-thead.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::columnIndexChanged):
(WebCore::AXObjectCache::rowIndexChanged):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::setColumnIndex):
* Source/WebCore/accessibility/AccessibilityTableColumn.h:
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::setRowIndex):
* Source/WebCore/accessibility/AccessibilityTableRow.h:
(WebCore::AccessibilityTableRow::setRowIndex): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):

Canonical link: https://commits.webkit.org/275762@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5cbab2: Queue::commandBufferWithDescriptor needs to null c...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cbab24ef4f3b2808ca46748bf6c34f3306dca7e
  
https://github.com/WebKit/WebKit/commit/5cbab24ef4f3b2808ca46748bf6c34f3306dca7e
  Author: Alex Christensen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/fast/webgpu/command-buffer-after-destruction-expected.txt
A LayoutTests/fast/webgpu/command-buffer-after-destruction.html
M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  ---
  Queue::commandBufferWithDescriptor needs to null check buffer before adding 
to NSMutableOrderedSet
https://bugs.webkit.org/show_bug.cgi?id=270597
rdar://124143184

Reviewed by Mike Wyrzykowski.

* LayoutTests/fast/webgpu/command-buffer-after-destruction-expected.txt: Added.
* LayoutTests/fast/webgpu/command-buffer-after-destruction.html: Added.
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::commandBufferWithDescriptor):

Canonical link: https://commits.webkit.org/275761@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c6180: Add myself as a contributor of the WebKit repository

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c618049b3b1e4cea009f30ce4a968862639f5c5
  
https://github.com/WebKit/WebKit/commit/8c618049b3b1e4cea009f30ce4a968862639f5c5
  Author: Elijah Sawyers 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add myself as a contributor of the WebKit repository

Reviewed by Brian Weinstein and Timothy Hatcher.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/275759@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 50f99f: Assertion not taken when falling back to legacy pr...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50f99f636b1701a183c224a1326a4aefe6bf6930
  
https://github.com/WebKit/WebKit/commit/50f99f636b1701a183c224a1326a4aefe6bf6930
  Author: Per Arne Vollan 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/Platform/cocoa/AssertionCapability.mm

  Log Message:
  ---
  Assertion not taken when falling back to legacy process launch path in 
Simulator
https://bugs.webkit.org/show_bug.cgi?id=270594
rdar://124158739

Reviewed by Chris Dumez.

* Source/WebKit/Platform/cocoa/AssertionCapability.mm:

Canonical link: https://commits.webkit.org/275758@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2cdc0d: REGRESSION (275711@main): [ iOS ] 6x TestWebKitAPI...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cdc0db1ae7125d4a2f565263f33e1e11e97bc8d
  
https://github.com/WebKit/WebKit/commit/2cdc0db1ae7125d4a2f565263f33e1e11e97bc8d
  Author: Pascoe 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm

  Log Message:
  ---
  REGRESSION (275711@main): [ iOS ] 6x 
TestWebKitAPI.WebAuthenticationPanel.MakeCredential (API-Tests) are constant 
failures
https://bugs.webkit.org/show_bug.cgi?id=270590
rdar://124156975

Unreviewed, test gardening.

These tests fail because WKTR doesn't have access to the real access group for 
passkeys,
they will be re-enabled after test development to use a different group in 
tests.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/275757@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7fed86: Fix bounds check in Queue::writeBuffer when buffer...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7fed8609a81438d9ae188d1b83db749dba59236d
  
https://github.com/WebKit/WebKit/commit/7fed8609a81438d9ae188d1b83db749dba59236d
  Author: Alex Christensen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/fast/webgpu/write-to-destroyed-buffer-expected.txt
A LayoutTests/fast/webgpu/write-to-destroyed-buffer.html
M Source/WebGPU/WebGPU/BindGroup.mm
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/CommandsMixin.mm
M Source/WebGPU/WebGPU/ComputePassEncoder.mm
M Source/WebGPU/WebGPU/Queue.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  Fix bounds check in Queue::writeBuffer when buffer has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=270538
rdar://123811082

Reviewed by Mike Wyrzykowski.

Buffer::destroy updates m_buffer but didn't update m_size, and it shouldn't 
update the size as
seen by the JS API.

Instead of updating it, I derive the size from m_buffer and replace size() with 
currentSize()
and initialSize()

I also add a null check to avoid writing to a buffer that is null.

* LayoutTests/fast/webgpu/write-to-destroyed-buffer-expected.txt: Added.
* LayoutTests/fast/webgpu/write-to-destroyed-buffer.html: Added.
* Source/WebGPU/WebGPU/Buffer.h:
(WebGPU::Buffer::create):
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Device::createBuffer):
(WebGPU::Buffer::Buffer):
(WebGPU::Buffer::getMappedRange):
(WebGPU::Buffer::errorValidatingMapAsync const):
(WebGPU::Buffer::mapAsync):
(WebGPU::Buffer::size const):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::validateWriteBuffer const):

Canonical link: https://commits.webkit.org/275756@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c31bee: [web-animations] remove unnecessary `return` state...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c31beeb0aa293d11b9d23a4c6f2f70cfda461dbe
  
https://github.com/WebKit/WebKit/commit/c31beeb0aa293d11b9d23a4c6f2f70cfda461dbe
  Author: Antoine Quint 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  ---
  [web-animations] remove unnecessary `return` statement in 
`KeyframeEffect::applyPendingAcceleratedActions()`
https://bugs.webkit.org/show_bug.cgi?id=270576
rdar://124145663

Reviewed by Dean Jackson.

* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

Canonical link: https://commits.webkit.org/275755@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 03a094: Update ANGLE to 2024-03-06 (b2773c110f641869afbb1e...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03a094cff894dbba57747e80877e5d7078d0f961
  
https://github.com/WebKit/WebKit/commit/03a094cff894dbba57747e80877e5d7078d0f961
  Author: Kimmo Kinnunen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/CONTRIBUTORS
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/build_overrides/clspv.gni
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/config/generated/cr-buildbucket.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/luci-milo.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/luci-scheduler.cfg
M Source/ThirdParty/ANGLE/infra/config/generated/project.cfg
M Source/ThirdParty/ANGLE/infra/config/main.star
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/angle_mb_config.pyl
M Source/ThirdParty/ANGLE/infra/specs/generate_test_spec_json.py
M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl
M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl
M Source/ThirdParty/ANGLE/infra/specs/waterfalls.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/interpreter_utils.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json
M Source/ThirdParty/ANGLE/scripts/process_angle_perf_results.py
M Source/ThirdParty/ANGLE/src/commit_id.py
M Source/ThirdParty/ANGLE/src/common/matrix_utils.cpp
M Source/ThirdParty/ANGLE/src/common/platform.h
M Source/ThirdParty/ANGLE/src/common/utilities.h
M Source/ThirdParty/ANGLE/src/common/utilities_unittest.cpp
M Source/ThirdParty/ANGLE/src/common/vector_utils.h
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.h
M Source/ThirdParty/ANGLE/src/compiler/translator/ImmutableString.h
M Source/ThirdParty/ANGLE/src/compiler/translator/ImmutableStringBuilder.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ImmutableStringBuilder.h
M Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/AstHelpers.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/AstHelpers.h
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/ModifyStruct.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/Name.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/Name.h
M Source/ThirdParty/ANGLE/src/libANGLE/BlobCache.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/BlobCache.h
M Source/ThirdParty/ANGLE/src/libANGLE/BlobCache_unittest.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/CLPlatform.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/CLPlatform.h
M Source/ThirdParty/ANGLE/src/libANGLE/CLProgram.h
M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Display.h
M Source/ThirdParty/ANGLE/src/libANGLE/Framebuffer.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Framebuffer.h
M Source/ThirdParty/ANGLE/src/libANGLE/FramebufferAttachment.h
M Source/ThirdParty/ANGLE/src/libANGLE/Image.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/Image.h
M Source/ThirdParty/ANGLE/src/libANGLE/MemoryProgramCache.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/State.h
M Source/ThirdParty/ANGLE/src/libANGLE/Surface.h
M Source/ThirdParty/ANGLE/src/libANGLE/Texture.h
M Source/ThirdParty/ANGLE/src/libANGLE/angletypes.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/angletypes.h
M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.h
M Source/ThirdParty/ANGLE/src/libANGLE/cl_types.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/CLKernelImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/ContextImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/DisplayImpl.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/DisplayImpl.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/Context11.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/Context11.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d9/Context9.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d9/Context9.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d9/Renderer9.cpp
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/

[webkit-changes] [WebKit/WebKit] 048ee1: Add SPI for setting default value of TrackingPreve...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 048ee145e7ccd7397833ab11ab76ee74256bbc92
  
https://github.com/WebKit/WebKit/commit/048ee145e7ccd7397833ab11ab76ee74256bbc92
  Author: Sihui Liu 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h

  Log Message:
  ---
  Add SPI for setting default value of TrackingPreventionEnabled flag on 
_WKWebsiteDataStoreConfiguration
https://bugs.webkit.org/show_bug.cgi?id=270505
rdar://124053569

Reviewed by Chris Dumez.

In current implementation, when client does not explicitly set 
TrackingPreventionEnabled flag on WebsiteDataStore, we
will use the default value, which is the TCC permission value. For clients that 
do not want to use the TCC permission
value by chance, add a new SPI for setting the default value at data store 
creation time.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:
(-[_WKWebsiteDataStoreConfiguration defaultTrackingPreventionEnabledOverride]):
(-[_WKWebsiteDataStoreConfiguration 
setDefaultTrackingPreventionEnabledOverride:]):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::defaultTrackingPreventionEnabled const):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::defaultTrackingPreventionEnabledOverride
 const):
(WebKit::WebsiteDataStoreConfiguration::setDefaultTrackingPreventionEnabledOverride):

Canonical link: https://commits.webkit.org/275753@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] de89f2: [Skia] Stub out BackingStore implementation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de89f2977a314e5ddbe49384e35b953061d17f29
  
https://github.com/WebKit/WebKit/commit/de89f2977a314e5ddbe49384e35b953061d17f29
  Author: Don Olmstead 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/Platform/WC.cmake
M Source/WebKit/UIProcess/BackingStore.h
A Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp

  Log Message:
  ---
  [Skia] Stub out BackingStore implementation
https://bugs.webkit.org/show_bug.cgi?id=270537

Reviewed by Adrian Perez de Castro.

Add a stub of BackingStore when `USE(SKIA)` is turned `ON`. Actual
implementation to come later.

* Source/WebKit/Platform/WC.cmake:
* Source/WebKit/UIProcess/BackingStore.h:
* Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp: Copied from 
Source\WebKit\UIProcess\BackingStore.h.

Canonical link: https://commits.webkit.org/275752@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c1c024: [Webauthn] Disable tests until test development fo...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1c0248f645301e3c81ed6f67987a181af43fb5d
  
https://github.com/WebKit/WebKit/commit/c1c0248f645301e3c81ed6f67987a181af43fb5d
  Author: Pascoe 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M LayoutTests/TestExpectations

  Log Message:
  ---
  [Webauthn] Disable tests until test development for access group landed
https://bugs.webkit.org/show_bug.cgi?id=270583
rdar://124150813

Unreviewed.

* LayoutTests/TestExpectations:
These tests fail because WKTR doesn't have access to the real access group for 
passkeys,
they will be re-enabled after test development to use a different group in 
tests.

Canonical link: https://commits.webkit.org/275751@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 525f85: import-w3c-tests should rewrite reference file nam...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 525f853875c0dcaebc7df8ba2317ce8ab0734156
  
https://github.com/WebKit/WebKit/commit/525f853875c0dcaebc7df8ba2317ce8ab0734156
  Author: Matt Woodrow 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Tools/Scripts/webkitpy/w3c/test_converter.py
M Tools/Scripts/webkitpy/w3c/test_importer.py

  Log Message:
  ---
  import-w3c-tests should rewrite reference file names in meta fuzzy 
annotations.
https://bugs.webkit.org/show_bug.cgi?id=270426


Reviewed by Jonathan Bedard.

* Tools/Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.__init__):
(_W3CTestConverter.convert_attributes_if_needed):
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.find_importable_tests):
(TestImporter.import_tests):

Canonical link: https://commits.webkit.org/275750@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 095152: Ignore unsupported disposal methods when decoding GIF

[Ahmad-S792]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 095152b0f5c6097f852de6a76aa44b2d69d3d184
  
https://github.com/WebKit/WebKit/commit/095152b0f5c6097f852de6a76aa44b2d69d3d184
  Author: Ahmad Saleem 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp

  Log Message:
  ---
  Ignore unsupported disposal methods when decoding GIF

https://bugs.webkit.org/show_bug.cgi?id=270572

Reviewed by Michael Catanzaro.

Merge: 
https://chromium.googlesource.com/chromium/blink/+/cdfed72e21acef69547a0266508067d238cd1b06

This fixes potential assertion failure about invalid disposal methods by 
ignoring
unsupported values when decoding GIF.

The bug is caused by some GIF images containing frames with disposal
method 5. Don't know what the author wanted.

NOTE - Due to lack of 'CPP' tests, I am unable to import test changes.

* Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::parse):

Canonical link: https://commits.webkit.org/275749@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 744503: [results.webkit.org] Allow instance to declare def...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74450308e745435f7feebf54ea505966aa09f837
  
https://github.com/WebKit/WebKit/commit/74450308e745435f7feebf54ea505966aa09f837
  Author: Jonathan Bedard 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/constants.js
M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py

  Log Message:
  ---
  [results.webkit.org] Allow instance to declare default architecture
https://bugs.webkit.org/show_bug.cgi?id=270442
rdar://124007556

Reviewed by Dewei Zhu.

Constructed queue names on results.webkit.org are often too verbose. 
Architecture is a
significant cause of this length, and for many queues on many instances, 
architecture would
be assumed were it excluded from the UI.

* 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js:
(Configuration.prototype.toString): Do not include architecture in printed 
configuration name
if the architecture is the instance's default architecture.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/templates/constants.js: 
Add default_architecture.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py:
(ViewRoutes.__init__): Add default_architecture.
(ViewRoutes.constants): Ditto.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
(WebSiteUnittest.test_constants): Update.

Canonical link: https://commits.webkit.org/275748@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] db2e97: [view-transitions] Reimport view-transitions WPTs.

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: db2e977c3266b1fa5601ffd6aa305bd3e3584538
  
https://github.com/WebKit/WebKit/commit/db2e977c3266b1fa5601ffd6aa305bd3e3584538
  Author: Matt Woodrow 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/3d-transform-incoming.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/3d-transform-outgoing.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/block-with-overflowing-text.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/break-inside-avoid-child.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-offscreen-child.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-opacity-zero-child.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/capture-with-visibility-mixed-descendants.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/class-specificity-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/class-specificity-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/class-specificity.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/clip-path-larger-than-border-box-on-child-of-named-element-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/clip-path-larger-than-border-box-on-child-of-named-element-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/clip-path-larger-than-border-box-on-child-of-named-element.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/content-with-transform-new-image.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/content-with-transform-old-image.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/css-tags-paint-order-with-entry.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/dialog-in-rtl-iframe.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/far-away-capture.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/fractional-box-with-overflow-children-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/fractional-box-with-overflow-children-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-new-has-scrollbar.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-old-has-scrollbar.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition-destroyed-document-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/inline-with-offset-from-containing-block.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-and-on-top-of-viewport-partially-onscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-and-on-top-of-viewport-partially-onscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-offscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-offscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-partially-onscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-below-viewport-partially-onscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-offscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-offscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-partially-onscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-left-of-viewport-partially-onscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-offscreen-new.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-offscreen-old.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/massive-element-on-top-of-viewport-partially-onscreen-new.html
M 

[webkit-changes] [WebKit/WebKit] 18a97d: [WPE][GTK] Implement portal-based geolocation

[Georges Basile Stavracas Neto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18a97d248bdc97d770550e8887c4096237e84892
  
https://github.com/WebKit/WebKit/commit/18a97d248bdc97d770550e8887c4096237e84892
  Author: Georges Basile Stavracas Neto 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp
M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.h

  Log Message:
  ---
  [WPE][GTK] Implement portal-based geolocation
https://bugs.webkit.org/show_bug.cgi?id=220253

Reviewed by Michael Catanzaro.

This turned into a somewhat messy patch, but the principle behind it is
to try and use the Location portal first, and fallback to the direct
Geoclue calls that it already does.

The Location portal has two particular steps: (1) create a geolocation
session, and (2) start the session and get geolocation updates.

Step 1 is where the location accuracy is set. For this reason, unlike
the direct Geoclue code path, we have to close and recreate the Location
portal session when high accuracy mode changes.

Talking about high accuracy mode, apparently the new value was never
stored into m_isHighAccuracyEnabled! This is fixed in this patch too.

Step 2 is where the Location session is started. Only after this call
that we'd receive geolocation position updates. In theory we'd be able
to pass a parent window handler in this step, and that would allow the
desktop environment to nicely place access control requests on it; that
is not currently supported by WebKit though, so just pass empty string
for now.

The destroy timer is used to release both Portal and Geoclue resources
so name the timer and the corresponding methods to match that. Also
rename Geoclue-specific methods to explicitly mention Geoclue, which
helps following the callback chain.

* Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp:
(WebKit::GeoclueGeolocationProvider::GeoclueGeolocationProvider):
(WebKit::GeoclueGeolocationProvider::start):
(WebKit::GeoclueGeolocationProvider::stop):
(WebKit::GeoclueGeolocationProvider::setEnableHighAccuracy):
(WebKit::GeoclueGeolocationProvider::destroyStateLater):
(WebKit::GeoclueGeolocationProvider::destroyState):
(WebKit::GeoclueGeolocationProvider::acquirePortalProxy):
(WebKit::GeoclueGeolocationProvider::setupPortalProxy):
(WebKit::GeoclueGeolocationProvider::createPortalSession):
(WebKit::GeoclueGeolocationProvider::startPortalSession):
(WebKit::GeoclueGeolocationProvider::portalLocationUpdated):
(WebKit::GeoclueGeolocationProvider::stopPortalSession):
(WebKit::GeoclueGeolocationProvider::createGeoclueManager):
(WebKit::GeoclueGeolocationProvider::setupGeoclueManager):
(WebKit::GeoclueGeolocationProvider::createGeoclueClient):
(WebKit::GeoclueGeolocationProvider::setupGeoclueClient):
(WebKit::GeoclueGeolocationProvider::startGeoclueClient):
(WebKit::GeoclueGeolocationProvider::stopGeoclueClient):
(WebKit::GeoclueGeolocationProvider::requestAccuracyLevel):
(WebKit::GeoclueGeolocationProvider::destroyManagerLater): Deleted.
(WebKit::GeoclueGeolocationProvider::destroyManager): Deleted.
(WebKit::GeoclueGeolocationProvider::setupManager): Deleted.
(WebKit::GeoclueGeolocationProvider::createClient): Deleted.
(WebKit::GeoclueGeolocationProvider::setupClient): Deleted.
(WebKit::GeoclueGeolocationProvider::startClient): Deleted.
(WebKit::GeoclueGeolocationProvider::stopClient): Deleted.
* Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.h:

Canonical link: https://commits.webkit.org/275746@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e156b: IPCTestingAPI crash when creating JS object during...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e156b8a70102f62d01fe0c2ad3f63db148f45d4
  
https://github.com/WebKit/WebKit/commit/2e156b8a70102f62d01fe0c2ad3f63db148f45d4
  Author: Charlie Wolfe 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  ---
  IPCTestingAPI crash when creating JS object during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=270547
rdar://124101628

Reviewed by Alex Christensen.

Some objects send IPC messages during destruction. We should dispatch the 
decoder to the main run loop
to avoid creating a JS object during garbage collection.

* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSMessageListener::willSendMessage):

Canonical link: https://commits.webkit.org/275745@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7cbf03: The functions threadSelfRestrictSupported, threadS...

[TuomasWebKit]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7cbf038b3af6dc95f13ec60e11ddbb1b2ca6b6f6
  
https://github.com/WebKit/WebKit/commit/7cbf038b3af6dc95f13ec60e11ddbb1b2ca6b6f6
  Author: Tuomas Karkkainen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/FastJITPermissions.h

  Log Message:
  ---
  The functions threadSelfRestrictSupported, threadSelfRestrictRWXToRW and 
threadSelfRestrictRWXToRX are incompatible with AddressSanitizer.
https://bugs.webkit.org/show_bug.cgi?id=270569

Reviewed by Keith Miller.

Suppress ASan instrumentation on threadSelfRestrictSupported,
threadSelfRestrictRWXToRW and threadSelfRestrictRWXToRX.

* Source/JavaScriptCore/assembler/FastJITPermissions.h:

Canonical link: https://commits.webkit.org/275744@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c85c7: Make WebCore::WebVTTParser testable

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c85c7c81e33e375407199f3d3668e9d902e93ce
  
https://github.com/WebKit/WebKit/commit/9c85c7c81e33e375407199f3d3668e9d902e93ce
  Author: David Kilzer 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/html/track/VTTRegion.h
M Source/WebCore/html/track/WebVTTParser.h

  Log Message:
  ---
  Make WebCore::WebVTTParser testable
https://bugs.webkit.org/show_bug.cgi?id=270526


Reviewed by Alex Christensen.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Make BufferedLineReader.h and WebVTTParser.h private headers.
* Source/WebCore/html/track/VTTRegion.h:
- Export WebCore::VTTRegion class.
* Source/WebCore/html/track/WebVTTParser.h:
- Export WebCore::WebVTTParser class.
(WebCore::WebVTTParser::WebVTTParser):
- Delete unused default constructor.

Canonical link: https://commits.webkit.org/275743@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8bdf93: Unreviewed, reverting 275736@main

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8bdf93874c28ae11e55e7fb62bc7d3c4d4d44845
  
https://github.com/WebKit/WebKit/commit/8bdf93874c28ae11e55e7fb62bc7d3c4d4d44845
  Author: Marta Darbinyan 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  Unreviewed, reverting 275736@main
rdar://124143076

breaks the builds

Reverted change:

Screen share / getDisplayMedia() buggy behavior and usability issues
https://bugs.webkit.org/show_bug.cgi?id=269961
rdar://123492622
https://commits.webkit.org/275736@main

Canonical link: https://commits.webkit.org/275742@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c97e0: [IFC][Subpixel] Do not mix float and LayoutUnit ty...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c97e0d70826cf9cb8fb388b96ad2da02b9ba6c3
  
https://github.com/WebKit/WebKit/commit/5c97e0d70826cf9cb8fb388b96ad2da02b9ba6c3
  Author: Alan Baradlay 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  [IFC][Subpixel] Do not mix float and LayoutUnit types in 
RenderText::positionForPoint
https://bugs.webkit.org/show_bug.cgi?id=270556

Reviewed by Antti Koivisto.

This is in preparation for removing integral vertical snapping.

Comparing the incoming LayoutUnit { pointBlockDirection } against the float { 
line bottom } provides the expected line range
as long as these values are both snapped to integral pixel values (as the 
result of integral based (vertical) line layout),
but once the snapping is removed, this incoming (and implicitly floored float 
when converted to LayoutUnit) value may not fall into the expected 
(non-snapped) line range.
Let's use the same type (with the same rounding strategy) to find "position for 
point".

* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):

Canonical link: https://commits.webkit.org/275741@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53ebed: [WebGPU] createView on a rgba16float canvas may crash

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53ebed3cf56ae327cbf832e5b1edd3f1ee0949ab
  
https://github.com/WebKit/WebKit/commit/53ebed3cf56ae327cbf832e5b1edd3f1ee0949ab
  Author: Mike Wyrzykowski 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  ---
  [WebGPU] createView on a rgba16float canvas may crash
https://bugs.webkit.org/show_bug.cgi?id=270559


Reviewed by Alex Christensen.

We were setting the pixel format to bgra8unorm but leaving
the WGPU texture format as rgba16float.

That is incorrect.

Additionally add validation around createView in a few additional
places.

* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::textureViewFormatCompatible):
(WebGPU::Device::errorValidatingTextureCreation):
(WebGPU::Texture::createView):
(WebGPU::textureViewFormatCompatible): Deleted.

Canonical link: https://commits.webkit.org/275740@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1b1dcd: Make WTF::Identified work with strongly typed iden...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b1dcd66b5d65444ff9e2c75ef940712ba2c31e1
  
https://github.com/WebKit/WebKit/commit/1b1dcd66b5d65444ff9e2c75ef940712ba2c31e1
  Author: Chris Dumez 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WTF/wtf/Identified.h
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.h
M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
M Source/WebCore/Modules/mediastream/UserMediaRequest.h
M Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h
M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.h
M Source/WebCore/dom/BroadcastChannel.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp
M Source/WebCore/workers/service/background-fetch/BackgroundFetch.h
M Source/WebCore/workers/service/server/SWServerRegistration.cpp
M Source/WebCore/workers/service/server/SWServerRegistration.h
M Source/WebCore/workers/service/server/SWServerToContextConnection.cpp
M Source/WebCore/workers/service/server/SWServerToContextConnection.h
M Source/WebCore/workers/shared/SharedWorker.cpp
M Source/WebCore/workers/shared/SharedWorker.h
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.cpp
M Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.h
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp
M Source/WebKit/NetworkProcess/storage/CacheStorageCache.h
M Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp
M Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.h
M Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp
M Source/WebKit/NetworkProcess/storage/StorageAreaBase.h
M Source/WebKit/NetworkProcess/webtransport/NetworkTransportSession.cpp
M Source/WebKit/NetworkProcess/webtransport/NetworkTransportSession.h
M Source/WebKit/Shared/mac/MediaFormatReader/MediaSampleCursor.h
M Source/WebKit/UIProcess/API/APIUserScript.h
M Source/WebKit/UIProcess/API/APIUserStyleSheet.h
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M Source/WebKit/UIProcess/DrawingAreaProxy.cpp
M Source/WebKit/UIProcess/DrawingAreaProxy.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionTabCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h
M Source/WebKit/UIProcess/Extensions/WebExtensionController.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h
M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h
M Source/WebKit/UIProcess/Notifications/WebNotification.cpp
M Source/WebKit/UIProcess/Notifications/WebNotification.h
M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
M Source/WebKit/UIProcess/UserContent/WebScriptMessageHandler.h
M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.cpp
M Source/WebKit/UIProcess/UserContent/WebUserContentControllerProxy.h
M Source/WebKit/UIProcess/VisitedLinkStore.cpp
M Source/WebKit/UIProcess/VisitedLinkStore.h
M Source/WebKit/UIProcess/WebURLSchemeHandler.cpp
M Source/WebKit/UIProcess/WebURLSchemeHandler.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h
M Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.h
M Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.h
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.h
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h
M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCResolver.h
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.cpp
M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCSocket.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm
M Source/WebKit/WebProcess/

[webkit-changes] [WebKit/WebKit] 4e0d0a: Conversion from rgba to rg8unorm should copy corre...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e0d0a195db543549fc827e2252061de45c22016
  
https://github.com/WebKit/WebKit/commit/4e0d0a195db543549fc827e2252061de45c22016
  Author: Alex Christensen 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A LayoutTests/fast/webgpu/conversion-to-rg8unorm-expected.txt
A LayoutTests/fast/webgpu/conversion-to-rg8unorm.html
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp

  Log Message:
  ---
  Conversion from rgba to rg8unorm should copy correct pixel values
https://bugs.webkit.org/show_bug.cgi?id=270558
rdar://123810638

Reviewed by Mike Wyrzykowski.

* LayoutTests/fast/webgpu/conversion-to-rg8unorm-expected.txt: Added.
* LayoutTests/fast/webgpu/conversion-to-rg8unorm.html: Added.
* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::copyToDestinationFormat):

Canonical link: https://commits.webkit.org/275738@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efc027: [Buildstream SDK] Bump to GStreamer 1.24.0

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efc0277033e84490380da8ad08c870369ad517ac
  
https://github.com/WebKit/WebKit/commit/efc0277033e84490380da8ad08c870369ad517ac
  Author: Philippe Normand 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Tools/Scripts/webkitpy/port/glib.py
M Tools/buildstream/elements/freedesktop-sdk.bst
R Tools/buildstream/patches/fdo-0001-gstreamer-Additional-patches.patch
R Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.9.patch
A Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.0.patch

  Log Message:
  ---
  [Buildstream SDK] Bump to GStreamer 1.24.0
https://bugs.webkit.org/show_bug.cgi?id=270570

Reviewed by Adrian Perez de Castro.

Update GStreamer from 1.22.9 to 1.24.0 and remove patches previously vendored 
and now shipping in
1.24.0.

* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/patches/fdo-0001-gstreamer-Additional-patches.patch: 
Removed.
* Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.24.0.patch: Renamed 
from Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.9.patch.

Canonical link: https://commits.webkit.org/275737@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad5541: Screen share / getDisplayMedia() buggy behavior an...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad55417ef5c24635d3716669d74cf18dc6bbf60f
  
https://github.com/WebKit/WebKit/commit/ad55417ef5c24635d3716669d74cf18dc6bbf60f
  Author: Youenn Fablet 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

  Log Message:
  ---
  Screen share / getDisplayMedia() buggy behavior and usability issues
https://bugs.webkit.org/show_bug.cgi?id=269961
rdar://123492622

Reviewed by Eric Carlson.

The default width and height if not set are 1920x1080, which might not align 
with the actual window/screen sizes.
This triggers adding black pixels to preserve the aspect ratio.
If width and height are not provided, we use SCContentFilter contentRect 
information to fill width and height.

Manually tested for both window and screen capture.
This does not yet the case of window size changing, this will be done as a 
follow-up.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::streamConfiguration):

Canonical link: https://commits.webkit.org/275736@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 432956: [GTK] [l10n] Updated Turkish translation of WebKitGTK

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 432956a238f1ecc4cd7e56fe656d33eba45638f8
  
https://github.com/WebKit/WebKit/commit/432956a238f1ecc4cd7e56fe656d33eba45638f8
  Author: Michael Catanzaro 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/gtk/po/tr.po

  Log Message:
  ---
  [GTK] [l10n] Updated Turkish translation of WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=269675

Unreviewed translation update.

* Source/WebCore/platform/gtk/po/tr.po:

Canonical link: https://commits.webkit.org/275003@main


  Commit: 30ffd82eb335550207b01dd6993134877a1555d6
  
https://github.com/WebKit/WebKit/commit/30ffd82eb335550207b01dd6993134877a1555d6
  Author: Michael Catanzaro 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/gtk/po/sv.po

  Log Message:
  ---
  Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=270035

Unreviewed translation update.

* Source/WebCore/platform/gtk/po/sv.po:

Canonical link: https://commits.webkit.org/275344@main


  Commit: cb47b05e152cc32c4a6dfc8c44dd2b137271735f
  
https://github.com/WebKit/WebKit/commit/cb47b05e152cc32c4a6dfc8c44dd2b137271735f
  Author: Michael Catanzaro 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/gtk/po/pl.po

  Log Message:
  ---
  [GTK][l10n] Updated Polish translation of WebKitGTK for 2.44
https://bugs.webkit.org/show_bug.cgi?id=270412

Unreviewed translation update.

* Source/WebCore/platform/gtk/po/pl.po:

Canonical link: https://commits.webkit.org/275626@main


  Commit: c44311bdc6abc567dd860ff4f7685e11f0700341
  
https://github.com/WebKit/WebKit/commit/c44311bdc6abc567dd860ff4f7685e11f0700341
  Author: Michael Catanzaro 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/platform/gtk/po/de.po

  Log Message:
  ---
  Proof-read German translation update
https://bugs.webkit.org/show_bug.cgi?id=270542

Unreviewed translation update.

* Source/WebCore/platform/gtk/po/de.po:

Canonical link: https://commits.webkit.org/275719@main


Compare: https://github.com/WebKit/WebKit/compare/e764fa239f8f...c44311bdc6ab

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6231f: `BackgroundPainter::paintFillLayers` should check ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6231f750f4e26e71cdf3c0f1d2fbb81879c665b
  
https://github.com/WebKit/WebKit/commit/b6231f750f4e26e71cdf3c0f1d2fbb81879c665b
  Author: Ahmad Saleem 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
A 
LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image-expected-mismatch.html
A LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image.html
M Source/WebCore/rendering/BackgroundPainter.cpp

  Log Message:
  ---
  `BackgroundPainter::paintFillLayers` should check box-shadow when finding an 
opaque layer

https://bugs.webkit.org/show_bug.cgi?id=250882
rdar://problem/104722307

Reviewed by Antti Koivisto.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: 
https://chromium.googlesource.com/chromium/blink/+/a48f4540763c24adff42b9b77d719597f51482f6

BackgroundPainter::paintFillLayers has a fast path when a layer has an opaque 
background image.
If a layer has an opaque background image, basically the layer's background 
layers will be
hidden by the background image. So we can skip rendering the background layers.
However, if box-shadow is also specified, the box-shadow will be rendered in a 
skipped background layer.

This causes "box-shadow disappears". We cannot use the fast path if box-shadow 
is specified.

* Source/WebCore/rendering/BackgroundPainter.cpp:
(BackgroundPainter::paintFillLayers):
* LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image.html: Add 
Test Case
* 
LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image-expected-mismatch.html:
 Add Test Case Expectation Mismatch

Canonical link: https://commits.webkit.org/275735@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c60281: Inline CustomElementElementQueue into CustomElemen...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c602819ddeb10b0600e9c1adebce3a73686f1ead
  
https://github.com/WebKit/WebKit/commit/c602819ddeb10b0600e9c1adebce3a73686f1ead
  Author: Ryosuke Niwa 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/dom/CustomElementReactionQueue.cpp
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/GCReachableRef.h

  Log Message:
  ---
  Inline CustomElementElementQueue into CustomElementReactionStack
https://bugs.webkit.org/show_bug.cgi?id=270551

Reviewed by Chris Dumez.

Inline CustomElementElementQueue into CustomElementReactionStack to avoid heap 
allocation.

* Source/WebCore/dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementQueue::processQueue):
(WebCore::CustomElementReactionQueue::enqueueElementOnAppropriateElementQueue):
(WebCore::CustomElementReactionStack::processQueue): Deleted.
(WebCore::CustomElementReactionStack::takeElements): Deleted.
* Source/WebCore/dom/CustomElementReactionQueue.h:
(WebCore::CustomElementQueue::CustomElementQueue): Inlined.
(WebCore::CustomElementQueue::~CustomElementQueue): Ditto.
(WebCore::CustomElementQueue::isEmpty const): Added.
(WebCore::CustomElementReactionStack::~CustomElementReactionStack):
(WebCore::CustomElementReactionStack::takeElements): Inlined.
* Source/WebCore/dom/GCReachableRef.h:

Canonical link: https://commits.webkit.org/275734@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9cfcc: REGRESSION (275491@main): [ iOS Debug ] 2x TestWeb...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9cfcceff6a79d150aca63fce8faa01329dc0071
  
https://github.com/WebKit/WebKit/commit/c9cfcceff6a79d150aca63fce8faa01329dc0071
  Author: Jean-Yves Avenard 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp

  Log Message:
  ---
  REGRESSION (275491@main): [ iOS Debug ] 2x 
TestWebKitAPI.WKWebView.PrintToPDFUsingPrint API tests are constant crashes
https://bugs.webkit.org/show_bug.cgi?id=270523
rdar://124076626

Reviewed by Aditya Keerthi.

In 275494@main, HashMap::isValidKey was used to check if the map contained the 
key. This is obviously incorrect.
Use HashMap::contains instead.

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::isAsyncReplyHandlerWithDispatcher):
(IPC::Connection::takeAsyncReplyHandlerWithDispatcherWithLockHeld): Similar to 
taskReplyHandler, check if the key is valid first.

Canonical link: https://commits.webkit.org/275733@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e555f8: [GStreamer] Update version checks for 1.24

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e555f8165998601bfe0a5482457682224f92c334
  
https://github.com/WebKit/WebKit/commit/e555f8165998601bfe0a5482457682224f92c334
  Author: Philippe Normand 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
M 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer] Update version checks for 1.24
https://bugs.webkit.org/show_bug.cgi?id=270514

Reviewed by Xabier Rodriguez-Calvar.

Since GStreamer 1.24.0 is released we no longer need to check for 1.23 
development versions.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addIceCandidate):
* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::handleNewDeinterleavePad):
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):
* Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webKitDMABufVideoSinkConstructed):
* Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp:
(WebCore::BaseSinkPositionFlushWorkaroundProbe::checkIsNeeded):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::resetParserState):
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp:
(WebCore::MediaRecorderPrivateBackend::setSink):
* 
Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp:
(WebCore::RealtimeIncomingSourceGStreamer::registerClient):

Canonical link: https://commits.webkit.org/275732@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 703536: [JSC] Use WriteBarrierEarlyInit for JSLexicalEnvir...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7035360227f653be3b93de01a9f6f324764e1ee9
  
https://github.com/WebKit/WebKit/commit/7035360227f653be3b93de01a9f6f324764e1ee9
  Author: Yusuke Suzuki 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/JSSymbolTableObject.h

  Log Message:
  ---
  [JSC] Use WriteBarrierEarlyInit for JSLexicalEnvironment's 
JSSymbolTableObject initialization
https://bugs.webkit.org/show_bug.cgi?id=270562
rdar://124120607

Reviewed by Alexey Shvayka.

Doing micro-optimization for super frequently allocated object 
(JSLexicalEnvironment). We can use WriteBarrierEarlyInit in the constructor.

* Source/JavaScriptCore/runtime/JSSymbolTableObject.h:
(JSC::JSSymbolTableObject::JSSymbolTableObject):

Canonical link: https://commits.webkit.org/275731@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d9ce6b: REGRESSION(274311@main) YouTube.com in safari Airp...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9ce6b4272d071babd1ff0ee646056cfb06f8b37
  
https://github.com/WebKit/WebKit/commit/d9ce6b4272d071babd1ff0ee646056cfb06f8b37
  Author: Jean-Yves Avenard 
  Date:   2024-03-05 (Tue, 05 Mar 2024)

  Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/MediaPlaybackTarget.h
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.h
M Source/WebCore/platform/graphics/avfoundation/MediaPlaybackTargetCocoa.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.h
R Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.mm
R 
Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.serialization.in
M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.h
M Source/WebCore/platform/mock/MediaPlaybackTargetMock.cpp
M Source/WebCore/platform/mock/MediaPlaybackTargetMock.h
M Source/WebCore/platform/mock/MediaPlaybackTargetPickerMock.cpp
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in
M Source/WebKit/GPUProcess/media/ios/RemoteMediaSessionHelperProxy.cpp
M Source/WebKit/Platform/SourcesCocoa.txt
A Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.h
A Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.mm
A 
Source/WebKit/Platform/cocoa/MediaPlaybackTargetContextSerialized.serialization.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp
M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h
M 
Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.messages.in
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  REGRESSION(274311@main) YouTube.com in safari Airplay connects to ATV 
receiver, no Video plays but only Audio
https://bugs.webkit.org/show_bug.cgi?id=270437
rdar://123467550

Reviewed by Youenn Fablet.

When activating an AirPlay target on a currently playing media element,
the UI process was sending a MediaPlaybackTargetContext to the web process, 
which
would then pass it to the GPUP's AVPlayer.
Following 274311@main, the AVOutputContext found in the 
MediaPlaybackTargetContext
would be serialized/deserialized at each IPC's endpoints. This relied on the
generic AVOutputContext IPC serialization introduced in 271664@main.
However, re-constructing an AVOutputContext in the WP is not allowed by
the sandbox. An AVOutputContext's serialization is made of a global 
identification
string which can be looked up in a global table. This look-uo would always
fail in the WP resulting in an null AVOutputContext being generated.
Subsequently, the GPUP would receive this null AVOutputContext causing the
AirPlay command to never reach the GPUP.

On iOS devices similarly, the GPUP sends the notification that a new 
AVOutputContext had
been selected, sends it to the WP which then re-send it for the GPUP for 
processing.
As above, the transit through the WP would null the AVOutputContext.

We revert to the behaviour pre-274311@main which would use a transient 
SerializedAVOutputContext
to pass a serialized AVOutputContext, with a cache of hasActiveRoute which would
only be reconstructed in the GPUP.
In order to keep the security aspect intended by 274311@main we introduce two
new classes: MediaPlaybackTargetSerialized and 
MediaPlaybackTargetContextSerialized
which will wrap either a MediaPlaybackTargetContextCocoa or a 
MediaPlaybackTargetContextMock.
The underlying AVOutputContext is now never accessed in the WP. Instead we only 
pass
the underlying AVOutputContext's global ID.
We split MediaPlaybackTargetContext into three sub-classes:
- Cocoa/AVOutputContext
- Mock
- Serialized

The MediaPlaybackTargetSerialized now uses the new serialization framework.

Manually tested to work with an ATV and a macOS sonoma as AirPlay target.
Some work covered by MediaPlaybackTargetMock tests; but infrastructure doesn't
allow for comprehensive regression tests.

* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/