[webkit-changes] [WebKit/WebKit] 93c3eb: AX: CSS content property replacement text ignored ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93c3eb8ac99a6b6e3894deaf14e5d38304898b48 https://github.com/WebKit/WebKit/commit/93c3eb8ac99a6b6e3894deaf14e5d38304898b48 Author: Anne van Kesteren Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/accessibility/mac/alt-for-css-content-expected.txt M LayoutTests/accessibility/mac/alt-for-css-content.html M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content-expected.txt M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content.html M Source/WebCore/accessibility/AccessibilityRenderObject.cpp Log Message: --- AX: CSS content property replacement text ignored when it is the empty string https://bugs.webkit.org/show_bug.cgi?id=270377 rdar://123919677 Reviewed by Antoine Quint. This issue came to light as part of the demo, but is more universally applicable as shown in the tests. While here, also cleanup some of the code as the render objects involved cannot become null. New web-platform-tests tests are exported: https://github.com/web-platform-tests/wpt/pull/44971 * LayoutTests/accessibility/mac/alt-for-css-content-expected.txt: * LayoutTests/accessibility/mac/alt-for-css-content.html: * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content.html: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement const): Canonical link: https://commits.webkit.org/275872@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88f3f5: Remove iPhone 7 from run-webkit-tests simulator te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88f3f506d43c730daa25817facdf855d1d379334 https://github.com/WebKit/WebKit/commit/88f3f506d43c730daa25817facdf855d1d379334 Author: Ben Schwartz Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py M Tools/Scripts/webkitpy/port/ios_simulator.py Log Message: --- Remove iPhone 7 from run-webkit-tests simulator testing. https://bugs.webkit.org/show_bug.cgi?id=270708 rdar://124253881 Reviewed by Ryan Haddad. run-webkit-tests will check for the existence of iPhone 7-specific test expectations as one of its steps. As we have not tested on iPhone 7 simulators for many years, this PR removes that call. * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Removed iPhone 7 device configuration presence unit test. (RunTest.test_device_type_test_division): Removed iPhone 7 device configuration presence unit test. (RunTest.test_device_type_specific_listing): Removed iPhone 7 device configuration presence unit test. * Tools/Scripts/webkitpy/port/ios_simulator.py: Removed iPhone 7 device configuration. (IOSSimulatorPort): Removed iPhone 7 device configuration. (IPhoneSimulatorPort): Removed iPhone 7 device configuration. Canonical link: https://commits.webkit.org/275871@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 71f450: Remove WTF::LegacyThreadSafeIdentified now that it...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71f4504aff74ff64373f68844fe991bf7dd0ab6a https://github.com/WebKit/WebKit/commit/71f4504aff74ff64373f68844fe991bf7dd0ab6a Author: Chris Dumez Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/Identified.h Log Message: --- Remove WTF::LegacyThreadSafeIdentified now that it is no longer used https://bugs.webkit.org/show_bug.cgi?id=270730 Reviewed by Darin Adler. * Source/WTF/wtf/Identified.h: (WTF::LegacyThreadSafeIdentified::LegacyThreadSafeIdentified): Deleted. (WTF::LegacyThreadSafeIdentified::generateIdentifier): Deleted. Canonical link: https://commits.webkit.org/275870@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26caf3: [RenderTreeDump] Remove adjustForTableCells
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26caf360aef3a037b7f92e907aa8603471c8e712 https://github.com/WebKit/WebKit/commit/26caf360aef3a037b7f92e907aa8603471c8e712 Author: Alan Baradlay Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/fast/block/basic/quirk-percent-height-table-cell-expected.txt M LayoutTests/fast/borders/border-radius-different-width-001-expected.txt M LayoutTests/fast/forms/input-appearance-spinbutton-expected.txt M LayoutTests/fast/repaint/subtree-root-clip-3-expected.txt M LayoutTests/fast/repaint/table-cell-vertical-overflow-expected.txt M LayoutTests/fast/table/height-percent-test-expected.txt M LayoutTests/fast/table/height-percent-test-vertical-expected.txt M LayoutTests/fast/table/vertical-align-baseline-readjust-expected.txt M LayoutTests/platform/ios/css1/basic/containment-expected.txt M LayoutTests/platform/ios/css1/basic/contextual_selectors-expected.txt M LayoutTests/platform/ios/css1/basic/grouping-expected.txt M LayoutTests/platform/ios/css1/basic/id_as_selector-expected.txt M LayoutTests/platform/ios/css1/basic/inheritance-expected.txt M LayoutTests/platform/ios/css1/box_properties/border-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_bottom-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_bottom_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_bottom_width-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_bottom_width_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_color-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_color_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_left-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_left_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_left_width-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_left_width_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_right-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_right_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_right_width-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_right_width_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_style-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_style_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_top-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_top_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_top_width-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_top_width_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_width-expected.txt M LayoutTests/platform/ios/css1/box_properties/border_width_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/clear-expected.txt M LayoutTests/platform/ios/css1/box_properties/clear_float-expected.txt M LayoutTests/platform/ios/css1/box_properties/float-expected.txt M LayoutTests/platform/ios/css1/box_properties/float_elements_in_series-expected.txt M LayoutTests/platform/ios/css1/box_properties/float_margin-expected.txt M LayoutTests/platform/ios/css1/box_properties/float_on_text_elements-expected.txt M LayoutTests/platform/ios/css1/box_properties/height-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_bottom-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_bottom_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_left-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_left_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_right-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_right_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_top-expected.txt M LayoutTests/platform/ios/css1/box_properties/margin_top_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding_bottom-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding_bottom_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding_inline-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding_left-expected.txt M LayoutTests/platform/ios/css1/box_properties/padding_left_inline-expected.txt
[webkit-changes] [WebKit/WebKit] 3feec6: [JSC] Combine FTL code generation into one
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3feec6ad3154fd9e99b455a8d5e9609402b6602f https://github.com/WebKit/WebKit/commit/3feec6ad3154fd9e99b455a8d5e9609402b6602f Author: Yusuke Suzuki Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/b3/air/AirDisassembler.cpp M Source/JavaScriptCore/ftl/FTLCompile.cpp R Source/JavaScriptCore/ftl/FTLGeneratedFunction.h M Source/JavaScriptCore/ftl/FTLJITCode.cpp M Source/JavaScriptCore/ftl/FTLJITCode.h M Source/JavaScriptCore/ftl/FTLJITFinalizer.h M Source/JavaScriptCore/ftl/FTLLink.cpp M Source/JavaScriptCore/ftl/FTLState.h Log Message: --- [JSC] Combine FTL code generation into one https://bugs.webkit.org/show_bug.cgi?id=270684 rdar://124259821 Reviewed by Justin Michaud. This patch simplifies FTL code generation. Previously we were always generating two codes, one for normal code and one for arity check etc. But just generating both into one is easy and simple. This patch cleans up around it and use of LinkBuffer / AssemblerData etc. gets simplified. Originally we were doing so since FTL part is generated by LLVM, and we generate arity check as a separate code, but now both are generated by JSC's JIT compiler. So we do not need to separate them. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/b3/air/AirDisassembler.cpp: (JSC::B3::Air::Disassembler::dump): * Source/JavaScriptCore/ftl/FTLCompile.cpp: (JSC::FTL::compile): * Source/JavaScriptCore/ftl/FTLGeneratedFunction.h: Removed. * Source/JavaScriptCore/ftl/FTLJITCode.cpp: (JSC::FTL::JITCode::~JITCode): (JSC::FTL::JITCode::initializeAddressForArityCheck): (JSC::FTL::JITCode::addressForCall): (JSC::FTL::JITCode::initializeArityCheckEntrypoint): Deleted. * Source/JavaScriptCore/ftl/FTLJITCode.h: * Source/JavaScriptCore/ftl/FTLJITFinalizer.h: * Source/JavaScriptCore/ftl/FTLLink.cpp: (JSC::FTL::link): * Source/JavaScriptCore/ftl/FTLState.h: Canonical link: https://commits.webkit.org/275868@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4258ba: Unreviewed. Fix the link title for Speedometer 3 a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4258bae584fc4274143ea607676fca5aec28403e https://github.com/WebKit/WebKit/commit/4258bae584fc4274143ea607676fca5aec28403e Author: Ryosuke Niwa Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Websites/browserbench.org/announcements/index.html Log Message: --- Unreviewed. Fix the link title for Speedometer 3 announcement. * Websites/browserbench.org/announcements/index.html: Canonical link: https://commits.webkit.org/275867@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf7239: [git-webkit revert] Add tabs to separate reverted ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf72395f4ed4676758133ecbae57ce8151406398 https://github.com/WebKit/WebKit/commit/cf72395f4ed4676758133ecbae57ce8151406398 Author: Brianna Fan Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py Log Message: --- [git-webkit revert] Add tabs to separate reverted changes in commit message https://bugs.webkit.org/show_bug.cgi?id=270706 rdar://problem/124287051 Reviewed by Ryan Haddad. Adds indentation for the reverted changeset for better readability. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py: (Revert.create_revert_commit_msg): Canonical link: https://commits.webkit.org/275866@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3aba39: Add target for webm_fuzzer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3aba3902984e20a3e6fbb49cda2049b7f5106618 https://github.com/WebKit/WebKit/commit/3aba3902984e20a3e6fbb49cda2049b7f5106618 Author: David Kilzer Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A Source/ThirdParty/libwebrtc/Configurations/BaseTarget-libwebm.xcconfig M Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/Configurations/h265_bitstream_parser_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig A Source/ThirdParty/libwebrtc/Configurations/webm_fuzzer.xcconfig M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj Log Message: --- Add target for webm_fuzzer https://bugs.webkit.org/show_bug.cgi?id=270712 Reviewed by Alex Christensen. * Source/ThirdParty/libwebrtc/Configurations/h264_bitstream_parser_fuzzer.xcconfig: (PRODUCT_NAME): Add. * Source/ThirdParty/libwebrtc/Configurations/h265_bitstream_parser_fuzzer.xcconfig: (PRODUCT_NAME): Add. - Drive-by fix to add PRODUCT_NAME to each xcconfig file. * Source/ThirdParty/libwebrtc/Configurations/BaseTarget-libwebm.xcconfig: Copied from Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig. * Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig: - Extract common variables from libwebm.xcconfig into BaseTarget-libwebm.xcconfig. * Source/ThirdParty/libwebrtc/Configurations/webm_fuzzer.xcconfig: Add. * Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj: - Drive-by fix to remove redundant PRODUCT_NAME variables from various targets. (Fuzzers (libwebrtc)): - Add webm_fuzzer as dependency to aggregate target. (webm_fuzzer target): Add. - Add target to build webm_fuzzer. Canonical link: https://commits.webkit.org/275865@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 04727d: Allow text selection in browserbench.org announcem...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 04727dd559ff23b9496990e2bb4aefdb62c3a368 https://github.com/WebKit/WebKit/commit/04727dd559ff23b9496990e2bb4aefdb62c3a368 Author: Ryosuke Niwa Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Websites/browserbench.org/index.html M Websites/browserbench.org/resources/main.css Log Message: --- Allow text selection in browserbench.org announcements https://bugs.webkit.org/show_bug.cgi?id=270725 Reviewed by Aditya Keerthi. Apply -webkit-user-select: none only to the top page. Also specify unprefixed version to make it work on other browsers. * Websites/browserbench.org/index.html: * Websites/browserbench.org/resources/main.css: (body): (body.benchmark-index): (img): Canonical link: https://commits.webkit.org/275864@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38c6ec: Non-unified build fixes, early March 2024 edition
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38c6ecad0ea32e80cb3e811c3ff759074006791f https://github.com/WebKit/WebKit/commit/38c6ecad0ea32e80cb3e811c3ff759074006791f Author: Don Olmstead Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/jit/JITSizeStatistics.cpp M Source/WebCore/Modules/model-element/ModelPlayerClient.h M Source/WebCore/css/CSSCrossfadeValue.h M Source/WebCore/css/CSSImageSetOptionValue.cpp M Source/WebCore/css/CSSImageSetOptionValue.h M Source/WebCore/css/CSSReflectValue.cpp M Source/WebCore/css/CSSReflectValue.h M Source/WebCore/css/CSSShadowValue.h M Source/WebCore/css/CSSValuePair.cpp M Source/WebCore/css/CSSValuePair.h M Source/WebCore/dom/SlotAssignment.h M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/rendering/svg/RenderSVGPath.cpp M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp M Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/FrameProcess.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp Log Message: --- Non-unified build fixes, early March 2024 edition https://bugs.webkit.org/show_bug.cgi?id=270719 Unreviewed non-unified build fix. * Source/JavaScriptCore/jit/JITSizeStatistics.cpp: * Source/WebCore/Modules/model-element/ModelPlayerClient.h: * Source/WebCore/css/CSSCrossfadeValue.h: * Source/WebCore/css/CSSImageSetOptionValue.cpp: * Source/WebCore/css/CSSImageSetOptionValue.h: * Source/WebCore/css/CSSReflectValue.cpp: * Source/WebCore/css/CSSReflectValue.h: * Source/WebCore/css/CSSShadowValue.h: * Source/WebCore/css/CSSValuePair.cpp: * Source/WebCore/css/CSSValuePair.h: * Source/WebCore/dom/SlotAssignment.h: * Source/WebCore/dom/TrustedType.cpp: * Source/WebCore/rendering/svg/RenderSVGPath.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: * Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp: * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: * Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: * Source/WebKit/UIProcess/FrameProcess.cpp: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: Canonical link: https://commits.webkit.org/275863@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bcbaf: [Gardening]: [ MacOS iOS ] svg/custom/svg-fonts-in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1bcbaf612c2ffbce09e1d14c53ee98a65a150b9a https://github.com/WebKit/WebKit/commit/1bcbaf612c2ffbce09e1d14c53ee98a65a150b9a Author: Jay Stfleur Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations A LayoutTests/platform/ios-wk2/svg/custom/svg-fonts-in-html-expected.txt M LayoutTests/platform/mac-ventura/svg/custom/svg-fonts-in-html-expected.txt M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [ MacOS iOS ] svg/custom/svg-fonts-in-html.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270315 rdar://123854058 Unreviewed test gardening. Added new baseline for iOS and Ventura * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios-wk2/svg/custom/svg-fonts-in-html-expected.txt: Added. * LayoutTests/platform/mac-ventura/svg/custom/svg-fonts-in-html-expected.txt: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275862@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7f56a: Add browserbench.org announcements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7f56ab4bb40f03c8d17051d59422fb62727809f https://github.com/WebKit/WebKit/commit/a7f56ab4bb40f03c8d17051d59422fb62727809f Author: Jonathan Davis Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A Websites/browserbench.org/announcements/index.html A Websites/browserbench.org/announcements/speedometer3/index.html A Websites/browserbench.org/announcements/speedometer3/preview.png M Websites/browserbench.org/index.html M Websites/browserbench.org/resources/main.css Log Message: --- Add browserbench.org announcements https://bugs.webkit.org/show_bug.cgi?id=270714 Reviewed by Ryosuke Niwa. * Websites/browserbench.org/announcements/index.html: Added. * Websites/browserbench.org/announcements/speedometer3/index.html: Added. * Websites/browserbench.org/announcements/speedometer3/preview.png: Added. * Websites/browserbench.org/index.html: * Websites/browserbench.org/resources/main.css: (#logo a): (.benchmark img): (.other a): (.benchmarks + .announcements): (.announcements): (.announcements h1): (.announcements a): (.announcements .date): (article): (main .navigation a,): (main .navigation a:hover,): (article h1): (article .byline): (article .byline .date): (article img): Canonical link: https://commits.webkit.org/275861@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9217a2: Fix Windows debug build after 275825@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9217a22a4000c04ee2da5624fc38b58415701a84 https://github.com/WebKit/WebKit/commit/9217a22a4000c04ee2da5624fc38b58415701a84 Author: Don Olmstead Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp Log Message: --- Fix Windows debug build after 275825@main https://bugs.webkit.org/show_bug.cgi?id=270720 Unreviewed build fix. Add a missing `HAVE(IOSURFACE)` guard. * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: Canonical link: https://commits.webkit.org/275860@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f606e5: WebExtensionContext::permissionsRequest needs to p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f606e5e964d5dcd860e4a6625db8092664bbc05c https://github.com/WebKit/WebKit/commit/f606e5e964d5dcd860e4a6625db8092664bbc05c Author: Timothy Hatcher Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm Log Message: --- WebExtensionContext::permissionsRequest needs to properly capture completionHandler. https://webkit.org/b/269678 rdar://problem/123197187 Reviewed by Brian Weinstein. Rework permissions.request() to only call the delegate if needed, never with an empty set. Also the completionHandler only worked if it was called immediately, but we need to support it being called later. To support all this, a CallbackAggregator was needed and it now waits for both delegates to be called (in either order) since they both retain the aggregator. This also changes the handling to better match the permissions.request() API, by only allowing granting all or none, not some. Added a test for this. Also updated the tests to not use nil, since the block parameters are not nullable. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm: (WebKit::WebExtensionContext::permissionsRequest): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm: (WebKit::WebExtensionContext::runtimeSendNativeMessage): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIPermissions.mm: (TEST(WKWebExtensionAPIPermissions, Basics)): Renamed. (TEST(WKWebExtensionAPIPermissions, AcceptPermissionsRequest)): Updated. (TEST(WKWebExtensionAPIPermissions, DenyPermissionsRequest)): Updated. (TEST(WKWebExtensionAPIPermissions, AcceptPermissionsDenyMatchPatternsRequest)): Updated. (TEST(WKWebExtensionAPIPermissions, RequestPermissionsOnly)): Updated. (TEST(WKWebExtensionAPIPermissions, RequestMatchPatternsOnly)): Updated. (TEST(WKWebExtensionAPIPermissions, GrantOnlySomePermissions)): Added. (TEST(WKWebExtensionAPIPermissions, GrantOnlySomeMatchPatterns)): Added. Canonical link: https://commits.webkit.org/275859@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c76d3a: Unreviewed, reverting 275857@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c76d3aa189af8174847229cb619b5bc930f31995 https://github.com/WebKit/WebKit/commit/c76d3aa189af8174847229cb619b5bc930f31995 Author: Commit Queue Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/Configurations/BaseXPCService.xcconfig M Source/WebKit/Configurations/GPUService.xcconfig M Source/WebKit/Configurations/NetworkService.xcconfig M Source/WebKit/Configurations/WebContentService.xcconfig M Source/WebKit/Configurations/WebKit.xcconfig Log Message: --- Unreviewed, reverting 275857@main. https://bugs.webkit.org/show_bug.cgi?id=270717 Can potentially break perf testing Reverted changeset: "Enable WebKit process extensions on newer OS versions" https://bugs.webkit.org/show_bug.cgi?id=270444 https://commits.webkit.org/275857@main Canonical link: https://commits.webkit.org/275858@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b976b6: Enable WebKit process extensions on newer OS versions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b976b6b01acf01bc6c34b774db27ebfa0f84f923 https://github.com/WebKit/WebKit/commit/b976b6b01acf01bc6c34b774db27ebfa0f84f923 Author: Per Arne Vollan Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebKit/Configurations/BaseExtension.xcconfig M Source/WebKit/Configurations/BaseXPCService.xcconfig M Source/WebKit/Configurations/GPUService.xcconfig M Source/WebKit/Configurations/NetworkService.xcconfig M Source/WebKit/Configurations/WebContentService.xcconfig M Source/WebKit/Configurations/WebKit.xcconfig Log Message: --- Enable WebKit process extensions on newer OS versions https://bugs.webkit.org/show_bug.cgi?id=270444 rdar://124008037 Reviewed by Chris Dumez. * Source/WebKit/Configurations/BaseExtension.xcconfig: * Source/WebKit/Configurations/BaseXPCService.xcconfig: * Source/WebKit/Configurations/GPUService.xcconfig: * Source/WebKit/Configurations/NetworkService.xcconfig: * Source/WebKit/Configurations/WebContentService.xcconfig: * Source/WebKit/Configurations/WebKit.xcconfig: Canonical link: https://commits.webkit.org/275857@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2cb2e: Convert AppleInterchangeNewline and AppleConverted...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2cb2e25ea8d52946b02a1b93b17cc031c24c7ac https://github.com/WebKit/WebKit/commit/f2cb2e25ea8d52946b02a1b93b17cc031c24c7ac Author: Richard Robinson Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/editing/HTMLInterchange.cpp M Source/WebCore/editing/HTMLInterchange.h M Source/WebCore/editing/ReplaceSelectionCommand.cpp M Source/WebCore/editing/cocoa/HTMLConverter.mm M Source/WebCore/editing/markup.cpp Log Message: --- Convert AppleInterchangeNewline and AppleConvertedSpace to be constant expressions instead of macros https://bugs.webkit.org/show_bug.cgi?id=270710 rdar://124290908 Reviewed by Abrar Rahman Protyasha and Ryosuke Niwa. * Source/WebCore/editing/HTMLInterchange.cpp: (WebCore::convertHTMLTextToInterchangeFormat): * Source/WebCore/editing/HTMLInterchange.h: * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): (WebCore::isInterchangeConvertedSpaceSpan): (WebCore::isInlineNodeWithStyle): * Source/WebCore/editing/cocoa/HTMLConverter.mm: (HTMLConverter::_processElement): * Source/WebCore/editing/markup.cpp: (WebCore::serializePreservingVisualAppearanceInternal): (WebCore::createFragmentFromText): Canonical link: https://commits.webkit.org/275856@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bda55e: [Garderning]: NEW TEST [ Ventura ] imported/w3c/we...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bda55eccbe3678ccf3e0141ef1dee054ca5d33b1 https://github.com/WebKit/WebKit/commit/bda55eccbe3678ccf3e0141ef1dee054ca5d33b1 Author: Jay Stfleur Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/html/rendering/widget/field-sizing-input-text-expected.txt M LayoutTests/platform/mac/TestExpectations Log Message: --- [Garderning]: NEW TEST [ Ventura ] imported/w3c/web-platform-tests/html/rendering/widget/field-sizing-input-text.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270656 rdar://124224461 Unreviewed test gardening. Removed test expectation and added baseline * LayoutTests/platform/mac-ventura/imported/w3c/web-platform-tests/html/rendering/widget/field-sizing-input-text-expected.txt: Added. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275855@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5a7d8: [Gardening]: NEW TEST[ Ventura WK2 ] accessibility...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5a7d8ccd633879e37dbed426114d2b29ee8f5ce https://github.com/WebKit/WebKit/commit/c5a7d8ccd633879e37dbed426114d2b29ee8f5ce Author: Jay Stfleur Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: NEW TEST[ Ventura WK2 ] accessibility/datetime/input-time-label-value.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=123857904 rdar://123857904 Unreviewed test gardening. Removing TestExpectations after rebaseline was added * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275854@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acfa63: Add disassembleBase64 function to jsc cli
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acfa63bc90bc133dab16f9512a77fe159adcb5b7 https://github.com/WebKit/WebKit/commit/acfa63bc90bc133dab16f9512a77fe159adcb5b7 Author: Keith Miller Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/disassembler/Disassembler.h M Source/JavaScriptCore/jsc.cpp Log Message: --- Add disassembleBase64 function to jsc cli https://bugs.webkit.org/show_bug.cgi?id=270707 rdar://124288714 Reviewed by Justin Michaud. Sometimes we get crash reports that have some assembly around the crashing JIT pc. This code is encoded in base64 but unfortunately `btoa` gives the code back with the wrong endianness, I think anyway. Rather than figure out how to flip the endianness I just decided to roll everything into one function. * Source/JavaScriptCore/disassembler/Disassembler.h: * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::data const): Canonical link: https://commits.webkit.org/275853@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3eeec6: [build.webkit.org] Add support for uploading build...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3eeec64b18a5f280bb412571611db77c3cd07037 https://github.com/WebKit/WebKit/commit/3eeec64b18a5f280bb412571611db77c3cd07037 Author: Brianna Fan Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/steps_unittest.py Log Message: --- [build.webkit.org] Add support for uploading build logs to S3 https://bugs.webkit.org/show_bug.cgi?id=270128 rdar://123655339 Reviewed by Aakash Jain. Adds UploadFileToS3 and GenerateS3URL steps to build.webkit.org. * Tools/CISupport/build-webkit-org/steps.py: (CheckOutSource.getResultSummary): Set 'revision' build property. (UploadFileToS3): (UploadFileToS3.__init__): (UploadFileToS3.getLastBuildStepByName): (UploadFileToS3.run): (UploadFileToS3.doStepIf): (UploadFileToS3.getResultSummary): (GenerateS3URL): (GenerateS3URL.__init__): (GenerateS3URL.run): (GenerateS3URL.hideStepIf): (GenerateS3URL.doStepIf): (GenerateS3URL.getResultSummary): * Tools/CISupport/build-webkit-org/steps_unittest.py: Canonical link: https://commits.webkit.org/275852@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec04ba: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec04baed9c99710129a149617a291fe6f21e6331 https://github.com/WebKit/WebKit/commit/ec04baed9c99710129a149617a291fe6f21e6331 Author: Dan Robson Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7619.1.6 Canonical link: https://commits.webkit.org/275851@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9cc9a: Rename RenderStyle effectiveAppearance() to usedAp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9cc9abad98277eaf64ffcea10679967a4114b45 https://github.com/WebKit/WebKit/commit/c9cc9abad98277eaf64ffcea10679967a4114b45 Author: Anne van Kesteren Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/AccessibilitySlider.cpp M Source/WebCore/html/HTMLMeterElement.cpp M Source/WebCore/html/RangeInputType.cpp M Source/WebCore/html/shadow/SliderThumbElement.cpp M Source/WebCore/html/shadow/TextControlInnerElements.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp M Source/WebCore/rendering/RenderAttachment.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderMenuList.cpp M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp M Source/WebCore/rendering/ios/RenderThemeIOS.mm M Source/WebCore/rendering/mac/RenderThemeMac.mm M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp M Source/WebCore/rendering/style/StyleMiscNonInheritedData.h M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Rename RenderStyle effectiveAppearance() to usedAppearance() https://bugs.webkit.org/show_bug.cgi?id=270701 Reviewed by Sam Weinig. This aligns it with terminology used in CSS standards. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isApplePayButton const): * Source/WebCore/accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySlider::orientation const): * Source/WebCore/html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::createElementRenderer): * Source/WebCore/html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): * Source/WebCore/html/shadow/SliderThumbElement.cpp: (WebCore::hasVerticalAppearance): (WebCore::SliderThumbElement::resolveCustomStyle): * Source/WebCore/html/shadow/TextControlInnerElements.cpp: (WebCore::searchFieldStyleHasExplicitlySpecifiedTextFieldAppearance): (WebCore::SearchFieldResultsButtonElement::resolveCustomStyle): * Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp: (WebCore::LayoutIntegration::BoxGeometryUpdater::updateLayoutBoxDimensions): * Source/WebCore/rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::shouldDrawBorder const): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::baselinePosition const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::ensureControlPart): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterStyleChange): (WebCore::RenderLayerScrollableArea::updateScrollbarsAfterLayout): * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::menuStyle const): (RenderMenuList::clientPaddingLeft const): (RenderMenuList::clientPaddingRight const): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustAppearanceForElement const): (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::createControlPart const): (WebCore::effectiveRendererForAppearance): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled const): (WebCore::RenderTheme::supportsFocusRing const): (WebCore::RenderTheme::isDefault const): (WebCore::RenderTheme::adjustButtonOrCheckboxOrColorWellOrInnerSpinButtonOrRadioStyle const): (WebCore::RenderTheme::paintSliderTicks): * Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::supportsFocusRing const): (WebCore::RenderThemeAdwaita::popupInternalPaddingBox const): (WebCore::RenderThemeAdwaita::paintSliderTrack): (WebCore::RenderThemeAdwaita::adjustSliderThumbSize const): (WebCore::RenderThemeAdwaita::paintSliderThumb): * Source/WebCore/rendering/ios/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::canCreateControlPartForRenderer const): (WebCore::RenderThemeIOS::adjustedPaintRect const): (WebCore::RenderThemeIOS::baselinePosition const): (WebCore::RenderThemeIOS::isControlStyled const): (WebCore::RenderThemeIOS::popupInternalPaddingBox const): (WebCore::RenderThemeIOS::adjustRoundBorderRadius): (WebCore::RenderThemeIOS::paintSliderTrack): (WebCore::RenderThemeIOS::adjustSliderThumbSize const): (WebCore::RenderThemeIOS::adjustButtonStyle const): (WebCore::RenderThemeIOS::supportsBoxShadow const): (WebCore::RenderThemeIOS::paintSliderTicks): * Source/WebCore/rendering/mac/RenderThemeMac.mm: (Web
[webkit-changes] [WebKit/WebKit] 27990d: Disable playsinline requirement for MediaStream ba...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27990dcc2c14f0068f25cb249913a52e557865c4 https://github.com/WebKit/WebKit/commit/27990dcc2c14f0068f25cb249913a52e557865c4 Author: Youenn Fablet Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/html/MediaElementSession.cpp Log Message: --- Disable playsinline requirement for MediaStream based HTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=270690 rdar://101353474 Reviewed by Eric Carlson. playsinline is often not set on media elements that render media streams. This triggers a compat issue where the local camera preview might end up being full screen. We disable playsinline requirement for media stream based media elements. The compat risk is very low and is a first step towards disabling playsinline everywhere. * Source/WebCore/html/MediaElementSession.cpp: (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback const): Canonical link: https://commits.webkit.org/275849@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d1d56: [UnifiedPDF] Fix coordinate space for accessibility.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d1d56d4da989bb82028ad08c8d392dc2b3ab51e https://github.com/WebKit/WebKit/commit/0d1d56d4da989bb82028ad08c8d392dc2b3ab51e Author: Elina Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h M Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm Log Message: --- [UnifiedPDF] Fix coordinate space for accessibility. Reviewed by Abrar Rahman Protyasha. - Fix VO cursor position does not match the focused element in unified pdf. There are 2 parts of this change. One in pdfKit and one in webKit - Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin - Remove extra functions - Add new accessibility support api. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::PDFPluginBase): (WebKit::PDFPluginBase::convertFromPDFViewToRootView const): Deleted. (WebKit::PDFPluginBase::convertFromPDFViewToScreenForAccessibility const): Deleted. (WebKit::PDFPluginBase::convertFromRootViewToPDFView const): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::UnifiedPDFPlugin): (WebKit::UnifiedPDFPlugin::accessibilityScrollToPage): (WebKit::UnifiedPDFPlugin::convertFromPDFPageToScreenForAccessibility const): (WebKit::UnifiedPDFPlugin::accessibilityHitTestIntPoint const): * Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.h: * Source/WebKit/WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm: (-[WKAccessibilityPDFDocumentObject setPDFPlugin:]): (-[WKAccessibilityPDFDocumentObject accessibilityFocusedUIElement]): (-[WKAccessibilityPDFDocumentObject accessibilityWindow]): (-[WKAccessibilityPDFDocumentObject accessibilityTopLevelUIElement]): (-[WKAccessibilityPDFDocumentObject accessibilityVisibleChildren]): (-[WKAccessibilityPDFDocumentObject accessibilitySubrole]): (-[WKAccessibilityPDFDocumentObject accessibilityFrame]): (-[WKAccessibilityPDFDocumentObject accessibilityParent]): (-[WKAccessibilityPDFDocumentObject accessibilityAttributeValue:]): (-[WKAccessibilityPDFDocumentObject accessibilityArrayAttributeCount:]): (-[WKAccessibilityPDFDocumentObject accessibilityChildren]): (-[WKAccessibilityPDFDocumentObject convertFromPDFPageToScreenForAccessibility:pageIndex:]): (-[WKAccessibilityPDFDocumentObject accessibilityHitTest:]): (-[WKAccessibilityPDFDocumentObject gotoDestination:]): (-[WKAccessibilityPDFDocumentObject parent]): Deleted. [UnifiedPDF] Fix coordinate space for accessibility https://bugs.webkit.org/show_bug.cgi?id=269956 rdar://123459892 Reviewed by Abrar Rahman Protyasha. - Fix VO cursor position does not match the focused element in unified pdf. There are 2 parts of this change. One in pdfKit and one in webKit - Update the plugin in WKAccessibilityDocumentObject to UnifiedPDFPlugin - Remove extra functions - Add new accessibility support api Canonical link: https://commits.webkit.org/275848@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bf1b8: Speed up WebExtensionContext::getCurrentTab().
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bf1b8f92e693edcb769f2935e864fa0a3752a96 https://github.com/WebKit/WebKit/commit/5bf1b8f92e693edcb769f2935e864fa0a3752a96 Author: Timothy Hatcher Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm Log Message: --- Speed up WebExtensionContext::getCurrentTab(). https://webkit.org/b/270644 rdar://problem/124222506 Reviewed by Brian Weinstein. Simplify the logic in getCurrentTab() by returning early if the page is a know extension page, and IncludeExtensionViews::No. This prevents logging an error "Tab for page XX was not found" and avoids looping through open tabs. Also removed the deep nesting, and added gotos to skip to the end checks faster. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::getCurrentTab const): Canonical link: https://commits.webkit.org/275847@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 226f99: [Gardening]: REGRESSION (275711@main): [ macOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 226f99e4c9e411890199f44972493f8bd2c7a56a https://github.com/WebKit/WebKit/commit/226f99e4c9e411890199f44972493f8bd2c7a56a Author: Karl Rackler Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (275711@main): [ macOS iOS wk2 ] 4 http/wpt/webauthn/public-key-credential tests are a consistent failure https://bugs.webkit.org/show_bug.cgi?id=270673 rdar://124229592 Unreviewed test gardening. Modifying test expectations. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275846@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f9503: [JSC] Fix thread-local AssemblerBuffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f9503bb480411badefe27802aff3edc4dc131a9 https://github.com/WebKit/WebKit/commit/6f9503bb480411badefe27802aff3edc4dc131a9 Author: Yusuke Suzuki Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/assembler/AssemblerBuffer.cpp M Source/JavaScriptCore/assembler/AssemblerBuffer.h M Source/JavaScriptCore/assembler/LinkBuffer.h Log Message: --- [JSC] Fix thread-local AssemblerBuffer https://bugs.webkit.org/show_bug.cgi?id=270642 rdar://124221850 Reviewed by Keith Miller. ARM64EHash broke thread-local AssemblerBuffer mechanism since it took the ownership of AssemblerData (not AssemblerBuffer) from MacroAssembler to LinkBuffer. So when destroying AssemblerBuffer, its underlying AssemblerData is always zero-sized. This broke thread-local AssemblerBuffer mechanism. This patch fixes it by 1. Moving thread-local AssemblerData access code from AssemblerBuffer to AssemblerData. 2. Tagging AssemblerData with enum class AssemblerDataType to specify which thread-local should be used. * Source/JavaScriptCore/assembler/AssemblerBuffer.cpp: (JSC::threadSpecificAssemblerHashes): * Source/JavaScriptCore/assembler/AssemblerBuffer.h: (JSC::AssemblerDataImpl::AssemblerDataImpl): (JSC::AssemblerDataImpl::operator=): (JSC::AssemblerDataImpl::takeBufferIfLarger): (JSC::AssemblerDataImpl::~AssemblerDataImpl): (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::releaseAssemblerHashes): (JSC::AssemblerData::AssemblerData): Deleted. (JSC::AssemblerData::operator=): Deleted. (JSC::AssemblerData::takeBufferIfLarger): Deleted. (JSC::AssemblerData::~AssemblerData): Deleted. (JSC::AssemblerData::clear): Deleted. (JSC::AssemblerData::buffer const): Deleted. (JSC::AssemblerData::capacity const): Deleted. (JSC::AssemblerData::grow): Deleted. (JSC::AssemblerData::isInlineBuffer const): Deleted. * Source/JavaScriptCore/assembler/LinkBuffer.h: Canonical link: https://commits.webkit.org/275845@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 216997: Rename RenderStyle effectiveUserModify() to usedUs...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2169972ec6e4afb45d504801515e94ab91d73f86 https://github.com/WebKit/WebKit/commit/2169972ec6e4afb45d504801515e94ab91d73f86 Author: Anne van Kesteren Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Position.cpp M Source/WebCore/editing/ApplyBlockElementCommand.cpp M Source/WebCore/editing/ReplaceSelectionCommand.cpp M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/TextIndicator.cpp M Source/WebCore/rendering/EventRegion.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/style/StyleTreeResolver.cpp M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- Rename RenderStyle effectiveUserModify() to usedUserModify() & effectiveUserSelect() to usedUserSelect() https://bugs.webkit.org/show_bug.cgi?id=270695 Reviewed by Aditya Keerthi. This aligns it with terminology used in CSS standards. * Source/WebCore/dom/Node.cpp: (WebCore::computeEditabilityFromComputedStyle): (WebCore::Node::canStartSelection const): * Source/WebCore/dom/Position.cpp: (WebCore::Position::nodeIsUserSelectNone): (WebCore::Position::nodeIsUserSelectAll): * Source/WebCore/editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): * Source/WebCore/editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): * Source/WebCore/editing/TextIterator.cpp: (WebCore::isRendererVisible): * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::selectCursor): * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::rangeForPoint): * Source/WebCore/page/TextIndicator.cpp: (WebCore::TextIndicator::createWithRange): * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegion::unite): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange): (WebCore::RenderElement::selectionColor const): (WebCore::RenderElement::selectionBackgroundColor const): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::collectSelectionGeometriesInternal): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::usedUserSelect const): (WebCore::RenderStyle::effectiveUserSelect const): Deleted. * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::usedUserModify const): (WebCore::RenderStyle::effectiveUserModify const): Deleted. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): * Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: (WebKit::InjectedBundleNodeHandle::isSelectableTextNode const): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::selectionPositionInformation): Canonical link: https://commits.webkit.org/275844@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2bc765: Build Failure: implicit capture of 'this' with a c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2bc765b66bd0b3aa9978cbbe6ad8b80cf5a7f1e8 https://github.com/WebKit/WebKit/commit/2bc765b66bd0b3aa9978cbbe6ad8b80cf5a7f1e8 Author: Timothy Hatcher Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICommandsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIMenusCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionURLSchemeHandlerCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIRuntimeCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm Log Message: --- Build Failure: implicit capture of 'this' with a capture default of '=' is deprecated. https://webkit.org/b/270704 rdar://124275043 Unreviewed build fix. Added `this` to the capture blocks. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm: (WebKit::WebExtensionContext::fireActionClickedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIAlarmsCocoa.mm: (WebKit::WebExtensionContext::fireAlarmsEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICommandsCocoa.mm: (WebKit::WebExtensionContext::fireCommandEventIfNeeded): (WebKit::WebExtensionContext::fireCommandChangedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm: (WebKit::WebExtensionContext::fireCookiesChangedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIMenusCocoa.mm: (WebKit::WebExtensionContext::fireMenusClickedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm: (WebKit::WebExtensionContext::firePermissionsEventListenerIfNecessary): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIRuntimeCocoa.mm: (WebKit::WebExtensionContext::runtimeSendMessage): (WebKit::WebExtensionContext::runtimeConnect): (WebKit::WebExtensionContext::runtimeWebPageSendMessage): (WebKit::WebExtensionContext::runtimeWebPageConnect): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIStorageCocoa.mm: (WebKit::WebExtensionContext::fireStorageChangedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPITabsCocoa.mm: (WebKit::WebExtensionContext::tabsConnect): (WebKit::WebExtensionContext::fireTabsCreatedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsUpdatedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsReplacedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsDetachedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsMovedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsAttachedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsActivatedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsHighlightedEventIfNeeded): (WebKit::WebExtensionContext::fireTabsRemovedEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIWindowsCocoa.mm: (WebKit::WebExtensionContext::fireWindowsEventIfNeeded): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::didStartProvisionalLoadForFrame): (WebKit::WebExtensionContext::didCommitLoadForFrame): (WebKit::WebExtensionContext::didFinishLoadForFrame): (WebKit::WebExtensionContext::didFailLoadForFrame): (WebKit::WebExtensionContext::resourceLoadDidSendRequest): (WebKit::WebExtensionContext::resourceLoadDidPerformHTTPRedirection): (WebKit::WebExtensionContext::resourceLoadDidReceiveChallenge): (WebKit::WebExtensionContext::resourceLoadDidReceiveResponse): (WebKit::WebExtensionContext::resourceLoadDidCompleteWithError): Canonical link: https://commits.webkit.org/275843@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b9b6b: [WebXR] Skip freezing layer tree with an active We...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b9b6bf2f2fb0ba67a772554d4dcc8fbb756b503 https://github.com/WebKit/WebKit/commit/2b9b6bf2f2fb0ba67a772554d4dcc8fbb756b503 Author: Ada Chan Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- [WebXR] Skip freezing layer tree with an active WebXR immersive session only when there's video content https://bugs.webkit.org/show_bug.cgi?id=270669 rdar://123777699 Reviewed by Eric Carlson. We initially skip freezing the layer tree with an active WebXR immersive session so videos can continue to get their requestVideoFrameCallback serviced. However, since this also incurs a power cost, we'll only do this when there's video content on the page. * Source/WebCore/page/Page.cpp: (WebCore::Page::shouldBlockLayerTreeFreezingForVideo): * Source/WebCore/page/Page.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updateDrawingAreaLayerTreeFreezeState): Canonical link: https://commits.webkit.org/275842@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1418b: [view-transitions] Support chaining `:only-child` ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1418bf98d34738599cef6f5f77255c3174f6a8f https://github.com/WebKit/WebKit/commit/d1418bf98d34738599cef6f5f77255c3174f6a8f Author: Tim Nguyen Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-group-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-group.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-image-pair-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-image-pair.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-new-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-new.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-no-transition.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-old-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-old.html M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-expected.txt M Source/WebCore/css/SelectorChecker.cpp M Source/WebCore/css/SelectorChecker.h M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp Log Message: --- [view-transitions] Support chaining `:only-child` after pseudo-elements https://bugs.webkit.org/show_bug.cgi?id=265223 rdar://118703154 Reviewed by Antti Koivisto. ::view-transition-group(name):only-child matches a group with no siblings. ::view-transition-image-pair(name):only-child should always match, since there is only one image-pair. ::view-transition-old(name):only-child matches an old capture with no associated new element. ::view-transition-new(name):only-child matches a new element with no associated old capture. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-group-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-group.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-image-pair-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-image-pair.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-new-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-new.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-no-transition.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-old-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/only-child-old.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/parsing/pseudo-elements-valid-expected.txt: * Source/WebCore/css/SelectorChecker.cpp: (WebCore::SelectorChecker::LocalContext::LocalContext): (WebCore::SelectorChecker::match const): (WebCore::SelectorChecker::matchHostPseudoClass const): (WebCore::hasViewTransitionPseudoElement): (WebCore::SelectorChecker::matchRecursively const): (WebCore::SelectorChecker::checkOne const): (WebCore::SelectorChecker::matchHasPseudoClass const): (WebCore::SelectorChecker::checkViewTransitionPseudoClass const): * Source/WebCore/css/SelectorChecker.h: * Source/WebCore/css/parser/CSSSelectorParser.cpp: (WebCore::isPseudoClassValidAfterPseudoElement): * Source/WebCore/dom/ViewTransition.h: (WebCore::OrderedNamedElementsMap::size const): (WebCore::OrderedNamedElementsMap::find const): * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: (WebCore::createRendererIfNeeded): Canonical link: https://commits.webkit.org/275841@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6a5f3: [GStreamer] Critical warnings in mpg123audiodec
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6a5f326cc05cf08b1c36bef027d2c311003a191 https://github.com/WebKit/WebKit/commit/a6a5f326cc05cf08b1c36bef027d2c311003a191 Author: Philippe Normand Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] Critical warnings in mpg123audiodec https://bugs.webkit.org/show_bug.cgi?id=270700 Unreviewed, GStreamer gardening. Flag tests as crashing until we have a GStreamer patch for the issue. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/275840@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a74dc: [Cocoa] Legacy EME tests time out with SampleBuffe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a74dcab081bf155995c7eb7fb745d444dbb4eae https://github.com/WebKit/WebKit/commit/7a74dcab081bf155995c7eb7fb745d444dbb4eae Author: Andy Estes Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp M Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.h A Source/WebCore/platform/graphics/avfoundation/objc/CDMFairPlayStreamingAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm Log Message: --- [Cocoa] Legacy EME tests time out with SampleBufferContentKeySessionSupportEnabled enabled https://bugs.webkit.org/show_bug.cgi?id=270678 rdar://problem/123089013 Reviewed by Jer Noble. The following legacy EME + MSE tests time out when enabling SampleBufferContentKeySessionSupportEnabled: - http/tests/media/fairplay/legacy-fairplay-mse-v2.html - http/tests/media/fairplay/legacy-fairplay-mse-v3.html This occurred because SourceBufferPrivateAVFObjC::canEnqueueSample would only consult m_cdmInstance (the modern CDM) to determine if a usable key existed to decrypt a sample. When legacy EME is in use there would not be a modern CDM instance, so all samples would be considered un-enqueueable and ultimately the canplay event would never be dispatched. Addressed this by teaching SourceBufferPrivateAVFObjC to check m_session (the legacy CDM) for usable keys if m_cdmInstance is null. Also, taught CDMSessionAVContentKeySession to attach content keys to samples rather than relying on AVStreamDataParser to do so; this matches how CDMInstanceSessionFairPlayStreamingAVFObjC attaches handles content key attachment. To fully resolve these timeouts, one additional change was necessary. In 274351@main we taught the FairPlay CDM how to decrypt MPEG2-TS streams, but we used a keyID that is incompatible with the AVContentKeyRequests vended by AVContentKeySession. Since AVContentKeySession vends MPEG2-TS key requests with an identifier of "TransportStreamIdentifier" and our CDM prefers to use the request identifier over request initialization data to represent the keyID, this commit changes CDMPrivateFairPlayStreaming::mptsKeyIDs() to return "TransportStreamIdentifier" instead of the preivious 16-byte value No new tests; covered by existing tests. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: (WebCore::CDMPrivateFairPlayStreaming::mptsKeyIDs): * Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.h: * Source/WebCore/platform/graphics/avfoundation/objc/CDMFairPlayStreamingAVFObjC.mm: Added. (WebCore::CDMPrivateFairPlayStreaming::keyIDsForRequest): * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::keyIDsForRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateKeyStatuses): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::contentKeyForSample): * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h: * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: (WebCore::CDMSessionAVContentKeySession::isAnyKeyUsable const): (WebCore::CDMSessionAVContentKeySession::attachContentKeyToSample): (WebCore::CDMSessionAVContentKeySession::contentKeyRequest const): (WebCore::CDMSessionAVContentKeySession::contentKeyRequest): Deleted. * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::canEnqueueSample): (WebCore::SourceBufferPrivateAVFObjC::attachContentKeyToSampleIfNeeded): Canonical link: https://commits.webkit.org/275839@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aaa2de: Cherry-pick 274706@main (9a071fa681c3). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: aaa2de95fee05bf4be501f5559d45512cf9cb93a https://github.com/WebKit/WebKit/commit/aaa2de95fee05bf4be501f5559d45512cf9cb93a Author: Philippe Normand Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp Log Message: --- Cherry-pick 274706@main (9a071fa681c3). https://bugs.webkit.org/show_bug.cgi?id=269354 [GStreamer] webrtc/video-lowercase-media-subtype.html times out https://bugs.webkit.org/show_bug.cgi?id=269354 Reviewed by Xabier Rodriguez-Calvar. The last issue with that test was that the transceiver direction (recvonly) of the receiver was copied over to the sending PeerConnection, thus breaking negotiation, preventing the sender to start streaming. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::doSetRemoteDescription): * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Canonical link: https://commits.webkit.org/274706@main Commit: 10d3e3ea3aa392556688cd532085bfff60aa0acd https://github.com/WebKit/WebKit/commit/10d3e3ea3aa392556688cd532085bfff60aa0acd Author: Carlos Garcia Campos Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp Log Message: --- Cherry-pick 274710@main (1512e48affb3). https://bugs.webkit.org/show_bug.cgi?id=269353 [WPE] Web Platform: implement WebPageProxy::callAfterNextPresentationUpdate https://bugs.webkit.org/show_bug.cgi?id=269353 Reviewed by Adrian Perez de Castro. With the old API we just use a 0 seconds timer, but with the new API we can use the buffer-renderer signal of WPEView to actually call the callback after the next buffer is rendered. This will hopefully reduce the flakiness of ref tests. * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::callAfterNextPresentationUpdate): Canonical link: https://commits.webkit.org/274710@main Commit: 0032643ddb04053db08c73517adf7ae6664fbf5f https://github.com/WebKit/WebKit/commit/0032643ddb04053db08c73517adf7ae6664fbf5f Author: Michael Catanzaro Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/platform/glib/UserAgentQuirks.cpp M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp Log Message: --- Cherry-pick 275835@main (1a9883acbbb0). https://bugs.webkit.org/show_bug.cgi?id=270438 Atlassian Confluence blocks Epiphany's user agent https://bugs.webkit.org/show_bug.cgi?id=270438 Reviewed by Philippe Normand. * Source/WebCore/platform/glib/UserAgentQuirks.cpp: (WebCore::urlRequiresMacintoshPlatform): * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275835@main Commit: a1717d6dc40464663ea845fd58d34b72b5aea62f https://github.com/WebKit/WebKit/commit/a1717d6dc40464663ea845fd58d34b72b5aea62f Author: Yusuke Suzuki Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/llint/LowLevelInterpreter.asm Log Message: --- Cherry-pick 274796@main (be51d0725a2c). https://bugs.webkit.org/show_bug.cgi?id=269534 [JSC] Use offlineasm globl to ensure that all entries have alt_entry https://bugs.webkit.org/show_bug.cgi?id=269534 rdar://122525586 Reviewed by Justin Michaud. We found that vmEntryToCSSJIT and vmEntryToCSSJITAfter are not having alt_entry properly since it is not using offlineasm globl. This allowed LLInt code shuffled by linkers when alt_entry is used, which breaks many assumptions. This patch fixes it. * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: Canonical link: https://commits.webkit.org/274796@main Commit: bdd790d01712ed52446a7cfc3d97cf7ebed381fc https://githu
[webkit-changes] [WebKit/WebKit] f25ae5: [visionOS] AudioSession interruptions do not stop ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f25ae590196b3cf576f1140a6c627927761cdaa5 https://github.com/WebKit/WebKit/commit/f25ae590196b3cf576f1140a6c627927761cdaa5 Author: Jean-Yves Avenard Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A LayoutTests/media/media-source/media-managedmse-noresumeafterpause-expected.txt A LayoutTests/media/media-source/media-managedmse-noresumeafterpause.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm Log Message: --- [visionOS] AudioSession interruptions do not stop playback https://bugs.webkit.org/show_bug.cgi?id=270614 rdar://116891193 Reviewed by Eric Carlson. In 25@main changes were made and then later reverted. The original description of 25@main was: "Timing differences on visionOS result in `AVSampleBufferRenderSynchronizer`'s rate being set to zero, prior to the interruption notification being dispatched when an interruption occurs. This difference ordering in ordering results in a sequence of events that causes WebKit to automatically resume playback following an interruption. Specifically: 1. `CMTimebaseEffectiveRateChangedCallback` is fired as AVSBRS has its rate changed, by the system. 2. Through the callback, the rate is observed as zero, resulting in playback being considered paused in the GPU process. 3. The GPU process state is reflected in the web process with a call to `MediaPlayerPrivateRemote::updateCachedState`. 4. `AVAudioSessionInterruptionNotification` is dispatched in the GPU process, by the system. 5. `HTMLMediaElement::updatePlayState()` is called in the web process. 6. The web process believes that playback is already paused, due to (3). 7. Consequently, the GPU process is never told to pause content; specifically, `MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal()` is elided. 8. Importantly, that method sets a flag variable, `m_playing` to false. 9. Since `m_playing` is not set to false, `MediaPlayerPrivateMediaSourceAVFObjC::shouldBePlaying()` will return true. 10. `MediaPlayerPrivateMediaSourceAVFObjC::updateAllRenderersHaveAvailableSamples()` eventually restarts playback, since `shouldBePlaying()` is true. " The observed effect description was correct, but the explanation wasn't. MediaPlayerPrivateMediaSourceAVFObjC::m_playing (later renamed m_isPlaying) indicates if the video "should be playing", which exclude the state where playback has paused due to the lack of data. MediaPlayerPrivateInterface::paused() was originally designed to determine if the CRABS player had been paused indirectly by the AVPlay through AirPlay interaction. As AirPlay doesn't support MSE, the only possible way the player is paused is if the MediaPlayerPrivateInterface::pause() got called. The implementation of MediaPlayerPrivateMediaSourceAVFObjC incorrectly reported the player as being paused if playback had stalled (the rate of the synchroniser had changed to 0). This leads to step 7. above happening. While the issue was noted on visionOS, side-effects could be observed elsewhere: if you called video.pause() while the video playback had stalled, currentTime could be seen temporarily progressing once more data was added due to MediaPlayerPrivate::pause() only being called once the media element's readyState changed. Test Added. * LayoutTests/media/media-source/media-managedmse-noresumeafterpause-expected.txt: Added. * LayoutTests/media/media-source/media-managedmse-noresumeafterpause.html: Added. * Source/WebCore/platform/graphics/MediaPlayerPrivate.h: Add API documentation for future references. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paused const): * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: WebM player copies the logic of the AVF MSE player. (WebCore::MediaPlayerPrivateWebM::paused const): apply the same fix as for MSE. Canonical link: https://commits.webkit.org/275838@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be13d8: `--site-isolation` isn't running tests in a cross-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be13d892218cf6b970dc28a19e5b16042924ed62 https://github.com/WebKit/WebKit/commit/be13d892218cf6b970dc28a19e5b16042924ed62 Author: Charlie Wolfe Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py M Tools/Scripts/webkitpy/port/driver.py M Tools/Scripts/webkitpy/port/driver_unittest.py M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestOptions.cpp M Tools/WebKitTestRunner/TestOptions.h Log Message: --- `--site-isolation` isn't running tests in a cross-origin iframe https://bugs.webkit.org/show_bug.cgi?id=270114 rdar://123646865 Reviewed by Alex Christensen. A typo was preventing it from being enabled. Most tests actually fail, so only enable a few for now. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): * Tools/Scripts/webkitpy/port/driver.py: (Driver.is_http_test): * Tools/Scripts/webkitpy/port/driver_unittest.py: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * Tools/WebKitTestRunner/TestOptions.h: (WTR::TestOptions::runInCrossOriginFrame const): (WTR::TestOptions::runInCrossOriginIFrame const): Deleted. Canonical link: https://commits.webkit.org/275837@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 06b335: Add runtime flag to allow JIT Cage experiments
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 06b3353a1bb84507905d8c052efb433ead7d055f https://github.com/WebKit/WebKit/commit/06b3353a1bb84507905d8c052efb433ead7d055f Author: Marcus Plutowski Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WTF/wtf/PlatformEnable.h Log Message: --- Add runtime flag to allow JIT Cage experiments https://bugs.webkit.org/show_bug.cgi?id=270668 rdar://119832251 Reviewed by Mark Lam. This was previously only configurable at compile time; now, the new allowJITCageExperiments will allow this behavior to be turned on at runtime. * Source/JavaScriptCore/runtime/Options.cpp: (JSC::canUseJITCage): * Source/JavaScriptCore/runtime/OptionsList.h: * Source/WTF/wtf/PlatformEnable.h: Canonical link: https://commits.webkit.org/275836@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a9883: Atlassian Confluence blocks Epiphany's user agent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a9883acbbb02ab8671f5e31e18ea0d0b8eda162 https://github.com/WebKit/WebKit/commit/1a9883acbbb02ab8671f5e31e18ea0d0b8eda162 Author: Michael Catanzaro Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/platform/glib/UserAgentQuirks.cpp M Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp Log Message: --- Atlassian Confluence blocks Epiphany's user agent https://bugs.webkit.org/show_bug.cgi?id=270438 Reviewed by Philippe Normand. * Source/WebCore/platform/glib/UserAgentQuirks.cpp: (WebCore::urlRequiresMacintoshPlatform): * Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/275835@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd1508: AX: Loading progress percentage used for WebAre ti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd1508d26370ab1fc6096e40d88b1e6a82436a26 https://github.com/WebKit/WebKit/commit/bd1508d26370ab1fc6096e40d88b1e6a82436a26 Author: Andres Gonzalez Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp M Source/WebCore/en.lproj/Localizable.strings M Source/WebCore/platform/LocalizedStrings.cpp M Source/WebCore/platform/LocalizedStrings.h M Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm Log Message: --- AX: Loading progress percentage used for WebAre title is not localized. https://bugs.webkit.org/show_bug.cgi?id=270670 Reviewed by Tyler Wilcock. Added COCOA helper function localizedPercentage and modified AXProcessingPage to return the entire localized string including the percentage. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::reportLoadingProgress): * Source/WebCore/en.lproj/Localizable.strings: * Source/WebCore/platform/LocalizedStrings.cpp: (WebCore::AXProcessingPage): Deleted. * Source/WebCore/platform/LocalizedStrings.h: * Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm: (WebCore::localizedPercentage): (WebCore::AXProcessingPage): Canonical link: https://commits.webkit.org/275834@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0268a5: Rename RenderStyle effectiveAccentColor() to usedA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0268a598d4f5ffa22507cfe582e6e5f6d6c14e6c https://github.com/WebKit/WebKit/commit/0268a598d4f5ffa22507cfe582e6e5f6d6c14e6c Author: Anne van Kesteren Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp M Source/WebCore/rendering/ios/RenderThemeIOS.mm M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- Rename RenderStyle effectiveAccentColor() to usedAccentColor() https://bugs.webkit.org/show_bug.cgi?id=270632 Reviewed by Aditya Keerthi. This aligns it with terminology used in CSS standards. * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::paint): (WebCore::ThemeAdwaita::paintCheckbox): (WebCore::ThemeAdwaita::paintRadio): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::extractControlStyleForRenderer const): (WebCore::RenderTheme::paint): * Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp: (WebCore::getAccentColor): (WebCore::RenderThemeAdwaita::paintMenuList): * Source/WebCore/rendering/ios/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const): (WebCore::RenderThemeIOS::controlTintColor const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::usedAccentColor const): (WebCore::RenderStyle::effectiveAccentColor const): Deleted. * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/275833@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 319ecb: :empty selector with animation not working properly
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 319ecb9c28e377b3bd11e6cbd878008f84e87bb7 https://github.com/WebKit/WebKit/commit/319ecb9c28e377b3bd11e6cbd878008f84e87bb7 Author: Antoine Quint Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/empty-pseudo-class-with-animation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/empty-pseudo-class-with-animation.html M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- :empty selector with animation not working properly https://bugs.webkit.org/show_bug.cgi?id=269051 rdar://122838142 Reviewed by Antti Koivisto. If an element is targeted by an animation, it may cause style updates with an `AnimationOnly` resolution type. When `Style::TreeResolver::resolveElement()` is called for that element, `resetStyleRelations()` is called on that element first under `Style::TreeResolver::resolveComposedTree()` while iterating through the composed tree. If an `:empty` pseudo-class rule matches that element, that call to `resetStyleRelations()` will remove the `StyleAffectedByEmpty` flag on that element, but it will not be recomputed under `resolveElement()` because when `styleForStyleable()` is called the `AnimationOnly` resolution type will mean that we clone the cached last style resolution style to return the `ResolvedStyle` value, clear of any relations. We now avoid calling `resetStyleRelations()` if the resolution type is `AnimationOnly`, ensuring that relations are preserved throughout animation updates. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/empty-pseudo-class-with-animation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/empty-pseudo-class-with-animation.html: Added. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveComposedTree): Canonical link: https://commits.webkit.org/275832@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eaa411: [MSE] screen should sleep if the video has stalled...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eaa411f285640e50b506f871981eed87e6e91fa3 https://github.com/WebKit/WebKit/commit/eaa411f285640e50b506f871981eed87e6e91fa3 Author: Jean-Yves Avenard Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in A Source/WebKit/WebProcess/GPU/media/MediaTimeUpdateData.serialization.in Log Message: --- [MSE] screen should sleep if the video has stalled, not just paused https://bugs.webkit.org/show_bug.cgi?id=270620 rdar://124190917 Reviewed by Youenn Fablet. A video may be playing as far as the HTMLMediaElement is concerned, but has stalled. Those videos should allow the screen to sleep. The code relied on an undocumented requirement that MediaPlayer::paused() returned true if the video has stalled, but this requirement causes breakage elsewhere (see webkit.org/b/270614) Checking on the value of MediaPlayerPrivateRemote::timeIsProgressing instead of paused() made several tests fail. Each failure revealed a discrepency between the GPU's MediaPlayer's time and the simulated currentTime in the WP. To avoid those, we re-sync the time estimator in each messages sent by the GPU process (currentTime, wall time, and if media player's time is progressing). No change in observable behaviour at this stage. Covered by existing tests. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::shouldDisableSleep const): * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::timeIsProgressing const): (WebCore::MediaPlayer::currentTimeMayProgress const): Deleted. * Source/WebCore/platform/graphics/MediaPlayer.h: * Source/WebCore/platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::timeIsProgressing const): (WebCore::MediaPlayerPrivateInterface::currentTimeMayProgress const): Deleted. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::timeIsProgressing const): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeMayProgress const): Deleted. * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h: * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::timeIsProgressing const): * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::timeIsProgressing const): (WebCore::MediaPlayerPrivateGStreamerMSE::currentTimeMayProgress const): Deleted. * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: * Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: (WebCore::MockMediaPlayerMediaSource::timeIsProgressing const): (WebCore::MockMediaPlayerMediaSource::currentTimeMayProgress const): Deleted. * Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.h: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::~RemoteMediaPlayerProxy): (WebKit::timeUpdateData const): (WebKit::RemoteMediaPlayerProxy::mediaPlayerSeeked): (WebKit::RemoteMediaPlayerProxy::mediaPlayerTimeChanged): (We
[webkit-changes] [WebKit/WebKit] c2361c: [WPE] WPE Platform: make functions to get DRM devi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2361c31a74159368c4298faa9049cd0cc3a3453 https://github.com/WebKit/WebKit/commit/c2361c31a74159368c4298faa9049cd0cc3a3453 Author: Carlos Garcia Campos Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp M Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp M Source/WebKit/WPEPlatform/wpe/WPEDisplay.h M Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt A Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.cpp A Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.cpp M Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.h M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp M Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp Log Message: --- [WPE] WPE Platform: make functions to get DRM device and render node members of WPEDisplay https://bugs.webkit.org/show_bug.cgi?id=270629 Reviewed by Alejandro G. Castro. They are currently global, and in the case of DRM might not be consistent with what it's actually used. Now that we have the primary display, we can move the API to WPEDisplay and return what every platform is actually using. * Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp: (WebKit::WebKitProtocolHandler::handleGPU): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp: (WebKit::DisplayVBlankMonitorDRM::create): * Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp: (WebKit::WebProcessPool::platformInitializeWebProcess): * Source/WebKit/WPEPlatform/wpe/WPEBufferDMABuf.cpp: (wpeBufferDMABufDispose): (wpeBufferDMABufTryEnsureGBMDevice): (wpeBufferDMABufImportToPixels): (gbmDevice): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEDisplay.cpp: (wpe_display_get_drm_device): (wpe_display_get_drm_render_node): (renderNodeFile): Deleted. (wpeDRMRenderNodeFile): Deleted. (wpe_render_node_device): Deleted. (renderDeviceFile): Deleted. (wpeDRMRenderDeviceFile): Deleted. (wpe_render_device): Deleted. * Source/WebKit/WPEPlatform/wpe/WPEDisplay.h: * Source/WebKit/WPEPlatform/wpe/drm/CMakeLists.txt: * Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.cpp: Added. (WTF::udev>::refIfNotNull): (WTF::udev>::derefIfNotNull): (WTF::udev_device>::refIfNotNull): (WTF::udev_device>::derefIfNotNull): (WTF::udev_enumerate>::refIfNotNull): (WTF::udev_enumerate>::derefIfNotNull): * Source/WebKit/WPEPlatform/wpe/drm/RefPtrUdev.h: Added. * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.cpp: (WPE::DRM::Seat::create): (WPE::DRM::Seat::Seat): * Source/WebKit/WPEPlatform/wpe/drm/WPEDRMSeat.h: * Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp: (findDevice): (wpeDisplayDRMConnect): (wpeDisplayDRMGetDRMDevice): (wpeDisplayDRMGetDRMRenderNode): (wpe_display_drm_class_init): * Source/WebKit/WPEPlatform/wpe/wayland/WPEDisplayWayland.cpp: (wpeDisplayWaylandDispose): (wpeDisplayWaylandConnect): (wpeDisplayWaylandGetDRMDevice): (wpeDisplayWaylandGetDRMRenderNode): (wpe_display_wayland_class_init): Canonical link: https://commits.webkit.org/275830@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75df56: [GTK] Make it possible to build with Skia instead ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75df56fbd143a4ac7df5e554b01c22030ea0ab22 https://github.com/WebKit/WebKit/commit/75df56fbd143a4ac7df5e554b01c22030ea0ab22 Author: Carlos Garcia Campos Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/PlatformGTK.cmake M Source/WebCore/platform/DragImage.h M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp M Source/WebCore/platform/graphics/IntRect.h M Source/WebCore/platform/graphics/cairo/IntRectCairo.cpp M Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp M Source/WebCore/platform/graphics/cairo/RefPtrCairo.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.h M Source/WebCore/platform/graphics/gtk/ImageAdapterGtk.cpp M Source/WebCore/platform/gtk/CursorGtk.cpp M Source/WebCore/platform/gtk/DragImageGtk.cpp M Source/WebCore/platform/gtk/RenderThemeGadget.cpp M Source/WebCore/platform/gtk/RenderThemeGadget.h M Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp M Source/WebCore/platform/gtk/RenderThemeScrollbar.h M Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp M Source/WebCore/platform/gtk/ScrollbarThemeGtk.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp M Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp M Source/WebKit/UIProcess/BackingStore.h M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h M Source/WebKit/UIProcess/ViewGestureController.h M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/ViewSnapshotStoreGtk3.cpp M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.h M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Source/cmake/WebKitFeatures.cmake M Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h M Tools/WebKitTestRunner/PlatformGTK.cmake M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp Log Message: --- [GTK] Make it possible to build with Skia instead of Cairo https://bugs.webkit.org/show_bug.cgi?id=270510 Reviewed by Don Olmstead. Add build option to enable Skia in the GTK port. This is just an initial patch, there are many features broken when building with Skia like printing, non-accelerated mode, favicons, snapshots, etc. We will fix them all in follow up patches. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/PlatformGTK.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/platform/DragImage.h: * Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp: * Source/WebCore/platform/graphics/IntRect.h: * Source/WebCore/platform/graphics/cairo/RefPtrCairo.cpp: * Source/WebCore/platform/graphics/cairo/RefPtrCairo.h: * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp: * Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.h: * Source/WebCore/platform/graphics/gtk/ImageAdapterGtk.cpp: (WebCore::ImageAdapter::gdkPixbuf): (WebCore::ImageAdapter::gdkTexture): * Source/WebCore/platform/gtk/CursorGtk.cpp: (WebCore::createCustomCursor): * Source/WebCore/platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): * Source/WebCore/platform/gtk/RenderThemeGadget.cpp: * Source/WebCore/platform/gtk/RenderThemeGadget.h: * Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp: * Source/WebCore/platform/gtk/RenderThemeScrollbar.h: * Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp: * Source/WebCore/platform/gtk/ScrollbarThemeGtk.h: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp: (API
[webkit-changes] [WebKit/WebKit] 123411: Add myself (Loïc Yhuel) to contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 123411aa4969b2d6201c2012b9d6ac597e3b1bee https://github.com/WebKit/WebKit/commit/123411aa4969b2d6201c2012b9d6ac597e3b1bee Author: Loïc Yhuel Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add myself (Loïc Yhuel) to contributors.json https://bugs.webkit.org/show_bug.cgi?id=267090 Reviewed by Michael Catanzaro. * metadata/contributors.json: Canonical link: https://commits.webkit.org/275828@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e80ab9: [GStreamer] Add va AV1 encoding support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e80ab9289841484d684b81a0ae84ad3cbd793b05 https://github.com/WebKit/WebKit/commit/e80ab9289841484d684b81a0ae84ad3cbd793b05 Author: Philippe Normand Date: 2024-03-08 (Fri, 08 Mar 2024) Changed paths: M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp Log Message: --- [GStreamer] Add va AV1 encoding support https://bugs.webkit.org/show_bug.cgi?id=270627 Reviewed by Xabier Rodriguez-Calvar. De-duplicate VA encoder setup callbacks and add AV1 support. * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (setupVaEncoder): (setVaBitrateMode): (setVaLatencyMode): (webkit_video_encoder_class_init): Canonical link: https://commits.webkit.org/275827@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
