[webkit-changes] [WebKit/WebKit] e9e959: [web-animations] composed keyframe animation behav...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9e959922d195e8daa40a74c08f00fe06a615206 https://github.com/WebKit/WebKit/commit/e9e959922d195e8daa40a74c08f00fe06a615206 Author: Antoine Quint Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/webanimations/accelerated-animations-and-composite-expected.txt M LayoutTests/webanimations/accelerated-animations-and-composite.html A LayoutTests/webanimations/accelerated-animations-and-implicit-keyframes-expected.txt A LayoutTests/webanimations/accelerated-animations-and-implicit-keyframes.html M Source/WebCore/animation/BlendingKeyframes.cpp M Source/WebCore/animation/BlendingKeyframes.h M Source/WebCore/animation/KeyframeEffect.cpp M Source/WebCore/animation/KeyframeEffect.h M Source/WebCore/animation/KeyframeEffectStack.cpp Log Message: --- [web-animations] composed keyframe animation behaves differently in Webkit than Firefox and Chrome https://bugs.webkit.org/show_bug.cgi?id=269858 rdar://123777133 Reviewed by Dean Jackson. The reported broken content for this bug used two animations targeting an accelerated property (`transform`) and using an implicit keyframe in both cases. When we encounter an accelerated animation with an implicit keyframe, we resolve the implicit keyframes using the underlying style. In this case, this breaks the content because the underlying style should be used only for the first of the two `transform` animations, and the second animation ought to use the output of the first animation to use as its underlying value. Since that values will change for each animation frame, we have to not run accelerated animations in this particular instance. So we now analyze the effect stack in `KeyframeEffectStack::allowsAcceleration()` for a case where an effect targets an accelerated property using an implicit keyframe when an effect lower down the stack is already animating that property. If we find this to be the case, we disable acceleration throughout the stack. Note that with threaded animation resolution, we are able to run this same scenario in the animation thread because we correctly resolve an effect stack with implicit keyframes no matter the configuration. The code path modified by this patch is not exercised when threaded animation resolution is enabled. We add a new test devoted to testing implicit keyframes for accelerated properties and modify the existing test for the `composite` property and acceleration to not contain implicit keyframes. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/webanimations/accelerated-animations-and-composite-expected.txt: * LayoutTests/webanimations/accelerated-animations-and-composite.html: * LayoutTests/webanimations/accelerated-animations-and-implicit-keyframes-expected.txt: Added. * LayoutTests/webanimations/accelerated-animations-and-implicit-keyframes.html: Added. * Source/WebCore/animation/BlendingKeyframes.cpp: (WebCore::BlendingKeyframes::hasImplicitKeyframeForProperty const): (WebCore::BlendingKeyframes::analyzeKeyframe): * Source/WebCore/animation/BlendingKeyframes.h: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::setBlendingKeyframes): (WebCore::KeyframeEffect::analyzeAcceleratedProperties): * Source/WebCore/animation/KeyframeEffect.h: * Source/WebCore/animation/KeyframeEffectStack.cpp: (WebCore::KeyframeEffectStack::allowsAcceleration const): Canonical link: https://commits.webkit.org/275887@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd74d7: Adopt com.apple.developer.cs.allow-jit entitlement...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd74d7957b6db44bbb1be9ac7d9684e87975b12d https://github.com/WebKit/WebKit/commit/dd74d7957b6db44bbb1be9ac7d9684e87975b12d Author: Mark Lam Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/JavaScriptCore/Scripts/process-entitlements.sh M Source/JavaScriptCore/jit/ExecutableAllocator.cpp M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Adopt com.apple.developer.cs.allow-jit entitlement for iOS. https://bugs.webkit.org/show_bug.cgi?id=270723 rdar://122841355 Reviewed by Justin Michaud. * Source/JavaScriptCore/Scripts/process-entitlements.sh: * Source/JavaScriptCore/jit/ExecutableAllocator.cpp: (JSC::isJITEnabled): (JSC::ExecutableAllocator::disableJIT): * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/275886@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad43bc: [visionOS] LinearMediaPlayer does not present audi...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad43bc6864cfe68b83ec4f3e67444f64e6ffe1ff
https://github.com/WebKit/WebKit/commit/ad43bc6864cfe68b83ec4f3e67444f64e6ffe1ff
Author: Andy Estes
Date: 2024-03-09 (Sat, 09 Mar 2024)
Changed paths:
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
Log Message:
---
[visionOS] LinearMediaPlayer does not present audio and text track options
https://bugs.webkit.org/show_bug.cgi?id=270727
rdar://124308729
Reviewed by Eric Carlson.
When introducing PlaybackSessionInterfaceLMK we neglected to provide
implementations for
{audio, legible}MediaSelectionOptionsChanged, resulting in LinearMediaPlayer
not presenting these
options in its UI.
Implemented these functions as well as the delegate callbacks to learn when the
user changes tracks.
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.h:
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setAudioTrack:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayer:setLegibleTrack:]):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionInterfaceLMK::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionInterfaceLMK::legibleMediaSelectionIndexChanged):
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h:
* Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm:
Canonical link: https://commits.webkit.org/275885@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d43d6: Resync Invoker WPTs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d43d6cf919e3ca92769de9455757ee77a5ad2ae https://github.com/WebKit/WebKit/commit/4d43d6cf919e3ca92769de9455757ee77a5ad2ae Author: Keith Cirkel Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log Log Message: --- Resync Invoker WPTs https://bugs.webkit.org/show_bug.cgi?id=270718 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/92088377f8a8f322333f5ca2efc6f077e5bedeb6 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/interestelement-interface.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeelement-interface.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invokeevent-interface.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log: Canonical link: https://commits.webkit.org/275884@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba446a: Try to fix older visionOS builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba446ad1e121c1b0761c63746217316fa7f3dc0b https://github.com/WebKit/WebKit/commit/ba446ad1e121c1b0761c63746217316fa7f3dc0b Author: Etienne Segonzac Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift Log Message: --- Try to fix older visionOS builds https://bugs.webkit.org/show_bug.cgi?id=270740 rdar://124325293 Reviewed by Tim Horton. Build fix for visionOS SDKs that do not have required QuickLook APIs. * Source/WebKit/WebKitSwift/Preview/PreviewWindowController.swift: Canonical link: https://commits.webkit.org/275883@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b72f93: REGRESSION(275869@main): [GTK][WPE] Hundreds of re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b72f93df865e8cf0d736a5e3bff43857cabb45e8 https://github.com/WebKit/WebKit/commit/b72f93df865e8cf0d736a5e3bff43857cabb45e8 Author: Philippe Normand Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M LayoutTests/platform/glib/css1/basic/containment-expected.txt M LayoutTests/platform/glib/css1/basic/contextual_selectors-expected.txt M LayoutTests/platform/glib/css1/basic/grouping-expected.txt M LayoutTests/platform/glib/css1/basic/id_as_selector-expected.txt M LayoutTests/platform/glib/css1/basic/inheritance-expected.txt M LayoutTests/platform/glib/css1/box_properties/border-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_color-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_color_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_style-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_style_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/clear-expected.txt M LayoutTests/platform/glib/css1/box_properties/clear_float-expected.txt M LayoutTests/platform/glib/css1/box_properties/float-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_elements_in_series-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_margin-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_on_text_elements-expected.txt M LayoutTests/platform/glib/css1/box_properties/height-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/width-expected.txt M LayoutTests/platform/glib/css1/cascade/cascade_order-expected.txt M LayoutTests/platform/glib/css1/cascade/impo
[webkit-changes] [WebKit/WebKit] 0e5409: Rename RenderStyle effectivePointerEvents() to use...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0e540948d2b714e3965d0e0343c9afb5cec30373 https://github.com/WebKit/WebKit/commit/0e540948d2b714e3965d0e0343c9afb5cec30373 Author: Anne van Kesteren Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebCore/page/InteractionRegion.cpp M Source/WebCore/rendering/EventRegion.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElementInlines.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h M Source/WebCore/rendering/style/StyleRareInheritedData.cpp M Source/WebCore/rendering/style/StyleRareInheritedData.h M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp M Source/WebCore/rendering/svg/RenderSVGShape.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Rename RenderStyle effectivePointerEvents() to usedPointerEvents() & effectiveTouchActions() to usedTouchActions() https://bugs.webkit.org/show_bug.cgi?id=270743 Reviewed by Tim Nguyen. This aligns them with terminology used in CSS standards. * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): * Source/WebCore/rendering/EventRegion.cpp: (WebCore::EventRegion::unite): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::styleWillChange): * Source/WebCore/rendering/RenderElementInlines.h: (WebCore::RenderElement::visibleToHitTesting const): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerStyleChanged): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::usedPointerEvents const): (WebCore::RenderStyle::usedTouchActions const): (WebCore::RenderStyle::effectivePointerEvents const): Deleted. (WebCore::RenderStyle::effectiveTouchActions const): Deleted. * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setUsedTouchActions): (WebCore::RenderStyle::setEffectiveTouchActions): Deleted. * Source/WebCore/rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator== const): * Source/WebCore/rendering/style/StyleRareInheritedData.h: * Source/WebCore/rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::checkIntersection): (WebCore::RenderSVGModelObject::checkEnclosure): * Source/WebCore/rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::nodeAtPoint): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint): * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::nodeAtPoint): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp: (WebCore::LegacyRenderSVGImage::nodeAtFloatPoint): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp: (WebCore::LegacyRenderSVGModelObject::checkIntersection): (WebCore::LegacyRenderSVGModelObject::checkEnclosure): * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp: (WebCore::LegacyRenderSVGShape::nodeAtFloatPoint): * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::computeUsedTouchActions): (WebCore::Style::Adjuster::adjust const): (WebCore::Style::computeEffectiveTouchActions): Deleted. Canonical link: https://commits.webkit.org/275881@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88fcde: Update API::UserScript & API::UserStyleSheet to us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88fcdec81c896d1300e28f7235a6a0018049 https://github.com/WebKit/WebKit/commit/88fcdec81c896d1300e28f7235a6a0018049 Author: Chris Dumez Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp A Source/WebKit/Shared/UserScriptIdentifier.h A Source/WebKit/Shared/UserStyleSheetIdentifier.h M Source/WebKit/Shared/WTFArgumentCoders.serialization.in M Source/WebKit/Shared/WebUserContentControllerDataTypes.h M Source/WebKit/Shared/WebUserContentControllerDataTypes.serialization.in M Source/WebKit/UIProcess/API/APIUserScript.h M Source/WebKit/UIProcess/API/APIUserStyleSheet.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp M Source/WebKit/WebProcess/UserContent/WebUserContentController.h M Source/WebKit/WebProcess/UserContent/WebUserContentController.messages.in Log Message: --- Update API::UserScript & API::UserStyleSheet to use strongly-typed identifiers https://bugs.webkit.org/show_bug.cgi?id=270732 Reviewed by Darin Adler. * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): * Source/WebKit/Shared/UserScriptIdentifier.h: Copied from Source/WebKit/Shared/WebUserContentControllerDataTypes.h. * Source/WebKit/Shared/UserStyleSheetIdentifier.h: Copied from Source/WebKit/Shared/WebUserContentControllerDataTypes.h. * Source/WebKit/Shared/WTFArgumentCoders.serialization.in: * Source/WebKit/Shared/WebUserContentControllerDataTypes.h: * Source/WebKit/Shared/WebUserContentControllerDataTypes.serialization.in: * Source/WebKit/UIProcess/API/APIUserScript.h: * Source/WebKit/UIProcess/API/APIUserStyleSheet.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp: (WebKit::WebUserContentController::removeUserScript): (WebKit::WebUserContentController::removeUserStyleSheet): (WebKit::WebUserContentController::addUserScriptInternal): (WebKit::WebUserContentController::removeUserScriptInternal): (WebKit::WebUserContentController::addUserStyleSheetInternal): (WebKit::WebUserContentController::removeUserStyleSheetInternal): * Source/WebKit/WebProcess/UserContent/WebUserContentController.h: * Source/WebKit/WebProcess/UserContent/WebUserContentController.messages.in: Canonical link: https://commits.webkit.org/275880@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18e217: Remove legacy ruby implementation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18e217e0c1998003d85e7596be9e58bb25867328 https://github.com/WebKit/WebKit/commit/18e217e0c1998003d85e7596be9e58bb25867328 Author: Antti Koivisto Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/editing/Editing.cpp M Source/WebCore/editing/TextIterator.cpp M Source/WebCore/html/RubyElement.cpp M Source/WebCore/html/RubyElement.h M Source/WebCore/html/RubyTextElement.cpp M Source/WebCore/html/track/WebVTTElement.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h M Source/WebCore/platform/ios/SelectionGeometry.cpp M Source/WebCore/platform/ios/SelectionGeometry.h M Source/WebCore/rendering/LegacyInlineFlowBox.cpp M Source/WebCore/rendering/LegacyInlineTextBox.cpp M Source/WebCore/rendering/LegacyLineLayout.cpp M Source/WebCore/rendering/LegacyLineLayout.h M Source/WebCore/rendering/LegacyRootInlineBox.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBlock.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderElementInlines.h M Source/WebCore/rendering/RenderImage.cpp M Source/WebCore/rendering/RenderLineBreak.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h R Source/WebCore/rendering/RenderRuby.cpp R Source/WebCore/rendering/RenderRuby.h R Source/WebCore/rendering/RenderRubyBase.cpp R Source/WebCore/rendering/RenderRubyBase.h R Source/WebCore/rendering/RenderRubyRun.cpp R Source/WebCore/rendering/RenderRubyRun.h R Source/WebCore/rendering/RenderRubyText.cpp R Source/WebCore/rendering/RenderRubyText.h M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderTreeAsText.cpp M Source/WebCore/rendering/TextDecorationPainter.cpp M Source/WebCore/rendering/line/BreakingContext.h M Source/WebCore/rendering/line/LineWidth.cpp M Source/WebCore/rendering/line/LineWidth.h M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h Log Message: --- Remove legacy ruby implementation https://bugs.webkit.org/show_bug.cgi?id=270741 rdar://124325661 Reviewed by Alan Baradlay. Remove dead code. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * Source/WebCore/editing/Editing.cpp: (WebCore::isBlock): * Source/WebCore/editing/TextIterator.cpp: (WebCore::shouldEmitNewlinesBeforeAndAfterNode): * Source/WebCore/html/RubyElement.cpp: (WebCore::RubyElement::createElementRenderer): Deleted. * Source/WebCore/html/RubyElement.h: * Source/WebCore/html/RubyTextElement.cpp: (WebCore::RubyTextElement::createElementRenderer): * Source/WebCore/html/track/WebVTTElement.cpp: * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForChild): (WebCore::LayoutIntegration::canUseForLineLayoutWithReason): * Source/WebCore/layout/integration/LayoutIntegrationCoverage.h: * Source/WebCore/platform/ios/SelectionGeometry.cpp: (WebCore::SelectionGeometry::SelectionGeometry): (WebCore::operator<<): * Source/WebCore/platform/ios/SelectionGeometry.h: (WebCore::SelectionGeometry::isInFixedPosition const): (WebCore::SelectionGeometry::isRubyText const): Deleted. * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::placeChildInlineBoxesInBlockDirection): (WebCore::LegacyInlineFlowBox::computeOverAnnotationAdjustment const): (WebCore::LegacyInlineFlowBox::computeUnderAnnotationAdjustment const): * Source/WebCore/rendering/LegacyInlineTextBox.cpp: * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::computeExpansionForJustifiedText): (WebCore::expansionBehaviorForInlineTextBox): (WebCore::LegacyLineLayout::computeInlineDirectionPositionsForSegment): (WebCore::LegacyLineLayout::layoutLineBoxes): (WebCore::LegacyLineLayout::setMarginsForRubyRun): Deleted. (WebCore::LegacyLineLayout::updateRubyForJustifiedText): Deleted. * Source/WebCore/rendering/LegacyLineLayout.h: * Source/WebCore/rendering/LegacyRootInlineBo
[webkit-changes] [WebKit/WebKit] cd4920: Unreviewed, reverting 275836@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd492006d90abe023692c5a7c2ac1538dede5e16 https://github.com/WebKit/WebKit/commit/cd492006d90abe023692c5a7c2ac1538dede5e16 Author: Commit Queue Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WTF/wtf/PlatformEnable.h Log Message: --- Unreviewed, reverting 275836@main. https://bugs.webkit.org/show_bug.cgi?id=270746 Large JS2 / JS3 regression Reverted changeset: "Add runtime flag to allow JIT Cage experiments" https://bugs.webkit.org/show_bug.cgi?id=270668 https://commits.webkit.org/275836@main Canonical link: https://commits.webkit.org/275878@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 637840: Rename RenderStyle hasEffectiveAppearance() to has...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6378406fb4f56935bc650ed073f1d52256535bcb https://github.com/WebKit/WebKit/commit/6378406fb4f56935bc650ed073f1d52256535bcb Author: Anne van Kesteren Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/dom/Element.cpp M Source/WebCore/html/CheckboxInputType.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLOptionElement.cpp M Source/WebCore/html/HTMLProgressElement.cpp M Source/WebCore/html/shadow/ProgressShadowElement.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp M Source/WebCore/rendering/BackgroundPainter.cpp M Source/WebCore/rendering/RenderAttachment.cpp M Source/WebCore/rendering/RenderBlock.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderMenuList.cpp M Source/WebCore/rendering/RenderProgress.cpp M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: --- Rename RenderStyle hasEffectiveAppearance() to hasUsedAppearance() https://bugs.webkit.org/show_bug.cgi?id=270744 Reviewed by Tim Nguyen. Necessary follow-up to 275850@main which renamed effectiveAppearance() to usedAppearance(). * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::boundingBoxForQuads): * Source/WebCore/dom/Element.cpp: (WebCore::Element::setActive): (WebCore::Element::setHovered): * Source/WebCore/html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::performSwitchAnimation): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::disabledStateChanged): * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): * Source/WebCore/html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attributeChanged): * Source/WebCore/html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::createElementRenderer): * Source/WebCore/html/shadow/ProgressShadowElement.cpp: (WebCore::ProgressShadowElement::rendererIsNeeded): (WebCore::ProgressInnerElement::rendererIsNeeded): * Source/WebCore/layout/integration/inline/LayoutIntegrationBoxGeometryUpdater.cpp: (WebCore::LayoutIntegration::BoxGeometryUpdater::updateLayoutBoxDimensions): * Source/WebCore/rendering/BackgroundPainter.cpp: (WebCore::BackgroundPainter::boxShadowShouldBeAppliedToBackground): * Source/WebCore/rendering/RenderAttachment.cpp: (WebCore::RenderAttachment::paintReplaced): * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::addVisualOverflowFromTheme): (WebCore::RenderBlock::baselinePosition const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::determineBackgroundBleedAvoidance const): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect const): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::hasVisibleBoxDecorationStyle const): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::hasVisibleBoxDecorations): * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::menuStyle const): * Source/WebCore/rendering/RenderProgress.cpp: (WebCore::RenderProgress::updateAnimationState): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::supportsFocusRing const): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::hasUsedAppearance const): (WebCore::RenderStyle::hasEffectiveAppearance const): Deleted. Canonical link: https://commits.webkit.org/275877@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f8c86: Element::rendererIsEverNeeded() only has a default...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f8c86d4cb27f37d847f9e584c4cde775ce26bae https://github.com/WebKit/WebKit/commit/8f8c86d4cb27f37d847f9e584c4cde775ce26bae Author: Tyler Wilcock Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Element::rendererIsEverNeeded() only has a default, hardcoded true implementation https://bugs.webkit.org/show_bug.cgi?id=270726 rdar://124307290 Reviewed by Aditya Keerthi. After https://commits.webkit.org/274917@main, only the default implementation of Element::rendererIsEverNeeded() is left, making the function useless. This patch removes it. * Source/WebCore/dom/Element.cpp: (WebCore::Element::rendererIsNeeded): * Source/WebCore/dom/Element.h: (WebCore::Element::rendererIsEverNeeded): Deleted. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsEverNeeded): Deleted. * Source/WebCore/html/HTMLElement.h: * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): Canonical link: https://commits.webkit.org/275876@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1fa82: Fix memory leak under [WKKeyedCoder initWithDictio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1fa8241a6a7dd667b704b385f5871ac89928326 https://github.com/WebKit/WebKit/commit/b1fa8241a6a7dd667b704b385f5871ac89928326 Author: Chris Dumez Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebKit/Shared/Cocoa/WKKeyedCoder.mm Log Message: --- Fix memory leak under [WKKeyedCoder initWithDictionary] https://bugs.webkit.org/show_bug.cgi?id=270734 rdar://124247709 Reviewed by Darin Adler. Make sure we adopt the result of `[NSDictionary mutableCopy]`. * Source/WebKit/Shared/Cocoa/WKKeyedCoder.mm: (-[WKKeyedCoder initWithDictionary:]): Canonical link: https://commits.webkit.org/275875@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7913ed: [GStreamer] Critical warnings in mpg123audiodec
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7913ede0502e03b19d95275be0e5d995cd35293b https://github.com/WebKit/WebKit/commit/7913ede0502e03b19d95275be0e5d995cd35293b Author: Philippe Normand Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M Tools/Scripts/webkitpy/port/glib.py Log Message: --- [GStreamer] Critical warnings in mpg123audiodec https://bugs.webkit.org/show_bug.cgi?id=270700 Unreviewed, gardening. Downrank the faulty mp3 GStreamer decoder, temporarily. * LayoutTests/platform/glib/TestExpectations: * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): Canonical link: https://commits.webkit.org/275874@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89bc7d: Find in Note: Dark gray outline (shadow) appears b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89bc7dd33ce84e204457c2f54d27bafa85cf8ace https://github.com/WebKit/WebKit/commit/89bc7dd33ce84e204457c2f54d27bafa85cf8ace Author: Megan Gardner Date: 2024-03-09 (Sat, 09 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm Log Message: --- Find in Note: Dark gray outline (shadow) appears behind gray/yellow highlights when matched text found in HTML note. https://bugs.webkit.org/show_bug.cgi?id=270666 rdar://122843511 Reviewed by Aditya Keerthi. In notes, the WKContentView is transparent, so our original solution of putting an additional grey layer behind the content view that filled up the empty parts of the scroll view would show through and make the find ui have a incorrect grey cast. So instead, we make four views that surround the WKContentView to fill in any part of the scrollView that isn't covered by the contentView. These are arranged around the content view like so: - --- || | ||--| || || || || - --| | || |__|| Each view is expanded to reach the edges of the scroll view every time the view is scrolled or the bounds change. This means that no matter where the content view is scrolled to, there will be a view that gives the correct grey cast to the scroll view. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView scrollViewDidScroll:]): (-[WKWebView _frameOrBoundsMayHaveChanged]): (-[WKWebView _updateFindOverlayForOverflowScrollPositions]): (-[WKWebView _showFindOverlay]): (-[WKWebView _hideFindOverlay]): (-[WKWebView _didAddLayerForFindOverlay:]): (-[WKWebView _updateFindOverlayPosition]): Deleted. Canonical link: https://commits.webkit.org/275873@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
