[webkit-changes] [WebKit/WebKit] 930a87: Mark request as same-site when we have a matching ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 930a87998c722414706d546c1f9dfc123fc62daa https://github.com/WebKit/WebKit/commit/930a87998c722414706d546c1f9dfc123fc62daa Author: Matthew Finkel Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/page/Page.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm Log Message: --- Mark request as same-site when we have a matching CORS-disabling pattern https://bugs.webkit.org/show_bug.cgi?id=270830 rdar://123848604 Reviewed by Alex Christensen. Some requests can be considered as same-site, even if they aren't according to the spec, just like we disble CORS for some requests that are cross-origin. We can leverage the existing CORS-Disabling patterns to decide when a request should be considered same-site. Covered by a new API test. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::setOriginalURLForDownloadRequest): (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::addSameSiteInfoToRequestIfNeeded): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/page/Page.h: (WebCore::Page::shouldAssumeSameSiteForRequestTo const): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm: (TEST): Canonical link: https://commits.webkit.org/276015@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3645b1: [JSC] Bracket compound assignment should resolve p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3645b1d995ed232f168ca763cb79551e3c8596eb https://github.com/WebKit/WebKit/commit/3645b1d995ed232f168ca763cb79551e3c8596eb Author: Ross Kirsling Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- [JSC] Bracket compound assignment should resolve property key at most once https://bugs.webkit.org/show_bug.cgi?id=270563 Reviewed by Yusuke Suzuki. Just as we did for `obj[prop]++` (275531@main), we need to make sure `obj[prop] += 1;` doesn't double-evaluate `prop`. The existing solution, however, is not of reasonable performance when `prop` is a Number value -- it is, of course, unacceptable for `arr[i]++` to be slow. To this end, this patch also introduces OpToPropertyKeyOrNumber, which will return numbers unchanged, just as it does with strings and symbols. * JSTests/test262/expectations.yaml: Mark 22 test cases as passing. * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::PostfixNode::emitBracket): (JSC::PrefixNode::emitBracket): (JSC::ReadModifyBracketNode::emitBytecode): (JSC::ShortCircuitReadModifyBracketNode::emitBytecode): (JSC::ObjectPatternNode::bindValue const): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: * Source/JavaScriptCore/dfg/DFGClobberize.h: * Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp: * Source/JavaScriptCore/dfg/DFGDoesGC.cpp: * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: * Source/JavaScriptCore/dfg/DFGNode.h: * Source/JavaScriptCore/dfg/DFGNodeType.h: * Source/JavaScriptCore/dfg/DFGOperations.cpp: * Source/JavaScriptCore/dfg/DFGOperations.h: * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGSafeToExecute.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: * Source/JavaScriptCore/ftl/FTLCapabilities.cpp: * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: * Source/JavaScriptCore/jit/JIT.cpp: * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/CommonSlowPaths.cpp: * Source/JavaScriptCore/runtime/CommonSlowPaths.h: Canonical link: https://commits.webkit.org/276014@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ea5e7: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ea5e7008360c0960dfe07a7258f2e41210c47be https://github.com/WebKit/WebKit/commit/0ea5e7008360c0960dfe07a7258f2e41210c47be Author: Fujii Hironori Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/276013@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 910ab1: [WPE][GTK] Warning: WebKit2: Couldn't find 'run_as...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 910ab18a82d45d05c146999c32b0c517bf78b56a https://github.com/WebKit/WebKit/commit/910ab18a82d45d05c146999c32b0c517bf78b56a Author: Michael Catanzaro Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in Log Message: --- [WPE][GTK] Warning: WebKit2: Couldn't find 'run_async_javascript_function_in_world_finish' for the corresponding async function: 'run_async_javascript_function_in_world' https://bugs.webkit.org/show_bug.cgi?id=269377 Reviewed by Adrian Perez de Castro. We need to use the new finish-func annotation so that language bindings can figure out how to complete the async call, due to our nonstandard naming for the finish function. It seems trying to reuse the same finish function for multiple async calls was not such a good idea. Unfortunately, with older gobject-introspection, we cannot use this new annotation or the build will fail due to the unrecognized annotation. So we will need to conditionalize the entire doc comment. Finally, I've also fixed the nullability of the world_name parameter, which was broken due to a missing colon. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Canonical link: https://commits.webkit.org/276012@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 61416a: [Gardening]: [ MacOS iOS ] svg/custom/svg-fonts-in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61416a0e0ae4def6f2bbcb5b53f0ed80f4298f1a https://github.com/WebKit/WebKit/commit/61416a0e0ae4def6f2bbcb5b53f0ed80f4298f1a Author: Jay Stfleur Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/mac-ventura/svg/custom/svg-fonts-in-html-expected.txt Log Message: --- [Gardening]: [ MacOS iOS ] svg/custom/svg-fonts-in-html.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=123854058 rdar://123854058 Unreviewed test gardening. Added rebaseline. * LayoutTests/platform/mac-ventura/svg/custom/svg-fonts-in-html-expected.txt: Canonical link: https://commits.webkit.org/276011@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3dab1c: Some identity tests file names are misspelled
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3dab1c928a9c9f669ff95f294165661a5e0a1e4e https://github.com/WebKit/WebKit/commit/3dab1c928a9c9f669ff95f294165661a5e0a1e4e Author: Marcos Caceres Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt A LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html A LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt A LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html R LayoutTests/http/wpt/identity/identtycredentialscontainer-create-basics.https-expected.txt R LayoutTests/http/wpt/identity/identtycredentialscontainer-create-basics.https.html R LayoutTests/http/wpt/identity/identtycredentialscontainer-store-basics.https-expected.txt R LayoutTests/http/wpt/identity/identtycredentialscontainer-store-basics.https.html Log Message: --- Some identity tests file names are misspelled https://bugs.webkit.org/show_bug.cgi?id=270827 rdar://124418780 Reviewed by Abrar Rahman Protyasha. Fixed the misspelled file names. * LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https-expected.txt: Renamed from LayoutTests/http/wpt/identity/identtycredentialscontainer-create-basics.https-expected.txt. * LayoutTests/http/wpt/identity/identitycredentialscontainer-create-basics.https.html: Renamed from LayoutTests/http/wpt/identity/identtycredentialscontainer-create-basics.https.html. * LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https-expected.txt: Renamed from LayoutTests/http/wpt/identity/identtycredentialscontainer-store-basics.https-expected.txt. * LayoutTests/http/wpt/identity/identitycredentialscontainer-store-basics.https.html: Renamed from LayoutTests/http/wpt/identity/identtycredentialscontainer-store-basics.https.html. Canonical link: https://commits.webkit.org/276010@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5fa77: REGRESSION(275943@main) TestWebKitAPI tests timing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5fa77c084b88ace87bb6b2ec49f0012a23da574 https://github.com/WebKit/WebKit/commit/c5fa77c084b88ace87bb6b2ec49f0012a23da574 Author: Jer Noble Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/ApplicationStateTracker.mm Log Message: --- REGRESSION(275943@main) TestWebKitAPI tests timing out https://bugs.webkit.org/show_bug.cgi?id=270875 rdar://124475961 Reviewed by Ben Nham and Chris Dumez. TestWebKitAPI, when running against iOS, is not a "real" UI application. As such, the UIWindows it creates are not associated with any UIWindowScene. This breaks the foreground/background checking logic in ApplicationStateTracker. Update ApplicationStateTracker to treat the view as "not background" if it has a UIWindow but no UIScene. * Source/WebKit/UIProcess/ApplicationStateTracker.mm: (WebKit::ApplicationStateTracker::setScene): Canonical link: https://commits.webkit.org/276009@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3134d8: [Gardening]: REGRESSION:(275949@main): [ MacOS iOS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3134d8e539ad3a2372355d1253f75e7e615353ca https://github.com/WebKit/WebKit/commit/3134d8e539ad3a2372355d1253f75e7e615353ca Author: Jay Stfleur Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION:(275949@main): [ MacOS iOS ] 11X imported/w3c/web-platform-tests/css/css-text/i18n/other-lang/css-text-line-break tests are consistent/flaky failures https://bugs.webkit.org/show_bug.cgi?id=124463423 rdar://124463423 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276008@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94cf8a: Update default Resource Timing buffer size from 1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94cf8a4a86fcf7663e04b370996b5cfea49f5311 https://github.com/WebKit/WebKit/commit/94cf8a4a86fcf7663e04b370996b5cfea49f5311 Author: Ryosuke Niwa Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/http/tests/performance/performance-resource-timing-entries-default-limit-expected.txt A LayoutTests/http/tests/performance/performance-resource-timing-entries-default-limit.html M LayoutTests/imported/w3c/web-platform-tests/preload/preload-referrer-policy-expected.txt M Source/WebCore/page/Performance.h Log Message: --- Update default Resource Timing buffer size from 150 to 250 https://bugs.webkit.org/show_bug.cgi?id=186077 Reviewed by Chris Dumez. Up the default buffer size to 250 per spec: https://w3c.github.io/resource-timing/#sec-extensions-performance-interface * LayoutTests/http/tests/performance/performance-resource-timing-entries-default-limit-expected.txt: Added. * LayoutTests/http/tests/performance/performance-resource-timing-entries-default-limit.html: Added. * LayoutTests/imported/w3c/web-platform-tests/preload/preload-referrer-policy-expected.txt: Rebaselined now that more test cases are passing. * Source/WebCore/page/Performance.h: Canonical link: https://commits.webkit.org/276007@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e73d2: [WebAuthn] Populate excludeCredentials in modern A...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e73d2ab80517c18e34b74ea0c985739698f3baa https://github.com/WebKit/WebKit/commit/3e73d2ab80517c18e34b74ea0c985739698f3baa Author: Pascoe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- [WebAuthn] Populate excludeCredentials in modern AS flow https://bugs.webkit.org/show_bug.cgi?id=270856 rdar://124405037 Reviewed by Chris Dumez. This patch starts passing along the excluded credentials from the request along the modern AS flow. * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::WebAuthenticatorCoordinatorProxy::requestsForRegisteration): Canonical link: https://commits.webkit.org/276006@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f816a1: Fix some assertions when using a canvas without a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f816a1743b89245484a0ea3462c76fe88d593d3e https://github.com/WebKit/WebKit/commit/f816a1743b89245484a0ea3462c76fe88d593d3e Author: Alex Christensen Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/use-canvas-without-layer-expected.txt A LayoutTests/fast/webgpu/use-canvas-without-layer.html M Source/WebCore/Modules/WebGPU/GPU.cpp M Source/WebCore/Modules/WebGPU/GPU.h M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp M Source/WebCore/Modules/WebGPU/GPUCommandEncoder.h M Source/WebCore/Modules/WebGPU/GPUDevice.cpp M Source/WebCore/Modules/WebGPU/GPUDevice.h M Source/WebCore/Modules/WebGPU/GPUPresentationContext.cpp M Source/WebCore/Modules/WebGPU/GPUPresentationContext.h M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp M Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.h M Source/WebCore/Modules/WebGPU/GPUTexture.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUPresentationContextImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPURenderBundleEncoderImpl.h M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUTextureImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCommandEncoder.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPresentationContext.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderBundleEncoder.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTexture.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.h M Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteCommandEncoderProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemotePresentationContextProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteRenderBundleEncoderProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteTextureProxy.h M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h Log Message: --- Fix some assertions when using a canvas without a layer with webgpu https://bugs.webkit.org/show_bug.cgi?id=270705 rdar://124213314 Reviewed by Mike Wyrzykowski. The test in this PR hit several issues: 1. PresentationContextIOSurface::present asserted, which I changed to an early return. 2. I handle errors when creating objects by returning nullptr instead of an object that has no corresponding object in the GPU process, and propogate those
[webkit-changes] [WebKit/WebKit] 09186d: [RenderTreeDump] Use linesBoundingBox for text, li...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09186d9fddd9a56ef268d9ae92da2b98e2008982 https://github.com/WebKit/WebKit/commit/09186d9fddd9a56ef268d9ae92da2b98e2008982 Author: Alan Baradlay Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual-expected.txt M LayoutTests/platform/ios/fast/block/basic/001-expected.txt Log Message: --- [RenderTreeDump] Use linesBoundingBox for text, line break and inline box https://bugs.webkit.org/show_bug.cgi?id=270731#c19 Unreviewed rebaseline after 275888@main. * LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual-expected.txt: * LayoutTests/platform/ios/fast/block/basic/001-expected.txt: Canonical link: https://commits.webkit.org/276004@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b74a5a: REGRESSION (275981@main): [ macOS ] 7 tests in Tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b74a5a42516e4102fd5b9b594e566099bf782ad2 https://github.com/WebKit/WebKit/commit/b74a5a42516e4102fd5b9b594e566099bf782ad2 Author: Timothy Hatcher Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm Log Message: --- REGRESSION (275981@main): [ macOS ] 7 tests in TestWebKitAPI.WKWebExtensionAPIPermissions are a constant failure/timeout. https://webkit.org/b/270872 rdar://problem/124475393 Reviewed by Jeff Miller. When requesting permissions via permissions.request(), we need to include optional permissions in the check. That was actually happening by accident before, since !hasPermission() was returning true for any unknown permission. With the change to needsPermission(), only RequestedExplicitly or RequestedImplicitly results were counted. To fix this, a new option was added for use by the permissions API to include optional permissions in the RequestedImplicitly category. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIPermissionsCocoa.mm: (WebKit::WebExtensionContext::permissionsRequest): Pass the IncludeOptionalPermissions option. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::requestPermissionMatchPatterns): Pass through options to needsPermission(). (WebKit::WebExtensionContext::requestPermissionToAccessURLs): Ditto. (WebKit::WebExtensionContext::requestPermissions): Ditto. (WebKit::WebExtensionContext::permissionState): Added support for IncludeOptionalPermissions to check the optional permissions from the extension's manifest. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMatchPatternCocoa.mm: (WebKit::WebExtensionMatchPattern::patternsMatchURL): Added const to URL to fix build issue. (WebKit::WebExtensionMatchPattern::patternsMatchPattern): Added. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::requestPermissionMatchPatterns): Added options parameter. (WebKit::WebExtensionContext::requestPermissionToAccessURLs): Ditto. (WebKit::WebExtensionContext::requestPermissions): Ditto. * Source/WebKit/UIProcess/Extensions/WebExtensionMatchPattern.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm: (TEST(WKWebExtensionAPITabs, QueryWithAccessPrompt)): Grant tabs permission so the tab URL counts as a requested URL and the prompt delegate will be called. Canonical link: https://commits.webkit.org/276003@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e273b: Null pointer dereference in `U2fAuthenticator::iss...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e273ba798318ec4c9710c4ba9b553a91bc0e7bb https://github.com/WebKit/WebKit/commit/9e273ba798318ec4c9710c4ba9b553a91bc0e7bb Author: Charlie Wolfe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp Log Message: --- Null pointer dereference in `U2fAuthenticator::issueSignCommand` https://bugs.webkit.org/show_bug.cgi?id=270873 rdar://124475802 Reviewed by Pascoe. Crash logs indicate it's possible for `u2fCmd` to be null. Avoid crashing in this case. * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: (WebKit::U2fAuthenticator::issueSignCommand): Canonical link: https://commits.webkit.org/276002@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0df991: Always use DDHighlightCreateWithRectsInVisibleRect...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0df9914623bbfc88ba44f2f270c2be15a8246f89 https://github.com/WebKit/WebKit/commit/0df9914623bbfc88ba44f2f270c2be15a8246f89 Author: Abrar Rahman Protyasha Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.h M Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.mm M Source/WebCore/page/mac/ImageOverlayControllerMac.mm M Source/WebCore/page/mac/ServicesOverlayController.mm Log Message: --- Always use DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection in DDHighlight creation code https://bugs.webkit.org/show_bug.cgi?id=270865 rdar://124465778 Reviewed by Tim Horton and Megan Gardner. Currently, we call DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection conditional on HAVE(DD_HIGHLIGHT_CREATE_WITH_SCALE). This is not necessary because all calls to the DDHighlight creation method happen in macOS-only codepaths, and the method in question is available on all supported macOS configurations. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.h: * Source/WebCore/PAL/pal/mac/DataDetectorsSoftLink.mm: * Source/WebCore/page/mac/ImageOverlayControllerMac.mm: (WebCore::ImageOverlayController::updateDataDetectorHighlights): * Source/WebCore/page/mac/ServicesOverlayController.mm: (WebCore::ServicesOverlayController::buildPhoneNumberHighlights): (WebCore::ServicesOverlayController::buildSelectionHighlight): Canonical link: https://commits.webkit.org/276001@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c357c: AX: AccessibilityNodeObject::determineAccessibilit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c357cd24a0e0e181d09dadd6f08fbb8fc93aa86 https://github.com/WebKit/WebKit/commit/8c357cd24a0e0e181d09dadd6f08fbb8fc93aa86 Author: Andres Gonzalez Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/accessibility/AccessibilityNodeObject.cpp Log Message: --- AX: AccessibilityNodeObject::determineAccessibilityRoleFromNode makes many unnecessary dynamicDowncasts. https://bugs.webkit.org/show_bug.cgi?id=270854 Reviewed by Tyler Wilcock. This is a hot method in ITM that calls many times Node::hasTagName(const HTMLQualifiedName&), which in turn dynamicDowncasts the Node to an HTMLElement. This patch reduces the number of dynamicDowncasts significantly by downcasting to an HTMLElement upfront and calling HTMLElement::hasTagName directly instead. In a run of LayoutTests/accessibility, the number of downcasts drops by 1978248 or 13% of the original number. * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): Canonical link: https://commits.webkit.org/276000@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 51b371: Cannot manage extension storage with WebKit extens...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 51b371557ac72cf9ffaf6db5b1f90b90c2472704 https://github.com/WebKit/WebKit/commit/51b371557ac72cf9ffaf6db5b1f90b90c2472704 Author: Kiara Rose Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h M Source/WebKit/UIProcess/Extensions/WebExtensionController.h Log Message: --- Cannot manage extension storage with WebKit extensions in Safari https://bugs.webkit.org/show_bug.cgi?id=270869 rdar://124037961 Reviewed by Timothy Hatcher. Update methods for fetching and removing data records. Since it's not guarenteed the context will be loaded, don't refer to the controller's map of extension context. Instead, do a direct comparision with the uniqueIdentifier from the context passed to determine if a match is found. Also, update _storageDirectoryPath so that a custom storage path can be set. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: (-[_WKWebExtensionSQLiteStore _deleteDatabaseFileAtURL:reopenDatabase:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.mm: (-[_WKWebExtensionControllerConfiguration _setStorageDirectoryPath:]): * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfigurationPrivate.h: * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::readDisplayNameFromState): (WebKit::WebExtensionContext::invalidateStorage): Make this public so it can be used after sql dbs are closed when data records are removed. (WebKit::WebExtensionContext::readDisplayNameAndLastBaseURLFromState): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm: (WebKit::WebExtensionController::getDataRecords): (WebKit::WebExtensionController::getDataRecord): (WebKit::WebExtensionController::sqliteStore): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerConfigurationCocoa.mm: (WebKit::WebExtensionControllerConfiguration::createStorageDirectoryPath): Convert identifier back to uppercase after toString(). This was causing a bug where a new (lowercased) directory would be used for extension storage. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: * Source/WebKit/UIProcess/Extensions/WebExtensionController.h: Canonical link: https://commits.webkit.org/275999@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18d9a4: AX: VoiceOver doesn't read characters when user pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18d9a43b9d86cc2a3e8fa52d54b470294a73b607 https://github.com/WebKit/WebKit/commit/18d9a43b9d86cc2a3e8fa52d54b470294a73b607 Author: Dominic Mazzoni Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/accessibility/mac/custom-text-editor-expected.txt A LayoutTests/accessibility/mac/custom-text-editor.html M Source/WebCore/accessibility/AXObjectCache.h M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm Log Message: --- AX: VoiceOver doesn't read characters when user presses left / right arrows in Monaco code editor https://bugs.webkit.org/show_bug.cgi?id=270616 rdar://123984168 Reviewed by Andres Gonzalez. When the character or selection extent moves by just one visible position, infer that it was a character granularity move, rather than a discontiguous selection. * LayoutTests/accessibility/mac/custom-text-editor-expected.txt: Added. * LayoutTests/accessibility/mac/custom-text-editor.html: Added. * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::inferDirectionFromIntent): (WebCore::AXObjectCache::postTextStateChangePlatformNotification): Canonical link: https://commits.webkit.org/275998@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0a2b3: and loadeddata events not fired on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0a2b3040d2d0424bd082eafba7f3922fe7641f0 https://github.com/WebKit/WebKit/commit/c0a2b3040d2d0424bd082eafba7f3922fe7641f0 Author: Jean-Yves Avenard Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/http/tests/media/audio-load-loadeddata-expected.txt A LayoutTests/http/tests/media/audio-load-loadeddata.html M LayoutTests/platform/ios/TestExpectations M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/MediaPlayerPrivate.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h Log Message: --- and loadeddata events not fired on page load https://bugs.webkit.org/show_bug.cgi?id=270837 rdar://124079735 Reviewed by Eric Carlson. The HTMLMediaElement would call MediaPlayer::prepareToPlay() on the first MediaPlayerPrivate created which may not be the one we end up using. The code assumed that as soon as a MediaPlayer was created, we could call prepareToPlay on it which in the case of the MediaPlayerPrivateAVFobjC would start loading the content. Since we enabled the WebM player, the assumption no longer applied, multiple players could be used until we find one that can play the content. If the GPU process was enabled, the behaviour was racy as the GPUP's MediaPlayer may not have been created yet. The site would set a HTMLMediaElement's source to a mp3 file, without using an explicit extension nor having the server provide the mime-type. As such, we have to try in succession all MediaPlayerPrivate until we can find one that can load the content. We cache the call to prepareToPlay() and re-issue it on all new MediaPlayerPrivate once created. Added test. * LayoutTests/http/tests/media/audio-load-loadeddata-expected.txt: Added. * LayoutTests/http/tests/media/audio-load-loadeddata.html: Added. * LayoutTests/platform/ios/TestExpectations: All media tests are disabled on iOS, force this one to run. * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::loadWithNextMediaEngine): (WebCore::MediaPlayer::prepareToPlay): * Source/WebCore/platform/graphics/MediaPlayer.h: * Source/WebCore/platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::prepareForPlayback): * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::prepareForPlayback): * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.messages.in: * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::prepareForPlayback): * Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: Canonical link: https://commits.webkit.org/275997@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c474a: Use system import directory when compiling sandboxes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c474aa470d68767fcdce7036daa5298385f865b https://github.com/WebKit/WebKit/commit/6c474aa470d68767fcdce7036daa5298385f865b Author: Per Arne Vollan Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/Scripts/compile-sandbox.sh Log Message: --- Use system import directory when compiling sandboxes https://bugs.webkit.org/show_bug.cgi?id=270868 rdar://124373752 Reviewed by Chris Dumez. Use system import directory when compiling sandboxes on macOS. This fixes a build issue seen on some host configurations. This patch was written by Christian Schmidt and Per Arne Vollan. * Source/WebKit/Scripts/compile-sandbox.sh: Canonical link: https://commits.webkit.org/275996@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 899b2d: [GLIB][WPE] Unreviewed test gardening, update base...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 899b2d18cda772f9e9ad728aa5d27f8f5d9b0870 https://github.com/WebKit/WebKit/commit/899b2d18cda772f9e9ad728aa5d27f8f5d9b0870 Author: Diego Pino Garcia Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/fast/images/image-in-map-expected.txt M LayoutTests/fast/text/whitespace/pre-newline-box-test-expected.txt M LayoutTests/fast/text/whitespace/tab-character-basics-expected.txt M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/fast/css/css-imports-expected.txt M LayoutTests/platform/glib/fast/css/css1_forward_compatible_parsing-expected.txt M LayoutTests/platform/glib/fast/css/css3-nth-child-expected.txt M LayoutTests/platform/glib/fast/css/empty-generated-content-expected.txt M LayoutTests/platform/glib/fast/css/empty-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/error-in-last-decl-expected.txt M LayoutTests/platform/glib/fast/css/ex-after-font-variant-expected.txt M LayoutTests/platform/glib/fast/css/find-next-layer-expected.txt M LayoutTests/platform/glib/fast/css/first-child-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-capitalized-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-detach-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-first-line-hover-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-float-after-float-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-float-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-hover-expected.txt M LayoutTests/platform/glib/fast/css/first-letter-visibility-expected.txt M LayoutTests/platform/glib/fast/css/first-of-type-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/focus-ring-detached-expected.txt M LayoutTests/platform/glib/fast/css/focus-ring-multiline-expected.txt M LayoutTests/platform/glib/fast/css/focus-ring-outline-offset-expected.txt M LayoutTests/platform/glib/fast/css/font-face-default-font-expected.txt M LayoutTests/platform/glib/fast/css/font-face-implicit-local-font-expected.txt M LayoutTests/platform/glib/fast/css/font-face-locally-installed-expected.txt M LayoutTests/platform/glib/fast/css/font-face-multiple-faces-expected.txt A LayoutTests/platform/glib/fast/css/font-face-opentype-expected.png M LayoutTests/platform/glib/fast/css/font-face-opentype-expected.txt M LayoutTests/platform/glib/fast/css/font-face-synthetic-bold-italic-expected.txt M LayoutTests/platform/glib/fast/css/font-face-unicode-range-expected.txt M LayoutTests/platform/glib/fast/css/font-face-weight-matching-expected.txt M LayoutTests/platform/glib/fast/css/font-shorthand-weight-only-expected.txt A LayoutTests/platform/glib/fast/css/font-smoothing-expected.png M LayoutTests/platform/glib/fast/css/font-smoothing-expected.txt M LayoutTests/platform/glib/fast/css/hover-subselector-expected.txt M LayoutTests/platform/glib/fast/css/import-rule-regression-11590-expected.txt M LayoutTests/platform/glib/fast/css/inline-element-line-break-expected.txt M LayoutTests/platform/glib/fast/css/invalid-percentage-property-expected.txt M LayoutTests/platform/glib/fast/css/last-child-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/last-of-type-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/layerZOrderCrash-expected.txt M LayoutTests/platform/glib/fast/css/line-height-font-order-expected.txt M LayoutTests/platform/glib/fast/css/non-empty-span-expected.txt M LayoutTests/platform/glib/fast/css/only-child-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/only-of-type-pseudo-class-expected.txt M LayoutTests/platform/glib/fast/css/pseudo-element-line-break-expected.txt M LayoutTests/platform/glib/fast/css/resize-corner-tracking-transformed-expected.txt M LayoutTests/platform/glib/fast/css/resize-corner-tracking-transformed-iframe-expected.txt M LayoutTests/platform/glib/fast/css/rtl-ordering-expected.txt M LayoutTests/platform/glib/fast/css/shadow-multiple-expected.txt M LayoutTests/platform/glib/fast/css/text-overflow-ellipsis-bidi-expected.txt M LayoutTests/platform/glib/fast/css/text-overflow-ellipsis-expected.txt M LayoutTests/platform/glib/fast/css/text-overflow-ellipsis-strict-expected.txt M LayoutTests/platform/glib/fast/css/text-overflow-ellipsis-text-align-center-expected.txt M LayoutTests/platform/glib/fast/css/text-overflow-ellipsis-text-align-right-expected.txt M LayoutTests/platform/glib/fast/css/textCapitalizeEdgeCases-expected.txt M LayoutTests/platform/glib/fast/css/universal-hover-quirk-expected.txt M LayoutTests/platform/glib/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt M LayoutTests/platform/glib/fast/c
[webkit-changes] [WebKit/WebKit] 92a81d: UnifiedPDF: Lookup pill has the wrong font size
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92a81dfc1401cf0f79b97c4123b7251bf4b08dd2 https://github.com/WebKit/WebKit/commit/92a81dfc1401cf0f79b97c4123b7251bf4b08dd2 Author: Tim Horton Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/Plugins/PluginView.cpp M Source/WebKit/WebProcess/Plugins/PluginView.h M Source/WebKit/WebProcess/WebPage/FindController.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm Log Message: --- UnifiedPDF: Lookup pill has the wrong font size https://bugs.webkit.org/show_bug.cgi?id=270835 rdar://123667947 Reviewed by Abrar Rahman Protyasha and Simon Fraser. Adopt TextIndicator for all UnifiedPDF text indication paths (Lookup from force-press and from the context menu, in addition to the existing find-in-page case). * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::showDefinitionForAttributedString): (WebKit::PDFPlugin::textForImmediateActionHitTestAtPoint): (WebKit::PDFPlugin::lookupTextAtLocation): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: (WebKit::PDFPluginBase::textIndicatorForCurrentSelection): (WebKit::PDFPluginBase::textIndicatorForSelection): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::performImmediateActionHitTestAtLocation): (WebKit::PDFPluginBase::dictionaryPopupInfoForSelection): Move this PDFPlugin-specific code here from WebPageMac. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::performContextMenuAction): (WebKit::UnifiedPDFPlugin::textIndicatorForCurrentSelection): (WebKit::UnifiedPDFPlugin::textIndicatorForSelection): (WebKit::UnifiedPDFPlugin::performDictionaryLookupAtLocation): (WebKit::UnifiedPDFPlugin::dictionaryPopupInfoForSelection): (WebKit::UnifiedPDFPlugin::showDefinitionForSelection): (WebKit::UnifiedPDFPlugin::textForImmediateActionHitTestAtPoint): Share more code between find and lookup. (WebKit::UnifiedPDFPlugin::searchInDictionary): Deleted. (WebKit::UnifiedPDFPlugin::showDefinitionForAttributedString): Deleted. (WebKit::UnifiedPDFPlugin::lookupTextAtLocation): Deleted. * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::textIndicatorForCurrentSelection): (WebKit::PluginView::performImmediateActionHitTestAtLocation const): (WebKit::PluginView::textIndicatorForSelection): Deleted. (WebKit::PluginView::lookupTextAtLocation const): Deleted. * Source/WebKit/WebProcess/Plugins/PluginView.h: Get rid of LookupTextResult. * Source/WebKit/WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::performImmediateActionHitTestAtLocation): (WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Deleted. Canonical link: https://commits.webkit.org/275994@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94f1c3: Unskip some layout tests when running with --site-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94f1c3176829feba3fb266fd73bb45cba7f86c02 https://github.com/WebKit/WebKit/commit/94f1c3176829feba3fb266fd73bb45cba7f86c02 Author: Alex Christensen Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Unskip some layout tests when running with --site-isolation https://bugs.webkit.org/show_bug.cgi?id=270870 rdar://124472866 Reviewed by Charlie Wolfe. This increases the number of tests we run by over 10x from 3 to 34. An assertion needed updating in WebPageProxy because we receive messages from processes that are not the main frame's process. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleMessage): (WebKit::WebPageProxy::handleSynchronousMessage): Canonical link: https://commits.webkit.org/275993@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7fc60: AX: frame-disconnect-textmarker-cache-crash.html f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7fc60bce0fc160d84129837d58712340e06a165 https://github.com/WebKit/WebKit/commit/c7fc60bce0fc160d84129837d58712340e06a165 Author: Tyler Wilcock Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/accessibility-isolated-tree/TestExpectations Log Message: --- AX: frame-disconnect-textmarker-cache-crash.html fails in ITM after https://commits.webkit.org/275791@main https://bugs.webkit.org/show_bug.cgi?id=270853 rdar://problem/124452605 Unreviewed test gardening. * LayoutTests/accessibility-isolated-tree/TestExpectations: Mark test as failing for now. Canonical link: https://commits.webkit.org/275992@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e880d7: chrome.action is undefined if the action key in th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e880d73dbb4dc6c60f4b36486962a3ffba9e5c42 https://github.com/WebKit/WebKit/commit/e880d73dbb4dc6c60f4b36486962a3ffba9e5c42 Author: Elijah Sawyers Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtension.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm Log Message: --- chrome.action is undefined if the action key in the manifest is missing or empty https://bugs.webkit.org/show_bug.cgi?id=270814 rdar://122330191 Reviewed by Timothy Hatcher. All keys in the dictionary in the manifest for action, browser_action, and page_action should be optional. This patch makes the necessary changes for that to be true. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm: (WebKit::WebExtension::hasAction): (WebKit::WebExtension::hasBrowserAction): (WebKit::WebExtension::hasPageAction): (WebKit::WebExtension::populateActionPropertiesIfNeeded): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm: (WebKit::WebExtensionAPINamespace::isPropertyAllowed): Canonical link: https://commits.webkit.org/275991@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d06002: Remove StyleAppearance::CapsLockIndicator
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d06002e88dea118000baa224563f54cd34131745 https://github.com/WebKit/WebKit/commit/d06002e88dea118000baa224563f54cd34131745 Author: Anne van Kesteren Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/html.css M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/style/StyleAppearance.cpp M Source/WebCore/style/StyleAppearance.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Remove StyleAppearance::CapsLockIndicator https://bugs.webkit.org/show_bug.cgi?id=250725 rdar://104616561 Reviewed by Tim Nguyen. It's not used for anything. * Source/WebCore/css/CSSPrimitiveValueMappings.h: (WebCore::toCSSValueID): * Source/WebCore/css/html.css: (input::-webkit-caps-lock-indicator): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::autoAppearanceForElement const): (WebCore::RenderTheme::createControlPart const): (WebCore::RenderTheme::paint): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::adjustCapsLockIndicatorStyle const): Deleted. (WebCore::RenderTheme::paintCapsLockIndicator): Deleted. * Source/WebCore/style/StyleAppearance.cpp: (WebCore::operator<<): * Source/WebCore/style/StyleAppearance.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/275990@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10bbc3: run-benchmarks should use the builtin server type ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10bbc37ccce8fa03b242be2f3fa8c98b1d094e05 https://github.com/WebKit/WebKit/commit/10bbc37ccce8fa03b242be2f3fa8c98b1d094e05 Author: Hysu Xiong Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py Log Message: --- run-benchmarks should use the builtin server type by default https://bugs.webkit.org/show_bug.cgi?id=270531 rdar://124084153 Reviewed by Stephanie Lewis. Switch the run-benchmarks default for --http-server-type to builtin. This helps reduce our dependency on Twisted. * Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py: (config_argument_parser): Canonical link: https://commits.webkit.org/275989@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc85b0: pictureInPicture in iOS does not work for camera s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc85b0e51049e8bf08fb1dc6a2dd538ffd982ebb https://github.com/WebKit/WebKit/commit/bc85b0e51049e8bf08fb1dc6a2dd538ffd982ebb Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm Log Message: --- pictureInPicture in iOS does not work for camera streams https://bugs.webkit.org/show_bug.cgi?id=268732 rdar://122295706 Reviewed by Eric Carlson. In the past entering pip window mode for local camera would end up showing nothing as camera would get muted if the app goes in background. With [AVCaptureSession initWithMediaEnvironment:], this restriction is no longer true. We can thus enable pip window for local cameras. Manually tested. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsPictureInPicture const): Deleted. Canonical link: https://commits.webkit.org/275988@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3795d9: Optimize text layout in text heavy web pages
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3795d9da24e4418ea3ed7f191e56e390738c6dac https://github.com/WebKit/WebKit/commit/3795d9da24e4418ea3ed7f191e56e390738c6dac Author: Yusuke Suzuki Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp M Source/WebCore/platform/graphics/FontCascade.cpp M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/WidthCache.h Log Message: --- Optimize text layout in text heavy web pages https://bugs.webkit.org/show_bug.cgi?id=270612 rdar://problem/124177964 Reviewed by Chris Dumez. This patch applies several changes. 1. isStrongDirectionalityCharacter is not used when the characters are 8Bit. We should apply isLatin1 fast path as the same to the caller. u_charDirection is ICU function and it is quite slow. 2. Move non-cach-hitting part of FontCascade::widthForSimpleText to FontCascade::widthForSimpleTextSlow. It has GlyphBuffer, and it has huge stack size. Let's extract the cache-hitting fast path from this function and avoid putting this on the stack. 3. This patch optimizes WidthCache. 3.1. We do not need to check MemoryPressureHandler status unless we extend the cache. 3.2. Since SmallStringKey's string size is small, we can make it much more like non-variable-length data and make it super fast. This patch changes the layout of SmallStringKey a bit so that we hold characters in std::array. So, comparison becomes `std::array == std::array` and because it is 32-bytes (16 size is picked for that), comparison gets done in a bulk style (e.g. 4 characters at once) automatically via compiler and it becomes super fast. By combining hash and length into one unsigned, we keep std::pair 40-bytes. 3.3. We also use WYHash for SmallStringKey's hashing. Plus, we now always hash all 16 characters (and if it is smaller than 16, then zeros follow). WYHash::computeHashAndMaskTop8Bits can see constant 16 size, so hashing gets done in a extremely fast way without branches (since now the size is always 16). Also, 16 is good number for WYHash since it can do 8-length hashing in a bulk way. 3.4. Making empty value of SmallStringKey zero. This allows HashMap to initialize newly rehashed table with zeroed-malloc. * Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp: (WebCore::Layout::TextUtil::isStrongDirectionalityCharacter): * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::widthForSimpleTextSlow const): (WebCore::addGlyphsFromText): Deleted. (WebCore::FontCascade::widthForSimpleText const): Deleted. * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::widthForSimpleText const): * Source/WebCore/platform/graphics/WidthCache.h: (WebCore::WidthCache::SmallStringKey::capacity): (WebCore::WidthCache::SmallStringKey::SmallStringKey): (WebCore::WidthCache::SmallStringKey::characters const): (WebCore::WidthCache::SmallStringKey::length const): (WebCore::WidthCache::SmallStringKey::hash const): (WebCore::WidthCache::SmallStringKey::isHashTableDeletedValue const): (WebCore::WidthCache::SmallStringKey::isHashTableEmptyValue const): (WebCore::WidthCache::add): (WebCore::WidthCache::addSlowCase): (WebCore::operator==): Deleted. Canonical link: https://commits.webkit.org/275987@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c2c34: Crash when quickly loading and unloading a Web Ext...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c2c34238fb70315d37c0d45c798e62ca746908c https://github.com/WebKit/WebKit/commit/5c2c34238fb70315d37c0d45c798e62ca746908c Author: Timothy Hatcher Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm Log Message: --- Crash when quickly loading and unloading a Web Extension. https://webkit.org/b/270862 rdar://124126618 Reviewed by Jeff Miller. When the extension controller is loading an extension context we move the local storage. The lambda can escape and be called async, but was only capturing references. We need to capture a protected this reference, and check if the context is still loaded before proceeding after the move has finished. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::load): Canonical link: https://commits.webkit.org/275986@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f0b9a: Non-unified build fix after 275657@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f0b9a8d21af3216db1c78f86f2e4f897fc9b2a5 https://github.com/WebKit/WebKit/commit/7f0b9a8d21af3216db1c78f86f2e4f897fc9b2a5 Author: Pascoe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp Log Message: --- Non-unified build fix after 275657@main https://bugs.webkit.org/show_bug.cgi?id=270863 rdar://124464930 Unreviewed, build fix. This import is needed, but isn't on ToT unified builds. Adding it to fix the build for non-unified. * Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp: Canonical link: https://commits.webkit.org/275985@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d6006: Versioning.
Branch: refs/heads/safari-7618.1.15.14-branch Home: https://github.com/WebKit/WebKit Commit: 2d60069b2bedbc97ecb5c3bf1891698399b7b8e1 https://github.com/WebKit/WebKit/commit/2d60069b2bedbc97ecb5c3bf1891698399b7b8e1 Author: Russell Epstein Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.15.14.1 Identifier: 272448.527@safari-7618.1.15.14-branch Commit: 31e01f5bb3b0e69e711aa408f62557cf74943d59 https://github.com/WebKit/WebKit/commit/31e01f5bb3b0e69e711aa408f62557cf74943d59 Author: Kimmo Kinnunen Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- Cherry-pick 26aaa25dcbdc. rdar://122309325 REGRESSION(267824@main): Changing HTMLCanvasElement width, height causes intermediate buffer allocations https://bugs.webkit.org/show_bug.cgi?id=268745 rdar://122309325 Reviewed by Simon Fraser. Resizing is intended to leave the buffer unallocated, so that sequential width, height assignments will not allocate multiple times. This intention was nullified by CanvasRenderingContext2DBase::reset(). Calling resetTransform redundantly would recreate the buffer immediately from width, height attribute setters. The transform reset is redundant, the context transform is reset when the context state saver is restored and re-saved. Clearing the canvas doesn't need to use public CanvasRenderingContext2DBase::clearCanvas() that will mutate the context state. The state is in known state with initial transform, and thus it doesn't need transform mutation. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::reset): Canonical link: https://commits.webkit.org/274135@main Identifier: 272448.528@safari-7618.1.15.14-branch Commit: 1d38857f5d9007f5c47d6d6ddc0b35856bb2d430 https://github.com/WebKit/WebKit/commit/1d38857f5d9007f5c47d6d6ddc0b35856bb2d430 Author: Ben Nham Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- Cherry-pick f4ce57789de5. rdar://121185956 hideContentUntilPendingUpdate async IPC call during backgrounding blocks process suspension https://bugs.webkit.org/show_bug.cgi?id=268799 rdar://121185956 Reviewed by Chris Dumez. On iOS, when the UIProcess goes into the background, it eventually calls in to hideContentUntilPendingUpdate through this call stack: ``` WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate() WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground() WebKit::ApplicationStateTracker::didCompleteSnapshotSequence() ``` The problem is that we recently added an async `DrawingArea::DispatchAfterEnsuringDrawing` IPC with reply handler call to hideContentUntilPendingUpdate (see 269776@main, 270672@main, 271260@main). An async IPC with a reply handler in the UIProcess implicitly takes out a background activity which prevents the WebContent process (and also the UIProcess) from suspending until the reply handler runs. Unfortunately, since the WebContent process is in the background, presumably it doesn't render, so the DispatchAfterEnsuringDrawing reply handler doesn't run, and the background activity also never completes. We basically end up blocking process suspension entirely until the 15 second timer in ProcessStateMonitor expires and forcefully invalidates all background activities for all processes. We need to fix this by reworking the logic somehow or by making this DispatchAfterEnsuringDrawing IPC not create a background activity. Here I'm just trying to make the IPC call not start a background activity. Note that there's also a DispatchAfterEnsuringDrawing call in WebPageProxy that I didn't touch since I don't have evidence that it's causing a background power regression, but I wonder if that also should avoid creating a background activity. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate): Canonical link: https://commits.webkit.org/274157@main Identifier: 272448.529@safari-7618.1.15.14-branch Commit: c4a7c5823ba73e8980db9a1e601e100d262e2049 https://github.com/WebKit/WebKit/commit/c4a7c5823ba73e8980db9a1e601e100d262e2049 Author: Jer Noble Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: A LayoutTests/http/tests/media/fairplay/fp
[webkit-changes] [WebKit/WebKit] ef0ad7: Versioning.
Branch: refs/heads/safari-7618.1.15.13-branch Home: https://github.com/WebKit/WebKit Commit: ef0ad7f8ee466c153e3b22b355c8975144ffd7ef https://github.com/WebKit/WebKit/commit/ef0ad7f8ee466c153e3b22b355c8975144ffd7ef Author: Russell Epstein Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.15.13.1 Identifier: 272448.527@safari-7618.1.15.13-branch Commit: e8b983d71be87010079e26e448de1fb52dfc03c8 https://github.com/WebKit/WebKit/commit/e8b983d71be87010079e26e448de1fb52dfc03c8 Author: Kimmo Kinnunen Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- Cherry-pick 26aaa25dcbdc. rdar://122309325 REGRESSION(267824@main): Changing HTMLCanvasElement width, height causes intermediate buffer allocations https://bugs.webkit.org/show_bug.cgi?id=268745 rdar://122309325 Reviewed by Simon Fraser. Resizing is intended to leave the buffer unallocated, so that sequential width, height assignments will not allocate multiple times. This intention was nullified by CanvasRenderingContext2DBase::reset(). Calling resetTransform redundantly would recreate the buffer immediately from width, height attribute setters. The transform reset is redundant, the context transform is reset when the context state saver is restored and re-saved. Clearing the canvas doesn't need to use public CanvasRenderingContext2DBase::clearCanvas() that will mutate the context state. The state is in known state with initial transform, and thus it doesn't need transform mutation. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::reset): Canonical link: https://commits.webkit.org/274135@main Identifier: 272448.528@safari-7618.1.15.13-branch Commit: bfdf50754050c294ccfb3ed4ed46d99a7ba06b4f https://github.com/WebKit/WebKit/commit/bfdf50754050c294ccfb3ed4ed46d99a7ba06b4f Author: Ben Nham Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- Cherry-pick f4ce57789de5. rdar://121185956 hideContentUntilPendingUpdate async IPC call during backgrounding blocks process suspension https://bugs.webkit.org/show_bug.cgi?id=268799 rdar://121185956 Reviewed by Chris Dumez. On iOS, when the UIProcess goes into the background, it eventually calls in to hideContentUntilPendingUpdate through this call stack: ``` WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate() WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground() WebKit::ApplicationStateTracker::didCompleteSnapshotSequence() ``` The problem is that we recently added an async `DrawingArea::DispatchAfterEnsuringDrawing` IPC with reply handler call to hideContentUntilPendingUpdate (see 269776@main, 270672@main, 271260@main). An async IPC with a reply handler in the UIProcess implicitly takes out a background activity which prevents the WebContent process (and also the UIProcess) from suspending until the reply handler runs. Unfortunately, since the WebContent process is in the background, presumably it doesn't render, so the DispatchAfterEnsuringDrawing reply handler doesn't run, and the background activity also never completes. We basically end up blocking process suspension entirely until the 15 second timer in ProcessStateMonitor expires and forcefully invalidates all background activities for all processes. We need to fix this by reworking the logic somehow or by making this DispatchAfterEnsuringDrawing IPC not create a background activity. Here I'm just trying to make the IPC call not start a background activity. Note that there's also a DispatchAfterEnsuringDrawing call in WebPageProxy that I didn't touch since I don't have evidence that it's causing a background power regression, but I wonder if that also should avoid creating a background activity. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate): Canonical link: https://commits.webkit.org/274157@main Identifier: 272448.529@safari-7618.1.15.13-branch Commit: a666863e2773f8d067f4d8b5a85679d7aa57d80e https://github.com/WebKit/WebKit/commit/a666863e2773f8d067f4d8b5a85679d7aa57d80e Author: Elliott Williams Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h
[webkit-changes] [WebKit/WebKit] e6a859: Cherry-pick 26aaa25dcbdc. rdar://122309325
Branch: refs/heads/safari-7618.1.15.12-branch Home: https://github.com/WebKit/WebKit Commit: e6a859812f68d2c7e1bff4a0acea2b5f8627f85b https://github.com/WebKit/WebKit/commit/e6a859812f68d2c7e1bff4a0acea2b5f8627f85b Author: Kimmo Kinnunen Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- Cherry-pick 26aaa25dcbdc. rdar://122309325 REGRESSION(267824@main): Changing HTMLCanvasElement width, height causes intermediate buffer allocations https://bugs.webkit.org/show_bug.cgi?id=268745 rdar://122309325 Reviewed by Simon Fraser. Resizing is intended to leave the buffer unallocated, so that sequential width, height assignments will not allocate multiple times. This intention was nullified by CanvasRenderingContext2DBase::reset(). Calling resetTransform redundantly would recreate the buffer immediately from width, height attribute setters. The transform reset is redundant, the context transform is reset when the context state saver is restored and re-saved. Clearing the canvas doesn't need to use public CanvasRenderingContext2DBase::clearCanvas() that will mutate the context state. The state is in known state with initial transform, and thus it doesn't need transform mutation. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::reset): Canonical link: https://commits.webkit.org/274135@main Identifier: 272448.527@safari-7618.1.15.12-branch Commit: 7ff929c51b262132ce42e0f4f80edadb785a6e78 https://github.com/WebKit/WebKit/commit/7ff929c51b262132ce42e0f4f80edadb785a6e78 Author: Ben Nham Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- Cherry-pick f4ce57789de5. rdar://121185956 hideContentUntilPendingUpdate async IPC call during backgrounding blocks process suspension https://bugs.webkit.org/show_bug.cgi?id=268799 rdar://121185956 Reviewed by Chris Dumez. On iOS, when the UIProcess goes into the background, it eventually calls in to hideContentUntilPendingUpdate through this call stack: ``` WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate() WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground() WebKit::ApplicationStateTracker::didCompleteSnapshotSequence() ``` The problem is that we recently added an async `DrawingArea::DispatchAfterEnsuringDrawing` IPC with reply handler call to hideContentUntilPendingUpdate (see 269776@main, 270672@main, 271260@main). An async IPC with a reply handler in the UIProcess implicitly takes out a background activity which prevents the WebContent process (and also the UIProcess) from suspending until the reply handler runs. Unfortunately, since the WebContent process is in the background, presumably it doesn't render, so the DispatchAfterEnsuringDrawing reply handler doesn't run, and the background activity also never completes. We basically end up blocking process suspension entirely until the 15 second timer in ProcessStateMonitor expires and forcefully invalidates all background activities for all processes. We need to fix this by reworking the logic somehow or by making this DispatchAfterEnsuringDrawing IPC not create a background activity. Here I'm just trying to make the IPC call not start a background activity. Note that there's also a DispatchAfterEnsuringDrawing call in WebPageProxy that I didn't touch since I don't have evidence that it's causing a background power regression, but I wonder if that also should avoid creating a background activity. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::hideContentUntilPendingUpdate): Canonical link: https://commits.webkit.org/274157@main Identifier: 272448.528@safari-7618.1.15.12-branch Commit: 5e0a5632b3321dabf1f2b427c0dc681153cf90bc https://github.com/WebKit/WebKit/commit/5e0a5632b3321dabf1f2b427c0dc681153cf90bc Author: Russell Epstein Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.15.12.1 Identifier: 272448.529@safari-7618.1.15.12-branch Commit: 9952c70b8dc64278be024239d63f0e93b7edc55c https://github.com/WebKit/WebKit/commit/9952c70b8dc64278be024239d63f0e93b7edc55c Author: Elliott Williams Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h
[webkit-changes] [WebKit/WebKit] 9c8f91: Versioning.
Branch: refs/heads/safari-7618.1.15.10-branch Home: https://github.com/WebKit/WebKit Commit: 9c8f91f26c4fd318ff5774efb97a7ec19aa2ade2 https://github.com/WebKit/WebKit/commit/9c8f91f26c4fd318ff5774efb97a7ec19aa2ade2 Author: Russell Epstein Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7618.1.15.10.1 Identifier: 272448.527@safari-7618.1.15.10-branch Commit: ea917500c3c6383c51bccfe4d77db2af0e2b3408 https://github.com/WebKit/WebKit/commit/ea917500c3c6383c51bccfe4d77db2af0e2b3408 Author: Wenson Hsieh Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebKit/Shared/FocusedElementInformation.h M Source/WebKit/Shared/FocusedElementInformation.serialization.in M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm Log Message: --- Cherry-pick 1cb03ba5c4bb. rdar://120743391 [iOS] -[WKContentView hasText] is incorrect when initially focusing an editable element https://bugs.webkit.org/show_bug.cgi?id=267729 rdar://120743391 Reviewed by Aditya Keerthi. Currently, `-hasText` is based entirely on the last cached `EditorState`'s post layout data. In the case where we've just started showing the keyboard for a focused editable element in `-[WKContentView _elementDidFocus:…:userObject:]`, we're still waiting for a new `EditorState` to arrive, so this result ends up being invalid (either `false` if we haven't received any post-layout editor state yet, or stale editor state data). To avoid this, we add a `hasPlainText` flag to `FocusedElementInformation` that represents whether or not the focused element initially had non-empty text content upon focus; if we're currently in the process of focusing (or are waiting for post-layout data) in `-hasText`, then use this initial value instead of the `EditorState`. Test: KeyboardInputTests.HasTextAfterFocusingTextField * Source/WebKit/Shared/FocusedElementInformation.h: * Source/WebKit/Shared/FocusedElementInformation.serialization.in: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView hasText]): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::focusedElementInformation): For text fields and text areas, instead of using `hasPlainText` (which relies on `TextIterator`), simply check whether the `value` is non-empty instead to avoid any extra performance cost. * Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Canonical link: https://commits.webkit.org/273211@main Identifier: 272448.528@safari-7618.1.15.10-branch Commit: 8415dd08d9faeeba42408774dd3739cb1c9f09fc https://github.com/WebKit/WebKit/commit/8415dd08d9faeeba42408774dd3739cb1c9f09fc Author: Jer Noble Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebCore/page/Quirks.cpp Log Message: --- Cherry-pick f2404c166790. rdar://121471373 [iOS] YouTube does not provide an AirPlay button in fullscreen mode https://bugs.webkit.org/show_bug.cgi?id=268634 rdar://121471373 Reviewed by Brent Fulgham and Aditya Keerthi. Add a quirk to disable the Fullscreen API on YouTube.com (and youtube.com embeds). * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableElementFullscreenQuirk const): Canonical link: https://commits.webkit.org/274117@main Identifier: 272448.529@safari-7618.1.15.10-branch Commit: 8155dd1252cc5d72eb15cf76e78dda26a575ebd8 https://github.com/WebKit/WebKit/commit/8155dd1252cc5d72eb15cf76e78dda26a575ebd8 Author: Kimmo Kinnunen Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M LayoutTests/platform/ios/fast/canvas/offscreen-giant-transfer-to-imagebitmap-expected.txt M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- Cherry-pick 26aaa25dcbdc. rdar://122309325 REGRESSION(267824@main): Changing HTMLCanvasElement width, height causes intermediate buffer allocations https://bugs.webkit.org/show_bug.cgi?id=268745 rdar://122309325 Reviewed by Simon Fraser. Resizing is intended to leave the buffer unallocated, so that sequential width, height assignments will not allocate multiple times. This intention was nullified by CanvasRenderingContext2DBase::reset(). Calling resetTransform redundantly would recreate the buffer immediately from width, height attribute setters. The transform reset is redundant, the context transform is reset when the context state saver is restored and re-saved. Clearing the canvas doesn't need to use public CanvasRenderingContext2DBase::clearCan
[webkit-changes] [WebKit/WebKit] e0f90e: Unreviewed, correct fast/forms/switch/no-pixels-ou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0f90e9713f350d396dc0e5113af7dc71f81ca63 https://github.com/WebKit/WebKit/commit/e0f90e9713f350d396dc0e5113af7dc71f81ca63 Author: Anne van Kesteren Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/fast/forms/switch/no-pixels-outside-the-box-vertical-lr-rtl.html M LayoutTests/fast/forms/switch/no-pixels-outside-the-box.html M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Unreviewed, correct fast/forms/switch/no-pixels-outside-the-box fuzziness for Intel https://bugs.webkit.org/show_bug.cgi?id=270823 rdar://124413482 Unfortunately I did not learn last time around that on Intel there's two additional pixels that differ. * LayoutTests/fast/forms/switch/no-pixels-outside-the-box-vertical-lr-rtl.html: * LayoutTests/fast/forms/switch/no-pixels-outside-the-box.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275984@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d4124e: Versioning.
Branch: refs/heads/safari-7618.1.15.11-branch
Home: https://github.com/WebKit/WebKit
Commit: d4124ec0bf9e092be48ca5b5535a47d4066f5b95
https://github.com/WebKit/WebKit/commit/d4124ec0bf9e092be48ca5b5535a47d4066f5b95
Author: Myah Cobbs
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Configurations/Version.xcconfig
Log Message:
---
Versioning.
WebKit-7618.1.15.11.1
Identifier: 272448.527@safari-7618.1.15.11-branch
Commit: cd722420bfa8fc7f04b7e20fc31aedb9742bf1ac
https://github.com/WebKit/WebKit/commit/cd722420bfa8fc7f04b7e20fc31aedb9742bf1ac
Author: Yusuke Suzuki
Date: 2024-02-08 (Thu, 08 Feb 2024)
Changed paths:
M Source/JavaScriptCore/runtime/HasOwnPropertyCache.h
M Source/JavaScriptCore/runtime/LazyPropertyInlines.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
A Source/WTF/wtf/LazyRef.h
A Source/WTF/wtf/LazyUniqueRef.h
M Tools/TestWebKitAPI/CMakeLists.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WTF/LazyRef.cpp
A Tools/TestWebKitAPI/Tests/WTF/LazyUniqueRef.cpp
Log Message:
---
Cherry-pick 339bfd3e4a54. rdar://122509050
[WTF] Add LazyRef & LazyUniqueRef
https://bugs.webkit.org/show_bug.cgi?id=267830
rdar://121328458
Reviewed by Ryosuke Niwa.
This patch adds LazyRef and LazyUniqueRef. This is similar to LazyProperty
in JSC.
We can set *stateless* lambda in the constructor side of the owner object
so that it offers clean interface for lazy initialization,
which does not mess up the owner object's interface.
For example,
LazyUniqueRef m_property;
Property& property() { return m_property.get(*this); }
First parameter is owner, which needs to be passed to `get`. And then, this
`get` will automatically initialize if it is not initialized.
And the initialization code can be freely customized, but you do not need
to define it as a VM's member! Instead, you can define it as a lambda inside
VM.cpp.
// This lambda needs to be stateless. So it must not capture anything
(otherwise, it hits crash because of RELEASE_ASSERT anyway).
m_property.initLater(
[](VM& vm, auto& ref) {
// You can do whatever. Even you can invoke the other property
which can be further lazily initialized (so, it implicitly creates dependency
graph of initialization).
ref.set(Property::create());
// And further, you can do anything after setting it. So these
operations can see Property& via `vm.property()`.
});
Or you can set lambda in constructor, so like, VM's constructor list,
: m_property(
[](VM& vm, auto& ref) {
// You can do whatever. Even you can invoke the other property
which can be further lazily initialized (so, it implicitly creates dependency
graph of initialization).
ref.set(Property::create());
// And further, you can do anything after setting it. So these
operations can see Property& via `vm.property()`.
})
, m_other()
, ...
This patch applies this to some of JSC::VM's fields, making definitions
much cleaner by moving all messy parts into VM.cpp side and clean up VM.h's
interface.
* Source/JavaScriptCore/runtime/HasOwnPropertyCache.h:
(JSC::HasOwnPropertyCache::Entry::offsetOfStructureID): Deleted.
(JSC::HasOwnPropertyCache::Entry::offsetOfImpl): Deleted.
(JSC::HasOwnPropertyCache::Entry::offsetOfResult): Deleted.
(JSC::HasOwnPropertyCache::operator delete): Deleted.
(JSC::HasOwnPropertyCache::create): Deleted.
(JSC::HasOwnPropertyCache::hash): Deleted.
(JSC::HasOwnPropertyCache::get): Deleted.
(JSC::HasOwnPropertyCache::tryAdd): Deleted.
(JSC::HasOwnPropertyCache::clear): Deleted.
(JSC::HasOwnPropertyCache::clearBuffer): Deleted.
(JSC::VM::ensureHasOwnPropertyCache): Deleted.
* Source/JavaScriptCore/runtime/LazyPropertyInlines.h:
(JSC::ElementType>::initLater):
* Source/JavaScriptCore/runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::invalidateStructureChainIntegrity):
(JSC::VM::ensureWatchdog): Deleted.
(JSC::VM::ensureHeapProfiler): Deleted.
(JSC::VM::ensureShadowChicken): Deleted.
(JSC::VM::ensureMegamorphicCacheSlow): Deleted.
* Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::watchdog):
(JSC::VM::ensureWatchdog):
(JSC::VM::heapProfiler):
(JSC::VM::ensureHeapProfiler):
(JSC::VM::hasOwnPropertyCache):
(JSC::VM::ensureHasOwnPropertyCache):
(JSC::VM::megamorphicCache):
(JSC::VM::ensureMegamorphicCache):
(JSC::VM::shadowChicken):
(JSC::VM::ensureShadowChicken):
(JSC::VM::heapProfiler const): Deleted.
* Source/WTF/WTF.xcodeproj/project.pbxpr
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7618.1.15-branch Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7618.1.14.1-branch Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7618.1.14.14-branch Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7618.1.14.13-branch Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/safari-7618-branch Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a9eb13: Add HAVE_UPDATED_WEB_EXTENSION_PROMPT_COMPLETION_H...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a9eb13f5a7a4fd8ee460706369037445cadc10ed https://github.com/WebKit/WebKit/commit/a9eb13f5a7a4fd8ee460706369037445cadc10ed Author: Timothy Hatcher Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h Log Message: --- Add HAVE_UPDATED_WEB_EXTENSION_PROMPT_COMPLETION_HANDLER. https://webkit.org/b/270858 rdar://problem/124459704 Reviewed by Jeff Miller. We need to add a define to allow clients to adopt the delegate changes from 275950@main. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerDelegate.h: Canonical link: https://commits.webkit.org/275983@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9c492: [Skia] Add support for favicons on GTK
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9c4929afd39ec66bf6c99028c2445be9bfd1522 https://github.com/WebKit/WebKit/commit/e9c4929afd39ec66bf6c99028c2445be9bfd1522 Author: Patrick Griffis Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/PlatformGTK.cmake M Source/WebCore/SourcesGTK.txt A Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp A Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h M Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp Log Message: --- [Skia] Add support for favicons on GTK https://bugs.webkit.org/show_bug.cgi?id=270811 Reviewed by Carlos Garcia Campos. * Source/WebCore/PlatformGTK.cmake: * Source/WebCore/SourcesGTK.txt: * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.cpp: Added. (WebCore::skiaImageToGdkTexture): * Source/WebCore/platform/graphics/gtk/GdkSkiaUtilities.h: Added. * Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp: (webkitFaviconDatabaseGetFaviconInternal): (webkit_favicon_database_get_favicon_finish): Canonical link: https://commits.webkit.org/275982@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 761708: WebExtensionContext::requestPermissions needs to i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76170850b6e90c8640ed83bac975a365972c5679 https://github.com/WebKit/WebKit/commit/76170850b6e90c8640ed83bac975a365972c5679 Author: Timothy Hatcher Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- WebExtensionContext::requestPermissions needs to ignore denied permissions. https://webkit.org/b/270857 rdar://problem/124457612 Reviewed by Jeff Miller. Currently these request methods use hasPermission(), but that isn't correct since if the permission is denied we shouldn't request it. Add new needsPermission() methods that return true only if the permission is requested. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::requestPermissionMatchPatterns): Use needsPermission(). (WebKit::WebExtensionContext::requestPermissionToAccessURLs): Ditto. (WebKit::WebExtensionContext::requestPermissions): Ditto. (WebKit::WebExtensionContext::needsPermission): Added. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::needsPermission): Added. Canonical link: https://commits.webkit.org/275981@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 114392: AX: Incomplete object information with focus event...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 114392b51f9c322d303c0e44142d53d89276f66b https://github.com/WebKit/WebKit/commit/114392b51f9c322d303c0e44142d53d89276f66b Author: Przemyslaw Gorszkowski Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/accessibility/focus-new-element.html A LayoutTests/platform/glib/accessibility/focus-new-element-expected.txt A LayoutTests/platform/ios-simulator-wk2/accessibility/focus-new-element-expected.txt A LayoutTests/platform/mac/accessibility/focus-new-element-expected.txt M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AXObjectCache.h M Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp Log Message: --- AX: Incomplete object information with focus event on dynamic created div https://bugs.webkit.org/show_bug.cgi?id=270433 Reviewed by Tyler Wilcock. When the element is dynamically created and focused, the focus change event should be deferred in case renderer is not available yet but document needs style recalculation. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::shouldDeferFocusChange): (WebCore::AXObjectCache::onFocusChange): * Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp: (testAccessibleStateChangedFocus): (beforeAll): * LayoutTests/accessibility/focus-new-element.html: Added. * LayoutTests/platform/glib/accessibility/focus-new-element-expected.txt: Added. * LayoutTests/platform/ios-simulator-wk2/accessibility/focus-new-element-expected.txt: Added. * LayoutTests/platform/mac/accessibility/focus-new-element-expected.txt: Added. Canonical link: https://commits.webkit.org/275980@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a88637: Unreviewed, reverting 275922@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a886378aa293617be992a0cb04320ef7c71c4367 https://github.com/WebKit/WebKit/commit/a886378aa293617be992a0cb04320ef7c71c4367 Author: Commit Queue Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSStyleRule.idl M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSParserImpl.h M Source/WebCore/css/parser/CSSSelectorParser.cpp M Source/WebCore/css/parser/CSSSelectorParserContext.cpp M Source/WebCore/css/parser/CSSSelectorParserContext.h Log Message: --- Unreviewed, reverting 275922@main. https://bugs.webkit.org/show_bug.cgi?id=270855 Caused crashes on fast/css/cssom-mutation-stylerule.html Reverted changeset: "[css-nesting] Remove feature flag" https://bugs.webkit.org/show_bug.cgi?id=270793 https://commits.webkit.org/275922@main Canonical link: https://commits.webkit.org/275979@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7f01a: Avoid using downcast<>() in ElementData::attribute...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7f01add50ebcfedd921f6f4d0ee721839f2dec0 https://github.com/WebKit/WebKit/commit/d7f01add50ebcfedd921f6f4d0ee721839f2dec0 Author: Chris Dumez Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/dom/ElementData.h Log Message: --- Avoid using downcast<>() in ElementData::attributesIterator() https://bugs.webkit.org/show_bug.cgi?id=270834 Reviewed by Ryosuke Niwa. Avoid using downcast<>() in ElementData::attributesIterator(), for performance reasons. * Source/WebCore/dom/ElementData.h: (WebCore::ElementData::attributesIterator const): Canonical link: https://commits.webkit.org/275978@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dca14b: Remove EnumTraits specialization for IPC::MessageF...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dca14b10d8160a8fc0f36ed7957f998380aef9fe https://github.com/WebKit/WebKit/commit/dca14b10d8160a8fc0f36ed7957f998380aef9fe Author: Žan Doberšek Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/Platform/IPC/MessageFlags.h A Source/WebKit/Platform/IPC/MessageFlags.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Remove EnumTraits specialization for IPC::MessageFlags https://bugs.webkit.org/show_bug.cgi?id=267534 Reviewed by Chris Dumez. Remove the IPC::MessageFlags EnumTraits specialization, replacing it with the appropriate serialization specification in a separate input file. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/Platform/IPC/MessageFlags.h: * Source/WebKit/Platform/IPC/MessageFlags.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/275977@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e39892: Fix edge cases of keyboard navigations around `anc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e39892e12f8d3c3a544327c87c9904401e15ef9f https://github.com/WebKit/WebKit/commit/e39892e12f8d3c3a544327c87c9904401e15ef9f Author: Ahmad Saleem Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/fast/events/anchor-empty-focus-expected.txt M LayoutTests/fast/events/anchor-empty-focus.html M LayoutTests/fast/events/frame-tab-focus-expected.txt M LayoutTests/fast/events/frame-tab-focus.html M LayoutTests/fast/events/tab-focus-anchor-expected.txt A LayoutTests/fast/events/tab-focus-anchor-tab-to-links-expected.txt A LayoutTests/fast/events/tab-focus-anchor-tab-to-links.html M LayoutTests/fast/events/tab-focus-anchor.html A LayoutTests/fast/forms/focus-on-control-with-zero-size-expected.txt A LayoutTests/fast/forms/focus-on-control-with-zero-size.html M LayoutTests/platform/ios/TestExpectations M Source/WebCore/html/HTMLAnchorElement.cpp Log Message: --- Fix edge cases of keyboard navigations around `anchor` elements with `TabsToLink` https://bugs.webkit.org/show_bug.cgi?id=270713 Reviewed by Ryosuke Niwa. This patch is to fix edge cases in keyboard focus navigation around `anchor` elements: Partial Merge: https://chromium.googlesource.com/chromium/blink/+/53f8eba14b6362795bae47c02236ca93303264a6 By merging above, WebKit is trying to fix case around `empty anchor` while `TabsToLinks` enabled. The test case was failing currently in WebKit, so this fixes it. Merge: https://chromium.googlesource.com/chromium/blink/+/7ef69ef071ba2b49ece747b93518b9a1218f9c45 In this merge, WebKit is aligning to allow keyboard navigation to anchors with `TabsToLinks` being disabled if the anchors have explicit tabindex. Beside following, this patch still retains `early return` if it is not focusable. > Changes: * Source/WebCore/html/HTMLAnchorElement.cpp: (HTMLAnchorElement::isKeyboardFocusable): > Test Cases & Expectations: * LayoutTests/fast/events/anchor-empty-focus-expected.txt: * LayoutTests/fast/events/anchor-empty-focus.html: * LayoutTests/fast/events/frame-tab-focus-expected.txt: * LayoutTests/fast/events/frame-tab-focus.html: * LayoutTests/fast/events/tab-focus-anchor-expected.txt: * LayoutTests/fast/events/tab-focus-anchor-tab-to-links-expected.txt: * LayoutTests/fast/events/tab-focus-anchor-tab-to-links.html: * LayoutTests/fast/events/tab-focus-anchor.html: * LayoutTests/fast/forms/focus-on-control-with-zero-size.html: * LayoutTests/fast/forms/focus-on-control-with-zero-size-expected.txt: > Platform Specific Test Expectation: * LayoutTests/platform/ios/TestExpectations: `iOS` don't have 'EventSender` keydown support Canonical link: https://commits.webkit.org/275976@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 876480: http/wpt/webrtc/video-script-transform.html, http/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87648049b5dd892907ba27366340fce58cc06f4d https://github.com/WebKit/WebKit/commit/87648049b5dd892907ba27366340fce58cc06f4d Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm Log Message: --- http/wpt/webrtc/video-script-transform.html, http/wpt/webrtc/video-script-transform-simulcast.html and imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html are failing on x86_64 bots rdar://124384840 https://bugs.webkit.org/show_bug.cgi?id=270790 Reviewed by Eric Carlson. I can reproduce locally on my x86 device by running one of these tests in parallel. The mock camera is failing capture if no frame is generated during 1 second. This happens since we are using a max buffer pool of 10 pixel buffers and it can take some time to free the pixel buffers. When increasing the limit to 5 seconds (aka 150 at 30fps), I am no longer able to reproduce. * Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm: (WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer): Canonical link: https://commits.webkit.org/275975@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c6309: Make SpeechRecognition class final
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c6309756835375c42b06c608256d654c2e2cbc3 https://github.com/WebKit/WebKit/commit/1c6309756835375c42b06c608256d654c2e2cbc3 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/Modules/speech/SpeechRecognition.h Log Message: --- Make SpeechRecognition class final rdar://124437578 https://bugs.webkit.org/show_bug.cgi?id=270842 Reviewed by Eric Carlson. * Source/WebCore/Modules/speech/SpeechRecognition.h: Canonical link: https://commits.webkit.org/275974@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 521523: [Skia] Change licenses to BSD
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 521523a605400300192fa4a9cec2085d65ef16cd https://github.com/WebKit/WebKit/commit/521523a605400300192fa4a9cec2085d65ef16cd Author: Pawel Lampe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/page/skia/MemoryReleaseSkia.cpp M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp M Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp M Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp M Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp M Source/WebCore/platform/graphics/skia/FontVariationsSkia.cpp M Source/WebCore/platform/graphics/skia/FontVariationsSkia.h M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebCore/platform/skia/SharedBufferSkia.cpp Log Message: --- [Skia] Change licenses to BSD https://bugs.webkit.org/show_bug.cgi?id=270844 Reviewed by Carlos Garcia Campos. * Source/WebCore/page/skia/MemoryReleaseSkia.cpp: * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerSkia.cpp: * Source/WebCore/platform/graphics/skia/FontCacheSkia.cpp: * Source/WebCore/platform/graphics/skia/FontCustomPlatformDataSkia.cpp: * Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp: * Source/WebCore/platform/graphics/skia/FontVariationsSkia.cpp: * Source/WebCore/platform/graphics/skia/FontVariationsSkia.h: * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: * Source/WebCore/platform/skia/SharedBufferSkia.cpp: Canonical link: https://commits.webkit.org/275973@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de0adc: [Skia] Compute tile mode on phased tiled rect
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de0adcf1202f689f4b5aaeab9940df8b306dfa6c https://github.com/WebKit/WebKit/commit/de0adcf1202f689f4b5aaeab9940df8b306dfa6c Author: Georges Basile Stavracas Neto Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Compute tile mode on phased tiled rect https://bugs.webkit.org/show_bug.cgi?id=270795 Reviewed by Carlos Garcia Campos. Otherwise it'll clamp after translating the source image. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawPattern): Canonical link: https://commits.webkit.org/275972@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 297c8c: Remove separate ruby user-agent stylesheet and set...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 297c8c16edae5c04e1392bd04d53fa0a4571de45 https://github.com/WebKit/WebKit/commit/297c8c16edae5c04e1392bd04d53fa0a4571de45 Author: Antti Koivisto Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/html.css R Source/WebCore/css/ruby.css M Source/WebCore/style/UserAgentStyle.cpp M Source/WebCore/style/UserAgentStyle.h Log Message: --- Remove separate ruby user-agent stylesheet and setting https://bugs.webkit.org/show_bug.cgi?id=270843 rdar://problem/124438539 Reviewed by Anne van Kesteren. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: The setting would just disable ruby stylesheet parsing. =* Source/WebCore/CMakeLists.txt: =* Source/WebCore/DerivedSources-input.xcfilelist: =* Source/WebCore/DerivedSources.make: =* Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/html.css: (ruby): (ruby, rt): (ruby > rt): (ruby > :not(rb, rbc, ruby)): (rt): Deleted. Move the ruby style rules to the main UA sheet. * Source/WebCore/css/ruby.css: Removed. * Source/WebCore/style/UserAgentStyle.cpp: (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): * Source/WebCore/style/UserAgentStyle.h: Canonical link: https://commits.webkit.org/275971@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40efee: Advanced Tracking and Fingerprinting Protection Is...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40efee6a397a9ef0fadc63c54c180b99ac713ba5 https://github.com/WebKit/WebKit/commit/40efee6a397a9ef0fadc63c54c180b99ac713ba5 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: A LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost-expected.txt A LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost-serviceworker.js A LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost.html A LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost.html.json M Source/WebCore/Modules/fetch/FetchLoader.cpp M Source/WebCore/Modules/fetch/FetchRequest.cpp M Source/WebCore/Modules/fetch/FetchRequest.h M Source/WebCore/loader/ResourceLoaderOptions.h M Source/WebCore/loader/ThreadableLoader.cpp M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp Log Message: --- Advanced Tracking and Fingerprinting Protection Issue with Service Workers rdar://117522948 https://bugs.webkit.org/show_bug.cgi?id=263366 Reviewed by Chris Dumez. Requests exposed to service worker via the fetch events have already gone through content extension checks. We can safely disable content extension checks for those requests. We add a corresponding ResourceLoaderOptions which is tested in CachedResourceLoader::requestResource before apply content extension checks. This new option is always enforcing content extension checks except for service worker fetch event requests. We do so in ServiceWorkerFetch::dispatchFetchEvent, and we ensure that cloned requests or requests created from fetch event requests keep the same flag. * LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost-expected.txt: Added. * LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost-serviceworker.js: Added. (onmessage.async e): * LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost.html: Added. * LayoutTests/http/tests/contentextensions/service-worker-block-everything-if-localhost.html.json: Added. * Source/WebCore/Modules/fetch/FetchLoader.cpp: (WebCore::FetchLoader::start): * Source/WebCore/Modules/fetch/FetchRequest.cpp: (WebCore::FetchRequest::initializeWith): (WebCore::FetchRequest::clone): * Source/WebCore/Modules/fetch/FetchRequest.h: * Source/WebCore/loader/ResourceLoaderOptions.h: (WebCore::ResourceLoaderOptions::shouldEnableContentExtensionsCheck): (WebCore::ResourceLoaderOptions::ResourceLoaderOptions): (WebCore::ResourceLoaderOptions::fetchPriorityHint): Deleted. * Source/WebCore/loader/ThreadableLoader.cpp: (WebCore::ThreadableLoaderOptions::isolatedCopy const): * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestResource): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::disableContentExtensionsChecks): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::dispatchFetchEvent): Canonical link: https://commits.webkit.org/275970@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad13d1: [ macOS ] fast/speechrecognition/start-recognition...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad13d163120d5e9bba5017c698e95994f6b88e28 https://github.com/WebKit/WebKit/commit/ad13d163120d5e9bba5017c698e95994f6b88e28 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/Modules/speech/SpeechRecognition.cpp M Source/WebCore/Modules/speech/SpeechRecognition.h Log Message: --- [ macOS ] fast/speechrecognition/start-recognition-after-denied-gum.html is a flaky Timeout rdar://123722096 https://bugs.webkit.org/show_bug.cgi?id=270194 Reviewed by Eric Carlson. Make sure to not GC SpeechRecognition if it can fire events and has event listeners. * LayoutTests/platform/mac-wk2/TestExpectations: * Source/WebCore/Modules/speech/SpeechRecognition.cpp: (WebCore::SpeechRecognition::virtualHasPendingActivity const): * Source/WebCore/Modules/speech/SpeechRecognition.h: Canonical link: https://commits.webkit.org/275969@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c4fa8: [WPE] Update baselines after 275888@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c4fa8678161cd70755e84393114909bc00b70bd https://github.com/WebKit/WebKit/commit/3c4fa8678161cd70755e84393114909bc00b70bd Author: Vitaly Dyachkov Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/css2.1/t1205-c566-list-stl-01-c-g-expected.txt M LayoutTests/css2.1/t1508-c527-font-03-b-expected.txt M LayoutTests/platform/glib/css1/basic/containment-expected.txt M LayoutTests/platform/glib/css1/basic/contextual_selectors-expected.txt M LayoutTests/platform/glib/css1/basic/grouping-expected.txt M LayoutTests/platform/glib/css1/basic/id_as_selector-expected.txt M LayoutTests/platform/glib/css1/basic/inheritance-expected.txt M LayoutTests/platform/glib/css1/box_properties/border-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_bottom_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_color-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_color_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_left_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_right_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_style-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_style_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_top_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_width-expected.txt M LayoutTests/platform/glib/css1/box_properties/border_width_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/clear-expected.txt M LayoutTests/platform/glib/css1/box_properties/clear_float-expected.txt M LayoutTests/platform/glib/css1/box_properties/float-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_elements_in_series-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_margin-expected.txt M LayoutTests/platform/glib/css1/box_properties/float_on_text_elements-expected.txt M LayoutTests/platform/glib/css1/box_properties/height-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/margin_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_bottom-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_bottom_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_left-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_left_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_right-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_right_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_top-expected.txt M LayoutTests/platform/glib/css1/box_properties/padding_top_inline-expected.txt M LayoutTests/platform/glib/css1/box_properties/width-expected.tx
[webkit-changes] [WebKit/WebKit] ba9233: [Skia] Purge caches on memory pressure
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba923386fa73c9fe13cab4d52a20e8f0d982935b https://github.com/WebKit/WebKit/commit/ba923386fa73c9fe13cab4d52a20e8f0d982935b Author: Pawel Lampe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/page/MemoryRelease.cpp A Source/WebCore/page/skia/MemoryReleaseSkia.cpp M Source/WebCore/platform/SourcesSkia.txt Log Message: --- [Skia] Purge caches on memory pressure https://bugs.webkit.org/show_bug.cgi?id=270634 Reviewed by Carlos Garcia Campos. * Source/WebCore/PlatformWPE.cmake: * Source/WebCore/page/MemoryRelease.cpp: * Source/WebCore/page/skia/MemoryReleaseSkia.cpp: Added. (WebCore::platformReleaseMemory): Canonical link: https://commits.webkit.org/275967@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fd23a6: [Skia] Handle image interpolation quality when fil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fd23a60530416cf834c6d5695914eca7839c9ac1 https://github.com/WebKit/WebKit/commit/fd23a60530416cf834c6d5695914eca7839c9ac1 Author: Pawel Lampe Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/Pattern.h M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/PatternSkia.cpp Log Message: --- [Skia] Handle image interpolation quality when filling with an image pattern https://bugs.webkit.org/show_bug.cgi?id=270685 Reviewed by Carlos Garcia Campos. This change takes image interpolation quality into account when using image pattern as CanvasRenderingContext2D.fillStyle or CanvasRenderingContext2D.strokeStyle. * Source/WebCore/platform/graphics/Pattern.h: * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::createFillPaint const): (WebCore::GraphicsContextSkia::createStrokePaint const): * Source/WebCore/platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::createPlatformPattern const): Canonical link: https://commits.webkit.org/275966@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbdb72: LayoutTests/http/wpt/webrtc/video-script-transform...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbdb72d59d20bd0cbc52b9e2bc409bf0b4e8d115 https://github.com/WebKit/WebKit/commit/cbdb72d59d20bd0cbc52b9e2bc409bf0b4e8d115 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/http/wpt/webrtc/video-script-transform-simulcast.html Log Message: --- LayoutTests/http/wpt/webrtc/video-script-transform-simulcast.html is flaky on arm64 bots rdar://124381982 https://bugs.webkit.org/show_bug.cgi?id=270785 Reviewed by Eric Carlson and Jean-Yves Avenard. * LayoutTests/http/wpt/webrtc/video-script-transform-simulcast.html: waitFor was not defined, let's implement it directly using setTimeout. Canonical link: https://commits.webkit.org/275965@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aee4e8: Update http/wpt/webrtc/video-script-transform.html...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aee4e88c815c823b7d149668b0ebbf2a0542fae2 https://github.com/WebKit/WebKit/commit/aee4e88c815c823b7d149668b0ebbf2a0542fae2 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- Update http/wpt/webrtc/video-script-transform.html, http/wpt/webrtc/video-script-transform-simulcast.html and imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html test expectations rdar://124384964 https://bugs.webkit.org/show_bug.cgi?id=270791 Unreviewed. http/wpt/webrtc/video-script-transform.html, http/wpt/webrtc/video-script-transform-simulcast.html and imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html are only failing on Monterey x86_64, updating test expectations accordingly. imported/w3c/web-platform-tests/webrtc/protocol/handover-datachannel.html is no longer flaky, removing test expectation. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/275964@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee8def: REGRESSION(271863@main): imported/w3c/web-platform...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee8def8950ffebd11530a1861c69048b1d593060 https://github.com/WebKit/WebKit/commit/ee8def8950ffebd11530a1861c69048b1d593060 Author: Youenn Fablet Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- REGRESSION(271863@main): imported/w3c/web-platform-tests/webrtc-extensions/RTCRtpSynchronizationSource-captureTimestamp.html is a flaky text failure rdar://119899602 https://bugs.webkit.org/show_bug.cgi?id=29 Unreviewed. Removing no longer flaky expectations. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275963@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ee397: Unreviewed, reverting 275944@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ee397c69b8869da40b9bb745af166896c39bd6f https://github.com/WebKit/WebKit/commit/6ee397c69b8869da40b9bb745af166896c39bd6f Author: Commit Queue Date: 2024-03-12 (Tue, 12 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Source/JavaScriptCore/bytecode/BytecodeList.rb M Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGClobberize.h M Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp M Source/JavaScriptCore/dfg/DFGDoesGC.cpp M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp M Source/JavaScriptCore/dfg/DFGNode.h M Source/JavaScriptCore/dfg/DFGNodeType.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/dfg/DFGOperations.h M Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp M Source/JavaScriptCore/dfg/DFGSafeToExecute.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp M Source/JavaScriptCore/ftl/FTLCapabilities.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/JIT.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp M Source/JavaScriptCore/runtime/CommonSlowPaths.h Log Message: --- Unreviewed, reverting 275944@main. https://bugs.webkit.org/show_bug.cgi?id=270838 8% JetStream2 regression Reverted changeset: "[JSC] Bracket compound assignment should resolve property key at most once" https://bugs.webkit.org/show_bug.cgi?id=270563 https://commits.webkit.org/275944@main Canonical link: https://commits.webkit.org/275962@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
