[webkit-changes] [WebKit/WebKit] 86ebc7: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86ebc770365f16e3fcc8e0d10206eabda37f2b7e https://github.com/WebKit/WebKit/commit/86ebc770365f16e3fcc8e0d10206eabda37f2b7e Author: Fujii Hironori Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/276334@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e80405: Create header file for AX interface declaration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e80405b7652c09a8e6adadf65c6eeca4a79f79a2 https://github.com/WebKit/WebKit/commit/e80405b7652c09a8e6adadf65c6eeca4a79f79a2 Author: Per Arne Vollan Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: A Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Create header file for AX interface declaration https://bugs.webkit.org/show_bug.cgi?id=271206 rdar://124950453 Reviewed by Sihui Liu and Chris Dumez. Guard against potential build issues, by moving interface declaration to a header file. * Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: Canonical link: https://commits.webkit.org/276333@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d98448: [WebGPU] MTLResource allocations should be attribu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9844889d42d79dc040865b5928b1da71fbdddf5 https://github.com/WebKit/WebKit/commit/d9844889d42d79dc040865b5928b1da71fbdddf5 Author: Mike Wyrzykowski Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCreateImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCreateImpl.h M Source/WebCore/platform/ProcessIdentity.h M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj M Source/WebGPU/WebGPU/Buffer.mm M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/Device.mm M Source/WebGPU/WebGPU/Instance.h M Source/WebGPU/WebGPU/Instance.mm A Source/WebGPU/WebGPU/MetalSPI.h M Source/WebGPU/WebGPU/PresentationContext.h M Source/WebGPU/WebGPU/PresentationContext.mm M Source/WebGPU/WebGPU/PresentationContextIOSurface.h M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm M Source/WebGPU/WebGPU/Queue.mm M Source/WebGPU/WebGPU/Texture.mm M Source/WebGPU/WebGPU/WebGPUExt.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm Log Message: --- [WebGPU] MTLResource allocations should be attributed to the respective web process https://bugs.webkit.org/show_bug.cgi?id=254219 Reviewed by Tadeu Zagallo and Myles C. Maxfield. Attribute memory used by IOSurfaces and MTLResource instances to the corresponding web process, so we do not exceed jetsam limits on iOS. Mostly this involves piping the web process ID which already is accessible via RemoteGPU down to WebGPU.framework and then calling the appropriate IOSurface and Metal SPIs. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUCreateImpl.cpp: (PAL::WebGPU::create): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUCreateImpl.h: * Source/WebGPU/WebGPU/Buffer.mm: (WebGPU::Device::safeCreateBuffer const): * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/Device.mm: (WebGPU::setOwnerWithIdentity): (WebGPU::Device::setOwnerWithIdentity const): (WebGPU::Device::newBufferWithBytes const): (WebGPU::Device::newTextureWithDescriptor const): * Source/WebGPU/WebGPU/Instance.h: * Source/WebGPU/WebGPU/Instance.mm: (WebGPU::Instance::create): (WebGPU::Instance::Instance): (WebGPU::m_webProcessID): (WebGPU::Instance::createSurface): (WebGPU::Instance::webProcessID const): * Source/WebGPU/WebGPU/PresentationContext.h: * Source/WebGPU/WebGPU/PresentationContext.mm: (WebGPU::PresentationContext::create): * Source/WebGPU/WebGPU/PresentationContextIOSurface.h: * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::create): (WebGPU::PresentationContextIOSurface::PresentationContextIOSurface): (WebGPU::PresentationContextIOSurface::renderBuffersWereRecreated): (WebGPU::PresentationContextIOSurface::configure): * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeBuffer): (WebGPU::Queue::writeTexture): * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Device::createTexture): * Source/WebGPU/WebGPU/WebGPUExt.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::webProcessID): (WebKit::RemoteGPU::workQueueInitialize): * Source/WebGPU/WebGPU/MetalSPI.h: Add SPI header. Canonical link: https://commits.webkit.org/276332@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48a7d5: Add Tanmoy Panigrahi as a contributor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48a7d5d9c1cbad06030708a4afbee8b56d842be4 https://github.com/WebKit/WebKit/commit/48a7d5d9c1cbad06030708a4afbee8b56d842be4 Author: Tanmoy Panigrahi Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add Tanmoy Panigrahi as a contributor https://bugs.webkit.org/show_bug.cgi?id=271204 rdar://124978532 Reviewed by Aditya Keerthi. I opened my first PR to WebKit today, and hope to contribute more in the future. Adding myself as a contributor will also help prevent benign errors/making it smoother to contribute. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276331@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e89c8: Unreviewed, build fix after 271819@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e89c8df137e7af2bf2e6054285d8e14e82b https://github.com/WebKit/WebKit/commit/5e89c8df137e7af2bf2e6054285d8e14e82b Author: Yusuke Suzuki Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/JavaScriptCore/jit/JITCode.h Log Message: --- Unreviewed, build fix after 271819@main https://bugs.webkit.org/show_bug.cgi?id=271211 rdar://124987262 * Source/JavaScriptCore/jit/JITCode.h: Canonical link: https://commits.webkit.org/276330@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 94e2e0: [UnifiedPDF] Only update platform highlight data f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 94e2e0c433d20ef173dd08f404c1d3603b29c0db https://github.com/WebKit/WebKit/commit/94e2e0c433d20ef173dd08f404c1d3603b29c0db Author: Abrar Rahman Protyasha Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Only update platform highlight data for page(s) of interest https://bugs.webkit.org/show_bug.cgi?id=271203 rdar://124976470 Reviewed by Simon Fraser. DDHighlightData is required for hit testing and to reflect zooming or scrolling. As such, we only care about updating platform highlight data on the page where we need to handle a mouse event, or on the page where a zoom or scroll operation occurred. This patch updates didInvalidateHighlightOverlayRects to accept an optional page index to limit which page's platform highlight data requires updating. If the caller fails to provide an index, or if that index does not already exist in our highlight map, we fallback to the existing behavior of updating the highlight data on all pages. This is a performance optimization for large PDF files since we avoid unnecessarily iterating through all pages containing data detector results. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm: (WebKit::PDFDataDetectorOverlayController::handleMouseEvent): (WebKit::PDFDataDetectorOverlayController::updatePlatformHighlightData): (WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::didChangeScrollOffset): Canonical link: https://commits.webkit.org/276329@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5383d2: test262-runner must only load async harness for as...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5383d29dcaad9a0143ba6eb69cd569a8a0e2ccec https://github.com/WebKit/WebKit/commit/5383d29dcaad9a0143ba6eb69cd569a8a0e2ccec Author: Ross Kirsling Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M JSTests/test262/expectations.yaml M Tools/Scripts/test262/Runner.pm Log Message: --- test262-runner must only load async harness for async-flagged tests https://bugs.webkit.org/show_bug.cgi?id=271140 Reviewed by Darin Adler. According to test262's documentation (https://github.com/tc39/test262/blob/main/INTERPRETING.md?plain=1#L343), we should not be loading `harness/doneprintHandle.js` for tests without `flags: [async]`. We currently load it for all tests, which results in a harness test failure. * JSTests/test262/expectations.yaml: * Tools/Scripts/test262/Runner.pm: Canonical link: https://commits.webkit.org/276328@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a37af: [Gardening]: REGRESSION (275711@main): 5 http/wpt/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a37af3a18debecc5b7154280dbe0e75a93bd310 https://github.com/WebKit/WebKit/commit/3a37af3a18debecc5b7154280dbe0e75a93bd310 Author: Ben Schwartz Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening]: REGRESSION (275711@main): 5 http/wpt/webauthn/public-key-credential* layout tests are constantly crashing/failing. https://bugs.webkit.org/show_bug.cgi?id=271207 rdar://124982361 Unreviewed test gardening. Revised existing test expectations to reflect current state of test results and to link back to this bug. Removed redundant expectations. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276327@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1f76c8: [WebDriver] Update imported WPT WebDriver tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f76c86e781a3ceff89d5bcb081e2a148e53ef1e https://github.com/WebKit/WebKit/commit/1f76c86e781a3ceff89d5bcb081e2a148e53ef1e Author: Lauro Moura Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py M Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py M WebDriverTests/TestExpectations.json M WebDriverTests/imported/w3c/config.json M WebDriverTests/imported/w3c/importer.json M WebDriverTests/imported/w3c/tools/webdriver/webdriver/__init__.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/client.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/error.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/__init__.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/_module.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/browser.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/browsing_context.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/input.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/network.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/permissions.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/script.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/session.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/modules/storage.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/transport.py A WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/undefined.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/client.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/error.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/protocol.py M WebDriverTests/imported/w3c/tools/webdriver/webdriver/transport.py M WebDriverTests/imported/w3c/tools/wptrunner/requirements.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_chromium.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_edge.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_firefox.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_ie.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_opera.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_safari.txt M WebDriverTests/imported/w3c/tools/wptrunner/requirements_sauce.txt M WebDriverTests/imported/w3c/tools/wptrunner/tox.ini M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/__init__.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/base.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/chrome.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/chrome_spki_certs.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/content_shell.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/edge.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/edgechromium.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/epiphany.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/firefox_android.py A WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/ladybird.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/safari.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/webkit.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/webkitgtk_minibrowser.py A WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/browsers/wktr.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/config.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/environment.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/actions.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/base.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executorchrome.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executorcontentshell.py A WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executoredge.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executorselenium.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py M WebDriverTests/imported/w3c/tools/wptrunner/wptrunner/executors/executorwebdriver.py A WebDri
[webkit-changes] [WebKit/WebKit] e37f46: model tag should inherit background color CSS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e37f4682210fbdca364bf9374911860e9a90b63a https://github.com/WebKit/WebKit/commit/e37f4682210fbdca364bf9374911860e9a90b63a Author: Eddy Wong Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/Modules/model-element/HTMLModelElement.cpp M Source/WebCore/Modules/model-element/HTMLModelElement.h M Source/WebCore/Modules/model-element/ModelPlayer.cpp M Source/WebCore/Modules/model-element/ModelPlayer.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h Log Message: --- model tag should inherit background color CSS rdar://120927982 https://bugs.webkit.org/show_bug.cgi?id=270828 Reviewed by Tim Horton. Propagate the resolved renderer background color for the model tag into ModelProcessModelPlayerProxy for setting into the portal layer. Background color will always be converted to opaque before being applied to the portal layer. This is to prevent showing passthrough through the page. Invalid color will result in resetting the background color to white. * Source/WebCore/Modules/model-element/HTMLModelElement.cpp: (WebCore::HTMLModelElement::applyBackgroundColor): * Source/WebCore/Modules/model-element/HTMLModelElement.h: * Source/WebCore/Modules/model-element/ModelPlayer.cpp: (WebCore::ModelPlayer::setBackgroundColor): * Source/WebCore/Modules/model-element/ModelPlayer.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm: (WebKit::ModelProcessModelPlayerProxy::createLayer): (WebKit::ModelProcessModelPlayerProxy::didFinishLoading): (WebKit::ModelProcessModelPlayerProxy::setBackgroundColor): * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp: (WebKit::ModelProcessModelPlayer::setBackgroundColor): * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h: Canonical link: https://commits.webkit.org/276325@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce6a01: Unreviewed Windows build fix after 276319@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce6a01e04a982a97d41767658d9014c54618d022 https://github.com/WebKit/WebKit/commit/ce6a01e04a982a97d41767658d9014c54618d022 Author: Chris Dumez Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp Log Message: --- Unreviewed Windows build fix after 276319@main. * Source/WebCore/platform/network/playstation/CurlSSLHandlePlayStation.cpp: (WebCore::CurlSSLHandle::platformInitialize): Canonical link: https://commits.webkit.org/276324@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 652ad7: AX: The accname for summary elements should use on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 652ad7d7e57a6537462ca14b93eab37db5eab819 https://github.com/WebKit/WebKit/commit/652ad7d7e57a6537462ca14b93eab37db5eab819 Author: Tyler Wilcock Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: --- AX: The accname for summary elements should use on subtree text over the title attribute https://bugs.webkit.org/show_bug.cgi?id=271168 rdar://problem/124958776 Reviewed by Chris Fleizach. This is defined in the spec: https://w3c.github.io/html-aam/#summary-element-accessible-name-computation * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::dependsOnTextUnderElement const): Canonical link: https://commits.webkit.org/276323@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 09180a: [UnifiedPDF] Data detector page overlay installati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09180a88fbc5d0a6862eef0b13382eff0d3fa32c https://github.com/WebKit/WebKit/commit/09180a88fbc5d0a6862eef0b13382eff0d3fa32c Author: Abrar Rahman Protyasha Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm Log Message: --- [UnifiedPDF] Data detector page overlay installation should be deferred till an active highlight needs to be painted https://bugs.webkit.org/show_bug.cgi?id=271202 rdar://124976143 Reviewed by Simon Fraser. This patch makes use of the installIfNeeded idiom to defer creation/installation of a PageOverlay instance until one is needed to parent an active highlight or to repaint it. It is a memory optimization in case the PDF in question has no data detector results. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm: (WebKit::PDFDataDetectorOverlayController::handleMouseEvent): (WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects): Canonical link: https://commits.webkit.org/276322@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 241cc4: [UnifiedPDF] Refactor selectionBoundsAcrossDocumen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 241cc4bba9ccc2218fc30b9ee65a24dd7636daef https://github.com/WebKit/WebKit/commit/241cc4bba9ccc2218fc30b9ee65a24dd7636daef Author: Abrar Rahman Protyasha Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Refactor selectionBoundsAcrossDocument() to accept a target coordinate space https://bugs.webkit.org/show_bug.cgi?id=271181 rdar://124969883 Reviewed by Sammy Gill. This patch is a small refactor of the selectionBoundsAcrossDocument() family of methods to some review feedback from 276239@main. This method now accepts a target coordinate space to represent its results in. I've also taken the liberty to rename it to `boundsForSelection`, since the target coordinate space needn't be implicit in the name anymore. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm: (WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::boundsForSelection const): (WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded): (WebKit::UnifiedPDFPlugin::setCurrentSelection): (WebKit::UnifiedPDFPlugin::selectionBoundsAcrossDocument const): Deleted. (WebKit::UnifiedPDFPlugin::selectionBoundsAcrossDocumentInContentSpace const): Deleted. Canonical link: https://commits.webkit.org/276321@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 292ff7: Crash under AccessibilityObject::accessibilitySecu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 292ff7293a5c8f04400a7a37665a8ad1a02e9b5d https://github.com/WebKit/WebKit/commit/292ff7293a5c8f04400a7a37665a8ad1a02e9b5d Author: Tyler Wilcock Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm Log Message: --- Crash under AccessibilityObject::accessibilitySecureFieldLength() https://bugs.webkit.org/show_bug.cgi?id=271158 rdar://122375537 Reviewed by Chris Dumez. This patch removes this unchecked downcast and generally simplifies the function. It has also been changed to return an unsigned, as it cannot possibly return a negative value, and furthermore, HTMLInput::value() returns a String, and the length() of Strings is unsigned. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm: (WebCore::AccessibilityObject::accessibilitySecureFieldLength): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityValue]): Canonical link: https://commits.webkit.org/276320@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c90475: Drop Vector::append(T*, size_t) and use Vector::ap...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c904754b70e17186e32cafafc5d82dd7bb925741 https://github.com/WebKit/WebKit/commit/c904754b70e17186e32cafafc5d82dd7bb925741 Author: Chris Dumez Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/JavaScriptCore/API/ObjcRuntimeExtras.h M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h M Source/JavaScriptCore/bytecode/ObjectPropertyConditionSet.cpp M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorMessageParser.cpp M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorMessageParser.h M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/parser/Lexer.cpp M Source/JavaScriptCore/parser/Lexer.h M Source/JavaScriptCore/runtime/IntlLocale.cpp M Source/JavaScriptCore/runtime/IntlObject.cpp M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/WasmBBQPlan.h M Source/JavaScriptCore/wasm/WasmEntryPlan.cpp M Source/JavaScriptCore/wasm/WasmEntryPlan.h M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmStreamingCompiler.h M Source/JavaScriptCore/wasm/WasmStreamingParser.cpp M Source/JavaScriptCore/wasm/WasmStreamingParser.h M Source/WTF/wtf/StdLibExtras.h M Source/WTF/wtf/StreamBuffer.h M Source/WTF/wtf/TrailingArray.h M Source/WTF/wtf/URL.cpp M Source/WTF/wtf/URLParser.cpp M Source/WTF/wtf/URLParser.h M Source/WTF/wtf/Vector.h M Source/WTF/wtf/cf/VectorCF.h M Source/WTF/wtf/cocoa/FileSystemCocoa.mm M Source/WTF/wtf/text/ASCIILiteral.h M Source/WTF/wtf/text/AtomString.h M Source/WTF/wtf/text/SuperFastHash.h M Source/WTF/wtf/text/WTFString.cpp M Source/WTF/wtf/text/win/StringWin.cpp M Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp M Source/WebCore/Modules/mediastream/SFrameUtils.cpp M Source/WebCore/Modules/mediastream/STUNMessageParsing.cpp M Source/WebCore/Modules/mediastream/STUNMessageParsing.h M Source/WebCore/Modules/webauthn/cbor/CBORReader.cpp M Source/WebCore/Modules/webauthn/cbor/CBORWriter.cpp M Source/WebCore/Modules/webauthn/fido/FidoHidPacket.cpp M Source/WebCore/Modules/webauthn/fido/FidoParsingUtils.cpp M Source/WebCore/Modules/webauthn/fido/U2fCommandConstructor.cpp M Source/WebCore/Modules/websockets/WebSocketFrame.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp M Source/WebCore/PAL/pal/text/TextCodecICU.cpp M Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp M Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/SerializedScriptValue.cpp M Source/WebCore/crypto/SubtleCrypto.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp M Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp M Source/WebCore/crypto/cocoa/CryptoKeyRSAMac.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmEd25519GCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp M Source/WebCore/crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h M Source/WebCore/crypto/parameters/CryptoAlgorithmAesCtrParams.h M Source/WebCore/crypto/parameters/CryptoAlgorithmAesGcmParams.h M Source/WebCore/crypto/parameters/CryptoAlgorithmHkdfParams.h M Source/WebCore/crypto/parameters/CryptoAlgorithmPbkdf2Params.h M Source/WebCore/crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h M Source/WebCore/crypto/parameters/CryptoAlgorithmRsaOaepParams.h M Source/WebCore/dom/DatasetDOMStringMap.cpp M Source/WebCore/fileapi/BlobBuilder.cpp M Source/WebCore/history/HistoryItem.cpp M Source/WebCore/html/parser/HTMLToken.h M Source/WebCore/loader/TextResourceDecoder.cpp M Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp M Source/WebCore/page/EventSource.cpp M Source/WebCore/page/PageConsoleClient.cpp M Source/WebCore/platform/SharedBuffer.cpp M Source/WebCore/platform/SharedBufferChunkReader.cpp M Source/WebCore/platform/SharedStringHash.cpp M Source/WebCore/platform/SharedStringHash.h M Source/WebCore/platform/audio/MultiChannelResampler.cpp M Source/WebCore/platform/audio/SincResampler.cpp M Source/WebCore/platform/graphics/WOFFFileFormat.cpp M Source/WebCore/platform/graphics/cairo/ImageBufferUtilitiesCairo.cpp M Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cp
[webkit-changes] [WebKit/WebKit] 2aaac5: Add page null check under [WKWebProcessPlugInFrame...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2aaac5377578daa8896c449b1cea387cf750e1a5 https://github.com/WebKit/WebKit/commit/2aaac5377578daa8896c449b1cea387cf750e1a5 Author: Chris Dumez Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm Log Message: --- Add page null check under [WKWebProcessPlugInFrame _browserContextController] https://bugs.webkit.org/show_bug.cgi?id=271174 rdar://122276358 Reviewed by Sihui Liu. Add page null check under [WKWebProcessPlugInFrame _browserContextController] to address some crashes in the wild. * Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: (-[WKWebProcessPlugInFrame _browserContextController]): Canonical link: https://commits.webkit.org/276318@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 215a08: Keyboard incorrectly duplicates certain text corre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 215a08dbf9d45f1a56cc1302a77ee80811a3c724 https://github.com/WebKit/WebKit/commit/215a08dbf9d45f1a56cc1302a77ee80811a3c724 Author: Richard Robinson Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Keyboard incorrectly duplicates certain text corrections/fill https://bugs.webkit.org/show_bug.cgi?id=271076 rdar://123642870 Reviewed by Abrar Rahman Protyasha. Add a quirk to disable the `writingsuggestions` web API for the affected sites. * Source/WebCore/dom/Element.cpp: (WebCore::Element::isWritingSuggestionsEnabled const): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableWritingSuggestionsQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/276317@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c52386: UnifiedPDF: Find-in-page highlights very unstable ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c52386bd6732a1e7c438508a47a44b639e919e3c https://github.com/WebKit/WebKit/commit/c52386bd6732a1e7c438508a47a44b639e919e3c Author: Tim Horton Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/WebPage/FindController.cpp Log Message: --- UnifiedPDF: Find-in-page highlights very unstable during zoom https://bugs.webkit.org/show_bug.cgi?id=271177 Reviewed by Simon Fraser. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::setScaleFactor): Adopt our `scrollToPoint` helper, which also makes this a programmatic scroll, which is important to make its application synchronous in the Web Content process, so that we can correctly repaint the overlay synchronously. * Source/WebKit/WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindUIAfterPageScroll): Disable async scrolling for UnifiedPDFPlugin while the find overlay is installed. Canonical link: https://commits.webkit.org/276316@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27daa9: Unreviewed, reverting 276290@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27daa90c6ffa89d11aac4bc668d25868b8266f10 https://github.com/WebKit/WebKit/commit/27daa90c6ffa89d11aac4bc668d25868b8266f10 Author: Commit Queue Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: R Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Unreviewed, reverting 276290@main. https://bugs.webkit.org/show_bug.cgi?id=271192 Introduced build issue Reverted changeset: "Create header file for interface declaration" https://bugs.webkit.org/show_bug.cgi?id=271160 https://commits.webkit.org/276290@main Canonical link: https://commits.webkit.org/276315@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4bddd: [ Ventura WK1 ] 2x imported/w3c/web-platform-tests...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4bddd14467ff8e5f1537083fc5f58014c87ee95 https://github.com/WebKit/WebKit/commit/e4bddd14467ff8e5f1537083fc5f58014c87ee95 Author: Eric Carlson Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm Log Message: --- [ Ventura WK1 ] 2x imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode are constant crashes https://bugs.webkit.org/show_bug.cgi?id=270915 rdar://124540415 Reviewed by Jer Noble. WebKit crashes because an internal method called by `-[AVPlayerItem selectMediaOption:inMediaSelectionGroup:]` messages a nil NSArray and an ObjC exception is thrown. Prevent the crash by putting all calls to `-[AVPlayerItem selectMediaOption:inMediaSelectionGroup:]` in try/catch blocks. * Source/WebCore/platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm: (WebCore::MediaSelectionGroupAVFObjC::selectionTimerFired): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): (WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTextTrack): Canonical link: https://commits.webkit.org/276314@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2fd8f8: [Unified Text Replacement] Replacing text with non...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2fd8f81aac4e867ffe107c0e1b3e34b1628c0953 https://github.com/WebKit/WebKit/commit/2fd8f81aac4e867ffe107c0e1b3e34b1628c0953 Author: Richard Robinson Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/editing/cocoa/HTMLConverter.h M Source/WebCore/editing/cocoa/HTMLConverter.mm M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm Log Message: --- [Unified Text Replacement] Replacing text with non-trivial attributed string attributes can sometimes cause a crash https://bugs.webkit.org/show_bug.cgi?id=271105 rdar://123712304 Reviewed by Aditya Keerthi. Currently, the original selected range isn't guaranteed to fit within the context attributed string, due to the slight differences between HTMLConverter and TextIterator. To fix, `editingAttributedString` will now be used, which uses TextIterator itself. Also add an assertion to ensure this postcondition is true. The replaced, expanded selection range was also being formed incorrectly, impacting subsequent calls of the function. A partial fix is done by using the context string instead of the replaced string, since the range is relative to the former. Additionally, the `extendedBoundaryPoint` method is altered to use a slightly different mechanism of expanding based on the number of characters, to completely fix this issue. Also add a precondition check to ensure the range passed in as the parameter is a valid range within the context range. * Source/WebCore/editing/cocoa/HTMLConverter.h: * Source/WebCore/editing/cocoa/HTMLConverter.mm: (WebCore::editingAttributedString): * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::extendedBoundaryPoint): (WebKit::UnifiedTextReplacementController::willBeginTextReplacementSession): (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): Canonical link: https://commits.webkit.org/276313@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c242e: Have WheelEventTestMonitor use ScrollableAreaIds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c242ed078742ebb14b48bd6c3e6dcef466d7d3e https://github.com/WebKit/WebKit/commit/4c242ed078742ebb14b48bd6c3e6dcef466d7d3e Author: Nikolaos Mouchtaris Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/WheelEventTestMonitor.cpp M Source/WebCore/page/WheelEventTestMonitor.h M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp M Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp M Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp M Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h M Source/WebCore/platform/ScrollAnimator.cpp M Source/WebCore/platform/ScrollAnimator.h M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/platform/ScrollingEffectsController.cpp M Source/WebCore/platform/ScrollingEffectsController.h M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm M Source/WebCore/platform/mac/ScrollingEffectsController.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm Log Message: --- Have WheelEventTestMonitor use ScrollableAreaIds https://bugs.webkit.org/show_bug.cgi?id=269242 rdar://122833730 Reviewed by Simon Fraser. Have WheelEventTestMonitor hold a scrolling node id rather than a void pointer. * Source/WebCore/page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEventInternal): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollOffsetChangedViaPlatformWidgetImpl): * Source/WebCore/page/WheelEventTestMonitor.cpp: (WebCore::WheelEventTestMonitor::deferForReason): (WebCore::WheelEventTestMonitor::removeDeferralForReason): * Source/WebCore/page/WheelEventTestMonitor.h: (WebCore::WheelEventTestMonitorCompletionDeferrer::WheelEventTestMonitorCompletionDeferrer): * Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: (WebCore::ScrollingCoordinator::deferWheelEventTestCompletionForReason): (WebCore::ScrollingCoordinator::removeWheelEventTestCompletionDeferralForReason): * Source/WebCore/page/scrolling/ThreadedScrollingCoordinator.cpp: (WebCore::ThreadedScrollingCoordinator::handleWheelEventForScrolling): * Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp: (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::deferWheelEventTestCompletionForReason const): (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::removeWheelEventTestCompletionDeferralForReason const): (WebCore::ThreadedScrollingTreeScrollingNodeDelegate::scrollingNodeID const): * Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.h: * Source/WebCore/platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::deferWheelEventTestCompletionForReason const): (WebCore::ScrollAnimator::removeWheelEventTestCompletionDeferralForReason const): (WebCore::ScrollAnimator::scrollingNodeID const): * Source/WebCore/platform/ScrollAnimator.h: * Source/WebCore/platform/ScrollingEffectsController.cpp: (WebCore::ScrollingEffectsController::startDeferringWheelEventTestCompletion): (WebCore::ScrollingEffectsController::stopDeferringWheelEventTestCompletion): * Source/WebCore/platform/ScrollingEffectsController.h: (WebCore::ScrollingEffectsControllerClient::deferWheelEventTestCompletionForReason const): (WebCore::ScrollingEffectsControllerClient::removeWheelEventTestCompletionDeferralForReason const): * Source/WebCore/platform/mac/ScrollbarsControllerMac.mm: (WebCore::ScrollbarsControllerMac::didBeginScrollGesture): (WebCore::ScrollbarsControllerMac::didEndScrollGesture): (WebCore::ScrollbarsControllerMac::sendContentAreaScrolledTimerFired): (WebCore::ScrollbarsControllerMac::sendContentAreaScrolledSoon): * Source/WebCore/platform/mac/ScrollingEffectsController.mm: (WebCore::ScrollingEffectsController::willStartRubberBandAnimation): (WebCore::ScrollingEffectsController::didStopRubberBandAnimation): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::startDeferringScrollingTestCompletionForNode): (WebKit::RemoteScrollingCoordinator::stopDeferringScrollingTestCompletionForNode): Canonical link: https://commits.webkit.org/276312@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 47ad10: [Gardening]: NEW TEST(275998@main): [ MacOS ] acce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 47ad108b33102a5d8b0283a0ec17b3c1fb0a33de https://github.com/WebKit/WebKit/commit/47ad108b33102a5d8b0283a0ec17b3c1fb0a33de Author: Jay Stfleur Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: NEW TEST(275998@main): [ MacOS ] accessibility/mac/custom-text-editor.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=124974415 rdar://124974415 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276311@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b7973: Implement getAttributeType and getPropertyType fun...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b79732d9cb95141673959f934689029a8cf6801 https://github.com/WebKit/WebKit/commit/6b79732d9cb95141673959f934689029a8cf6801 Author: Luke Warlow Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-namespace-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M Source/WebCore/dom/TrustedTypePolicyFactory.cpp M Source/WebCore/dom/TrustedTypePolicyFactory.h M Source/WebCore/dom/TrustedTypePolicyFactory.idl Log Message: --- Implement getAttributeType and getPropertyType functions on TrustedTypePolicyFactory https://bugs.webkit.org/show_bug.cgi?id=270080 Reviewed by Ryosuke Niwa and Darin Adler. Implements getAttributeType and getPropertyType metadata functions. Also adds missing test coverage for SVGScript href attribute handling. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-namespace-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: (WebCore::TrustedTypePolicyFactory::getAttributeType const): (WebCore::TrustedTypePolicyFactory::getPropertyType const): * Source/WebCore/dom/TrustedTypePolicyFactory.idl: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. Canonical link: https://commits.webkit.org/276310@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7b53c: [UnifiedPDF] Pinch and keyboard zooming do not dis...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7b53c30f92b3c9864be53a3c9383b066a7620d4 https://github.com/WebKit/WebKit/commit/a7b53c30f92b3c9864be53a3c9383b066a7620d4 Author: Sammy Gill Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Pinch and keyboard zooming do not disable automatically resize option. https://bugs.webkit.org/show_bug.cgi?id=271088 rdar://problem/124717930 Reviewed by Tim Horton. When pinch zooming is performed we should stop updating the document fitting scale. Zooming via keyboard shortcuts should also have the same beheavior. Let's do this when the page's scale factor has changed so that it catches both cases. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::didBeginMagnificationGesture): Canonical link: https://commits.webkit.org/276309@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 803074: Remove managed configuration setting to enable leg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 803074e08cd722c86aa733598862df6250c1b826 https://github.com/WebKit/WebKit/commit/803074e08cd722c86aa733598862df6250c1b826 Author: Alex Christensen Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm Log Message: --- Remove managed configuration setting to enable legacy TLS without warning in Safari https://bugs.webkit.org/show_bug.cgi?id=271162 rdar://124635456 Reviewed by Chris Dumez. It was added several years ago to allow transition to a Safari that warns when you are using TLS 1.0 or 1.1. That several year long transition no longer needs a managed configuration setting to allow legacy TLS in Safari without a warning. Safari uses _WKWebsiteDataStoreConfiguration.legacyTLSEnabled to disable it. Users also have the ability to click through a warning to access pages with legacy TLS. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::systemAllowsLegacyTLSFor): Canonical link: https://commits.webkit.org/276308@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36a9e5: UnifiedPDF: Clicks on the HUD buttons can pass thr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36a9e5373c6fb72786a7aa1f43f3a379063d4530 https://github.com/WebKit/WebKit/commit/36a9e5373c6fb72786a7aa1f43f3a379063d4530 Author: Tim Horton Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/UIProcess/PDF/WKPDFHUDView.h M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm M Source/WebKit/UIProcess/mac/WebViewImpl.mm Log Message: --- UnifiedPDF: Clicks on the HUD buttons can pass through to the PDF and trigger form focus https://bugs.webkit.org/show_bug.cgi?id=271171 Reviewed by Abrar Rahman Protyasha. Don't send mouse up/down events to the page if the PDF HUD handled them. * Source/WebKit/UIProcess/PDF/WKPDFHUDView.h: * Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm: (-[WKPDFHUDView handleMouseDown:]): (-[WKPDFHUDView handleMouseUp:]): (-[WKPDFHUDView mouseDown:]): Deleted. (-[WKPDFHUDView mouseUp:]): Deleted. * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::mouseUp): Canonical link: https://commits.webkit.org/276307@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 399ae1: [run-webkit-tests] Ignore glob results which match...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 399ae11e2665a28984066ee47fb8563d3eccef59 https://github.com/WebKit/WebKit/commit/399ae11e2665a28984066ee47fb8563d3eccef59 Author: Sam Sneddon Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py Log Message: --- [run-webkit-tests] Ignore glob results which match files when looking for directories https://bugs.webkit.org/show_bug.cgi?id=271186 Reviewed by Jonathan Bedard. * Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: (LayoutTestFinder.get_tests): * Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy_unittest.py: Canonical link: https://commits.webkit.org/276306@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a6c7d: Remove ENABLE_PUBLIC_SUFFIX_LIST directive
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a6c7d3f4e3c172f292beee56b2d0ed4f7daa82f https://github.com/WebKit/WebKit/commit/2a6c7d3f4e3c172f292beee56b2d0ed4f7daa82f Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/dom/Document.cpp M Source/WebCore/loader/CrossOriginAccessControl.cpp M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/page/PerformanceMonitor.cpp M Source/WebCore/page/SecurityOrigin.cpp M Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp M Source/WebCore/platform/PublicSuffix.h M Source/WebCore/platform/RegistrableDomain.h M Source/WebCore/platform/cocoa/PublicSuffixCocoa.mm M Source/WebCore/platform/glib/UserAgentQuirks.cpp M Source/WebCore/platform/network/NetworkStorageSession.cpp M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp M Source/WebCore/platform/network/curl/CookieJarDB.cpp M Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp M Source/WebCore/platform/soup/PublicSuffixSoup.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp M Source/WebKit/Shared/LoadParameters.h M Source/WebKit/Shared/LoadParameters.serialization.in M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/cmake/OptionsWin.cmake M Source/cmake/WebKitFeatures.cmake M Tools/Scripts/webkitperl/FeatureList.pm M Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp M Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp Log Message: --- Remove ENABLE_PUBLIC_SUFFIX_LIST directive https://bugs.webkit.org/show_bug.cgi?id=271157 Reviewed by Sihui Liu. It's enabled on all ports. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::urlForBindings const): * Source/WebCore/loader/CrossOriginAccessControl.cpp: (WebCore::shouldCrossOriginResourcePolicyCancelLoad): * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::updateRequestFetchMetadataHeaders): (WebCore::CachedResourceLoader::updateRequestAfterRedirection): (WebCore::CachedResourceLoader::updateHTTPRequestHeaders): * Source/WebCore/page/PerformanceMonitor.cpp: (WebCore::reportPageOverPostLoadResourceThreshold): * Source/WebCore/page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isSameSiteAs const): (WebCore::SecurityOrigin::isMatchingRegistrableDomainSuffix const): * Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp: (WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode): * Source/WebCore/platform/PublicSuffix.h: * Source/WebCore/platform/RegistrableDomain.h: (WebCore::RegistrableDomain::uncheckedCreateFromHost): (WebCore::RegistrableDomain::registrableDomainFromHost): * Source/WebCore/platform/cocoa/PublicSuffixCocoa.mm: * Source/WebCore/platform/glib/UserAgentQuirks.cpp: (WebCore::urlRequiresChromeBrowser): (WebCore::urlRequiresMacintoshPlatform): (WebCore::UserAgentQuirks::quirksForURL): * Source/WebCore/platform/network/NetworkStorageSession.cpp: * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::partitionName): * Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp: * Source/WebCore/platform/network/curl/CookieJarDB.cpp: (WebCore::CookieJarDB::hasCookies): (WebCore::CookieJarDB::canAcceptCookie): * Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp: * Source/WebCore/platform/soup/PublicSuffixSoup.cpp: * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::shouldAllowHSTSPolicySetting const): * Source/WebKit/Shared/LoadParameters.h: * Source/WebKit/Shared/LoadParameters.serialization.in: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::goToBackForwardItem): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::launchProcessForReload): (WebKit::WebPageProxy::loadRequestWithNavigationShared): (WebKit::WebPageProxy::loadFile): (WebKit::WebPageProxy::goToBackForwardItem): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch): (WebKit::WebProcessProxy::didExceedMemoryFootprintThreshold): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp: (WebKit::WebsiteDataRecord::displayNameForHostName): (WebKit::WebsiteDataRecord::displayNameForOrigin): (WebKit::WebsiteDataRecord::topPrivatelyControlledDomain): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::goToBackForwardItem): * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Tools/Scripts/webkitperl/FeatureList.pm: * Tools/TestWebKit
[webkit-changes] [WebKit/WebKit] f342b3: [run-webkit-tests] Manager shouldn't treat all IOE...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f342b3fa9121a066f4662153f043e664e02408c9 https://github.com/WebKit/WebKit/commit/f342b3fa9121a066f4662153f043e664e02408c9 Author: Sam Sneddon Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py Log Message: --- [run-webkit-tests] Manager shouldn't treat all IOErrors invalid --test-list paths https://bugs.webkit.org/show_bug.cgi?id=271180 Reviewed by Jonathan Bedard and Darin Adler. Currently this means all IOErrors are swallowed by Manager, which is awkward when we have an actual bug (rdar://124918090) here, which should show up as an uncaught exception rather than silently failing. * Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py: (LayoutTestFinder._read_test_names_from_file): * Tools/Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): (Manager.print_expectations): (Manager.print_summary): Canonical link: https://commits.webkit.org/276304@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc8767: http/tests/site-isolation/draw-after-navigation.ht...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc87670c0188aa017261a6a653a1d99472f0805f https://github.com/WebKit/WebKit/commit/dc87670c0188aa017261a6a653a1d99472f0805f Author: Charlie Wolfe Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- http/tests/site-isolation/draw-after-navigation.html is flaky https://bugs.webkit.org/show_bug.cgi?id=271163 rdar://124956252 Reviewed by Alex Christensen. 275592@main accidentally made the ForceRepaint message only sent to the main frame process. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::forceRepaint): Canonical link: https://commits.webkit.org/276303@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c9fb3: Unreviewed, reverting 276198@main and 276218@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c9fb3193d9dbf320747d07b485d275b4adf8f2d https://github.com/WebKit/WebKit/commit/6c9fb3193d9dbf320747d07b485d275b4adf8f2d Author: Commit Queue Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/InitializeThreading.cpp M Source/JavaScriptCore/runtime/MachineContext.h M Source/JavaScriptCore/runtime/VMTraps.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.cpp M Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/PlatformJSCOnly.cmake M Source/WTF/wtf/PlatformMac.cmake M Source/WTF/wtf/PlatformRegisters.cpp M Source/WTF/wtf/PlatformRegisters.h M Source/WTF/wtf/threads/Signals.cpp M Source/WTF/wtf/threads/Signals.h M Source/WTF/wtf/win/SignalsWin.cpp M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Tools/TestWebKitAPI/Tests/WTF/Signals.cpp Log Message: --- Unreviewed, reverting 276198@main and 276218@main. https://bugs.webkit.org/show_bug.cgi?id=271182 Broke internal Safari Reverted changesets: "new exception handler adoption" https://bugs.webkit.org/show_bug.cgi?id=269728 https://commits.webkit.org/276198@main "fix darwin_arm_thread_state64 macro usage build issue" https://bugs.webkit.org/show_bug.cgi?id=271097 https://commits.webkit.org/276218@main Canonical link: https://commits.webkit.org/276302@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bf10e0: Remove UnprefixedFullscreenAPIEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bf10e09dc8be4f7392f1c752f5a110196884c165 https://github.com/WebKit/WebKit/commit/bf10e09dc8be4f7392f1c752f5a110196884c165 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/dom/Document+Fullscreen.idl M Source/WebCore/dom/DocumentOrShadowRoot+Fullscreen.idl M Source/WebCore/dom/Element+Fullscreen.idl M Source/WebCore/dom/FullscreenManager.cpp Log Message: --- Remove UnprefixedFullscreenAPIEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271142 Reviewed by Tim Nguyen. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/Document+Fullscreen.idl: * Source/WebCore/dom/DocumentOrShadowRoot+Fullscreen.idl: * Source/WebCore/dom/Element+Fullscreen.idl: * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::dispatchEventForNode): Canonical link: https://commits.webkit.org/276301@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 737de5: Increase maximum number of dynamic and session rul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 737de53153a1a63472f39ac12e7d2e8b1c7fdc14 https://github.com/WebKit/WebKit/commit/737de53153a1a63472f39ac12e7d2e8b1c7fdc14 Author: Kiara Rose Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionConstants.h Log Message: --- Increase maximum number of dynamic and session rules to 30,000 https://bugs.webkit.org/show_bug.cgi?id=271179 rdar://124967815 Reviewed by Timothy Hatcher. Increase the limit for the maximum number of dynamic and session rules as discussed in the in person WECG meeting. * Source/WebKit/Shared/Extensions/WebExtensionConstants.h: Canonical link: https://commits.webkit.org/276300@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f28f2: [Gardening]: NEW TEST[ MacOS iOS ] media/now-playi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f28f249c61a0c78dab08ba8c6b70dec22446da9 https://github.com/WebKit/WebKit/commit/4f28f249c61a0c78dab08ba8c6b70dec22446da9 Author: Jay Stfleur Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: NEW TEST[ MacOS iOS ] media/now-playing-webaudio.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=124968584 rdar://124968584 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276299@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e70a1: Remove UseLegacyBackgroundSizeShorthandBehavior pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e70a1ee916d54723a0c777b044195eaa5e8fe24 https://github.com/WebKit/WebKit/commit/1e70a1ee916d54723a0c777b044195eaa5e8fe24 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: R LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt R LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm Log Message: --- Remove UseLegacyBackgroundSizeShorthandBehavior preference https://bugs.webkit.org/show_bug.cgi?id=271156 Reviewed by Tim Nguyen. The behavior has been consistent for a little over a decade. Time to remove the old code paths. * LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Removed. * LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeBackgroundShorthand): * Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h: * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h: * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm: (WebKit::defaultUseLegacyBackgroundSizeShorthandBehavior): Deleted. Canonical link: https://commits.webkit.org/276298@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf6198: [build.webkit.org] Upload WebKit build logs to s3
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf619842d9f4be8d6fb994be0a77baa89d06d90b https://github.com/WebKit/WebKit/commit/cf619842d9f4be8d6fb994be0a77baa89d06d90b Author: Brianna Fan Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/steps_unittest.py M Tools/CISupport/ews-build/steps.py Log Message: --- [build.webkit.org] Upload WebKit build logs to s3 https://bugs.webkit.org/show_bug.cgi?id=270807 rdar://problem/124396801 Reviewed by Aakash Jain. Filter logs through filter-build-webkit and upload logs to S3. * Tools/CISupport/build-webkit-org/steps.py: (CompileWebKit): (CompileWebKit.start): * Tools/CISupport/build-webkit-org/steps_unittest.py: (TestCompileWebKit.test_success_architecture): Canonical link: https://commits.webkit.org/276297@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 787725: CSS3DTransformInteroperabilityEnabled preference r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 787725bce0c09bdc6c67aaa9078850e9f5ee2683 https://github.com/WebKit/WebKit/commit/787725bce0c09bdc6c67aaa9078850e9f5ee2683 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsLayerClient.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebCore/platform/graphics/transforms/TransformState.cpp M Source/WebCore/platform/graphics/transforms/TransformState.h M Source/WebCore/rendering/LayerOverlapMap.cpp M Source/WebCore/rendering/RenderGeometryMap.cpp M Source/WebCore/rendering/RenderGeometryMap.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerBacking.h M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/SVGLayerTransformComputation.h M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp Log Message: --- CSS3DTransformInteroperabilityEnabled preference removal follow-up https://bugs.webkit.org/show_bug.cgi?id=271141 Reviewed by Matt Woodrow. This removes the remaining CSS 3D transform interoperability branches where it is a little less apparent whether they are always true. * Source/WebCore/platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::useGiantTiles const): (WebCore::GraphicsLayerClient::useCSS3DTransformInteroperability const): Deleted. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::flushCompositingState): (WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush const): (WebCore::GraphicsLayerCA::platformCALayerUseCSS3DTransformInteroperability const): Deleted. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h: (WebCore::PlatformCALayerClient::platformCALayerUseGiantTiles const): (WebCore::PlatformCALayerClient::platformCALayerUseCSS3DTransformInteroperability const): Deleted. * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::commonInit): * Source/WebCore/platform/graphics/transforms/TransformState.cpp: (WebCore::TransformState::operator=): (WebCore::TransformState::shouldFlattenBefore): (WebCore::TransformState::shouldFlattenAfter): * Source/WebCore/platform/graphics/transforms/TransformState.h: (WebCore::TransformState::TransformState): * Source/WebCore/rendering/LayerOverlapMap.cpp: (WebCore::LayerOverlapMap::LayerOverlapMap): * Source/WebCore/rendering/RenderGeometryMap.cpp: (WebCore::RenderGeometryMap::RenderGeometryMap): (WebCore::RenderGeometryMap::mapToContainer const): * Source/WebCore/rendering/RenderGeometryMap.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateTransformFlatteningLayer): * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute const): (WebCore::RenderObject::absoluteToLocal const): (WebCore::RenderObject::absoluteToLocalQuad const): (WebCore::RenderObject::localToContainerQuad const): (WebCore::RenderObject::localToContainerPoint const): * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer const): * Source/WebCore/rendering/svg/SVGLayerTransformComputation.h: (WebCore::SVGLayerTransformComputation::computeAccumulatedTransform const): * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp: (WebKit::GraphicsLayerWC::flushCompositingState): Canonical link: https://commits.webkit.org/276296@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35b903: [JSC] Remove no-longer-used LLInt -> OMG tiering u...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35b9037171bb6b1e4fba5754093baac2286a1321 https://github.com/WebKit/WebKit/commit/35b9037171bb6b1e4fba5754093baac2286a1321 Author: Yusuke Suzuki Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M JSTests/wasm/stress/simd-unreachable.js M JSTests/wasm/v8/adapter-frame.js M JSTests/wasm/v8/add-getters.js M JSTests/wasm/v8/anyfunc.js M JSTests/wasm/v8/array-copy-benchmark.js M JSTests/wasm/v8/array-init-from-segment.js M JSTests/wasm/v8/asm-wasm-copy.js M JSTests/wasm/v8/asm-wasm-deopt.js M JSTests/wasm/v8/asm-wasm-exception-in-tonumber.js M JSTests/wasm/v8/asm-wasm-expr.js M JSTests/wasm/v8/asm-wasm-f32.js M JSTests/wasm/v8/asm-wasm-f64.js M JSTests/wasm/v8/asm-wasm-heap.js M JSTests/wasm/v8/asm-wasm-i32.js M JSTests/wasm/v8/asm-wasm-imports.js M JSTests/wasm/v8/asm-wasm-literals.js M JSTests/wasm/v8/asm-wasm-math-intrinsic.js M JSTests/wasm/v8/asm-wasm-memory.js M JSTests/wasm/v8/asm-wasm-names.js M JSTests/wasm/v8/asm-wasm-stack.js M JSTests/wasm/v8/asm-wasm-stdlib.js M JSTests/wasm/v8/asm-wasm-switch.js M JSTests/wasm/v8/asm-wasm-u32.js M JSTests/wasm/v8/asm-wasm.js M JSTests/wasm/v8/asm-with-wasm-off.js M JSTests/wasm/v8/atomics-non-shared.js M JSTests/wasm/v8/atomics-stress.js M JSTests/wasm/v8/atomics.js M JSTests/wasm/v8/atomics64-stress.js M JSTests/wasm/v8/bigint-i64-to-imported-js-func.js M JSTests/wasm/v8/bigint-opt.js M JSTests/wasm/v8/bigint-rematerialize.js M JSTests/wasm/v8/bigint.js M JSTests/wasm/v8/bit-shift-right.js M JSTests/wasm/v8/bounds-check-64bit.js M JSTests/wasm/v8/bounds-check-turbofan.js M JSTests/wasm/v8/bulk-memory.js M JSTests/wasm/v8/call-ref.js M JSTests/wasm/v8/call_indirect.js M JSTests/wasm/v8/calls.js M JSTests/wasm/v8/code-space-overflow.js M JSTests/wasm/v8/committed-code-exhaustion.js M JSTests/wasm/v8/compare-exchange-stress.js M JSTests/wasm/v8/compare-exchange64-stress.js M JSTests/wasm/v8/compilation-hints-async-compilation.js M JSTests/wasm/v8/compilation-hints-decoder.js M JSTests/wasm/v8/compilation-hints-ignored.js M JSTests/wasm/v8/compilation-hints-lazy-validation.js M JSTests/wasm/v8/compilation-hints-streaming-compilation.js M JSTests/wasm/v8/compilation-hints-streaming-lazy-validation.js M JSTests/wasm/v8/compilation-hints-sync-compilation.js M JSTests/wasm/v8/compilation-limits-asm.js M JSTests/wasm/v8/compilation-limits.js M JSTests/wasm/v8/compiled-module-management.js M JSTests/wasm/v8/compiled-module-serialization.js M JSTests/wasm/v8/data-segments.js M JSTests/wasm/v8/disable-trap-handler.js M JSTests/wasm/v8/disallow-codegen.js M JSTests/wasm/v8/divrem-trap.js M JSTests/wasm/v8/element-segments-with-reftypes.js M JSTests/wasm/v8/empirical_max_memory.js M JSTests/wasm/v8/ensure-wasm-binaries-up-to-date.js M JSTests/wasm/v8/errors.js M JSTests/wasm/v8/export-global.js M JSTests/wasm/v8/export-identity.js M JSTests/wasm/v8/export-mutable-global.js M JSTests/wasm/v8/export-table.js M JSTests/wasm/v8/expose-wasm.js M JSTests/wasm/v8/extended-constants.js M JSTests/wasm/v8/externref-globals.js M JSTests/wasm/v8/externref-table.js M JSTests/wasm/v8/externref.js M JSTests/wasm/v8/ffi-error.js M JSTests/wasm/v8/ffi.js M JSTests/wasm/v8/float-constant-folding.js M JSTests/wasm/v8/function-names.js M JSTests/wasm/v8/function-prototype.js M JSTests/wasm/v8/futex.js M JSTests/wasm/v8/gc-buffer.js M JSTests/wasm/v8/gc-casts-from-any.js M JSTests/wasm/v8/gc-casts-invalid.js M JSTests/wasm/v8/gc-casts-subtypes.js M JSTests/wasm/v8/gc-experimental-string-conversions.js M JSTests/wasm/v8/gc-experiments.js M JSTests/wasm/v8/gc-frame.js M JSTests/wasm/v8/gc-js-interop-async-debugger.js M JSTests/wasm/v8/gc-js-interop-collections.js M JSTests/wasm/v8/gc-js-interop-export.mjs M JSTests/wasm/v8/gc-js-interop-global-constructors.js M JSTests/wasm/v8/gc-js-interop-import.mjs M JSTests/wasm/v8/gc-js-interop-numeric.js M JSTests/wasm/v8/gc-js-interop-objects.js M JSTests/wasm/v8/gc-js-interop-wasm.js M JSTests/wasm/v8/gc-js-interop.js M JSTests/wasm/v8/gc-memory.js M JSTests/wasm/v8/gc-nominal.js M JSTests/wasm/v8/gc-optimizations.js M JSTests/wasm/v8/gc-stress.js M JSTests/wasm/v8/gc-typecheck-reducer.js M JSTests/wasm/v8/gdbjit.js M JSTests/wasm/v8/generic-wrapper.js M JSTests/wasm/v8/globals-import-export-identity.js M JSTests/wasm/v8/globals.js M JSTests/wasm/v8/graceful_shutdown.js M JSTests/wasm/v8/graceful_shutdown_during_tierup.js M JSTests/wasm/v8/grow-huge-memory.js M JSTests/wasm/v8/grow-memory-detaching.js M JSTests/wasm/v8/grow-memory-in-branc
[webkit-changes] [WebKit/WebKit] afd161: REGRESSION(268173@main) Safari rendered bdiusa.com...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afd16103076c8029ee4527728da0ff1926fc7483 https://github.com/WebKit/WebKit/commit/afd16103076c8029ee4527728da0ff1926fc7483 Author: Matt Woodrow Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: A LayoutTests/fast/clip/offscreen-transparency-clip-expected.html A LayoutTests/fast/clip/offscreen-transparency-clip.html M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- REGRESSION(268173@main) Safari rendered bdiusa.com as all white. https://bugs.webkit.org/show_bug.cgi?id=270926 Reviewed by Simon Fraser. We're using transparencyClipBox to determine the size of the transparency layer to push, and it's returning an empty rectangle. It recurses through descendants, and finds a child layer positioned way off to the left of the screen (at -33553151). Due to limits of int32, adding the bounds of that child into the original rect (0,0) width=1686 height=18933.45, results in (-33554430,0) width=33554432 height=18933.45 which no longer includes the visible area of the screen (except for the very left edge). This fix moves the intersection with the dirty rect down to happen per-layer, so that we clip before unioning the descendants in, and avoid this problem. As the existing code comment mentions, it would still be preferable to take CSS clips into account when computing these rectangles. * LayoutTests/fast/clip/offscreen-transparency-clip-expected.html: Added. * LayoutTests/fast/clip/offscreen-transparency-clip.html: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::paintingExtent): Deleted. Canonical link: https://commits.webkit.org/276294@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2694d9: [GCC] Unreviewed, build fix for Debian 11 after 27...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2694d9fd7095bb1e77640cd3ac0b799448758ed7 https://github.com/WebKit/WebKit/commit/2694d9fd7095bb1e77640cd3ac0b799448758ed7 Author: Diego Pino Garcia Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp M Source/WebCore/loader/FormSubmission.cpp M Source/WebCore/platform/network/FormData.cpp M Source/WebKit/UIProcess/API/glib/IconDatabase.cpp M Tools/TestWebKitAPI/Tests/WTF/Vector.cpp Log Message: --- [GCC] Unreviewed, build fix for Debian 11 after 276220@main Several build bots using GCC10.2 (Debian 11) and GCC 11.4 (Ubuntu 22.04) are failing after changes introduced in 276220@main, possibly due to limitations in the compiler. * Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: (PAL::CryptoDigest::computeHash): * Source/WebCore/loader/FormSubmission.cpp: (WebCore::appendMailtoPostFormDataToURL): * Source/WebCore/platform/network/FormData.cpp: (WebCore::FormDataElement::isolatedCopy const): * Source/WebKit/UIProcess/API/glib/IconDatabase.cpp: (WebKit::IconDatabase::setIconForPageURL): * Tools/TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/276293@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1dbb4d: [JSC] Simplify BaselineCallLinkInfo by not setting...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dbb4d47a17bf9214dbea275fe54e156f6a8d0e6 https://github.com/WebKit/WebKit/commit/1dbb4d47a17bf9214dbea275fe54e156f6a8d0e6 Author: Yusuke Suzuki Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/CallLinkStatus.cpp M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/Repatch.cpp M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp M Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/BaselineJITCode.cpp M Source/JavaScriptCore/jit/BaselineJITCode.h M Source/JavaScriptCore/jit/JIT.cpp M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp M Source/JavaScriptCore/wasm/js/WasmToJS.cpp Log Message: --- [JSC] Simplify BaselineCallLinkInfo by not setting doneLocation https://bugs.webkit.org/show_bug.cgi?id=271107 rdar://124739833 Reviewed by Justin Michaud. This patch makes CodeBlock::setupWithUnlinkedBaselineCode and BaselineCallLinkInfo simpler by not setting doneLocation. CallLinkInfo's doneLocation for Baseline JIT is collected during compilation, and it is used only by DFG OSR exit compiler. We can just keep it in BaselineJITCode and use it instead of storing it in BaselineCallLinkInfo. * Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::doneLocationIfExists): (JSC::CallLinkInfo::doneLocation): Deleted. * Source/JavaScriptCore/bytecode/CallLinkInfo.h: (JSC::UnlinkedCallLinkInfo::setDoneLocation): (JSC::UnlinkedCallLinkInfo::setCodeLocations): Deleted. * Source/JavaScriptCore/bytecode/CallLinkStatus.cpp: (JSC::CallLinkStatus::computeFor): * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::setupWithUnlinkedBaselineCode): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::emitProxyObjectAccess): * Source/JavaScriptCore/bytecode/Repatch.cpp: (JSC::linkPolymorphicCall): * Source/JavaScriptCore/dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link): * Source/JavaScriptCore/dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::callerReturnPC): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/jit/BaselineJITCode.cpp: (JSC::BaselineJITCode::getCallLinkDoneLocationForBytecodeIndex const): (JSC::BaselineJITCode::~BaselineJITCode): Deleted. * Source/JavaScriptCore/jit/BaselineJITCode.h: * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::link): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp: (JSC::PolymorphicCallNode::unlinkOrUpgradeImpl): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::wasmToJS): Canonical link: https://commits.webkit.org/276292@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27a08b: AX: VoiceOver is reading standard time instead of ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27a08be942a4d169a735ff4b7136cfed2eed80d5 https://github.com/WebKit/WebKit/commit/27a08be942a4d169a735ff4b7136cfed2eed80d5 Author: Andres Gonzalez Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/accessibility/datetime/input-time-label-value-expected.txt M LayoutTests/accessibility/datetime/input-time-label-value.html A LayoutTests/platform/ios/accessibility/datetime/input-time-label-value-expected.txt M LayoutTests/platform/mac-ventura/accessibility/datetime/input-time-label-value-expected.txt M Source/WebCore/accessibility/AXCoreObject.h M Source/WebCore/accessibility/AccessibilityNodeObject.cpp M Source/WebCore/accessibility/AccessibilityObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm Log Message: --- AX: VoiceOver is reading standard time instead of daylight savings time in elements. https://bugs.webkit.org/show_bug.cgi?id=270988 Reviewed by Tyler Wilcock. Corrects the NSDate returned to AX client taking into account the daylight savings status. The correction does not apply to datetime-local fields. This involves the following changes: - AXIsolatedObjects now cache the DateComponentsType instead of the AXF value requred by VoiceOver. - The AXFDateTimeComponent value is computed on demand from the DateComponentsType. - AccessibilityUIElement::dateValue also accounts for daylight savings adjustment. - The test input-time-label-value.html was expanded to also check not just the UI string representing the time, but the NSDate being sent to VoiceOver. * LayoutTests/accessibility/datetime/input-time-label-value-expected.txt: * LayoutTests/accessibility/datetime/input-time-label-value.html: * LayoutTests/platform/ios/accessibility/datetime/input-time-label-value-expected.txt: Added. * Source/WebCore/accessibility/AXCoreObject.h: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityObject::dateTimeComponentsType const): * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::setProperty): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: * Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm: (): Deleted. (WebCore::AccessibilityObject::dateTimeComponents const): Deleted. * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (convertToAXFDateTimeComponents): (gmtToLocalTimeOffset): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): * Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: (WTR::AccessibilityUIElement::dateValue): Canonical link: https://commits.webkit.org/276291@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e65333: Create header file for interface declaration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6533346dc5ade83fa418ae71af1544b4d606055 https://github.com/WebKit/WebKit/commit/e6533346dc5ade83fa418ae71af1544b4d606055 Author: Per Arne Vollan Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: A Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Create header file for interface declaration https://bugs.webkit.org/show_bug.cgi?id=271160 rdar://124950453 Reviewed by Sihui Liu and Chris Dumez. Guard against potential build issues, by moving interface declaration to a header file. * Source/WebKit/Platform/spi/Cocoa/AccessibilityUtilitiesSPI.h: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::postNotification): Canonical link: https://commits.webkit.org/276290@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fee2d0: Unified PDF: HUD gets pinned to the left side of t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fee2d02ccb2159f478000d7b9264ac55c21889ef https://github.com/WebKit/WebKit/commit/fee2d02ccb2159f478000d7b9264ac55c21889ef Author: Tim Horton Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/UIProcess/PDF/WKPDFHUDView.h M Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm Log Message: --- Unified PDF: HUD gets pinned to the left side of the viewport after dragging window from/to 1x display https://bugs.webkit.org/show_bug.cgi?id=271170 Reviewed by Simon Fraser and Abrar Rahman Protyasha. Fix a longstanding bug in the HUD: if the device scale factor changes but the HUD frame does not, we'll rebuild the layer, but not lay it out inside the view, only set its size. Fix this by removing our setFrame override and implementing -layout instead. * Source/WebKit/UIProcess/PDF/WKPDFHUDView.h: * Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm: (-[WKPDFHUDView layout]): (-[WKPDFHUDView _setupLayer:]): (-[WKPDFHUDView _redrawLayer]): (-[WKPDFHUDView setFrame:]): Deleted. Canonical link: https://commits.webkit.org/276289@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07b024: UnifiedPDF: Home and End keys don't work
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07b0249cdf4af4e82778d4a7f381de4f468b7a8f https://github.com/WebKit/WebKit/commit/07b0249cdf4af4e82778d4a7f381de4f468b7a8f Author: Tim Horton Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/KeyboardScrollingAnimator.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- UnifiedPDF: Home and End keys don't work https://bugs.webkit.org/show_bug.cgi?id=271165 Reviewed by Abrar Rahman Protyasha. * Source/WebCore/platform/KeyboardScrollingAnimator.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::handleKeyboardEvent): Take care of Home and End key commands that make it to us. Canonical link: https://commits.webkit.org/276288@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d4ecd7: Remove FormAssociatedCustomElementsEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d4ecd740a990f3594cf147b44a7e734924793aad https://github.com/WebKit/WebKit/commit/d4ecd740a990f3594cf147b44a7e734924793aad Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp M Source/WebCore/dom/ElementInternals.idl M Source/WebCore/html/HTMLElement.idl Log Message: --- Remove FormAssociatedCustomElementsEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271155 Reviewed by Ryosuke Niwa. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp: (WebCore::JSCustomElementRegistry::define): * Source/WebCore/dom/ElementInternals.idl: * Source/WebCore/html/HTMLElement.idl: Canonical link: https://commits.webkit.org/276287@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dbbb87: Explicitly set SameSite=None cookies in resourceLo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dbbb87d3dd12cfddd29a9ccb896c1861aeccd76c https://github.com/WebKit/WebKit/commit/dbbb87d3dd12cfddd29a9ccb896c1861aeccd76c Author: Charlie Wolfe Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie.py M LayoutTests/http/tests/storageAccess/resources/set-cookie.py Log Message: --- Explicitly set SameSite=None cookies in resourceLoadStatistics/resources/set-cookie.py and storageAccess/resources/set-cookie.py https://bugs.webkit.org/show_bug.cgi?id=270825 rdar://124363343 Reviewed by Alex Christensen. * LayoutTests/http/tests/resourceLoadStatistics/resources/set-cookie.py: * LayoutTests/http/tests/storageAccess/resources/set-cookie.py: Canonical link: https://commits.webkit.org/276286@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5f8e9: Remove ConstructableStylesheetsEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e5f8e964dc554b7bcdb89a1d417fbedf0f6e5002 https://github.com/WebKit/WebKit/commit/e5f8e964dc554b7bcdb89a1d417fbedf0f6e5002 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSStyleSheet.idl M Source/WebCore/css/DocumentOrShadowRoot+CSSOM.idl Log Message: --- Remove ConstructableStylesheetsEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271152 Reviewed by Ryosuke Niwa. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSStyleSheet.idl: * Source/WebCore/css/DocumentOrShadowRoot+CSSOM.idl: Canonical link: https://commits.webkit.org/276285@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 34d57d: Remove ImperativeSlotAPIEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 34d57dde0c8f223d0698f9e280f4b76736221775 https://github.com/WebKit/WebKit/commit/34d57dde0c8f223d0698f9e280f4b76736221775 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/dom/ShadowRoot.idl M Source/WebCore/dom/ShadowRootInit.idl M Source/WebCore/html/HTMLSlotElement.idl Log Message: --- Remove ImperativeSlotAPIEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271148 Reviewed by Ryosuke Niwa. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/ShadowRoot.idl: * Source/WebCore/dom/ShadowRootInit.idl: * Source/WebCore/html/HTMLSlotElement.idl: Canonical link: https://commits.webkit.org/276284@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd5e35: Remove MaskWebGLStringsEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd5e355b8a047e36f26f3584d561ee0c88bbde44 https://github.com/WebKit/WebKit/commit/dd5e355b8a047e36f26f3584d561ee0c88bbde44 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h Log Message: --- Remove MaskWebGLStringsEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271147 Reviewed by Ryosuke Niwa. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getParameter): * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::getParameter): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences maskWebGLStringsEnabled]): (-[WebPreferences setMaskWebGLStringsEnabled:]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/276283@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2922af: REGRESSION(274077@main): failure to build on i586 ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2922af379dc70b4b1a63b01d67179eb431f03ac4 https://github.com/WebKit/WebKit/commit/2922af379dc70b4b1a63b01d67179eb431f03ac4 Author: Michael Catanzaro Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/Timer.cpp Log Message: --- REGRESSION(274077@main): failure to build on i586 (and likely other 32bit arches): static assertion failed: Timer should stay small https://bugs.webkit.org/show_bug.cgi?id=271108 Unreviewed build fix. This changes SameSizeOfTimer to ensure it matches the size of Timer on 32-bit platforms. * Source/WebCore/platform/Timer.cpp: Canonical link: https://commits.webkit.org/276282@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db6af5: [Unified Text Replacement] Replacing text with dif...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db6af5233814f255608474151037c983fcd06a82 https://github.com/WebKit/WebKit/commit/db6af5233814f255608474151037c983fcd06a82 Author: Richard Robinson Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm Log Message: --- [Unified Text Replacement] Replacing text with different text lengths sometimes results in duplicate characters https://bugs.webkit.org/show_bug.cgi?id=271137 rdar://124474722 Reviewed by Aditya Keerthi. Use the correct resolved simple range as it was intended. * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements): Canonical link: https://commits.webkit.org/276281@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6f6701: [WebCore] Use fast bitset iteration for Style Buil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6f670174ddc808f8b33835f906a779b27236e8a4 https://github.com/WebKit/WebKit/commit/6f670174ddc808f8b33835f906a779b27236e8a4 Author: Yusuke Suzuki Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/wtf/BitSet.h M Source/WebCore/style/PropertyCascade.cpp M Source/WebCore/style/PropertyCascade.h M Source/WebCore/style/StyleBuilder.cpp M Tools/TestWebKitAPI/Tests/WTF/BitSet.cpp Log Message: --- [WebCore] Use fast bitset iteration for Style Builder::applyPropertiesImpl https://bugs.webkit.org/show_bug.cgi?id=271100 rdar://124722402 Reviewed by Antti Koivisto. While top-priority / high-priority CSS properties are limited, more than 300 low-priority CSS properties exist. And we are doing very naive iteration for that in Builder::applyPropertiesImpl. Given that only low-priority CSS properties are huge and it is placed at the end of bitset, let's just use super fast bitset iteration instead of doing naive loop. * Source/WTF/wtf/BitSet.h: (WTF::WordType>::forEachSetBit const): * Source/WebCore/style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::set): * Source/WebCore/style/PropertyCascade.h: (WebCore::Style::PropertyCascade::isEmpty const): (WebCore::Style::PropertyCascade::propertyIsPresent): (WebCore::Style::PropertyCascade::propertyIsPresent const): (WebCore::Style::PropertyCascade::hasNormalProperty const): * Source/WebCore/style/StyleBuilder.cpp: (WebCore::Style::Builder::applyPropertiesImpl): * Tools/TestWebKitAPI/Tests/WTF/BitSet.cpp: (TestWebKitAPI::testBitSetForEachSetBitWithStartIndex): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/276280@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df2c83: Remove FetchMetadataEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df2c830759663d7c153f068043215c4bb452300d https://github.com/WebKit/WebKit/commit/df2c830759663d7c153f068043215c4bb452300d Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp M Source/WebCore/loader/CrossOriginPreflightChecker.cpp M Source/WebCore/loader/cache/CachedResourceLoader.cpp Log Message: --- Remove FetchMetadataEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271154 Reviewed by Sihui Liu. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp: (WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): * Source/WebCore/loader/CrossOriginPreflightChecker.cpp: (WebCore::CrossOriginPreflightChecker::startPreflight): (WebCore::CrossOriginPreflightChecker::doPreflight): * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::updateRequestAfterRedirection): (WebCore::CachedResourceLoader::updateHTTPRequestHeaders): Canonical link: https://commits.webkit.org/276279@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42860c: Improve logging in ResourceLoadStatisticsStore
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42860c4e30eafd4f3bb5d9db93216f397801171f https://github.com/WebKit/WebKit/commit/42860c4e30eafd4f3bb5d9db93216f397801171f Author: Sihui Liu Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h Log Message: --- Improve logging in ResourceLoadStatisticsStore https://bugs.webkit.org/show_bug.cgi?id=271082 rdar://124713253 Reviewed by Per Arne Vollan. When debugging an ITP issue I notice the logs are not easy to find and read, so this patch makes following improvements: 1. Intead of using Network channel, which is usually very noisy, make the logs use the dedicated ResourceLoadStatistics channel. 2. Make logs have the same format by using the macros everywhere. Currently some logs use the macros and others don't, and their are formatted differently. 3. Make the error logs more informational by including sessionID, database error code and error message in them. * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: (WebKit::ResourceLoadStatisticsStore::ResourceLoadStatisticsStore): (WebKit::ResourceLoadStatisticsStore::removeDataRecords): (WebKit::ResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode): (WebKit::ResourceLoadStatisticsStore::debugLogDomainsInBatches): (WebKit::ResourceLoadStatisticsStore::tableExists): (WebKit::ResourceLoadStatisticsStore::deleteTable): (WebKit::ResourceLoadStatisticsStore::missingUniqueIndices): (WebKit::ResourceLoadStatisticsStore::migrateDataToPCMDatabaseIfNecessary): (WebKit::ResourceLoadStatisticsStore::addMissingTablesIfNecessary): (WebKit::ResourceLoadStatisticsStore::openAndUpdateSchemaIfNecessary): (WebKit::ResourceLoadStatisticsStore::isEmpty const): (WebKit::ResourceLoadStatisticsStore::createUniqueIndices): (WebKit::ResourceLoadStatisticsStore::createSchema): (WebKit::ResourceLoadStatisticsStore::insertObservedDomain): (WebKit::ResourceLoadStatisticsStore::relationshipExists const): (WebKit::ResourceLoadStatisticsStore::domainID const): (WebKit::ResourceLoadStatisticsStore::ensureAndMakeDomainList): (WebKit::ResourceLoadStatisticsStore::insertDomainRelationshipList): (WebKit::ResourceLoadStatisticsStore::mergeStatistic): (WebKit::ResourceLoadStatisticsStore::mergeStatistics): (WebKit::ResourceLoadStatisticsStore::getThirdPartyDataForSpecificFirstPartyDomains const): (WebKit::ResourceLoadStatisticsStore::aggregatedThirdPartyData const): (WebKit::ResourceLoadStatisticsStore::incrementRecordsDeletedCountForDomains): (WebKit::ResourceLoadStatisticsStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain): (WebKit::ResourceLoadStatisticsStore::markAsPrevalentIfHasRedirectedToPrevalent): (WebKit::ResourceLoadStatisticsStore::hasStorageAccess): (WebKit::ResourceLoadStatisticsStore::requestStorageAccess): (WebKit::ResourceLoadStatisticsStore::requestStorageAccessUnderOpener): (WebKit::ResourceLoadStatisticsStore::grantStorageAccess): (WebKit::ResourceLoadStatisticsStore::grantStorageAccessInternal): (WebKit::ResourceLoadStatisticsStore::grandfatherDataForDomains): (WebKit::ResourceLoadStatisticsStore::ensurePrevalentResourcesForDebugMode): (WebKit::ResourceLoadStatisticsStore::logFrameNavigation): (WebKit::ResourceLoadStatisticsStore::logCrossSiteLoadWithLinkDecoration): (WebKit::ResourceLoadStatisticsStore::clearTopFrameUniqueRedirectsToSinceSameSiteStrictEnforcement): (WebKit::ResourceLoadStatisticsStore::setUserInteraction): (WebKit::ResourceLoadStatisticsStore::logUserInteraction): (WebKit::ResourceLoadStatisticsStore::clearUserInteraction): (WebKit::ResourceLoadStatisticsStore::hasHadUserInteraction): (WebKit::ResourceLoadStatisticsStore::setPrevalentResource): (WebKit::ResourceLoadStatisticsStore::setDomainsAsPrevalent): (WebKit::ResourceLoadStatisticsStore::predicateValueForDomain const): (WebKit::ResourceLoadStatisticsStore::clearPrevalentResource): (WebKit::ResourceLoadStatisticsStore::setGrandfathered): (WebKit::ResourceLoadStatisticsStore::setIsScheduledForAllScriptWrittenStorageRemoval): (WebKit::ResourceLoadStatisticsStore::setMostRecentWebPushInteractionTime): (WebKit::ResourceLoadStatisticsStore::getMostRecentlyUpdatedTimestamp const): (WebKit::ResourceLoadStatisticsStore::setSubframeUnderTopFrameDomain): (WebKit::ResourceLoadStatisticsStore::setSubresourceUnderTopFrameDomain): (WebKit::ResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo): (WebKit::ResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom): (WebKit::ResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo): (WebKit::ResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom): (WebKit::ResourceLoadStatisticsStore::ensureResourceStatisticsForRegistrableDomain): (WebKit::ResourceLoadStatisticsStore::clearDatabaseContents): (WebKit::ResourceLoadStatisticsStore::removeDataForDomain
[webkit-changes] [WebKit/WebKit] 40f3c6: Setting white-space to non-default value dynamical...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40f3c61c1d9db38322926691028b6ec5be87793f https://github.com/WebKit/WebKit/commit/40f3c61c1d9db38322926691028b6ec5be87793f Author: Alan Baradlay Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: A LayoutTests/fast/text/text-node-needs-renderer-after-style-change-expected.html A LayoutTests/fast/text/text-node-needs-renderer-after-style-change.html M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/css-variable-change-style-001-expected.txt M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- Setting white-space to non-default value dynamically on a blank (whitespace/new line) does not work correctly https://bugs.webkit.org/show_bug.cgi?id=239689 Reviewed by Antti Koivisto. Let's consider constructing a renderer for whitespace only content when we need to preserve whitespace as the result of a style change. css/css-variables/css-variable-change-style-001: progression. * LayoutTests/fast/text/text-node-needs-renderer-after-style-change-expected.html: Added. * LayoutTests/fast/text/text-node-needs-renderer-after-style-change.html: Added. * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateRenderTree): Canonical link: https://commits.webkit.org/276277@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d679ab: [CMake] Regenerate bindings when UnifiedWebPrefere...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d679abb2e0d1e427796a3f6b8d740e8c6681a559 https://github.com/WebKit/WebKit/commit/d679abb2e0d1e427796a3f6b8d740e8c6681a559 Author: Patrick Griffis Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/WebCoreMacros.cmake Log Message: --- [CMake] Regenerate bindings when UnifiedWebPreferences is modified https://bugs.webkit.org/show_bug.cgi?id=264156 Reviewed by Don Olmstead. When a setting is removed from UnifiedWebPreferences the output of the generated files may change if an IDL file uses EnabledBySetting. Ideally this would be tracked per IDL file but that isn't how the generator currently works. * Source/WebCore/WebCoreMacros.cmake: Canonical link: https://commits.webkit.org/276276@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0be766: "NULL Object : Crash under WebCore::RenderObject::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0be766940c18b3f779d8cac89d2e9696720e1b91 https://github.com/WebKit/WebKit/commit/0be766940c18b3f779d8cac89d2e9696720e1b91 Author: Nisha Jain Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: A LayoutTests/dom/html/document-renderobject-null-crash-expected.txt A LayoutTests/dom/html/document-renderobject-null-crash.html M Source/WebCore/dom/Document.cpp Log Message: --- "NULL Object : Crash under WebCore::RenderObject::~RenderObject; WebCore::RenderText::~RenderText; WebCore::RenderTreeBuilder::destroy" https://bugs.webkit.org/show_bug.cgi?id=267297 rdar://119186861. Reviewed by Alan Baradlay. Document::caretPositionFromPoint API is using CheckPtr to get RenderObject even though the Object is already destroyed. In order to make sure CheckedPtr is valid the render needs to be destroyed earlier not after. Using updateLayoutIgnorePendingStylesheets API for uptodate renderer tree. * LayoutTests/dom/html/document-renderobject-null-crash-expected.txt: Added test expected file. * LayoutTests/dom/html/document-renderobject-null-crash.html: Added test case. * Source/WebCore/dom/Document.cpp: (WebCore::Document::caretPositionFromPoint): Added updateLayoutIgnorePendingStylesheets to get updated renderer tree before using CheckedPtr. Originally-landed-as: 272448.251@safari-7618-branch (9baf7178103b). rdar://124556134 Canonical link: https://commits.webkit.org/276275@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 35eac7: [WPE] Flaky crashes in ScrollingTreeFrameScrolling...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 35eac7110bda60860e9184254cbe3fb9494d3170 https://github.com/WebKit/WebKit/commit/35eac7110bda60860e9184254cbe3fb9494d3170 Author: Vitaly Dyachkov Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/wpe/TestExpectations M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp Log Message: --- [WPE] Flaky crashes in ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers https://bugs.webkit.org/show_bug.cgi?id=213228 Reviewed by Adrian Perez de Castro. When the `FrameView` delegates scrolling to a native scroll view, we do not create a dedicated graphics layer for scrolled contents. In this case, `static_cast(scrolledContentsLayer())` evaluates to `nullptr` and we hit the assertion. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp: (WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers): Canonical link: https://commits.webkit.org/276274@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee7e9f: [Xcode] Simplify code coverage builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee7e9fa115013e7be28a5ba2f52c16f486d4e55a https://github.com/WebKit/WebKit/commit/ee7e9fa115013e7be28a5ba2f52c16f486d4e55a Author: David Kilzer Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Makefile.shared M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Tools/Scripts/webkitdirs.pm R Tools/coverage/coverage.xcconfig Log Message: --- [Xcode] Simplify code coverage builds https://bugs.webkit.org/show_bug.cgi?id=271055 Reviewed by Alex Christensen. This change simplifies code coverage builds of WebKit using Xcode. Instead of specifying `-xcconfig Tools/coverage/coverage.xcconfig` on the command-line, the CLANG_COVERAGE_MAPPING=YES Xcode variable now enables code coverage builds. * Makefile.shared: - Add support for `CODE_COVERAGE=YES` when using `make` to build. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: (WebCoreTestSupport: InternalSettingsGenerated.cpp): - This file causes clang to hang indefinitely when compiled with code coverage enabled, so add "-fno-profile-instr-generate -fno-coverage-mapping" to COMPILER_FLAGS for just this file. (Has no effect on non-code-coverage builds.) The issue is tracked by . * Tools/Scripts/webkitdirs.pm: (XcodeCoverageSupportOptions): - Use "CLANG_COVERAGE_MAPPING=YES" instead of specifying a path to Tools/coverage/coverage.xcconfig. * Tools/coverage/coverage.xcconfig: Remove. Canonical link: https://commits.webkit.org/276273@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e13808: Remove HasPseudoClassEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e13808ae29cfebdb2bc36b9721a7b718dce6c0f6 https://github.com/WebKit/WebKit/commit/e13808ae29cfebdb2bc36b9721a7b718dce6c0f6 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/contentextensions/ContentExtensionParser.cpp M Source/WebCore/css/CSSPseudoSelectors.json M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSSelectorParserContext.cpp M Source/WebCore/css/parser/CSSSelectorParserContext.h Log Message: --- Remove HasPseudoClassEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271151 Reviewed by Antti Koivisto. It's been stable for over a year. Potentially some more code could be cleaned up in ContentExtensionParser given how this was added in 259068@main, but changes have been made there meanwhile and this might well be needed for other CSS-related preferences in the future. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/contentextensions/ContentExtensionParser.cpp: (WebCore::ContentExtensions::isValidCSSSelector): (WebCore::ContentExtensions::contentExtensionCSSParserContext): * Source/WebCore/css/CSSPseudoSelectors.json: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSSelectorParserContext.cpp: (WebCore::CSSSelectorParserContext::CSSSelectorParserContext): (WebCore::add): * Source/WebCore/css/parser/CSSSelectorParserContext.h: Canonical link: https://commits.webkit.org/276272@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 904dc9: Remove ENABLE_3D_TRANSFORMS directive
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 904dc91d2381352b51d8f5e4ba2bec012458d913 https://github.com/WebKit/WebKit/commit/904dc91d2381352b51d8f5e4ba2bec012458d913 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/cmake/OptionsWin.cmake M Source/cmake/WebKitFeatures.cmake M Tools/Scripts/webkitperl/FeatureList.pm M Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl Log Message: --- Remove ENABLE_3D_TRANSFORMS directive https://bugs.webkit.org/show_bug.cgi?id=271145 Reviewed by Michael Catanzaro. It's been enabled on all ports since 2017 or so. * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::transform3d): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::makeMatrixRenderable): * Source/WebCore/rendering/RenderLayerCompositor.cpp: * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::shouldUseTransformFromContainer const): (WebCore::RenderObject::getTransformFromContainer const): * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Tools/Scripts/webkitperl/FeatureList.pm: * Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Canonical link: https://commits.webkit.org/276271@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fa9c6d: VP8 WebCoreDecompressionSession should attribute i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa9c6d7fd22bb76f2a4b349e899025e72dfdfb3a https://github.com/WebKit/WebKit/commit/fa9c6d7fd22bb76f2a4b349e899025e72dfdfb3a Author: Youenn Fablet Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/VideoDecoder.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.h M Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h M Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp Log Message: --- VP8 WebCoreDecompressionSession should attribute its IOSurfaces to the media player resource owner https://bugs.webkit.org/show_bug.cgi?id=271144 rdar://123795173 Reviewed by Jean-Yves Avenard. When WebCoreDecompressionSession uses a VideoDecoder to do its decoding, it uses an IOSurface pixel buffer pool. We then need to attribute these buffers to the corresponding resource owner. To do so, we are setting a resourceOwner in WebCoreDecompressionSession from VideoMediaSampleRenderer, which gets it from MediaPlayerPrivateWebM. The WebCoreDecompressionSession is creating a VideoDecoder that is given the resourceOwner so that, everytime we have a pixel buffer coming from the buffer pool, we then do the attribution. We also do this for MediaPlayerPrivateMediaSourceAVFObjC's session. This means piping the resource owner to MediaSourcePrivate -> SourceBufferPrivate. * Source/WebCore/platform/VideoDecoder.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureDecompressionSession): * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer): * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::setVideoRenderer): * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::ensureLayer): (WebCore::MediaPlayerPrivateWebM::ensureDecompressionSession): * Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.h: (WebCore::VideoMediaSampleRenderer::setResourceOwner): * Source/WebCore/platform/graphics/cocoa/VideoMediaSampleRenderer.mm: (WebCore::VideoMediaSampleRenderer::initializeDecompressionSession): * Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.h: * Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::initializeVideoDecoder): * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp: (WebCore::LibWebRTCVPXInternalVideoDecoder::LibWebRTCVPXInternalVideoDecoder): (WebCore::LibWebRTCVPXInternalVideoDecoder::Decoded): Canonical link: https://commits.webkit.org/276270@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6991ef: Reduce function call in `prepareWhitespaceAtPositi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6991ef6c707e9b2a052dc182c7d3ca9801b1d3a0 https://github.com/WebKit/WebKit/commit/6991ef6c707e9b2a052dc182c7d3ca9801b1d3a0 Author: Ahmad Saleem Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/editing/CompositeEditCommand.cpp Log Message: --- Reduce function call in `prepareWhitespaceAtPositionForSplit` https://bugs.webkit.org/show_bug.cgi?id=271119 Reviewed by Ryosuke Niwa. This patch is to reduce function call by using local variable introduced above. * Source/WebCore/editing/CompositeEditCommand.cpp: (CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Canonical link: https://commits.webkit.org/276269@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1d071: [Skia] Add support for dashed/dotted borders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1d071b0bba21adab22fddb046d53bec683c0c50 https://github.com/WebKit/WebKit/commit/d1d071b0bba21adab22fddb046d53bec683c0c50 Author: Pawel Lampe Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] Add support for dashed/dotted borders https://bugs.webkit.org/show_bug.cgi?id=271044 Reviewed by Carlos Garcia Campos. This change ports dashed/dotted borders implementation from core graphics to skia. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::drawLine): (WebCore::GraphicsContextSkia::setLineDash): Canonical link: https://commits.webkit.org/276268@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d01779: Do not repaint newly moved inline box
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d017799bfec158028d9d0678477b3c42db76ed6e https://github.com/WebKit/WebKit/commit/d017799bfec158028d9d0678477b3c42db76ed6e Author: Alan Baradlay Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp M Source/WebCore/rendering/RenderBlockFlow.cpp Log Message: --- Do not repaint newly moved inline box https://bugs.webkit.org/show_bug.cgi?id=267141 rdar://120555470 Reviewed by Antti Koivisto. 1. Repaint needs uptodate geometry information to compute the damaged area 2. Whenever we invalidate the line layout path, we lose all geometry information so a full repaint is being issued on the very first invalidation. (note that there may be multiple mutations happening the same time) This patch ensures that such repaints are _not_ issued on newly inserted content. Since we don't keep track of whether a particular renderer has already issued repaint, moving renders between blocks could potentially be repainted twice; initially when they get detached and later when they get inserted at their new position. Repaint issued at this later stage most likely results in incorrectly computed damage area as all relevant geometries are relative to the former block -and in some cases it may even trigger crashes as we don't find associated layout/display boxes in the new block. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::invalidateLineLayoutPath): Originally-landed-as: 272448.98@safari-7618-branch (77a82bb2bcde). rdar://124556609 Canonical link: https://commits.webkit.org/276267@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e225c2: Remove CSSTypedOMEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e225c278f4c06f451ea92cc68b12986dd2a99979 https://github.com/WebKit/WebKit/commit/e225c278f4c06f451ea92cc68b12986dd2a99979 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/css-typedom/attributeStyleMap.html M LayoutTests/css-typedom/css-style-value-parse.html M LayoutTests/css-typedom/sameobject.html M LayoutTests/fast/css-custom-paint/properties.html M LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSStyleRule.idl M Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl M Source/WebCore/css/ElementCSSInlineStyle.idl M Source/WebCore/css/typedom/CSSKeywordValue.idl M Source/WebCore/css/typedom/CSSNumericValue.idl M Source/WebCore/css/typedom/CSSOMVariableReferenceValue.idl M Source/WebCore/css/typedom/CSSStyleImageValue.idl M Source/WebCore/css/typedom/CSSStyleValue.idl M Source/WebCore/css/typedom/CSSUnitValue.idl M Source/WebCore/css/typedom/CSSUnparsedValue.idl M Source/WebCore/css/typedom/StylePropertyMap.idl M Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl M Source/WebCore/css/typedom/color/CSSColor.idl M Source/WebCore/css/typedom/color/CSSColorValue.idl M Source/WebCore/css/typedom/color/CSSHSL.idl M Source/WebCore/css/typedom/color/CSSHWB.idl M Source/WebCore/css/typedom/color/CSSLCH.idl M Source/WebCore/css/typedom/color/CSSLab.idl M Source/WebCore/css/typedom/color/CSSOKLCH.idl M Source/WebCore/css/typedom/color/CSSOKLab.idl M Source/WebCore/css/typedom/color/CSSRGB.idl M Source/WebCore/css/typedom/numeric/CSSMathClamp.idl M Source/WebCore/css/typedom/numeric/CSSMathInvert.idl M Source/WebCore/css/typedom/numeric/CSSMathMax.idl M Source/WebCore/css/typedom/numeric/CSSMathMin.idl M Source/WebCore/css/typedom/numeric/CSSMathNegate.idl M Source/WebCore/css/typedom/numeric/CSSMathProduct.idl M Source/WebCore/css/typedom/numeric/CSSMathSum.idl M Source/WebCore/css/typedom/numeric/CSSMathValue.idl M Source/WebCore/css/typedom/numeric/CSSNumericArray.idl M Source/WebCore/css/typedom/numeric/CSSNumericBaseType.idl M Source/WebCore/css/typedom/transform/CSSMatrixComponent.idl M Source/WebCore/css/typedom/transform/CSSPerspective.idl M Source/WebCore/css/typedom/transform/CSSRotate.idl M Source/WebCore/css/typedom/transform/CSSScale.idl M Source/WebCore/css/typedom/transform/CSSSkew.idl M Source/WebCore/css/typedom/transform/CSSSkewX.idl M Source/WebCore/css/typedom/transform/CSSSkewY.idl M Source/WebCore/css/typedom/transform/CSSTransformComponent.idl M Source/WebCore/css/typedom/transform/CSSTransformValue.idl M Source/WebCore/css/typedom/transform/CSSTranslate.idl M Source/WebCore/dom/Element+ComputedStyleMap.idl M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h Log Message: --- Remove CSSTypedOMEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271128 Reviewed by Tim Nguyen. It's been stable for over a year. * LayoutTests/css-typedom/attributeStyleMap.html: * LayoutTests/css-typedom/css-style-value-parse.html: * LayoutTests/css-typedom/sameobject.html: * LayoutTests/fast/css-custom-paint/properties.html: * LayoutTests/fast/css/css-typed-om/style-property-map-set-CSSMathSum-value.html: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSStyleRule.idl: * Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl: * Source/WebCore/css/ElementCSSInlineStyle.idl: * Source/WebCore/css/typedom/CSSKeywordValue.idl: * Source/WebCore/css/typedom/CSSNumericValue.idl: * Source/WebCore/css/typedom/CSSOMVariableReferenceValue.idl: * Source/WebCore/css/typedom/CSSStyleImageValue.idl: * Source/WebCore/css/typedom/CSSStyleValue.idl: * Source/WebCore/css/typedom/CSSUnitValue.idl: * Source/WebCore/css/typedom/CSSUnparsedValue.idl: * Source/WebCore/css/typedom/StylePropertyMap.idl: * Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl: * Source/WebCore/css/typedom/color/CSSColor.idl: * Source/WebCore/css/typedom/color/CSSColorValue.idl: * Source/WebCore/css/typedom/color/CSSHSL.idl: * Source/WebCore/css/typedom/color/CSSHWB.idl: * Source/WebCore/css/typedom/color/CSSLCH.idl: * Source/WebCore/css/typedom/color/CSSLab.idl: * Source/WebCore/css/typedom/color/CSSOKLCH.idl: * Source/WebCore/css/typedom/color/CSSOKLab.idl: * Source/WebCore/css/typedom/color/CSSRGB.idl: * Source/WebCore/css/typedom/numeric/CSSMathClamp.idl: * Source/WebCore/css/typedom/numeric/CSSMathInvert.idl: * Source/WebCore/css/typedom/numeric/CSSMathMax.idl: * Source/WebCore/css/typedom/numeric/CSSMathMin.idl: * Sourc
[webkit-changes] [WebKit/WebKit] 5ded93: [Skia] ImageBufferSkiaAcceleratedBackend should se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ded935fb7008e1b3222f34a9f508a34fa365923 https://github.com/WebKit/WebKit/commit/5ded935fb7008e1b3222f34a9f508a34fa365923 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h Log Message: --- [Skia] ImageBufferSkiaAcceleratedBackend should set RenderingMode as Accelerated https://bugs.webkit.org/show_bug.cgi?id=271149 Reviewed by Alejandro G. Castro. This is used by ImageBuffer on construction to populate ImageBufferBackend::Info. * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.h: Canonical link: https://commits.webkit.org/276265@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e2195: Remove WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e2195e9df0094eda3658fca55540a66b0bf4ae2 https://github.com/WebKit/WebKit/commit/4e2195e9df0094eda3658fca55540a66b0bf4ae2 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: R LayoutTests/animations/animation-css-rule-types-expected.txt R LayoutTests/animations/animation-css-rule-types.html M LayoutTests/animations/change-keyframes-name.html M LayoutTests/animations/change-keyframes.html M LayoutTests/animations/keyframe-autoclose-brace.html M LayoutTests/animations/keyframes-rule-expected.txt M LayoutTests/animations/keyframes-rule.html M LayoutTests/animations/unprefixed-keyframes-rule-expected.txt M LayoutTests/animations/unprefixed-keyframes-rule.html M LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt M LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html M Source/WebCore/css/CSSRule.idl Log Message: --- Remove WEBKIT_KEYFRAMES_RULE and WEBKIT_KEYFRAME_RULE in CSSRule https://bugs.webkit.org/show_bug.cgi?id=170728 rdar://97084520 Reviewed by Tim Nguyen. Chromium removed these in 2017 without fallout and at least judging from GitHub code search, JavaScript code in the wild already accounts for these not existing. The constants are kept around in Source/WebKitLegacy/mac/DOM/DOMCSSRule.h as removing them there is more trouble than it's worth. * LayoutTests/animations/animation-css-rule-types-expected.txt: Removed. * LayoutTests/animations/animation-css-rule-types.html: Removed. * LayoutTests/animations/change-keyframes-name.html: * LayoutTests/animations/change-keyframes.html: * LayoutTests/animations/keyframe-autoclose-brace.html: * LayoutTests/animations/keyframes-rule-expected.txt: * LayoutTests/animations/keyframes-rule.html: * LayoutTests/animations/unprefixed-keyframes-rule-expected.txt: * LayoutTests/animations/unprefixed-keyframes-rule.html: * LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt: * LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html: * Source/WebCore/css/CSSRule.idl: Canonical link: https://commits.webkit.org/276264@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ca594: Remove SubgridEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ca5949f8c61513b7c94fe7ad6d45545c633f2e7 https://github.com/WebKit/WebKit/commit/7ca5949f8c61513b7c94fe7ad6d45545c633f2e7 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/css/parser/CSSParserContext.h M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp Log Message: --- Remove SubgridEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271143 Reviewed by Tim Nguyen. It's been stable for over a year. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::add): * Source/WebCore/css/parser/CSSParserContext.h: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeGridTrackList): Canonical link: https://commits.webkit.org/276263@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] accfe3: Unreviewed. Add Skia reviewers to the watch list
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: accfe39ad62017b79b1741efd264b5e5a9416cf5 https://github.com/WebKit/WebKit/commit/accfe39ad62017b79b1741efd264b5e5a9416cf5 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M .github/CODEOWNERS Log Message: --- Unreviewed. Add Skia reviewers to the watch list * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/276262@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b65e20: [GStreamer] Caps negotiation issue in video encode...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b65e2001a308e3a0a86411c0bf91b802157f934f https://github.com/WebKit/WebKit/commit/b65e2001a308e3a0a86411c0bf91b802157f934f Author: Philippe Normand Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp Log Message: --- [GStreamer] Caps negotiation issue in video encoder for I422 formats https://bugs.webkit.org/show_bug.cgi?id=271110 Reviewed by Xabier Rodriguez-Calvar. The encoder was being configured to convert input buffers to Y422, which is not a valid GStreamer video format. Use I422 instead. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (webkit_video_encoder_class_init): Canonical link: https://commits.webkit.org/276261@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 014919: Remove CSSCustomPropertiesAndValuesEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 014919f9c1daee75dec2ccb53771489899bb0c48 https://github.com/WebKit/WebKit/commit/014919f9c1daee75dec2ccb53771489899bb0c48 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/css-custom-properties-api/crash.html M LayoutTests/css-custom-properties-api/cycles.html M LayoutTests/css-custom-properties-api/inherits.html M LayoutTests/css-custom-properties-api/initialValue.html M LayoutTests/css-custom-properties-api/initialValueJS.html M LayoutTests/css-custom-properties-api/inline.html M LayoutTests/css-custom-properties-api/length.html M LayoutTests/css-custom-properties-api/length2.html M LayoutTests/css-custom-properties-api/registerProperty.html M LayoutTests/fast/css-custom-paint/properties.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl M Source/WebCore/css/DOMCSSNamespace+CSSPropertiesandValues.idl M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h Log Message: --- Remove CSSCustomPropertiesAndValuesEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271126 Reviewed by Tim Nguyen. It's been stable over a year. * LayoutTests/css-custom-properties-api/crash.html: * LayoutTests/css-custom-properties-api/cycles.html: * LayoutTests/css-custom-properties-api/inherits.html: * LayoutTests/css-custom-properties-api/initialValue.html: * LayoutTests/css-custom-properties-api/initialValueJS.html: * LayoutTests/css-custom-properties-api/inline.html: * LayoutTests/css-custom-properties-api/length.html: * LayoutTests/css-custom-properties-api/length2.html: * LayoutTests/css-custom-properties-api/registerProperty.html: * LayoutTests/fast/css-custom-paint/properties.html: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl: * Source/WebCore/css/DOMCSSNamespace+CSSPropertiesandValues.idl: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumePropertyRule): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences CSSCustomPropertiesAndValuesEnabled]): (-[WebPreferences setCSSCustomPropertiesAndValuesEnabled:]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/276260@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e2767: Remove AriaReflectionForElementReferencesEnabled p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e27679dcfcb40158f9237e335ef83052f34e370 https://github.com/WebKit/WebKit/commit/9e27679dcfcb40158f9237e335ef83052f34e370 Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AriaAttributes.idl M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h Log Message: --- Remove AriaReflectionForElementReferencesEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271121 Reviewed by Tim Nguyen. It's been stable for at least a year. * LayoutTests/fast/custom-elements/reactions-for-aria-element-attributes.html: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::addRelation): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::elementsFromAttribute const): * Source/WebCore/accessibility/AriaAttributes.idl: * Source/WebCore/dom/Element.cpp: (WebCore::Element::isElementReflectionAttribute): (WebCore::Element::isElementsArrayReflectionAttribute): (WebCore::Element::attributeChanged): (WebCore::Element::getElementsArrayAttribute const): (WebCore::Element::setElementsArrayAttribute): * Source/WebCore/dom/Element.h: Canonical link: https://commits.webkit.org/276259@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93f630: Add ability to sniff media content should we faile...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93f6303ff83e5c20dbd79f5e6ae7c8a801ee519d https://github.com/WebKit/WebKit/commit/93f6303ff83e5c20dbd79f5e6ae7c8a801ee519d Author: Jean-Yves Avenard Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/http/tests/media/video-throttled-load-metadata-expected.txt M LayoutTests/http/tests/media/video-throttled-load-metadata.html A LayoutTests/media/video-src-mp4-blob-expected.txt A LayoutTests/media/video-src-mp4-blob.html A LayoutTests/media/video-src-webm-blob-expected.txt A LayoutTests/media/video-src-webm-blob.html A LayoutTests/media/video-srcobject-mp4-blob-expected.txt A LayoutTests/media/video-srcobject-mp4-blob.html M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac/TestExpectations M Source/WTF/wtf/NativePromise.h M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/platform/CommonAtomStrings.h M Source/WebCore/platform/ContentType.cpp M Source/WebCore/platform/ContentType.h M Source/WebCore/platform/PlatformMediaError.cpp M Source/WebCore/platform/PlatformMediaError.h A Source/WebCore/platform/graphics/MIMESniffer.cpp A Source/WebCore/platform/graphics/MIMESniffer.h M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h A Source/WebCore/platform/graphics/MediaResourceSniffer.cpp A Source/WebCore/platform/graphics/MediaResourceSniffer.h M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp M Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Tools/TestWebKitAPI/CMakeLists.txt M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj A Tools/TestWebKitAPI/Tests/WebCore/MIMESniffer.cpp Log Message: --- Add ability to sniff media content should we failed to play a file or if the provided content type was invalid. https://bugs.webkit.org/show_bug.cgi?id=270975 rdar://problem/124614908 Reviewed by Jer Noble. We have always relied on the server to provide a valid content-type and if that failed we always used the URL's file name extension instead. While the HTML5 specs clearly states that determining the type of a resource should be done through sniffing, this is however a too significant change to enable right away. There are also performance advantages in using the provided content-type: it's typically immediately available. Should the provided content-type be invalid or non-existent (such as with some blobs) playback would have failed. We add a MIMEtype sniffer for media content as per HTML5 specs. Should we fail to play a media using the older content type detection rather than immediately fail, we will also sniff the type as a last attempt before retrying. In order to not unnecessarily retry following a sniffing, we needed to distinguish a format error from a network error which the MediaPlayerPrivateAVFoundationObjC didn't do. As a fly-by fix, we add a way to distinguish the two errors by recording in the WebCoreNSURLSession any network failures. For now will limit sniffing to media element where the src attribute is set (and so exclude element where alternative sources are defined) Added API tests for the mimetype sniffer and tests for webm and mp4 in a blob. * LayoutTests/media/video-src-mp4-blob-expected.txt: Added. * LayoutTests/media/video-src-mp4-blob.html: Added. * LayoutTests/media/video-src-webm-blob-expected.txt: Added. * LayoutTests/media/video-src-webm-blob.html: Added. * LayoutTests/media/video-srcobject-mp4-blob-expected.txt: Added. * LayoutTests/media/video-srcobject-mp4-blob.html: Added. * LayoutTests/http/tests/media/video-throttled-load-metadata-expected.txt: * LayoutTests/http/tests/media/video-throttled-load-metadata.html: The test was racy and could caused the loadedmetadata message to have been received before the worker's message. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Remove failure expectations. Tests were failing as an incorrect content-type was provided. Now that we sniff if the provided content-type was incorrect files can properly play again. * Source/WTF/wtf/NativePromise.h: * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/HTMLMediaElement.cpp: Move all the logic from MediaPlayer related to guessing
[webkit-changes] [WebKit/WebKit] 670a1d: Remove CSS3DTransformInteroperabilityEnabled prefe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 670a1d8a8f4eb2216584a01ec74b98f9efb1b0da https://github.com/WebKit/WebKit/commit/670a1d8a8f4eb2216584a01ec74b98f9efb1b0da Author: Anne van Kesteren Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/rendering/LayerOverlapMap.cpp M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerBacking.h M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderView.cpp M Source/WebCore/rendering/svg/RenderSVGRoot.cpp M Source/WebCore/rendering/svg/SVGLayerTransformComputation.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm Log Message: --- Remove CSS3DTransformInteroperabilityEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271124 Reviewed by Matt Woodrow. It's been stable for at least a year. The one unfortunate side effect of this patch is that it more clearly highlights that some underlying code continues to branch. Arguably those booleans should be turned into clearly named enum classes. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::copyElementBaseProperties): * Source/WebCore/rendering/LayerOverlapMap.cpp: (WebCore::LayerOverlapMap::LayerOverlapMap): * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState const): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::hitTestList): (WebCore::isHitCandidateLegacy): Deleted. * Source/WebCore/rendering/RenderLayer.h: * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::useCSS3DTransformInteroperability const): Deleted. * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerStyleChanged): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute const): (WebCore::RenderObject::absoluteToLocal const): (WebCore::RenderObject::absoluteToLocalQuad const): (WebCore::RenderObject::shouldUseTransformFromContainer const): (WebCore::RenderObject::getTransformFromContainer const): (WebCore::RenderObject::pushOntoTransformState const): (WebCore::RenderObject::pushOntoGeometryMap const): (WebCore::RenderObject::localToContainerQuad const): (WebCore::RenderObject::localToContainerPoint const): (WebCore::RenderObject::participatesInPreserve3D const): * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer const): (WebCore::RenderView::pushMappingToContainer const): (WebCore::RenderView::mapAbsoluteToLocalPoint const): * Source/WebCore/rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer const): * Source/WebCore/rendering/svg/SVGLayerTransformComputation.h: (WebCore::SVGLayerTransformComputation::computeAccumulatedTransform const): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::createLayer): (WebKit::RemoteLayerTreeHost::css3DTransformInteroperabilityEnabled const): Deleted. Canonical link: https://commits.webkit.org/276257@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9bcc76: Unreviewed. [GTK] Bump version numbers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9bcc76df9f5d94cb122a0afe4ca2d9761f8bb131 https://github.com/WebKit/WebKit/commit/9bcc76df9f5d94cb122a0afe4ca2d9761f8bb131 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/cmake/OptionsGTK.cmake Log Message: --- Unreviewed. [GTK] Bump version numbers * Source/cmake/OptionsGTK.cmake: Canonical link: https://commits.webkit.org/276256@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e5efc: [Skia] Add support for font render properties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e5efc33fac0f5a7214e55db7af541d8f6523260 https://github.com/WebKit/WebKit/commit/1e5efc33fac0f5a7214e55db7af541d8f6523260 Author: Carlos Garcia Campos Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/platform/SourcesCairo.txt M Source/WebCore/platform/SourcesSkia.txt A Source/WebCore/platform/graphics/FontRenderOptions.cpp A Source/WebCore/platform/graphics/FontRenderOptions.h M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp M Source/WebCore/platform/graphics/cairo/CairoUtilities.h A Source/WebCore/platform/graphics/cairo/FontRenderOptionsCairo.cpp M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp M Source/WebCore/platform/graphics/skia/FontPlatformDataSkia.cpp A Source/WebCore/platform/graphics/skia/FontRenderOptionsSkia.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp M Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp Log Message: --- [Skia] Add support for font render properties https://bugs.webkit.org/show_bug.cgi?id=271112 Reviewed by Michael Catanzaro. Set hinting, antialias and pixel geometry. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/platform/SourcesCairo.txt: * Source/WebCore/platform/SourcesSkia.txt: * Source/WebCore/platform/graphics/FontRenderOptions.cpp: Added. (WebCore::FontRenderOptions::singleton): * Source/WebCore/platform/graphics/FontRenderOptions.h: Added. (WebCore::FontRenderOptions::fontOptions const): (WebCore::FontRenderOptions::hinting const): (WebCore::FontRenderOptions::antialias const): (WebCore::FontRenderOptions::subpixelOrder const): * Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: (WebCore::getDefaultCairoFontOptions): (WebCore::defaultCairoFontOptions): Deleted. (WebCore::disableCairoFontHintingForTesting): Deleted. (WebCore::setDefaultCairoHintOptions): Deleted. (WebCore::setDefaultCairoAntialiasOptions): Deleted. * Source/WebCore/platform/graphics/cairo/CairoUtilities.h: * Source/WebCore/platform/graphics/cairo/FontRenderOptionsCairo.cpp: Added. (WebCore::FontRenderOptions::FontRenderOptions): (WebCore::FontRenderOptions::setHinting): (WebCore::FontRenderOptions::setAntialias): (WebCore::FontRenderOptions::setSubpixelOrder): (WebCore::FontRenderOptions::disableHintingForTesting): * Source/WebCore/platform/graphics/skia/FontRenderOptionsSkia.cpp: Added. (WebCore::FontRenderOptions::setHinting): (WebCore::FontRenderOptions::setAntialias): (WebCore::FontRenderOptions::setSubpixelOrder): (WebCore::FontRenderOptions::disableHintingForTesting): * Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp: * Source/WebKit/WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::platformInitializeWebProcess): * Source/WebKit/WebProcess/gtk/GtkSettingsManagerProxy.cpp: (WebKit::GtkSettingsManagerProxy::applyHintingSettings): (WebKit::GtkSettingsManagerProxy::applyAntialiasSettings): Canonical link: https://commits.webkit.org/276255@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3bb34: [Buildstream SDK] Update to latest GTK release
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3bb34488a8354fe384ee361381e25ba7add2bf2 https://github.com/WebKit/WebKit/commit/e3bb34488a8354fe384ee361381e25ba7add2bf2 Author: Philippe Normand Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M Tools/buildstream/elements/sdk/gtk.bst Log Message: --- [Buildstream SDK] Update to latest GTK release https://bugs.webkit.org/show_bug.cgi?id=271129 Reviewed by Adrian Perez de Castro. Update to GTK 4.14.1, required for Epiphany Canary. * Tools/buildstream/elements/sdk/gtk.bst: Canonical link: https://commits.webkit.org/276254@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
