[webkit-changes] [WebKit/WebKit] f3577b: [WebGPU] Textures with size greater than 4096 are ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f3577bf0e0621e26e819f81574c64a363d21db63 https://github.com/WebKit/WebKit/commit/f3577bf0e0621e26e819f81574c64a363d21db63 Author: Mike Wyrzykowski Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/Texture.h M Source/WebGPU/WebGPU/Texture.mm Log Message: --- [WebGPU] Textures with size greater than 4096 are not cleared correctly https://bugs.webkit.org/show_bug.cgi?id=271303 Reviewed by Dan Glastonbury. We can not use 16 bytes for all texture formats since that will copy too many bytes and fail the validation layer for texture widths greater than 4096 when the bytes per pixel is < 16. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::clearTexture): * Source/WebGPU/WebGPU/Texture.h: * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Texture::bytesPerRow): Canonical link: https://commits.webkit.org/276446@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b2297a: Add IPC validation for WebCore::CharacterRange's l...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b2297acef0ca59e3d838412ce6b26a16d19d6f7f https://github.com/WebKit/WebKit/commit/b2297acef0ca59e3d838412ce6b26a16d19d6f7f Author: Wenson Hsieh Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Add IPC validation for WebCore::CharacterRange's length https://bugs.webkit.org/show_bug.cgi?id=271353 Reviewed by Abrar Rahman Protyasha. Protect against overflow when decoding a `CharacterRange` (two `uint64_t`s) by adding a validator that uses `CheckedUint64`. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/276445@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c3b657: [WebGPU] newly added depth comparison tests are fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c3b657ce657a51f76c6ff2afcf38b5dd98c47dcd https://github.com/WebKit/WebKit/commit/c3b657ce657a51f76c6ff2afcf38b5dd98c47dcd Author: Mike Wyrzykowski Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/http/tests/webgpu/common/framework/test_config.js M LayoutTests/http/tests/webgpu/common/internal/query/compare.js M LayoutTests/http/tests/webgpu/common/internal/query/query.js M LayoutTests/http/tests/webgpu/common/internal/test_group.js M LayoutTests/http/tests/webgpu/common/internal/test_suite_listing.js M LayoutTests/http/tests/webgpu/common/internal/version.js M LayoutTests/http/tests/webgpu/common/runtime/helper/options.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker-worker.js M LayoutTests/http/tests/webgpu/common/runtime/helper/test_worker.js A LayoutTests/http/tests/webgpu/common/runtime/helper/utils_worker.js A LayoutTests/http/tests/webgpu/common/runtime/helper/wrap_for_worker.js M LayoutTests/http/tests/webgpu/common/runtime/wpt.js M LayoutTests/http/tests/webgpu/common/util/util.js M LayoutTests/http/tests/webgpu/cts-chunked2sec.https.html M LayoutTests/http/tests/webgpu/cts.https.html M LayoutTests/http/tests/webgpu/resources/cache/hashes.json M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/abs.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/acos.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/acosh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/asin.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/asinh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atan.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atan2.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/atanh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_division.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_logical.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_addition.bin A LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_matrix_multiplication.bin A LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_scalar_multiplication.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_subtraction.bin A LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_matrix_vector_multiplication.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/af_remainder.bin A LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/ai_arithmetic.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/f16_logical.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/f32_logical.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/i32_arithmetic.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/binary/i32_comparison.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/ceil.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/clamp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/cos.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/cosh.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/cross.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/degrees.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/determinant.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/distance.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/dot.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/exp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/exp2.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/faceForward.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/fma.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/frexp.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/inverseSqrt.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/length.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/execution/log.bin M LayoutTests/http/tests/webgpu/resources/cache/webgpu/shader/
[webkit-changes] [WebKit/WebKit] 119a9a: Add more smart pointers to MarkupAccumulator.cpp
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 119a9a97ca3f1c0b1487723b9222f905a97446ce https://github.com/WebKit/WebKit/commit/119a9a97ca3f1c0b1487723b9222f905a97446ce Author: Abigail Fox Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/editing/MarkupAccumulator.cpp Log Message: --- Add more smart pointers to MarkupAccumulator.cpp https://bugs.webkit.org/show_bug.cgi?id=271278 rdar://125044266 Reviewed by Ryosuke Niwa and David Kilzer. * Source/WebCore/editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::replacementElement): (WebCore::MarkupAccumulator::replaceAttributeIfNecessary): (WebCore::MarkupAccumulator::appendURLAttributeForReplacementIfNecessary): Canonical link: https://commits.webkit.org/276443@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 993b0f: Add more smart pointers to accessibility
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 993b0f2b6cd6519ab36bd5a2212029303baa0802 https://github.com/WebKit/WebKit/commit/993b0f2b6cd6519ab36bd5a2212029303baa0802 Author: Abigail Fox Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXGeometryManager.cpp M Source/WebCore/accessibility/AccessibilityList.cpp M Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp Log Message: --- Add more smart pointers to accessibility https://bugs.webkit.org/show_bug.cgi?id=271297 rdar://125063164 Reviewed by Tim Nguyen. * Source/WebCore/accessibility/AXGeometryManager.cpp: (WebCore::AXGeometryManager::scheduleRenderingUpdate): * Source/WebCore/accessibility/AccessibilityList.cpp: (WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers): (WebCore::AccessibilityList::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp: (WebCore::AccessibilityProgressIndicator::valueDescription const): Canonical link: https://commits.webkit.org/276442@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62586e: Garden WPE/GTK /webkit/WebKitWebView/save API test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 62586ecaf74fb950f9d1450f2a8030f739462a34 https://github.com/WebKit/WebKit/commit/62586ecaf74fb950f9d1450f2a8030f739462a34 Author: Lauro Moura Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- Garden WPE/GTK /webkit/WebKitWebView/save API test failure Unreviewed gardening. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/276441@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc4afd: Fix PlayStation build following 276417@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc4afd55e79ab471f49f361a783bf6f8b551c429 https://github.com/WebKit/WebKit/commit/cc4afd55e79ab471f49f361a783bf6f8b551c429 Author: Ross Kirsling Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/wtf/MathExtras.h Log Message: --- Fix PlayStation build following 276417@main https://bugs.webkit.org/show_bug.cgi?id=271352 Unreviewed build fix. PlayStation doesn't currently support std::is_integral, but there's no reason not to use std::is_integral_v anyway. * Source/WTF/wtf/MathExtras.h: (WTF::negate): Replace std::is_integral with std::is_integral_v, as we do elsewhere in the very same file. Canonical link: https://commits.webkit.org/276440@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81451d: REGRESSION (UI-side compositing) changing between ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81451dabde97ba73cbed2abc4c4be64957aa20f6 https://github.com/WebKit/WebKit/commit/81451dabde97ba73cbed2abc4c4be64957aa20f6 Author: Nikolaos Mouchtaris Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A LayoutTests/fast/scrolling/mac/scrollable-area-size-for-overlay-scrollbars-expected.txt A LayoutTests/fast/scrolling/mac/scrollable-area-size-for-overlay-scrollbars.html M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/platform/Scrollbar.cpp M Source/WebCore/platform/Scrollbar.h M Source/WebCore/platform/ScrollbarsController.cpp M Source/WebCore/platform/ScrollbarsController.h M Source/WebCore/platform/mac/ScrollbarsControllerMac.h M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebCore/testing/Internals.mm M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- REGRESSION (UI-side compositing) changing between non-overlay and overlay scrollbars should adjust the size of the scrollable area https://bugs.webkit.org/show_bug.cgi?id=263618 rdar://117507268 Reviewed by Simon Fraser. This patch fixes a couple bugs related to switching back and forth dynamically between overlay and non-overlay scrollbars. First, setFrameScrollingNodeState() was not always called when switching the default, so iterate through each page and call LocalFrameView::overlayScrollbarDefaultDidChange to force a scrolling commit to plumb across this state change. Second, when we get the state change on the ui-process side, we call _updateAllScrollerImpPairsForNewRecommendedScrollerStyle, which notifies all the scroller imp pairs in the process of the new style. On the web process side, we had code to adjust the scrollbar thickness and force a relayout, which now doesn't work since there are no NSScrollerImpPairs in the web process. Instead, replicate this code in RemoteScrollbarsController and loop through the scrollable areas in the FrameView. This takes care of updating scrollable areas with overflow, while https://github.com/WebKit/WebKit/pull/19561 will take care of updating scrollable areas without overflow. Also add some additional testing infrastructure to compare the size of the scrollable area before and after toggling scrollbar style. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::usesOverlayScrollbars const): (WebCore::LocalFrameView::overlayScrollbarDefaultDidChange): * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState): * Source/WebCore/page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::scrollingTreeNodeMarkScrollbarStyleChange): (WebCore::ScrollingTree::scrollingTreeNodesWithScrollbarStyleChange): (WebCore::ScrollingTree::clearScrollingTreeNodesWithScrollbarStyleChange): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp: (WebCore::ScrollingTreeScrollingNode::markHasScrollbarStyleChange): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm: (-[WebScrollerImpPairDelegateMac scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): * Source/WebCore/platform/Scrollbar.cpp: (WebCore::Scrollbar::updateScrollbarThickness): * Source/WebCore/platform/Scrollbar.h: * Source/WebCore/platform/ScrollbarsController.cpp: (WebCore::ScrollbarsController::updateScrollbarsThickness): * Source/WebCore/platform/ScrollbarsController.h: (WebCore::ScrollbarsController::updateScrollerStyle): * Source/WebCore/platform/mac/ScrollbarsControllerMac.h: * Source/WebCore/platform/mac/ScrollbarsControllerMac.mm: (WebCore::ScrollbarsControllerMac::updateScrollerStyle): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::scrollingNodesHaveScrollbarStyleChange): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.h: * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm: (WebKit::RemoteLayerTreeDrawingAreaProxyMac::didCommitLayerTree): * Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrol
[webkit-changes] [WebKit/WebKit] 18d622: [Site Isolation] Begin unskipping tests in http/te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18d622f74a5c75cc26147509a5f85db818e2cf40 https://github.com/WebKit/WebKit/commit/18d622f74a5c75cc26147509a5f85db818e2cf40 Author: Charlie Wolfe Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations Log Message: --- [Site Isolation] Begin unskipping tests in http/tests/security https://bugs.webkit.org/show_bug.cgi?id=271350 Reviewed by Alex Christensen. * LayoutTests/platform/mac-site-isolation/TestExpectations: Canonical link: https://commits.webkit.org/276438@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 09c434: Scoped Arguments needs to alias between named and ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09c434a6e6c752650beb946b01d9894e3212374c https://github.com/WebKit/WebKit/commit/09c434a6e6c752650beb946b01d9894e3212374c Author: Michael Saboff Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A JSTests/stress/arrow-function-captured-arguments-aliased.js M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm M Source/JavaScriptCore/runtime/GetPutInfo.h M Source/JavaScriptCore/runtime/ScopedArguments.cpp M Source/JavaScriptCore/runtime/ScopedArguments.h M Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp M Source/JavaScriptCore/runtime/ScopedArgumentsTable.h M Source/JavaScriptCore/runtime/SymbolTable.h Log Message: --- Scoped Arguments needs to alias between named and unnamed accesses and across nested scopes https://bugs.webkit.org/show_bug.cgi?id=261934 rdar://114925088 rdar://117838992 Reviewed by Yusuke Suzuki. Fixed issue where an access to a named argument and a seperate access via its argument[i] counterpart weren't recognized throughout all JIT tiers as accesses to the same scoped value. The DFG bytecode parser can unknowingly constant fold the read access. Added aliasing via the SymbolTable and its ScopedArgumentsTable for both types of accesses of such values. related objects Added watchpoints for scoped arguments, and shared the watchpoint from the SymbolTableEntry for the named parameter with the ScopedArgument entry for the matching index. Tagged op_put_to_scope bytecodes with a new ScopedArgumentInitialization initialization type in GetPutInfo to signify this shared watchpoint case. Since currently all tiers write to scoped arguments via ScopedArguments::setIndexQuickly(), that is where we fire its watchpoint. Added a new test. * JSTests/stress/arrow-function-captured-arguments-aliased.js: Added. (createOptAll): (createOpt500): (createOpt2000): (createOpt5000): (main): * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::finishCreation): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/GetPutInfo.h: (JSC::initializationModeName): (JSC::isInitialization): * Source/JavaScriptCore/runtime/ScopedArguments.cpp: (JSC::ScopedArguments::unmapArgument): * Source/JavaScriptCore/runtime/ScopedArguments.h: * Source/JavaScriptCore/runtime/ScopedArgumentsTable.cpp: (JSC::ScopedArgumentsTable::tryCreate): (JSC::ScopedArgumentsTable::tryClone): (JSC::ScopedArgumentsTable::trySetLength): (JSC::ScopedArgumentsTable::trySetWatchpointSet): * Source/JavaScriptCore/runtime/ScopedArgumentsTable.h: * Source/JavaScriptCore/runtime/SymbolTable.cpp: (JSC::SymbolTable::cloneScopePart): * Source/JavaScriptCore/runtime/SymbolTable.h: Originally-landed-as: 272448.5@safari-7618-branch (97894699773c). rdar://124557495 Canonical link: https://commits.webkit.org/276437@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 45c98e: [visionOS] Refine MIME Type detection for Image Fu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 45c98e354986bec75c307d9a0c4c29c44b39dd59 https://github.com/WebKit/WebKit/commit/45c98e354986bec75c307d9a0c4c29c44b39dd59 Author: Etienne Segonzac Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- [visionOS] Refine MIME Type detection for Image Fullscreen https://bugs.webkit.org/show_bug.cgi?id=271321 Reviewed by Mike Wyrzykowski. Fall back to generating a MIME Type based on the file extension if the server-sent MIME Type is not a supported image type. Bail out of the Quick Look path is this doesn't work either. * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): Canonical link: https://commits.webkit.org/276436@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d87ff: Further adjustments to the organization storage ac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d87ffb4145cbaff9fc2b97b2bd6d7d2f3dda29a https://github.com/WebKit/WebKit/commit/1d87ffb4145cbaff9fc2b97b2bd6d7d2f3dda29a Author: Matthew Finkel Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.h M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm Log Message: --- Further adjustments to the organization storage access prompt https://bugs.webkit.org/show_bug.cgi?id=271007 rdar://124640260 Reviewed by Wenson Hsieh. After receiving additional feedback, adjust the wording and add a disclosure list. If the list of domains is more than 2, then show the domains in a list via a disclosure button. * Source/WebCore/en.lproj/Localizable.strings: * Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.h: * Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm: (-[_WKSSOSiteList initWithSiteList:withAlert:withTableView:]): (-[_WKSSOSiteList numberOfRowsInTableView:]): (-[_WKSSOSiteList tableView:viewForTableColumn:row:]): (-[_WKSSOSiteList toggleTableViewContents:]): (WebKit::presentStorageAccessAlert): (WebKit::presentStorageAccessAlertQuirk): (WebKit::presentStorageAccessAlertSSOQuirk): (WebKit::displayStorageAccessAlert): Canonical link: https://commits.webkit.org/276435@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a94be: [IFC][Intrinsic width] Disable preferred width com...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a94beca11560b21da9bf685d25f63b23c304332 https://github.com/WebKit/WebKit/commit/9a94beca11560b21da9bf685d25f63b23c304332 Author: Alan Baradlay Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A LayoutTests/fast/inline/replaced-element-with-percent-max-width-in-flexing-container-expected.html A LayoutTests/fast/inline/replaced-element-with-percent-max-width-in-flexing-container.html M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp Log Message: --- [IFC][Intrinsic width] Disable preferred width computation for replaced content with precent max-width https://bugs.webkit.org/show_bug.cgi?id=271339 Reviewed by Simon Fraser. Replaced content with precent max-width needs special preferred-width-computation handling. Let's use legacy codepath for such such content for now. * LayoutTests/fast/inline/replaced-element-with-percent-max-width-in-flexing-container-expected.html: Added. * LayoutTests/fast/inline/replaced-element-with-percent-max-width-in-flexing-container.html: Added. * Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp: (WebCore::LayoutIntegration::canUseForPreferredWidthComputation): Canonical link: https://commits.webkit.org/276434@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c71e10: [UnifiedPDF] PDF flickers/flashes while zooming
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c71e10996782481c1c4e50483cade26d81e001f6 https://github.com/WebKit/WebKit/commit/c71e10996782481c1c4e50483cade26d81e001f6 Author: Simon Fraser Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsLayerClient.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm Log Message: --- [UnifiedPDF] PDF flickers/flashes while zooming https://bugs.webkit.org/show_bug.cgi?id=271292 rdar://122884598 Reviewed by Tim Horton. Change the way we paint the low-resolution page backgrounds so that they reliably appear behind the PDF tiles when zooming. Previously, the page previews were only painted in `AsyncPDFRenderer::paintTilesForPage()` if we'd painted no cached tiles. However, there was no guarantee that the entire rect was covered in cached tile paints, and "leakage" of repaint rects between tiles (because of GraphicsLayerCA-level integral rounding) often resulting in painting some strips of tiles around the edges, but not filling the entire area; this area would remain white (from the white fill painted earlier), hence flashing. Conceptually the page preview needs to appear behind cached tiles, and it's hard to answer the question "have I filled the given rect with tiles" given floating point drawing coordinates. We also want to avoid always painting the page previews behind the tiles, for performance. So instead, display the page previews in the "page background" layers which we already have and currently just provide a white fill. We need draw the page previews only once; we can just scale the page background layers as necessary. To avoid repaints on page scale changes, we need to implement a new GraphicsLayerClient callback that allows us to keep the layer contentsScale fixed. The page background layers, and their associated cache buffers are always sized using `layoutBoundsForPageAtIndex()`, and the buffer scale, and the layer contents scale are determined via `scaleForPagePreviews()`. The white fill behind the full-resolution PDF content is now painted into the cached buffers. * Source/WebCore/platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::customContentsScale const): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateContentsScale): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::paintPagePreviewOnWorkQueue): (WebKit::AsyncPDFRenderer::coverageRectDidChange): (WebKit::AsyncPDFRenderer::paintPDFIntoBuffer): (WebKit::AsyncPDFRenderer::paintTilesForPage): (WebKit::AsyncPDFRenderer::paintPagePreview): (WebKit::AsyncPDFRenderer::updateTilesForPaintingRect): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::updatePageBackgroundLayers): (WebKit::UnifiedPDFPlugin::paintBackgroundLayerForPage): (WebKit::UnifiedPDFPlugin::scaleForPagePreviews const): (WebKit::UnifiedPDFPlugin::didGeneratePreviewForPage): (WebKit::UnifiedPDFPlugin::backgroundLayerForPage const): (WebKit::UnifiedPDFPlugin::pageIndexForPageBackgroundLayer const): (WebKit::UnifiedPDFPlugin::customContentsScale const): (WebKit::UnifiedPDFPlugin::tiledBackingUsageChanged): (WebKit::UnifiedPDFPlugin::didChangeIsInWindow): (WebKit::UnifiedPDFPlugin::paint): (WebKit::UnifiedPDFPlugin::paintContents): (WebKit::UnifiedPDFPlugin::paintPDFContent): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm: (WebKit::PlatformCALayerRemote::create): , Canonical link: https://commits.webkit.org/276433@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6165ff: [JSC] Keep builtin UnlinkedFunctionExecutable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6165ff108d4cb0a08d1989951f6af78efa5644e4 https://github.com/WebKit/WebKit/commit/6165ff108d4cb0a08d1989951f6af78efa5644e4 Author: Yusuke Suzuki Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/JavaScriptCore/builtins/BuiltinExecutables.cpp M Source/JavaScriptCore/builtins/BuiltinExecutables.h M Source/JavaScriptCore/heap/Heap.cpp M Source/JavaScriptCore/runtime/VM.cpp Log Message: --- [JSC] Keep builtin UnlinkedFunctionExecutable https://bugs.webkit.org/show_bug.cgi?id=271324 rdar://125101756 Reviewed by Justin Michaud and Keith Miller. We found that they go away quickly when opening a new iframe etc., and as a result, we may parse and generate code again and again for very popular builtin functions in some cases. Let's keep them in a similar manner to CodeCache. And clear when CodeCache clearing gets requested. * Source/JavaScriptCore/builtins/BuiltinExecutables.cpp: (JSC::BuiltinExecutables::visitAggregateImpl): (JSC::BuiltinExecutables::clear): (JSC::BuiltinExecutables::finalizeUnconditionally): Deleted. * Source/JavaScriptCore/builtins/BuiltinExecutables.h: * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::finalizeUnconditionalFinalizers): * Source/JavaScriptCore/runtime/VM.cpp: (JSC::VM::deleteAllCode): (JSC::VM::visitAggregateImpl): Canonical link: https://commits.webkit.org/276432@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bea525: [WebGPU] https://webgpu.github.io/webgpu-samples/?...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bea525fcbf9e30266d4828e15da7aca0cc6f05e0 https://github.com/WebKit/WebKit/commit/bea525fcbf9e30266d4828e15da7aca0cc6f05e0 Author: Mike Wyrzykowski Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/RenderBundleEncoder.mm M Source/WebGPU/WebGPU/RenderPassEncoder.mm Log Message: --- [WebGPU] https://webgpu.github.io/webgpu-samples/?sample=bundleCulling works without RenderBundles https://bugs.webkit.org/show_bug.cgi?id=270861 Reviewed by Tadeu Zagallo. This patch fixes two issues: (1) RenderBundles which used indirect dispatches did not work due to an early return. (2) setViewport was not called for RenderBundles. Both a relatively small changes. * Source/WebGPU/WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::drawIndexedIndirect): (WebGPU::RenderBundleEncoder::drawIndirect): * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::executeBundles): Canonical link: https://commits.webkit.org/276431@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72a544: Backdrop-filter: blur() with a transparent backdro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72a54445957dedd746d7958426195091e80fe77a https://github.com/WebKit/WebKit/commit/72a54445957dedd746d7958426195091e80fe77a Author: Matt Woodrow Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsLayerClient.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/ca/PlatformCAFilters.h M Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerBacking.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm Log Message: --- Backdrop-filter: blur() with a transparent backdrop renders incorrectly. https://bugs.webkit.org/show_bug.cgi?id=176830 This sets the 'inputNormalizeEdgesTransparent' property on the CoreAnimation blur filter function, required to get correct blur behaviour on the edge of a partially transparent surface. Reviewed by Simon Fraser. I haven't found a good way to test this that isn't super fuzzy unfortunately. This is only enabled when unprefixed backdrop filter is enabled, since it requires a backdrop root (part of unprefixing) to restrict the blur area correctly. * Source/WebCore/platform/graphics/GraphicsLayerClient.h: (WebCore::GraphicsLayerClient::cssUnprefixedBackdropFilterEnabled const): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::platformCALayerCSSUnprefixedBackdropFilterEnabled const): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/ca/PlatformCAFilters.h: * Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h: (WebCore::PlatformCALayerClient::platformCALayerCSSUnprefixedBackdropFilterEnabled const): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm: (WebCore::PlatformCAFilters::setFiltersOnLayer): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::setFilters): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::cssUnprefixedBackdropFilterEnabled const): * Source/WebCore/rendering/RenderLayerBacking.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm: (WebKit::RemoteLayerTreeHost::cssUnprefixedBackdropFilterEnabled const): Canonical link: https://commits.webkit.org/276430@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6491f: [WTF] WTF_ALWAYS_LOG
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6491fe8a5f06df095ea8abaa02ff8ad68c66c63 https://github.com/WebKit/WebKit/commit/f6491fe8a5f06df095ea8abaa02ff8ad68c66c63 Author: Matthieu Dubet Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/wtf/Assertions.h Log Message: --- [WTF] WTF_ALWAYS_LOG https://bugs.webkit.org/show_bug.cgi?id=270115 Reviewed by Simon Fraser. No more "stream <<" typing everytime. * Source/WTF/wtf/Assertions.h: Canonical link: https://commits.webkit.org/276429@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a79ce: Add modified time to webkitbugspy.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a79cecafe05309d0d3308c479fd62be0827809c https://github.com/WebKit/WebKit/commit/7a79cecafe05309d0d3308c479fd62be0827809c Author: Ben Schwartz Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py Log Message: --- Add modified time to webkitbugspy. https://bugs.webkit.org/show_bug.cgi?id=271272 rdar://125039020 Reviewed by Jonathan Bedard. Currently, webkitbugspy does not have a method to retrieve the last modified time of an Issue object. This change adds this information into the Issue object such that it is callable. Added getters/setters for the new modified property: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py Added the new modified property into the mocks: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py Added new webkitbugspy unit tests: * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py Canonical link: https://commits.webkit.org/276428@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db57a9: [iOS] Entering fullscreen from iframe without expl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db57a9aa346bded84559a78247d35ad528795990 https://github.com/WebKit/WebKit/commit/db57a9aa346bded84559a78247d35ad528795990 Author: Jer Noble Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- [iOS] Entering fullscreen from iframe without explicit viewport results in badly cropped video https://bugs.webkit.org/show_bug.cgi?id=270909 rdar://123725878 Reviewed by Eric Carlson. Follow-up fix to 276138@main: resetViewportDefaultConfiguration() will not trigger viewportDidChange(), and therefore calling those methods in that order can leave the calculated viewport in an inconsistent state. Instead, ensure resetViewportDefaultConfiguration() is called before viewportDidChange() by calling isInFullscreenChanged() before willEnterFullscreen(). * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::willEnterFullScreen): Canonical link: https://commits.webkit.org/276427@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc58b4: [view-transitions] Enable by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc58b49dda8876ac9d1170a47df01547b1388b38 https://github.com/WebKit/WebKit/commit/cc58b49dda8876ac9d1170a47df01547b1388b38 Author: Tim Nguyen Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [view-transitions] Enable by default https://bugs.webkit.org/show_bug.cgi?id=269632 rdar://123128491 Reviewed by Simon Fraser. Most demos now function to a decent level as of #26175. Remaining functionality is polish on top of the current work. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/276426@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ffbd39: [WebGPU] MTLResource allocations should be attribu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ffbd3982c707032a0294ce4b63e20169d6400607 https://github.com/WebKit/WebKit/commit/ffbd3982c707032a0294ce4b63e20169d6400607 Author: Mike Wyrzykowski Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] MTLResource allocations should be attributed to the respective web process https://bugs.webkit.org/show_bug.cgi?id=254219 Reviewed by David Kilzer. Fixup bad merge from 276332@main. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/276425@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 057782: Installs sandbox profile correctly for com.apple.W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0577820839eedc6f2d82ca0ed68a3487615f3808 https://github.com/WebKit/WebKit/commit/0577820839eedc6f2d82ca0ed68a3487615f3808 Author: Eddy Wong Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Installs sandbox profile correctly for com.apple.WebKit.Model process rdar://125101800 https://bugs.webkit.org/show_bug.cgi?id=271325 Reviewed by Per Arne Vollan. We were missing a command to copy the built com.apple.WebKit.Model.sb file to the system sandbox profiles folder. So the system never picked it up. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Copies com.apple.WebKit.Model.sb, if it exists, to the sandbox profiles folder. Canonical link: https://commits.webkit.org/276424@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41005c: Support arm64 devices for inline jit toggle api fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41005c9bbd29a09c26fae9fceae8c52a5908da9a https://github.com/WebKit/WebKit/commit/41005c9bbd29a09c26fae9fceae8c52a5908da9a Author: Justin Michaud Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h Log Message: --- Support arm64 devices for inline jit toggle api for testing. https://bugs.webkit.org/show_bug.cgi?id=271256 rdar://124978350 Reviewed by Mark Lam. Support arm64 devices for inline jit toggle api for testing. * Source/WTF/wtf/PlatformUse.h: Canonical link: https://commits.webkit.org/276423@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/tags/wpewebkit-2.44.0 Home: https://github.com/WebKit/WebKit To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e0634: Unreviewed. Update OptionsWPE.cmake and NEWS for t...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 3e0634e4659fd958a262855932379784acfe6022 https://github.com/WebKit/WebKit/commit/3e0634e4659fd958a262855932379784acfe6022 Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/wpe/NEWS M Source/cmake/OptionsWPE.cmake Log Message: --- Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.44.0 release Need the bug URL (OOPS!). * Source/WebKit/wpe/NEWS: Add release notes for 2.44.0. * Source/cmake/OptionsWPE.cmake: Bump version numbers. To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c6ba4e: Update TextCodec::decode() to take in a std::span
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c6ba4e769fb09334ad7f67d6464f37b0beb7055d https://github.com/WebKit/WebKit/commit/c6ba4e769fb09334ad7f67d6464f37b0beb7055d Author: Chris Dumez Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp M Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h M Source/WebCore/PAL/pal/text/TextCodec.cpp M Source/WebCore/PAL/pal/text/TextCodec.h M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp M Source/WebCore/PAL/pal/text/TextCodecCJK.h M Source/WebCore/PAL/pal/text/TextCodecICU.cpp M Source/WebCore/PAL/pal/text/TextCodecICU.h M Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp M Source/WebCore/PAL/pal/text/TextCodecLatin1.h M Source/WebCore/PAL/pal/text/TextCodecReplacement.cpp M Source/WebCore/PAL/pal/text/TextCodecReplacement.h M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp M Source/WebCore/PAL/pal/text/TextCodecSingleByte.h M Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp M Source/WebCore/PAL/pal/text/TextCodecUTF16.h M Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp M Source/WebCore/PAL/pal/text/TextCodecUTF8.h M Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp M Source/WebCore/PAL/pal/text/TextCodecUserDefined.h M Source/WebCore/PAL/pal/text/TextEncoding.cpp M Source/WebCore/PAL/pal/text/TextEncoding.h M Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp M Source/WebCore/PAL/pal/text/win/TextCodecWin.h M Source/WebCore/dom/TextDecoder.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.cpp M Source/WebCore/inspector/agents/InspectorPageAgent.h M Source/WebCore/platform/network/FormData.cpp M Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp M Source/WebCore/platform/win/PasteboardWin.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm M Source/WebKitLegacy/mac/WebView/WebResource.mm M Tools/TestWebKitAPI/Tests/WebCore/TextCodec.cpp Log Message: --- Update TextCodec::decode() to take in a std::span https://bugs.webkit.org/show_bug.cgi?id=271284 Reviewed by Darin Adler. Update TextCodec::decode() to take in a std::span instead of a raw pointer & size. * Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp: (WebCore::CDMSessionClearKey::generateKeyRequest): * Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h: (PAL::URLEscapeSequence::decodeRun): * Source/WebCore/PAL/pal/text/TextCodec.cpp: (PAL::TextCodec::decode): Deleted. * Source/WebCore/PAL/pal/text/TextCodec.h: * Source/WebCore/PAL/pal/text/TextCodecCJK.cpp: (PAL::TextCodecCJK::decodeCommon): (PAL::TextCodecCJK::eucJPDecode): (PAL::TextCodecCJK::iso2022JPDecode): (PAL::TextCodecCJK::shiftJISDecode): (PAL::TextCodecCJK::eucKRDecode): (PAL::TextCodecCJK::gb18030Decode): (PAL::TextCodecCJK::gbkDecode): (PAL::TextCodecCJK::big5Decode): (PAL::TextCodecCJK::decode): * Source/WebCore/PAL/pal/text/TextCodecCJK.h: * Source/WebCore/PAL/pal/text/TextCodecICU.cpp: (PAL::TextCodecICU::decode): * Source/WebCore/PAL/pal/text/TextCodecICU.h: * Source/WebCore/PAL/pal/text/TextCodecLatin1.cpp: (PAL::TextCodecLatin1::decode): * Source/WebCore/PAL/pal/text/TextCodecLatin1.h: * Source/WebCore/PAL/pal/text/TextCodecReplacement.cpp: (PAL::TextCodecReplacement::decode): * Source/WebCore/PAL/pal/text/TextCodecReplacement.h: * Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp: (PAL::decode): (PAL::TextCodecSingleByte::decode): * Source/WebCore/PAL/pal/text/TextCodecSingleByte.h: * Source/WebCore/PAL/pal/text/TextCodecUTF16.cpp: (PAL::TextCodecUTF16::decode): * Source/WebCore/PAL/pal/text/TextCodecUTF16.h: * Source/WebCore/PAL/pal/text/TextCodecUTF8.cpp: (PAL::TextCodecUTF8::decode): * Source/WebCore/PAL/pal/text/TextCodecUTF8.h: * Source/WebCore/PAL/pal/text/TextCodecUserDefined.cpp: (PAL::TextCodecUserDefined::decode): * Source/WebCore/PAL/pal/text/TextCodecUserDefined.h: * Source/WebCore/PAL/pal/text/TextEncoding.cpp: (PAL::TextEncoding::decode const): * Source/WebCore/PAL/pal/text/TextEncoding.h: (PAL::TextEncoding::decode const): * Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp: (PAL::TextCodecWin::decode): * Source/WebCore/PAL/pal/text/win/TextCodecWin.h: * Source/WebCore/dom/TextDecoder.cpp: (WebCore::TextDecoder::decode): * Source/WebCore/inspector/agents/InspectorPageAgent.cpp: (WebCore::decodeBuffer): (WebCore::InspectorPageAgent::mainResourceContent): (WebCore::InspectorPageAgent::sharedBufferContent): (WebCore::InspectorPageAgent::dataContent): * Source/WebCore/inspector/agents/InspectorPageAgent.h: * Source/WebCore/platform/network/FormData.cpp: (WebCore::FormData::flattenToString const): Canonical link: https://commits.webkit.org/276422@main To unsubscribe from these emails, change your notification setti
[webkit-changes] [WebKit/WebKit] b3f5cc: Speedometer 3: buildTransaction spends a lot of ti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3f5ccb38cd2800b166d39aeb366186f94a38f93 https://github.com/WebKit/WebKit/commit/b3f5ccb38cd2800b166d39aeb366186f94a38f93 Author: Matt Woodrow Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.messages.in M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp Log Message: --- Speedometer 3: buildTransaction spends a lot of time destroying mach port objects. https://bugs.webkit.org/show_bug.cgi?id=270549 Reviewed by Kimmo Kinnunen. Flusing a RemoteImageBufferSetProxy waits on both the `didPrepareForDisplay` message to be delivered to the WorkQueue, and the semaphore to be signaled when drawing command flushing is completed. This was previously required, since building of the transaction on the main thread was blocked on the didPrepareForDisplay message, so it was delivered as early as possible. The current state is that all waiting happens on a background thread, so there's no longer any benefit to having two separate notifications. This changes moves sending of the didPrepareForDisplay message to happen once drawing flushing is completed, and removes the seamphore signaling. This should be a small performance win in some cases, since we no longer need to allocate and destroy the semaphore objects. * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: (WebKit::RemoteImageBufferSet::RemoteImageBufferSet): (WebKit::RemoteImageBufferSet::endPrepareForDisplay): (WebKit::RemoteImageBufferSet::ensureBufferForDisplay): (WebKit::RemoteImageBufferSet::setFlushSignal): Deleted. (WebKit::RemoteImageBufferSet::flush): Deleted. * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h: * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::prepareImageBufferSetsForDisplay): (WebKit::RemoteRenderingBackend::prepareImageBufferSetsForDisplaySync): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.cpp: (WebKit::RemoteImageBufferSetProxyFlushFence::create): (WebKit::RemoteImageBufferSetProxyFlushFence::waitFor): (WebKit::RemoteImageBufferSetProxyFlushFence::RemoteImageBufferSetProxyFlushFence): (WebKit::RemoteImageBufferSetProxy::flushFrontBufferAsync): (WebKit::RemoteImageBufferSetProxy::willPrepareForDisplay): (WebKit::RemoteImageBufferSetProxyFlushFence::~RemoteImageBufferSetProxyFlushFence): Deleted. (WebKit::RemoteImageBufferSetProxyFlushFence::tryTakeEvent): Deleted. (WebKit::RemoteImageBufferSetProxyFlushFence::setWaitingForSignal): Deleted. (): Deleted. (WebKit::RemoteImageBufferSetProxy::createFlushFence): Deleted. * Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferSetProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::prepareImageBufferSetsForDisplay): Canonical link: https://commits.webkit.org/276421@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0092ec: [Gardening]: [ MacOS WK1 Debug ] fast/frames/lots-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0092ec090f110aa2be240d13f771bd26edf70fec https://github.com/WebKit/WebKit/commit/0092ec090f110aa2be240d13f771bd26edf70fec Author: Jay Stfleur Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: [ MacOS WK1 Debug ] fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html are consistent/flaky timeouts https://bugs.webkit.org/show_bug.cgi?id=125110638 rdar://125110638 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/276420@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 243400: Add Matthew Finkel as a reviewer in contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 243400dfc4a0c576811cf4410c4ddbc21da39991 https://github.com/WebKit/WebKit/commit/243400dfc4a0c576811cf4410c4ddbc21da39991 Author: Matthew Finkel Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Add Matthew Finkel as a reviewer in contributors.json https://bugs.webkit.org/show_bug.cgi?id=271334 rdar://125110632 Reviewed by Charlie Wolfe. Update my entry with my granted reviewer privileges. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276419@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7cd42a: Regression: Pages that update their title now get ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cd42ac1d51cd7b8c245caf7e61f58173017d7f1 https://github.com/WebKit/WebKit/commit/7cd42ac1d51cd7b8c245caf7e61f58173017d7f1 Author: Chris Dumez Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/UIProcess/ProcessThrottler.cpp M Source/WebKit/UIProcess/ProcessThrottler.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxyInternals.h M Source/WebKit/UIProcess/WebProcessProxy.cpp Log Message: --- Regression: Pages that update their title now get suspended when backgrounded https://bugs.webkit.org/show_bug.cgi?id=270813 rdar://12480 Reviewed by Ben Nham. Pages that update their title now get suspended when backgrounded since we've stopped taking near-suspended assertions on both iOS and macOS. We used to monitor pages in the background for 8 minutes to see if they update their title while in the background, if they did, we would let them keep running in the background. Since we no longer take near-suspended assertions, we can no longer observe pages in the background (since they'd get suspended as soon as backgrounded). To address the issue, we now monitor title changes while in the foreground. If the page updates its title, we now take a background assertion to let it keep running after backgrounding. This is not perfect but this addresses the regression for now. We should revisit though because this is too permissive. Maybe we only want to consider title changes without recent user interaction for e.g. * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::ProcessThrottler): (WebKit::ProcessThrottler::dropNearSuspendedAssertionTimerFired): (WebKit::m_shouldTakeUIBackgroundAssertion): Deleted. (WebKit::ProcessThrottler::pageAllowedToRunInTheBackgroundToken): Deleted. (WebKit::ProcessThrottler::numberOfPagesAllowedToRunInTheBackgroundChanged): Deleted. * Source/WebKit/UIProcess/ProcessThrottler.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::hasAllowedToRunInTheBackgroundActivity const): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::resetStateAfterProcessExited): * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::canBeAddedToWebProcessCache const): Canonical link: https://commits.webkit.org/276418@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f70606: [JSC] Extend JSBigInt::compare and JSBigInt::compa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f706066e1e24e20a84f82374480a7b33e1de2d10 https://github.com/WebKit/WebKit/commit/f706066e1e24e20a84f82374480a7b33e1de2d10 Author: Yijia Huang Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/JSBigInt.cpp M Source/JavaScriptCore/runtime/JSBigInt.h M Source/WTF/wtf/MathExtras.h Log Message: --- [JSC] Extend JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32 https://bugs.webkit.org/show_bug.cgi?id=271073 rdar://124706111 Reviewed by Keith Miller. This patch extends JSBigInt::compare and JSBigInt::compareToDouble for Int64 and Int32. * Source/JavaScriptCore/runtime/JSBigInt.cpp: (JSC::Int64BigIntImpl::Int64BigIntImpl): (JSC::Int64BigIntImpl::isZero): (JSC::Int64BigIntImpl::sign): (JSC::Int64BigIntImpl::length): (JSC::Int64BigIntImpl::digit): (JSC::JSBigInt::compare): (JSC::JSBigInt::compareToDouble): * Source/JavaScriptCore/runtime/JSBigInt.h: Canonical link: https://commits.webkit.org/276417@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d98b64: `--site-isolation` should not run every test as a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d98b641aed396224fa6fdbeb2dbadac07ebfa803 https://github.com/WebKit/WebKit/commit/d98b641aed396224fa6fdbeb2dbadac07ebfa803 Author: Charlie Wolfe Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py Log Message: --- `--site-isolation` should not run every test as a reference test https://bugs.webkit.org/show_bug.cgi?id=271298 rdar://125064104 Reviewed by Pascoe and Alex Christensen. `-—site-isolation` uses `--self-compare-with-header` to compare the output of a test in a cross-origin iframe with and without site isolation enabled. However, `-—self-compare-with-header` will force each test to run as a reference test. For testing site isolation, tests that intend to output and compare text should still do so. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner): (SingleTestRunner._run_self_comparison_without_reference_test): * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options): Canonical link: https://commits.webkit.org/276416@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a907a: Build WebKit process extensions for all SDK variants
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a907ad049edd443daa9236b711db5502ea1d508 https://github.com/WebKit/WebKit/commit/6a907ad049edd443daa9236b711db5502ea1d508 Author: Per Arne Vollan Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/Configurations/BaseExtension.xcconfig Log Message: --- Build WebKit process extensions for all SDK variants https://bugs.webkit.org/show_bug.cgi?id=271315 rdar://125062966 Reviewed by Chris Dumez. * Source/WebKit/Configurations/BaseExtension.xcconfig: Canonical link: https://commits.webkit.org/276415@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 64ea9d: [web-animations] pause animation scheduling while ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 64ea9d3d29ee05ce871c26618b8d340a5a578d28 https://github.com/WebKit/WebKit/commit/64ea9d3d29ee05ce871c26618b8d340a5a578d28 Author: Antoine Quint Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/animation/DocumentTimeline.cpp M Source/WebCore/animation/DocumentTimeline.h M Source/WebCore/animation/WebAnimation.h M Source/WebCore/animation/WebAnimationTypes.h M Source/WebCore/style/StyleTreeResolver.cpp M Source/WebCore/style/Styleable.cpp M Source/WebCore/style/Styleable.h Log Message: --- [web-animations] pause animation scheduling while style-originated animations are being updated https://bugs.webkit.org/show_bug.cgi?id=271311 Reviewed by Dean Jackson. When we will be adding animation support for the `display` property (see bug 267762) we will need to resolve animations even when the underlying style has `display: none` to see whether animations yield a different value. In that process, we may create style-originated animations that will ultimately be canceled once we're certain `display: none` is still set. As it stands, the creation of a style-originated animation will immediately lead to animation scheduling and possibly be observable through Web content by the dispatch of animation events. As such, in preparation for supporting the animation of the `display` property, we now pause animation scheduling while we consider new style-originated animations. We now store new animations that we create in a list as we start the `Style::TreeResolver::createAnimatedElementUpdate()` process and once it completes, provided that list is not empty, we notify the `DocumentTimeline` to schedule animation resolution in a single operation. The purpose of using a list rather than just a boolean flag to signal style-originated animation creation is that, as mentioned above, we will need to silently cancel those newly created animations should the animated style have `display: none`. * Source/WebCore/animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::animationTimingDidChange): (WebCore::DocumentTimeline::styleOriginatedAnimationsWereCreated): * Source/WebCore/animation/DocumentTimeline.h: * Source/WebCore/animation/WebAnimation.h: (WebCore::WebAnimation::isEffectInvalidationSuspended const): (WebCore::WebAnimation::isEffectInvalidationSuspended): Deleted. * Source/WebCore/animation/WebAnimationTypes.h: * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): * Source/WebCore/style/Styleable.cpp: (WebCore::Styleable::updateCSSAnimations const): (WebCore::updateCSSTransitionsForStyleableAndProperty): (WebCore::Styleable::updateCSSTransitions const): * Source/WebCore/style/Styleable.h: Canonical link: https://commits.webkit.org/276414@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a55f23: [WebCodecs] sampleRate and numberOfChannels are re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a55f2304f88ff328ebbad4128ab76ae5a7e8a9ef https://github.com/WebKit/WebKit/commit/a55f2304f88ff328ebbad4128ab76ae5a7e8a9ef Author: Philippe Normand Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl M Source/WebCore/platform/AudioEncoder.h M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp Log Message: --- [WebCodecs] sampleRate and numberOfChannels are required and have to be non-zero in a valid AudioEncoderConfig https://bugs.webkit.org/show_bug.cgi?id=271238 Reviewed by Youenn Fablet. Mark the sampleRate and numberOfChannels fields as required. The isValidAudioDataInit() function already checks they are non-zero. * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp: (WebCore::createAudioEncoderConfig): (WebCore::WebCodecsAudioEncoder::createEncodedChunkMetadata): * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl: * Source/WebCore/platform/AudioEncoder.h: * Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp: (WebCore::GStreamerInternalAudioEncoder::initialize): Canonical link: https://commits.webkit.org/276413@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da50e6: [GStreamer][WebRTC] webrtc/connection-state.html s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da50e63df7f3e6b3090496e1dd8b4221752cdeff https://github.com/WebKit/WebKit/commit/da50e63df7f3e6b3090496e1dd8b4221752cdeff Author: Philippe Normand Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- [GStreamer][WebRTC] webrtc/connection-state.html started failing after update to 1.24.0 https://bugs.webkit.org/show_bug.cgi?id=271243 Reviewed by Xabier Rodriguez-Calvar. The `doneGatheringCandidates()` method is called by the PeerConnectionBackend when it's notified from gst-webrtc that the ICE gathering is finished, so we don't need to call it ourselves. The end-of-candidates SDP attribute shouldn't appear in the offer/answer the end-point reports either. This is covered by the webrtc/libwebrtc/descriptionGetters.html test. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::fetchDescription): (WebCore::GStreamerMediaEndpoint::doSetLocalDescription): (WebCore::GStreamerMediaEndpoint::doSetRemoteDescription): (WebCore::GStreamerMediaEndpoint::onIceCandidate): Canonical link: https://commits.webkit.org/276412@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25189f: Unreviewed. [WPE] Bump version numbers
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25189f590bcbad0daadc6c3ade146d88acc55636 https://github.com/WebKit/WebKit/commit/25189f590bcbad0daadc6c3ade146d88acc55636 Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/cmake/OptionsWPE.cmake Log Message: --- Unreviewed. [WPE] Bump version numbers * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/276411@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fbd093: Unreviewed, reverting 276373@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbd093121b1beaf10159c90404afb7e9e3a325b8 https://github.com/WebKit/WebKit/commit/fbd093121b1beaf10159c90404afb7e9e3a325b8 Author: Commit Queue Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Unreviewed, reverting 276373@main. https://bugs.webkit.org/show_bug.cgi?id=271326 exposed issues with rendering captions Reverted changeset: "[visionOS] Enable Linear Media Player by default" https://bugs.webkit.org/show_bug.cgi?id=271172 https://commits.webkit.org/276373@main Canonical link: https://commits.webkit.org/276410@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 403085: [Gardening]: NEW TEST(276140@main): [ MacOS WK1 De...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 403085294213191abcc77a2bd6c487babb79155c https://github.com/WebKit/WebKit/commit/403085294213191abcc77a2bd6c487babb79155c Author: Jay Stfleur Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: NEW TEST(276140@main): [ MacOS WK1 Debug ] media/media-source/worker/media-managedmse-worker.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=125100787 rdar://125100787 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/276409@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 867737: [Skia] Make GraphicsContextSkia constructor receiv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 867737f23957b13585997afb13f21ebfe1d3be80 https://github.com/WebKit/WebKit/commit/867737f23957b13585997afb13f21ebfe1d3be80 Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h M Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp Log Message: --- [Skia] Make GraphicsContextSkia constructor receive a SkCanvas instead of a SkSurface https://bugs.webkit.org/show_bug.cgi?id=271309 Reviewed by Alejandro G. Castro. For printing we won't have a SkSurface to pass. The constructor now receives a reference to a SkCanvas, so callers need to ensure the canvas will be alive, which is always the case except for ShareableBitmap. For that case we also include an optional destroy notify parameter that is used to release the associated SkSurface when the graphics context is destroyed. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::GraphicsContextSkia): (WebCore::GraphicsContextSkia::hasPlatformContext const): (WebCore::GraphicsContextSkia::getCTM const): (WebCore::GraphicsContextSkia::platformContext const): (WebCore::GraphicsContextSkia::save): (WebCore::GraphicsContextSkia::restore): (WebCore::GraphicsContextSkia::drawRect): (WebCore::GraphicsContextSkia::drawNativeImageInternal): (WebCore::GraphicsContextSkia::drawLine): (WebCore::GraphicsContextSkia::drawEllipse): (WebCore::GraphicsContextSkia::fillPath): (WebCore::GraphicsContextSkia::strokePath): (WebCore::GraphicsContextSkia::fillRect): (WebCore::GraphicsContextSkia::clip): (WebCore::GraphicsContextSkia::clipPath): (WebCore::GraphicsContextSkia::clipBounds const): (WebCore::GraphicsContextSkia::clipToImageBuffer): (WebCore::GraphicsContextSkia::drawDotsForDocumentMarker): (WebCore::GraphicsContextSkia::translate): (WebCore::GraphicsContextSkia::concatCTM): (WebCore::GraphicsContextSkia::setCTM): (WebCore::GraphicsContextSkia::beginTransparencyLayer): (WebCore::GraphicsContextSkia::endTransparencyLayer): (WebCore::GraphicsContextSkia::clearRect): (WebCore::GraphicsContextSkia::strokeRect): (WebCore::GraphicsContextSkia::clipOut): (WebCore::GraphicsContextSkia::rotate): (WebCore::GraphicsContextSkia::scale): (WebCore::GraphicsContextSkia::fillRoundedRectImpl): (WebCore::GraphicsContextSkia::fillRectWithRoundedHole): (WebCore::GraphicsContextSkia::drawPattern): (WebCore::GraphicsContextSkia::canvas const): Deleted. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.cpp: (WebCore::ImageBufferSkiaSurfaceBackend::ImageBufferSkiaSurfaceBackend): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaSurfaceBackend.h: * Source/WebCore/platform/graphics/skia/ImageBufferSkiaUnacceleratedBackend.cpp: (WebCore::ImageBufferSkiaUnacceleratedBackend::create): * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::strokeContains const): (WebCore::PathSkia::strokeBoundingRect const): * Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp: (WebCore::ShareableBitmap::createGraphicsContext): * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): (WebCore::CoordinatedGraphicsLayer::paintImage): * Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp: (WebKit::BackingStore::incorporateUpdate): Canonical link: https://commits.webkit.org/276408@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2c404: Cherry-pick 275480@main (73271df67cec). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: e2c404f16697d8f0022ff1860870a0bc38f2a39a https://github.com/WebKit/WebKit/commit/e2c404f16697d8f0022ff1860870a0bc38f2a39a Author: Lauro Moura Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M Source/WebKit/UIProcess/XR/PlatformXRSystem.h Log Message: --- Cherry-pick 275480@main (73271df67cec). https://bugs.webkit.org/show_bug.cgi?id=270239 (REGRESSION 275453@main) Broke clean cmake builds https://bugs.webkit.org/show_bug.cgi?id=270239 Reviewed by Don Olmstead. Fix entry for file that was moved to cocoa-specific directory. * Source/WebKit/UIProcess/XR/PlatformXRSystem.h: Drive-by non-unified fix that was breaking unified WPE build on flatpak * Source/WebKit/Sources.txt: * Source/WebKit/SourcesCocoa.txt: Canonical link: https://commits.webkit.org/275480@main Commit: ff25d1c79f5d4007c79ed9a351f36f73442d0afc https://github.com/WebKit/WebKit/commit/ff25d1c79f5d4007c79ed9a351f36f73442d0afc Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt M Tools/MiniBrowser/wpe/main.cpp M Tools/wpe/backends/PlatformWPE.cmake M Tools/wpe/backends/ViewBackend.cpp M Tools/wpe/backends/atk/ViewBackendAtk.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.h Log Message: --- Cherry-pick 276392@main (9d2e1868ff2f). https://bugs.webkit.org/show_bug.cgi?id=267508 [WPE] Introduce USE(ATK) https://bugs.webkit.org/show_bug.cgi?id=267508 Reviewed by Michael Catanzaro. ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep accessibility optional in the WPE port. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::View::~View): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/CMakeLists.txt: * Tools/MiniBrowser/wpe/main.cpp: (activate): * Tools/wpe/backends/PlatformWPE.cmake: * Tools/wpe/backends/ViewBackend.cpp: (WPEToolingBackends::ViewBackend::initializeAccessibility): (WPEToolingBackends::ViewBackend::updateAccessibilityState): * Tools/wpe/backends/atk/ViewBackendAtk.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.h: Canonical link: https://commits.webkit.org/276392@main Commit: dba426f3d041a11a99181e7971544b1f387ce9af https://github.com/WebKit/WebKit/commit/dba426f3d041a11a99181e7971544b1f387ce9af Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/Modules/webxr/WebXRLayer.cpp Log Message: --- [WebXR] Fix non-unified build Unreviewed build fix. * Source/WebCore/Modules/webxr/WebXRLayer.cpp: Add missing include. Commit: 09fd3067a8caea5ef3e8038fe9db7854157e96ba https://github.com/WebKit/WebKit/commit/09fd3067a8caea5ef3e8038fe9db7854157e96ba Author: Adrian Perez de Castro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in Log Message: --- [WPE] Fix the build with ENABLE_WPE_PLATFORM=OFF Unreviewed build fix. * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Add guards around parts that depend on the new unreleased platform API. Commit: a97ad1248d0766e63c8bbde79938960f9e38e38f https://github.com/WebKit/WebKit/commit/a97ad1248d0766e63c8bbde79938960f9e38e38f Author: Michael Catanzaro Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/Timer.cpp Log Message: --- Cherry-pick 276282@main (2922af379dc7). https://bugs.webkit.org/show_bug.cgi?id=271108 REGRESSION(274077@main): failure to build on i586 (and likely other 32bit arches): static assertion fail
[webkit-changes] [WebKit/WebKit] 143ff2: [Skia] Implement TestController::takeViewPortSnaps...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 143ff2a9a2aee70e3eb4fb2b8576acabff66c93e https://github.com/WebKit/WebKit/commit/143ff2a9a2aee70e3eb4fb2b8576acabff66c93e Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp M Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp Log Message: --- [Skia] Implement TestController::takeViewPortSnapshot() https://bugs.webkit.org/show_bug.cgi?id=271312 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp: (WTR::TestController::takeViewPortSnapshot): * Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp: (WTR::TestController::takeViewPortSnapshot): Canonical link: https://commits.webkit.org/276407@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ec9483: Update computeHashImpl() to use a span
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ec9483a7d0e3850cee94dd22f1635397c6a1c764 https://github.com/WebKit/WebKit/commit/ec9483a7d0e3850cee94dd22f1635397c6a1c764 Author: Chris Dumez Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/wtf/text/AtomStringImpl.cpp M Source/WTF/wtf/text/StringHash.h M Source/WTF/wtf/text/StringHasher.h M Source/WTF/wtf/text/StringHasherInlines.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/StringView.h M Source/WTF/wtf/text/SuperFastHash.h M Source/WTF/wtf/text/WYHash.h M Source/WebCore/bindings/js/ScriptBufferSourceProvider.h M Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp M Source/WebCore/loader/cache/CachedScript.cpp M Source/WebCore/platform/graphics/WidthCache.h M Tools/TestWebKitAPI/Tests/WTF/StringHasher.cpp M Tools/TestWebKitAPI/Tests/WTF/SuperFastHash.cpp M Tools/TestWebKitAPI/Tests/WTF/WYHash.cpp Log Message: --- Update computeHashImpl() to use a span https://bugs.webkit.org/show_bug.cgi?id=271215 Reviewed by Darin Adler and Sam Weinig. * Source/WTF/wtf/text/AtomStringImpl.cpp: (WTF::SubstringTranslator8::hash): (WTF::SubstringTranslator16::hash): * Source/WTF/wtf/text/StringHash.h: (WTF::ASCIICaseInsensitiveHash::hash): (WTF::HashTranslatorASCIILiteral::hash): * Source/WTF/wtf/text/StringHasher.h: * Source/WTF/wtf/text/StringHasherInlines.h: (WTF::StringHasher::computeHashAndMaskTop8Bits): (WTF::StringHasher::computeLiteralHashAndMaskTop8Bits): (WTF::StringHasher::hashWithTop8BitsMasked): * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::hashSlowCase const): (WTF::StringImpl::concurrentHash const): * Source/WTF/wtf/text/StringImpl.h: (WTF::HashTranslatorCharBuffer::HashTranslatorCharBuffer): (WTF::StringImpl::setHash const): (WTF::StringImpl::assertHashIsCorrect const): * Source/WTF/wtf/text/StringView.h: (WTF::StringView::hash const): * Source/WTF/wtf/text/SuperFastHash.h: (WTF::SuperFastHash::computeHashAndMaskTop8Bits): (WTF::SuperFastHash::computeHash): (WTF::SuperFastHash::computeHashImpl): * Source/WTF/wtf/text/WYHash.h: (WTF::WYHash::computeHashAndMaskTop8Bits): (WTF::WYHash::hash): (WTF::WYHash::computeHashImpl): * Source/WebCore/bindings/js/ScriptBufferSourceProvider.h: * Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash): * Source/WebCore/loader/cache/CachedScript.cpp: (WebCore::CachedScript::script): * Source/WebCore/platform/graphics/WidthCache.h: (WebCore::WidthCache::SmallStringKey::SmallStringKey): Canonical link: https://commits.webkit.org/276406@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d2c1b: [WebGPU] WebGPU: RemoteBuffer::getMappedRange() se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d2c1bf775f993e9f392f00216b08325ee9671b2 https://github.com/WebKit/WebKit/commit/0d2c1bf775f993e9f392f00216b08325ee9671b2 Author: Mike Wyrzykowski Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp Log Message: --- [WebGPU] WebGPU: RemoteBuffer::getMappedRange() sets Write flag unconditionally https://bugs.webkit.org/show_bug.cgi?id=271266 Reviewed by Dan Glastonbury. We should only set the map mode to Write if the buffer was mapped at creation, otherwise we can write to a buffer that was mapped as read only. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp: (WebKit::RemoteBuffer::RemoteBuffer): (WebKit::RemoteBuffer::getMappedRange): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp: (WebKit::WebGPU::RemoteBufferProxy::RemoteBufferProxy): (WebKit::WebGPU::RemoteBufferProxy::getMappedRange): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::createBuffer): Canonical link: https://commits.webkit.org/276405@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81b0d4: ASAN_SEGV | Hard null deref |LayoutIntegration::Bo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81b0d446a83d8bab20a4244d95b8885a53d81ad5 https://github.com/WebKit/WebKit/commit/81b0d446a83d8bab20a4244d95b8885a53d81ad5 Author: Erica Li Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A LayoutTests/fast/inline/sticky-inline-box-invalidation-repaint-crash-expected.txt A LayoutTests/fast/inline/sticky-inline-box-invalidation-repaint-crash.html M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt M Source/WebCore/rendering/RenderInline.cpp Log Message: --- ASAN_SEGV | Hard null deref |LayoutIntegration::BoxTree::layoutBoxForRenderer; LayoutIntegration::LineLayout::enclosingBorderBoxRectFor; WebCore::RenderInline::linesBoundingBox. https://bugs.webkit.org/show_bug.cgi?id=266567. rdar://114586645. Reviewed by Alan Baradlay. similar to 107979394, apply handling for repainting a freshly inserted sticky inline box. * LayoutTests/fast/inline/sticky-inline-box-invalidation-repaint-crash-expected.txt: Added. * LayoutTests/fast/inline/sticky-inline-box-invalidation-repaint-crash.html: Added. * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-002-expected.txt: re-baseline for rdar://119187070. * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox const): Originally-landed-as: 272448.75@safari-7618-branch (2534e02e1983). rdar://124556813 Canonical link: https://commits.webkit.org/276404@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e09543: BBQJIT OSR Entry throws stack overflow from invali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0954318753da3a4c14b63c1a20d36a16c1053b2 https://github.com/WebKit/WebKit/commit/e0954318753da3a4c14b63c1a20d36a16c1053b2 Author: Justin Michaud Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A JSTests/wasm/stress/repro_1289.js A JSTests/wasm/stress/repro_1289.wasm A JSTests/wasm/stress/repro_1289.wat M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.h M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmInstance.h M Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/WasmOperations.h M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp M Source/JavaScriptCore/wasm/WasmThunks.cpp M Source/JavaScriptCore/wasm/WasmThunks.h Log Message: --- BBQJIT OSR Entry throws stack overflow from invalid frame https://bugs.webkit.org/show_bug.cgi?id=268424 rdar://121251778 Reviewed by Yusuke Suzuki. In this test case, we end up in a situation where the current LLInt frame is above the soft stack limit. We then loop osr entry into BBQ, where we perform a stack check and fail, but before we finish writing the OSR entry buffer into our stack frame. The stack unwinder sees the BBQ callee and we jump to that, but the frame is uninitialized. The fix is two fold; we first make BBQ crash in this case to avoid a security issue. We do the same for OMG, just in case this bug is exploitable there too. Second, we do a stack check before performing OSR entry, and fail early. * JSTests/wasm/stress/repro_1289.js: Added. (debuggingHelper): (instantiateJsc): (async let): * JSTests/wasm/stress/repro_1289.wasm: Added. * JSTests/wasm/stress/repro_1289.wat: Added. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::stackCheckSize const): (JSC::Wasm::BBQJIT::addLoopOSREntrypoint): (JSC::Wasm::parseAndCompileBBQ): * Source/JavaScriptCore/wasm/WasmCallee.h: * Source/JavaScriptCore/wasm/WasmInstance.h: (JSC::Wasm::Instance::softStackLimit const): * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/WasmOperations.h: * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): * Source/JavaScriptCore/wasm/WasmThunks.cpp: (JSC::Wasm::crashDueToBBQStackOverflow): * Source/JavaScriptCore/wasm/WasmThunks.h: Originally-landed-as: 272448.466@safari-7618-branch (a08ba6e8c208). rdar://124558656 Canonical link: https://commits.webkit.org/276403@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 983282: [IFC][Ruby] Line spacing is not even for contents ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 983282c29f7dceda11aef7f77a54a0d997f0892a https://github.com/WebKit/WebKit/commit/983282c29f7dceda11aef7f77a54a0d997f0892a Author: Alan Baradlay Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: A LayoutTests/fast/ruby/tight-line-spacing-with-line-height-expected.html A LayoutTests/fast/ruby/tight-line-spacing-with-line-height.html M LayoutTests/platform/ios/TestExpectations M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp Log Message: --- [IFC][Ruby] Line spacing is not even for contents that has ruby https://bugs.webkit.org/show_bug.cgi?id=271295 Reviewed by Antti Koivisto. Let annotation spill into previous/next line's half-leading to keep vertical (horizontal) rhythm (i.e. do not stretch lines with ruby too much even if it means overlapping adjacent line boxes). * LayoutTests/fast/ruby/tight-line-spacing-with-line-height-expected.html: Added. * LayoutTests/fast/ruby/tight-line-spacing-with-line-height.html: Added. * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::adjustLayoutBoundsAndStretchAncestorRubyBase): Canonical link: https://commits.webkit.org/276402@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcddb3: [WTR][Skia] Add support for web contents pixel res...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcddb3eea6b4257f6a974f9f78efdfedf9e68c8f https://github.com/WebKit/WebKit/commit/bcddb3eea6b4257f6a974f9f78efdfedf9e68c8f Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp M Source/WebKit/Shared/API/c/cairo/WKImageCairo.h A Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp A Source/WebKit/Shared/API/c/skia/WKImageSkia.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- [WTR][Skia] Add support for web contents pixel results https://bugs.webkit.org/show_bug.cgi?id=271239 Reviewed by Alejandro G. Castro. Add WKImageSkia with WKImageCreateSkImage() to be used from dumpPixelsAndCompareWithExpected(). * Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp: (WKImageCreateCairoSurface): (WKImageCreateFromCairoSurface): * Source/WebKit/Shared/API/c/cairo/WKImageCairo.h: * Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. (WKImageCreateSkImage): * Source/WebKit/Shared/API/c/skia/WKImageSkia.h: Copied from Source/WebKit/Shared/API/c/cairo/WKImageCairo.h. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: * Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Canonical link: https://commits.webkit.org/276401@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e2652: [GStreamer][WebRTC] Re-enable auto header extensio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e2652f49f822f4a98b9c7f80d22578bd4b9316a https://github.com/WebKit/WebKit/commit/6e2652f49f822f4a98b9c7f80d22578bd4b9316a Author: Philippe Normand Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Re-enable auto header extensions on audio/video RTP payloaders https://bugs.webkit.org/show_bug.cgi?id=271242 Reviewed by Xabier Rodriguez-Calvar. The caps negotiation issues with auto-header-extension enabled seem to have been solved. * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: (WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType): Canonical link: https://commits.webkit.org/276400@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2ec55e: Add unadjustedMovement option to requestPointerLock
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2ec55eb4e151f9387e8becd4bf9a9bbae1a61aef https://github.com/WebKit/WebKit/commit/2ec55eb4e151f9387e8becd4bf9a9bbae1a61aef Author: James Howard Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/fast/js-promise/js-promise-invalid-context-access.html M LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html M LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html M LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_promise-expected.txt A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_promise.html A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_unadjustedMovement-expected.txt A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_unadjustedMovement.html A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_without_gesture-expected.txt A LayoutTests/imported/w3c/web-platform-tests/pointerlock/pointerlock_without_gesture.html A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/pointerlock/pointerlock_unadjustedMovement-expected.txt M LayoutTests/platform/ios/TestExpectations A LayoutTests/platform/mac/pointer-lock/pointer-lock-option-unadjusted-movement-expected.txt M LayoutTests/platform/wpe/TestExpectations M LayoutTests/pointer-lock/lock-element-not-in-dom.html M LayoutTests/pointer-lock/locked-element-removed-from-dom.html A LayoutTests/pointer-lock/pending-locked-element-removed-from-dom-expected.txt A LayoutTests/pointer-lock/pending-locked-element-removed-from-dom.html A LayoutTests/pointer-lock/pointer-lock-option-unadjusted-movement-expected.txt A LayoutTests/pointer-lock/pointer-lock-option-unadjusted-movement.html M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WTF/wtf/PlatformHave.h M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources-input.xcfilelist M Source/WebCore/DerivedSources-output.xcfilelist M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/dom/Element+PointerLock.idl M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h A Source/WebCore/dom/PointerLockOptions.h A Source/WebCore/dom/PointerLockOptions.idl M Source/WebCore/page/PointerLockController.cpp M Source/WebCore/page/PointerLockController.h M Source/WebCore/platform/PlatformMouseEvent.h M Source/WebCore/platform/mac/PlatformEventFactoryMac.h M Source/WebCore/platform/mac/PlatformEventFactoryMac.mm M Source/WebKit/Shared/WebEvent.serialization.in M Source/WebKit/Shared/WebEventConversion.cpp M Source/WebKit/Shared/WebMouseEvent.cpp M Source/WebKit/Shared/WebMouseEvent.h M Source/WebKit/Shared/mac/WebEventFactory.mm M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Add unadjustedMovement option to requestPointerLock https://bugs.webkit.org/show_bug.cgi?id=218054 Reviewed by Simon Fraser and Abrar Rahman Protyasha. This change implements the proposed modifications to the pointerlock spec described in https://github.com/w3c/pointerlock/pull/49/. The new behavior is controlled by the Runtime Flag PointerLockOptionsEnabled. When the flag is set, all WebKit platforms receive the ability to return a promise from requestPointerLock, which can be rejected with DOMExceptions describing why pointer lock couldn't be obtained. On macOS only, all mouse move events are annotated with unaccelerated movement, which is readily available on NSEvent (since macOS 10.15). When unadjustedMovement is requested via PointerLockOptions (and PointerLockOptionsEnabled is set), the unaccelerated values are provided in the movementX/Y attributes on MouseEvents. On other platforms, the promise returned from requestPointerLock can be used to learn that unadjustedMovement is not implemented for them (again, when PointerLockOptionsEnabled is set). When PointerLockOptionsEnabled is not set, requestPointerLock behaves as before: it does not return a promise and any options passed are ignored, meaning accelerated mouse motion will always be provided. * LayoutTests/fast/js-promise/js-promise-invalid-context-access.html: * LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html: * LayoutTests/http/tests/pointer-lock/iframe-sandboxed.html: * LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html: * LayoutTests/pointer-lock/lock-element-not-in-dom.html: * LayoutTests/pointer-lock/locked-element-removed-from-dom.html: Handle promise rejection if returned from requestPointerLock
[webkit-changes] [WebKit/WebKit] f10b74: [GTK][Skia] Implement PlatformWebView::windowSnaps...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f10b743dee70ce8e1a1755f95e7b62a7f0062831 https://github.com/WebKit/WebKit/commit/f10b743dee70ce8e1a1755f95e7b62a7f0062831 Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp Log Message: --- [GTK][Skia] Implement PlatformWebView::windowSnapshotImage() in WTR https://bugs.webkit.org/show_bug.cgi?id=271231 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::viewSnapshot): (WTR::PlatformWebView::windowSnapshotImage): Canonical link: https://commits.webkit.org/276398@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f8535: NEW TEST(275558@main): [ MacOS iOS ] media/now-pla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f8535c34001ddb92fc03e7310aa5889d06d322f https://github.com/WebKit/WebKit/commit/4f8535c34001ddb92fc03e7310aa5889d06d322f Author: Youenn Fablet Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/media/now-playing-webaudio.html Log Message: --- NEW TEST(275558@main): [ MacOS iOS ] media/now-playing-webaudio.html is a flaky failure rdar://124968584 https://bugs.webkit.org/show_bug.cgi?id=271178 Reviewed by Chris Dumez. Some audio nodes maybe collected even if the audio context is rendering. This might change the aduio rendering and the now playing info. Update the test to workaround this until https://bugs.webkit.org/show_bug.cgi?id=271227 is investigated. * LayoutTests/media/now-playing-webaudio.html: Canonical link: https://commits.webkit.org/276397@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a69a0: [view-transitions] Fix white flash on certain demos
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a69a06fefcb4f147bce55072b5346aedc75d170 https://github.com/WebKit/WebKit/commit/1a69a06fefcb4f147bce55072b5346aedc75d170 Author: Tim Nguyen Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation.html M Source/WebCore/dom/Element.h M Source/WebCore/dom/EventTarget.h M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/rendering/RenderElement.cpp Log Message: --- [view-transitions] Fix white flash on certain demos https://bugs.webkit.org/show_bug.cgi?id=270146 rdar://123668861 Reviewed by Matt Woodrow. The white flash was caused by the definition of `RenderElement::capturedInViewTransition` leading to the original element layers being hidden too early before the pseudo-elements are even shown. To fix this, update the definition of capturedInViewTransition to match exactly what the spec specifies: https://drafts.csswg.org/css-view-transitions-1/#ref-for-captured-in-a-view-transition This also ensures that we only move element layers for content that was successfully captured as opposed to anything with a view-transition-name. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/no-white-flash-before-activation.html: Added. * Source/WebCore/dom/Element.h: (WebCore::Element::capturedInViewTransition const): (WebCore::Element::setCapturedInViewTransition): * Source/WebCore/dom/EventTarget.h: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::activateViewTransition): (WebCore::ViewTransition::clearViewTransition): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::capturedInViewTransition const): Canonical link: https://commits.webkit.org/276396@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 326f9e: Remove DeclarativeShadowRootsEnabled preference
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 326f9e3be2e4a266da5362468106c85c14465212 https://github.com/WebKit/WebKit/commit/326f9e3be2e4a266da5362468106c85c14465212 Author: Anne van Kesteren Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/dom/ShadowRoot.idl M Source/WebCore/dom/ShadowRootInit.idl M Source/WebCore/html/HTMLTemplateElement.idl M Source/WebCore/html/parser/HTMLConstructionSite.cpp Log Message: --- Remove DeclarativeShadowRootsEnabled preference https://bugs.webkit.org/show_bug.cgi?id=271237 Reviewed by Ryosuke Niwa. This has been stable for over a year. There might still be some things we need to tweak, but this preference won't help us with that. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/dom/ShadowRoot.idl: * Source/WebCore/dom/ShadowRootInit.idl: * Source/WebCore/html/HTMLTemplateElement.idl: * Source/WebCore/html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLTemplateElement): Canonical link: https://commits.webkit.org/276395@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27beb2: [Skia] Implement PathSkia::applySegments()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27beb283af66084a09a6991dfefdc796dfad17da https://github.com/WebKit/WebKit/commit/27beb283af66084a09a6991dfefdc796dfad17da Author: Pawel Lampe Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/PathImpl.cpp M Source/WebCore/platform/graphics/PathImpl.h M Source/WebCore/platform/graphics/cairo/PathCairo.cpp M Source/WebCore/platform/graphics/cairo/PathCairo.h M Source/WebCore/platform/graphics/cg/PathCG.cpp M Source/WebCore/platform/graphics/cg/PathCG.h M Source/WebCore/platform/graphics/skia/PathSkia.cpp M Source/WebCore/platform/graphics/skia/PathSkia.h Log Message: --- [Skia] Implement PathSkia::applySegments() https://bugs.webkit.org/show_bug.cgi?id=270841 Reviewed by Carlos Garcia Campos. * Source/WebCore/platform/graphics/PathImpl.cpp: (WebCore::PathImpl::applySegments const): * Source/WebCore/platform/graphics/PathImpl.h: * Source/WebCore/platform/graphics/cairo/PathCairo.cpp: (WebCore::PathCairo::applySegments const): Deleted. * Source/WebCore/platform/graphics/cairo/PathCairo.h: * Source/WebCore/platform/graphics/cg/PathCG.cpp: (WebCore::pathSegmentApplierCallback): Deleted. (WebCore::PathCG::applySegments const): Deleted. * Source/WebCore/platform/graphics/cg/PathCG.h: * Source/WebCore/platform/graphics/skia/PathSkia.cpp: (WebCore::PathSkia::applySegments const): Deleted. * Source/WebCore/platform/graphics/skia/PathSkia.h: Canonical link: https://commits.webkit.org/276394@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 129ce1: AXNotification enum ought to be an X macro
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 129ce14b05a4a086cd7ddb915f9ad64c116873aa https://github.com/WebKit/WebKit/commit/129ce14b05a4a086cd7ddb915f9ad64c116873aa Author: Ross Kirsling Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebCore/accessibility/AXLogger.cpp M Source/WebCore/accessibility/AXObjectCache.h Log Message: --- AXNotification enum ought to be an X macro https://bugs.webkit.org/show_bug.cgi?id=270893 Reviewed by Darin Adler. AXNotification is a giant and frequently updated enum. Every time it is updated, exhaustive switch statements must be updated accordingly. This is a very appropriate place for an X macro -- selfishly, it will help PlayStation port avoid build breaks (since we handle this enum in WKAPICast), but irrespective of platform, it also means that AXLogger won't need to be updated each time AXNotification is updated. * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.h: Canonical link: https://commits.webkit.org/276393@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9d2e18: [WPE] Introduce USE(ATK)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9d2e1868ff2f6788291d06b764513846dbc46b8e https://github.com/WebKit/WebKit/commit/9d2e1868ff2f6788291d06b764513846dbc46b8e Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Source/WebKit/PlatformWPE.cmake M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake M Tools/MiniBrowser/wpe/CMakeLists.txt M Tools/MiniBrowser/wpe/main.cpp M Tools/wpe/backends/PlatformWPE.cmake M Tools/wpe/backends/ViewBackend.cpp M Tools/wpe/backends/atk/ViewBackendAtk.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp M Tools/wpe/backends/atk/WebKitAccessibleApplication.h Log Message: --- [WPE] Introduce USE(ATK) https://bugs.webkit.org/show_bug.cgi?id=267508 Reviewed by Michael Catanzaro. ENABLE_ACCESSIBILITY was removed in 273021@main, so add USE_ATK to keep accessibility optional in the WPE port. * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebViewAccessible.h: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::m_backend): (WKWPE::View::~View): * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: (WebKit::WebPageProxy::bindAccessibilityTree): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/MiniBrowser/wpe/CMakeLists.txt: * Tools/MiniBrowser/wpe/main.cpp: (activate): * Tools/wpe/backends/PlatformWPE.cmake: * Tools/wpe/backends/ViewBackend.cpp: (WPEToolingBackends::ViewBackend::initializeAccessibility): (WPEToolingBackends::ViewBackend::updateAccessibilityState): * Tools/wpe/backends/atk/ViewBackendAtk.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.cpp: * Tools/wpe/backends/atk/WebKitAccessibleApplication.h: Canonical link: https://commits.webkit.org/276392@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8dbfd: [WTR][Skia] Draw repaint rects mask
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8dbfdb0176c402869c7bfb0ec6c837d289c79aa https://github.com/WebKit/WebKit/commit/c8dbfdb0176c402869c7bfb0ec6c837d289c79aa Author: Carlos Garcia Campos Date: 2024-03-20 (Wed, 20 Mar 2024) Changed paths: M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- [WTR][Skia] Draw repaint rects mask https://bugs.webkit.org/show_bug.cgi?id=271236 Reviewed by Alejandro G. Castro. * Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Canonical link: https://commits.webkit.org/276391@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
