[webkit-changes] [WebKit/WebKit] fe11bc: Inline box may not be present in the enclosing for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe11bcadadbf8b7ad5f95d337b6842b4b42982ec https://github.com/WebKit/WebKit/commit/fe11bcadadbf8b7ad5f95d337b6842b4b42982ec Author: Alan Baradlay Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/rendering/RenderInline.cpp Log Message: --- Inline box may not be present in the enclosing formatting context https://bugs.webkit.org/show_bug.cgi?id=268525 rdar://119921061 Reviewed by Antti Koivisto. Speculative fix when the (potentially damaged) inline box is not present in the enclosing formatting context. This may happen when RenderInline::linesBoundingBox is called on a dirty tree after moving an inline box () from a block to an other (but before clearing the tree by running layout). * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox const): Originally-landed-as: 272448.456@safari-7618-branch (66b364de9dfc). rdar://124553574 Canonical link: https://commits.webkit.org/276674@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 779251: Complete transition to std::span in CryptoDigest-r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 779251105768188876c269d293475f2a65f2152c https://github.com/WebKit/WebKit/commit/779251105768188876c269d293475f2a65f2152c Author: Brent Fulgham Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/API/JSScript.mm M Source/JavaScriptCore/bytecode/CodeBlockHash.cpp M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp M Source/JavaScriptCore/runtime/CachedBytecode.h M Source/WTF/wtf/SHA1.h M Source/WTF/wtf/persistence/PersistentEncoder.cpp M Source/WTF/wtf/persistence/PersistentEncoder.h M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/PAL/pal/crypto/CryptoDigest.h M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp M Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp M Source/WebCore/css/FontFace.cpp M Source/WebCore/dom/Node.cpp M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/loader/ResourceCryptographicDigest.cpp M Source/WebCore/loader/ResourceCryptographicDigest.h M Source/WebCore/loader/cache/TrustedFonts.cpp M Source/WebCore/loader/cache/TrustedFonts.h M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebCore/storage/StorageUtilities.cpp M Source/WebCore/workers/service/server/SWScriptStorage.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm M Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp M Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp M Tools/TestWebKitAPI/cocoa/HTTPServer.mm M Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp M Tools/WebKitTestRunner/cg/TestInvocationCG.cpp M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- Complete transition to std::span in CryptoDigest-related code https://bugs.webkit.org/show_bug.cgi?id=271488 Reviewed by Chris Dumez and Sihui Liu. Following the changes in Bug 249414 and Bug 271383, complete the work of moving to std::span in CryptoDigest-related code. * Source/JavaScriptCore/API/JSScript.mm: (-[JSScript readCache]): (-[JSScript writeCache:]): * Source/JavaScriptCore/bytecode/CodeBlockHash.cpp: (JSC::CodeBlockHash::CodeBlockHash): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp: (Inspector::backendCommandsHash): * Source/JavaScriptCore/runtime/CachedBytecode.h: (JSC::CachedBytecode::span const): * Source/WTF/wtf/SHA1.h: * Source/WTF/wtf/persistence/PersistentEncoder.cpp: (WTF::Persistence::Encoder::updateChecksumForData): * Source/WTF/wtf/persistence/PersistentEncoder.h: (WTF::Persistence::Encoder::updateChecksumForNumber): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::buildClientDataJsonHash): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::getExpectedWebSocketAccept): * Source/WebCore/PAL/pal/crypto/CryptoDigest.h: (PAL::CryptoDigest::addBytes): Deleted. * Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/css/FontFace.cpp: (WebCore::FontFace::create): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/dom/Node.cpp: (WebCore::hashPointer): * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::createDigest): *
[webkit-changes] [WebKit/WebKit] 20f975: Use std::span more with SharedBuffer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20f975626f24cd2a36d74011d4c6f70a3895feb2 https://github.com/WebKit/WebKit/commit/20f975626f24cd2a36d74011d4c6f70a3895feb2 Author: Chris Dumez Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/FileSystem.h M Source/WTF/wtf/Vector.h M Source/WTF/wtf/posix/FileSystemPOSIX.cpp M Source/WTF/wtf/text/AtomStringImpl.h M Source/WTF/wtf/text/StringCommon.h M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/StringView.h M Source/WTF/wtf/win/FileSystemWin.cpp M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp M Source/WebCore/Modules/cache/DOMCache.cpp M Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp M Source/WebCore/Modules/fetch/FetchResponse.cpp M Source/WebCore/Modules/highlight/AppHighlightRangeData.cpp M Source/WebCore/Modules/mediasource/SourceBuffer.cpp M Source/WebCore/Modules/mediasource/SourceBuffer.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.cpp M Source/WebCore/css/CSSFontFaceSource.cpp M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp M Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp M Source/WebCore/page/ShareDataReader.cpp M Source/WebCore/platform/Decimal.cpp M Source/WebCore/platform/PasteboardCustomData.cpp M Source/WebCore/platform/SharedBuffer.cpp M Source/WebCore/platform/SharedBuffer.h M Source/WebCore/platform/SharedBufferChunkReader.cpp M Source/WebCore/platform/SharedMemory.h M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.h M Source/WebCore/platform/encryptedmedia/CDMProxy.h M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp M Source/WebCore/platform/generic/KeyedEncoderGeneric.cpp M Source/WebCore/platform/glib/KeyedEncoderGlib.cpp M Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.h M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm M Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp M Source/WebCore/platform/graphics/gtk/ImageAdapterGtk.cpp M Source/WebCore/platform/image-decoders/ico/ICOImageDecoder.cpp M Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp M Source/WebCore/platform/network/BlobResourceHandle.cpp M Source/WebCore/platform/network/BlobResourceHandle.h M Source/WebCore/platform/network/FormDataBuilder.cpp M Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp M Source/WebCore/testing/MockCDMFactory.cpp M Source/WebCore/testing/MockContentFilter.cpp M Source/WebCore/workers/ScriptBuffer.cpp M Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp M Source/WebKit/GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.h M Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp M Source/WebKit/Shared/WebCompiledContentRuleList.cpp M Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/gtk/DropTargetGtk3.cpp M Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm M Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp M Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp M Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMSession.cpp M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp M Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp M Tools/TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm Log Message: --- Use std::span more with SharedBuffer https://bugs.webkit.org/show_bug.cgi?id=271534
[webkit-changes] [WebKit/WebKit] dc3b49: Remove Quirk needsAnchorElementsToBeMouseFocusable...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc3b492a8ef1398738518cf3b412320c50761eb9 https://github.com/WebKit/WebKit/commit/dc3b492a8ef1398738518cf3b412320c50761eb9 Author: Karl Dubost Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Remove Quirk needsAnchorElementsToBeMouseFocusable for vote.gov https://bugs.webkit.org/show_bug.cgi?id=271213 rdar://124987798 Reviewed by Chris Dumez and Aditya Keerthi. After testing, this quirk is not necessary anymore. The selection of states redirect correctly to the right URI. It was added on rdar://121240580 https://bugs.webkit.org/show_bug.cgi?id=267779 * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable const): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::needsAnchorElementsToBeMouseFocusable const): Deleted. * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/276671@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 645818: [Remote Inspection] Element targeting should addit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6458185c5c4dad377eeb25a81f4f85bbb4c3db97 https://github.com/WebKit/WebKit/commit/6458185c5c4dad377eeb25a81f4f85bbb4c3db97 Author: Wenson Hsieh Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/page/ElementTargeting.cpp M Source/WebCore/page/ElementTargetingTypes.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/APITargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm A Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-2.html Log Message: --- [Remote Inspection] Element targeting should additionally find nearby out-of-flow elements https://bugs.webkit.org/show_bug.cgi?id=271616 Reviewed by Abrar Protyasha. When targeting elements for remote inspection, additionally surface nearby elements which aren't precisely under the hit test location. Our strategy for this consists of the following: 1. While collecting targets, aggregate a `Region` containing the rects of all targeted out-of-flow elements (and hit-tested elements underneath targeted elements). 2. After building the list of targets, scan the entire DOM for out-of-flow renderers that are also contained in the "nearby targets" region, which also satisfy the same criteria for element targeting. 3. Add these as "nearby targets" to the final list of target infos, to the end of the array. See below for more details. Test: ElementTargeting.NearbyOutOfFlowElements * Source/WebCore/page/ElementTargeting.cpp: (WebCore::targetedElementInfo): Refactor this code to pull common logic into lambdas, and implement the steps detailed above. (WebCore::findTargetedElements): * Source/WebCore/page/ElementTargetingTypes.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/APITargetedElementInfo.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _requestTargetedElementInfo:completionHandler:]): * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h: Add a new `isUnderPoint` property, which is `YES` for elements that are directly hit-tested, and `NO` for nearby targets. * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm: (-[_WKTargetedElementInfo isUnderPoint]): * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.h: Add a new `canIncludeNearbyElements` (default: `YES`) which determines whether or not element targeting should include elements that have not been hit-tested, but are visually contained within another element that has been hit-tested. * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementRequest.mm: (-[_WKTargetedElementRequest init]): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-2.html: Added. Add a new API test to exercise the change. Canonical link: https://commits.webkit.org/276670@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20f030: [Site Isolation] Begin unskipping tests in fast/lo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20f030dd8d0e9b16512d6f3699c4a90187865c42 https://github.com/WebKit/WebKit/commit/20f030dd8d0e9b16512d6f3699c4a90187865c42 Author: Charlie Wolfe Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations Log Message: --- [Site Isolation] Begin unskipping tests in fast/loader https://bugs.webkit.org/show_bug.cgi?id=271687 Unreviewed. * LayoutTests/platform/mac-site-isolation/TestExpectations: Canonical link: https://commits.webkit.org/276669@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c52499: AX: Assert crash in [WebAccessibilityObjectWrapper...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c5249991fba8d30b23b5c8449efd3f0686728d01
https://github.com/WebKit/WebKit/commit/c5249991fba8d30b23b5c8449efd3f0686728d01
Author: Andres Gonzalez
Date: 2024-03-25 (Mon, 25 Mar 2024)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
Log Message:
---
AX: Assert crash in [WebAccessibilityObjectWrapper
accessibilityPresenterProcessIdentifier].
https://bugs.webkit.org/show_bug.cgi?id=271652
Reviewed by Chris Fleizach.
Partial revert of https://bugs.webkit.org/show_bug.cgi?id=270866 (276073@main).
We are hitting the following assert on launch if VoiceOver is running:
int presentingApplicationPID()
{
const auto& pid = presentingApplicationPIDOverride();
ASSERT(!pid || RunLoop::isMain());
...
This patch reverts getting the process ID in the wrapper from the cached value
in the AXIsolatedTree as it was before the above change.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::treeID const):
(WebCore::AXIsolatedTree::processID const):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityPresenterProcessIdentifier]):
Canonical link: https://commits.webkit.org/276668@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3219d4: [Gardening]: [ iOS ] imported/w3c/web-platform-tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3219d458f747335e24cc58bdb659ad10e645a3b2 https://github.com/WebKit/WebKit/commit/3219d458f747335e24cc58bdb659ad10e645a3b2 Author: Jay Stfleur Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: [ iOS ] imported/w3c/web-platform-tests/css/css-content/quotes-007.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=125381669 rdar://125381669 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276667@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e1d49: REGRESSION (272891@main): [ Sonoma wk1 ] css3/filt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e1d49a57856d28899c09cdf6a1fc8ea8d14fb11 https://github.com/WebKit/WebKit/commit/6e1d49a57856d28899c09cdf6a1fc8ea8d14fb11 Author: Said Abou-Hallawa Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/css3/filters/effect-sepia-square-expected.html M LayoutTests/css3/filters/effect-sepia-square.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- REGRESSION (272891@main): [ Sonoma wk1 ] css3/filters/effect-sepia-square.html is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=271479 rdar://125249572 [Filters] Unreviewed test gardening. Adjust the pixel tolerance of this test. There is only 1/255 difference between the RGB channels of the result from those of the the expected. * LayoutTests/css3/filters/effect-sepia-square-expected.html: * LayoutTests/css3/filters/effect-sepia-square.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/27@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ef59cf: [Site Isolation] Frame removal notifications can c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ef59cf8e34cc7db2ffdd07cf2bb7b8640c353b43 https://github.com/WebKit/WebKit/commit/ef59cf8e34cc7db2ffdd07cf2bb7b8640c353b43 Author: Charlie Wolfe Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/html/HTMLFrameOwnerElement.cpp M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyFrameLoaderClient.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebCore/page/RemoteFrameClient.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h Log Message: --- [Site Isolation] Frame removal notifications can complete before the frame is removed https://bugs.webkit.org/show_bug.cgi?id=271666 rdar://125367065 Reviewed by Alex Christensen. When we broadcast the removal of a frame, it's possible to receive a `DidDestroyFrame` message from a process we are notifying about the frame's removal before receiving it from the process that actually initiated the removal. To avoid this race, we should not broadcast frame removal until the frame has actually been destroyed. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::disconnectContentFrame): * Source/WebCore/loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebCore/loader/EmptyFrameLoaderClient.h: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/page/Frame.h: * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebCore/page/RemoteFrame.h: * Source/WebCore/page/RemoteFrameClient.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didDestroyFrame): (WebKit::WebPageProxy::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didDestroyFrame): * Source/WebKit/UIProcess/WebProcessProxy.h: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::broadcastFrameRemovalToOtherProcesses): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: Canonical link: https://commits.webkit.org/276665@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7c317: Drop `StringView(const char*, unsigned)` constructor
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7c31722d07633238c955129129f97d0739ae05b https://github.com/WebKit/WebKit/commit/e7c31722d07633238c955129129f97d0739ae05b Author: Chris Dumez Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/IntlLocale.cpp M Source/JavaScriptCore/runtime/IntlObject.cpp M Source/WTF/wtf/text/StringView.h M Source/WTF/wtf/text/WTFString.h M Source/WebCore/html/FTPDirectoryDocument.cpp M Source/WebCore/loader/FTPDirectoryParser.h M Source/WebCore/platform/Decimal.cpp M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp M Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.cpp M Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp M Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp M Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerQuirks.cpp M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp M Source/WebCore/platform/network/HTTPHeaderMap.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm Log Message: --- Drop `StringView(const char*, unsigned)` constructor https://bugs.webkit.org/show_bug.cgi?id=271619 Reviewed by Darin Adler and Brent Fulgham. Drop `StringView(const char*, unsigned)` constructor, in favor of the one taking in a span. * Source/JavaScriptCore/runtime/IntlLocale.cpp: (JSC::LocaleIDBuilder::overrideLanguageScriptRegion): * Source/JavaScriptCore/runtime/IntlObject.cpp: (JSC::canonicalizeUnicodeExtensionsAfterICULocaleCanonicalization): * Source/WTF/wtf/text/StringView.h: (WTF::emptyStringView): * Source/WebCore/html/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine): * Source/WebCore/platform/Decimal.cpp: (WebCore::Decimal::fromDouble): * Source/WebCore/platform/graphics/cocoa/AudioTrackPrivateWebM.cpp: (WebCore::AudioTrackPrivateWebM::codec const): * Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp: (WebCore::WebMParser::OnTrackEntry): * Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp: (WebCore::VideoTrackPrivateWebM::codec const): * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp: (WebCore::toRTCRtpCapabilities): * Source/WebCore/platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::set): Canonical link: https://commits.webkit.org/276664@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6aefea: Use NodeName and Namespace in CSS JIT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6aefea97977e9843bddcd473b491014f7622795e https://github.com/WebKit/WebKit/commit/6aefea97977e9843bddcd473b491014f7622795e Author: Yusuke Suzuki Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/assembler/MacroAssembler.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h M Source/WTF/wtf/PlatformEnable.h M Source/WebCore/cssjit/RegisterAllocator.h M Source/WebCore/cssjit/SelectorCompiler.cpp M Source/WebCore/dom/QualifiedName.h Log Message: --- Use NodeName and Namespace in CSS JIT https://bugs.webkit.org/show_bug.cgi?id=267671 rdar://121167170 Reviewed by Ryosuke Niwa and Justin Michaud. 1. Use NodeName in CSS JIT code generation. This is more efficient and we can reduce code size. 2. Drop Darwin ARMv7 CSS JIT since it is no longer used. 3. We adjust registers so that this patch removes weird configuration of Assemblers in CSS JIT (what registers are reserved etc.). * Source/JavaScriptCore/assembler/MacroAssembler.h: (JSC::MacroAssembler::patchableBranch16): * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::branch16): (JSC::MacroAssemblerARM64::patchableBranch16): * Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::branch16): (JSC::MacroAssemblerARMv7::patchableBranch16): * Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h: (JSC::MacroAssemblerRISCV64::branch16): * Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branch8): * Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::branch16): * Source/WTF/wtf/PlatformEnable.h: * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching): (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName): * Source/WebCore/dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::namespaceMemoryOffset): (WebCore::QualifiedName::QualifiedNameImpl::nodeNameMemoryOffset): (WebCore::QualifiedName::QualifiedNameImpl::namespaceURIMemoryOffset): Canonical link: https://commits.webkit.org/276663@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 508e18: Fix "use-after-free" warning in WebCore/page/Navig...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 508e1805310e8f0136a08d4449bc3b23720a6ecc https://github.com/WebKit/WebKit/commit/508e1805310e8f0136a08d4449bc3b23720a6ecc Author: Patrick Griffis Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/page/NavigateEvent.cpp M Source/WebCore/page/NavigateEvent.h M Source/WebCore/page/Navigation.cpp Log Message: --- Fix "use-after-free" warning in WebCore/page/Navigation.cpp with GCC 12 https://bugs.webkit.org/show_bug.cgi?id=271648 Reviewed by Michael Catanzaro. GCC hits a bug with copying this RefPtr by value for some reason. This should never have been passed by value anyway and since it doesn't take ownership should have been passed by a raw pointer. * Source/WebCore/page/NavigateEvent.cpp: (WebCore::NavigateEvent::NavigateEvent): (WebCore::NavigateEvent::create): * Source/WebCore/page/NavigateEvent.h: * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): Canonical link: https://commits.webkit.org/276662@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0845c: Expose model entity transform to JS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0845c44e6b01ab1d954725d84b6423ff499d075 https://github.com/WebKit/WebKit/commit/f0845c44e6b01ab1d954725d84b6423ff499d075 Author: Eddy Wong Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/Modules/model-element/HTMLModelElement.cpp M Source/WebCore/Modules/model-element/HTMLModelElement.h M Source/WebCore/Modules/model-element/HTMLModelElement.idl M Source/WebCore/Modules/model-element/ModelPlayer.cpp M Source/WebCore/Modules/model-element/ModelPlayer.h M Source/WebCore/Modules/model-element/ModelPlayerClient.h M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/platform/graphics/cocoa/TransformationMatrixCocoa.cpp M Source/WebCore/platform/graphics/transforms/TransformationMatrix.h M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in M Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h M Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in Log Message: --- Expose model entity transform to JS rdar://124986396 https://bugs.webkit.org/show_bug.cgi?id=271208 Reviewed by Alex Christensen. Exposes the root entity transform matrix to JS side, so that developers can move the 3D object around within the tag portal. HTMLModelTag has an m_entityTransform "truth" that's used to serve JS getter synchronously. ModelPlayer now has the ability to determine whether a certain transform matrix is supported. If not, HTMLModelElement::setEntityTransform will raise an Unsupported Exception. Upon model load, Model Process will send an IPC message to Web Process to update the m_entityTransform state of the HTMLModelElement to make it aware of the default applied transform. * Source/WebCore/Modules/model-element/HTMLModelElement.cpp: (WebCore::HTMLModelElement::modelPlayer const): (WebCore::HTMLModelElement::entityTransform const): * Source/WebCore/Modules/model-element/HTMLModelElement.h: * Source/WebCore/Modules/model-element/HTMLModelElement.idl: * Source/WebCore/Modules/model-element/ModelPlayer.cpp: (WebCore::ModelPlayer::entityTransform): (WebCore::ModelPlayer::setEntityTransform): (WebCore::ModelPlayer::supportsTransform): * Source/WebCore/Modules/model-element/ModelPlayer.h: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/cocoa/TransformationMatrixCocoa.cpp: (WebCore::TransformationMatrix::TransformationMatrix): (WebCore::TransformationMatrix::operator simd_float4x4 const): Added convenience converter methods to/from simd_float4x4, which is the commonly used transform matrix data type on visionOS. Applicable only on Cocoa platforms. * Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.h: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.messages.in: * Source/WebKit/ModelProcess/cocoa/ModelProcessModelPlayerProxy.mm: (WebKit::ModelProcessModelPlayerProxy::transformSupported): Require the transform to be a non-shear, uniform-scaling matrix, for now. (WebKit::ModelProcessModelPlayerProxy::computeTransform): (WebKit::ModelProcessModelPlayerProxy::updateTransform): (WebKit::ModelProcessModelPlayerProxy::didFinishLoading): (WebKit::ModelProcessModelPlayerProxy::entityTransform): (WebKit::ModelProcessModelPlayerProxy::setEntityTransform): * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.cpp: (WebKit::ModelProcessModelPlayer::didUpdateEntityTransform): (WebKit::ModelProcessModelPlayer::entityTransform): (WebKit::ModelProcessModelPlayer::setEntityTransform): (WebKit::ModelProcessModelPlayer::supportsTransform): * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.h: * Source/WebKit/WebProcess/Model/ModelProcessModelPlayer.messages.in: Canonical link: https://commits.webkit.org/276661@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c69db: Remote worker processes may not obey the lockdown ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c69db119e4e166af7a2412338314d58d68b76fa https://github.com/WebKit/WebKit/commit/1c69db119e4e166af7a2412338314d58d68b76fa Author: Chris Dumez Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm M Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/UIProcess/WebProcessPool.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebProcessProxy.h M Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp M Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm Log Message: --- Remote worker processes may not obey the lockdown mode setting https://bugs.webkit.org/show_bug.cgi?id=268183 rdar://121617300 Reviewed by Youenn Fablet. Make sure we carry over the requesting process' lockdown mode state to the newly created process when we decide to launch a remote worker process. Also make sure that the settings that are meant to be disabled in lockdown mode also get disabled in the remote worker contexts, not just in page/window contexts. * Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _isJITDisabledInAllServiceWorkerProcesses:]): * Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess): (WebKit::WebProcessPool::isJITDisabledInAllServiceWorkerProcesses const): * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createForRemoteWorkers): * Source/WebKit/UIProcess/WebProcessProxy.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Originally-landed-as: 272448.386@safari-7618-branch (dd435ec50671). rdar://124554815 Canonical link: https://commits.webkit.org/276660@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f8703: Unreviewed, reverting 276651@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f8703729179eec8914a5cdc960b14a9f0750be5 https://github.com/WebKit/WebKit/commit/4f8703729179eec8914a5cdc960b14a9f0750be5 Author: Marta Darbinyan Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/spi/darwin/AbortWithReasonSPI.h M Source/WebCore/PAL/Configurations/PAL.xcconfig M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj R Source/WebCore/PAL/pal/PALSwift.h M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift R Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift R Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp A Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm R Source/WebCore/PAL/pal/module.modulemap M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp A Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.mm R Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp A Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.mm M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp M Tools/Scripts/swift/.swift-format Log Message: --- Unreviewed, reverting 276651@main rdar://125378502 Breaking the builds Reverted change: Introducing C++ Swift Interop https://bugs.webkit.org/show_bug.cgi?id=271263 rdar://123331949 https://commits.webkit.org/276651@main Canonical link: https://commits.webkit.org/276659@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 443e08: Synchronize WPT interfaces partially
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 443e0896e6d51e7e755786265e6ff447a63a595a https://github.com/WebKit/WebKit/commit/443e0896e6d51e7e755786265e6ff447a63a595a Author: Anne van Kesteren Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.serviceworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.sharedworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/dom/idlharness.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/encoding/idlharness.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/encoding/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/idlharness.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/idlharness.any.serviceworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/idlharness.any.sharedworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fetch/api/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/fs/idlharness.https.any.worker-expected.txt R LayoutTests/imported/w3c/web-platform-tests/interfaces/OWNERS R LayoutTests/imported/w3c/web-platform-tests/interfaces/ResizeObserver.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/WebCryptoAPI.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/console.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/dom.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/encoding.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/fetch.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/fs.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/hr-time.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/notifications.idl R LayoutTests/imported/w3c/web-platform-tests/interfaces/origin-policy.idl R LayoutTests/imported/w3c/web-platform-tests/interfaces/pointerevents-extension.idl R LayoutTests/imported/w3c/web-platform-tests/interfaces/remoteplayback.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/reporting.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/requestidlecallback.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/resize-observer.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/service-workers.idl R LayoutTests/imported/w3c/web-platform-tests/interfaces/storage-buckets.tentative.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/streams.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/ua-client-hints.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/uievents.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/url.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/wai-aria.idl M LayoutTests/imported/w3c/web-platform-tests/interfaces/xhr.idl M LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any.serviceworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any.sharedworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/service-workers/idlharness.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.serviceworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.sharedworker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/streams/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/uievents/idlharness.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/idlharness.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/url/idlharness.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/wai-aria/idlharness.window-expected.txt Log Message: --- Synchronize WPT interfaces partially https://bugs.webkit.org/show_bug.cgi?id=271639 Reviewed by Darin Adler. Updates the IDL of various standards up to this commit: https://github.com/web-platform-tests/wpt/commit/cea69e33dac7011aeda11cb114ce58e283e0ffe2 * LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/idlharness.https.any-expected.txt: *
[webkit-changes] [WebKit/WebKit] 4f7cc3: [Gardening]: [ iOS ] imported/w3c/web-platform-tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f7cc3574b9b22319a1487cf8b709a27b48dc833 https://github.com/WebKit/WebKit/commit/4f7cc3574b9b22319a1487cf8b709a27b48dc833 Author: Jay Stfleur Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: [ iOS ] imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unrelated-element.html is a consistent image failure https://bugs.webkit.org/show_bug.cgi?id=125375879 rdar://125375879 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276657@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1614b: Implement URL.parse()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1614bd8c992e7e6e162fff5143f3a4932226ae5 https://github.com/WebKit/WebKit/commit/e1614bd8c992e7e6e162fff5143f3a4932226ae5 Author: Anne van Kesteren Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any-expected.txt A LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.html A LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.js A LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker.html M LayoutTests/imported/w3c/web-platform-tests/url/w3c-import.log M Source/WebCore/html/DOMURL.cpp M Source/WebCore/html/DOMURL.h M Source/WebCore/html/DOMURL.idl Log Message: --- Implement URL.parse() https://bugs.webkit.org/show_bug.cgi?id=271636 Reviewed by Alex Christensen. This was standardized in https://github.com/whatwg/url/pull/825 and test coverage was added here: https://github.com/web-platform-tests/wpt/pull/45248 As a drive-by fix we remove m_baseURL from DOMURL as it does not need it. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.html: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.js: Added. (forEach): (test): * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-parse.any.worker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/url/w3c-import.log: * Source/WebCore/html/DOMURL.cpp: (WebCore::DOMURL::DOMURL): (WebCore::DOMURL::create): (WebCore::parseInternal): (WebCore::DOMURL::parse): (WebCore::DOMURL::canParse): * Source/WebCore/html/DOMURL.h: * Source/WebCore/html/DOMURL.idl: Canonical link: https://commits.webkit.org/276656@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 926a35: [ews-build.webkit.org] Add jsc-armv7 to Linux checks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 926a356211ea6a9125eb272a82f16e681b24616e https://github.com/WebKit/WebKit/commit/926a356211ea6a9125eb272a82f16e681b24616e Author: Jonathan Bedard Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Tools/CISupport/ews-build/steps.py Log Message: --- [ews-build.webkit.org] Add jsc-armv7 to Linux checks https://bugs.webkit.org/show_bug.cgi?id=271647 rdar://125354332 Reviewed by Ryan Haddad. * Tools/CISupport/ews-build/steps.py: (CheckStatusOfPR): Canonical link: https://commits.webkit.org/276655@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5b95a: [JSC] We should fix the backwards propagation for ...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f5b95a221c2e77a79052e1cd0cf6f2e38b50aadd
https://github.com/WebKit/WebKit/commit/f5b95a221c2e77a79052e1cd0cf6f2e38b50aadd
Author: Yijia Huang
Date: 2024-03-25 (Mon, 25 Mar 2024)
Changed paths:
A JSTests/stress/propogate-PureInt-double-use.js
M Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp
M Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.h
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGGraph.h
M Source/JavaScriptCore/dfg/DFGPhase.cpp
M Source/JavaScriptCore/dfg/DFGPhase.h
M Source/JavaScriptCore/dfg/DFGPlan.cpp
M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp
Log Message:
---
[JSC] We should fix the backwards propagation for DFG node use flags after
the fixup phase
https://bugs.webkit.org/show_bug.cgi?id=257949
rdar://110661900
Reviewed by Yusuke Suzuki.
Given JS code:
let x = -1 >>> v; // <-- [1]
let y = x + -0.2; // <-- [2]
let z = y | 0; // <-- [3]
In the BackwardsPropagationPhase, Node {y} is a PureInt (The node
is never used as a number) since it's only used in [3] which will
be truncated to int32, see spec [4]. Then, the PureInt info will be
propagated to node {x} since the right operand (-0.2) at [2] is within
two to the 32th power range. Later then, the UInt32ToNumber emitted at
[1] will be optimized out in the FixupPhase due to the PureInt {x}.
However, this is not expected since {x} should be treated as a number
when being added with -0.2.
This brings us the concern that PureInt is not sufficiently proven in
the BackwardsPropagationPhase until the FixupPhase which is used to fixes
edge uses. In this case, since the {x} node has a number result because of
the emitted UInt32ToNumber, [2] wouldn't be treated as an integer add. As a
result, a DoubleRep(x) is introduced for the double arithmetic add at [2].
Here, the DoubleRep is basically a double representation which can be leveraged
by floating point arithmetic operations. With that we can confirm that the
wrapped
node is definitely going to be used as a double and we should rely on that to
prove the number use of a DFG node.
So to fix this issue, we should run BackwardsPropagationPhase again after the
FixupPhase with those inserted double representation nodes as proofs in order
to fix the node uses. And move the corresponding UInt32ToNumber optimization
to the later StrengthReductionPhase.
[4] https://tc39.es/ecma262/#sec-numeric-types-number-bitwiseOR
* JSTests/stress/propogate-PureInt-double-use.js: Added.
(test):
(throw.new.Error.opt1):
(throw.new.Error.opt2):
(throw.new.Error):
* Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):
* Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.h:
* Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/dfg/DFGPhase.cpp:
(JSC::DFG::Phase::endPhase):
* Source/JavaScriptCore/dfg/DFGPhase.h:
(JSC::DFG::Phase::Phase):
* Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
Canonical link: https://commits.webkit.org/276654@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8998f0: Remove access to containermanagerd.fb_check semaph...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8998f07ee8d646398d95f3193b0d46aca3e86ec9 https://github.com/WebKit/WebKit/commit/8998f07ee8d646398d95f3193b0d46aca3e86ec9 Author: Sihui Liu Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- Remove access to containermanagerd.fb_check semaphore from web process's sandbox https://bugs.webkit.org/show_bug.cgi?id=271667 rdar://125367419 Reviewed by Per Arne Vollan. This semaphore is no longer in use. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/276653@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf3a32: Fix some watchOS builds after 276639@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf3a32feaad71981575de9c509fe8a850ea3503a https://github.com/WebKit/WebKit/commit/cf3a32feaad71981575de9c509fe8a850ea3503a Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in Log Message: --- Fix some watchOS builds after 276639@main https://bugs.webkit.org/show_bug.cgi?id=271670 rdar://125372380 Unreviewed. OSStatus isn't the same exact type as int32_t on all platforms. Remove this and I'll worry about it later. * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: Canonical link: https://commits.webkit.org/276652@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e88f01: Introducing C++ Swift Interop
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e88f01ab1a57ebb1b114ee93abd0867a6ec0cac8 https://github.com/WebKit/WebKit/commit/e88f01ab1a57ebb1b114ee93abd0867a6ec0cac8 Author: nmahendru Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/spi/darwin/AbortWithReasonSPI.h M Source/WebCore/PAL/Configurations/PAL.xcconfig M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/PALSwift.h M Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift A Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift A Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp R Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm A Source/WebCore/PAL/pal/module.modulemap M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp R Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.mm A Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp R Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.mm M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp M Tools/Scripts/swift/.swift-format Log Message: --- Introducing C++ Swift Interop https://bugs.webkit.org/show_bug.cgi?id=271263 rdar://123331949 Reviewed by Alex Christensen, Geoffrey Garen and Elliott Williams. This is an examplar of the C++ Swift interop feature. We have randomly chosen the Digest Implementation to be the first one to adopt this. The Compiler feature is only available for newer platforms to code has been guarded with ifdefs. The changes in AbortWithReasonSPI.h are to allow the Swift Generator to work. It, at the moment cannot handle headers included inside `extern C` blocks. Input parameteres to Swift have been intentionally chosen as spans as swift, at the moment my make copies of inputs for safety guarantees. Copying a span is cheap so that is Okie. On the return path, Swift calls the WTF::Vector move constructor(confirmed in debugger). * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/spi/darwin/AbortWithReasonSPI.h: * Source/WebCore/Configurations/WebCore.xcconfig: * Source/WebCore/PAL/Configurations/PAL.xcconfig: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/PALSwift/CryptoKitShim.swift: (AesGcm.test(_:)): (AesKwRV.errCode): (AesKwRV.outputSize): (HashFunction.update(_:)): (Digest.sha1(_:)): (Digest.sha256(_:)): (Digest.sha384(_:)): (Digest.sha512(_:)): (AesKwReturnValue.errCode): Deleted. (AesKwReturnValue.outputSize): Deleted. * Source/WebCore/PAL/pal/PALSwift/UnsafeOverlays.swift: Added. (HashFunction.update(_:)): * Source/WebCore/PAL/pal/PALSwiftModule.h: Copied from Source/WTF/wtf/spi/darwin/AbortWithReasonSPI.h. * Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp: Renamed from Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm. (PAL::CryptoDigest::computeHash): * Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp: (PAL::createCryptoDigest): (PAL::CryptoDigest::computeHash): * Source/WebCore/PAL/pal/module.modulemap: Added. * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::dispatchDigest): * Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp: Renamed from Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.mm. (WebCore::encryptCryptoKitAESGCM): (WebCore::CryptoAlgorithmAESGCM::platformEncrypt): * Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.cpp: Renamed from Source/WebCore/crypto/cocoa/CryptoAlgorithmAESKWMac.mm. (WebCore::wrapKeyAESKWCryptoKit): (WebCore::unwrapKeyAESKWCryptoKit): * Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp: Canonical link: https://commits.webkit.org/276651@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a54c7: [Gardening]: rdar://125372071 (REGRESSION (276513@...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a54c7e57a184a313f1fe7e3e2b5ca79a8b7a64f https://github.com/WebKit/WebKit/commit/9a54c7e57a184a313f1fe7e3e2b5ca79a8b7a64f Author: Jay Stfleur Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening]: rdar://125372071 (REGRESSION (276513@main): [ iOS ] fast/images/async-image-intersect-different-size-for-drawing.html is a consistent failure (271669)) https://bugs.webkit.org/show_bug.cgi?id=125372071 rdar://125372071 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276650@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a40e7: [WebGPU] Partial 3D image_copy tests are failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a40e77e06425083e1b803e42122e923f5a5fcb5 https://github.com/WebKit/WebKit/commit/4a40e77e06425083e1b803e42122e923f5a5fcb5 Author: Mike Wyrzykowski Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/CommandEncoder.mm M Source/WebGPU/WebGPU/Queue.mm Log Message: --- [WebGPU] Partial 3D image_copy tests are failing https://bugs.webkit.org/show_bug.cgi?id=271382 Reviewed by Tadeu Zagallo. For the purpose of validation of bytesPerRow, we should be using the 2D dimension as the issue is we would crash at the metal validation layer. No test expectations update since the expectations were set to passing and this test does not run in EWS as it takes too long. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::copyBufferToTexture): (WebGPU::CommandEncoder::copyTextureToBuffer): * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/276649@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 313a88: [WebGPU] GPUCanvasContext.configure() should valid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 313a887ec859849a0dc903b18e664c09d64ade2e https://github.com/WebKit/WebKit/commit/313a887ec859849a0dc903b18e664c09d64ade2e Author: Mike Wyrzykowski Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebGPU/WebGPU/Device.h M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm Log Message: --- [WebGPU] GPUCanvasContext.configure() should validate the GPUTextureDescriptor before creating the backing textures https://bugs.webkit.org/show_bug.cgi?id=271404 rdar://125183118 Reviewed by Tadeu Zagallo. The spec says we should validate the texture descriptor before creating the texures in GPUCanvasContext.configure() and we were not doing so. Doing so avoids crashes createTextureView() as the returned texture is invalid. * Source/WebGPU/WebGPU/Device.h: * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: (WebGPU::PresentationContextIOSurface::configure): Canonical link: https://commits.webkit.org/276648@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c33f54: [Remote Inspection] _WKTargetedElementInfo should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c33f546359f3ccb08df0878d6957252f57f47047 https://github.com/WebKit/WebKit/commit/c33f546359f3ccb08df0878d6957252f57f47047 Author: Wenson Hsieh Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/page/ElementTargeting.cpp M Source/WebCore/page/ElementTargetingTypes.h M Source/WebKit/Shared/API/APIObject.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/APIFrameInfo.cpp M Source/WebKit/UIProcess/API/APIFrameInfo.h M Source/WebKit/UIProcess/API/APITargetedElementInfo.cpp M Source/WebKit/UIProcess/API/APITargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfoPrivate.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-1.html A Tools/TestWebKitAPI/Tests/WebKitCocoa/nested-frames.html Log Message: --- [Remote Inspection] _WKTargetedElementInfo should expose a method to get contained subframes https://bugs.webkit.org/show_bug.cgi?id=271510 Reviewed by Megan Gardner. Add a new method on `_WKTargetedElementInfo` to request `_WKFrameTreeNode`s that correspond to the subframes underneath the targeted element. See below for more details. * Source/WebCore/page/ElementTargeting.cpp: (WebCore::collectChildFrameIdentifiers): (WebCore::targetedElementInfo): Plumb frame IDs for subframes underneath the targeted element from the web process to the UI process. * Source/WebCore/page/ElementTargetingTypes.h: * Source/WebKit/Shared/API/APIObject.h: Drive-by fix a typo in a comment: `namespace Object` should be `namespace API`. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/APIFrameInfo.cpp: (API::FrameInfo::title const): Add a getter for `title` on `FrameInfo`, which calls into `WebFrameProxy`. * Source/WebKit/UIProcess/API/APIFrameInfo.h: * Source/WebKit/UIProcess/API/APITargetedElementInfo.cpp: (API::TargetedElementInfo::isSameElement const): (API::TargetedElementInfo::childFrames const): * Source/WebKit/UIProcess/API/APITargetedElementInfo.h: * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm: (-[WKFrameInfo _title]): Add a new SPI method on `WKFrameInfo`, which allows clients to read the last cached `title` for the given frame. * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfoPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h: * Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm: (-[_WKTargetedElementInfo getChildFrames:]): Implement the new API method. Using the list of subframe IDs from the targeting results, request `FrameTreeNodeData` for each subframe and call the completion handler once all the async calls are complete. * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm: (-[_WKTargetedElementInfo childFrames]): (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-1.html: * Tools/TestWebKitAPI/Tests/WebKitCocoa/nested-frames.html: Added. Augment an existing API test to cover this new method as well. Canonical link: https://commits.webkit.org/276647@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7bac52: REGRESSION: JavaScriptCore: JSC::ScopedArguments::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7bac523bd87dc3ce0c63e66ce5b279ec91e7b9dc https://github.com/WebKit/WebKit/commit/7bac523bd87dc3ce0c63e66ce5b279ec91e7b9dc Author: Michael Saboff Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/ScopedArguments.h M Source/JavaScriptCore/runtime/SymbolTable.cpp M Source/JavaScriptCore/runtime/SymbolTable.h Log Message: --- REGRESSION: JavaScriptCore: JSC::ScopedArguments::setIndexQuickly https://bugs.webkit.org/show_bug.cgi?id=268409 rdar://121748005 Reviewed by Yusuke Suzuki. A code inspection of the symbol table and scoped arguments code revealed that SymbolTable::cloneScopePart() doesn't properly copy the ScopedArgumentsTable from the source. Since ScopedArguments point to the WatchpointSets in the related SymbolTable, we need to create new WatchpointSets in the cloned SymbolTable and have the ScopedArguments point to the related new WatchpointSets. This is a speculative fix. * Source/JavaScriptCore/runtime/ScopedArguments.h: * Source/JavaScriptCore/runtime/SymbolTable.cpp: (JSC::SymbolTable::cloneScopePart): (JSC::SymbolTable::hasScopedWatchpointSet): * Source/JavaScriptCore/runtime/SymbolTable.h: Originally-landed-as: 272448.422@safari-7618-branch (5bc92c9d5253). rdar://124554329 Canonical link: https://commits.webkit.org/276646@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a0671: Add missing stack check to bbq->omg OSR
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a0671fdf83143eb848ccf3e2f565d2fd4bded7b https://github.com/WebKit/WebKit/commit/3a0671fdf83143eb848ccf3e2f565d2fd4bded7b Author: Justin Michaud Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: A JSTests/wasm/stress/omg-stack-overflow.js A JSTests/wasm/stress/omg-stack-overflow.wasm M Source/JavaScriptCore/wasm/WasmOperations.cpp Log Message: --- Add missing stack check to bbq->omg OSR https://bugs.webkit.org/show_bug.cgi?id=270605 rdar://124060272 Reviewed by Keith Miller. In https://commits.webkit.org/272448.466@safari-7618-branch, we turned a stack overflow during OSR entry into a crash, preventing a security issue. While the crash prevents memory corruption, it should never happen. This patch fixes a case that was missed in the first patch. Note: the test case currently runs forever, so it is skipped until we fix the watchdog in wasm. * JSTests/wasm/stress/omg-stack-overflow.js: Added. (globalThis.callerIsBBQOrOMGCompiled.instantiateJsc): (else.instantiateBrowser): (async let): * JSTests/wasm/stress/omg-stack-overflow.wasm: Added. * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): Originally-landed-as: 272448.704@safari-7618-branch (36930ea8be72). rdar://125261536 Canonical link: https://commits.webkit.org/276645@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d689b8: visionOS: Compositing layers can end up getting sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d689b8edef147f0eab7c70fc6f0f3a1ad8db5e3b https://github.com/WebKit/WebKit/commit/d689b8edef147f0eab7c70fc6f0f3a1ad8db5e3b Author: Tim Horton Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm Log Message: --- visionOS: Compositing layers can end up getting shuffled out of order on layer tree mutation https://bugs.webkit.org/show_bug.cgi?id=268420 Reviewed by Richard Robinson and Simon Fraser. It turns out it is not advisable to have interleaved UIView and CALayer children underneath a UIView. Avoid this by wrapping the interaction region root layer in a UIView. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (-[UIView _web_setSubviews:]): Add an assertion to avoid future re-debugging of this issue. (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates): Don't bother moving the interaction region container around in the non-UIView case; it never comes up, as on UIKit-having platforms we always make UIViews for all but the tile contents layers, which never have interaction regions. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: (WebKit::RemoteLayerTreeNode::ensureInteractionRegionsContainer): (WebKit::RemoteLayerTreeNode::removeInteractionRegionsContainer): (WebKit::RemoteLayerTreeNode::repositionInteractionRegionsContainerIfNeeded): Swap the CALayer for a UIView. However, we'll continue using the layer for maintaining state and our set of sublayers, since it has no view children. Originally-landed-as: 272448.443@safari-7618-branch (1b8630ced33e). rdar://124554005 Canonical link: https://commits.webkit.org/276644@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed9c79: Undo increase of libPAS internal minimum alignment...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9c798aa81ee81d11e0dadcdcea6d4bd0fab411 https://github.com/WebKit/WebKit/commit/ed9c798aa81ee81d11e0dadcdcea6d4bd0fab411 Author: David Degazio Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/bmalloc/libpas/src/libpas/pas_config.h Log Message: --- Undo increase of libPAS internal minimum alignment from 8 to 16 bytes https://bugs.webkit.org/show_bug.cgi?id=271487 rdar://124708602 Reviewed by Yusuke Suzuki and Justin Michaud. Reverts previous increase of PAS_INTERNAL_MIN_ALIGN, bumping it back down to 8 bytes. * Source/bmalloc/libpas/src/libpas/pas_config.h: Canonical link: https://commits.webkit.org/276643@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24c837: Temporarily disable view transition UA styles
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24c837086e409b1de91f2ce3bd979f51860eb7eb https://github.com/WebKit/WebKit/commit/24c837086e409b1de91f2ce3bd979f51860eb7eb Author: Tim Nguyen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/style/UserAgentStyle.cpp Log Message: --- Temporarily disable view transition UA styles https://bugs.webkit.org/show_bug.cgi?id=271658 rdar://125296710 Reviewed by Aditya Keerthi. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/style/UserAgentStyle.cpp: (WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement): Canonical link: https://commits.webkit.org/276642@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b57d8: Remove redundant call in `Editor::findEventTargetF...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b57d85c546411c0fe87d91197463b985a7bf017 https://github.com/WebKit/WebKit/commit/9b57d85c546411c0fe87d91197463b985a7bf017 Author: Ahmad Saleem Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/editing/Editor.cpp Log Message: --- Remove redundant call in `Editor::findEventTargetFrom` https://bugs.webkit.org/show_bug.cgi?id=271622 Reviewed by Sihui Liu. This patch removes redundant call for returning `nullptr`, if there is no target while in above `if`, it returns value properly, so this is noop condition. * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::findEventTargetFrom const): Canonical link: https://commits.webkit.org/276641@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 246a66: Reduce function call in `InsertTextCommand::doApply`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 246a66813dd13ee3aebed5647d19655cc2acfc0d https://github.com/WebKit/WebKit/commit/246a66813dd13ee3aebed5647d19655cc2acfc0d Author: Ahmad Saleem Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/editing/InsertTextCommand.cpp Log Message: --- Reduce function call in `InsertTextCommand::doApply` https://bugs.webkit.org/show_bug.cgi?id=271620 Reviewed by Tim Nguyen. This patch is to reduce function call by using local variable introduced above. * Source/WebCore/editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::doApply): Canonical link: https://commits.webkit.org/276640@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a06598: Expose more serialized type metadata to IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a065988161d6135e409d797948336b4c5c1b977a https://github.com/WebKit/WebKit/commit/a065988161d6135e409d797948336b4c5c1b977a Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp M Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/ProcessQualified.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Expose more serialized type metadata to IPC test API https://bugs.webkit.org/show_bug.cgi?id=271422 Reviewed by Sihui Liu. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/Scripts/webkit/messages.py: (serialized_identifiers): (headers_for_type): * Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp: (IPC::serializedIdentifiers): * Source/WebKit/Shared/Cocoa/CoreIPCNSValue.serialization.in: * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/ProcessQualified.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemoteProperties.serialization.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276639@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 072015: Remove unnecessary Vector copy in mapHostName
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07201542805cb54b6385b71196040c2d6c10f3ef https://github.com/WebKit/WebKit/commit/07201542805cb54b6385b71196040c2d6c10f3ef Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/URLHelpers.cpp Log Message: --- Remove unnecessary Vector copy in mapHostName https://bugs.webkit.org/show_bug.cgi?id=271440 Reviewed by Sihui Liu. * Source/WTF/wtf/URLHelpers.cpp: (WTF::URLHelpers::mapHostName): Canonical link: https://commits.webkit.org/276638@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1dff3b: [Site Isolation] http/tests/security/cors-post-red...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1dff3b6af5623c09f268b39c8b60b7c3cd90ce9c https://github.com/WebKit/WebKit/commit/1dff3b6af5623c09f268b39c8b60b7c3cd90ce9c Author: Charlie Wolfe Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp M Source/WebKit/UIProcess/ProvisionalFrameProxy.h M Source/WebKit/UIProcess/RemotePageProxy.cpp M Source/WebKit/UIProcess/WebFrameProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm Log Message: --- [Site Isolation] http/tests/security/cors-post-redirect-30* is a consistent crash https://bugs.webkit.org/show_bug.cgi?id=271628 rdar://125336415 Reviewed by Alex Christensen. When a site-isolated iframe navigates and receives a cross-site redirect, we skip the `DidStartProvisionalLoadForFrame` message in the new process because we have already received it from the old process. However, if the old process is hosting another frame on the page, the process will stay alive and send a `DidFailProvisionalLoadForFrame` message. Then, when the load is committed in the new process we fail an assertion because the UI process thinks the load already failed. If we receive a `DidFailProvisionalLoadForFrame` message and a provisional frame exists that was created by a cross-site redirect, we know that the load did not fail; it is just happening in a new process. I also added a test to verify that when a provisional load actually fails on a cross-site redirect, the delegate is still called. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: (WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy): * Source/WebKit/UIProcess/ProvisionalFrameProxy.h: (WebKit::ProvisionalFrameProxy::isCrossSiteRedirect const): * Source/WebKit/UIProcess/RemotePageProxy.cpp: (WebKit::RemotePageProxy::didFailProvisionalLoadForFrame): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::prepareForProvisionalNavigationInProcess): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h: * Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm: (-[TestNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]): Canonical link: https://commits.webkit.org/276637@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eab787: Make window.open use correct process when called f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eab78766e024f6411cb60e10a3ed18b84e84aa30 https://github.com/WebKit/WebKit/commit/eab78766e024f6411cb60e10a3ed18b84e84aa30 Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp M Source/WebKit/UIProcess/API/APIPageConfiguration.h M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp M Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: --- Make window.open use correct process when called from a site isolated iframe https://bugs.webkit.org/show_bug.cgi?id=271514 Reviewed by Charlie Wolfe. When JS calls window.open, WebPageProxy::createNewPage gives an API::PageConfiguration (which is now equivalent to a WKWebViewConfiguration) to the UIClient containing state that must be used to make the new WKWebView. Before site isolation, that state was just the related page, whose process must be shared to keep functionality working such as iframes with the same origin as the opener being able to directly access the opener's DOM. With site isolation, the state that is needed to keep this functionality working is the BrowsingContextGroup, which contains the maps of domains to processes, and the opener frame identifier, which needs to be used to put the opened frame initially in the same process as the opener while the opened frame contains only about:blank. From about:blank it can then use the BrowsingContextGroup to navigate to the correct process for any domain. Unfortunately, though, there is SPI to do tricky things with the related page, and WebKitTestRunner uses this SPI to retrofit an unrelated WKWebViewConfiguration into looking enough like the suggested WKWebViewConfiguration that WebKit accepts it and uses it correctly. In order to keep this working, I needed to make additional SPI to copy the site isolation state from one WKPageConfigurationRef to another. Conveninetly, WKPageConfigurationRef can now be converted to WKWebViewConfiguration using toll-free-bridging. It looks like all that work I did over the last week to clean up WKWebViewConfiguration is already paying off! I verified this fixes http/tests/site-isolation/iframe-and-window-open.html but only how we used to run it before 276416@main. Additional work is being done on our strategy for running existing layout tests to verify site isolation correctness. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebKit/UIProcess/API/APIPageConfiguration.cpp: (API::PageConfiguration::setBrowsingContextGroup): (API::PageConfiguration::openerFrameID const): (API::PageConfiguration::setOpenerFrameID): * Source/WebKit/UIProcess/API/APIPageConfiguration.h: * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.cpp: (WKPageConfigurationCopySiteIsolationState): * Source/WebKit/UIProcess/API/C/WKPageConfigurationRef.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::createNewPage): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::createWebPage): * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateOtherPage): Canonical link: https://commits.webkit.org/276636@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4b39a: REGRESSION(276505@main) reloading after crashing r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4b39a8c7766b2eae64e5cc8676ab35483f18bc8 https://github.com/WebKit/WebKit/commit/a4b39a8c7766b2eae64e5cc8676ab35483f18bc8 Author: Alex Christensen Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- REGRESSION(276505@main) reloading after crashing registers RegistrableDomain as a public suffix https://bugs.webkit.org/show_bug.cgi?id=271662 rdar://125363034 Reviewed by Sihui Liu. topPrivatelyControlledDomain was actually unused, but what we should be sending as a public suffix should actually be a public suffix. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::launchProcessForReload): Canonical link: https://commits.webkit.org/276635@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a2127: Revert BECore cleanup.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a21270b827059302cbd0fafb6a145d1bbf78709 https://github.com/WebKit/WebKit/commit/5a21270b827059302cbd0fafb6a145d1bbf78709 Author: Justin Michaud Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/Configurations/Base.xcconfig M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Configurations/WebCore.xcconfig Log Message: --- Revert BECore cleanup. https://bugs.webkit.org/show_bug.cgi?id=271661 rdar://125362649 Reviewed by Wenson Hsieh. This broke some builds. * Source/JavaScriptCore/Configurations/Base.xcconfig: * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/Configurations/WebCore.xcconfig: Canonical link: https://commits.webkit.org/276634@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba849a: [css-grid] Grid track sizing algorithm logical hei...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba849a630cec232ab5f53e05503f0fdf40cccebd https://github.com/WebKit/WebKit/commit/ba849a630cec232ab5f53e05503f0fdf40cccebd Author: Sammy Gill Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: A PerformanceTests/Layout/nested-grid-subgrid-free-space-columns.html M Source/WebCore/Headers.cmake M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp M Source/WebCore/rendering/RenderGrid.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: --- [css-grid] Grid track sizing algorithm logical height computation unnecessarily dirties grid items. https://bugs.webkit.org/show_bug.cgi?id=271083 rdar://124713418 Reviewed by Matt Woodrow. In certain situations when trying to compute the logical height for a grid item, the grid track sizing algorithm will update the grid item's overriding containing block size and mark it dirty for layout. This dirtying would occur even it we end up setting the override size to the same value and could result in bad performance with particular types of content. For example, nested grid content would run grid layout multiple times which is currently expensive. In this patch we avoid this extra call to layout by checking to see if the override size is already set to the value we are attempting to set it to. If it is then we will avoid dirtying the renderer. This also ended up exposing an invalidation bug in which we were not properly invalidating the grid items when there was a style change on the grid related to its column or row sizes. This was demonstrated with new failures in css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html which was performing this behavior. Now when the grid style changes we will check to see if any of the sizes for the columns or the rows are different. If this occurs we should mark the grid items as dirty. This is likely to be more than necessary since we could probably try to identify the exact set of grid items that need to be invalidated, but this approach is the least risky for now. Future patches should attempt to reign this invalidation in a bit more. Without this patch I was getting about 2 runs/s and afterwards I was able to get about ~690 runs/s. * PerformanceTests/Layout/nested-grid-subgrid-free-space-columns.html: Added. * Source/WebCore/Headers.cmake: * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const): * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::styleDidChange): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::gridTrackSizes const): Canonical link: https://commits.webkit.org/276633@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c8090: Use rvalue references for callback parameters in U...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c8090445e4865e40598f59cf37099ba7f947897 https://github.com/WebKit/WebKit/commit/6c8090445e4865e40598f59cf37099ba7f947897 Author: Sihui Liu Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h Log Message: --- Use rvalue references for callback parameters in UniqueIDBDatabase https://bugs.webkit.org/show_bug.cgi?id=271624 rdar://problem/125334392 Reviewed by Per Arne Vollan. * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::createObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore): (WebCore::IDBServer::UniqueIDBDatabase::createIndex): (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex): (WebCore::IDBServer::UniqueIDBDatabase::renameIndex): (WebCore::IDBServer::UniqueIDBDatabase::putOrAdd): (WebCore::IDBServer::UniqueIDBDatabase::putOrAddAfterSpaceCheck): (WebCore::IDBServer::UniqueIDBDatabase::getRecord): (WebCore::IDBServer::UniqueIDBDatabase::getAllRecords): (WebCore::IDBServer::UniqueIDBDatabase::getCount): (WebCore::IDBServer::UniqueIDBDatabase::deleteRecord): (WebCore::IDBServer::UniqueIDBDatabase::openCursor): (WebCore::IDBServer::UniqueIDBDatabase::iterateCursor): (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction): (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction): * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h: Canonical link: https://commits.webkit.org/276632@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] db0669: Add 's shadowRootDelegatesFocus & shadow...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: db0669a6fa034ab98e120208f72fd232948b1fcc https://github.com/WebKit/WebKit/commit/db0669a6fa034ab98e120208f72fd232948b1fcc Author: Anne van Kesteren Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic.html M Source/WebCore/html/HTMLTemplateElement.idl Log Message: --- Add 's shadowRootDelegatesFocus & shadowRootClonable https://bugs.webkit.org/show_bug.cgi?id=271640 Reviewed by Tim Nguyen. These were missed in prior PRs that added support for the corresponding content attributes. Partially synchronize WPT up to the following commit to add missing test coverage: https://github.com/web-platform-tests/wpt/commit/2969dd3b1af9126ed769915ff852cb29eb615d52 * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-basic.html: * Source/WebCore/html/HTMLTemplateElement.idl: Canonical link: https://commits.webkit.org/276631@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2fa5e5: [WGSL] Validate functions missing a return statement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2fa5e500ae947d383e44891f61cd27213c0f622e https://github.com/WebKit/WebKit/commit/2fa5e500ae947d383e44891f61cd27213c0f622e Author: Tadeu Zagallo Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebGPU/WGSL/TypeCheck.cpp M Source/WebGPU/WGSL/tests/invalid/function-call.wgsl Log Message: --- [WGSL] Validate functions missing a return statement https://bugs.webkit.org/show_bug.cgi?id=271482 rdar://124143123 Reviewed by Mike Wyrzykowski. Implement the behavior analysis from the spec[1] and check if functions with a return type are missing a return statement. [1]: https://www.w3.org/TR/WGSL/#behaviors * Source/WebGPU/WGSL/TypeCheck.cpp: (WGSL::TypeChecker::visit): (WGSL::TypeChecker::analyze): (WGSL::TypeChecker::analyzeStatements): * Source/WebGPU/WGSL/tests/invalid/function-call.wgsl: Canonical link: https://commits.webkit.org/276630@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7cb7a6: 'kAudioDevicePropertyTapEnabled' is deprecated
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cb7a6e0f00e1bcf3a5558b2cbed8774d82e2200 https://github.com/WebKit/WebKit/commit/7cb7a6e0f00e1bcf3a5558b2cbed8774d82e2200 Author: Youenn Fablet Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/pal/spi/cf/CoreAudioSPI.h M Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp Log Message: --- 'kAudioDevicePropertyTapEnabled' is deprecated rdar://118872154 https://bugs.webkit.org/show_bug.cgi?id=271630 Reviewed by Jean-Yves Avenard and Eric Carlson. Use kAudioDevicePropertyTapEnabled where not deprecated and kAudioDevicePropertyReferenceStreamEnabled otherwise. Remove non Mac declaration of kAudioDevicePropertyTapEnabled since it is only used in Mac. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/spi/cf/CoreAudioSPI.h: * Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp: (WebCore::isValidCaptureDevice): Canonical link: https://commits.webkit.org/276629@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 533a59: Some AVSampleBufferDisplayLayer methods are deprec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 533a598f6d616ddd5075ca57cbbf06029803d428 https://github.com/WebKit/WebKit/commit/533a598f6d616ddd5075ca57cbbf06029803d428 Author: Youenn Fablet Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm Log Message: --- Some AVSampleBufferDisplayLayer methods are deprecated rdar://125340931 https://bugs.webkit.org/show_bug.cgi?id=271633 Reviewed by Jonathan Bedard. Add deprecation blocks to AVSampleBufferDisplayLayer flush, flushAndRemoveImage, isReadyForMoreMediaData, requestMediaDataWhenReadyOnQueue, stopRequestingMediaData and status. * Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm: (WebCore::LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer): (WebCore::LocalSampleBufferDisplayLayer::didFail const): (WebCore::LocalSampleBufferDisplayLayer::flush): (WebCore::LocalSampleBufferDisplayLayer::flushAndRemoveImage): (WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData): Canonical link: https://commits.webkit.org/276628@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d87f5d: AX: Mac combo boxes should expose aria-activedesce...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d87f5d6705184810976f06f36392729a3e964b39 https://github.com/WebKit/WebKit/commit/d87f5d6705184810976f06f36392729a3e964b39 Author: Dominic Mazzoni Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: A LayoutTests/accessibility/mac/aria-combobox-activedescendant-expected.txt A LayoutTests/accessibility/mac/aria-combobox-activedescendant.html M Source/WebCore/accessibility/AXCoreObject.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Log Message: --- AX: Mac combo boxes should expose aria-activedescendant as AXSelectedChildren https://bugs.webkit.org/show_bug.cgi?id=271287 rdar://problem/125050867 Reviewed by Andres Gonzalez. This is necessary, but probably not sufficient, to support https://bugs.webkit.org/show_bug.cgi?id=231724 (AX: VoiceOver doesn't announce aria-activedescendant value for select-only combobox specification). There are other bugs preventing VoiceOver from working but exposing the active descendant is pretty fundamental so I'd like to get that in first. Part of the bug is that an element can be both a combo box and a text field, so the supported attribute logic needed to be updated to take that into account. * LayoutTests/accessibility/mac/aria-combobox-activedescendant-expected.txt: Added. * LayoutTests/accessibility/mac/aria-combobox-activedescendant.html: Added. * Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::AXCoreObject::canHaveSelectedChildren const): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::selectedChildren): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): Canonical link: https://commits.webkit.org/276627@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2989c: AX: Input time elements with no value are read inc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2989cc4e30ed41ddc976422ff3b0ba0faa930f1 https://github.com/WebKit/WebKit/commit/f2989cc4e30ed41ddc976422ff3b0ba0faa930f1 Author: Andres Gonzalez Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/accessibility/datetime/input-time-label-value-expected.txt M LayoutTests/accessibility/datetime/input-time-label-value.html M LayoutTests/platform/ios/accessibility/datetime/input-time-label-value-expected.txt M LayoutTests/platform/mac-ventura/accessibility/datetime/input-time-label-value-expected.txt M Source/WebCore/html/BaseDateAndTimeInputType.cpp M Source/WebCore/html/shadow/DateTimeEditElement.cpp M Source/WebCore/html/shadow/DateTimeEditElement.h M Source/WebCore/html/shadow/DateTimeFieldElement.h M Source/WebCore/html/shadow/DateTimeFieldElements.cpp M Source/WebCore/html/shadow/DateTimeFieldElements.h M Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp M Source/WebCore/html/shadow/DateTimeNumericFieldElement.h M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp M Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h Log Message: --- AX: Input time elements with no value are read incorrectly by VoiceOver. https://bugs.webkit.org/show_bug.cgi?id=271394 Reviewed by Tyler Wilcock. The problem occurs because BaseDateAndTimeInputType::valueAsDouble returns NaN if the value attribute is not present. Thus, accessibilityValueAsDate was returning a bogus WallTime. This patch fixes the problem by getting the placeholder value set during the creation of the shadow subtree for the datetime element, which is the value shown on the screen. * LayoutTests/accessibility/datetime/input-time-label-value-expected.txt: * LayoutTests/accessibility/datetime/input-time-label-value.html: Added a test case with no value. * LayoutTests/platform/ios/accessibility/datetime/input-time-label-value-expected.txt: * LayoutTests/platform/mac-ventura/accessibility/datetime/input-time-label-value-expected.txt: * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::accessibilityValueAsDate const): (WebCore::BaseDateAndTimeInputType::setupDateTimeChooserParameters): * Source/WebCore/html/shadow/DateTimeEditElement.cpp: (WebCore::DateTimeEditElement::placeholderValue const): (WebCore::DateTimeEditElement::valueAsDateTimeFieldsState const): * Source/WebCore/html/shadow/DateTimeEditElement.h: * Source/WebCore/html/shadow/DateTimeFieldElement.h: * Source/WebCore/html/shadow/DateTimeFieldElements.cpp: (WebCore::DateTimeDayFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeMeridiemFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeMillisecondFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeMinuteFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeMonthFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeSecondFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeSymbolicMonthFieldElement::populateDateTimeFieldsState): (WebCore::DateTimeYearFieldElement::populateDateTimeFieldsState): Modified the populateDateTimeFieldsState method to return the placeholder value if the value has not been set. * Source/WebCore/html/shadow/DateTimeFieldElements.h: * Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp: (WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement): (WebCore::DateTimeNumericFieldElement::valueAsInteger const): Inlined in header. * Source/WebCore/html/shadow/DateTimeNumericFieldElement.h: * Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.cpp: (WebCore::DateTimeSymbolicFieldElement::valueAsInteger const): Inlined in header. * Source/WebCore/html/shadow/DateTimeSymbolicFieldElement.h: Canonical link: https://commits.webkit.org/276626@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ce30e: [IFC][Partial layout] ASSERT_NOT_REACHED in handle...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ce30e754d8c1833837d1b7e08964cf0e4a9ccd2 https://github.com/WebKit/WebKit/commit/5ce30e754d8c1833837d1b7e08964cf0e4a9ccd2 Author: Alan Baradlay Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: A LayoutTests/fast/text/partial-layout-with-pagination-and-widow-expected.txt A LayoutTests/fast/text/partial-layout-with-pagination-and-widow.html M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp Log Message: --- [IFC][Partial layout] ASSERT_NOT_REACHED in handleEnterExitBidiContext with inconsistent InlineBoxStart/End pairs https://bugs.webkit.org/show_bug.cgi?id=271428 Reviewed by Antti Koivisto. Partial layout triggered by pagination may initiate incremental inline item (re)building on non-yet-supported content. Let's just do full rebuild for now. * LayoutTests/fast/text/partial-layout-with-pagination-and-widow-expected.txt: Added. * LayoutTests/fast/text/partial-layout-with-pagination-and-widow.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::rebuildInlineItemListIfNeeded): Canonical link: https://commits.webkit.org/276625@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6adb3: [Legacy line layout removal] Remove incremental la...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6adb32149c044cff114910e85d078c5fa8add7e https://github.com/WebKit/WebKit/commit/e6adb32149c044cff114910e85d078c5fa8add7e Author: Antti Koivisto Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/rendering/LegacyInlineBox.h M Source/WebCore/rendering/LegacyInlineFlowBox.cpp M Source/WebCore/rendering/LegacyLineLayout.cpp M Source/WebCore/rendering/LegacyLineLayout.h M Source/WebCore/rendering/LegacyRootInlineBox.cpp M Source/WebCore/rendering/LegacyRootInlineBox.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderCombineText.cpp M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderTextLineBoxes.cpp M Source/WebCore/rendering/RenderTextLineBoxes.h M Source/WebCore/rendering/line/BreakingContext.h M Source/WebCore/rendering/line/LineBreaker.cpp M Source/WebCore/rendering/line/LineInfo.cpp M Source/WebCore/rendering/line/LineInfo.h M Source/WebCore/rendering/line/LineInlineHeaders.h M Source/WebCore/rendering/line/LineLayoutState.h Log Message: --- [Legacy line layout removal] Remove incremental layout support https://bugs.webkit.org/show_bug.cgi?id=271635 rdar://125343719 Reviewed by Alan Baradlay. We only use this code for SVG now. SVG line layout is never incremental as there is never more than one line. * Source/WebCore/rendering/LegacyInlineBox.h: (WebCore::LegacyInlineBox::InlineBoxBitfields::InlineBoxBitfields): * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::removeChild): * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::dirtyLineBoxesForRenderer): (WebCore::constructBidiRunsForSegment): (WebCore::LegacyLineLayout::createLineBoxesFromBidiRuns): (WebCore::LegacyLineLayout::layoutRunsAndFloats): (WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange): (WebCore::LegacyLineLayout::layoutLineBoxes): (WebCore::isCollapsibleSpace): Deleted. (WebCore::findFirstTrailingSpace): Deleted. (WebCore::LegacyLineLayout::handleTrailingSpaces): Deleted. (WebCore::deleteLineRange): Deleted. (WebCore::LegacyLineLayout::linkToEndLineIfNeeded): Deleted. (WebCore::LegacyLineLayout::determineStartPosition): Deleted. (WebCore::LegacyLineLayout::determineEndPosition): Deleted. (WebCore::LegacyLineLayout::matchedEndLine): Deleted. * Source/WebCore/rendering/LegacyLineLayout.h: * Source/WebCore/rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::childRemoved): Deleted. (WebCore::LegacyRootInlineBox::lineBreakBidiStatus const): Deleted. (WebCore::LegacyRootInlineBox::setLineBreakInfo): Deleted. * Source/WebCore/rendering/LegacyRootInlineBox.h: (WebCore::LegacyRootInlineBox::lineBreakObj const): Deleted. (WebCore::LegacyRootInlineBox::lineBreakPos const): Deleted. (WebCore::LegacyRootInlineBox::setLineBreakPos): Deleted. * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::layoutInlineChildren): * Source/WebCore/rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineTextIfNeeded): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::setTextWithOffset): * Source/WebCore/rendering/RenderTextLineBoxes.cpp: (WebCore::RenderTextLineBoxes::dirtyAll): (WebCore::RenderTextLineBoxes::dirtyRange): Deleted. * Source/WebCore/rendering/RenderTextLineBoxes.h: * Source/WebCore/rendering/line/BreakingContext.h: (WebCore::BreakingContext::BreakingContext): (WebCore::BreakingContext::handleEmptyInline): (WebCore::BreakingContext::handleText): * Source/WebCore/rendering/line/LineBreaker.cpp: (WebCore::LineBreaker::nextLineBreak): * Source/WebCore/rendering/line/LineInfo.cpp: (WebCore::LineInfo::setEmpty): * Source/WebCore/rendering/line/LineInfo.h: (WebCore::LineInfo::LineInfo): (WebCore::LineInfo::isEmpty const): (WebCore::LineInfo::previousLineBrokeCleanly const): Deleted. (WebCore::LineInfo::floatPaginationStrut const): Deleted. (WebCore::LineInfo::setPreviousLineBrokeCleanly): Deleted. (WebCore::LineInfo::setFloatPaginationStrut): Deleted. * Source/WebCore/rendering/line/LineInlineHeaders.h: (WebCore::shouldCollapseWhiteSpace): (WebCore::skipNonBreakingSpace): * Source/WebCore/rendering/line/LineLayoutState.h: (WebCore::LineLayoutState::LineLayoutState): (WebCore::LineLayoutState::endLineLogicalTop const): Deleted. (WebCore::LineLayoutState::setEndLineLogicalTop): Deleted. (WebCore::LineLayoutState::endLine const): Deleted. (WebCore::LineLayoutState::setEndLine): Deleted. (WebCore::LineLayoutState::adjustedLogicalLineTop const): Deleted. (WebCore::LineLayoutState::setAdjustedLogicalLineTop): Deleted. (WebCore::LineLayoutState::endLineMatched const): Deleted. (WebCore::LineLayoutState::setEndLineMatched): Deleted. (WebCore::LineLayoutState::markForFullLayout): Deleted. (WebCore::LineLayoutState::isFullLayout const): Deleted. (WebCore::LineLayoutState::usesRepaintBounds const): Deleted.
[webkit-changes] [WebKit/WebKit] 3a45bd: [LibWebRTC] Build fix for Linux after 276556@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a45bd5537bca43ff55c8b907a7172279d21ee40 https://github.com/WebKit/WebKit/commit/3a45bd5537bca43ff55c8b907a7172279d21ee40 Author: Diego Pino Garcia Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp Log Message: --- [LibWebRTC] Build fix for Linux after 276556@main build://bugs.webkit.org/show_bug.cgi?id=271368 Reviewed by Youenn Fablet. Implementation of function 'hasRegisteredName' was guarded by ENABLE_MDNS flag, but definition was not. * Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp: (WebKit::NetworkMDNSRegister::hasRegisteredName const): Canonical link: https://commits.webkit.org/276623@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 28f019: Cherry-pick 276622@main (aaef68ed33c2). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 28f0194c07a7629f869404af303d856ff652df82 https://github.com/WebKit/WebKit/commit/28f0194c07a7629f869404af303d856ff652df82 Author: Adrian Perez de Castro Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Tools/gtk/manifest.txt.in M Tools/wpe/manifest.txt.in Log Message: --- Cherry-pick 276622@main (aaef68ed33c2). https://bugs.webkit.org/show_bug.cgi?id=271644 [GLib] Script rewrite-compile-commands missing from release tarballs https://bugs.webkit.org/show_bug.cgi?id=271644 Reviewed by Michael Catanzaro. * Tools/gtk/manifest.txt.in: List Tools/Scripts/rewrite-compile-commands for inclusion in release tarballs. * Tools/wpe/manifest.txt.in: Ditto. Canonical link: https://commits.webkit.org/276622@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aaef68: [GLib] Script rewrite-compile-commands missing fro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aaef68ed33c21d9c87ec64da52af8082a08335f2 https://github.com/WebKit/WebKit/commit/aaef68ed33c21d9c87ec64da52af8082a08335f2 Author: Adrian Perez de Castro Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Tools/gtk/manifest.txt.in M Tools/wpe/manifest.txt.in Log Message: --- [GLib] Script rewrite-compile-commands missing from release tarballs https://bugs.webkit.org/show_bug.cgi?id=271644 Reviewed by Michael Catanzaro. * Tools/gtk/manifest.txt.in: List Tools/Scripts/rewrite-compile-commands for inclusion in release tarballs. * Tools/wpe/manifest.txt.in: Ditto. Canonical link: https://commits.webkit.org/276622@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b85d1: Cherry-pick 276621@main (d1482329e9e2). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 4b85d1752db83c03a865cea65125cc3b81216f32 https://github.com/WebKit/WebKit/commit/4b85d1752db83c03a865cea65125cc3b81216f32 Author: Philippe Normand Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp Log Message: --- Cherry-pick 276621@main (d1482329e9e2). https://bugs.webkit.org/show_bug.cgi?id=271611 [GStreamer][MSE] Leaks seek events https://bugs.webkit.org/show_bug.cgi?id=271611 Reviewed by Alicia Boya Garcia. The event ref passed to the send_event vfunc is transfer-full, so it needs to be adopted. When chaining to the parent class we transfer it back. * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: (webKitMediaSrcSendEvent): Canonical link: https://commits.webkit.org/276621@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d14823: [GStreamer][MSE] Leaks seek events
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1482329e9e22040aed5251aa90eb1becd3cf725 https://github.com/WebKit/WebKit/commit/d1482329e9e22040aed5251aa90eb1becd3cf725 Author: Philippe Normand Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp Log Message: --- [GStreamer][MSE] Leaks seek events https://bugs.webkit.org/show_bug.cgi?id=271611 Reviewed by Alicia Boya Garcia. The event ref passed to the send_event vfunc is transfer-full, so it needs to be adopted. When chaining to the parent class we transfer it back. * Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp: (webKitMediaSrcSendEvent): Canonical link: https://commits.webkit.org/276621@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42bc00: imported/w3c/web-platform-tests/webcodecs/videoFra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42bc00b84f3bf71daa1a91454460befba85d56d8 https://github.com/WebKit/WebKit/commit/42bc00b84f3bf71daa1a91454460befba85d56d8 Author: Youenn Fablet Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html is flaky https://bugs.webkit.org/show_bug.cgi?id=271460 rdar://125231124 Reviewed by Eric Carlson. Make sure to close VideoFrames explicitly to not trigger console warning messages about VideoFrames being GCed. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-serialization.crossAgentCluster.https.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276620@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 843aa5: Cherry-pick 276608@main (7e81143103b9). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 843aa547b17c3386aa260c9a8737ee434d054c25 https://github.com/WebKit/WebKit/commit/843aa547b17c3386aa260c9a8737ee434d054c25 Author: Philippe Normand Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp Log Message: --- Cherry-pick 276608@main (7e81143103b9). https://bugs.webkit.org/show_bug.cgi?id=266875 [GTK] Reproducible crash on invalid web process message DrawingArea_CommitTransientZoom https://bugs.webkit.org/show_bug.cgi?id=266875 Reviewed by Adrian Perez de Castro. Fix regression introduced by https://commits.webkit.org/272128@main. The message sender should expect a reply since that commit. * Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp: (WebKit::DrawingAreaProxyCoordinatedGraphics::commitTransientZoom): Canonical link: https://commits.webkit.org/276608@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0b7f7: New Test(254216@main): [ iOS Debug x86_64 wk2 ] fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0b7f7faeffb5ec679ddd471a0f7c68a91a37715 https://github.com/WebKit/WebKit/commit/a0b7f7faeffb5ec679ddd471a0f7c68a91a37715 Author: Youenn Fablet Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- New Test(254216@main): [ iOS Debug x86_64 wk2 ] fast/mediastream/getDisplayMedia-displaySurface.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=244913 rdar://99670481 Unreviewed. Since https://bugs.webkit.org/show_bug.cgi?id=269711, we have simplified capability ranges and have removed the deubg assert. We reenable the test given the crash is no longer there. * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/276619@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57d6d2: Cherry-pick 276612@main (6af38ff93284). https://bu...
Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 57d6d23bcdce94503fcd41cc5a8544e6d5845943 https://github.com/WebKit/WebKit/commit/57d6d23bcdce94503fcd41cc5a8544e6d5845943 Author: Adrian Perez de Castro Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/WebCore/PlatformGTK.cmake M Source/WebCore/PlatformWPE.cmake M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/WPEPlatform/CMakeLists.txt M Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h M Source/cmake/FindGBM.cmake M Source/cmake/FindLibDRM.cmake M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- Cherry-pick 276612@main (6af38ff93284). https://bugs.webkit.org/show_bug.cgi?id=271525 [GTK] Build broken with USE_GBM=OFF https://bugs.webkit.org/show_bug.cgi?id=271525 Reviewed by Michael Catanzaro. Add missing USE(GBM) guards, arrange to link against libdrm with USE_GBM=OFF and USE_LIBDRM=ON, and while at it convert the the libdrm CMake find-module to use imported targets. * Source/WebCore/PlatformGTK.cmake: Link libgbm or libdrm as appropriate. * Source/WebCore/PlatformWPE.cmake: Ditto. * Source/WebKit/PlatformGTK.cmake: Remove explicit libdrm linking, now using an imported target it gets pulled transitively due to WebKit linking against the WebCore target. * Source/WebKit/PlatformWPE.cmake: Ditto. * Source/WebKit/WPEPlatform/CMakeLists.txt: Link libgbm of libdrm as appropriate, remove specifying the libdrm include directory for GObject-Introspection as it gets pulled from transitively from the imported target. * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.cpp: (WebKit::AcceleratedSurfaceDMABuf::backgroundColorDidChange): Add missing USE(GBM) guard on usage of SwapChain::Type::EGLImage. * Source/WebKit/WebProcess/WebPage/dmabuf/AcceleratedSurfaceDMABuf.h: Only define SwapChain::Type::EGLImage with USE(GBM). * Source/cmake/FindGBM.cmake: Make the GBM::GBM target INTERFACE-depend on the LibDRM::LibDRM target, because headers from the former include headers from the latter. * Source/cmake/FindLibDRM.cmake: Convert to use imported targets, this is needed to make GBM::GBM depend on it, and simplifies CMake build files all around. * Source/cmake/OptionsGTK.cmake: Use LibDRM_FOUND instead of LIBDRM_FOUND. * Source/cmake/OptionsWPE.cmake: Ditto. Canonical link: https://commits.webkit.org/276612@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
