[webkit-changes] [WebKit/WebKit] 17c01d: [WebGPU] Use MESSAGE_CHECK instead of RELEASE_ASSE...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17c01d484bd83e089e42d7cc7343d1f84a28f8a9
  
https://github.com/WebKit/WebKit/commit/17c01d484bd83e089e42d7cc7343d1f84a28f8a9
  Author: Mike Wyrzykowski 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h

  Log Message:
  ---
  [WebGPU] Use MESSAGE_CHECK instead of RELEASE_ASSERT on the CoreIPC boundary
https://bugs.webkit.org/show_bug.cgi?id=271862


Reviewed by Tadeu Zagallo.

Use MESSAGE_CHECK instead of RELEASE_ASSERT.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp:
(WebKit::RemoteCommandEncoder::RemoteCommandEncoder):
(WebKit::RemoteCommandEncoder::beginRenderPass):
(WebKit::RemoteCommandEncoder::beginComputePass):
(WebKit::RemoteCommandEncoder::finish):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp:
(WebKit::RemoteDevice::createBuffer):
(WebKit::RemoteDevice::createTexture):
(WebKit::RemoteDevice::createSampler):
(WebKit::RemoteDevice::importExternalTextureFromVideoFrame):
(WebKit::RemoteDevice::createBindGroupLayout):
(WebKit::RemoteDevice::createPipelineLayout):
(WebKit::RemoteDevice::createBindGroup):
(WebKit::RemoteDevice::createShaderModule):
(WebKit::RemoteDevice::createComputePipeline):
(WebKit::RemoteDevice::createRenderPipeline):
(WebKit::RemoteDevice::createCommandEncoder):
(WebKit::RemoteDevice::createRenderBundleEncoder):
(WebKit::RemoteDevice::createQuerySet):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::createPresentationContext):
(WebKit::RemoteGPU::createCompositorIntegration):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp:
(WebKit::RemoteRenderBundleEncoder::RemoteRenderBundleEncoder):
(WebKit::RemoteRenderBundleEncoder::finish):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp:
(WebKit::RemoteTexture::RemoteTexture):
(WebKit::RemoteTexture::createView):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h:

Canonical link: https://commits.webkit.org/277049@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c7683: [web-animations] update WPT import for web-animations

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c76831f0cd0eb86c40b9ef7940b86c31f8ecc2f
  
https://github.com/WebKit/WebKit/commit/8c76831f0cd0eb86c40b9ef7940b86c31f8ecc2f
  Author: Antoine Quint 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/imported/w3c/resources/resource-files.json
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/resources/side-effects-common.js
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/resources/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-current-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-current-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-current.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-in-effect-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-in-effect-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-in-effect.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-none-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-none-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/side-effects-of-animations-none.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/crashtests/color-mix-crashtest.html
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/crashtests/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/progress.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/progress.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/scroll-timeline-progress.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/scroll-timeline-progress.tentative.html
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/background-position-responsive-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/background-position-responsive.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/box-shadow-responsive-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/box-shadow-responsive.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/neutral-keyframe-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/neutral-keyframe-ref.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/neutral-keyframe.html
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/responsive-test.js
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/toggle-animated-iframe-visibility.html
M 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/width-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/width.html
M LayoutTests/imported/w3c/web-platform-tests/web-animations/testcommon.js
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
M 

[webkit-changes] [WebKit/WebKit] 8ca189: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ca1894946dec87b304f3e7af7cb5d451eb76732
  
https://github.com/WebKit/WebKit/commit/8ca1894946dec87b304f3e7af7cb5d451eb76732
  Author: Fujii Hironori 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/277047@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fd6c3c: Subframe navigation is failing in extension popovers

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd6c3c9d46a0d20f4f13125568295e1b7fe017fd
  
https://github.com/WebKit/WebKit/commit/fd6c3c9d46a0d20f4f13125568295e1b7fe017fd
  Author: Elijah Sawyers 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/NavigationState.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm

  Log Message:
  ---
  Subframe navigation is failing in extension popovers
https://bugs.webkit.org/show_bug.cgi?id=272103
rdar://125800143

Reviewed by Brian Weinstein and Timothy Hatcher.

This patch fixes a bug where subframe navigation is blocked in extension 
popovers.
We have to loosen the constraints of isUnsupportedWebExtensionNavigation to 
allow
subframe navigation.

Additionally, this patch adds a new test to validate the fix.

* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::isUnsupportedWebExtensionNavigation):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIAction, SubframeNavigation)):

Canonical link: https://commits.webkit.org/277046@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2af8bf: [view-transitions] Add a timeout to the update cal...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2af8bf35f173cde9b114c2b371380ffae26fd3c7
  
https://github.com/WebKit/WebKit/commit/2af8bf35f173cde9b114c2b371380ffae26fd3c7
  Author: Tim Nguyen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-timeout-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-timeout.html
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h

  Log Message:
  ---
  [view-transitions] Add a timeout to the update callback
https://bugs.webkit.org/show_bug.cgi?id=272117
rdar://125877338

Reviewed by Ryosuke Niwa and Simon Fraser.

Implement step 9 of 
https://drafts.csswg.org/css-view-transitions-1/#call-dom-update-callback-algorithm

Follow Blink's timeout of 4 seconds: 
https://github.com/chromium/chromium/blob/a1aab3746bf8d8834086287b30c673e2a63eb633/third_party/blink/renderer/core/view_transition/view_transition.cc#L938-L945

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-timeout-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/update-callback-timeout.html:
 Added.
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupViewTransition):
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/277045@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2b1412: [Gardening]: REGRESSION (276827@main): [ MacOS wk1...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b1412d7e651358cad36e2c7a6c70ece4fb1ca7d
  
https://github.com/WebKit/WebKit/commit/2b1412d7e651358cad36e2c7a6c70ece4fb1ca7d
  Author: Jay Stfleur 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (276827@main): [ MacOS wk1 Debug ] 
tables/mozilla/bugs/bug4576.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=125879096
rdar://125879096

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277044@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 492d57: Use std::span more in WTFString

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 492d572f84caae7af7b09bc7b2d0da09cc6c4c1e
  
https://github.com/WebKit/WebKit/commit/492d572f84caae7af7b09bc7b2d0da09cc6c4c1e
  Author: Chris Dumez 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/IntlNumberFormat.cpp
M Source/WTF/wtf/text/AtomString.h
M Source/WTF/wtf/text/IntegerToStringConversion.h
M Source/WTF/wtf/text/StringBuilder.cpp
M Source/WTF/wtf/text/StringBuilder.h
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WTF/wtf/text/StringImpl.h
M Source/WTF/wtf/text/StringView.h
M Source/WTF/wtf/text/WTFString.cpp
M Source/WTF/wtf/text/WTFString.h

  Log Message:
  ---
  Use std::span more in WTFString
https://bugs.webkit.org/show_bug.cgi?id=272067

Reviewed by Darin Adler.

* Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:
(JSC::computeCurrencySortKey):
(JSC::extractCurrencySortKey):
(JSC::computeCurrencyDigits):
* Source/WTF/wtf/text/ASCIILiteral.h:
(WTF::StringLiterals::operator _charspan):
* Source/WTF/wtf/text/AtomString.h:
(WTF::IntegerToStringConversionTrait::flush):
* Source/WTF/wtf/text/IntegerToStringConversion.h:
(WTF::numberToStringImpl):
* Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::appendCharacters):
(WTF::IntegerToStringConversionTrait::flush):
* Source/WTF/wtf/text/StringImpl.h:
(WTF::containsOnly):
(WTF::isSpecialCharacter const):
* Source/WTF/wtf/text/StringView.h:
(WTF::isSpecialCharacter const):
* Source/WTF/wtf/text/WTFString.cpp:
(WTF::String::ascii const):
(WTF::String::latin1 const):
* Source/WTF/wtf/text/WTFString.h:
(WTF::IntegerToStringConversionTrait::flush):

Canonical link: https://commits.webkit.org/277043@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f3925d: Some API tests started crashing in CFRelease after...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3925d705c14b41a1722888fd11619e5ab1779ba
  
https://github.com/WebKit/WebKit/commit/f3925d705c14b41a1722888fd11619e5ab1779ba
  Author: Chris Dumez 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm

  Log Message:
  ---
  Some API tests started crashing in CFRelease after macOS update
https://bugs.webkit.org/show_bug.cgi?id=272110
rdar://125807895

Reviewed by Brady Eidson and Sihui Liu.

Our API test was unsafe as it was not ref'ing autoreleased
NSStrings / NSURLs and expecting them to still be alive after
calling some async operations.

Update those tests to use RetainPtr more consistently.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:
(TEST(IndexedDB, CheckpointsWALAutomatically)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(runMultipleIndicesTestWithDatabase):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
(IndexedDBThirdPartyStorageLayout)):
((IndexedDB, IndexedDBGetDatabases)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
(TEST(IndexedDB, IndexedDBTempFileSize)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
(TEST(IndexedDB, StoreBlobThenRemoveData)):
(TEST(IndexedDB, StoreBlobThenDeleteDatabase)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
((WKWebsiteDataStore, RemoveServiceWorkerData)):

Canonical link: https://commits.webkit.org/277042@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e7316: Any early attempt to load the background page shou...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e7316e13961cb67eede460d56d8ddffc7e4f2d1
  
https://github.com/WebKit/WebKit/commit/2e7316e13961cb67eede460d56d8ddffc7e4f2d1
  Author: Kiara Rose 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  ---
  Any early attempt to load the background page should return early
https://bugs.webkit.org/show_bug.cgi?id=272120
rdar://12586

Reviewed by Brian Weinstein.

We return early for premature background page loads. But we're not doing this 
after toggling the enabled
state of the extension. To fix this, we should set 
`m_safeToLoadBackgroundContent` back to false when
the extension unloads, since we use this variable to check if we should return 
early in
`loadBackgroundWebViewIfNeeded`.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::unload):

Canonical link: https://commits.webkit.org/277041@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31c43b: [WebXR] Depth values are not correct

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31c43b74127b146546cf4bae0509bc3e62dc9c25
  
https://github.com/WebKit/WebKit/commit/31c43b74127b146546cf4bae0509bc3e62dc9c25
  Author: Mike Wyrzykowski 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp

  Log Message:
  ---
  [WebXR] Depth values are not correct
https://bugs.webkit.org/show_bug.cgi?id=272119


Reviewed by Dan Glastonbury.

Compositor expects reverse-Z but WebXR writes forward Z values, so
just zero them for now so the reprojection doesn't cause jittering.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::blitSharedToLayered):

Canonical link: https://commits.webkit.org/277040@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ae2a09: disable i386 swift module compilation for watch si...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae2a0966fb718e40529940a5afb634e91d84e163
  
https://github.com/WebKit/WebKit/commit/ae2a0966fb718e40529940a5afb634e91d84e163
  Author: Nitin Mahendru 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/PAL/Configurations/PAL.xcconfig

  Log Message:
  ---
  disable i386 swift module compilation for watch simulator
https://bugs.webkit.org/show_bug.cgi?id=271926
rdar://125645416

Reviewed by Elliott Williams.

WebKit does not support it and there is no need for PAL module to generate i386
swift modules. PAL don't expose the swift modules.
Xcode by default will generate swift modules for i386 for watch simulator only.
So this additional setting should disable it.

* Source/WebCore/PAL/Configurations/PAL.xcconfig:

Canonical link: https://commits.webkit.org/277039@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58a545: [Remote Inspection] Frequent targeted element requ...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58a545029fd142c73099d59e6e3a601a6c034dc4
  
https://github.com/WebKit/WebKit/commit/58a545029fd142c73099d59e6e3a601a6c034dc4
  Author: Wenson Hsieh 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/ElementTargetingController.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-2.html

  Log Message:
  ---
  [Remote Inspection] Frequent targeted element requests can break automatic 
visibility adjustment
https://bugs.webkit.org/show_bug.cgi?id=272068

Reviewed by Tim Horton.

Currently, `m_pendingAdjustmentClientRects` cleared out and recomputed in
`ElementTargetingController` when the WebKit client requests targeted element 
information; this
cache is then consulted when the client goes to adjust visibility for these 
previously requested
elements, to update visibility adjustment coverage regions (in client 
coordinates). By clearing out
`m_pendingAdjustmentClientRects`, we avoid unbounded growth in this map, as the 
user targets
elements around the page.

However, this strategy has a subtle flaw — it's possible for the client to 
perform another targeted
element request in between the first targeting request, and visibility 
adjustment; in this case, if
the request finds different hit-tested elements (e.g. in the case where the 
targeted element has
already been unparented), we'll end up with no cached client rects at adjustent 
time, since the
second request would've cleared out the cached rects.

Fix this race by not clearing out this client rect cache during each targeting 
request; instead, we
prevent unbounded growth by scheduling a timer to perform cache cleanup, once 
no more targeting
requests are received. This works well in practice, since the cache doesn't get 
very large to begin
with (in real use cases), so there's no need to aggressively clear out the map.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ElementTargetingController::findTargets):

Restart the client rect cleanup timer whenever we receive another request to 
target elements. After
a somewhat-arbitrary 15 seconds of inactivity, purge the client rect cache.

(WebCore::ElementTargetingController::adjustVisibility):
(WebCore::ElementTargetingController::reset):
(WebCore::ElementTargetingController::cleanUpAdjustmentClientRects):
* Source/WebCore/page/ElementTargetingController.h:

Add a timer that cleans up `m_recentAdjustmentClientRects` when fired. 
Additionally, rename what is
currently `m_pendingAdjustmentClientRects` to `m_recentAdjustmentClientRects`, 
now that this map no
longer tracks only the last set of targeted elements that are pending 
visibility adjustment.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting, NearbyOutOfFlowElements)):
(TestWebKitAPI::TEST(ElementTargeting, AdjustVisibilityForUnparentedElement)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-2.html:

Augment an existing API test to cover this corner case.

Canonical link: https://commits.webkit.org/277038@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d12bc: [WebXR] WebXR should base its foveation on the app...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d12bc5c1a01933bbd3edd6ecef280e2bc58afac
  
https://github.com/WebKit/WebKit/commit/4d12bc5c1a01933bbd3edd6ecef280e2bc58afac
  Author: Mike Wyrzykowski 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.h
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm
M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp

  Log Message:
  ---
  [WebXR] WebXR should base its foveation on the app's setting
https://bugs.webkit.org/show_bug.cgi?id=272069


Reviewed by Tim Horton.

Respect the app's foveation setting.

Also fixup the viewport transformation.

* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:
(rx::ContextMtl::setupDrawImpl):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.h:
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm:
(rx::mtl::RenderCommandEncoder::setViewport):
(rx::mtl::RenderCommandEncoder::rasterizationRateMapForPass const):
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_render_utils.mm:
(rx::mtl::ClearUtils::setupClearWithDraw):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::usesLayeredMode const):
(WebCore::WebXROpaqueFramebuffer::blitSharedToLayered):
(WebCore::convertViewportToPhysicalCoordinates):
(WebCore::WebXROpaqueFramebuffer::drawViewport const):
(WebCore::displayLayout):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
* Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::computeViewports):

Canonical link: https://commits.webkit.org/277037@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 730e0f: [Gardening]: REGRESSION (274826@main): [ Sonoma WK...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 730e0ffe23b1848d9f0e1e7694f0590b5d2ac958
  
https://github.com/WebKit/WebKit/commit/730e0ffe23b1848d9f0e1e7694f0590b5d2ac958
  Author: Jay Stfleur 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: REGRESSION (274826@main): [ Sonoma WK1 ] 2X 
imported/w3c/web-platform-tests/mixed-content/tentative/autoupgrades tests are 
flaky failures
https://bugs.webkit.org/show_bug.cgi?id=125870094
rdar://125870094

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277036@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fef30a: Thread safety warning: MediaFormatReader m_duratio...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fef30aefacf72c9c0cb3ce0a2d84fd3bd7fbf4b7
  
https://github.com/WebKit/WebKit/commit/fef30aefacf72c9c0cb3ce0a2d84fd3bd7fbf4b7
  Author: Jer Noble 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp
M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h

  Log Message:
  ---
  Thread safety warning: MediaFormatReader m_duration is unprotected by 
m_parseTracksLock
rdar://124551630
https://bugs.webkit.org/show_bug.cgi?id=272048

Reviewed by Eric Carlson.

In addition to holding the lock when accessing m_duration, we should also not 
be handing
a reference to an internal variable that can be modified off the calling thread.

* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::duration const):
* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.h:

Canonical link: https://commits.webkit.org/277035@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fb4251: Web Inspector: Console and code editor completion ...

[Qianlang Chen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb425171fec8fd7ecc3a326e6f62aafcbc674974
  
https://github.com/WebKit/WebKit/commit/fb425171fec8fd7ecc3a326e6f62aafcbc674974
  Author: Qianlang Chen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js

  Log Message:
  ---
  Web Inspector: Console and code editor completion does not auto-scroll 
suggestion into view
rdar://124979790
https://bugs.webkit.org/show_bug.cgi?id=271205

Reviewed by Devin Rousso.

In the original code, there is logic to scroll a newly-selected item
into view in the `CompletionSuggestionsView.selectedIndex` setter, but
when the list of suggestions is updated with the `update` method, there
is no similar logic to scroll the default selection into view.

* Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView.prototype.update):
   - Make sure to let the to-be-selected element scrollIntoViewIfNeeded.

Canonical link: https://commits.webkit.org/277034@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4754c8: REGRESSION (275949@main): 18 imported WPT /i18n/.....

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4754c8d81df8cfe4e842b7aa4d1173b3bc59f5be
  
https://github.com/WebKit/WebKit/commit/4754c8d81df8cfe4e842b7aa4d1173b3bc59f5be
  Author: Alan Baradlay 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations
M 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp
M 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.h
M 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionContext.h

  Log Message:
  ---
  REGRESSION (275949@main): 18 imported WPT /i18n/.../css-text-line-break* 
tests are consistent/flaky failures.
https://bugs.webkit.org/show_bug.cgi?id=270860


Reviewed by Antti Koivisto.

Same content with different locale may produce different soft wrap 
opportunities. Let's include computedLocal in the key.

* LayoutTests/platform/mac/TestExpectations:
* 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp:
(WebCore::Layout::add):
* 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.h:
* 
Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionContext.h:
(WebCore::Layout::TextBreakingPositionContext::TextBreakingPositionContext):

Canonical link: https://commits.webkit.org/277033@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 76dc1d: Make WebCore::IDBSerializationContext testable

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76dc1d42c4219e4ae8beb7fb639f76382350fee8
  
https://github.com/WebKit/WebKit/commit/76dc1d42c4219e4ae8beb7fb639f76382350fee8
  Author: David Kilzer 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/indexeddb/IDBValue.h
M Source/WebCore/bindings/js/IDBBindingUtilities.h

  Log Message:
  ---
  Make WebCore::IDBSerializationContext testable
https://bugs.webkit.org/show_bug.cgi?id=272032


Reviewed by Sihui Liu.

Original patch by Jesse Hertz.

* Source/WebCore/Modules/indexeddb/IDBValue.h:
(WebCore::IDBValue::IDBValue):
* Source/WebCore/bindings/js/IDBBindingUtilities.h:
(WebCore::deserializeIDBValueToJSValue):
(WebCore::callOnIDBSerializationThreadAndWait):
- Export methods to make the code testable.

Canonical link: https://commits.webkit.org/277032@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c73791: [visionOS] After exiting docked fullscreen, elemen...

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c73791d25f70d40a33c043af83c786729448e796
  
https://github.com/WebKit/WebKit/commit/c73791d25f70d40a33c043af83c786729448e796
  Author: Andy Estes 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm

  Log Message:
  ---
  [visionOS] After exiting docked fullscreen, element fullscreen window 
contains only a view snapshot
https://bugs.webkit.org/show_bug.cgi?id=272114
rdar://125734832

Reviewed by Jer Noble.

Element fullscreen expects to exit when switching to LinearMediaPlayer 
fullscreen, but we lack the
API from LinearMediaKit to do this properly. As a result, when exiting 
LinearMediaKit fullscreen the
element fullscreen window remains visible with a view snapshot displayed in 
place of the web view.
Work around this issue by exiting element fullscreen when we receive a video 
receiver endpoint.

* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionManagerProxy::setVideoReceiverEndpoint):

Canonical link: https://commits.webkit.org/277031@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 256947: [Navigation] Process NavigateEvent earlier in Fram...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25694764feddef056fca34e4757708ef5cd45503
  
https://github.com/WebKit/WebKit/commit/25694764feddef056fca34e4757708ef5cd45503
  Author: Rob Buis 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt
M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  ---
  [Navigation] Process NavigateEvent earlier in FrameLoader::loadInSameDocument
https://bugs.webkit.org/show_bug.cgi?id=271464

Reviewed by Alex Christensen.

Process NavigateEvent earlier in FrameLoader::loadInSameDocument, this allows 
us to properly determine same document
and hashChange values, before updating the document url. Also now we react to 
preventDefault() calls by doing an early return.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-anchor-fragment-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-destination-getState-back-forward-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/navigate-svg-anchor-fragment-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):

Canonical link: https://commits.webkit.org/277030@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5c78bf: BBQ has spurious assertion for zero-frame leaf fun...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c78bf00205e1af497ee267a81415a01f4201193
  
https://github.com/WebKit/WebKit/commit/5c78bf00205e1af497ee267a81415a01f4201193
  Author: Justin Michaud 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  ---
  BBQ has spurious assertion for zero-frame leaf functions
https://bugs.webkit.org/show_bug.cgi?id=272066
rdar://125620937

Reviewed by Yusuke Suzuki.

It's fine for there to be a zero-sized stack check from BBQ.

* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::parseAndCompileBBQ):

Canonical link: https://commits.webkit.org/277029@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 230649: [JFC] Enable LTO for Apple Watch

[AtariDreams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 230649e15f7c1de2b8e0441161fdc936bfda9679
  
https://github.com/WebKit/WebKit/commit/230649e15f7c1de2b8e0441161fdc936bfda9679
  Author: Rose <83477269+ataridre...@users.noreply.github.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig

  Log Message:
  ---
  [JFC] Enable LTO for Apple Watch
https://bugs.webkit.org/show_bug.cgi?id=272052

Reviewed by Alexey Proskuryakov.

LTO can work on Apple Watch now that the issue has
been fixed.

* Source/JavaScriptCore/Configurations/Base.xcconfig:
Enable LTO for Apple Watch.

Canonical link: https://commits.webkit.org/277028@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5180ad: _WKWebExtensionDataRecord.errors shouldn't return ...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5180add1072b2fa2b4007c230cab8327563a3ae7
  
https://github.com/WebKit/WebKit/commit/5180add1072b2fa2b4007c230cab8327563a3ae7
  Author: Kiara Rose 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionDataRecord.h

  Log Message:
  ---
  _WKWebExtensionDataRecord.errors shouldn't return a nil array
https://bugs.webkit.org/show_bug.cgi?id=272102
rdar://125862003

Reviewed by Brian Weinstein and Timothy Hatcher.

Return an empty array if there are no errors for the WebExtensionDataRecord.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm:
(WebKit::WebExtensionDataRecord::errors):
* Source/WebKit/UIProcess/Extensions/WebExtensionDataRecord.h:
(WebKit::WebExtensionDataRecord::errors): Deleted.

Canonical link: https://commits.webkit.org/277027@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a52a8a: [LayoutTests] Add speech-synthesis-gc-utterance-ca...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a52a8a1177815b4e150d1d355317bd5cfe8ebc2a
  
https://github.com/WebKit/WebKit/commit/a52a8a1177815b4e150d1d355317bd5cfe8ebc2a
  Author: Jonathan Bedard 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A 
LayoutTests/fast/speechsynthesis/mac/speech-synthesis-gc-utterance-cancel-crash-expected.txt
A 
LayoutTests/fast/speechsynthesis/mac/speech-synthesis-gc-utterance-cancel-crash.html

  Log Message:
  ---
  [LayoutTests] Add speech-synthesis-gc-utterance-cancel-crash.html
https://bugs.webkit.org/show_bug.cgi?id=272097
rdar://125857266

Reviewed by Alexey Proskuryakov.

* 
LayoutTests/fast/speechsynthesis/mac/speech-synthesis-gc-utterance-cancel-crash-expected.txt:
 Added.
* 
LayoutTests/fast/speechsynthesis/mac/speech-synthesis-gc-utterance-cancel-crash.html:
 Added.

Canonical link: https://commits.webkit.org/277026@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 841e14: Adopt std::span in more places

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 841e14710a42738a5f3d202e572058a8953ffca1
  
https://github.com/WebKit/WebKit/commit/841e14710a42738a5f3d202e572058a8953ffca1
  Author: Chris Dumez 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h
M Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformerCocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp
M Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp
M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp
M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.h
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheData.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
M Source/WebKit/Platform/IPC/DaemonCoders.h
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp
M Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm
M Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h

  Log Message:
  ---
  Adopt std::span in more places
https://bugs.webkit.org/show_bug.cgi?id=272070

Reviewed by Darin Adler.

* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::GPUQueue::writeBuffer):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.cpp:
(WebCore::WebGPU::QueueImpl::writeBuffer):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUQueueImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUQueue.h:
* Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformerCocoa.cpp:
(WebCore::RTCRtpSFrameTransformer::computeSaltKey):
(WebCore::createBaseSFrameKey):
(WebCore::RTCRtpSFrameTransformer::computeAuthenticationKey):
(WebCore::RTCRtpSFrameTransformer::computeEncryptionKey):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp:
(WebCore::keyDerivationHMAC):
(WebCore::deriveHDKFBits):
(WebCore::deriveHDKFSHA256Bits):
(WebCore::calculateHMACSignature):
(WebCore::calculateSHA256Signature):
* Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.h:
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp:
(WebKit::RemoteQueue::writeBuffer):
* Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::Data):
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:
(WebKit::NetworkCache::Data::Data):
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp:
(WebKit::NetworkCache::Data::Data):
* Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::encodeAsStorageRecord const):
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::encodeRecordMetaData):
* Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:
(WebKit::NetworkCache::SubresourcesEntry::encodeAsStorageRecord const):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::processUDPData):
(WebKit::NetworkRTCUDPSocketCocoaConnections::setupNWConnection):
* Source/WebKit/Platform/IPC/DaemonCoders.h:
(WebKit::Daemon::Coder::encode):
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::getSerializedFormat):
* Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::encodeContentRuleListMetaData):
(API::compiledToFile):
* Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm:
(WebKit::GPUProcessProxy::sendBookmarkDataForCacheDirectory):
* Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::HistoryEntryDataEncoder::encodeArithmeticType):
(WebKit::HistoryEntryDataEncoder::encodeFixedLengthData):
(WebKit::HistoryEntryDataDecoder::HistoryEntryDataDecoder):
(WebKit::decodeSessionHistoryEntryData):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.cpp:
(WebKit::WebGPU::RemoteQueueProxy::writeBuffer):
* 

[webkit-changes] [WebKit/WebKit] 0592c3: [view-transitions] Skip view transition when viewp...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0592c365e74a51c1b37ad0a6a8c8d685f3b35656
  
https://github.com/WebKit/WebKit/commit/0592c365e74a51c1b37ad0a6a8c8d685f3b35656
  Author: Tim Nguyen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-before-ready-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/wpe/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/dom/ViewTransition.h

  Log Message:
  ---
  [view-transitions] Skip view transition when viewport size changes
https://bugs.webkit.org/show_bug.cgi?id=271302
rdar://125067725

Reviewed by Matt Woodrow.

Skip view transition when large viewport unit size changes, choose large 
viewport units given they have the correct behavior of not skipping the 
transition when
toggling the top navigation bar on mobile Safari.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-before-ready-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::skipViewTransition):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::activateViewTransition):
(WebCore::ViewTransition::handleTransitionFrame):
* Source/WebCore/dom/ViewTransition.h:

Canonical link: https://commits.webkit.org/277024@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 191d3f: [JSC] Update `expectations.yaml` for `/built-ins/F...

[SUZUKI Sosuke]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 191d3fc6487b1d0687fbc826509b9cf9ece7aa96
  
https://github.com/WebKit/WebKit/commit/191d3fc6487b1d0687fbc826509b9cf9ece7aa96
  Author: Sosuke Suzuki 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M JSTests/test262/expectations.yaml

  Log Message:
  ---
  [JSC] Update `expectations.yaml` for `/built-ins/Function/prototype/toString/`
https://bugs.webkit.org/show_bug.cgi?id=272082

Reviewed by Yusuke Suzuki.

https://commits.webkit.org/276904@main changed the output of 
Function.prototype.toString. This also changed the failure messages in test262. 
However, updating expectations.yaml was forgotten. This patch updates 
expectations.yaml.

* JSTests/test262/expectations.yaml:

Canonical link: https://commits.webkit.org/277023@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] adf972: Figure out how to tell if a Web Extension has been...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adf9728dc4e18d23d5393998b76018b74154b910
  
https://github.com/WebKit/WebKit/commit/adf9728dc4e18d23d5393998b76018b74154b910
  Author: Timothy Hatcher 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WTF/wtf/spi/cocoa/SecuritySPI.h
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h

  Log Message:
  ---
  Figure out how to tell if a Web Extension has been updated in WebKit.
https://webkit.org/b/249266
rdar://problem/103573769

Reviewed by Brian Weinstein.

Use the code signing hash from the app extension bundle to tell if an extension
has updated. This will change after building in Xcode or via App Store updates.
There is no quick way to do this for non-bundle code paths, so we still consider
an extension updated if the version in the manifest changes.

Unfortunately, there is no way to test this with TestWebKitAPI currently since 
it requires
an extension to be loaded from a bundle, code signed, updated, and reloaded. I 
was able
to manually test this against extensions loaded in Safari.

* Source/WTF/wtf/spi/cocoa/SecuritySPI.h: Added functions and types for iOS and 
macOS.
* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIScriptingCocoa.mm:
(WebKit::WebExtensionContext::clearRegisteredContentScripts): Added.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::bundleStaticCode const): Made const, use bridge_cast().
(WebKit::WebExtension::bundleHash const): Added.
(WebKit::WebExtension::validateResourceData): Store staticCode in variable. Use 
bridge_cast().
(WebKit::WebExtension::imageForPath): Use bridge_cast().
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::load): Call determineInstallReasonDuringLoad().
(WebKit::WebExtensionContext::loadBackgroundWebViewDuringLoad):
(WebKit::WebExtensionContext::determineInstallReasonDuringLoad): Renamed. Drop 
writeStateToStorage()
since it is already done by the caller in load(). Save and compare the 
bundleHash() to determine updates.
Always set LastSeenVersion. Call clearRegisteredContentScripts() when extension 
updates.
(WebKit::WebExtensionContext::queueStartupAndInstallEventsForExtensionIfNecessary):
 Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionContext.h:

Canonical link: https://commits.webkit.org/277022@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ce8f32: [Gardening]: [ Sonoma WK1 ] 7X imported/w3c/web-pl...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce8f320abb693b6c881cb490a9d62b408f357f31
  
https://github.com/WebKit/WebKit/commit/ce8f320abb693b6c881cb490a9d62b408f357f31
  Author: Jay Stfleur 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  [Gardening]: [ Sonoma WK1 ] 7X imported/w3c/web-platform-tests/worklets tests 
are flaky failures
https://bugs.webkit.org/show_bug.cgi?id=125862089
rdar://125862089

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/277021@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b7d41: CheckedPtr should require FastMalloc, Part 2

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b7d41505065a3dacb612e0dc4112df118590c05
  
https://github.com/WebKit/WebKit/commit/8b7d41505065a3dacb612e0dc4112df118590c05
  Author: Geoffrey Garen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CheckedRef.h
M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/animation/DocumentTimelinesController.h
M Source/WebCore/bindings/js/ScriptController.h
M Source/WebCore/dom/CustomElementDefaultARIA.h
M Source/WebCore/dom/CustomElementReactionQueue.h
M Source/WebCore/dom/DocumentMarkerController.h
M Source/WebCore/dom/EventLoop.h
M Source/WebCore/dom/ExtensionStyleSheets.h
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/dom/IdTargetObserver.h
M Source/WebCore/dom/IdTargetObserverRegistry.h
M Source/WebCore/dom/PendingScriptClient.h
M Source/WebCore/dom/RejectedPromiseTracker.h
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/dom/VisitedLinkState.h
M Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
M Source/WebCore/dom/messageports/WorkerMessagePortChannelProvider.h
M Source/WebCore/editing/Editor.h
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/editing/TextManipulationController.h
M Source/WebCore/history/BackForwardController.h
M Source/WebCore/history/CachedPage.h
M Source/WebCore/html/parser/HTMLDocumentParser.h
M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/FrameLoader.h
M Source/WebCore/loader/HistoryController.h
M Source/WebCore/loader/NavigationScheduler.h
M Source/WebCore/loader/ProgressTracker.h
M Source/WebCore/loader/ThreadableLoaderClient.h
M Source/WebCore/page/AlternativeTextClient.h
M Source/WebCore/page/DeviceController.h
M Source/WebCore/page/DiagnosticLoggingClient.h
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/EventHandler.h
M Source/WebCore/page/FocusController.h
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/PageConsoleClient.h
M Source/WebCore/page/csp/ContentSecurityPolicy.h
M Source/WebCore/page/scrolling/ScrollingStateTree.h
M Source/WebCore/platform/KeyboardScrollingAnimator.h
M Source/WebCore/platform/OrientationNotifier.h
M Source/WebCore/platform/ScrollView.h
M Source/WebCore/platform/ScrollableArea.cpp
M Source/WebCore/platform/ScrollableArea.h
M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/graphics/DisplayRefreshMonitorClient.h
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/GlyphBuffer.h
M Source/WebCore/platform/graphics/TextRun.cpp
M Source/WebCore/platform/graphics/TextRun.h
M Source/WebCore/platform/graphics/TiledBacking.h
M Source/WebCore/platform/graphics/WidthIterator.cpp
M Source/WebCore/platform/graphics/ca/LayerPool.h
M Source/WebCore/platform/graphics/cocoa/NullPlaybackSessionInterface.h
M Source/WebCore/platform/graphics/cocoa/NullVideoPresentationInterface.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceIOS.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h
M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateMock.h
M Source/WebCore/platform/mediastream/AudioTrackPrivateMediaStream.h
M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
M 
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp
M 
Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderCocoa.h
M Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h
M Source/WebCore/platform/network/curl/CurlMultipartHandleClient.h
M Source/WebCore/platform/network/curl/CurlRequest.h
M Source/WebCore/platform/sql/SQLiteDatabase.h
M Source/WebCore/rendering/LegacyRootInlineBox.cpp
M 

[webkit-changes] [WebKit/WebKit] 836cb9: [content-visibility] ASSERTION FAILED: !renderer.n...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 836cb999ce8c37075ae7c05ef485328a4b96e73c
  
https://github.com/WebKit/WebKit/commit/836cb999ce8c37075ae7c05ef485328a4b96e73c
  Author: Vitaly Dyachkov 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wk2/TestExpectations
M Source/WebCore/rendering/RenderDescendantIterator.h
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderIterator.h

  Log Message:
  ---
  [content-visibility] ASSERTION FAILED: !renderer.needsLayout() causing 
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-video.html
 to constantly crash
https://bugs.webkit.org/show_bug.cgi?id=262157

Reviewed by Darin Adler.

Normally, when we do `RenderElement::layout()`, we first lay out its
children and then clear the `needsLayout` flag. When assertions are
enabled, in `RenderObject::clearNeedsLayout()` we check that
block-positioned children don't need layout.

But if the element is skipped for layout, we call
`RenderElement::clearNeedsLayoutForSkippedContent()` instead.

As the first step, this method calls `RenderObject::clearNeedsLayout()`
on every descendent. Note that it won't lay out the descendant's
children but will still check that the block-positioned children of the
descendent don't need layout, which might be false and cause the
assertion to fail.

This patch implements `descendantsOfTypePostOrder()` function which
is then used to guarantee that `RenderElement`'s needs-layout flag is
always cleared after its children.

* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wk2/TestExpectations:
* Source/WebCore/rendering/RenderDescendantIterator.h:
(WebCore::RenderDescendantPostOrderIterator::RenderDescendantPostOrderIterator):
(WebCore::RenderDescendantPostOrderIterator::operator):
(WebCore::RenderDescendantPostOrderConstIterator::RenderDescendantPostOrderConstIterator):
(WebCore::RenderDescendantPostOrderConstIterator::operator):
(WebCore::RenderDescendantPostOrderIteratorAdapter::RenderDescendantPostOrderIteratorAdapter):
(WebCore::RenderDescendantPostOrderIteratorAdapter::begin):
(WebCore::RenderDescendantPostOrderIteratorAdapter::end):
(WebCore::RenderDescendantPostOrderIteratorAdapter::at):
(WebCore::RenderDescendantPostOrderConstIteratorAdapter::RenderDescendantPostOrderConstIteratorAdapter):
(WebCore::RenderDescendantPostOrderConstIteratorAdapter::begin const):
(WebCore::RenderDescendantPostOrderConstIteratorAdapter::end const):
(WebCore::RenderDescendantPostOrderConstIteratorAdapter::at const):
(WebCore::descendantsOfTypePostOrder):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::clearNeedsLayoutForSkippedContent):
* Source/WebCore/rendering/RenderIterator.h:
(WebCore::RenderPostOrderIterator::operator bool const):
(WebCore::RenderPostOrderConstIterator::operator bool const):
(WebCore::RenderObjectPostOrderTraversal::next):
(WebCore::RenderPostOrderTraversal::firstWithin):
(WebCore::RenderPostOrderTraversal::next):
(WebCore::RenderPostOrderIterator::RenderPostOrderIterator):
(WebCore::RenderPostOrderIterator::traverseNext):
(WebCore::RenderPostOrderIterator::operator):
(WebCore::= const):
(WebCore::RenderPostOrderConstIterator::RenderPostOrderConstIterator):
(WebCore::RenderPostOrderConstIterator::traverseNext):
(WebCore::RenderPostOrderConstIterator::operator const):
(WebCore:: const):

Canonical link: https://commits.webkit.org/277019@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 95a0fa: Functionally fix fast/loader/window-open-to-invali...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95a0fa3e3d5ee8a82829bb5939c033ac88fc6cd8
  
https://github.com/WebKit/WebKit/commit/95a0fa3e3d5ee8a82829bb5939c033ac88fc6cd8
  Author: Alex Christensen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  ---
  Functionally fix 
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html with 
--site-isolation
https://bugs.webkit.org/show_bug.cgi?id=272092

Reviewed by Per Arne Vollan.

This fixes two issues.  The first is that the test calls window.open with _top 
as the second parameter,
and when running with --site-isolation the top frame is a RemoteFrame, so I 
moved a few dynamicDowncast
calls from LocalDOMWindow::open to only be where we really need a LocalFrame.

The second issue is that we were calling 
WebProcessProxy::fontdMachExtensionHandles multiple times for the same
process, which caused an assertion and is unnecessary.  Fix that by only 
calling it once per process, since
it is a process-global thing.

This makes the test pass except for another change needed to 
printNavigationErrorMessage which I'll do in a separate
PR because that will need to remove the frame URL of the frame we attempted to 
navigate, which is unavailable and
should not be available if it is a RemoteFrame.  I'll do that in a separate PR 
because it'll require updating 64
test expectations files.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::open):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry):
* Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::fontdMachExtensionHandles):
(WebKit::WebProcessProxy::fontdMachExtensionHandles const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/277018@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 664b7b: Expose more type metadata to IPC test API

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 664b7bf627029f4ce7a114f132974308189ab7b6
  
https://github.com/WebKit/WebKit/commit/664b7bf627029f4ce7a114f132974308189ab7b6
  Author: Alex Christensen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in
M Source/WebCore/platform/PlatformMediaError.h
M Source/WebCore/svg/SVGPreserveAspectRatioValue.h
M Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in
M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in
M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/cf/CoreIPCCGColorSpace.serialization.in
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in
M 
Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemoteMessageReceiver.messages.in
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebProcess.messages.in
M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  ---
  Expose more type metadata to IPC test API
https://bugs.webkit.org/show_bug.cgi?id=272071

Reviewed by Brady Eidson.

* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in:
* Source/WebCore/platform/PlatformMediaError.h:
* Source/WebCore/svg/SVGPreserveAspectRatioValue.h:
* Source/WebKit/GPUProcess/graphics/PathSegment.serialization.in:
* Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
* Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/cf/CoreIPCCGColorSpace.serialization.in:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
* 
Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemoteMessageReceiver.messages.in:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebProcess.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(SerializedTypeInfo)):

Canonical link: https://commits.webkit.org/277017@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6094d4: AX: Move accessibility/combobox/combobox-collapsed...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6094d45639abdda18ec3a4791016ffc7eed86e81
  
https://github.com/WebKit/WebKit/commit/6094d45639abdda18ec3a4791016ffc7eed86e81
  Author: Andres Gonzalez 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
R 
LayoutTests/accessibility/combobox/combobox-collapsed-selection-changed-expected.txt
R 
LayoutTests/accessibility/combobox/combobox-collapsed-selection-changed.html
A 
LayoutTests/accessibility/combobox/gtk/combobox-collapsed-selection-changed-expected.txt
A 
LayoutTests/accessibility/combobox/gtk/combobox-collapsed-selection-changed.html
R 
LayoutTests/platform/glib/accessibility/combobox/combobox-collapsed-selection-changed-expected.txt
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  AX: Move accessibility/combobox/combobox-collapsed-selection-changed.html 
under gtk since it is a glib-only test.
https://bugs.webkit.org/show_bug.cgi?id=271980


Unreviewed test gardening.

Followup to https://bugs.webkit.org/show_bug.cgi?id=271844.

* 
LayoutTests/accessibility/combobox/combobox-collapsed-selection-changed-expected.txt:
 Removed.
* 
LayoutTests/accessibility/combobox/gtk/combobox-collapsed-selection-changed-expected.txt:
 Renamed from 
LayoutTests/platform/glib/accessibility/combobox/combobox-collapsed-selection-changed-expected.txt.
* 
LayoutTests/accessibility/combobox/gtk/combobox-collapsed-selection-changed.html:
 Renamed from 
LayoutTests/accessibility/combobox/combobox-collapsed-selection-changed.html.
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277016@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4f1ded: REGRESSION (UI-side compositing) overflow:scroll i...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f1ded96b3967cf2de4cc260b1e49940e93822e4
  
https://github.com/WebKit/WebKit/commit/4f1ded96b3967cf2de4cc260b1e49940e93822e4
  Author: Nikolaos Mouchtaris 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A 
LayoutTests/fast/scrolling/mac/scrollbars/svg-foreign-object-overlay-scrollbar-hovered-expected.txt
A 
LayoutTests/fast/scrolling/mac/scrollbars/svg-foreign-object-overlay-scrollbar-hovered.html
M LayoutTests/resources/ui-helper.js
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.h
M 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm

  Log Message:
  ---
  REGRESSION (UI-side compositing) overflow:scroll inside SVG foreignObject 
fails to render scrollbars
https://bugs.webkit.org/show_bug.cgi?id=261227
rdar://115075206

Reviewed by Simon Fraser.

Keep NSScrollerImps in the web process for scrollers inside svg foreignObject as
they don't follow the normal code path for creating scrollbars in the UI 
process.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::usesOverlayScrollbars const):
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):
* Source/WebCore/platform/mac/NSScrollerImpDetails.h:
* Source/WebCore/platform/mac/NSScrollerImpDetails.mm:
(WebCore::ScrollerStyle::usesOverlayScrollbars):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::registerScrollbarsForScrollableAreaInSVGForeignObject):
(WebCore::RenderLayer::updateAncestorDependentState):
* Source/WebCore/rendering/RenderLayer.h:
(WebCore::RenderLayer::isInsideSVGForeignObject const):
* 
Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm:
(WebKit::RemoteScrollbarsController::shouldRegisterScrollbars const):

Canonical link: https://commits.webkit.org/277015@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e6ba3: Add SPI for creating _WKApplicationManifest with data

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e6ba3e0f23c4e003355f497be46b7cf7cd613f8
  
https://github.com/WebKit/WebKit/commit/0e6ba3e0f23c4e003355f497be46b7cf7cd613f8
  Author: Sihui Liu 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h
M Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm

  Log Message:
  ---
  Add SPI for creating _WKApplicationManifest with data
https://bugs.webkit.org/show_bug.cgi?id=272075
rdar://125791668

Reviewed by Chris Dumez.

Test: WKApplicationManifest.EmptyJSONData
  WKApplicationManifest.JSONDataEncoding

* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.mm:
(-[_WKApplicationManifest initWithJSONData:manifestURL:documentURL:]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:
(TestWebKitAPI::TEST(WKApplicationManifest, EmptyJSONData)):
(TestWebKitAPI::TEST(WKApplicationManifest, JSONDataEncoding)):

Canonical link: https://commits.webkit.org/277014@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aebc03: [tvOS] Enable WEB_CODECS and other media related c...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aebc03fd2f91cfa9a26817399f3c721d61228c71
  
https://github.com/WebKit/WebKit/commit/aebc03fd2f91cfa9a26817399f3c721d61228c71
  Author: Youenn Fablet 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h
M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm
M Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderProvider.cpp

  Log Message:
  ---
  [tvOS] Enable WEB_CODECS and other media related compilation flags
rdar://125828604
https://bugs.webkit.org/show_bug.cgi?id=272073

Reviewed by Chris Dumez.

Enable Web codecs, media recorder and speech recognition compilation flags on 
tvOS.
Update MediaRecorder code to use more softlinking.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::AudioSampleBufferCompressor):
* Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
* Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderProvider.cpp:
(WebKit::MediaRecorderProvider::createMediaRecorderPrivate):

Canonical link: https://commits.webkit.org/277013@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff1c5f: Update methods used to fetch web extension data re...

[kiaraarose]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff1c5f882081ba26030d9e273fc0dabec87aceff
  
https://github.com/WebKit/WebKit/commit/ff1c5f882081ba26030d9e273fc0dabec87aceff
  Author: Kiara Rose 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecordInternal.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm
A Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm
M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M Source/WebKit/UIProcess/Extensions/WebExtensionDataRecord.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  ---
  Update methods used to fetch web extension data records to set an error if an 
issue occurred.
https://bugs.webkit.org/show_bug.cgi?id=271998
rdar://124625910

Reviewed by Timothy Hatcher.

We should notify apps if there was an issue in deleting or calculating 
extension storage.
If an error occurs, apps can decide to show an alert to their users. We add a 
test for this
unfortunately because I tested manually by forcing an error (e.g. result = 
makeUnexpected("error"))
and I verified _WKWebExtensionDataRecord.errors was populated in Safari.

* Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm:
(-[_WKWebExtensionSQLiteStore _deleteDatabase]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.h:
(NS_ERROR_ENUM):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecord.mm:
(WebKit::createDataRecordError):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecordInternal.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionControllerCocoa.mm:
(WebKit::WebExtensionController::getDataRecords):
(WebKit::WebExtensionController::getDataRecord):
(WebKit::WebExtensionController::removeData):
(WebKit::WebExtensionController::calculateStorageSize):
(WebKit::WebExtensionController::removeStorage):

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionDataRecordCocoa.mm:
Copied from 
Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionDataRecordInternal.h.
(WebKit::WebExtensionDataRecord::setError):
Sets an error on the corresponding _WKWebExtensionDataRecord.

* Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm:
(-[_WKWebExtensionStorageSQLiteStore getValuesForKeys:completionHandler:]):
(-[_WKWebExtensionStorageSQLiteStore getStorageSizeForKeys:completionHandler:]):
(-[_WKWebExtensionStorageSQLiteStore 
getStorageSizeForAllKeysIncludingKeyedData:withCompletionHandler:]):
Add additional logging when an error occurs.

* Source/WebKit/UIProcess/Extensions/WebExtensionController.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionDataRecord.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/277012@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75ce3a: [resultsdbpy] Add dashboard on landing page (Follo...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75ce3a2acb5d4dcdfdd7ca973bbd4729fc52dd3a
  
https://github.com/WebKit/WebKit/commit/75ce3a2acb5d4dcdfdd7ca973bbd4729fc52dd3a
  Author: Jonathan Bedard 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js
M 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js

  Log Message:
  ---
  [resultsdbpy] Add dashboard on landing page (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=272034
rdar://125787240

Unreviewed follow-up fix.

We were removing the "simulator" flag in our configurations, because 
configurations
which are not simulator leave this flag undefined instead of 'false'.

* 
Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js:
(Configuration.prototype.toParams): Strip architecture if it matches the 
default.
* Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/dashboard.js:
(Dashboard.prototype.reload):

Canonical link: https://commits.webkit.org/277011@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6e2039: [JSC] Crash On JSC when open dir as input file

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e20396fae8be933e13ffd02edbc90d1bd3d62a2
  
https://github.com/WebKit/WebKit/commit/6e20396fae8be933e13ffd02edbc90d1bd3d62a2
  Author: Michael Saboff 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/jsc.cpp

  Log Message:
  ---
  [JSC] Crash On JSC when open dir as input file
https://bugs.webkit.org/show_bug.cgi?id=251420
rdar://104853422

Reviewed by Yusuke Suzuki.

Added code to check the type of filesystem object the JSC shell is trying to 
load via stat() and fstat().
We return an error message when thrying to open some non-file object.

* Source/JavaScriptCore/jsc.cpp:
(fillBufferWithContentsOfFile):

Canonical link: https://commits.webkit.org/277010@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5001e0: [IFC][Integration] RELEASE_ASSERT() under LayoutIn...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5001e0ea367f78e2978504689fcf4dbe578c101a
  
https://github.com/WebKit/WebKit/commit/5001e0ea367f78e2978504689fcf4dbe578c101a
  Author: Alan Baradlay 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/text/remove-renderer-and-select-crash-expected.txt
A LayoutTests/fast/text/remove-renderer-and-select-crash.html
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h
M Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp
M Source/WebCore/layout/integration/inline/InlineIteratorBox.h
M Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h
M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h

  Log Message:
  ---
  [IFC][Integration] RELEASE_ASSERT() under 
LayoutIntegration::BoxTree::rendererForLayoutBox
https://bugs.webkit.org/show_bug.cgi?id=271908


Reviewed by Antti Koivisto.

1. IFC produces display boxes. BoxTree contains all the layout boxes as well as 
a map to find associated renders.
2. Content mutation destroys a renderer
  - IFC invalidates the relevant lines and detaches the layout box
However we keep the layout box around until after the next layout when the 
associated display boxes get invalidated as well.
3. While display box should be self contained, we consult the renderer for 
selection state (not on the display box).
-> RELEASE_ASSERT.

This is a temporary fix until after we either keep the associated renderer 
alive (like we do with the layout box) or transfer all states to display box
so that we don't need to talk to the renderer anymore).

* LayoutTests/TestExpectations:
* LayoutTests/fast/text/remove-renderer-and-select-crash-expected.txt: Added.
* LayoutTests/fast/text/remove-renderer-and-select-crash.html: Added.
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::hasRendererForLayoutBox const):
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:
* Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp:
(WebCore::InlineIterator::Box::selectionState const):
* Source/WebCore/layout/integration/inline/InlineIteratorBox.h:
(WebCore::InlineIterator::Box::hasRenderer const):
* Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::hasRenderer const):
* Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::hasRenderer const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp:
(WebCore::LayoutIntegration::InlineContent::hasRendererForLayoutBox const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hasRendererForLayoutBox const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:

Canonical link: https://commits.webkit.org/277009@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a1f01f: Github api should not assume the current user as t...

[Alex Atwater]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1f01fd352d03d3ed4965b126e20665f7a6c6c45
  
https://github.com/WebKit/WebKit/commit/a1f01fd352d03d3ed4965b126e20665f7a6c6c45
  Author: Alex Atwater 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py

  Log Message:
  ---
  Github api should not assume the current user as the fork owner.
https://bugs.webkit.org/show_bug.cgi?id=272054
rdar://125792901 (Github api should not assume the current user as the fork 
owner)

Reviewed by Jonathan Bedard.

Canonical link: https://commits.webkit.org/277008@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1870b1: CrashTracer: com.apple.WebKit.WebContent at WebCor...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1870b119a45087666315f1a1627f8c4cd02ed9cd
  
https://github.com/WebKit/WebKit/commit/1870b119a45087666315f1a1627f8c4cd02ed9cd
  Author: Tim Nguyen 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/dom/RadioButtonGroups.cpp

  Log Message:
  ---
  CrashTracer: com.apple.WebKit.WebContent at WebCore: 
WebCore::ValidatedFormListedElement::updateValidity
https://bugs.webkit.org/show_bug.cgi?id=272044
rdar://117727866

Reviewed by Ryosuke Niwa.

It speculatively fixes a bug that RadioButtonGroup::m_members may contain a 
nullptr WeakRef.

* Source/WebCore/dom/RadioButtonGroups.cpp:
(WebCore::RadioButtonGroup::isEmpty const):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsStyleRecalcForAllButtons):
(WebCore::RadioButtonGroup::updateValidityForAllButtons):

Canonical link: https://commits.webkit.org/277007@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 35fd5b: REGRESSION (276787@main): [ MacOS WK1 ] http/tests...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35fd5bdf2ea4638eedc536500aedcbd8dc72ecab
  
https://github.com/WebKit/WebKit/commit/35fd5bdf2ea4638eedc536500aedcbd8dc72ecab
  Author: Youenn Fablet 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
A 
LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt

  Log Message:
  ---
  REGRESSION (276787@main): [ MacOS WK1 ] 
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe.html
 is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=271892
rdar://125615616

Reviewed by Chris Dumez.

The HTML script tag triggers first a preload then an actual load.
Both are checked for CSP and in WK1, both will expose a console message, 
contrary to WK2 where only one console message appears.
Add a WK1 specific test expectation to handle this case.

* LayoutTests/platform/mac-wk1/TestExpectations:
* 
LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt:
 Added.

Canonical link: https://commits.webkit.org/277006@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c6ee0: [WGSL] Pointer rewriter should visit phony assignment

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c6ee0f8bb9311052934ad81e2e5f5f044d42fed
  
https://github.com/WebKit/WebKit/commit/9c6ee0f8bb9311052934ad81e2e5f5f044d42fed
  Author: Tadeu Zagallo 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebGPU/WGSL/PointerRewriter.cpp
M Source/WebGPU/WGSL/tests/valid/array-length.wgsl
M Source/WebGPU/WGSL/wgslc.cpp

  Log Message:
  ---
  [WGSL] Pointer rewriter should visit phony assignment
https://bugs.webkit.org/show_bug.cgi?id=272035
rdar://125618287

Reviewed by Mike Wyrzykowski.

The pointer rewriter needs to delete phony assignments when the right-hand side
is a pointer, but it fails to visit the assignment when it's not a pointer. I 
also
fixed a compilation error in wgslc due to some recent refactoring to use 
std::span.

* Source/WebGPU/WGSL/PointerRewriter.cpp:
(WGSL::PointerRewriter::visit):
* Source/WebGPU/WGSL/tests/valid/array-length.wgsl:
* Source/WebGPU/WGSL/wgslc.cpp:
(runWGSL):

Canonical link: https://commits.webkit.org/277005@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ae013f: AX: textUnderElement does not find visibility:visi...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ae013fff20db490f84ec85a4c11f66439dfc4db9
  
https://github.com/WebKit/WebKit/commit/ae013fff20db490f84ec85a4c11f66439dfc4db9
  Author: Tyler Wilcock 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A LayoutTests/accessibility/button-hidden-and-unhidden-text-expected.txt
A LayoutTests/accessibility/button-hidden-and-unhidden-text.html
A LayoutTests/accessibility/hidden-label-expected.txt
A LayoutTests/accessibility/hidden-label.html
M 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_hidden_not_referenced-expected.txt
A 
LayoutTests/platform/glib/accessibility/button-hidden-and-unhidden-text-expected.txt
A LayoutTests/platform/glib/accessibility/hidden-label-expected.txt
M LayoutTests/platform/ios/TestExpectations
A LayoutTests/platform/ios/accessibility/hidden-label-expected.txt
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityMathMLElement.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  ---
  AX: textUnderElement does not find visibility:visible text when it's within a 
visibility:hidden container
https://bugs.webkit.org/show_bug.cgi?id=271995
rdar://problem/125738704

Reviewed by Andres Gonzalez.

When `visibility:visible` is placed within a `visibility:hidden` container, the 
elements within are rendered. But currently,
`AccessibilityNodeObject::textUnderElement` stops immediately when encountering 
`visibility:hidden`, meaning we can miss
this nested `visibility:visible` text.

With this patch, when encountering a hidden style, we still search the subtree 
for text that isn't hidden.

This patch also fixes a bug where we never updated the cached accessibility 
text of controls associated with a label
via the for attribute when the for attribute of that label changes.

* LayoutTests/accessibility/button-hidden-and-unhidden-text-expected.txt: Added.
* LayoutTests/accessibility/button-hidden-and-unhidden-text.html: Added.
* LayoutTests/accessibility/hidden-label-expected.txt: Added.
* LayoutTests/accessibility/hidden-label.html: Added.
* 
LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_hidden_not_referenced-expected.txt:
* 
LayoutTests/platform/glib/accessibility/button-hidden-and-unhidden-text-expected.txt:
 Added.
* LayoutTests/platform/glib/accessibility/hidden-label-expected.txt: Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/accessibility/hidden-label-expected.txt: Added.
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::TextUnderElementMode::isHidden):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::isDOMHidden):
(WebCore::AXObjectCache::addLabelForRelation):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityMathMLElement.cpp:
(WebCore::AccessibilityMathMLElement::textUnderElement const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isDOMHidden const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::removeNode):

Canonical link: https://commits.webkit.org/277004@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e226e9: Remove unused m_isValid private field in FragmentD...

[Olivier Blin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e226e90766d3d4e2a85c2c3fc3c7fb33dca3e721
  
https://github.com/WebKit/WebKit/commit/e226e90766d3d4e2a85c2c3fc3c7fb33dca3e721
  Author: Olivier Blin 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/dom/FragmentDirectiveGenerator.h

  Log Message:
  ---
  Remove unused m_isValid private field in FragmentDirectiveGenerator
https://bugs.webkit.org/show_bug.cgi?id=272086

Reviewed by Chris Dumez.

* Source/WebCore/dom/FragmentDirectiveGenerator.h:
The m_isValid private field is unused (introduced in 274919@main).

Canonical link: https://commits.webkit.org/277003@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e46c0: [Cleanup] Checking needsLayout() does not need Che...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e46c0d29422243b629cfb62c1c1419ca9febed0
  
https://github.com/WebKit/WebKit/commit/0e46c0d29422243b629cfb62c1c1419ca9febed0
  Author: Alan Baradlay 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h

  Log Message:
  ---
  [Cleanup] Checking needsLayout() does not need CheckedPtr in 
Document::updateLayoutIfDimensionsOutOfDate
https://bugs.webkit.org/show_bug.cgi?id=271983

Reviewed by Antti Koivisto.

1. Fix FIXME in Document::DimensionsCheck. All is indeed Width | Height. Let's 
use that in the incoming OptionSet instead.
2. When parent document is dirty, let's just run updateLayout and return right 
away instead of going through the "can we optimize case" codepath (it saves 
calling updateRelevancyOfContentVisibilityElements/updateStyleIfNeeded twice)
3. Move 
isVertical/hasSpecifiedLogicalHeight/checkingLogicalWidth/checkingLogicalHeight 
inside [if (!requireFullLayout) { }] where they are actually used.
4. requireFullLayout should just read "element.renderer()->needsLayout() || 
is(element)" at this point (accessing const needsLayout() 
should not require a CheckedPtr)

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
* Source/WebCore/dom/Document.h:
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

Canonical link: https://commits.webkit.org/277002@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f876ff: Enable PopStateEvent's hasUAVisualTransition (UAVi...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f876ff89c61f56e2259a2a27e8168defe01f96f8
  
https://github.com/WebKit/WebKit/commit/f876ff89c61f56e2259a2a27e8168defe01f96f8
  Author: Anne van Kesteren 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  Enable PopStateEvent's hasUAVisualTransition 
(UAVisualTransitionDetectionEnabled) by default
https://bugs.webkit.org/show_bug.cgi?id=271886

Reviewed by Rob Buis.

With the implementation added in 275438@main it seems there are no
remaining issues with this feature.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/277001@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 38f64d: ASSERTION FAILED (!m_inStyleRecalc) in Document::u...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38f64dda7344e7b24a0efe0da543e80060e12b8c
  
https://github.com/WebKit/WebKit/commit/38f64dda7344e7b24a0efe0da543e80060e12b8c
  Author: Alan Baradlay 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/page/ios/ContentChangeObserver.cpp

  Log Message:
  ---
  ASSERTION FAILED (!m_inStyleRecalc) in Document::usesStyleBasedEditability() 
when inline media controls are presented
https://bugs.webkit.org/show_bug.cgi?id=271972


Reviewed by Antti Koivisto.

ContentChangeObserver::isConsideredActionableContent is called when we finished 
updating the element (see RenderTreeUpdater::updateElementRenderer)
meaning computed style (including descendants) should be all up-to-date.

* Source/WebCore/dom/Node.cpp:
(WebCore::Node::willRespondToMouseClickEvents const):
* Source/WebCore/dom/Node.h:
* Source/WebCore/page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::isConsideredActionableContent const):

Canonical link: https://commits.webkit.org/277000@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e0661: [IFC] Negative hyphen width triggers ASSERT in Tex...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e06611bad266d7b09a6fa818bf0fd4b04865018
  
https://github.com/WebKit/WebKit/commit/8e06611bad266d7b09a6fa818bf0fd4b04865018
  Author: Alan Baradlay 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A LayoutTests/fast/text/negative-hyphen-width-with-break-word-expected.txt
A LayoutTests/fast/text/negative-hyphen-width-with-break-word.html
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp

  Log Message:
  ---
  [IFC] Negative hyphen width triggers ASSERT in TextUtil::breakWord
https://bugs.webkit.org/show_bug.cgi?id=272011


Reviewed by Antti Koivisto.

When negative letter-spacing produces negative hyphen width, we think there's 
some actual
available space for content (subtracting a negative value) which confuses 
TextUtil::breakWord logic.

This patch ensures we never inflate horizontal available space.

* LayoutTests/fast/text/negative-hyphen-width-with-break-word-expected.txt: 
Added.
* LayoutTests/fast/text/negative-hyphen-width-with-break-word.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::tryHyphenationAcrossOverflowingInlineTextItems
 const):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::breakWord):

Canonical link: https://commits.webkit.org/276999@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 004c28: Cherry-pick 276977@main (ea2be408f27e).

[Thomas Devoogdt]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 004c28e211d9fbc10edcb404332d0f6ab31242f5
  
https://github.com/WebKit/WebKit/commit/004c28e211d9fbc10edcb404332d0f6ab31242f5
  Author: Thomas Devoogdt 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/css/SelectorChecker.cpp
M Source/WebCore/css/SelectorCheckerTestFunctions.h
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/dom/FullscreenManager.h
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
M 
Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h

  Log Message:
  ---
  Cherry-pick 276977@main (ea2be408f27e).

https://bugs.webkit.org/show_bug.cgi?id=271881

REGRESSION: fix compilation if !ENABLE(VIDEO)

https://bugs.webkit.org/show_bug.cgi?id=271881

Reviewed by Mike Wyrzykowski.

[WebCore]: FullscreenManager: add missing include

HTMLMediaElement normally includes HTMLMediaElementEnums,
but only if VIDEO is enabled.

[WebCore]: FullscreenManager: fix undefined reference to HTMLMediaElement

HTMLMediaElement is not compiled if VIDEO is not enabled.

[WebCore]: css: fix fix undefined reference to HTMLMediaElement

HTMLMediaElement is not compiled if VIDEO is not enabled.

[WebCore]: InspectorDOMAgent: fix fix undefined reference to 
HTMLMediaElement

HTMLMediaElement is not compiled if VIDEO is not enabled.

[WebKit]: WebGPU: drop duplicate directive in RemoteDevice

The #if PLATFORM(COCOA) && ENABLE(VIDEO) directive is already defined
outside the function scope, so drop the inner ones.

[WebCore]: GPUDevice: fix undefined reference to HTMLMediaElement

HTMLMediaElement is not compiled if VIDEO is not enabled.

[WebKit]: WebFullScreenManagerProxy: add missing include

HTMLMediaElement normally includes HTMLMediaElementEnums,
but only if VIDEO is enabled.

[WebKit]: WebFullScreenManager: add missing include

HTMLMediaElement normally includes HTMLMediaElementEnums,
but only if VIDEO is enabled.

[WebKit]: InjectedBundlePageFullScreenClient: add missing include

HTMLMediaElement normally includes HTMLMediaElementEnums,
but only if VIDEO is enabled.

[WebKit]: WebCoreArgumentCoders.serialization.in: fix undefined reference

CaptionUserPreferencesDisplayMode and SerializedPlatformDataCueValue
are only compiled if VIDEO is enabled.

Signed-off-by: Thomas Devoogdt 
Canonical link: https://commits.webkit.org/276977@main

(cherry picked from commit ea2be408f27eb1009bbde7b0a2496018d4ca5e86)
Signed-off-by: Thomas Devoogdt 



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8beec2: [Skia] Implement snapshots on GTK

[Patrick]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8beec28e86cfaac38332e5b6712d9f7dd3dbd480
  
https://github.com/WebKit/WebKit/commit/8beec28e86cfaac38332e5b6712d9f7dd3dbd480
  Author: Patrick Griffis 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp

  Log Message:
  ---
  [Skia] Implement snapshots on GTK
https://bugs.webkit.org/show_bug.cgi?id=270912

Reviewed by Carlos Garcia Campos.

* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:

Canonical link: https://commits.webkit.org/276998@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eff294: [WPE] Add a soft limit to the amount of GPU memory...

[Miguel Gómez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eff294d622ac02b2267f5093ffe7e384d3f554aa
  
https://github.com/WebKit/WebKit/commit/eff294d622ac02b2267f5093ffe7e384d3f554aa
  Author: Miguel Gomez 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/PlatformWPE.cmake
M Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp
M Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h

  Log Message:
  ---
  [WPE] Add a soft limit to the amount of GPU memory BitmapTexturePool can hold
https://bugs.webkit.org/show_bug.cgi?id=271765

Reviewed by Carlos Garcia Campos.

Add a soft limit to the amount of memory that BitmapTexturePool can hold. When
the limit is reached, be more aggressive trying to release the stored textures.

* Source/WebCore/PlatformWPE.cmake:
* Source/WebCore/platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::acquireTexture):
(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
(WebCore::BitmapTexturePool::enterLimitExceededModeIfNeeded):
(WebCore::BitmapTexturePool::exitLimitExceededModeIfNeeded):
* Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:

Canonical link: https://commits.webkit.org/276997@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7e4ae4: Build fix: Switch CoreTelephony.framework to use d...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e4ae4b1abc75768b5b5cb44665b6007cb4ebe0a
  
https://github.com/WebKit/WebKit/commit/7e4ae4b1abc75768b5b5cb44665b6007cb4ebe0a
  Author: David Kilzer 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebKit/Configurations/WebKit.xcconfig
M Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig

  Log Message:
  ---
  Build fix: Switch CoreTelephony.framework to use delay-init linking
https://bugs.webkit.org/show_bug.cgi?id=271936


Unreviewed build fix.

* Source/WebKit/Configurations/WebKit.xcconfig:
(OTHER_LDFLAGS_DELAY_INIT):
* Tools/TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
(OTHER_LDFLAGS_DELAY_INIT):
- Define empty OTHER_LDFLAGS_DELAY_INIT for tvOS, visionOS and watchOS.
  CoreTelephony.framework only needs to be linked on iOS/iPadOS.

Canonical link: https://commits.webkit.org/276996@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8f3e5c: [Skia] Fix background-size behavior when backgroun...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f3e5c6bf81044decce65bb6627203b3e8fda995
  
https://github.com/WebKit/WebKit/commit/8f3e5c6bf81044decce65bb6627203b3e8fda995
  Author: Pawel Lampe 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  ---
  [Skia] Fix background-size behavior when background repeats
https://bugs.webkit.org/show_bug.cgi?id=271455

Reviewed by Carlos Garcia Campos.

GraphicsContextSkia::drawPattern is being invoked only when the pattern 
repetition is expected.
Hence this change removes spurious conditional repetition.

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::drawPattern):

Canonical link: https://commits.webkit.org/276995@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d7d6a: [Skia] Fix GraphicsContextSkia::setLineDash when o...

[Pawel Lampe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d7d6a2d4ee87c3942ae1088f7412658fa8866d8
  
https://github.com/WebKit/WebKit/commit/6d7d6a2d4ee87c3942ae1088f7412658fa8866d8
  Author: Pawel Lampe 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp

  Log Message:
  ---
  [Skia] Fix GraphicsContextSkia::setLineDash when odd number of elements is 
provided
https://bugs.webkit.org/show_bug.cgi?id=271760

Reviewed by Carlos Garcia Campos.

The spec states that if an odd number of elements is provided within dash array,
the array should be repeated to yield an even number of elements.
Therefore e.g. 1,2,3 should become 1,2,3,1,2,3.
* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContextSkia::setLineDash):

Canonical link: https://commits.webkit.org/276994@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b78e11: [@starting-style] Style adjuster wrongly invoked w...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b78e11bab3e30ab21cd2847a963341825126c1ee
  
https://github.com/WebKit/WebKit/commit/b78e11bab3e30ab21cd2847a963341825126c1ee
  Author: Antti Koivisto 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment.html
M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  ---
  [@starting-style] Style adjuster wrongly invoked with null element
https://bugs.webkit.org/show_bug.cgi?id=272076
rdar://125837628

Reviewed by Antoine Quint.

We may compute wrong starting style for elements that require style 
adjustments. This may have observable effects.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-adjustment.html:
 Added.

 is always blockified per HTML spec. Test we don't trigger a transition 
based on before-adjustment value.

* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveStartingStyle const):

The pseudo-element logic was reversed.

Canonical link: https://commits.webkit.org/276993@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1b57c1: [iOS] 2 fast/viewport/viewport-legacy-xhtmlmp*.htm...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b57c1925dd6e75019a596962321846094c57544
  
https://github.com/WebKit/WebKit/commit/1b57c1925dd6e75019a596962321846094c57544
  Author: Abrar Rahman Protyasha 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html
M LayoutTests/fast/viewport/viewport-legacy-xhtmlmp.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/ViewportArguments.h
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  [iOS] 2 fast/viewport/viewport-legacy-xhtmlmp*.html layout tests are 
constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=271784
rdar://125504723

Reviewed by Tim Horton.

This patch addresses the following failed tests:
- fast/viewport/viewport-legacy-xhtmlmp.html
- fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html

Both tests use the XHTML Mobile Profile (XHTML-MP) doctype, but this is
not reflected in the document's resolved viewport configuration. The
test output shows that the viewport's width is equivalent to the default
desktop width (980) and the minimum scale is equivalent to the ratio
between the XHTML mobile paramaters width (320) and the default desktop
width.

This patch updates the viewport configuration to XHTML-MP parameters and
provides the right viewport origin type (CSSDeviceAdaption) if the web
page's viewport configuration is being reset and the page has a mobile
doctype, like for the failing tests. This way, We make sure the document
throws away the stale viewport arguments with desktop values and instead
respects the mobile profile, but only if the exisitng viewport arguments
were not configured through a meta tag, since that takes priority over
XHTML-MP.

Lastly, we improve conformance to current smart pointer usage guidelines
with drive-by refactors in WebPage::resetViewportDefaultConfiguration
and in Document::updateViewportArguments.

* LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
* LayoutTests/fast/viewport/viewport-legacy-xhtmlmp.html:

Update viewport spec link in the test comments.

* LayoutTests/platform/ios/TestExpectations:

Fix test expectations.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::isViewportDocument const):

Make the lambda function from Document::updateViewportArguments a member
function so we can call it in WebPage::resetViewportDefaultConfiguration
as well.

Also, slight smart pointer hygiene improvements.

(WebCore::Document::updateViewportArguments):
* Source/WebCore/dom/Document.h:

* Source/WebCore/dom/ViewportArguments.h:

Rearrange the ViewportArguments::Type cases to reflect that viewport
arguments obtained from a meta tag are prioritized over XHTML-MP.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetViewportDefaultConfiguration):

If we have received a mobile doctype, and we have a viewport document,
update the viewport configuration to reflect that of the XHTML-MP. Call
WebPage::viewportPropertiesDidChange to propagate these changes.

Also, slight smart pointer hygiene improvements.

Canonical link: https://commits.webkit.org/276992@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41e8f1: [GTK] Port SelectionData to new IPC serialization ...

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41e8f107db1c092980668ad788326ae5b5354dd9
  
https://github.com/WebKit/WebKit/commit/41e8f107db1c092980668ad788326ae5b5354dd9
  Author: Claudio Saavedra 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/platform/gtk/PasteboardGtk.cpp
M Source/WebCore/platform/gtk/SelectionData.cpp
M Source/WebCore/platform/gtk/SelectionData.h
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp
M Source/WebKit/Shared/gtk/ArgumentCodersGtk.h
A Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in
M Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp
M Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp

  Log Message:
  ---
  [GTK] Port SelectionData to new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=271836

Reviewed by Carlos Garcia Campos.

Remove the ArgumentCoders for SelectionData, adapt the
class a bit to make it work well with the generated serializers,
and add a new ArgumentCodersGtk.serialization.in for the
GTK-specific serializers.

* Source/WebCore/platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::typesSafeForBindings):
(WebCore::Pasteboard::readOrigin):
(WebCore::Pasteboard::readStringInCustomData):
* Source/WebCore/platform/gtk/SelectionData.cpp:
(WebCore::SelectionData::SelectionData):
* Source/WebCore/platform/gtk/SelectionData.h:
(WebCore::SelectionData::setImage):
(WebCore::SelectionData::image const):
(WebCore::SelectionData::customData const):
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::encodeImage): Deleted.
(IPC::decodeImage): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.h:
* Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: Added.
* Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp:
(WebKit::DragSource::DragSource):
* Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp:
(WebKit::Clipboard::write):

Canonical link: https://commits.webkit.org/276991@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 60ad4c: [Remote Inspection] Add a way to immediately apply...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60ad4ce2c9dba49e168cb8048022d1e9baf67afc
  
https://github.com/WebKit/WebKit/commit/60ad4ce2c9dba49e168cb8048022d1e9baf67afc
  Author: Wenson Hsieh 
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
M Source/WebCore/loader/DocumentLoader.h
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/ElementTargetingTypes.h
M Source/WebCore/page/Page.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/Shared/WebsitePoliciesData.cpp
M Source/WebKit/Shared/WebsitePoliciesData.h
M Source/WebKit/Shared/WebsitePoliciesData.serialization.in
M Source/WebKit/UIProcess/API/APITargetedElementInfo.h
M Source/WebKit/UIProcess/API/APIWebsitePolicies.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/element-targeting-3.html
M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  ---
  [Remote Inspection] Add a way to immediately apply visibility adjustment 
based on CSS selectors when loading
https://bugs.webkit.org/show_bug.cgi?id=272060

Reviewed by Aditya Keerthi.

Add a mechanism which allows WebKit clients to eagerly apply visibility 
adjustment to elements per
navigation, based on sets of CSS selectors. See below for more details.

* Source/WebCore/loader/DocumentLoader.h:
(WebCore::DocumentLoader::visibilityAdjustmentSelectors const):
(WebCore::DocumentLoader::setVisibilityAdjustmentSelectors):

Add plumbing from `WebsitePoliciesData` down into `DocumentLoader`, like all of 
the other per-load
website policies.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::computeClientRect):
(WebCore::targetedElementInfo):
(WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions):
(WebCore::ElementTargetingController::applyVisibilityAdjustmentFromSelectors):

If we haven't already done so yet, pull `visibilityAdjustmentSelectors` from 
the `DocumentLoader`
into `ElementTargetingController`. For up to 30 seconds after committing the 
load, continually look
for elements that correspond to these selectors, and immediately adjust 
visibility for them if
found.

(WebCore::ElementTargetingController::reset):
(WebCore::ElementTargetingController::resetAdjustmentRegions): Deleted.

Rename `resetAdjustmentRegions` to just `reset`, since it now clears out more 
state than just what's
necessary for tracking adjustment regions.

* Source/WebCore/page/ElementTargetingController.h:
* Source/WebCore/page/ElementTargetingTypes.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::didCommitLoad):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebsitePoliciesData.cpp:
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
* Source/WebKit/Shared/WebsitePoliciesData.h:
* Source/WebKit/Shared/WebsitePoliciesData.serialization.in:

Add more plumbing for CSS selectors from the client down into WebCore.

* Source/WebKit/UIProcess/API/APITargetedElementInfo.h:
* Source/WebKit/UIProcess/API/APIWebsitePolicies.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setVisibilityAdjustmentSelectors:]):
(-[WKWebpagePreferences _visibilityAdjustmentSelectors]):

Add support for the new SPI. See above for more details.

* Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm:
(-[_WKTargetedElementInfo boundsInWebView]):
(-[_WKTargetedElementInfo boundsInClientCoordinates]):

Also, clean up this `bounds` SPI property — currently, the `-bounds` property 
returns the bounds of
the element in root view coordinates, while the targeted element request 
expects a point in the web
view's coordinate space. To address this inconsistency and clarify the behavior 
of the API, add
alternatives to `bounds`: `boundsInWebView` and `boundsInClientCoordinates` 
that explicitly indicate
which coordinate space the bounds are in. Depending on the purpose, the client 
can use either.

* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::setUpWebViewForSnapshotting):

Factor this setup code into a common helper to reduce code duplication.

(TestWebKitAPI::TEST(ElementTargeting, AdjustVisibilityForUnparentedElement)):
(TestWebKitAPI::TEST(ElementTargeting, 

[webkit-changes] [WebKit/WebKit] 60f802: Update ANGLE to 2024-03-25 (3ed8c5f4314708d3078950...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60f80224d2c98fea3d208c385f050a662f34ae32
  
https://github.com/WebKit/WebKit/commit/60f80224d2c98fea3d208c385f050a662f34ae32
  Author: Kimmo Kinnunen 
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
M Source/ThirdParty/ANGLE/.gitignore
M Source/ThirdParty/ANGLE/.gitmodules
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
M Source/ThirdParty/ANGLE/BUILD.gn
M Source/ThirdParty/ANGLE/CONTRIBUTORS
M Source/ThirdParty/ANGLE/Compiler.cmake
M Source/ThirdParty/ANGLE/DEPS
M Source/ThirdParty/ANGLE/GL.cmake
M Source/ThirdParty/ANGLE/OWNERS
M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h
M Source/ThirdParty/ANGLE/WebKit/angle_commit.h
M Source/ThirdParty/ANGLE/changes.diff
M Source/ThirdParty/ANGLE/doc/GPUMemoryAnalysis.md
M Source/ThirdParty/ANGLE/doc/TestingAndProcesses.md
M Source/ThirdParty/ANGLE/gni/angle.gni
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesGL_autogen.h
M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h
M Source/ThirdParty/ANGLE/include/platform/gl_features.json
M Source/ThirdParty/ANGLE/include/platform/vk_features.json
M Source/ThirdParty/ANGLE/infra/specs/angle.json
M Source/ThirdParty/ANGLE/infra/specs/angle_mb_config.pyl
M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl
M Source/ThirdParty/ANGLE/infra/specs/waterfalls.pyl
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_format.json
M 
Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
M Source/ThirdParty/ANGLE/scripts/generate_android_bp.py
M Source/ThirdParty/ANGLE/scripts/roll_chromium_deps.py
M Source/ThirdParty/ANGLE/src/common/system_utils.h
M Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp
M Source/ThirdParty/ANGLE/src/common/system_utils_win.cpp
M Source/ThirdParty/ANGLE/src/compiler.gni
A Source/ThirdParty/ANGLE/src/compiler/translator/AsNode.h
M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.h
M Source/ThirdParty/ANGLE/src/compiler/translator/ImmutableString.h
M Source/ThirdParty/ANGLE/src/compiler/translator/IntermNode.h
A Source/ThirdParty/ANGLE/src/compiler/translator/IntermRebuild.cpp
A Source/ThirdParty/ANGLE/src/compiler/translator/IntermRebuild.h
A Source/ThirdParty/ANGLE/src/compiler/translator/NodeType.h
M Source/ThirdParty/ANGLE/src/compiler/translator/SymbolTable.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/ValidateClipCullDistance.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/ValidateClipCullDistance.h
M Source/ThirdParty/ANGLE/src/compiler/translator/glsl/TranslatorESSL.cpp
R Source/ThirdParty/ANGLE/src/compiler/translator/msl/AsNode.h
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/EmitMetal.cpp
R Source/ThirdParty/ANGLE/src/compiler/translator/msl/IntermRebuild.cpp
R Source/ThirdParty/ANGLE/src/compiler/translator/msl/IntermRebuild.h
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/MapSymbols.cpp
R Source/ThirdParty/ANGLE/src/compiler/translator/msl/NodeType.h
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/RewritePipelines.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/SymbolEnv.cpp
M Source/ThirdParty/ANGLE/src/compiler/translator/msl/TranslatorMSL.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/SeparateDeclarations.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/SeparateDeclarations.h
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/AddExplicitTypeCasts.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/ConvertUnsupportedConstructorsToFunctionCalls.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/FixTypeConstructors.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/GuardFragDepthWrite.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/HoistConstants.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/IntroduceVertexIndexID.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/ReduceInterfaceBlocks.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/ReduceInterfaceBlocks.h
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/RewriteCaseDeclarations.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/RewriteOutArgs.cpp
M 
Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/msl/RewriteUnaddressableReferences.cpp
M 

[webkit-changes] [WebKit/WebKit] 2416ed: [iOS] audio level switches to VC level when starti...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2416ed8f257fc9151b8c8566e39cc4728a5c7e31
  
https://github.com/WebKit/WebKit/commit/2416ed8f257fc9151b8c8566e39cc4728a5c7e31
  Author: Youenn Fablet 
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm

  Log Message:
  ---
  [iOS] audio level switches to VC level when starting microphone capture even 
if audioSession type is set to 'play-and-record' before microphone capture
rdar://125073697
https://bugs.webkit.org/show_bug.cgi?id=271305

Reviewed by Eric Carlson.

Make sure to always use VideoChat mode when AudioSession category is play and 
record.
This ensures that, when DOMAudioSession.type is set to "play-and-record", we 
directly use the VC audio volume, even before starting to caputre microphone.

* Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateSessionState):

Canonical link: https://commits.webkit.org/276988@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes