[webkit-changes] [WebKit/WebKit] 8715d4: REGRESSION(r290676?): [ iOS ] media/video-played-r...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8715d40f1d7038e9f43619d153210883228d17a6
  
https://github.com/WebKit/WebKit/commit/8715d40f1d7038e9f43619d153210883228d17a6
  Author: Jean-Yves Avenard 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M LayoutTests/media/video-played-collapse.html
M LayoutTests/media/video-played.js
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  REGRESSION(r290676?): [ iOS ] media/video-played-ranges-1.html is a flaky 
text failure
https://bugs.webkit.org/show_bug.cgi?id=238771
rdar://91262784

Reviewed by Eric Carlson.

The test failed due to bug 270618 which was fixed in 276761@main.
However, amend test as it assumes that the value of currentTime would only 
progressed
by less than 0.01 following a call to play(); pause();
While likely, this isn't guaranteed particularly on a busy sytem as playback 
progress
happens completely in parallel to the main thread.

* LayoutTests/media/video-played-ranges-1-expected.txt:
* LayoutTests/media/video-played-reset-expected.txt:
* LayoutTests/media/video-played.js:
(testRanges):
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/277800@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 815968: [WTF] List all headers in wtf/CMakeLists.txt

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 815968c690eb9551f3378bbdd996c624ea1289ac
  
https://github.com/WebKit/WebKit/commit/815968c690eb9551f3378bbdd996c624ea1289ac
  Author: Yusuke Suzuki 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/PlatformGTK.cmake
M Source/WTF/wtf/PlatformJSCOnly.cmake
M Source/WTF/wtf/PlatformMac.cmake
M Source/WTF/wtf/PlatformPlayStation.cmake
M Source/WTF/wtf/PlatformWPE.cmake
M Source/WTF/wtf/PlatformWin.cmake

  Log Message:
  ---
  [WTF] List all headers in wtf/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=273050
rdar://126832738

Reviewed by Keith Miller.

Since they are just headers, we can list them all regardless of whether it is 
actually used.

* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/PlatformGTK.cmake:
* Source/WTF/wtf/PlatformJSCOnly.cmake:
* Source/WTF/wtf/PlatformMac.cmake:
* Source/WTF/wtf/PlatformPlayStation.cmake:
* Source/WTF/wtf/PlatformWPE.cmake:
* Source/WTF/wtf/PlatformWin.cmake:

Canonical link: https://commits.webkit.org/277799@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b783bc: [Unified Text Replacement] Selection is sometimes ...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b783bcea8eeeb4a606e0cfee6815ab1e34451127
  
https://github.com/WebKit/WebKit/commit/b783bcea8eeeb4a606e0cfee6815ab1e34451127
  Author: Richard Robinson 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h

  Log Message:
  ---
  [Unified Text Replacement] Selection is sometimes incorrect after text 
replacement
https://bugs.webkit.org/show_bug.cgi?id=272957
rdar://125097437

Reviewed by Wenson Hsieh.

After text replacement, ensure the replaced text is selected.

To ensure the selection is always correct, keep track of the character offsets 
of the ranges
instead of relying on the live ranges automatically updating.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveReplacements):
(WebKit::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::updateStateForSelectedReplacementIfNeeded):

Canonical link: https://commits.webkit.org/277798@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 746768: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 746768c82e523e6593afa393075a783653356129
  
https://github.com/WebKit/WebKit/commit/746768c82e523e6593afa393075a783653356129
  Author: Fujii Hironori 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/277797@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a5f7f: Decrease use of StringView::character8() / charact...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a5f7f431122a5e13b4d81f3cf9d4352e1338d98
  
https://github.com/WebKit/WebKit/commit/4a5f7f431122a5e13b4d81f3cf9d4352e1338d98
  Author: Chris Dumez 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M Source/JavaScriptCore/yarr/YarrParser.h
M Source/WTF/wtf/JSONValues.cpp
M Source/WTF/wtf/text/AdaptiveStringSearcher.h
M Source/WTF/wtf/text/Base64.cpp
M Source/WTF/wtf/text/StringCommon.h
M Source/WTF/wtf/text/StringImpl.cpp
M Source/WTF/wtf/text/StringView.cpp
M Source/WTF/wtf/text/StringView.h
M Source/WTF/wtf/text/TextBreakIterator.cpp
M Source/WTF/wtf/text/WTFString.h
M Source/WTF/wtf/text/cf/StringViewCF.cpp
M Source/WTF/wtf/text/cocoa/StringViewCocoa.mm
M Source/WTF/wtf/text/icu/TextBreakIteratorICU.h
M Source/WTF/wtf/text/icu/UTextProvider.h
M Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp
M Source/WTF/wtf/text/icu/UTextProviderLatin1.h
M Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp
M Source/WTF/wtf/text/icu/UTextProviderUTF16.h
M Source/WTF/wtf/unicode/icu/CollatorICU.cpp
M Source/WebCore/dom/SpaceSplitString.cpp

  Log Message:
  ---
  Decrease use of StringView::character8() / character16()
https://bugs.webkit.org/show_bug.cgi?id=273040

Reviewed by Darin Adler.

Decrease use of StringView::character8() / character16() in preparation
for dropping them.

* Source/JavaScriptCore/yarr/YarrParser.h:
(JSC::Yarr::Parser::Parser):
* Source/WTF/wtf/JSONValues.cpp:
(WTF::JSONImpl::Value::parseJSON):
* Source/WTF/wtf/text/AdaptiveStringSearcher.h:
(WTF::searchStringRaw): Deleted.
* Source/WTF/wtf/text/Base64.cpp:
(WTF::base64Decode):
(WTF::base64DecodeToString):
* Source/WTF/wtf/text/StringCommon.h:
* Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
* Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::find const):
(WTF::getCharactersWithASCIICaseInternal):
(WTF::StringView::getCharactersWithASCIICase const):
(WTF::normalizedNFC):
(WTF::makeStringByReplacingAll):
(WTF::makeStringBySimplifyingNewLinesSlowCase):
* Source/WTF/wtf/text/StringView.h:
(WTF::StringView::span8 const):
(WTF::StringView::span16 const):
(WTF::StringView::span const):
(WTF::StringView::span const):
(WTF::StringView::characterAt const):
(WTF::StringView::unsafeCharacterAt const):
(WTF::equal):
(WTF::StringView::CodePoints::Iterator::Iterator):
(WTF::StringView::trim const):
(WTF::startsWith):
(WTF::startsWithIgnoringASCIICase):
(WTF::endsWith):
(WTF::endsWithIgnoringASCIICase):
(WTF::StringView::characters8 const): Deleted.
(WTF::StringView::characters16 const): Deleted.
(WTF::StringView::characters const): Deleted.
(WTF::StringView::characters const): Deleted.
* Source/WTF/wtf/text/TextBreakIterator.cpp:
(WTF::setTextForIterator):
(WTF::numGraphemeClusters):
(WTF::numCodeUnitsInGraphemeClusters):
* Source/WTF/wtf/text/WTFString.h:
(WTF::String::span const):
(WTF::String::span const):
* Source/WTF/wtf/text/cf/StringViewCF.cpp:
(WTF::StringView::createCFString const):
(WTF::StringView::createCFStringWithoutCopying const):
* Source/WTF/wtf/text/cocoa/StringViewCocoa.mm:
(WTF::StringView::createNSString const):
(WTF::StringView::createNSStringWithoutCopying const):
* Source/WTF/wtf/text/icu/TextBreakIteratorICU.h:
(WTF::TextBreakIteratorICU::setText):
* Source/WTF/wtf/text/icu/UTextProvider.h:
(WTF::initializeContextAwareUTextProvider):
* Source/WTF/wtf/text/icu/UTextProviderLatin1.cpp:
(WTF::openLatin1ContextAwareUTextProvider):
* Source/WTF/wtf/text/icu/UTextProviderLatin1.h:
* Source/WTF/wtf/text/icu/UTextProviderUTF16.cpp:
(WTF::openUTF16ContextAwareUTextProvider):
* Source/WTF/wtf/text/icu/UTextProviderUTF16.h:
* Source/WTF/wtf/unicode/icu/CollatorICU.cpp:
(WTF::createIterator):
* Source/WebCore/dom/SpaceSplitString.cpp:
(WebCore::spaceSplitStringContainsValueInternal):

Canonical link: https://commits.webkit.org/277796@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc5b39: Re-sync hsl()/hsla() implementation with the lates...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc5b392973637f900bd2f3d89cfb722f08aaedf5
  
https://github.com/WebKit/WebKit/commit/bc5b392973637f900bd2f3d89cfb722f08aaedf5
  Author: Sam Weinig 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hsl-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt
M LayoutTests/platform/glib/fast/css/hsl-color-expected.txt
M LayoutTests/platform/ios/fast/css/hsl-color-expected.txt
M LayoutTests/platform/mac/fast/css/hsl-color-expected.txt
M LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.h
M Source/WebCore/html/canvas/CanvasStyle.cpp
M Source/WebCore/platform/graphics/Color.cpp
M Source/WebCore/platform/graphics/ColorConversion.cpp
M Source/WebCore/platform/graphics/ColorConversion.h
M Source/WebCore/platform/graphics/ColorModels.h
M Source/WebCore/platform/graphics/ColorNormalization.h
M Source/WebCore/platform/graphics/ColorTypes.h

  Log Message:
  ---
  Re-sync hsl()/hsla() implementation with the latest spec
https://bugs.webkit.org/show_bug.cgi?id=272941

Reviewed by Darin Adler.

The CSS Color specification has changed since hsl()/hsla() was last
worked on. This updates things to support:

- Modified parsing rules which now allow  in places that previously
  supported .
- Expanded value range for saturation and lightness, and a constricted value
  range for hue.
- Changes to the types used by the h/s/l/alpha symbols used in the relative
  color form to always be CSS_NUMBER.
- Update conversion to/from sRGB that accounts for expanded value range.

Since the value range is legal for values greater than what bounded sRGB
supports, the reference color space for HSLA was changed to ExpandedSRGB
and unnecessary clipping to the bounded form (such as after interpolation)
was removed.

* LayoutTests/TestExpectations:
Two tests that use the expanded range of hsl() expecting it to be
clipped now fail and will need to be revised with the working group.
(Since the tests are reference tests, they now depend on the how the
graphics library used by the engine maps out of gamut colors and the
display properties it is being shown on).

* LayoutTests/TestExpectations
Added two tests as new image only failures due to their dependence on
an sRGB display and unspecified gamut mapping. Tracking with 
webkit.org/b/272940.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-invalid-relative-color-expected.txt
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-hsl-expected.txt
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt
Update a good chunk of tests to now pass. We still see some hsl()/hsla() 
failures due to
not implementing analogous component forwarding yet. Tracked via 
webkit.org/b/273033.

* LayoutTests/platform/glib/fast/css/hsl-color-expected.txt
* LayoutTests/platform/ios/fast/css/hsl-color-expected.txt
* LayoutTests/platform/mac/fast/css/hsl-color-expected.txt
* LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt
This test had an out of gamut hsl() color which is now getting a slightly
more green result. The render tree dump can't deal with out of gamut colors
and we should probably fix that. Tracking with webkit.org/b/273032.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp:
(WebCore::CSSPropertyParserHelpers::consumeRGBOrHSLLegacyOptionalAlphaRaw):
(WebCore::CSSPropertyParserHelpers::colorByResolvingHSLComponentsModern):
(WebCore::CSSPropertyParserHelpers::colorByResolvingHSLComponentsLegacy):
(WebCore::CSSPropertyParserHelpers::parseRelativeHSLParametersRaw):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeHSLParametersLegacyRaw):

[webkit-changes] [WebKit/WebKit] 92f622: [CMake] copy-user-interface-resources.pl very slow...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 92f622fab3091300db9c1798f2f1fb7ca1a8bd6b
  
https://github.com/WebKit/WebKit/commit/92f622fab3091300db9c1798f2f1fb7ca1a8bd6b
  Author: Philippe Normand 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M Source/WebInspectorUI/CMakeLists.txt

  Log Message:
  ---
  [CMake] copy-user-interface-resources.pl very slow on release developer builds
https://bugs.webkit.org/show_bug.cgi?id=273042

Reviewed by Michael Catanzaro.

Disable COMBINE_INSPECTOR_RESOURCES for developer builds.

Before:

Executed in   48.30 secsfish   external
   usr time   29.89 secs  304.00 micros   29.89 secs
   sys time   18.25 secs   67.00 micros   18.25 secs

After:

Executed in  378.19 millisfish   external
   usr time  233.63 millis  205.00 micros  233.42 millis
   sys time  142.31 millis   45.00 micros  142.26 millis

* Source/WebInspectorUI/CMakeLists.txt:

Canonical link: https://commits.webkit.org/277794@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 990058: [JSC] add support for `RegExp.escape`

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 990058dd93878188d65e53e02eda4b64feb69c1d
  
https://github.com/WebKit/WebKit/commit/990058dd93878188d65e53e02eda4b64feb69c1d
  Author: Devin Rousso 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
A JSTests/stress/regexp-escape.js
M Source/JavaScriptCore/runtime/OptionsList.h
M Source/JavaScriptCore/runtime/RegExpConstructor.cpp

  Log Message:
  ---
  [JSC] add support for `RegExp.escape`
https://bugs.webkit.org/show_bug.cgi?id=272622

Reviewed by Justin Michaud and Ross Kirsling.

This will help developers construct regular expressions that contain special 
characters without having to manually escape/replace them (e.g. URLs often 
contain a `.` so making a regular expression to match would require that all of 
them be replaced with `\.` instead).

Spec: 
Proposal: 

* Source/JavaScriptCore/runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
(JSC::regExpConstructorEscape): Added.

* Source/JavaScriptCore/runtime/OptionsList.h:
Add a feature flag for this.

* JSTests/stress/regexp-escape.js: Added.

Canonical link: https://commits.webkit.org/277793@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 30489f: Enable willReadFrequently for Cocoa

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30489f57ba198899d871f9a2f58e9157e5a3db2f
  
https://github.com/WebKit/WebKit/commit/30489f57ba198899d871f9a2f58e9157e5a3db2f
  Author: Kimmo Kinnunen 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/canvas/canvas-will-read-frequently-expected.txt
M LayoutTests/fast/canvas/canvas-will-read-frequently.html
A PerformanceTests/Canvas/getImageDataFromImageCPU.html
A PerformanceTests/Canvas/getImageDataFromImageGPU.html
M Source/WebCore/html/CanvasBase.cpp

  Log Message:
  ---
  Enable willReadFrequently for Cocoa
https://bugs.webkit.org/show_bug.cgi?id=272963
rdar://126739379

Reviewed by Anne van Kesteren.

* LayoutTests/TestExpectations:
* LayoutTests/fast/canvas/canvas-will-read-frequently-expected.txt:
* LayoutTests/fast/canvas/canvas-will-read-frequently.html:
* PerformanceTests/Canvas/getImageDataFromImageCPU.html: Added.
* PerformanceTests/Canvas/getImageDataFromImageGPU.html: Added.
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::allocateImageBuffer const):

Canonical link: https://commits.webkit.org/277792@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 66ae15: REGRESSION (277669@main): [ MacOS iOS ] imported/w...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66ae152260926f15ae9562167b035ae55f810fa1
  
https://github.com/WebKit/WebKit/commit/66ae152260926f15ae9562167b035ae55f810fa1
  Author: Alan Baradlay 
  Date:   2024-04-21 (Sun, 21 Apr 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/rendering/RenderText.cpp

  Log Message:
  ---
  REGRESSION (277669@main): [ MacOS iOS ] 
imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-form-controls-crash.html
 is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=272944


Reviewed by Antti Koivisto.

Only invalidate LineLayout when text content actually changes.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::setText):
(WebCore::RenderText::setTextWithOffset):

Canonical link: https://commits.webkit.org/277791@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes