[webkit-changes] [WebKit/WebKit] 2b3f00: Add more smart pointers to lazy load observers

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2b3f00e89aabd3a238b70e5153315344e8ac73e1
  
https://github.com/WebKit/WebKit/commit/2b3f00e89aabd3a238b70e5153315344e8ac73e1
  Author: Rob Buis 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/html/LazyLoadFrameObserver.cpp
M Source/WebCore/html/LazyLoadFrameObserver.h
M Source/WebCore/html/LazyLoadImageObserver.cpp

  Log Message:
  ---
  Add more smart pointers to lazy load observers
https://bugs.webkit.org/show_bug.cgi?id=273321

Reviewed by Chris Dumez.

Add more smart pointers to lazy load observers, by both replacing raw member
variables and fixing [alpha.webkit.UncountedCallArgsChecker] warnings.

* Source/WebCore/html/LazyLoadFrameObserver.cpp:
(WebCore::LazyLoadFrameObserver::observe):
(WebCore::LazyLoadFrameObserver::unobserve):
* Source/WebCore/html/LazyLoadFrameObserver.h:
* Source/WebCore/html/LazyLoadImageObserver.cpp:
(WebCore::LazyLoadImageObserver::observe):

Canonical link: https://commits.webkit.org/278368@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1cf271: [Gardening] [site-isolation] Attempt #2 of enable ...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cf2718c2e3c8760365235b7b2f537692c64baec
  
https://github.com/WebKit/WebKit/commit/1cf2718c2e3c8760365235b7b2f537692c64baec
  Author: Robert Jenner 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations

  Log Message:
  ---
  [Gardening] [site-isolation] Attempt #2 of enable more tests to run in 
site-isolation
rdar://127515199
https://bugs.webkit.org/show_bug.cgi?id=273715

Unreviewed test gardening.

* LayoutTests/platform/mac-site-isolation/TestExpectations:

Canonical link: https://commits.webkit.org/278367@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc1560: JIT operations should return the current exception...

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc1560bbe0bacc088faf2b65876379f39a324979
  
https://github.com/WebKit/WebKit/commit/fc1560bbe0bacc088faf2b65876379f39a324979
  Author: Keith Miller 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/assembler/MacroAssembler.h
M Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp
M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.cpp
M Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.cpp
M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.cpp
M Source/JavaScriptCore/b3/B3Type.h
M Source/JavaScriptCore/b3/B3Validate.cpp
M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp
M Source/JavaScriptCore/b3/testb3.h
M Source/JavaScriptCore/b3/testb3_5.cpp
M Source/JavaScriptCore/b3/testb3_6.cpp
M Source/JavaScriptCore/b3/testb3_7.cpp
M Source/JavaScriptCore/dfg/DFGAbstractInterpreter.h
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGArithMode.h
M Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGJITCompiler.h
M Source/JavaScriptCore/dfg/DFGOSRExit.cpp
M Source/JavaScriptCore/dfg/DFGOSRExit.h
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGOperations.h
M Source/JavaScriptCore/dfg/DFGSaneStringGetByValSlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp
M Source/JavaScriptCore/ftl/FTLOSRExitCompiler.h
M Source/JavaScriptCore/ftl/FTLOperations.cpp
M Source/JavaScriptCore/ftl/FTLOperations.h
M Source/JavaScriptCore/ftl/FTLOutput.cpp
M Source/JavaScriptCore/ftl/FTLOutput.h
M Source/JavaScriptCore/jit/AssemblyHelpers.cpp
M Source/JavaScriptCore/jit/AssemblyHelpers.h
M Source/JavaScriptCore/jit/CCallHelpers.h
M Source/JavaScriptCore/jit/JIT.h
M Source/JavaScriptCore/jit/JITCall.cpp
M Source/JavaScriptCore/jit/JITInlines.h
M Source/JavaScriptCore/jit/JITOperations.cpp
M Source/JavaScriptCore/jit/JITOperations.h
A Source/JavaScriptCore/jit/OperationResult.h
M Source/JavaScriptCore/llint/LLIntThunks.h
M Source/JavaScriptCore/runtime/AtomicsObject.cpp
M Source/JavaScriptCore/runtime/CommonSlowPaths.h
M Source/JavaScriptCore/runtime/ExceptionScope.h
M Source/JavaScriptCore/runtime/HashMapImplInlines.h
M Source/JavaScriptCore/runtime/MathCommon.cpp
M Source/JavaScriptCore/runtime/MathCommon.h
M Source/JavaScriptCore/runtime/StringPrototype.cpp
M Source/JavaScriptCore/tools/JSDollarVM.cpp
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/WasmOperations.h
M Source/JavaScriptCore/yarr/YarrJIT.cpp
M Source/WTF/wtf/PlatformCallingConventions.h
M Source/WTF/wtf/Threading.cpp
M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
M Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/domjit/JSDocumentDOMJIT.cpp

  Log Message:
  ---
  JIT operations should return the current exception in a return GPR when it's 
free.
https://bugs.webkit.org/show_bug.cgi?id=273264
rdar://127065985

Reviewed by Yusuke Suzuki.

This patch makes a lot of changes so that we can pass the current exception in 
a return register.

1) There's now a new set of macros for JIT_OPERATIONS that wrap the return type 
in a templated
   struct containing the true result and a pointer to the current exception if 
there's an extra
   return register in the C++ calling convention (and returning a `struct` 
won't push everything
   to the stack... armv7...).

2) Exception checking macro assembler functions take an optional register 
parameter, which is
   the register the exception is in, typically returnGPR2 but sometimes 
returnGPR.

3) Started moving FTL towards the same templated operation signature deduction 
of arguments used
   in the other JITs.

4) exception checks have been pushed into callOperation in DFG since that has 
the signature
   of the operation being called already.

5) We don't support exceptions in registers for double on ARM64 since that 
causes the double to
   be returned in x0 rather than d0. Also, FTL doesn't support 
`FastOperationResult`

[webkit-changes] [WebKit/WebKit] d72914: [WebGPU] GPUQueueDescriptor.idl is missing

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7291479188e96a6d65ccfcd622d1931a3e95e6a
  
https://github.com/WebKit/WebKit/commit/d7291479188e96a6d65ccfcd622d1931a3e95e6a
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources-output.xcfilelist
M Source/WebCore/DerivedSources.make
M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
M Source/WebCore/Modules/WebGPU/GPUDevice.h
M Source/WebCore/Modules/WebGPU/GPUDeviceDescriptor.h
M Source/WebCore/Modules/WebGPU/GPUDeviceDescriptor.idl
A Source/WebCore/Modules/WebGPU/GPUQueueDescriptor.h
A Source/WebCore/Modules/WebGPU/GPUQueueDescriptor.idl
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  ---
  [WebGPU] GPUQueueDescriptor.idl is missing
https://bugs.webkit.org/show_bug.cgi?id=272554


Reviewed by Tadeu Zagallo.

Add GPUQueueDescriptor which simply sets the label on the GPUQueue.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/WebGPU/GPUDeviceDescriptor.h:
* Source/WebCore/Modules/WebGPU/GPUDeviceDescriptor.idl:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

* Source/WebCore/Modules/WebGPU/GPUQueueDescriptor.h: Added.
* Source/WebCore/Modules/WebGPU/GPUQueueDescriptor.idl: Added.

Canonical link: https://commits.webkit.org/278365@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dc88c3: [GPUP][macOS] Add read access to sysctl properties...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc88c33a969459327c2441aaefb8ec38d9c3b6c3
  
https://github.com/WebKit/WebKit/commit/dc88c33a969459327c2441aaefb8ec38d9c3b6c3
  Author: Brent Fulgham 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in

  Log Message:
  ---
  [GPUP][macOS] Add read access to sysctl properties to match iOS
https://bugs.webkit.org/show_bug.cgi?id=273704


Reviewed by Per Arne Vollan.

In Bug 236018 we added `kern.bootargs` to the iOS sandbox to reduce telemetry, 
and because it
was needed to support control of certain system behaviors at boot time.

We should have added this to the macOS sandbox at the time, but did not.

This patch brings the two sandboxes into alignment, and avoids sandbox 
telemetry that hides
more useful findings.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/278364@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 585ea5: REGRESSION (278276@main): Crash when collecting Tr...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 585ea5ce731bd4f65e124ce2e0271a78796413dd
  
https://github.com/WebKit/WebKit/commit/585ea5ce731bd4f65e124ce2e0271a78796413dd
  Author: Megan Gardner 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/dom/DocumentMarkerController.cpp
M Source/WebCore/rendering/MarkedText.cpp
M Source/WebCore/rendering/MarkedText.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
M Source/WebCore/rendering/TextBoxPainter.cpp

  Log Message:
  ---
  REGRESSION (278276@main): Crash when collecting Transparent DocumentMarkers.
https://bugs.webkit.org/show_bug.cgi?id=273710
rdar://127511853

Reviewed by Wenson Hsieh.

Original implementation of transparent document markers
was incorrect and resulted in a WebProcess crash. They
need to be closer to draggedContent markers (which I hope
to combine them with someday) and be gathered and added
separately so they can work with selection.

* Source/WebCore/dom/DocumentMarkerController.cpp:
(WebCore::shouldInsertAsSeparateMarker):
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForDocumentMarkers):
(WebCore::MarkedText::collectForDraggedAndTransparentType):
(WebCore::MarkedText::collectForDraggedContent): Deleted.
* Source/WebCore/rendering/MarkedText.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::contentRangesBetweenOffsetsForType const):
(WebCore::RenderText::draggedContentRangesBetweenOffsets const): Deleted.
* Source/WebCore/rendering/RenderText.h:
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::paintForeground):

Canonical link: https://commits.webkit.org/278363@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1aa9df: [WebGPU] Queue should not allow command buffer to ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1aa9df849f39cec5ea2277ad8ce17b7ced915634
  
https://github.com/WebKit/WebKit/commit/1aa9df849f39cec5ea2277ad8ce17b7ced915634
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273585-expected.txt
A LayoutTests/fast/webgpu/fuzz-273585.html
M Source/WebGPU/WebGPU/Queue.mm

  Log Message:
  ---
  [WebGPU] Queue should not allow command buffer to be committed twice
https://bugs.webkit.org/show_bug.cgi?id=273585


Reviewed by Cameron McCormack.

Check the command buffer status during validation to ensure
addCompleted / scheduled handler doesn't occur after commit.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273585-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273585.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::errorValidatingSubmit const):

Canonical link: https://commits.webkit.org/278362@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c00211: Replace plain enum's by enum class at FontCascade

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c002113a5d2bf93d8b868fd78dd014c5005b9bf6
  
https://github.com/WebKit/WebKit/commit/c002113a5d2bf93d8b868fd78dd014c5005b9bf6
  Author: Vitor Roriz 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
M Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h
M Source/WebCore/platform/graphics/FontCascade.cpp
M Source/WebCore/platform/graphics/FontCascade.h
M Source/WebCore/platform/graphics/GraphicsContext.h
M Source/WebCore/platform/graphics/NullGraphicsContext.h

  Log Message:
  ---
  Replace plain enum's by enum class at FontCascade
https://bugs.webkit.org/show_bug.cgi?id=273719
rdar://127519509

Reviewed by Sammy Gill.

There are 2 plain enum's on FontCascade.
This patch replace them by enum class.

* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawTextUnchecked):
* Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h:
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::layoutSimpleText const):
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/NullGraphicsContext.h:

Canonical link: https://commits.webkit.org/278361@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6d8b44: [Legacy line layout removal] Stop measuring text i...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d8b441bc01730b462d5f6f3c18e9cbd3e8956f0
  
https://github.com/WebKit/WebKit/commit/6d8b441bc01730b462d5f6f3c18e9cbd3e8956f0
  Author: Antti Koivisto 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/glib/svg/batik/text/xmlSpace-expected.txt
M LayoutTests/platform/ios/svg/batik/text/xmlSpace-expected.txt
M LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.txt
M Source/WebCore/rendering/LegacyLineLayout.cpp
M Source/WebCore/rendering/LegacyLineLayout.h
M Source/WebCore/rendering/line/BreakingContext.h
M Source/WebCore/rendering/line/LineBreaker.cpp
M Source/WebCore/rendering/line/LineBreaker.h

  Log Message:
  ---
  [Legacy line layout removal] Stop measuring text in BreakingContext
https://bugs.webkit.org/show_bug.cgi?id=273614
rdar://127416332

Reviewed by Alan Baradlay and Sam Weinig.

SVG doesn't break lines so there is no need to measure.

* LayoutTests/platform/ios/svg/batik/text/xmlSpace-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.txt:

Non-visual change (we create an inline box for empty inline whereas previously 
we didn't)

* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutRunsAndFloatsInRange):
* Source/WebCore/rendering/LegacyLineLayout.h:
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
(WebCore::WordMeasurement::WordMeasurement): Deleted.
(WebCore::firstPositiveWidth): Deleted.
(WebCore::textWidth): Deleted.
(WebCore::BreakingContext::textWidthConsideringPossibleTrailingSpace): Deleted.
(WebCore::BreakingContext::computeAdditionalBetweenWordsWidth): Deleted.
* Source/WebCore/rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
* Source/WebCore/rendering/line/LineBreaker.h:

Canonical link: https://commits.webkit.org/278360@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a75914: Test fix: Test for parsing XML with WebCore and li...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a759149fe1d9f628136b7f90b1e71e24b54e36be
  
https://github.com/WebKit/WebKit/commit/a759149fe1d9f628136b7f90b1e71e24b54e36be
  Author: David Kilzer 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/XMLParsing.mm

  Log Message:
  ---
  Test fix: Test for parsing XML with WebCore and libxml2 in the same process
https://bugs.webkit.org/show_bug.cgi?id=273553


Unreviewed fix for API test on iOS Simulator.

API Test:
TestWebKitAPI.XMLParsing.WebCoreDoesNotBreakLibxml2

* Tools/TestWebKitAPI/Tests/WebCore/cocoa/XMLParsing.mm:
(TestWebKitAPI::XMLParsing::Setup): Add.
- Add class with Setup() method.  This is required to call
  WebCoreTestSupport::testDocumentFragmentParseXML() on iOS Simulator.
(TestWebKitAPI::TEST_F(XMLParsing, WebCoreDoesNotBreakLibxml2)):
- Improve test to check that the entity loader function is also properly
  restored.

Canonical link: https://commits.webkit.org/278359@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5fe8dd: Replace potentially more confusing decltype() usag...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5fe8dd6a3b46ad9e11f397ea324c5615cb7680bf
  
https://github.com/WebKit/WebKit/commit/5fe8dd6a3b46ad9e11f397ea324c5615cb7680bf
  Author: Sam Weinig 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
M Source/WebCore/Modules/entriesapi/FileSystemEntry.cpp
M Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp
M Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
M Source/WebCore/bindings/js/JSDOMConvertUnion.h
M Source/WebCore/css/CSSGradientValue.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/DeprecatedCSSOMValue.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/color/CSSResolvedColorMix.cpp
M Source/WebCore/dom/Node.cpp
M Source/WebCore/loader/SubresourceIntegrity.cpp
M Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp
M Source/WebCore/platform/Length.cpp
M Source/WebCore/platform/graphics/Color.cpp
M Source/WebCore/platform/graphics/ColorBlending.cpp
M Source/WebCore/platform/graphics/ColorConversion.cpp
M Source/WebCore/platform/graphics/ColorInterpolation.cpp
M Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp
M Source/WebCore/platform/graphics/ColorInterpolationMethod.h
M Source/WebCore/platform/graphics/ColorSpace.h
M Source/WebCore/platform/graphics/PathSegment.cpp
M Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp
M Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
M Source/WebCore/style/RuleFeature.cpp
M Source/WebCore/svg/SVGViewSpec.cpp
M Source/WebCore/workers/service/ServiceWorkerClients.cpp
M Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp

  Log Message:
  ---
  Replace potentially more confusing decltype() usage with template lambdas 
where possible
https://bugs.webkit.org/show_bug.cgi?id=273694

Reviewed by Darin Adler.

A somewhat common patter in WebCore is for a call site to use a generic lambda 
but still
want to know what the type of the generic argument was. Something like:

function([](auto parameter) {
using Type = std::decay_t;

...
});

This was necessary in the past due to the lack of template lambdas, but now we 
have them
and this can be come:

function([](Type parameter) {
...
});

Additionally, this now lets us provide a template parameter without the need 
for passing
an argument. For example, if the actual value of the parameter was not needed 
in the
example above, we could instead write:

function([]() {
...
});

This allows us to generalize a few places that needed a mapping of color space 
to color
type, allowing us to remove some duplicate copies of the big switch.

* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::matchAll):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
* Source/WebCore/Modules/entriesapi/FileSystemEntry.cpp:
(WebCore::FileSystemEntry::getParent):
* Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:
(WebCore::doFetch):
* Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::type const):
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::addIceCandidate):
* Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::addIceCandidate):
* Source/WebCore/bindings/js/JSDOMConvertUnion.h:
(WebCore::Detail::forEachArgs):
(WebCore::forEach):
* Source/WebCore/css/CSSGradientValue.cpp:
(WebCore::appendColorInterpolationMethod):
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::operator delete):
* Source/WebCore/css/DeprecatedCSSOMValue.cpp:
(WebCore::DeprecatedCSSOMValue::operator delete):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleBase::operator delete):
(WebCore::StyleRuleBase::copy const):
* Source/WebCore/css/color/CSSResolvedColorMix.cpp:
(WebCore::mix):
* Source/WebCore/dom/Node.cpp:
(WebCore::NodeRareData::operator delete):
* Source/WebCore/loader/SubresourceIntegrity.cpp:
(WebCore::parseIntegrityMetadata):
* Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:
(WebCore::parseApplicationCacheManifest):
* Source/WebCore/platform/Length.cpp:
(WebCore::Length::Length):
* Source/WebCore/platform/graphics/Color.cpp:
(WebCore::Color::anyComponentIsNone const):
(WebCore::Color::invertedColorWithAlpha const):
* Source/WebCore/platform/graphics/Col

[webkit-changes] [WebKit/WebKit] 25b857: [WebGPU] RenderBundleEncoder::setPipeline replay c...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25b857296fadedbda2bfc9d957537b46338149e4
  
https://github.com/WebKit/WebKit/commit/25b857296fadedbda2bfc9d957537b46338149e4
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273578-expected.txt
A LayoutTests/fast/webgpu/fuzz-273578.html
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.h
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] RenderBundleEncoder::setPipeline replay command should call into 
RenderPassEncoder
https://bugs.webkit.org/show_bug.cgi?id=273578


Reviewed by Dan Glastonbury.

We were not validating setPipeline calls in ICBs leading
to metal validation errors in invalid usage scenarios.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273578-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273578.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setPipeline):
Class helper.

* Source/WebGPU/WebGPU/RenderPassEncoder.h:
Introduce helper.

* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::errorValidatingPipeline const):
(WebGPU::RenderPassEncoder::setPipeline):
Call helper.

Canonical link: https://commits.webkit.org/278357@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 04fce8: Refactor logic for muting autoplaying video elemen...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04fce867503f4cab34c98b03c5b5c117dd914767
  
https://github.com/WebKit/WebKit/commit/04fce867503f4cab34c98b03c5b5c117dd914767
  Author: Wenson Hsieh 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
A LayoutTests/fast/element-targeting/target-video-in-subframe-expected.txt
A LayoutTests/fast/element-targeting/target-video-in-subframe.html
M LayoutTests/resources/ui-helper.js
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/page/ElementTargetingTypes.h
M Source/WebCore/page/MediaProducer.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/UIProcess/API/APITargetedElementInfo.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.h
M Source/WebKit/UIProcess/API/Cocoa/_WKTargetedElementInfo.mm
M Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
M Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.h
M Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm

  Log Message:
  ---
  Refactor logic for muting autoplaying video elements in background tabs
https://bugs.webkit.org/show_bug.cgi?id=273633
rdar://125859510

Reviewed by Aditya Keerthi.

Refactor some logic related to muting media elements. See below for more 
details.

* LayoutTests/fast/element-targeting/target-video-in-subframe-expected.txt: 
Added.
* LayoutTests/fast/element-targeting/target-video-in-subframe.html: Added.
* LayoutTests/resources/ui-helper.js:
(window.UIHelper.resetVisibilityAdjustments):
(window.UIHelper):

Add a new layout test (and testing hooks) to exercise the change.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::visibilityAdjustmentStateDidChange):

Add plumbing to propagate visibility state change to all audio producers.

* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setVisibilityAdjustment):

Set a flag on `Page` to indicate that we've applied visibility adjustment to at 
least one element
before. Used in `isInVisibilityAdjustmentSubtree()` below to exit right away, 
in the common case
where there has never been visibility adjustment.

(WebCore::Element::isInVisibilityAdjustmentSubtree const):

Add a helper method to compute whether or not the element is inside of a 
visibility adjustment
subtree, by traversing ancestors in the DOM.

* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didFinishInsertingNode):
(WebCore::HTMLMediaElement::removedFromAncestor):
(WebCore::HTMLMediaElement::visibilityAdjustmentStateDidChange):

Recompute and cache the visibility adjustment subtree state whenever the media 
element is
unparented, re-parented, or visibility state otherwise changes.

(WebCore::HTMLMediaElement::effectiveMuted const):

Consult the cached state flag that's updated above when determining whether the 
media element should
be `effectivelyMuted()`.

* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::hasAudibleMedia):
(WebCore::targetedElementInfo):

Add support for a `hasAudibleMedia` flag on targeted element info.

(WebCore::findOnlyMainElement):
(WebCore::isNavigationalElement):
(WebCore::containsNavigationalElement):

Drive-by fix: mark the arguments to a few helper functions as `const`.

(WebCore::ElementTargetingController::adjustVisibility):
(WebCore::ElementTargetingController::adjustVisibilityInRepeatedlyTargetedRegions):
(WebCore::ElementTargetingController::resetVisibilityAdjustments):
(WebCore::ElementTargetingController::dispatchVisibilityAdjustmentStateDidChange):
* Source/WebCore/page/ElementTargetingController.h:
* Source/WebCore/page/ElementTargetingTypes.h:
* Source/WebCore/page/MediaProducer.h:
(WebCore::MediaProducer::visibilityAdjustmentStateDidChange):

Add a new delegate hook to inform media producers when visibility state 
changes. Currently, this is
only implemented by `HTMLMediaElement`, which allows it to adjust whether or 
not the underlying
media player should be muted, through `effectiveMuted()`.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::didCommitLoad):
* Source/WebCore/page/Page.h:

Add a boolean flag to track whether or not there has ever been any visibility 
adjustment in the
page (this bit is cleared out in `didCommitLoad` above).

(WebCore::Page::hasEverSetVisibi

[webkit-changes] [WebKit/WebKit] 415ec2: [ iOS wk2 ] webgl/1.0.3/conformance/uniforms/out-o...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 415ec24722aedbfd49f21e9a5dd41347a7136bd4
  
https://github.com/WebKit/WebKit/commit/415ec24722aedbfd49f21e9a5dd41347a7136bd4
  Author: Jay Stfleur 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  [ iOS wk2 ] 
webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html is a 
flaky/consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=269321
rdar://122912491

Unreviewed test gardening.

Removing test expectation.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/278355@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8d47e9: [ Sonoma+ wk2 Release ] inspector/console/console-...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8d47e90a96db05b0f771ea5453685b29ef55d496
  
https://github.com/WebKit/WebKit/commit/8d47e90a96db05b0f771ea5453685b29ef55d496
  Author: Jay Stfleur 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  [ Sonoma+ wk2 Release ] inspector/console/console-screenshot.html is a flaky 
text failure
https://bugs.webkit.org/show_bug.cgi?id=268200
rdar://121695395

Unreviewed test gardening.

Removing test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/278354@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c4552: REGRESSION: [ Ventura+ Release x86_64 ] fast/canva...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c4552d23e72054a1b0f9839447a1813f9aa3a4a
  
https://github.com/WebKit/WebKit/commit/3c4552d23e72054a1b0f9839447a1813f9aa3a4a
  Author: Jay Stfleur 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  REGRESSION: [ Ventura+ Release x86_64 ] 
fast/canvas/image-buffer-backend-variants.html  is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=267612
rdar://121081110

Unreviewed test gardening.

Removing test expectation.

* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/278353@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 438692: --only-smart-pointers should enable webkit.NoUncou...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 438692dd840d555018cb25e55ae5bc1dc177a7e4
  
https://github.com/WebKit/WebKit/commit/438692dd840d555018cb25e55ae5bc1dc177a7e4
  Author: Ryosuke Niwa 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Tools/Scripts/build-and-analyze

  Log Message:
  ---
  --only-smart-pointers should enable webkit.NoUncountedMemberChecker and 
webkit.RefCntblBaseVirtualDtor
https://bugs.webkit.org/show_bug.cgi?id=273674

Reviewed by Geoffrey Garen and David Kilzer.

This PR enables two WebKit checkers webkit.NoUncountedMemberChecker and 
webkit.RefCntblBaseVirtualDtor
with --only-smart-pointers.

* Tools/Scripts/build-and-analyze:
(make_analyzer_flags):

Canonical link: https://commits.webkit.org/278352@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 371cab: Avoid copying FontPalette and FontVariantAlternates

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 371cab863ee8cb0010261fddb8e0435391fc4dbd
  
https://github.com/WebKit/WebKit/commit/371cab863ee8cb0010261fddb8e0435391fc4dbd
  Author: Brent Fulgham 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/platform/graphics/FontDescription.h
M Source/WebCore/platform/text/TextFlags.cpp
M Source/WebCore/platform/text/TextFlags.h
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  ---
  Avoid copying FontPalette and FontVariantAlternates
https://bugs.webkit.org/show_bug.cgi?id=273568


Reviewed by Chris Dumez.

Reduce unnecessary copies in our font handling code:
(1) FontPalette is a struct containing an enum and an AtomString, and should be 
returned
by const reference to avoid copying that string.
(2) FontVariantAlternates is lightweight, containing only a `Markable`, but the
`Markable` is holding a very heavy-weight object that contains Vectors of 
Strings,
and Strings.

* Source/WebCore/css/CSSFontFace.h:
* Source/WebCore/css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::fontFace):
* Source/WebCore/css/CSSFontFaceSet.h:
* Source/WebCore/platform/graphics/FontDescription.h:
(WebCore::FontDescription::variantAlternates const):
(WebCore::FontDescription::fontPalette const):
(WebCore::FontDescription::setVariantAlternates):
(WebCore::FontDescription::setFontPalette):
* Source/WebCore/platform/text/TextFlags.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/text/TextFlags.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::fontPalette const):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueFontVariantAlternates):

Canonical link: https://commits.webkit.org/278351@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0470d0: REGRESSION (iOS 17.4.1?): tag fails to adj...

[Eric Carlson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0470d0f338da5e4a677552edd1f13f7549159271
  
https://github.com/WebKit/WebKit/commit/0470d0f338da5e4a677552edd1f13f7549159271
  Author: Eric Carlson 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm

  Log Message:
  ---
  REGRESSION (iOS 17.4.1?):  tag fails to adjust its size according to 
changes in the parent element
https://bugs.webkit.org/show_bug.cgi?id=272078
rdar://125881482

Reviewed by Jer Noble.

When layout changes the size of a remote-hosted video element with a MediaStream
source, the order of calls to `VideoPresentationManagerProxy` and
`VideoPresentationModelContext` isn't always the same. If
`VideoPresentationManagerProxy::createViewWithID` is called before the model's
view has been created, it creates and configures a WebAVPlayerLayerView and
a WKVideoView. It did not set the model's video dimensions, which sometimes
caused WebAVPlayerLayer to be resized incorrectly when layout changed the
size of the video element very quickly.

* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createViewWithID): Call 
model->setVideoDimensions
with the video's native dimensions.

Canonical link: https://commits.webkit.org/278350@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 603edf: [Gardening][ Site-Isolation ] Enable more tests to...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 603edf08c9a2be2387cdd44241a9ef4628274bd9
  
https://github.com/WebKit/WebKit/commit/603edf08c9a2be2387cdd44241a9ef4628274bd9
  Author: Robert Jenner 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations

  Log Message:
  ---
  [Gardening][ Site-Isolation ] Enable more tests to run in site-isolation]
https://bugs.webkit.org/show_bug.cgi?id=273715
rdar://127515199

Unreviewed test gardening.

* LayoutTests/platform/mac-site-isolation/TestExpectations:

Canonical link: https://commits.webkit.org/278349@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb7b0b: Drop StringBuilder:append() overload taking in a `...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb7b0b0b9e5e2cda97a1624334713db993fa4ce0
  
https://github.com/WebKit/WebKit/commit/eb7b0b0b9e5e2cda97a1624334713db993fa4ce0
  Author: Chris Dumez 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/API/tests/PingPongStackOverflowTest.cpp
M Source/JavaScriptCore/bytecode/Instruction.h
M Source/JavaScriptCore/bytecode/Opcode.cpp
M Source/JavaScriptCore/bytecode/Opcode.h
M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp
M Source/JavaScriptCore/heap/GCLogging.cpp
M Source/JavaScriptCore/heap/GCLogging.h
M Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/runtime/ConsoleClient.cpp
M Source/JavaScriptCore/runtime/DateConversion.cpp
M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
M Source/JavaScriptCore/runtime/FileBasedFuzzerAgent.cpp
M Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.cpp
M Source/JavaScriptCore/runtime/FunctionConstructor.cpp
M Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp
M Source/JavaScriptCore/runtime/IntlDurationFormat.cpp
M Source/JavaScriptCore/runtime/IntlNumberFormat.cpp
M Source/JavaScriptCore/runtime/IntlNumberFormatInlines.h
M Source/JavaScriptCore/runtime/Options.cpp
M Source/JavaScriptCore/runtime/Options.h
M Source/JavaScriptCore/runtime/PredictionFileCreatingFuzzerAgent.cpp
M Source/JavaScriptCore/runtime/RegExp.cpp
M Source/JavaScriptCore/runtime/TypeProfiler.cpp
M Source/JavaScriptCore/runtime/TypeSet.cpp
M Source/JavaScriptCore/tools/FunctionOverrides.cpp
M Source/WTF/wtf/JSONValues.cpp
M Source/WTF/wtf/text/StringBuilder.h
M Source/WTF/wtf/text/TextStream.cpp
M Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp
M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp
M Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp
M Source/WebCore/Modules/fetch/FetchHeaders.cpp
M Source/WebCore/Modules/geolocation/Geolocation.cpp
M Source/WebCore/Modules/indexeddb/IDBKeyData.cpp
M Source/WebCore/Modules/indexeddb/IDBKeyPath.cpp
M Source/WebCore/Modules/indexeddb/server/IndexValueStore.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp
M Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp
M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp
M Source/WebCore/Modules/websockets/WebSocket.cpp
M Source/WebCore/Modules/websockets/WebSocketExtensionDispatcher.cpp
M Source/WebCore/PAL/pal/avfoundation/OutputContext.mm
M Source/WebCore/bindings/js/ScriptController.cpp
M Source/WebCore/contentextensions/CombinedURLFilters.cpp
M Source/WebCore/contentextensions/Term.h
M Source/WebCore/css/CSSBasicShapes.cpp
M Source/WebCore/css/CSSContainerRule.cpp
M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
M Source/WebCore/css/CSSFontFaceSrcValue.cpp
M Source/WebCore/css/CSSFontFeatureValuesRule.cpp
M Source/WebCore/css/CSSFontFeatureValuesRule.h
M Source/WebCore/css/CSSFontPaletteValuesRule.cpp
M Source/WebCore/css/CSSGradientValue.cpp
M Source/WebCore/css/CSSGroupingRule.cpp
M Source/WebCore/css/CSSImportRule.cpp
M Source/WebCore/css/CSSLayerBlockRule.cpp
M Source/WebCore/css/CSSLayerStatementRule.cpp
M Source/WebCore/css/CSSLineBoxContainValue.cpp
M Source/WebCore/css/CSSMarkup.cpp
M Source/WebCore/css/CSSMediaRule.cpp
M Source/WebCore/css/CSSNamespaceRule.cpp
M Source/WebCore/css/CSSPropertyRule.cpp
M Source/WebCore/css/CSSScopeRule.cpp
M Source/WebCore/css/CSSSelectorList.cpp
M Source/WebCore/css/CSSStyleRule.cpp
M Source/WebCore/css/CSSStyleSheet.cpp
M Source/WebCore/css/CSSSupportsRule.cpp
M Source/WebCore/css/CSSTimingFunctionValue.cpp
M Source/WebCore/css/ShorthandSerializer.cpp
M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
M Source/WebCore/css/parser/CSSParserToken.cpp
M Source/WebCore/css/query/GenericMediaQuerySerialization.cpp
M Source/WebCore/css/query/MediaQueryParser.cpp
M Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp
M Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp
M Source/WebCore/css/typedom/numeric/CSSMathMax.cpp
M Source/WebCore/css/typedom/numeric/CSSMathMin.cpp
M Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp
M Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp
M Source/WebCore/css/typedom/numeric/CSSMathSum.cpp
M Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp
M Source/WebCore/css/typedom/transform/CSSPerspective.cpp
M Source/WebCore/css/typedom/transform/CSSRotate.cpp
M Source/WebCore/css/typedom/transform/CSSScale.cpp
M Source/WebCore/css/typedom/transform/CSSSkewX.cpp
M Source/WebCore/css/typedom/transform/CSSSkewY.cpp
M Source/WebCore/css/typedom

[webkit-changes] [WebKit/WebKit] 3a1c5a: [WebGPU] Destroyed texture should not be used as d...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a1c5a3d36c4a39fd3509541b23a39dafc756089
  
https://github.com/WebKit/WebKit/commit/3a1c5a3d36c4a39fd3509541b23a39dafc756089
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebGPU/WebGPU/Device.mm

  Log Message:
  ---
  [WebGPU] Destroyed texture should not be used as depth stencil attachments
https://bugs.webkit.org/show_bug.cgi?id=273323


Reviewed by Tadeu Zagallo.

Destroyed textures are 1x1 bgra8unorm textures, there is no
benefit to having those set as a depth stencil attachment.

Any draw commands will make the command encoder invalid when a
destroyed texture is used during a draw command, so there is
no change in behavior.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273323-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273323.html: Added.
* LayoutTests/fast/webgpu/fuzz-273573-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273573.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
(WebGPU::Device::placeholderTexture const):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::m_maxDrawCount):
(WebGPU::RenderPassEncoder::drawIndexed):
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::destroy):
* Source/WebGPU/WebGPU/TextureView.h:
(WebGPU::TextureView::texture const): Deleted.
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::texture const):
(WebGPU::TextureView::destroy):

Canonical link: https://commits.webkit.org/278347@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c194c: [WebGPU] CommandEncoder::beginRenderPass can fail ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c194cc6e82c4f336bd5817c7f17d3f3d744efad
  
https://github.com/WebKit/WebKit/commit/1c194cc6e82c4f336bd5817c7f17d3f3d744efad
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273503-expected.txt
A LayoutTests/fast/webgpu/fuzz-273503.html
M Source/WebGPU/WebGPU/CommandEncoder.mm

  Log Message:
  ---
  [WebGPU] CommandEncoder::beginRenderPass can fail metal validation for 
destroyed textures
https://bugs.webkit.org/show_bug.cgi?id=273503


Reviewed by Dan Glastonbury.

Destroyed textures have one mip level and one slice.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273503-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273503.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):

Canonical link: https://commits.webkit.org/278346@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c53d43: [Unified Text Replacement] When a "rich text" text...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c53d438a8fed8e5c2a8ca63d7e5c900ee9d24967
  
https://github.com/WebKit/WebKit/commit/c53d438a8fed8e5c2a8ca63d7e5c900ee9d24967
  Author: Richard Robinson 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm
M Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h

  Log Message:
  ---
  [Unified Text Replacement] When a "rich text" text replacement session ends, 
the session should be undone if it is not accepted
https://bugs.webkit.org/show_bug.cgi?id=273709
rdar://127390343

Reviewed by Abrar Rahman Protyasha.

Ensure that `didEndTextReplacementSession` handles both plain text and rich 
text replacements properly.

* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
(WebKit::UnifiedTextReplacementController::didEndTextReplacementSession):
* Source/WebKit/WebProcess/WebPage/UnifiedTextReplacementController.h:

Canonical link: https://commits.webkit.org/278345@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9fdc37: [cocoa] Expand when new experimental network loade...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fdc371bbb0e6ca63346e3781017e65cb0de1637
  
https://github.com/WebKit/WebKit/commit/9fdc371bbb0e6ca63346e3781017e65cb0de1637
  Author: Matthew Finkel 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
M Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h
M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm

  Log Message:
  ---
  [cocoa] Expand when new experimental network loader is enabled
https://bugs.webkit.org/show_bug.cgi?id=273091
rdar://126718999

Reviewed by Brent Fulgham.

The existing feature flag still takes precedence, but now the loader is used
when the a LOOA check passes, and for all tests (not only layout tests).
Otherwise, if the loader is enabled, then we use it for Safari.

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::useNetworkLoader):

Canonical link: https://commits.webkit.org/278344@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e8f92: Implement trusted types integration with script el...

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e8f9225aef76436cdf18015c6037d5810d87fae
  
https://github.com/WebKit/WebKit/commit/4e8f9225aef76436cdf18015c6037d5810d87fae
  Author: Luke Warlow 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
A 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
A 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt
M Source/WebCore/dom/TrustedType.cpp
M Source/WebCore/dom/TrustedType.h
M Source/WebCore/html/HTMLScriptElement.cpp
M Source/WebCore/html/HTMLScriptElement.h
M Source/WebCore/html/HTMLScriptElement.idl
M Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm

  Log Message:
  ---
  Implement trusted types integration with script elements IDL
https://bugs.webkit.org/show_bug.cgi?id=269718

Reviewed by Ryosuke Niwa and Darin Adler.

Implement shadow properties for textContent and innerText on HTMLScriptElement.
Implement enforcement on src and text as well as the shadowed properties.

This doesn't implement any changes to the prepareScript function that will be 
addressed in a follow up.

Spec: https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-scripts

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* 
LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt:
* Source/WebCore/dom/TrustedType.cpp:
(WebCore::trustedTypeCompliantString):
* Source/WebCore/dom/TrustedType.h:
* Source/WebCore/html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
(WebCore::HTMLScriptElement::setTextContent):
(WebCore::HTMLScriptElement::setInnerText):
(WebCore::HTMLScriptElement::src const):
(WebCore::HTMLScriptElement::setSrc):
(WebCore::HTMLScriptElement::addSubresourceAttributeURLs const):
* Source/WebCore/html/HTMLScriptElement.h:
* Source/WebCore/html/HTMLScriptElement.idl:
* Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm:
(-[DOMHTMLScriptElement setText:]):

Canonical link: https://commits.webkit.org/278343@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d62376: [UnifiedPDF] Going between page layout modes doesn...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d6237610e33903698a8368b9bc1a7bf4af9495cc
  
https://github.com/WebKit/WebKit/commit/d6237610e33903698a8368b9bc1a7bf4af9495cc
  Author: Sammy Gill 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Going between page layout modes doesn't rescale or center 
appropriately
https://bugs.webkit.org/show_bug.cgi?id=273696
rdar://125381629

Reviewed by Abrar Rahman Protyasha and Simon Fraser.

To fix this, we can just force m_shouldUpdateAutoSizeScale to be set
right before we perform a document layout in this scenario. This will make
sure that the document gets refitted to the available width.

However, we should also respect if the document is already in
"Automatically Resize," mode. This means that we should not adjust the
page scale factor when performing this layout if the state was *already*
set.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setDisplayModeAndUpdateLayout):

Canonical link: https://commits.webkit.org/278342@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd689a: Add rounded corners to videos in in-window fullscr...

[Dana Estra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd689ab77d9e39a83693a5bb7655941e9d6c7c24
  
https://github.com/WebKit/WebKit/commit/bd689ab77d9e39a83693a5bb7655941e9d6c7c24
  Author: Dana Estra 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/css/fullscreen.css

  Log Message:
  ---
  Add rounded corners to videos in in-window fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=273692
rdar://127496496

Reviewed by Jer Noble.

Add rounded corners to videos in in-window fullscreen mode. This
Requires setting the margins to auto to avoid stretching the
Aspect ratio of the video and removing padding so that the
Rounded corners appear along the video content.

* Source/WebCore/css/fullscreen.css:
(*|*:not(:root):-internal-in-window-fullscreen):

Canonical link: https://commits.webkit.org/278341@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a2287: Adopt smart pointers in WebCore/bridge/ files

[Mikhail R. Gadelha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a2287a135f68bd03cbcee31be0afd575c27e207
  
https://github.com/WebKit/WebKit/commit/0a2287a135f68bd03cbcee31be0afd575c27e207
  Author: Mikhail R. Gadelha 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/bridge/runtime_array.cpp
M Source/WebCore/bridge/runtime_method.cpp
M Source/WebCore/bridge/runtime_object.cpp

  Log Message:
  ---
  Adopt smart pointers in WebCore/bridge/ files
https://bugs.webkit.org/show_bug.cgi?id=273642

Reviewed by Chris Dumez.

Changes based on clang-tidy's alpha.webkit.UncountedLocalVars checker.

* Source/WebCore/bridge/runtime_array.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
* Source/WebCore/bridge/runtime_method.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/WebCore/bridge/runtime_object.cpp:
(JSC::Bindings::JSC_DEFINE_CUSTOM_GETTER):
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::JSC_DEFINE_HOST_FUNCTION):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Canonical link: https://commits.webkit.org/278340@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcf26e: AX: Remove unused traits from WebAccessibilityObje...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcf26e870112c64f47227ea3b147779e3ed4da69
  
https://github.com/WebKit/WebKit/commit/dcf26e870112c64f47227ea3b147779e3ed4da69
  Author: Tyler Wilcock 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/accessibility/ios-simulator/fieldset-traits-expected.txt
M LayoutTests/accessibility/ios-simulator/fieldset-traits.html
M LayoutTests/accessibility/ios-simulator/landmark-type-expected.txt
M LayoutTests/accessibility/ios-simulator/landmark-type.html
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Tools/DumpRenderTree/AccessibilityUIElement.cpp
M Tools/DumpRenderTree/AccessibilityUIElement.h
M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp
M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

  Log Message:
  ---
  AX: Remove unused traits from WebAccessibilityObjectWrapperIOS.mm
https://bugs.webkit.org/show_bug.cgi?id=273549
rdar://problem/127362143

Reviewed by Chris Fleizach.

Remove several traits that are not used by any accessibility framework.

All but `_axContainedByFieldsetTrait` were added in commit:

https://github.com/WebKit/WebKit/commit/4290c93aecfb2f3cea540f159f24ea589e138dfb

`_axContainedByFieldsetTrait` was added in:

https://github.com/WebKit/WebKit/commit/9a8c226e01ae1ac9bc5f971ab13900275c9b21de

* LayoutTests/accessibility/ios-simulator/fieldset-traits-expected.txt:
* LayoutTests/accessibility/ios-simulator/fieldset-traits.html:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]): Deleted.
* Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::getJSClass):
(hasContainedByFieldsetTraitCallback): Deleted.
* Tools/DumpRenderTree/AccessibilityUIElement.h:
* Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::hasContainedByFieldsetTrait): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait): Deleted.

Canonical link: https://commits.webkit.org/278339@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a64941: Add a hasTraps() check in B3::Value::effects()

[Keith Miller]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a649419b8cf4bc2d1b95dfc5c2ba17bf4310de8c
  
https://github.com/WebKit/WebKit/commit/a649419b8cf4bc2d1b95dfc5c2ba17bf4310de8c
  Author: Keith Miller 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/b3/B3EliminateDeadCode.cpp
M Source/JavaScriptCore/b3/B3Value.cpp

  Log Message:
  ---
  Add a hasTraps() check in B3::Value::effects()
https://bugs.webkit.org/show_bug.cgi?id=273648
rdar://127458113

Reviewed by Yusuke Suzuki.

Some profiling of reduceStrength showed we spent a number of samples
in B3::Value::effects() checking traps(). But most B3 Kinds don't
ever have traps(). Since we just switched on the Kind we can use
`hasTraps()` hoist the traps() check into the cases that actually
use it.

* Source/JavaScriptCore/b3/B3EliminateDeadCode.cpp:
(JSC::B3::eliminateDeadCodeImpl):
* Source/JavaScriptCore/b3/B3Value.cpp:
(JSC::B3::Value::effects const):

Canonical link: https://commits.webkit.org/278338@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a46465: [WebGPU] no need to clear destroyed textures

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4646567a5dadda7de0b64cdc57e6e4ab6fb2e4a
  
https://github.com/WebKit/WebKit/commit/a4646567a5dadda7de0b64cdc57e6e4ab6fb2e4a
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273570-expected.txt
A LayoutTests/fast/webgpu/fuzz-273570.html
M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  ---
  [WebGPU] no need to clear destroyed textures
https://bugs.webkit.org/show_bug.cgi?id=273570


Reviewed by Cameron McCormack.

Destroyed textures act like valid objects but no operations
including clearing should occur on them.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273570-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273570.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::previouslyCleared const):

Canonical link: https://commits.webkit.org/278337@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ff9b34: Unreviewed, reverting 278275@main (c97a08d)

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff9b348d8343bfcc3a9fed4dc42303bed3f6113c
  
https://github.com/WebKit/WebKit/commit/ff9b348d8343bfcc3a9fed4dc42303bed3f6113c
  Author: Yijia Huang 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSBase.h
M Source/JavaScriptCore/API/JSValue.h
M Source/JavaScriptCore/API/JSValue.mm
M Source/JavaScriptCore/API/JSValueRef.cpp
M Source/JavaScriptCore/API/JSValueRef.h
M Source/JavaScriptCore/API/tests/testapi.cpp
M Source/JavaScriptCore/API/tests/testapi.mm

  Log Message:
  ---
  Unreviewed, reverting 278275@main (c97a08d)
https://bugs.webkit.org/show_bug.cgi?id=273705
rdar://127504731

Failed Xcode build

Reverted change:

[WIP] Introduce BigInt Public C API in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=250511
rdar://104194532
278275@main (c97a08d)

Canonical link: https://commits.webkit.org/278336@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4142d9: Rename "computedCSSPadding()" to "resolveLengthPer...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4142d950a6e7766786f1f3e2bd4650e3228628ec
  
https://github.com/WebKit/WebKit/commit/4142d950a6e7766786f1f3e2bd4650e3228628ec
  Author: Simon Fraser 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderBoxModelObject.h
M Source/WebCore/rendering/RenderBoxModelObjectInlines.h

  Log Message:
  ---
  Rename "computedCSSPadding()" to "resolveLengthPercentage()"
https://bugs.webkit.org/show_bug.cgi?id=273672
rdar://problem/127473476

Reviewed by Tim Nguyen.

`computedCSSPadding()` was called for margin values in 
`RenderBox::marginBoxRect()`,
so is clearly misnamed. It's really resolving the CSS ``[1] 
values
which use the container's logical width (which is true for margins and padding)
so name it thusly.

[1] https://drafts.csswg.org/css-values-4/#mixed-percentages

* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::marginBoxRect const):
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderBoxModelObjectInlines.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter const):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore const):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom const):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd const):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft const):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight const):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart const):
(WebCore::RenderBoxModelObject::computedCSSPaddingTop const):
(WebCore::RenderBoxModelObject::resolveLengthPercentageUsingContainerLogicalWidth
 const):
(WebCore::RenderBoxModelObject::computedCSSPadding const): Deleted.

Canonical link: https://commits.webkit.org/278335@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 27bf3c: Fix a typo in the name of setTransfrom-aliases-tra...

[Frances Cornwall]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27bf3cb29852e2e0558f19ee09e13e9d1d1c0fa3
  
https://github.com/WebKit/WebKit/commit/27bf3cb29852e2e0558f19ee09e13e9d1d1c0fa3
  Author: Frances Cornwall 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
A LayoutTests/fast/canvas/setTransform-aliases-transform-expected.html
A LayoutTests/fast/canvas/setTransform-aliases-transform.html
R LayoutTests/fast/canvas/setTransfrom-aliases-transform-expected.html
R LayoutTests/fast/canvas/setTransfrom-aliases-transform.html

  Log Message:
  ---
  Fix a typo in the name of setTransfrom-aliases-transform-expected.html and 
setTransfrom-aliases-transform.html
https://bugs.webkit.org/show_bug.cgi?id=273654

Reviewed by Said Abou-Hallawa.

Rename setTransfrom-aliases-transform-expected.html and 
setTransfrom-aliases-transform.html to 
setTransform-aliases-transform-expected.html and 
setTransfrom-aliases-transform.html.

* LayoutTests/fast/canvas/setTransform-aliases-transform-expected.html: Renamed 
from LayoutTests/fast/canvas/setTransfrom-aliases-transform-expected.html.
* LayoutTests/fast/canvas/setTransform-aliases-transform.html: Renamed from 
LayoutTests/fast/canvas/setTransfrom-aliases-transform.html.

Canonical link: https://commits.webkit.org/278334@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6126d8: [Site Isolation] Begin considering iframe navigati...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6126d87e8020993596d13f1fc39c5803dbcadd40
  
https://github.com/WebKit/WebKit/commit/6126d87e8020993596d13f1fc39c5803dbcadd40
  Author: Charlie Wolfe 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/loader/HistoryController.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  [Site Isolation] Begin considering iframe navigations in the back-forward list
https://bugs.webkit.org/show_bug.cgi?id=273669
rdar://127471573

Reviewed by Alex Christensen.

When an iframe is initially loaded with site isolation disabled, 
`LockBackForwardList::Yes` is set on the
frame load request to indicate that the back-forward list should not be 
updated. We should do the same
when loading an iframe in a new process. Also, remove an unnecessary return 
that causes any isolated
frame navigation to be ignored.

The test verifies that `canGoBack` returns false after initially loading a 
cross-origin iframe, but
returns true after the iframe navigates.

* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, CanGoBackAfterLoadingAndNavigatingFrame)):

Canonical link: https://commits.webkit.org/278333@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e4d6c1: [visionOS] Add SPI module for LinearMediaKit

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4d6c1fe5c1faced0e57babc474e9a5c73628a3f
  
https://github.com/WebKit/WebKit/commit/e4d6c1fe5c1faced0e57babc474e9a5c73628a3f
  Author: Elliott Williams 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/Configurations/WebKitSwift.xcconfig
A Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface
M Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h

  Log Message:
  ---
  [visionOS] Add SPI module for LinearMediaKit
rdar://127327242
https://bugs.webkit.org/show_bug.cgi?id=273527

Reviewed by Andy Estes.

Reland of https://commits.webkit.org/278232@main which avoids making
risky changes to XPCSPI.h and WebKitSwift's language mode.

In order to build visionOS using the public SDK, WebKitSwift needs to
`import LinearMediaKit`, which a private framework. For C-family
frameworks we'd handle this by adding an SPI header, to go with
auto-extracted TBDs in WebKitLibraries/. But because this is a Swift
framework, we need an alternative.

Add a handwritten LinearMediaKit.swiftinterface file to the relevant spi
directory. This contains the subset of the framework that WebKit links
against. In public SDK builds, SWIFT_INCLUDE_PATHS is modified to
include this directory, making the module importable in public while
falling back to the private framework's module internally.

* Source/WebKit/Configurations/WebKitSwift.xcconfig:
* Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface: Added.
* Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h: In
  public visionOS builds, libxpc is not available. Rather than use
  XPCSPI.h, which has non-modular includes and assumes a c++ compiler,
  use OS_OBJECT_DECL to get a xpc_object_t for use in interface
  declarations.

Canonical link: https://commits.webkit.org/278332@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4e9e48: LinearMediaKitSPI.h is installed as a private SDK ...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e9e482a62317a2ef7fe192f0a1e9452a0903bf2
  
https://github.com/WebKit/WebKit/commit/4e9e482a62317a2ef7fe192f0a1e9452a0903bf2
  Author: Elliott Williams 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebKitSwift/WebKitSwift.h

  Log Message:
  ---
  LinearMediaKitSPI.h is installed as a private SDK header
https://bugs.webkit.org/show_bug.cgi?id=273666
rdar://problem/127468662

Reviewed by Andy Estes.

Partial reland of https://commits.webkit.org/278232@main, SPI module
changes will land as a follow-up.

Remove LinearMediaKitSPI.h from private headers and the WebKitSwift.h
umbrella header, as it is causing TAPI failures. It doesn't need to be
installed to SDK; it's only used from within the WebKit.xcodeproj
targets.

* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/WebKitSwift.h:

Canonical link: https://commits.webkit.org/278331@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b8d20: Canvas/getImageDataFromImageCPU.html and Canvas/ge...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b8d201ec04a474680eb0e26e546aca3f3df906c
  
https://github.com/WebKit/WebKit/commit/4b8d201ec04a474680eb0e26e546aca3f3df906c
  Author: Kimmo Kinnunen 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M PerformanceTests/Canvas/getImageDataFromImageCPU.html
M PerformanceTests/Canvas/getImageDataFromImageGPU.html

  Log Message:
  ---
  Canvas/getImageDataFromImageCPU.html and Canvas/getImageDataFromImageGPU.html 
fail
https://bugs.webkit.org/show_bug.cgi?id=273680
rdar://127329340

Reviewed by Alexey Proskuryakov and Anne van Kesteren.

Remove console.log() messages that cause the tests to fail in automation.

* PerformanceTests/Canvas/getImageDataFromImageCPU.html:
* PerformanceTests/Canvas/getImageDataFromImageGPU.html:

Canonical link: https://commits.webkit.org/278330@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 252452: REGRESSION (274409@main): [ macOS wk2 ] 2 tests in...

[Matthew Finkel]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 252452ae30653f87ce0c6d9f6fb21cbb68df1dfd
  
https://github.com/WebKit/WebKit/commit/252452ae30653f87ce0c6d9f6fb21cbb68df1dfd
  Author: Matthew Finkel 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M 
LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https-UpgradeMixedContent.html
M 
LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https.html
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  REGRESSION (274409@main): [ macOS wk2 ] 2 tests in 
http/tests/navigation/ping-attribute are flaky
https://bugs.webkit.org/show_bug.cgi?id=269798
rdar://123321229

Reviewed by Charlie Wolfe.

These tests have been flakey since 274409@main. Apparently there's a race
condition between the the xhr request that deletes any stale pings and the
script-based location redirect. This change attempts to avoid that issue by
only deleting cookies if we're not going to load a different page.

* 
LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https-UpgradeMixedContent.html:
* 
LayoutTests/http/tests/navigation/ping-attribute/area-cross-origin-from-https.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/278329@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 82dc23: Unreviewed, reverting 278288@main (e67257693a4f)

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82dc23eeba43b14ac36dee42927276dc19336d52
  
https://github.com/WebKit/WebKit/commit/82dc23eeba43b14ac36dee42927276dc19336d52
  Author: Jonathan Bedard 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/AccessCase.cpp
M Source/JavaScriptCore/bytecode/AccessCase.h
M Source/JavaScriptCore/bytecode/GetByStatus.cpp
M Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp
M Source/JavaScriptCore/bytecode/GetterSetterAccessCase.h
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/PutByStatus.cpp
M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h
M Source/JavaScriptCore/runtime/StructureID.h

  Log Message:
  ---
  Unreviewed, reverting 278288@main (e67257693a4f)
https://bugs.webkit.org/show_bug.cgi?id=273690
rdar://127494769

Broke Debug EWS

Reverted change:

[JSC] Start using limited variant of Handler IC
https://bugs.webkit.org/show_bug.cgi?id=273604
rdar://127402051
278288@main (e67257693a4f)

Canonical link: https://commits.webkit.org/278328@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 078b08: [visionOS] Refine transition for Image Fullscreen

[Etienne Segonzac]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 078b086740b309270f57e55054d1da8298ffce4f
  
https://github.com/WebKit/WebKit/commit/078b086740b309270f57e55054d1da8298ffce4f
  Author: Etienne Segonzac 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  ---
  [visionOS] Refine transition for Image Fullscreen
https://bugs.webkit.org/show_bug.cgi?id=272829


Reviewed by Aditya Keerthi.

Special case the transition to fullscreen when using Quick Look, since
scene swapping will take care of the animation, and we don't display the
fullscreen window.
Bump the QOS of the WorkQueue. It's only used as part of the fullscreen
transition, in reaction to user action.

* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::sharedQuickLookFileQueue):
QOS bump.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
Keep track of whether or not we're using Image Fullscreen. It impacts
the exit transition, and we don't want to depend on the exact moment the
image buffer is released in WebFullScreenManagerProxy.
(-[WKFullScreenWindowController _configureSpatialFullScreenTransition]):
Skip the spatial fullscreen transition window manipulation when using
Image Fullscreen.
(-[WKFullScreenWindowController 
_performSpatialFullScreenTransition:completionHandler:]):
Add a new Image Fullscreen code path for the transition in and out of
fullscreen. Hide the fullscreen window since we're not using it.
Remove the old branches at different points during the transition.
(-[WKFullScreenWindowController showUI]):
Remove the Image Fullscreen specific chrome management, the WebKit
window will be hidden.

Canonical link: https://commits.webkit.org/278327@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7328ea: [WebGPU] Destroyed texture should not be used as d...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7328ea1a6d2a83ce883c443780f6e916dbc56f28
  
https://github.com/WebKit/WebKit/commit/7328ea1a6d2a83ce883c443780f6e916dbc56f28
  Author: Mike Wyrzykowski 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/webgpu/fuzz-273323-expected.txt
A LayoutTests/fast/webgpu/fuzz-273323.html
A LayoutTests/fast/webgpu/fuzz-273573-expected.txt
A LayoutTests/fast/webgpu/fuzz-273573.html
M Source/WebGPU/WebGPU/CommandEncoder.mm
M Source/WebGPU/WebGPU/Device.h
M Source/WebGPU/WebGPU/Device.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/Texture.mm
M Source/WebGPU/WebGPU/TextureView.h
M Source/WebGPU/WebGPU/TextureView.mm

  Log Message:
  ---
  [WebGPU] Destroyed texture should not be used as depth stencil attachments
https://bugs.webkit.org/show_bug.cgi?id=273323


Reviewed by Tadeu Zagallo.

Destroyed textures are 1x1 bgra8unorm textures, there is no
benefit to having those set as a depth stencil attachment.

Any draw commands will make the command encoder invalid when a
destroyed texture is used during a draw command, so there is
no change in behavior.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273323-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273323.html: Added.
* LayoutTests/fast/webgpu/fuzz-273573-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273573.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
(WebGPU::Device::placeholderTexture const):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::m_maxDrawCount):
(WebGPU::RenderPassEncoder::drawIndexed):
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::destroy):
* Source/WebGPU/WebGPU/TextureView.h:
(WebGPU::TextureView::texture const): Deleted.
* Source/WebGPU/WebGPU/TextureView.mm:
(WebGPU::TextureView::texture const):
(WebGPU::TextureView::destroy):

Canonical link: https://commits.webkit.org/278326@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2da25a: Unskip html/semantics/popover-light-dismiss.html WPT

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2da25afcddf733555a446fc6851676dbe23dfea4
  
https://github.com/WebKit/WebKit/commit/2da25afcddf733555a446fc6851676dbe23dfea4
  Author: Luke Warlow 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html
M LayoutTests/platform/glib/TestExpectations
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M LayoutTests/platform/ios/TestExpectations
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt
M LayoutTests/platform/mac-ventura-wk2/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  Unskip html/semantics/popover-light-dismiss.html WPT
https://bugs.webkit.org/show_bug.cgi?id=273141

Reviewed by Tim Nguyen.

This patch splits the "Scrolling withing" subtest from the 
popover-light-dismiss.html WPT into its own file.
It also unskips the main light dimiss test on all platforms.

* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within.html:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:
* LayoutTests/platform/mac-ventura-wk2/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:

* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt:

 LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/278325@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dc1ebf: [MacOS] WKWebView should have SPI to report whethe...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc1ebf3e81905b72da8d9f266b88db88d7847f08
  
https://github.com/WebKit/WebKit/commit/dc1ebf3e81905b72da8d9f266b88db88d7847f08
  Author: Abrar Rahman Protyasha 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm

  Log Message:
  ---
  [MacOS] WKWebView should have SPI to report whether a PDF is being displayed
https://bugs.webkit.org/show_bug.cgi?id=273639
rdar://127442624

Reviewed by Tim Horton.

This patch exposes the `_isDisplayingPDF` method on WKWebViewMac, which
clients can query to answer whether the web view is presenting a main
frame PDF.

This also establishes parity with WKWebViewIOS, where the namesake was
added in 149116@main.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isDisplayingPDF]):

Move getter implementation to this shared location.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:

Move property declaration to the shared WKPrivate category.

* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _isDisplayingPDF]): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
(TEST(WKWebView, IsDisplayingPDF)):

Add an API test exercising the `_isDisplayingPDF` SPI.

Canonical link: https://commits.webkit.org/278324@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d48763: Fix for UIProcess crash after 273330.

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d48763c9c2dea7e864c05a2731e910e8387fcd67
  
https://github.com/WebKit/WebKit/commit/d48763c9c2dea7e864c05a2731e910e8387fcd67
  Author: Megan Gardner 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm

  Log Message:
  ---
  Fix for UIProcess crash after 273330.
https://bugs.webkit.org/show_bug.cgi?id=273663
rdar://127466607

Reviewed by Abrar Rahman Protyasha, Tim Horton and Wenson Hsieh.

If the web process crashes, then this UI process will crash with no
mainFrame and/or frameID.

* Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):

Canonical link: https://commits.webkit.org/278323@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fcd15c: AX: accessibility/element-reflection-ariaowns.html...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcd15cc132a52511cebd1c2cd06deb77e40ce1ad
  
https://github.com/WebKit/WebKit/commit/fcd15cc132a52511cebd1c2cd06deb77e40ce1ad
  Author: Andres Gonzalez 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
M LayoutTests/accessibility/aria-owns-hierarchy-remap-expected.txt
M LayoutTests/accessibility/aria-owns-hierarchy-remap.html
M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  ---
  AX: accessibility/element-reflection-ariaowns.html times out in isolated tree 
mode.
https://bugs.webkit.org/show_bug.cgi?id=273632


Reviewed by Tyler Wilcock.

The cause of the problem is that the parent of the newly owned object needs to 
be notified that one of its children is removed. There was an attempt to do 
this by notifying a previous owner of the owned object, but that wasn't enough 
because it doesn't work for targets that were not previously owned.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/aria-owns-hierarchy-remap-expected.txt:
* LayoutTests/accessibility/aria-owns-hierarchy-remap.html:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::addRelation):

Canonical link: https://commits.webkit.org/278322@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29e764: [GTK][WPE] Rebaseline after 261894@main

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29e7640d3ac0f4c6c079c580b98ac14767da77df
  
https://github.com/WebKit/WebKit/commit/29e7640d3ac0f4c6c079c580b98ac14767da77df
  Author: Vitaly Dyachkov 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M 
LayoutTests/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt
M 
LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt
M 
LayoutTests/platform/glib/accessibility/deleting-iframe-destroys-axcache-expected.txt
M 
LayoutTests/platform/glib/accessibility/w3c-svg-presentational-role-expected.txt
M LayoutTests/platform/glib/accessibility/w3c-svg-roles-expected.txt
R 
LayoutTests/platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt
M 
LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt

  Log Message:
  ---
  [GTK][WPE] Rebaseline after 261894@main

Unreviewed rebaseline.

* 
LayoutTests/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt:
* 
LayoutTests/platform/glib/accessibility/aria-visible-element-roles-expected.txt:
* 
LayoutTests/platform/glib/accessibility/deleting-iframe-destroys-axcache-expected.txt:
* 
LayoutTests/platform/glib/accessibility/w3c-svg-presentational-role-expected.txt:
* LayoutTests/platform/glib/accessibility/w3c-svg-roles-expected.txt:
* 
LayoutTests/platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/accessibility/aria-visible-element-roles-expected.txt:

Canonical link: https://commits.webkit.org/278321@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 394936: [GTK] accessibility/aria-combobox-control-owns-ele...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3949366a96b5f945dcea33cb5222ae3429505ee5
  
https://github.com/WebKit/WebKit/commit/3949366a96b5f945dcea33cb5222ae3429505ee5
  Author: Vitaly Dyachkov 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations

  Log Message:
  ---
  [GTK] accessibility/aria-combobox-control-owns-elements.html timing out since 
added in r227144
https://bugs.webkit.org/show_bug.cgi?id=182107

Unreviewed test gardening.

Fixed in 277921@main.

* LayoutTests/platform/glib/TestExpectations:

Canonical link: https://commits.webkit.org/278320@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7c46c2: [WPE][Debug] ASSERTION FAILED: m_wrapper

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7c46c2f8a2111433c881737a881f09d62348cb9a
  
https://github.com/WebKit/WebKit/commit/7c46c2f8a2111433c881737a881f09d62348cb9a
  Author: Vitaly Dyachkov 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  ---
  [WPE][Debug] ASSERTION FAILED: m_wrapper
https://bugs.webkit.org/show_bug.cgi?id=266711

Reviewed by Chris Dumez.

We should not dispatch the "resize" event if `ScriptExecutionContext`
has already been stopped.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::layoutSizeChanged):

Canonical link: https://commits.webkit.org/278319@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 65862d: AX: aria-describedby text can become stale after t...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65862d818c5d5e4878f83a7f0ece5241ef658c21
  
https://github.com/WebKit/WebKit/commit/65862d818c5d5e4878f83a7f0ece5241ef658c21
  Author: Tyler Wilcock 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
A LayoutTests/accessibility/dynamic-aria-describedby-subtree-expected.txt
A LayoutTests/accessibility/dynamic-aria-describedby-subtree.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  ---
  AX: aria-describedby text can become stale after the targeted element changes 
its subtree
https://bugs.webkit.org/show_bug.cgi?id=273584
rdar://problem/127390465

Reviewed by Andres Gonzalez.

When an object targeted by aria-describedby changes its subtree, we need to 
re-compute AXPropertyName::{AccessibilityText, ExtendedDescription}
for the described object. We already did this for aria-labelledby 
relationships, so this patch hooks into the same
method to check for describedby relationships too.

* LayoutTests/accessibility/dynamic-aria-describedby-subtree-expected.txt: 
Added.
* LayoutTests/accessibility/dynamic-aria-describedby-subtree.html: Added.
* LayoutTests/platform/glib/TestExpectations: Skip new test.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateDependentProperties):

Canonical link: https://commits.webkit.org/278318@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53e169: [GTK] Gardening a11y API tests

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53e169967eff062fc425dcd26e50b89a1073d5ea
  
https://github.com/WebKit/WebKit/commit/53e169967eff062fc425dcd26e50b89a1073d5ea
  Author: Claudio Saavedra 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  ---
  [GTK] Gardening a11y API tests
https://bugs.webkit.org/show_bug.cgi?id=273683

Unreviewed gardening.

These tests are failing in the bots, mark the failure.

* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/278317@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 862356: [GLIB] Simplify the GTlsCertificate argument coders

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 86235681dd54e9723d90a56cf1f5bfbdb5a94cf9
  
https://github.com/WebKit/WebKit/commit/86235681dd54e9723d90a56cf1f5bfbdb5a94cf9
  Author: Claudio Saavedra 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp
M Source/WebKit/Shared/glib/ArgumentCodersGLib.h

  Log Message:
  ---
  [GLIB] Simplify the GTlsCertificate argument coders
https://bugs.webkit.org/show_bug.cgi?id=273677

Reviewed by Michael Catanzaro.

Instead of handcoding the certificate chain, use a Vector directly, which
has coding support already. Similarly, instead of handcoding GByteArray structs
in a handful of different places, add an argument coder for GByteArray and use 
it
where needed.

* Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp:
(IPC::ArgumentCoder>::encode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::encode):
(IPC::ArgumentCoder>::decode):
* Source/WebKit/Shared/glib/ArgumentCodersGLib.h:

Canonical link: https://commits.webkit.org/278316@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e86473: Adopt more smart pointers in IntersectionObserver

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e864738237198a14b63c6f519be1023b951f00fe
  
https://github.com/WebKit/WebKit/commit/e864738237198a14b63c6f519be1023b951f00fe
  Author: Rob Buis 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/page/IntersectionObserver.cpp

  Log Message:
  ---
  Adopt more smart pointers in IntersectionObserver
https://bugs.webkit.org/show_bug.cgi?id=273478

Reviewed by Chris Dumez.

Adopt more smart pointers in IntersectionObserver based on the
[alpha.webkit.UncountedLocalVarsChecker] warning.

* Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::observe):
(WebCore::IntersectionObserver::unobserve):
(WebCore::IntersectionObserver::disconnect):
(WebCore::IntersectionObserver::targetDestroyed):
(WebCore::computeClippedRectInRootContentsSpace):
(WebCore::IntersectionObserver::nowTimestamp const):
(WebCore::IntersectionObserver::notify):
(WebCore::IntersectionObserver::isReachableFromOpaqueRoots const):

Canonical link: https://commits.webkit.org/278315@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc4f41: [GTK][WPE] Rebaseline `accessibility/combobox/aria...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc4f416faf364311ee2ba573725339818edc2ed3
  
https://github.com/WebKit/WebKit/commit/bc4f416faf364311ee2ba573725339818edc2ed3
  Author: Vitaly Dyachkov 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
R 
LayoutTests/platform/glib/accessibility/combobox/aria-combobox-no-owns-expected.txt

  Log Message:
  ---
  [GTK][WPE] Rebaseline `accessibility/combobox/aria-combobox-no-owns.html`

Unreviewed rebaseline after 277921@main.

* 
LayoutTests/platform/glib/accessibility/combobox/aria-combobox-no-owns-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/278314@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fcd93b: [WinCairo] Unreviewed test gardening

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcd93b88f5b342c4bd38cc6bece31fe829f36c93
  
https://github.com/WebKit/WebKit/commit/fcd93b88f5b342c4bd38cc6bece31fe829f36c93
  Author: Fujii Hironori 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  [WinCairo] Unreviewed test gardening

* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/278313@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1f466b: Web Inspector: Scrollbar shows behind content in C...

[Razvan Caliman - Apple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f466b833564041ac97f7008b6137a79c9f30692
  
https://github.com/WebKit/WebKit/commit/1f466b833564041ac97f7008b6137a79c9f30692
  Author: Razvan Caliman 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.css
M Source/WebInspectorUI/UserInterface/Views/LogContentView.css

  Log Message:
  ---
  Web Inspector: Scrollbar shows behind content in Console and Event badge 
popover
https://bugs.webkit.org/show_bug.cgi?id=273638
rdar://127442634

Reviewed by Simon Fraser.

Workaround for rdar://125601926

Overflow doesn't create a CSS stacking context.

* Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.css:
(.event-badge-popover-content > .details-section.event-listeners):
* Source/WebInspectorUI/UserInterface/Views/LogContentView.css:
(.console-messages):

Canonical link: https://commits.webkit.org/278312@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fb6f64: Adjust iOS animation

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb6f64f9959f2873795185a5be1348f9c2d75cbb
  
https://github.com/WebKit/WebKit/commit/fb6f64f9959f2873795185a5be1348f9c2d75cbb
  Author: Anne van Kesteren 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/html/CheckboxInputType.cpp
M Source/WebCore/html/CheckboxInputType.h
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/html/HTMLInputElement.h
M Source/WebCore/platform/graphics/SpringSolver.h
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/ios/RenderThemeIOS.h

  Log Message:
  ---
  Adjust  iOS animation
https://bugs.webkit.org/show_bug.cgi?id=271839
rdar://125563501

Reviewed by Aditya Keerthi.

The pressed animation for the thumb needs a slight delay. This in turn
necessitates introducing additional state to indicate when it is
pressed, as the control generally being active is no longer sufficient
(that changes too early now).

Also make these more general improvements:

- Rename pressed to held to account for the slight change in semantics.
- Abstract finding the relevant Touch of a TouchEvent in a method.
- Call dispatchSimulatedClick with SendNoEvents for its mouse events
  argument. They are redundant and could possibly lead to non-touch
  code paths being triggered.

* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::findTouchWithIdentifier):
(WebCore::CheckboxInputType::subsequentTouchEventTouch const):
(WebCore::CheckboxInputType::handleTouchEvent):
(WebCore::CheckboxInputType::startSwitchPointerTracking):
(WebCore::CheckboxInputType::stopSwitchPointerTracking):
(WebCore::CheckboxInputType::disabledStateChanged):
(WebCore::CheckboxInputType::willUpdateCheckedness):
(WebCore::switchAnimationDuration):
(WebCore::CheckboxInputType::switchAnimationStartTime const):
(WebCore::CheckboxInputType::setSwitchAnimationStartTime):
(WebCore::CheckboxInputType::setIsSwitchHeld):
(WebCore::CheckboxInputType::isSwitchVisuallyOn const):
(WebCore::CheckboxInputType::switchAnimationHeldProgress const):
(WebCore::CheckboxInputType::isSwitchHeld const):
(WebCore::CheckboxInputType::switchAnimationTimerFired):
(WebCore::CheckboxInputType::switchAnimationPressedProgress const): Deleted.
* Source/WebCore/html/CheckboxInputType.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::switchAnimationHeldProgress const):
(WebCore::HTMLInputElement::isSwitchHeld const):
(WebCore::HTMLInputElement::switchAnimationPressedProgress const): Deleted.
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/platform/graphics/SpringSolver.h:
(WebCore::SpringSolver::solve const):
(WebCore::SpringSolver::solve): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::switchAnimationHeldDuration const):
(WebCore::RenderTheme::switchAnimationPressedDuration const): Deleted.
* Source/WebCore/rendering/ios/RenderThemeIOS.h:

Canonical link: https://commits.webkit.org/278311@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cde484: Adopt more smart pointers in History.cpp

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cde48409003c820470a6e7ff1f5e2c753fa956e7
  
https://github.com/WebKit/WebKit/commit/cde48409003c820470a6e7ff1f5e2c753fa956e7
  Author: Rob Buis 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/page/History.cpp

  Log Message:
  ---
  Adopt more smart pointers in History.cpp
https://bugs.webkit.org/show_bug.cgi?id=273541

Reviewed by Sihui Liu.

Adopt more smart pointers in History.cpp based on the
[alpha.webkit.UncountedLocalVarsChecker] warning.

* Source/WebCore/page/History.cpp:
(WebCore::History::length const):
(WebCore::History::scrollRestoration const):
(WebCore::History::setScrollRestoration):
(WebCore::History::go):
(WebCore::History::urlForState):

Canonical link: https://commits.webkit.org/278310@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3f1a72: [webkitpy] Make Executive.kill_process more reliable.

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f
  
https://github.com/WebKit/WebKit/commit/3f1a725ef3d3f0a0ee05b56aff41fbfdae90f34f
  Author: Ben Schwartz 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Tools/Scripts/webkitpy/common/system/executive.py

  Log Message:
  ---
  [webkitpy] Make Executive.kill_process more reliable.
rdar://127407344
https://bugs.webkit.org/show_bug.cgi?id=273652

Reviewed by Ryan Haddad and Jonathan Bedard.

Executive.kill_process currently tries to exit with SIGTERM once and then jumps 
straight to
SIGKILL. This can leave leftover processes, as SIGKILL sometimes doesn't give 
processes
enough time to react in the way that SIGTERM does.

* Tools/Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process): Add more retries and wait 0.05 seconds after each.

Canonical link: https://commits.webkit.org/278309@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ecb7a6: [ArmV7] proxy-is-array.js is a constant failure

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ecb7a69e6acd372f569c4f07a7bbfe11269b46a9
  
https://github.com/WebKit/WebKit/commit/ecb7a69e6acd372f569c4f07a7bbfe11269b46a9
  Author: Justin Michaud 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

  Log Message:
  ---
  [ArmV7] proxy-is-array.js is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=273626

Reviewed by Yusuke Suzuki.

In 277977@main, I opted in the 32-bit direct call path into DataIC, except the
change makes absolutely no sense. It is still calling repatch just below, and
the 64-bit ports don't use DataIC here either, so this just broke direct call 
repatching.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):

Canonical link: https://commits.webkit.org/278308@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c8fc95: Re-import css/css-view-transitions WPT

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8fc955f74a3ba462e3738aace67c17544db90f8
  
https://github.com/WebKit/WebKit/commit/c8fc955f74a3ba462e3738aace67c17544db90f8
  Author: Tim Nguyen 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/resources/resource-files.json
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.txt
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition-destroyed-document-crash.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildard-expected.html
R 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildard.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildcard-expected.html
A 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildcard.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-element-display-none-during-transition-crash.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-to-shared-animation-incoming-expected.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-to-shared-animation-incoming-ref.html
M 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/w3c-import.log
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  Re-import css/css-view-transitions WPT
https://bugs.webkit.org/show_bug.cgi?id=273664
rdar://127467132

Reviewed by Matt Woodrow.

Upstream commit: 
https://github.com/web-platform-tests/wpt/commit/8fdc5d7317af5c0d7812c26366d066843bc523ae

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/resources/resource-files.json:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.html:
 Removed.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unpainted-element-from-point-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/iframe-transition-destroyed-document-crash.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildcard-expected.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildard-expected.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildcard.html:
 Renamed from 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-with-classes-match-wildard.html.
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-element-display-none-during-transition-crash.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-to-shared-animation-incoming-expected.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/root-to-shared-animation-incoming-ref.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/w3c-import.log:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/278307@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f7fca: [GStreamer][WebAudio] Misc improvements in playbac...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f7fcac9257ebed1331734bccf454638ca63a732
  
https://github.com/WebKit/WebKit/commit/9f7fcac9257ebed1331734bccf454638ca63a732
  Author: Philippe Normand 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

  Log Message:
  ---
  [GStreamer][WebAudio] Misc improvements in playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=273555

Reviewed by Xabier Rodriguez-Calvar.

A small queue is needed before the sink, by design. In the webaudiosrc element 
timestamping was
improved, silent buffers are now flagged as droppable and the render task 
starts only when going to
PLAYING state.

* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcRenderAndPushFrames):
(webKitWebAudioSrcChangeState):

Canonical link: https://commits.webkit.org/278306@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e9b556: [ARMv7] Fix concurrent BBQ repatching

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9b5568186739399f480a72072955bb38563436e
  
https://github.com/WebKit/WebKit/commit/e9b5568186739399f480a72072955bb38563436e
  Author: Justin Michaud 
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/ARMv7Assembler.h
M Source/JavaScriptCore/assembler/AssemblerCommon.h
M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

  Log Message:
  ---
  [ARMv7] Fix concurrent BBQ repatching
https://bugs.webkit.org/show_bug.cgi?id=273545

Reviewed by Keith Miller and Yusuke Suzuki.

Armv7 places a few interesting constraints on repatching in thumb mode:

- As far as I can tell, you cannot concurrently repatch a mov without an isb
- bl and family can be repatched without an isb, but bl is a 32-bit instruction.
So to repatch it concurrently, we need it to be 4-byte aligned.

This patch fixes this. I also added some debug assertions that verified that
this was the only place in our test case that tried to concurrently repatch an 
unaligned
bl, but the assertions were too involved to upstream.

This should fix export-arity.js crashes on armv7 on ToT.

* Source/JavaScriptCore/assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::alignWithNop):
* Source/JavaScriptCore/assembler/AssemblerCommon.h:
(JSC::machineCodeCopy):
* Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::threadSafePatchableNearCall):
(JSC::MacroAssemblerARMv7::threadSafePatchableNearTailCall):

Canonical link: https://commits.webkit.org/278305@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes