[webkit-changes] [WebKit/WebKit] 2e01b0: Gardening: Post Accessibility notifications during...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e01b0865746d8111a6353ba474df8b339a7f3cb
  
https://github.com/WebKit/WebKit/commit/2e01b0865746d8111a6353ba474df8b339a7f3cb
  Author: Ben Schwartz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: Post Accessibility notifications during composition contexts 
indicating start, end, and value change.
https://bugs.webkit.org/show_bug.cgi?id=258228
rdar://110925384

Unreviewed test gardening.

Enabling test on Sonoma+.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279429@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 119130: Pass invalidation handler to ExtensionProcess::gra...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11913004d540d2edc9ab32dffa2e1c15624e73cb
  
https://github.com/WebKit/WebKit/commit/11913004d540d2edc9ab32dffa2e1c15624e73cb
  Author: Per Arne Vollan 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/Platform/cocoa/AssertionCapability.h
M Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
M Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.h
M Source/WebKit/UIProcess/Launcher/cocoa/ExtensionProcess.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

  Log Message:
  ---
  Pass invalidation handler to ExtensionProcess::grantCapability
https://bugs.webkit.org/show_bug.cgi?id=274331
rdar://126825362

Reviewed by Chris Dumez.

In order for the invalidation handler to be called when the grant is 
invalidated, we need to
pass the invalidation handler to ExtensionProcess::grantCapability.

* Source/WebKit/Platform/cocoa/AssertionCapability.h:
* Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm:
(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::acquireSync):
(WebKit::Functionhttps://commits.webkit.org/279428@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8aa207: [webkitpy] Increase pid attachment timeout thresho...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8aa207a07272e6a453adcd964135ff0e263426b2
  
https://github.com/WebKit/WebKit/commit/8aa207a07272e6a453adcd964135ff0e263426b2
  Author: Ben Schwartz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/Scripts/webkitpy/port/simulator_process.py

  Log Message:
  ---
  [webkitpy] Increase pid attachment timeout threshold for SimulatorProcess.
rdar://128904125

Reviewed by Ryan Haddad.

We are seeing timeouts under certain circumstances and would like to increase 
the threshold
while the root cause is investigated.

* Tools/Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess._start):

Canonical link: https://commits.webkit.org/279427@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 237b90: Add an early return if loading updated DNR rules f...

[Brian Weinstein]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 237b90c1c756967c60ca644f02dcc13084364628
  
https://github.com/WebKit/WebKit/commit/237b90c1c756967c60ca644f02dcc13084364628
  Author: Brian Weinstein 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm

  Log Message:
  ---
  Add an early return if loading updated DNR rules fails
https://bugs.webkit.org/show_bug.cgi?id=274785
rdar://128749905

Reviewed by Timothy Hatcher.

Without this early return, we were both trying to roll back to a savepoint and 
commit the same savepoint,
and then we would call the completion handler more than once, leading to this 
crash.

These code paths should be mutually exclusive, so make sure to add an early 
return.

* 
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIDeclarativeNetRequestCocoa.mm:
(WebKit::WebExtensionContext::updateDeclarativeNetRequestRulesInStorage):

Canonical link: https://commits.webkit.org/279426@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 71e39c: When converting HTML that contains an image to an ...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71e39c7bd8fc08ef9171cf4bfbaed96673158980
  
https://github.com/WebKit/WebKit/commit/71e39c7bd8fc08ef9171cf4bfbaed96673158980
  Author: Richard Robinson 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/editing/cocoa/HTMLConverter.mm
M Source/WebCore/loader/mac/LoaderNSURLExtras.h
M Source/WebCore/loader/mac/LoaderNSURLExtras.mm

  Log Message:
  ---
  When converting HTML that contains an image to an attributed string and back 
using `HTMLConverter::editingAttributedString`, the image is lost
https://bugs.webkit.org/show_bug.cgi?id=274701
rdar://128717614

Reviewed by Aditya Keerthi.

When converting an NSAttributedString to an HTML document fragment, if the 
attributed string
contains a text attachment backed by a file wrapper without a preferred file 
name, the attachment
is dropped and not converted to HTML.

Fix by ensuring that a file wrapper for an image always has a preferred file 
name when converting
HTML to an attributed string inside of `HTMLConverter::editingAttributedString` 
using the following
mechanism:

1. If the image is backed by an attachment, use the attachment's title as the 
preferred name.
2. Otherwise, try to use the image's alt attribute's value as the preferred 
name, if present.
3. Otherwise, try to convert the image's url into a filename and use that as 
the preferred name.
4. If all else fails, use the default "unknown" file name as the preferred name.

* Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverter::HTMLConverter):
(HTMLConverter::_addLinkForElement):
(HTMLConverter::_processElement):
(preferredFilenameForElement):
(fileWrapperForElement):

Canonical link: https://commits.webkit.org/279425@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3abd48: [Remote Inspection] Adjust the heuristic when comp...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3abd48ae06eaeb85830aa83b2983cf0b80fefa15
  
https://github.com/WebKit/WebKit/commit/3abd48ae06eaeb85830aa83b2983cf0b80fefa15
  Author: Wenson Hsieh 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/page/ElementTargetingController.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm

  Log Message:
  ---
  [Remote Inspection] Adjust the heuristic when computing the adjustment rect 
count
https://bugs.webkit.org/show_bug.cgi?id=274810
rdar://128885913

Reviewed by Abrar Rahman Protyasha and Megan Gardner.

Make a minor adjustment to how we handle empty (or `display: none;`) elements 
when getting the total
adjustment rect count, so that they count towards the final result.

* Source/WebCore/page/ElementTargetingController.cpp:
(WebCore::ElementTargetingController::numberOfVisibilityAdjustmentRects const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting, AdjustVisibilityFromSelectors)):

Canonical link: https://commits.webkit.org/279424@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b01d2: Add ArrayBuffer::createFromBytes() overload which ...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b01d2cbf96a742dfb6195ebe6220455f349b902
  
https://github.com/WebKit/WebKit/commit/9b01d2cbf96a742dfb6195ebe6220455f349b902
  Author: Chris Dumez 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/API/JSTypedArray.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp

  Log Message:
  ---
  Add ArrayBuffer::createFromBytes() overload which takes in a std::span
https://bugs.webkit.org/show_bug.cgi?id=274795

Reviewed by Darin Adler.

Add ArrayBuffer::createFromBytes() overload which takes in a std::span
to promote the use of spans.

* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::createAdopted):
(JSC::ArrayBuffer::createFromBytes):
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::createFromBytes):

Canonical link: https://commits.webkit.org/279423@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4af8f0: Fix render tree construction when inlines are inse...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4af8f052cd4fee2c1f169220ab61ed94f512d0ff
  
https://github.com/WebKit/WebKit/commit/4af8f052cd4fee2c1f169220ab61ed94f512d0ff
  Author: Ahmad Saleem 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A 
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block-expected.txt
A 
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block.html
M LayoutTests/platform/glib/tables/mozilla/bugs/bug113235-3-expected.txt
M LayoutTests/platform/ios/tables/mozilla/bugs/bug113235-3-expected.txt
M LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.png
M LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt
M Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp

  Log Message:
  ---
  Fix render tree construction when inlines are inserted in reverse after a 
block in a continuation

https://bugs.webkit.org/show_bug.cgi?id=274762
rdar://problem/128826228

Reviewed by Darin Adler.

This patch aligns WebKit with Blink / Chromium and
Gecko / Firefox.

Merge: 
https://chromium.googlesource.com/chromium/blink/+/6ac676e5e68e3271321b9c8236192b6a530d055e

When inserting inlines after a block inside of an inline continuation,
if we insert inline content in reverse DOM order, we can (depending on
when we attach) end up appending the renderers in the wrong location,
leading to visual aberrations.

The fix is in RenderTreeBuilder, where we should always attach behind our
beforeChild if we're inserting an inline and beforeChild is an inline,
regardless of other continuation state.

* Source/WebCore/rendering/updating/RenderTreeBuilderInline.cpp:
(WebCore::RenderTreeBuilder::Inline::insertChildToContinuation):
* 
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block.html:
 Add Test Case
* 
LayoutTests/fast/inline/continuation-inlines-inserted-in-reverse-after-block-expected.txt:
 Add Test Case Expectation
* LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt: 
Rebaselined
* LayoutTests/platform/mac/tables/mozilla/bugs/bug113235-3-expected.png: Ditto
* LayoutTests/platform/glib/tables/mozilla/bugs/bug113235-3-expected.txt: Ditto
* LayoutTests/platform/ios/tables/mozilla/bugs/bug113235-3-expected.txt: Ditto

Canonical link: https://commits.webkit.org/279422@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e0283: Adjust error-handling for invalid filter primitive...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e028375b9c5a9717932ec07c446b4d1b9704345
  
https://github.com/WebKit/WebKit/commit/8e028375b9c5a9717932ec07c446b4d1b9704345
  Author: Ahmad Saleem 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/css3/filters/invalid-reference-filter-in-chain.html
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
M 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
M 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt
M LayoutTests/svg/filters/feMerge-wrong-input-expected.txt
A LayoutTests/svg/filters/in-attribute-error-handling-expected.html
A LayoutTests/svg/filters/in-attribute-error-handling.html
M Source/WebCore/svg/graphics/filters/SVGFilterGraph.h

  Log Message:
  ---
  Adjust error-handling for invalid filter primitive references

https://bugs.webkit.org/show_bug.cgi?id=250276
rdar://problem/104262208

Reviewed by Simon Fraser and Darin Adler.

This patch aligns LegacySVG engine in WebKit with
Gecko / Firefox and Blink / Chromium.

Merge: 
https://chromium.googlesource.com/chromium/blink/+/ffa39ae78904542a2864e2cb7d1c16c24ee2324e

When a filter primitive has an 'in' (or, where applicable, 'in2') attribute
that references a non-existent result, treat that reference as having the
default value (==no value) instead of producing an error.

* Source/WebCore/svg/graphics/filters/SVGFilterGraph.h:
(WebCore::SVGFilterGraph::getNamedNode const):
* LayoutTests/svg/filters/in-attribute-error-handling.html: Add Test Case
* LayoutTests/svg/filters/in-attribute-error-handling-expected.html: Add Test 
Case Expectation
* LayoutTests/css3/filters/invalid-reference-filter-in-chain.html: Add Pixel 
Tolerance for GTK and WPE

> Rebaselines:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt:
* 
LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-02-b-manual-expected.txt:
* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/import/filters-overview-03-b-manual-expected.txt:
* LayoutTests/svg/filters/feMerge-wrong-input-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-background-01-f-manual-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-composite-03-f-manual-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-tests/svg/import/filters-overview-01-b-manual-expected.txt:
* 
LayoutTests/platform/ios/imported/w3c/web-platform-

[webkit-changes] [WebKit/WebKit] 1cf2af: REGRESSION (macOS 14): Form controls draw with an ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1cf2af72f97ef4de30a5d7edad747d3360dece65
  
https://github.com/WebKit/WebKit/commit/1cf2af72f97ef4de30a5d7edad747d3360dece65
  Author: Aditya Keerthi 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M 
LayoutTests/fast/forms/select/mac-wk2/inactive-appearance-expected-mismatch.html
M LayoutTests/fast/forms/select/mac-wk2/inactive-appearance.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/PAL/pal/spi/mac/NSCellSPI.h
M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm

  Log Message:
  ---
  REGRESSION (macOS 14): Form controls draw with an active appearance when the 
window is inactive
https://bugs.webkit.org/show_bug.cgi?id=273588
rdar://127391198

Reviewed by Richard Robinson.

Prior to GPU process support on macOS, inactive form controls were drawn by
overriding the return value of `hasKeyAppearance` on the backing window as
necessary. However, with the introduction of GPU process, `NSCell`s are no 
longer
backed by a control view, and do not have a window. Consequently, they are
always drawn with an active appearance.

This is not an issue in configurations where GPU process is disabled, as the
control view path still exists.

Fix by adopting AppKit SPI to specify the presentation state of `NSCell`s that
are not backed by control views.

This regression was previously missed as the regression test responsible for the
behavior was broken until 278267@main.

* 
LayoutTests/fast/forms/select/mac-wk2/inactive-appearance-expected-mismatch.html:
* LayoutTests/fast/forms/select/mac-wk2/inactive-appearance.html:

Adjust the test to use `testRunner.setWindowIsKey` rather than
`internals.setPageIsFocusedAndActive`. The latter results in flakiness, as
an activity state update can come after the override, but before taking the
snapshot, invalidating the test result.

Also, use `runSingly` to ensure window key-state is reset, to avoid flakiness.

* LayoutTests/platform/mac-wk2/TestExpectations:

Mark the test as passing.

* Source/WebCore/PAL/pal/spi/mac/NSCellSPI.h:
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::applyViewlessCellSettings):

Use `-[NSCell _setFallbackBezelPresentationState:]` to set an appropriate 
presentation
state, matching the window's active state. Note that only the 
`NSPresentationStateActiveKey`
and `NSPresentationStateInactive` are used, matching the control view path.

Canonical link: https://commits.webkit.org/279420@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d06b72: [Win] Enable HAVE_INT128_T

[Fujii Hironori]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d06b72cc3780ef6093f2f98d307ee8d6ee43fd58
  
https://github.com/WebKit/WebKit/commit/d06b72cc3780ef6093f2f98d307ee8d6ee43fd58
  Author: Fujii Hironori 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WTF/wtf/Int128.h
M Source/cmake/OptionsMSVC.cmake

  Log Message:
  ---
  [Win] Enable HAVE_INT128_T
https://bugs.webkit.org/show_bug.cgi?id=274765

Reviewed by Alex Christensen and Yusuke Suzuki.

Clang-cl has a bug that it generates incorrectly-aligned movaps
instructions. 

We have to specify 'aligned(16)' attribute and use 'typedef' instead
of 'using' for int128 types.

* Source/WTF/wtf/Int128.h:
* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/279419@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e7a7b: Cherry-pick 272448.917@safari-7618-branch (1e58c93...

[David Degazio]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e7a7b504ca22598698b11f3be3257e8042c0b1d
  
https://github.com/WebKit/WebKit/commit/2e7a7b504ca22598698b11f3be3257e8042c0b1d
  Author: David Degazio 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A JSTests/wasm/stress/inlinee-may-have-exception-handlers.js
A JSTests/wasm/stress/rethrow-should-set-callsite-index.js
A JSTests/wasm/stress/throw-should-set-callsite-index.js
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
M Source/JavaScriptCore/wasm/WasmB3IRGenerator.h
M Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h
M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp
M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp

  Log Message:
  ---
  Cherry-pick 272448.917@safari-7618-branch (1e58c9386ed9). 
https://bugs.webkit.org/show_bug.cgi?id=272106

[JSC] Inlined functions in OMG may have exception handlers
https://bugs.webkit.org/show_bug.cgi?id=272106
rdar://125181187

Reviewed by Justin Michaud and Yusuke Suzuki.

Primarily fixes a bug where any WebAssembly function inlined in OMG was
assumed to not have exception handlers. We now propagate a reference to
the Wasm::CalleeGroup from the OMGPlan/OSREntryPlan to the B3IRGenerator,
and read the hasExceptionHandlers() property from the inlined function's
callee, similar to how the top-level function's generator is initialized
in the plan.

In addition to this, we also change when we set the callsite index.
Currently we don't set the callsite index for any call or throw outside
of a try block, which means that we might throw with an old callsite
index set, and erroneously catch the exception in a previous block. To
fix this, we now set a bool in the IR generator after a try or catch block
ends, and set the callsite index for the first call/throw after a try/catch
ends.

Finally, consistent with BBQ, we don't write invalid callsite indices
except for during the function prologue (before our first call/throw). We
also don't write the callsite index at all in the case that we are known
to be in a function without exception handlers.

* JSTests/wasm/stress/inlinee-may-have-exception-handlers.js: Added.
(async test):
* JSTests/wasm/stress/rethrow-should-set-callsite-index.js: Added.
(async test):
* JSTests/wasm/stress/throw-should-set-callsite-index.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::shouldSetCallSiteIndexAfterTry const):
(JSC::Wasm::B3IRGenerator::didSetCallSiteIndexAfterTry):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::preparePatchpointForExceptions):
(JSC::Wasm::B3IRGenerator::addThrow):
(JSC::Wasm::B3IRGenerator::addRethrow):
(JSC::Wasm::B3IRGenerator::addEndToUnreachable):
(JSC::Wasm::B3IRGenerator::emitInlineDirectCall):
(JSC::Wasm::parseAndCompileB3):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:
* Source/JavaScriptCore/wasm/WasmIRGeneratorHelpers.h:
(JSC::Wasm::PatchpointExceptionHandle::PatchpointExceptionHandle):
(JSC::Wasm::PatchpointExceptionHandle::generate const):
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
(JSC::Wasm::OSREntryPlan::work):

Canonical link: https://commits.webkit.org/272448.917@safari-7618-branch

Canonical link: https://commits.webkit.org/274313.285@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 190ac0: Gardening: Support custom annotations for Accessib...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 190ac0f18d5db17c038cb3f4d6197e7735426e25
  
https://github.com/WebKit/WebKit/commit/190ac0f18d5db17c038cb3f4d6197e7735426e25
  Author: Ben Schwartz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/platform/mac-ventura-wk2/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: Support custom annotations for Accessibility in composition 
contexts.
https://bugs.webkit.org/show_bug.cgi?id=257867
rdar://110488738

Unreviewed test gardening.

Modifying existing test expectations to match current expected results.

* LayoutTests/platform/mac-ventura-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279418@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 827066: [WebDriver] Add confirmation of socket connection ...

[Haruhisa SHIN]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 827066c642dd0139614ce43da695a13630da596f
  
https://github.com/WebKit/WebKit/commit/827066c642dd0139614ce43da695a13630da596f
  Author: Haruhisa SHIN 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebDriver/SessionHost.cpp

  Log Message:
  ---
  [WebDriver] Add confirmation of socket connection before sending commands to 
the backend
https://bugs.webkit.org/show_bug.cgi?id=274509

Reviewed by Carlos Garcia Campos.

The SessionHost of WebDriver is trying to send a command to backend
without checking whether the socket is connected or not.
If the socket is disconnected, the completionHandler will remain added
to the queue and will not be called by anyone, and the process will not
be completed.
To solve this problem, add code to check the status of the socket
before sending the command.

* Source/WebDriver/SessionHost.cpp:
(WebDriver::SessionHost::sendCommandToBackend):

Canonical link: https://commits.webkit.org/279417@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c66309: Xcode is not able to attach to WebContent Developm...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c663098fb4c10a2d32d9879df7fdec7606ed3edd
  
https://github.com/WebKit/WebKit/commit/c663098fb4c10a2d32d9879df7fdec7606ed3edd
  Author: Per Arne Vollan 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/Scripts/process-entitlements.sh
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

  Log Message:
  ---
  Xcode is not able to attach to WebContent Development variant
https://bugs.webkit.org/show_bug.cgi?id=274676
rdar://128695932

Reviewed by Chris Dumez.

Restricted entitlement should not be added to WebContent Development variant. 
Xcode will not be
able to attach to the Development version if there are restricted entitlements 
added to it.

* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):

Canonical link: https://commits.webkit.org/279416@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1560bc: [WebGPU] Auto layout incorrectly allows mismatched...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1560bc9c8d3f033453f813e557a9dffe16d4946c
  
https://github.com/WebKit/WebKit/commit/1560bc9c8d3f033453f813e557a9dffe16d4946c
  Author: Mike Wyrzykowski 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/webgpu/regression/repro_274713-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274713.html
A LayoutTests/fast/webgpu/regression/repro_274713b-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274713b.html
M Source/WebGPU/WebGPU/BindGroupLayout.h
M Source/WebGPU/WebGPU/BindGroupLayout.mm
M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  ---
  [WebGPU] Auto layout incorrectly allows mismatched bindings
https://bugs.webkit.org/show_bug.cgi?id=274713


Reviewed by Tadeu Zagallo.

Validate that mismatched bindings between fragment and vertex programs results
in a validation error.

* LayoutTests/fast/webgpu/regression/repro_274713-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274713.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274713b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274713b.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::BindGroupLayout::equalBindingEntries):
(WebGPU::equalEntries):
(WebGPU::equalBindingEntries): Deleted.
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::makeBindingLayout):
(WebGPU::toBindingLayout):
(WebGPU::Device::addPipelineLayouts):

Canonical link: https://commits.webkit.org/279415@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6aea55: [IFC][Out-of-flow] Block level out-of-flow boxes m...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6aea550742b522782eb3ac5cecf6fca0f5a1dcfc
  
https://github.com/WebKit/WebKit/commit/6aea550742b522782eb3ac5cecf6fca0f5a1dcfc
  Author: Alan Baradlay 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  ---
  [IFC][Out-of-flow] Block level out-of-flow boxes may use simplified layout 
even with text-align/indent set on root
https://bugs.webkit.org/show_bug.cgi?id=274784

Reviewed by Antti Koivisto.

Only inline level out-of-flow boxes are affected by text-align/indent value.
 e.g.
  


  
only the first  gets center aligned.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::hasSimpleStaticPositionForInlineLevelOutOfFlowChildrenByStyle):
(WebCore::RenderBlockFlow::layoutModernLines):
(WebCore::hasSimpleStaticPositionForOutOfFlowChildren): Deleted.

Canonical link: https://commits.webkit.org/279414@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87a891: [run-webkit-tests] Handle failed simulator install...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87a89115afe584101f433a84caf977b7a20bed1c
  
https://github.com/WebKit/WebKit/commit/87a89115afe584101f433a84caf977b7a20bed1c
  Author: Jonathan Bedard 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  ---
  [run-webkit-tests] Handle failed simulator install due to high load
https://bugs.webkit.org/show_bug.cgi?id=274808
rdar://128896147

Reviewed by Elliott Williams.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.install_app): Exit code 18 can be caused by high load when 
booting
simulators and may be re-tryable.

Canonical link: https://commits.webkit.org/279413@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9a775: [Site Isolation] Add a test for window.length on a...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9a7758190f779d1ab23fee09243e74ccf0b05ef
  
https://github.com/WebKit/WebKit/commit/c9a7758190f779d1ab23fee09243e74ccf0b05ef
  Author: Charlie Wolfe 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/http/tests/site-isolation/opened-window-length-expected.txt
A LayoutTests/http/tests/site-isolation/opened-window-length.html
A 
LayoutTests/http/tests/site-isolation/resources/post-message-to-opener-on-iframes-load.html

  Log Message:
  ---
  [Site Isolation] Add a test for window.length on an opened window
https://bugs.webkit.org/show_bug.cgi?id=274806
rdar://128903816

Reviewed by Sihui Liu.

This already works, but there is no test.

* LayoutTests/http/tests/site-isolation/opened-window-length-expected.txt: 
Added.
* LayoutTests/http/tests/site-isolation/opened-window-length.html: Added.
* 
LayoutTests/http/tests/site-isolation/resources/post-message-to-opener-on-iframes-load.html:
 Added.

Canonical link: https://commits.webkit.org/279412@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e451a3: [CSS] Fix link invalidation when color depends on ...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e451a390febd89df0938e9b125ebff43adbf100b
  
https://github.com/WebKit/WebKit/commit/e451a390febd89df0938e9b125ebff43adbf100b
  Author: Matthieu Dubet 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/css/link-style-color-invalidation-expected.html
A LayoutTests/fast/css/link-style-color-invalidation.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  ---
  [CSS] Fix link invalidation when color depends on the visited style
https://bugs.webkit.org/show_bug.cgi?id=61697
rdar://97529381

Reviewed by Simon Fraser.

This patch fixes the comparison for the "color" property,
by comparing the used value used for rendering
(taking into account the duality color/visitedLinkColor).

We should ideally do that for each color property
(backgroundColor/visitedLinkBackgroundColor...etc) in a followup patch.

Also, this doesn't change the current algorithm which requires repaint
whenever the color value changes without looking at its actual usage
in other properties (like what is done in the SVGRenderStyle diff).

* LayoutTests/fast/css/link-style-color-invalidation-expected.html: Added.
* LayoutTests/fast/css/link-style-color-invalidation.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::currentColorWithVisitedDiffers):
(WebCore::RenderStyle::changeRequiresRepaint const):
(WebCore::RenderStyle::changeRequiresRepaintIfText const):

Canonical link: https://commits.webkit.org/279411@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5dec07: [JSC] Do not use disallowStubs

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5dec07a85f6eb5306f53796598fa8bf9da84aa4c
  
https://github.com/WebKit/WebKit/commit/5dec07a85f6eb5306f53796598fa8bf9da84aa4c
  Author: Yusuke Suzuki 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp

  Log Message:
  ---
  [JSC] Do not use disallowStubs
https://bugs.webkit.org/show_bug.cgi?id=148914
rdar://128886060

Reviewed by Keith Miller.

Previously out Call IC stub for repatching is doing a jump to the stub and jump 
back to the caller. This means, when calling a function from polymorphic call 
stub,
there is no return address pointing at the caller of this stub. As a result, we 
may collect Getter / Setter IC code, and it destroys holding polymorphic call 
stub code too.
But now, all call IC stubs are invoked through call operations. This means the 
return address is pointing at caller's address, so JITStubRoutine's GC scanning 
just works.
We do not need to disable stubs anymore.

* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::generateImpl):
(JSC::InlineCacheCompiler::emitProxyObjectAccess):

Canonical link: https://commits.webkit.org/279410@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d72323: REGRESSION (iPadOS 17.5): Audio distortion occurs ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d72323075072a471f67c1d17890c475999735f67
  
https://github.com/WebKit/WebKit/commit/d72323075072a471f67c1d17890c475999735f67
  Author: Jean-Yves Avenard 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/platform/audio/SharedAudioDestination.cpp

  Log Message:
  ---
  REGRESSION (iPadOS 17.5): Audio distortion occurs when using AudioContext 
with a sample rate of 44100Hz and an AudioWorklet
https://bugs.webkit.org/show_bug.cgi?id=274507
rdar://128551401

Reviewed by Jer Noble.

Wait until render has completed on worklet thread before processing the next 
one.

* Source/WebCore/platform/audio/SharedAudioDestination.cpp:
(WebCore::SharedAudioDestination::sharedRender):

Canonical link: https://commits.webkit.org/279409@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb30fd: Crash with ruby and continuations

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb30fdac92be85496b875235c1372a152134ac22
  
https://github.com/WebKit/WebKit/commit/bb30fdac92be85496b875235c1372a152134ac22
  Author: Robert Jenner 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/ruby/ruby-continuation-crash-expected.txt
A LayoutTests/fast/ruby/ruby-continuation-crash.html
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp

  Log Message:
  ---
  Crash with ruby and continuations
https://bugs.webkit.org/show_bug.cgi?id=271167
rdar://124432235

Reviewed by Ryosuke Niwa.

* LayoutTests/fast/ruby/ruby-continuation-crash-expected.txt: Added.
* LayoutTests/fast/ruby/ruby-continuation-crash.html: Added.
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::destroyAndCleanUpAnonymousWrappers):

Improve robustness by using WeakPtr for destroyRoot and null checking before 
calling destroy(*destroyRoot)
as it might get deleted by an earlier destroy() call.

Originally-landed-as: 272448.763@safari-7618-branch (df9629adcf83). 
rdar://128549808
Canonical link: https://commits.webkit.org/279408@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e93bb5: Cherry-pick 279185@main (aa28356f83b8). https://bu...

[Yijia Huang]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: e93bb5b3910212e7e93c6ea1a74d48ac5bc1fb31
  
https://github.com/WebKit/WebKit/commit/e93bb5b3910212e7e93c6ea1a74d48ac5bc1fb31
  Author: Georges Basile Stavracas Neto 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp
M Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp

  Log Message:
  ---
  Cherry-pick 279185@main (aa28356f83b8). 
https://bugs.webkit.org/show_bug.cgi?id=274578

[GTK] Build failures in TestWebKitAPI for WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=274578

Unreviewed build fix.

Add explicit return types to the lambdas, which makes Clang happy
enough to finish the build.

* Tools/TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:

Canonical link: https://commits.webkit.org/279185@main

Canonical link: https://commits.webkit.org/274313.266@webkitglib/2.44


  Commit: 40ddaf4044d23d8a708ffb11a5d5049e0fb94022
  
https://github.com/WebKit/WebKit/commit/40ddaf4044d23d8a708ffb11a5d5049e0fb94022
  Author: Alexey Shvayka 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/CustomGetterSetter.h

  Log Message:
  ---
  Cherry-pick 272448.523@safari-7618-branch (66d8614c41ca). 
https://bugs.webkit.org/show_bug.cgi?id=268897

[JSC] Harden CustomGetterSetter by adding MethodTable overrides that always 
crash
https://bugs.webkit.org/show_bug.cgi?id=268897


Reviewed by Mark Lam.

Just like GetterSetter, CustomGetterSetter is never purposely exposed to 
userland code.
However, to make exploitation of accidentally exposed CustomGetterSetter 
objects difficult, this
patch implements MethodTable overrides that abort the program when reached, 
similar to GetterSetter.

* Source/JavaScriptCore/runtime/CustomGetterSetter.h:
(JSC::CustomGetterSetter::getOwnPropertySlot):
(JSC::CustomGetterSetter::put):
(JSC::CustomGetterSetter::putByIndex):
(JSC::CustomGetterSetter::setPrototype):
(JSC::CustomGetterSetter::defineOwnProperty):
(JSC::CustomGetterSetter::deleteProperty):

Canonical link: https://commits.webkit.org/272448.523@safari-7618-branch

Canonical link: https://commits.webkit.org/274313.267@webkitglib/2.44


  Commit: 5e5cde0c683fd8e3c901b633d446cc432ecc63f3
  
https://github.com/WebKit/WebKit/commit/5e5cde0c683fd8e3c901b633d446cc432ecc63f3
  Author: Said Abou-Hallawa 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/css3/filters/filter-visited-links-expected.html
M LayoutTests/css3/filters/filter-visited-links.html
M Source/WebCore/rendering/InlineBoxPainter.cpp

  Log Message:
  ---
  Cherry-pick 272448.560@safari-7618-branch (36df2fc04fb9). 
https://bugs.webkit.org/show_bug.cgi?id=262337

Prevent SVG filters from leaking the background of visited hyperlinks
https://bugs.webkit.org/show_bug.cgi?id=262337
rdar://116206368

Reviewed by Simon Fraser.

We should prevent websites from learning which sites have been visited via 
SVG
filters on hyperlinks, per the attack described in 
https://arxiv.org/abs/2305.12784.

This is a follow up for 266683@main. The background color of the visited 
links
should be ignored when an SVG filter is applied.

* LayoutTests/css3/filters/filter-visited-links-expected.html:
* LayoutTests/css3/filters/filter-visited-links.html:
* Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintDecorations):

Canonical link: https://commits.webkit.org/272448.560@safari-7618-branch

Canonical link: https://commits.webkit.org/274313.268@webkitglib/2.44


  Commit: e5b99737a050e85bb92878e04bad9ed2a49b5b74
  
https://github.com/WebKit/WebKit/commit/e5b99737a050e85bb92878e04bad9ed2a49b5b74
  Author: Scott Marcy 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/svg/mutual-recursion-test-expected.txt
A LayoutTests/fast/svg/mutual-recursion-test.html
M Source/WebCore/rendering/svg/SVGResources.cpp
M Source/WebCore/rendering/svg/SVGResources.h

  Log Message:
  ---
  Cherry-pick 272448.561@safari-7618-branch (e14592228595). 
https://bugs.webkit.org/show_bug.cgi?id=268556

Break a mutual recursion cycle laying out SVG elements.
https://bugs.webkit.org/show_bug.cgi?id=268556
rdar://118510445

Reviewed by shallawa (Said Abou-Hallawa).

Breaks the recursion cycle by having the SVGResource object track if it is 
already doing layout for a different root.

* LayoutTests/fast/svg/mutual-recursion-test-expected.txt: Added.
* LayoutTests/fast/svg/mutual-recursion-test.html: Added.
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::layoutDifferentRootIfNeeded):
* Source/WebCor

[webkit-changes] [WebKit/WebKit] c922e7: REGRESSION(279321@main): js/dom/missing-exception-...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c922e71a44e37dcafcac43e2b537ace3f9134ad3
  
https://github.com/WebKit/WebKit/commit/c922e71a44e37dcafcac43e2b537ace3f9134ad3
  Author: Jay Stfleur 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac/TestExpectations

  Log Message:
  ---
  REGRESSION(279321@main): 
js/dom/missing-exception-check-in-convertVariadicArguments.html is crashing : 
Unchecked exception detected at JSC::VM::verifyExceptionCheckNeedIsSatisfied : 
ASSERTION FAILED: !m_needExceptionCheck
https://bugs.webkit.org/show_bug.cgi?id=274732
rdar://128901317

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/279407@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c13e5f: Update URL to retrieve build archives list

[Ling Ho]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c13e5f0094fa9b3b1660aa8a711fd34bd955fcec
  
https://github.com/WebKit/WebKit/commit/c13e5f0094fa9b3b1660aa8a711fd34bd955fcec
  Author: Ling Ho 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Websites/webkit.org/wp-content/themes/webkit/build-archives.php

  Log Message:
  ---
  Update URL to retrieve build archives list
https://bugs.webkit.org/show_bug.cgi?id=274791


Reviewed by Alexey Proskuryakov.

URL to retrieve the build archives needs to be updated because the backend 
service has been migrated.

* Websites/webkit.org/wp-content/themes/webkit/build-archives.php:

Canonical link: https://commits.webkit.org/279406@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a8256b: [visionOS] Captions are missing in fullscreen mode

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8256bf61cd70cb214e683a81a617354b57b3a42
  
https://github.com/WebKit/WebKit/commit/a8256bf61cd70cb214e683a81a617354b57b3a42
  Author: Jer Noble 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h
M Source/WebCore/platform/cocoa/VideoFullscreenCaptions.mm
M Source/WebCore/platform/cocoa/VideoPresentationModel.h
M Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.h
M Source/WebCore/platform/cocoa/VideoPresentationModelVideoElement.mm
M Source/WebCore/platform/graphics/MediaPlayer.cpp
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
M Source/WebCore/platform/graphics/TextTrackRepresentation.cpp
M Source/WebCore/platform/graphics/TextTrackRepresentation.h
M Source/WebCore/platform/graphics/VideoLayerManager.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm
M Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.h
M Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
M Source/WebCore/platform/mac/VideoPresentationInterfaceMac.mm
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.h
M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.h
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.messages.in
M Source/WebKit/WebProcess/cocoa/VideoPresentationManager.mm

  Log Message:
  ---
  [visionOS] Captions are missing in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=274592
rdar://128502343

Reviewed by Andy Estes.

When enabling the entity-backed rendering path on visionOS, we inadventantly 
broke
caption display in fullscreen. The reasons are multifaceted, but stem from the 
lack
of a WebAVPlayerLayer containing the video content in that path.

Untangling the requirement to have a fullscreen video layer requires changes at 
every
process level:

- Rather than have individual MediaPlayers report whether they need a 
TextTrackRepresentation,
  move responibility for telling HTMLMediaPlayer so up to the UI layer (and 
VideoPlaybackInterface).
- Notify the HTMLMediaElement of TextTrackRepresentation size changes directly, 
rather than
  implicitly via fullscreen video layer size changes.
- Allow the bounds of the TextTrackRepresentation to be set directly, rather 
than implictly
  via the representation's layer.

This removes large swaths of text track responsibilities from 
MediaPlayer/Private, but requires
VideoPresentationInterface subclasess to directly notify the element when they 
need a
representation for text tracks to be created.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::textTrackRepresentation const):
(WebCore::MediaControlsHost::requiresTextTrackRepresentationChanged):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setTextTrackRepresentataionBounds):
(WebCore::HTMLMediaElement::setRequiresTextTrackRepresentation):
(WebCore::HTMLMediaElement::requiresTextTrackRepresentation const):
(WebCore::HTMLMediaElement::setTextTrackRepresentation):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContaine

[webkit-changes] [WebKit/WebKit] 8105a8: [css-counter-styles] RenderListMarker, RenderCount...

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8105a859925ce565fd8953e8234578b8c49ac354
  
https://github.com/WebKit/WebKit/commit/8105a859925ce565fd8953e8234578b8c49ac354
  Author: Vitor Roriz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WTF/wtf/unicode/CharacterNames.h
M Source/WebCore/css/CSSCounterStyle.cpp
M Source/WebCore/css/CSSCounterStyle.h
M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
M Source/WebCore/css/CSSCounterStyleDescriptors.h
M Source/WebCore/css/CSSCounterStyleRule.cpp
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/counterStyles.css
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/rendering/RenderCounter.cpp
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/style/ListStyleType.cpp
M Source/WebCore/rendering/style/ListStyleType.h

  Log Message:
  ---
  [css-counter-styles] RenderListMarker, RenderCounter should use 
CSSCounterStyle::text() to handle TextDirection
https://bugs.webkit.org/show_bug.cgi?id=256153
rdar://109014745

Reviewed by Matthieu Dubet and Tim Nguyen.

Before we can address the bug, we need a small refactoring on how we handle
disclosure-closed counter style:
With this patch, we will handle disclosure-closed as one of the special complex 
systems,
such that we can consider RTL context when calculating its text value.

We fail css/css-counter-styles/counter-style-at-rule/disclosure-styles.html for 
2 different
reasons. Therefore, we need to fix it in 2 different points:

1. RenderListMarker: This class is used for rendering list markers for the 
general case.
It has custom code for hadling TextDirection for counter styles due to 
disclosure-closed
style. We can now delegate this to CSSCounterStyle::text by passing 
TextDirection information.

The custom code currently checks if the counter-style has a "disclosure-closed" 
identifier but
that won't work for "extends" systems. When an author extends a counter-style, 
it can give any
identifier name to it, but it should still act as the counter-style it is 
extending.  Since this
is now handled by CSSCounterStyle itself, we no longer need the custom code.

2. RenderCounter: The class is used when rendering counters with the counter() 
function. These
counters can also be a list-style-type that is mapped to an existent 
counter-style. Currently we
don't handle TextDirection here, which breaks disclosure-closed style for the 
RTL case. Also here
we can delegate TextDirection processing by passing the element's direction to 
CSSCounterStyle::text().

* LayoutTests/TestExpectations:
* Source/WTF/wtf/unicode/CharacterNames.h:
* Source/WebCore/css/CSSCounterStyle.cpp:
(WebCore::CSSCounterStyle::counterForSystemDisclosureClosed):
(WebCore::CSSCounterStyle::initialRepresentation const):
(WebCore::CSSCounterStyle::fallbackText):
(WebCore::CSSCounterStyle::text):
(WebCore::CSSCounterStyle::isInRange const):
* Source/WebCore/css/CSSCounterStyle.h:
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
(WebCore::CSSCounterStyleDescriptors::areSymbolsValidForSystem):
(WebCore::CSSCounterStyleDescriptors::systemCSSText const):
* Source/WebCore/css/CSSCounterStyleDescriptors.h:
* Source/WebCore/css/CSSCounterStyleRule.cpp:
(WebCore::toCounterStyleSystemEnum):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/counterStyles.css:
(@counter-style disclosure-closed):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeCounterStyleSystem):
* Source/WebCore/rendering/RenderCounter.cpp:
(WebCore::RenderCounter::originalText const):
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::textRun const):
(WebCore::RenderListMarker::updateContent):
* Source/WebCore/rendering/style/ListStyleType.cpp:
(WebCore::ListStyleType::isDisclosureClosed const): Deleted.
* Source/WebCore/rendering/style/ListStyleType.h:

Canonical link: https://commits.webkit.org/279404@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5dceca: [WebGPU] Bind groups skip validation in some cases

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5dceca812aa0bab38c7a52a10b6368e10f162c7d
  
https://github.com/WebKit/WebKit/commit/5dceca812aa0bab38c7a52a10b6368e10f162c7d
  Author: Mike Wyrzykowski 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/webgpu/regression/repro_274706-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706.html
A LayoutTests/fast/webgpu/regression/repro_274706b-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706b.html
A LayoutTests/fast/webgpu/regression/repro_274706c-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274706c.html
M Source/WebGPU/WebGPU/Pipeline.mm
M Source/WebGPU/WebGPU/PipelineLayout.h
M Source/WebGPU/WebGPU/PipelineLayout.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.h
M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  ---
  [WebGPU] Bind groups skip validation in some cases
https://bugs.webkit.org/show_bug.cgi?id=274706


Reviewed by Tadeu Zagallo.

Bind group validation was being skipped by the number of vertex buffers
a pipeline used.

RenderPipeline::vertexStageInBufferCount() was not needed at all since
the validation is handled by RenderPipeline::requiredBufferIndices().

* LayoutTests/fast/webgpu/regression/repro_274706-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274706b-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706b.html: Added.
* LayoutTests/fast/webgpu/regression/repro_274706c-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274706c.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/PipelineLayout.h:
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::errorValidatingBindGroupCompatibility const):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
* Source/WebGPU/WebGPU/RenderPipeline.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::RenderPipeline::vertexStageInBufferCount const): Deleted.

Canonical link: https://commits.webkit.org/279403@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e6c9b: Add a `UUID` specialization to `ObjectIdentifier`

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e6c9b9adb42cc075ecbe93cdf5a34c8c8762b72
  
https://github.com/WebKit/WebKit/commit/3e6c9b9adb42cc075ecbe93cdf5a34c8c8762b72
  Author: Richard Robinson 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WTF/wtf/CrossThreadCopier.h
M Source/WTF/wtf/Forward.h
M Source/WTF/wtf/ObjectIdentifier.cpp
M Source/WTF/wtf/ObjectIdentifier.h
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/MessageSender.h
M Source/WebKit/Platform/IPC/MessageSenderInlines.h
M Source/WebKit/Platform/IPC/StreamClientConnection.h
M Source/WebKit/Platform/IPC/StreamServerConnection.h
M Source/WebKit/Shared/AuxiliaryProcess.h
M Source/WebKit/Shared/WTFArgumentCoders.serialization.in
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/Extensions/WebExtensionController.h
M Source/WebKit/UIProcess/RemotePageProxy.h
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h

  Log Message:
  ---
  Add a `UUID` specialization to `ObjectIdentifier`
https://bugs.webkit.org/show_bug.cgi?id=274738
rdar://128772989

Reviewed by Chris Dumez.

Allow `UUID`-backed `ObjectIdentifier`s to be created.

* Source/WTF/wtf/CrossThreadCopier.h:
* Source/WTF/wtf/Forward.h:
* Source/WTF/wtf/ObjectIdentifier.cpp:
(WTF::ObjectIdentifierMainThreadAccessTraits::generateIdentifierInternal):
(WTF::ObjectIdentifierThreadSafeAccessTraits::generateIdentifierInternal):
(WTF::operator<<):
(WTF::ObjectIdentifierMainThreadAccessTraits::generateIdentifierInternal):
(WTF::ObjectIdentifierThreadSafeAccessTraits::generateIdentifierInternal):
(WTF::ObjectIdentifierMainThreadAccessTraits::generateIdentifierInternal): 
Deleted.
(WTF::ObjectIdentifierThreadSafeAccessTraits::generateIdentifierInternal): 
Deleted.
* Source/WTF/wtf/ObjectIdentifier.h:
(WTF::ObjectIdentifierGenericBase::toUInt64 const):
(WTF::ObjectIdentifierGenericBase::toRawValue const):
(WTF::ObjectIdentifierGenericBase::isValidIdentifier):
(WTF::ObjectIdentifierGenericBase::ObjectIdentifierGenericBase):
(WTF::ObjectIdentifierGenericBase::hashTableDeletedValue):
(WTF::ObjectIdentifierGenericBase::isHashTableDeletedValue const):
(WTF::ObjectIdentifierGenericBase::isValid const):
(WTF::ObjectIdentifierGenericBase::toRawValue const):
(WTF::ObjectIdentifierGenericBase::operator bool const):
(WTF::ObjectIdentifierGenericBase::loggingString const):
(WTF::ObjectIdentifierGenericBase::isValidIdentifier):
(WTF::ObjectIdentifierGenericBase::ObjectIdentifierGenericBase):
(WTF::ObjectIdentifierGenericBase::hashTableDeletedValue):
(WTF::ObjectIdentifierGeneric::ObjectIdentifierGeneric):
(WTF::add):
(WTF::ObjectIdentifierGenericBaseHash::hash):
(WTF::ObjectIdentifierGenericBaseHash::equal):
(WTF::ObjectIdentifierGenericBaseHash::hash):
(WTF::ObjectIdentifierGenericBaseHash::equal):
(WTF::operator==):
(WTF::operator>):
(WTF::operator>=):
(WTF::operator<):
(WTF::operator<=):
(WTF::ObjectIdentifierGenericBase::isHashTableDeletedValue const): Deleted.
(WTF::ObjectIdentifierGenericBase::isValid const): Deleted.
(WTF::ObjectIdentifierGenericBase::toUInt64 const): Deleted.
(WTF::ObjectIdentifierGenericBase::operator bool const): Deleted.
(WTF::ObjectIdentifierGenericBase::loggingString const): Deleted.
(WTF::ObjectIdentifierGenericBase::isValidIdentifier): Deleted.
(WTF::ObjectIdentifierGenericBase::ObjectIdentifierGenericBase): Deleted.
(WTF::ObjectIdentifierGenericBase::hashTableDeletedValue): Deleted.
(WTF::ObjectIdentifierGenericBaseHash::hash): Deleted.
(WTF::ObjectIdentifierGenericBaseHash::equal): Deleted.
(WTF::ObjectIdentifierGenericBaseStringTypeAdapter::length const): Deleted.
(WTF::ObjectIdentifierGenericBaseStringTypeAdapter::is8Bit const): Deleted.
(WTF::ObjectIdentifierGenericBaseStringTypeAdapter::writeTo const): Deleted.
(WTF::ObjectIdentifierGenericBaseStringTypeAdapter::ObjectIdentifierGenericBaseStringTypeAdapter):
 Deleted.
* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::escapeIDForJSON):
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::sendWithAsyncReply):
(IPC::Connection::sendWithPromisedReply):
(IPC::Connection::sendWithPromisedReplyOnDispatcher):
(IPC::Connection::send):
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):
* Source/WebKit/Platform/IPC/MessageSender.h:
* Source/WebKit/Platform/IPC/MessageSenderInlines.h:
(IPC::MessageSender::send):
(IPC::MessageSender::sendSync):
(IPC::MessageSender::sendWithAsyncReply):
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::send):
(IPC::StreamClientConnection::sendWithAsyncReply):
(IPC::StreamClientConnection::sendSync):
(IPC::StreamClientConnection::waitForAndDispatchImmediat

[webkit-changes] [WebKit/WebKit] 9b9256: [WebGPU] CommandsMixin::computedSizeOverflows does...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b92567e1389cae708ba091fe3df496b9a471627
  
https://github.com/WebKit/WebKit/commit/9b92567e1389cae708ba091fe3df496b9a471627
  Author: Mike Wyrzykowski 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebGPU/WebGPU/CommandsMixin.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm

  Log Message:
  ---
  [WebGPU] CommandsMixin::computedSizeOverflows does not correctly handle 
overflow
https://bugs.webkit.org/show_bug.cgi?id=274782


Reviewed by Tadeu Zagallo.

Handle overflow in case a value greater than 2^53 - 1 is passed to these
functions.

Attempted to write a test but since 2^53 - 1 is the max value for Number
in JavaScript, this issue is only reproducible when sending messages directly
from the IPC layer.

* Source/WebGPU/WebGPU/CommandsMixin.mm:
(WebGPU::CommandsMixin::computedSizeOverflows):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::setIndexBuffer):
(WebGPU::RenderBundleEncoder::setVertexBuffer):

Canonical link: https://commits.webkit.org/279401@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b48458: [resolve-ChangeLogs] Remove

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b484588f8fdfddb692273b47721d0851a1bbe5a3
  
https://github.com/WebKit/WebKit/commit/b484588f8fdfddb692273b47721d0851a1bbe5a3
  Author: Jonathan Bedard 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/Scripts/resolve-ChangeLogs

  Log Message:
  ---
  [resolve-ChangeLogs] Remove
https://bugs.webkit.org/show_bug.cgi?id=274155
rdar://128067276

Reviewed by Ryan Haddad.

* Tools/Scripts/resolve-ChangeLogs: Replace with stub.

Canonical link: https://commits.webkit.org/279400@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 29d113: [WGSL] shader, execution, expression, unary, address_o...

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29d113f326172fe15e5e79df5f4e600c52b418c9
  
https://github.com/WebKit/WebKit/commit/29d113f326172fe15e5e79df5f4e600c52b418c9
  Author: Tadeu Zagallo 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/address_of_and_indirection-expected.txt
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  ---
  [WGSL] shader,execution,expression,unary,address_of_and_indirection:* is 
failing
https://bugs.webkit.org/show_bug.cgi?id=274754
rdar://128792671

Reviewed by Mike Wyrzykowski.

There were two issues:
- we weren't setting CallExpression::m_isConstructor for calls to struct and 
array
  constructors.
- we were not handling the case for index access on pointers in the code 
generator.
  i.e. `x[i]` needs to emit `(*x)[i]` when `x` is a pointer.

* 
LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/unary/address_of_and_indirection-expected.txt:
 Added.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/279399@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9752ce: Support using Ref for IDLInterfaces in IDL records

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9752ce405aad243af0d5ddcef0c04cf303fd82f2
  
https://github.com/WebKit/WebKit/commit/9752ce405aad243af0d5ddcef0c04cf303fd82f2
  Author: Sam Weinig 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp
M Source/WebCore/Modules/async-clipboard/ClipboardItem.h
M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp
M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h
M Source/WebCore/bindings/IDLTypes.h
M Source/WebCore/bindings/js/JSDOMConvertRecord.h
M Source/WebCore/testing/TypeConversions.h

  Log Message:
  ---
  Support using Ref for IDLInterfaces in IDL records
https://bugs.webkit.org/show_bug.cgi?id=274757

Reviewed by Darin Adler.

Continues effort to improve non-null hygiene by correctly mapping
WebIDL record values with non-optional IDL interface members to Ref
rather than RefPtr. For instance, the IDL record:

   record

previously would have mapped to:

   Vector>>

and now maps to:

   Vector>>

* Source/WebCore/bindings/IDLTypes.h:
- Switch to using InnerParameterType for the key/value types rather
  than ImplementationType. This has no effect on the key, as strings
  have the same ImplementationType and InnerParameterType, but is done
  for consistency.

* Source/WebCore/Modules/async-clipboard/ClipboardItem.cpp:
(WebCore::ClipboardItem::ClipboardItem):
(WebCore::ClipboardItem::create):
* Source/WebCore/Modules/async-clipboard/ClipboardItem.h:
* Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
(WebCore::ClipboardItemBindingsDataSource::ClipboardItemBindingsDataSource):
(WebCore::ClipboardItemBindingsDataSource::types const):
(WebCore::ClipboardItemBindingsDataSource::getType):
(WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):
* Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.h:
* Source/WebCore/testing/TypeConversions.h:
(WebCore::TypeConversions::testNodeRecord const):
(WebCore::TypeConversions::setTestNodeRecord):
- Updates RefPtrs to Refs.

Canonical link: https://commits.webkit.org/279398@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bdb542: Gardening: [macOS wk1] compositing/repaint/iframes...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bdb542d7b7adad253fdebc22ebd7d797cf6ea92b
  
https://github.com/WebKit/WebKit/commit/bdb542d7b7adad253fdebc22ebd7d797cf6ea92b
  Author: Ben Schwartz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  Gardening: [macOS wk1] 
compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html
 is flakily failing.
https://bugs.webkit.org/show_bug.cgi?id=274792
rdar://128884891

Unreviewed test gardening.

Adding test expectation for flakily failing test.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/279397@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0cbfcb: fast/images/decode-render-animated-image.html is f...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0cbfcb62088bde6605bd69df7e94bc2e53d00eb9
  
https://github.com/WebKit/WebKit/commit/0cbfcb62088bde6605bd69df7e94bc2e53d00eb9
  Author: Said Abou-Hallawa 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  fast/images/decode-render-animated-image.html is flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=271408
rdar://125573776

Unreviewed test gardening

The test has been passing since 279153@main. Remove it from the test 
expectations.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/279396@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d8aaf: Drop NetworkCache::Data::data() in favor of span()

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d8aaf204b714840ed87ce50cce54109a41e94da
  
https://github.com/WebKit/WebKit/commit/9d8aaf204b714840ed87ce50cce54109a41e94da
  Author: Chris Dumez 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WTF/wtf/FileSystem.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheData.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp
M Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp

  Log Message:
  ---
  Drop NetworkCache::Data::data() in favor of span()
https://bugs.webkit.org/show_bug.cgi?id=274760

Reviewed by Darin Adler.

* Source/WTF/wtf/FileSystem.h:
(WTF::FileSystemImpl::MappedFileData::data const):
* Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::bytesEqual):
* Source/WebKit/NetworkProcess/cache/NetworkCacheData.h:
(WebKit::NetworkCache::Data::size const):
(WebKit::NetworkCache::Data::span const): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::span const):
(WebKit::NetworkCache::Data::data const): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:
(WebKit::NetworkCache::Data::span const):
(WebKit::NetworkCache::Data::data const): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp:
(WebKit::NetworkCache::Data::data const):
* Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::getContentRuleListSourceFromMappedFile):

Canonical link: https://commits.webkit.org/279395@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5592e5: RE-BASELINE: REGRESSION(267516@main): imported/w3c...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5592e5d6a57299ce8f6a181d986144823eee65e6
  
https://github.com/WebKit/WebKit/commit/5592e5d6a57299ce8f6a181d986144823eee65e6
  Author: Ben Schwartz 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt

  Log Message:
  ---
  RE-BASELINE: REGRESSION(267516@main): 
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
 is constantly failing.
https://bugs.webkit.org/show_bug.cgi?id=267871
rdar://121387671

Unreviewed test re-baseline.

This test was errantly re-baselined as part of 267516@main.

* 
LayoutTests/platform/mac/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:

Canonical link: https://commits.webkit.org/279394@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d3dc83: Drop ArrayBuffer constructors taking in a raw poin...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d3dc83426c85179bcfac48a7b40cf93e50c402e1
  
https://github.com/WebKit/WebKit/commit/d3dc83426c85179bcfac48a7b40cf93e50c402e1
  Author: Chris Dumez 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/ArrayBuffer.cpp
M Source/JavaScriptCore/runtime/ArrayBuffer.h
M Source/JavaScriptCore/runtime/JSArrayBufferView.cpp
M Source/JavaScriptCore/runtime/JSArrayBufferView.h
M Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp
M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
M Source/WebCore/Modules/fetch/FetchBody.cpp
M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp
M Source/WebCore/Modules/mediastream/RTCEncodedFrame.cpp
M 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp
M Source/WebCore/Modules/push-api/PushSubscription.cpp
M Source/WebCore/Modules/push-api/PushSubscriptionOptions.cpp
M Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp
M Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp
M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp
M Source/WebCore/Modules/webcodecs/WebCodecsVideoEncoder.cpp
M Source/WebCore/Modules/websockets/WebSocket.cpp
M Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp
M Source/WebCore/bindings/js/BufferSource.h
M Source/WebCore/bindings/js/IDBBindingUtilities.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
M Source/WebCore/bindings/js/StructuredClone.cpp
M Source/WebCore/platform/SharedBuffer.cpp
M 
Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp
M 
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm
M Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm
M Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm
M Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
M 
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
M Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp

  Log Message:
  ---
  Drop ArrayBuffer constructors taking in a raw pointer, in favor of std::span
https://bugs.webkit.org/show_bug.cgi?id=274698

Reviewed by Darin Adler and Yusuke Suzuki.

This is to promote adoption of std::span throughout the code base.

* Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::create):
(JSC::ArrayBuffer::createAdopted):
(JSC::ArrayBuffer::tryCreate):
(JSC::ArrayBuffer::sliceWithClampedIndex const):
* Source/JavaScriptCore/runtime/ArrayBuffer.h:
* Source/JavaScriptCore/runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::slowDownAndWasteMemory):
* Source/JavaScriptCore/runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::span const):
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::makeArrayBuffer):
* Source/WebCore/Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consumeAsStream):
* Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::consumeFormDataAsStream):
* Source/WebCore/Modules/mediastream/RTCEncodedFrame.cpp:
(WebCore::RTCEncodedFrame::data const):
* 
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp:
(WebCore::LibWebRTCDtlsTransportBackendObserver::updateState):
* Source/WebCore/Modules/push-api/PushSubscription.cpp:
(WebCore::PushSubscription::getKey const):
* Source/WebCore/Modules/push-api/PushSubscriptionOptions.cpp:
(WebCore::PushSubscriptionOptions::applicationServerKey const):
* Source/WebCore/Modules/webauthn/AuthenticatorAssertionResponse.cpp:
(WebCore::AuthenticatorAssertionResponse::create):
(WebCore::AuthenticatorAssertionResponse::setAuthenticatorData):
* Source/WebCore/Modules/webauthn/AuthenticatorAttestationResponse.cpp:
(WebCore::AuthenticatorAttestationResponse::create):
(WebCore::AuthenticatorAttestationResponse::getAuthenticatorData const):
(WebCore::AuthenticatorAttestationResponse::getPublicKey const):
* Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp:
(WebCore::buildClientDataJson):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp:
(WebCore::WebCodecsAudioDecoder::isConfigSupported):
* Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:
(WebCore::WebCodecsAudioEncoder::configure):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder

[webkit-changes] [WebKit/WebKit] 966bb6: Enforce bounds checking in FixedVector

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 966bb6ff4463ee03a265c34655184a179d20889c
  
https://github.com/WebKit/WebKit/commit/966bb6ff4463ee03a265c34655184a179d20889c
  Author: Chris Dumez 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WTF/wtf/FixedVector.h

  Log Message:
  ---
  Enforce bounds checking in FixedVector
https://bugs.webkit.org/show_bug.cgi?id=274783

Reviewed by Darin Adler.

Enforce bounds checking in FixedVector for safety. This tested as
performance neutral on the benchmarks we track.

* Source/WTF/wtf/FixedVector.h:
(WTF::FixedVector::at):
(WTF::FixedVector::at const):
(WTF::FixedVector::operator[]):
(WTF::FixedVector::operator[] const):

Canonical link: https://commits.webkit.org/279392@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a38ef7: [JSC] Simplify Repatch Call IC

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a38ef78e135b3a164a8361109797d5fc0fb7a9b5
  
https://github.com/WebKit/WebKit/commit/a38ef78e135b3a164a8361109797d5fc0fb7a9b5
  Author: Yusuke Suzuki 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp
M Source/JavaScriptCore/bytecode/CallLinkInfo.h
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/Repatch.cpp
M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp
M Source/JavaScriptCore/dfg/DFGJITCompiler.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
M Source/JavaScriptCore/jit/JITCall.cpp
M Source/JavaScriptCore/jit/JITThunks.h
M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp
M Source/JavaScriptCore/jit/ThunkGenerators.cpp
M Source/JavaScriptCore/jit/ThunkGenerators.h
M Source/JavaScriptCore/wasm/js/WasmToJS.cpp

  Log Message:
  ---
  [JSC] Simplify Repatch Call IC
https://bugs.webkit.org/show_bug.cgi?id=274360
rdar://128339225

Reviewed by Keith Miller.

This patch changes slow path implementation from generated special code to Data 
Call IC's one.

* Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::clearCallee):
(JSC::CallLinkInfo::revertCallToStub):
(JSC::CallLinkInfo::reset):
(JSC::CallLinkInfo::setVirtualCall):
(JSC::CallLinkInfo::emitFastPathImpl):
(JSC::CallLinkInfo::emitDataICFastPath):
(JSC::CallLinkInfo::emitTailCallDataICFastPath):
(JSC::CallLinkInfo::setStub):
(JSC::CallLinkInfo::emitFastPath):
(JSC::CallLinkInfo::emitTailCallFastPath):
(JSC::OptimizingCallLinkInfo::emitFastPath):
(JSC::OptimizingCallLinkInfo::emitTailCallFastPath):
(JSC::OptimizingCallLinkInfo::initializeFromDFGUnlinkedCallLinkInfo):
(JSC::CallLinkInfo::doneLocationIfExists): Deleted.
(JSC::OptimizingCallLinkInfo::setSlowPathCallDestination): Deleted.
(JSC::CallLinkInfo::emitSlowPathImpl): Deleted.
(JSC::CallLinkInfo::emitDataICSlowPath): Deleted.
(JSC::CallLinkInfo::emitSlowPath): Deleted.
(JSC::CallLinkInfo::emitTailCallSlowPath): Deleted.
(JSC::OptimizingCallLinkInfo::emitSlowPath): Deleted.
(JSC::OptimizingCallLinkInfo::emitTailCallSlowPath): Deleted.
* Source/JavaScriptCore/bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::codeOrigin const):
(JSC::UnlinkedCallLinkInfo::setDoneLocation): Deleted.
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::InlineCacheCompiler::generateImpl):
(JSC::InlineCacheCompiler::emitProxyObjectAccess):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::linkSlowFor):
(JSC::linkPolymorphicCall):
* Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* Source/JavaScriptCore/dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addJSCall): Deleted.
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord): Deleted.
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* Source/JavaScriptCore/jit/JITCall.cpp:
(JSC::JIT::compileTailCall):
(JSC::JIT::compileOpCall):
* Source/JavaScriptCore/jit/JITThunks.h:
* Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp:
(JSC::PolymorphicCallNode::unlinkOrUpgradeImpl):
* Source/JavaScriptCore/jit/ThunkGenerators.cpp:
(JSC::polymorphicRepatchThunk): Deleted.
* Source/JavaScriptCore/jit/ThunkGenerators.h:
* Source/JavaScriptCore/wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):

Canonical link: https://commits.webkit.org/279391@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 825c23: [WebGPU] Integer overflow in RenderBundleEncoder::...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 825c235203559922b2b51bb8fd75758878b26f6b
  
https://github.com/WebKit/WebKit/commit/825c235203559922b2b51bb8fd75758878b26f6b
  Author: Mike Wyrzykowski 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A LayoutTests/fast/webgpu/regression/repro_274703-expected.txt
A LayoutTests/fast/webgpu/regression/repro_274703.html
M Source/WebGPU/WebGPU/Buffer.h
M Source/WebGPU/WebGPU/Buffer.mm
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  ---
  [WebGPU] Integer overflow in RenderBundleEncoder::runIndexBufferValidation
https://bugs.webkit.org/show_bug.cgi?id=274703


Reviewed by Tadeu Zagallo.

Use checked arithmetic to avoid overflow and out of bounds reads.

* LayoutTests/fast/webgpu/regression/repro_274703-expected.txt: Added.
* LayoutTests/fast/webgpu/regression/repro_274703.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::maxIndex const): Deleted.
This was not being used, the values are computed using a shader now.

* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::runIndexBufferValidation):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::runIndexBufferValidation):

Canonical link: https://commits.webkit.org/279390@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ade27f: Try to fix the visionOS build

[aestes]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ade27f1d72267d4fdc08599f0179817e40223e15
  
https://github.com/WebKit/WebKit/commit/ade27f1d72267d4fdc08599f0179817e40223e15
  Author: Andy Estes 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerManagerProxyCocoa.mm

  Log Message:
  ---
  Try to fix the visionOS build
https://bugs.webkit.org/show_bug.cgi?id=274787
rdar://128876348

Unreviewed build fix after 279382@main.

* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerManagerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerManagerProxy::handleVideoReceiverEndpointMessage):

Canonical link: https://commits.webkit.org/279389@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 33808d: Versioning.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33808df7d0b1b590b321d6c6321386652f029cda
  
https://github.com/WebKit/WebKit/commit/33808df7d0b1b590b321d6c6321386652f029cda
  Author: Dan Robson 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Configurations/Version.xcconfig

  Log Message:
  ---
  Versioning.

WebKit-7619.1.17

Canonical link: https://commits.webkit.org/279388@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efa4d4: [Unified Text Replacement] Swap characters view sh...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efa4d47c0a234c2083a4402500db717be94bbaa5
  
https://github.com/WebKit/WebKit/commit/efa4d47c0a234c2083a4402500db717be94bbaa5
  Author: Richard Robinson 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  ---
  [Unified Text Replacement] Swap characters view should be shown even when 
there is no selection
https://bugs.webkit.org/show_bug.cgi?id=274734
rdar://128712983

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):

Canonical link: https://commits.webkit.org/279387@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d646a: Fix site isolation overlay crash during teardown

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d646a441196993aecaf93b3af2ae2ab7eb87bd5
  
https://github.com/WebKit/WebKit/commit/4d646a441196993aecaf93b3af2ae2ab7eb87bd5
  Author: Pascoe 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/page/DebugPageOverlays.cpp

  Log Message:
  ---
  Fix site isolation overlay crash during teardown
https://bugs.webkit.org/show_bug.cgi?id=274612
rdar://128636304

Reviewed by Charlie Wolfe.

The debug overlays are stored in a WeakHashMap from page to a vector of the 
overlays.
However, when site isolation is on, whenever a value is being removed from the 
WeakHashMap
because the page has been destrucuted, the overlay will try to access a WeakRef 
to the page,
which crashes. To fix this, we make the page in a RegionOverlay stored as 
WeakPtr instead and
check it before accessing it.

* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::MouseWheelRegionOverlay::updateRegion):
(WebCore::NonFastScrollableRegionOverlay::updateRegion):
(WebCore::InteractionRegionOverlay::activeLayer const):
(WebCore::InteractionRegionOverlay::activeRegion const):
(WebCore::InteractionRegionOverlay::mouseEvent):
(WebCore::SiteIsolationOverlay::drawRect):
(WebCore::RegionOverlay::~RegionOverlay):
(WebCore::RegionOverlay::protectedPage const): Deleted.

Canonical link: https://commits.webkit.org/279386@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c07620: Sync `html/syntax/speculative-parsing/generated` f...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c076205ec69bcffbc6f47108e6f5826d765bcae0
  
https://github.com/WebKit/WebKit/commit/c076205ec69bcffbc6f47108e6f5826d765bcae0
  Author: Ahmad Saleem 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/nested-template-shadowrootmode-1.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/nested-template-shadowrootmode-1.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/nested-template-shadowrootmode-2.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/nested-template-shadowrootmode-2.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/nested-template-shadowrootmode-2.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-img-src.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-img-src.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-img-src.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-link-stylesheet.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-link-stylesheet.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-img-src.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-img-src.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-link-stylesheet.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-link-stylesheet.tentative.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-script-src.tentative.sub-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/template-shadowrootmode-script-src.tentative.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/nested-template-shadowrootmode-1.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/nested-template-shadowrootmode-1.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/nested-template-shadowrootmode-2.tentative-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/nested-template-shadowrootmode-2.tentative.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/nested-template-shadowrootmode-1-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/nested-template-shadowrootmode-2-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/template-img-src-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/template-link-stylesheet-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/template-shadowrootmode-img-src-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/template-shadowrootmode-link-stylesheet-framed.sub.html
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/template-shadowrootmode-script-src-framed.sub.html
M 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/resources/w3c-import.log
A 
LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/template-img-src.tentative-expected.txt
 

[webkit-changes] [WebKit/WebKit] 2e51cc: Add script to filter layout tests to minimize buil...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e51cc753a270436ea8154ac0f74d69f9cff9059
  
https://github.com/WebKit/WebKit/commit/2e51cc753a270436ea8154ac0f74d69f9cff9059
  Author: Brianna Fan 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
A Tools/Scripts/filter-test-logs

  Log Message:
  ---
  Add script to filter layout tests to minimize buildbot logging
https://bugs.webkit.org/show_bug.cgi?id=274673
rdar://128694401

Reviewed by Aakash Jain.

Condenses all existing log-filtering scripts into one and adds a method for 
layout tests.
The filter ensures that any logs being parsed by the buildmaster for results 
are still printed.

* Tools/Scripts/filter-test-logs: Added.
(parser):
(filter_jsc_test):
(filter_layout_tests):
(filter_scan_build):
(main):

Canonical link: https://commits.webkit.org/279384@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 326ac9: Fix ARMv7 silent spills

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 326ac9397cf30659d60157e5b18e08ceb682785d
  
https://github.com/WebKit/WebKit/commit/326ac9397cf30659d60157e5b18e08ceb682785d
  Author: Justin Michaud 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/runtime/MapPrototype.cpp

  Log Message:
  ---
  Fix ARMv7 silent spills
https://bugs.webkit.org/show_bug.cgi?id=274770

Reviewed by Keith Miller.

After https://commits.webkit.org/279031@main and
https://commits.webkit.org/279337@main, we saw some
armv7 test failures. These changes match the 64-bit port.

* Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::genericJSValueNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compile):
* Source/JavaScriptCore/runtime/MapPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/279383@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3759cb: [visionOS] REGRESSION(278712@main) CRASH in Remote...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3759cba9ed6c8260f6fdd34c4bb0512e8fb69383
  
https://github.com/WebKit/WebKit/commit/3759cba9ed6c8260f6fdd34c4bb0512e8fb69383
  Author: Jer Noble 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerManagerProxyCocoa.mm

  Log Message:
  ---
  [visionOS] REGRESSION(278712@main) CRASH in 
RemoteMediaPlayerManagerProxy::handleVideoReceiverEndpointMessage
rdar://128258443
https://bugs.webkit.org/show_bug.cgi?id=274674

Reviewed by Andy Estes.

When adding the ability to cache and uncache VideoTarget objects in the GPU 
process, "uncaching" was signalled
by sending an empty identifier for the media player identifier field in 
VideoReceiverEndpointMessage. This causes
an issue when looking up MediaPlayer objects from a HashMap where the media 
player identifier is this empty
value.

Validate the mediaPlayerIdentifier value before using it as the key to the 
m_proxies map.

Drive-by: Also validate the mediaElementIdentifier() before using it.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::mediaPlayer):

Canonical link: https://commits.webkit.org/279382@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7d0e2: [UnifiedPDF] Select element for choice annotations...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7d0e2efd37914f2c13e5a148dc3213386ac3bc6
  
https://github.com/WebKit/WebKit/commit/b7d0e2efd37914f2c13e5a148dc3213386ac3bc6
  Author: Sammy Gill 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/Shared/WebHitTestResultData.serialization.in
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  ---
  [UnifiedPDF] Select element for choice annotations will sometimes flicker
https://bugs.webkit.org/show_bug.cgi?id=274634
rdar://128406464

Reviewed by Abrar Rahman Protyasha.

The choice annotation has a HTML select element backing it for user
interaction. Sometimes clicking on the choice annotation while the
corresponding HTML element is already active will result in the
element disappearing and reappearing resulting in a flicker. It appears
this is due to the logic in WebPageMac::performImmediateActionHitTestAtLocation
taking focus away from the HTML element and giving it to the plugin
document.

To fix this let the plugin note that the the hit test is over an already
active annotation via WebHitTestResultData. If this is the case then
we will not focus the plugin document and keep the focus on the
HTML annotation.

* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/Shared/WebHitTestResultData.serialization.in:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::textForImmediateActionHitTestAtPoint):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):

Canonical link: https://commits.webkit.org/279381@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 866927: The stack-overflow-in-syntax-checker.js JSC stress...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 866927170c083846d494376c653608dfd5d29360
  
https://github.com/WebKit/WebKit/commit/866927170c083846d494376c653608dfd5d29360
  Author: Mark Lam 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M JSTests/stress/stack-overflow-in-syntax-checker.js
M Source/JavaScriptCore/jsc.cpp

  Log Message:
  ---
  The stack-overflow-in-syntax-checker.js JSC stress test is flaky.
https://bugs.webkit.org/show_bug.cgi?id=274749
rdar://128786930

Reviewed by Justin Michaud.

We observed that the stack-overflow-in-syntax-checker.js test is flaky.  After 
a lot of
investigation, the issue turns out to be a test issue:

1. The test starts a worker thread using $262.agent.start.
2. The worker thread will always fail to parse its script: the script will 
cause the parser
   to recurse too deeply, thereby resulting in a StackOverflowError.
3. Since the StackOverflowError occurs during parsing, adding a try-catch block 
around the
   worker payload script (in 279015@main) does not help because the error 
occurs before the
   script even gets to execute.
4. If the worker thread throws the StackOverflowError, and propagate it all the 
way out,
   resulting in an uncaught exception before the main thread terminates, this 
will result
   in the process exiting with EXIT_FAILURE.  The test fails.
5. On the other hand, if the main thread finishes first before the worker 
thread can exit
   with EXIT_FAILURE, then the test passes.

The test is flaky because its result is dependent on whether the main thread or 
the worker
thread wins the race.

The purpose of this test is to ensure that the stack overflow in the parser 
does not result
in a crash.  Hence, whether we get an uncaught exception or not is irrelevant 
and should not
fail the test.

The fix is to add a new `--ignoreUncaughtExceptions` option to the jsc shell, 
and require
that option for this test.

* JSTests/stress/stack-overflow-in-syntax-checker.js:
(try.262.agent.start.262.agent.receiveBroadcast):
(try.262.agent.start.try.262.agent.receiveBroadcast): Deleted.
(try.catch): Deleted.
* Source/JavaScriptCore/jsc.cpp:
(checkException):
(printUsageStatement):
(CommandLine::parseArguments):
(CommandLine::CommandLine):

Canonical link: https://commits.webkit.org/279380@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f409e9: REGRESSION(279376@main) [WPE] Build broken without...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f409e9ff48c8321c7e7de16ac3d46f8eed2a8292
  
https://github.com/WebKit/WebKit/commit/f409e9ff48c8321c7e7de16ac3d46f8eed2a8292
  Author: Lauro Moura 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp

  Log Message:
  ---
  REGRESSION(279376@main) [WPE] Build broken without WPE_PLATFORM guard
https://bugs.webkit.org/show_bug.cgi?id=274776

Unreviewed build fix.

Use the right API call.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
(WebKit::WebAutomationSession::platformSimulateKeySequence):

Canonical link: https://commits.webkit.org/279379@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 695612: [wpe][cross-toolchain-helper][browserperfdash] Add...

[Carlos Alberto Lopez Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69561296f9ee6854de4c9fc7a401800a9fbf24c3
  
https://github.com/WebKit/WebKit/commit/69561296f9ee6854de4c9fc7a401800a9fbf24c3
  Author: Carlos Alberto Lopez Perez 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
A 
Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch
R 
Tools/yocto/meta-openembedded_backport-libbacktrace-patch-to-mickledore-branch.patch
M Tools/yocto/rpi/local-rpi3-32bits-mesa.conf
M Tools/yocto/rpi/local-rpi3-32bits-userland.conf
M Tools/yocto/rpi/local-rpi3-64bits-mesa.conf
M Tools/yocto/rpi/local-rpi4-32bits-mesa.conf
M Tools/yocto/rpi/local-rpi4-64bits-mesa.conf
M Tools/yocto/targets.conf

  Log Message:
  ---
  [wpe][cross-toolchain-helper][browserperfdash] Add netdata into the 
cross-toolchain-helper images for the RPi boards and send local timestamps on 
browserperfdash
https://bugs.webkit.org/show_bug.cgi?id=274771

Reviewed by Nikolas Zimmermann.

We are experimenting with a new concept for showing performance data
from the perf bots that relies on netdata to profile the whole
system metrics.

So to support this add netdata into the images for the RPi boards
(this is generally useful as it can be used to check performance
metrics on the boards).

Also send timestamps of when a perf test starts and ends on the
perf bot, that will be used later to match with the data from
netdata.

* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(BrowserPerfDashRunner.__init__):
(BrowserPerfDashRunner.run):
* 
Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch:
 Added.
* 
Tools/yocto/meta-openembedded_backport-libbacktrace-patch-to-mickledore-branch.patch:
 Removed.
* Tools/yocto/rpi/local-rpi3-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi3-32bits-userland.conf:
* Tools/yocto/rpi/local-rpi3-64bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-32bits-mesa.conf:
* Tools/yocto/rpi/local-rpi4-64bits-mesa.conf:
* Tools/yocto/targets.conf:

Canonical link: https://commits.webkit.org/279378@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 932717: [Invalidation] Teardown root should take care of m...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 93271739610fe9de4d1ad373c645ac298c792966
  
https://github.com/WebKit/WebKit/commit/93271739610fe9de4d1ad373c645ac298c792966
  Author: Alan Baradlay 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.h

  Log Message:
  ---
  [Invalidation] Teardown root should take care of marking ancestors dirty on 
behalf of its subtree
https://bugs.webkit.org/show_bug.cgi?id=274658

Reviewed by Antti Koivisto.

Instead of calling setNeedsLayoutAndPrefWidthsRecalc on each and every renderer 
at teardown,
let's just dirty the parent of the destroy root and any renderer that skip the 
destroy root
as containing block.

* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererStateOnDetach):
* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::repaintAndMarkContainingBlockDirtyBeforeTearDown):
(WebCore::RenderTreeUpdater::tearDownRenderers):
(WebCore::repaintBeforeTearDown): Deleted.

Canonical link: https://commits.webkit.org/279377@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4a97b2: [WPE][WebDriver] Implement automation keyboard and...

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a97b2ece9b549de56c9e960f11009ecc00967da
  
https://github.com/WebKit/WebKit/commit/4a97b2ece9b549de56c9e960f11009ecc00967da
  Author: Lauro Moura 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/SourcesWPE.txt
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp
A Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.h
A Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp
M Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
M Source/WebKit/UIProcess/Automation/win/WebAutomationSessionWin.cpp
M Source/WebKit/WPEPlatform/wpe/WPEKeymapXKB.cpp

  Log Message:
  ---
  [WPE][WebDriver] Implement automation keyboard and mouse input handlers for 
new WPE API
https://bugs.webkit.org/show_bug.cgi?id=273750

Reviewed by Carlos Garcia Campos.

Using new WPEEvent class when we're under the new WPE API.

This commit also moves the WPE-related WebAutomationSession platformSimulate* 
methods
implementation to the new API file, calling the older libwpe-based API in the 
`LibWPE.cpp`
file if required.

* Source/WebKit/SourcesWPE.txt: Add new file
* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:
* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.h: Added
* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
* Source/WebKit/WPEPlatform/wpe/WPEKeymapXKB.cpp: Fix typo

Canonical link: https://commits.webkit.org/279376@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Carlos Garcia Campos]

  Branch: refs/tags/webkitgtk-2.45.3
  Home:   https://github.com/WebKit/WebKit

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 821caf: Unreviewed. Update OptionsGTK.cmake and NEWS for 2...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 821caf922ecfff7b8ea52f31501469d54fa27b54
  
https://github.com/WebKit/WebKit/commit/821caf922ecfff7b8ea52f31501469d54fa27b54
  Author: Carlos Garcia Campos 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebKit/gtk/NEWS
M Source/cmake/OptionsGTK.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsGTK.cmake and NEWS for 2.45.3 release

* Source/WebKit/gtk/NEWS: Add release notes for 2.45.3.
* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Canonical link: https://commits.webkit.org/279375@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 309cc5: Add forward declarations and supplement missing he...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 309cc59bd2d54605fc8b370b723110edfa9d7796
  
https://github.com/WebKit/WebKit/commit/309cc59bd2d54605fc8b370b723110edfa9d7796
  Author: weidongliu 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/jit/JITStubRoutine.h
M Source/JavaScriptCore/runtime/ExceptionScope.cpp

  Log Message:
  ---
  Add forward declarations and supplement missing header files.
https://bugs.webkit.org/show_bug.cgi?id=274755

Reviewed by Justin Michaud.

* Source/JavaScriptCore/jit/JITStubRoutine.h:
* Source/JavaScriptCore/runtime/ExceptionScope.cpp:

Canonical link: https://commits.webkit.org/279374@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 025a8d: [GTK][WPE] Enable offscreen canvas by default

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 025a8d8de935c29deb0d9acee28dbfa442b055be
  
https://github.com/WebKit/WebKit/commit/025a8d8de935c29deb0d9acee28dbfa442b055be
  Author: Carlos Garcia Campos 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
R LayoutTests/platform/gtk/inspector/canvas/context-attributes-expected.txt
R LayoutTests/platform/gtk/inspector/canvas/requestClientNodes-expected.txt
R LayoutTests/platform/gtk/inspector/canvas/requestContent-2d-expected.txt
R LayoutTests/platform/gtk/inspector/canvas/resolveContext-2d-expected.txt
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  ---
  [GTK][WPE] Enable offscreen canvas by default
https://bugs.webkit.org/show_bug.cgi?id=274753

Reviewed by Miguel Gomez.

* LayoutTests/platform/gtk/inspector/canvas/context-attributes-expected.txt: 
Removed.
* LayoutTests/platform/gtk/inspector/canvas/requestClientNodes-expected.txt: 
Removed.
* LayoutTests/platform/gtk/inspector/canvas/requestContent-2d-expected.txt: 
Removed.
* LayoutTests/platform/gtk/inspector/canvas/resolveContext-2d-expected.txt: 
Removed.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/279373@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2058ec: [view-transitions] Captured root element with marg...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2058eceb3fd5f84b7d394aa7281110088f9f62e1
  
https://github.com/WebKit/WebKit/commit/2058eceb3fd5f84b7d394aa7281110088f9f62e1
  Author: Matt Woodrow 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/dom/ViewTransition.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h

  Log Message:
  ---
  [view-transitions] Captured root element with margins display snapshots in 
incorrect position.
https://bugs.webkit.org/show_bug.cgi?id=274397


Reviewed by Tim Nguyen.

If the root element is captured in the view transition, then we effectively do 
snapshotting
of the RenderView instead.

Computing the element-to-screen transform should be skipped, since it would 
include any
margin on the root element relative the view.

Most of the code in RenderLayerBacking that prepares a captured layer for 
attachment
into the pseduo element tree also needs to operate on the RenderView's layer in 
this case,
so a new 'effectiveCapturedInViewTransition' added to make this simpler.

* LayoutTests/TestExpectations:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::copyElementBaseProperties):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
(WebCore::RenderLayerBacking::shouldClipCompositedBounds const):
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::effectiveCapturedInViewTransition const):
* Source/WebCore/rendering/RenderObject.h:

Canonical link: https://commits.webkit.org/279372@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f22da2: REGRESSION(279341@main): Minibrowser crashes if sc...

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f22da2434a23d81d5f3001579a20a945e3ce2f0f
  
https://github.com/WebKit/WebKit/commit/f22da2434a23d81d5f3001579a20a945e3ce2f0f
  Author: Diego Pino Garcia 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Tools/MiniBrowser/gtk/main.c

  Log Message:
  ---
  REGRESSION(279341@main): Minibrowser crashes if schema doesn't contain 
'color-scheme'
https://bugs.webkit.org/show_bug.cgi?id=274767

Reviewed by Carlos Garcia Campos.

Check whether schema contains 'color-scheme' before attempting to
retrieve its value.

* Tools/MiniBrowser/gtk/main.c:
(setupDarkMode):

Canonical link: https://commits.webkit.org/279371@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5282ec: VideoDecoderConfigSize should be `unsigned long` r...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5282ec7af05ea5dbb3338bafea9ea9953c97cacc
  
https://github.com/WebKit/WebKit/commit/5282ec7af05ea5dbb3338bafea9ea9953c97cacc
  Author: Ahmad Saleem 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoderConfig.idl

  Log Message:
  ---
  VideoDecoderConfigSize should be `unsigned long` rather than `unsigned long 
long`

https://bugs.webkit.org/show_bug.cgi?id=274012
rdar://problem/128291404

Reviewed by Youenn Fablet.

This patch aligns with web-specification [1]:

[1] https://w3c.github.io/webcodecs/#video-decoder-config

Which uses 'unsigned long' instead of current 'unsigned long long' for
codedWidth, codedHeight, displayAspectWidth and displayAspectHeight.

* Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoderConfig.idl:

Canonical link: https://commits.webkit.org/279370@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e522f1: [JSC] Remove wasm entrypoint thunk generation

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e522f11064930938fafd62938d82d37709757d36
  
https://github.com/WebKit/WebKit/commit/e522f11064930938fafd62938d82d37709757d36
  Author: Yusuke Suzuki 
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
M Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmIPIntPlan.h
M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
M Source/JavaScriptCore/wasm/WasmLLIntPlan.h
M Source/JavaScriptCore/wasm/WasmModule.cpp
M Source/JavaScriptCore/wasm/WasmModule.h

  Log Message:
  ---
  [JSC] Remove wasm entrypoint thunk generation
https://bugs.webkit.org/show_bug.cgi?id=274764
rdar://128826832

Reviewed by Justin Michaud.

Because caller stores callee to a specific stack slot, we do not need to 
generate LLInt/IPInt entrypoint thunk anymore.
This patch wipes it. And we move LLIntCallee / IPIntCallee generation from the 
last part of LLIntPlan / IPIntPlan to each function compilation.
We also move entrypoint thunk generation from the last phase to the each 
function compilation.

* Source/JavaScriptCore/wasm/WasmIPIntPlan.cpp:
(JSC::Wasm::IPIntPlan::prepareImpl):
(JSC::Wasm::IPIntPlan::compileFunction):
(JSC::Wasm::IPIntPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmIPIntPlan.h:
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::prepareImpl):
(JSC::Wasm::LLIntPlan::compileFunction):
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.h:
* Source/JavaScriptCore/wasm/WasmModule.cpp:
(JSC::Wasm::Module::Module):
* Source/JavaScriptCore/wasm/WasmModule.h:

Canonical link: https://commits.webkit.org/279369@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes