[webkit-changes] [WebKit/WebKit] 75f056: Unreviewed revert "[WebGPU] A12x devices and earli...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75f0563655c21deccfb63c1b6d6572620ca9b0bb
  
https://github.com/WebKit/WebKit/commit/75f0563655c21deccfb63c1b6d6572620ca9b0bb
  Author: Mike Wyrzykowski 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/TestExpectations
R LayoutTests/fast/webgpu/fuzz-274334-expected.txt
R LayoutTests/fast/webgpu/fuzz-274334.html
M Source/WebGPU/WebGPU/HardwareCapabilities.mm

  Log Message:
  ---
  Unreviewed revert "[WebGPU] A12x devices and earlier allowed for creation of 
more samplers than supported by the HW"

This reverts commit a19c25f387d25390c062e22d4b56e32a275ef274.

Unreviewed revert of rdar://128065020 ([WebGPU] A12x devices and earlier 
allowed for creation of more samplers than supported by the HW (274334))
as this broke all iOS device with feature level < Apple6.

Canonical link: https://commits.webkit.org/279564@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fbdfff: Put 'd' property support behind a feature flag

[Cameron McCormack]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fbdfff8e6dbaa200426e5cedfb3899818cffec40
  
https://github.com/WebKit/WebKit/commit/fbdfff8e6dbaa200426e5cedfb3899818cffec40
  Author: Cameron McCormack 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/css/CSSProperties.json

  Log Message:
  ---
  Put 'd' property support behind a feature flag
https://bugs.webkit.org/show_bug.cgi?id=274935
rdar://129028514

Reviewed by Matthieu Dubet.

The feature is not yet complete, but we are currently parsing the
property. Move it behind a disabled feature flag for now.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/279563@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 071943: [macOS] Safari flashes a page background colored b...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 071943e457d9e93f456b8a8ee24a016e0143cb1c
  
https://github.com/WebKit/WebKit/commit/071943e457d9e93f456b8a8ee24a016e0143cb1c
  Author: Abrar Rahman Protyasha 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderLayerCompositor.h

  Log Message:
  ---
  [macOS] Safari flashes a page background colored bar with top content inset 
dimensions in footer when window resizing
https://bugs.webkit.org/show_bug.cgi?id=274831
rdar://128940179

Reviewed by Simon Fraser.

Previously, on a FrameView resize, RenderLayerCompositor was sizing its
overhang area layer incorrectly since it did not account for the top
content offset. This is incorrect because the layer itself was
positioned vertically at the top content offset, so with the inflated
size, we always had a page background colored bar hanging at the bottom
of the frame, which was easily perceptible when snap resizing a Safari
window, for example.

This patch fixes said issue by introducing a reusable utility method
RenderLayerCompositor::updateSizeAndPositionForOverhangAreaLayer() that
is used both during layer creation and any later updates (such as when a
frame view's size changes). We make sure to size the layer (and
position it) correctly in this method, accounting for the top content
offset.

* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateSizeAndPositionForOverhangAreaLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
* Source/WebCore/rendering/RenderLayerCompositor.h:

Canonical link: https://commits.webkit.org/279562@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7e5e04: [Site Isolation] Remove child frames of old main f...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e5e04b40d3eae60d9cd0176061cf2a5ba92511d
  
https://github.com/WebKit/WebKit/commit/7e5e04b40d3eae60d9cd0176061cf2a5ba92511d
  Author: Alex Christensen 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebFrameProxy.cpp
M Source/WebKit/UIProcess/WebFrameProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  [Site Isolation] Remove child frames of old main frame when committing a 
provisional page
https://bugs.webkit.org/show_bug.cgi?id=274941
rdar://125374765

Reviewed by Charlie Wolfe.

When a main frame navigates to a new domain, we need the iframes of the 
previous page to be
removed in the UI process and in all other processes.  This isn't an issue with 
site isolation
off because we cache or discard the entirety of the previous process when 
process swapping.
With site isolation, though, the same processes can be reused for the same 
domains after
main frame navigations.

* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::removeRemoteFrameProcessUse):
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::commitProvisionalPage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, NavigateToDomainAgainWithSPIUse)):

Canonical link: https://commits.webkit.org/279561@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] af2b37: [UnifiedPDF] Hide the selection layer when there i...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af2b37e3e31f37e7295b93568c24aac51fe1bf46
  
https://github.com/WebKit/WebKit/commit/af2b37e3e31f37e7295b93568c24aac51fe1bf46
  Author: Simon Fraser 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Hide the selection layer when there is no selection
https://bugs.webkit.org/show_bug.cgi?id=274939
rdar://128971102

Reviewed by Abrar Rahman Protyasha.

If the current selection is empty, we can unparent the selection layer to avoid
having to repaint it on resize. When there is a non-empty selection, we reparent
and mark it as being in the window.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::ensureLayers):
(WebKit::UnifiedPDFPlugin::repaintOnSelectionChange):
(WebKit::UnifiedPDFPlugin::showOrHideSelectionLayerAsNecessary):

Canonical link: https://commits.webkit.org/279560@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81447b: [UnifiedPDF] The data detectors page overlay layer...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81447b127263b34c50c5a9093d383d3eff31b6e5
  
https://github.com/WebKit/WebKit/commit/81447b127263b34c50c5a9093d383d3eff31b6e5
  Author: Simon Fraser 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M 
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm

  Log Message:
  ---
  [UnifiedPDF] The data detectors page overlay layer doesn't need backing store
https://bugs.webkit.org/show_bug.cgi?id=274936
rdar://129034911

Reviewed by Abrar Rahman Protyasha.

Each DataDetectorHighlight has its own GraphicsLayer into which it paints. 
Fading is done via
opacity on this layer.

These DD layers are parented in the `OverlayType::Document` page overlay layer, 
which
can be an empty container with no backing store. So don't request that it use a 
tiled layer.

We can also remove calls to -setNeedsRepaint in the overlay layer, simplifying
`didInvalidateHighlightOverlayRects()` somewhat.

* 
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm:
(WebKit::PDFDataDetectorOverlayController::installOverlayIfNeeded):
(WebKit::PDFDataDetectorOverlayController::didInvalidateHighlightOverlayRects):

Canonical link: https://commits.webkit.org/279559@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ada9ed: [visionOS] In Firefox, YouTube videos immediately ...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ada9edd4a1898e2870f3d09f50f1aefd3cbd039c
  
https://github.com/WebKit/WebKit/commit/ada9edd4a1898e2870f3d09f50f1aefd3cbd039c
  Author: Jean-Yves Avenard 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  [visionOS] In Firefox, YouTube videos immediately exit full screen
https://bugs.webkit.org/show_bug.cgi?id=274458
rdar://12214

Reviewed by Jer Noble.

The primary cause for fullscreen to immediately exit was a typo in the use of 
the PLATFORM
macro which caused requestHideAndExitFullscreen() to be immediately called once 
we had entered
fullscreen.
Then we had two issues that were revealed once the primary issue was fixed. 
When running in
iOS compatibility mode, once we entered fullscreen we would either remove the 
player from the
video layer (CRABS) or teardown the video layer (MSE).
To avoid this, we check if a FigVideoTargetRef is set, which indicate that the 
application
isn't running in iOS compatibility mode and a LMK isn't in use.

Manually tested MSE and CRABS, for both app in both native (Safari) and 
compatibility mode (Firefox)

* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedVideoMode const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::isInFullscreenOrPictureInPictureChanged):
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isInFullscreenOrPictureInPictureChanged):
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.mm:
(WebCore::VideoPresentationInterfaceIOS::doSetup):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewDidLeaveWindow): Fix typo and replace with 
PLATFORM(VISION). This caused to immediately
exit fullscreen as soon as we entered fullscreen.

Canonical link: https://commits.webkit.org/279558@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe2a6a: Modifier keys and mouse events sent to backgrounde...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe2a6a572c960334e5bd9af22bf151a91e0ad36e
  
https://github.com/WebKit/WebKit/commit/fe2a6a572c960334e5bd9af22bf151a91e0ad36e
  Author: Richard Robinson 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm

  Log Message:
  ---
  Modifier keys and mouse events sent to backgrounded Safari window
https://bugs.webkit.org/show_bug.cgi?id=274877
rdar://115430109

Reviewed by Simon Fraser.

Currently, the event monitor which dispatches mouse events on modifier key 
presses gets installed when added
to a window, and removed when removed from a window. However, this results in 
the monitor still existing for
backgrounded windows.

Fix by creating a new tracking area and ensuring that the monitor is only 
active while the mouse is within
the tracking area of the window.

* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::secondaryTrackingAreaOptions):
(WebKit::m_flagsChangedEventMonitorTrackingArea):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::mouseEntered):
(WebKit::WebViewImpl::mouseExited):
(WebKit::m_primaryTrackingArea): Deleted.

Canonical link: https://commits.webkit.org/279557@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 634eb5: [JSC] Use precompiled handlers for simple cases fo...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 634eb56589dc475e6b4e1cdf0ccfc91e870b9439
  
https://github.com/WebKit/WebKit/commit/634eb56589dc475e6b4e1cdf0ccfc91e870b9439
  Author: Yusuke Suzuki 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h
M Source/JavaScriptCore/bytecode/AccessCase.cpp
M Source/JavaScriptCore/bytecode/AccessCase.h
M Source/JavaScriptCore/bytecode/InlineAccess.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/bytecode/InstanceOfStatus.cpp
M Source/JavaScriptCore/bytecode/Repatch.cpp
M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp
M Source/JavaScriptCore/bytecode/StructureStubInfo.h
M Source/JavaScriptCore/dfg/DFGJITCode.h
M Source/JavaScriptCore/jit/BaselineJITRegisters.h
M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp
M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h
M Source/JavaScriptCore/jit/JITInlineCacheGenerator.h

  Log Message:
  ---
  [JSC] Use precompiled handlers for simple cases for IC
https://bugs.webkit.org/show_bug.cgi?id=274912
rdar://129016313

Reviewed by Keith Miller.

This patch starts applying precompiled code for common ICs via Handler IC when 
it is only one AccessCase.
Eventually we will make all Handler IC as chain of AccessCases so this 
one-AccessCase-compilation will cover
all Handler IC compilation.

We add InlineCacheCompiler::compileOneAccessCaseHandler, which will handle all 
Handler IC cases eventually.
And based on Handler IC's assumption, compileOneAccessCaseHandler code gets 
much simplified (since there is only one AccessCase),
which allows us to extract necessary information for precompiled IC cleanly.

And then, we apply precompiled ICs for Load, Miss, Transition, and Replace 
cases. We do this only when we meet several conditions: checkingConditions
are empty, no-poly-proto, no viaGlobalProxy. But this effectively covers most 
of cases in fact since these conditions are exceptional cases.

In precompiled IC, we use GPRInfo::handlerGPR to extract per-handler 
information like StructureID, offset etc.

* Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add8):
* Source/JavaScriptCore/bytecode/AccessCase.cpp:
(JSC::AccessCase::create):
(JSC::AccessCase::fromStructureStubInfo):
(JSC::AccessCase::guardedByStructureCheckSkippingConstantIdentifierCheck const):
(JSC::AccessCase::requiresIdentifierNameMatch const):
(JSC::AccessCase::requiresInt32PropertyCheck const):
(JSC::AccessCase::forEachDependentCell const):
(JSC::AccessCase::doesCalls const):
(JSC::AccessCase::canReplace const):
(JSC::AccessCase::runWithDowncast):
(JSC::AccessCase::checkConsistency):
(JSC::AccessCase::canBeShared):
* Source/JavaScriptCore/bytecode/AccessCase.h:
(JSC::AccessCase::structureID const):
(JSC::AccessCase::newStructureID const):
(JSC::AccessCase::conditionSet const):
* Source/JavaScriptCore/bytecode/InlineAccess.cpp:
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::canGenerateSelfPropertyReplace):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::isCacheableArrayLength):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::isCacheableStringLength):
(JSC::InlineAccess::generateStringLength):
(JSC::InlineAccess::generateSelfInAccess):
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp:
(JSC::needsScratchFPR):
(JSC::forInBy):
(JSC::isStateless):
(JSC::doesJSCalls):
(JSC::isMegamorphic):
(JSC::InlineCacheHandler::InlineCacheHandler):
(JSC::InlineCacheHandler::create):
(JSC::InlineCacheHandler::createPreCompiled):
(JSC::InlineCacheCompiler::generateWithGuard):
(JSC::InlineCacheCompiler::generateWithoutGuard):
(JSC::collectConditions):
(JSC::InlineCacheCompiler::generateWithConditionChecks):
(JSC::InlineCacheCompiler::generateAccessCase):
(JSC::InlineCacheCompiler::emitProxyObjectAccess):
(JSC::InlineCacheCompiler::compile):
(JSC::getByIdLoadHandlerCodeGenerator):
(JSC::getByIdMissHandlerCodeGenerator):
(JSC::putByIdReplaceHandlerCodeGenerator):
(JSC::putByIdTransitionHandlerCodeGenerator):
(JSC::InlineCacheCompiler::compileOneAccessCaseHandler):
(JSC::InlineCacheCompiler::generate): Deleted.
(JSC::InlineCacheCompiler::generateImpl): Deleted.
(JSC::InlineCacheCompiler::regenerate): Deleted.
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
* Source/JavaScriptCore/bytecode/InstanceOfStatus.cpp:
(JSC::InstanceOfStatus::computeForStubInfo):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::tryCacheArrayGetByVal):
(JSC::repatchArrayGetByVal):
(JSC::tryCachePutBy):
(JSC::tryCacheArrayPutByVal):
(JSC::repatchArrayPutByVal):
(JSC::tryCacheDeleteBy):
(JSC::tryCacheInBy):
(JSC::tryCacheHasPrivateBrand):
(JSC::tryCacheCheckPrivateBrand):
(JSC::tryCacheSetPrivateBrand):
(JSC::tryCacheInstanceOf):
(JSC::tryCacheArrayInByVal):

[webkit-changes] [WebKit/WebKit] 1a2ff3: [ macOS Release ] TestWebKitAPI.HSTS.Preconnect is...

[Robert Jenner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a2ff32f194dd697a4b90ec23978b67f893bef23
  
https://github.com/WebKit/WebKit/commit/1a2ff32f194dd697a4b90ec23978b67f893bef23
  Author: Robert Jenner 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm

  Log Message:
  ---
  [ macOS Release ] TestWebKitAPI.HSTS.Preconnect is a flaky timeout (255560)
https://bugs.webkit.org/show_bug.cgi?id=255560
rdar://108167361

Reviewed by Ryan Haddad.

Disabling API test on mac due to negative impact on EWS.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
(TestWebKitAPI::TEST(HSTS, DISABLED_Preconnect)):
(TestWebKitAPI::TEST(HSTS, Preconnect)): Deleted.

Canonical link: https://commits.webkit.org/279555@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90aaf2: Enable a couple of feature flags in PlatformHave.h...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90aaf2621d41a0beef16f7f97efe8e8a74b058ed
  
https://github.com/WebKit/WebKit/commit/90aaf2621d41a0beef16f7f97efe8e8a74b058ed
  Author: Wenson Hsieh 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  ---
  Enable a couple of feature flags in PlatformHave.h on tvOS
https://bugs.webkit.org/show_bug.cgi?id=274911

Reviewed by Abrar Rahman Protyasha.

Enable `HAVE_UI_TEXT_SELECTION_DISPLAY_INTERACTION` and remove 
`HAVE_CANCEL_WEB_TOUCH_EVENTS_GESTURE`
entirely, since we no longer depend on SPI for touch events on all iOS family 
ports.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _cancelTouchEventGestureRecognizer]):

Canonical link: https://commits.webkit.org/279554@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a9f0f: [curl] Obtain the Content-Length and request heade...

[Kenji Shukuwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a9f0f239bc433855d47938d4d421b1dbac39f46
  
https://github.com/WebKit/WebKit/commit/8a9f0f239bc433855d47938d4d421b1dbac39f46
  Author: Kenji Shukuwa 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/wincairo/TestExpectations
M Source/WebCore/platform/network/curl/CurlContext.cpp
M Source/WebCore/platform/network/curl/CurlContext.h
M Source/WebCore/platform/network/curl/CurlRequest.cpp
M Source/WebCore/platform/network/curl/CurlRequest.h

  Log Message:
  ---
  [curl] Obtain the Content-Length and request header size ourselves.
https://bugs.webkit.org/show_bug.cgi?id=272445

Reviewed by Fujii Hironori.

Since curl 8.7.0, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T and
CURLINFO_REQUEST_SIZE  are no longer available in the header callback.
For this reason, we will obtain the Content-Length and request header
size ourselves.

* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::addExtraNetworkLoadMetrics):
* Source/WebCore/platform/network/curl/CurlContext.h:
* Source/WebCore/platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveDebugInfo):
(WebCore::CurlRequest::networkLoadMetrics):
(WebCore::CurlRequest::getContentLength):
* Source/WebCore/platform/network/curl/CurlRequest.h:

Canonical link: https://commits.webkit.org/279553@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 183b8f: Fix WTF handling for logging to a file in DataLog.cpp

[Marcus Plutowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 183b8fe2f0c1a1cdd7d766ff2933029a64fb6c81
  
https://github.com/WebKit/WebKit/commit/183b8fe2f0c1a1cdd7d766ff2933029a64fb6c81
  Author: Marcus Plutowski 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WTF/wtf/DataLog.cpp

  Log Message:
  ---
  Fix WTF handling for logging to a file in DataLog.cpp
https://bugs.webkit.org/show_bug.cgi?id=274855
rdar://128959048

Reviewed by Mark Lam.

In addition to the small (char*) -> (const char*) fix, this reorganizes
things so that the two log options are independent (w/o depending on or
overriding one another), the env-var path works for both, and now the
default path should work on Windows.

* Source/WTF/wtf/DataLog.cpp:

Canonical link: https://commits.webkit.org/279552@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8e2703: Update canUseFastRenderer() in WebKitNSStringExtra...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e2703a62c3ac7282b9f96744a53646a89b59c9a
  
https://github.com/WebKit/WebKit/commit/8e2703a62c3ac7282b9f96744a53646a89b59c9a
  Author: Chris Dumez 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm

  Log Message:
  ---
  Update canUseFastRenderer() in WebKitNSStringExtras to use std::span
https://bugs.webkit.org/show_bug.cgi?id=274923

Reviewed by Brent Fulgham.

* Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm:
(canUseFastRenderer):
(-[NSString _web_drawAtPoint:font:textColor:]):
(-[NSString _web_widthWithFont:]):

Canonical link: https://commits.webkit.org/279551@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c9b24: [git-webkit] Handle segment type in undefined posi...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c9b24b1bc21367c11a5f0c268864ab755d17f9f
  
https://github.com/WebKit/WebKit/commit/8c9b24b1bc21367c11a5f0c268864ab755d17f9f
  Author: Jonathan Bedard 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py

  Log Message:
  ---
  [git-webkit] Handle segment type in undefined position
https://bugs.webkit.org/show_bug.cgi?id=274928
rdar://129026771

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
(BitBucket.PRGenerator._position_converters): Use a default dictionary of 
dictionaries
for the `relative_to_absolute` variable, instead of relying on either the source
or destination position to be defined.

Canonical link: https://commits.webkit.org/279550@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e39e0c: WebCore::ScopedInspectorShaderProgramHighlight con...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e39e0c613f32314d1779a80cf520865827c19646
  
https://github.com/WebKit/WebKit/commit/e39e0c613f32314d1779a80cf520865827c19646
  Author: David Kilzer 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/html/canvas/WebGLUtilities.h

  Log Message:
  ---
  WebCore::ScopedInspectorShaderProgramHighlight constructor does not 
initialize struct m_savedBlend



Reviewed by Dan Glastonbury.

* Source/WebCore/html/canvas/WebGLUtilities.h:
(WebCore::ScopedInspectorShaderProgramHighlight::m_savedBlend):
- Add default initializers.

Canonical link: https://commits.webkit.org/279549@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 957ddb: Whitelist more notifyd notifications for WebContent

[bnham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 957ddb2b94a123946d5ef1e6420bcbcceca2f53c
  
https://github.com/WebKit/WebKit/commit/957ddb2b94a123946d5ef1e6420bcbcceca2f53c
  Author: Ben Nham 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M 
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
M Source/WebKit/Scripts/process-entitlements.sh
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Whitelist more notifyd notifications for WebContent
https://bugs.webkit.org/show_bug.cgi?id=274910
rdar://128970749

Reviewed by Per Arne Vollan.

After looking at more data it looks like we are still not forwarding a number 
of notifyd
notifications that WebContent cares about when ENABLE_NOTIFY_BLOCKING is on.

Add in those missing notification names and also refactor the way the list of 
notifications is
handled, since that knowledge is currently distributed across 3 places in the 
codebase:

 - process-entitlements.sh
 - WebProcessPool::registerNotificationObservers()
 - iOS/macOS WebContentsandbox profile

Ideally these lists would come from some centralized file. But for now, I've at 
least reorganized
things so it should be easier to keep these lists in sync.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/279548@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5ea0ef: Add support for Chrome for Testing in run-benchmark

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ea0ef45d1d1f4b13fcb64523c2f4ab62d2e7384
  
https://github.com/WebKit/WebKit/commit/5ea0ef45d1d1f4b13fcb64523c2f4ab62d2e7384
  Author: Yusuke Suzuki 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M 
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py

  Log Message:
  ---
  Add support for Chrome for Testing in run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=274930
rdar://129030745

Reviewed by Stephanie Lewis.

Add Chrome for Testing configuration to run-benchmark

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeForTestingDriver):
(OSXChromeForTestingDriver._set_chrome_binary_location):
(OSXChromeForTestingDriver.launch_args_with_url):

Canonical link: https://commits.webkit.org/279547@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 541190: [MultiRep HEIC] Disable drag and drop without a se...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 541190981bc904c51cf3cb6594d75824a9ea2b7c
  
https://github.com/WebKit/WebKit/commit/541190981bc904c51cf3cb6594d75824a9ea2b7c
  Author: Aditya Keerthi 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/page/DragController.cpp

  Log Message:
  ---
  [MultiRep HEIC] Disable drag and drop without a selection
https://bugs.webkit.org/show_bug.cgi?id=274886
rdar://128900601

Reviewed by Richard Robinson.

Image elements containing a multi-representation HEIC should only be draggable
as part of a selection.

* Source/WebCore/page/DragController.cpp:
(WebCore::imageElementIsDraggable):

Canonical link: https://commits.webkit.org/279546@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 533cd7: [Gardening]: [visionOS wk2 ] pdf/fullscreen.html i...

[martadarbinyan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 533cd773407f72e5e2560b56137e435094ac634b
  
https://github.com/WebKit/WebKit/commit/533cd773407f72e5e2560b56137e435094ac634b
  Author: Marta Darbinyan 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
A LayoutTests/platform/visionos/pdf/fullscreen-expected.txt

  Log Message:
  ---
  [Gardening]: [visionOS wk2 ] pdf/fullscreen.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=274924
rdar://129024750

Unreviewed test gardening.

Updating the rebaseline.

* LayoutTests/platform/visionos/pdf/fullscreen-expected.txt: Added.

Canonical link: https://commits.webkit.org/279545@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d85282: Add fault logging when timing out waiting for LS d...

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d852829c3dd22fff99f9c35a51517a93fe782c3f
  
https://github.com/WebKit/WebKit/commit/d852829c3dd22fff99f9c35a51517a93fe782c3f
  Author: Per Arne Vollan 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm

  Log Message:
  ---
  Add fault logging when timing out waiting for LS database
https://bugs.webkit.org/show_bug.cgi?id=274921
rdar://129023429

Reviewed by Chris Dumez.

Add fault logging when timing out waiting for LS database in the WebContent 
process.
This patch replaces the existing debug assert with a fault log, which will give 
us
more information about how often this happens in all build configurations.

* Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
(WebKit::LaunchServicesDatabaseManager::waitForDatabaseUpdate):

Canonical link: https://commits.webkit.org/279544@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 360f91: NEW TEST (278840@main): [ iOS Debug ] ipc/dirty-re...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 360f910bf19225a3f14a2758df457e295c4f8e10
  
https://github.com/WebKit/WebKit/commit/360f910bf19225a3f14a2758df457e295c4f8e10
  Author: Jay Stfleur 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations

  Log Message:
  ---
  NEW TEST (278840@main): [ iOS Debug ] ipc/dirty-region-overflow.html is a 
consistent crash
https://bugs.webkit.org/show_bug.cgi?id=274925
rdar://129025058

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/ios/TestExpectations:

Canonical link: https://commits.webkit.org/279543@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 39d487: Gardening: [ Monterey wk2 Release ] imported/w3c/w...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39d48790a45cb923a2b6ce537d1a1b9c3db9d064
  
https://github.com/WebKit/WebKit/commit/39d48790a45cb923a2b6ce537d1a1b9c3db9d064
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: [ Monterey wk2 Release ] 
imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-012.html is a 
flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=238880
rdar://91364715

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279542@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5cf6b7: Gardening: MediaPlayerPrivateMediaSourceAVFObjC is...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cf6b7b36a72dc60197e6df066008e9355f5707b
  
https://github.com/WebKit/WebKit/commit/5cf6b7b36a72dc60197e6df066008e9355f5707b
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: MediaPlayerPrivateMediaSourceAVFObjC is not handling aspect ratio 
preservation signal from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=264944
rdar://118508061

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279541@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6aa9ff: Adding Jay Stfleur as contributor to the Webkit Pr...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6aa9fff3e9b491dd0164a0837b4976ce01376df7
  
https://github.com/WebKit/WebKit/commit/6aa9fff3e9b491dd0164a0837b4976ce01376df7
  Author: Jay Stfleur 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Adding Jay Stfleur as contributor to the Webkit Project
https://bugs.webkit.org/show_bug.cgi?id=268950
rdar://122501538

Unreviewed change.

Editing contributor info.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/279540@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81560b: Gardening: [ BigSur+ wk2 Release ] css3/masking/re...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81560b2588abb4316c1bff96fda50196a54d1d0c
  
https://github.com/WebKit/WebKit/commit/81560b2588abb4316c1bff96fda50196a54d1d0c
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: [ BigSur+ wk2 Release ] 
css3/masking/reference-clip-path-animate-transform-repaint.html is a flaky 
failure
https://bugs.webkit.org/show_bug.cgi?id=230504
rdar://83322101

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279539@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5ca7f8: [WPE] Unreviewed, fix build error after 279501@main

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5ca7f83342d31c77a802fe0b525f005a82e38732
  
https://github.com/WebKit/WebKit/commit/5ca7f83342d31c77a802fe0b525f005a82e38732
  Author: Diego Pino Garcia 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp
M Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp

  Log Message:
  ---
  [WPE] Unreviewed, fix build error after 279501@main
https://bugs.webkit.org/show_bug.cgi?id=273750

In the case unified sources group files 'WebAutomationSessionLibWPE.cpp'
and 'WebAutomationSessionWPE.cpp' together, because there are several
static functions in these files defined with the same name, a duplicate
symbol build error will happen.

Rename function names to avoid collisions.

* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:
(WebKit::libWPEModifiersToEventState):
(WebKit::platformSimulateMouseInteractionLibWPE):
(WebKit::modifiersToEventState): Deleted.
* Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionWPE.cpp:
(WebKit::libWPEMouseButtonToWPEButton):
(WebKit::libWPEStateModifierForWPEButton):
(WebKit::doMouseEvent):
(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
(WebKit::mouseButtonToWPEButton): Deleted.
(WebKit::stateModifierForWPEButton): Deleted.

Canonical link: https://commits.webkit.org/279538@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3cecef: [UnifiedPDF] Form annotations get stuck permanentl...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cecef4425a0713947e7774132427d2d9bb7193d
  
https://github.com/WebKit/WebKit/commit/3cecef4425a0713947e7774132427d2d9bb7193d
  Author: Abrar Rahman Protyasha 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  ---
  [UnifiedPDF] Form annotations get stuck permanently on the document when 
navigating while an annotation is focused
https://bugs.webkit.org/show_bug.cgi?id=274867
rdar://128912717

Reviewed by Simon Fraser.

When an annotation is focused and we navigate away, nothing ensures that
the active annotation is cleaned up appropriately and the queued async
task to call Node::remove() on the annotation element gets dropped.

This means that on a reload, the Node corresponding to the previous
active annotation is still hanging around, and now with no way to
actually detach it.

This patch fixes said issue by ensuring we do eager cleanup for any
active annotation when the PDF plugin is torn down.Note that we now
provide additional context to setActiveAnnotation() because when the
navigation has started, and the plugin is being torn down,
PDFPluginBase::isFullFramePlugin() returns false, expectedly so. We do
not want to consult this during cleanup.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeActiveAnnotation:]):
(WebKit::PDFPlugin::setActiveAnnotation):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::handleEvent):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::teardown):
(WebKit::UnifiedPDFPlugin::handleMouseEvent):
(WebKit::UnifiedPDFPlugin::focusNextAnnotation):
(WebKit::UnifiedPDFPlugin::focusPreviousAnnotation):
(WebKit::UnifiedPDFPlugin::setActiveAnnotation):

Canonical link: https://commits.webkit.org/279537@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2fd00: field changes sizes briefly while typing

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2fd007b306c7afe6bee7a3789887c08432d1df2
  
https://github.com/WebKit/WebKit/commit/a2fd007b306c7afe6bee7a3789887c08432d1df2
  Author: Alan Baradlay 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
A LayoutTests/fast/dynamic/input-box-inside-flex-grid-expected.html
A LayoutTests/fast/dynamic/input-box-inside-flex-grid.html
M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  ---
   field changes sizes briefly while typing
https://bugs.webkit.org/show_bug.cgi?id=274904


Reviewed by Antti Koivisto.

* LayoutTests/fast/dynamic/input-box-inside-flex-grid-expected.html: Added.
* LayoutTests/fast/dynamic/input-box-inside-flex-grid.html: Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):

Canonical link: https://commits.webkit.org/279536@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a505c: [WK1] iOS WK1 application crashes after loading media

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a505cbe327dcfe2c7efe4897bf07ac3532b54fb
  
https://github.com/WebKit/WebKit/commit/0a505cbe327dcfe2c7efe4897bf07ac3532b54fb
  Author: Jean-Yves Avenard 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WTF/WTF.xcodeproj/project.pbxproj
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/Forward.h
A Source/WTF/wtf/MainThreadDispatcher.cpp
A Source/WTF/wtf/MainThreadDispatcher.h
M Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
M 
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h
M 
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm
M Source/WebCore/platform/network/cocoa/RangeResponseGenerator.h
M Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm
M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h
M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm
M Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h

  Log Message:
  ---
  [WK1] iOS WK1 application crashes after loading media
https://bugs.webkit.org/show_bug.cgi?id=274888
rdar://128549043

Reviewed by Youenn Fablet.

In 273804@main we added the possibility to perform the media networking 
operation off the main thread.
The PlatformResourceMediaLoader was made to take a WorkQueue on which the 
operations were to be performed.
For builds without a GPU process or WK1, we used the WorkQueue::main().
However WorkQueue::main() isn't handling the subtelties related to the Web 
thread vs UI thread.
This triggered a RELEASE_ASSERT(isMainThread()) as isMainThread() with WK1 on 
iOS checks that we are
on the WebThread.

So instead rather than using WorkQueues we use 
RefCountedSerialFunctionDispatcher and we introduce
MainThreadDispatcher which is a RCSerialFunctionDispatcher that will dispatch 
using runOnMainThread().

Covered by existing tests.

* Source/WTF/WTF.xcodeproj/project.pbxproj:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/Forward.h:
* Source/WTF/wtf/MainThreadDispatcher.cpp: Added.
(WTF::MainThreadDispatcher::singleton):
(WTF::MainThreadDispatcher::isCurrent const):
(WTF::MainThreadDispatcher::dispatch):
(WTF::MainThreadDispatcher::ref const):
(WTF::MainThreadDispatcher::deref const):
* Source/WTF/wtf/MainThreadDispatcher.h: Added.
* Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:
(WebCore::PlatformMediaResourceLoader::targetDispatcher):
(WebCore::PlatformMediaResourceLoader::targetQueue): Deleted.
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest):
* Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
* 
Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::PlatformResourceMediaLoader::PlatformResourceMediaLoader):
(WebCore::PlatformResourceMediaLoader::stop):
(WebCore::PlatformResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::loadFailed):
(WebCore::PlatformResourceMediaLoader::loadFinished):
(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):
(WebCore::WebCoreAVFResourceLoader::create):
(WebCore::WebCoreAVFResourceLoader::WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::stopLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::loadFailed):
(WebCore::WebCoreAVFResourceLoader::loadFinished):
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):
* Source/WebCore/platform/network/cocoa/RangeResponseGenerator.h:
* Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::RangeResponseGenerator):
(WebCore::RangeResponseGenerator::map):
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):
(WebCore::RangeResponseGenerator::giveResponseToTasksWithFinishedRanges):
(WebCore::RangeResponseGenerator::willHandleRequest):
(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
* Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h:
* Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:onTarget:]):
(-[WebCoreNSURLSe

[webkit-changes] [WebKit/WebKit] 99ec45: REGRESSION (279452@main): [ MacOS WK1 ] imported/w...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99ec4582f9e47c6cf61839b40e0e58937465d582
  
https://github.com/WebKit/WebKit/commit/99ec4582f9e47c6cf61839b40e0e58937465d582
  Author: Sihui Liu 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations
M 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt

  Log Message:
  ---
  REGRESSION (279452@main): [ MacOS WK1 ] 
imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub.html
 is consistent failure
https://bugs.webkit.org/show_bug.cgi?id=274906
rdar://129012244

Unreviewed test gardening: remove the new console log line added in 279452@main 
from the expected file.

* LayoutTests/platform/mac-wk1/TestExpectations:
* 
LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub-expected.txt:

Canonical link: https://commits.webkit.org/279534@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8bd834: Adopt StringParsingBuffer & std::span in WGSL's L...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8bd834504598b8c53f71236d66d714b6a61b3281
  
https://github.com/WebKit/WebKit/commit/8bd834504598b8c53f71236d66d714b6a61b3281
  Author: Chris Dumez 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/Lexer.h

  Log Message:
  ---
   Adopt StringParsingBuffer & std::span in WGSL's Lexer
https://bugs.webkit.org/show_bug.cgi?id=274861

Reviewed by Sam Weinig.

* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::isIdentifierStart):
(WGSL::isIdentifierContinue):
(WGSL::Lexer::nextToken):
(WGSL::Lexer::shift):
(WGSL::Lexer::peek):
(WGSL::Lexer::isAtEndOfFile const):
(WGSL::Lexer::lexNumber):
* Source/WebGPU/WGSL/Lexer.h:
(WGSL::Lexer::Lexer):

Canonical link: https://commits.webkit.org/279533@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a1ef8a: Gardening: webanimations/translate-property-and-tr...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1ef8a77f6774fa9ce968e15775a004febc52a4b
  
https://github.com/WebKit/WebKit/commit/a1ef8a77f6774fa9ce968e15775a004febc52a4b
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: 
webanimations/translate-property-and-translate-animation-with-delay-on-forced-layer.html
 is a flaky image-only fail
rdar://82032946

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279532@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 74d680: Gardening: [Mac wk2] webrtc/video-setDirection.htm...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74d680c3aafd5514db18da0ccd82f49180fb2519
  
https://github.com/WebKit/WebKit/commit/74d680c3aafd5514db18da0ccd82f49180fb2519
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: [Mac wk2] webrtc/video-setDirection.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=229158
rdar://82257954

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279531@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0455d0: Upgrade my status to committer in contributors.json

[Marcus Plutowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0455d0b0f6513167e77e4abd419943b493c8e7ad
  
https://github.com/WebKit/WebKit/commit/0455d0b0f6513167e77e4abd419943b493c8e7ad
  Author: Marcus Plutowski 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Upgrade my status to committer in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=274907
rdar://129012669

Reviewed by Yusuke Suzuki.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/279530@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1dec53: Gardening: [Mac wk2]webrtc/video-addTrack.html is ...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dec53fa229deae8c4e48e4cce6297e1f1f777a9
  
https://github.com/WebKit/WebKit/commit/1dec53fa229deae8c4e48e4cce6297e1f1f777a9
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: [Mac wk2]webrtc/video-addTrack.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=229156
rdar://81991835

Unreviewed test gardening.

Remove stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279529@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31262e: Gardening: REGRESSION: [Big Sur wk2 Debug] accessi...

[Ben]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31262e0cf797969fbbe3f903861f40336e175c23
  
https://github.com/WebKit/WebKit/commit/31262e0cf797969fbbe3f903861f40336e175c23
  Author: Ben Schwartz 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  Gardening: REGRESSION: [Big Sur wk2 Debug] accessibility/table-title.html is 
a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=227504
rdar://79931898

Unreviewed test gardening.

Removing stale test expectation.

* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279528@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f22f3b: REGRESSION (279452@main): [ MacOS WK1 ] imported/w...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f22f3b7a00b4775add6c7a3d3bd3f1bbdc2c1945
  
https://github.com/WebKit/WebKit/commit/f22f3b7a00b4775add6c7a3d3bd3f1bbdc2c1945
  Author: Jay Stfleur 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-wk1/TestExpectations

  Log Message:
  ---
  REGRESSION (279452@main): [ MacOS WK1 ] 
imported/w3c/web-platform-tests/geolocation-API/enabled-by-permission-policy-attribute-redirect-on-load.https.sub.html
 is consistent failure
https://bugs.webkit.org/show_bug.cgi?id=274906
rdar://129012244

Unreviewed test gardening.

Adding test expectation.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/279527@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3b8230: [ GARDENING ]([ iOS EWS ] TestWebKitAPI._WKDownloa...

[Dawn Morningstar]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b82304c6e8abdd67c3270feeefe68067dbf9a4d
  
https://github.com/WebKit/WebKit/commit/3b82304c6e8abdd67c3270feeefe68067dbf9a4d
  Author: Dawn Morningstar 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

  Log Message:
  ---
  [ GARDENING ]([ iOS EWS ] 
TestWebKitAPI._WKDownload.DownloadMonitorReturnToForeground is a flaky timeout 
(274905))
rdar://129011312

Unreviewed test gardening.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::TEST(_WKDownload, DownloadMonitorReturnToForeground)):

Canonical link: https://commits.webkit.org/279526@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b777f4: [Site Isolation] Fix date/time pickers

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b777f464fd85daefa693aa81e02c404314147e09
  
https://github.com/WebKit/WebKit/commit/b777f464fd85daefa693aa81e02c404314147e09
  Author: Charlie Wolfe 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  ---
  [Site Isolation] Fix date/time pickers
https://bugs.webkit.org/show_bug.cgi?id=274866
rdar://128967740

Reviewed by Alex Christensen and Pascoe.

A few more layout tests pass with this, also tested locally on Mac.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseDate):
(WebKit::WebPageProxy::didEndDateTimePicker):

Canonical link: https://commits.webkit.org/279525@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd6c80: [Site Isolation] Fix `_executeEditCommand:`

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd6c80aa02f3ad5e04ad7e03b583d05675390469
  
https://github.com/WebKit/WebKit/commit/cd6c80aa02f3ad5e04ad7e03b583d05675390469
  Author: Charlie Wolfe 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  ---
  [Site Isolation] Fix `_executeEditCommand:`
https://bugs.webkit.org/show_bug.cgi?id=274860
rdar://128966041

Reviewed by Alex Christensen and Pascoe.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::executeEditCommand):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, SynchronouslyExecuteEditCommandSelectAll)):

Canonical link: https://commits.webkit.org/279524@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 32a1e9: [WebXR] Avoid re-allocation of metal textures for ...

[Ada Chan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32a1e991f51741f6d02c5025fd3773ffcd9302c6
  
https://github.com/WebKit/WebKit/commit/32a1e991f51741f6d02c5025fd3773ffcd9302c6
  Author: Ada Chan 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp
M Source/WebCore/Modules/webxr/WebXRSession.cpp
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.h
M Source/WebCore/platform/xr/PlatformXR.h
M Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp
M Source/WebCore/testing/WebFakeXRDevice.cpp
M Source/WebKit/Shared/XR/PlatformXR.serialization.in
M Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm

  Log Message:
  ---
  [WebXR] Avoid re-allocation of metal textures for every frame
https://bugs.webkit.org/show_bug.cgi?id=274882
rdar://128010992

Reviewed by Dan Glastonbury and Mike Wyrzykowski.

Before this code change, metal texture handles are passed in
the frame data for every frame render, and we'd allocate a metal
texture from this handle (and later deallocate it) for each frame.

With this change, we allow textures to be reused. PlatformXRSystem
can send back a reusable index along with the texture handle, and
WebXROpaqueFramebuffer caches the allocated texture with that index.
When this same texture can be reused in a future frame, PlatformXRSystem
will send back that index in the frame data with a null texture handle
as a signal that the last texture stored at that index should be used.

* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
(WebCore::WebXRExternalRenderbuffer::operator bool const):
(WebCore::WebXRAttachmentSet::operator bool const):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp:
(WebCore::WebXROpaqueFramebuffer::~WebXROpaqueFramebuffer):
The cleanup of the display attachments is now handled in 
releaseAllDisplayAttachments().
(WebCore::WebXROpaqueFramebuffer::startFrame):
Call the new helper method bindCompositorTexturesForDisplay() that will
reuse a cached texture if possible.
(WebCore::WebXROpaqueFramebuffer::endFrame):
We no longer need to deallocate the texture after each frame render.
(WebCore::WebXROpaqueFramebuffer::releaseAllDisplayAttachments):
Release all the cached display attachments.
(WebCore::WebXROpaqueFramebuffer::blitShared):
(WebCore::WebXROpaqueFramebuffer::blitSharedToLayered):
(WebCore::WebXROpaqueFramebuffer::reusableDisplayAttachments const):
If texture handle is null, return the texture cached at the 
reusableTextureIndex.
(WebCore::WebXROpaqueFramebuffer::bindCompositorTexturesForDisplay):
First, ensure the m_displayAttachmentsSets vector is large enough to store
the set of display attachments used for this frame render. If there's no
layerData.textureData, which is the case when we run layout tests, create a
temporary renderbuffer to be used as the display color buffer. Otherwise,
check if we can reuse a previously created texture. If reuse is not possible,
create new textures with the handles passed in the frame data.
(WebCore::WebXROpaqueFramebuffer::releaseDisplayAttachmentsAtIndex):
Helper method to clean up the display attachments, refactored from old code.
* Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::didCompleteShutdown):
* Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::sessionEnded):
Clean up any cached display attachments.
* Source/WebCore/Modules/webxr/WebXRWebGLLayer.h:
* Source/WebCore/platform/xr/PlatformXR.h:
Introduce ExternalTextureData that packages up all the texture info
along with the reusable index.
Store LayerData with UniqueRef so we don't have to worry about its
size getting too large to be hashable.
* Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::OpenXRDevice::requestFrame):
* Source/WebCore/testing/WebFakeXRDevice.cpp:
(WebCore::SimulatedXRDevice::frameTimerFired):
Don't pass any textureData from the fake device so a temporary
renderbuffer will be used for the color display buffer.
* Source/WebKit/Shared/XR/PlatformXR.serialization.in:
* Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm:
(WebKit::ARKitCoordinator::renderLoop):

Canonical link: https://commits.webkit.org/279523@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a5473c: [UnifiedPDF] Keep page previews around more aggres...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5473c4f0084ecfaba9cb8a09b2ea86d6e95a820
  
https://github.com/WebKit/WebKit/commit/a5473c4f0084ecfaba9cb8a09b2ea86d6e95a820
  Author: Simon Fraser 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/html/PluginDocument.cpp
M Source/WebCore/html/PluginDocument.h
M Source/WebCore/page/MemoryRelease.cpp
M Source/WebCore/plugins/PluginViewBase.h
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h

  Log Message:
  ---
  [UnifiedPDF] Keep page previews around more aggressively
https://bugs.webkit.org/show_bug.cgi?id=273958
rdar://127820531

Reviewed by Abrar Rahman Protyasha.

Page previews are used to show a lower-resolution of the PDF page before we 
render
high-resolution tiles. They help reduce apparent flashiness when scrolling and 
zooming.

We currently only retain page previews for pages in the visible area (based on
TiledBacking's `coverageRect`). However, this causes us to throw away and 
re-render
page previews frequently when scrolling and zooming.

Instead, retain all the page previews, for full-page plugins, and rely on a 
memory
warning to release those outside the visible area. They are released via a
`releaseMemory()` call that is plumbed through from `releaseCriticalMemory()`.
Doing this only for full-frame plugins avoids the need to traverse the DOM to 
find
all the PDFPlugin instances.

* Source/WebCore/html/PluginDocument.cpp:
(WebCore::PluginDocument::releaseMemory):
* Source/WebCore/html/PluginDocument.h:
* Source/WebCore/page/MemoryRelease.cpp:
(WebCore::releaseCriticalMemory):
* Source/WebCore/plugins/PluginViewBase.h:
(WebCore::PluginViewBase::releaseMemory):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::releaseMemory):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::releaseMemory):
(WebKit::AsyncPDFRenderer::removePreviewForPage):
(WebKit::AsyncPDFRenderer::coverageRectDidChange):
(WebKit::AsyncPDFRenderer::removePagePreviewsOutsideCoverageRect):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::releaseMemory):
(WebKit::UnifiedPDFPlugin::shouldCachePagePreviews const):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::releaseMemory):
* Source/WebKit/WebProcess/Plugins/PluginView.h:

Canonical link: https://commits.webkit.org/279522@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] be0cf2: Unreviewed, reverting 279326@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be0cf29026ecfadab408199cdb6436060f89
  
https://github.com/WebKit/WebKit/commit/be0cf29026ecfadab408199cdb6436060f89
  Author: Commit Queue 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm
M Source/WebKit/Platform/cocoa/XPCUtilities.h
M Source/WebKit/Platform/cocoa/XPCUtilities.mm
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h
M Source/WebKit/UIProcess/Cocoa/XPCConnectionTerminationWatchdog.h
M Source/WebKit/UIProcess/Cocoa/XPCConnectionTerminationWatchdog.mm
M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

  Log Message:
  ---
  Unreviewed, reverting 279326@main.
https://bugs.webkit.org/show_bug.cgi?id=274902

Broke process termination on iOS

Reverted changeset:

"Invalidate process object in XPC connection termination watchdog"
https://bugs.webkit.org/show_bug.cgi?id=273773
https://commits.webkit.org/279326@main

Canonical link: https://commits.webkit.org/279521@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c7b3a: Unreviewed build fix after 279512@main.

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c7b3a9e940e9f230b1afddf798b9509e46965df
  
https://github.com/WebKit/WebKit/commit/8c7b3a9e940e9f230b1afddf798b9509e46965df
  Author: Chris Dumez 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

  Log Message:
  ---
  Unreviewed build fix after 279512@main.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):

Canonical link: https://commits.webkit.org/279520@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8c82c6: [LFC] Introduce concept of primary layout state

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8c82c6544856e727ced9aacc14b5936042918b1e
  
https://github.com/WebKit/WebKit/commit/8c82c6544856e727ced9aacc14b5936042918b1e
  Author: Antti Koivisto 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/layout/LayoutState.cpp
M Source/WebCore/layout/LayoutState.h
M Source/WebCore/layout/layouttree/LayoutBox.cpp
M Source/WebCore/layout/layouttree/LayoutBox.h
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
M Source/WebCore/rendering/RenderView.cpp

  Log Message:
  ---
  [LFC] Introduce concept of primary layout state
https://bugs.webkit.org/show_bug.cgi?id=274895
rdar://problem/128999403

Reviewed by Alan Baradlay.

Geometry for the primary layout state gets a direct cache in layout boxes.
This way we can remove the layout state pointer from Layout::Box saving memory
and simplifying code.

* Source/WebCore/layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::ensureGeometryForBoxSlow):
* Source/WebCore/layout/LayoutState.h:
(WebCore::Layout::LayoutState::type const):
(WebCore::Layout::LayoutState::hasBoxGeometry const):
(WebCore::Layout::LayoutState::ensureGeometryForBox):
(WebCore::Layout::LayoutState::geometryForBox const):
(WebCore::Layout::Box::canCacheForLayoutState const): Deleted.
(WebCore::Layout::Box::cachedGeometryForLayoutState const): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::setCachedGeometryForLayoutState const): Deleted.
* Source/WebCore/layout/layouttree/LayoutBox.h:
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::printLayoutTreeForLiveDocuments):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):

Canonical link: https://commits.webkit.org/279519@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cdcd67: NEW TEST (279412@main): [ MacOS iOS ] http/tests/s...

[Jay Saintfleur]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdcd67f955bd27839f33ec035fb1716e3cfdca1d
  
https://github.com/WebKit/WebKit/commit/cdcd67f955bd27839f33ec035fb1716e3cfdca1d
  Author: Jay Stfleur 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk2/TestExpectations

  Log Message:
  ---
  NEW TEST (279412@main): [ MacOS iOS ] 
http/tests/site-isolation/opened-window-length.html is a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=274847
rdar://128953241

Unreviewed test gardening.

Removing test expectation.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/279518@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 05bc25: REGRESSION(278264@main): [ GStreamer Debug ] `ASSE...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05bc254f9ea74fb43e4a8b622dc1f063a3c27a19
  
https://github.com/WebKit/WebKit/commit/05bc254f9ea74fb43e4a8b622dc1f063a3c27a19
  Author: Vitaly Dyachkov 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp

  Log Message:
  ---
  REGRESSION(278264@main): [ GStreamer Debug ] `ASSERTION FAILED: 
!gst_is_initialized()` in `TestWebCore/GStreamerTest.*` API tests
https://bugs.webkit.org/show_bug.cgi?id=274892

Reviewed by Philippe Normand.

`gst_deinit()` does not reset `gst_initialized`, thus this assertion will 
always fail.

* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp:
(TestWebKitAPI::GStreamerTest::TearDownTestSuite):

Canonical link: https://commits.webkit.org/279517@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2228e1: [WebGPU] Replace asynchronous .requestAdapterInfo(...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2228e1db0bd91bd4dac15c25dc4bbbaddd482485
  
https://github.com/WebKit/WebKit/commit/2228e1db0bd91bd4dac15c25dc4bbbaddd482485
  Author: Mike Wyrzykowski 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp
M Source/WebCore/Modules/WebGPU/GPUAdapter.h
M Source/WebCore/Modules/WebGPU/GPUAdapter.idl

  Log Message:
  ---
  [WebGPU] Replace asynchronous .requestAdapterInfo() with synchronous .info
https://bugs.webkit.org/show_bug.cgi?id=274797


Reviewed by Dan Glastonbury.

Per recent spec change, requestAdapterInfo has become a synchronous info
call.

Our implementation already resolved the promise synchronously, so the impact
is minimal.

Reland keeping both implementations as removing the old version regresses
some websites.

* Source/WebCore/Modules/WebGPU/GPUAdapter.cpp:
(WebCore::GPUAdapter::info):
* Source/WebCore/Modules/WebGPU/GPUAdapter.h:
* Source/WebCore/Modules/WebGPU/GPUAdapter.idl:

Canonical link: https://commits.webkit.org/279516@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c60da0: Silence IOKit related sandbox violation for syscall

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c60da0e181654353be440d432c5807f212545e1c
  
https://github.com/WebKit/WebKit/commit/c60da0e181654353be440d432c5807f212545e1c
  Author: Per Arne Vollan 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

  Log Message:
  ---
  Silence IOKit related sandbox violation for syscall
https://bugs.webkit.org/show_bug.cgi?id=274899
rdar://129004331

Reviewed by Sihui Liu.

All use of IOKit is blocked in the WebContent process. This patch disables 
reporting
for a IOKit related syscall.

* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/279515@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4e1fc: [GLIB] Many API tests are asserting in debug mode ...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4e1fcab19f990a18c6eeb38459ec03477fe3c29
  
https://github.com/WebKit/WebKit/commit/a4e1fcab19f990a18c6eeb38459ec03477fe3c29
  Author: Vitaly Dyachkov 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  ---
  [GLIB] Many API tests are asserting in debug mode when destroying 
WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=221119

Unreviewed API tests gardening.

Fixed in 245040@main.

* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/279514@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 484500: [SHA1] Add fast path when adding UTF8 bytes from a...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 484500b2c078b29f80e12b8130c3f95ca698e2d3
  
https://github.com/WebKit/WebKit/commit/484500b2c078b29f80e12b8130c3f95ca698e2d3
  Author: Chris Dumez 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/CodeBlockHash.cpp
M Source/JavaScriptCore/bytecode/ParseHash.cpp
M Source/WTF/wtf/SHA1.cpp
M Source/WTF/wtf/SHA1.h
M Source/WebCore/inspector/DOMPatchSupport.cpp
M Source/WebCore/platform/WebCorePersistentCoders.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm

  Log Message:
  ---
  [SHA1] Add fast path when adding UTF8 bytes from a String that only contains 
ASCII
https://bugs.webkit.org/show_bug.cgi?id=274873

Reviewed by Darin Adler and Timothy Hatcher.

Add fast path when adding UTF8 bytes from a String that only contains ASCII.
Also fix a bug in our HTTP disk cache hashing function where there was already
a fast path and this fast path was hashing the null terminator, where was the
slow path wasn't. Align both code paths so that we never hash the null
terminator and bump the HTTP cache version since this change is not backward
compatible.

* Source/JavaScriptCore/bytecode/CodeBlockHash.cpp:
(JSC::CodeBlockHash::CodeBlockHash):
* Source/JavaScriptCore/bytecode/ParseHash.cpp:
(JSC::ParseHash::ParseHash):
* Source/WTF/wtf/SHA1.cpp:
(WTF::SHA1::addUTF8Bytes):
* Source/WTF/wtf/SHA1.h:
(WTF::SHA1::addUTF8Bytes):
* Source/WebCore/inspector/DOMPatchSupport.cpp:
(WebCore::addStringToSHA1):
* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::addStringToSHA1):
* Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::hashString):
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::computeStringHashForContentBlockerRules):

Canonical link: https://commits.webkit.org/279513@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 102588: Use consistent typing / naming for parameters of l...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 102588eaaeb7cc47ce9308b229049a80bedf4600
  
https://github.com/WebKit/WebKit/commit/102588eaaeb7cc47ce9308b229049a80bedf4600
  Author: Chris Dumez 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  ---
  Use consistent typing / naming for parameters of logOnBehalfOfWebContent()
https://bugs.webkit.org/show_bug.cgi?id=274885

Reviewed by Per Arne Vollan.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::registerLogHook):

Canonical link: https://commits.webkit.org/279512@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e42a32: Fix CARenderServer sandbox violation

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e42a325eda4c660df9387de3e1eb1fa88c127f18
  
https://github.com/WebKit/WebKit/commit/e42a325eda4c660df9387de3e1eb1fa88c127f18
  Author: Per Arne Vollan 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  ---
  Fix CARenderServer sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=274884
rdar://128983768

Reviewed by Chris Dumez.

Fix CARenderServer sandbox violation under WebPage::platformInitialize on macOS.
Do not try to eagerly open up a Mach connection to CARenderServer when unified
PDF is enabled, since this access is not required and blocked in the sandbox in
that case.

* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformInitialize):

Canonical link: https://commits.webkit.org/279511@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e1aad2: [GTK][WPE] Unreviewed test gardening

[Diego Pino]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1aad2548d9a86f76d78686ff38d4f65c6870bcf
  
https://github.com/WebKit/WebKit/commit/e1aad2548d9a86f76d78686ff38d4f65c6870bcf
  Author: Diego Pino Garcia 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
R 
LayoutTests/platform/glib/fast/block/basic/inline-content-with-floating-image-expected.txt
R 
LayoutTests/platform/glib/fast/block/basic/inline-content-with-floating-images2-expected.txt
R 
LayoutTests/platform/glib/fast/inline/simple-inline-inflow-positioned-expected.txt
R 
LayoutTests/platform/glib/fast/inline/simple-inline-with-out-of-flow-descendant2-expected.txt
R 
LayoutTests/platform/glib/fast/inline/simple-intruding-floats3-expected.txt
M LayoutTests/platform/gtk-wayland/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
R 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt
R 
LayoutTests/platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt
R 
LayoutTests/platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt
R 
LayoutTests/platform/wpe/fast/inline/simple-inline-with-out-of-flow-descendant-expected.txt

  Log Message:
  ---
  [GTK][WPE] Unreviewed test gardening

Mark several tests that are now passing after baseline update as
failure. Also, properly mark some other tests as flaky.

* 
LayoutTests/glib/fast/inline/simple-inline-with-out-of-flow-descendant2-expected.txt:
 Removed.
* LayoutTests/platform/glib/TestExpectations:
* 
LayoutTests/platform/glib/fast/block/basic/inline-content-with-floating-image-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/fast/block/basic/inline-content-with-floating-images2-expected.txt:
 Removed.
* 
LayoutTests/platform/glib/fast/inline/simple-inline-inflow-positioned-expected.txt:
 Removed.
* LayoutTests/platform/glib/fast/inline/simple-intruding-floats3-expected.txt: 
Removed.
* LayoutTests/platform/gtk-wayland/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* 
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/fast/inline/simple-inline-with-out-of-flow-descendant-expected.txt:
 Removed.

Canonical link: https://commits.webkit.org/279510@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5dfbc6: [CMake][GLib] Propagate unified build setting to m...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5dfbc67f91ea412829e4f77603be555dd0e6568f
  
https://github.com/WebKit/WebKit/commit/5dfbc67f91ea412829e4f77603be555dd0e6568f
  Author: Adrian Perez de Castro 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/cmake/WebKitDist.cmake

  Log Message:
  ---
  [CMake][GLib] Propagate unified build setting to make-dist script
https://bugs.webkit.org/show_bug.cgi?id=274894

Reviewed by Carlos Garcia Campos.

 Pass --unified to make-dist if ENABLE_UNIFIED_BUILDS has been enabled.

 While at it, change the WEBKIT_DECLARE_DIST_TARGETS() macro to be a
 function: it does not modify the caller environment in any way so there
 is no reason for it to be a macro. This makes it easier to have a new
 local variable that does not pollute the scope of the caller.

* Source/cmake/WebKitDist.cmake:

Canonical link: https://commits.webkit.org/279509@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit]

[Adrian Perez]

  Branch: refs/tags/wpewebkit-2.45.3
  Home:   https://github.com/WebKit/WebKit

To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b7fdcc: Unreviewed. Update OptionsWPE.cmake and NEWS for t...

[Adrian Perez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b7fdcc092a033f77d299b7c19af25dee1d6196c0
  
https://github.com/WebKit/WebKit/commit/b7fdcc092a033f77d299b7c19af25dee1d6196c0
  Author: Adrian Perez de Castro 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebKit/wpe/NEWS
M Source/cmake/OptionsWPE.cmake

  Log Message:
  ---
  Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.45.3 release

* Source/WebKit/wpe/NEWS: Add release notes for 2.45.3
* Source/cmake/OptionsWPE.cmake: Bump version numbers.

Canonical link: https://commits.webkit.org/279508@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 52e428: Cherry-pick 279246@main (467a1e1b9822). https://bu...

[Frances Cornwall]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 52e428e37d6e31f4a602176a017d64110f0603f6
  
https://github.com/WebKit/WebKit/commit/52e428e37d6e31f4a602176a017d64110f0603f6
  Author: Frances Cornwall 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css

  Log Message:
  ---
  Cherry-pick 279246@main (467a1e1b9822). 
https://bugs.webkit.org/show_bug.cgi?id=274495

Remove duplicate `background-color`
https://bugs.webkit.org/show_bug.cgi?id=274495

Reviewed by Devin Rousso.

Remove duplicate background-color in GraphicsOverviewContentView.css.

* Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview):

Canonical link: https://commits.webkit.org/279246@main

Canonical link: https://commits.webkit.org/274313.292@webkitglib/2.44



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a04bd3: REGRESSION(2.45.1/2.45.2): [GTK] UI process crash ...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a04bd30787a23ce52d90bba8c0acb4f4cd5ab5d5
  
https://github.com/WebKit/WebKit/commit/a04bd30787a23ce52d90bba8c0acb4f4cd5ab5d5
  Author: Carlos Garcia Campos 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp
M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp

  Log Message:
  ---
  REGRESSION(2.45.1/2.45.2): [GTK] UI process crash in 
Nicosia::AcceleratedBuffer::~AcceleratedBuffer: Couldn't find current GLX or 
EGL context
https://bugs.webkit.org/show_bug.cgi?id=274389

Reviewed by Miguel Gomez.

The problem is that the scrolling thread is invalidated when the page is
destroyed after the SkiaAcceleratedBufferPool is destroyed. So, the
CompositeLayers of the scroling tree nodes can have a reference of a
Nicosia::AcceleratedBuffer that is destroyed in the async scrolling thread
with no current GL context. In SkiaAcceleratedBufferPool we make sure to
make the skia GL context current before destroying the buffers, but
buffers are only destroyed there if it's the last reference. We should make
sure that Nicosia::AcceleratedBuffer GL recources are freed in the main
thread with the skia GL context current on destruction.

* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:
(Nicosia::AcceleratedBuffer::~AcceleratedBuffer):
* Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp:
(WebCore::SkiaAcceleratedBufferPool::releaseUnusedBuffersTimerFired):
(WebCore::SkiaAcceleratedBufferPool::~SkiaAcceleratedBufferPool): Deleted.

Canonical link: https://commits.webkit.org/279507@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c4467f: WebCore::XPath::Value has uninitialized fields aft...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4467fc5aed587478747535b46aedf0d08ad2995
  
https://github.com/WebKit/WebKit/commit/c4467fc5aed587478747535b46aedf0d08ad2995
  Author: David Kilzer 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/xml/XPathFunctions.cpp
M Source/WebCore/xml/XPathPath.h
M Source/WebCore/xml/XPathPredicate.cpp
M Source/WebCore/xml/XPathPredicate.h
M Source/WebCore/xml/XPathResult.cpp
M Source/WebCore/xml/XPathValue.cpp
M Source/WebCore/xml/XPathValue.h
M Source/WebCore/xml/XPathVariableReference.h

  Log Message:
  ---
  WebCore::XPath::Value has uninitialized fields after construction



Reviewed by Chris Dumez.

Fix in XPathValue.h is to set m_bool and m_double to default values when
constructing WebCore::XPath::Value objects.

Additional drive-by fixes that comprise most of the changes:
- Update WebCore::XPath::Value::Type to an enum class.
- Fix format of header files to remove unwanted whitespace.
- Add missing comments for closing namespace braces.
- Fix indentation of case statements in XPathValue.cpp.
- Fix formatting of constructors in XPathValue.h.

* Source/WebCore/xml/XPathFunctions.cpp:
* Source/WebCore/xml/XPathPath.h:
* Source/WebCore/xml/XPathPredicate.cpp:
(WebCore::XPath::predicateIsContextPositionSensitive):
* Source/WebCore/xml/XPathPredicate.h:
* Source/WebCore/xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
* Source/WebCore/xml/XPathValue.cpp:
(WebCore::XPath::Value::modifiableNodeSet):
(WebCore::XPath::Value::toBoolean const):
(WebCore::XPath::Value::toNumber const):
(WebCore::XPath::Value::toString const):
* Source/WebCore/xml/XPathValue.h:
(WebCore::XPath::Value):
- Initialize m_bool to false and m_double to 0 to fix the bug.
(WebCore::XPath::Value::Type):
- Change to enum class with size uint8_t.
- Remove redundant "Value" from the end of enum names.
(WebCore::XPath::Value::Value):
- Delete default constructor since it is unused.
(WebCore::XPath::Value::type const):
(WebCore::XPath::Value::isNodeSet const):
(WebCore::XPath::Value::isBoolean const):
(WebCore::XPath::Value::isNumber const):
(WebCore::XPath::Value::isString const):
(WebCore::XPath::Value::Data::create):
(WebCore::XPath::Value::Data::Data):
* Source/WebCore/xml/XPathVariableReference.h:

Canonical link: https://commits.webkit.org/279506@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d24496: Move all CacheStorageConnection callbacks to Nativ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d244968bca644b6ae5f293054c1c1ba757cef5a2
  
https://github.com/WebKit/WebKit/commit/d244968bca644b6ae5f293054c1c1ba757cef5a2
  Author: Youenn Fablet 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/Modules/cache/CacheStorageConnection.h
M Source/WebCore/Modules/cache/DOMCache.cpp
M Source/WebCore/Modules/cache/DOMCacheEngine.h
M Source/WebCore/Modules/cache/DOMCacheStorage.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp
M Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/page/CacheStorageProvider.h
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/workers/WorkerGlobalScope.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h

  Log Message:
  ---
  Move all CacheStorageConnection callbacks to NativePromise
https://bugs.webkit.org/show_bug.cgi?id=274726
rdar://128755510

Reviewed by Jean-Yves Avenard and Sihui Liu.

We move from completion handlers to native promise as a simplification.
We introduce a new enqueueTaskWhenSettled version that can take completion 
handler and a finalizer.
Covered by existing tests.

* Source/WebCore/Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::clearMemoryRepresentation):
(WebCore::CacheStorageConnection::engineRepresentation):
* Source/WebCore/Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::queryCache):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):
* Source/WebCore/Modules/cache/DOMCacheEngine.h:
* Source/WebCore/Modules/cache/DOMCacheStorage.cpp:
(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::doOpen):
(WebCore::DOMCacheStorage::doRemove):
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::retrieveCaches):
(WebCore::WorkerCacheStorageConnection::retrieveRecords):
(WebCore::WorkerCacheStorageConnection::batchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::batchPutOperation):
(WebCore::WorkerCacheStorageConnection::retrieveCachesCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::retrieveRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::deleteRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::putRecordsCompleted): Deleted.
(WebCore::WorkerCacheStorageConnection::clearPendingRequests): Deleted.
* Source/WebCore/Modules/cache/WorkerCacheStorageConnection.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::enqueueTaskWhenSettled):
* Source/WebCore/page/CacheStorageProvider.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::clearCacheStorageMemoryRepresentation):
(WebCore::Internals::cacheStorageEngineRepresentation):
* Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::prepareForDestruction):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::retrieveCaches):
(WebKit::WebCacheStorageConnection::retrieveRecords):
(WebKit::WebCacheStorageConnection::batchDeleteOperation):
(WebKit::WebCacheStorageConnection::batchPutOperation):
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
(WebKit::WebCacheStorageConnection::engineRepresentation):
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.h:

Canonical link: https://commits.webkit.org/279505@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] adc45c: Fix !ENABLE(MODERN_MEDIA_CONTROLS) build following...

[Ross Kirsling]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adc45c7a7123592ff48f69f77fcc8a448cc42e36
  
https://github.com/WebKit/WebKit/commit/adc45c7a7123592ff48f69f77fcc8a448cc42e36
  Author: Ross Kirsling 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp

  Log Message:
  ---
  Fix !ENABLE(MODERN_MEDIA_CONTROLS) build following 279471@main
https://bugs.webkit.org/show_bug.cgi?id=274891

Unreviewed build fix.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::supportsRewind const):

Canonical link: https://commits.webkit.org/279504@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a43717: [JSC] `Intl.DurationFormat#resolvedOptions().fract...

[SUZUKI Sosuke]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a43717459fdb2af1b6dee3dbdb68488943c17710
  
https://github.com/WebKit/WebKit/commit/a43717459fdb2af1b6dee3dbdb68488943c17710
  Author: Sosuke Suzuki 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
A JSTests/stress/intl-durationformat-fractionaldigits-undefined.js
M JSTests/stress/intl-durationformat.js
M JSTests/test262/expectations.yaml
M Source/JavaScriptCore/runtime/IntlDurationFormat.cpp

  Log Message:
  ---
  [JSC] `Intl.DurationFormat#resolvedOptions().fractionalDigits` should be 
`undefined` if `fractionalDigits` is `undefined`.
https://bugs.webkit.org/show_bug.cgi?id=274733

Reviewed by Ross Kirsling.

According to the spec[1], when creating a `DurationFormat` instance with
`new Intl.DurationFormat(locales, { fractionalDigits: undefined });`,
`Intl.DurationFormat#resolvedOptions().fractionalDigits` should be `undefined`. 
However, in the
current JSC, it is `0`. This was occurring because, according to the spec[2], 
the
`fallback` argument of the `GetNumberOption` abstract operation should be 
`undefined`, but we were
passing `0`.

This patch makes the following changes:

- Pass `numeric_limits::max()`, representing `undefined`, to the 
`fallback` argument of
the `intlNumberOption`
function, which corresponds to the `GetNumberOption` abstract operation, when 
initializing
`DurationFormat` instances.
- In the `DurationFormat#resolvedOption` function, set the `fractionalDigits` 
field to
`jsUndefined()` if `m_fractionalDigits` is `numeric_limits::max()`.

[1]: 
https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.prototype.resolvedOptions
[2]: https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat

* JSTests/stress/intl-durationformat-fractionaldigits-undefined.js: Added.
(shouldBe):
* JSTests/stress/intl-durationformat.js:
(test):
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/IntlDurationFormat.cpp:
(JSC::IntlDurationFormat::initializeDurationFormat):
(JSC::collectElements):
(JSC::IntlDurationFormat::resolvedOptions const):

Canonical link: https://commits.webkit.org/279503@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ea41c4: Digital credentials API should be tested for non-f...

[Marcos Cáceres]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea41c4b338ed40e45bc65ede49fdd3593cd6fb32
  
https://github.com/WebKit/WebKit/commit/ea41c4b338ed40e45bc65ede49fdd3593cd6fb32
  Author: Marcos Caceres 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt
A 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M LayoutTests/platform/wincairo/TestExpectations

  Log Message:
  ---
  Digital credentials API should be tested for non-fully active docs
https://bugs.webkit.org/show_bug.cgi?id=274763
rdar://128827081

Reviewed by Anne van Kesteren.

Tests Digital Credentials API against a non-fully active document.

* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https-expected.txt:
 Added.
* 
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html:
 Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:

Canonical link: https://commits.webkit.org/279502@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 659d03: Add libbacktrace support to JSCOnly port

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 659d0385e3f6c2dfba598d8ee3d4b776758e831f
  
https://github.com/WebKit/WebKit/commit/659d0385e3f6c2dfba598d8ee3d4b776758e831f
  Author: Justin Michaud 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
M Source/JavaScriptCore/PlatformJSCOnly.cmake
M Source/WTF/wtf/PlatformJSCOnly.cmake
M Source/cmake/OptionsJSCOnly.cmake

  Log Message:
  ---
  Add libbacktrace support to JSCOnly port
https://bugs.webkit.org/show_bug.cgi?id=273770

Reviewed by Yusuke Suzuki, Elliott Williams and Carlos Alberto Lopez Perez.

This makes WTFReportBacktrace() work properly, and matches the WPE and GTK 
ports.

* Source/JavaScriptCore/PlatformJSCOnly.cmake:
* Source/WTF/wtf/PlatformJSCOnly.cmake:
* Source/cmake/OptionsJSCOnly.cmake:

Canonical link: https://commits.webkit.org/279501@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 44fbc6: Unreviewed, reverting 279411@main.

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44fbc63c53dc3203ba35fd698c964c24285b9a67
  
https://github.com/WebKit/WebKit/commit/44fbc63c53dc3203ba35fd698c964c24285b9a67
  Author: Commit Queue 
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
R LayoutTests/fast/css/link-style-color-invalidation-expected.html
R LayoutTests/fast/css/link-style-color-invalidation.html
M LayoutTests/platform/ios/TestExpectations
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  ---
  Unreviewed, reverting 279411@main.
https://bugs.webkit.org/show_bug.cgi?id=274889

This is not correct

Reverted changeset:

"[CSS] Fix link invalidation when color depends on the visited style"
https://bugs.webkit.org/show_bug.cgi?id=61697
https://commits.webkit.org/279411@main

Canonical link: https://commits.webkit.org/279500@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes