[webkit-changes] [WebKit/WebKit] 098c58: Drop CachePayload::data() in favor of span()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 098c58dd13bf40fc81971361162e21d05cb1f74a https://github.com/WebKit/WebKit/commit/098c58dd13bf40fc81971361162e21d05cb1f74a Author: Chris Dumez Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/JavaScriptCore/runtime/CachePayload.h M Source/JavaScriptCore/runtime/CachedBytecode.h M Source/JavaScriptCore/runtime/CachedTypes.cpp Log Message: --- Drop CachePayload::data() in favor of span() https://bugs.webkit.org/show_bug.cgi?id=276051 Reviewed by Darin Adler. * Source/JavaScriptCore/runtime/CachePayload.h: * Source/JavaScriptCore/runtime/CachedBytecode.h: (JSC::CachedBytecode::span const): (JSC::CachedBytecode::data const): Deleted. * Source/JavaScriptCore/runtime/CachedTypes.cpp: (JSC::Decoder::offsetOf): (JSC::Decoder::ptrForOffsetFromBase): (JSC::decodeCodeBlockImpl): (JSC::isCachedBytecodeStillValid): Canonical link: https://commits.webkit.org/280565@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e65507: Remove code guarded by USE_CTFONTHASTABLE
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e655079064af83588a5c9021d7ff449ba86da050 https://github.com/WebKit/WebKit/commit/e655079064af83588a5c9021d7ff449ba86da050 Author: Vitor Roriz Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/platform/graphics/Font.h M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp Log Message: --- Remove code guarded by USE_CTFONTHASTABLE https://bugs.webkit.org/show_bug.cgi?id=276104 rdar://130928732 Reviewed by Brent Fulgham. We no longer need this since USE(CTFONTHASTABLE) is always true for our builds now. We are also removing the wrapper `fontHasTable` as it is now exactly what the lower level CT function `fontHasTable` does. Wrapping seems unnecessary as the function is just used locally and if any unlikely change would occur with the CT API it would be fairly simple to update it. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/platform/graphics/Font.h: * Source/WebCore/platform/graphics/coretext/FontCoreText.cpp: (WebCore::fontHasEitherTable): (WebCore::Font::platformInit): (WebCore::fontHasTable): Deleted. Canonical link: https://commits.webkit.org/280564@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8802ee: SEGV YarrJIT.h:350:28 (275528)
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8802eec90fd42545b18c5008dd3733cae9092499 https://github.com/WebKit/WebKit/commit/8802eec90fd42545b18c5008dd3733cae9092499 Author: Michael Saboff Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A JSTests/stress/regexp-backreference-dangling-surrogate.js M Source/JavaScriptCore/yarr/YarrInterpreter.cpp M Source/JavaScriptCore/yarr/YarrJIT.cpp Log Message: --- SEGV YarrJIT.h:350:28 (275528) https://bugs.webkit.org/show_bug.cgi?id=275528 rdar://129910892 Reviewed by Yusuke Suzuki. When we read a dangling surrogate, it reads as the sentinel -1. This sentinel value should always fail to match anything. When processing a backreference in an ignore case RegExp compiled for 16-bit strings, we case fold by calling out to the function areCanonicallyEquivalent(), passing a character from the referenced capture and the corresponding character in the backreference atom. We were not checking the case where either character was the -1 sentinel for a dangling surrogate. Added these checks in both the interpreter and JIT code. Found and fixed a bug in the JIT code where we increment the character pointers for non-BMP characters. We were reusing the result register from the areCanonicallyEquivalent() result to see if we read a non-BMP. Fixed this to use the other character argument, that is in a callee saved register. Added a new regression test. * JSTests/stress/regexp-backreference-dangling-surrogate.js: Added. (arrayToString): (objectToString): (dumpValue): (compareArray): (compareGroups): (testRegExp): (testRegExpSyntaxError): * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::InputStream::reread): (JSC::Yarr::Interpreter::tryConsumeBackReference): * Source/JavaScriptCore/yarr/YarrJIT.cpp: (JSC::Yarr::areCanonicallyEquivalentThunkGenerator): Canonical link: https://commits.webkit.org/280563@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb03da: [macOS] Disable shadows for `NSWindow`s created fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb03da83a2a9e1f542ec8988711bd56f1a47e618 https://github.com/WebKit/WebKit/commit/fb03da83a2a9e1f542ec8988711bd56f1a47e618 Author: Aditya Keerthi Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm Log Message: --- [macOS] Disable shadows for `NSWindow`s created for testing https://bugs.webkit.org/show_bug.cgi?id=276099 rdar://130925395 Reviewed by Richard Robinson and Abrar Rahman Protyasha. Due to a regression in another component, shadows are causing issues running tests on recent macOS builds. `NSWindow` shadows are unnecessary for testing as frameless windows are used. Simply remove them. * Tools/TestWebKitAPI/cocoa/TestWKWebView.mm: (-[TestWKWebView _setUpTestWindow:]): * Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::PlatformWebView): Canonical link: https://commits.webkit.org/280562@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55758c: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55758c85d2e45076d32887f652b6c338867bfa7e https://github.com/WebKit/WebKit/commit/55758c85d2e45076d32887f652b6c338867bfa7e Author: Fujii Hironori Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/280561@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 868193: [iOS] Several editing-related layout tests are fla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 868193b30419dc7d9692914ca3f8f30a7f66d16e https://github.com/WebKit/WebKit/commit/868193b30419dc7d9692914ca3f8f30a7f66d16e Author: Wenson Hsieh Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/editing/selection/ios/change-selection-by-tapping.html M LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm Log Message: --- [iOS] Several editing-related layout tests are flaky on x86_64 simulator https://bugs.webkit.org/show_bug.cgi?id=276101 rdar://130607129 Reviewed by Megan Gardner. For reasons that are still unknown, keyboard autocorrection triggers very aggressively on selection changes when both of the following conditions are true: 1. Running tests in iOS simulator on an Intel (x86_64) host machine. 2. The iOS simulator was newly created (e.g. using `xcrun simctl create`). This causes the following two tests to fail… • editing/selection/ios/change-selection-by-tapping.html This test fails because `can't` is autocorrected to `can’t` (with an apostrophe instead of a straight quote), leading to a text diff. • editing/selection/ios/show-grammar-replacements-on-tap.html This test fails because `thing` is "autocorrected" to `thing` immediately upon tapping to change the selection, which triggers an editing command that clears the grammar markers underneath the word. • fast/events/ios/key-command-delete-to-end-of-paragraph.html It's actually unclear why this test is failing, due to the fact that I was unable to reproduce this at all in any configuration. Keep these tests passing by making a couple of minor adjustments: * LayoutTests/editing/selection/ios/change-selection-by-tapping.html: * LayoutTests/fast/events/ios/key-command-delete-to-end-of-paragraph.html: Force `spellcheck="false"` here to prevent correction from triggering when simulating selection changes. * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::applyAutocorrectionInternal): Return early if the original and new strings are identical, to prevent editing commands from triggering (which blow away the grammar markers in `show-grammar-replacements-on-tap.html`). Canonical link: https://commits.webkit.org/280560@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46ec36: Revert 280405@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46ec369cc87cbbfdd6f5ac8efd956bcac0735f94 https://github.com/WebKit/WebKit/commit/46ec369cc87cbbfdd6f5ac8efd956bcac0735f94 Author: Charlie Wolfe Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/WKPagePrivate.h M Source/WebKit/UIProcess/WebPageProxyTesting.cpp M Source/WebKit/UIProcess/WebPageProxyTesting.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp M Source/WebKit/WebProcess/WebPage/WebPageTesting.h M Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in M Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp M Tools/WebKitTestRunner/TestController.cpp Log Message: --- Revert 280405@main https://bugs.webkit.org/show_bug.cgi?id=276095 rdar://130922657 Unreviewed. Caused flaky test failures. * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageFlushDeferredDidReceiveMouseEventForTesting): Deleted. * Source/WebKit/UIProcess/API/C/WKPagePrivate.h: * Source/WebKit/UIProcess/WebPageProxyTesting.cpp: (WebKit::WebPageProxyTesting::flushDeferredDidReceiveMouseEvent): Deleted. * Source/WebKit/UIProcess/WebPageProxyTesting.h: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageFlushDeferredDidReceiveMouseEventForTesting): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h: * Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp: (WebKit::WebPageTesting::flushDeferredDidReceiveMouseEvent): Deleted. * Source/WebKit/WebProcess/WebPage/WebPageTesting.h: * Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in: * Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp: (WTR::EventSendingController::mouseMoveTo): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Canonical link: https://commits.webkit.org/280559@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a36845: [Site Isolation] Avoid skipping code on out-of-pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a368459ce9a9e6b637a366dd90ba655f57031e23 https://github.com/WebKit/WebKit/commit/a368459ce9a9e6b637a366dd90ba655f57031e23 Author: Charlie Wolfe Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/css/query/MediaQueryFeatures.cpp M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/InspectorOverlay.cpp M Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp M Source/WebCore/inspector/agents/InspectorTimelineAgent.h M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/NavigationScheduler.cpp M Source/WebCore/page/Chrome.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/page/PageConsoleClient.cpp M Source/WebCore/page/ResourceUsageOverlay.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp Log Message: --- [Site Isolation] Avoid skipping code on out-of-process frames in more places https://bugs.webkit.org/show_bug.cgi?id=276020 rdar://130784398 Reviewed by Sihui Liu and Alex Christensen. * Source/WebCore/css/query/MediaQueryFeatures.cpp: (WebCore::MQ::Features::colorGamut): * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::mainDocumentRegistrableDomainForPCM const): * Source/WebCore/inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleTimeStampImpl): * Source/WebCore/inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didCompleteRenderingFrame): (WebCore::InspectorInstrumentation::takeHeapSnapshot): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::logConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleTimeStamp): * Source/WebCore/inspector/InspectorOverlay.cpp: (WebCore::InspectorOverlay::drawBounds): (WebCore::InspectorOverlay::drawElementTitle): * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didTimeStamp): (WebCore::InspectorTimelineAgent::time): (WebCore::InspectorTimelineAgent::timeEnd): (WebCore::InspectorTimelineAgent::didPerformanceMark): (WebCore::InspectorTimelineAgent::setFrameIdentifier): (WebCore::InspectorTimelineAgent::appendRecord): * Source/WebCore/inspector/agents/InspectorTimelineAgent.h: * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::disallowWebArchive const): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): * Source/WebCore/loader/NavigationScheduler.cpp: * Source/WebCore/page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::didAccessWindowProxyPropertyViaOpener): * Source/WebCore/page/Page.cpp: (WebCore::Page::windowScreenDidChange): (WebCore::Page::didCompleteRenderingFrame): (WebCore::Page::setSessionID): (WebCore::dispatchPrintEvent): (WebCore::Page::dispatchBeforePrintEvent): (WebCore::Page::dispatchAfterPrintEvent): * Source/WebCore/page/PageConsoleClient.cpp: (WebCore::PageConsoleClient::takeHeapSnapshot): (WebCore::PageConsoleClient::time): (WebCore::PageConsoleClient::timeLog): (WebCore::PageConsoleClient::timeEnd): (WebCore::PageConsoleClient::timeStamp): * Source/WebCore/page/ResourceUsageOverlay.cpp: (WebCore::ResourceUsageOverlay::initialize): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidScroll): Canonical link: https://commits.webkit.org/280558@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 33c1f1: ReportingObserverCallbacks can leak the Document o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33c1f1877fa266b544427d68f05d3e33e7a027f4 https://github.com/WebKit/WebKit/commit/33c1f1877fa266b544427d68f05d3e33e7a027f4 Author: Ryan Reno Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A LayoutTests/fast/reporting/reporting-observer-callback-does-not-leak-expected.txt A LayoutTests/fast/reporting/reporting-observer-callback-does-not-leak.html A LayoutTests/fast/reporting/resources/reporting-observer-with-callback.html M Source/WebCore/Modules/reporting/ReportingObserver.cpp M Source/WebCore/Modules/reporting/ReportingObserver.h M Source/WebCore/Modules/reporting/ReportingObserver.idl M Source/WebCore/Modules/reporting/ReportingObserverCallback.h M Source/WebCore/Modules/reporting/ReportingObserverCallback.idl M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/bindings/js/JSReportingObserverCustom.cpp Log Message: --- ReportingObserverCallbacks can leak the Document object https://bugs.webkit.org/show_bug.cgi?id=276080 rdar://130908426 Reviewed by Ryosuke Niwa. By default callbacks are held as JSC::Strong handles. This creates a GC Root which will keep anything captured in the callback function alive. On sites like britannica.com, many documents are captured in this way and lead to memory leaks. This patch makes ReportingObserverCallback Weak and keeps the callback wrapper alive via ReportingObserver's visitAdditionalChildren. * LayoutTests/fast/reporting/reporting-observer-callback-does-not-leak-expected.txt: Added. * LayoutTests/fast/reporting/reporting-observer-callback-does-not-leak.html: Added. * LayoutTests/fast/reporting/resources/reporting-observer-with-callback.html: Added. * Source/WebCore/Modules/reporting/ReportingObserver.cpp: (WebCore::ReportingObserver::callbackConcurrently): * Source/WebCore/Modules/reporting/ReportingObserver.h: * Source/WebCore/Modules/reporting/ReportingObserver.idl: * Source/WebCore/Modules/reporting/ReportingObserverCallback.h: * Source/WebCore/Modules/reporting/ReportingObserverCallback.idl: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSReportingObserverCustom.cpp: Added. (WebCore::JSReportingObserver::visitAdditionalChildren): Canonical link: https://commits.webkit.org/280557@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 745d34: [WPE][cross-toolchain-helper] Fix issue with the i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 745d34f6850a4932596574036359e6aa5a8189cc https://github.com/WebKit/WebKit/commit/745d34f6850a4932596574036359e6aa5a8189cc Author: Carlos Alberto Lopez Perez Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Tools/yocto/meta-openembedded_and_meta-webkit.patch Log Message: --- [WPE][cross-toolchain-helper] Fix issue with the icu installation and long paths https://bugs.webkit.org/show_bug.cgi?id=276098 Unreviewed follow-up build-fix after 280438@main There is a bug icu that causes libicu to be installed incorrectly when the build system uses long paths (around 500 or more chars). This caused that nodejs couldn't run properly on the bots because icu was unproperly installed, making the Chromium build fail (which we try to build since 280438@main) * Tools/yocto/meta-openembedded_and_meta-webkit.patch: Canonical link: https://commits.webkit.org/280556@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c7764: CRASH in HTMLMediaElement::setSpatialTrackingLabel()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c7764ee7e56f52d44ef86f557b1ec09d7f8c999 https://github.com/WebKit/WebKit/commit/6c7764ee7e56f52d44ef86f557b1ec09d7f8c999 Author: Jer Noble Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- CRASH in HTMLMediaElement::setSpatialTrackingLabel() https://bugs.webkit.org/show_bug.cgi?id=276091 rdar://130719077 Reviewed by Andy Estes. Add a null-check to m_player before dereferencing. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setSpatialTrackingLabel): Canonical link: https://commits.webkit.org/280555@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 36f383: [WebVTT] Cues should use white-space:pre-line
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36f38359156a0215fa0147c38f6c2e62e745bd89 https://github.com/WebKit/WebKit/commit/36f38359156a0215fa0147c38f6c2e62e745bd89 Author: Jer Noble Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/README.md A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering-expected.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.webvtt A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.m4a A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.mp3 A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/resources/reference.css A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/resources/webvtt-rendering-test.js A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line-expected.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.html A LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.webvtt M LayoutTests/platform/glib/TestExpectations M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css M Source/WebCore/css/mediaControls.css Log Message: --- [WebVTT] Cues should use white-space:pre-line https://bugs.webkit.org/show_bug.cgi?id=275616 rdar://130084169 Reviewed by Eric Carlson. The WebVTT spec requires: > 7.4. Applying CSS properties to WebVTT Node Objects: > The white-space property on the (root) list of WebVTT Node Objects must be > set to pre-line. [CSS22] Update our default styles for cues to use this value for `white-space:`. Add WPT reference tests to verify the change. The test uses `mix-blend-mode` to combine the actual rendering and the expected rendering into a green result. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/README.md: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/basic-cue-rendering.webvtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.m4a: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/content/silence.mp3: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/reference.css: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/rendering/white-space-pre-line.webvtt: Added. * Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css: (::-webkit-media-text-track-display): * Source/WebCore/css/mediaControls.css: (video::-webkit-media-text-track-display): Canonical link: https://commits.webkit.org/280554@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fccea: Remove and replace `WKBundleFrameClearOpener`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fccea83e22310b46704369e74dee277c7e8ff93 https://github.com/WebKit/WebKit/commit/1fccea83e22310b46704369e74dee277c7e8ff93 Author: Charlie Wolfe Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/WKPagePrivate.h M Source/WebKit/UIProcess/WebPageProxyTesting.cpp M Source/WebKit/UIProcess/WebPageProxyTesting.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp M Source/WebKit/WebProcess/WebPage/WebPageTesting.h M Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in M Source/WebKit/mac/WebKit2.order M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestInvocation.cpp Log Message: --- Remove and replace `WKBundleFrameClearOpener` https://bugs.webkit.org/show_bug.cgi?id=276052 rdar://130867827 Reviewed by Alex Christensen. * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageClearOpenerForTesting): * Source/WebKit/UIProcess/API/C/WKPagePrivate.h: * Source/WebKit/UIProcess/WebPageProxyTesting.cpp: (WebKit::WebPageProxyTesting::flushDeferredDidReceiveMouseEvent): (WebKit::WebPageProxyTesting::clearOpener): * Source/WebKit/UIProcess/WebPageProxyTesting.h: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: * Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp: (WebKit::WebPageTesting::clearOpener): * Source/WebKit/WebProcess/WebPage/WebPageTesting.h: * Source/WebKit/WebProcess/WebPage/WebPageTesting.messages.in: * Source/WebKit/mac/WebKit2.order: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke): Canonical link: https://commits.webkit.org/280553@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a4379: grid-within-flexbox-indefinite.html now passing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a437945ebe2ebb453219f6a4d24f32a038a223c https://github.com/WebKit/WebKit/commit/3a437945ebe2ebb453219f6a4d24f32a038a223c Author: Brandon Stewart Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/TestExpectations Log Message: --- grid-within-flexbox-indefinite.html now passing https://bugs.webkit.org/show_bug.cgi?id=276077 rdar://problem/130903429 Reviewed by Sammy Gill. Test case was passing now when running layout tests. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/280552@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d9d0b: REGRESSION(279794@main): [Win] The viewport doesn'...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d9d0b8a3afea43c607d5a7fa4284c05235cf673 https://github.com/WebKit/WebKit/commit/8d9d0b8a3afea43c607d5a7fa4284c05235cf673 Author: Fujii Hironori Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp Log Message: --- REGRESSION(279794@main): [Win] The viewport doesn't fit into the window in non-GPU process mode https://bugs.webkit.org/show_bug.cgi?id=275845 Reviewed by Don Olmstead. Windows WebKit is still supporting non-GPU process mode for Playwright. After https://commits.webkit.org/279794@main added device scale factor support to GraphicsLayerWC for GPU process mode, the viewport didn't fit into the window for non-GPU process mode, The viewport should be adjusted for GraphicsLayerTextureMapper. * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp: Canonical link: https://commits.webkit.org/280551@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79ffef: Remove remaining code guarded by USE_KCTFONTVARIAT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79ffefa41f392abfca4c210d2ae0e526b2a24f11 https://github.com/WebKit/WebKit/commit/79ffefa41f392abfca4c210d2ae0e526b2a24f11 Author: Vitor Roriz Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Log Message: --- Remove remaining code guarded by USE_KCTFONTVARIATIONAXESATTRIBUTE https://bugs.webkit.org/show_bug.cgi?id=275976 rdar://130715334 Reviewed by Brent Fulgham and Alex Christensen. We no longer need this since USE_KCTFONTVARIATIONAXESATTRIBUTE is always true for our builds now. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::variationCapabilitiesForFontDescriptor): Canonical link: https://commits.webkit.org/280550@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f89085: Import css/css-viewport WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8908598724972f1589395ed904246dd0b0197c1 https://github.com/WebKit/WebKit/commit/f8908598724972f1589395ed904246dd0b0197c1 Author: Tim Nguyen Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/META.yml A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/computedStyle-zoom-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/computedStyle-zoom.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/width-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/width-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/width.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/background-image-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/background-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/background-image.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/basic-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/basic-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/basic.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/border-spacing-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/border-spacing.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/font-size-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/font-size-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/font-size.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/green-square-100px.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom-nested.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom.sub-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/iframe-zoom.sub.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/image-intrinsic-size-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/image-intrinsic-size.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/inherited-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/inherited-length-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/inherited-length.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/inherited.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/letter-spacing-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/letter-spacing.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/line-height.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/list-style-image-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/list-style-image.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/parsing/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/parsing/zoom-computed-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/parsing/zoom-computed.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/parsing/zoom-valid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/parsing/zoom-valid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/border-spacing-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/iframe-zoom-nested-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/iframe-zoom-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/letter-spacing-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/list-style-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/stroke-ref.html A
[webkit-changes] [WebKit/WebKit] a08ea8: GARDENING: REGRESSION (iOS 17.5?): [ iOS Debug ] 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a08ea83df0e6de959808f45773bccbf77c835599 https://github.com/WebKit/WebKit/commit/a08ea83df0e6de959808f45773bccbf77c835599 Author: Ben Schwartz Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations Log Message: --- GARDENING: REGRESSION (iOS 17.5?): [ iOS Debug ] 2 fast/events/ios/key-events-comprehensive/* tests are constantly failing. https://bugs.webkit.org/show_bug.cgi?id=276092 rdar://130915383 Unreviewed test gardening. Filing bug for pre-existing test failures. * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/280548@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f84cb: [JSC] Inline hot part of op_enter in Baseline JIT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f84cbe944f64a1b34715c0257d9cfed5bdefc9f https://github.com/WebKit/WebKit/commit/8f84cbe944f64a1b34715c0257d9cfed5bdefc9f Author: Yusuke Suzuki Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/JavaScriptCore/bytecode/CodeBlock.cpp M Source/JavaScriptCore/bytecode/CodeBlock.h M Source/JavaScriptCore/jit/AssemblyHelpers.h M Source/JavaScriptCore/jit/BaselineJITRegisters.h M Source/JavaScriptCore/jit/JITOpcodes.cpp M Source/JavaScriptCore/jit/JITOperations.cpp M Source/JavaScriptCore/runtime/VM.h M Source/JavaScriptCore/runtime/VMTraps.h Log Message: --- [JSC] Inline hot part of op_enter in Baseline JIT https://bugs.webkit.org/show_bug.cgi?id=276060 rdar://130879769 Reviewed by Yijia Huang. Our new profiling identified that op_enter thunk call in Baseline JIT is too costly. As the result of collecting data, we found that most of # of variables is very small. So we should take fast-path-slow-path approach here. We inline fast path part in Baseline JIT code, and jumping to the generic slow thunk when we found it hits the slow case. * Source/JavaScriptCore/bytecode/CodeBlock.cpp: (JSC::CodeBlock::capabilityLevel): * Source/JavaScriptCore/bytecode/CodeBlock.h: (JSC::CodeBlock::offsetOfVM): * Source/JavaScriptCore/jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::branchIfBarriered): * Source/JavaScriptCore/jit/BaselineJITRegisters.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter): (JSC::JIT::op_enter_handlerGenerator): (JSC::JIT::emitSlow_op_enter): * Source/JavaScriptCore/jit/JITOperations.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/runtime/VM.h: (JSC::VM::offsetOfTrapsBits): * Source/JavaScriptCore/runtime/VMTraps.h: (JSC::VMTraps::offsetOfTrapsBits): Canonical link: https://commits.webkit.org/280547@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ba958: Unreviewed, reverting 280485@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ba958925667426fec9e6ddad9169d296aa4836a https://github.com/WebKit/WebKit/commit/8ba958925667426fec9e6ddad9169d296aa4836a Author: Commit Queue Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M JSTests/microbenchmarks/wasm-cc-int-to-int.js M JSTests/wasm/lowExecutableMemory/executable-memory-oom.js R JSTests/wasm/stress/cc-double-to-double.js R JSTests/wasm/stress/cc-f32-kitchen-sink.js R JSTests/wasm/stress/cc-float-to-float.js R JSTests/wasm/stress/cc-i32-kitchen-sink-neg.js M JSTests/wasm/stress/cc-i32-kitchen-sink.js R JSTests/wasm/stress/cc-i64-kitchen-sink-neg.js R JSTests/wasm/stress/cc-i64-kitchen-sink.js M JSTests/wasm/stress/cc-int-to-int-cross-module-with-exception.js M JSTests/wasm/stress/cc-int-to-int-cross-module.js M JSTests/wasm/stress/cc-int-to-int-jit-to-llint.js M JSTests/wasm/stress/cc-int-to-int-memory.js M JSTests/wasm/stress/cc-int-to-int-no-jit.js M JSTests/wasm/stress/cc-int-to-int-tail-call.js M JSTests/wasm/stress/cc-int-to-int.js M Source/JavaScriptCore/interpreter/CallFrame.h M Source/JavaScriptCore/interpreter/CallFrameInlines.h M Source/JavaScriptCore/jit/FPRInfo.h M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/llint/InPlaceInterpreter.cpp M Source/JavaScriptCore/llint/InPlaceInterpreter.h M Source/JavaScriptCore/llint/WebAssembly.asm M Source/JavaScriptCore/runtime/Options.cpp M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp M Source/JavaScriptCore/wasm/WasmCallee.cpp M Source/JavaScriptCore/wasm/WasmCallee.h M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp M Source/JavaScriptCore/wasm/WasmOMGPlan.h M Source/JavaScriptCore/wasm/WasmOperations.cpp M Source/JavaScriptCore/wasm/WasmOperations.h M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h Log Message: --- Unreviewed, reverting 280485@main. https://bugs.webkit.org/show_bug.cgi?id=276085 Broke iOS wasm Reverted changeset: "Add operation-based jitless wasm entry thunk" https://bugs.webkit.org/show_bug.cgi?id=275397 https://commits.webkit.org/280485@main Canonical link: https://commits.webkit.org/280546@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5dfa6b: Unreviewed, small-pool is too small
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5dfa6b4e66a4440eee5b35e81117a870f02c4d81 https://github.com/WebKit/WebKit/commit/5dfa6b4e66a4440eee5b35e81117a870f02c4d81 Author: Yusuke Suzuki Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Tools/Scripts/run-jsc-stress-tests Log Message: --- Unreviewed, small-pool is too small https://bugs.webkit.org/show_bug.cgi?id=276084 rdar://130911205 small-pool configuration is too small and too fragile against how executable memory is allocated via libpas. We extend it to at least 1MB. * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/280545@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cc0631: Setting allowsContentJavaScript=NO does not show <...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cc0631f6705ab4beef5007a7e7965d4421b7b1b1 https://github.com/WebKit/WebKit/commit/cc0631f6705ab4beef5007a7e7965d4421b7b1b1 Author: Tim Horton Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/html/parser/HTMLParserOptions.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm Log Message: --- Setting allowsContentJavaScript=NO does not show elements https://bugs.webkit.org/show_bug.cgi?id=276037 rdar://130822453 Reviewed by Richard Robinson and Geoffrey Garen. * Source/WebCore/html/parser/HTMLParserOptions.cpp: (WebCore::HTMLParserOptions::HTMLParserOptions): Sites generally expect that if their script won't run, elements are inserted into the DOM. Some use this, for example, to insert style that hides elements that won't be populated by forthcoming changes from script. Previously, WebKit would insert elements if JavaScript was totally disabled, but not if it was disabled by the "disable content JavaScript" mechanism (which still allows the user agent to run script, just denies script from the page). However, given the overall purpose of is about script from the page, it seems prudent to insert contents in both cases. The scriptingFlag in the parser seems to only affect participation, so this minimal patch appears to do the trick without any unexpected downstream effects. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm: (TEST(WebKit, AllowsContentJavaScriptAffectsNoscriptElements)): Add a test that covers this behavior. Canonical link: https://commits.webkit.org/280544@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5f0104: Add style and layout interleaving for `anchor()`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5f0104f4e2cd965e5622fb88090d7425bc464801 https://github.com/WebKit/WebKit/commit/5f0104f4e2cd965e5622fb88090d7425bc464801 Author: David Choi Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/css/CSSAnchorValue.cpp M Source/WebCore/css/CSSAnchorValue.h M Source/WebCore/css/CSSPrimitiveValue.h M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/page/LocalFrameViewLayoutContext.cpp A Source/WebCore/style/AnchorPositionEvaluator.cpp A Source/WebCore/style/AnchorPositionEvaluator.h M Source/WebCore/style/MatchedDeclarationsCache.cpp M Source/WebCore/style/StyleBuilderConverter.h M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleScope.h M Source/WebCore/style/StyleTreeResolver.cpp M Source/WebCore/style/StyleTreeResolver.h Log Message: --- Add style and layout interleaving for `anchor()` https://bugs.webkit.org/show_bug.cgi?id=275938 rdar://130642534 Reviewed by Antti Koivisto. This patch introduces an initial implementation of style and layout interleaving for anchor positioning. For each anchor-positioned element, we perform a layout to get its containing block, then bounce back to style resolution to determine its anchors, and then finally attempt to resolve the element with another style resolution. The actual resolution of `anchor()` is not implemented yet, (this patch is a precursor for its implementation). As a result, there are no behavioral changes. This patch also is not fully spec-compliant when finding anchors for each anchor-positioned element. It only attempts to find the last anchor element in tree order with a matching anchor name. Further patches will build on this patch to correctly determine anchors and actually resolve anchor-positioned elements. * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/css/CSSAnchorValue.cpp: (WebCore::CSSAnchorValue::collectAnchorNames const): * Source/WebCore/css/CSSAnchorValue.h: * Source/WebCore/css/CSSPrimitiveValue.h: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeAnchor): * Source/WebCore/dom/Document.cpp: (WebCore::Document::resolveStyle): (WebCore::Document::isInStyleInterleavedLayoutForSelfOrAncestor const): * Source/WebCore/dom/Document.h: (WebCore::Document::isInStyleInterleavedLayout const): * Source/WebCore/dom/Element.cpp: (WebCore::Element::invalidateAncestorsForAnchor): (WebCore::Element::invalidateForResumingAnchorPositionedElementResolution): * Source/WebCore/dom/Element.h: * Source/WebCore/page/LocalFrameViewLayoutContext.cpp: (WebCore::LocalFrameViewLayoutContext::performLayout): (WebCore::LocalFrameViewLayoutContext::runOrScheduleAsynchronousTasks): * Source/WebCore/style/AnchorPositionEvaluator.cpp: Added. (WebCore::Style::AnchorPositionEvaluator::resolveAnchorValue): * Source/WebCore/style/AnchorPositionEvaluator.h: Added. * Source/WebCore/style/MatchedDeclarationsCache.cpp: (WebCore::Style::MatchedDeclarationsCache::isCacheable): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertLength): * Source/WebCore/style/StyleResolver.cpp: * Source/WebCore/style/StyleScope.h: * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::popParent): (WebCore::Style::TreeResolver::resolveComposedTree): (WebCore::Style::TreeResolver::resolve): (WebCore::Style::TreeResolver::updateAnchorPositioningState): (WebCore::Style::TreeResolver::findAnchorsForAnchorPositionedElement): (WebCore::Style::elementIsInContainingBlockChain): (WebCore::Style::TreeResolver::findLastAcceptableAnchorWithName): (WebCore::Style::TreeResolver::updateAnchorPositioningStateInInitialContainingBlock): * Source/WebCore/style/StyleTreeResolver.h: (WebCore::Style::TreeResolver::hasUnresolvedAnchorPositionedElements const): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm: Canonical link: https://commits.webkit.org/280543@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4cf517: [Writing Tools] Quoted text in emails is rewritten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4cf517d5ce5eec2f7df269c82e6c6bb24d348265 https://github.com/WebKit/WebKit/commit/4cf517d5ce5eec2f7df269c82e6c6bb24d348265 Author: Richard Robinson Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/editing/cocoa/HTMLConverter.h M Source/WebCore/editing/cocoa/HTMLConverter.mm M Source/WebCore/page/writing-tools/WritingToolsController.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm Log Message: --- [Writing Tools] Quoted text in emails is rewritten (should be excluded from modification) https://bugs.webkit.org/show_bug.cgi?id=276004 rdar://120563824 Reviewed by Abrar Rahman Protyasha. Add the `WTWritingToolsPreserved` attribute to the ranges corresponding to text enclosed in `blockquote` or `pre` tags, so that Writing Tools does not rewrite the content. * Source/WebCore/editing/cocoa/HTMLConverter.h: * Source/WebCore/editing/cocoa/HTMLConverter.mm: (hasAncestorQualifyingForWritingToolsPreservation): (WebCore::editingAttributedString): * Source/WebCore/page/writing-tools/WritingToolsController.mm: (WebCore::WritingToolsController::willBeginWritingToolsSession): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm: (TEST(WritingTools, BlockquoteAndPreContentsAreIgnored)): Canonical link: https://commits.webkit.org/280542@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e99576: Unreviewed, reverting 280514@main.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e995762d1abd06dd39a1b07b6ccebc33be15e16d https://github.com/WebKit/WebKit/commit/e995762d1abd06dd39a1b07b6ccebc33be15e16d Author: Commit Queue Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/Modules/webaudio/AudioBuffer.cpp M Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp M Source/WebCore/Modules/webaudio/AudioListener.cpp M Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp M Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp M Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp M Source/WebCore/Modules/webaudio/BiquadProcessor.cpp M Source/WebCore/Modules/webaudio/ConstantSourceNode.cpp M Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp M Source/WebCore/Modules/webaudio/GainNode.cpp M Source/WebCore/Modules/webaudio/IIRProcessor.cpp M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceCocoa.cpp M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceGStreamer.cpp M Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp M Source/WebCore/Modules/webaudio/OscillatorNode.cpp M Source/WebCore/Modules/webaudio/PeriodicWave.cpp M Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp M Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp M Source/WebCore/Modules/webaudio/StereoPannerNode.cpp M Source/WebCore/Modules/webaudio/WaveShaperDSPKernel.cpp M Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp M Source/WebCore/platform/audio/AudioArray.h M Source/WebCore/platform/audio/AudioBus.cpp M Source/WebCore/platform/audio/AudioChannel.cpp M Source/WebCore/platform/audio/AudioChannel.h M Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp M Source/WebCore/platform/audio/AudioResampler.cpp M Source/WebCore/platform/audio/AudioResamplerKernel.cpp M Source/WebCore/platform/audio/Biquad.cpp M Source/WebCore/platform/audio/DirectConvolver.cpp M Source/WebCore/platform/audio/DownSampler.cpp M Source/WebCore/platform/audio/DynamicsCompressor.cpp M Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp M Source/WebCore/platform/audio/EqualPowerPanner.cpp M Source/WebCore/platform/audio/FFTConvolver.cpp M Source/WebCore/platform/audio/FFTFrame.cpp M Source/WebCore/platform/audio/HRTFKernel.cpp M Source/WebCore/platform/audio/HRTFPanner.cpp M Source/WebCore/platform/audio/IIRFilter.cpp M Source/WebCore/platform/audio/MultiChannelResampler.cpp M Source/WebCore/platform/audio/PushPullFIFO.cpp M Source/WebCore/platform/audio/Reverb.cpp M Source/WebCore/platform/audio/ReverbAccumulationBuffer.cpp M Source/WebCore/platform/audio/ReverbConvolver.cpp M Source/WebCore/platform/audio/ReverbConvolverStage.cpp M Source/WebCore/platform/audio/ReverbInputBuffer.cpp M Source/WebCore/platform/audio/SincResampler.cpp M Source/WebCore/platform/audio/StereoPanner.cpp M Source/WebCore/platform/audio/UpSampler.cpp M Source/WebCore/platform/audio/cocoa/AudioFileReaderCocoa.cpp M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp M Source/WebCore/platform/audio/mac/FFTFrameMac.cpp M Source/WebCore/platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm M Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderCocoa.mm Log Message: --- Unreviewed, reverting 280514@main. https://bugs.webkit.org/show_bug.cgi?id=276078 Introduced crashes in WebAudio tests Reverted changeset: "Drop AudioArray::data() in favor of span()" https://bugs.webkit.org/show_bug.cgi?id=276036 https://commits.webkit.org/280514@main Canonical link: https://commits.webkit.org/280541@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da2348: REGRESSION(276827@main): Prevent BitmapImageSource...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da23487493c641fe1aaa8404321875beae95b65f https://github.com/WebKit/WebKit/commit/da23487493c641fe1aaa8404321875beae95b65f Author: Said Abou-Hallawa Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/BitmapImageSource.cpp Log Message: --- REGRESSION(276827@main): Prevent BitmapImageSource from accessing a null ImageDecoder https://bugs.webkit.org/show_bug.cgi?id=275999 rdar://129791964 Reviewed by Simon Fraser. Make BitmapImageSource more robust by checking m_decoder before accessing it. This was the behavior of the old BitmapImage/ImageSource code. * Source/WebCore/platform/graphics/BitmapImageSource.cpp: (WebCore::BitmapImageSource::encodedDataStatusChanged): (WebCore::BitmapImageSource::cacheMetadataAtIndex): (WebCore::BitmapImageSource::nativeImageAtIndexCacheIfNeeded): (WebCore::BitmapImageSource::nativeImageAtIndexRequestIfNeeded): Canonical link: https://commits.webkit.org/280540@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad131b: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad131bf6f3330df20887275c2d31967f8b2a9124 https://github.com/WebKit/WebKit/commit/ad131bf6f3330df20887275c2d31967f8b2a9124 Author: Russell Epstein Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7619.1.22 Canonical link: https://commits.webkit.org/280539@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63f111: [JSC] Use Data Call IC in FTL
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63f11147b08a7bacd245550e84ef886cde29a333 https://github.com/WebKit/WebKit/commit/63f11147b08a7bacd245550e84ef886cde29a333 Author: Yusuke Suzuki Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp M Source/JavaScriptCore/bytecode/CallLinkInfo.h M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/dfg/DFGJITCompiler.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/ftl/FTLState.cpp M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp M Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm Log Message: --- [JSC] Use Data Call IC in FTL https://bugs.webkit.org/show_bug.cgi?id=276000 rdar://130766372 Reviewed by Yijia Huang. This patch makes FTL always use Data IC for CallLinkInfo. As a result, now all calls use Data IC (except for DirectCallLinkInfo). In addition to simplify the implementation, it also unlocks CallLinkInfo's upgradeIfPossible feature for all code. * Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlinkOrUpgradeImpl): (JSC::CallLinkInfo::setMonomorphicCallee): (JSC::CallLinkInfo::clearCallee): (JSC::CallLinkInfo::revertCallToStub): (JSC::DataOnlyCallLinkInfo::initialize): (JSC::CallLinkInfo::setVirtualCall): (JSC::CallLinkInfo::setStub): (JSC::CallLinkInfo::emitFastPathImpl): (JSC::CallLinkInfo::emitDataICFastPath): (JSC::CallLinkInfo::emitTailCallDataICFastPath): (JSC::OptimizingCallLinkInfo::emitFastPath): (JSC::OptimizingCallLinkInfo::emitTailCallFastPath): * Source/JavaScriptCore/bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::offsetOfCodeBlock): (JSC::CallLinkInfo::offsetOfMonomorphicCallDestination): (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::isDataIC const): Deleted. (JSC::CallLinkInfo::useDataIC const): Deleted. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateAccessCase): (JSC::InlineCacheCompiler::emitProxyObjectAccess): * Source/JavaScriptCore/dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::addCallLinkInfo): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/ftl/FTLState.cpp: (JSC::FTL::State::addCallLinkInfo): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp: (JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine): (JSC::PolymorphicCallStubRoutine::upgradeIfPossible): * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.h: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: Canonical link: https://commits.webkit.org/280538@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d57feb: Remove uses of CTFontCopyVariationAxesInternal in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d57febaa8b2ff0ea3570d7330f6728b859df5b7b https://github.com/WebKit/WebKit/commit/d57febaa8b2ff0ea3570d7330f6728b859df5b7b Author: Vitor Roriz Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp Log Message: --- Remove uses of CTFontCopyVariationAxesInternal in favor of the official API https://bugs.webkit.org/show_bug.cgi?id=275977 rdar://130680716 Reviewed by Brent Fulgham. Since macOS 13.0 / iOS 16.00, we can get the variation axes with non localized axes names by reading the kCTFontVariationAxesAttribute from font's descriptor. We can now deprecate the SPI function. * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::variationAxesWithNonLocalizedAxesNames): (WebCore::variationAxes): (WebCore::variationCapabilitiesForFontDescriptor): Canonical link: https://commits.webkit.org/280537@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55ba16: [build.webkit.org] [GTK] Update GTK-Linux-64-bit-R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55ba16e6c14d720fd960396179e00dd5895b1cec https://github.com/WebKit/WebKit/commit/55ba16e6c14d720fd960396179e00dd5895b1cec Author: Diego Pino Garcia Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Tools/CISupport/build-webkit-org/config.json M Tools/CISupport/build-webkit-org/factories_unittest.py Log Message: --- [build.webkit.org] [GTK] Update GTK-Linux-64-bit-Release-Debian-11-Build bot after upgrade to GCC 11.2 https://bugs.webkit.org/show_bug.cgi?id=276073 Reviewed by Carlos Alberto Lopez Perez. After upgrade to GCC11.2, this bot is no longer in support. However, we'd like to keep it around since there's still many users on Debian 11. In order to keep the bot, it's necessary to switch C/CXX compiler to clang and provision minimal dependencies via JHBuild, since Debian 11 doesn't provide libsoup-3. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories_unittest.py: Canonical link: https://commits.webkit.org/280536@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5877b: Allow WebRTC network traffic on the interface used...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5877b229ffa2ae13da637a0fd8910e30ffafc29 https://github.com/WebKit/WebKit/commit/b5877b229ffa2ae13da637a0fd8910e30ffafc29 Author: Youenn Fablet Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A LayoutTests/http/wpt/webrtc/resources/cacheable-iframe.py A LayoutTests/http/wpt/webrtc/rtcNetworkInterface-expected.txt A LayoutTests/http/wpt/webrtc/rtcNetworkInterface.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/Modules/mediastream/RTCNetworkManager.h M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h M Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp M Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h Log Message: --- Allow WebRTC network traffic on the interface used to load the document main resource even if it is not the default interface https://bugs.webkit.org/show_bug.cgi?id=275986 rdar://problem/130748643 Reviewed by Eric Carlson. With split VPN, HTTP trafic may go through either default interface or the VPN interface. But WebRTC UDP traffic will only go through the default interface as we do not enumerate all interfaces even post getUserMedia. To improve the support of split VPN, we use the following heuristic: - We continue allow using the default network interface. - We get the interface that would be used to create a TCP connection to the document's host. In case of no VPN, or full VPN, the same interface will be used. In case of split VPN, two interfaces may be used. This only happens post getUserMedia and is controlled by EnumeratingVisibleNetworkInterfacesEnabled flag. * LayoutTests/http/wpt/webrtc/resources/cacheable-iframe.py: Added. (main): * LayoutTests/http/wpt/webrtc/rtcNetworkInterface-expected.txt: Added. * LayoutTests/http/wpt/webrtc/rtcNetworkInterface.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/Modules/mediastream/RTCNetworkManager.h: * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::rtcNetworkInterfaceName const): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp: (WebKit::NetworkRTCProvider::getInterfaceName): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h: * Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.messages.in: * Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h: * Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm: (WebKit::createNWConnection): (WebKit::NetworkRTCTCPSocketCocoa::NetworkRTCTCPSocketCocoa): (WebKit::NetworkRTCTCPSocketCocoa::getInterfaceName): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp: (WebKit::LibWebRTCNetworkManager::networksChanged): (WebKit::LibWebRTCNetworkManager::interfaceNameForTesting const): * Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetworkManager.h: Canonical link: https://commits.webkit.org/280535@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 474a44: [WebDriver][WPE] Support creating new webviews fro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 474a4428f7ed3cc1525d935f010d1d0979c52c9f https://github.com/WebKit/WebKit/commit/474a4428f7ed3cc1525d935f010d1d0979c52c9f Author: Lauro Moura Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Tools/MiniBrowser/wpe/main.cpp Log Message: --- [WebDriver][WPE] Support creating new webviews from create-web-view signal https://bugs.webkit.org/show_bug.cgi?id=212950 Reviewed by Carlos Garcia Campos. The create-web-view signal is used by the automation session to ask the user code to return new views for automation. For example, the first view being automated or new views as response to WebDriver commands creating new windows/tabs. In the new WPE API, it's easier to create new WebViews. This commit takes advantage of this to support this feature (currently only through new windows, as MiniBrowser doesn't support tabs). In the old WPE API, we keep the previous behavior of always returning the same view. * Tools/MiniBrowser/wpe/main.cpp: (createWebViewForAutomationCallback): Canonical link: https://commits.webkit.org/280534@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be6447: [GStreamer] Use gstStructureGet helper in more places
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be64472d6f0a6e2415907fabe53ba7aa4fec261c https://github.com/WebKit/WebKit/commit/be64472d6f0a6e2415907fabe53ba7aa4fec261c Author: Philippe Normand Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp Log Message: --- [GStreamer] Use gstStructureGet helper in more places https://bugs.webkit.org/show_bug.cgi?id=276063 Reviewed by Xabier Rodriguez-Calvar. Use the new helper instead of gst_structure_get_ functions when possible. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::pickAvailablePayloadType): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::getVideoSizeAndFormatFromCaps): (WebCore::getVideoResolutionFromCaps): * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::createOptionalParserForFormat): * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (videoEncoderSetEncoder): * Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp: (WebCore::GStreamerIncomingTrackProcessor::stats): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp: (WebCore::GStreamerVideoCapturer::reconfigure): Canonical link: https://commits.webkit.org/280533@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59b02e: [GStreamer] Use ASCIILiteral in registry scanner
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59b02eee1fcfe02ef18314b534ad1c54866518a0 https://github.com/WebKit/WebKit/commit/59b02eee1fcfe02ef18314b534ad1c54866518a0 Author: Philippe Normand Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h Log Message: --- [GStreamer] Use ASCIILiteral in registry scanner https://bugs.webkit.org/show_bug.cgi?id=276061 Reviewed by Xabier Rodriguez-Calvar. Replace const char* usage in hasElementForMediaType with an ASCIILiteral. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const): (WebCore::GStreamerRegistryScanner::initializeDecoders): (WebCore::GStreamerRegistryScanner::initializeEncoders): (WebCore::GStreamerRegistryScanner::fillAudioRtpCapabilities): (WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h: Canonical link: https://commits.webkit.org/280532@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87ee5e: [GStreamer] Support for serializing uint64_t value...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87ee5e0693a006bda3b05bfc7f47fdaaafd4dd99 https://github.com/WebKit/WebKit/commit/87ee5e0693a006bda3b05bfc7f47fdaaafd4dd99 Author: Philippe Normand Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp Log Message: --- [GStreamer] Support for serializing uint64_t values to JSON https://bugs.webkit.org/show_bug.cgi?id=276068 Reviewed by Xabier Rodriguez-Calvar. BigInt is not officially supported in JSON, so the workaround is to serialize to a string. See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#use_within_json * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::gstStructureValueToJSON): * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/280531@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14d24d: [GTK][WPE] DRMDeviceNode needs to be ThreadSafeRef...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14d24d0067bb5d83653aed94987f7ea6137069a6 https://github.com/WebKit/WebKit/commit/14d24d0067bb5d83653aed94987f7ea6137069a6 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h Log Message: --- [GTK][WPE] DRMDeviceNode needs to be ThreadSafeRefCounted https://bugs.webkit.org/show_bug.cgi?id=275583 Reviewed by Nikolas Zimmermann. Make DRMDeviceNode ThreadSafeRefCounted and ensure the GBMDevice is always created in the main thread. * Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp: (WebCore::DRMDeviceManager::initializeMainDevice): (WebCore::DRMDeviceManager::deviceNode): * Source/WebCore/platform/graphics/gbm/DRMDeviceNode.cpp: (WebCore::DRMDeviceNode::create): (WebCore::DRMDeviceNode::gbmDevice const): * Source/WebCore/platform/graphics/gbm/DRMDeviceNode.h: Canonical link: https://commits.webkit.org/280530@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 753627: [WPE] WPE Platform: set application ID on toplevel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75362745f30d727ca88328a2be32ac8aa5f4b933 https://github.com/WebKit/WebKit/commit/75362745f30d727ca88328a2be32ac8aa5f4b933 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp Log Message: --- [WPE] WPE Platform: set application ID on toplevel under wayland https://bugs.webkit.org/show_bug.cgi?id=275987 Reviewed by Alejandro G. Castro. * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (wpeToplevelWaylandConstructed): Canonical link: https://commits.webkit.org/280529@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a3cd9f: [GStreamer][EME][Thunder] Add AV1 to the list of s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a3cd9fe326f0c567a19a0d6f5236e68232d15756 https://github.com/WebKit/WebKit/commit/a3cd9fe326f0c567a19a0d6f5236e68232d15756 Author: Xabier Rodriguez-Calvar Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp Log Message: --- [GStreamer][EME][Thunder] Add AV1 to the list of supported types to decryptor https://bugs.webkit.org/show_bug.cgi?id=276065 Reviewed by Philippe Normand. Add AV1 to the decryptor caps. Patch by Eugene Mutavchi . * Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.cpp: Canonical link: https://commits.webkit.org/280528@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0381c: [WPE] WPE Platform: fix toplevel resize under wayland
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0381cc1d025f3694d5d910f30cadba98ae76b04 https://github.com/WebKit/WebKit/commit/e0381cc1d025f3694d5d910f30cadba98ae76b04 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp Log Message: --- [WPE] WPE Platform: fix toplevel resize under wayland https://bugs.webkit.org/show_bug.cgi?id=276069 Reviewed by Nikolas Zimmermann. WPEToplevelWayland is not notifying the views about the resize request. We should call wpeToplevelWaylandResized(). * Source/WebKit/WPEPlatform/wpe/wayland/WPEToplevelWayland.cpp: (wpeToplevelWaylandResize): Canonical link: https://commits.webkit.org/280527@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92b5dd: [Navigation] Abort ongoing navigation on window.st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92b5ddfd057326297847ab105fe65e50437ad65b https://github.com/WebKit/WebKit/commit/92b5ddfd057326297847ab105fe65e50437ad65b Author: Rob Buis Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-detach-in-onnavigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-in-onnavigate-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Abort ongoing navigation on window.stop() https://bugs.webkit.org/show_bug.cgi?id=275659 Reviewed by Darin Adler and Alex Christensen. Implement the "inform the navigation API about aborting navigation" alogithm [1] and call it as part of the "stop loading" algorithm [2]. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#inform-the-navigation-api-about-aborting-navigation [2] https://html.spec.whatwg.org/multipage/document-lifecycle.html#nav-stop * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-detach-in-onnavigate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigate-event/signal-abort-window-stop-in-onnavigate-expected.txt: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): * Source/WebCore/page/Navigation.cpp: (WebCore::Navigation::innerDispatchNavigateEvent): (WebCore::Navigation::abortOngoingNavigationIfNeeded): * Source/WebCore/page/Navigation.h: Canonical link: https://commits.webkit.org/280526@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e73a5a: [GStreamer][LibWebRTC] Fix format handling in vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e73a5a8be966c99782f1d6059e131837f5a91e4e https://github.com/WebKit/WebKit/commit/e73a5a8be966c99782f1d6059e131837f5a91e4e Author: Philippe Normand Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp Log Message: --- [GStreamer][LibWebRTC] Fix format handling in video encoder/decoder factory https://bugs.webkit.org/show_bug.cgi?id=276047 Reviewed by Xabier Rodriguez-Calvar. The SdpVideoFormat == operator relies on codec parameters additionally to the codec name, we want to check the name only. * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp: (WebCore::GStreamerVideoDecoderFactory::Create): * Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp: (WebCore::GStreamerVideoEncoderFactory::Create): Canonical link: https://commits.webkit.org/280525@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 19a245: [GStreamer] Registry scanner element filtering imp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19a24540092a3acd36896b569960a56e0bec8853 https://github.com/WebKit/WebKit/commit/19a24540092a3acd36896b569960a56e0bec8853 Author: Philippe Normand Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- [GStreamer] Registry scanner element filtering improvements https://bugs.webkit.org/show_bug.cgi?id=276048 Reviewed by Xabier Rodriguez-Calvar. We can't use gst_element_factory_list_filter because it would allow-list elements with pads using ANY in their caps template. This issue was found when trying to reduce the list of RTP (de)payloaders using GST_PLUGIN_FEATURE_RANK, the rtpgstdepay element would be selected as candidate for audio/G722 caps, which is valid, but in practice not a suitable element for our pipeline. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::findCompatibleFactories): (WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForCaps const): Canonical link: https://commits.webkit.org/280524@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 606967: [WebXR] Implement explicit resolve of WebXR MSAA R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 606967dd83de240185d0a057c06725572478321d https://github.com/WebKit/WebKit/commit/606967dd83de240185d0a057c06725572478321d Author: Dan Glastonbury Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/ThirdParty/ANGLE/Configurations/BaseTarget.xcconfig M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/interpreter_utils.json M Source/ThirdParty/ANGLE/scripts/entry_point_packed_gl_enums.json M Source/ThirdParty/ANGLE/scripts/gl_angle_ext.xml M Source/ThirdParty/ANGLE/scripts/registry_xml.py M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.cpp M Source/ThirdParty/ANGLE/src/common/entry_points_enum_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Context_gles_ext_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/Framebuffer.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Framebuffer.h M Source/ThirdParty/ANGLE/src/libANGLE/capture/capture_gles_ext_autogen.cpp M Source/ThirdParty/ANGLE/src/libANGLE/capture/capture_gles_ext_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/gles_extensions_autogen.cpp M Source/ThirdParty/ANGLE/src/libANGLE/gles_extensions_autogen.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BUILD.gn M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/FrameBufferMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/RenderTargetMtl.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/RenderTargetMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_state_cache.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_state_cache.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm M Source/ThirdParty/ANGLE/src/libANGLE/validationESEXT.cpp M Source/ThirdParty/ANGLE/src/libANGLE/validationESEXT_autogen.h M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_ext_autogen.cpp M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_gles_ext_autogen.h M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2_autogen.cpp M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2_no_capture_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2_with_capture_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/opengl32_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/opengl32_with_wgl_autogen.def M Source/ThirdParty/ANGLE/src/libGLESv2/proc_table_egl_autogen.cpp M Source/ThirdParty/ANGLE/src/libGLESv2/proc_table_glx_autogen.cpp M Source/ThirdParty/ANGLE/src/libGLESv2/proc_table_wgl_autogen.cpp M Source/ThirdParty/ANGLE/src/tests/angle_end2end_tests.gni M Source/ThirdParty/ANGLE/util/capture/frame_capture_replay_autogen.cpp M Source/ThirdParty/ANGLE/util/capture/trace_gles_loader_autogen.cpp M Source/ThirdParty/ANGLE/util/capture/trace_gles_loader_autogen.h M Source/ThirdParty/ANGLE/util/capture/trace_interpreter_autogen.cpp M Source/ThirdParty/ANGLE/util/gles_loader_autogen.cpp M Source/ThirdParty/ANGLE/util/gles_loader_autogen.h M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h M Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp M Source/WebCore/platform/graphics/GraphicsContextGL.cpp M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp Log Message: --- [WebXR] Implement explicit resolve of WebXR MSAA Rendertarget https://bugs.webkit.org/show_bug.cgi?id=274137 rdar://128041507 Reviewed by Mike Wyrzykowski. GL requires a glBlitFramebuffer to resolve MSAA render targets into single-sample render targets. Internally, ANGLE's Metal backend has an implicit resolve target that it allocates, which becomes the source for the glBlitFramebuffer operation. GPU profiling data captured from device
[webkit-changes] [WebKit/WebKit] 00b3d6: [WPE] Split WPEWebView into Legacy and Platform im...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00b3d6a56f5149245b9e1501389ae169846ec240 https://github.com/WebKit/WebKit/commit/00b3d6a56f5149245b9e1501389ae169846ec240 Author: Carlos Garcia Campos Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/C/wpe/WKView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp M Source/WebKit/UIProcess/API/wpe/WPEWebView.h A Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp A Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h A Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp A Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h M Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp Log Message: --- [WPE] Split WPEWebView into Legacy and Platform implementations https://bugs.webkit.org/show_bug.cgi?id=275985 Reviewed by Nikolas Zimmermann. It makes clearer what code is expected to be used for new and old APIs. * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/C/wpe/WKView.cpp: (WKViewCreate): (WKViewCreateDeprecated): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewCreatePage): (webkitWebViewGetRendererBufferFormat): * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::doneWithTouchEvent): (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode): (WebKit::PageClientImpl::updateAcceleratedCompositingMode): (WebKit::PageClientImpl::enterFullScreen): (WebKit::PageClientImpl::exitFullScreen): * Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp: (WKWPE::View::View): (WKWPE::View::close): (WKWPE::View::accessible const): (): Deleted. (WKWPE::m_backend): Deleted. (WKWPE::View::~View): Deleted. (WKWPE::View::setViewState): Deleted. (WKWPE::View::handleKeyboardEvent): Deleted. (WKWPE::View::synthesizeCompositionKeyPress): Deleted. (WKWPE::viewToplevelIsFullScreen): Deleted. (WKWPE::View::enterFullScreen): Deleted. (WKWPE::View::didEnterFullScreen): Deleted. (WKWPE::View::exitFullScreen): Deleted. (WKWPE::View::didExitFullScreen): Deleted. (WKWPE::View::requestExitFullScreen): Deleted. (WKWPE::View::setFullScreen): Deleted. (WKWPE::View::platformWebPageProxyForGamepadInput): Deleted. (WKWPE::View::updateAcceleratedSurface): Deleted. (WKWPE::View::renderBufferFormat const): Deleted. (WKWPE::View::updateDisplayID): Deleted. (WKWPE::View::touchPointsForEvent): Deleted. (WKWPE::View::setCursor): Deleted. (WKWPE::View::callAfterNextPresentationUpdate): Deleted. * Source/WebKit/UIProcess/API/wpe/WPEWebView.h: (WKWPE::View::page): (WKWPE::View::client const): (WKWPE::View::size const): (WKWPE::View::backend const): (WKWPE::View::wpeView const): (WKWPE::View::setCursor): (WKWPE::View::create): Deleted. (WKWPE::View::backend): Deleted. (WKWPE::View::touchGestureController const): Deleted. * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp: Added. (WKWPE::ViewLegacy::ViewLegacy): (WKWPE::ViewLegacy::~ViewLegacy): (WKWPE::ViewLegacy::setViewState): (WKWPE::ViewLegacy::handleKeyboardEvent): (WKWPE::ViewLegacy::synthesizeCompositionKeyPress): (WKWPE::ViewLegacy::setFullScreen): (WKWPE::ViewLegacy::platformWebPageProxyForGamepadInput): (WKWPE::ViewLegacy::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.h: Added. * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp: Added. (WKWPE::ViewPlatform::ViewPlatform): (WKWPE::ViewPlatform::~ViewPlatform): (WKWPE::viewToplevelIsFullScreen): (WKWPE::ViewPlatform::enterFullScreen): (WKWPE::ViewPlatform::didEnterFullScreen): (WKWPE::ViewPlatform::exitFullScreen): (WKWPE::ViewPlatform::didExitFullScreen): (WKWPE::ViewPlatform::requestExitFullScreen): (WKWPE::ViewPlatform::updateAcceleratedSurface): (WKWPE::ViewPlatform::renderBufferFormat const): (WKWPE::ViewPlatform::updateDisplayID): (WKWPE::ViewPlatform::touchPointsForEvent): (WKWPE::ViewPlatform::synthesizeCompositionKeyPress): (WKWPE::ViewPlatform::setCursor): (WKWPE::ViewPlatform::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h: Added. * Source/WebKit/UIProcess/Gamepad/libwpe/UIGamepadProviderLibWPE.cpp: (WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput): Canonical link: https://commits.webkit.org/280522@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
