[webkit-changes] [WebKit/WebKit] 23ede0: [ews-build] Bugzillas enclosed in <> in commit mes...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23ede0a382568460eb573f122aa0b349d134937f
  
https://github.com/WebKit/WebKit/commit/23ede0a382568460eb573f122aa0b349d134937f
  Author: Aakash Jain 
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] Bugzillas enclosed in <> in commit messages do not get closed 
upon landing
https://bugs.webkit.org/show_bug.cgi?id=278426

Reviewed by Ryan Haddad.

Updated the regular expression to include angle brackets as well in bugs url.

* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/283169@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f9b965: [ews-build] Highlight flaky API test failures when...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9b9656704d7a2845d7e920988577c05c4a13d09
  
https://github.com/WebKit/WebKit/commit/f9b9656704d7a2845d7e920988577c05c4a13d09
  Author: Aakash Jain 
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build] Highlight flaky API test failures when tests fails in first run 
but passes in rerun
https://bugs.webkit.org/show_bug.cgi?id=278742

Reviewed by Ryan Haddad.

When the first run has test failures, but second run for exact same code passes 
all
the tests, it means the test failures in first run were flaky. Indicate that in 
buildbot
build summary, so that they are easier to notice and fix. We already do that 
for layout-tests.

* Tools/CISupport/ews-build/steps.py:
(RunAPITests.run):

Canonical link: https://commits.webkit.org/282861@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b21577: [ews-build] Do not print worker environment variab...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b215773cfd9d99c78a9b0a670968ea732f6bb1bc
  
https://github.com/WebKit/WebKit/commit/b215773cfd9d99c78a9b0a670968ea732f6bb1bc
  Author: Aakash Jain 
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] Do not print worker environment variables in 
find-modified-layout-tests step
https://bugs.webkit.org/show_bug.cgi?id=278470

Reviewed by Jonathan Bedard.

It makes the buildbot build page hard to read, especially because this step is 
mostly skipped,
and buildbot expands it by default showing all these unnecessary details on 
front.
This causes users to have to scroll lot more to see the relevant things. In 
almost all other
steps we have disabled printing worker environment variables.

* Tools/CISupport/ews-build/steps.py:
(FindModifiedLayoutTests.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFindModifiedLayoutTests.test_success):
(TestFindModifiedLayoutTests.test_success_svg):
(TestFindModifiedLayoutTests.test_success_xml):
(TestFindModifiedLayoutTests.test_ignore_certain_directories):
(TestFindModifiedLayoutTests.test_ignore_certain_directories_svg):
(TestFindModifiedLayoutTests.test_ignore_certain_directories_xml):
(TestFindModifiedLayoutTests.test_ignore_certain_suffixes):
(TestFindModifiedLayoutTests.test_ignore_non_layout_test_in_html_directory):
(TestFindModifiedLayoutTests.test_non_relevant_patch):
(TestFindModifiedLayoutTests.test_non_accessible_patch):

Canonical link: https://commits.webkit.org/282571@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f6683: [ews] Fix few unit-tests for TestPrintConfiguration

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f668343383c51dbd8a53961c50154f4e4cbfda6
  
https://github.com/WebKit/WebKit/commit/5f668343383c51dbd8a53961c50154f4e4cbfda6
  Author: Aakash Jain 
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Fix few unit-tests for TestPrintConfiguration
https://bugs.webkit.org/show_bug.cgi?id=278459

Reviewed by Jonathan Bedard.

These ews unit-tests for TestPrintConfiguration were accidentally disabled in
https://commits.webkit.org/243915@main due to incorrect indentation.
Enabling them and fixing them as required.

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/282566@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d68593: [ews] Relax the validation for OS version mismatch...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d68593a1e6a5509f40be9b7a0e61b58f864a3d4f
  
https://github.com/WebKit/WebKit/commit/d68593a1e6a5509f40be9b7a0e61b58f864a3d4f
  Author: Aakash Jain 
  Date:   2024-08-21 (Wed, 21 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Relax the validation for OS version mismatch between builder and tester
https://bugs.webkit.org/show_bug.cgi?id=278400

Reviewed by Jonathan Bedard.

We can relax the OS version validation between builder and testers, as long as 
SDK version match.
We can match only the major and minor OS version, and ignore the patch version.
For example: 13.6.6 and 13.6.7 should be allowed, but 13.6.6 and 13.7 (or 
13.6.6 and 14) should not be.

* Tools/CISupport/ews-build/steps.py:
(PrintConfiguration.parseAndValidate):

Canonical link: https://commits.webkit.org/282565@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ce5933: [ews] Make error message more actionable when merg...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce593378d3ed35c61145ee4e10198d9297ddbf92
  
https://github.com/WebKit/WebKit/commit/ce593378d3ed35c61145ee4e10198d9297ddbf92
  Author: Aakash Jain 
  Date:   2024-08-20 (Tue, 20 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Make error message more actionable when merge queue rejects a change
https://bugs.webkit.org/show_bug.cgi?id=278384

Reviewed by Ryan Haddad.

Include the link to the buildbot build which has the details of the failure.

* Tools/CISupport/ews-build/steps.py:
(ValidateCommitMessage.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/282505@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9102fe: [ews] Bump minimum python version to Python 3.9

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9102fe7539a53ce332ed119b382dc08338513938
  
https://github.com/WebKit/WebKit/commit/9102fe7539a53ce332ed119b382dc08338513938
  Author: Aakash Jain 
  Date:   2024-08-16 (Fri, 16 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Bump minimum python version to Python 3.9
https://bugs.webkit.org/show_bug.cgi?id=278099

Reviewed by Ryan Haddad and Sam Sneddon.

Similar to https://commits.webkit.org/281302@main for ews django app.

* Tools/CISupport/ews-build/steps.py:

Canonical link: https://commits.webkit.org/282354@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5f0a26: Regression 281869@main ews unit-tests are failing

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f0a26da9dca73e60f32238559871aa3b2651f75
  
https://github.com/WebKit/WebKit/commit/5f0a26da9dca73e60f32238559871aa3b2651f75
  Author: Aakash Jain 
  Date:   2024-08-06 (Tue, 06 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Regression 281869@main ews unit-tests are failing
https://bugs.webkit.org/show_bug.cgi?id=277682

Reviewed by Sam Sneddon.

* Tools/CISupport/ews-build/steps_unittest.py:
(TestRunWebKitTestsRepeatFailuresRedTree.test_success_tests_names_with_shell_conflictive_chars):

Canonical link: https://commits.webkit.org/281905@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f1093f: [ews] Reduce safe-merge-queue scheduler frequency ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1093f70353a1f46aad7dbcbbf69b2110b2ef31d
  
https://github.com/WebKit/WebKit/commit/f1093f70353a1f46aad7dbcbbf69b2110b2ef31d
  Author: Aakash Jain 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/loadConfig.py

  Log Message:
  ---
  [ews] Reduce safe-merge-queue scheduler frequency on testing instances
https://bugs.webkit.org/show_bug.cgi?id=277274

Reviewed by Ryan Haddad.

Reduce safe-merge-queue scheduler frequency on testing instances to avoid 
accumulating too many pending build-requests.

* Tools/CISupport/ews-build/loadConfig.py:

Canonical link: https://commits.webkit.org/281576@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 16953f: [ews] Remove unneeded logs

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 16953f9b1ed0974eb20fdce7cd940eccc57bffb0
  
https://github.com/WebKit/WebKit/commit/16953f9b1ed0974eb20fdce7cd940eccc57bffb0
  Author: Aakash Jain 
  Date:   2024-07-29 (Mon, 29 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Remove unneeded logs
https://bugs.webkit.org/show_bug.cgi?id=277260

Reviewed by Jonathan Bedard.

Remove unneeded logs for the GenerateS3URL step for the success case.
We added it earlier when the step was having issues, but we don't need it 
anymore.

* Tools/CISupport/ews-build/steps.py:
(GenerateS3URL.run):

Canonical link: https://commits.webkit.org/281503@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8a1b97: [ews-app] Enforce minimum python version

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a1b9717a8e7210eaaed7314b5c979e2c06cb6f4
  
https://github.com/WebKit/WebKit/commit/8a1b9717a8e7210eaaed7314b5c979e2c06cb6f4
  Author: Aakash Jain 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews-app/settings.py

  Log Message:
  ---
  [ews-app] Enforce minimum python version
https://bugs.webkit.org/show_bug.cgi?id=277006

Reviewed by Jonathan Bedard and Ryan Haddad.

* Tools/CISupport/ews-app/ews-app/settings.py:

Canonical link: https://commits.webkit.org/281302@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63b451: [ews] Status-bubbles links are incorrect for dev i...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63b45146b501c2b2c7744ec5b35d0248ab9d9cfe
  
https://github.com/WebKit/WebKit/commit/63b45146b501c2b2c7744ec5b35d0248ab9d9cfe
  Author: Aakash Jain 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews-app/settings.py
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/config.py

  Log Message:
  ---
  [ews] Status-bubbles links are incorrect for dev instance
https://bugs.webkit.org/show_bug.cgi?id=276903

Reviewed by Jonathan Bedard.

Remove hard-coded values for uat and dynamically generate appropriate values
for dev vs uat instances.
Also remove the need to explicitly add DEV_INSTANCE variable in passwords.json 
and
detect it automatically based on hostname.

* Tools/CISupport/ews-app/ews-app/settings.py:
* Tools/CISupport/ews-app/ews/common/github.py:
* Tools/CISupport/ews-app/ews/config.py:

Canonical link: https://commits.webkit.org/281298@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c65fa3: [ews-app] Disable automatic Bugzilla patch sending...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c65fa3ce7346836535baa9e91d20ef1b21bb4cef
  
https://github.com/WebKit/WebKit/commit/c65fa3ce7346836535baa9e91d20ef1b21bb4cef
  Author: Aakash Jain 
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/util.py
M Tools/CISupport/ews-app/ews/fetcher.py

  Log Message:
  ---
  [ews-app] Disable automatic Bugzilla patch sending on testing environment
https://bugs.webkit.org/show_bug.cgi?id=276795

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/common/util.py:
(get_custom_suffix): Method to detect environment type and return corresponding 
suffix.
* Tools/CISupport/ews-app/ews/fetcher.py:
(FetchLoop.run): Disable automatic Bugzilla patch sending on testing 
environment.

Canonical link: https://commits.webkit.org/281104@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 947a01: [ews] Add vision-wk2 queue trigger relationship

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 947a010680139a63cee22eb357ccc30c445c86e2
  
https://github.com/WebKit/WebKit/commit/947a010680139a63cee22eb357ccc30c445c86e2
  Author: Aakash Jain 
  Date:   2024-07-12 (Fri, 12 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/buildbot.py

  Log Message:
  ---
  [ews] Add vision-wk2 queue trigger relationship
https://bugs.webkit.org/show_bug.cgi?id=276542

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-app/ews/common/buildbot.py:
(Buildbot):

Canonical link: https://commits.webkit.org/280911@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b9a63: [ews] Add validation to prevent SDK or OS version ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b9a637b40a0096c88677a48b105ac608aac3d97
  
https://github.com/WebKit/WebKit/commit/4b9a637b40a0096c88677a48b105ac608aac3d97
  Author: Aakash Jain 
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add validation to prevent SDK or OS version mismatch between 
corresponding builds on tester and builder queues
https://bugs.webkit.org/show_bug.cgi?id=276379

Unreviewed follow-up fix. Remove debugging code.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):

Canonical link: https://commits.webkit.org/280869@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 03191f: [ews] Add validation to prevent SDK or OS version ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03191fc211d8c2f79172f58e36fc435b20e092f4
  
https://github.com/WebKit/WebKit/commit/03191fc211d8c2f79172f58e36fc435b20e092f4
  Author: Aakash Jain 
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add validation to prevent SDK or OS version mismatch between 
corresponding builds on tester and builder queues
https://bugs.webkit.org/show_bug.cgi?id=276379

Reviewed by Sam Sneddon.

* Tools/CISupport/ews-build/steps.py:
(Trigger.propertiesToPassToTriggers):
(PrintConfiguration):
(PrintConfiguration.run):
(PrintConfiguration.parseAndValidate):
(PrintConfiguration.getResultSummary):

Canonical link: https://commits.webkit.org/280825@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3c9d0f: [ews] Reduce accumulation of pending build-request...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3c9d0f2ee7c56183f27826b2d845ffc5dbe12dff
  
https://github.com/WebKit/WebKit/commit/3c9d0f2ee7c56183f27826b2d845ffc5dbe12dff
  Author: Aakash Jain 
  Date:   2024-07-09 (Tue, 09 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews] Reduce accumulation of pending build-requests in testing environments
https://bugs.webkit.org/show_bug.cgi?id=276373

Reviewed by Sam Sneddon.

Reduce accumulation of pending build-requests by ignoring 90% of the PRs in
testing environment.

* Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits.handle_pull_request):

Canonical link: https://commits.webkit.org/280787@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 00beae: ews is not posting status-bubbles in GitHub comments

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00beaeda9f0f7e5784e93df74d9599dac296675a
  
https://github.com/WebKit/WebKit/commit/00beaeda9f0f7e5784e93df74d9599dac296675a
  Author: Aakash Jain 
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
A Tools/CISupport/ews-app/ews/migrations/0009_alter_change_comment_id.py
M Tools/CISupport/ews-app/ews/models/patch.py

  Log Message:
  ---
  ews is not posting status-bubbles in GitHub comments
https://bugs.webkit.org/show_bug.cgi?id=275257

Reviewed by Jonathan Bedard.

Switch comment_id field from Integer to BigInteger. The comment_id we are 
getting from
GitHub are now larger than the Integer range in Django (which is 2147483647).

* Tools/CISupport/ews-app/ews/models/patch.py:
* Tools/CISupport/ews-app/ews/migrations/0009_alter_change_comment_id.py: 
Migration added.

Canonical link: https://commits.webkit.org/279818@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 538cc4: [build.webkit.org] Do not try to download build pr...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 538cc4d94b8a51496c3f982522eb0e50cb6aa732
  
https://github.com/WebKit/WebKit/commit/538cc4d94b8a51496c3f982522eb0e50cb6aa732
  Author: Aakash Jain 
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] Do not try to download build product from master
https://bugs.webkit.org/show_bug.cgi?id=274538

Reviewed by Ryan Haddad.

We stopped uploading archives to build master in 276...@main.so, while 
downloading
archives, when download from s3 fails, there is no point in trying to fallback 
to
download from build master.

We should make it a hard failure when download from s3 fails.
This is similar to 276539@main for ews.

* Tools/CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct):

Canonical link: https://commits.webkit.org/279145@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e03191: [ews] Allow multiple production hostname in send_e...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e03191057148641542843f812cb67727b1954deb
  
https://github.com/WebKit/WebKit/commit/e03191057148641542843f812cb67727b1954deb
  Author: Aakash Jain 
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
M Tools/CISupport/ews-build/send_email.py

  Log Message:
  ---
  [ews] Allow multiple production hostname in send_email.py
https://bugs.webkit.org/show_bug.cgi?id=271465

Unreviewed infrastructure fix.

* Tools/CISupport/ews-build/send_email.py:
(send_email):

Canonical link: https://commits.webkit.org/276542@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 74c76a: [ews] Do not try to download build product from ma...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74c76a11700d402f304b80e81e52fbf6e2b6ce5b
  
https://github.com/WebKit/WebKit/commit/74c76a11700d402f304b80e81e52fbf6e2b6ce5b
  Author: Aakash Jain 
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Do not try to download build product from master
https://bugs.webkit.org/show_bug.cgi?id=271463

Reviewed by Jonathan Bedard.

We stopped uploading archives to build master in 273509@main. So, while 
downloading
archives, when download from s3 fails, there is no point in trying to fallback 
to
download from build master.

* Tools/CISupport/ews-build/steps.py:
(DownloadBuiltProduct):

Canonical link: https://commits.webkit.org/276539@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2cef4: [ews-build.webkit.org] Report DNS name, not HOSTNA...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2cef47865d2a42c2a634ee96167af86da19a1ad
  
https://github.com/WebKit/WebKit/commit/a2cef47865d2a42c2a634ee96167af86da19a1ad
  Author: Aakash Jain 
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build.webkit.org] Report DNS name, not HOSTNAME to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=271066

Reviewed by Jonathan Bedard.

Similar to 275238@main.

* Tools/CISupport/ews-build/steps.py:

Canonical link: https://commits.webkit.org/276196@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0b42e6: [ews] Build failure emails should include commit i...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b42e6c6ade0519487e119ae12ff6c54ac67ef6e
  
https://github.com/WebKit/WebKit/commit/0b42e6c6ade0519487e119ae12ff6c54ac67ef6e
  Author: Aakash Jain 
  Date:   2024-03-07 (Thu, 07 Mar 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Build failure emails should include commit identifier
https://bugs.webkit.org/show_bug.cgi?id=270637

Reviewed by Ryan Haddad.

This would help in quickly identifying the potential regression point/range by
glancing over the emails.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure):

Canonical link: https://commits.webkit.org/275796@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f6fe8: [ews-build] Reduce duration to keep buildbot logs ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f6fe8dd5f940a6c609a80b8a00779f3c1f178bc
  
https://github.com/WebKit/WebKit/commit/9f6fe8dd5f940a6c609a80b8a00779f3c1f178bc
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews-build] Reduce duration to keep buildbot logs to 30 days
https://bugs.webkit.org/show_bug.cgi?id=270255

Reviewed by Jonathan Bedard.

old buildbot logs on EWS aren't much usable. Most of the PRs are already landed 
and even
if they aren't, people should rebase on ToT and re-run EWS for latest results.

Note that this does not affect GitHub status-bubbles or bugzilla 
status-bubbles. The builds
will still be there, links will still work from GitHub status-bubbles, just 
that the detailed
logs wouldn't be available for older builds.

* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/275472@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59e1c1: [ews] Load passwords.json from ews-build directory...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59e1c186c9fdf9ce0896b9d6a59b1d5286dccfba
  
https://github.com/WebKit/WebKit/commit/59e1c186c9fdf9ce0896b9d6a59b1d5286dccfba
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg
M Tools/CISupport/ews-build/utils.py

  Log Message:
  ---
  [ews] Load passwords.json from ews-build directory for all masters
https://bugs.webkit.org/show_bug.cgi?id=270232

Reviewed by Jonathan Bedard.

Load passwords.json from ews-build directory for all masters, so that all 
masters
load same passwords.json without need to create a symlink.

* Tools/CISupport/ews-build/utils.py:
* Tools/CISupport/build-webkit-org/master.cfg: Similar change for 
build.webkit.org for future use.

Canonical link: https://commits.webkit.org/275455@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 22d619: [ews] Disable buildbot-profiler

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22d619a9cd36f08eda8abfa49ccd9cdefb6da071
  
https://github.com/WebKit/WebKit/commit/22d619a9cd36f08eda8abfa49ccd9cdefb6da071
  Author: Aakash Jain 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build-webserver/master.cfg
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews] Disable buildbot-profiler
https://bugs.webkit.org/show_bug.cgi?id=270221

Unreviewed infrastructure maintenance.

Do not need it currently.

* Tools/CISupport/ews-build-webserver/master.cfg:
* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/275440@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 70f3a2: [build.webkit.org] Support multiple hostnames for ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 70f3a29f11a7ab9d3d4cc0deee46b20e505f5af9
  
https://github.com/WebKit/WebKit/commit/70f3a29f11a7ab9d3d4cc0deee46b20e505f5af9
  Author: Aakash Jain 
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] Support multiple hostnames for production instance
https://bugs.webkit.org/show_bug.cgi?id=269579

Reviewed by Ryan Haddad.

* Tools/CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct.run):
(TransferToS3.doStepIf):

Canonical link: https://commits.webkit.org/274852@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f9d5d1: [ews] compiling webkit steps fails frequently with...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9d5d15874ed35c73a1ba4afcc7ecc7283d0ae86
  
https://github.com/WebKit/WebKit/commit/f9d5d15874ed35c73a1ba4afcc7ecc7283d0ae86
  Author: Aakash Jain 
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] compiling webkit steps fails frequently with error Failed to open 
WebKitBuild/build-log.txt
https://bugs.webkit.org/show_bug.cgi?id=269084

Reviewed by Jonathan Bedard.

filter-build-webkit fails when WebKitBuild directory does not already exist. 
Better to not
depend on WebKitBuild directory.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/274380@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 578b35: [ews] Increase timeout for compiling webkit steps

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 578b35f89e28b873f1c6fa36c4e622e0216cb1d1
  
https://github.com/WebKit/WebKit/commit/578b35f89e28b873f1c6fa36c4e622e0216cb1d1
  Author: Aakash Jain 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Increase timeout for compiling webkit steps
https://bugs.webkit.org/show_bug.cgi?id=269000

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/274297@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8df1e6: Convert ews-build.webkit.org to multi-master (to i...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8df1e60d240a30bf4dfc17a6b32663ba946752ab
  
https://github.com/WebKit/WebKit/commit/8df1e60d240a30bf4dfc17a6b32663ba946752ab
  Author: Aakash Jain 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
A Tools/CISupport/ews-build-webserver/buildbot.tac
A Tools/CISupport/ews-build-webserver/master.cfg
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  Convert ews-build.webkit.org to multi-master (to improve responsiveness)
https://bugs.webkit.org/show_bug.cgi?id=268982

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/master.cfg:
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build-webserver/buildbot.tac: Copied from 
Tools/CISupport/ews-build/buildbot.tac.
* Tools/CISupport/ews-build-webserver/master.cfg: Copied from 
Tools/CISupport/ews-build/master.cfg.

Canonical link: https://commits.webkit.org/274295@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d4fd59: [ews] Enable buildbot-profiler

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4fd599ee8cbd60c88fce4ea9a99953c5fddc16c
  
https://github.com/WebKit/WebKit/commit/d4fd599ee8cbd60c88fce4ea9a99953c5fddc16c
  Author: Aakash Jain 
  Date:   2024-02-06 (Tue, 06 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews] Enable buildbot-profiler
https://bugs.webkit.org/show_bug.cgi?id=268863

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/274176@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c16b52: [ews] Improve handling of case when PR breaks layo...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c16b5257b6f7700d5a2738c5fd5970e1f42d0497
  
https://github.com/WebKit/WebKit/commit/c16b5257b6f7700d5a2738c5fd5970e1f42d0497
  Author: Aakash Jain 
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Improve handling of case when PR breaks layout-test
https://bugs.webkit.org/show_bug.cgi?id=268548

Reviewed by Jonathan Bedard.

Treat WARNINGS similar to SUCCESS when layout-test step completes.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeJSCTestsResults.start):
(AnalyzeLayoutTestsResults.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResults.test_change_breaks_layout_tests1):
(TestAnalyzeLayoutTestsResults.test_change_breaks_layout_tests2):

Canonical link: https://commits.webkit.org/273905@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5a6af2: [ews] unit-tests should not talk to live github se...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a6af29b4230f41b518802b9d501baf1eb5e7ca2
  
https://github.com/WebKit/WebKit/commit/5a6af29b4230f41b518802b9d501baf1eb5e7ca2
  Author: Aakash Jain 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] unit-tests should not talk to live github server
https://bugs.webkit.org/show_bug.cgi?id=268107

Reviewed by Ryan Haddad and Jonathan Bedard.

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/273537@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 15355e: [ews] Make S3 upload failure a hard failure

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 15355e2a96a5c3e46cc78b687107f32a1f66b5f0
  
https://github.com/WebKit/WebKit/commit/15355e2a96a5c3e46cc78b687107f32a1f66b5f0
  Author: Aakash Jain 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Make S3 upload failure a hard failure
https://bugs.webkit.org/show_bug.cgi?id=268081

Reviewed by Jonathan Bedard.

Make S3 upload failure a hard failure on ews-build.webkit.org.
Remove the fallback to uploading to the build-master, as that seems to overload 
the server.

* Tools/CISupport/ews-build/steps.py:
(UploadFileToS3):
(UploadFileToS3.run):
(UploadFileToS3.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestUploadFileToS3.test_success):

Canonical link: https://commits.webkit.org/273509@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a66da: [upload-file-to-url] Bump S3 upload timeout to 15 ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a66dadaf2d756b702a1db90f45af3a65158b7a5
  
https://github.com/WebKit/WebKit/commit/2a66dadaf2d756b702a1db90f45af3a65158b7a5
  Author: Aakash Jain 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [upload-file-to-url] Bump S3 upload timeout to 15 minutes
https://bugs.webkit.org/show_bug.cgi?id=268076

Reviewed by Jonathan Bedard.

Recently added logging in 273416@main indicates that we are occasionally 
hitting the 10 minute timeout.
Also, when the retry helps, the retry is also taking near about 10 minutes.
Let's bump S3 upload timeout to 15 minutes, and reduce the number of retries 
from 3 to 2,
effectively still maintaining the overall time of 30 minutes.

* Tools/Scripts/upload-file-to-url:
(upload):

Canonical link: https://commits.webkit.org/273499@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 80d432: upload-file-to-url should print information about ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80d432578269e9734ce838b30d89f2b9308821c5
  
https://github.com/WebKit/WebKit/commit/80d432578269e9734ce838b30d89f2b9308821c5
  Author: Aakash Jain 
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  upload-file-to-url should print information about retry attempts live while 
it is running
https://bugs.webkit.org/show_bug.cgi?id=268004

Reviewed by Jonathan Bedard.

Replace print with sys.stderr.write.
Also, increase timeout for upload-file-to-s3 step from 30 to 31 minutes so as to
allow the script to finish by itself (it has 3 retries of 10 minutes each).

* Tools/Scripts/upload-file-to-url:
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/273416@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0a18be: [build.webkit.org] Use python 3 f-strings (follow-...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a18be4d9678570bffc3da8af0ef596a5b90203c
  
https://github.com/WebKit/WebKit/commit/0a18be4d9678570bffc3da8af0ef596a5b90203c
  Author: Aakash Jain 
  Date:   2024-01-18 (Thu, 18 Jan 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] Use python 3 f-strings (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=267410

Unreviewed minor follow-up fix.

* Tools/CISupport/build-webkit-org/steps.py:
(ShowIdentifier.url_for_identifier):

Canonical link: https://commits.webkit.org/273175@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b0c523: [ews] Add support for dev instance

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0c5231d39b4039a0625880e8496f195cda979dc
  
https://github.com/WebKit/WebKit/commit/b0c5231d39b4039a0625880e8496f195cda979dc
  Author: Aakash Jain 
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/master.cfg
M Tools/CISupport/ews-build/send_email.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/utils.py

  Log Message:
  ---
  [ews] Add support for dev instance
https://bugs.webkit.org/show_bug.cgi?id=267408

Reviewed by Jonathan Bedard and Ling Ho.

Add support for dev instance, just like uat instance.

* Tools/CISupport/ews-build/events.py:
* Tools/CISupport/ews-build/master.cfg:
* Tools/CISupport/ews-build/send_email.py:
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/utils.py:
(get_custom_suffix):

Canonical link: https://commits.webkit.org/272942@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f9c147: [ews] Improve error logging when passwords.json is...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f9c1475ac7e327f474a5c2422aa2006f83bb0ee7
  
https://github.com/WebKit/WebKit/commit/f9c1475ac7e327f474a5c2422aa2006f83bb0ee7
  Author: Aakash Jain 
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg
M Tools/CISupport/ews-app/ews/common/util.py
M Tools/CISupport/ews-build/utils.py

  Log Message:
  ---
  [ews] Improve error logging when passwords.json is missing
https://bugs.webkit.org/show_bug.cgi?id=267407

Reviewed by Jonathan Bedard.

When passwords.json is missing (e.g.: local testing), currently we log messages 
saying:
Error in finding {variable_name} in passwords.json
We should print more accurate message.

* Tools/CISupport/ews-build/utils.py:
(load_password):
* Tools/CISupport/build-webkit-org/master.cfg:
* Tools/CISupport/ews-app/ews/common/util.py:
(load_password):

Canonical link: https://commits.webkit.org/272915@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67ebfd: [build.webkit.org] Use python 3 f-strings

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67ebfd0ad8d6dd1c3db988f9fbabfd9b91c6e7ab
  
https://github.com/WebKit/WebKit/commit/67ebfd0ad8d6dd1c3db988f9fbabfd9b91c6e7ab
  Author: Aakash Jain 
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/loadConfig.py
M Tools/CISupport/build-webkit-org/loadConfig_unittest.py
M Tools/CISupport/build-webkit-org/master.cfg
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  ---
  [build.webkit.org] Use python 3 f-strings
https://bugs.webkit.org/show_bug.cgi?id=267410

Reviewed by Jonathan Bedard.

Used f-strings for formatting. build.webkit.org code is python 3 only.

* Tools/CISupport/build-webkit-org/loadConfig.py:
* Tools/CISupport/build-webkit-org/loadConfig_unittest.py:
* Tools/CISupport/build-webkit-org/master.cfg:
* Tools/CISupport/build-webkit-org/steps.py:
* Tools/CISupport/build-webkit-org/steps_unittest.py:

Canonical link: https://commits.webkit.org/272914@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bb7930: [build-webkit-org] Update OS mapping in PrintConfi...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb7930fd0fc11cb4b163f768b1090dd58b89e746
  
https://github.com/WebKit/WebKit/commit/bb7930fd0fc11cb4b163f768b1090dd58b89e746
  Author: Aakash Jain 
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build-webkit-org] Update OS mapping in PrintConfiguration
https://bugs.webkit.org/show_bug.cgi?id=266690

Reviewed by Jonathan Bedard.

* Tools/CISupport/build-webkit-org/steps.py:
(PrintConfiguration.convert_build_to_os_name):

Canonical link: https://commits.webkit.org/272354@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0f607b: [build.webkit.org] Improve support for required ch...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f607be029bf0deefdc9f4e4edc27b9aa2a5ddd6
  
https://github.com/WebKit/WebKit/commit/0f607be029bf0deefdc9f4e4edc27b9aa2a5ddd6
  Author: Aakash Jain 
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
M Tools/CISupport/Shared/transfer-archive-to-s3

  Log Message:
  ---
  [build.webkit.org] Improve support for required changes for uat/dev instance 
- part 2
https://bugs.webkit.org/show_bug.cgi?id=266654

Reviewed by Ryan Haddad.

Auto-detect the uat/dev instance and make changes accordingly.
Also change print statements to use f-strings.

* Tools/CISupport/Shared/transfer-archive-to-s3:
(uploadToS3):
(archiveExists):

Canonical link: https://commits.webkit.org/272290@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eea16f: [ews] Develop orange status-bubble equivalent in G...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eea16f7ff6cd7188f8f46d04ff7659bb210707b7
  
https://github.com/WebKit/WebKit/commit/eea16f7ff6cd7188f8f46d04ff7659bb210707b7
  Author: Aakash Jain 
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py

  Log Message:
  ---
  [ews] Develop orange status-bubble equivalent in Github status-bubbles
https://bugs.webkit.org/show_bug.cgi?id=244054

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS):

Canonical link: https://commits.webkit.org/272225@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aac162: [ews] show-identifier step is failing sometimes wi...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aac162dd61cb50104e83a2e3a2ae624196ea3a69
  
https://github.com/WebKit/WebKit/commit/aac162dd61cb50104e83a2e3a2ae624196ea3a69
  Author: Aakash Jain 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Tools/Scripts/webkitpy/__init__.py

  Log Message:
  ---
  [ews] show-identifier step is failing sometimes with error  No archives for 
six-1.16 found
https://bugs.webkit.org/show_bug.cgi?id=266141

Reviewed by Jonathan Bedard.

Ignore import error while trying to import six. Maybe show-identifier
or the command being invoked might work without it.

* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/272182@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aeb803: upload-file-to-s3 should retry when the request fa...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeb80393640e8010a6d6e2f4381820b082d06055
  
https://github.com/WebKit/WebKit/commit/aeb80393640e8010a6d6e2f4381820b082d06055
  Author: Aakash Jain 
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  upload-file-to-s3 should retry when the request fails with status_code 503 
(follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=266419

Unreviewed follow-up fix.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/272179@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a0cb03: upload-file-to-s3 fails because of webkitpy autoin...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0cb037063a252e2b157a7cecbbe61e4dbccebe6
  
https://github.com/WebKit/WebKit/commit/a0cb037063a252e2b157a7cecbbe61e4dbccebe6
  Author: Aakash Jain 
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  upload-file-to-s3 fails because of webkitpy autoinstaller failing with error 
No archives for six-1.16 found
https://bugs.webkit.org/show_bug.cgi?id=266411

Reviewed by Jonathan Bedard.

Ignore webkitpy errors while trying to import. We are only importing it to 
auto-install
requests module, which might already be present.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/272057@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3be6d4: upload-file-to-s3 should retry when the request fa...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3be6d4ae5ddb6b67a9caea84ac256468892ac032
  
https://github.com/WebKit/WebKit/commit/3be6d4ae5ddb6b67a9caea84ac256468892ac032
  Author: Aakash Jain 
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  upload-file-to-s3 should retry when the request fails with status_code 503
https://bugs.webkit.org/show_bug.cgi?id=266419

Reviewed by Jonathan Bedard.

We added retry in 271774@main to upload-file-to-s3.
However, that doesn't retry in the case when the request fails with non 200 
status_code.
We should retry in those cases as well.

* Tools/Scripts/upload-file-to-url:
(upload):

Canonical link: https://commits.webkit.org/272052@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 816628: [ews] macOS tester queues are failing to download ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81662800f1e4176871b60575e891194c1debe327
  
https://github.com/WebKit/WebKit/commit/81662800f1e4176871b60575e891194c1debe327
  Author: Aakash Jain 
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  [ews] macOS tester queues are failing to download archives
https://bugs.webkit.org/show_bug.cgi?id=266339

Reviewed by Jonathan Bedard and Ryan Haddad.

We do not need to explicitly state the architecture in triggered queues, they
automatically get it from the parent queue through the trigger step. It is
better to let it be handled automatically, so that when we change architecture
for builder queues, tester queues get it automatically.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/271985@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 952dc0: upload-file-to-url should print file size in MB

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 952dc0fc914bd136281afdcf40f58fa8d892904b
  
https://github.com/WebKit/WebKit/commit/952dc0fc914bd136281afdcf40f58fa8d892904b
  Author: Aakash Jain 
  Date:   2023-12-12 (Tue, 12 Dec 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  upload-file-to-url should print file size in MB
https://bugs.webkit.org/show_bug.cgi?id=266142

Reviewed by Jonathan Bedard.

Files being uploaded are several hundred MBs, so better to print the size in MB.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/271937@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2af122: [ews] Increase s3 presigned url validity duration

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2af1228023a0c31d84f27e3e4b867deb06496f73
  
https://github.com/WebKit/WebKit/commit/2af1228023a0c31d84f27e3e4b867deb06496f73
  Author: Aakash Jain 
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
M Tools/CISupport/Shared/generate-s3-url

  Log Message:
  ---
  [ews] Increase s3 presigned url validity duration
https://bugs.webkit.org/show_bug.cgi?id=266143

Unreviewed follpw-up fix.

We increased the timeout for s3 upload to 10 minutes in 
https://github.com/WebKit/WebKit/pull/21545
and then added retries in https://github.com/WebKit/WebKit/pull/21547

We need to increase s3 presigned url validity duration as well, otherwise by 
the time we retry,
s3 url would have expired.

* Tools/CISupport/Shared/generate-s3-url:
(generateS3URL):

Canonical link: https://commits.webkit.org/271802@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e9e0f3: [ews] Add retry to upload-file-to-url (follow-up fix)

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9e0f310a265ae5b050c08a7a2fcb630ea43beda
  
https://github.com/WebKit/WebKit/commit/e9e0f310a265ae5b050c08a7a2fcb630ea43beda
  Author: Aakash Jain 
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [ews] Add retry to upload-file-to-url (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=266119

Unreviewed follow-up fix.

Also increase the timeout for buildbot step.

* Tools/CISupport/ews-build/steps.py:
(UploadFileToS3.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:
* Tools/Scripts/upload-file-to-url:
(upload):

Canonical link: https://commits.webkit.org/271800@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 31db17: Add retry to upload-file-to-url

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 31db174057c23ab1b37dbf3b1cc96a85cd8c6741
  
https://github.com/WebKit/WebKit/commit/31db174057c23ab1b37dbf3b1cc96a85cd8c6741
  Author: Aakash Jain 
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  Add retry to upload-file-to-url
https://bugs.webkit.org/show_bug.cgi?id=266119

Reviewed by Elliott Williams.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/271774@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 166116: [ews-app] Prevent uat instance from updating GitHu...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1661161210c4013acda53e3c76633593c10926b9
  
https://github.com/WebKit/WebKit/commit/1661161210c4013acda53e3c76633593c10926b9
  Author: Aakash Jain 
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py

  Log Message:
  ---
  [ews-app] Prevent uat instance from updating GitHub PRs
https://bugs.webkit.org/show_bug.cgi?id=248238

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS.add_or_update_comment_for_change_id):

Canonical link: https://commits.webkit.org/269815@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 79b291: [ews-build] Reduce threshold for stopping build du...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 79b2911c8639b5a7e3a0ad9f8413402a498c9827
  
https://github.com/WebKit/WebKit/commit/79b2911c8639b5a7e3a0ad9f8413402a498c9827
  Author: Aakash Jain 
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build] Reduce threshold for stopping build due to excessive logging in 
run-api-tests
https://bugs.webkit.org/show_bug.cgi?id=263603

Reviewed by Ryan Haddad.

In 269577@main we added a feature to stop builds that exceed a predefined 
threshold of log lines
in run-api-tests, in order to prevent overloading the server. It did work, but 
the limit was quite high,
and buildbot was already under too much load and took long time to actually 
stop the build.
We should reduce that limit. Also, I analyzed data from actual runs and most 
runs for api-tests are under
10k log lines. It's rare for a api test run to exceed 100k logs, and most of 
the time it does indicate some issue.

* Tools/CISupport/ews-build/steps.py:
(BuildLogLineObserver.parseOutputLine):
(RunAPITests):
(RunAPITests.parseOutputLine):
(RunAPITests.handleExcessiveLogging):

Canonical link: https://commits.webkit.org/269778@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d87254: [ews-build] run-api-tests step should fail builds ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d87254aa4b2936116573a8f1c6cac118dd78cb43
  
https://github.com/WebKit/WebKit/commit/d87254aa4b2936116573a8f1c6cac118dd78cb43
  Author: Aakash Jain 
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build] run-api-tests step should fail builds that exceed a predefined 
threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=263450

Reviewed by Jonathan Bedard and Elliott Williams.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.handleExcessiveLogging): Drive-by fix.
(RunAPITests): Stop subclassing from TestWithFailureCount which uses 
BufferLogObserver.
(RunAPITests.run):
(RunAPITests.parseOutputLine): Parse each log ling as it comes.
(RunAPITests.handleExcessiveLogging): Handle excessive logging by stopping the 
build.
(RunAPITests.getResultSummary): Custom failure message.
(RunAPITests.countFailures): Deleted. Re-implemented in parseOutputLine.

Canonical link: https://commits.webkit.org/269577@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cc544c: [ews] email about bot being in bad state should in...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc544c9c4912b9b7ddd16aaa185379d805631473
  
https://github.com/WebKit/WebKit/commit/cc544c9c4912b9b7ddd16aaa185379d805631473
  Author: Aakash Jain 
  Date:   2023-10-13 (Fri, 13 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] email about bot being in bad state should include more information
https://bugs.webkit.org/show_bug.cgi?id=263137

Reviewed by Jonathan Bedard.

This would help in quickly triaging if multiple failures are happening on same 
PR.
Similar to 264173@main.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKitWithoutChange.send_email_for_unexpected_build_failure):

Canonical link: https://commits.webkit.org/269316@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c7e557: [ews] Add Sonoma mapping to PrintConfiguration step

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c7e5572ce6af10c7b76b443717eab3d007e2b1ed
  
https://github.com/WebKit/WebKit/commit/c7e5572ce6af10c7b76b443717eab3d007e2b1ed
  Author: Aakash Jain 
  Date:   2023-10-13 (Fri, 13 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add Sonoma mapping to PrintConfiguration step
https://bugs.webkit.org/show_bug.cgi?id=263134

Reviewed by Ryan Haddad.

* Tools/CISupport/ews-build/steps.py:
(PrintConfiguration.convert_build_to_os_name): Add Sonoma to our version / name 
map.

Canonical link: https://commits.webkit.org/269315@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b54f6: [ews] Use passwords.json instead of environment va...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b54f623ec6249b2c2835048e0bc0fe647be2b1b
  
https://github.com/WebKit/WebKit/commit/8b54f623ec6249b2c2835048e0bc0fe647be2b1b
  Author: Aakash Jain 
  Date:   2023-10-11 (Wed, 11 Oct 2023)

  Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/send_email.py

  Log Message:
  ---
  [ews] Use passwords.json instead of environment variables
https://bugs.webkit.org/show_bug.cgi?id=263009

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/events.py:
* Tools/CISupport/ews-build/send_email.py:

Canonical link: https://commits.webkit.org/269202@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a4c5c5: [build.webkit.org] download-built-product step fai...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4c5c55d46c169e9e4aa886d5d3591bda93a28bf
  
https://github.com/WebKit/WebKit/commit/a4c5c55d46c169e9e4aa886d5d3591bda93a28bf
  Author: Aakash Jain 
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] download-built-product step fails on uat instances
https://bugs.webkit.org/show_bug.cgi?id=262371

Reviewed by Ryan Haddad.

finished() was used in old-style steps. This step was changed to new-style step
in 264202@main.

* Tools/CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct.run):

Canonical link: https://commits.webkit.org/268652@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6e0343: [build.webkit.org] Use passwords.json instead of e...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e0343960cafd78e5401985f6e487a305467d201
  
https://github.com/WebKit/WebKit/commit/6e0343960cafd78e5401985f6e487a305467d201
  Author: Aakash Jain 
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg

  Log Message:
  ---
  [build.webkit.org] Use passwords.json instead of environment variables
https://bugs.webkit.org/show_bug.cgi?id=261907

Reviewed by Ryan Haddad.

* Tools/CISupport/build-webkit-org/master.cfg:

Canonical link: https://commits.webkit.org/268277@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dbba9e: [build.webkit.org] run-api-tests step should fail ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dbba9e878ad1cc2a7bc39f7b857fc85636a9b5ce
  
https://github.com/WebKit/WebKit/commit/dbba9e878ad1cc2a7bc39f7b857fc85636a9b5ce
  Author: Aakash Jain 
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] run-api-tests step should fail builds that exceed a 
predefined threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=261839

Reviewed by Jonathan Bedard.

* Tools/CISupport/build-webkit-org/steps.py:
(RunAPITests):
(RunAPITests.parseOutputLine):
(RunAPITests.handleExcessiveLogging):
(RunAPITests.getResultSummary):

Canonical link: https://commits.webkit.org/268273@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2aec77: [ews-app] Github ews status-bubble hover over mess...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2aec77b1f6f2accd80bb717e38dd79f1748ae310
  
https://github.com/WebKit/WebKit/commit/2aec77b1f6f2accd80bb717e38dd79f1748ae310
  Author: Aakash Jain 
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews-app] Github ews status-bubble hover over message might be incorrect in 
case of failure
https://bugs.webkit.org/show_bug.cgi?id=261897

Reviewed by Ryan Haddad.

We limited the steps for which we send info from buildbot to django app in 
261168@main.
Various analyze-* steps were not included in that list, which cause djano app 
to pick incorrect
step to generate hover-over message. To generate the hover-over message in case 
of failure,we uses the
information from the last failed step. So missing the analyze-* step cause 
djano app to pick incorrect step.

* Tools/CISupport/ews-build/events.py:

Canonical link: https://commits.webkit.org/268266@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0e414d: [build.webkit.org] layout-tests step should fail b...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e414dda15b582f8936991071d07605d850c9a3e
  
https://github.com/WebKit/WebKit/commit/0e414dda15b582f8936991071d07605d850c9a3e
  Author: Aakash Jain 
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] layout-tests step should fail builds that exceed a 
predefined threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=261836

Reviewed by Jonathan Bedard.

* Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit.handleExcessiveLogging):
(CompileWebKit.getResultSummary):
(RunWebKitTests):
(RunWebKitTests.parseOutputLine):
(RunWebKitTests.getResultSummary):
(RunWebKitTests.handleExcessiveLogging):
(RunWebDriverTests.getResultSummary):
(RunWebDriverTests.handleExcessiveLogging):

Canonical link: https://commits.webkit.org/268247@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5d3a04: [build.webkit.org] webdriver-test step should fail...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d3a040a8b27a0bd5148a70fa43e8fae75a11c4f
  
https://github.com/WebKit/WebKit/commit/5d3a040a8b27a0bd5148a70fa43e8fae75a11c4f
  Author: Aakash Jain 
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] webdriver-test step should fail builds that exceed a 
predefined threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=261699

Reviewed by Jonathan Bedard.

* Tools/CISupport/build-webkit-org/steps.py:
(RunWebDriverTests):
(RunWebDriverTests.start):
(RunWebDriverTests.getResultSummary):
(RunWebDriverTests.parseOutputLine):
(RunWebDriverTests.handleExcessiveLogging):
(RunWebDriverTests.commandComplete): Deleted.
(RunWebDriverTests.evaluateCommand): Deleted.
(RunWebDriverTests.getText): Deleted.
(RunWebDriverTests.getText2): Deleted.

Canonical link: https://commits.webkit.org/268094@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e6adef: [build.webkit.org] compile-webkit step should fail...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6adefb9e86216f9688a0bbcc6afa67a787953fc
  
https://github.com/WebKit/WebKit/commit/e6adefb9e86216f9688a0bbcc6afa67a787953fc
  Author: Aakash Jain 
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  ---
  [build.webkit.org] compile-webkit step should fail builds that exceed a 
predefined threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=261614

Reviewed by Jonathan Bedard.

* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit):
(CompileWebKit.parseOutputLine):
(CompileWebKit.handleExcessiveLogging):
(CompileWebKit.getResultSummary):
(Compile32bitJSC):
(CompileJSCOnly):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
(TestCompileWebKit.test_failure):
(TestCompileJSCOnly.test_failure):

Canonical link: https://commits.webkit.org/268034@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d2c66: [ews] compile-webkit step should fail builds that ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d2c662836f451b7baef89a705710692703eb31b
  
https://github.com/WebKit/WebKit/commit/9d2c662836f451b7baef89a705710692703eb31b
  Author: Aakash Jain 
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] compile-webkit step should fail builds that exceed a predefined 
threshold of log lines
https://bugs.webkit.org/show_bug.cgi?id=261569

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(ParseByLineLogObserver):
(ParseByLineLogObserver.__init__):
(ParseByLineLogObserver.consumeLineGenerator):
(BuildLogLineObserver):
(BuildLogLineObserver.__init__):
(BuildLogLineObserver.parseOutputLine):
(CompileWebKit.__init__):
(CompileWebKit.start):
(CompileWebKit.handleExcessiveLogging):
(CompileWebKit.getResultSummary):
(BuildLogLineObserver.outLineReceived): Deleted.

Canonical link: https://commits.webkit.org/268017@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b25c98: [build.webkit.org] Remove unused imports in steps.py

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b25c98be626a3295a5205025e975a7385366edb9
  
https://github.com/WebKit/WebKit/commit/b25c98be626a3295a5205025e975a7385366edb9
  Author: Aakash Jain 
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  [build.webkit.org] Remove unused imports in steps.py
https://bugs.webkit.org/show_bug.cgi?id=261334

Reviewed by Alexey Proskuryakov and Jonathan Bedard.

* Tools/CISupport/build-webkit-org/steps.py:

Canonical link: https://commits.webkit.org/267794@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 73ccfa: [build.webkit.org] Remove old dead code related to...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73ccfaa3b09716ab05f0bbebbfd3d7e1ae32917a
  
https://github.com/WebKit/WebKit/commit/73ccfaa3b09716ab05f0bbebbfd3d7e1ae32917a
  Author: Aakash Jain 
  Date:   2023-09-07 (Thu, 07 Sep 2023)

  Changed paths:
R Tools/CISupport/build-webkit-org/make_passwords_json.py

  Log Message:
  ---
  [build.webkit.org] Remove old dead code related to authentication - part 2
https://bugs.webkit.org/show_bug.cgi?id=261291

Reviewed by Alexey Proskuryakov.

make_passwords_json.py is dead code. Deleting it.

* Tools/CISupport/build-webkit-org/make_passwords_json.py: Removed.

Canonical link: https://commits.webkit.org/267752@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] afae26: merge-queue is marking builds as FAILURE when it s...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: afae26e9504066af8d4d928962ad762d596c4fc4
  
https://github.com/WebKit/WebKit/commit/afae26e9504066af8d4d928962ad762d596c4fc4
  Author: Aakash Jain 
  Date:   2023-08-14 (Mon, 14 Aug 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  merge-queue is marking builds as FAILURE when it successfully lands PR after 
retry
https://bugs.webkit.org/show_bug.cgi?id=234644

Reviewed by Jonathan Bedard.

Set overall build status as SUCCESS (green) if the commit was successful.

* Tools/CISupport/ews-build/steps.py:
(SetBuildSummary.start):

Canonical link: https://commits.webkit.org/266880@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad0590: [ews] mac-wk2 build marked as green even though it...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad0590629fe039f6c156050f08c73eceb23a1a45
  
https://github.com/WebKit/WebKit/commit/ad0590629fe039f6c156050f08c73eceb23a1a45
  Author: Aakash Jain 
  Date:   2023-08-11 (Fri, 11 Aug 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] mac-wk2 build marked as green even though it found failure in stress 
mode
https://bugs.webkit.org/show_bug.cgi?id=260020

Reviewed by Jonathan Bedard.

Check if stress mode already set build_summary before updating it.
Also mark build as failure if stress mode detected failures.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.evaluateCommand):
(RunWebKitTestsInStressMode): Updated the failure text to be more clear.
(ReRunWebKitTests.evaluateCommand):
(AnalyzeLayoutTestsResults.report_pre_existing_failures):
(SetBuildSummary.start):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/266824@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a65266: [ews] Increase timeout for upload-file-to-url

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6526615dff2a661aa9e90f412ca4bb6c4431b2f
  
https://github.com/WebKit/WebKit/commit/a6526615dff2a661aa9e90f412ca4bb6c4431b2f
  Author: Aakash Jain 
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [ews] Increase timeout for upload-file-to-url
https://bugs.webkit.org/show_bug.cgi?id=259992

Reviewed by Ryan Haddad.

Increase the timeout in the script to avoid timeout failures. Also
increase timeout for buildbot step.

* Tools/Scripts/upload-file-to-url:
* Tools/CISupport/ews-build/steps.py:
(UploadFileToS3.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/266740@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 84a762: [ews] upload-to-s3 fails without any logs

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84a762a13ce17bb1ca9d20e5efb05534bddb9f1d
  
https://github.com/WebKit/WebKit/commit/84a762a13ce17bb1ca9d20e5efb05534bddb9f1d
  Author: Aakash Jain 
  Date:   2023-08-09 (Wed, 09 Aug 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] upload-to-s3 fails without any logs
https://bugs.webkit.org/show_bug.cgi?id=259929

Rubber-stamped by Ryan Haddad.

- Add more logs to cover scenarios when UploadFileToS3 step exits pre-maturely.
- Add more logging to GenerateS3URL to help in debugging. This logging goes to
buildbot server.
- Make GenerateS3URL fail when the url isn't generated properly.

* Tools/CISupport/ews-build/steps.py:
(UploadFileToS3):
(UploadFileToS3.run):
(GenerateS3URL.finished):

Canonical link: https://commits.webkit.org/266722@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c68c71: [ews] Add more logging to upload-file-to-url

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c68c71ed51aa5948b7ebd4260d2c6a829b458327
  
https://github.com/WebKit/WebKit/commit/c68c71ed51aa5948b7ebd4260d2c6a829b458327
  Author: Aakash Jain 
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [ews] Add more logging to upload-file-to-url
https://bugs.webkit.org/show_bug.cgi?id=259803

Reviewed by Ryan Haddad.

Add more logging to upload-file-to-url to help debug issues when it fails.

* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/266556@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ed562: Improve error message when webkitbot fails to find...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ed56214691e441804a37eaed0d57bb0dd51f22b
  
https://github.com/WebKit/WebKit/commit/9ed56214691e441804a37eaed0d57bb0dd51f22b
  Author: Aakash Jain 
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py

  Log Message:
  ---
  Improve error message when webkitbot fails to find identifier
https://bugs.webkit.org/show_bug.cgi?id=259477

Reviewed by Ryan Haddad.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

Canonical link: https://commits.webkit.org/266291@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 231cc6: [build.webkit.org] Remove old dead code related to...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 231cc6abf642fd85f6fe102e8ebb0e422fc839aa
  
https://github.com/WebKit/WebKit/commit/231cc6abf642fd85f6fe102e8ebb0e422fc839aa
  Author: Aakash Jain 
  Date:   2023-06-14 (Wed, 14 Jun 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/README
R Tools/CISupport/build-webkit-org/committer_auth.py
R Tools/CISupport/build-webkit-org/htdigestparser.py
R Tools/CISupport/build-webkit-org/htdigestparser_unittest.py

  Log Message:
  ---
  [build.webkit.org] Remove old dead code related to authentication
https://bugs.webkit.org/show_bug.cgi?id=258086

Reviewed by Ryan Haddad.

Remove old dead code related to authentication. We now have 'Login with Github' 
functionality.
We don't need this old custom code. Also this is dead code since we upgraded 
from buildbot 0.8 to newer version.

* Tools/CISupport/build-webkit-org/README:
* Tools/CISupport/build-webkit-org/committer_auth.py: Removed.
* Tools/CISupport/build-webkit-org/htdigestparser.py: Removed.
* Tools/CISupport/build-webkit-org/htdigestparser_unittest.py: Removed.

Canonical link: https://commits.webkit.org/265161@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 328332: REGRESSION(264798@main): Archive-minified-built-pr...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 328332879f73f577f06523f673458638fa53c53c
  
https://github.com/WebKit/WebKit/commit/328332879f73f577f06523f673458638fa53c53c
  Author: Aakash Jain 
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  REGRESSION(264798@main): Archive-minified-built-product is failing due to 
extra argument "archive"
https://bugs.webkit.org/show_bug.cgi?id=258038

Reviewed by Dewei Zhu.

* Tools/CISupport/build-webkit-org/steps.py:
(ArchiveMinifiedBuiltProduct):
(ArchiveMinifiedBuiltProduct.run):

Canonical link: https://commits.webkit.org/265131@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9ee08e: [ews] email about Infrastructure issue should incl...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ee08e81f7d26f3fde69650b999482fe95c21f0f
  
https://github.com/WebKit/WebKit/commit/9ee08e81f7d26f3fde69650b999482fe95c21f0f
  Author: Aakash Jain 
  Date:   2023-05-17 (Wed, 17 May 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] email about Infrastructure issue should include PR information
https://bugs.webkit.org/show_bug.cgi?id=256913

Reviewed by Ryan Haddad.

This would help in quickly triaging if multiple failures are happening on same 
PR.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.send_email_for_infrastructure_issue):

Canonical link: https://commits.webkit.org/264173@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 37f8d2: [ews] validate-change fails with exception sometimes

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37f8d2f0eb10a67483252c38fcf3494a44d11acf
  
https://github.com/WebKit/WebKit/commit/37f8d2f0eb10a67483252c38fcf3494a44d11acf
  Author: Aakash Jain 
  Date:   2023-05-04 (Thu, 04 May 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] validate-change fails with exception sometimes
https://bugs.webkit.org/show_bug.cgi?id=256315

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.get_patch_json):
(BugzillaMixin.get_bug_json):

Canonical link: https://commits.webkit.org/263678@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e9ec1: REGRESSION: iOS layout tests intermittently failin...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e9ec190c7f6e5d6b05a2a71a93a96ec4bffafba
  
https://github.com/WebKit/WebKit/commit/2e9ec190c7f6e5d6b05a2a71a93a96ec4bffafba
  Author: Aakash Jain 
  Date:   2023-05-03 (Wed, 03 May 2023)

  Changed paths:
M Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

  Log Message:
  ---
  REGRESSION: iOS layout tests intermittently failing with TypeError: 
'NoneType' object is not subscriptable in _test_passes_fuzzy_matching
https://bugs.webkit.org/show_bug.cgi?id=255873

Reviewed by Simon Fraser.

Check if fuzzy_result is None before accessing it.

* Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._test_passes_fuzzy_matching):

Canonical link: https://commits.webkit.org/263649@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d573b8: [ews] Expected additionalArguments frequently miss...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d573b83aa2c218b96c855021965c9a683f231274
  
https://github.com/WebKit/WebKit/commit/d573b83aa2c218b96c855021965c9a683f231274
  Author: Aakash Jain 
  Date:   2023-04-25 (Tue, 25 Apr 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Expected additionalArguments frequently missing from iOS layout test 
queues
https://bugs.webkit.org/show_bug.cgi?id=255742

Reviewed by Ryan Haddad.

additionalArguments were missing because in CompileWebKit class (and 
sub-classes), we were inadvertently removing
them. Especially compile-webkit-without-change step was the one removing the 
additionalArguments. This accessed build property
and removed various values from it, buy since a list is accessed by reference, 
original property was also modified.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit): Do not explicitly remove arguments, instead just check if the 
additionalArguments is within valid list for that step.
(RunWebKitTests): Drive-by fix. Code refactoring to adopt clener approach to 
handle additionalArguments, using ENABLE_ADDITIONAL_ARGUMENTS.
(RunWebKitTestsInStressMode): Ditto.
(RunWebKitTestsInStressMode.setLayoutTestCommand): Ditto.
(Trigger.propertiesToPassToTriggers): Revert previous attempt to fix this issue.

Canonical link: https://commits.webkit.org/263387@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b5fe9: [ews] upload-file-to-url can sometimes get stuck i...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b5fe9ed475ad9209a25ef5c045c53f269b95bd6
  
https://github.com/WebKit/WebKit/commit/8b5fe9ed475ad9209a25ef5c045c53f269b95bd6
  Author: Aakash Jain 
  Date:   2023-04-21 (Fri, 21 Apr 2023)

  Changed paths:
M Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [ews] upload-file-to-url can sometimes get stuck indefinitely
https://bugs.webkit.org/show_bug.cgi?id=255799

Reviewed by Ryan Haddad.

Specify a timeout so that the requests can not get stuck indefinitely.
* Tools/Scripts/upload-file-to-url:

Canonical link: https://commits.webkit.org/263255@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d01d57: [ews] Add logging when FindModifiedLayoutTests fai...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d01d57322f191dedd7460d99966429bb33bf5d13
  
https://github.com/WebKit/WebKit/commit/d01d57322f191dedd7460d99966429bb33bf5d13
  Author: Aakash Jain 
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Add logging when FindModifiedLayoutTests fails to access the PR content
https://bugs.webkit.org/show_bug.cgi?id=255740

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(FindModifiedLayoutTests.start):

Canonical link: https://commits.webkit.org/263193@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aeba31: [ews] Add unit-tests for GenerateS3URL and UploadF...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aeba312790f6ecacc4d0e829fd29492d182171b2
  
https://github.com/WebKit/WebKit/commit/aeba312790f6ecacc4d0e829fd29492d182171b2
  Author: Aakash Jain 
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] Add unit-tests for GenerateS3URL and UploadFileToS3 steps
https://bugs.webkit.org/show_bug.cgi?id=255471

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps_unittest.py:
(TestGenerateS3URL):
(TestUploadFileToS3):

Canonical link: https://commits.webkit.org/263023@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f2d4b2: EWS bots should upload archives directly to S3

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2d4b23fbdc9f771c30dbb5f4f0df4149a28a4b7
  
https://github.com/WebKit/WebKit/commit/f2d4b23fbdc9f771c30dbb5f4f0df4149a28a4b7
  Author: Aakash Jain 
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
A Tools/CISupport/Shared/generate-s3-url
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  EWS bots should upload archives directly to S3
https://bugs.webkit.org/show_bug.cgi?id=255339

Reviewed by Ryan Haddad.

Server will generate a pre-signed url in each build, securely pass it to the
bot, and bot will upload the archive directly to S3. In case the upload fails, 
we
fallback to previous approach of bot uploading to master and master tranferring 
to S3.

* Tools/CISupport/Shared/generate-s3-url: Script to generate pre-signed url, 
runs on master.
* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.evaluateCommand):
(UploadFileToS3): Step to run on bot to upload archive directly to S3.
(GenerateS3URL): Step to generate pre-signed url.

Canonical link: https://commits.webkit.org/262927@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ab2b21: [ews] Add a script to upload a file to given url

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab2b21fb6389a635366adfb87663046d4f3945af
  
https://github.com/WebKit/WebKit/commit/ab2b21fb6389a635366adfb87663046d4f3945af
  Author: Aakash Jain 
  Date:   2023-04-12 (Wed, 12 Apr 2023)

  Changed paths:
A Tools/Scripts/upload-file-to-url

  Log Message:
  ---
  [ews] Add a script to upload a file to given url
https://bugs.webkit.org/show_bug.cgi?id=255340

Reviewed by Ryan Haddad.

* Tools/Scripts/upload-file-to-url: Added.

Canonical link: https://commits.webkit.org/262888@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e8d924: [ews] uat instance builds showing up on GitHub PRs

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8d924df4eda290ab11da2fd34c35ebae6f16e18
  
https://github.com/WebKit/WebKit/commit/e8d924df4eda290ab11da2fd34c35ebae6f16e18
  Author: Aakash Jain 
  Date:   2023-04-03 (Mon, 03 Apr 2023)

  Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/master.cfg
M Tools/CISupport/ews-build/steps.py
A Tools/CISupport/ews-build/utils.py

  Log Message:
  ---
  [ews] uat instance builds showing up on GitHub PRs
https://bugs.webkit.org/show_bug.cgi?id=254928

Reviewed by Jonathan Bedard.

Do not send data directly to Github on uat instance.
Also modified to read passwords.json instead of relying on environment 
variables.

* Tools/CISupport/ews-build/events.py:
* Tools/CISupport/ews-build/master.cfg:
(load_password): Moved to utils.py
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/utils.py: Added.

Canonical link: https://commits.webkit.org/262527@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b6a2d7: [ews] Improve input validation in ews django app

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6a2d70d7c8718b7335b65f29fcabd9235d237c7
  
https://github.com/WebKit/WebKit/commit/b6a2d70d7c8718b7335b65f29fcabd9235d237c7
  Author: Aakash Jain 
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-app/ews/views/retrypatch.py

  Log Message:
  ---
  [ews] Improve input validation in ews django app
https://bugs.webkit.org/show_bug.cgi?id=253911

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-app/ews/views/retrypatch.py:
(RetryPatch.post):

Canonical link: https://commits.webkit.org/261655@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41f47a: [ews] Allow any WebKit committer to stop ongoing b...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41f47a0b64bd15c6fbb39b800f9327432d4935f6
  
https://github.com/WebKit/WebKit/commit/41f47a0b64bd15c6fbb39b800f9327432d4935f6
  Author: Aakash Jain 
  Date:   2023-03-14 (Tue, 14 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews] Allow any WebKit committer to stop ongoing build
https://bugs.webkit.org/show_bug.cgi?id=253669

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/261654@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a358af: EWS unit-tests are getting stuck trying to talk to...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a358af782fce150ac18f4008d7071989786097e7
  
https://github.com/WebKit/WebKit/commit/a358af782fce150ac18f4008d7071989786097e7
  Author: Aakash Jain 
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  EWS unit-tests are getting stuck trying to talk to live bugzilla instance
https://bugs.webkit.org/show_bug.cgi?id=253839

Reviewed by Ryan Haddad.

Unit-tests shouldn't talk to live bugzilla instance. In fact EWS bots do
not store any bugzilla credentials and IIRC shouldn't talk to bugzilla.

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/261585@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c58a5c: [ews] Improve logging in case of email sending fai...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c58a5c443d87c8c272b999fd07ac05c0a24fcccb
  
https://github.com/WebKit/WebKit/commit/c58a5c443d87c8c272b999fd07ac05c0a24fcccb
  Author: Aakash Jain 
  Date:   2023-03-09 (Thu, 09 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] Improve logging in case of email sending failure
https://bugs.webkit.org/show_bug.cgi?id=253100

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(ValidateChange.send_email_for_github_failure):
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):

Canonical link: https://commits.webkit.org/261423@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 25e7f0: [ews] Reduce excessive logging due to github webhooks

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25e7f0c5753514ce60c760ce326e0d170aee1ae6
  
https://github.com/WebKit/WebKit/commit/25e7f0c5753514ce60c760ce326e0d170aee1ae6
  Author: Aakash Jain 
  Date:   2023-03-08 (Wed, 08 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews] Reduce excessive logging due to github webhooks
https://bugs.webkit.org/show_bug.cgi?id=253529

Reviewed by Jonathan Bedard.

Reduce excessive logging due to github webhooks. This huge logging makes 
twistd.log unreadable and isn't really useful to use.

* Tools/CISupport/ews-build/events.py:
(logging_disabled): context manager to disable the log.msg function 
appropriately.
(logging_disabled.__init__):
(logging_disabled.log_disabled):
(logging_disabled.__enter__):
(logging_disabled.__exit__):
(GitHubEventHandlerNoEdits._get_payload):
(GitHubEventHandlerNoEdits.handle_pull_request): Updated logs to include hash 
(to help in debugging ews history of a hash).

Canonical link: https://commits.webkit.org/261373@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 89117e: [ews] block-pull-request should indicate in UI the...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89117ea44ecca688a1b1458da5d9597735417322
  
https://github.com/WebKit/WebKit/commit/89117ea44ecca688a1b1458da5d9597735417322
  Author: Aakash Jain 
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] block-pull-request should indicate in UI the reason for being skipped.
https://bugs.webkit.org/show_bug.cgi?id=253451

Reviewed by Jonathan Bedard.

block-pull-request should indicate in UI the reason for being skipped.
It has happenned few times that people asked why was block-pull-request step 
skipped.

* Tools/CISupport/ews-build/steps.py:
(BlockPullRequest.run):

Canonical link: https://commits.webkit.org/261287@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ccc5e2: check-webkit-style should not complaint about svn ...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ccc5e22b725480194336b4a96969f48a251e9ccc
  
https://github.com/WebKit/WebKit/commit/ccc5e22b725480194336b4a96969f48a251e9ccc
  Author: Aakash Jain 
  Date:   2023-03-06 (Mon, 06 Mar 2023)

  Changed paths:
R Tools/Scripts/webkitpy/common/checksvnconfigfile.py
M Tools/Scripts/webkitpy/style/checkers/png.py
M Tools/Scripts/webkitpy/style/checkers/png_unittest.py
M Tools/Scripts/webkitpy/tool/commands/download.py
M Tools/Scripts/webkitpy/tool/steps/__init__.py
R Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py
R Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py

  Log Message:
  ---
  check-webkit-style should not complaint about svn related errors while 
checking png files
https://bugs.webkit.org/show_bug.cgi?id=253386

Reviewed by Jonathan Bedard.

Removed SVN related code from style checker for png files. We moved away from
SVN a while back.

* Tools/Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.

Canonical link: https://commits.webkit.org/261272@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c0168: [ews] unsafe-merge-queue should validate commit ju...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c0168845d1eae59add0200638e4e846c03fbacd
  
https://github.com/WebKit/WebKit/commit/1c0168845d1eae59add0200638e4e846c03fbacd
  Author: Aakash Jain 
  Date:   2023-03-04 (Sat, 04 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews] unsafe-merge-queue should validate commit just before merging
https://bugs.webkit.org/show_bug.cgi?id=253347

Reviewed by Jonathan Bedard.

unsafe-merge-queue should validate commit just before merging. Validation should
be done as close to the merging as possible, since it's possible that somebody 
removed
the unsafe-merge-queue label at the last moment.

* Tools/CISupport/ews-build/factories.py:
* Tools/CISupport/ews-build/factories_unittest.py:

Canonical link: https://commits.webkit.org/261220@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 41910e: [ews] Send only important steps info to ews-app

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41910e61bbb5a7db89c0689a6e2819853b66fb88
  
https://github.com/WebKit/WebKit/commit/41910e61bbb5a7db89c0689a6e2819853b66fb88
  Author: Aakash Jain 
  Date:   2023-03-03 (Fri, 03 Mar 2023)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py
M Tools/CISupport/ews-build/events.py

  Log Message:
  ---
  [ews] Send only important steps info to ews-app
https://bugs.webkit.org/show_bug.cgi?id=253341

Reviewed by Ryan Haddad.

EWS (buildbot) should send only important steps info to ews-app. Currently it's
sending information of every step start/stop to ews django app. Then django app
filters out which steps info to use. Instead EWS should just filter out the step
and send only required info to ews-app.

Also, step information is only used to display status-bubble hover-over summary.
Step information in hover-over messages are less useful in GitHub as compared 
to bugzilla,
since there are limitations in Github on how we can display hover-over messages.
We should only display useful information in hover-over messages.

Therefore we should send step information for only the important steps (which we
really want to show in hover-over messages). This would save thousands of 
network
requests every hour from buildbot-server, and would help with load on buildbot 
server.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS._should_display_step): Deleted.
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
(StatusBubble._steps_messages_from_multiple_builds):
(StatusBubble._should_display_step): Deleted.
* Tools/CISupport/ews-build/events.py:
(Events): Added list of steps which should be reported to ews django app.
(Events.stepStarted):
(Events.stepFinished):

Canonical link: https://commits.webkit.org/261168@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2609ef: Regression 257767@main: WebKitPerl-Tests-EWS build...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2609ef79bbc2d841e61d17a5001f550a832a33e3
  
https://github.com/WebKit/WebKit/commit/2609ef79bbc2d841e61d17a5001f550a832a33e3
  Author: Aakash Jain 
  Date:   2023-02-27 (Mon, 27 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Regression 257767@main: WebKitPerl-Tests-EWS build marked as SUCCESS despite 
failing tests
https://bugs.webkit.org/show_bug.cgi?id=253018

Reviewed by Jonathan Bedard.

Matching the base class appropriately.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitPerlTests.evaluateCommand):
(ReRunWebKitPerlTests.evaluateCommand):

Canonical link: https://commits.webkit.org/260900@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dcfcca: Remove windows code from build.webkit.org

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcfcca1924313cd7feacd61d0c65d86ce157a506
  
https://github.com/WebKit/WebKit/commit/dcfcca1924313cd7feacd61d0c65d86ce157a506
  Author: Aakash Jain 
  Date:   2023-02-24 (Fri, 24 Feb 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/loadConfig_unittest.py
M Tools/CISupport/delete-stale-build-files

  Log Message:
  ---
  Remove windows code from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=252929

Reviewed by Ryan Haddad.

As announced on webkit-dev, we are decommissioning the Apple Windows port.
We already removed the queues. We should remove the code specific to windows 
from build.webkit.org

* Tools/CISupport/build-webkit-org/loadConfig_unittest.py:
* Tools/CISupport/delete-stale-build-files:

Canonical link: https://commits.webkit.org/260817@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7be92e: Implement Login with GitHub on build.webkit.org

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7be92ea7008d99047bd075d5f758ab9487cbc197
  
https://github.com/WebKit/WebKit/commit/7be92ea7008d99047bd075d5f758ab9487cbc197
  Author: Aakash Jain 
  Date:   2023-02-23 (Thu, 23 Feb 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg

  Log Message:
  ---
  Implement Login with GitHub on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=252778

Reviewed by Ryan Haddad.

References:
https://docs.buildbot.net/latest/developer/auth.html
https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules

* Tools/CISupport/build-webkit-org/master.cfg:

Canonical link: https://commits.webkit.org/260763@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fc24cb: [build.webkit.org] Improve support for required ch...

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc24cb6aa35fab30f64f21e16cfe90d466ee1775
  
https://github.com/WebKit/WebKit/commit/fc24cb6aa35fab30f64f21e16cfe90d466ee1775
  Author: Aakash Jain 
  Date:   2023-02-22 (Wed, 22 Feb 2023)

  Changed paths:
M Tools/CISupport/build-webkit-org/master.cfg

  Log Message:
  ---
  [build.webkit.org] Improve support for required changes for uat/dev instance
https://bugs.webkit.org/show_bug.cgi?id=252764


Reviewed by Ryan Haddad.

Auto-detect the uat/dev instance and make changes accordingly.

* Tools/CISupport/build-webkit-org/master.cfg:

Canonical link: https://commits.webkit.org/260701@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a2a8bd: [ews] Implement Login with GitHub on EWS

[Aakash J]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2a8bd0fd59f404abcc2442605c566c8f4542f52
  
https://github.com/WebKit/WebKit/commit/a2a8bd0fd59f404abcc2442605c566c8f4542f52
  Author: Aakash Jain 
  Date:   2023-02-20 (Mon, 20 Feb 2023)

  Changed paths:
M Tools/CISupport/ews-build/master.cfg

  Log Message:
  ---
  [ews] Implement Login with GitHub on EWS
https://bugs.webkit.org/show_bug.cgi?id=235829


Reviewed by Jonathan Bedard.

References:
https://docs.buildbot.net/latest/developer/auth.html
https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules

* Tools/CISupport/ews-build/master.cfg:

Canonical link: https://commits.webkit.org/260531@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes