[webkit-changes] [WebKit/WebKit] 20f5c3: REGRESSION(288180@main): compile-webkit-without-ch...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 20f5c368817a02c8094708469254cb8965a0ff84
  
https://github.com/WebKit/WebKit/commit/20f5c368817a02c8094708469254cb8965a0ff84
  Author: Brianna Fan 
  Date:   2024-12-22 (Sun, 22 Dec 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  REGRESSION(288180@main): compile-webkit-without-change will fail if 
compile-webkit fails and infinitely retry the build
https://bugs.webkit.org/show_bug.cgi?id=285079
rdar://141909613

Unreviewed fix. Make 'build_failed' into a class variable instead of a shared 
build property.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.__init__):
(CompileWebKit.errorReceived):
(CompileWebKit.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/288231@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f2d5bd: [ews-build] iOS-17 Sim builds are silently failing...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f2d5bd4a206ed5cb227ee1ba50791278b07d4cc0
  
https://github.com/WebKit/WebKit/commit/f2d5bd4a206ed5cb227ee1ba50791278b07d4cc0
  Author: Brianna Fan 
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] iOS-17 Sim builds are silently failing due to Use of 
uninitialized value in string eq error
https://bugs.webkit.org/show_bug.cgi?id=283601
rdar://140444299

Reviewed by Ryan Haddad.

There should be errors if and only if there is a build failure.
If there are errors logged, set the build_failed property. Then, check this
property at the end of the build to ensure that there wasn't a silent failure.

* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.errorReceived):
(CompileWebKit.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/288180@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2a6522: Update clang for Safer-CPP to reduce false positiv...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a6522ef12f438a0e50ff961a3ac26df963bf36c
  
https://github.com/WebKit/WebKit/commit/2a6522ef12f438a0e50ff961a3ac26df963bf36c
  Author: Brianna Fan 
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
M Tools/CISupport/Shared/steps.py

  Log Message:
  ---
  Update clang for Safer-CPP to reduce false positives/negatives
https://bugs.webkit.org/show_bug.cgi?id=285035
rdar://141832365

Reviewed by Ryosuke Niwa.

* Tools/CISupport/Shared/steps.py:

Canonical link: https://commits.webkit.org/288176@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 694c6f: [build-webkit-org] World-Leaks-Tests download-buil...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 694c6f2e6809805e7da150997706da5d19bd240a
  
https://github.com/WebKit/WebKit/commit/694c6f2e6809805e7da150997706da5d19bd240a
  Author: Brianna Fan 
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/config.json

  Log Message:
  ---
  [build-webkit-org] World-Leaks-Tests download-built-product failing with 403
https://bugs.webkit.org/show_bug.cgi?id=285032
rdar://141831152

Reviewed by Ryan Haddad.

Change Apple-Sequoia-Release-World-Leaks-Tests scheduler to 'Triggerable' type
and set it to be triggered by 'Apple-Sequoia-Release-Build'.

* Tools/CISupport/build-webkit-org/config.json:

Canonical link: https://commits.webkit.org/288173@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 483f8e: [ews-build] macOS WK2 Intel tests and arm64 tests ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 483f8e31a7ad3e40cb3d9eeab99659ebf5464a05
  
https://github.com/WebKit/WebKit/commit/483f8e31a7ad3e40cb3d9eeab99659ebf5464a05
  Author: Brianna Fan 
  Date:   2024-12-20 (Fri, 20 Dec 2024)

  Changed paths:
M Tools/CISupport/Shared/generate-s3-url
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] macOS WK2 Intel tests and arm64 tests share generated S3 URLs
https://bugs.webkit.org/show_bug.cgi?id=284333
rdar://141183934

Reviewed by Ryan Haddad.

* Tools/CISupport/Shared/generate-s3-url:
(generateS3URL): Add additional suffix to file keys if specified.
(main): Add 'additions' option.

* Tools/CISupport/ews-build/steps.py: Add `additions=f'self.build.number'`
  to all .txt invocations of GenerateS3URL.
(CompileWebKit.follow_up_steps):
(RunJavaScriptCoreTests.evaluateCommand):
(RunWebKitTests.evaluateCommand):
(RunWebKitTestsInStressMode.evaluateCommand):
(ReRunWebKitTests.evaluateCommand):
(RunWebKitTestsWithoutChange.evaluateCommand):
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.evaluateCommand):
(RunWebKitTestsWithoutChangeRedTree.evaluateCommand):
(RunAPITests.run):

(GenerateS3URL.__init__): Add `additions` argument.
(GenerateS3URL.run):
(GenerateS3URL):
(GenerateS3URL.hideStepIf): Deleted.

* Tools/CISupport/ews-build/steps_unittest.py:
(TestGenerateS3URL.configureStep):
(TestGenerateS3URL.test_failure):

Canonical link: https://commits.webkit.org/288170@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 58deab: `git-webkit pr` raises when on detached HEAD

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58deabc6ad4703a9cc7bc54f7fdc0579f8f544cc
  
https://github.com/WebKit/WebKit/commit/58deabc6ad4703a9cc7bc54f7fdc0579f8f544cc
  Author: Brianna Fan 
  Date:   2024-12-18 (Wed, 18 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py

  Log Message:
  ---
  `git-webkit pr` raises when on detached HEAD
https://bugs.webkit.org/show_bug.cgi?id=284312
rdar://141172754

Reviewed by Sam Sneddon.

Move logic for validating whether a PR can be made on a branch
to Git.is_suitable_branch_for_pull_request.

A branch is invalid if:
1. It is None
2. It is a default branch (e.g. main)
3. It is a prod branch
4. It is a remote branch and does not match the dev branch pattern

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.is_suitable_branch_for_pull_request):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pull_request_branch_point):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:

Canonical link: https://commits.webkit.org/288027@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] beeff9: Update Brianna Fan's status to reviewer

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: beeff9484efd858b96a4b3e5c6fec6a141534140
  
https://github.com/WebKit/WebKit/commit/beeff9484efd858b96a4b3e5c6fec6a141534140
  Author: Brianna Fan 
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Update Brianna Fan's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=284833
rdar://141630622

Reviewed by Jonathan Bedard.

Update my contributor status :D

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/287957@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1e3c91: [git-webkit] fails with AttributeError in webkitsc...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e3c919e26c254c5a97fcf220343bba9ae67deda
  
https://github.com/WebKit/WebKit/commit/1e3c919e26c254c5a97fcf220343bba9ae67deda
  Author: Brianna Fan 
  Date:   2024-12-17 (Tue, 17 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py

  Log Message:
  ---
  [git-webkit] fails with AttributeError in webkitscmpy/contributor.py
https://bugs.webkit.org/show_bug.cgi?id=284826
rdar://136616946

Reviewed by Jonathan Bedard.

Skips when a contributor mapping is None.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py:
(Contributor.Mapping.__iter__):

Canonical link: https://commits.webkit.org/287952@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c2efb: Enforce Safer C++ Checks across all WebKit projects

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c2efb9f553ee9cb3cea3d5b878a68a951c60c4a
  
https://github.com/WebKit/WebKit/commit/9c2efb9f553ee9cb3cea3d5b878a68a951c60c4a
  Author: Brianna Fan 
  Date:   2024-12-13 (Fri, 13 Dec 2024)

  Changed paths:
A 
Source/JavaScriptCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A 
Source/JavaScriptCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
A Source/WTF/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A Source/WTF/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A Source/WTF/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WTF/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A Source/WTF/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A Source/WTF/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A Source/WTF/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A Source/WTF/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A Source/WTF/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
A Source/WebDriver/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A 
Source/WebDriver/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A Source/WebDriver/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebDriver/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A Source/WebDriver/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A 
Source/WebDriver/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A Source/WebDriver/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebDriver/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A 
Source/WebDriver/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A Source/WebGPU/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebGPU/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A Source/WebGPU/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A 
Source/WebInspectorUI/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
A 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/generate-dirty-files
M Tools/Scripts/update

[webkit-changes] [WebKit/WebKit] 029035: [git-webkit pr] Remove limit from pre-PR checks

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0290356c4504a6e4a4a65f3e169bb332c07b958b
  
https://github.com/WebKit/WebKit/commit/0290356c4504a6e4a4a65f3e169bb332c07b958b
  Author: Brianna Fan 
  Date:   2024-12-12 (Thu, 12 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  ---
  [git-webkit pr] Remove limit from pre-PR checks
https://bugs.webkit.org/show_bug.cgi?id=284577
rdar://141395853

Reviewed by Jonathan Bedard.

Add an infinite loop to pre_pr_checks :P
There shouldn't be a case in which it actually loops
in perpetuity due to the user input needed.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pre_pr_checks):

Canonical link: https://commits.webkit.org/287766@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8cf317: [Static Analyzer CI] Ignore warnings in DerivedSou...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8cf317bdb949ec068f83cbba0686042d5da9dc59
  
https://github.com/WebKit/WebKit/commit/8cf317bdb949ec068f83cbba0686042d5da9dc59
  Author: Brianna Fan 
  Date:   2024-12-11 (Wed, 11 Dec 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/generate-dirty-files

  Log Message:
  ---
  [Static Analyzer CI] Ignore warnings in DerivedSources in EWS
https://bugs.webkit.org/show_bug.cgi?id=284416
rdar://141249759

Reviewed by Ryosuke Niwa.

Do not truncate the path of files in DerivedSources so we can ignore any
files from DerivedSources that start with JS when comparing results.

Updated expectations accordingly.

* Tools/Scripts/compare-static-analysis-results:
(find_diff):
* Tools/Scripts/generate-dirty-files:
(find_project_results):

* Source/WebCore/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/287684@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f71e30: [Static Analyzer CI] Update clang to ef6397c4

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f71e30fd281651ee7ad56ac313788d675fde3736
  
https://github.com/WebKit/WebKit/commit/f71e30fd281651ee7ad56ac313788d675fde3736
  Author: Brianna Fan 
  Date:   2024-12-10 (Tue, 10 Dec 2024)

  Changed paths:
M Tools/CISupport/Shared/steps.py

  Log Message:
  ---
  [Static Analyzer CI] Update clang to ef6397c4
https://bugs.webkit.org/show_bug.cgi?id=284321
rdar://141176415

Reviewed by Ryan Haddad.

* Tools/CISupport/Shared/steps.py:

Canonical link: https://commits.webkit.org/287610@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dec8a5: [webkitpy] git-webkit revert --no-pr --no-bug fail...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dec8a5a198221db63c38f87869bf008954aeef6d
  
https://github.com/WebKit/WebKit/commit/dec8a5a198221db63c38f87869bf008954aeef6d
  Author: Brianna Fan 
  Date:   2024-12-09 (Mon, 09 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py

  Log Message:
  ---
  [webkitpy] git-webkit revert --no-pr --no-bug fails with "Please verify that 
the issue exists"
https://bugs.webkit.org/show_bug.cgi?id=283824
rdar://141044493

Reviewed by Jonathan Bedard.

Fixes the failure by removing the prompt for an issue.

Adds the following features:
- Skip auto-relation when --no-bug/--no-issue is set.
- The commit message will be populated without bug URLS.
- A branch will be created using the revert reason and have no associated bugs.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert.create_revert_commit_msg):
(Revert.main):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
(TestRevert):

Canonical link: https://commits.webkit.org/287555@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 273f4e: git-webkit added rdar:// link to Bugzilla when pos...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 273f4e3ba575c0dc66a5172499bf17dc9aa3440e
  
https://github.com/WebKit/WebKit/commit/273f4e3ba575c0dc66a5172499bf17dc9aa3440e
  Author: Brianna Fan 
  Date:   2024-12-06 (Fri, 06 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py

  Log Message:
  ---
  git-webkit added rdar:// link to Bugzilla when posting a PR for a 
cherry-picked branch commit
https://bugs.webkit.org/show_bug.cgi?id=284136
rdar://140073874

Reviewed by Sam Sneddon and Jonathan Bedard.

When there is an existing tracked bug, the user will now have three options:
1. Overwrite the pre-existing tracked bug with the new one
2. Skip CC-ing (helpful for cherry-picks)
3. Abort the entire process

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.cc_radar):

Canonical link: https://commits.webkit.org/287467@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 94fb48: [Static Analyzer CI] Filter unexpected results usi...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94fb4893473fce89ffca8bfc7a9dcab2842a14f6
  
https://github.com/WebKit/WebKit/commit/94fb4893473fce89ffca8bfc7a9dcab2842a14f6
  Author: Brianna Fan 
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Filter unexpected results using results.webkit.org to 
reduce build times on EWS
https://bugs.webkit.org/show_bug.cgi?id=282770
rdar://139393719

Reviewed by Jonathan Bedard.

Consult results.webkit.org on the first run of 
FindUnexpectedStaticAnalyzerResults to determine if
failures and successes on the PR are pre-existing. If so, we can filter those 
results out.

* Tools/CISupport/ews-build/steps.py:

(FindUnexpectedStaticAnalyzerResults):
- If self.expectations = True (1st run on PR):
  - Check results database for each unexpected result
   1. If it fails, fall back to rebuilding on ToT.
   2. If it succeeds with no changes, run GenerateSaferCPPResultsIndex, 
Delete, Archive,
  Upload, Extract, & Display results.
   3. If it succeeds with changes, run 
DownloadUnexpectedResultsFromMaster, DeleteStaticAnalyzerResults,
  GenerateSaferCPPResultsIndex, then Archive, Upload, Extract, & 
Display results.
- If self.expectations = False (2nd run on ToT):
  - These are not new changes and are already running.
  - Compare the PR and ToT results. Then run Archive, Upload, Extract, 
& Display results.
  - Upload ToT results to results.webkit.org.

(FindUnexpectedStaticAnalyzerResults.run): Add new logic for each case 
enumerated above.
(FindUnexpectedStaticAnalyzerResults.filter_results_using_results_db): Added.
(FindUnexpectedStaticAnalyzerResults.check_results_db): Added.
(FindUnexpectedStaticAnalyzerResults.find_unexpected_results): Added.
(FindUnexpectedStaticAnalyzerResults.createResultMessage): Added.

Canonical link: https://commits.webkit.org/287360@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e4d2d6: [Static Analyzer CI] Cannot tell what hash a warni...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e4d2d6ab1facc28375694804ff7b60ac8e232449
  
https://github.com/WebKit/WebKit/commit/e4d2d6ab1facc28375694804ff7b60ac8e232449
  Author: Brianna Fan 
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Cannot tell what hash a warning is for on PRs with many 
force-pushes
https://bugs.webkit.org/show_bug.cgi?id=281692
rdar://138143049

Reviewed by Jonathan Bedard.

Add the PR hash to the corresponding comment. This will help determine if a 
given build
is for the most recent push.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults.createComment):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/287357@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ee9eea: [ews-build] Add steps to support filtering safer-c...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee9eeaa4c7f099c8ad6cc1f8ddbfe87346545d46
  
https://github.com/WebKit/WebKit/commit/ee9eeaa4c7f099c8ad6cc1f8ddbfe87346545d46
  Author: Brianna Fan 
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] Add steps to support filtering safer-cpp-results with 
results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=283064
rdar://139814797

Reviewed by Jonathan Bedard.

These steps are needed after filtering safer-cpp-checks results using results 
database.
The buildbot master will filter results and modify unexpected_results.json 
file, so the
worker will need the updated file through DownloadUnexpectedResultsFromMaster.

With the updated results, we will need to re-generate the results index page 
using
GenerateSaferCPPResultsIndex.

Then, we want to delete full StaticAnalyzer results so they're not uploaded to
the master by using DeleteStaticAnalyzerResults.

(DownloadUnexpectedResultsFromMaster):
- If results database filters out results, we need to move the new 
unexpected_results.json file
  over to the worker from the master.
- This uses the pre-existing transfer.FileDownload step and is similar to 
DownloadBuiltProductFromMaster.

(DeleteStaticAnalyzerResults):
- Added if there are unexpected results. We don't want to upload the entire 
40GB+ results so
  this step deletes the specified StaticAnalyzer directory.

(GenerateSaferCPPResultsIndex):
- If there are unexpected results after filtering, we need to generate a 
new results index page
  that displays the results with links to each report.
- This is run on the worker and uses the unexpected_results.json file from 
DownloadUnexpectedResultsFromMaster.
- It also sets the 'unexpected_new_issues' property to be used by 
DisplaySaferCPPResults.

* Tools/CISupport/ews-build/steps_unittest.py: Added unittests for 
DownloadUnexpectedResultsFromMaster,
DeleteStaticAnalyzerResults, and GenerateSaferCPPResultsIndex.

Canonical link: https://commits.webkit.org/287229@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 11d225: [git-webkit] [pr] unable to create branches that m...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11d2259137716771fabba53a7febb6f30a30e3a8
  
https://github.com/WebKit/WebKit/commit/11d2259137716771fabba53a7febb6f30a30e3a8
  Author: Brianna Fan 
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py

  Log Message:
  ---
  [git-webkit] [pr] unable to create branches that match integration scheme via 
git-webkit pr
https://bugs.webkit.org/show_bug.cgi?id=283444
rdar://136986741

Reviewed by Jonathan Bedard.

Check that the current branch is not a development branch before trying to 
create
a new branch. This will allow PRs to be made directly from integration branches.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pull_request_branch_point):

Canonical link: https://commits.webkit.org/287226@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 82e704: REGRESSION: webkitbot fails to create Bugzilla bugs

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82e70476d461d1cbb3d04509a3fc257f62d11a52
  
https://github.com/WebKit/WebKit/commit/82e70476d461d1cbb3d04509a3fc257f62d11a52
  Author: Brianna Fan 
  Date:   2024-11-20 (Wed, 20 Nov 2024)

  Changed paths:
M Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py
M Websites/bugs.webkit.org/template/en/custom/bug/create/create.html.tmpl

  Log Message:
  ---
  REGRESSION: webkitbot fails to create Bugzilla bugs
https://bugs.webkit.org/show_bug.cgi?id=28
rdar://140159876

Reviewed by Sam Sneddon.

Submitting the form to create a new bug relies on mechanize.Browser.submit()
which in turn calls mechanize.HTMLForm.click(). Without specified args,
click() "will click on the first clickable control".

The recent bugzilla redesign added a new clickable button ("Save as Template")
which is what we're clicking instead of "Submit Bug".

This change adds an id to the "Submit Bug" button and passes it as
an argument to submit().

* Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.create_bug):
* Websites/bugs.webkit.org/template/en/custom/bug/create/create.html.tmpl:

Canonical link: https://commits.webkit.org/286863@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e577dc: Update Safer CPP expectations after updating clang

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e577dc8aa26ef91a90f48eef77101b7f01d4c370
  
https://github.com/WebKit/WebKit/commit/e577dc8aa26ef91a90f48eef77101b7f01d4c370
  Author: Brianna Fan 
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
M 
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Update Safer CPP expectations after updating clang

Reviewed by Ryosuke Niwa.

We updated clang to 9a8740e1, which uncovered new failures and cleaned up some
false positives.

* Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/286742@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 833b49: Update clang to enable 3 new Safer CPP checkers

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 833b49910cf24ea6e61381f03720c6dae41f510a
  
https://github.com/WebKit/WebKit/commit/833b49910cf24ea6e61381f03720c6dae41f510a
  Author: Brianna Fan 
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
M 
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
A Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A 
Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Tools/CISupport/Shared/steps.py
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Update clang to enable 3 new Safer CPP checkers
https://bugs.webkit.org/show_bug.cgi?id=283204
rdar://140004167

Reviewed by Ryosuke Niwa.

Update clang version and update expectations accordingly.

* Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: 
Added.
* Source/WebCore/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations: 
Added.
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations: 
Added.
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: 
Added.
* Source/WebKit/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations: 
Added.
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebKit/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations: 
Added.
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Tools/CISupport/Shared/steps.py:
* Tools/CISupport/ews-build/steps.py:

Canonical link: https://commits.webkit.org/286737@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1dfad9: [build-webkit-org] Update clang automatically for ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dfad921695d08b3dc86d29e432ed7f248b24915
  
https://github.com/WebKit/WebKit/commit/1dfad921695d08b3dc86d29e432ed7f248b24915
  Author: Brianna Fan 
  Date:   2024-11-15 (Fri, 15 Nov 2024)

  Changed paths:
A Tools/CISupport/Shared/__init__.py
M Tools/CISupport/Shared/download-and-install-build-tools
A Tools/CISupport/Shared/steps.py
A Tools/CISupport/Shared/steps_unittest.py
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
M Tools/CISupport/run-tests

  Log Message:
  ---
  [build-webkit-org] Update clang automatically for Safer-CPP-Checks
https://bugs.webkit.org/show_bug.cgi?id=283091
rdar://139818398

Reviewed by Ryan Haddad.

Run the following steps in SaferCPPChecks on build-webkit-org to automatically 
build clang.

Add InstallCMake, InstallNinja, PrintClangVersion, CheckoutLLVMProject, and 
UpdateClang
to Shared/steps.py as a first step towards consolidating similar code in 
ews-build and build-webkit-org.

* Tools/CISupport/Shared/__init__.py: Added.

* Tools/CISupport/Shared/download-and-install-build-tools:
(download_and_install):
- Add a command to remove the com.apple.quarantine attribute so that we 
don't hang on
  the first run of CMake.app.

* Tools/CISupport/Shared/steps.py:
- Classes moved from ews-build. No new code changes were made.
(ShellMixin):
(AddToLogMixin):
(InstallCMake):
(InstallNinja):
(CheckOutLLVMProject):
(UpdateClang):
(PrintClangVersion):
(PrintClangVersionAfterUpdate):

* Tools/CISupport/Shared/steps_unittest.py:
- Tests moved from ews-build. No new code changes were made.
(ExpectMasterShellCommand):
(BuildStepMixinAdditions):
(TestPrintClangVersion):
(TestCheckoutLLVMProject):
(TestUpdateClang):
(TestInstallCMake):
(TestInstallNinja):

* Tools/CISupport/build-webkit-org/factories.py:
(SaferCPPStaticAnalyzerFactory.__init__): Add steps mentioned above.

* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps): Add steps mentioned above.

* Tools/CISupport/ews-build/factories.py: Import Shared.

* Tools/CISupport/ews-build/steps.py: Deleted steps moved to Shared.

* Tools/CISupport/ews-build/steps_unittest.py: Deleted tests moved to Shared.
* Tools/CISupport/run-tests: Add 'Shared' to modules.

Canonical link: https://commits.webkit.org/286664@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b1c5f: [ews-build] Access the full 'results' endpoint and...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b1c5f064280c803cb0cc02ca448571fb973b923
  
https://github.com/WebKit/WebKit/commit/4b1c5f064280c803cb0cc02ca448571fb973b923
  Author: Brianna Fan 
  Date:   2024-11-13 (Wed, 13 Nov 2024)

  Changed paths:
M Tools/CISupport/ews-build/results_db.py

  Log Message:
  ---
  [ews-build] Access the full 'results' endpoint and compare actual and given 
results
https://bugs.webkit.org/show_bug.cgi?id=282659
rdar://139321333

Reviewed by Jonathan Bedard.

Add support for safer-cpp-checks suite.
Add access to the 'api/results' endpoint for suites and individual tests.
Add a comparison method for actual and user-given results per test.

* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase): Added safer-cpp-checks and fixed typo.
(ResultsDatabase.make_request): Added. Specify which endpoint to request.
(ResultsDatabase.get_results): Added. Has the option to specify a test to
retrieve results for. Otherwise, return results for the suite.
(ResultsDatabase.is_test_pre_existing_failure): Fixed typo.
(ResultsDatabase.does_result_match): Added. Returns whether a test result is
equal to a given result. User can specify a default value for a test if
results do not exist.

Canonical link: https://commits.webkit.org/286573@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dffd29: Unreviewed, fix deleting reports directory in comp...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dffd293f7f78581f7a8a0c3ac965fabcc6d8ca6b
  
https://github.com/WebKit/WebKit/commit/dffd293f7f78581f7a8a0c3ac965fabcc6d8ca6b
  Author: Brianna Fan 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Unreviewed, fix deleting reports directory in compare-static-analysis-results 
removes results for the previous project
https://bugs.webkit.org/show_bug.cgi?id=282802
rdar://139483521

Logic here is faulty, since deleting the results directory in the second call of
this function will delete results for the previous run.

* Tools/Scripts/compare-static-analysis-results:
(create_filtered_results_dir):

Canonical link: https://commits.webkit.org/286313@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f28363: Add option to generate new index using updated une...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f283632e7ab8857dd6bd8f70d3f64889588756c2
  
https://github.com/WebKit/WebKit/commit/f283632e7ab8857dd6bd8f70d3f64889588756c2
  Author: Brianna Fan 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Add option to generate new index using updated unexpected results in 
compare-static-analysis-results
https://bugs.webkit.org/show_bug.cgi?id=282713
rdar://139383076

Reviewed by Ryosuke Niwa.

Add --generate-results-only option. This will be used in Safer-CPP-Checks after 
comparing the unexpected
results to results database. If there are changes in the results, then we need 
to generate a new results index,
without performing another comparison.

Usage: compare-static-analysis-results [new-dir] --build-output 
[scan-build-output] --scan-build-path [scan-build] --generate-results-only

* Tools/Scripts/compare-static-analysis-results:
(parser): Add generate-results-only option.
(compare_results): Separate out comparison logic from main.
(generate_results_only): Read from unexpected_results.json and 
issues_per_file.json to get paths to the unexpected result files.
Pass those files into the pre-existing create_filtered_results_dir function 
to generate an index with new results.
(main): Clean up main.

Canonical link: https://commits.webkit.org/286309@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 55a405: compare-static-analysis-results should upload comp...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55a405ffb60198aee3fa68ee8af63e352c9bcdda
  
https://github.com/WebKit/WebKit/commit/55a405ffb60198aee3fa68ee8af63e352c9bcdda
  Author: Brianna Fan 
  Date:   2024-11-07 (Thu, 07 Nov 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  compare-static-analysis-results should upload comparison results from the 
archived dir if given
https://bugs.webkit.org/show_bug.cgi?id=282769
rdar://139449957

Reviewed by Ryan Haddad.

Default to uploading results with the archived_dir provided since this one will 
be
built from tip-of-tree.

* Tools/Scripts/compare-static-analysis-results:
(main):

Canonical link: https://commits.webkit.org/286297@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 621a05: Support uploading results from compare-static-anal...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 621a052ef95767ae7dbc57ee33e8a59b286a11da
  
https://github.com/WebKit/WebKit/commit/621a052ef95767ae7dbc57ee33e8a59b286a11da
  Author: Brianna Fan 
  Date:   2024-11-06 (Wed, 06 Nov 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Support uploading results from compare-static-analysis-results when comparing 
two runs instead of expectations
https://bugs.webkit.org/show_bug.cgi?id=282701
rdar://139370284

Reviewed by Jonathan Bedard.

Previously, running this script with --archived-dir and --report would fail.
This commit adds support for uploading the current run to results db by using 
the existing logic
for checking against expectations.

* Tools/Scripts/compare-static-analysis-results:
(create_filtered_results_dir):
(compare_project_results_to_expectations): Add upload_only argument and filter 
logging.
(main): If there's a report url then we should populate 
project_results_for_upload.

Canonical link: https://commits.webkit.org/286234@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d48d24: [Static Analyzer CI] EWS results should be uploade...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d48d243498f7fcf2c9da573b795e24b19d12191d
  
https://github.com/WebKit/WebKit/commit/d48d243498f7fcf2c9da573b795e24b19d12191d
  Author: Brianna Fan 
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] EWS results should be uploaded from the tip-of-tree run 
without expectations
https://bugs.webkit.org/show_bug.cgi?id=282637
rdar://139311754

Reviewed by Jonathan Bedard.

When building from tip-of-tree without the PR changes, we should upload to 
results database.
This is when we do not compare results against expectations.

* Tools/CISupport/ews-build/steps.py:
(FindUnexpectedStaticAnalyzerResults.run): Move upload options to the not 
self.expectations case.
* Tools/CISupport/ews-build/steps_unittest.py: Fix unittests for full coverage 
of both scenarios.

Canonical link: https://commits.webkit.org/286186@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 11dfba: Unreviewed fix, find-unexpected-static-analyzer-re...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11dfba1313e48949b9fdff176331190f4ac369e5
  
https://github.com/WebKit/WebKit/commit/11dfba1313e48949b9fdff176331190f4ac369e5
  Author: Brianna Fan 
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Unreviewed fix, find-unexpected-static-analyzer-results failing with 
unrecognized arguments
https://bugs.webkit.org/show_bug.cgi?id=282626
rdar://139298889

Add a comma between commands.

* Tools/CISupport/ews-build/steps.py:
(FindUnexpectedStaticAnalyzerResults.run):

Canonical link: https://commits.webkit.org/286173@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 12de6b: [Static Analyzer CI] Report Safer-CPP-Checks EWS r...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12de6b1f0027bb199af3314dc4909cb1a4df72e2
  
https://github.com/WebKit/WebKit/commit/12de6b1f0027bb199af3314dc4909cb1a4df72e2
  Author: Brianna Fan 
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Report Safer-CPP-Checks EWS results to results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=282547
rdar://139215342

Reviewed by Ryan Haddad and Jonathan Bedard.

Add upload options to FindUnexpectedStaticAnalyzerResults to report results 
when the command
is run after a build from tip of tree.

* Tools/CISupport/ews-build/steps.py:
(PrintConfiguration.parseAndValidate): Set properties that are required for 
uploading results.
(FindUnexpectedStaticAnalyzerResults.__init__):
(FindUnexpectedStaticAnalyzerResults.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/286158@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d256a: [Static Analyzer CI] Report Safer-CPP-Checks resul...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d256af83c4dd2c7b1317db78bec8faceed7e2b7
  
https://github.com/WebKit/WebKit/commit/4d256af83c4dd2c7b1317db78bec8faceed7e2b7
  Author: Brianna Fan 
  Date:   2024-10-30 (Wed, 30 Oct 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Report Safer-CPP-Checks results to results.webkit.org
rdar://138526035
https://bugs.webkit.org/show_bug.cgi?id=282023

Reviewed by Jonathan Bedard.

Add properties in PrintConfiguration that are needed to pass to 
generate-dirty-files.
Add the required arguments to FindUnexpectedStaticAnalyzerResults so results 
are uploaded on each run.

* Tools/CISupport/build-webkit-org/steps.py:
(FindUnexpectedStaticAnalyzerResults.run):
(PrintConfiguration.getResultSummary):
* Tools/CISupport/build-webkit-org/steps_unittest.py:

Canonical link: https://commits.webkit.org/285931@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fe6a52: Unreviewed, mac-safer-cpp failing with UnboundLoca...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe6a520e134f8245d6ec68e935637993dbf7f2aa
  
https://github.com/WebKit/WebKit/commit/fe6a520e134f8245d6ec68e935637993dbf7f2aa
  Author: Brianna Fan 
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Unreviewed, mac-safer-cpp failing with UnboundLocalError
https://bugs.webkit.org/show_bug.cgi?id=282284
rdar://138869447

Fix errors due to previous changes to support results uploading.

* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_by_run):
(main):

Canonical link: https://commits.webkit.org/285859@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 314b05: Unreviewed, update Safer C++ Expectations after We...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 314b05642e9907e25ca8dd5a0eafa2c098ba8583
  
https://github.com/WebKit/WebKit/commit/314b05642e9907e25ca8dd5a0eafa2c098ba8583
  Author: Brianna Fan 
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations

  Log Message:
  ---
  Unreviewed, update Safer C++ Expectations after WebGPU fixes

Smart pointer adoption in 285817@main fixed many bugs!

* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/285851@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7b55d9: Unreviewed, find-unexpected-static-analyzer-result...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b55d901d26878c85689419985cb40ec140fb8d4
  
https://github.com/WebKit/WebKit/commit/7b55d901d26878c85689419985cb40ec140fb8d4
  Author: Brianna Fan 
  Date:   2024-10-29 (Tue, 29 Oct 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Unreviewed, find-unexpected-static-analyzer-results failing with ValueError: 
too many values to unpack
https://bugs.webkit.org/show_bug.cgi?id=282255
rdar://138852598

Assign 3 variables to find_diff output after recent changes made it return one 
more value.

* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_by_run):

Canonical link: https://commits.webkit.org/285847@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f167dc: [Static Analyzer CI] Support reporting static anal...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f167dc39b8298efca1aa742a21c7fc976ebd9024
  
https://github.com/WebKit/WebKit/commit/f167dc39b8298efca1aa742a21c7fc976ebd9024
  Author: Brianna Fan 
  Date:   2024-10-28 (Mon, 28 Oct 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/webkitpy/results/options.py

  Log Message:
  ---
  [Static Analyzer CI] Support reporting static analyzer results to 
results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=281925
rdar://138433382

Reviewed by Jonathan Bedard.

Take parsed results and format them for the resultsdb API to upload.
Config and build details are provided from buildbot as arguments.
Then, use webkitpy.results.upload to results.webkit.org.

* Tools/Scripts/compare-static-analysis-results:
(parser): Add new options.
(find_diff): Fix empty file logic and return list of all files with issues.
(compare_project_results_to_expectations): Assign an actual and expected result 
to each file.
(upload_results): Create the results object for upload. Check repo for the 
current commit. Upload results.
(main): Call upload_results if the upload arguments are passed.

* Tools/Scripts/webkitpy/results/options.py: Support both optparse and argparse!
(add_optargs):
(upload_options):
(upload_args):

Canonical link: https://commits.webkit.org/285799@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ad8966: [ews] unsafe-merge-queue sometimes fails with exce...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad8966f8e9dee6554214bc84cde2a6afe5a56112
  
https://github.com/WebKit/WebKit/commit/ad8966f8e9dee6554214bc84cde2a6afe5a56112
  Author: Brianna Fan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews] unsafe-merge-queue sometimes fails with exception in 
retrieve-pr-data-from-label-webkit-webkit step
https://bugs.webkit.org/show_bug.cgi?id=278941
rdar://135033550

Reviewed by Jonathan Bedard.

Add retries and error handling to get_number_of_prs_with_label.
If there are errors, attempt to print out the message for easier debugging.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.get_number_of_prs_with_label):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/285701@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f0339c: [Static Analyzer CI] Update Safer-CPP-Checks queue...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0339cd13291ec15f92afc4e8b618ced46d07be5
  
https://github.com/WebKit/WebKit/commit/f0339cd13291ec15f92afc4e8b618ced46d07be5
  Author: Brianna Fan 
  Date:   2024-10-25 (Fri, 25 Oct 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  [Static Analyzer CI] Update Safer-CPP-Checks queue to Sequoia
https://bugs.webkit.org/show_bug.cgi?id=282020
rdar://138521603

Reviewed by Ryan Haddad.

Make necessary config changes for the update.

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/285700@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9f388a: [Static Analyzer CI] Run ValidateChange before cri...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f388aaa3f33dd78780056e17fd6b0d7de6610b1
  
https://github.com/WebKit/WebKit/commit/9f388aaa3f33dd78780056e17fd6b0d7de6610b1
  Author: Brianna Fan 
  Date:   2024-10-21 (Mon, 21 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [Static Analyzer CI] Run ValidateChange before critical steps in Safer C++ 
build
https://bugs.webkit.org/show_bug.cgi?id=281695
rdar://138142480

Reviewed by Ryan Haddad.

Add ValidateChange before building a second time to prevent building when the PR
may have already been updated. This change, coupled with the change to add a 
hash
to the PR comment, will reduce noise and improve clarity of PR comments.

* Tools/CISupport/ews-build/steps.py:
(FindUnexpectedStaticAnalyzerResults.run):

Canonical link: https://commits.webkit.org/285528@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a06ee5: Unreviewed, Update Safer C++ expectations after up...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a06ee5087942d08040ba1649c3b49ea7e7c03601
  
https://github.com/WebKit/WebKit/commit/a06ee5087942d08040ba1649c3b49ea7e7c03601
  Author: Brianna Fan 
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations

  Log Message:
  ---
  Unreviewed, Update Safer C++ expectations after updating clang
https://bugs.webkit.org/show_bug.cgi?id=281756
rdar://138187617

Update expectations based on new builds after 285409@main.
Re-adding AudioNodeOutput.h to expectations after 285391@main, since this
was determined to be an unrelated failure that occurred in that change.

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/285412@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a75c31: [Static Analyzer CI] Update clang to latest version

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a75c3104c9ec8ce287ce38927d2c2c01be646029
  
https://github.com/WebKit/WebKit/commit/a75c3104c9ec8ce287ce38927d2c2c01be646029
  Author: Brianna Fan 
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [Static Analyzer CI] Update clang to latest version
https://bugs.webkit.org/show_bug.cgi?id=281707
rdar://138153140

Reviewed by Ryosuke Niwa.

Update LLVM_REVISION to latest hash.

* Tools/CISupport/ews-build/steps.py:

Canonical link: https://commits.webkit.org/285409@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e74b10: update-safer-cpp-expectations should provide a lin...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e74b10abd622d2784dd18fad39c638db67feaa3f
  
https://github.com/WebKit/WebKit/commit/e74b10abd622d2784dd18fad39c638db67feaa3f
  Author: Brianna Fan 
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
M Tools/Scripts/update-safer-cpp-expectations

  Log Message:
  ---
  update-safer-cpp-expectations should provide a link to post-commit results
https://bugs.webkit.org/show_bug.cgi?id=281454
rdar://137908874

Reviewed by Ryosuke Niwa.

Add a link to post-commit results when --find-expectations is invoked.
Add better spacing and rephrase output.

* Tools/Scripts/update-safer-cpp-expectations:
(update_expectations):
(is_expected_file):
(main):

Canonical link: https://commits.webkit.org/285206@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 579202: Add email to contributors.json

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5792020e356116034dee328524be0dd557d91670
  
https://github.com/WebKit/WebKit/commit/5792020e356116034dee328524be0dd557d91670
  Author: Brianna Fan 
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add email to contributors.json

Unreviewed.

The sign-up for the contributors meeting used my other email...
Adding that to contributors.json.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/284989@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7a683e: find-modified-layout-tests flags every test when e...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a683ea260a812d4eb17df9db5398afa566ec1b4
  
https://github.com/WebKit/WebKit/commit/7a683ea260a812d4eb17df9db5398afa566ec1b4
  Author: Brianna Fan 
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  find-modified-layout-tests flags every test when expectations spacing changes
https://bugs.webkit.org/show_bug.cgi?id=281235
rdar://137695334

Reviewed by Jonathan Bedard.

Add '-w' (ignore all white space) option when diff-ing the expectations printed 
from
run-webkit-tests --print-expectations.

* Tools/CISupport/ews-build/steps.py:
(FindModifiedLayoutTests):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestFindModifiedLayoutTests.test_success):
(TestFindModifiedLayoutTests.test_success_svg):
(TestFindModifiedLayoutTests.test_success_xml):
(TestFindModifiedLayoutTests.test_ignore_certain_directories):
(TestFindModifiedLayoutTests.test_ignore_certain_directories_svg):
(TestFindModifiedLayoutTests.test_ignore_certain_directories_xml):
(TestFindModifiedLayoutTests.test_ignore_certain_suffixes):
(TestFindModifiedLayoutTests.test_ignore_non_layout_test_in_html_directory):
(TestFindModifiedLayoutTests.test_non_relevant_patch):
(TestFindModifiedLayoutTests.test_non_accessible_patch):

Canonical link: https://commits.webkit.org/284982@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fff8fc: Unreviewed fix, [Static Analyzer CI] Fixed files f...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fff8fcf6d15d71f0f5f0ebc6fdc701b2e68673af
  
https://github.com/WebKit/WebKit/commit/fff8fcf6d15d71f0f5f0ebc6fdc701b2e68673af
  Author: Brianna Fan 
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Unreviewed fix, [Static Analyzer CI] Fixed files from different builds appear 
in other PR comments
https://bugs.webkit.org/show_bug.cgi?id=281228
rdar://137649620

Setting commands as a class property actually persists over multiple builds.
Thus, PR comments would include every command ever added to that set.
Make commands_to_comment a local variable that's passed into the relevant 
methods as a parameter.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.run):
(DisplaySaferCPPResults.getFilesPerProject):
(DisplaySaferCPPResults.createComment):

Canonical link: https://commits.webkit.org/284969@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b50ab3: [Static Analyzer CI] Enable update-safer-cpp-expec...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b50ab39c922f4afcc0b894736c29846f1f50d065
  
https://github.com/WebKit/WebKit/commit/b50ab39c922f4afcc0b894736c29846f1f50d065
  Author: Brianna Fan 
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
M Tools/Scripts/update-safer-cpp-expectations

  Log Message:
  ---
  [Static Analyzer CI] Enable update-safer-cpp-expectations to take in lists of 
files per checker
https://bugs.webkit.org/show_bug.cgi?id=281068
rdar://137521171

Reviewed by Ryosuke Niwa.

Modify update-safer-cpp-expectations to take in arguments for the project, 
checker, and files to update.
Now, we can construct a one-liner command to update expectations.

* Tools/Scripts/update-safer-cpp-expectations:
(parser): Add new arguments for each checker.
(modify_expectations_for_checker_from_file): Separate logic for updating using 
results file.
(update_expectations_from_file): Ditto.
(modify_expectations_for_checker): New logic for updating using checker args.
(update_expectations): Ditto.
(main):

Canonical link: https://commits.webkit.org/284901@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 96d957: [Static Analyzer CI] Improve the content and reada...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96d957f16d1d0481aee6156b2840eb282b65bdd1
  
https://github.com/WebKit/WebKit/commit/96d957f16d1d0481aee6156b2840eb282b65bdd1
  Author: Brianna Fan 
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Improve the content and readability of the unexpected 
failures/passes comment
https://bugs.webkit.org/show_bug.cgi?id=281093
rdar://137541288

Reviewed by Ryan Haddad.

Includes information for fixes and failures in one comment when both occur.
Adds code and header formatting to improve readability.
Also fixes a bug where LeaveComment is run twice upon failure.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.run):
Improve code clarity and call createComment.
(DisplaySaferCPPResults.getFilesPerProject):
Remove extra space.
(DisplaySaferCPPResults.createComment): Created.
Now comments will contain both fixes/failure info when relevant.
Separate out comment creation for clarity.
Add LeaveComment and SetBuildSummary to prevent duplication bug.
(DisplaySaferCPPResults.change_type): Created.
Support both PRs and patches.
(DisplaySaferCPPResults.getResultSummary): Remove comment logic.
* Tools/CISupport/ews-build/steps_unittest.py: Update unit test coverage.

Canonical link: https://commits.webkit.org/284900@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b27096: Unreviewed, Update expectations after 284841@main

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b27096d060b61dae8ddc4afc794b02bccbebd4e2
  
https://github.com/WebKit/WebKit/commit/b27096d060b61dae8ddc4afc794b02bccbebd4e2
  Author: Brianna Fan 
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations

  Log Message:
  ---
  Unreviewed, Update expectations after 284841@main

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/284842@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c8232c: [Static Analyzer CI] update-safer-cpp-expectations...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8232c76e5bfb9078f32e9dc1e881227852c46bf
  
https://github.com/WebKit/WebKit/commit/c8232c76e5bfb9078f32e9dc1e881227852c46bf
  Author: Brianna Fan 
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] update-safer-cpp-expectations should take less steps to 
run
https://bugs.webkit.org/show_bug.cgi?id=281029
rdar://137459530

Reviewed by Ryan Haddad.

Construct a copy-pastable command for updating expectations to comment on the 
PR.
There will be one command per project.

* Tools/CISupport/ews-build/steps.py:
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.getFilesPerProject):
(DisplaySaferCPPResults.getResultSummary):

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284840@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2ed7ca: [Static Analyzer CI] Safer CPP build should skip P...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ed7ca28c53b094403638a92ba3afa01e97b8bc2
  
https://github.com/WebKit/WebKit/commit/2ed7ca28c53b094403638a92ba3afa01e97b8bc2
  Author: Brianna Fan 
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Safer CPP build should skip PRs without relevant changes 
or with skip-ews label
https://bugs.webkit.org/show_bug.cgi?id=281010
rdar://137451787

Reviewed by Ryan Haddad.

Add ValidateChanges after checking out PR to check if skip-ews label is applied.
Check whether changes in the PR are under Source/WebKit or Source/WebCore or 
are in any of the
scripts associated with the Safer CPP queue.

This will skip unnecessary builds and allow the queue to process more relevant 
changes in a timely fashion.

* Tools/CISupport/ews-build/factories.py:
(SaferCPPStaticAnalyzerFactory.__init__):
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(CheckChangeRelevance):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckChangeRelevance.test_relevant_safer_cpp_pull_request):
(TestCheckChangeRelevance.test_non_relevant_patch_on_various_queues):
(TestCheckChangeRelevance.test_non_relevant_pull_request_on_various_queues):

Canonical link: https://commits.webkit.org/284833@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4b1e99: [ews-app] Status bubble layout breaks when mac-saf...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b1e999cbf60401642dbe71cbebeb9de375117d2
  
https://github.com/WebKit/WebKit/commit/4b1e999cbf60401642dbe71cbebeb9de375117d2
  Author: Brianna Fan 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-app] Status bubble layout breaks when mac-safer-cpp status has a newline
https://bugs.webkit.org/show_bug.cgi?id=280850
rdar://137233140

Reviewed by Jonathan Bedard.

Remove newline from ParseStaticAnalyzerResults summary.
Remove parse-static-analyzer-results from steps to report.
Add display-safer-cpp-results to steps to report.

* Tools/CISupport/ews-build/events.py:
(Events):
* Tools/CISupport/ews-build/steps.py:
(ParseStaticAnalyzerResults.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284645@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 75ac8b: Unreviewed, update Safer CPP Expectations.

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 75ac8b1b9b22cf91bf1fa0f1a2e770f3e036bac3
  
https://github.com/WebKit/WebKit/commit/75ac8b1b9b22cf91bf1fa0f1a2e770f3e036bac3
  Author: Brianna Fan 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Unreviewed, update Safer CPP Expectations.

* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/284625@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 62d9ef: [Static Analyzer CI] Temporarily disable blocking ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62d9ef473c3b3efa3196095c51aa3d89a31d6b40
  
https://github.com/WebKit/WebKit/commit/62d9ef473c3b3efa3196095c51aa3d89a31d6b40
  Author: Brianna Fan 
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Temporarily disable blocking merging for 
Safer-CPP-Checks queue
https://bugs.webkit.org/show_bug.cgi?id=280810
rdar://137179960

Reviewed by Ryan Haddad.

Disable adding merging blocked label upon failure.
Remove from safe-merge-queue list.

* Tools/CISupport/ews-build/steps.py:
(CheckStatusOfPR):
(DisplaySaferCPPResults.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284614@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 85240f: Rename SmartPointerExpectations to SaferCPPExpecta...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 85240f4aa8e106436a3aaca644997e7441a9fd28
  
https://github.com/WebKit/WebKit/commit/85240f4aa8e106436a3aaca644997e7441a9fd28
  Author: Brianna Fan 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
A 
Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
R 
Source/WebCore/SmartPointerExpectations/NoUncheckedPtrMemberCheckerExpectations
R 
Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
R 
Source/WebCore/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations
R 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
R 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
A Source/WebKit/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations
A Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
A Source/WebKit/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations
A Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
A Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
R 
Source/WebKit/SmartPointerExpectations/NoUncheckedPtrMemberCheckerExpectations
R 
Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
R Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations
R 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
R 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/update-safer-cpp-expectations

  Log Message:
  ---
  Rename SmartPointerExpectations to SaferCPPExpectations
https://bugs.webkit.org/show_bug.cgi?id=280812

Reviewed by Ryosuke Niwa.

Follow new naming convention.

* Source/WebCore/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations: 
Renamed from 
Source/WebCore/SmartPointerExpectations/NoUncheckedPtrMemberCheckerExpectations.
* Source/WebCore/SaferCPPExpectations/NoUncountedMemberCheckerExpectations: 
Renamed from 
Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations.
* Source/WebCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations: 
Renamed from 
Source/WebCore/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations.
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: 
Renamed from 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations.
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: 
Renamed from 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations.
* Source/WebKit/SaferCPPExpectations/NoUncheckedPtrMemberCheckerExpectations: 
Renamed from 
Source/WebKit/SmartPointerExpectations/NoUncheckedPtrMemberCheckerExpectations.
* Source/WebKit/SaferCPPExpectations/NoUncountedMemberCheckerExpectations: 
Renamed from 
Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations.
* Source/WebKit/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations: 
Renamed from 
Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations.
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: 
Renamed from 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations.
* Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: 
Renamed from 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations.
* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_to_expectations):
* Tools/Scripts/update-safer-cpp-expectations:
(parser):

Canonical link: https://commits.webkit.org/284601@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bc1c19: [Static Analyzer CI] Rename scripts and processes ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc1c19d5d9028c4bed727da393f371de3997f17e
  
https://github.com/WebKit/WebKit/commit/bc1c19d5d9028c4bed727da393f371de3997f17e
  Author: Brianna Fan 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
R Tools/Scripts/smart-pointer-tool
A Tools/Scripts/update-safer-cpp-expectations

  Log Message:
  ---
  [Static Analyzer CI] Rename scripts and processes from smart pointer to safer 
CPP
https://bugs.webkit.org/show_bug.cgi?id=280729
rdar://137096120

Reviewed by Ryosuke Niwa and Ryan Haddad.

Reflect the nature of our static analysis better by changing references to 
smart pointer
to safer cpp or static analysis.

Also updated build summary for build-webkit-org DisplaySaferCPPResults to be 
more accurate
and useful based on the results. Added unittests for DisplaySaferCPPResults.

* Tools/Scripts/update-safer-cpp-expectations:
Renamed from Tools/Scripts/smart-pointer-tool.
Allow the user to pass in any filename if arguments are specified correctly.
(parser): Add arguments for adding and removing failures, specifying project 
name.
(modify_expectations_for_checker):
(update_expectations):
(is_expected_file):
(main):

* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/factories.py:
(SaferCPPStaticAnalyzerFactory):
(SaferCPPStaticAnalyzerFactory.__init__):
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/steps.py:
(ScanBuild):
(ScanBuild.run):
(DisplaySaferCPPResults):
(UpdateSaferCPPBaseline):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/events.py:
(Events):
* Tools/CISupport/ews-build/factories.py:
(SaferCPPStaticAnalyzerFactory):
(SaferCPPStaticAnalyzerFactory.__init__):
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build/steps.py:
(UpdatePullRequest.hideStepIf):
(ScanBuild):
(ScanBuildWithoutChange):
(FindUnexpectedStaticAnalyzerResults.run):
(DisplaySaferCPPResults):
(DisplaySaferCPPResults.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284596@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1aa77a: Unreviewed follow-up fix: [Static Analyzer CI] Add...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1aa77a8c7fc0465113c99617249bedd2e5025886
  
https://github.com/WebKit/WebKit/commit/1aa77a8c7fc0465113c99617249bedd2e5025886
  Author: Brianna Fan 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Unreviewed follow-up fix: [Static Analyzer CI] Add steps to download cmake 
and ninja on worker
https://bugs.webkit.org/show_bug.cgi?id=280722
rdar://137073482

Fix path to download-and-install-build-tools.

* Tools/CISupport/ews-build/steps.py:
(InstallNinja.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284582@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ba0327: [Static Analyzer CI] Add step to update clang on w...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba0327a7a34f728c64cf5febdbba1f02fb0abb33
  
https://github.com/WebKit/WebKit/commit/ba0327a7a34f728c64cf5febdbba1f02fb0abb33
  Author: Brianna Fan 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Add step to update clang on worker
https://bugs.webkit.org/show_bug.cgi?id=280306
rdar://136511492

Reviewed by Jonathan Bedard.

Frequent changes are being made to the checks so having an automatic system to 
update
the workers will save a lot of engineering time.

In the future, we just need to update LLVM_REVISION to build on the desired 
change.

* Tools/CISupport/ews-build/factories.py:
(SmartPointerStaticAnalyzerFactory.__init__):

* Tools/CISupport/ews-build/steps.py:
(CheckOutLLVMProject):
Modelled very closely after CheckoutSource. This step will check if the 
current
clang version matches the desired revision. If not, it will check out the 
desired revision.
(CheckOutLLVMProject.__init__):
(CheckOutLLVMProject.run_vc):
(CheckOutLLVMProject.parseGotRevision):
(CheckOutLLVMProject.getResultSummary):

(UpdateClang):
This step will build clang if the current clang version doesn't match the 
desired revision.
We must delete WebKitBuild for a clean build, otherwise the build will fail.
If the build is not successful, we resort to the previous clang if there is 
one.
If there is none, we retry the build.
(UpdateClang.__init__):
(UpdateClang.run):
(UpdateClang.doStepIf):
(UpdateClang.getResultSummary):

(PrintClangVersionAfterUpdate):
Added after a successful clang update. This will print the new version and 
switch the build directory
with the new one.
(PrintClangVersionAfterUpdate.run):
(PrintClangVersionAfterUpdate.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284576@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1a9cbd: [Static Analyzer CI] Add steps to download cmake a...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a9cbdc6175fb64a2e4fcb420c1970ca01f9a2af
  
https://github.com/WebKit/WebKit/commit/1a9cbdc6175fb64a2e4fcb420c1970ca01f9a2af
  Author: Brianna Fan 
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
A Tools/CISupport/Shared/download-and-install-build-tools
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Add steps to download cmake and ninja on worker
https://bugs.webkit.org/show_bug.cgi?id=280722
rdar://137073482

Reviewed by Jonathan Bedard.

In order to build clang, we need to install cmake and ninja. This commit 
introduces a script
that downloads the corresponding package and installs it on the worker in a 
specified directory.

The InstallClang and InstallNinja steps are added to the factory and should 
only need to be run
on a bot the very first time it is running this particular queue.

* Tools/CISupport/ews-build/factories.py:
(SmartPointerStaticAnalyzerFactory.__init__):
* Tools/CISupport/ews-build/steps.py:
(InstallCMake):
(InstallCMake.__init__):
(InstallCMake.run):
(InstallCMake.evaluateCommand):
(InstallCMake.getResultSummary):
(InstallNinja):
(InstallNinja.__init__):
(InstallNinja.run):
(InstallNinja.evaluateCommand):
(InstallNinja.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284572@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 17a253: [ews-build] Bring up Safer-CPP-Checks queue!

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17a253991b6e47ca9fdb018f263363dbd7362cf6
  
https://github.com/WebKit/WebKit/commit/17a253991b6e47ca9fdb018f263363dbd7362cf6
  Author: Brianna Fan 
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build] Bring up Safer-CPP-Checks queue!
https://bugs.webkit.org/show_bug.cgi?id=280636
rdar://136993599

Reviewed by Aakash Jain and Ryan Haddad.

Config change to bring up Mac-Safer-CPP-Checks EWS queue.

* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS):
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/steps.py:
(CheckStatusOfPR): Add 'mac-safer-cpp' to safe-merge-queue checks.

Canonical link: https://commits.webkit.org/284530@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] aa72ed: 'DisplaySmartPointerResults' object has no attribu...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa72ed8af76cfdb3ef4705484dd5bd2c6328e942
  
https://github.com/WebKit/WebKit/commit/aa72ed8af76cfdb3ef4705484dd5bd2c6328e942
  Author: Brianna Fan 
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py

  Log Message:
  ---
  'DisplaySmartPointerResults' object has no attribute 'addToLog'
https://bugs.webkit.org/show_bug.cgi?id=280620
rdar://136975631

Reviewed by Ryan Haddad.

Fix call to function.

* Tools/CISupport/build-webkit-org/steps.py:
(DisplaySmartPointerResults.run):

Canonical link: https://commits.webkit.org/284453@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 63647c: Add NoUncheckedPtrMemberChecker to static analysis

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63647cf8fc38f9dd23012e8308903e1652414b7d
  
https://github.com/WebKit/WebKit/commit/63647cf8fc38f9dd23012e8308903e1652414b7d
  Author: Brianna Fan 
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
M Tools/Scripts/build-and-analyze
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/generate-dirty-files
M Tools/Scripts/smart-pointer-tool

  Log Message:
  ---
  Add NoUncheckedPtrMemberChecker to static analysis
https://bugs.webkit.org/show_bug.cgi?id=280554
rdar://136863793

Reviewed by Ryosuke Niwa.

Enable NoUncheckedPtrMemberChecker in build-and-analyze.
Add the checker to various scripts that deal with static analyzer output.

* Tools/Scripts/build-and-analyze:
(make_analyzer_flags):
* Tools/Scripts/compare-static-analysis-results:
* Tools/Scripts/generate-dirty-files:
* Tools/Scripts/smart-pointer-tool:

Canonical link: https://commits.webkit.org/284401@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cec46c: [Static Analyzer CI] Fix various bugs in the build...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cec46c832d43e424e30f7d802ca92dd489373c9c
  
https://github.com/WebKit/WebKit/commit/cec46c832d43e424e30f7d802ca92dd489373c9c
  Author: Brianna Fan 
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Fix various bugs in the build summary
https://bugs.webkit.org/show_bug.cgi?id=280527
rdar://136843493

Reviewed by Aakash Jain.

1) Set property 'build_summary' instead of 'build_finish_summary' when step 
succeeds.
2) Add conditional 'pluralSuffix' to summary string.
3) Turn list of files into a set to remove duplicates.

* Tools/CISupport/ews-build/steps.py:
(DisplaySmartPointerResults.getFilesPerProject):
(DisplaySmartPointerResults.getResultSummary):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/284388@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91c366: The jsc-armv7 and jsc-armv7-tests EWS bots should ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91c3660a4cbc627b2a9b27476bcaf4dac7b8c72c
  
https://github.com/WebKit/WebKit/commit/91c3660a4cbc627b2a9b27476bcaf4dac7b8c72c
  Author: Brianna Fan 
  Date:   2024-09-27 (Fri, 27 Sep 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  The jsc-armv7 and jsc-armv7-tests EWS bots should not block merging
https://bugs.webkit.org/show_bug.cgi?id=280541
rdar://136542647

Reviewed by Ryan Haddad.

Remove tests from the safe-merge-queue status check.

* Tools/CISupport/ews-build/steps.py:
(CheckStatusOfPR):

Canonical link: https://commits.webkit.org/284392@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2d6827: [Static Analyzer CI] Add smart pointer analysis qu...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d68279abbd5dc5a27a5f59521fbb1f83c7f
  
https://github.com/WebKit/WebKit/commit/2d68279abbd5dc5a27a5f59521fbb1f83c7f
  Author: Brianna Fan 
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
M Tools/CISupport/ews-build/events.py
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Add smart pointer analysis queue to EWS
https://bugs.webkit.org/show_bug.cgi?id=276625
rdar://131782284

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/factories.py:
(SmartPointerStaticAnalyzerFactory.__init__): Added.

* Tools/CISupport/ews-build/steps.py:
(RevertAppliedChanges.__init__): Add exclude argument to ignore given patterns.
(RevertAppliedChanges.run):

(ScanBuildSmartPointer): Copied from build-webkit with following differences:
  - baseline arg added for building without PR changes applied
  - Call FindUnexpectedStaticAnalyzerResults with expectations = False if 
baseline build

(ParseStaticAnalyzerResults): Copied from build-webkit. Added baseline arg.

(FindUnexpectedStaticAnalyzerResults): Copied from build-webkit. Added 
expectations arg.
(FindUnexpectedStaticAnalyzerResults.run):
  - Run script with --check-expectations arg if expectations = True.
If there are failures, rebuild without changes.
  - If expectations = False, compare PR results with baseline results.
(FindUnexpectedStaticAnalyzerResults.createResultMessage):

(DisplaySmartPointerResults): Copied from build-webkit. Slight differences in 
wording.
(DisplaySmartPointerResults.getFilesPerProject):
(DisplaySmartPointerResults.getResultSummary): Comment and block the PR if 
there are failures.

(PrintClangVersion): Copied from build-webkit with minor changes.
(ArchiveStaticAnalyzerResults): Ditto.
(UploadStaticAnalyzerResults): Ditto.
(ExtractStaticAnalyzerTestResults): Ditto.

Tools/CISupport/ews-build/events.py: Added steps to STEPS_TO_REPORT.
* Tools/CISupport/ews-build/steps_unittest.py:
* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/loadConfig.py:

Canonical link: https://commits.webkit.org/284319@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 139351: [Static Analyzer CI] New issues that appear in fai...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13935113a90e455976400086bc8f09708e125f8d
  
https://github.com/WebKit/WebKit/commit/13935113a90e455976400086bc8f09708e125f8d
  Author: Brianna Fan 
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  [Static Analyzer CI] New issues that appear in failing files are marked as 
unexpected failures and will block EWS
https://bugs.webkit.org/show_bug.cgi?id=280320
rdar://136647523

Reviewed by Ryosuke Niwa.

Populate new issues from the list of unexpected failing files.

* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_by_run):

Canonical link: https://commits.webkit.org/284235@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e98a93: compare-static-analysis-results should ignore empt...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e98a9345c9f408c524de8892542608bf49e4ba76
  
https://github.com/WebKit/WebKit/commit/e98a9345c9f408c524de8892542608bf49e4ba76
  Author: Brianna Fan 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  compare-static-analysis-results should ignore empty lines when comparing 
results
https://bugs.webkit.org/show_bug.cgi?id=280043
rdar://136343298

Reviewed by Ryosuke Niwa.

Check for empty lines in expectation files.

* Tools/Scripts/compare-static-analysis-results:
(find_diff):

Canonical link: https://commits.webkit.org/283980@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d9b084: Unreviewed, update smart pointer expectations.

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9b084c658132d10fb5f62cecf89ea3e83ebbb41
  
https://github.com/WebKit/WebKit/commit/d9b084c658132d10fb5f62cecf89ea3e83ebbb41
  Author: Brianna Fan 
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
M 
Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations
M Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Unreviewed, update smart pointer expectations.

* Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations:
* Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/283973@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2e5790: [Static Analyzer CI] Run smart pointer static anal...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e5790b1d728501d4958b8c9bb6d3c91df5e45e3
  
https://github.com/WebKit/WebKit/commit/2e5790b1d728501d4958b8c9bb6d3c91df5e45e3
  Author: Brianna Fan 
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
M Makefile.shared
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/Scripts/build-and-analyze

  Log Message:
  ---
  [Static Analyzer CI] Run smart pointer static analysis with release config
https://bugs.webkit.org/show_bug.cgi?id=279856
rdar://136183334

Reviewed by Ryosuke Niwa.

Change the build config for Apple-Sonoma-Smart-Pointer-Static-Analyzer-Build to 
release and
invoke build-and-analyze with release config.

This will allow the configuration of make analyze to be changed using 
set-webkit-configuration and
default to whatever configuration was last set, similar to how local builds 
work.

* Makefile.shared: Remove debug-only config.
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/steps.py:
(ScanBuildSmartPointer.run): Add --configuration release to build-and-analyze 
invocation.
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/Scripts/build-and-analyze:
(main): Run set-webkit-configuration before make analyze.
(parse_args): Add --configuration argument (default: debug).

Canonical link: https://commits.webkit.org/283850@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9de14d: [git-webkit] Should check keywords before creating...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9de14d8038d513869581f1780ba09e2e46891c44
  
https://github.com/WebKit/WebKit/commit/9de14d8038d513869581f1780ba09e2e46891c44
  Author: Brianna Fan 
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py

  Log Message:
  ---
  [git-webkit] Should check keywords before creating bug
https://bugs.webkit.org/show_bug.cgi?id=279835
rdar://135730147

Reviewed by Jonathan Bedard.

If there is a radar to cc, check it for any keywords that can help
automatically classify the project for the new bug.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main):

Canonical link: https://commits.webkit.org/283794@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 969257: [Static Analyzer CI] Add tool to improve smart poi...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9692577c30fd125a0ea9bb930f00f2d1313682e4
  
https://github.com/WebKit/WebKit/commit/9692577c30fd125a0ea9bb930f00f2d1313682e4
  Author: Brianna Fan 
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
A Tools/Scripts/smart-pointer-tool

  Log Message:
  ---
  [Static Analyzer CI] Add tool to improve smart pointer development workflow
https://bugs.webkit.org/show_bug.cgi?id=279793
rdar://136109601

Reviewed by Ryosuke Niwa.

This script automates certain tasks in the smart pointer workflow.
- Run `smart-pointer-tool --update-expectations {unexpected result file}` to 
automatically
add or delete files from the expectation lists.
- Run `smart-pointer-tool --find-expectations {file}` to check if there are 
smart pointer bugs
for that file.

* Tools/Scripts/smart-pointer-tool: Added.
(parser):
(modify_expectations_for_checker):
(update_expectations):
(is_expected_file):
(main):

Canonical link: https://commits.webkit.org/283735@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5fbb26: Unreviewed, update smart pointer expectations afte...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5fbb26344124ead3e7ce1bcbdeebd2b5e89908c1
  
https://github.com/WebKit/WebKit/commit/5fbb26344124ead3e7ce1bcbdeebd2b5e89908c1
  Author: Brianna Fan 
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
M 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Unreviewed, update smart pointer expectations after reducing false positives.

* Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/283509@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e24dc: Unreviewed, update smart pointer expectations.

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e24dc8ee650a6845e57c6bb61e9deb1e9207121
  
https://github.com/WebKit/WebKit/commit/3e24dc8ee650a6845e57c6bb61e9deb1e9207121
  Author: Brianna Fan 
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
M 
Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations

  Log Message:
  ---
  Unreviewed, update smart pointer expectations.
https://bugs.webkit.org/show_bug.cgi?id=279541
rdar://135824917

Updated using a script!

* Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/RefCntblBaseVirtualDtorExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:

Canonical link: https://commits.webkit.org/283501@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b1846e: [Static Analyzer CI] Update the summary page for u...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1846eb8836ac04b508679d16a0ed048cf3c63d0
  
https://github.com/WebKit/WebKit/commit/b1846eb8836ac04b508679d16a0ed048cf3c63d0
  Author: Brianna Fan 
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
M Tools/Scripts/generate-static-analysis-archive

  Log Message:
  ---
  [Static Analyzer CI] Update the summary page for unexpected results
https://bugs.webkit.org/show_bug.cgi?id=279465
rdar://135748287

Reviewed by Ryosuke Niwa.

Update the UI of the unexpected results page.
Now results are sorted by passes and failures, then by project.
File lists and counts are displayed in a table.

* Tools/Scripts/generate-static-analysis-archive:
(parse_command_line):
(generate_unexpected_table):
(generate_unexpected_results_page):
(generate_results_page):
(create_results_file):
(generate_unexpected_results_links): Deleted.

Canonical link: https://commits.webkit.org/283445@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c1374: [Static Analyzer CI] Hide unexpected results link ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c1374263cc64cdf8a8b080703e7d6b27e615810
  
https://github.com/WebKit/WebKit/commit/1c1374263cc64cdf8a8b080703e7d6b27e615810
  Author: Brianna Fan 
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Hide unexpected results link if there are no unexpected 
results
https://bugs.webkit.org/show_bug.cgi?id=279289
rdar://129720143

Reviewed by Aakash Jain.

Add result links to DisplaySmartPointerResults and hide unexpected when there 
are none.

* Tools/CISupport/build-webkit-org/steps.py:
(DisplaySmartPointerResults): Rename DisplayUnexpectedResults to 
DisplaySmartPointerResults.
(DisplaySmartPointerResults.run): Add result links to 
DisplaySmartPointerResults instead of ExtractStaticAnalyzerTestResults.
(DisplaySmartPointerResults.getFilesPerProject): Improve logging.
(DisplaySmartPointerResults.getResultSummary): Display 'No unexpected results' 
upon success.
(DisplaySmartPointerResults.resultDirectoryURL): Added.
(DisplaySmartPointerResults.resultDownloadURL): Added.
(ExtractStaticAnalyzerTestResults):
(ExtractStaticAnalyzerTestResults.addCustomURLs): Pass.
(ExtractStaticAnalyzerTestResults.run): Deleted.
(ExtractStaticAnalyzerTestResults.getLastBuildStepByName): Deleted.
* Tools/CISupport/build-webkit-org/steps_unittest.py:

Canonical link: https://commits.webkit.org/283439@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ada351: [Static Analyzer CI] Rename CompareStaticAnalyzerR...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ada351a49dbecae5a43081415973c92df6063f74
  
https://github.com/WebKit/WebKit/commit/ada351a49dbecae5a43081415973c92df6063f74
  Author: Brianna Fan 
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py

  Log Message:
  ---
  [Static Analyzer CI] Rename CompareStaticAnalyzerResults
https://bugs.webkit.org/show_bug.cgi?id=279386
rdar://135594323

Reviewed by Ryan Haddad.

Rename CompareStaticAnalyzerResults to FindUnexpectedStaticAnalyzerResults.

* Tools/CISupport/build-webkit-org/steps.py:
(ScanBuildSmartPointer.run):
(FindUnexpectedStaticAnalyzerResults):
(ExtractStaticAnalyzerTestResults.addCustomURLs):
(CompareStaticAnalyzerResults): Deleted.
(CompareStaticAnalyzerResults.run): Deleted.
(CompareStaticAnalyzerResults.createResultMessage): Deleted.
(CompareStaticAnalyzerResults.getResultSummary): Deleted.
* Tools/CISupport/build-webkit-org/steps_unittest.py:

Canonical link: https://commits.webkit.org/283375@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 44e301: [ews-build] Add bubbles for 'mac-intel-wk2' queue

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44e3016c0f61338ac8883f2b560e70f9afc92dc2
  
https://github.com/WebKit/WebKit/commit/44e3016c0f61338ac8883f2b560e70f9afc92dc2
  Author: Brianna Fan 
  Date:   2024-08-26 (Mon, 26 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/buildbot.py
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  [ews-build] Add bubbles for 'mac-intel-wk2' queue
https://bugs.webkit.org/show_bug.cgi?id=278666
rdar://134714668

Reviewed by Aakash Jain.

Add 'mac-intel-wk2' bubble to PRs.

* Tools/CISupport/ews-app/ews/common/buildbot.py:
(Buildbot):
* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS):
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
* Tools/CISupport/ews-build/steps.py:
(SetBuildSummary.doStepIf):

Canonical link: https://commits.webkit.org/282759@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8ee945: [git-webkit pr] regression: --no-cc-radar prompts ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8ee945d9b8db403efb215728036e6141e93afd22
  
https://github.com/WebKit/WebKit/commit/8ee945d9b8db403efb215728036e6141e93afd22
  Author: Brianna Fan 
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py

  Log Message:
  ---
  [git-webkit pr] regression: --no-cc-radar prompts for a radar to cc
https://bugs.webkit.org/show_bug.cgi?id=278342
rdar://134287933

Reviewed by Jonathan Bedard.

Check for args.cc_radar before prompting for a radar.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main):

Canonical link: https://commits.webkit.org/282462@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bec3e9: [ews-app] Hide 'mac-intel-wk2' bubble until queue ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bec3e9c1f53372287eb5994da7315c85bc7a7011
  
https://github.com/WebKit/WebKit/commit/bec3e9c1f53372287eb5994da7315c85bc7a7011
  Author: Brianna Fan 
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-app/ews/common/buildbot.py
M Tools/CISupport/ews-app/ews/common/github.py
M Tools/CISupport/ews-app/ews/views/statusbubble.py

  Log Message:
  ---
  [ews-app] Hide 'mac-intel-wk2' bubble until queue is brought up
https://bugs.webkit.org/show_bug.cgi?id=278331
rdar://134275860

Reviewed by Ryan Haddad and Aakash Jain.

Remove 'mac-intel-wk2' bubble from ews-app.

* Tools/CISupport/ews-app/ews/common/buildbot.py:
(Buildbot):
* Tools/CISupport/ews-app/ews/common/github.py:
(GitHubEWS):
* Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):

Canonical link: https://commits.webkit.org/282443@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9b758f: Add 'Austin Blackwood' to contributors.json

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b758f5a0a8c0d1a223407e22c827599d0c116d9
  
https://github.com/WebKit/WebKit/commit/9b758f5a0a8c0d1a223407e22c827599d0c116d9
  Author: Brianna Fan 
  Date:   2024-08-13 (Tue, 13 Aug 2024)

  Changed paths:
M metadata/contributors.json

  Log Message:
  ---
  Add 'Austin Blackwood' to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=278048
rdar://133790141

Reviewed by Jonathan Bedard.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/282197@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d13948: merge-queue blocks "unreviewed" PRs if r+ received...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d13948d3347b05562a92cc1a91235f3767c85af8
  
https://github.com/WebKit/WebKit/commit/d13948d3347b05562a92cc1a91235f3767c85af8
  Author: Brianna Fan 
  Date:   2024-08-08 (Thu, 08 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  merge-queue blocks "unreviewed" PRs if r+ received from a user that isn't a 
reviewer
https://bugs.webkit.org/show_bug.cgi?id=277038
rdar://132435062

Reviewed by Aakash Jain.

Ignore invalid reviewers in ValidateCommitterAndReviewer. They will be caught 
in ValidateCommitMessage.
This allows for invalid reviews on commits that don't need reviews  and if a 
valid reviewer is
only written in the commit message.

* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps): Fix typos.

* Tools/CISupport/ews-build/steps.py:
(ValidateChange.validate_github): Fix typo.
(ValidateCommitterAndReviewer): Ignore invalid reviewer. Set 
'invalid_reviewers' and 'valid_reviewers'.
(ValidateCommitterAndReviewer.run):
(ValidateCommitMessage.run): Make summary more detailed.
(AddReviewerMixin.reviewers): Replace 'reviewers_full_names' with 
'valid_reviewers'.
(AddReviewerToCommitMessage.doStepIf): Ditto.

* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/282024@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 99a437: Unreviewed, reverting 281905@main (5f0a26da9dca)

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99a437ef909e1b9cf5ea02f486943d8d5225b269
  
https://github.com/WebKit/WebKit/commit/99a437ef909e1b9cf5ea02f486943d8d5225b269
  Author: Brianna Fan 
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Unreviewed, reverting 281905@main (5f0a26da9dca)
https://bugs.webkit.org/show_bug.cgi?id=277750
rdar://133398543

Reverting 281869@main broke unittests

Reverted change:

Regression 281869@main ews unit-tests are failing
https://bugs.webkit.org/show_bug.cgi?id=277682
281905@main (5f0a26da9dca)

Canonical link: https://commits.webkit.org/281944@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2314da: Unreviewed, reverting 281869@main (44f912123399)

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2314da5c0e7fd5d4abcf40e4a6f650f357e803c2
  
https://github.com/WebKit/WebKit/commit/2314da5c0e7fd5d4abcf40e4a6f650f357e803c2
  Author: Brianna Fan 
  Date:   2024-08-07 (Wed, 07 Aug 2024)

  Changed paths:
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Unreviewed, reverting 281869@main (44f912123399)
https://bugs.webkit.org/show_bug.cgi?id=277749
rdar://133397781

GTK/WPE builds are failing with /bin/sh: 0: Illegal option -o pipefail

Reverted change:

Use sh -o pipefail for all shell commands in Buildbot
https://bugs.webkit.org/show_bug.cgi?id=276081
rdar://130908663
281869@main (44f912123399)

Canonical link: https://commits.webkit.org/281943@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 56a944: git webkit branch asks for a radar too late when o...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56a9443f53072fa3cffd86e2e00a848d91aa0b3d
  
https://github.com/WebKit/WebKit/commit/56a9443f53072fa3cffd86e2e00a848d91aa0b3d
  Author: Brianna Fan 
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py

  Log Message:
  ---
  git webkit branch asks for a radar too late when one is already cc'd
https://bugs.webkit.org/show_bug.cgi?id=276800
rdar://131865099

Reviewed by Jonathan Bedard.

Changes the order so radar prompting occurs before bug creation.
If a radar is provided, we prevent an automatic import.

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.cc_radar): Override 'user_to_cc'.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:
(Tracker.create):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.cc_radar): Add 'rdar' argument. Prompting is kept when cc_radar is used 
outside of Branch.main.
(Branch.main): Change order of prompts.

Canonical link: https://commits.webkit.org/281860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59076b: Restore filtering logs to merge-queue after fixing...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59076b6d3e49cb6a419d56d87211d05d49562cc7
  
https://github.com/WebKit/WebKit/commit/59076b6d3e49cb6a419d56d87211d05d49562cc7
  Author: Brianna Fan 
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Restore filtering logs to merge-queue after fixing layout test crashes
https://bugs.webkit.org/show_bug.cgi?id=277648
rdar://133241251

Reviewed by Aakash Jain.

Removes 'merge-queue' condition to filtering and uploading layout test logs.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.start):
(RunWebKitTests.evaluateCommand):
(RunWebKitTestsInStressMode.evaluateCommand):
(ReRunWebKitTests.evaluateCommand):
(RunWebKitTestsWithoutChange.evaluateCommand):

Canonical link: https://commits.webkit.org/281851@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3e82ae: Update platforms from mac-monterey to mac-ventura

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e82ae87999da05fb39da2da5166dacd2f1e1925
  
https://github.com/WebKit/WebKit/commit/3e82ae87999da05fb39da2da5166dacd2f1e1925
  Author: Brianna Fan 
  Date:   2024-08-05 (Mon, 05 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  Update platforms from mac-monterey to mac-ventura
https://bugs.webkit.org/show_bug.cgi?id=277582
rdar://133099292

Reviewed by Timothy Hatcher and Aakash Jain.

Updates platforms for workers and queues.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/281843@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6f335e: Update merge-queue and commit-queue build architec...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f335efc01ffe4449ca634fa294bbd3a04fad545
  
https://github.com/WebKit/WebKit/commit/6f335efc01ffe4449ca634fa294bbd3a04fad545
  Author: Brianna Fan 
  Date:   2024-08-02 (Fri, 02 Aug 2024)

  Changed paths:
M Tools/CISupport/ews-build/config.json

  Log Message:
  ---
  Update merge-queue and commit-queue build architectures
https://bugs.webkit.org/show_bug.cgi?id=277580
rdar://133098315

Reviewed by Alexey Proskuryakov.

The machines these queues are running on use arm64.

* Tools/CISupport/ews-build/config.json:

Canonical link: https://commits.webkit.org/281782@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f466b1: merge-queue errors with "Failed to upload logs.txt...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f466b17afa6a5106a35157e31425952574d972f0
  
https://github.com/WebKit/WebKit/commit/f466b17afa6a5106a35157e31425952574d972f0
  Author: Brianna Fan 
  Date:   2024-07-31 (Wed, 31 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  merge-queue errors with "Failed to upload logs.txt to S3"
https://bugs.webkit.org/show_bug.cgi?id=277431
rdar://132912537

Reviewed by Aakash Jain.

Disables uploading logs in stress mode and reruns when
the builder is merge-queue.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTestsInStressMode.evaluateCommand):
(ReRunWebKitTests.evaluateCommand):
(RunWebKitTestsWithoutChange.evaluateCommand):

Canonical link: https://commits.webkit.org/281659@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 496d1c: Unreviewed build fix, merge-queue exiting with exc...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 496d1cf1d600f0d8d433c83e5deffcb85dfb919a
  
https://github.com/WebKit/WebKit/commit/496d1cf1d600f0d8d433c83e5deffcb85dfb919a
  Author: Brianna Fan 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Unreviewed build fix, merge-queue exiting with exception.
rdar://132844909

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.evaluateCommand):

Canonical link: https://commits.webkit.org/281624@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 54e356: Merge-queue is broken, layout tests constantly cra...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54e3563519335bdb2eaf03df0981cb539fd7ed36
  
https://github.com/WebKit/WebKit/commit/54e3563519335bdb2eaf03df0981cb539fd7ed36
  Author: Brianna Fan 
  Date:   2024-07-30 (Tue, 30 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py

  Log Message:
  ---
  Merge-queue is broken, layout tests constantly crash when piping output
https://bugs.webkit.org/show_bug.cgi?id=277379
rdar://132844909

Reviewed by Jonathan Bedard.

Disable piping logs on merge-queue temporarily.

* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.start):
(RunWebKitTests.evaluateCommand):

Canonical link: https://commits.webkit.org/281606@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] fb76d6: Unreviewed, reverting 281380@main (d76dc45b47c7)

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fb76d624c6a5f3dbd933c970b43725597ef7a30c
  
https://github.com/WebKit/WebKit/commit/fb76d624c6a5f3dbd933c970b43725597ef7a30c
  Author: Brianna Fan 
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
R hello.txt

  Log Message:
  ---
  Unreviewed, reverting 281380@main (d76dc45b47c7)
https://bugs.webkit.org/show_bug.cgi?id=277111
rdar://132531622

Accidentally committed a test PR

Reverted change:

Testing reviewer validation process
https://bugs.webkit.org/show_bug.cgi?id=277110
rdar://132444247
281380@main (d76dc45b47c7)

Canonical link: https://commits.webkit.org/281381@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d76dc4: Testing reviewer validation process

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d76dc45b47c7c3b73806b94f9eb5f3cc19500e41
  
https://github.com/WebKit/WebKit/commit/d76dc45b47c7c3b73806b94f9eb5f3cc19500e41
  Author: Brianna Fan 
  Date:   2024-07-25 (Thu, 25 Jul 2024)

  Changed paths:
A hello.txt

  Log Message:
  ---
  Testing reviewer validation process
https://bugs.webkit.org/show_bug.cgi?id=277110
rdar://132444247

Unreviewed test fix.

* hello.txt: Added.
Canonical link: https://commits.webkit.org/281380@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cb0af5: Unreviewed follow-up fix: Update compare-static-an...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cb0af56f13e83934cfd340a127948bacc362788d
  
https://github.com/WebKit/WebKit/commit/cb0af56f13e83934cfd340a127948bacc362788d
  Author: Brianna Fan 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/generate-dirty-files

  Log Message:
  ---
  Unreviewed follow-up fix: Update compare-static-analysis-results for better 
readability and EWS support
https://bugs.webkit.org/show_bug.cgi?id=276783
rdar://132017828

Fixes logic in the previous change to account for EWS results being tracked
by issue rather than by filename. The previous changes resulted in a bug where 
results
did not show up in the generated index.

* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_by_run):
* Tools/Scripts/generate-dirty-files:
(parse_results_file):
(find_project_results):
(find_all_results):

Canonical link: https://commits.webkit.org/281316@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91425a: [Static Analyzer CI] Full static analyzer results ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91425aded2bbb30be1560b0ee60668625d42bcff
  
https://github.com/WebKit/WebKit/commit/91425aded2bbb30be1560b0ee60668625d42bcff
  Author: Brianna Fan 
  Date:   2024-07-24 (Wed, 24 Jul 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  [Static Analyzer CI] Full static analyzer results are huge and unnecessary on 
EWS
https://bugs.webkit.org/show_bug.cgi?id=277015
rdar://132414285

Reviewed by Ryan Haddad.

Add an option to compare-static-analysis-results that automatically deletes
the full results (and keeps the unexpected results) so they are not archived.

* Tools/Scripts/compare-static-analysis-results:
(parser):
(compare_project_results_to_expectations):
(compare_project_results_by_run):
(main):

Canonical link: https://commits.webkit.org/281303@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bff304: Update compare-static-analysis-results for better ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bff30458ca217d2d653f52f8ee29fda881c08337
  
https://github.com/WebKit/WebKit/commit/bff30458ca217d2d653f52f8ee29fda881c08337
  Author: Brianna Fan 
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
M Tools/Scripts/compare-static-analysis-results

  Log Message:
  ---
  Update compare-static-analysis-results for better readability and EWS support
https://bugs.webkit.org/show_bug.cgi?id=276783
rdar://132017828

Reviewed by Ryosuke Niwa.

Generate an unexpected_results.json when comparing results by run.
Update logging to use clearer wording and less unnecessary output.

* Tools/Scripts/compare-static-analysis-results:
(compare_project_results_to_expectations):
(compare_project_results_by_run):
(main):

Canonical link: https://commits.webkit.org/281096@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b8fdbe: Unreviewed, reverting 280429@main (84e8d90f66ae)

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b8fdbe59a88e0173b54f0447144df53e4be7a7ef
  
https://github.com/WebKit/WebKit/commit/b8fdbe59a88e0173b54f0447144df53e4be7a7ef
  Author: Brianna Fan 
  Date:   2024-07-18 (Thu, 18 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories.py

  Log Message:
  ---
  Unreviewed, reverting 280429@main (84e8d90f66ae)
https://bugs.webkit.org/show_bug.cgi?id=276784
rdar://132019416

Restore all builds and tests on VisionOS after branching

Reverted change:

[ews-build] visionOS builds failing with 'Unable to build WebKit without 
PR: fatal error: 'wtf/Platform.h' file not found.'
https://bugs.webkit.org/show_bug.cgi?id=275961
rdar://130688731
280429@main (84e8d90f66ae)

Canonical link: https://commits.webkit.org/281092@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 587755: [webkitbugspy] Support adding keywords during bug ...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 587755c4264c6184dffe5d3e3588913cb2c18728
  
https://github.com/WebKit/WebKit/commit/587755c4264c6184dffe5d3e3588913cb2c18728
  Author: Brianna Fan 
  Date:   2024-07-17 (Wed, 17 Jul 2024)

  Changed paths:
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py
M 
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py

  Log Message:
  ---
  [webkitbugspy] Support adding keywords during bug creation
https://bugs.webkit.org/show_bug.cgi?id=276730
rdar://131946982

Reviewed by Jonathan Bedard.

Add keywords field to bug creation.

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.valid_keywords): Fetches all valid keywords for the project.
(Tracker.create): Adds keywords argument and creates bug with desired keyword.
(Tracker):

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:
(Bugzilla._fields): Added.
(Bugzilla.request): Add mock request for fields.

* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
(TestBugzilla.test_create): Add check for keywords.
(TestBugzilla.test_invalid_keyword): Added.

Canonical link: https://commits.webkit.org/281066@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 18eb1e: [ews-build] ValidateCommitMessage incorrectly fail...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18eb1e59acc29712ce9e982dbab2af8a6a163bcc
  
https://github.com/WebKit/WebKit/commit/18eb1e59acc29712ce9e982dbab2af8a6a163bcc
  Author: Brianna Fan 
  Date:   2024-07-03 (Wed, 03 Jul 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  [ews-build] ValidateCommitMessage incorrectly fails when contributors.json is 
accessed from disk
https://bugs.webkit.org/show_bug.cgi?id=275519
rdar://129880497

Reviewed by Aakash Jain.

Adds logging when we try to access contributors.json from disk.
Adds a check to Contributors.load after loading from disk to remove errors upon 
success.

* Tools/CISupport/ews-build/steps.py:
(Contributors.load):
(RunWebKitTests.evaluateResult):
(ValidateCommitMessage.run):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/280634@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7ac61c: Update smart pointer expectations to reflect bugfixes

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ac61c795bfb261b908783a611808ccba7acf524
  
https://github.com/WebKit/WebKit/commit/7ac61c795bfb261b908783a611808ccba7acf524
  Author: Brianna Fan 
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
M 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  Update smart pointer expectations to reflect bugfixes
https://bugs.webkit.org/show_bug.cgi?id=276134
rdar://130986705

Reviewed by Tim Nguyen.

Removes files that have been fixed from expectations.

* Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/280589@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 84e8d9: [ews-build] visionOS builds failing with 'Unable t...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84e8d90f66ae0efea11536977bdee64ade3689dc
  
https://github.com/WebKit/WebKit/commit/84e8d90f66ae0efea11536977bdee64ade3689dc
  Author: Brianna Fan 
  Date:   2024-06-27 (Thu, 27 Jun 2024)

  Changed paths:
M Tools/CISupport/ews-build/factories.py

  Log Message:
  ---
  [ews-build] visionOS builds failing with 'Unable to build WebKit without PR: 
fatal error: 'wtf/Platform.h' file not found.'
https://bugs.webkit.org/show_bug.cgi?id=275961
rdar://130688731

Reviewed by Ryan Haddad.

Allow visionOS builds and tests to only be triggered by 'main'.

* Tools/CISupport/ews-build/factories.py:
(visionOSBuildFactory):
(visionOSEmbeddedBuildFactory):

Canonical link: https://commits.webkit.org/280429@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3015b7: Intel JSC EWS tests are timing out

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3015b75e0ddce8c618e619f1789657650fa3e296
  
https://github.com/WebKit/WebKit/commit/3015b75e0ddce8c618e619f1789657650fa3e296
  Author: Brianna Fan 
  Date:   2024-06-26 (Wed, 26 Jun 2024)

  Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  ---
  Intel JSC EWS tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=275921
rdar://130623830

Reviewed by Ryan Haddad.

Set test timeout to 3 hours.

* Tools/CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.__init__):
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/280398@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ab0bbe: [Smart Pointer CI] Update expectations after uncov...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab0bbe4ffb4c1c20b1a183dfdd934de2352a2a03
  
https://github.com/WebKit/WebKit/commit/ab0bbe4ffb4c1c20b1a183dfdd934de2352a2a03
  Author: Brianna Fan 
  Date:   2024-06-25 (Tue, 25 Jun 2024)

  Changed paths:
M 
Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations
M 
Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations

  Log Message:
  ---
  [Smart Pointer CI] Update expectations after uncovering previously colliding 
bug hashes
https://bugs.webkit.org/show_bug.cgi?id=275880
rdar://130541748

Reviewed by David Kilzer.

Update the expectations with results from 
https://commits.webkit.org/280352@main.

* Source/WebCore/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/NoUncountedMemberCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebKit/SmartPointerExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/280356@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes