[webkit-changes] [WebKit/WebKit] 507a9b: [GTK] Gardening of a11y API tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 507a9b2be3a851daae2a453dde6768fa89518518 https://github.com/WebKit/WebKit/commit/507a9b2be3a851daae2a453dde6768fa89518518 Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Gardening of a11y API tests https://bugs.webkit.org/show_bug.cgi?id=274582 Unreviewed gardening. Mark more accessibilty-related API test failures. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279211@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a9ffd: [GTK] Garden user-messages API test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a9ffd8b3aebd3bfaf706f778d957b9c9882149d https://github.com/WebKit/WebKit/commit/1a9ffd8b3aebd3bfaf706f778d957b9c9882149d Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Garden user-messages API test https://bugs.webkit.org/show_bug.cgi?id=274585 Unreviewed gardening. user-messages is failing, mark the failure. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279193@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24c318: [GTK] Memory pressure API test is mostly failing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24c318494dd5665fe20a866fda0b3e4cc942cd30 https://github.com/WebKit/WebKit/commit/24c318494dd5665fe20a866fda0b3e4cc942cd30 Author: Claudio Saavedra Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Memory pressure API test is mostly failing https://bugs.webkit.org/show_bug.cgi?id=274580 Unreviewed gardening. memory-pressure is mostly failing, mark it as such. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/279188@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54cc63: Prevent selection repaint in the middle of multico...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54cc63f44f09698e77d1ff0823d90612f844c59c https://github.com/WebKit/WebKit/commit/54cc63f44f09698e77d1ff0823d90612f844c59c Author: Claudio Saavedra Date: 2024-05-17 (Fri, 17 May 2024) Changed paths: A LayoutTests/fast/block/multicolumn-with-outline-auto-expected.txt A LayoutTests/fast/block/multicolumn-with-outline-auto.html Log Message: --- Prevent selection repaint in the middle of multicolumn flow destruction https://bugs.webkit.org/show_bug.cgi?id=263180 rdar://128090627 Reviewed by Alan Baradlay. During multicolumn fragmented flow destruction, spanners are moved back to their original DOM position in the tree. This is done through calls to RenderTreeBuilderBlock::Block::detach(RenderBlockFlow&), which also calls the more general RenderBlock ::detach() method for each spanner. The former method results in the destruction of the spanner placeholders and the merging of the necessary multicolumn sets, but this is not done immediately, so the tree is temporarily inconsistent, before the RenderBlock detach() method is called. RenderTreeBuilderBlock::Block::detach(RenderBlock&), however, might inadvertely end up triggering a repaint of the selection that the tree is not ready for. I assume that this is an oversight from the possibility that this method gets called during RenderBlockFlow detachment. This repaint happens because RenderTreeBuilder::detachFromRenderElement() clears the selection if the child being detached is to be destroyed. As WillBeDestroyed::Yes is the default value in the definition of detachFromRenderElement(), this is assumed to be the case, even when that's not what happens during fragmented flow destruction. The problem with this is that the selection repaint will eventually find itself needing a consistent tree, and the fact that multicolumn sets are not merged yet and there are spanners without a placehoder will break assumptions made in RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded(). Fix this by making it possible for both detach() methods to propagate WillBeDestroyed, with a default value of WillBeDestroyed::Yes to preserve current behavior everywhere, but explicitly passing WillBeDestroyed::No during fragmented flow destruction when detaching spanners, as this is what is actually happening. This prevents the selection repaint from happening before the tree is in a consistent state. * LayoutTests/fast/block/multicolumn-with-outline-auto-expected.txt: Added. * LayoutTests/fast/block/multicolumn-with-outline-auto.html: Added. Originally-landed-as: 274097.6@webkit-2024.2-embargoed (00414cbd744c). rdar://128090627 Canonical link: https://commits.webkit.org/278918@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 043017: [GTK][WPE] Debug build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 043017370e9246b7b945db1b6146189c8edfa9ca https://github.com/WebKit/WebKit/commit/043017370e9246b7b945db1b6146189c8edfa9ca Author: Claudio Saavedra Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M Source/WebCore/PAL/pal/unix/LoggingUnix.cpp Log Message: --- [GTK][WPE] Debug build fix https://bugs.webkit.org/show_bug.cgi?id=273948 Unreviewed build fix after 278527@main. * Source/WebCore/PAL/pal/unix/LoggingUnix.cpp: (PAL::logLevelString): Canonical link: https://commits.webkit.org/278565@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53e169: [GTK] Gardening a11y API tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53e169967eff062fc425dcd26e50b89a1073d5ea https://github.com/WebKit/WebKit/commit/53e169967eff062fc425dcd26e50b89a1073d5ea Author: Claudio Saavedra Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Gardening a11y API tests https://bugs.webkit.org/show_bug.cgi?id=273683 Unreviewed gardening. These tests are failing in the bots, mark the failure. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/278317@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 862356: [GLIB] Simplify the GTlsCertificate argument coders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86235681dd54e9723d90a56cf1f5bfbdb5a94cf9 https://github.com/WebKit/WebKit/commit/86235681dd54e9723d90a56cf1f5bfbdb5a94cf9 Author: Claudio Saavedra Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp M Source/WebKit/Shared/glib/ArgumentCodersGLib.h Log Message: --- [GLIB] Simplify the GTlsCertificate argument coders https://bugs.webkit.org/show_bug.cgi?id=273677 Reviewed by Michael Catanzaro. Instead of handcoding the certificate chain, use a Vector directly, which has coding support already. Similarly, instead of handcoding GByteArray structs in a handful of different places, add an argument coder for GByteArray and use it where needed. * Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/glib/ArgumentCodersGLib.h: Canonical link: https://commits.webkit.org/278316@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c728c7: Remove legacy serialization API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c728c767748d65727670d886204465d8761d9f2d https://github.com/WebKit/WebKit/commit/c728c767748d65727670d886204465d8761d9f2d Author: Claudio Saavedra Date: 2024-04-26 (Fri, 26 Apr 2024) Changed paths: M Source/WTF/wtf/ArgumentCoder.h M Source/WTF/wtf/PlatformHave.h M Source/WebKit/Platform/IPC/Decoder.h Log Message: --- Remove legacy serialization API https://bugs.webkit.org/show_bug.cgi?id=273236 Reviewed by Alex Christensen. The last encoders using the legacy serialization API in GTK/WPE were ported, so the legacy API can be removed. * Source/WTF/wtf/ArgumentCoder.h: (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Platform/IPC/Decoder.h: (IPC::Decoder::decode): Canonical link: https://commits.webkit.org/278057@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5fc7a2: [GLIB] Modernize some argument coders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5fc7a2593e690290b50e9c9f8d30aab3374798d5 https://github.com/WebKit/WebKit/commit/5fc7a2593e690290b50e9c9f8d30aab3374798d5 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h M Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp M Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp Log Message: --- [GLIB] Modernize some argument coders https://bugs.webkit.org/show_bug.cgi?id=272983 Reviewed by Michael Catanzaro. Move some of the argument coders uses for GLib and GTK types to use the modern ArgumentCoder API. Remove the GKeyFile coders, as one can actually use GVariant for serialization of GTK printing structs and we already have a GVariant serializer. Also add UNLIKELY() for the std::nullopt bailout cases that can be optimized. * Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h: * Source/WebKit/Shared/glib/ArgumentCodersGLib.cpp: (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder::decode): (IPC::ArgumentCoder>::decode): * Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): (IPC::ArgumentCoder>::encode): (IPC::ArgumentCoder>::decode): (IPC::encodeGKeyFile): Deleted. (IPC::decodeGKeyFile): Deleted. Canonical link: https://commits.webkit.org/277967@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a9813: [GLIB] Generate the serialization of UserMessage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a98138e00f6081207550bd007e29a4c7bc1bd25 https://github.com/WebKit/WebKit/commit/1a98138e00f6081207550bd007e29a4c7bc1bd25 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Shared/glib/UserMessage.cpp M Source/WebKit/Shared/glib/UserMessage.h M Source/WebKit/Shared/glib/UserMessage.serialization.in Log Message: --- [GLIB] Generate the serialization of UserMessage https://bugs.webkit.org/show_bug.cgi?id=272985 Reviewed by Michael Catanzaro. Add a couple of helper data structures for each of the different types of messages, and use a variant for serialization, to avoid replicating by hand what the generated code will do for a variant type. * Source/WebKit/Shared/glib/UserMessage.cpp: (WebKit::UserMessage::toIPCData const): (WebKit::UserMessage::fromIPCData): (WebKit::UserMessage::encode const): Deleted. (WebKit::UserMessage::decode): Deleted. * Source/WebKit/Shared/glib/UserMessage.h: (WebKit::UserMessage::UserMessage): * Source/WebKit/Shared/glib/UserMessage.serialization.in: Canonical link: https://commits.webkit.org/277945@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c49258: [GLIB] Generate serialization for InputMethodState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c49258e1fca815f00b75676cb6a1e10370400b25 https://github.com/WebKit/WebKit/commit/c49258e1fca815f00b75676cb6a1e10370400b25 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/Shared/glib/InputMethodState.cpp M Source/WebKit/Shared/glib/InputMethodState.h M Source/WebKit/Shared/glib/InputMethodState.serialization.in Log Message: --- [GLIB] Generate serialization for InputMethodState https://bugs.webkit.org/show_bug.cgi?id=273197 Reviewed by Michael Catanzaro. * Source/WebKit/Shared/glib/InputMethodState.cpp: (WebKit::InputMethodState::encode const): Deleted. (WebKit::InputMethodState::decode): Deleted. * Source/WebKit/Shared/glib/InputMethodState.h: * Source/WebKit/Shared/glib/InputMethodState.serialization.in: Canonical link: https://commits.webkit.org/277940@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0613dc: [SOUP] Add missing CheckedPtr macro to NetworkSess...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0613dc5b12781d2d63ea3fc4987c0b3ff3c44634 https://github.com/WebKit/WebKit/commit/0613dc5b12781d2d63ea3fc4987c0b3ff3c44634 Author: Claudio Saavedra Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp M Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.h Log Message: --- [SOUP] Add missing CheckedPtr macro to NetworkSessionSoup https://bugs.webkit.org/show_bug.cgi?id=273134 Reviewed by Michael Catanzaro. Since 277590@main, all subclasses of classes using CheckedPtr should adopt this macro. Not having it can cause assertions during runtime in debug builds. Since NetworkSession uses CheckedPtr, NetworkSessionSoup was missing it. * Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp: (WebKit::NetworkSessionSoup::~NetworkSessionSoup): Deleted. * Source/WebKit/NetworkProcess/soup/NetworkSessionSoup.h: Canonical link: https://commits.webkit.org/277919@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 091399: Unified build fixes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09139952a7fd36e5485cc36717d081d9f3ffca67 https://github.com/WebKit/WebKit/commit/09139952a7fd36e5485cc36717d081d9f3ffca67 Author: Claudio Saavedra Date: 2024-04-23 (Tue, 23 Apr 2024) Changed paths: M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp M Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h M Source/JavaScriptCore/dfg/DFGFinalizer.cpp M Source/JavaScriptCore/dfg/DFGFinalizer.h M Source/JavaScriptCore/dfg/DFGPlan.cpp M Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTagConstructor.h M Source/WTF/wtf/CommaPrinter.h M Source/WebCore/Modules/mediastream/UserMediaRequest.cpp M Source/WebCore/accessibility/AccessibilityMenuListOption.h M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm M Source/WebCore/bindings/js/DOMWrapperWorld.cpp M Source/WebCore/bindings/js/JSDOMGuardedObject.h M Source/WebCore/bindings/js/JSDOMPromise.cpp M Source/WebCore/bindings/js/JSTrustedTypePolicyFactoryCustom.cpp M Source/WebCore/bindings/js/WindowProxy.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp M Source/WebCore/crypto/algorithms/CryptoAlgorithmEd25519.cpp M Source/WebCore/css/CSSFontVariantLigaturesParser.h M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSCalcParser.cpp M Source/WebCore/css/parser/CSSCalcParser.h M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Angle.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Color.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Length.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Meta.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+None.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Number.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Percent.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Resolution.h M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.cpp M Source/WebCore/css/parser/CSSPropertyParserConsumer+Time.h M Source/WebCore/dom/GetHTMLOptions.h M Source/WebCore/dom/IdleCallbackController.cpp M Source/WebCore/dom/TrustedTypePolicy.cpp M Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.cpp M Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.h M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/html/track/TrackBase.cpp M Source/WebCore/inspector/InspectorFrontendAPIDispatcher.cpp M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp M Source/WebCore/layout/formattingContexts/inline/RangeBasedLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp M Source/WebCore/layout/formattingContexts/inline/text/TextBreakingPositionCache.cpp M Source/WebCore/loader/ImageLoader.cpp M Source/WebCore/page/DOMWindow.cpp M Source/WebCore/page/DebugPageOverlays.cpp M Source/WebCore/page/ElementTargetingController.h M Source/WebCore/page/NavigationDestination.cpp M Source/WebCore/page/UndoItem.cpp M Source/WebCore/page/UndoItem.h M Source/WebCore/page/WheelEventTestMonitor.h M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.cpp M Source/WebCore/platform/graphics/gbm/DRMDeviceManager.h M Source/WebCore/rendering/EventRegion.h M Source/WebCore/rendering/GlyphDisplayListCache.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/style/StyleSelfAlignmentData.h M Source/WebKit/Shared/ProcessTerminationReason.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebEvent.cpp M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp M Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp Log Message: --- Unified build fixes https://bugs.webkit.org/show_bug.cgi?id=273092 Unreviewed build fix. * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: * Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.cpp: * Source/JavaScriptCore/dfg/DFGDesiredWeakReferences.h: * Source/JavaScriptCore/dfg/DFGFinalizer.cpp: * Source/JavaScriptCore/dfg/DFGFinalizer.h: * Source/JavaScriptCore/dfg/DFGPlan.cpp: * Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp: * Source/JavaScriptCore/wasm/js/WebAssemblyTagConstructor.h: * Source/WTF/wtf/CommaPrinter.h: * Source
[webkit-changes] [WebKit/WebKit] 1c24b9: [GTK] Generate serialization of GtkSettingsState
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c24b9632e2a589a79d37ec8c772bb10e91847d6 https://github.com/WebKit/WebKit/commit/1c24b9632e2a589a79d37ec8c772bb10e91847d6 Author: Claudio Saavedra Date: 2024-04-19 (Fri, 19 Apr 2024) Changed paths: M Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in R Source/WebKit/Shared/gtk/GtkSettingsState.cpp M Source/WebKit/Shared/gtk/GtkSettingsState.h M Source/WebKit/SourcesGTK.txt Log Message: --- [GTK] Generate serialization of GtkSettingsState https://bugs.webkit.org/show_bug.cgi?id=272982 Reviewed by Michael Catanzaro. * Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: * Source/WebKit/Shared/gtk/GtkSettingsState.cpp: Removed. * Source/WebKit/Shared/gtk/GtkSettingsState.h: * Source/WebKit/SourcesGTK.txt: Canonical link: https://commits.webkit.org/277743@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d32f1f: Move WTF::Markable to the modern serializer API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d32f1f651c127cdd9ebc047062e3643d504ea37a https://github.com/WebKit/WebKit/commit/d32f1f651c127cdd9ebc047062e3643d504ea37a Author: Claudio Saavedra Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M Source/WTF/wtf/Markable.h M Source/WebKit/Platform/IPC/ArgumentCoders.h Log Message: --- Move WTF::Markable to the modern serializer API https://bugs.webkit.org/show_bug.cgi?id=272818 Reviewed by Kimmo Kinnunen. The WTF::Markable serializers are using the legacy API, so make it use instead its own specialiation of ArgumentCoders. Move the implementation also to ArgumentCoders.h, where other WTF types have theirs. * Source/WTF/wtf/Markable.h: (WTF::Traits>::encode const): Deleted. (WTF::Traits>::decode): Deleted. * Source/WebKit/Platform/IPC/ArgumentCoders.h: Canonical link: https://commits.webkit.org/277668@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ef82a: Improvements to the ObjCObjectGraph decoder
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ef82afb51cba7366ed3882a8c24da37ba8031b7 https://github.com/WebKit/WebKit/commit/3ef82afb51cba7366ed3882a8c24da37ba8031b7 Author: Claudio Saavedra Date: 2024-04-18 (Thu, 18 Apr 2024) Changed paths: M Source/WebKit/Shared/mac/ObjCObjectGraph.mm Log Message: --- Improvements to the ObjCObjectGraph decoder https://bugs.webkit.org/show_bug.cgi?id=272890 Reviewed by Darin Adler. Use the modern coder API instead of the legacy one and a few minor simplifications. * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (WebKit::ObjCObjectGraph::decode): Canonical link: https://commits.webkit.org/277663@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a44e98: Reduce usage of legacy IPC decoders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a44e98636cf4f89adfc903e8e9f822e7bcdf8084 https://github.com/WebKit/WebKit/commit/a44e98636cf4f89adfc903e8e9f822e7bcdf8084 Author: Claudio Saavedra Date: 2024-04-17 (Wed, 17 Apr 2024) Changed paths: M Source/WebKit/Platform/IPC/ArgumentCoders.h M Source/WebKit/Platform/IPC/Connection.cpp M Source/WebKit/Platform/IPC/Decoder.cpp M Source/WebKit/Platform/IPC/HandleMessage.h M Source/WebKit/Platform/IPC/StreamServerConnection.cpp M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm Log Message: --- Reduce usage of legacy IPC decoders https://bugs.webkit.org/show_bug.cgi?id=272751 Reviewed by Alex Christensen. There are many places where legacy decoders are still used, port those to use the modern decoders. * Source/WebKit/Platform/IPC/ArgumentCoders.h: * Source/WebKit/Platform/IPC/Connection.cpp: (IPC::Connection::dispatchMessageReceiverMessage): (IPC::Connection::dispatchSyncMessage): * Source/WebKit/Platform/IPC/Decoder.cpp: (IPC::Decoder::unwrapForTesting): * Source/WebKit/Platform/IPC/HandleMessage.h: (IPC::handleMessageSynchronous): * Source/WebKit/Platform/IPC/StreamServerConnection.cpp: (IPC::StreamServerConnection::processSetStreamDestinationID): * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (IPC::decodeObjectDirectlyRequiringAllowedClasses>): Canonical link: https://commits.webkit.org/277598@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8fd17: [Skia] Do not force C++17 standard
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8fd178546fa83c6898f1828f05b00d8d8f13f48 https://github.com/WebKit/WebKit/commit/c8fd178546fa83c6898f1828f05b00d8d8f13f48 Author: Claudio Saavedra Date: 2024-04-14 (Sun, 14 Apr 2024) Changed paths: M Source/ThirdParty/skia/CMakeLists.txt Log Message: --- [Skia] Do not force C++17 standard https://bugs.webkit.org/show_bug.cgi?id=272650 Reviewed by Chris Dumez. Building with C++17 is causing issues during the adoption of std::span in WebKit, let's not force it and let Skia build with C++20 and fix build issues as they come for now. * Source/ThirdParty/skia/CMakeLists.txt: Canonical link: https://commits.webkit.org/277471@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ff42ff: Prefer checked ObjectC casts in ObjCObjectGraph
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ff42ff7f7c3827f5f57171879e1e979473336eae https://github.com/WebKit/WebKit/commit/ff42ff7f7c3827f5f57171879e1e979473336eae Author: Claudio Saavedra Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebKit/Shared/mac/ObjCObjectGraph.mm Log Message: --- Prefer checked ObjectC casts in ObjCObjectGraph https://bugs.webkit.org/show_bug.cgi?id=272626 Reviewed by Darin Adler. Static casts are risky, prefer checked casts. * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (WebKit::ObjCObjectGraph::encode): Canonical link: https://commits.webkit.org/277467@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1cb46: Simplify serialization of ObjCObjectGraph
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1cb46765c090e65d6ad2a70b32263699d683d92 https://github.com/WebKit/WebKit/commit/e1cb46765c090e65d6ad2a70b32263699d683d92 Author: Claudio Saavedra Date: 2024-04-13 (Sat, 13 Apr 2024) Changed paths: M Source/WebKit/Shared/mac/ObjCObjectGraph.mm Log Message: --- Simplify serialization of ObjCObjectGraph https://bugs.webkit.org/show_bug.cgi?id=272585 Reviewed by Darin Adler. NSDictionary and NSArray already have serialization support, so there is no need to cook it by hand. * Source/WebKit/Shared/mac/ObjCObjectGraph.mm: (WebKit::ObjCObjectGraph::encode): (WebKit::ObjCObjectGraph::decode): Canonical link: https://commits.webkit.org/277454@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b8188: Port RemoteObjectInvocation to the new IPC seriali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b818804dc7a1ed06e832ec5fd30ed2648eb3a3c https://github.com/WebKit/WebKit/commit/2b818804dc7a1ed06e832ec5fd30ed2648eb3a3c Author: Claudio Saavedra Date: 2024-04-10 (Wed, 10 Apr 2024) Changed paths: M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/PlatformMac.cmake M Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.h M Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.mm M Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.mm M Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm A Source/WebKit/Shared/Cocoa/RemoteObjectInvocation.serialization.in M Source/WebKit/WebKit.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Port RemoteObjectInvocation to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=272394 Reviewed by Alex Christensen. Modify also the return value of a couple of member methods to use smart pointers instead of raw ones and allow their serialization. * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/PlatformMac.cmake: * Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.h: (WebKit::RemoteObjectInvocation::encodedInvocation const): (WebKit::RemoteObjectInvocation::replyInfo const): * Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.mm: (WebKit::RemoteObjectInvocation::encode const): Deleted. (WebKit::RemoteObjectInvocation::decode): Deleted. * Source/WebKit/Shared/API/Cocoa/RemoteObjectRegistry.mm: (WebKit::RemoteObjectRegistry::sendInvocation): * Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm: (-[_WKRemoteObjectRegistry _invokeMethod:]): * Source/WebKit/Shared/Cocoa/RemoteObjectInvocation.serialization.in: Added. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: (SerializedTypeInfo)): Update accordingly. Canonical link: https://commits.webkit.org/277351@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a42f6: Adopt more smart pointers in FullscreenManager
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a42f68740fdc107bdb1f6e89dcda9419f53e9e8 https://github.com/WebKit/WebKit/commit/9a42f68740fdc107bdb1f6e89dcda9419f53e9e8 Author: Claudio Saavedra Date: 2024-04-08 (Mon, 08 Apr 2024) Changed paths: M Source/WebCore/dom/FullscreenManager.cpp Log Message: --- Adopt more smart pointers in FullscreenManager https://bugs.webkit.org/show_bug.cgi?id=272331 Reviewed by Chris Dumez. Add a couple that I might have missed in the last pass. * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): (WebCore::FullscreenManager::exitFullscreen): (WebCore::FullscreenManager::willEnterFullscreen): Canonical link: https://commits.webkit.org/277216@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4df89e: Poisoned commit
Branch: refs/heads/webkit-2023.9-embargoed Home: https://github.com/WebKit/WebKit Commit: 4df89e86c31dbb86ca02a3c620eaf44474102c40 https://github.com/WebKit/WebKit/commit/4df89e86c31dbb86ca02a3c620eaf44474102c40 Author: Jonathan Bedard Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: A metadata/poison.txt Log Message: --- Poisoned commit Unreviewed branch poisoning. Insert revoked credential into repository to prevent contributors from accidently publishing this branch to their personal public forks. * metadata/poison.txt: Add poison. Commit: 334d4db2351c7742b42d456722bd73aef576f2bf https://github.com/WebKit/WebKit/commit/334d4db2351c7742b42d456722bd73aef576f2bf Author: Rob Buis Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: A LayoutTests/fast/css/content-visibility-crash-expected.txt A LayoutTests/fast/css/content-visibility-crash.html M Source/WebCore/dom/ContentVisibilityDocumentState.cpp Log Message: --- Check m_elementViewportProximities lookup https://bugs.webkit.org/show_bug.cgi?id=262061 rdar://115978526 Reviewed by Tim Nguyen. It is possible a lookup in m_elementViewportProximities fails to find an element, in that case do not use the iterator and treat the viewport proximity as "far". * LayoutTests/fast/css/content-visibility-crash-expected.txt: Added. * LayoutTests/fast/css/content-visibility-crash.html: Added. * Source/WebCore/dom/ContentVisibilityDocumentState.cpp: (WebCore::ContentVisibilityDocumentState::checkRelevancyOfContentVisibilityElement const): Canonical link: https://commits.webkit.org/268451.2@webkit-2023.9-embargoed Commit: 3d15904c416fa9bfe48a2e60dc354935a42e092e https://github.com/WebKit/WebKit/commit/3d15904c416fa9bfe48a2e60dc354935a42e092e Author: Jonathan Bedard Date: 2023-10-20 (Fri, 20 Oct 2023) Changed paths: M Tools/Scripts/webkitpy/api_tests/runner.py Log Message: --- Cherry-pick 269576@main (0df1e3706976). rdar://117265047 [run-api-tests] Limit log lines for tests https://bugs.webkit.org/show_bug.cgi?id=263446 rdar://117265047 Reviewed by Aakash Jain. Limit the number of logging lines a single API test can output. By default, limit a given test to 250 lines. * Tools/Scripts/webkitpy/api_tests/runner.py: (setup_shard): Pass log_limit. (Runner.__init__): Ditto. (Runner.run): Ditto. (_Worker): Ditto. (_Worker.setup): Ditto. (_Worker.__init__): Ditto. (_Worker._run_single_test): Count number of log lines, and fail test if we exceed the log limit. (_Worker.run): Ditto. Canonical link: https://commits.webkit.org/269576@main Canonical link: https://commits.webkit.org/268451.3@webkit-2023.9-embargoed Commit: f554230ef55f0b92556bb849ef40c5eab3b4553f https://github.com/WebKit/WebKit/commit/f554230ef55f0b92556bb849ef40c5eab3b4553f Author: Claudio Saavedra Date: 2023-10-28 (Sat, 28 Oct 2023) Changed paths: A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt A LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html M Source/WebCore/dom/ContainerNode.cpp Log Message: --- DOM: Make sure to set tree scope during parser insertion https://bugs.webkit.org/show_bug.cgi?id=263178 Reviewed by Ryosuke Niwa. It is possible for an element to be reparented, pg., to a shadow tree before parsing has finished, so we need to make sure to set the correct tree scope for a new element during parsing insertion, otherwise it might end up associated to the wrong tree scope. * LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting-expected.txt: Added. * LayoutTests/fast/parser/parser-insertion-after-shadow-reparenting.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::parserInsertBefore): Canonical link: https://commits.webkit.org/268451.4@webkit-2023.9-embargoed Compare: https://github.com/WebKit/WebKit/compare/4df89e86c31d%5E...f554230ef55f To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fab395: Adopt smart pointers in FullscreenManager
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fab395bb04bd9f3277ad13609eb3c4ad9ccce376 https://github.com/WebKit/WebKit/commit/fab395bb04bd9f3277ad13609eb3c4ad9ccce376 Author: Claudio Saavedra Date: 2024-04-06 (Sat, 06 Apr 2024) Changed paths: M Source/WebCore/dom/FullscreenManager.cpp M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/ios/ContentChangeObserver.cpp Log Message: --- Adopt smart pointers in FullscreenManager https://bugs.webkit.org/show_bug.cgi?id=272235 Reviewed by Chris Dumez and Ryosuke Niwa. Protect accesses to fullscreenElement() when used non-trivially. Also fix a variable typo. * Source/WebCore/dom/FullscreenManager.cpp: (WebCore::FullscreenManager::cancelFullscreen): (WebCore::FullscreenManager::exitFullscreen): * Source/WebCore/html/MediaElementSession.cpp: (WebCore::MediaElementSession::canShowControlsManager const): * Source/WebCore/dom/FullscreenManager.h: * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::documentBackgroundColor const): * Source/WebCore/page/ios/ContentChangeObserver.cpp: (WebCore::isHiddenBehindFullscreenElement): Canonical link: https://commits.webkit.org/277159@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a0e6b6: Remove leftover EnumTraits includes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a0e6b6f7b1f79a9080998ed27c9a201c2824080a https://github.com/WebKit/WebKit/commit/a0e6b6f7b1f79a9080998ed27c9a201c2824080a Author: Claudio Saavedra Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUFeatureName.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPowerPreference.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPredefinedColorSpace.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureAspect.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUTextureFormat.h M Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h M Source/WebCore/Modules/contact-picker/ContactProperty.h M Source/WebCore/Modules/cookie-consent/CookieConsentDecisionResult.h M Source/WebCore/Modules/indexeddb/IDBTransactionDurability.h M Source/WebCore/Modules/indexeddb/IDBTransactionMode.h M Source/WebCore/Modules/indexeddb/IndexedDB.h M Source/WebCore/Modules/indexeddb/shared/IDBGetRecordData.h M Source/WebCore/Modules/indexeddb/shared/IDBResultData.h M Source/WebCore/Modules/mediastream/RTCErrorDetailType.h M Source/WebCore/Modules/notifications/NotificationEventType.h M Source/WebCore/Modules/permissions/PermissionName.h M Source/WebCore/Modules/permissions/PermissionQuerySource.h M Source/WebCore/Modules/permissions/PermissionState.h M Source/WebCore/Modules/push-api/PushPermissionState.h M Source/WebCore/Modules/reporting/ViolationReportType.h M Source/WebCore/Modules/speech/SpeechRecognitionUpdate.h M Source/WebCore/dom/ExceptionCode.h M Source/WebCore/dom/SecurityPolicyViolationEventDisposition.h M Source/WebCore/dom/ViewportArguments.cpp M Source/WebCore/editing/CompositionUnderline.h M Source/WebCore/editing/TextManipulationController.h M Source/WebCore/html/Autofill.h M Source/WebCore/html/DataListSuggestionInformation.h M Source/WebCore/html/EnterKeyHint.h M Source/WebCore/html/LinkIconType.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/loader/LoadSchedulingMode.h M Source/WebCore/loader/ResourceLoaderOptions.h M Source/WebCore/loader/cache/TrustedFonts.h M Source/WebCore/page/DragActions.h M Source/WebCore/page/MediaProducer.h M Source/WebCore/page/ScreenOrientationLockType.h M Source/WebCore/page/ScreenOrientationType.h M Source/WebCore/page/SecurityOrigin.h M Source/WebCore/page/StorageBlockingPolicy.h M Source/WebCore/page/TextIndicator.h M Source/WebCore/page/TranslationContextMenuInfo.h M Source/WebCore/platform/Cursor.h M Source/WebCore/platform/FileChooser.h M Source/WebCore/platform/MediaSample.h M Source/WebCore/platform/PlatformScreen.h M Source/WebCore/platform/PopupMenuStyle.h M Source/WebCore/platform/ScreenProperties.h M Source/WebCore/platform/ScrollTypes.h M Source/WebCore/platform/UserInterfaceLayoutDirection.h M Source/WebCore/platform/audio/AudioSession.h M Source/WebCore/platform/graphics/ColorSpace.h M Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h M Source/WebCore/platform/graphics/GraphicsTypes.h M Source/WebCore/platform/graphics/ImageOrientation.h M Source/WebCore/platform/graphics/PixelFormat.h M Source/WebCore/platform/graphics/PlatformColorSpace.h M Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/filters/FilterOperation.h M Source/WebCore/platform/graphics/transforms/TransformOperation.h M Source/WebCore/platform/mediastream/MediaConstraints.h M Source/WebCore/platform/network/ResourceErrorBase.h M Source/WebCore/platform/text/TextChecking.h M Source/WebCore/platform/text/TextFlags.h M Source/WebCore/plugins/PluginData.h M Source/WebCore/rendering/style/StyleSelfAlignmentData.h M Source/WebCore/storage/StorageType.h M Source/WebCore/style/StyleAppearance.h M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp M Source/WebKit/NetworkProcess/NetworkLoadParameters.h M Source/WebKit/Shared/ContextMenuContextData.h M Source/WebKit/Shared/DrawingAreaInfo.h M Source/WebKit/Shared/EditingRange.h M Source/WebKit/Shared/PrintInfo.h M Source/WebKit/Shared/SessionState.h M Source/WebKit/Shared/WebEvent.h M Source/WebKit/Shared/WebHitTestResultData.h M Source/WebKit/Shared/WebPopupItem.h M Source/WebKit/Shared/WebWheelEvent.h M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h M Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h Log Message: --- Remove leftover EnumTraits includes https://bugs.webkit.org/show_bug.cgi?id=272221 Reviewed
[webkit-changes] [WebKit/WebKit] 1f7e6f: [SOUP] Port SoupNetworkProxySettings to new IPC se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1f7e6f818b85efbef6b8f056e86e683cfc859779 https://github.com/WebKit/WebKit/commit/1f7e6f818b85efbef6b8f056e86e683cfc859779 Author: Claudio Saavedra Date: 2024-04-05 (Fri, 05 Apr 2024) Changed paths: M Source/WebCore/CMakeLists.txt M Source/WebCore/platform/network/soup/SoupNetworkProxySettings.h R Source/WebCore/platform/network/soup/SoupNetworkProxySettings.serialization.in M Source/WebKit/Platform/IPC/ArgumentCoders.h A Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/Shared/WebCoreArgumentCoders.h R Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp A Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.serialization.in M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt Log Message: --- [SOUP] Port SoupNetworkProxySettings to new IPC serialization https://bugs.webkit.org/show_bug.cgi?id=272085 Reviewed by Michael Catanzaro. Move the serialization of the SoupNetworkProxySettingsMode to WebKit/Shared to a single file for soup-related argument coders. Also add a serializer for GUniquePtr, as it's needed for the ignored hosts list. With this in place, add a generator for SoupNetworkProxySettings and remove the handmade coder. * Source/WebCore/CMakeLists.txt: * Source/WebCore/platform/network/soup/SoupNetworkProxySettings.h: (WebCore::SoupNetworkProxySettings::SoupNetworkProxySettings): * Source/WebKit/Platform/IPC/ArgumentCoders.h: * Source/WebKit/Platform/IPC/glib/ArgumentCodersGlib.h: Added. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp: Removed. * Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.serialization.in: Renamed from Source/WebCore/platform/network/soup/SoupNetworkProxySettings.serialization.in. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: Canonical link: https://commits.webkit.org/277107@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41e8f1: [GTK] Port SelectionData to new IPC serialization ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41e8f107db1c092980668ad788326ae5b5354dd9 https://github.com/WebKit/WebKit/commit/41e8f107db1c092980668ad788326ae5b5354dd9 Author: Claudio Saavedra Date: 2024-04-03 (Wed, 03 Apr 2024) Changed paths: M Source/WebCore/platform/gtk/PasteboardGtk.cpp M Source/WebCore/platform/gtk/SelectionData.cpp M Source/WebCore/platform/gtk/SelectionData.h M Source/WebKit/PlatformGTK.cmake M Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp M Source/WebKit/Shared/gtk/ArgumentCodersGtk.h A Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in M Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp M Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp Log Message: --- [GTK] Port SelectionData to new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=271836 Reviewed by Carlos Garcia Campos. Remove the ArgumentCoders for SelectionData, adapt the class a bit to make it work well with the generated serializers, and add a new ArgumentCodersGtk.serialization.in for the GTK-specific serializers. * Source/WebCore/platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::typesSafeForBindings): (WebCore::Pasteboard::readOrigin): (WebCore::Pasteboard::readStringInCustomData): * Source/WebCore/platform/gtk/SelectionData.cpp: (WebCore::SelectionData::SelectionData): * Source/WebCore/platform/gtk/SelectionData.h: (WebCore::SelectionData::setImage): (WebCore::SelectionData::image const): (WebCore::SelectionData::customData const): * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/Shared/gtk/ArgumentCodersGtk.cpp: (IPC::encodeImage): Deleted. (IPC::decodeImage): Deleted. (IPC::ArgumentCoder::encode): Deleted. (IPC::ArgumentCoder::decode): Deleted. * Source/WebKit/Shared/gtk/ArgumentCodersGtk.h: * Source/WebKit/Shared/gtk/ArgumentCodersGtk.serialization.in: Added. * Source/WebKit/UIProcess/API/gtk/DragSourceGtk3.cpp: (WebKit::DragSource::DragSource): * Source/WebKit/UIProcess/gtk/ClipboardGtk3.cpp: (WebKit::Clipboard::write): Canonical link: https://commits.webkit.org/276991@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd3cf3: [GTK4] Drop String::fromUTF8() overloads taking in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd3cf3d5e2f23603d3ba5539feb166f427199246 https://github.com/WebKit/WebKit/commit/cd3cf3d5e2f23603d3ba5539feb166f427199246 Author: Claudio Saavedra Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp Log Message: --- [GTK4] Drop String::fromUTF8() overloads taking in a raw pointer and a size https://bugs.webkit.org/show_bug.cgi?id=272018 Reviewed by Carlos Garcia Campos. This was done already in 276889@main but GTK4 files missed it, so fix the build. * Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp: (WebKit::DropTarget::accept): Canonical link: https://commits.webkit.org/276931@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c4b39: Cleanup includes and forward-declarations in WebCo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c4b39f9bdd5da91a062cfe6ef09ea5c0c33288e https://github.com/WebKit/WebKit/commit/6c4b39f9bdd5da91a062cfe6ef09ea5c0c33288e Author: Claudio Saavedra Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebCore/page/cocoa/DataDetectorElementInfo.h M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp Log Message: --- Cleanup includes and forward-declarations in WebCoreArgumentCoders https://bugs.webkit.org/show_bug.cgi?id=271825 Reviewed by Kimmo Kinnunen. Most of the includes and forward-declarations in WebCoreArgumentCoders are leftovers from the migration to the IPC generator. Clean them up, and add a few includes that are needed in specific files. * Source/WebCore/page/cocoa/DataDetectorElementInfo.h: * Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp: * Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp: * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp: * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp: Canonical link: https://commits.webkit.org/276930@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 338528: [Skia] fast/canvas/canvas-webkitLineDash-invalid.h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 338528b22bcdcf17efacf0e7084f562f7f044a0d https://github.com/WebKit/WebKit/commit/338528b22bcdcf17efacf0e7084f562f7f044a0d Author: Claudio Saavedra Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp Log Message: --- [Skia] fast/canvas/canvas-webkitLineDash-invalid.html is crashing https://bugs.webkit.org/show_bug.cgi?id=270633 Reviewed by Carlos Garcia Campos. The assert in setLineDash() is problematic because setting canvas.webkitLineDash with an odd-sized vector will pass it down unchecked (contrary to using canvas.setLineDash(), which will double the size in that case). Skia can handle an odd-sized vector just fine, so there's no need for this assert. This fixes the crashing fast/canvas/canvas-webkitLineDash-invalid.html test, caused by the assert. * Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContextSkia::setLineDash): Canonical link: https://commits.webkit.org/275787@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 669cd0: [Skia] Fix double-free in WebKitTestRunner
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 669cd08179b221aa3a22360738e260d1caef5a4b https://github.com/WebKit/WebKit/commit/669cd08179b221aa3a22360738e260d1caef5a4b Author: Claudio Saavedra Date: 2024-03-07 (Thu, 07 Mar 2024) Changed paths: M Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp Log Message: --- [Skia] Fix double-free in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=270585 Reviewed by Carlos Garcia Campos and Adrian Perez de Castro. sk_sp::get() returns a raw pointer without increasing the reference count. To preserve semantics we need to explicitly increase it when returning the snapshot, otherwise we risk a double-free. * Tools/wpe/backends/fdo/HeadlessViewBackendFdo.cpp: (WPEToolingBackends::HeadlessViewBackend::snapshot): Canonical link: https://commits.webkit.org/275784@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75f6f3: [EWS] Skip upload of WPE Skia builds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75f6f39cead3a40b6b7974dc019c3434af9445cf https://github.com/WebKit/WebKit/commit/75f6f39cead3a40b6b7974dc019c3434af9445cf Author: Claudio Saavedra Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M Tools/CISupport/ews-build/config.json M Tools/CISupport/ews-build/factories.py M Tools/CISupport/ews-build/loadConfig.py Log Message: --- [EWS] Skip upload of WPE Skia builds https://bugs.webkit.org/show_bug.cgi?id=270515 Reviewed by Jonathan Bedard. Due to an oversight, WPE Skia build products are getting uploaded to the same directory than cairo builds, which is causing some of the cairo-builds to be overwritten and used in the test runners. Create a new WPE Skia factory that explicitly skips the upload step, since we are not testing Skia builds yet, and when we do, we will most likely use the WPE factory and do away with cairo testing in a similar way. * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories.py: (WPESkiaBuildFactory): * Tools/CISupport/ews-build/loadConfig.py: Canonical link: https://commits.webkit.org/275688@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01e08c: [EWS] Add WPE Skia queue to bubbles and safe-merge...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01e08c97a417e8fb113bbba0841d7df56b0d8ee9 https://github.com/WebKit/WebKit/commit/01e08c97a417e8fb113bbba0841d7df56b0d8ee9 Author: Claudio Saavedra Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M Tools/CISupport/ews-app/ews/common/github.py M Tools/CISupport/ews-app/ews/views/statusbubble.py M Tools/CISupport/ews-build/steps.py Log Message: --- [EWS] Add WPE Skia queue to bubbles and safe-merge queue https://bugs.webkit.org/show_bug.cgi?id=270393 Reviewed by Aakash Jain. WPE Skia build queue has been running without issues for the last few days in ews-build.webkit.org, add to bubbles and safe-merge checks. * Tools/CISupport/ews-app/ews/common/github.py: (GitHubEWS): * Tools/CISupport/ews-app/ews/views/statusbubble.py: (StatusBubble): * Tools/CISupport/ews-build/steps.py: (CheckStatusOfPR): Canonical link: https://commits.webkit.org/275646@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 291cc0: [WPE] Fix build in older platforms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 291cc07523180d8fcb508c042e391e80398efb9e https://github.com/WebKit/WebKit/commit/291cc07523180d8fcb508c042e391e80398efb9e Author: Claudio Saavedra Date: 2024-03-01 (Fri, 01 Mar 2024) Changed paths: M Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp Log Message: --- [WPE] Fix build in older platforms https://bugs.webkit.org/show_bug.cgi?id=270355 Unreviewed build fix. The include was wrong, even if WPE_PLATFORM is not enabled, the DMABufRendererBufferFormat definition is needed for the empty vector. * Source/WebKit/UIProcess/wpe/WebPageProxyWPE.cpp: Canonical link: https://commits.webkit.org/275559@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d9ebc: [Debug][JSC] Fix debug build
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d9ebc9dbcc637e5ef3f37fccc0502ac5d141909 https://github.com/WebKit/WebKit/commit/8d9ebc9dbcc637e5ef3f37fccc0502ac5d141909 Author: Claudio Saavedra Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/JavaScriptCore/b3/B3LowerToAir.cpp Log Message: --- [Debug][JSC] Fix debug build https://bugs.webkit.org/show_bug.cgi?id=268904 Reviewed by Mark Lam. lowWidth is declared unsigned, no need for negative assert check. * Source/JavaScriptCore/b3/B3LowerToAir.cpp: Canonical link: https://commits.webkit.org/274305@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a3358: [Debug] Build fix for Linux platforms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a335876b24b43f5f0986933fc2b97e310b796bf https://github.com/WebKit/WebKit/commit/7a335876b24b43f5f0986933fc2b97e310b796bf Author: Claudio Saavedra Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/WidthIterator.cpp Log Message: --- [Debug] Build fix for Linux platforms https://bugs.webkit.org/show_bug.cgi?id=268736 Reviewed by Chris Dumez. GlyphBufferStringOffset is defined as unsigned in non-CG builds, so the assertion is redundant. * Source/WebCore/platform/graphics/WidthIterator.cpp: (WebCore::resetGlyphBuffer): Canonical link: https://commits.webkit.org/274133@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 790be6: [html] Port PredefinedColorSpace to the new IPC se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 790be614997f866247b1b23d86f54a1813ae4cdc https://github.com/WebKit/WebKit/commit/790be614997f866247b1b23d86f54a1813ae4cdc Author: Claudio Saavedra Date: 2023-12-24 (Sun, 24 Dec 2023) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/canvas/PredefinedColorSpace.h M Source/WebCore/inspector/InspectorCanvasCallTracer.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- [html] Port PredefinedColorSpace to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266769 Reviewed by Tim Nguyen. Remove the EnumTraits for this enum, make it inherit from uint_8 explicitly, and port it to use the generator for serialization. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/canvas/PredefinedColorSpace.h: * Source/WebCore/inspector/InspectorCanvasCallTracer.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/272492@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba9b89: [GTK][WPE] Increase the crash and timeout threshol...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba9b89f5031f0ba8c2f62dfbfadb4570f5c04ef7 https://github.com/WebKit/WebKit/commit/ba9b89f5031f0ba8c2f62dfbfadb4570f5c04ef7 Author: Claudio Saavedra Date: 2023-12-20 (Wed, 20 Dec 2023) Changed paths: M Tools/CISupport/build-webkit-org/config.json Log Message: --- [GTK][WPE] Increase the crash and timeout threshold for Debug test bots https://bugs.webkit.org/show_bug.cgi?id=266627 Reviewed by Carlos Alberto Lopez Perez. We are increasing the threshold for crash and timeouts in the Debug bots so that we can more easily garden the failures in the next couple of weeks. * Tools/CISupport/build-webkit-org/config.json: Canonical link: https://commits.webkit.org/272335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d53053: Port PopupMenuSize to the new IPC serialization fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d53053272d0deb10e08ef4a5cf0a01cdea69a692 https://github.com/WebKit/WebKit/commit/d53053272d0deb10e08ef4a5cf0a01cdea69a692 Author: Claudio Saavedra Date: 2023-12-18 (Mon, 18 Dec 2023) Changed paths: M Source/WebCore/platform/PopupMenuStyle.h M Source/WebCore/rendering/RenderTheme.h M Source/WebCore/rendering/RenderThemeMac.h M Source/WebCore/rendering/RenderThemeMac.mm M Source/WebKit/Shared/PlatformPopupMenuData.h M Source/WebKit/Shared/PlatformPopupMenuData.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm Log Message: --- Port PopupMenuSize to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266584 Reviewed by Aditya Keerthi. Remove the EnumTraits for PopupMenuSize and also take the chance to rename the enum to remove redundance, both in its name and their elements. * Source/WebCore/platform/PopupMenuStyle.h: (WebCore::PopupMenuStyle::PopupMenuStyle): (WebCore::PopupMenuStyle::menuSize const): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::popupMenuSize const): * Source/WebCore/rendering/RenderThemeMac.h: * Source/WebCore/rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::popupMenuSize const): * Source/WebKit/Shared/PlatformPopupMenuData.h: * Source/WebKit/Shared/PlatformPopupMenuData.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/mac/WebPopupMenuProxyMac.mm: (WebKit::WebPopupMenuProxyMac::showPopupMenu): * Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm: (PopupMenuMac::show): Canonical link: https://commits.webkit.org/272243@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 32bdd4: Port ContextMenuItemType to new IPC serialization ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 32bdd4a63f177448c04fc55e4298243efec5bbfa https://github.com/WebKit/WebKit/commit/32bdd4a63f177448c04fc55e4298243efec5bbfa Author: Claudio Saavedra Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp M Source/WebCore/inspector/InspectorFrontendHost.cpp M Source/WebCore/page/ContextMenuController.cpp M Source/WebCore/platform/ContextMenuItem.cpp M Source/WebCore/platform/ContextMenuItem.h M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp M Source/WebKit/Shared/API/c/WKSharedAPICast.h M Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp M Source/WebKit/Shared/WebContextMenuItem.cpp M Source/WebKit/Shared/WebContextMenuItemData.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp M Source/WebKit/Shared/glib/WebContextMenuItemGlib.h M Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm M Source/WebKit/UIProcess/win/WebContextMenuProxyWin.cpp M Source/WebKit/UIProcess/win/WebView.cpp M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm Log Message: --- Port ContextMenuItemType to new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266079 Reviewed by Alex Christensen. Port the ContextMenuItemType enum to the new IPC serialization format to get rid of its EnumTraits. Take the chance to also rename the enum members to remove the Type suffix, as it was redundant. * Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::showMediaControlsContextMenu): * Source/WebCore/inspector/InspectorFrontendHost.cpp: (WebCore::populateContextMenu): * Source/WebCore/page/ContextMenuController.cpp: (WebCore::separatorItem): (WebCore::ContextMenuController::createAndAppendFontSubMenu): (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): (WebCore::ContextMenuController::createAndAppendSpeechSubMenu): (WebCore::ContextMenuController::createAndAppendUnicodeSubMenu): (WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): (WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): (WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): (WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::addDebuggingItems): (WebCore::ContextMenuController::checkOrEnableIfNeeded const): * Source/WebCore/platform/ContextMenuItem.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::setSubMenu): * Source/WebCore/platform/ContextMenuItem.h: * Source/WebKit/Shared/API/c/WKContextMenuItem.cpp: (WKContextMenuItemCreateAsAction): (WKContextMenuItemCreateAsCheckableAction): (WKContextMenuItemGetType): * Source/WebKit/Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): * Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp: (webkitContextMenuItemToWebContextMenuItemData): (webkit_context_menu_item_new_from_stock_action): (webkit_context_menu_item_new_from_stock_action_with_label): (webkit_context_menu_item_new_with_submenu): (webkit_context_menu_item_new_separator): (webkit_context_menu_item_is_separator): * Source/WebKit/Shared/WebContextMenuItem.cpp: (WebKit::WebContextMenuItem::create): (WebKit::WebContextMenuItem::separatorItem): (WebKit::WebContextMenuItem::submenuItemsAsAPIArray const): * Source/WebKit/Shared/WebContextMenuItemData.cpp: (WebKit::WebContextMenuItemData::WebContextMenuItemData): (WebKit::WebContextMenuItemData::core const): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp: (WebKit::WebContextMenuItemGlib::WebContextMenuItemGlib): (WebKit::WebContextMenuItemGlib::createActionIfNeeded): * Source/WebKit/Shared/glib/WebContextMenuItemGlib.h: * Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp: (WebKit::contextMenuItemActivatedCallback): (WebKit::WebContextMenuProxyGtk::append): (WebKit::WebContextMenuProxyGtk::buildMenu): (WebKit::WebContextMenuProxyGtk::populateSubMenu): (WebKit::WebContextMenuProxyGtk::populate): * Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm: (-[WKMenuTarget forwardContextMenuAction:]): (WebKit::createMenuActionItem): (WebKit::WebContextMenuProxyMac::getContextMenuItem): * Source/WebKit/UIProcess/win/WebContextMenuProxyWin.cpp: (WebKit::createMenuItem): * Source/WebKit/UIProcess/win/WebView.cpp: (WebKit::WebView::onMenuCommand): * Source/WebKitLegacy/mac/WebView/WebHTMLView.mm: (createMenuItem): Canonical link: https://commits.webkit.org/271896@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ee1f9: Port PlatformCursorType enum to new IPC serializat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ee1f9fa72c44ed1e57ead14290777ac27629625 https://github.com/WebKit/WebKit/commit/6ee1f9fa72c44ed1e57ead14290777ac27629625 Author: Claudio Saavedra Date: 2023-12-11 (Mon, 11 Dec 2023) Changed paths: M Source/WebCore/platform/Cursor.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port PlatformCursorType enum to new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=266082 Reviewed by Alex Christensen. Move cursor types to the new serialization format and remove its EnumTraits. * Source/WebCore/platform/Cursor.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271888@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c38667: Rename ContextMenuItemTagCopyImageUrlToClipboard t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c38667754e0673f0662f01833aa07e5ae4973e8a https://github.com/WebKit/WebKit/commit/c38667754e0673f0662f01833aa07e5ae4973e8a Author: Claudio Saavedra Date: 2023-12-09 (Sat, 09 Dec 2023) Changed paths: M Source/WebCore/page/ContextMenuController.cpp M Source/WebCore/platform/ContextMenuItem.cpp M Source/WebCore/platform/ContextMenuItem.h M Source/WebCore/platform/LocalizedStrings.h M Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp M Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h M Source/WebKit/Shared/API/c/WKSharedAPICast.h M Source/WebKit/Shared/API/glib/WebKitContextMenuActions.cpp M Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm Log Message: --- Rename ContextMenuItemTagCopyImageUrlToClipboard to please the style-checker https://bugs.webkit.org/show_bug.cgi?id=266137 Reviewed by Chris Dumez. The style checker has been bugging me in a different MR because of ContextMenuItemTagCopyImageUrlToClipboard. Rename it to capitalize URL properly and a fix the capitalization of a few related methods as well. * Source/WebCore/page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded const): * Source/WebCore/platform/ContextMenuItem.cpp: (WebCore::isValidContextMenuAction): * Source/WebCore/platform/ContextMenuItem.h: * Source/WebCore/platform/LocalizedStrings.h: * Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagCopyImageURLToClipboard): (WebCore::contextMenuItemTagCopyImageUrlToClipboard): Deleted. * Source/WebKit/Shared/API/c/WKContextMenuItemTypes.h: * Source/WebKit/Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl): * Source/WebKit/Shared/API/glib/WebKitContextMenuActions.cpp: (webkitContextMenuActionGetActionTag): (webkitContextMenuActionGetForContextMenuItem): (webkitContextMenuActionGetLabel): * Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm: (-[WKInspectorViewController _webView:contextMenu:forElement:]): Canonical link: https://commits.webkit.org/271808@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a8e828: Remove leftover #undef from WebCoreArgumentCoders ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8e828af90ad88f814b9f6632ab3d38287e83c08 https://github.com/WebKit/WebKit/commit/a8e828af90ad88f814b9f6632ab3d38287e83c08 Author: Claudio Saavedra Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M Source/WebKit/Shared/WebCoreArgumentCoders.h Log Message: --- Remove leftover #undef from WebCoreArgumentCoders header https://bugs.webkit.org/show_bug.cgi?id=266083 Reviewed by Philippe Normand. This #undef was added when WTFLogLevel had its EnumTraits here, as WTFLogLevel::Always was used. That was removed at some point in the past but the #undef was left. Remove it. * Source/WebKit/Shared/WebCoreArgumentCoders.h: Canonical link: https://commits.webkit.org/271750@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eb32d9: [media] Port assorted enum classes to new serializ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb32d9600cf95276a54978ebcb5812fe1dac5692 https://github.com/WebKit/WebKit/commit/eb32d9600cf95276a54978ebcb5812fe1dac5692 Author: Claudio Saavedra Date: 2023-12-08 (Fri, 08 Dec 2023) Changed paths: M Source/WebCore/platform/encryptedmedia/CDMInstanceSession.h M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- [media] Port assorted enum classes to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265794 Reviewed by Alex Christensen. A handful of media stream and encrpyted media enums can be trivially ported to the new serialization format, remove their enum traits. * Source/WebCore/platform/encryptedmedia/CDMInstanceSession.h: * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271727@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ccdef: Move WebFindOptions to the new serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ccdef5950c2cb3ff46b6664ced7976fcc218660 https://github.com/WebKit/WebKit/commit/7ccdef5950c2cb3ff46b6664ced7976fcc218660 Author: Claudio Saavedra Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources.make M Source/WebKit/Shared/WebFindOptions.h A Source/WebKit/Shared/WebFindOptions.serialization.in Log Message: --- Move WebFindOptions to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=265877 Reviewed by Alex Christensen. Add a serialization file for the WebFindOptions.h enums and remove the EnumTraits for these. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/WebFindOptions.h: * Source/WebKit/Shared/WebFindOptions.serialization.in: Added. Canonical link: https://commits.webkit.org/271710@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7bb974: [JSC] Port enum classes to new serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7bb974912a5e68c176c876e3ce7ba59149e056b5 https://github.com/WebKit/WebKit/commit/7bb974912a5e68c176c876e3ce7ba59149e056b5 Author: Claudio Saavedra Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M Source/JavaScriptCore/runtime/ConsoleTypes.h M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources.make A Source/WebKit/Shared/JavaScriptCore.serialization.in Log Message: --- [JSC] Port enum classes to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265679 Reviewed by Alex Christensen. Move JSC's console types to the new serialization format and remove the EnumTraits for it. Use a new JavaScriptCore serialization file to keep things tidy. * Source/JavaScriptCore/runtime/ConsoleTypes.h: * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources.make: * Source/WebKit/Shared/JavaScriptCore.serialization.in: Added. Canonical link: https://commits.webkit.org/271709@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5beaf2: Move GraphicsContextGLSimulatedEventForTesting enu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5beaf2534b4b8efb459a132cc4a94ad2c285f784 https://github.com/WebKit/WebKit/commit/5beaf2534b4b8efb459a132cc4a94ad2c285f784 Author: Claudio Saavedra Date: 2023-12-06 (Wed, 06 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/GraphicsContextGLEnums.h M Source/WebKit/Shared/WebCoreArgumentCoders.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Move GraphicsContextGLSimulatedEventForTesting enum class to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265875 Reviewed by Chris Dumez. This enum can be trivially moved to the new serialization format, remove the EnumTraits bits for it. * Source/WebCore/platform/graphics/GraphicsContextGLEnums.h: * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271634@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4dbbd: [GTK][WPE] Garden crashing notification API test
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4dbbd012a579b4ca10baab6dcafc8ad1bb8b3dc https://github.com/WebKit/WebKit/commit/e4dbbd012a579b4ca10baab6dcafc8ad1bb8b3dc Author: Claudio Saavedra Date: 2023-12-05 (Tue, 05 Dec 2023) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK][WPE] Garden crashing notification API test https://bugs.webkit.org/show_bug.cgi?id=265902 Unreviewed gardening. I marked the flakiness earlier, turns out this is actually crashing flakily. * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/271569@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4393c: [WPE][GTK] Mark WebKitWebView/notification test fl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4393c1e8fb932dfa1e0f680ca3fa6f8c276455f https://github.com/WebKit/WebKit/commit/b4393c1e8fb932dfa1e0f680ca3fa6f8c276455f Author: Claudio Saavedra Date: 2023-12-05 (Tue, 05 Dec 2023) Changed paths: M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [WPE][GTK] Mark WebKitWebView/notification test flakiness https://bugs.webkit.org/show_bug.cgi?id=265887 Unreviewed gardening * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/271558@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fb2a4: [WebXR] Port enum classes to new serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fb2a422f959942a00e037541091558e8c3b18ed https://github.com/WebKit/WebKit/commit/3fb2a422f959942a00e037541091558e8c3b18ed Author: Claudio Saavedra Date: 2023-12-04 (Mon, 04 Dec 2023) Changed paths: M Source/WebCore/platform/xr/PlatformXR.h M Source/WebKit/Shared/XR/XRSystem.serialization.in Log Message: --- [WebXR] Port enum classes to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265665 Reviewed by Dan Glastonbury. Move the XR enums to the new serialization format to be able to get rid of the enum traits for them. * Source/WebCore/platform/xr/PlatformXR.h: * Source/WebKit/Shared/XR/XRSystem.serialization.in: Canonical link: https://commits.webkit.org/271466@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 95643b: Add test against Attr element leaks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95643b4e0b67e1344afdbd9546b7edb9268d8962 https://github.com/WebKit/WebKit/commit/95643b4e0b67e1344afdbd9546b7edb9268d8962 Author: Claudio Saavedra Date: 2023-12-02 (Sat, 02 Dec 2023) Changed paths: A LayoutTests/fast/dom/Element/set-attribute-twice-and-gc-expected.txt A LayoutTests/fast/dom/Element/set-attribute-twice-and-gc.html Log Message: --- Add test against Attr element leaks https://bugs.webkit.org/show_bug.cgi?id=265714 Reviewed by Chris Dumez. Test that adding a uppercase attribute node twice to an element doesn't leak one. * LayoutTests/fast/dom/Element/set-attribute-twice-and-gc-expected.txt: Added. * LayoutTests/fast/dom/Element/set-attribute-twice-and-gc.html: Added. Canonical link: https://commits.webkit.org/271424@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb42e4: Port InspectorClient enums to new serialization fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb42e43f91a1435591e4da9c6b72e9338b10c399 https://github.com/WebKit/WebKit/commit/bb42e43f91a1435591e4da9c6b72e9338b10c399 Author: Claudio Saavedra Date: 2023-11-21 (Tue, 21 Nov 2023) Changed paths: M Source/WebCore/inspector/InspectorClient.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port InspectorClient enums to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265212 Reviewed by Timothy Hatcher. Port from EnumTraits to the new serialization format, move the enum out of the InspectorClient class to ease the move, and remove EnumTraits bits in favor of autogenerated serializers. * Source/WebCore/inspector/InspectorClient.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/271038@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 814938: [GTK][WPE] Port UserMessage enum to new serializat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 814938529bfcfdb9820b278e1895a882d837b001 https://github.com/WebKit/WebKit/commit/814938529bfcfdb9820b278e1895a882d837b001 Author: Claudio Saavedra Date: 2023-11-21 (Tue, 21 Nov 2023) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/Shared/glib/UserMessage.h A Source/WebKit/Shared/glib/UserMessage.serialization.in Log Message: --- [GTK][WPE] Port UserMessage enum to new serialization format https://bugs.webkit.org/show_bug.cgi?id=265190 Reviewed by Carlos Garcia Campos. Remove the EnumTrait bits and use the generator for serialization. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/Shared/glib/UserMessage.h: * Source/WebKit/Shared/glib/UserMessage.serialization.in: Added. Canonical link: https://commits.webkit.org/271019@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee55f4: [GTK][WPE] Generate serializators for InputMethodS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee55f47782fa1001fcb04d1b7e5c8ade9b718471 https://github.com/WebKit/WebKit/commit/ee55f47782fa1001fcb04d1b7e5c8ade9b718471 Author: Claudio Saavedra Date: 2023-11-20 (Mon, 20 Nov 2023) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake M Source/WebKit/Shared/glib/InputMethodState.h A Source/WebKit/Shared/glib/InputMethodState.serialization.in Log Message: --- [GTK][WPE] Generate serializators for InputMethodState enumerations https://bugs.webkit.org/show_bug.cgi?id=265145 Reviewed by Carlos Garcia Campos. Add the generator for InputMethodState enums serialization, get rid of the EnumTraits bits, and move the enums out of the InputMethodState struct to ease things. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/Shared/glib/InputMethodState.h: * Source/WebKit/Shared/glib/InputMethodState.serialization.in: Added. Canonical link: https://commits.webkit.org/271002@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6226d4: [GTK] Get rid of EnumTraits for DMABufRendererBuff...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6226d4c168b66ce1788461b8255a261e65f0d47b https://github.com/WebKit/WebKit/commit/6226d4c168b66ce1788461b8255a261e65f0d47b Author: Claudio Saavedra Date: 2023-11-17 (Fri, 17 Nov 2023) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h M Source/WebKit/Shared/glib/DMABufRendererBufferFormat.serialization.in M Source/WebKit/Shared/glib/DMABufRendererBufferMode.h A Source/WebKit/Shared/glib/DMABufRendererBufferMode.serialization.in Log Message: --- [GTK] Get rid of EnumTraits for DMABufRendererBuffer enums https://bugs.webkit.org/show_bug.cgi?id=264958 Reviewed by Chris Dumez. Port the DMABufRendererBuffer enums to the new IPC serialization format, and get rid of the EnumTraits bits. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/Shared/glib/DMABufRendererBufferFormat.h: * Source/WebKit/Shared/glib/DMABufRendererBufferFormat.serialization.in: * Source/WebKit/Shared/glib/DMABufRendererBufferMode.h: * Source/WebKit/Shared/glib/DMABufRendererBufferMode.serialization.in: added Canonical link: https://commits.webkit.org/270894@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe68a6: [WPE][Debug] Garden scrolling crashes now passing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe68a6b43bed69327a6ae483c7f6e0a1c5074c0b https://github.com/WebKit/WebKit/commit/fe68a6b43bed69327a6ae483c7f6e0a1c5074c0b Author: Claudio Saavedra Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][Debug] Garden scrolling crashes now passing https://bugs.webkit.org/show_bug.cgi?id=264960 Unreviewed gardening. These tests are no longer crashing in Debug after 270820@main. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/270831@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3671f: Port Font enums to the new IPC serialization format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3671f566b6e5bfc9a31a795d336b43d17c1c1e3 https://github.com/WebKit/WebKit/commit/d3671f566b6e5bfc9a31a795d336b43d17c1c1e3 Author: Claudio Saavedra Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M Source/WebCore/css/CSSFontFace.cpp M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/Font.h M Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port Font enums to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=264883 Reviewed by Chris Dumez. Move the serializable enums out of the Font class, remove the EnumTraits bits, and port the serialization to the generator format. Also take the opportunity to rename Font::Interstitial and Font::OrientationFallback to Font::IsInterstitial and Font::IsOrientationFallback respectively, to better match their boolean nature. * Source/WebCore/css/CSSFontFace.cpp: (WebCore::CSSFontFace::font): * Source/WebCore/platform/graphics/Font.cpp: (WebCore::Font::create): (WebCore::Font::Font): (WebCore::m_shouldNotBeUsedForArabic): (WebCore::Font::verticalRightOrientationFont const): (WebCore::Font::uprightOrientationFont const): (WebCore::Font::invisibleFont const): (WebCore::Font::brokenIdeographFont const): * Source/WebCore/platform/graphics/Font.h: (WebCore::Font::isTextOrientationFallback const): (WebCore::Font::isInterstitial const): * Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::Font::platformCreateScaledFont const): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder::decode): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270827@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 362150: Port PlatformMediaSession enums to the new IPC ser...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 362150b0a4ce0acd454616a3e58ff789b3a35492 https://github.com/WebKit/WebKit/commit/362150b0a4ce0acd454616a3e58ff789b3a35492 Author: Claudio Saavedra Date: 2023-11-14 (Tue, 14 Nov 2023) Changed paths: M Source/WebCore/Modules/webaudio/AudioContext.cpp M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/MediaElementSession.cpp M Source/WebCore/platform/audio/PlatformMediaSession.cpp M Source/WebCore/platform/audio/PlatformMediaSession.h M Source/WebCore/platform/audio/PlatformMediaSession.serialization.in M Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h M Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm M Source/WebCore/testing/Internals.cpp Log Message: --- Port PlatformMediaSession enums to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=264807 Reviewed by Chris Dumez. Port the enums to the serialization format, and the flags enum to OptionSet. * Source/WebCore/Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::resumeRendering): (WebCore::AudioContext::suspend): (WebCore::AudioContext::resume): (WebCore::AudioContext::suspendPlayback): (WebCore::AudioContext::defaultDestinationWillBecomeConnected): * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pausedForUserInteraction const): (WebCore::HTMLMediaElement::virtualHasPendingActivity const): (WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const): (WebCore::HTMLMediaElement::updateShouldAutoplay): (WebCore::HTMLMediaElement::playbackControlsManagerBehaviorRestrictionsTimerFired): * Source/WebCore/html/MediaElementSession.cpp: (WebCore::MediaElementSession::visibilityChanged): (WebCore::MediaElementSession::clientDataBufferingTimerFired): (WebCore::MediaElementSession::preferredBufferingPolicy const): (WebCore::MediaElementSession::nowPlayingInfo const): (WebCore::MediaElementSession::updateMediaUsageIfChanged): * Source/WebCore/platform/audio/PlatformMediaSession.cpp: (WebCore::convertEnumerationToString): (WebCore::PlatformMediaSession::beginInterruption): (WebCore::PlatformMediaSession::endInterruption): (WebCore::PlatformMediaSession::clientWillBeginAutoplaying): (WebCore::PlatformMediaSession::clientWillBeginPlayback): (WebCore::PlatformMediaSession::processClientWillPausePlayback): (WebCore::PlatformMediaSession::pauseSession): * Source/WebCore/platform/audio/PlatformMediaSession.h: * Source/WebCore/platform/audio/PlatformMediaSession.serialization.in: * Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback): (WebCore::PlatformMediaSessionManager::sessionWillEndPlayback): (WebCore::PlatformMediaSessionManager::sessionStateChanged): (WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive): (WebCore::PlatformMediaSessionManager::applicationDidBecomeActive): (WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): (WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): (WebCore::PlatformMediaSessionManager::sessionIsPlayingToWirelessPlaybackTargetChanged): (WebCore::PlatformMediaSessionManager::processSystemWillSleep): (WebCore::PlatformMediaSessionManager::processSystemDidWake): (WebCore::PlatformMediaSessionManager::mediaPlaybackIsPaused): (WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForGroup): (WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForGroup): * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::sessionWillEndPlayback): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::beginMediaSessionInterruption): (WebCore::Internals::endMediaSessionInterruption): Canonical link: https://commits.webkit.org/270719@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 433403: Remove leftover EnumTraits.h includes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4334033d8c88a541cd5a9739112c61565685a1d4 https://github.com/WebKit/WebKit/commit/4334033d8c88a541cd5a9739112c61565685a1d4 Author: Claudio Saavedra Date: 2023-11-14 (Tue, 14 Nov 2023) Changed paths: M Source/WebCore/html/track/VTTCue.h M Source/WebCore/platform/mediacapabilities/ColorGamut.h M Source/WebCore/platform/mediacapabilities/HdrMetadataType.h Log Message: --- Remove leftover EnumTraits.h includes https://bugs.webkit.org/show_bug.cgi?id=264813 Reviewed by Žan Doberšek. These were left in some of my previous commits. * Source/WebCore/html/track/VTTCue.h: * Source/WebCore/platform/mediacapabilities/ColorGamut.h: * Source/WebCore/platform/mediacapabilities/HdrMetadataType.h: Canonical link: https://commits.webkit.org/270709@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfde53: Port the VTT enums to the new IPC serialization fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfde53f43eaf15437997cc11e539b2bce32acbd6 https://github.com/WebKit/WebKit/commit/dfde53f43eaf15437997cc11e539b2bce32acbd6 Author: Claudio Saavedra Date: 2023-11-14 (Tue, 14 Nov 2023) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/track/VTTCue.cpp M Source/WebCore/html/track/VTTCue.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port the VTT enums to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=264768 Reviewed by Chris Dumez. Remove the EnumTraits enums in favor of the new IPC serialization format. Needed to pull a few headers included from VTTCue.h to the private headers for this to work. Also added an alias to the last item in two of the enums, for convenience when doing static-asserts. * Source/WebCore/Headers.cmake: * Source/WebCore/html/track/VTTCue.cpp: * Source/WebCore/html/track/VTTCue.h: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270698@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 279959: Port media capabilities enums to new serialization...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 279959ad2c2cfe9b4f0dd82bfbe631ac6f56c446 https://github.com/WebKit/WebKit/commit/279959ad2c2cfe9b4f0dd82bfbe631ac6f56c446 Author: Claudio Saavedra Date: 2023-11-13 (Mon, 13 Nov 2023) Changed paths: M Source/WebCore/platform/mediacapabilities/ColorGamut.h M Source/WebCore/platform/mediacapabilities/HdrMetadataType.h M Source/WebCore/platform/mediacapabilities/TransferFunction.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port media capabilities enums to new serialization format https://bugs.webkit.org/show_bug.cgi?id=264679 Reviewed by Chris Dumez. Do away with the EnumTraits for these enums and use the generator for their IPC serialization. * Source/WebCore/platform/mediacapabilities/ColorGamut.h: * Source/WebCore/platform/mediacapabilities/HdrMetadataType.h: * Source/WebCore/platform/mediacapabilities/TransferFunction.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270639@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e975c: [WPE][Debug] Garden more scrolling-related assert ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e975c79b0d4766d80b0421a6dedeae64ca84b63 https://github.com/WebKit/WebKit/commit/6e975c79b0d4766d80b0421a6dedeae64ca84b63 Author: Claudio Saavedra Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][Debug] Garden more scrolling-related assert crashes https://bugs.webkit.org/show_bug.cgi?id=264697 Unreviewed gardening. * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/270609@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fed843: [WPE][Debug] Garden some more scrolling assertion ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fed843be93429ad9a7298a922754da371d5dfc06 https://github.com/WebKit/WebKit/commit/fed843be93429ad9a7298a922754da371d5dfc06 Author: Claudio Saavedra Date: 2023-11-11 (Sat, 11 Nov 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][Debug] Garden some more scrolling assertion crashes https://bugs.webkit.org/show_bug.cgi?id=264688 Unreviewed gardening * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/270601@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ddbf5: Port CredentialPersistence to the new serializatio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ddbf5c0c6b8f939705ff74f6008467bc92fad3f https://github.com/WebKit/WebKit/commit/0ddbf5c0c6b8f939705ff74f6008467bc92fad3f Author: Claudio Saavedra Date: 2023-11-11 (Sat, 11 Nov 2023) Changed paths: M Source/WebCore/platform/network/CredentialBase.cpp M Source/WebCore/platform/network/CredentialBase.h M Source/WebCore/platform/network/cocoa/CredentialCocoa.mm M Source/WebCore/platform/network/mac/ResourceHandleMac.mm M Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/C/WKAPICast.h M Source/WebKit/UIProcess/API/glib/WebKitCredential.cpp M Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp Log Message: --- Port CredentialPersistence to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=264661 Reviewed by Chris Dumez. Remove EnumTraits for CredentialPersistence and port the enum to a serializable format. * Source/WebCore/platform/network/CredentialBase.cpp: (WebCore::CredentialBase::CredentialBase): * Source/WebCore/platform/network/CredentialBase.h: (): Deleted. * Source/WebCore/platform/network/cocoa/CredentialCocoa.mm: (WebCore::toNSURLCredentialPersistence): (WebCore::toCredentialPersistence): * Source/WebCore/platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): (WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication): (WebCore::ResourceHandle::receivedCredential): * Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp: (WebCore::NetworkStorageSession::getCredentialFromPersistentStorage): * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::tryPasswordBasedAuthentication): * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::CompletionHandlerhttps://commits.webkit.org/270599@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e55ad8: Remove EnumTraits for ResourceErrorBase::Type
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e55ad8994829d8db4a003596ca5ab79e613ab794 https://github.com/WebKit/WebKit/commit/e55ad8994829d8db4a003596ca5ab79e613ab794 Author: Claudio Saavedra Date: 2023-11-11 (Sat, 11 Nov 2023) Changed paths: M Source/WebCore/platform/network/ResourceErrorBase.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Remove EnumTraits for ResourceErrorBase::Type https://bugs.webkit.org/show_bug.cgi?id=264662 Reviewed by Chris Dumez. Use the generator instead. * Source/WebCore/platform/network/ResourceErrorBase.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270598@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2d41e7: LocalFrameView: Use a weak reference for embedded ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2d41e7df7e956440d7df6ed59e3a3e898b50f1c1 https://github.com/WebKit/WebKit/commit/2d41e7df7e956440d7df6ed59e3a3e898b50f1c1 Author: Claudio Saavedra Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: A LayoutTests/fast/dom/move-embedded-during-update-expected.txt A LayoutTests/fast/dom/move-embedded-during-update.html M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h Log Message: --- LocalFrameView: Use a weak reference for embedded objects during update https://bugs.webkit.org/show_bug.cgi?id=263179 rdar://116715302 Reviewed by Chris Dumez. Embedded objects can be remove during update, so it's safer to use a weak reference to avoid leaking one. * LayoutTests/fast/dom/move-embedded-during-update-expected.txt: Added. * LayoutTests/fast/dom/move-embedded-during-update.html: Added. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::updateEmbeddedObject): (WebCore::LocalFrameView::updateEmbeddedObjects): * Source/WebCore/page/LocalFrameView.h: Co-authored-by: Žan Doberšek Canonical link: https://commits.webkit.org/270541@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecc0e5: [WPE][Debug] Gardening scroll-related assertion cr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecc0e56f998cab90503be3bf373fa5c38c625897 https://github.com/WebKit/WebKit/commit/ecc0e56f998cab90503be3bf373fa5c38c625897 Author: Claudio Saavedra Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: M LayoutTests/platform/wpe/TestExpectations Log Message: --- [WPE][Debug] Gardening scroll-related assertion crashes https://bugs.webkit.org/show_bug.cgi?id=264566 Unreviewed gardening. * LayoutTests/platform/wpe/TestExpectations: Mark Debug crashes. Canonical link: https://commits.webkit.org/270524@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fab679: Cherry-pick 268085@main (ab8e3bcac480). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: fab67902d6a54a746ae34f9239f905f4fb408957 https://github.com/WebKit/WebKit/commit/fab67902d6a54a746ae34f9239f905f4fb408957 Author: Claudio Saavedra Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/gtk/GtkUtilities.cpp M Source/WebKit/Shared/gtk/WebEventFactory.cpp Log Message: --- Cherry-pick 268085@main (ab8e3bcac480). https://bugs.webkit.org/show_bug.cgi?id=261674 [GTK4] NativeWebWheelEvent crashes on wheel event tests https://bugs.webkit.org/show_bug.cgi?id=261674 Reviewed by Michael Catanzaro. The GdkEvent API in GTK4 won't play ball when given a NULL event. When synthesizing wheel events we might pass a NULL event to the event factory, so make sure that the methods that call GDK API on it are NULL-safe. * Source/WebCore/platform/gtk/GtkUtilities.cpp: (WebCore::wallTimeForEvent): * Source/WebKit/Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent): Canonical link: https://commits.webkit.org/268085@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e69f0: [GTK] Fix debug build after 269061@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e69f0be5f77f19dd319d9377a5b9c3565ccfcb8 https://github.com/WebKit/WebKit/commit/9e69f0be5f77f19dd319d9377a5b9c3565ccfcb8 Author: Claudio Saavedra Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M Source/WebCore/editing/gtk/WebContentReaderGtk.cpp Log Message: --- [GTK] Fix debug build after 269061@main https://bugs.webkit.org/show_bug.cgi?id=263014 Unreviewed build fix. Smart pointer move broke an assertion, went undetected by the EWS, because GTK doesn't have a Debug one. * Source/WebCore/editing/gtk/WebContentReaderGtk.cpp: (WebCore::WebContentReader::readImage): Canonical link: https://commits.webkit.org/269201@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab8e3b: [GTK4] NativeWebWheelEvent crashes on wheel event ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab8e3bcac4804bcfb9af5394a962556985b3c201 https://github.com/WebKit/WebKit/commit/ab8e3bcac4804bcfb9af5394a962556985b3c201 Author: Claudio Saavedra Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M Source/WebCore/platform/gtk/GtkUtilities.cpp M Source/WebKit/Shared/gtk/WebEventFactory.cpp Log Message: --- [GTK4] NativeWebWheelEvent crashes on wheel event tests https://bugs.webkit.org/show_bug.cgi?id=261674 Reviewed by Michael Catanzaro. The GdkEvent API in GTK4 won't play ball when given a NULL event. When synthesizing wheel events we might pass a NULL event to the event factory, so make sure that the methods that call GDK API on it are NULL-safe. * Source/WebCore/platform/gtk/GtkUtilities.cpp: (WebCore::wallTimeForEvent): * Source/WebKit/Shared/gtk/WebEventFactory.cpp: (WebKit::modifiersForEvent): Canonical link: https://commits.webkit.org/268085@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc011e: [webkitpy] Detection of GTK4 is broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc011e53e91781e58ab5fc3a91795eba69d836ea https://github.com/WebKit/WebKit/commit/bc011e53e91781e58ab5fc3a91795eba69d836ea Author: Claudio Saavedra Date: 2023-09-13 (Wed, 13 Sep 2023) Changed paths: M Tools/Scripts/webkitpy/port/gtk.py M Tools/Scripts/webkitpy/port/gtk_unittest.py Log Message: --- [webkitpy] Detection of GTK4 is broken https://bugs.webkit.org/show_bug.cgi?id=261503 Reviewed by Adrian Perez de Castro. The name of the current binary for the gtk4 library is different, update the method to actually find all library binaries. * Tools/Scripts/webkitpy/port/gtk.py: (GtkPort._is_gtk4_build): * Tools/Scripts/webkitpy/port/gtk_unittest.py: (GtkPortTest.test_gtk4_expectations_binary_only): (GtkPortTest.test_gtk_expectations_both_binaries): Canonical link: https://commits.webkit.org/267946@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a3990: [GTK][WPE] fast/mediastream/RTCRtpSender-outlives-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a39903564eeec94a6006abb311ecb8c2f89f422 https://github.com/WebKit/WebKit/commit/5a39903564eeec94a6006abb311ecb8c2f89f422 Author: Claudio Saavedra Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection.html passing https://bugs.webkit.org/show_bug.cgi?id=257480 Unreviewed gardening patch Test not crashing anymore after 264662@main. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/264669@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2caf60: [GTK][WPE] Mark fast/mediastream/RTCRtpSender-outl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2caf60ff3b66f466ff7ea3601f0227cdb9da5eae https://github.com/WebKit/WebKit/commit/2caf60ff3b66f466ff7ea3601f0227cdb9da5eae Author: Claudio Saavedra Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] Mark fast/mediastream/RTCRtpSender-outlives-RTCPeerConnection.html as flaky Unreviewed gardening. This test is crashing a lot on GTK, a few times in WPE. Opened bug #257456 for investigation, mark the flakiness for now. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/264654@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6648ca: [GTK][WPE] imported/w3c/web-platform-tests/html/us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6648ca5f20edbfc787d01d2661a987477fbdeee6 https://github.com/WebKit/WebKit/commit/6648ca5f20edbfc787d01d2661a987477fbdeee6 Author: Claudio Saavedra Date: 2023-05-29 (Mon, 29 May 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK][WPE] imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html?touch crashing https://bugs.webkit.org/show_bug.cgi?id=257454 Unreviewed gardening. * LayoutTests/platform/glib/TestExpectations: Skip until the patch in bug #233092 lands. Canonical link: https://commits.webkit.org/264653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c98a1: Add test for display contents on focus change
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c98a1beca342adf46e228d27278c9102d08e580 https://github.com/WebKit/WebKit/commit/3c98a1beca342adf46e228d27278c9102d08e580 Author: Claudio Saavedra Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: A LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt A LayoutTests/fast/css/content/display-contents-on-focus-crash.html Log Message: --- Add test for display contents on focus change https://bugs.webkit.org/show_bug.cgi?id=251380 rdar://104813991 Reviewed by Antti Koivisto. Already fixed by #248776, but add this test for completeness. * LayoutTests/fast/css/content/display-contents-on-focus-crash-expected.txt: Added. * LayoutTests/fast/css/content/display-contents-on-focus-crash.html: Added. Originally-landed-as: 260286.12@webkit-2023.2-embargoed (042db6f5677e). https://bugs.webkit.org/show_bug.cgi?id=251380 Canonical link: https://commits.webkit.org/264351@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 994a3d: [GTK][WPE] Update several test results
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 994a3d080727520d6b51853f663e987469d91082 https://github.com/WebKit/WebKit/commit/994a3d080727520d6b51853f663e987469d91082 Author: Claudio Saavedra Date: 2023-05-19 (Fri, 19 May 2023) Changed paths: R LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-flexbox/text-as-flexitem-size-001-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/cssom-view/cssom-getBoundingClientRect-003-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt A LayoutTests/platform/glib/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/out-of-flow/all-mathml-containers-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt R LayoutTests/platform/gtk/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt R LayoutTests/platform/wpe/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt Log Message: --- [GTK][WPE] Update several test results https://bugs.webkit.org/show_bug.cgi?id=257015 Unreviewed gardening. Several tests have been passing but the expectation file had them as failing. Update those. Additionally update and move some results that are the same for WPE and GTK to the glib expectations directory. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/layer-counter-style-override-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt. * LayoutTests/platform/glib/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt: Renamed from LayoutTests/platform/wpe/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/out-of-flow/all-mathml-containers-expected.txt: Removed. * LayoutTests/platform/gtk/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt: Removed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt: Removed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt: Removed. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-flexbox/text-as-flexitem-size-001-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/cssom-view/cssom-getBoundingClientRect-003-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/dominant-baseline-hanging-small-font-size-expected.txt: Canonical link: https://commits.webkit.org/264247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e8e216: [GTK] Assorted test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8e21629a2bd68dfd154f7222795e137b424d37f https://github.com/WebKit/WebKit/commit/e8e21629a2bd68dfd154f7222795e137b424d37f Author: Claudio Saavedra Date: 2023-05-17 (Wed, 17 May 2023) Changed paths: M LayoutTests/platform/gtk/editing/pasteboard/innerText-inline-table-expected.png M LayoutTests/platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt M LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.png M LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.txt Log Message: --- [GTK] Assorted test gardening https://bugs.webkit.org/show_bug.cgi?id=256902 Unreviewed test gardening. Update test expectations that changed recently and were not updated, see https://commits.webkit.org/263535@main and https://commits.webkit.org/263754@main * LayoutTests/platform/gtk/editing/pasteboard/innerText-inline-table-expected.png: * LayoutTests/platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt: * LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.png: * LayoutTests/platform/gtk/fast/forms/basic-buttons-expected.txt: Canonical link: https://commits.webkit.org/264154@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0e6ea: REGRESSION(264093@main) GTK WTR changes broke hund...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0e6eaf56e49a22b059b8c4b974651dd59585b64 https://github.com/WebKit/WebKit/commit/c0e6eaf56e49a22b059b8c4b974651dd59585b64 Author: Claudio Saavedra Date: 2023-05-17 (Wed, 17 May 2023) Changed paths: M Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp Log Message: --- REGRESSION(264093@main) GTK WTR changes broke hundred of tests https://bugs.webkit.org/show_bug.cgi?id=256886 Reviewed by Philippe Normand. These changes caused hundred of GTK tests breaking, are unaccounted for in the original commit log, so revert them. We should land them again with updated test results and, preferrably, together with the WPE implementation. * Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: (WTR::EventSenderProxy::rawKeyDown): (WTR::EventSenderProxy::rawKeyUp): Canonical link: https://commits.webkit.org/264148@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c32aed: [GTK][WPE] Fix broken test expectations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c32aedc17738c110bba419c2e501893f2efb97dd https://github.com/WebKit/WebKit/commit/c32aedc17738c110bba419c2e501893f2efb97dd Author: Claudio Saavedra Date: 2023-05-17 (Wed, 17 May 2023) Changed paths: M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt Log Message: --- [GTK][WPE] Fix broken test expectations https://bugs.webkit.org/show_bug.cgi?id=256881 Unreviewed gardening. 263587@main updated GTK and WPE expectations but did a poor job on actually not breaking them. Fix them. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/264139@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdbb4b: Cherry-pick 259548.47@safari-7615-branch (0f2c1212...
b.com/WebKit/WebKit/commit/ea15ace73a2e2643dc73085a137791fb80f4339a Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash-expected.txt A LayoutTests/fast/multicol/nested-columns-out-of-flow-crash.html M Source/WebCore/rendering/RenderObject.cpp M Source/WebCore/rendering/RenderObject.h Log Message: --- Cherry-pick 256843.7@webkit-2022.12-embargoed (3b92d70ba3ea). rdar://107475202 Do not skip fragmented flow thread descendents https://bugs.webkit.org/show_bug.cgi?id=245374 rdar://98438399 Reviewed by Alan Baradlay. Do not skip fragmented flow thread descendents in initializeFragmentedFlowStateOnInsertion since its children may have a different state based on the inserted fragmented flow thread. When a fragmented flow thread is removed there is no effect on the inner fragmented flow threads so that behaviour is unchenged. * LayoutTests/fast/multicol/nested-columns-out-of-flow-crash-expected.txt: Added. * LayoutTests/fast/multicol/nested-columns-out-of-flow-crash.html: Added. * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::setFragmentedFlowStateIncludingDescendants): (WebCore::RenderObject::initializeFragmentedFlowStateOnInsertion): * Source/WebCore/rendering/RenderObject.h: Canonical link: https://commits.webkit.org/256843.7@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/262444@main Commit: fa3e94b523cdb209d4db2980a7a92dfeb7cf8707 https://github.com/WebKit/WebKit/commit/fa3e94b523cdb209d4db2980a7a92dfeb7cf8707 Author: Rob Buis Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/layers/normal-flow-dialog-remove-layer-crash-expected.html A LayoutTests/fast/layers/normal-flow-dialog-remove-layer-crash.html M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- Cherry-pick 256843.8@webkit-2022.12-embargoed (fe2f16c1dabe). rdar://107475239 Recalculate normal flow value in RenderLayer::establishesTopLayerDidChange https://bugs.webkit.org/show_bug.cgi?id=251013 Reviewed by Tim Nguyen. In RenderLayer::rebuildZOrderLists the RenderView layer makes sure the layers for dialogs/top-level elements are appended after everything else in the positive z-order list. When removing the dialog layer, dirtyPaintOrderListsOnChildChange will be called and since it is not a normal only flow everything will be handled correctly through dirtyStackingContextZOrderLists. In the test case the behaviour is the same until dirtyPaintOrderListsOnChildChange is called on the dialog layer removal. Now that layer to be removed *is* a normal only flow (the element is no longer positioned and has non visible overflow, see RenderLayer::shouldBeNormalFlowOnly). This means the positive z-order list is unchanged and the deleted layer still part of it. When the test cleanup code does a final repaint, the RenderView positive z-order list is processed as normal and when trying to access the deleted layer the UAF happens. To fix this, make sure the normal flow value is correct when adding the layer in RenderLayer::establishesTopLayerDidChange. * LayoutTests/fast/layers/normal-flow-dialog-remove-layer-crash-expected.html: Added. * LayoutTests/fast/layers/normal-flow-dialog-remove-layer-crash.html: Added. * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::establishesTopLayerDidChange): Canonical link: https://commits.webkit.org/256843.8@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/262445@main Commit: 55616cb231b6806084e5b17f82cd9612ab260394 https://github.com/WebKit/WebKit/commit/55616cb231b6806084e5b17f82cd9612ab260394 Author: Claudio Saavedra Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: A LayoutTests/fast/css/content/content-on-focus-change-expected.txt A LayoutTests/fast/css/content/content-on-focus-change.html Log Message: --- Cherry-pick 256843.9@webkit-2022.12-embargoed (4c3dcd480f7e). rdar://107475307 Test display contents change on focus change https://bugs.webkit.org/show_bug.cgi?id=251014 Reviewed by Tim Nguyen. * LayoutTests/fast/css/content/content-on-focus-change-expected.txt: Added. * LayoutTests/fast/css/content/content-on-focus-change.html: Added. Canonical link: https://commits.webkit.org/256843.9@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/262446@main Compare: https://github.com/WebKit/WebKit/compare/e3babff08eae...55616cb231b6 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd27bc: Cherry-pick 261693@main (b0b96aa8e1b2). https://bu...
Branch: refs/heads/webkitglib/2.40 Home: https://github.com/WebKit/WebKit Commit: bd27bcaaf821b9eb1c95060bd9db3012c02c048b https://github.com/WebKit/WebKit/commit/bd27bcaaf821b9eb1c95060bd9db3012c02c048b Author: Chris Dumez Date: 2023-03-16 (Thu, 16 Mar 2023) Changed paths: M Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h Log Message: --- Cherry-pick 261693@main (b0b96aa8e1b2). https://bugs.webkit.org/show_bug.cgi?id=253898 Fix data race found by TSan in AudioScheduledSourceNode https://bugs.webkit.org/show_bug.cgi?id=253898 Reviewed by Jer Noble. AudioScheduledSourceNode::m_playbackState was accessed from several threads without synchronization. Use std::atomic<> to address the issue. * Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h: Canonical link: https://commits.webkit.org/261693@main Commit: 4bdaccd3d57e4f13bc558ecdc8cc47f4ea4221e2 https://github.com/WebKit/WebKit/commit/4bdaccd3d57e4f13bc558ecdc8cc47f4ea4221e2 Author: Claudio Saavedra Date: 2023-03-16 (Thu, 16 Mar 2023) Changed paths: M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c Log Message: --- Cherry-pick 261696@main (4f087256dcd6). https://bugs.webkit.org/show_bug.cgi?id=252309 Zydis fails to build in Debug mode with -Werror=type-limits (GCC 12.2 / SCCACHE) https://bugs.webkit.org/show_bug.cgi?id=252309 Reviewed by Yusuke Suzuki. Suppress -Wtype-limits while this gets fixed in zydis upstream. Canonical link: https://commits.webkit.org/261696@main Compare: https://github.com/WebKit/WebKit/compare/cbe361695f6a...4bdaccd3d57e ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0fafba: Cherry-pick 261693@main (b0b96aa8e1b2). https://bu...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 0fafba1714a919f8a187a123b69c0b13875e https://github.com/WebKit/WebKit/commit/0fafba1714a919f8a187a123b69c0b13875e Author: Chris Dumez Date: 2023-03-16 (Thu, 16 Mar 2023) Changed paths: M Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h Log Message: --- Cherry-pick 261693@main (b0b96aa8e1b2). https://bugs.webkit.org/show_bug.cgi?id=253898 Fix data race found by TSan in AudioScheduledSourceNode https://bugs.webkit.org/show_bug.cgi?id=253898 Reviewed by Jer Noble. AudioScheduledSourceNode::m_playbackState was accessed from several threads without synchronization. Use std::atomic<> to address the issue. * Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.h: Canonical link: https://commits.webkit.org/261693@main Commit: 77a4fe576c1a0c42b2e3ab19c60264aa99b8b138 https://github.com/WebKit/WebKit/commit/77a4fe576c1a0c42b2e3ab19c60264aa99b8b138 Author: Claudio Saavedra Date: 2023-03-16 (Thu, 16 Mar 2023) Changed paths: M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c Log Message: --- Cherry-pick 261696@main (4f087256dcd6). https://bugs.webkit.org/show_bug.cgi?id=252309 Zydis fails to build in Debug mode with -Werror=type-limits (GCC 12.2 / SCCACHE) https://bugs.webkit.org/show_bug.cgi?id=252309 Reviewed by Yusuke Suzuki. Suppress -Wtype-limits while this gets fixed in zydis upstream. Canonical link: https://commits.webkit.org/261696@main Compare: https://github.com/WebKit/WebKit/compare/44d26798af86...77a4fe576c1a ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f0872: Zydis fails to build in Debug mode with -Werror=ty...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f087256dcd6e55f75e9a37db9de504f608b77ab https://github.com/WebKit/WebKit/commit/4f087256dcd6e55f75e9a37db9de504f608b77ab Author: Claudio Saavedra Date: 2023-03-15 (Wed, 15 Mar 2023) Changed paths: M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c M Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c Log Message: --- Zydis fails to build in Debug mode with -Werror=type-limits (GCC 12.2 / SCCACHE) https://bugs.webkit.org/show_bug.cgi?id=252309 Reviewed by Yusuke Suzuki. Suppress -Wtype-limits while this gets fixed in zydis upstream. Canonical link: https://commits.webkit.org/261696@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0301fc: [Debug][Wasm] Build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0301fc0f931a9b6ae8e98187b8131932e98b5223 https://github.com/WebKit/WebKit/commit/0301fc0f931a9b6ae8e98187b8131932e98b5223 Author: Claudio Saavedra Date: 2023-03-14 (Tue, 14 Mar 2023) Changed paths: M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp Log Message: --- [Debug][Wasm] Build fix https://bugs.webkit.org/show_bug.cgi?id=253880 Reviewed by Philippe Normand. Value.asLocal() returns an unsigned value, comparison is redundant (and fails with -Werror=type-limits). * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::locationOfWithoutBinding): Canonical link: https://commits.webkit.org/261630@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 155bed: HTMLFrameOwnerElement: use Document::creationURL()...
Branch: refs/heads/webkit-2023.2-embargoed Home: https://github.com/WebKit/WebKit Commit: 155bed7390009a843b69d83e18f31097c198f7d7 https://github.com/WebKit/WebKit/commit/155bed7390009a843b69d83e18f31097c198f7d7 Author: Claudio Saavedra Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html M Source/WebCore/html/HTMLFrameOwnerElement.cpp Log Message: --- HTMLFrameOwnerElement: use Document::creationURL() for self-reference check https://bugs.webkit.org/show_bug.cgi?id=248469 Reviewed by Darin Adler. Document::url() can be changed through the History API, therefore it's not a reliable source to verify whether a given URL is self-referencing. Use creationURL instead, which is immutable. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt: Added. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html: Added. * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Canonical link: https://commits.webkit.org/256843.2@webkit-2022.12-embargoed Commit: 1d7abcd180abe9c3164366f5b6c0fb86e69790b5 https://github.com/WebKit/WebKit/commit/1d7abcd180abe9c3164366f5b6c0fb86e69790b5 Author: Rob Buis Date: 2022-12-08 (Thu, 08 Dec 2022) Changed paths: A LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt A LayoutTests/fast/block/crash-empty-layoutStateStack.html M Source/WebCore/rendering/RenderBlock.cpp Log Message: --- Protect against empty layout state https://bugs.webkit.org/show_bug.cgi?id=248771 Reviewed by Alan Baradlay. Protect against empty layout state. * LayoutTests/fast/block/crash-empty-layoutStateStack-expected.txt: Added. * LayoutTests/fast/block/crash-empty-layoutStateStack.html: Added. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObject): (WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Canonical link: https://commits.webkit.org/256843.3@webkit-2022.12-embargoed Commit: 6234ec9c65b9f2d07fc59985ffba242fdd0da686 https://github.com/WebKit/WebKit/commit/6234ec9c65b9f2d07fc59985ffba242fdd0da686 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt A LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html M Source/WebCore/rendering/RenderLayerModelObject.cpp Log Message: --- Do not issue repaints when in detached state https://bugs.webkit.org/show_bug.cgi?id=248773 Reviewed by Antti Koivisto. Do not issue repaints when the RenderObject is in detached state while removing render subtrees. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2-expected.txt: Added. * LayoutTests/fast/table/table-cell-crash-when-detached-state-2.html: Added. * Source/WebCore/rendering/RenderLayerModelObject.cpp: (WebCore::RenderTableCell::willBeRemovedFromTree const): Canonical link: https://commits.webkit.org/256843.4@webkit-2022.12-embargoed Commit: 312254f5776dd16bde18cd4d99444d81a0c331d6 https://github.com/WebKit/WebKit/commit/312254f5776dd16bde18cd4d99444d81a0c331d6 Author: Rob Buis Date: 2022-12-16 (Fri, 16 Dec 2022) Changed paths: A LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt A LayoutTests/fast/css/content/quote-display-contents-crash.html M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/Element.cpp Log Message: --- Check displayContentsChanged in destroyRenderTreeIfNeeded https://bugs.webkit.org/show_bug.cgi?id=248776 rdar://102807985> Reviewed by Antti Koivisto. Check displayContentsChanged in destroyRenderTreeIfNeeded since display: contents may be removed due to focus removal while removing subtrees but we still need to clean up pseudo elements. * LayoutTests/fast/css/content/quote-display-contents-crash-expected.txt: Added. * LayoutTests/fast/css/content/quote-display-contents-crash.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::destroyRenderTreeIfNeeded): * Source/WebCore/dom/Element.cpp: (WebCore::Element::resolveComputedStyle): Canonical link: https://commits.webkit.org/256843.5@webkit-2022.12-embargoed Commit: c4c0ef6360b2aa3fd32b1b9f6a5b6b5ccaa61a98 https://github.com/WebKit/WebKit/commit/c4c0ef6360b2aa3fd32b1b9f6a5b6b5ccaa61a98 Author: Rob Buis Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: A LayoutTests/fast/dom/set-outer-text-on-moved-element-expected.html A LayoutTests/fast/dom/set-outer-text-on-moved-element.html M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp Log Message: --- Verify that style update roots are for corr
[webkit-changes] [WebKit/WebKit] f6afe3: HTML Parser: Test nested A element with nested for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6afe3e3209ab00d3535b1277ff26b7176b81e39 https://github.com/WebKit/WebKit/commit/f6afe3e3209ab00d3535b1277ff26b7176b81e39 Author: Claudio Saavedra Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: A LayoutTests/fast/html/nested-a-with-nested-formatting-attributes-expected.txt A LayoutTests/fast/html/nested-a-with-nested-formatting-attributes.html Log Message: --- HTML Parser: Test nested A element with nested formatting attributes https://bugs.webkit.org/show_bug.cgi?id=245393 Reviewed by Alan Baradlay. * LayoutTests/fast/html/nested-a-with-nested-formatting-attributes-expected.txt: Added. * LayoutTests/fast/html/nested-a-with-nested-formatting-attributes.html: Added. Canonical link: https://commits.webkit.org/260009@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e72817: Cherry-pick 252432.838@safari-7614-branch (6651709...
://commits.webkit.org/252432.898@safari-7614-branch Commit: 35ecde32dfff55d1afd332047651da077426fb95 https://github.com/WebKit/WebKit/commit/35ecde32dfff55d1afd332047651da077426fb95 Author: Claudio Saavedra Date: 2023-01-31 (Tue, 31 Jan 2023) Changed paths: A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html M Source/WebCore/html/HTMLFrameOwnerElement.cpp Log Message: --- Cherry-pick 256843.2@webkit-2022.12-embargoed (155bed739000). https://bugs.webkit.org/show_bug.cgi?id=248469 HTMLFrameOwnerElement: use Document::creationURL() for self-reference check https://bugs.webkit.org/show_bug.cgi?id=248469 Reviewed by Darin Adler. Document::url() can be changed through the History API, therefore it's not a reliable source to verify whether a given URL is self-referencing. Use creationURL instead, which is immutable. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt: Added. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html: Added. * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Canonical link: https://commits.webkit.org/256843.2@webkit-2022.12-embargoed Compare: https://github.com/WebKit/WebKit/compare/33fc68e77ae8...35ecde32dfff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 562c83: Cherry-pick 256843.2@webkit-2022.12-embargoed (155...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 562c83b8958666e8fb3d74344129490b96e3db9c https://github.com/WebKit/WebKit/commit/562c83b8958666e8fb3d74344129490b96e3db9c Author: Claudio Saavedra Date: 2023-01-25 (Wed, 25 Jan 2023) Changed paths: A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt A LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html M Source/WebCore/html/HTMLFrameOwnerElement.cpp Log Message: --- Cherry-pick 256843.2@webkit-2022.12-embargoed (155bed739000). rdar://104648588 HTMLFrameOwnerElement: use Document::creationURL() for self-reference check https://bugs.webkit.org/show_bug.cgi?id=248469 Reviewed by Darin Adler. Document::url() can be changed through the History API, therefore it's not a reliable source to verify whether a given URL is self-referencing. Use creationURL instead, which is immutable. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified-expected.txt: Added. * LayoutTests/http/tests/security/embedded-self-reference-after-url-modified.html: Added. * Source/WebCore/html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::isProhibitedSelfReference const): Canonical link: https://commits.webkit.org/256843.2@webkit-2022.12-embargoed Canonical link: https://commits.webkit.org/259370@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e82a3: RenderInline: unused variable broke the build at 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e82a3da2ccc41ca28e85ac2a9c0166cf8d6b59c https://github.com/WebKit/WebKit/commit/1e82a3da2ccc41ca28e85ac2a9c0166cf8d6b59c Author: Claudio Saavedra Date: 2022-12-15 (Thu, 15 Dec 2022) Changed paths: M Source/WebCore/rendering/RenderInline.cpp Log Message: --- RenderInline: unused variable broke the build at 257937@main https://bugs.webkit.org/show_bug.cgi?id=249422 Unreviewed build fix. * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::innerPaddingBoxWidth const): Canonical link: https://commits.webkit.org/257956@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9d802: Debug build fixes with assertions disabled
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9d802d8c6456d7cd603897751af94c900431f30 https://github.com/WebKit/WebKit/commit/b9d802d8c6456d7cd603897751af94c900431f30 Author: Claudio Saavedra Date: 2022-12-13 (Tue, 13 Dec 2022) Changed paths: M Source/JavaScriptCore/dfg/DFGCSEPhase.cpp M Source/WTF/wtf/FastMalloc.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp M Source/WebCore/accessibility/AXObjectCache.cpp M Source/WebCore/accessibility/AccessibilityObject.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/layout/formattingContexts/FormattingContext.cpp M Source/WebCore/loader/cache/CachedResource.cpp M Source/WebCore/platform/PODRedBlackTree.h M Source/WebCore/platform/audio/FFTFrame.cpp M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp M Source/WebCore/platform/graphics/Font.cpp M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp M Source/WebCore/rendering/RenderFragmentedFlow.cpp M Source/WebCore/rendering/RenderInline.cpp M Source/WebCore/rendering/RenderTableSection.cpp M Source/WebCore/rendering/svg/RenderSVGText.cpp Log Message: --- Debug build fixes with assertions disabled https://bugs.webkit.org/show_bug.cgi?id=249129 Reviewed by Philippe Normand. When disabling assertions in a Debug build there are plenty of unused variables that break the build due to -Werror. Most of those are due to using NDEBUG when ASSERT_ENABLED is needed. Fix those. * Source/JavaScriptCore/dfg/DFGCSEPhase.cpp: * Source/WTF/wtf/FastMalloc.cpp: * Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp: (WebCore::IDBServer::MemoryIDBBackingStore::clearObjectStore): * Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp: (WebCore::PeerConnectionBackend::validateSDP const): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::notificationPostTimerFired): * Source/WebCore/accessibility/AccessibilityObject.cpp: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): (WebCore::AccessibilityRenderObject::detachRemoteParts): * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/dom/Document.cpp: (WebCore::Document::removedLastRef): * Source/WebCore/layout/formattingContexts/FormattingContext.cpp: (WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const): * Source/WebCore/loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): * Source/WebCore/platform/PODRedBlackTree.h: * Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp: (WebCore::CDMFactoryClearKey::createCDM): (WebCore::CDMInstanceSessionClearKey::loadSession): (WebCore::CDMInstanceSessionClearKey::removeSessionData): * Source/WebCore/platform/graphics/Font.cpp: (WebCore::codePointSupportIndex): * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::handleErrorConditionFromStreamingThread): * Source/WebCore/rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::removeRenderBoxFragmentInfo): * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRect const): * Source/WebCore/rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject): * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::checkLayoutAttributesConsistency): Canonical link: https://commits.webkit.org/257784@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 615545: DumpRenderTree: dumpChildFramesAsText inconsistent...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6155452b4f3443d561bcf998d5b934aefbb7c167 https://github.com/WebKit/WebKit/commit/6155452b4f3443d561bcf998d5b934aefbb7c167 Author: Claudio Saavedra Date: 2022-11-30 (Wed, 30 Nov 2022) Changed paths: M Tools/DumpRenderTree/mac/DumpRenderTree.mm M Tools/DumpRenderTree/win/DumpRenderTree.cpp Log Message: --- DumpRenderTree: dumpChildFramesAsText inconsistent with WTR https://bugs.webkit.org/show_bug.cgi?id=248531 Reviewed by Darin Adler and David Kilzer. DumpRenderTree needs dumpAsText as well in order for dumpChildFramesAsText to work, whereas WTR doesn't. Fix this inconsistency in DRT. * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (dump): * Tools/DumpRenderTree/win/DumpRenderTree.cpp: (dump): Canonical link: https://commits.webkit.org/257221@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6e0351: [WPE] Fix build after 256940@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6e03517aaddb74069a4b59bc5936fda90b49d9a5 https://github.com/WebKit/WebKit/commit/6e03517aaddb74069a4b59bc5936fda90b49d9a5 Author: Claudio Saavedra Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp Log Message: --- [WPE] Fix build after 256940@main Unreviewed build fix. Use proper format specifier for logging. * Source/WebCore/platform/gamepad/libwpe/GamepadProviderLibWPE.cpp: (WebCore::GamepadProviderLibWPE::gamepadConnected): (WebCore::GamepadProviderLibWPE::gamepadDisconnected): Canonical link: https://commits.webkit.org/256988@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4cd9a0: [SOUP] http/tests/security/cookies/cookie-theft-wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4cd9a03152f06e46cabc1ee0083c52085f722619 https://github.com/WebKit/WebKit/commit/4cd9a03152f06e46cabc1ee0083c52085f722619 Author: Claudio Saavedra Date: 2022-11-09 (Wed, 09 Nov 2022) Changed paths: M LayoutTests/platform/gtk/TestExpectations Log Message: --- [SOUP] http/tests/security/cookies/cookie-theft-with-javascript-doc.html crashing no more https://bugs.webkit.org/show_bug.cgi?id=246858 Unreviewed gardening. * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/256498@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 69c437: WPE: Tentative build-fix for the Ubuntu LTS bot
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 69c437dd145700f24c8084ca971e3ac084423475 https://github.com/WebKit/WebKit/commit/69c437dd145700f24c8084ca971e3ac084423475 Author: Claudio Saavedra Date: 2022-10-29 (Sat, 29 Oct 2022) Changed paths: M Tools/wpe/backends/fdo/WindowViewBackend.cpp Log Message: --- WPE: Tentative build-fix for the Ubuntu LTS bot https://bugs.webkit.org/show_bug.cgi?id=247228 Reviewed by Michael Catanzaro. * Tools/wpe/backends/fdo/WindowViewBackend.cpp: Canonical link: https://commits.webkit.org/256135@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8db30a: WPE: Tentative build fix for the Ubuntu LTS bot
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8db30a2f05dd28e538760996c2b0c72f1f4934b5 https://github.com/WebKit/WebKit/commit/8db30a2f05dd28e538760996c2b0c72f1f4934b5 Author: Claudio Saavedra Date: 2022-10-26 (Wed, 26 Oct 2022) Changed paths: M Tools/wpe/backends/fdo/WindowViewBackend.cpp Log Message: --- WPE: Tentative build fix for the Ubuntu LTS bot https://bugs.webkit.org/show_bug.cgi?id=247062 Reviewed by Michael Catanzaro. wl_pointer::axis_value120 was only defined in version 8, it seems that the Ubuntu LTS bot has an older version of the wayland protocols. * Tools/wpe/backends/fdo/WindowViewBackend.cpp: Canonical link: https://commits.webkit.org/256015@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9cbd8d: JSC: Fix -Wreturn-type error/warning
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9cbd8da8ae8dd844d53b6ee4000c99cc357e8ba1 https://github.com/WebKit/WebKit/commit/9cbd8da8ae8dd844d53b6ee4000c99cc357e8ba1 Author: Claudio Saavedra Date: 2022-10-26 (Wed, 26 Oct 2022) Changed paths: M Source/JavaScriptCore/jit/Width.h Log Message: --- JSC: Fix -Wreturn-type error/warning https://bugs.webkit.org/show_bug.cgi?id=247058 Reviewed by Ross Kirsling. * Source/JavaScriptCore/jit/Width.h: (JSC::mask): Add missing return at the end of the method. Canonical link: https://commits.webkit.org/256010@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ed88f: [SOUP] http/tests/security/cookies/cookie-theft-wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ed88f50e058c49da0815c6dcf5f8f71529daae7 https://github.com/WebKit/WebKit/commit/1ed88f50e058c49da0815c6dcf5f8f71529daae7 Author: Claudio Saavedra Date: 2022-10-25 (Tue, 25 Oct 2022) Changed paths: M LayoutTests/platform/gtk/TestExpectations Log Message: --- [SOUP] http/tests/security/cookies/cookie-theft-with-javascript-doc.html crashing since 255420@main Unreviewed gardening. * LayoutTests/platform/gtk/TestExpectations: Add the failure. Canonical link: https://commits.webkit.org/256000@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a2e027: HTML Parser: Update formatting element list bookma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2e027e92c7b91eeabcb6bd5e81ced26afa64cc0 https://github.com/WebKit/WebKit/commit/a2e027e92c7b91eeabcb6bd5e81ced26afa64cc0 Author: Claudio Saavedra Date: 2022-10-24 (Mon, 24 Oct 2022) Changed paths: M Source/WebCore/html/parser/HTMLFormattingElementList.cpp M Source/WebCore/html/parser/HTMLFormattingElementList.h M Source/WebCore/html/parser/HTMLTreeBuilder.cpp Log Message: --- HTML Parser: Update formatting element list bookmarks on element removal https://bugs.webkit.org/show_bug.cgi?id=246936 Reviewed by Ryosuke Niwa. When elements are removed from the formatting element list, the position in the list of the element bookmarked might change, so make sure that bookmarks are updated when needed. * Source/WebCore/html/parser/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::removeUpdatingBookmark): * Source/WebCore/html/parser/HTMLFormattingElementList.h: * Source/WebCore/html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Canonical link: https://commits.webkit.org/255907@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb1dbb: More unified-build fixes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb1dbb083e33c49e36983dd2a32b8315d9aaf61d https://github.com/WebKit/WebKit/commit/cb1dbb083e33c49e36983dd2a32b8315d9aaf61d Author: Claudio Saavedra Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/WebCore/css/parser/CSSParserImpl.cpp M Source/WebCore/page/FrameView.cpp Log Message: --- More unified-build fixes https://bugs.webkit.org/show_bug.cgi?id=246684 Unreviewed build fix. * Source/WebCore/css/parser/CSSParserImpl.cpp: * Source/WebCore/page/FrameView.cpp: Canonical link: https://commits.webkit.org/255670@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c5badd: More unified-build fixes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5baddfe6e6cdc29e1f3714bdc7c283ee786bcc3 https://github.com/WebKit/WebKit/commit/c5baddfe6e6cdc29e1f3714bdc7c283ee786bcc3 Author: Claudio Saavedra Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M Source/JavaScriptCore/runtime/NumberPredictionFuzzerAgent.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp M Source/WebCore/css/query/GenericMediaQueryTypes.h M Source/WebCore/page/AbstractFrame.cpp M Source/WebCore/page/ScreenOrientation.cpp M Source/WebCore/platform/graphics/SourceBufferPrivateClient.cpp M Source/WebKit/UIProcess/OverrideLanguages.cpp Log Message: --- More unified-build fixes https://bugs.webkit.org/show_bug.cgi?id=246637 Unreviewed build fix. * Source/JavaScriptCore/runtime/NumberPredictionFuzzerAgent.cpp: * Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp: * Source/WebCore/css/query/GenericMediaQueryTypes.h: * Source/WebCore/page/AbstractFrame.cpp: * Source/WebCore/page/ScreenOrientation.cpp: * Source/WebCore/platform/graphics/SourceBufferPrivateClient.cpp: * Source/WebKit/UIProcess/OverrideLanguages.cpp: Canonical link: https://commits.webkit.org/255645@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
