[webkit-changes] [WebKit/WebKit] 6dd9fa: Strip prefix from Trusted Type Function samples
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dd9fa30a220a37e4edc257c79c3512403f25c17 https://github.com/WebKit/WebKit/commit/6dd9fa30a220a37e4edc257c79c3512403f25c17 Author: Luke Warlow Date: 2024-12-18 (Wed, 18 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt M Source/WebCore/page/csp/ContentSecurityPolicy.cpp Log Message: --- Strip prefix from Trusted Type Function samples https://bugs.webkit.org/show_bug.cgi?id=277258 Reviewed by Tim Nguyen. This strips "function anonymous" and similar prefixes for the function variants from the CSP violation report sample produced by trusted types. This aligns with Chromium's existing behaviour and the latest spec consensus. Spec: https://w3c.github.io/trusted-types/dist/spec/#should-block-sink-type-mismatch * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMissingTrustedTypesForSinkGroup const): Canonical link: https://commits.webkit.org/287999@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20aaac: Implement FocusOptions.focusVisible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20aaacc363ae8d250a9b0c203c4053b2818abfe4 https://github.com/WebKit/WebKit/commit/20aaacc363ae8d250a9b0c203c4053b2818abfe4 Author: Luke Warlow Date: 2024-12-17 (Tue, 17 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/focusVisible-expected.txt M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/FocusOptions.h M Source/WebCore/dom/FocusOptions.idl Log Message: --- Implement FocusOptions.focusVisible https://bugs.webkit.org/show_bug.cgi?id=242456 Reviewed by Manuel Rego Casasnovas. Implement the focusVisible item in FocusOptions. When this value is provided the focus visibility is enabled or disabled, if the value isn't provided we fallback to an implementation defined value. An assertion is removed as the case that's being protected against is now valid. * LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/focusVisible-expected.txt: * Source/WebCore/dom/Element.cpp: (WebCore::Element::setFocus): (WebCore::Element::setHasFocusVisible): (WebCore::Element::focus): * Source/WebCore/dom/FocusOptions.h: * Source/WebCore/dom/FocusOptions.idl: Canonical link: https://commits.webkit.org/287959@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87d1cb: Re-import trusted-types WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87d1cb313a7416ce900c5e90a31138370f2967de https://github.com/WebKit/WebKit/commit/87d1cb313a7416ce900c5e90a31138370f2967de Author: Luke Warlow Date: 2024-12-17 (Tue, 17 Dec 2024) Changed paths: M LayoutTests/TestExpectations R LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-TT-realm-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-TT-realm.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-non-TT-realm-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-non-TT-realm.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-applying-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-applying-default-policy.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-default-policy-throwing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-default-policy-throwing.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/helper.sub.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-event-handlers-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-event-handlers.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/tt-block-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/tt-block-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/w3c-import.log Log Message: --- Re-import trusted-types WPT https://bugs.webkit.org/show_bug.cgi?id=284748 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/3f2ceab4f04aaecd9582e1a38dcf60e630c27faf * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-TT-realm-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-TT-realm.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-non-TT-realm-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP-after-adoption-from-non-TT-realm.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-respects-Elements-node-documents-globals-CSP.html. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string
[webkit-changes] [WebKit/WebKit] 71863b: Re-import content-security-policy/reporting WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 71863b6daa9c7783d91640850061622764c7bbd8 https://github.com/WebKit/WebKit/commit/71863b6daa9c7783d91640850061622764c7bbd8 Author: Luke Warlow Date: 2024-12-17 (Tue, 17 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub.html A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub-expected.txt A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub.html A LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub.html.sub.headers M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-preload-and-consume.https.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-uri-from-child-frame.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/support/not-embeddable-frame.py M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/support/set-cookie.py M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/w3c-import.log A LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub-expected.txt M LayoutTests/tests-options.json Log Message: --- Re-import content-security-policy/reporting WPT https://bugs.webkit.org/show_bug.cgi?id=284747 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/f4515a8ef1ad577e0b48e1609a29b80c664ebf69 * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub.html: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub.html.sub.headers: Added. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-preload-and-consume.https.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-uri-from-child-frame.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/support/not-embeddable-frame.py: (main): * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/support/set-cookie.py: (main): * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/w3c-import.log: * LayoutTests/tests-options.json: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/reporting/report-frame-ancestors-no-parent-cookies.sub-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-cross-origin-frame.sub-expected.txt: Added. Canonical link: https://commits.webkit.org/287930@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 152e92: Implement trusted types enforcement on Function co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 152e920a5ac26047b9103bd750367343205e7752 https://github.com/WebKit/WebKit/commit/152e920a5ac26047b9103bd750367343205e7752 Author: Luke Warlow Date: 2024-12-16 (Mon, 16 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt M Source/JavaScriptCore/API/JSAPIGlobalObject.cpp M Source/JavaScriptCore/API/JSAPIGlobalObject.mm M Source/JavaScriptCore/debugger/DebuggerEvalEnabler.h M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/DirectEvalExecutable.cpp M Source/JavaScriptCore/runtime/FunctionConstructor.cpp M Source/JavaScriptCore/runtime/GlobalObjectMethodTable.h M Source/JavaScriptCore/runtime/IndirectEvalExecutable.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.h M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/JSDOMWindowBase.h M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h Log Message: --- Implement trusted types enforcement on Function constructor https://bugs.webkit.org/show_bug.cgi?id=273187 Reviewed by Yusuke Suzuki. This patch adds trusted types enforcement to the Function constructor as well as updating the eval implementation. The canCompileStrings global method table function no longer takes a JSValue argument, this is because it is now only called for untrusted input from eval. The implementation of TT enforcement for both direct and indirect eval is updated to do more work in JSC. The structure of the TrustedScript type is used by JSC to determine if an object should be evaluated, rather than always calling codeForEval. Only if the structures don't match is codeForEval called, this can happen if someone changes the instance properties such as for polyfills. The canCompileStrings call is now only done if the input is known to be untrusted (raw string rather than TrustedScript argument). The Function constructor is now also updated such that when TT enforcement is enabled through CSP, similar logic comparing the arguments to the TrustedScript structure is used. If not all of the arguments match the structure then they're not trusted so we fallback to calling canCompileStrings, with a new ArgList atgument. The ArgList is used to check if the arguments are modified trusted script objects, which are accepted providing the stringifier isn't modified. DebuggerEvalEnabler is also updated to disable trusted types and re-enable it, so that web inspector can continue working on sites with TT enforced. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt: * Source/JavaScriptCore/API/JSAPIGlobalObject.cpp: (JSC::JSAPIGlobalObject::globalObjectMethodTable): * Source/JavaScriptCore/API/JSAPIGlobalObject.mm: (JSC::JSAPIGlobalObject::globalObjectMethodTable): * Source/JavaScriptCore/debugger/DebuggerEvalEnabler.h: (JSC::DebuggerEvalEnabler::DebuggerEvalEnabler): (JSC::DebuggerEvalEnabler::~DebuggerEvalEnabler): * Source/JavaScriptCore/interpreter/Interpreter.
[webkit-changes] [WebKit/WebKit] cda20f: Textarea incorrectly reserves space for overlay sc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cda20f66eecb111c71be0960b981e596473e889f https://github.com/WebKit/WebKit/commit/cda20f66eecb111c71be0960b981e596473e889f Author: Luke Warlow Date: 2024-12-14 (Sat, 14 Dec 2024) Changed paths: A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size-expected.txt A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size.html A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size-expected.txt A LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size.html M Source/WebCore/platform/ScrollTypes.h M Source/WebCore/platform/ScrollbarTheme.h M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h M Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp M Source/WebCore/platform/gtk/ScrollbarThemeGtk.h M Source/WebCore/platform/ios/ScrollbarThemeIOS.h M Source/WebCore/platform/ios/ScrollbarThemeIOS.mm M Source/WebCore/platform/mac/ScrollbarThemeMac.h M Source/WebCore/platform/mac/ScrollbarThemeMac.mm M Source/WebCore/platform/mock/ScrollbarThemeMock.cpp M Source/WebCore/platform/mock/ScrollbarThemeMock.h M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h M Source/WebCore/rendering/RenderBox.h M Source/WebCore/rendering/RenderScrollbarTheme.h M Source/WebCore/rendering/RenderTextControl.cpp Log Message: --- Textarea incorrectly reserves space for overlay scrollbar https://bugs.webkit.org/show_bug.cgi?id=275114 Reviewed by Simon Fraser. Check the ScrollbarTheme::usesOverlayScrollbar in the various ScrollbarTheme's scrollbarThickness method. Update RenderTextControl to tell scrollbarThickness to ignore overlay scrollbar sizing. This aligns WebKit with Firefox. * LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size-expected.txt: Added. * LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-cols-size.html: Added. * LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size-expected.txt: Added. * LayoutTests/fast/scrolling/mac/scrollbars/overlay-scrollbar-textarea-rows-size.html: Added. * Source/WebCore/platform/ScrollTypes.h: * Source/WebCore/platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::scrollbarThickness): * Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp: (WebCore::ScrollbarThemeAdwaita::scrollbarThickness): * Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h: * Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::scrollbarThickness): * Source/WebCore/platform/gtk/ScrollbarThemeGtk.h: * Source/WebCore/platform/ios/ScrollbarThemeIOS.h: * Source/WebCore/platform/ios/ScrollbarThemeIOS.mm: (WebCore::ScrollbarThemeIOS::scrollbarThickness): * Source/WebCore/platform/mac/ScrollbarThemeMac.h: * Source/WebCore/platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::scrollbarThickness): * Source/WebCore/platform/mock/ScrollbarThemeMock.cpp: (WebCore::ScrollbarThemeMock::scrollbarThickness): * Source/WebCore/platform/mock/ScrollbarThemeMock.h: * Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp: (WebCore::ScrollbarThemePlayStation::scrollbarThickness): * Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h: * Source/WebCore/rendering/RenderBox.h: * Source/WebCore/rendering/RenderScrollbarTheme.h: * Source/WebCore/rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::scrollbarThickness const): Canonical link: https://commits.webkit.org/287837@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ea689b: Consume user activation in showPicker()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ea689bbd86df6c8d9d057f501db533b6a3ad22b7 https://github.com/WebKit/WebKit/commit/ea689bbd86df6c8d9d057f501db533b6a3ad22b7 Author: Luke Warlow Date: 2024-12-11 (Wed, 11 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt M Source/WebCore/html/HTMLInputElement.cpp M Source/WebCore/html/HTMLSelectElement.cpp Log Message: --- Consume user activation in showPicker() https://bugs.webkit.org/show_bug.cgi?id=274798 Reviewed by Tim Nguyen. The HTML spec has beeen updated to consume user activation in the show the picker algorithm. This patch implements that change for the showPicker() JS methods. Follow ups will be needed to address it for other invocations such as click() * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::showPicker): * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::showPicker): Canonical link: https://commits.webkit.org/287664@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d65fd5: Bugzilla color scheme only works in WebKit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d65fd51cf5d16ff261bbdb6dc196ec328e4565d8 https://github.com/WebKit/WebKit/commit/d65fd51cf5d16ff261bbdb6dc196ec328e4565d8 Author: Luke Warlow Date: 2024-12-10 (Tue, 10 Dec 2024) Changed paths: M Websites/bugs.webkit.org/template/en/custom/global/header.html.tmpl Log Message: --- Bugzilla color scheme only works in WebKit https://bugs.webkit.org/show_bug.cgi?id=284377 Reviewed by Tim Nguyen. This patch switches Bugzilla's supported-color-schemes meta tag to use color-scheme instead. * Websites/bugs.webkit.org/template/en/custom/global/header.html.tmpl: Canonical link: https://commits.webkit.org/287628@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 899ca0: Implement imperative invoker changes to popover APIs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 899ca0cd494c188aeb6bf1566f35e7b29bab8869 https://github.com/WebKit/WebKit/commit/899ca0cd494c188aeb6bf1566f35e7b29bab8869 Author: Luke Warlow Date: 2024-12-10 (Tue, 10 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt M Source/WebCore/dom/PopoverData.h M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLElement.idl M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/page/FocusController.cpp Log Message: --- Implement imperative invoker changes to popover APIs https://bugs.webkit.org/show_bug.cgi?id=282337 Reviewed by Tim Nguyen. Update showPopover() and togglePopover() to be able to set a popover invoker relationship imperatively. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt: * Source/WebCore/dom/PopoverData.h: (WebCore::PopoverData::invoker const): (WebCore::PopoverData::setInvoker): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::showPopover): (WebCore::HTMLElement::showPopoverInternal): (WebCore::HTMLElement::togglePopover): (WebCore::HTMLElement::handleCommandInternal): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLElement.idl: * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::handlePopoverTargetAction const): * Source/WebCore/page/FocusController.cpp: (WebCore::invokerForOpenPopover): Canonical link: https://commits.webkit.org/287624@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99da70: Reimport css/selectors tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99da701a3e878762b3bdd220a162027febaec559 https://github.com/WebKit/WebKit/commit/99da701a3e878762b3bdd220a162027febaec559 Author: Luke Warlow Date: 2024-12-10 (Tue, 10 Dec 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/crashtests/has-pseudoclass-only-crash.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/crashtests/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-pseudoclass-only-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-pseudoclass-only.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-closed-pseudo-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-closed-pseudo.html A LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-pseudo-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-pseudo.html M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/WEB_FEATURES.yml M LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log Log Message: --- Reimport css/selectors tests https://bugs.webkit.org/show_bug.cgi?id=284367 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/6d70cd30aa1eb2e5e8bcce4f0627cc7c3572cbe4 * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/WEB_FEATURES.yml: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/crashtests/has-pseudoclass-only-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/crashtests/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-pseudoclass-only-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-pseudoclass-only.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-closed-pseudo-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-pseudo-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-pseudo.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/selectors/open-closed-pseudo.html. * LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/WEB_FEATURES.yml: * LayoutTests/imported/w3c/web-platform-tests/css/selectors/w3c-import.log: Canonical link: https://commits.webkit.org/287614@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a02da: Implement new popover inside invoker behaviour
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a02dacf8e5b11135f826944889ac535264f3e41 https://github.com/WebKit/WebKit/commit/8a02dacf8e5b11135f826944889ac535264f3e41 Author: Luke Warlow Date: 2024-12-08 (Sun, 08 Dec 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-nested-in-button-expected.txt M Source/WebCore/html/HTMLButtonElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormControlElement.h M Source/WebCore/html/HTMLInputElement.cpp Log Message: --- Implement new popover inside invoker behaviour https://bugs.webkit.org/show_bug.cgi?id=283494 Reviewed by Tim Nguyen. This patch matches the new spec behaviour for when a popover is inside its invoker. See https://github.com/whatwg/html/pull/10770 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-nested-in-button-expected.txt: * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::handlePopoverTargetAction const): * Source/WebCore/html/HTMLFormControlElement.h: * Source/WebCore/html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Canonical link: https://commits.webkit.org/287522@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 876a7a: Re-import popover WPTs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 876a7a1da45b4fb251675180dfedc2e1918465fc https://github.com/WebKit/WebKit/commit/876a7a1da45b4fb251675180dfedc2e1918465fc Author: Luke Warlow Date: 2024-12-06 (Fri, 06 Dec 2024) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-active-document.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative-expected.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-crash.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hang.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hang.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-minimum-role-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-minimum-role.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-nested-in-button-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-nested-in-button.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt M LayoutTests/tests-options.json Log Message: --- Re-import popover WPTs https://bugs.webkit.org/show_bug.cgi?id=284158 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/6e5a52d2d1bf4cc67ef6a96bd1a4b956fd5123e1 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/imperative-invokers.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-active-document.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative-expected.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hint-crash.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hang.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-hang.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform
[webkit-changes] [WebKit/WebKit] 3540c7: Import trusted types WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3540c7d95aaa2e7d56c2e1e4e74ebd49bd885d53 https://github.com/WebKit/WebKit/commit/3540c7d95aaa2e7d56c2e1e4e74ebd49bd885d53 Author: Luke Warlow Date: 2024-12-03 (Tue, 03 Dec 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-appending-line-feed-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-appending-line-feed.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-event-handler-content-attributes.tentative.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-parseHTMLUnsafe.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-innerHTML-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-innerHTML.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-applying-default-policy-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-untrusted-arguments-and-applying-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/legacy-trusted-script-urls-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/legacy-trusted-script-urls.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/namespaces.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-report-only-support.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-navigation-expected.txt
[webkit-changes] [WebKit/WebKit] 9a8ecb: popovertarget on button type=button in form doesn'...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a8ecbaa8fc59d6f4336fffe04c31986cdc5e92e https://github.com/WebKit/WebKit/commit/9a8ecbaa8fc59d6f4336fffe04c31986cdc5e92e Author: Luke Warlow Date: 2024-08-27 (Tue, 27 Aug 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html M Source/WebCore/html/HTMLButtonElement.cpp Log Message: --- popovertarget on button type=button in form doesn't work https://bugs.webkit.org/show_bug.cgi?id=275899 Reviewed by Darin Adler. This patch fixes an issue where buttons with popovertarget never work when inside a form. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Removed. * Source/WebCore/html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Canonical link: https://commits.webkit.org/282801@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88833b: 'strict-dynamic' in script-src CSP breaks external...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88833ba4cdcb34cf4e173fec453dafac8c74ccda https://github.com/WebKit/WebKit/commit/88833ba4cdcb34cf4e173fec453dafac8c74ccda Author: Luke Warlow Date: 2024-08-21 (Wed, 21 Aug 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes-expected.txt M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.h M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h Log Message: --- 'strict-dynamic' in script-src CSP breaks external script with matching integrity hash https://bugs.webkit.org/show_bug.cgi?id=270784 Reviewed by Ryan Reno. This patch updates the early CSP checks for when 'strict-dynamic' is present to also match sub-resource-integrity. * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes-expected.txt: * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::requestClassicScript): (WebCore::ScriptElement::requestModuleScript): (WebCore::ScriptElement::requestImportMap): (WebCore::ScriptElement::executeClassicScript): (WebCore::ScriptElement::registerImportMap): * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowNonParserInsertedScripts const): * Source/WebCore/page/csp/ContentSecurityPolicy.h: * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForNonParserInsertedScripts const): * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h: Canonical link: https://commits.webkit.org/282577@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83cc6f: Re-import content-security-policy/script-src WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83cc6f24d7b679183916aa73fe604c70d7978bc4 https://github.com/WebKit/WebKit/commit/83cc6f24d7b679183916aa73fe604c70d7978bc4 Author: Luke Warlow Date: 2024-08-20 (Tue, 20 Aug 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/nonce-enforce-blocked.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub.html.sub.headers M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes.html M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes.html.headers M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/support/worker-with-script-src-none-set-timeout.js M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-data-set-timeout.sub-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-data-set-timeout.sub.html M LayoutTests/platform/ios/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt M LayoutTests/platform/mac/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt Log Message: --- Re-import content-security-policy/script-src WPT https://bugs.webkit.org/show_bug.cgi?id=278376 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/2eb5c22fba7e20f805a7bd5decebe1e404d7a810 * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/nonce-enforce-blocked.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub.html.sub.headers: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes.html: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-strict_dynamic_hashes.html.headers: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/support/worker-with-script-src-none-set-timeout.js: (typeof.SharedWorkerGlobalScope.string_appeared_here.port.onmessage): (typeof.SharedWorkerGlobalScope.string_appeared_here.onconnect): * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-data-set-timeout.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/worker-data-set-timeout.sub.html: * LayoutTests/platform/mac/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-sri_hash.sub-expected.txt: Canonical link: https://commits.webkit.org/282509@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7953dd: Re-sync Trusted Types WPTs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7953dd8cab7b616e55c21183c7c97d0cd8fcd76a https://github.com/WebKit/WebKit/commit/7953dd8cab7b616e55c21183c7c97d0cd8fcd76a Author: Luke Warlow Date: 2024-07-30 (Tue, 30 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-svg-script-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-svg-script-element.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/resources/block-text-node-insertion.js A LayoutTests/imported/w3c/web-platform-tests/trusted-types/resources/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/WorkerGlobalScope-eval.https.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-set-href.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/w3c-import.log A LayoutTests/platform/glib/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt Log Message: --- Re-sync Trusted Types WPTs https://bugs.webkit.org/show_bug.cgi?id=277257 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/1d24c38ca30445130c8f54642a55cd0512140d30 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-svg-script-element-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-svg-script-element.html: Copied from LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element.html. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/resources/block-text-node-insertion.js: Added. (string_appeared_here.checkMessage.): (string_appeared_here.checkMessage): * LayoutTests/imported/w3c/web-platform-tests/trusted-types
[webkit-changes] [WebKit/WebKit] 0446b6: XMLDocumentParser incorrectly treated as an API ch...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0446b6ec9aaa9a013071c69981e8df7c3a533f9b https://github.com/WebKit/WebKit/commit/0446b6ec9aaa9a013071c69981e8df7c3a533f9b Author: Luke Warlow Date: 2024-07-29 (Mon, 29 Jul 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt M Source/WebCore/xml/parser/XMLDocumentParser.cpp Log Message: --- XMLDocumentParser incorrectly treated as an API change by script elements https://bugs.webkit.org/show_bug.cgi?id=274519 Reviewed by Ryosuke Niwa. The XMLDocumentParser acts as an API when appending leaf text nodes. This is needed for the SVGTRefElement which relies on mutation events. This patch changes the code to correctly call parserAppendData for XHTML documents. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt: * Source/WebCore/xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::updateLeafTextNode): Canonical link: https://commits.webkit.org/281494@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10507b: Remove trusted types enforcement from DOM node APIs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10507bcb292c24fee4a4dee3fd04edb3a338fe83 https://github.com/WebKit/WebKit/commit/10507bcb292c24fee4a4dee3fd04edb3a338fe83 Author: Luke Warlow Date: 2024-07-24 (Wed, 24 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments.html M Source/WebCore/dom/ChildNode.idl M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/ContainerNode.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/dom/ParentNode.idl M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h Log Message: --- Remove trusted types enforcement from DOM node APIs https://bugs.webkit.org/show_bug.cgi?id=276881 Reviewed by Ryosuke Niwa. The enforcement of Trusted Types in various node manipulation APIs in DOM was based on a previous model for protecting script elements. This patch removes it as its not needed. See https://github.com/whatwg/dom/pull/1299 and https://github.com/w3c/trusted-types/issues/537 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments.html. * Source/WebCore/dom/ChildNode.idl: * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::append): (WebCore::ContainerNode::prepend): (WebCore::ContainerNode::replaceChildren): * Source/WebCore/dom/ContainerNode.h: * Source/WebCore/dom/Node.cpp: (WebCore::nodeSetPreTransformedFromNodeOrStringVector): (WebCore::Node::convertNodesOrStringsIntoNode): (WebCore::Node::convertNodesOrStringsIntoNodeVector): (WebCore::Node::before): (WebCore::Node::after): (WebCore::Node::replaceWith): (WebCore::nodeSetPreTransformedFromNodeOrStringOrTrustedScriptVector): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNode): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNodeVector): Deleted. * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ParentNode.idl: * Source/WebCore/dom/TrustedType.cpp: (WebCore::processNodeOrStringAsTrustedType): Deleted. * Source/WebCore/dom/TrustedType.h: Canonical link: https://commits.webkit.org/281285@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c973b: Implement new dialog initial focus algorithm
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c973b21d0a469cd1f875e7e3b1ed0d53eda193b https://github.com/WebKit/WebKit/commit/0c973b21d0a469cd1f875e7e3b1ed0d53eda193b Author: Luke Warlow Date: 2024-07-22 (Mon, 22 Jul 2024) Changed paths: M LayoutTests/fast/layers/layer-order-after-top-layer.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/child-sequential-focus-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-previous-iframe.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/show-modal-focusing-steps-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt M Source/WebCore/dom/Element.cpp M Source/WebCore/html/HTMLDialogElement.cpp M Source/WebCore/html/HTMLDialogElement.h Log Message: --- Implement new dialog initial focus algorithm https://bugs.webkit.org/show_bug.cgi?id=250795 Reviewed by Tim Nguyen. Updates the dialog focusing steps and the focus delegate steps to match latest spec. Spec PR: https://github.com/whatwg/html/pull/8199 * LayoutTests/fast/layers/layer-order-after-top-layer.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/child-sequential-focus-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-previous-iframe.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/show-modal-focusing-steps-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-initial-focus.html: Removed. These tests no longer exist in upstream WPT repo. * Source/WebCore/dom/Element.cpp: (WebCore::Element::findFocusDelegateForTarget): * Source/WebCore/html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::runFocusingSteps): (WebCore::HTMLDialogElement::supportsFocus const): * Source/WebCore/html/HTMLDialogElement.h: Canonical link: https://commits.webkit.org/281215@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ef778: Trusted Types violation sample clips incorrectly
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ef7784b36a8d052bdb3272fd5a04c9f36b421fd https://github.com/WebKit/WebKit/commit/3ef7784b36a8d052bdb3272fd5a04c9f36b421fd Author: Luke Warlow Date: 2024-07-03 (Wed, 03 Jul 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.h Log Message: --- Trusted Types violation sample clips incorrectly https://bugs.webkit.org/show_bug.cgi?id=275392 Reviewed by Darin Adler. This patch follows the spec for sample truncation in trusted types. Spec: https://w3c.github.io/trusted-types/dist/spec/#should-block-sink-type-mismatch * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMissingTrustedTypesForSinkGroup const): (WebCore::ContentSecurityPolicy::reportViolation const): * Source/WebCore/page/csp/ContentSecurityPolicy.h: Canonical link: https://commits.webkit.org/280638@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3e88f: Trusted Types default policy is wrongly collected ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3e88fd786923be81497db3126e376412e138057 https://github.com/WebKit/WebKit/commit/d3e88fd786923be81497db3126e376412e138057 Author: Luke Warlow Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A LayoutTests/fast/html/trusted-types-default-policy-gc-expected.txt A LayoutTests/fast/html/trusted-types-default-policy-gc.html M Source/WebCore/dom/TrustedTypePolicy.idl Log Message: --- Trusted Types default policy is wrongly collected by GC https://bugs.webkit.org/show_bug.cgi?id=275951 Reviewed by Justin Michaud. This adds a missing GenerateIsReachable to the TrustedTypePolicy.idl * LayoutTests/fast/html/trusted-types-default-policy-gc-expected.txt: Added. * LayoutTests/fast/html/trusted-types-default-policy-gc.html: Added. * Source/WebCore/dom/TrustedTypePolicy.idl: Canonical link: https://commits.webkit.org/280573@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce91be: Remove StringContext IDL extended attribute
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce91bea67be00f227f148569046739d756256697 https://github.com/WebKit/WebKit/commit/ce91bea67be00f227f148569046739d756256697 Author: Luke Warlow Date: 2024-06-12 (Wed, 12 Jun 2024) Changed paths: M Source/WebCore/bindings/IDLTypes.h M Source/WebCore/bindings/js/JSDOMConvertStrings.cpp M Source/WebCore/bindings/js/JSDOMConvertStrings.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/IDLAttributes.json M Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp R Source/WebCore/bindings/scripts/test/JS/JSTestStringContext.h M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep R Source/WebCore/bindings/scripts/test/TestStringContext.idl Log Message: --- Remove StringContext IDL extended attribute https://bugs.webkit.org/show_bug.cgi?id=273878 Reviewed by Darin Adler. Removes the StringContext attribute and most of the associated codegen for it. Some code remains in use by the ScheduledAction type used for HTML timers. * Source/WebCore/bindings/IDLTypes.h: * Source/WebCore/bindings/js/JSDOMConvertStrings.cpp: (WebCore::trustedScriptCompliantString): (WebCore::trustedTypeCompliantString): Deleted. * Source/WebCore/bindings/js/JSDOMConvertStrings.h: (WebCore::TrustedStringConverter::convert): * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (IsAnnotatedType): (GetAnnotatedIDLType): (JSValueToNative): * Source/WebCore/bindings/scripts/IDLAttributes.json: * Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl: * Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::jsTestGlobalObject_TestStringContextConstructorGetter): Deleted. * Source/WebCore/bindings/scripts/test/JS/JSTestStringContext.h: Removed. * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestStringContext.idl: Removed. Canonical link: https://commits.webkit.org/279964@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1ae029: Remove Trusted Types enforcement from toggleAttribute
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1ae029b5a34e88b0d89e96f50b70b502d7a47483 https://github.com/WebKit/WebKit/commit/1ae029b5a34e88b0d89e96f50b70b502d7a47483 Author: Luke Warlow Date: 2024-06-12 (Wed, 12 Jun 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-toggleAttribute-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-toggleAttribute.html M Source/WebCore/dom/Element.cpp Log Message: --- Remove Trusted Types enforcement from toggleAttribute https://bugs.webkit.org/show_bug.cgi?id=275352 Reviewed by Darin Adler. The DOM spec PR no longer enforced Trusted Types within toggleAttribute so this removes that from the implementation. See https://github.com/whatwg/dom/pull/1268 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-toggleAttribute-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-toggleAttribute.html: Added. * Source/WebCore/dom/Element.cpp: (WebCore::Element::toggleAttribute): Canonical link: https://commits.webkit.org/279950@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e10551: Unskip trusted types reporting tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e105514fe7efa49a67a766bcdd0fa8e44167b133 https://github.com/WebKit/WebKit/commit/e105514fe7efa49a67a766bcdd0fa8e44167b133 Author: Luke Warlow Date: 2024-06-11 (Tue, 11 Jun 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting.html Log Message: --- Unskip trusted types reporting tests https://bugs.webkit.org/show_bug.cgi?id=275363 Reviewed by Tim Nguyen. This unskips tests related to CSP reporting and trusted types. Some assertions are updated to match latest specs. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-no-unsafe-eval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-report-only.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting.html: Canonical link: https://commits.webkit.org/279940@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfe83d: Update implementation of TT enforcement for docume...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfe83d0fa5bcf6c925c095e765d6fbf57082297e https://github.com/WebKit/WebKit/commit/cfe83d0fa5bcf6c925c095e765d6fbf57082297e Author: Luke Warlow Date: 2024-06-11 (Tue, 11 Jun 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M Source/WebCore/dom/DOMImplementation.cpp M Source/WebCore/dom/Document+HTML.idl M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm Log Message: --- Update implementation of TT enforcement for document.write(ln) https://bugs.webkit.org/show_bug.cgi?id=273819 Reviewed by Darin Adler. This patch switches document.write and writeln to use a union IDL type and single call to default policy. See whatwg/html#10328 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt: * Source/WebCore/dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument): * Source/WebCore/dom/Document+HTML.idl: * Source/WebCore/dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): * Source/WebCore/dom/Document.h: * Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm: (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): Canonical link: https://commits.webkit.org/279904@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dec2a0: Re-import showPicker tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dec2a0e1021a8ee3720d64a32ccfbf3c26231fe9 https://github.com/WebKit/WebKit/commit/dec2a0e1021a8ee3720d64a32ccfbf3c26231fe9 Author: Luke Warlow Date: 2024-06-10 (Mon, 10 Jun 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/click-user-gesture-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/click-user-gesture.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-being-cv-hidden-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-being-cv-hidden.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-being-rendered-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-being-rendered.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker
[webkit-changes] [WebKit/WebKit] 7a4725: Implement trusted types enforcement on eval
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a4725b0e7299c17437ca3c94836d430bd741aac https://github.com/WebKit/WebKit/commit/7a4725b0e7299c17437ca3c94836d430bd741aac Author: Luke Warlow Date: 2024-05-29 (Wed, 29 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-importScripts-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/WorkerGlobalScope-eval.https.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-expected.txt M Source/JavaScriptCore/API/JSAPIGlobalObject.cpp M Source/JavaScriptCore/API/JSAPIGlobalObject.mm M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/GlobalObjectMethodTable.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp M Source/WebCore/bindings/js/JSDOMGlobalObject.h M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/JSDOMWindowBase.h M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebCore/bindings/js/ScriptController.h M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/EmptyScriptExecutionContext.h M Source/WebCore/dom/ScriptExecutionContext.h M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h M Source/WebCore/workers/WorkerOrWorkletScriptController.cpp M Source/WebCore/workers/WorkerOrWorkletScriptController.h Log Message: --- Implement trusted types enforcement on eval https://bugs.webkit.org/show_bug.cgi?id=273185 Reviewed by Darin Adler and Justin Michaud. This patch introduces a new canCompileStrings function to the global object method table. This function is used in eval for enforcement of trusted types. It also updates the associated tests to match the latest spec. A follow up patch will update the Function constructor to use this. See https://tc39.es/proposal-dynamic-code-brand-checks * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-importScripts-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/WorkerGlobalScope-eval.https.js: * LayoutTests/imported/w3c/web
[webkit-changes] [WebKit/WebKit] 173a8f: Re-import trusted-types WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 173a8f84a49c3d30b630ed5b7033d1f2469c260a https://github.com/WebKit/WebKit/commit/173a8f84a49c3d30b630ed5b7033d1f2469c260a Author: Luke Warlow Date: 2024-05-25 (Sat, 25 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/w3c-import.log Log Message: --- Re-import trusted-types WPT tests https://bugs.webkit.org/show_bug.cgi?id=274644 Reviewed by Darin Adler. Upstream Commit: https://github.com/web-platform-tests/wpt/commit/fd90ede0aab2c3cd2f3736822f638b9f24bee3a5 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/w3c-import.log: Canonical link: https://commits.webkit.org/279324@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ae49b: Re-sync WPT's resources/testdriver.js
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ae49b1e2fa6471627ca69cc04b47b630666f12e https://github.com/WebKit/WebKit/commit/7ae49b1e2fa6471627ca69cc04b47b630666f12e Author: Luke Warlow Date: 2024-05-25 (Sat, 25 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-close-request-expected.txt M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver.js Log Message: --- Re-sync WPT's resources/testdriver.js https://bugs.webkit.org/show_bug.cgi?id=274621 Reviewed by Tim Nguyen. Upstream Commit: https://github.com/web-platform-tests/wpt/commit/1a6206c84228a17ab23a7e8b02768d1f15655705 * LayoutTests/imported/w3c/web-platform-tests/resources/testdriver.js: (window.test_driver.send_keys): (window.test_driver.get_window_rect): (window.test_driver.set_rph_registration_mode): (window.test_driver.cancel_fedcm_dialog): (window.test_driver.click_fedcm_dialog_button): (window.test_driver.select_fedcm_account): (window.test_driver.get_fedcm_account_list): (window.test_driver.get_fedcm_dialog_title): (window.test_driver.get_fedcm_dialog_type): (window.test_driver.set_fedcm_delay_enabled): (window.test_driver.reset_fedcm_cooldown): (window.test_driver.create_virtual_sensor): (window.test_driver.update_virtual_sensor): (window.test_driver.remove_virtual_sensor): (window.test_driver.get_virtual_sensor_information): (window.test_driver.set_device_posture): (window.test_driver.clear_device_posture): (window.test_driver_internal.async get_window_rect): (window.test_driver_internal.set_rph_registration_mode): (window.test_driver_internal.async cancel_fedcm_dialog): (window.test_driver_internal.async click_fedcm_dialog_button): (window.test_driver_internal.async select_fedcm_account): (window.test_driver_internal.async get_fedcm_account_list): (window.test_driver_internal.async get_fedcm_dialog_title): (window.test_driver_internal.async get_fedcm_dialog_type): (window.test_driver_internal.async set_fedcm_delay_enabled): (window.test_driver_internal.async reset_fedcm_cooldown): (window.test_driver_internal.async create_virtual_sensor): (window.test_driver_internal.async update_virtual_sensor): (window.test_driver_internal.async remove_virtual_sensor): (window.test_driver_internal.async get_virtual_sensor_information): (window.test_driver_internal.async set_device_posture): (window.test_driver_internal.async clear_device_posture): * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-close-request-expected.txt: Canonical link: https://commits.webkit.org/279320@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd2092: Re-import inert WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd20922111ccf77bbdafb9a47859c7b1625f0379 https://github.com/WebKit/WebKit/commit/cd20922111ccf77bbdafb9a47859c7b1625f0379 Author: Luke Warlow Date: 2024-05-25 (Sat, 25 May 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/inert/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-expected.txt A LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-flat-tree-expected.txt A LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-flat-tree.html A LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find.html M LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style-expected.txt M LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style.html M LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.html A LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines-around-selection-range-in-contenteditable-expected.txt A LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines-around-selection-range-in-contenteditable.html M LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.html M LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html A LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-fullscreen-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-fullscreen-element.html A LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-003-expected.txt A LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-003.html M LayoutTests/imported/w3c/web-platform-tests/inert/w3c-import.log M LayoutTests/platform/glib/TestExpectations Log Message: --- Re-import inert WPT tests https://bugs.webkit.org/show_bug.cgi?id=274645 Reviewed by Tim Nguyen. Upstream Commit: https://github.com/web-platform-tests/wpt/commit/a48548e4db69188a390d50dc9b2bc40f41c7f356 * LayoutTests/imported/w3c/web-platform-tests/inert/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-flat-tree-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find-flat-tree.html: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-find.html: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-computed-style.html: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.html: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines-around-selection-range-in-contenteditable-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines-around-selection-range-in-contenteditable.html: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.html: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html: * LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-fullscreen-element-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-fullscreen-element.html: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-003-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/inert/w3c-import.log: * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/279315@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b35a1: Replace StringContext IDL extended attribute with ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b35a19d0a910ba3376525d9dae67fe6b4d5016f https://github.com/WebKit/WebKit/commit/3b35a19d0a910ba3376525d9dae67fe6b4d5016f Author: Luke Warlow Date: 2024-05-25 (Sat, 25 May 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-exception-order-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-exception-order.xhtml M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-outerHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-outerHTML.html M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/Document.idl M Source/WebCore/dom/Element+DOMParsing.idl M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/InnerHTML.idl M Source/WebCore/dom/Range+DOMParsing.idl M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/Range.h M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h M Source/WebCore/html/HTMLIFrameElement.cpp M Source/WebCore/html/HTMLIFrameElement.h M Source/WebCore/html/HTMLIFrameElement.idl M Source/WebCore/workers/Worker.cpp M Source/WebCore/workers/Worker.h M Source/WebCore/workers/Worker.idl M Source/WebCore/workers/WorkerGlobalScope.cpp M Source/WebCore/workers/WorkerGlobalScope.h M Source/WebCore/workers/WorkerGlobalScope.idl M Source/WebCore/workers/service/ServiceWorkerContainer.cpp M Source/WebCore/workers/service/ServiceWorkerContainer.h M Source/WebCore/workers/service/ServiceWorkerContainer.idl M Source/WebCore/workers/shared/SharedWorker.cpp M Source/WebCore/workers/shared/SharedWorker.h M Source/WebCore/workers/shared/SharedWorker.idl M Source/WebCore/xml/DOMParser.cpp M Source/WebCore/xml/DOMParser.h M Source/WebCore/xml/DOMParser.idl Log Message: --- Replace StringContext IDL extended attribute with union types https://bugs.webkit.org/show_bug.cgi?id=273412 Reviewed by Darin Adler. This patch replaces most usages of the StringContext IDL extended attribute, with union types and updates to the callsites to do the trusted type enforcement. Follow up patches will address HTML timer functions, Document write(ln) and the StringContext code generator changes. * Source/WebCore/dom/Document+HTML.idl: * Source/WebCore/dom/Document.cpp: (WebCore::Document::parseHTMLUnsafe): (WebCore::Document::write): (WebCore::Document::writeln): * Source/WebCore/dom/Document.h: * Source/WebCore/dom/Document.idl: * Source/WebCore/dom/Element+DOMParsing.idl: * Source/WebCore/dom/Element.cpp: (WebCore::Element::setHTMLUnsafe): (WebCore::Element::setOuterHTML): (WebCore::Element::setInnerHTML): (WebCore::Element::insertAdjacentHTML): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/InnerHTML.idl: * Source/WebCore/dom/Range+DOMParsing.idl: * Source/WebCore/dom/Range.cpp: (WebCore::Range::createContextualFragment): * Source/WebCore/dom/Range.h: * Source/WebCore/dom/ShadowRoot.cpp: (WebCore::ShadowRoot::setHTMLUnsafe): (WebCore::ShadowRoot::setInnerHTML): * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/TrustedType.cpp: (WebCore::trustedTypeCompliantString): * Source/WebCore/dom/TrustedType.h: * Source/WebCore/html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::srcdoc const): (WebCore::HTMLIFrameElement::setSrcdoc): * Source/WebCore/html/HTMLIFrameElement.h: * Source/WebCore/html/HTMLIFrameElement.idl: * Source/WebCore/workers/Worker.cpp: (WebCore::Worker::create): * Source/WebCore/workers/Worker.h: * Source/WebCore/workers/Worker.idl: * Source/WebCore/workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::importScripts): * Source/WebCore/workers/WorkerGlobalScope.h: * Source/WebCore/workers/WorkerGlobalScope.idl: * Source/WebCore/workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::addRegistration): * Source/WebCore/workers/service/ServiceWorkerContainer.h: * Source/WebCore/workers/service/ServiceWorkerContainer.idl: * Source/WebCore/workers/shared/SharedWorker.cpp: (WebCore::SharedWorker::create): * Source/WebCore/workers/shared/SharedWorker.h: * Source/WebCore/workers/shared/SharedWorker.idl: * Source/WebCore/xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString): * Source/WebCore/xml/DOMParser.h: * Source/WebCore/xml/DOMParser.idl: * LayoutTests/imported/w3c/web-platform-tests/trusted-types
[webkit-changes] [WebKit/WebKit] c31d9c: Trusted Types fails to protect against a script ed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c31d9c40707d3ec58faee43f7446ac3fbd6c4531 https://github.com/WebKit/WebKit/commit/c31d9c40707d3ec58faee43f7446ac3fbd6c4531 Author: Luke Warlow Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot.html M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptElement.h Log Message: --- Trusted Types fails to protect against a script edited mid-parse https://bugs.webkit.org/show_bug.cgi?id=274253 Reviewed by Darin Adler. This patch adds a new flag to script elements that is triggered if their children are changed by API. This flag is then used to decide whether to accept parsed script elements as trusted. This patch stops parsed scripts working in XHTML documents when TT is enforced. A follow up patch will address that. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/SVGScriptElement-internal-slot.html: Added. * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElement::finishParsingChildren): * Source/WebCore/dom/ScriptElement.h: Canonical link: https://commits.webkit.org/279225@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5e0f9b: Implement eval support for TrustedScript objects
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5e0f9b3cfb2b1ec21b3481b9c09ba763aa32a119 https://github.com/WebKit/WebKit/commit/5e0f9b3cfb2b1ec21b3481b9c09ba763aa32a119 Author: Luke Warlow Date: 2024-05-23 (Thu, 23 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/WorkerGlobalScope-eval.https.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-eval-reporting.html M LayoutTests/platform/wincairo/TestExpectations M Source/JavaScriptCore/API/JSAPIGlobalObject.cpp M Source/JavaScriptCore/API/JSAPIGlobalObject.mm M Source/JavaScriptCore/interpreter/Interpreter.cpp M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/GlobalObjectMethodTable.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp M Source/JavaScriptCore/runtime/OptionsList.h M Source/WebCore/bindings/js/JSDOMWindowBase.cpp M Source/WebCore/bindings/js/JSDOMWindowBase.h M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSShadowRealmGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.cpp M Source/WebCore/bindings/js/JSWorkletGlobalScopeBase.h Log Message: --- Implement eval support for TrustedScript objects https://bugs.webkit.org/show_bug.cgi?id=273184 Reviewed by Ryosuke Niwa and Justin Michaud. This patch introduces a new codeForEval function to the global object method table. The eval code is updated to check if an object has associated code instead of always returning the object. Add test coverage for indirect evals. See https://tc39.es/proposal-dynamic-code-brand-checks/ * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-no-tt.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no-csp-no-tt-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-no
[webkit-changes] [WebKit/WebKit] 708db4: textarea's width calculations aren't fully writing...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 708db469479bb6c79a55f65532177b6964dd49b0 https://github.com/WebKit/WebKit/commit/708db469479bb6c79a55f65532177b6964dd49b0 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt M Source/WebCore/rendering/RenderTextControlMultiLine.cpp Log Message: --- textarea's width calculations aren't fully writing mode aware https://bugs.webkit.org/show_bug.cgi?id=274332 Reviewed by Aditya Keerthi. Updates the width cacluations to take into account writing mode when decided whether to add scrollbar thickness. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt: * Source/WebCore/rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth const): Canonical link: https://commits.webkit.org/279150@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be4cdc: Implement further enforcement of Trusted Types for...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be4cdc9c602803f8505921b2c66f86aa0f392497 https://github.com/WebKit/WebKit/commit/be4cdc9c602803f8505921b2c66f86aa0f392497 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback.html M Source/WebCore/dom/Attr.cpp M Source/WebCore/dom/Attr.h M Source/WebCore/dom/CharacterData.cpp M Source/WebCore/dom/CharacterData.h M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h Log Message: --- Implement further enforcement of Trusted Types for Attributes https://bugs.webkit.org/show_bug.cgi?id=274267 Reviewed by Ryosuke Niwa. This patch adds trusted types enforcement to Attr textContent, value and nodeValue. It also improves error handling for mutating attributes within default policy. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/modify-attributes-in-callback.html: * Source/WebCore/dom/Attr.cpp: (WebCore::Attr::setValue): (WebCore::Attr::setNodeValue): * Source/WebCore/dom/Attr.h: * Source/WebCore/dom/CharacterData.cpp: (WebCore::CharacterData::setNodeValue): * Source/WebCore/dom/CharacterData.h: * Source/WebCore/dom/Element.cpp: (WebCore::Element::validateAttributeIndex const): (WebCore::Element::setAttribute): * Source/WebCore/dom/Element.h: * Source/WebCore/dom/Node.cpp: (WebCore::Node::setNodeValue): (WebCore::Node::setTextContent): * Source/WebCore/dom/Node.h: Canonical link: https://commits.webkit.org/279118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f33204: Implement trusted types enforcement for script ele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f33204d52243ae13948a2dee417d69e25442c2d8 https://github.com/WebKit/WebKit/commit/f33204d52243ae13948a2dee417d69e25442c2d8 Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-expected.txt M Source/WebCore/dom/ScriptElement.cpp M Source/WebCore/dom/ScriptElement.h M Source/WebCore/html/HTMLScriptElement.cpp M Source/WebCore/html/HTMLScriptElement.h M Source/WebCore/svg/SVGScriptElement.cpp M Source/WebCore/svg/SVGScriptElement.h Log Message: --- Implement trusted types enforcement for script elements https://bugs.webkit.org/show_bug.cgi?id=269365 Reviewed by Darin Adler and Ryosuke Niwa. Add script text string to script element. This is used to ensure that script elements can't be manipulated in untrusted ways. See https://w3c.github.io/trusted-types/dist/spec/#htmlscriptelement-script-text and https://w3c.github.io/trusted-types/dist/spec/#slot-value-verification * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-expected.txt: * Source/WebCore/dom/ScriptElement.cpp: (WebCore::ScriptElement::finishParsingChildren): (WebCore::ScriptElement::prepareScript): (WebCore::ScriptElement::setTrustedScriptText): * Source/WebCore/dom/ScriptElement.h: * Source/WebCore/html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::finishParsingChildren): (WebCore::HTMLScriptElement::setTextContent): (WebCore::HTMLScriptElement::setInnerText): * Source/WebCore/html/HTMLScriptElement.h: * Source/WebCore/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::finishParsingChildren): * Source/WebCore/svg/SVGScriptElement.h: Canonical link: https://commits.webkit.org/279117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2e64b: Implement `field-sizing: content` minimum width fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2e64ba96fbed90353cfdea4b0c20a855a6c40bb https://github.com/WebKit/WebKit/commit/c2e64ba96fbed90353cfdea4b0c20a855a6c40bb Author: Luke Warlow Date: 2024-05-22 (Wed, 22 May 2024) Changed paths: A LayoutTests/fast/forms/text/text-field-sizing-caret-expected.txt A LayoutTests/fast/forms/text/text-field-sizing-caret.html A LayoutTests/fast/forms/textarea/textarea-field-sizing-caret-expected.txt A LayoutTests/fast/forms/textarea/textarea-field-sizing-caret.html M Source/WebCore/html/HTMLTextFormControlElement.cpp Log Message: --- Implement `field-sizing: content` minimum width for text caret https://bugs.webkit.org/show_bug.cgi?id=269128 Reviewed by Darin Adler. Updates text control computed style to include a minimum sizing so the caret shows. * LayoutTests/fast/forms/text/text-field-sizing-caret-expected.txt: Added. * LayoutTests/fast/forms/text/text-field-sizing-caret.html: Added. * LayoutTests/fast/forms/textarea/textarea-field-sizing-caret-expected.txt: Added. * LayoutTests/fast/forms/textarea/textarea-field-sizing-caret.html: Added. * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::adjustInnerTextStyle const): Canonical link: https://commits.webkit.org/279115@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8f9c15: Re-import html/rendering/widgets WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f9c15bfec1a7eb65205b586c4c9731ae8774f8d https://github.com/WebKit/WebKit/commit/8f9c15bfec1a7eb65205b586c4c9731ae8774f8d Author: Luke Warlow Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/WEB_FEATURES.yml M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/computed-style-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/computed-style.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-date-baseline-print-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-password-background-suppresses-appearance-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-password-background-suppresses-appearance-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-password-background-suppresses-appearance.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-text-size-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-text-size.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-cols-rows-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-cols-rows.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-001.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/textarea-scrollbar-sizing-002.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/w3c-import.log M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/computed-style-expected.txt Log Message: --- Re-import html/rendering/widgets WPT tests https://bugs.webkit.org/show_bug.cgi?id=274462 Reviewed by Tim Nguyen. Upstream commit: web-platform-tests/wpt@4593ea7 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/computed-style-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/computed-style.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/display-none-or-contents.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/input-type-button-clip.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-date-baseline-print-expected.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-password-background-suppresses-appearance-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-password-background-suppresses-appearance-ref.html: Added. * LayoutTests/imported
[webkit-changes] [WebKit/WebKit] 4e0e3b: Import close-watcher WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e0e3b849e9f3f82af1c8253da4750ea4da065e2 https://github.com/WebKit/WebKit/commit/4e0e3b849e9f3f82af1c8253da4750ea4da065e2 Author: Luke Warlow Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/close-watcher/META.yml A LayoutTests/imported/w3c/web-platform-tests/close-watcher/abortsignal-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/abortsignal.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/basic-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/basic.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/README.md A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keydown-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keydown.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keypress-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keypress.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keyup-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/keyup.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/not-user-activation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/not-user-activation.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/synthetic-keyboard-event-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/synthetic-keyboard-event.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/esc-key/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/close-watcher/event-properties-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/event-properties.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/frame-removal-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/frame-removal.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/inside-event-listeners-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/inside-event-listeners.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/resources/helpers.js A LayoutTests/imported/w3c/web-platform-tests/close-watcher/resources/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/README.md A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate-preventDefault.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate-preventDefault_CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate-preventDefault_dialog-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate_CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-activate_dialog-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-closerequest-n.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-closerequest-n_CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-closerequest-n_dialog-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-destroy-n.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-destroy-n_CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n-destroy-n_dialog-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n_CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/n_dialog-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nn-CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nn-CloseWatcher.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nn-activate-CloseWatcher-expected.txt A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nn-activate-CloseWatcher.html A LayoutTests/imported/w3c/web-platform-tests/close-watcher/user-activation/nn-activate-dialog-expected.txt A LayoutTests/imported
[webkit-changes] [WebKit/WebKit] e84b70: Update implementation of TT enforcement for docume...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e84b70e7fa81a96f61afc01534992746135fdc8f https://github.com/WebKit/WebKit/commit/e84b70e7fa81a96f61afc01534992746135fdc8f Author: Luke Warlow Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html M Source/WebCore/dom/Document+HTML.idl M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h Log Message: --- Update implementation of TT enforcement for document.write(ln) https://bugs.webkit.org/show_bug.cgi?id=273819 Reviewed by Ryosuke Niwa. This patch switches document.write and writeln to use a union IDL type and single call to default policy. This brings it close to chromium behaviour. See https://github.com/whatwg/html/pull/10328 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write.html: * Source/WebCore/dom/Document+HTML.idl: * Source/WebCore/dom/Document.cpp: (WebCore::Document::write): (WebCore::Document::writeln): * Source/WebCore/dom/Document.h: Canonical link: https://commits.webkit.org/278501@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e8f92: Implement trusted types integration with script el...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e8f9225aef76436cdf18015c6037d5810d87fae https://github.com/WebKit/WebKit/commit/4e8f9225aef76436cdf18015c6037d5810d87fae Author: Luke Warlow Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h M Source/WebCore/html/HTMLScriptElement.cpp M Source/WebCore/html/HTMLScriptElement.h M Source/WebCore/html/HTMLScriptElement.idl M Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm Log Message: --- Implement trusted types integration with script elements IDL https://bugs.webkit.org/show_bug.cgi?id=269718 Reviewed by Ryosuke Niwa and Darin Adler. Implement shadow properties for textContent and innerText on HTMLScriptElement. Implement enforcement on src and text as well as the shadowed properties. This doesn't implement any changes to the prepareScript function that will be addressed in a follow up. Spec: https://w3c.github.io/trusted-types/dist/spec/#enforcement-in-scripts * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * Source/WebCore/dom/TrustedType.cpp: (WebCore::trustedTypeCompliantString): * Source/WebCore/dom/TrustedType.h: * Source/WebCore/html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::setText): (WebCore::HTMLScriptElement::setTextContent): (WebCore::HTMLScriptElement::setInnerText): (WebCore::HTMLScriptElement::src const): (WebCore::HTMLScriptElement::setSrc): (WebCore::HTMLScriptElement::addSubresourceAttributeURLs const): * Source/WebCore/html/HTMLScriptElement.h: * Source/WebCore/html/HTMLScriptElement.idl: * Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm: (-[DOMHTMLScriptElement setText:]): Canonical link: https://commits.webkit.org/278343@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2da25a: Unskip html/semantics/popover-light-dismiss.html WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2da25afcddf733555a446fc6851676dbe23dfea4 https://github.com/WebKit/WebKit/commit/2da25afcddf733555a446fc6851676dbe23dfea4 Author: Luke Warlow Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M LayoutTests/platform/mac-ventura-wk2/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- Unskip html/semantics/popover-light-dismiss.html WPT https://bugs.webkit.org/show_bug.cgi?id=273141 Reviewed by Tim Nguyen. This patch splits the "Scrolling withing" subtest from the popover-light-dismiss.html WPT into its own file. It also unskips the main light dimiss test on all platforms. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-scroll-within.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: * LayoutTests/platform/mac-ventura-wk2/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt: LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/278325@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 812621: Re-import html/semantics/popovers WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 812621486d61df6bb975c53792858d9122276bfd https://github.com/WebKit/WebKit/commit/812621486d61df6bb975c53792858d9122276bfd Author: Luke Warlow Date: 2024-04-24 (Wed, 24 Apr 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-and-svg-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-appearance-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-backdrop-appearance-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-dialog-appearance-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hover-crash-hang.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none-ref.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-open-overflow-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking-context-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-nesting.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/w3c-import.log M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- Re-import html/semantics/popovers WPT https://bugs.webkit.org/show_bug.cgi?id=273136 Reviewed by Tim Nguyen. Upstream commit: https://github.com/web-platform-tests/wpt/commit/43ae6cd615fad8cd6df2cade33ad48bfb9f285cb * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-ref.html: Removed. * LayoutTests/imported/w3c/web-platform-tests
[webkit-changes] [WebKit/WebKit] b538c7: LinkText and VisitedText system colors doesn't obe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b538c70c4d25f6ed285f69728f78a54cb4b9ad14 https://github.com/WebKit/WebKit/commit/b538c70c4d25f6ed285f69728f78a54cb4b9ad14 Author: Luke Warlow Date: 2024-04-09 (Tue, 09 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/mac/RenderThemeMac.mm Log Message: --- LinkText and VisitedText system colors doesn't obey color scheme https://bugs.webkit.org/show_bug.cgi?id=272299 Reviewed by Tim Nguyen. Change LinkText and VisitedText CSS system colors to use a different value when the used color scheme is dark. The chosen colors are the same as `-webkit-link` and are what is expected by WPT tests. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-color/system-color-support-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-color/system-color-consistency-expected.txt: * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor const): * Source/WebCore/rendering/mac/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemColor const): Canonical link: https://commits.webkit.org/277259@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18692f: Remove trusted types enforcement from object and e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18692f5a98be6dcc54fca171bd358e136660ec4b https://github.com/WebKit/WebKit/commit/18692f5a98be6dcc54fca171bd358e136660ec4b Author: Luke Warlow Date: 2024-04-08 (Mon, 08 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node.html M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M Source/WebCore/dom/TrustedTypePolicyFactory.cpp M Source/WebCore/html/HTMLEmbedElement.idl M Source/WebCore/html/HTMLObjectElement.idl Log Message: --- Remove trusted types enforcement from object and embed elements https://bugs.webkit.org/show_bug.cgi?id=271824 Reviewed by Anne van Kesteren. This removes TT coverage of object and embed elements. These no longer need protecting as they're not XSS sinks anymore. Also updates the test suite to remove coverage of them. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node.html: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLEl
[webkit-changes] [WebKit/WebKit] 3fe3c3: Implement GC handling for trusted types API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fe3c3955914a08964b9c840e2750350e1e8b7af https://github.com/WebKit/WebKit/commit/3fe3c3955914a08964b9c840e2750350e1e8b7af Author: Luke Warlow Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj A Source/WebCore/bindings/js/JSTrustedTypePolicyCustom.cpp A Source/WebCore/bindings/js/JSTrustedTypePolicyFactoryCustom.cpp M Source/WebCore/dom/CreateHTMLCallback.h M Source/WebCore/dom/CreateHTMLCallback.idl M Source/WebCore/dom/CreateScriptCallback.h M Source/WebCore/dom/CreateScriptCallback.idl M Source/WebCore/dom/CreateScriptURLCallback.h M Source/WebCore/dom/CreateScriptURLCallback.idl M Source/WebCore/dom/TrustedTypePolicy.cpp M Source/WebCore/dom/TrustedTypePolicy.h M Source/WebCore/dom/TrustedTypePolicy.idl M Source/WebCore/dom/TrustedTypePolicyFactory.cpp M Source/WebCore/dom/TrustedTypePolicyFactory.h M Source/WebCore/dom/TrustedTypePolicyFactory.idl M Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.cpp M Source/WebCore/workers/WorkerGlobalScope.cpp Log Message: --- Implement GC handling for trusted types API https://bugs.webkit.org/show_bug.cgi?id=268419 Reviewed by Ryosuke Niwa. This patch implements visitAdditionalChildren for TrustedTypePolicy calling visitJSFunction on callbacks. TrustedTypePolicy is also an opaque root which is added inside of TrustedTypePolicyFactory visitAdditionalChildren. It also marks TrustedTypePolicyFactory as being reachable via scriptExecutionContext. The trusted type callbacks are now weak callbacks. The WorkerGlobalScopeTrustedTypes supplement is now also removed in WorkerGlobalScope::prepareForDestruction, this is so that teardown happens in the right order. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/JSTrustedTypePolicyCustom.cpp: Added. (WebCore::JSTrustedTypePolicy::visitAdditionalChildren): * Source/WebCore/bindings/js/JSTrustedTypePolicyFactoryCustom.cpp: Added. (WebCore::JSTrustedTypePolicyFactory::visitAdditionalChildren): * Source/WebCore/dom/CreateHTMLCallback.h: * Source/WebCore/dom/CreateHTMLCallback.idl: * Source/WebCore/dom/CreateScriptCallback.h: * Source/WebCore/dom/CreateScriptCallback.idl: * Source/WebCore/dom/CreateScriptURLCallback.h: * Source/WebCore/dom/CreateScriptURLCallback.idl: * Source/WebCore/dom/TrustedTypePolicy.cpp: (WebCore::TrustedTypePolicy::TrustedTypePolicy): (WebCore::TrustedTypePolicy::getPolicyValue): (WebCore::root): * Source/WebCore/dom/TrustedTypePolicy.h: (WebCore::TrustedTypePolicy::options const): (WebCore::TrustedTypePolicy::WTF_RETURNS_LOCK): * Source/WebCore/dom/TrustedTypePolicy.idl: * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: (WebCore::TrustedTypePolicyFactory::create): (WebCore::TrustedTypePolicyFactory::TrustedTypePolicyFactory): * Source/WebCore/dom/TrustedTypePolicyFactory.h: (WebCore::TrustedTypePolicyFactory::defaultPolicyConcurrently const): * Source/WebCore/dom/TrustedTypePolicyFactory.idl: * Source/WebCore/dom/WindowOrWorkerGlobalScopeTrustedTypes.cpp: (WebCore::DOMWindowTrustedTypes::trustedTypes const): (WebCore::WorkerGlobalScopeTrustedTypes::trustedTypes const): * Source/WebCore/workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::prepareForDestruction): Canonical link: https://commits.webkit.org/276974@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bb9ca2: Implement trusted types integration with DOM node ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb9ca28dcac916cb783096b485f9c589b147f21d https://github.com/WebKit/WebKit/commit/bb9ca28dcac916cb783096b485f9c589b147f21d Author: Luke Warlow Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M Source/WebCore/dom/ChildNode.idl M Source/WebCore/dom/ContainerNode.cpp M Source/WebCore/dom/ContainerNode.h M Source/WebCore/dom/Node.cpp M Source/WebCore/dom/Node.h M Source/WebCore/dom/ParentNode.idl M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h Log Message: --- Implement trusted types integration with DOM node conversion APIs https://bugs.webkit.org/show_bug.cgi?id=270435 Reviewed by Ryosuke Niwa. Update the "converting nodes into a node" algorithm to integrate Trusted Types protection. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt: * Source/WebCore/dom/ChildNode.idl: * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::append): (WebCore::ContainerNode::prepend): (WebCore::ContainerNode::replaceChildren): * Source/WebCore/dom/ContainerNode.h: * Source/WebCore/dom/Node.cpp: (WebCore::nodeSetPreTransformedFromNodeOrStringOrTrustedScriptVector): (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNode): (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNodeVector): (WebCore::Node::before): (WebCore::Node::after): (WebCore::Node::replaceWith): (WebCore::nodeSetPreTransformedFromNodeOrStringVector): Deleted. (WebCore::Node::convertNodesOrStringsIntoNode): Deleted. (WebCore::Node::convertNodesOrStringsIntoNodeVector): Deleted. * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ParentNode.idl: * Source/WebCore/dom/TrustedType.cpp: (WebCore::processNodeOrStringAsTrustedType): * Source/WebCore/dom/TrustedType.h: Canonical link: https://commits.webkit.org/276942@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3c491: Implement trusted types integration with setTimeou...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3c49184f6ef80a04d39e1a9929e6cbb63d274e7 https://github.com/WebKit/WebKit/commit/e3c49184f6ef80a04d39e1a9929e6cbb63d274e7 Author: Luke Warlow Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval-expected.txt M Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h M Source/WebCore/bindings/js/JSDOMConvertStrings.cpp M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestScheduledAction.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestScheduledAction.h M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep A Source/WebCore/bindings/scripts/test/TestScheduledAction.idl Log Message: --- Implement trusted types integration with setTimeout and setInterval https://bugs.webkit.org/show_bug.cgi?id=267692 Reviewed by Anne van Kesteren and Darin Adler. Make use of StringContext IDL adaptor for TrustedScript within the ScheduledAction IDL converter. Includes fix InterfaceName attribute within StringContext IDL generator code. Also handles exceptions in IDL string conversion code within trustedTypeCompliantString converter. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval-expected.txt: * Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h: (WebCore::Converter::convert): * Source/WebCore/bindings/js/JSDOMConvertStrings.cpp: (WebCore::trustedTypeCompliantString): * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (JSValueToNative): * Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl: * Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp: (WebCore::jsTestGlobalObject_TestScheduledActionRealConstructorGetter): (WebCore::JSC_DEFINE_CUSTOM_GETTER): * Source/WebCore/bindings/scripts/test/JS/JSTestScheduledAction.cpp: Added. (WebCore::JSTestScheduledActionDOMConstructor::prototypeForStructure): (WebCore::JSTestScheduledActionDOMConstructor::initializeProperties): (WebCore::JSTestScheduledActionPrototype::finishCreation): (WebCore::JSTestScheduledAction::JSTestScheduledAction): (WebCore::JSTestScheduledAction::createPrototype): (WebCore::JSTestScheduledAction::prototype): (WebCore::JSTestScheduledAction::getConstructor): (WebCore::JSTestScheduledAction::destroy): (WebCore::JSC_DEFINE_CUSTOM_GETTER): (WebCore::jsTestScheduledActionPrototypeFunction_methodBody): (WebCore::JSC_DEFINE_HOST_FUNCTION): (WebCore::JSTestScheduledAction::subspaceForImpl): (WebCore::JSTestScheduledAction::analyzeHeap): (WebCore::JSTestScheduledActionOwner::isReachableFromOpaqueRoots): (WebCore::JSTestScheduledActionOwner::finalize): (WebCore::toJSNewlyCreated): (WebCore::toJS): (WebCore::JSTestScheduledAction::toWrapped): * Source/WebCore/bindings/scripts/test/JS/JSTestScheduledAction.h: Added. (WebCore::JSTestScheduledAction::create): (WebCore::JSTestScheduledAction::createStructure): (WebCore::JSTestScheduledAction::subspaceFor): (WebCore::wrapperOwner): (WebCore::wrapperKey): (WebCore::toJS): (WebCore::toJSNewlyCreated): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestScheduledAction.idl: Copied from Source/WebCore/bindings/js/JSDOMConvertScheduledAction.h. Canonical link: https://commits.webkit.org/276934@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e2d6c: Re-sync trusted types WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e2d6c1b4f4b8352acd17a5623f9ab378baadb3e https://github.com/WebKit/WebKit/commit/2e2d6c1b4f4b8352acd17a5623f9ab378baadb3e Author: Luke Warlow Date: 2024-03-28 (Thu, 28 Mar 2024) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.tentative.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-parseHTMLUnsafe-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-parseHTMLUnsafe.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setHTMLUnsafe-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setHTMLUnsafe.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/idlharness.tentative.window.js.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/idlharness.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/idlharness.window.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/idlharness.window.js M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/helper.sub.js R LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-from-literal-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-from-literal.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-from-literal.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-from-literal.tentative.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/w3c-import.log Log Message: --- Re-sync trusted types WPT tests https://bugs.webkit.org/show_bug.cgi?id=271316 Reviewed by Anne van Kesteren. Upstream commit: https://github.com/web-platform-tests/wpt/commit/577d22542f1321249653d695626f05aa42320ff7 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.html. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-parseHTMLUnsafe-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-parseHTMLUnsafe.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setHTMLUnsafe-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setHTMLUnsafe.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-ShadowRoot-setHTMLUnsafe.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types
[webkit-changes] [WebKit/WebKit] 40089a: TrustedTypesPolicyFactory getPropertyType returns ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40089a95fed02486c5a38b2c831b85dca7f09e1c https://github.com/WebKit/WebKit/commit/40089a95fed02486c5a38b2c831b85dca7f09e1c Author: Luke Warlow Date: 2024-03-28 (Thu, 28 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt M Source/WebCore/dom/TrustedTypePolicyFactory.cpp Log Message: --- TrustedTypesPolicyFactory getPropertyType returns TrustedScript for event handlers https://bugs.webkit.org/show_bug.cgi?id=271822 Reviewed by Anne van Kesteren. Previously getPropertyType would return TrustedScript for event handlers. This patch fixes it so that it correctly returns null. Only getAttributeType should handle event handlers. Also adds a test to check for this. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt: * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: (WebCore::TrustedTypePolicyFactory::getPropertyType const): Canonical link: https://commits.webkit.org/276788@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8b3a40: Implement invoke defaults for popover
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8b3a40134afa148adf04eeae3ca908ce0f5a1c40 https://github.com/WebKit/WebKit/commit/8b3a40134afa148adf04eeae3ca908ce0f5a1c40 Author: Luke Warlow Date: 2024-03-26 (Tue, 26 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Element.h M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFormControlElement.cpp Log Message: --- Implement invoke defaults for popover https://bugs.webkit.org/show_bug.cgi?id=263513 Reviewed by Darin Adler. This adds the `handleInvokeInternal` logic to toggle popovers. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt: * Source/WebCore/dom/Document.cpp: (WebCore::Document::handlePopoverLightDismiss): * Source/WebCore/dom/Element.h: (WebCore::Element::handleInvokeInternal): * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::handleInvokeInternal): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::handleInvokeAction): Canonical link: https://commits.webkit.org/276694@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79b128: [ Sonoma wk1 ] 5 dialog element tests are constant...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79b1286a002bc683a3d4a49495ece635ec674751 https://github.com/WebKit/WebKit/commit/79b1286a002bc683a3d4a49495ece635ec674751 Author: Luke Warlow Date: 2024-03-19 (Tue, 19 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-stacking-order.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-generated-content.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-display-none.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-nesting.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking-dynamic.html M LayoutTests/platform/mac/TestExpectations Log Message: --- [ Sonoma wk1 ] 5 dialog element tests are constant failure https://bugs.webkit.org/show_bug.cgi?id=270263 Reviewed by Tim Nguyen. Add some fuzziness to deal with 0.01% failures. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-stacking-order.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-generated-content.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-display-none.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-nesting.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking-dynamic.html: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276343@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6b7973: Implement getAttributeType and getPropertyType fun...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6b79732d9cb95141673959f934689029a8cf6801 https://github.com/WebKit/WebKit/commit/6b79732d9cb95141673959f934689029a8cf6801 Author: Luke Warlow Date: 2024-03-18 (Mon, 18 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-namespace-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M Source/WebCore/dom/TrustedTypePolicyFactory.cpp M Source/WebCore/dom/TrustedTypePolicyFactory.h M Source/WebCore/dom/TrustedTypePolicyFactory.idl Log Message: --- Implement getAttributeType and getPropertyType functions on TrustedTypePolicyFactory https://bugs.webkit.org/show_bug.cgi?id=270080 Reviewed by Ryosuke Niwa and Darin Adler. Implements getAttributeType and getPropertyType metadata functions. Also adds missing test coverage for SVGScript href attribute handling. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-namespace-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-svg.html: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: (WebCore::TrustedTypePolicyFactory::getAttributeType const): (WebCore::TrustedTypePolicyFactory::getPropertyType const): * Source/WebCore/dom/TrustedTypePolicyFactory.idl: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt: Added. Canonical link: https://commits.webkit.org/276310@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c28bce: Implement the `require-trusted-types-for` pre-navi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c28bce0ecd22a5a41b3b0f9c8958be13880e5f64 https://github.com/WebKit/WebKit/commit/c28bce0ecd22a5a41b3b0f9c8958be13880e5f64 Author: Luke Warlow Date: 2024-03-05 (Tue, 05 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-report-only-support.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.html M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-navigation-expected.txt M Source/WebCore/bindings/js/ScriptController.cpp M Source/WebCore/dom/TrustedType.cpp M Source/WebCore/dom/TrustedType.h Log Message: --- Implement the `require-trusted-types-for` pre-navigation check https://bugs.webkit.org/show_bug.cgi?id=267695 Reviewed by Youenn Fablet. When the 'require-trusted-types-for' CSP directive is present javascript URLs are now passed through a default policy or rejected if one doesn't exist. Spec: https://w3c.github.io/trusted-types/dist/spec/#require-trusted-types-for-pre-navigation-check * LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-report-only-support.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/support/navigation-support.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-navigation-expected.txt: * Source/WebCore/bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeJavaScriptURL): * Source/WebCore/dom/TrustedType.cpp: (WebCore::requireTrustedTypesForPreNavigationCheckPasses): * Source/WebCore/dom/TrustedType.h: Canonical link: https://commits.webkit.org/275687@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fc59f: Implement trusted types integration with execCommand
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fc59f12a6f2f4fc8289f4ec367d0944a3a2b4b1 https://github.com/WebKit/WebKit/commit/9fc59f12a6f2f4fc8289f4ec367d0944a3a2b4b1 Author: Luke Warlow Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Document-execCommand-expected.txt M Source/WebCore/dom/Document+HTML.idl M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/TrustedHTML.h Log Message: --- Implement trusted types integration with execCommand https://bugs.webkit.org/show_bug.cgi?id=267690 Reviewed by Youenn Fablet and Ryosuke Niwa. Call trustedTypeCompliantString from within document execCommand when command is insertHTML. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Document-execCommand-expected.txt: * Source/WebCore/dom/Document+HTML.idl: * Source/WebCore/dom/Document.cpp: (WebCore::Document::execCommand): * Source/WebCore/dom/Document.h: * Source/WebCore/dom/TrustedHTML.h: Canonical link: https://commits.webkit.org/275667@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcca5f: Implement field-sizing support for input and textarea
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcca5fc0fa1715d7da3e05cac22fb460a12539f0 https://github.com/WebKit/WebKit/commit/bcca5fc0fa1715d7da3e05cac22fb460a12539f0 Author: Luke Warlow Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt R LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt A LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt R LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt A LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt M Source/WebCore/rendering/RenderTextControl.cpp Log Message: --- Implement field-sizing support for input and textarea https://bugs.webkit.org/show_bug.cgi?id=269125 Reviewed by Aditya Keerthi. Inputs and textareas with field-sizing: content now size based on their content size not intrinsic. This patch does not include the handling for caret width, autofill, or placeholders. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt: Removed. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt: Removed. * LayoutTests/platform/mac-monterey/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Added. * Source/WebCore/rendering/RenderTextControl.cpp
[webkit-changes] [WebKit/WebKit] caf4cd: Implement enforcement of `require-trusted-types-fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: caf4cd7788f1f9bce326f9c5c145ff04e32dad07 https://github.com/WebKit/WebKit/commit/caf4cd7788f1f9bce326f9c5c145ff04e32dad07 Author: Luke Warlow Date: 2024-03-03 (Sun, 03 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-importScripts-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMParser-parseFromString-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-outerHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Range-createContextualFragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/empty-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/empty-default-policy-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-source-file-path-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-svg-script-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/worker-constructor.https-expected.txt M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/IDLTypes.h M Source/WebCore/bindings/js/JSDOMConvertStrings.cpp M Source/WebCore/bindings/js/JSDOMConvertStrings.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/IDLAttributes.json M Source/WebCore/bindings/scripts/test/BindingTestGlobalConstructors.idl M Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestStringContext.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestStringContext.h M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep A Source/WebCore/bindings/scripts/test/TestStringContext.idl M Source/WebCore/dom/Document+HTML.idl M Source/WebCore/dom/Document.idl M Source/WebCore/dom/Element+DOMParsing.idl M Source/WebCore/dom/InnerHTML.idl M Source/WebCore/dom/Range+DOMParsing.idl A Source/WebCore/dom/TrustedType.cpp A Source/WebCore/dom/TrustedType.h M Source/WebCore/dom/TrustedTypePolicy.cpp M Source/WebCore/dom/TrustedTypePolicy.h M Source/WebCore/html/HTMLEmbedElement.idl M Source/WebCore/html/HTMLIFrameElement.idl M Source/WebCore/html/HTMLObjectElement.idl M Source/WebCore/html/HTMLScriptElement.idl M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.h M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h M Source/WebCore/workers/Worker.idl M Source/WebCore/workers/WorkerGlobalScope.idl M Source/WebCore/workers/service/ServiceWorkerContainer.idl M Source/WebCore/workers/shared
[webkit-changes] [WebKit/WebKit] bb7f81: Re-import dialog element WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb7f816988c6ad8bb3b36c145e05c36ae7cb6a45 https://github.com/WebKit/WebKit/commit/bb7f816988c6ad8bb3b36c145e05c36ae7cb6a45 Author: Luke Warlow Date: 2024-02-24 (Sat, 24 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/WEB_FEATURES.yml M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-stacking-order.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-previous-outside.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusability-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusability.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-generated-content.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-display-none.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-nesting.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-remove-popover-attribute-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-remove-popover-attribute-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-remove-popover-attribute.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/top-layer-stacking-dynamic.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log Log Message: --- Re-import dialog element WPT tests https://bugs.webkit.org/show_bug.cgi?id=270017 Reviewed by Anne van Kesteren. Upstream commit: https://github.com/web-platform-tests/wpt/commit/da26ae6760f4034af286c04f2a9ea81239823982 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/WEB_FEATURES.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-stacking-order.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-previous-outside.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-generated-content.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt: * LayoutTests/imported/w3c/web-platform
[webkit-changes] [WebKit/WebKit] 29552d: Re-import popover WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29552da0350d577daa7ff84e5803c7203904caa1 https://github.com/WebKit/WebKit/commit/29552da0350d577daa7ff84e5803c7203904caa1 Author: Luke Warlow Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/fullscreen/api/fullscreen-reordering.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/WEB_FEATURES.yml A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/invoker-show-crash.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/label-in-invoker-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/label-in-invoker.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-change-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display-none.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-idl-property.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-multicol-display-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-multicol-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-multicol-display.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-multicol-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display-expected.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nested-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-expected.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display-ref.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-scroll-display.tentative.html R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-transition.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover
[webkit-changes] [WebKit/WebKit] b1c316: Invokers should work on non-html elements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1c3165a6c3bfac437737539fdbc51cfb395dbae https://github.com/WebKit/WebKit/commit/b1c3165a6c3bfac437737539fdbc51cfb395dbae Author: Luke Warlow Date: 2024-02-18 (Sun, 18 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html M Source/WebCore/dom/Element.h M Source/WebCore/html/HTMLElement.h M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLFormControlElement.h Log Message: --- Invokers should work on non-html elements https://bugs.webkit.org/show_bug.cgi?id=269673 Reviewed by Tim Nguyen. This changes invokers to work on non-HTML elements by changing code to reference Element instead of HTMLElement. This patch also fixes the relevant test as it was wrong. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html: * Source/WebCore/dom/Element.h: (WebCore::Element::handleInvokeInternal): * Source/WebCore/html/HTMLElement.h: (WebCore::HTMLElement::handleInvokeInternal): Deleted. * Source/WebCore/html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::invokeTargetElement const): * Source/WebCore/html/HTMLFormControlElement.h: Canonical link: https://commits.webkit.org/274954@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c186a8: Re-import invoker WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c186a833cb69d41564ab234631537684365c1501 https://github.com/WebKit/WebKit/commit/c186a833cb69d41564ab234631537684365c1501 Author: Luke Warlow Date: 2024-02-18 (Sun, 18 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-fullscreen-behavior.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-fullscreen-behavior.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-generic-eventtarget-crash.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-audio-behavior.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-details-behavior.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-details-behavior.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-video-behavior.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log M LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt M Source/WebCore/dom/InvokeEvent.cpp Log Message: --- Re-import invoker WPT tests https://bugs.webkit.org/show_bug.cgi?id=269670 Reviewed by Tim Nguyen. Upstream commit: web-platform-tests/wpt@32864fa Also fixes an issue where null invokers would be retargeted causing a crash. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-fullscreen-behavior.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-fullscreen-behavior.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-generic-eventtarget-crash.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-audio-behavior.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-details-behavior.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-details-behavior.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-video-behavior.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/w3c-import.log: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-on-popover-behavior.tentative-expected.txt: * Source/WebCore/dom/InvokeEvent.cpp: (WebCore::InvokeEvent::invoker const): Canonical link: https://commits.webkit.org/274953@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40981b: Implement field-sizing support for select
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40981b4a16b926588c4728336922676a52c2c8c3 https://github.com/WebKit/WebKit/commit/40981b4a16b926588c4728336922676a52c2c8c3 Author: Luke Warlow Date: 2024-02-11 (Sun, 11 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt M Source/WebCore/rendering/RenderMenuList.cpp Log Message: --- Implement field-sizing support for select https://bugs.webkit.org/show_bug.cgi?id=269124 Reviewed by Alan Baradlay. Selects with "field-sizing: content" applied now correctly size based on the selected options width. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Removed. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Removed. * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::computeIntrinsicLogicalWidths const): (RenderMenuList::computePreferredLogicalWidths): Canonical link: https://commits.webkit.org/274443@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf51aa: Implement field-sizing support for listboxes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf51aaac17a75e4035b00844e53fdfcf33cff3da https://github.com/WebKit/WebKit/commit/cf51aaac17a75e4035b00844e53fdfcf33cff3da Author: Luke Warlow Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt A LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt A LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt M Source/WebCore/rendering/RenderListBox.cpp Log Message: --- Implement field-sizing support for listboxes https://bugs.webkit.org/show_bug.cgi?id=269069 Reviewed by Aditya Keerthi. Selects with "field-sizing: content" applied now correctly size based on their contents rather than the size attribute when in listbox mode. Listbox mode is used when the size attribute is greater than 1 or the multiple attribute is applied. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added. * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Added. * Source/WebCore/rendering/RenderListBox.cpp: (WebCore::RenderListBox::size const): Canonical link: https://commits.webkit.org/274414@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 378cf7: Implement parsing support for `field-sizing`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 378cf7aa646dbec394d4fac997df4193b3dbe2cb https://github.com/WebKit/WebKit/commit/378cf7aa646dbec394d4fac997df4193b3dbe2cb Author: Luke Warlow Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSPrimitiveValueMappings.h M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleConstants.cpp M Source/WebCore/rendering/style/RenderStyleConstants.h M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp M Source/WebCore/rendering/style/StyleRareNonInheritedData.h Log Message: --- Implement parsing support for `field-sizing` https://bugs.webkit.org/show_bug.cgi?id=268956 Reviewed by Tim Nguyen. Spec: https://drafts.csswg.org/css-ui/#field-sizing Grammar for property: fixed | content This adds the field-sizing property to the CSS parser behind a flag, and updates the relevant expectation files. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/css/CSSPrimitiveValueMappings.h: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::initialValueForLonghand): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::fieldSizing const): (WebCore::RenderStyle::initialFieldSizing): (WebCore::RenderStyle::setFieldSizing): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleConstants.cpp: (WebCore::operator<<): * Source/WebCore/rendering/style/RenderStyleConstants.h: * Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const): * Source/WebCore/rendering
[webkit-changes] [WebKit/WebKit] 24a12a: Import `field-sizing` WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24a12aa6d3bbf28e24c8c7dbe186377e5e3c432e https://github.com/WebKit/WebKit/commit/24a12aa6d3bbf28e24c8c7dbe186377e5e3c432e Author: Luke Warlow Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed.html A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.html R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.html R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.html R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/w3c-import.log M LayoutTests/platform/glib/TestExpectations Log Message: --- Import `field-sizing` WPT tests https://bugs.webkit.org/show_bug.cgi?id=268954 Reviewed by Aditya Keerthi. Imports CSS parsing and HTML rendering tests for the field-sizing CSS property Upstream commit: https://github.com/web-platform-tests/wpt/commit/3c00d743109ae3d06e874e56dd9287f3ded06f44 * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field
[webkit-changes] [WebKit/WebKit] 829ee3: Trusted types allows duplicate default policies wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 829ee3dbf2a771f11bd4e9f7251d6a626ad98093 https://github.com/WebKit/WebKit/commit/829ee3dbf2a771f11bd4e9f7251d6a626ad98093 Author: Luke Warlow Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-without-enforcement-expected.txt M Source/WebCore/page/csp/ContentSecurityPolicy.cpp Log Message: --- Trusted types allows duplicate default policies without CSP enforcement https://bugs.webkit.org/show_bug.cgi?id=268989 Reviewed by Tim Nguyen. This patch disallows duplicate default policies even without CSP enforcement. This follows step 3 from https://w3c.github.io/trusted-types/dist/spec/#create-trusted-type-policy-algorithm * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-without-enforcement-expected.txt: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowTrustedTypesPolicy const): Canonical link: https://commits.webkit.org/274298@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 142d2a: Implement enforcement of `trusted-types` CSP direc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 142d2a80207e10069b36196a19a83cda6b96223d https://github.com/WebKit/WebKit/commit/142d2a80207e10069b36196a19a83cda6b96223d Author: Luke Warlow Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-check-report-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt M Source/WebCore/dom/TrustedTypePolicyFactory.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/page/csp/ContentSecurityPolicy.h M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp M Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h M Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp M Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.h Log Message: --- Implement enforcement of `trusted-types` CSP directive https://bugs.webkit.org/show_bug.cgi?id=267632 Reviewed by Youenn Fablet. This updates the trusted types policy creation code to validate that it's allowed by CSP. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-list-report-only-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-check-report-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-reporting-expected.txt: * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: (WebCore::TrustedTypePolicyFactory::createPolicy): * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowTrustedTypesPolicy const): (WebCore::ContentSecurityPolicy::reportViolation const): * Source/WebCore/page/csp/ContentSecurityPolicy.h: * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForTrustedTypesPolicy const): (WebCore::ContentSecurityPolicyDirectiveList::shouldReportSample const): * Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.h: * Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.cpp: (WebCore::ContentSecurityPolicyTrustedTypesDirective::allows const): * Source/WebCore/page/csp/ContentSecurityPolicyTrustedTypesDirective.h: Canonical link: https://commits.webkit.org/274263@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c98f5: Implement parsing for trusted-types and require-tr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c98f5233c675be7ea9333a0cbb7496894af968a https://github.com/WebKit/WebKit/commit/6c98f5233c675be7ea9333a0cbb7496894af968a Author: Luke Warlow Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/GlobalEventHandlers-onclick-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-skip-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Document-execCommand-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMParser-parseFromString-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-insertAdjacentHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-outerHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Element-setAttributeNS-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Range-createContextualFragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-attribute-via-attribute-node-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-text-node-insertion-into-script-element-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/csp-block-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-callback-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/default-policy-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/empty-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/empty-default-policy-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-with-permissive-csp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/no-require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/require-trusted-types-for-report-only-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-createHTMLDocument-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types-duplicate-names-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/trusted-types
[webkit-changes] [WebKit/WebKit] 74d050: Add stubs for Trusted Types API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74d050dabf126cdca0dd92b7cf303dd5dc925f63 https://github.com/WebKit/WebKit/commit/74d050dabf126cdca0dd92b7cf303dd5dc925f63 Author: Luke Warlow Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/securitypolicyviolation/source-file-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMParser-parseFromString-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-outerHTML-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/GlobalEventHandlers-onclick-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Range-createContextualFragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-wildcard-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-createXXX-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-constants-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-createXYZTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-noNamesGiven-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-none-skip-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-cspTests-wildcard-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-nameTests-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-createPolicy-unenforced-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-defaultPolicy-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getAttributeType-namespace-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-isXXX-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/Window-TrustedTypes-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-eval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/WorkerGlobalScope-importScripts-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Document-execCommand-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMParser-parseFromString-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval-expected.txt M LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-string-assignment-to-Document-write-expected.txt
[webkit-changes] [WebKit/WebKit] fdb8fc: Remove personal email from contributors.json
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdb8fc77d35299cc92268940dfa1c58b1179ee77 https://github.com/WebKit/WebKit/commit/fdb8fc77d35299cc92268940dfa1c58b1179ee77 Author: Luke Warlow Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M metadata/contributors.json Log Message: --- Remove personal email from contributors.json https://bugs.webkit.org/show_bug.cgi?id=268291 Reviewed by Anne van Kesteren. This removes my personal email from contributors.json * metadata/contributors.json: Canonical link: https://commits.webkit.org/273657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a505bd: IDL Callbacks with variadic params cause build fai...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a505bd79a80c6d9ecde4c2ecb518287eb99bc85a https://github.com/WebKit/WebKit/commit/a505bd79a80c6d9ecde4c2ecb518287eb99bc85a Author: Luke Warlow Date: 2024-01-15 (Mon, 15 Jan 2024) Changed paths: M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h Log Message: --- IDL Callbacks with variadic params cause build failures on some platforms https://bugs.webkit.org/show_bug.cgi?id=267548 Reviewed by Chris Dumez. Includes the IDLType import in the header file to prevent template specialization errors on some platforms. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateCallbackHeaderContent): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp: * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h: Canonical link: https://commits.webkit.org/273050@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 84e943: Import trusted types WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84e9432d4205b081f4daacb43fb04e88ec357225 https://github.com/WebKit/WebKit/commit/84e9432d4205b081f4daacb43fb04e88ec357225 Author: Luke Warlow Date: 2024-01-15 (Mon, 15 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMParser-parseFromString-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMParser-parseFromString-regression-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMParser-parseFromString-regression.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMParser-parseFromString.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/DOMWindowTimers-setTimeout-setInterval.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-execCommand-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-execCommand.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Document-write.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentHTML-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentHTML.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-insertAdjacentText.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-outerHTML-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-outerHTML.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttribute.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Element-setAttributeNS.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/GlobalEventHandlers-onclick-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/GlobalEventHandlers-onclick.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLElement-generic.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-in-xhtml-document.tentative.https.xhtml A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/HTMLScriptElement-internal-slot.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/META.yml A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Range-createContextualFragment-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/Range-createContextualFragment.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedType-AttributeNodes.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-no-name.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-wildcard-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-CSP-wildcard.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-createXXX-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicy-createXXX.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-blocking.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-constants-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types
[webkit-changes] [WebKit/WebKit] fcfe0a: Variadic params to callbacks aren't handled correctly
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcfe0a54117d8eb309a3c1285e5cbd09585b290f https://github.com/WebKit/WebKit/commit/fcfe0a54117d8eb309a3c1285e5cbd09585b290f Author: Luke Warlow Date: 2024-01-10 (Wed, 10 Jan 2024) Changed paths: M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm A Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp A Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h M Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep A Source/WebCore/bindings/scripts/test/TestCallbackFunctionWithVariadic.idl Log Message: --- Variadic params to callbacks aren't handled correctly https://bugs.webkit.org/show_bug.cgi?id=267332 Reviewed by Chris Dumez. Updates code generator to handle variadic params to callbacks. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: (GenerateCallbackHeaderContent): (GenerateCallbackImplementationContent): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.cpp: Added. (WebCore::JSTestCallbackFunctionWithVariadic::JSTestCallbackFunctionWithVariadic): (WebCore::JSTestCallbackFunctionWithVariadic::~JSTestCallbackFunctionWithVariadic): (WebCore::JSTestCallbackFunctionWithVariadic::handleEvent): (WebCore::toJS): * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithVariadic.h: Added. (WebCore::toJS): * Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep: * Source/WebCore/bindings/scripts/test/TestCallbackFunctionWithVariadic.idl: Added. Canonical link: https://commits.webkit.org/272855@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50773f: Implement history action user activation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50773fa12cff9404aa56ad0bcac5f09e9ab6c194 https://github.com/WebKit/WebKit/commit/50773fa12cff9404aa56ad0bcac5f09e9ab6c194 Author: Luke Warlow Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: A LayoutTests/fast/html/history-action-user-activation-expected.txt A LayoutTests/fast/html/history-action-user-activation.html M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wpe/TestExpectations M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalDOMWindow.h M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl Log Message: --- Implement history action user activation https://bugs.webkit.org/show_bug.cgi?id=266554 Reviewed by Alex Christensen. This implements the history action user activation algorithm from the HTML spec. Spec URL: https://html.spec.whatwg.org/multipage/interaction.html#history-action-activation * LayoutTests/fast/html/history-action-user-activation-expected.txt: Added. * LayoutTests/fast/html/history-action-user-activation.html: Added. * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::hasHistoryActionActivation const): (WebCore::LocalDOMWindow::consumeHistoryActionUserActivation): * Source/WebCore/page/LocalDOMWindow.h: * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::hasHistoryActionActivation): (WebCore::Internals::consumeHistoryActionUserActivation): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: Canonical link: https://commits.webkit.org/272590@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1c733: Update my list of email addresses in contributors....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1c73363d5266abbdb2f6ea17d8fda5b0a93db9b https://github.com/WebKit/WebKit/commit/a1c73363d5266abbdb2f6ea17d8fda5b0a93db9b Author: Luke Warlow Date: 2023-12-17 (Sun, 17 Dec 2023) Changed paths: M metadata/contributors.json Log Message: --- Update my list of email addresses in contributors.json https://bugs.webkit.org/show_bug.cgi?id=266558 Reviewed by Tim Nguyen. Add my igalia address to contributors.json * metadata/contributors.json: Canonical link: https://commits.webkit.org/272197@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dddc5b: showPicker() method of inputs doesn't trigger data...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dddc5bb328a4b8636946a735281b09101f1d3161 https://github.com/WebKit/WebKit/commit/dddc5bb328a4b8636946a735281b09101f1d3161 Author: Luke Warlow Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: A LayoutTests/fast/forms/datalist/datalist-show-picker-expected.txt A LayoutTests/fast/forms/datalist/datalist-show-picker.html M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios/TestExpectations M Source/WebCore/html/TextFieldInputType.cpp M Source/WebCore/html/TextFieldInputType.h Log Message: --- showPicker() method of inputs doesn't trigger datalist suggestions https://bugs.webkit.org/show_bug.cgi?id=261701 Reviewed by Aditya Keerthi. Implements showPicker for TextFieldInputs that have a datalist. This does not work on iOS a follow up will address that. * LayoutTests/fast/forms/datalist/datalist-show-picker-expected.txt: Added. * LayoutTests/fast/forms/datalist/datalist-show-picker.html: Added. * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * Source/WebCore/html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::showPicker): * Source/WebCore/html/TextFieldInputType.h: Canonical link: https://commits.webkit.org/269981@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e012ed: Grant committer status to Luke Warlow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e012edb596c25b00154ac89cf9c988c893237efb https://github.com/WebKit/WebKit/commit/e012edb596c25b00154ac89cf9c988c893237efb Author: Luke Warlow Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M metadata/contributors.json Log Message: --- Grant committer status to Luke Warlow https://bugs.webkit.org/show_bug.cgi?id=263605 Reviewed by Tim Nguyen. Add committer status to myself. * metadata/contributors.json: Canonical link: https://commits.webkit.org/269728@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ab4d8: [popover] Using nested shadow DOM wrongly auto-hid...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ab4d83515295e0a665d55c86ce55d5ff35ca226 https://github.com/WebKit/WebKit/commit/4ab4d83515295e0a665d55c86ce55d5ff35ca226 Author: Luke Warlow Date: 2023-10-20 (Fri, 20 Oct 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested.html M LayoutTests/platform/ios-wk2/TestExpectations M Source/WebCore/html/HTMLElement.cpp Log Message: --- [popover] Using nested shadow DOM wrongly auto-hides popover by light dismiss https://bugs.webkit.org/show_bug.cgi?id=263081 Reviewed by Ryosuke Niwa. Use the flat tree as mandated by the spec when calculating the nearest inclusive open popoer: - https://html.spec.whatwg.org/#nearest-inclusive-open-popover * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-flat-tree-nested.html: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::topmostPopoverAncestor): * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269596@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5df7cd: Add support for `showPicker()` to `HTMLSelectElement`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5df7cdc4a1ec1cfef6b892665536af6eefe925e2 https://github.com/WebKit/WebKit/commit/5df7cdc4a1ec1cfef6b892665536af6eefe925e2 Author: Luke Warlow Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/forms/select/select-show-picker-expected.txt A LayoutTests/fast/forms/select/select-show-picker.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative-expected.txt M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/HTMLSelectElement.cpp M Source/WebCore/html/HTMLSelectElement.h M Source/WebCore/html/HTMLSelectElement.idl Log Message: --- Add support for `showPicker()` to `HTMLSelectElement` https://bugs.webkit.org/show_bug.cgi?id=261814 Reviewed by Aditya Keerthi. At whatwg/html#9754, it's proposed to add a new HTMLSelectElement::showPicker() method to show the popup for select elements. This patch introduces this functionality, for non-iOS platforms in WK2. * LayoutTests/fast/forms/select/select-show-picker-expected.txt: Added. * LayoutTests/fast/forms/select/select-show-picker.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative-expected.txt: Added. * LayoutTests/platform/ios/TestExpectations: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::showPicker): * Source/WebCore/html/HTMLSelectElement.h: * Source/WebCore/html/HTMLSelectElement.idl: * LayoutTests/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/269420@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 96b83e: showPicker() method of date input doesn't work
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 96b83e8d4b0e7d4e8f08fc92b7723dbfa07eac8f https://github.com/WebKit/WebKit/commit/96b83e8d4b0e7d4e8f08fc92b7723dbfa07eac8f Author: Luke Warlow Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: A LayoutTests/fast/forms/date/date-show-picker-expected.txt A LayoutTests/fast/forms/date/date-show-picker.html A LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker-expected.txt A LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker.html M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios/TestExpectations M Source/WebCore/html/BaseDateAndTimeInputType.cpp M Source/WebCore/html/BaseDateAndTimeInputType.h M Source/WebCore/html/MonthInputType.cpp M Source/WebCore/html/MonthInputType.h M Source/WebCore/html/TimeInputType.cpp M Source/WebCore/html/TimeInputType.h M Source/WebCore/html/WeekInputType.cpp M Source/WebCore/html/WeekInputType.h Log Message: --- showPicker() method of date input doesn't work https://bugs.webkit.org/show_bug.cgi?id=257308 Reviewed by Aditya Keerthi. Implement showPicker for date and datetime-local inputs. * Source/WebCore/html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::handleDOMActivateEvent): (WebCore::BaseDateAndTimeInputType::showPicker): * Source/WebCore/html/BaseDateAndTimeInputType.h: * Source/WebCore/html/MonthInputType.cpp: (WebCore::MonthInputType::showPicker): * Source/WebCore/html/MonthInputType.h: * Source/WebCore/html/TimeInputType.cpp: (WebCore::TimeInputType::showPicker): * Source/WebCore/html/TimeInputType.h: * Source/WebCore/html/WeekInputType.cpp: (WebCore::WeekInputType::showPicker): * Source/WebCore/html/WeekInputType.h: * LayoutTests/fast/forms/date/date-show-picker-expected.txt: Added. * LayoutTests/fast/forms/date/date-show-picker.html: Added. * LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker-expected.txt: Added. * LayoutTests/fast/forms/datetimelocal/datetimelocal-show-picker.html: Added. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/269257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8c00e: Re-import html/semantics/forms/the-select-elements...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8c00ef307ffaecf03a2cb3995fffe6b9a9fa1a7 https://github.com/WebKit/WebKit/commit/d8c00ef307ffaecf03a2cb3995fffe6b9a9fa1a7 Author: Luke Warlow Date: 2023-10-06 (Fri, 06 Oct 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/inserted-or-removed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/inserted-or-removed.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/resources/show-picker-child-iframe.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/resources/w3c-import.log A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log M LayoutTests/tests-options.json Log Message: --- Re-import html/semantics/forms/the-select-elements WPT https://bugs.webkit.org/show_bug.cgi?id=262783 Reviewed by Tim Nguyen. WPT Commit: 3538a9f3031846a83f95f9c514388fc4f35437fc * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/inserted-or-removed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/inserted-or-removed.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/resources/show-picker-child-iframe.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/resources/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-add-optgroup.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-cross-origin-iframe.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-disabled.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-multiple.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-size.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/show-picker-user-gesture.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log: * LayoutTests/tests-options.json: Canonical link: https://commits.webkit.org/268997@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4045ef: [css-scrollbars-1] Implement resolving of scrollba...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4045ef1224deb4c08f783027c4f2972e04cd4c58 https://github.com/WebKit/WebKit/commit/4045ef1224deb4c08f783027c4f2972e04cd4c58 Author: Luke Warlow Date: 2023-08-24 (Thu, 24 Aug 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- [css-scrollbars-1] Implement resolving of scrollbar track and thumb color https://bugs.webkit.org/show_bug.cgi?id=260141 Reviewed by Simon Fraser. This patch has no behavior changes. Adds code to get the resolved scrollbar thumb and track color. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollbarThumbColorStyle const): (WebCore::LocalFrameView::scrollbarTrackColorStyle const): * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::scrollbarThumbColorStyle const): (WebCore::ScrollableArea::scrollbarTrackColorStyle const): * Source/WebCore/platform/ScrollableArea.h: * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::scrollbarThumbColorStyle const): (WebCore::RenderLayerScrollableArea::scrollbarTrackColorStyle const): * Source/WebCore/rendering/RenderLayerScrollableArea.h: * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::effectiveScrollbarThumbColor const): (WebCore::RenderStyle::effectiveScrollbarTrackColor const): * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/267260@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0fdfc0: Reimport css/css-scrollbars WPT tests.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0fdfc09c5b301aacda87c71e444263c2f4d7f5f6 https://github.com/WebKit/WebKit/commit/0fdfc09c5b301aacda87c71e444263c2f4d7f5f6 Author: Luke Warlow Date: 2023-07-25 (Tue, 25 Jul 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-014.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006.html M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/w3c-import.log Log Message: --- Reimport css/css-scrollbars WPT tests. https://bugs.webkit.org/show_bug.cgi?id=259484 Reviewed by Tim Nguyen. Reimport css/css-scrollbars WPT tests. This is to get fixes for certain scrollbar-color tests. Along with some extra scrollbar-width repaint tests. WPT Commit: b8294eb4bdfde4a0d038dd6670a3fa7a5434183b * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-ref.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-014.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-paint-006.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/w3c-import.log: Canonical link: https://commits.webkit.org/266297@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87011d: Update inverted-colors UA styles to match spec
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87011db312c8a25aa85d0b991cc4fd19870c789d https://github.com/WebKit/WebKit/commit/87011db312c8a25aa85d0b991cc4fd19870c789d Author: Luke Warlow Date: 2023-07-22 (Sat, 22 Jul 2023) Changed paths: A LayoutTests/fast/media/mq-inverted-colors-ua-styles-expected.txt A LayoutTests/fast/media/mq-inverted-colors-ua-styles-img-expected.html A LayoutTests/fast/media/mq-inverted-colors-ua-styles-img.html A LayoutTests/fast/media/mq-inverted-colors-ua-styles.html M Source/WebCore/css/html.css Log Message: --- Update inverted-colors UA styles to match spec https://bugs.webkit.org/show_bug.cgi?id=259416 Reviewed by Tim Nguyen. Updated the style for the inverted-colors media query in html.css the new styles are taken directly from the spec. Spec: https://drafts.csswg.org/mediaqueries-5/#inverted * LayoutTests/fast/media/mq-inverted-colors-ua-styles-expected.txt: Added. * LayoutTests/fast/media/mq-inverted-colors-ua-styles-img-expected.html: Added. * LayoutTests/fast/media/mq-inverted-colors-ua-styles-img.html: Added. * LayoutTests/fast/media/mq-inverted-colors-ua-styles.html: Added. * Source/WebCore/css/html.css: (@media (inverted-colors) img:not(picture>img), picture, video): (@media (inverted-colors) img, picture, video): Deleted. Canonical link: https://commits.webkit.org/266234@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 044d44: Scrollbar doesn't update on CSS color-scheme change
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 044d44c8940b219fb3d4f65e0cda8f97a4f86f30 https://github.com/WebKit/WebKit/commit/044d44c8940b219fb3d4f65e0cda8f97a4f86f30 Author: Luke Warlow Date: 2023-07-20 (Thu, 20 Jul 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4.html M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/rendering/RenderBox.cpp Log Message: --- Scrollbar doesn't update on CSS color-scheme change https://bugs.webkit.org/show_bug.cgi?id=244494 Reviewed by Aditya Keerthi. The color-scheme property is now diffed and triggers invalidateScrollbars on scrollable areas. invalidateScrollbars also now calls invalidateScrollCorners. This causes the scrollbar and scroll corner to correctly rerender without hovering or invalidating through other means. When UI Side Compositing is disabled. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-1.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-2.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-3.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-scheme-dynamic-4.html: Added. * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::invalidateScrollbars): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): Canonical link: https://commits.webkit.org/266176@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ac44b: Legacy scrollbar corner pseudo styles used despite...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ac44ba11fa34b3d06f0baca832d453e14c7f185 https://github.com/WebKit/WebKit/commit/3ac44ba11fa34b3d06f0baca832d453e14c7f185 Author: Luke Warlow Date: 2023-07-12 (Wed, 12 Jul 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010.html M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: --- Legacy scrollbar corner pseudo styles used despite standard scrollbar property usage https://bugs.webkit.org/show_bug.cgi?id=258773 Reviewed by Simon Fraser. This patch changes the code that retrieves the ScrollbarCorner pseudo styles to check that there's no standard property usage. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-006.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-007.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-008.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-009.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-010.html: Added. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::updateScrollCorner): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::updateScrollCornerStyle): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::usesStandardScrollbarStyle const): (WebCore::RenderStyle::usesLegacyScrollbarStyle const): Canonical link: https://commits.webkit.org/265990@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4a4b32: Add scrollbar width style to ScrollableAreaParameters
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4a4b3254505852dd5204ff5c5b6d4882143175eb https://github.com/WebKit/WebKit/commit/4a4b3254505852dd5204ff5c5b6d4882143175eb Author: Luke Warlow Date: 2023-07-10 (Mon, 10 Jul 2023) Changed paths: M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm M Source/WebCore/platform/ScrollTypes.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Add scrollbar width style to ScrollableAreaParameters https://bugs.webkit.org/show_bug.cgi?id=259017 Reviewed by Simon Fraser. This patch adds scrollbarWidthStyle to ScrollableAreaParameters. This is wired up to ScrollerPairMac to replace the hardcoded ScrollbarWidth::Auto. This will allow a follow up to fix the thin value having no affect with composited scrolling. This patch has no behaviour changes. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry): * Source/WebCore/page/scrolling/ScrollingCoordinatorTypes.h: (WebCore::ScrollableAreaParameters::operator== const): * Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h: * Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm: (WebCore::ScrollerPairMac::scrollbarWidthStyle const): * Source/WebCore/platform/ScrollTypes.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/265907@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 763623: Improve resolving of scrollbar-gutter style
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76362384eea16a54d1b77d63215830abef329124 https://github.com/WebKit/WebKit/commit/76362384eea16a54d1b77d63215830abef329124 Author: Luke Warlow Date: 2023-07-08 (Sat, 08 Jul 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/platform/ScrollableArea.cpp M Source/WebCore/platform/ScrollableArea.h M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h Log Message: --- Improve resolving of scrollbar-gutter style https://bugs.webkit.org/show_bug.cgi?id=259014 Reviewed by Darin Adler. Move the resolution of scrollbar-gutter styles to its own function and implement for RenderLayerScrollableArea and LocalFrameView. This will allow implementation of scrollbar-gutter on viewports. This patch has no behaviour changes. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::scrollbarGutterStyle const): * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::scrollbarGutterStyle const): * Source/WebCore/platform/ScrollableArea.h: * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::verticalScrollbarWidth const): (WebCore::RenderLayerScrollableArea::horizontalScrollbarHeight const): (WebCore::RenderLayerScrollableArea::scrollbarGutterStyle const): * Source/WebCore/rendering/RenderLayerScrollableArea.h: Canonical link: https://commits.webkit.org/265882@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d00d3: Scrollbar gutters don't update when scrollbar-widt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d00d37d49601fbb0bd5320641f73a91d9bb01a2 https://github.com/WebKit/WebKit/commit/8d00d37d49601fbb0bd5320641f73a91d9bb01a2 Author: Luke Warlow Date: 2023-07-03 (Mon, 03 Jul 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003.html M Source/WebCore/rendering/style/RenderStyle.cpp Log Message: --- Scrollbar gutters don't update when scrollbar-width value does https://bugs.webkit.org/show_bug.cgi?id=258770 Reviewed by Tim Nguyen. Correctly diff scrollbar-width inside of RenderStyle::rareDataChangeRequiresLayout. Scrollbar gutters now correctly repaint. Add a WPT test that tests this. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-003.html: Added. * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::rareDataChangeRequiresLayout): Canonical link: https://commits.webkit.org/265726@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 78b414: ScrollerMac shouldn't use hardcoded NSControlSize
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 78b4149d570a3d45b62b4d6312c7692d2f7f18e4 https://github.com/WebKit/WebKit/commit/78b4149d570a3d45b62b4d6312c7692d2f7f18e4 Author: Luke Warlow Date: 2023-07-01 (Sat, 01 Jul 2023) Changed paths: M Source/WebCore/page/scrolling/mac/ScrollerMac.mm M Source/WebCore/page/scrolling/mac/ScrollerPairMac.h M Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm M Source/WebCore/platform/mac/ScrollTypesMac.h M Source/WebCore/platform/mac/ScrollbarThemeMac.mm Log Message: --- ScrollerMac shouldn't use hardcoded NSControlSize https://bugs.webkit.org/show_bug.cgi?id=258752 Reviewed by Simon Fraser. This patch moves the function to convert from ScrollbarWidth to NSControlSize into ScrollTypesMac.h. This is then used inside of ScrollerMac instead of a hard coded NSControlSizeRegular. ScrollerPairMac currently returns a hardcoded ScrollbarWidth::Auto, so this patch has no behaviour changes. * Source/WebCore/page/scrolling/mac/ScrollerMac.mm: (WebCore::ScrollerMac::attach): (WebCore::ScrollerMac::updateScrollbarStyle): * Source/WebCore/page/scrolling/mac/ScrollerPairMac.h: * Source/WebCore/page/scrolling/mac/ScrollerPairMac.mm: (WebCore::ScrollerPairMac::scrollbarWidthStyle const): * Source/WebCore/platform/mac/ScrollTypesMac.h: (WebCore::nsControlSizeFromScrollbarWidth): * Source/WebCore/platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::registerScrollbar): (WebCore::ScrollbarThemeMac::scrollbarThickness): (WebCore::scrollbarWidthToNSControlSize): Deleted. Canonical link: https://commits.webkit.org/265691@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4498c4: Scroll corner painting ignores color-scheme when o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4498c483beb97701ef5ca9d7ee2050b86a8d924a https://github.com/WebKit/WebKit/commit/4498c483beb97701ef5ca9d7ee2050b86a8d924a Author: Luke Warlow Date: 2023-07-01 (Sat, 01 Jul 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/platform/mac/ScrollbarThemeMac.mm Log Message: --- Scroll corner painting ignores color-scheme when overflow: scroll https://bugs.webkit.org/show_bug.cgi?id=258482 Reviewed by Aditya Keerthi. Update the local appearance value before painting Mac scroll corner. This means that the color-scheme is correctly accounted for when painting the scroll corner for both frame views and scrollable areas. * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::paintScrollCorner): * Source/WebCore/platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paintScrollCorner): Canonical link: https://commits.webkit.org/265687@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f05615: Ignore ::-webkit-scrollbar styles when scrollbar-c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f056156a42b6e3c32320293c36b6e0f44451f509 https://github.com/WebKit/WebKit/commit/f056156a42b6e3c32320293c36b6e0f44451f509 Author: Luke Warlow Date: 2023-06-22 (Thu, 22 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005-expected.txt M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderMenuList.cpp M Source/WebCore/rendering/RenderSearchField.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: --- Ignore ::-webkit-scrollbar styles when scrollbar-color is not auto https://bugs.webkit.org/show_bug.cgi?id=257617 Reviewed by Tim Nguyen. Rename hasCustomScrollbarStyle to usesLegacyScrollbarStyle to avoid confusion. RenderStyle::usesLegacyScrollbarStyle() now returns true if a custom style for the scrollbar has been set via ::-webkit-scrollbar, the value of scrollbar-width is auto (default), and the value of scrollbar-color is auto (default). * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005-expected.txt: * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::rootElementForCustomScrollbarPartStyle const): (WebCore::LocalFrameView::createScrollbar): (WebCore::LocalFrameView::canShowNonOverlayScrollbars const): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::canUseOverlayScrollbars const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::createScrollbar): * Source/WebCore/rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar): * Source/WebCore/rendering/RenderMenuList.cpp: (RenderMenuList::createScrollbar): * Source/WebCore/rendering/RenderSearchField.cpp: (WebCore::RenderSearchField::createScrollbar): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::usesLegacyScrollbarStyle const): (WebCore::RenderStyle::hasCustomScrollbarStyle const): Deleted. Canonical link: https://commits.webkit.org/265423@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 581332: Implement scrollbar-color CSS parsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 581332fbe81687fdac5e494e55c5364f99d7e7d6 https://github.com/WebKit/WebKit/commit/581332fbe81687fdac5e494e55c5364f99d7e7d6 Author: Luke Warlow Date: 2023-06-19 (Mon, 19 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-parsing-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-types.js M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/css/CSSProperties.json M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/css/parser/CSSPropertyParser.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp M Source/WebCore/css/parser/CSSPropertyParserHelpers.h M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/rendering/style/RenderStyleSetters.h A Source/WebCore/rendering/style/ScrollbarColor.cpp A Source/WebCore/rendering/style/ScrollbarColor.h M Source/WebCore/rendering/style/StyleRareInheritedData.cpp M Source/WebCore/rendering/style/StyleRareInheritedData.h M Source/WebCore/style/StyleBuilderConverter.h Log Message: --- Implement scrollbar-color CSS parsing https://bugs.webkit.org/show_bug.cgi?id=257571 Reviewed by Darin Adler and Tim Nguyen. Spec: https://drafts.csswg.org/css-scrollbars/#scrollbar-color Grammar for property: auto | {2} This adds the property to the CSS parser behind a flag. This also adds animation support for this property. Test expectations have been updated, and new tests have been added. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-parsing-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-list.js: * LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/property-types.js: (const.colorPairType.testInterpolation
[webkit-changes] [WebKit/WebKit] b703b0: Fix scrollbar-gutter invalidation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b703b067b883426bca606987e3d1ac7041c554a0 https://github.com/WebKit/WebKit/commit/b703b067b883426bca606987e3d1ac7041c554a0 Author: Luke Warlow Date: 2023-06-16 (Fri, 16 Jun 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002.html M Source/WebCore/rendering/style/RenderStyle.cpp Log Message: --- Fix scrollbar-gutter invalidation https://bugs.webkit.org/show_bug.cgi?id=258207 Reviewed by Tim Nguyen. Add diff check for scrollbarGutter to RenderStyle rareDataChangeRequiresLayout. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-dynamic-002.html: Added. * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::rareDataChangeRequiresLayout): Canonical link: https://commits.webkit.org/265254@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf7c4d: Remove unused ScrollbarControlSize enum
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf7c4d623cac1295df1716344da55b40d82a9a3c https://github.com/WebKit/WebKit/commit/cf7c4d623cac1295df1716344da55b40d82a9a3c Author: Luke Warlow Date: 2023-06-16 (Fri, 16 Jun 2023) Changed paths: M Source/WebCore/platform/ScrollTypes.h Log Message: --- Remove unused ScrollbarControlSize enum https://bugs.webkit.org/show_bug.cgi?id=258203 Reviewed by Aditya Keerthi. This enum is no longer used so this patch deletes it. * Source/WebCore/platform/ScrollTypes.h: Canonical link: https://commits.webkit.org/265246@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a055c: Implement scrollbar-gutter both-edges support on n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a055c133ed578da42d94db83e7e62e367f0e25f https://github.com/WebKit/WebKit/commit/9a055c133ed578da42d94db83e7e62e367f0e25f Author: Luke Warlow Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBoxInlines.h M Source/WebCore/rendering/style/RenderStyle.h Log Message: --- Implement scrollbar-gutter both-edges support on non-viewports https://bugs.webkit.org/show_bug.cgi?id=257708 Reviewed by Simon Fraser. Scrollbar gutter now correctly works (on non-viewports) for both the "stable" and "stable both-edges" values. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::contentBoxLocation const): * Source/WebCore/rendering/RenderBoxInlines.h: (WebCore::RenderBox::computedCSSContentBoxRect const): (WebCore::RenderBox::contentHeight const): (WebCore::RenderBox::contentWidth const): (WebCore::RenderBox::overridingContentLogicalHeight const): (WebCore::RenderBox::overridingContentLogicalWidth const): * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/265199@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 964948: Ignore ::-webkit-scrollbar styles when scrollbar-w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 964948660ae097f883e12408b84dea3efd98a7ae https://github.com/WebKit/WebKit/commit/964948660ae097f883e12408b84dea3efd98a7ae Author: Luke Warlow Date: 2023-06-13 (Tue, 13 Jun 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-010-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-010.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-011-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-011.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-012-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-012.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-013-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-013.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-014-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-014.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-015-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-015.html A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-016-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-016.html M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/LocalFrameView.h M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderMenuList.cpp M Source/WebCore/rendering/RenderSearchField.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h Log Message: --- Ignore ::-webkit-scrollbar styles when scrollbar-width is not auto https://bugs.webkit.org/show_bug.cgi?id=257052 Reviewed by Tim Nguyen and Simon Fraser. RenderStyle::hasCustomScrollbarStyle() returns true if a custom style for the scrollbar has been set via ::-webkit-scrollbar and the value of scrollbar-width is auto (default). This replaces usages of hasPseudoStyle(PseudoId::Scrollbar) so the standard properties for styling scrollbars take precedence over the non-standard. WPT tests are included. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-003.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-004.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-color-005.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-010-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-scrollbars/scrollbar-width-010
[webkit-changes] [WebKit/WebKit] 309ff2: Correct statuses for certain CSS properties
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 309ff24a9f51908bd7c7a16d4e942cb6d46b7939 https://github.com/WebKit/WebKit/commit/309ff24a9f51908bd7c7a16d4e942cb6d46b7939 Author: Luke Warlow Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WebCore/css/CSSProperties.json Log Message: --- Correct statuses for certain CSS properties https://bugs.webkit.org/show_bug.cgi?id=257766 Reviewed by Tim Nguyen. Adds missing "in development" status for scrollbar-width and scrollbar-gutter. Also change various other properties to be stable. * Source/WebCore/css/CSSProperties.json: Canonical link: https://commits.webkit.org/264945@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f6bd1: Fix scrollbar-gutter stable in vertical writing modes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f6bd1d186405f2134662981c82a0857f353b5e2 https://github.com/WebKit/WebKit/commit/0f6bd1d186405f2134662981c82a0857f353b5e2 Author: Luke Warlow Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt M Source/WebCore/rendering/RenderBox.cpp M Source/WebCore/rendering/RenderBoxModelObject.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.h Log Message: --- Fix scrollbar-gutter stable in vertical writing modes https://bugs.webkit.org/show_bug.cgi?id=257605 Reviewed by Simon Fraser. Stable scrollbar gutters on non-viewports now correctly account for vertical writing modes. * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt: * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::includeHorizontalScrollbarSize const): (WebCore::RenderBox::verticalScrollbarWidth const): (WebCore::RenderBox::horizontalScrollbarHeight const): (WebCore::RenderBox::overflowClipRect const): * Source/WebCore/rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::verticalScrollbarWidth const): (WebCore::RenderLayerScrollableArea::horizontalScrollbarHeight const): (WebCore::RenderLayerScrollableArea::computeScrollOrigin): * Source/WebCore/rendering/RenderLayerScrollableArea.h: Canonical link: https://commits.webkit.org/264937@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes