[webkit-changes] [WebKit/WebKit] fa3668: Adopt smart pointers to glib related code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fa36680627bf7c079a0d1f1b88b171889342af25 https://github.com/WebKit/WebKit/commit/fa36680627bf7c079a0d1f1b88b171889342af25 Author: Mikhail R. Gadelha Date: 2024-06-14 (Fri, 14 Jun 2024) Changed paths: M Source/JavaScriptCore/API/glib/JSCClass.cpp M Source/JavaScriptCore/API/glib/JSCContext.cpp M Source/JavaScriptCore/API/glib/JSCException.cpp M Source/JavaScriptCore/API/glib/JSCValue.cpp M Source/JavaScriptCore/API/glib/JSCWeakValue.cpp M Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp M Source/WTF/wtf/glib/RunLoopGLib.cpp M Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp M Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp M Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp M Source/WebKit/UIProcess/API/glib/WebKitSecurityManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp M Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebResourceLoadManager.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebHitTestResult.cpp M Source/WebKit/WebProcess/WebCoreSupport/glib/WebEditorClientGLib.cpp M Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp Log Message: --- Adopt smart pointers to glib related code https://bugs.webkit.org/show_bug.cgi?id=274898 Reviewed by Carlos Garcia Campos. This patch changes glib related code in WebKit to use smart pointers * Source/JavaScriptCore/API/glib/JSCClass.cpp: (getProperty): (setProperty): (hasProperty): (deleteProperty): (getPropertyNames): (jscClassCreate): (jscClassCreateConstructor): (jscClassAddMethod): * Source/JavaScriptCore/API/glib/JSCContext.cpp: (jscContextPushCallback): (jscContextPopCallback): (jscContextGarbageCollect): (jsc_context_evaluate_in_object): (jsc_context_check_syntax): * Source/JavaScriptCore/API/glib/JSCException.cpp: (jscExceptionCreate): * Source/JavaScriptCore/API/glib/JSCValue.cpp: (jsc_value_object_enumerate_properties): (jsc_value_object_define_property_data): (jscValueObjectDefinePropertyAccessor): (jscValueFunctionCreate): (jsc_value_is_array_buffer): (jsc_value_typed_array_get_type): * Source/JavaScriptCore/API/glib/JSCWeakValue.cpp: (jsc_weak_value_get_value): * Source/JavaScriptCore/API/glib/JSCWrapperMap.cpp: (JSC::WrapperMap::registerClass): (JSC::WrapperMap::createJSWrapper): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp: (Inspector::RemoteInspector::sendMessageToTarget): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp: (Inspector::RemoteInspectorServer::setTargetList): (Inspector::RemoteInspectorServer::setupInspectorClient): (Inspector::RemoteInspectorServer::connectionDidClose): (Inspector::RemoteInspectorServer::sendMessageToFrontend): * Source/WTF/wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::run): * Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp: (webkitAutomationSessionCreate): * Source/WebKit/UIProcess/API/glib/WebKitBackForwardList.cpp: (webkitBackForwardListCreateList): * Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp: (webkit_cookie_manager_set_persistent_storage): (webkit_cookie_manager_set_accept_policy): * Source/WebKit/UIProcess/API/glib/WebKitFileChooserRequest.cpp: (webkit_file_chooser_request_get_mime_types): (webkit_file_chooser_request_get_selected_files): * Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp: (webkit_network_session_set_itp_enabled): (webkit_network_session_get_itp_enabled): (webkit_network_session_set_persistent_credential_storage_enabled): (webkit_network_session_get_persistent_credential_storage_enabled): (webkit_network_session_set_tls_errors_policy): (webkit_network_session_allow_tls_certificate_for_host): (webkit_network_session_set_proxy_settings): (webkit_network_session_get_itp_summary): (webkit_network_session_prefetch_dns): (webkit_network_session_download_uri): * Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp: (WebKit::WebKitProtocolHandler::handleGPU): * Source/WebKit/UIProcess/API/glib/WebKitSecurityManager.cpp: (registerSecurityPolicyForURIScheme): * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webKitSettingsConstructed): * Source/WebKit/UIProcess/API
[webkit-changes] [WebKit/WebKit] 4fc946: Replace duplicated code in LLIntSlowPaths with alr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4fc946a72c06f3c63d781b31c1f908f286ebb598 https://github.com/WebKit/WebKit/commit/4fc946a72c06f3c63d781b31c1f908f286ebb598 Author: Mikhail R. Gadelha Date: 2024-06-05 (Wed, 05 Jun 2024) Changed paths: M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp Log Message: --- Replace duplicated code in LLIntSlowPaths with already defined macros https://bugs.webkit.org/show_bug.cgi?id=274984 Reviewed by Keith Miller. This patch removes some duplicated code in favor of using the LLINT_BEGIN_NO_SET_PC() and LLINT_BEGIN() macros. * Source/JavaScriptCore/llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::llint_slow_path_checkpoint_osr_exit_from_inlined_call): (JSC::LLInt::llint_slow_path_checkpoint_osr_exit): Canonical link: https://commits.webkit.org/279740@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d0caf: Use RefPtr local variable for nextChild in insertC...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d0caf9579718608843389ad1dcf5961c5cce63e https://github.com/WebKit/WebKit/commit/0d0caf9579718608843389ad1dcf5961c5cce63e Author: Mikhail R. Gadelha Date: 2024-05-15 (Wed, 15 May 2024) Changed paths: A LayoutTests/fast/dom/set-attribute-and-normalize-in-event-expected.txt A LayoutTests/fast/dom/set-attribute-and-normalize-in-event.html M Source/WebCore/dom/ContainerNode.cpp Log Message: --- Use RefPtr local variable for nextChild in insertChildrenBeforeWithoutPreInsertionValidityCheck https://bugs.webkit.org/show_bug.cgi?id=268765 rdar://122122623 Reviewed by Ryosuke Niwa and Chris Dumez. This patch adds a RefPtr to hold a reference to nextChild so that the pointer stay valid through the scope of the function. In the test case, the removeChild() call (from the before() call in the js script) triggers a DOMSubtreeModified event, which eventually calls normalize. The normalize() call can destroy text elements when normalizing the content of the node if there is no one holding the reference to that node, so holding nextChild in a RefPtr prevents us from reading an invalid pointer. * LayoutTests/fast/dom/set-attribute-and-normalize-in-event-expected.txt: Added. * LayoutTests/fast/dom/set-attribute-and-normalize-in-event.html: Added. * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::insertChildrenBeforeWithoutPreInsertionValidityCheck): Originally-landed-as: 274097.10@webkit-2024.2-embargoed (65b1fae34533). rdar://128089683 Canonical link: https://commits.webkit.org/278837@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6ca865: [IPC] Cleanup DaemonCoders.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6ca8653a03e3863ac614b15f1a59ac6b271031f9 https://github.com/WebKit/WebKit/commit/6ca8653a03e3863ac614b15f1a59ac6b271031f9 Author: Mikhail R. Gadelha Date: 2024-05-13 (Mon, 13 May 2024) Changed paths: M Source/WebKit/Platform/IPC/DaemonCoders.cpp M Source/WebKit/Platform/IPC/DaemonCoders.h Log Message: --- [IPC] Cleanup DaemonCoders.h https://bugs.webkit.org/show_bug.cgi?id=273198 Reviewed by Ben Nham. Removed unused IPC code from DaemonCoders * Source/WebKit/Platform/IPC/DaemonCoders.cpp: (WebKit::Daemon::Coder::encode): Deleted. (WebKit::Daemon::Coder::decode): Deleted. (WebKit::Daemon::Coder::encode): Deleted. (WebKit::Daemon::Coder::decode): Deleted. * Source/WebKit/Platform/IPC/DaemonCoders.h: (WebKit::Daemon::Coder::encode): Deleted. (WebKit::Daemon::Coder::decode): Deleted. Canonical link: https://commits.webkit.org/278695@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 00b342: Suppress uncounted local var warning in RETURN_IF_...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00b342534fc4efcdbe48e6f332982cc6c88ad41d https://github.com/WebKit/WebKit/commit/00b342534fc4efcdbe48e6f332982cc6c88ad41d Author: Mikhail R. Gadelha Date: 2024-05-09 (Thu, 09 May 2024) Changed paths: M Source/JavaScriptCore/runtime/ExceptionScope.h Log Message: --- Suppress uncounted local var warning in RETURN_IF_EXCEPTION https://bugs.webkit.org/show_bug.cgi?id=273697 Reviewed by Ryosuke Niwa. Add a macro to supress warning on the vm variable not being counted when the preprocessor expands the RETURN_IF_EXCEPTION macro in a function body. This patch removes more than 2000 warnings when checking all the webkit codebase. * Source/JavaScriptCore/runtime/ExceptionScope.h: Canonical link: https://commits.webkit.org/278560@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a2287: Adopt smart pointers in WebCore/bridge/ files
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a2287a135f68bd03cbcee31be0afd575c27e207 https://github.com/WebKit/WebKit/commit/0a2287a135f68bd03cbcee31be0afd575c27e207 Author: Mikhail R. Gadelha Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebCore/bridge/runtime_array.cpp M Source/WebCore/bridge/runtime_method.cpp M Source/WebCore/bridge/runtime_object.cpp Log Message: --- Adopt smart pointers in WebCore/bridge/ files https://bugs.webkit.org/show_bug.cgi?id=273642 Reviewed by Chris Dumez. Changes based on clang-tidy's alpha.webkit.UncountedLocalVars checker. * Source/WebCore/bridge/runtime_array.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER): (JSC::RuntimeArray::getOwnPropertyNames): (JSC::RuntimeArray::getOwnPropertySlot): (JSC::RuntimeArray::put): (JSC::RuntimeArray::putByIndex): * Source/WebCore/bridge/runtime_method.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER): (JSC::RuntimeMethod::getOwnPropertySlot): (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/WebCore/bridge/runtime_object.cpp: (JSC::Bindings::JSC_DEFINE_CUSTOM_GETTER): (JSC::Bindings::RuntimeObject::getOwnPropertySlot): (JSC::Bindings::RuntimeObject::put): (JSC::Bindings::JSC_DEFINE_HOST_FUNCTION): (JSC::Bindings::RuntimeObject::getOwnPropertyNames): Canonical link: https://commits.webkit.org/278340@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad81d5: Removed EnumTraits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad81d5649c426c8497b62f411b81edbc64462b06 https://github.com/WebKit/WebKit/commit/ad81d5649c426c8497b62f411b81edbc64462b06 Author: Mikhail R. Gadelha Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/Modules/webauthn/AuthenticatorTransport.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- Removed EnumTraits as it was already ported to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=268158 Reviewed by Alex Christensen. Ported in https://commits.webkit.org/256789@main * Source/WebCore/Modules/webauthn/AuthenticatorTransport.h: Canonical link: https://commits.webkit.org/278110@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a0c58: [IPC] Remove EnumTraits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a0c584ccaa2b3b7694bc4b97dfd4afb610a4bb6 https://github.com/WebKit/WebKit/commit/9a0c584ccaa2b3b7694bc4b97dfd4afb610a4bb6 Author: Mikhail R. Gadelha Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionDataType.h M Source/WebKit/Shared/Extensions/WebExtensionStorage.serialization.in Log Message: --- [IPC] Remove EnumTraits https://bugs.webkit.org/show_bug.cgi?id=271887 Reviewed by Timothy Hatcher. Delete the EnumTraits in favor of the serialization format, already implemented in 274603@main. This patch also removes the [OptionSet] attribute as it is not needed. * Source/WebKit/Shared/Extensions/WebExtensionDataType.h: * Source/WebKit/Shared/Extensions/WebExtensionStorage.serialization.in: Canonical link: https://commits.webkit.org/276879@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 152d60: Port ResolvedEmojiPolicy to the new IPC serializat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 152d6055bde1a9088c7c462937d4290bdce32854 https://github.com/WebKit/WebKit/commit/152d6055bde1a9088c7c462937d4290bdce32854 Author: Mikhail R. Gadelha Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/FontCascadeFonts.h M Source/WebCore/platform/text/TextFlags.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Port ResolvedEmojiPolicy to the new IPC serialization format https://bugs.webkit.org/show_bug.cgi?id=267704 Reviewed by Alex Christensen. * Source/WebCore/platform/graphics/FontCascadeFonts.h: * Source/WebCore/platform/text/TextFlags.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/275925@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 665900: Removed Enums from Platform/mediastream/libwebrtc ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 665900f919e3d8e794eb067e138f580fcbfffdef https://github.com/WebKit/WebKit/commit/665900f919e3d8e794eb067e138f580fcbfffdef Author: Mikhail R. Gadelha Date: 2024-03-11 (Mon, 11 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCEnumTraits.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h M Source/WebKit/GPUProcess/GPUProcess.h M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/Shared/RTCPacketOptions.cpp Log Message: --- Removed Enums from Platform/mediastream/libwebrtc as they were already ported to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=267867 Reviewed by Alex Christensen. The enums were ported in: https://commits.webkit.org/271173@main https://commits.webkit.org/270713@main Since the header is not needed anymore, it was also deleted. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCEnumTraits.h: Removed. * Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h: * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/Shared/RTCPacketOptions.cpp: Canonical link: https://commits.webkit.org/275924@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6dacd0: Port enums in WebKit/UIProcess/Extensions/ to the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6dacd0ef2df10ed4f71ef7d4026e3846625ac63a https://github.com/WebKit/WebKit/commit/6dacd0ef2df10ed4f71ef7d4026e3846625ac63a Author: Mikhail R. Gadelha Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M Source/WebKit/CMakeLists.txt M Source/WebKit/DerivedSources-input.xcfilelist M Source/WebKit/DerivedSources.make M Source/WebKit/UIProcess/Extensions/WebExtension.h A Source/WebKit/UIProcess/Extensions/WebExtension.serialization.in M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Port enums in WebKit/UIProcess/Extensions/ to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=268553 Reviewed by Timothy Hatcher. * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/UIProcess/Extensions/WebExtension.h: * Source/WebKit/UIProcess/Extensions/WebExtension.serialization.in: Added. * Source/WebKit/UIProcess/Extensions/WebExtensionTab.h: * Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/274367@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5495e9: Remove Enumtraits<> from WebKit/Shared/Extensions/
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5495e9f832d3d1c122ae1868c10d107c84f481f5 https://github.com/WebKit/WebKit/commit/5495e9f832d3d1c122ae1868c10d107c84f481f5 Author: Mikhail R. Gadelha Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M Source/WebKit/Shared/Extensions/WebExtensionStorageAccessLevel.h M Source/WebKit/Shared/Extensions/WebExtensionStorageType.h Log Message: --- Remove Enumtraits<> from WebKit/Shared/Extensions/ https://bugs.webkit.org/show_bug.cgi?id=268383 Reviewed by Timothy Hatcher. The enums already use the new serialization format and are defined in WebExtensionStorage.serialization.in * Source/WebKit/Shared/Extensions/WebExtensionStorageAccessLevel.h: * Source/WebKit/Shared/Extensions/WebExtensionStorageType.h: Canonical link: https://commits.webkit.org/273825@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87307b: Removed EnumTraits as i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87307bed482bd31fc33e2d071f4fc5985824b09a https://github.com/WebKit/WebKit/commit/87307bed482bd31fc33e2d071f4fc5985824b09a Author: Mikhail R. Gadelha Date: 2024-01-25 (Thu, 25 Jan 2024) Changed paths: M Source/WebCore/platform/mediastream/CaptureDevice.h Log Message: --- Removed EnumTraits as it was already ported to use the new serialization format https://bugs.webkit.org/show_bug.cgi?id=267711 Reviewed by Darin Adler. The EnumTraits was ported in https://commits.webkit.org/260561@main * Source/WebCore/platform/mediastream/CaptureDevice.h: Canonical link: https://commits.webkit.org/273529@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66aad8: Port JavaScript/inspector enums to new serializati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66aad8027ab811f57446a93d0fb23308c6dca370 https://github.com/WebKit/WebKit/commit/66aad8027ab811f57446a93d0fb23308c6dca370 Author: Mikhail R. Gadelha Date: 2024-01-25 (Thu, 25 Jan 2024) Changed paths: M Source/JavaScriptCore/inspector/InspectorFrontendChannel.h M Source/JavaScriptCore/inspector/InspectorTarget.h M Source/WebKit/Shared/JavaScriptCore.serialization.in Log Message: --- Port JavaScript/inspector enums to new serialization format https://bugs.webkit.org/show_bug.cgi?id=268006 Reviewed by Alex Christensen. Port JavaScript/inspector enums to new serialization format * Source/JavaScriptCore/inspector/InspectorFrontendChannel.h: * Source/JavaScriptCore/inspector/InspectorTarget.h: * Source/WebKit/Shared/JavaScriptCore.serialization.in: Canonical link: https://commits.webkit.org/273502@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 840e8f: Port JavaScriptCore/parser enums to new serializat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 840e8f70706ef6076a82934d37857c04ff0b4b09 https://github.com/WebKit/WebKit/commit/840e8f70706ef6076a82934d37857c04ff0b4b09 Author: Mikhail R. Gadelha Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/JavaScriptCore/parser/SourceProvider.h M Source/WebKit/Shared/JavaScriptCore.serialization.in Log Message: --- Port JavaScriptCore/parser enums to new serialization format https://bugs.webkit.org/show_bug.cgi?id=268002 Reviewed by Alex Christensen. Port JavaScriptCore/parser enums to new serialization format * Source/JavaScriptCore/parser/SourceProvider.h: * Source/WebKit/Shared/JavaScriptCore.serialization.in: Canonical link: https://commits.webkit.org/273445@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99370f: Change all enums under WebCore/platform/graphics/f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99370f48350dfae138b30520042652145a85eff8 https://github.com/WebKit/WebKit/commit/99370f48350dfae138b30520042652145a85eff8 Author: Mikhail R. Gadelha Date: 2024-01-17 (Wed, 17 Jan 2024) Changed paths: M Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm M Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm M Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp M Source/WebCore/platform/graphics/filters/DistantLightSource.cpp M Source/WebCore/platform/graphics/filters/DistantLightSource.h M Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp M Source/WebCore/platform/graphics/filters/FEColorMatrix.h M Source/WebCore/platform/graphics/filters/FEComponentTransfer.cpp M Source/WebCore/platform/graphics/filters/FEComponentTransfer.h M Source/WebCore/platform/graphics/filters/FEComposite.cpp M Source/WebCore/platform/graphics/filters/FEComposite.h M Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h M Source/WebCore/platform/graphics/filters/FEDisplacementMap.cpp M Source/WebCore/platform/graphics/filters/FEDisplacementMap.h M Source/WebCore/platform/graphics/filters/FEMorphology.h M Source/WebCore/platform/graphics/filters/FETurbulence.h M Source/WebCore/platform/graphics/filters/FilterFunction.h M Source/WebCore/platform/graphics/filters/FilterOperation.h M Source/WebCore/platform/graphics/filters/FilterRenderingMode.h M Source/WebCore/platform/graphics/filters/LightSource.h M Source/WebCore/platform/graphics/filters/PointLightSource.cpp M Source/WebCore/platform/graphics/filters/PointLightSource.h M Source/WebCore/platform/graphics/filters/SpotLightSource.cpp M Source/WebCore/platform/graphics/filters/SpotLightSource.h M Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareArithmeticApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h M Source/WebCore/platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp M Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h M Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.h M Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.h M Source/WebCore/rendering/CSSFilter.cpp M Source/WebCore/svg/SVGComponentTransferFunctionElement.cpp M Source/WebCore/svg/SVGComponentTransferFunctionElement.h M Source/WebCore/svg/SVGFEColorMatrixElement.cpp M Source/WebCore/svg/SVGFEColorMatrixElement.h M Source/WebCore/svg/SVGFECompositeElement.cpp M Source/WebCore/svg/SVGFECompositeElement.h M Source/WebCore/svg/SVGFEDisplacementMapElement.cpp M Source/WebCore/svg/SVGFEDisplacementMapElement.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Change all enums under WebCore/platform/graphics/filters/ to use serializer https://bugs.webkit.org/show_bug.cgi?id=264834 Reviewed by Chris Dumez. This patch changes all enums so they don't use the EnumTraits template anymore. Most of the patch is straightforward: it turns the enum into enum classes, adds an uint8_t type specifier to the enum classes, and adds the enum scope in the call sites. The only change that doesn't follow this is the removal of FEFirst and FELast from FilterFunction::Type, default values for the start and end of a subset of values in the enum; they are only ever used in the isFilterEffect() function, so I just replaced them with the actual values. * Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm: (WebCore::FEColorMatrixCoreImageApplier::supportsCoreImageRendering): (WebCore::FEColorMatrixCoreImageApplier::apply const): * Source/WebCore/platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm: (WebCore::FEComponentTransferCoreImageApplier::supportsCoreImageRendering): (WebCore::FEComponentTransferCoreImageApplier::apply const): * Source/WebCore/platform/graphics/cpu/arm/filters/FECompositeNeonArithmeticApplier.cpp: (WebCore::FECompositeNeonArithmeticApplier::FECompositeNeonArithmeticApplier): * Source/WebCore/platform/graphics/filters/DistantLightSource.cpp: (WebCore::DistantLightSource::DistantLightSource): * Source/WebCore/platform/graphics/filters/DistantLightSource.h: * Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::resultIsAlphaImage const): (WebCore::FEColorMatrix::supportedFilterRenderingModes const): (WebCore
[webkit-changes] [WebKit/WebKit] d53d6d: Move enums under WebCore/rendering/ to use the ser...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d53d6d23b888ad7f49bd058a9d8e233983e40f07 https://github.com/WebKit/WebKit/commit/d53d6d23b888ad7f49bd058a9d8e233983e40f07 Author: Mikhail R. Gadelha Date: 2023-11-12 (Sun, 12 Nov 2023) Changed paths: M Source/WebCore/page/LocalFrameView.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/rendering/Pagination.h M Source/WebCore/rendering/RenderBlockFlow.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/rendering/RenderView.cpp M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h M Source/WebCore/style/StyleResolveForDocument.cpp M Source/WebCore/testing/Internals.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Move enums under WebCore/rendering/ to use the serializer https://bugs.webkit.org/show_bug.cgi?id=264623 Reviewed by Chris Dumez. This patch covers the enums in Pagination.h (WebCore::PaginationMode) and in RenderObject.h (WebCore::RepaintRectCalculation). The patch mostly just adds the necessary scopes given that the enums now are enum classes. The only exception is the EnumeratedArray in the rendering/svg/legacy/ headers, which needed an extra argument, the last value in the enum; without it EnumeratedArray tries to call EnumTraits::values::max> and fails * Source/WebCore/page/LocalFrameView.cpp: (WebCore::paginationModeForRenderStyle): * Source/WebCore/page/Page.cpp: (WebCore::Page::pageCount const): (WebCore::Page::pageCountAssumingLayoutIsUpToDate const): * Source/WebCore/rendering/Pagination.h: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange): * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/RenderView.cpp: (WebCore::RenderView::styleDidChange): (WebCore::RenderView::requiresColumns const): (WebCore::RenderView::paint): (WebCore::RenderView::pageNumberForBlockProgressionOffset const): (WebCore::RenderView::pageCount const): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setColumnStylesFromPaginationMode): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResource.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.h: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceMasker.h: * Source/WebCore/style/StyleResolveForDocument.cpp: (WebCore::Style::resolveForDocument): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::setPagination): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPaginationMode): (WKPageGetPaginationMode): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setPaginationMode): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/270613@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4d1a5: Remove enums from ColorInterpolationMethod.h in fa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4d1a5b4a4e40b927cb3dd5a5862cb2a090f979a https://github.com/WebKit/WebKit/commit/a4d1a5b4a4e40b927cb3dd5a5862cb2a090f979a Author: Mikhail R. Gadelha Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: M Source/WebCore/platform/graphics/ColorInterpolationMethod.h Log Message: --- Remove enums from ColorInterpolationMethod.h in favor of the serializer https://bugs.webkit.org/show_bug.cgi?id=264599 Reviewed by Tim Nguyen. 259829@main added the serializer for the enums removed in this PR but they were never removed from the header. * Source/WebCore/platform/graphics/ColorInterpolationMethod.h: Canonical link: https://commits.webkit.org/270570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87ce4c: Use serialization for WebCore::ExceptionCode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87ce4ccda0c65191a9b808891842b4eee7eaaeaf https://github.com/WebKit/WebKit/commit/87ce4ccda0c65191a9b808891842b4eee7eaaeaf Author: Mikhail R. Gadelha Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: M Source/WebCore/dom/ExceptionCode.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Use serialization for WebCore::ExceptionCode https://bugs.webkit.org/show_bug.cgi?id=264453 Reviewed by Chris Dumez. OutOfMemoryError was missing from EnumTraits, so it was added to the enum class in WebCoreArgumentCoders.serialization.in * Source/WebCore/dom/ExceptionCode.h: (): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/270558@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdcc9a: Make ExceptionCode an enum class
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdcc9a4b872ce5ce101d5183af5fc39abd5d4844 https://github.com/WebKit/WebKit/commit/fdcc9a4b872ce5ce101d5183af5fc39abd5d4844 Author: Mikhail R. Gadelha Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: M Source/WebCore/Modules/ShapeDetection/BarcodeDetector.cpp M Source/WebCore/Modules/ShapeDetection/FaceDetector.cpp M Source/WebCore/Modules/ShapeDetection/TextDetector.cpp M Source/WebCore/Modules/WebGPU/GPUAdapter.cpp M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp M Source/WebCore/Modules/WebGPU/GPUQueue.cpp M Source/WebCore/Modules/applepay-ams-ui/ApplePayAMSUIPaymentHandler.cpp M Source/WebCore/Modules/applepay/ApplePayContactField.cpp M Source/WebCore/Modules/applepay/ApplePayMerchantCapability.cpp M Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp M Source/WebCore/Modules/applepay/ApplePaySession.cpp M Source/WebCore/Modules/applepay/ApplePaySetup.cpp M Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm M Source/WebCore/Modules/applepay/PaymentRequestValidator.mm M Source/WebCore/Modules/applepay/PaymentSession.cpp M Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp M Source/WebCore/Modules/async-clipboard/Clipboard.cpp M Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp M Source/WebCore/Modules/async-clipboard/ClipboardItemPasteboardDataSource.cpp M Source/WebCore/Modules/audiosession/DOMAudioSession.cpp M Source/WebCore/Modules/beacon/NavigatorBeacon.cpp M Source/WebCore/Modules/cache/DOMCache.cpp M Source/WebCore/Modules/cache/DOMCacheEngine.cpp M Source/WebCore/Modules/cache/WindowOrWorkerGlobalScopeCaches.cpp M Source/WebCore/Modules/compression/CompressionStreamEncoder.cpp M Source/WebCore/Modules/compression/DecompressionStreamDecoder.cpp M Source/WebCore/Modules/contact-picker/ContactsManager.cpp M Source/WebCore/Modules/cookie-consent/NavigatorCookieConsent.cpp M Source/WebCore/Modules/cookie-store/CookieStore.cpp M Source/WebCore/Modules/cookie-store/CookieStoreManager.cpp M Source/WebCore/Modules/credentialmanagement/BasicCredential.cpp M Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeySystemAccess.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp M Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.cpp M Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp M Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.cpp M Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.cpp M Source/WebCore/Modules/fetch/FetchBody.cpp M Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp M Source/WebCore/Modules/fetch/FetchBodyOwner.cpp M Source/WebCore/Modules/fetch/FetchHeaders.cpp M Source/WebCore/Modules/fetch/FetchRequest.cpp M Source/WebCore/Modules/fetch/FetchResponse.cpp M Source/WebCore/Modules/fetch/FormDataConsumer.cpp M Source/WebCore/Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemDirectoryHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemHandle.cpp M Source/WebCore/Modules/filesystemaccess/FileSystemSyncAccessHandle.cpp M Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.cpp M Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp M Source/WebCore/Modules/indexeddb/IDBCursor.cpp M Source/WebCore/Modules/indexeddb/IDBDatabase.cpp M Source/WebCore/Modules/indexeddb/IDBFactory.cpp M Source/WebCore/Modules/indexeddb/IDBIndex.cpp M Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp M Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp M Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp M Source/WebCore/Modules/indexeddb/IDBRequest.cpp M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp M Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp M Source/WebCore/Modules/indexeddb/server/IndexValueStore.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp M Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp M Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp M Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp M Source/WebCore/Modules/indexeddb/server/SQLiteIDBTransaction.cpp M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp M Source/WebCore/Modules/indexeddb/shared
[webkit-changes] [WebKit/WebKit] 0914c4: Remove EnumTraits...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0914c457bf21854287be5b8679c60519f7f986ec https://github.com/WebKit/WebKit/commit/0914c457bf21854287be5b8679c60519f7f986ec Author: Mikhail R. Gadelha Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M Source/WebCore/platform/Cookie.h Log Message: --- Remove EnumTraits from Cookie.h https://bugs.webkit.org/show_bug.cgi?id=264364 Reviewed by Chris Dumez. 255698@main added serializer for the struct Cookie, including WebCore::Cookie::SameSitePolicy, but the EnumTraits was never removed. * Source/WebCore/platform/Cookie.h: Canonical link: https://commits.webkit.org/270386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7dd18b: [JSC][32bit] Fix JIT being disabled when compiling...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab https://github.com/WebKit/WebKit/commit/7dd18bda3626e7ca2f007d2ea8f7df7104bc95ab Author: Mikhail R. Gadelha Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/b3/air/AirArg.h M Source/JavaScriptCore/wasm/WasmOpcodeOrigin.h M Source/WTF/wtf/PlatformCPU.h M Source/bmalloc/bmalloc/BPlatform.h M Source/cmake/OptionsCommon.cmake Log Message: --- [JSC][32bit] Fix JIT being disabled when compiling JSC on linux with clang https://bugs.webkit.org/show_bug.cgi?id=234034 Reviewed by Justin Michaud. JIT was always disabled when building JSC with clang on linux 32 bits because CMake checked if the compiler defined __thumb2__ and while gcc does define it by default, clang doesn't. This patch adds extra compilation flags when compiling JSC with clang for arm (except on Darwin), so the expected __thumb2__ define is defined and JIT is enabled. Also some minor changes: (1) this patch also adds __ARM_ARCH_8__ and __ARM_ARCH_8A__ to the list that sets BTHUMB_ARCH_VERSION and WTF_THUMB_ARCH_VERSION to 4. These two seem to be used mostly for sanity check. (2) a small fix in AirArg where clang complains about a missing typename. gcc seems to accept either. * Source/JavaScriptCore/b3/air/AirArg.h: (JSC::B3::Air::Arg::isValidAddrForm): * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::parseAndCompileAirImpl): * Source/WTF/wtf/PlatformCPU.h: * Source/bmalloc/bmalloc/BPlatform.h: * Source/cmake/OptionsCommon.cmake: Canonical link: https://commits.webkit.org/260921@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit]
Branch: refs/heads/eng/JSC-Fix-wasm-tests-on-MIPS Home: https://github.com/WebKit/WebKit ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c481d0: [JSC] Fix wasm tests on MIPS
Branch: refs/heads/eng/JSC-Fix-wasm-tests-on-MIPS Home: https://github.com/WebKit/WebKit Commit: c481d03721b2635e808e6b2f24ac7d47bdcb06b3 https://github.com/WebKit/WebKit/commit/c481d03721b2635e808e6b2f24ac7d47bdcb06b3 Author: Mikhail R. Gadelha Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M JSTests/wasm/stress/throw-from-wasm-catch-in-baseline-JIT.js M JSTests/wasm/stress/timer-exception.js Log Message: --- [JSC] Fix wasm tests on MIPS https://bugs.webkit.org/show_bug.cgi?id=251917 Unreviewed test gardening. Prevent MIPS failure by checking if wasm is available. * JSTests/wasm/stress/throw-from-wasm-catch-in-baseline-JIT.js: (vm.isWasmSupported): (foo): Deleted. * JSTests/wasm/stress/timer-exception.js: (async let): Deleted. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e046df: [32bit] skip stress/verify-can-gc-node-index.js if...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e046df1c0973fbe9063f9816db6670748506cfce https://github.com/WebKit/WebKit/commit/e046df1c0973fbe9063f9816db6670748506cfce Author: Mikhail R. Gadelha Date: 2022-10-12 (Wed, 12 Oct 2022) Changed paths: M JSTests/stress/verify-can-gc-node-index.js Log Message: --- [32bit] skip stress/verify-can-gc-node-index.js if it's memory limited Unreviewed test gardening. This patch removes the skip if only arm and skips the test on all memory limited systems. I just ran the test on a MIPS system and got it to randomly crash: Running stress/verify-can-gc-node-index.js.default Aborted stress/verify-can-gc-node-index.js.default: Crashing because current footprint: 639549440 exceeds limit: 629145600 stress/verify-can-gc-node-index.js.default: ERROR: Unexpected exit code: 134 FAIL: stress/verify-can-gc-node-index.js.default So it's not only an ARM issue. * JSTests/stress/verify-can-gc-node-index.js: Canonical link: https://commits.webkit.org/255447@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] daf8e7: Fix miscellaneous compiler warnings
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: daf8e774bb088209699af2f2c175078242da82b1 https://github.com/WebKit/WebKit/commit/daf8e774bb088209699af2f2c175078242da82b1 Author: Mikhail R. Gadelha Date: 2022-10-10 (Mon, 10 Oct 2022) Changed paths: M Source/JavaScriptCore/assembler/testmasm.cpp M Source/JavaScriptCore/runtime/ArrayBufferView.cpp M Source/WTF/wtf/text/StringCommon.h Log Message: --- Fix miscellaneous compiler warnings Reviewed by Darin Adler. * Source/JavaScriptCore/assembler/testmasm.cpp: (JSC::testExtractUnsignedBitfield32): fixed comparison of unsigned expression in ‘>= 0’ is always true * Source/WTF/wtf/text/StringCommon.h: (WTF::find): fixed comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ * Source/JavaScriptCore/runtime/ArrayBufferView.cpp: (JSC::ArrayBufferView::visitDerived): fixed control reaches end of non-void function Canonical link: https://commits.webkit.org/255360@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55fce2: [JSC][32bit] HashTable's deletedValue conflict wit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55fce2d2fa0fc5c39d9f7d198eb3ff91cbd03c3b https://github.com/WebKit/WebKit/commit/55fce2d2fa0fc5c39d9f7d198eb3ff91cbd03c3b Author: Mikhail R. Gadelha Date: 2022-10-10 (Mon, 10 Oct 2022) Changed paths: A JSTests/stress/hash-deleted-value-cell-32.js M Source/JavaScriptCore/heap/HeapUtil.h Log Message: --- [JSC][32bit] HashTable's deletedValue conflict with cell payload https://bugs.webkit.org/show_bug.cgi?id=246179 Reviewed by Darin Adler. When processing callees in the sampling profiler a cell payload can be 0x, which becomes -1 in 32bit systems, causing an assertion to fail in HashTable::checkKey when it compares the key to its default deletedValue (-1), but only when JSC is built with asserts enabled. This patch adds a guard to prevent checking the assertion if the cell is equal to the deletedValue by checking if the cell is a valid set value. It's only enabled in 32bit builds when asserts are enabled. * JSTests/stress/hash-deleted-value-cell-32.js: Added. (__getProperties): (__getRandomProperty): (startSamplingProfiler.__v_45.shouldThrow): (i.try.__v_45.shouldThrow): * Source/JavaScriptCore/heap/HeapUtil.h: (JSC::HeapUtil::isPointerGCObjectJSCell): Canonical link: https://commits.webkit.org/255332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22a4b3: [ARMv7][32bit] ASSERTION FAILED: CacheableIdentifi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22a4b34d6231dea23bdbf492e0c24e133f4c6e5d https://github.com/WebKit/WebKit/commit/22a4b34d6231dea23bdbf492e0c24e133f4c6e5d Author: Mikhail R. Gadelha Date: 2022-09-27 (Tue, 27 Sep 2022) Changed paths: A JSTests/stress/get-private-name-cell.js M Source/JavaScriptCore/bytecode/StructureStubInfo.cpp M Source/JavaScriptCore/bytecode/StructureStubInfo.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/jit/ICStats.h M Source/JavaScriptCore/jit/JITOperations.cpp Log Message: --- [ARMv7][32bit] ASSERTION FAILED: CacheableIdentifier::isCacheableIdentifierCell(fieldNameValue) https://bugs.webkit.org/show_bug.cgi?id=242640 Reviewed by Yusuke Suzuki. This patch adds AccessType::GetPrivateNameById, the corresponding slow path code, and changes compileGetPrivateNameById to use it when calling cachedGetById. The patch also includes some minor changes: 1. Adds default member initializer to StructureStubInfo 2. Rename argument names in JSValueRegs::withTwoAvailableRegs to be clearer 3. Fix typos in ICEVENT and where they are called * JSTests/stress/get-private-name-cell.js: Added. (__f_0): (__v_0.0.__c_0.prototype.field.this.init.init): (__v_0.0.__c_0.prototype.getField): (__v_0.0.__c_0): * Source/JavaScriptCore/bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::reset): (JSC::slowOperationFromUnlinkedStructureStubInfo): (JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo): * Source/JavaScriptCore/bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::appropriateOptimizingGetByIdFunction): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/jit/GPRInfo.h: (JSC::JSValueRegs::withTwoAvailableRegs): (JSC::JSValueRegs::payloadOnly): * Source/JavaScriptCore/jit/ICStats.h: * Source/JavaScriptCore/jit/JITOperations.cpp: (JSC::JSC_DEFINE_JIT_OPERATION): Canonical link: https://commits.webkit.org/254938@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9da55c: Fix clang GTK debug builds after 254605@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9da55c0a2eabf2c618ae5f85f65c859b8d2f72d7 https://github.com/WebKit/WebKit/commit/9da55c0a2eabf2c618ae5f85f65c859b8d2f72d7 Author: Mikhail R. Gadelha Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M Source/WTF/wtf/KeyValuePair.h Log Message: --- Fix clang GTK debug builds after 254605@main Unreviewed build fix. * Source/WTF/wtf/KeyValuePair.h: (WTF::KeyValuePair::KeyValuePair): Canonical link: https://commits.webkit.org/254616@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 700ac8: Ran clang-tidy on JSC, WTF and bmalloc
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 700ac83f17d8b756e640c6aaf20af02f9a6d08ce https://github.com/WebKit/WebKit/commit/700ac83f17d8b756e640c6aaf20af02f9a6d08ce Author: Mikhail R. Gadelha Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M Source/JavaScriptCore/API/JSClassRef.cpp M Source/JavaScriptCore/API/JSClassRef.h M Source/JavaScriptCore/API/JSObjectRef.cpp M Source/JavaScriptCore/API/JSScriptRef.cpp M Source/JavaScriptCore/API/OpaqueJSString.h M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h M Source/JavaScriptCore/assembler/AssemblerBuffer.h M Source/JavaScriptCore/assembler/CodeLocation.h M Source/JavaScriptCore/assembler/LinkBuffer.h M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h M Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h M Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h M Source/JavaScriptCore/assembler/MacroAssemblerPrinter.h M Source/JavaScriptCore/assembler/Printer.h M Source/JavaScriptCore/b3/B3ArgumentRegValue.cpp M Source/JavaScriptCore/b3/B3AtomicValue.cpp M Source/JavaScriptCore/b3/B3BasicBlock.cpp M Source/JavaScriptCore/b3/B3BlockInsertionSet.cpp M Source/JavaScriptCore/b3/B3CCallValue.cpp M Source/JavaScriptCore/b3/B3CaseCollection.h M Source/JavaScriptCore/b3/B3CheckSpecial.cpp M Source/JavaScriptCore/b3/B3CheckSpecial.h M Source/JavaScriptCore/b3/B3CheckValue.cpp M Source/JavaScriptCore/b3/B3Const32Value.cpp M Source/JavaScriptCore/b3/B3Const64Value.cpp M Source/JavaScriptCore/b3/B3ConstDoubleValue.cpp M Source/JavaScriptCore/b3/B3ConstFloatValue.cpp M Source/JavaScriptCore/b3/B3ConstrainedValue.h M Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp M Source/JavaScriptCore/b3/B3ExtractValue.cpp M Source/JavaScriptCore/b3/B3FenceValue.cpp M Source/JavaScriptCore/b3/B3FoldPathConstants.cpp M Source/JavaScriptCore/b3/B3InferSwitches.cpp M Source/JavaScriptCore/b3/B3Kind.h M Source/JavaScriptCore/b3/B3LowerToAir.cpp M Source/JavaScriptCore/b3/B3MemoryValue.cpp M Source/JavaScriptCore/b3/B3PCToOriginMap.h M Source/JavaScriptCore/b3/B3PatchpointSpecial.cpp M Source/JavaScriptCore/b3/B3PatchpointValue.cpp M Source/JavaScriptCore/b3/B3PhiChildren.cpp M Source/JavaScriptCore/b3/B3PhiChildren.h M Source/JavaScriptCore/b3/B3Procedure.cpp M Source/JavaScriptCore/b3/B3Procedure.h M Source/JavaScriptCore/b3/B3PureCSE.cpp M Source/JavaScriptCore/b3/B3ReduceStrength.cpp M Source/JavaScriptCore/b3/B3SSACalculator.cpp M Source/JavaScriptCore/b3/B3SSACalculator.h M Source/JavaScriptCore/b3/B3SlotBaseValue.cpp M Source/JavaScriptCore/b3/B3SparseCollection.h M Source/JavaScriptCore/b3/B3StackmapSpecial.cpp M Source/JavaScriptCore/b3/B3StackmapValue.cpp M Source/JavaScriptCore/b3/B3StackmapValue.h M Source/JavaScriptCore/b3/B3SuccessorCollection.h M Source/JavaScriptCore/b3/B3SwitchCase.h M Source/JavaScriptCore/b3/B3SwitchValue.cpp M Source/JavaScriptCore/b3/B3UpsilonValue.cpp M Source/JavaScriptCore/b3/B3UseCounts.cpp M Source/JavaScriptCore/b3/B3ValueKey.h M Source/JavaScriptCore/b3/B3Variable.cpp M Source/JavaScriptCore/b3/B3Variable.h M Source/JavaScriptCore/b3/B3VariableLiveness.cpp M Source/JavaScriptCore/b3/B3VariableValue.cpp M Source/JavaScriptCore/b3/B3WasmAddressValue.cpp M Source/JavaScriptCore/b3/B3WasmBoundsCheckValue.cpp M Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp M Source/JavaScriptCore/b3/air/AirAllocateStackByGraphColoring.cpp M Source/JavaScriptCore/b3/air/AirArg.h M Source/JavaScriptCore/b3/air/AirBlockInsertionSet.cpp M Source/JavaScriptCore/b3/air/AirCCallSpecial.cpp M Source/JavaScriptCore/b3/air/AirCode.cpp M Source/JavaScriptCore/b3/air/AirCode.h M Source/JavaScriptCore/b3/air/AirEmitShuffle.h M Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp M Source/JavaScriptCore/b3/air/AirInst.h M Source/JavaScriptCore/b3/air/AirKind.h M Source/JavaScriptCore/b3/air/AirLivenessAdapter.h M Source/JavaScriptCore/b3/air/AirOptimizeBlockOrder.cpp M Source/JavaScriptCore/b3/air/AirPhaseInsertionSet.h M Source/JavaScriptCore/b3/air/AirPrintSpecial.cpp M Source/JavaScriptCore/b3/air/AirRegLiveness.cpp M Source/JavaScriptCore/b3/air/AirRegLiveness.h M Source/JavaScriptCore/b3/air/AirSpecial.cpp M Source/JavaScriptCore/b3/air/AirTmp.h M Source/JavaScriptCore/b3/air/AirTmpSet.h M Source/JavaScriptCore/b3/air/AirTmpWidth.cpp M Source/JavaScriptCore/b3/air/AirTmpWidth.h M Source/JavaScriptCore/bytecode/AccessCaseSnippetParams.h M Source/JavaScriptCore/bytecode/ArithProfile.h M Source/JavaScriptCore/bytecode/ArrayProfile.h M Source/JavaScriptCore
