[webkit-changes] [WebKit/WebKit] c15c26: Unified build fixes on macOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c15c2658c2629382644f9ca7fdf4bccc7d4ee725 https://github.com/WebKit/WebKit/commit/c15c2658c2629382644f9ca7fdf4bccc7d4ee725 Author: Yury Semikhatsky Date: 2023-11-17 (Fri, 17 Nov 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h M Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm Log Message: --- Unified build fixes on macOS https://bugs.webkit.org/show_bug.cgi?id=264981 Unreviewed, adding some missing includes to fix unified build errors mentioned in the bug. * Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h: * Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm: Canonical link: https://commits.webkit.org/270895@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6955d: Web Inspector: update test to actually evaluate pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6955d53f2d33b7238ebdfa982c6bf056f20eb9d https://github.com/WebKit/WebKit/commit/b6955d53f2d33b7238ebdfa982c6bf056f20eb9d Author: Yury Semikhatsky Date: 2023-11-16 (Thu, 16 Nov 2023) Changed paths: M LayoutTests/inspector/runtime/callFunctionOn-awaitPromise.html Log Message: --- Web Inspector: update test to actually evaluate promise from iframe https://bugs.webkit.org/show_bug.cgi?id=264917 Reviewed by Devin Rousso. Updated the test to evaluate a promise that is actually created in the iframe. * LayoutTests/inspector/runtime/callFunctionOn-awaitPromise.html: Canonical link: https://commits.webkit.org/270830@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 700de8: Web Inspector: support awaitPromise parameter in R...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 700de83458a2ea7b582efa0fb8f50e748547847f https://github.com/WebKit/WebKit/commit/700de83458a2ea7b582efa0fb8f50e748547847f Author: Yury Semikhatsky Date: 2023-11-15 (Wed, 15 Nov 2023) Changed paths: A LayoutTests/inspector/runtime/callFunctionOn-awaitPromise-expected.txt A LayoutTests/inspector/runtime/callFunctionOn-awaitPromise.html M Source/JavaScriptCore/inspector/InjectedScript.cpp M Source/JavaScriptCore/inspector/InjectedScript.h M Source/JavaScriptCore/inspector/InjectedScriptSource.js M Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp M Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.h M Source/JavaScriptCore/inspector/protocol/Runtime.json M Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp M Source/WebCore/inspector/agents/page/PageRuntimeAgent.h Log Message: --- Web Inspector: support awaitPromise parameter in Runtime.callFunctionOn https://bugs.webkit.org/show_bug.cgi?id=264374 Reviewed by Devin Rousso. Added awaitPromise parameter to Runtime.callFunctionOn to allow getting result of an asyncronouse function call with a single protocol command. This allows to avoi possible navigation between Runtime.callFunctionOn command and subsequent Runtime.awaitPromise which invalidates the function result handle. * Source/JavaScriptCore/inspector/InjectedScript.cpp: (Inspector::InjectedScript::callFunctionOn): * Source/JavaScriptCore/inspector/InjectedScript.h: * Source/JavaScriptCore/inspector/InjectedScriptSource.js: (let.InjectedScript.prototype.callFunctionOn): * Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.cpp: (Inspector::InspectorRuntimeAgent::callFunctionOn): * Source/JavaScriptCore/inspector/agents/InspectorRuntimeAgent.h: * Source/JavaScriptCore/inspector/protocol/Runtime.json: * Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::callFunctionOn): * Source/WebCore/inspector/agents/page/PageRuntimeAgent.h: * LayoutTests/inspector/runtime/callFunctionOn-awaitPromise-expected.txt: Added. * LayoutTests/inspector/runtime/callFunctionOn-awaitPromise.html: Added. Canonical link: https://commits.webkit.org/270784@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4eed6: ScriptFunctionCall::call() can return an empty JSV...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4eed62b176cca45404f2c11f8a3dd2c4d3fe5df https://github.com/WebKit/WebKit/commit/a4eed62b176cca45404f2c11f8a3dd2c4d3fe5df Author: Yury Semikhatsky Date: 2023-11-14 (Tue, 14 Nov 2023) Changed paths: M Source/JavaScriptCore/inspector/InjectedScript.cpp M Source/JavaScriptCore/inspector/InjectedScriptBase.cpp M Source/JavaScriptCore/inspector/InjectedScriptModule.cpp Log Message: --- ScriptFunctionCall::call() can return an empty JSValue if the watchdog timer fires, callers should check for this https://bugs.webkit.org/show_bug.cgi?id=165875 Reviewed by Devin Rousso. ScriptFunctionCall::call() may return empty JSValue from several places, the callers now check for emptiness first before accessing the value. Unfortunately, I don't have a reliable repro which could be converted to a layout test like the one in https://github.com/WebKit/WebKit/commit/11d211bca821fa4803d6da95c857a04b7f32c46a even though the symptoms are similar. * Source/JavaScriptCore/inspector/InjectedScript.cpp: (Inspector::InjectedScript::wrapObject const): (Inspector::InjectedScript::wrapJSONString const): (Inspector::InjectedScript::wrapTable const): (Inspector::InjectedScript::previewValue const): (Inspector::InjectedScript::createCommandLineAPIObject const): Canonical link: https://commits.webkit.org/270739@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7d464f: [WPE] frameDisplayed may be called after View has ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7d464f717df9050f11fe11af583b82cd7800edc4 https://github.com/WebKit/WebKit/commit/7d464f717df9050f11fe11af583b82cd7800edc4 Author: Yury Semikhatsky Date: 2023-11-09 (Thu, 09 Nov 2023) Changed paths: M Source/WebKit/UIProcess/API/wpe/WPEView.cpp Log Message: --- [WPE] frameDisplayed may be called after View has been deleted https://bugs.webkit.org/show_bug.cgi?id=264360 Reviewed by Michael Catanzaro. WKWPE::View is set as a client to wpe_view_backend in the view's constructor. Since the backend may live longer than the view, we reset clear the client in the view destuctor to avoid use after free similar to the one mentioned in the bug. * Source/WebKit/UIProcess/API/wpe/WPEView.cpp: (WKWPE::View::~View): Canonical link: https://commits.webkit.org/270493@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 59ea48: [ Monterey+ WK2 ] http/tests/inspector/network/xhr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 59ea483f709d2732e0cdf15123f2da2750c653ab https://github.com/WebKit/WebKit/commit/59ea483f709d2732e0cdf15123f2da2750c653ab Author: Yury Semikhatsky Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt M LayoutTests/http/tests/inspector/network/xhr-request-type.html M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [ Monterey+ WK2 ] http/tests/inspector/network/xhr-request-type.html is a constant TEXT failure https://bugs.webkit.org/show_bug.cgi?id=259374 Reviewed by Fujii Hironori. Unflake the test: - use async XHR to ensure it comes after the main resource events - use echo to ensure that resource mime type returned by the server is always text/plain (previosly it could be application/octet-stream sometimes which caused base64 encoding of the resource) * LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt: * LayoutTests/http/tests/inspector/network/xhr-request-type.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/267688@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 883556: Web Inspector: XHR request with same URL as main r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 883556d2265f71ae3ff0ba8c595936d7884192e7 https://github.com/WebKit/WebKit/commit/883556d2265f71ae3ff0ba8c595936d7884192e7 Author: Yury Semikhatsky Date: 2023-05-30 (Tue, 30 May 2023) Changed paths: A LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt A LayoutTests/http/tests/inspector/network/xhr-request-type.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp Log Message: --- Web Inspector: XHR request with same URL as main resource should have type XHR https://bugs.webkit.org/show_bug.cgi?id=257407 Reviewed by Devin Rousso. Only use cached resource type when couldn't infer resource type based on the current ResourceRequest because CachedResource for the same URL may have different type. This fixes the bug where XHR is sent with the same URL as the main resource and was wrongly marked as another request with type Document rather than XHR. * LayoutTests/http/tests/inspector/network/xhr-request-type-expected.txt: Added. * LayoutTests/http/tests/inspector/network/xhr-request-type.html: Added. * Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::willSendRequest): * LayoutTests/platform/mac-wk1/TestExpectations: ignore new test in WK1. Canonical link: https://commits.webkit.org/264686@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 43c58c: Clean up TestExpectations after 264216@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 43c58cf6df2dc79b15a6fcdebe00ed7a5ceaf45d https://github.com/WebKit/WebKit/commit/43c58cf6df2dc79b15a6fcdebe00ed7a5ceaf45d Author: Yury Semikhatsky Date: 2023-05-26 (Fri, 26 May 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- Clean up TestExpectations after 264216@main https://bugs.webkit.org/show_bug.cgi?id=257409 Reviewed by Tim Nguyen. Removed mentions of the tests that have been moved to a different location or deleted. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/264616@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8050ec: [CURL] Add support for data url link downloads
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8050ec39e480cea3e8046942831a6edc31bf17d1 https://github.com/WebKit/WebKit/commit/8050ec39e480cea3e8046942831a6edc31bf17d1 Author: Yury Semikhatsky Date: 2023-04-26 (Wed, 26 Apr 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/platform/network/DataURLDecoder.h M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/PlatformPlayStation.cmake M Source/WebKit/PlatformWin.cmake Log Message: --- [CURL] Add support for data url link downloads https://bugs.webkit.org/show_bug.cgi?id=255696 Reviewed by Fujii Hironori. Curl does not support data: urls, handle them using NetworkDataTaskDataURL. * LayoutTests/platform/wincairo/TestExpectations: * Source/WebCore/platform/network/DataURLDecoder.h: * Source/WebKit/NetworkProcess/NetworkDataTask.cpp: * Source/WebKit/PlatformPlayStation.cmake Canonical link: https://commits.webkit.org/263434@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] afb133: [CURL][SOUP] Extract common data URL logic into sh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: afb1339d37f44414e98767bb0bc75cb0ab71c139 https://github.com/WebKit/WebKit/commit/afb1339d37f44414e98767bb0bc75cb0ab71c139 Author: Yury Semikhatsky Date: 2023-04-24 (Mon, 24 Apr 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkDataTask.cpp A Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp A Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.h M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt Log Message: --- [CURL][SOUP] Extract common data URL logic into shared NetworkDataTaskDataURL https://bugs.webkit.org/show_bug.cgi?id=255750 Reviewed by Fujii Hironori. Curl and Soup don't support data: URLs and the download logic for both of these platforms is mostly the same. This change extracts common bits of data urls handling into NetworkDataTaskDataURL which can be shared by both platforms. * Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp: Added. (WebKit::NetworkDataTaskDataURL::create): (WebKit::NetworkDataTaskDataURL::NetworkDataTaskDataURL): (WebKit::NetworkDataTaskDataURL::~NetworkDataTaskDataURL): (WebKit::NetworkDataTaskDataURL::resume): note that this task never gets back to the suspended state once it has been initially resumed. (WebKit::NetworkDataTaskDataURL::cancel): (WebKit::NetworkDataTaskDataURL::invalidateAndCancel): (WebKit::NetworkDataTaskDataURL::state const): (WebKit::NetworkDataTaskDataURL::setPendingDownloadLocation): (WebKit::NetworkDataTaskDataURL::suggestedFilename const): (WebKit::NetworkDataTaskDataURL::didDecodeDataURL): (WebKit::NetworkDataTaskDataURL::downloadDecodedData): * Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.h: Added. * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::create): (WebKit::NetworkDataTaskSoup::createRequest): (WebKit::NetworkDataTaskSoup::clearRequest): (WebKit::NetworkDataTaskSoup::resume): (WebKit::NetworkDataTaskSoup::didReadDataURL): Deleted. * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h: * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: Canonical link: https://flagged.apple.com:443/proxy?t2=DH9R9Z1MH2&o=https%3A%2F%2Fcommits.webkit.org%2F263349%40main&emid=d505eef2-b70a-4721-8897-0e0dd569eb07&c=11 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://flagged.apple.com:443/proxy?t2=DH9x2o0qc3&o=https%3A%2F%2Flists.webkit.org%2Fmailman%2Flistinfo%2Fwebkit-changes&emid=d505eef2-b70a-4721-8897-0e0dd569eb07&c=11
[webkit-changes] [WebKit/WebKit] 119fa0: [CURL] Do not attempt to create directories for in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 119fa0cb2ae6d59279a7ec2369cbc6b1b399dcb7 https://github.com/WebKit/WebKit/commit/119fa0cb2ae6d59279a7ec2369cbc6b1b399dcb7 Author: Yury Semikhatsky Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M Source/WebCore/platform/network/curl/CookieJarDB.cpp Log Message: --- [CURL] Do not attempt to create directories for in-memory cookie jar https://bugs.webkit.org/show_bug.cgi?id=255548 Reviewed by Fujii Hironori. When using ephemeral context the following error message was printed to the console: Unable to create the Cookie Database path :memory: * Source/WebCore/platform/network/curl/CookieJarDB.cpp: (WebCore::CookieJarDB::openDatabase): Canonical link: https://commits.webkit.org/263046@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 160e3d: [GCC] Build error in Ubuntu 20.04 after 262721@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 160e3d34e280d4ae287ce051e7cbb3b7d17e79b5 https://github.com/WebKit/WebKit/commit/160e3d34e280d4ae287ce051e7cbb3b7d17e79b5 Author: Yury Semikhatsky Date: 2023-04-11 (Tue, 11 Apr 2023) Changed paths: M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h Log Message: --- [GCC] Build error in Ubuntu 20.04 after 262721@main https://bugs.webkit.org/show_bug.cgi?id=255264 Reviewed by Philippe Normand. operator== requires explicit definition in GCC9.3. * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollbarHoverState::operator== const): (WebCore::ScrollbarHoverState::operator!= const): Canonical link: https://commits.webkit.org/262814@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c985ac: [WPE][GTK] web process leak if webkit_download_set...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c985acc37157f1ac8e7601e494ebd71bd76e6509 https://github.com/WebKit/WebKit/commit/c985acc37157f1ac8e7601e494ebd71bd76e6509 Author: Yury Semikhatsky Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp Log Message: --- [WPE][GTK] web process leak if webkit_download_set_destination is called with empty destination https://bugs.webkit.org/show_bug.cgi?id=242217 Reviewed by Michael Catanzaro. Fail if download destination is set to "". * Source/WebKit/UIProcess/API/glib/WebKitDownload.cpp: (webkit_download_set_destination): Canonical link: https://commits.webkit.org/256737@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
