from:"adamk"

[webkit-changes] [95071] trunk

2011-09-13 Thread adamk

Title: [95071] trunk








Revision 95071
Author ad...@chromium.org
Date 2011-09-13 19:09:25 -0700 (Tue, 13 Sep 2011)


Log Message
Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=68021

Reviewed by Tony Chang.

Source/WebCore:

Reported by valgrind in http://crbug.com/60653.

Besides fixing the uninitialized read, add support for outputting the
list separator for counters() calls and the list-style name.

Test: fast/css/counters/counter-cssText.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):

LayoutTests:

* fast/css/counters/counter-cssText-expected.txt: Added.
* fast/css/counters/counter-cssText.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp


Added Paths

trunk/LayoutTests/fast/css/counters/counter-cssText-expected.txt
trunk/LayoutTests/fast/css/counters/counter-cssText.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95070 => 95071)

--- trunk/LayoutTests/ChangeLog	2011-09-14 01:58:25 UTC (rev 95070)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 02:09:25 UTC (rev 95071)
@@ -1,3 +1,13 @@
+2011-09-13  Adam Klein  
+
+Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
+https://bugs.webkit.org/show_bug.cgi?id=68021
+
+Reviewed by Tony Chang.
+
+* fast/css/counters/counter-cssText-expected.txt: Added.
+* fast/css/counters/counter-cssText.html: Added.
+
 2011-09-13  Kenichi Ishibashi  
 
 WebFont followed tiny monospace text displays weird


Added: trunk/LayoutTests/fast/css/counters/counter-cssText-expected.txt (0 => 95071)

--- trunk/LayoutTests/fast/css/counters/counter-cssText-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/counters/counter-cssText-expected.txt	2011-09-14 02:09:25 UTC (rev 95071)
@@ -0,0 +1,13 @@
+Test the cssText output of counter-valued CSSPrimitiveValues
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS rules[2].style.cssText is "content: counter(section, decimal); "
+PASS rules[3].style.cssText is "content: counters(section, ':', decimal); "
+PASS rules[4].style.cssText is "content: counter(section, lower-roman); "
+PASS rules[5].style.cssText is "content: counters(section, ',', upper-roman); "
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/counters/counter-cssText.html (0 => 95071)

--- trunk/LayoutTests/fast/css/counters/counter-cssText.html	(rev 0)
+++ trunk/LayoutTests/fast/css/counters/counter-cssText.html	2011-09-14 02:09:25 UTC (rev 95071)
@@ -0,0 +1,39 @@
+
+
+
+body {
+counter-reset: section;
+}
+h1 {
+counter-increment: section;
+}
+h2:before {
+content: counter(section);
+}
+h2:after {
+content: counters(section, ":", decimal);
+}
+h3:before {
+content: counter(section, lower-roman);
+}
+h3:after {
+content: counters(section, ",", upper-roman);
+}
+
+
+
+
+
+description("Test the cssText output of counter-valued CSSPrimitiveValues");
+var rules = document.styleSheets[1].cssRules;
+shouldBeEqualToString("rules[2].style.cssText", "content: counter(section, decimal); ");
+shouldBeEqualToString("rules[3].style.cssText", "content: counters(section, ':', decimal); ");
+shouldBeEqualToString("rules[4].style.cssText", "content: counter(section, lower-roman); ");
+shouldBeEqualToString("rules[5].style.cssText", "content: counters(section, ',', upper-roman); ");
+window.successfullyParsed = true;
+
+

[webkit-changes] [95034] branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp

2011-09-13 Thread adamk

Title: [95034] branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp








Revision 95034
Author ad...@chromium.org
Date 2011-09-13 10:58:02 -0700 (Tue, 13 Sep 2011)


Log Message
Merge 95010 - Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958

Reviewed by Darin Adler.

Reported by Valgrind in http://crbug.com/77049.

The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.

No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.

* platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):


TBR=ad...@chromium.org
Review URL: http://codereview.chromium.org/7891013

Modified Paths

branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp




Diff

Modified: branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp (95033 => 95034)

--- branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp	2011-09-13 17:54:15 UTC (rev 95033)
+++ branches/chromium/874/Source/WebCore/platform/graphics/Gradient.cpp	2011-09-13 17:58:02 UTC (rev 95034)
@@ -124,10 +124,6 @@
 if (!m_stops.size())
 return;
 
-// Shortcut for the ideal case (ordered 2-stop gradient)
-if (m_stops.size() == 2 && compareStops(*m_stops.begin(), *m_stops.end()))
-return;
-
 std::stable_sort(m_stops.begin(), m_stops.end(), compareStops);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95010] trunk/Source/WebCore

2011-09-12 Thread adamk

Title: [95010] trunk/Source/WebCore








Revision 95010
Author ad...@chromium.org
Date 2011-09-12 20:55:41 -0700 (Mon, 12 Sep 2011)


Log Message
Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958

Reviewed by Darin Adler.

Reported by Valgrind in http://crbug.com/77049.

The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.

No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.

* platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Gradient.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95009 => 95010)

--- trunk/Source/WebCore/ChangeLog	2011-09-13 03:50:01 UTC (rev 95009)
+++ trunk/Source/WebCore/ChangeLog	2011-09-13 03:55:41 UTC (rev 95010)
@@ -1,3 +1,23 @@
+2011-09-12  Adam Klein  
+
+Fix out-of-bounds access in Gradient::sortStopsIfNecessary
+https://bugs.webkit.org/show_bug.cgi?id=67958
+
+Reviewed by Darin Adler.
+
+Reported by Valgrind in http://crbug.com/77049.
+
+The errant code was added as an optimization in r67804.
+This patch reverts that one, as all parties agree that the optimization
+doesn't seem worthwhile, and there clearly aren't any tests covering
+the special case.
+
+No new tests, as existing tests should cover the remaining call to
+|std::stable_sort|.
+
+* platform/graphics/Gradient.cpp:
+(WebCore::Gradient::sortStopsIfNecessary):
+
 2011-09-12  Jacky Jiang  
 
 Setting document.title doesn't affect contents of title tag of XHTML documents


Modified: trunk/Source/WebCore/platform/graphics/Gradient.cpp (95009 => 95010)

--- trunk/Source/WebCore/platform/graphics/Gradient.cpp	2011-09-13 03:50:01 UTC (rev 95009)
+++ trunk/Source/WebCore/platform/graphics/Gradient.cpp	2011-09-13 03:55:41 UTC (rev 95010)
@@ -124,10 +124,6 @@
 if (!m_stops.size())
 return;
 
-// Shortcut for the ideal case (ordered 2-stop gradient)
-if (m_stops.size() == 2 && compareStops(*m_stops.begin(), *m_stops.end()))
-return;
-
 std::stable_sort(m_stops.begin(), m_stops.end(), compareStops);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [94869] trunk/Source/WebCore

2011-09-09 Thread adamk

Title: [94869] trunk/Source/WebCore








Revision 94869
Author ad...@chromium.org
Date 2011-09-09 11:37:05 -0700 (Fri, 09 Sep 2011)


Log Message
Initialize ExceptionCode in Element::removeAttribute
https://bugs.webkit.org/show_bug.cgi?id=67820

Reviewed by Darin Adler.

Silences valgrind warning reported in http://crbug.com/76490.

No new tests since this would only very occasionally be flaky,
and in the codepath in the valgrind report, the ec is ignored anyway.

* dom/Element.cpp:
(WebCore::Element::removeAttribute): Initialize ec to 0.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (94868 => 94869)

--- trunk/Source/WebCore/ChangeLog	2011-09-09 18:21:54 UTC (rev 94868)
+++ trunk/Source/WebCore/ChangeLog	2011-09-09 18:37:05 UTC (rev 94869)
@@ -1,3 +1,18 @@
+2011-09-09  Adam Klein  
+
+Initialize ExceptionCode in Element::removeAttribute
+https://bugs.webkit.org/show_bug.cgi?id=67820
+
+Reviewed by Darin Adler.
+
+Silences valgrind warning reported in http://crbug.com/76490.
+
+No new tests since this would only very occasionally be flaky,
+and in the codepath in the valgrind report, the ec is ignored anyway.
+
+* dom/Element.cpp:
+(WebCore::Element::removeAttribute): Initialize ec to 0.
+
 2011-09-09  Laszlo Gombos  
 
 [Qt] Remove common.pri


Modified: trunk/Source/WebCore/dom/Element.cpp (94868 => 94869)

--- trunk/Source/WebCore/dom/Element.cpp	2011-09-09 18:21:54 UTC (rev 94868)
+++ trunk/Source/WebCore/dom/Element.cpp	2011-09-09 18:37:05 UTC (rev 94869)
@@ -1520,6 +1520,7 @@
 String localName = shouldIgnoreAttributeCase(this) ? name.lower() : name;
 
 if (m_attributeMap) {
+ec = 0;
 m_attributeMap->removeNamedItem(localName, ec);
 if (ec == NOT_FOUND_ERR)
 ec = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [94824] trunk/Source/WebCore

2011-09-08 Thread adamk

Title: [94824] trunk/Source/WebCore








Revision 94824
Author ad...@chromium.org
Date 2011-09-08 18:14:50 -0700 (Thu, 08 Sep 2011)


Log Message
Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator
https://bugs.webkit.org/show_bug.cgi?id=67810

Reviewed by Tony Chang.

Reported as a valgrind failure in http://crbug.com/84777.

No possible change in behavior, so no tests. The unitialized read
could never have an impact:

   if (m_sortedTextBoxesPosition + 1 < m_sortedTextBoxes.size()) ...

Since m_sortedTextBoxes.size() will be zero here if
m_sortedTextBoxesPosition is uninitialized, and they're both unsigned,
so no possible value of m_sortedTextBoxesPosition could be < 0.

* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextIterator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (94823 => 94824)

--- trunk/Source/WebCore/ChangeLog	2011-09-09 00:50:09 UTC (rev 94823)
+++ trunk/Source/WebCore/ChangeLog	2011-09-09 01:14:50 UTC (rev 94824)
@@ -1,3 +1,24 @@
+2011-09-08  Adam Klein  
+
+Always zero-out m_sortedTextBoxesPosition to avoid uninitialized read in TextIterator
+https://bugs.webkit.org/show_bug.cgi?id=67810
+
+Reviewed by Tony Chang.
+
+Reported as a valgrind failure in http://crbug.com/84777.
+
+No possible change in behavior, so no tests. The unitialized read
+could never have an impact:
+
+   if (m_sortedTextBoxesPosition + 1 < m_sortedTextBoxes.size()) ...
+
+Since m_sortedTextBoxes.size() will be zero here if
+m_sortedTextBoxesPosition is uninitialized, and they're both unsigned,
+so no possible value of m_sortedTextBoxesPosition could be < 0.
+
+* editing/TextIterator.cpp:
+(WebCore::TextIterator::TextIterator):
+
 2011-09-08  Tony Chang  
 
 Cleanup of switch statements with default cases


Modified: trunk/Source/WebCore/editing/TextIterator.cpp (94823 => 94824)

--- trunk/Source/WebCore/editing/TextIterator.cpp	2011-09-09 00:50:09 UTC (rev 94823)
+++ trunk/Source/WebCore/editing/TextIterator.cpp	2011-09-09 01:14:50 UTC (rev 94824)
@@ -253,6 +253,7 @@
 , m_remainingTextBox(0)
 , m_firstLetterText(0)
 , m_lastCharacter(0)
+, m_sortedTextBoxesPosition(0)
 , m_emitsCharactersBetweenAllVisiblePositions(false)
 , m_entersTextControls(false)
 , m_emitsTextWithoutTranscoding(false)
@@ -272,6 +273,7 @@
 , m_textLength(0)
 , m_remainingTextBox(0)
 , m_firstLetterText(0)
+, m_sortedTextBoxesPosition(0)
 , m_emitsCharactersBetweenAllVisiblePositions(behavior & TextIteratorEmitsCharactersBetweenAllVisiblePositions)
 , m_entersTextControls(behavior & TextIteratorEntersTextControls)
 , m_emitsTextWithoutTranscoding(behavior & TextIteratorEmitsTextsWithoutTranscoding)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93809] trunk/Source/WebCore

2011-08-25 Thread adamk

Title: [93809] trunk/Source/WebCore








Revision 93809
Author ad...@chromium.org
Date 2011-08-25 12:44:06 -0700 (Thu, 25 Aug 2011)


Log Message
use strict in CodeGeneratorJS and CodeGeneratorV8
https://bugs.webkit.org/show_bug.cgi?id=66915

Reviewed by Darin Adler.

Making these files "use strict" makes changing them less
time-consuming and error-prone, and helps avoid accidentally
adding dead code (added a FIXME for one such case).

No expected change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(NativeToJSValue):
(GenerateHashValue):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateNormalAttrSetter):
(GetFunctionTemplateCallbackName):
(GenerateNewFunctionTemplate):
(GenerateParametersCheckExpression):
(GenerateFunctionParametersCheck):
(GenerateImplementation):
():

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (93808 => 93809)

--- trunk/Source/WebCore/ChangeLog	2011-08-25 19:21:41 UTC (rev 93808)
+++ trunk/Source/WebCore/ChangeLog	2011-08-25 19:44:06 UTC (rev 93809)
@@ -1,3 +1,35 @@
+2011-08-25  Adam Klein  
+
+use strict in CodeGeneratorJS and CodeGeneratorV8
+https://bugs.webkit.org/show_bug.cgi?id=66915
+
+Reviewed by Darin Adler.
+
+Making these files "use strict" makes changing them less
+time-consuming and error-prone, and helps avoid accidentally
+adding dead code (added a FIXME for one such case).
+
+No expected change in behavior.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(AddIncludesForType):
+(GenerateParametersCheckExpression):
+(GenerateFunctionParametersCheck):
+(GenerateImplementation):
+(GenerateImplementationFunctionCall):
+(NativeToJSValue):
+(GenerateHashValue):
+* bindings/scripts/CodeGeneratorV8.pm:
+(AddIncludesForType):
+(GenerateHeaderNamedAndIndexedPropertyAccessors):
+(GenerateNormalAttrSetter):
+(GetFunctionTemplateCallbackName):
+(GenerateNewFunctionTemplate):
+(GenerateParametersCheckExpression):
+(GenerateFunctionParametersCheck):
+(GenerateImplementation):
+():
+
 2011-08-25  Dean Jackson  
 
 https://bugs.webkit.org/show_bug.cgi?id=21586


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (93808 => 93809)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-25 19:21:41 UTC (rev 93808)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-25 19:44:06 UTC (rev 93809)
@@ -26,6 +26,10 @@
 
 package CodeGeneratorJS;
 
+use strict;
+
+my ($codeGenerator, $IMPL, $HEADER, $DEPS);
+
 my $module = "";
 my $outputDir = "";
 my $writeDependencies = 0;
@@ -281,7 +285,7 @@
 if ($codeGenerator->IsPrimitiveType($type) or $codeGenerator->AvoidInclusionOfType($type)
 or $type eq "DOMString" or $type eq "DOMObject" or $type eq "Array") {
 } elsif ($type =~ /SVGPathSeg/) {
-$joinedName = $type;
+my $joinedName = $type;
 $joinedName =~ s/Abs|Rel//;
 $includesRef->{"${joinedName}.h"} = 1;
 } elsif ($type eq "XPathNSResolver") {
@@ -1182,7 +1186,7 @@
 push(@andExpression, "argsCount == $numParameters");
 my $parameterIndex = 0;
 my %usedArguments = ();
-foreach $parameter (@{$function->parameters}) {
+foreach my $parameter (@{$function->parameters}) {
 last if $parameterIndex >= $numParameters;
 my $value = "arg$parameterIndex";
 my $type = $codeGenerator->StripModule($parameter->type);
@@ -1217,7 +1221,7 @@
 my $numParameters = 0;
 my @neededArguments = ();
 
-foreach $parameter (@{$function->parameters}) {
+foreach my $parameter (@{$function->parameters}) {
 if ($parameter->extendedAttributes->{"Optional"}) {
 my ($_expression_, @usedArguments) = GenerateParametersCheckExpression($numParameters, $function);
 push(@orExpression, $_expression_);
@@ -1312,13 +1316,13 @@
 
 # - Add all constants
 if (!($dataNode->extendedAttributes->{"OmitConstructor"} || $dataNode->extendedAttributes->{"CustomConstructor"})) {
-$hashSize = $numConstants;
-$hashName = $className . "ConstructorTable";
+my $hashSize = $numConstants;
+my $hashName = $className . "ConstructorTable";
 
-@hashKeys = ();
-@hashValue1 = ();
-@hashValue2 = ();
-@hashSpecials = ();
+my @hashKeys = ();
+my @hashValue1 = ();
+my @hashValue2 = ();
+my @hashSpecials = ();
 
 # FIXME: we should not need a function for every constant.

[webkit-changes] [93632] trunk/Source/WebKit/chromium

2011-08-23 Thread adamk

Title: [93632] trunk/Source/WebKit/chromium








Revision 93632
Author ad...@chromium.org
Date 2011-08-23 13:19:09 -0700 (Tue, 23 Aug 2011)


Log Message
[chromium] Remove a few FIXME #defines in API headers
https://bugs.webkit.org/show_bug.cgi?id=66791

Reviewed by James Robinson.

* DEPS:
Roll chromium_rev to r97891.
* public/WebFileSystem.h:
#define made obsolete in http://crrev.com/97520.
* public/WebKitClient.h:
#define made obsolete in http://crrev.com/97524 and
http://crrev.com/97891.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/public/WebFileSystem.h
trunk/Source/WebKit/chromium/public/WebKitClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (93631 => 93632)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-23 20:10:46 UTC (rev 93631)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-23 20:19:09 UTC (rev 93632)
@@ -1,3 +1,19 @@
+2011-08-23  Adam Klein  
+
+[chromium] Remove a few FIXME #defines in API headers
+https://bugs.webkit.org/show_bug.cgi?id=66791
+
+Reviewed by James Robinson.
+
+* DEPS:
+Roll chromium_rev to r97891.
+* public/WebFileSystem.h:
+#define made obsolete in http://crrev.com/97520.
+* public/WebKitClient.h:
+#define made obsolete in http://crrev.com/97524 and
+http://crrev.com/97891.
+
+
 2011-08-23  Al Patrick  
 
 Add shareResources flag to 3D graphics context attributes


Modified: trunk/Source/WebKit/chromium/DEPS (93631 => 93632)

--- trunk/Source/WebKit/chromium/DEPS	2011-08-23 20:10:46 UTC (rev 93631)
+++ trunk/Source/WebKit/chromium/DEPS	2011-08-23 20:19:09 UTC (rev 93632)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '97834'
+  'chromium_rev': '97891'
 }
 
 deps = {


Modified: trunk/Source/WebKit/chromium/public/WebFileSystem.h (93631 => 93632)

--- trunk/Source/WebKit/chromium/public/WebFileSystem.h	2011-08-23 20:10:46 UTC (rev 93631)
+++ trunk/Source/WebKit/chromium/public/WebFileSystem.h	2011-08-23 20:19:09 UTC (rev 93632)
@@ -40,9 +40,6 @@
 class WebFileWriter;
 class WebFileWriterClient;
 
-// FIXME(zelidrag): Remove this define once Chromium side catches up.
-#define WEB_FILE_SYSTEM_TYPE_EXTERNAL
-
 class WebFileSystem {
 public:
 enum Type {


Modified: trunk/Source/WebKit/chromium/public/WebKitClient.h (93631 => 93632)

--- trunk/Source/WebKit/chromium/public/WebKitClient.h	2011-08-23 20:10:46 UTC (rev 93631)
+++ trunk/Source/WebKit/chromium/public/WebKitClient.h	2011-08-23 20:19:09 UTC (rev 93632)
@@ -47,9 +47,6 @@
 typedef void *HANDLE;
 #endif
 
-// FIXME: remove after rolling deps
-#define WEBKIT_USE_MONOTONIC_CLOCK_FOR_TIMER_SCHEDULING
-
 namespace WebKit {
 
 class WebApplicationCacheHost;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [93553] trunk/Source/WebKit/chromium

2011-08-22 Thread adamk

Title: [93553] trunk/Source/WebKit/chromium








Revision 93553
Author ad...@chromium.org
Date 2011-08-22 15:44:31 -0700 (Mon, 22 Aug 2011)


Log Message
[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711

Reviewed by Tony Chang.

The Chromium side of this patch was submitted as
http://crrev.com/97687.

* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h
trunk/Source/WebKit/chromium/public/WebIDBCursor.h
trunk/Source/WebKit/chromium/public/WebIDBDatabase.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (93552 => 93553)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-22 22:44:31 UTC (rev 93553)
@@ -1,3 +1,21 @@
+2011-08-22  Adam Klein  
+
+[chromium] Remove deprecated and unused bits of WebIDB* headers
+https://bugs.webkit.org/show_bug.cgi?id=66711
+
+Reviewed by Tony Chang.
+
+The Chromium side of this patch was submitted as
+http://crrev.com/97687.
+
+* public/WebIDBCallbacks.h:
+* public/WebIDBCursor.h:
+(WebKit::WebIDBCursor::primaryKey):
+(WebKit::WebIDBCursor::value):
+(WebKit::WebIDBCursor::deleteFunction):
+* public/WebIDBDatabase.h:
+(WebKit::WebIDBDatabase::transaction):
+
 2011-08-22  Dimitri Glazkov  
 
 Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.


Modified: trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h (93552 => 93553)

--- trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h	2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBCallbacks.h	2011-08-22 22:44:31 UTC (rev 93553)
@@ -49,8 +49,6 @@
 virtual void onSuccess(WebIDBCursor*) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void onSuccess(WebIDBDatabase*) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void onSuccess(const WebIDBKey&) { WEBKIT_ASSERT_NOT_REACHED(); }
-// FIXME: remove after Webkit roll.
-virtual void onSuccess(WebIDBIndex*) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void onSuccess(WebIDBTransaction*) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void onSuccess(const WebSerializedScriptValue&) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void onBlocked() { WEBKIT_ASSERT_NOT_REACHED(); }


Modified: trunk/Source/WebKit/chromium/public/WebIDBCursor.h (93552 => 93553)

--- trunk/Source/WebKit/chromium/public/WebIDBCursor.h	2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBCursor.h	2011-08-22 22:44:31 UTC (rev 93553)
@@ -55,29 +55,15 @@
 WEBKIT_ASSERT_NOT_REACHED();
 return WebIDBKey::createInvalid();
 }
-// FIXME: Remove the following 2 methods and uncomment third after roll.
 virtual WebSerializedScriptValue value() const
 {
-WebSerializedScriptValue serializedScriptValue;
-WebIDBKey key;
-value(serializedScriptValue, key);
-return serializedScriptValue;
+WEBKIT_ASSERT_NOT_REACHED();
+return WebSerializedScriptValue();
 }
-virtual void value(WebSerializedScriptValue& serializedScriptValue, WebIDBKey& key) const
-{
-serializedScriptValue = value();
-}
-// virtual WebSerializedScriptValue value() const
-// {
-// WEBKIT_ASSERT_NOT_REACHED();
-// return WebSerializedScriptValue();
-// }
 
 virtual void update(const WebSerializedScriptValue&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
 virtual void continueFunction(const WebIDBKey&, WebIDBCallbacks*, WebExceptionCode&) { WEBKIT_ASSERT_NOT_REACHED(); }
-// FIXME: Remove after WK roll.
-virtual void remove(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { deleteFunction(callbacks, ec); }
-virtual void deleteFunction(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { remove(callbacks, ec); }
+virtual void deleteFunction(WebIDBCallbacks* callbacks, WebExceptionCode& ec) { WEBKIT_ASSERT_NOT_REACHED(); }
 
 protected:
 WebIDBCursor() { }


Modified: trunk/Source/WebKit/chromium/public/WebIDBDatabase.h (93552 => 93553)

--- trunk/Source/WebKit/chromium/public/WebIDBDatabase.h	2011-08-22 22:35:53 UTC (rev 93552)
+++ trunk/Source/WebKit/chromium/public/WebIDBDatabase.h	2011-08-22 22:44:31 UTC (rev 93553)
@@ -68,13 +68,9 @@
 // Transfers ownership of the WebIDBTransaction to the caller.
 virtual WebIDBTransaction* transaction(const WebDOMStringList& names, unsigned short mode, WebExceptionCode& ec)
 {
-return transaction(names, mode, 0, ec);
+WEBKIT_ASSERT_NOT_REACHED();
+return 0;
 }
-// FIXME: R

[webkit-changes] [93449] trunk/Source/WebKit/chromium

2011-08-19 Thread adamk

Title: [93449] trunk/Source/WebKit/chromium








Revision 93449
Author ad...@chromium.org
Date 2011-08-19 16:18:11 -0700 (Fri, 19 Aug 2011)


Log Message
[chromium] Remove various unreferenced bits from Chromium API headers
https://bugs.webkit.org/show_bug.cgi?id=66575

Reviewed by Tony Chang.

* public/WebApplicationCacheHost.h:
(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
* public/WebFrame.h:
* public/WebFrameClient.h:
(WebKit::WebFrameClient::didReceiveTitle):
* public/WebVideoFrame.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebApplicationCacheHost.h
trunk/Source/WebKit/chromium/public/WebFrame.h
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/public/WebVideoFrame.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (93448 => 93449)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-19 22:53:27 UTC (rev 93448)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-19 23:18:11 UTC (rev 93449)
@@ -1,3 +1,17 @@
+2011-08-19  Adam Klein  
+
+[chromium] Remove various unreferenced bits from Chromium API headers
+https://bugs.webkit.org/show_bug.cgi?id=66575
+
+Reviewed by Tony Chang.
+
+* public/WebApplicationCacheHost.h:
+(WebKit::WebApplicationCacheHost::willStartMainResourceRequest):
+* public/WebFrame.h:
+* public/WebFrameClient.h:
+(WebKit::WebFrameClient::didReceiveTitle):
+* public/WebVideoFrame.h:
+
 2011-08-19  Fady Samuel  
 
 Expose Fixed Layout Size mode to Chromium's WebKit API


Modified: trunk/Source/WebKit/chromium/public/WebApplicationCacheHost.h (93448 => 93449)

--- trunk/Source/WebKit/chromium/public/WebApplicationCacheHost.h	2011-08-19 22:53:27 UTC (rev 93448)
+++ trunk/Source/WebKit/chromium/public/WebApplicationCacheHost.h	2011-08-19 23:18:11 UTC (rev 93449)
@@ -74,11 +74,9 @@
 virtual ~WebApplicationCacheHost() { }
 
 // Called for every request made within the context.
-virtual void willStartMainResourceRequest(WebURLRequest& r, const WebFrame*) { willStartMainResourceRequest(r); }
+virtual void willStartMainResourceRequest(WebURLRequest& r, const WebFrame*) { }
 virtual void willStartSubResourceRequest(WebURLRequest&) { }
 
-virtual void willStartMainResourceRequest(WebURLRequest&) { } // DEPRECATED, remove after derived classes have caught up.
-
 // One or the other selectCache methods is called after having parsed the  tag.
 // The latter returns false if the current document has been identified as a "foreign"
 // entry, in which case the frame navigation will be restarted by webkit.
@@ -121,4 +119,3 @@
 }  // namespace WebKit
 
 #endif  // WebApplicationCacheHost_h
-


Modified: trunk/Source/WebKit/chromium/public/WebFrame.h (93448 => 93449)

--- trunk/Source/WebKit/chromium/public/WebFrame.h	2011-08-19 22:53:27 UTC (rev 93448)
+++ trunk/Source/WebKit/chromium/public/WebFrame.h	2011-08-19 23:18:11 UTC (rev 93449)
@@ -37,8 +37,6 @@
 #include "WebNode.h"
 #include "WebURL.h"
 #include "WebURLLoaderOptions.h"
-// FIXME : Remove this file when transient done.
-#include "WebVector.h"
 
 struct NPObject;
 


Modified: trunk/Source/WebKit/chromium/public/WebFrameClient.h (93448 => 93449)

--- trunk/Source/WebKit/chromium/public/WebFrameClient.h	2011-08-19 22:53:27 UTC (rev 93448)
+++ trunk/Source/WebKit/chromium/public/WebFrameClient.h	2011-08-19 23:18:11 UTC (rev 93449)
@@ -209,12 +209,7 @@
 virtual void didCreateDocumentElement(WebFrame*) { }
 
 // The page title is available.
-// FIXME: remove override once Chrome is updated to new API.
-virtual void didReceiveTitle(WebFrame*, const WebString& title) { }
-virtual void didReceiveTitle(WebFrame* frame, const WebString& title, WebTextDirection direction)
-{
-didReceiveTitle(frame, title);
-}
+virtual void didReceiveTitle(WebFrame* frame, const WebString& title, WebTextDirection direction) { }
 
 // The icon for the page have changed.
 virtual void didChangeIcon(WebFrame*, WebIconURL::Type) { }


Modified: trunk/Source/WebKit/chromium/public/WebVideoFrame.h (93448 => 93449)

--- trunk/Source/WebKit/chromium/public/WebVideoFrame.h	2011-08-19 22:53:27 UTC (rev 93448)
+++ trunk/Source/WebKit/chromium/public/WebVideoFrame.h	2011-08-19 23:18:11 UTC (rev 93449)
@@ -51,12 +51,6 @@
 FormatASCII,
 };
 
-// FIXME: delete once Chromium has updated to remove references.
-enum SurfaceType {
-SurfaceTypeSystemMemory,
-SurfaceTypeTexture,
-};
-
 virtual ~WebVideoFrame() { }
 virtual Format format() const = 0;
 virtual unsigned width() const = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [91900] trunk/Source/WebCore

2011-07-27 Thread adamk

Title: [91900] trunk/Source/WebCore








Revision 91900
Author ad...@chromium.org
Date 2011-07-27 21:32:39 -0700 (Wed, 27 Jul 2011)


Log Message
[V8] Remove unused m_isWeak member of V8AbstractEventListener
https://bugs.webkit.org/show_bug.cgi?id=65273

Reviewed by Adam Barth.

m_isWeak is set to true in the constructor and never changed,
so the one if statement that tests it always executes; the
code has been updated to make this clear.

No behavior change, thus no tests.

* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):
* bindings/v8/V8AbstractEventListener.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp
trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (91899 => 91900)

--- trunk/Source/WebCore/ChangeLog	2011-07-28 04:23:06 UTC (rev 91899)
+++ trunk/Source/WebCore/ChangeLog	2011-07-28 04:32:39 UTC (rev 91900)
@@ -1,3 +1,21 @@
+2011-07-27  Adam Klein  
+
+[V8] Remove unused m_isWeak member of V8AbstractEventListener
+https://bugs.webkit.org/show_bug.cgi?id=65273
+
+Reviewed by Adam Barth.
+
+m_isWeak is set to true in the constructor and never changed,
+so the one if statement that tests it always executes; the
+code has been updated to make this clear.
+
+No behavior change, thus no tests.
+
+* bindings/v8/V8AbstractEventListener.cpp:
+(WebCore::V8AbstractEventListener::V8AbstractEventListener):
+(WebCore::V8AbstractEventListener::setListenerObject):
+* bindings/v8/V8AbstractEventListener.h:
+
 2011-07-27  Fady Samuel  
 
 Popups on Chromium now check the minimum row height set through the Chromium WebKit API when


Modified: trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp (91899 => 91900)

--- trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp	2011-07-28 04:23:06 UTC (rev 91899)
+++ trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.cpp	2011-07-28 04:32:39 UTC (rev 91900)
@@ -54,7 +54,6 @@
 
 V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, const WorldContextHandle& worldContext)
 : EventListener(JSEventListenerType)
-, m_isWeak(true)
 , m_isAttribute(isAttribute)
 , m_worldContext(worldContext)
 {
@@ -116,8 +115,7 @@
 #ifndef NDEBUG
 V8GCController::registerGlobalHandle(EVENT_LISTENER, this, m_listener);
 #endif
-if (m_isWeak)
-m_listener.MakeWeak(this, &weakEventListenerCallback);
+m_listener.MakeWeak(this, &weakEventListenerCallback);
 }
 
 void V8AbstractEventListener::invokeEventHandler(ScriptExecutionContext* context, Event* event, v8::Handle jsEvent)


Modified: trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.h (91899 => 91900)

--- trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.h	2011-07-28 04:23:06 UTC (rev 91899)
+++ trunk/Source/WebCore/bindings/v8/V8AbstractEventListener.h	2011-07-28 04:32:39 UTC (rev 91900)
@@ -89,8 +89,7 @@
 }
 
 // Provides access to the underlying handle for GC. Returned
-// value might be a weak handle and so not guaranteed to stay
-// alive.
+// value is a weak handle and so not guaranteed to stay alive.
 v8::Persistent existingListenerObjectPersistentHandle()
 {
 return m_listener;
@@ -126,9 +125,6 @@
 
 v8::Persistent m_listener;
 
-// Indicates if the above handle is weak.
-bool m_isWeak;
-
 // Indicates if this is an HTML type listener.
 bool m_isAttribute;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [89870] trunk/LayoutTests

2011-06-27 Thread adamk

Title: [89870] trunk/LayoutTests








Revision 89870
Author ad...@chromium.org
Date 2011-06-27 15:31:36 -0700 (Mon, 27 Jun 2011)


Log Message
2011-06-27  Adam Klein  

Reviewed by Adam Barth.

Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
https://bugs.webkit.org/show_bug.cgi?id=63486

* fast/filesystem/filesystem-no-callback-null-ptr-crash.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (89869 => 89870)

--- trunk/LayoutTests/ChangeLog	2011-06-27 22:18:15 UTC (rev 89869)
+++ trunk/LayoutTests/ChangeLog	2011-06-27 22:31:36 UTC (rev 89870)
@@ -1,3 +1,12 @@
+2011-06-27  Adam Klein  
+
+Reviewed by Adam Barth.
+
+Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
+https://bugs.webkit.org/show_bug.cgi?id=63486
+
+* fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
+
 2011-06-27  Jay Civelli  
 
 Reviewed by Darin Fisher.


Modified: trunk/LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html (89869 => 89870)

--- trunk/LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html	2011-06-27 22:18:15 UTC (rev 89869)
+++ trunk/LayoutTests/fast/filesystem/filesystem-no-callback-null-ptr-crash.html	2011-06-27 22:31:36 UTC (rev 89870)
@@ -6,8 +6,10 @@
 
   if (window.layoutTestController)
   layoutTestController.dumpAsText();
-  // These two calls so not cause a NULL pointer crash:
-  try { window.requestFileSystem(10); } catch (e) {}
-  try { window.resolveLocalFileSystemURI(); } catch (e) {}
-  document.getElementById('log').innerHTML = "PASS";
+  if (window.webkitRequestFileSystem) {
+  // These two calls should not cause a NULL pointer crash:
+  webkitRequestFileSystem(TEMPORARY, 100);
+  webkitResolveLocalFileSystemURL('');
+  document.getElementById('log').innerHTML = "PASS";
+  }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87590] trunk/LayoutTests

2011-05-27 Thread adamk

Title: [87590] trunk/LayoutTests








Revision 87590
Author ad...@chromium.org
Date 2011-05-27 18:24:21 -0700 (Fri, 27 May 2011)


Log Message
2011-05-27  Adam Klein  

Unreviewed. Hopefully last rebaseline from r87526.

* platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/svg/hixie/text/
trunk/LayoutTests/platform/chromium-mac-leopard/svg/hixie/text/003-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87589 => 87590)

--- trunk/LayoutTests/ChangeLog	2011-05-28 00:30:18 UTC (rev 87589)
+++ trunk/LayoutTests/ChangeLog	2011-05-28 01:24:21 UTC (rev 87590)
@@ -1,5 +1,11 @@
 2011-05-27  Adam Klein  
 
+Unreviewed. Hopefully last rebaseline from r87526.
+
+* platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.
+
+2011-05-27  Adam Klein  
+
 Unreviewed. Even more rebaselines after r87526.
 
 * platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.


Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/hixie/text/003-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/hixie/text/003-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87589] trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-05-27 Thread adamk

Title: [87589] trunk/LayoutTests/platform/chromium/test_expectations.txt








Revision 87589
Author ad...@chromium.org
Date 2011-05-27 17:30:18 -0700 (Fri, 27 May 2011)


Log Message
Unreviewed test expectations update: Vista flakiness.

Modified Paths

trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87588 => 87589)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-28 00:28:56 UTC (rev 87588)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-28 00:30:18 UTC (rev 87589)
@@ -4012,6 +4012,9 @@
 BUGCR84093 VISTA : http/tests/history/redirect-200-refresh-2-seconds.pl = TIMEOUT PASS
 BUGCR84095 VISTA : svg/custom/use-detach.svg = TIMEOUT PASS
 
+// Flaky for a long time with no obvious cause.
+BUGADAMK VISTA : http/tests/history/redirect-301.html = TIMEOUT PASS
+
 BUGWK61611 LINUX WIN : editing/pasteboard/interchange-newline-2.html = TEXT
 
 BUGWK61613 WIN : http/tests/local/formdata/form-data-with-unknown-file-extension.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87587] trunk/LayoutTests

2011-05-27 Thread adamk

Title: [87587] trunk/LayoutTests








Revision 87587
Author ad...@chromium.org
Date 2011-05-27 17:26:19 -0700 (Fri, 27 May 2011)


Log Message
2011-05-27  Adam Klein  

Unreviewed. Even more rebaselines after r87526.

* platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
* platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
* platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/wicd/
trunk/LayoutTests/platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
trunk/LayoutTests/platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png
trunk/LayoutTests/platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87586 => 87587)

--- trunk/LayoutTests/ChangeLog	2011-05-27 23:53:36 UTC (rev 87586)
+++ trunk/LayoutTests/ChangeLog	2011-05-28 00:26:19 UTC (rev 87587)
@@ -1,3 +1,21 @@
+2011-05-27  Adam Klein  
+
+Unreviewed. Even more rebaselines after r87526.
+
+* platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
+* platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
+* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
+* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
+* platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
+* platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
+* platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
+* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
+* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
+* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
+* platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
+* platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-05-27  Steve Lacey  
 
 Reviewed by Eric Carlson.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87586 => 87587)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 23:53:36 UTC (rev 87586)
+++ trunk/LayoutTests/platform/chromium/test

[webkit-changes] [87584] trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-05-27 Thread adamk

Title: [87584] trunk/LayoutTests/platform/chromium/test_expectations.txt








Revision 87584
Author ad...@chromium.org
Date 2011-05-27 16:21:33 -0700 (Fri, 27 May 2011)


Log Message
Unreviewed test expectations update: widen flakiness to include Linux.

Modified Paths

trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87583 => 87584)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 23:18:07 UTC (rev 87583)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 23:21:33 UTC (rev 87584)
@@ -3651,7 +3651,7 @@
 BUGDPRANKE WIN DEBUG : perf/mouse-event.html = TEXT TIMEOUT PASS
 BUGDPRANKE WIN DEBUG : perf/typing-at-end-of-line.html = TEXT TIMEOUT PASS
 BUGDPRANKE DEBUG : fast/notifications/notifications-display-close-events.html = TIMEOUT PASS
-BUGDPRANKE WIN MAC DEBUG : fast/css-generated-content/table-row-group-to-inline.html = IMAGE+TEXT PASS
+BUGDPRANKE DEBUG : fast/css-generated-content/table-row-group-to-inline.html = IMAGE+TEXT PASS
 
 BUGWK60127 WIN LINUX : canvas/philip/tests/2d.gradient.radial.touch2.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87579] trunk/LayoutTests

2011-05-27 Thread adamk

Title: [87579] trunk/LayoutTests








Revision 87579
Author ad...@chromium.org
Date 2011-05-27 15:32:01 -0700 (Fri, 27 May 2011)


Log Message
2011-05-27  Adam Klein  

Unreviewed. More rebaselines after r87526.

* platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
* platform/chromium-linux/svg/in-html/by-reference-expected.txt:
* platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux-x86/svg/in-html/
trunk/LayoutTests/platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt
trunk/LayoutTests/platform/chromium-win-vista/svg/in-html/
trunk/LayoutTests/platform/chromium-win-vista/svg/in-html/by-reference-expected.txt
trunk/LayoutTests/platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87578 => 87579)

--- trunk/LayoutTests/ChangeLog	2011-05-27 22:14:13 UTC (rev 87578)
+++ trunk/LayoutTests/ChangeLog	2011-05-27 22:32:01 UTC (rev 87579)
@@ -1,3 +1,13 @@
+2011-05-27  Adam Klein  
+
+Unreviewed. More rebaselines after r87526.
+
+* platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
+* platform/chromium-linux/svg/in-html/by-reference-expected.txt:
+* platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
+* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-05-27  Adrienne Walker  
 
 [chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87578 => 87579)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 22:14:13 UTC (rev 87578)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 22:32:01 UTC (rev 87579)
@@ -4038,6 +4038,3 @@
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-text.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE
-
-// Failing after r87526, probably just needs rebaselining.
-BUGADAMK WIN LINUX : svg/in-html/by-reference.html = TEXT


Modified: trunk/LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt (87578 => 87579)

--- trunk/LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt	2011-05-27 22:14:13 UTC (rev 87578)
+++ trunk/LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt	2011-05-27 22:32:01 UTC (rev 87579)
@@ -21,7 +21,7 @@
 RenderPartObject {IFRAME} at (108,0) size 100x100
   layer at (0,0) size 100x100
 RenderView at (0,0) size 100x100
-  layer at (0,0) size 50x50
+  layer at (0,0) size 100x100
 RenderSVGRoot {svg} at (0,0) size 0x0
 RenderText {#text} at (208,85) size 4x19
   text run at (208,85) width 4: " "


Copied: trunk/LayoutTests/platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt (from rev 87578, trunk/LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt) (0 => 87579)

--- trunk/LayoutTests/platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt	2011-05-27 22:32:01 UTC (rev 87579)
@@ -0,0 +1,39 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x400
+  RenderBlock {HTML} at (0,0) size 800x400
+RenderBody {BODY} at (0,0) size 800x400
+  RenderBlock {DIV} at (0,0) size 400x400 [bgcolor=#00FF00]
+RenderEmbeddedObject {OBJECT} at (0,50) size 50x50
+  layer at (0,0) size 50x50
+RenderView at (0,0) size 50x50
+  layer at (0,0) size 50x50
+RenderSVGRoot {svg} at (0,0) size 0x0
+RenderText {#text} at (50,85) size 4x19
+  text run at (50,85) width 4: " "
+RenderEmbeddedObject {EMBED} at (54,50) size 50x50
+  layer at (0,0) size 50x50
+RenderView at (0,0) size 50x50
+  layer at (0,0) size 50x50
+RenderSVGRoot {svg} at (0,0) size 0x0
+

[webkit-changes] [87572] trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-05-27 Thread adamk

Title: [87572] trunk/LayoutTests/platform/chromium/test_expectations.txt








Revision 87572
Author ad...@chromium.org
Date 2011-05-27 14:36:05 -0700 (Fri, 27 May 2011)


Log Message
[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

Modified Paths

trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87571 => 87572)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 21:33:11 UTC (rev 87571)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 21:36:05 UTC (rev 87572)
@@ -3760,7 +3760,6 @@
 
 // flakiness on canaries (noted ~ r85006)
 BUGDPRANKE CPU : svg/hixie/rendering-model/003.xhtml = IMAGE+TEXT PASS
-BUGDPRANKE CPU : svg/in-html/by-reference.html = IMAGE+TEXT PASS
 BUGDPRANKE CPU : fast/dom/HTMLFormElement/document-deactivation-callback-crash.html = PASS TEXT
 BUGDPRANKE LINUX DEBUG CPU : svg/custom/font-platformDestroy-crash.svg = PASS CRASH
 BUGDPRANKE CPU : fast/dom/HTMLObjectElement/object-as-frame.html = PASS TEXT
@@ -4031,7 +4030,7 @@
 BUGADAMK SNOWLEOPARD DEBUG : svg/custom/object-sizing-explicit-width.xhtml = IMAGE+TEXT
 BUGADAMK SNOWLEOPARD DEBUG : svg/wicd/test-rightsizing-a.xhtml = IMAGE+TEXT
 
-// After r87256, these all have extra scrollbars where the platform/mac expectations do not.
+// After r87526, these all have extra scrollbars where the platform/mac expectations do not.
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = IMAGE+TEXT
@@ -4039,3 +4038,6 @@
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-text.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE
+
+// Failing after r87526, probably just needs rebaselining.
+BUGADAMK WIN LINUX : svg/in-html/by-reference.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87516] trunk/LayoutTests/platform/chromium/test_expectations.txt

2011-05-27 Thread adamk

Title: [87516] trunk/LayoutTests/platform/chromium/test_expectations.txt








Revision 87516
Author ad...@chromium.org
Date 2011-05-27 09:10:00 -0700 (Fri, 27 May 2011)


Log Message
[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

Modified Paths

trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87515 => 87516)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 15:41:20 UTC (rev 87515)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 16:10:00 UTC (rev 87516)
@@ -3704,10 +3704,6 @@
 BUGWK59166 WIN LINUX DEBUG CPU : svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html = TIMEOUT
 BUGWK59166 WIN LINUX DEBUG CPU : svg/filters/feDropShadow.svg = TIMEOUT
 
-BUGWK59172 : fast/html/details-children-merge-crash.html = TEXT
-BUGWK59172 : fast/html/details-element-render-inline-crash.html = TEXT
-BUGWK59172 : fast/html/details-mouse-click.html = TEXT
-
 BUGCR80301 LEOPARD : fast/canvas/canvas-largedraws.html = TIMEOUT
 
 // roll up from r84685:r84721??






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87457] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87457] trunk/LayoutTests








Revision 87457
Author ad...@chromium.org
Date 2011-05-26 18:00:59 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Remove some passing tests from the test expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87456 => 87457)

--- trunk/LayoutTests/ChangeLog	2011-05-27 00:29:40 UTC (rev 87456)
+++ trunk/LayoutTests/ChangeLog	2011-05-27 01:00:59 UTC (rev 87457)
@@ -1,3 +1,9 @@
+2011-05-26  Adam Klein  
+
+Unreviewed. Remove some passing tests from the test expectations.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-26  Qi Zhang  
 
 Reviewed by Andreas Kling.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87456 => 87457)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 00:29:40 UTC (rev 87456)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-27 01:00:59 UTC (rev 87457)
@@ -3712,9 +3712,6 @@
 BUGWK59166 WIN LINUX DEBUG CPU : svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html = TIMEOUT
 BUGWK59166 WIN LINUX DEBUG CPU : svg/filters/feDropShadow.svg = TIMEOUT
 
-BUGWK59172 : fast/html/details-children-merge-crash.html = TEXT
-BUGWK59172 : fast/html/details-element-render-inline-crash.html = TEXT
-BUGWK59172 : fast/html/details-mouse-click.html = TEXT
 BUGWK59172 WIN   : fast/html/details-add-summary-1-and-click.html = TEXT
 BUGWK59172 LINUX : fast/html/details-add-summary-1-and-click.html = TEXT
 BUGWK59172 WIN   : fast/html/details-add-summary-1.html = TEXT
@@ -4008,9 +4005,9 @@
 BUGWK60822 : plugins/get-url-notify-with-url-that-fails-to-load.html = CRASH TIMEOUT PASS
 
 // Started crashing after r86584.
-BUGWK60931:  http/tests/security/aboutBlank/window-open-self-about-blank.html = CRASH
-BUGWK60931:  http/tests/security/_javascript_URL/xss-ALLOWED-from-_javascript_-url-window-open.html = CRASH
-BUGWK60931:  http/tests/security/_javascript_URL/xss-ALLOWED-to-_javascript_-url-window-open.html = CRASH
+BUGWK60931 DEBUG :  http/tests/security/aboutBlank/window-open-self-about-blank.html = CRASH
+BUGWK60931 DEBUG :  http/tests/security/_javascript_URL/xss-ALLOWED-from-_javascript_-url-window-open.html = CRASH
+BUGWK60931 DEBUG :  http/tests/security/_javascript_URL/xss-ALLOWED-to-_javascript_-url-window-open.html = CRASH
 
 // Flaky since added by r86478
 BUGCR82881 : http/tests/appcache/interrupted-update.html = PASS TEXT
@@ -4093,8 +4090,6 @@
 
 BUGWK61326 : fast/storage/storage-detached-iframe.html = CRASH
 
-BUGCR83683 : fast/dom/HTMLLinkElement/prerender.html = TEXT
-
 // Needs expectations
 BUGMORRITA : fast/html/details-replace-text.html = FAIL
 BUGMORRITA : fast/html/details-replace-summary-child.html = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87449] trunk/Source

2011-05-26 Thread adamk

Title: [87449] trunk/Source








Revision 87449
Author ad...@chromium.org
Date 2011-05-26 16:47:32 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Sheriff Bot  

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::setContentsSize):
* page/FrameView.h:
2011-05-26  Sheriff Bot  

Unreviewed, rolling out r87444.
http://trac.webkit.org/changeset/87444
https://bugs.webkit.org/show_bug.cgi?id=61582

Layout test regressions in Chromium/WebKit: fast/css/first-
letter-text-fragment-crash.html, fast/css/first-letter-
visibility.html (Requested by aklein on #webkit).

* public/WebFrameClient.h:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebCore/page/Chrome.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebFrameClient.h
trunk/Source/WebKit/chromium/src/ChromeClientImpl.cpp
trunk/Source/WebKit/chromium/src/ChromeClientImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (87448 => 87449)

--- trunk/Source/WebCore/ChangeLog	2011-05-26 23:39:22 UTC (rev 87448)
+++ trunk/Source/WebCore/ChangeLog	2011-05-26 23:47:32 UTC (rev 87449)
@@ -1,3 +1,20 @@
+2011-05-26  Sheriff Bot  
+
+Unreviewed, rolling out r87444.
+http://trac.webkit.org/changeset/87444
+https://bugs.webkit.org/show_bug.cgi?id=61582
+
+Layout test regressions in Chromium/WebKit: fast/css/first-
+letter-text-fragment-crash.html, fast/css/first-letter-
+visibility.html (Requested by aklein on #webkit).
+
+* page/Chrome.cpp:
+* page/Chrome.h:
+* page/ChromeClient.h:
+* page/FrameView.cpp:
+(WebCore::FrameView::setContentsSize):
+* page/FrameView.h:
+
 2011-05-26  David Levin  
 
 Reviewed by Darin Fisher.


Modified: trunk/Source/WebCore/page/Chrome.cpp (87448 => 87449)

--- trunk/Source/WebCore/page/Chrome.cpp	2011-05-26 23:39:22 UTC (rev 87448)
+++ trunk/Source/WebCore/page/Chrome.cpp	2011-05-26 23:47:32 UTC (rev 87449)
@@ -114,11 +114,6 @@
 m_client->contentsSizeChanged(frame, size);
 }
 
-void Chrome::contentsPreferredSizeChanged(Frame* frame, const IntSize& size) const
-{
-m_client->contentsPreferredSizeChanged(frame, size);
-}
-
 void Chrome::scrollRectIntoView(const IntRect& rect) const
 {
 // FIXME: The unused ScrollView* argument can and should be removed from ChromeClient::scrollRectIntoView.


Modified: trunk/Source/WebCore/page/Chrome.h (87448 => 87449)

--- trunk/Source/WebCore/page/Chrome.h	2011-05-26 23:39:22 UTC (rev 87448)
+++ trunk/Source/WebCore/page/Chrome.h	2011-05-26 23:47:32 UTC (rev 87449)
@@ -84,7 +84,6 @@
 void scrollRectIntoView(const IntRect&) const;
 
 void contentsSizeChanged(Frame*, const IntSize&) const;
-void contentsPreferredSizeChanged(Frame*, const IntSize&) const;
 
 void setWindowRect(const FloatRect&) const;
 FloatRect windowRect() const;


Modified: trunk/Source/WebCore/page/ChromeClient.h (87448 => 87449)

--- trunk/Source/WebCore/page/ChromeClient.h	2011-05-26 23:39:22 UTC (rev 87448)
+++ trunk/Source/WebCore/page/ChromeClient.h	2011-05-26 23:47:32 UTC (rev 87449)
@@ -161,7 +161,6 @@
 virtual void dispatchViewportDataDidChange(const ViewportArguments&) const { }
 
 virtual void contentsSizeChanged(Frame*, const IntSize&) const = 0;
-virtual void contentsPreferredSizeChanged(Frame*, const IntSize&) const { }
 virtual void scrollRectIntoView(const IntRect&, const ScrollView*) const = 0; // Currently only Mac has a non empty implementation.

 virtual bool shouldMissingPluginMessageBeButton() const { return false; }


Modified: trunk/Source/WebCore/page/FrameView.cpp (87448 => 87449)

--- trunk/Source/WebCore/page/FrameView.cpp	2011-05-26 23:39:22 UTC (rev 87448)
+++ trunk/Source/WebCore/page/FrameView.cpp	2011-05-26 23:47:32 UTC (rev 87449)
@@ -475,35 +475,24 @@
 
 void FrameView::setContentsSize(const IntSize& size)
 {
-bool contentsSizeChanged = size != contentsSize();
-Page* page = frame() ? frame()->page() : 0;
-if (contentsSizeChanged) {
-m_deferSetNeedsLayouts++;
+if (size == contentsSize())
+return;
 
-ScrollView::setContentsSize(size);
-scrollAnimator()->contentsResized();
-if (page)
-page->chro

[webkit-changes] [87435] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87435] trunk/LayoutTests








Revision 87435
Author ad...@chromium.org
Date 2011-05-26 14:50:52 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed.  Add Leopard rebaseline.

* platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87434 => 87435)

--- trunk/LayoutTests/ChangeLog	2011-05-26 21:46:09 UTC (rev 87434)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 21:50:52 UTC (rev 87435)
@@ -1,3 +1,9 @@
+2011-05-26  Adam Klein  
+
+Unreviewed.  Add Leopard rebaseline.
+
+* platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
+
 2011-05-26  Sheriff Bot  
 
 Unreviewed, rolling out r87368.


Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/gradients/css3-repeating-linear-gradients2-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87418] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87418] trunk/LayoutTests








Revision 87418
Author ad...@chromium.org
Date 2011-05-26 12:42:08 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Suppress more flaky Linux tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87417 => 87418)

--- trunk/LayoutTests/ChangeLog	2011-05-26 19:36:13 UTC (rev 87417)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 19:42:08 UTC (rev 87418)
@@ -1,5 +1,11 @@
 2011-05-26  Adam Klein  
 
+Unreviewed. Suppress more flaky Linux tests.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-26  Adam Klein  
+
 Unreviewed. Suppress flaky timeouts and crashes in a few tests.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87417 => 87418)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:36:13 UTC (rev 87417)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:42:08 UTC (rev 87418)
@@ -4123,11 +4123,11 @@
 // New test added in r87324
 BUGCR83994 WIN : platform/win/plugins/call-_javascript_-that-destroys-plugin.html = CRASH
 
-BUGWK61519 WIN LINUX : inspector/debugger/scripts-panel.html = TEXT PASS
+BUGWK61519 WIN LINUX : inspector/debugger/scripts-panel.html = TEXT TIMEOUT PASS
 BUGCR84031 MAC LINUX : storage/domstorage/sessionstorage/delete-removal.html = TIMEOUT PASS
 BUGCR84032 WIN : fast/dom/object-plugin-hides-properties.html = TIMEOUT PASS
 
-BUGWK61533 LINUX : inspector/profiler/cpu-profiler-profiling.html = CRASH PASS
+BUGWK61533 LINUX : inspector/profiler/cpu-profiler-profiling.html = CRASH TIMEOUT PASS
 
 BUGCR84093 VISTA : http/tests/history/redirect-200-refresh-2-seconds.pl = TIMEOUT PASS
 BUGCR84095 VISTA : svg/custom/use-detach.svg = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87415] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87415] trunk/LayoutTests








Revision 87415
Author ad...@chromium.org
Date 2011-05-26 12:33:58 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Suppress flaky timeouts and crashes in a few tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87414 => 87415)

--- trunk/LayoutTests/ChangeLog	2011-05-26 19:30:48 UTC (rev 87414)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 19:33:58 UTC (rev 87415)
@@ -1,5 +1,11 @@
 2011-05-26  Adam Klein  
 
+Unreviewed. Suppress flaky timeouts and crashes in a few tests.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-26  Adam Klein  
+
 Unreviewed. Remove test expectations for now-passing tests.
 
 * platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87414 => 87415)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:30:48 UTC (rev 87414)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:33:58 UTC (rev 87415)
@@ -965,7 +965,7 @@
 
 // Our gradients are wrong here.
 BUGCR19559 WIN LINUX : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = FAIL
-BUGCR10304 LINUX : svg/carto.net/button.svg = FAIL
+BUGCR10304 LINUX : svg/carto.net/button.svg = FAIL CRASH
 
 // Probably need to change the test upstream to describe it better and use no
 // hard coded numbers.
@@ -4128,3 +4128,6 @@
 BUGCR84032 WIN : fast/dom/object-plugin-hides-properties.html = TIMEOUT PASS
 
 BUGWK61533 LINUX : inspector/profiler/cpu-profiler-profiling.html = CRASH PASS
+
+BUGCR84093 VISTA : http/tests/history/redirect-200-refresh-2-seconds.pl = TIMEOUT PASS
+BUGCR84095 VISTA : svg/custom/use-detach.svg = TIMEOUT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87410] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87410] trunk/LayoutTests








Revision 87410
Author ad...@chromium.org
Date 2011-05-26 12:14:16 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Remove test expectations for now-passing tests.

* platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87409 => 87410)

--- trunk/LayoutTests/ChangeLog	2011-05-26 19:06:47 UTC (rev 87409)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 19:14:16 UTC (rev 87410)
@@ -1,5 +1,11 @@
 2011-05-26  Adam Klein  
 
+Unreviewed. Remove test expectations for now-passing tests.
+
+* platform/chromium/test_expectations.txt: Narrow some failures to Win/Linux; remove tests now passing due to rollout.
+
+2011-05-26  Adam Klein  
+
 Unreviewed. Rebaselines for SVG tests added in r87284.
 
 * platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87409 => 87410)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:06:47 UTC (rev 87409)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 19:14:16 UTC (rev 87410)
@@ -4099,16 +4099,9 @@
 BUGMORRITA : fast/html/details-replace-text.html = FAIL
 BUGMORRITA : fast/html/details-replace-summary-child.html = FAIL
 
-// Regression from webkit r87118
-BUGWK61342 MAC : fast/repaint/fixed-move-after-keyboard-scroll.html = IMAGE+TEXT
-BUGWK61342 MAC : fast/dom/vertical-scrollbar-in-rtl.html = TEXT
-BUGWK61342 MAC : fast/events/node-event-anchor-lock.html = TEXT
-BUGWK61342 MAC : fast/events/scroll-after-click-on-tab-index.html = TEXT
-BUGWK61342 MAC : fast/events/scrollbar-double-click.html = TEXT
-
 // New tests added in r87121
-BUGWK61169 : css3/images/optimize-contrast-canvas.html = IMAGE
-BUGWK61169 : css3/images/optimize-contrast-image.html = IMAGE
+BUGWK61169 WIN LINUX : css3/images/optimize-contrast-canvas.html = IMAGE
+BUGWK61169 WIN LINUX : css3/images/optimize-contrast-image.html = IMAGE
 
 BUGWK61370 LINUX : svg/W3C-SVG-1.1/fonts-glyph-04-t.svg = IMAGE
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87404] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87404] trunk/LayoutTests








Revision 87404
Author ad...@chromium.org
Date 2011-05-26 11:28:43 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Rebaselines for SVG tests added in r87284.

* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svg

[webkit-changes] [87396] trunk/LayoutTests

2011-05-26 Thread adamk

Title: [87396] trunk/LayoutTests








Revision 87396
Author ad...@chromium.org
Date 2011-05-26 09:56:19 -0700 (Thu, 26 May 2011)


Log Message
2011-05-26  Adam Klein  

Unreviewed. Test expectations update/rebaseline.

* platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
* platform/chromium/test_expectations.txt: BUGCR84052, border-antialiasing.html IMAGE+TEXT.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png
trunk/LayoutTests/platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87395 => 87396)

--- trunk/LayoutTests/ChangeLog	2011-05-26 16:36:38 UTC (rev 87395)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 16:56:19 UTC (rev 87396)
@@ -1,3 +1,12 @@
+2011-05-26  Adam Klein  
+
+Unreviewed. Test expectations update/rebaseline.
+
+* platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
+* platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
+* platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
+* platform/chromium/test_expectations.txt: BUGCR84052, border-antialiasing.html IMAGE+TEXT.
+
 2011-05-26  Andrey Kosyakov  
 
 Reviewed by Yury Semikhatsky.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87395 => 87396)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 16:36:38 UTC (rev 87395)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 16:56:19 UTC (rev 87396)
@@ -4146,3 +4146,6 @@
 BUGCR84032 WIN : fast/dom/object-plugin-hides-properties.html = TIMEOUT PASS
 
 BUGWK61533 LINUX : inspector/profiler/cpu-profiler-profiling.html = CRASH PASS
+
+// New test added in r87387
+BUGCR84052 WIN LINUX : fast/borders/border-antialiasing.html = IMAGE+TEXT


Added: trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients2-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/css3-repeating-linear-gradients2-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win-vista/fast/gradients/css3-repeating-linear-gradients2-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87350] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87350] trunk/LayoutTests








Revision 87350
Author ad...@chromium.org
Date 2011-05-25 18:58:06 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
reported as http://crbug.com/83994.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87349 => 87350)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:50:55 UTC (rev 87349)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 01:58:06 UTC (rev 87350)
@@ -1,5 +1,12 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
+reported as http://crbug.com/83994.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Temporarily ignore MHTML test failures on Windows
 while we dig into it in http://crbug.com/83833.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87349 => 87350)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:50:55 UTC (rev 87349)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:58:06 UTC (rev 87350)
@@ -4153,3 +4153,6 @@
 BUGCR83833 WIN : mhtml/page_with_image_unmht.mht = MISSING
 BUGCR83833 WIN : mhtml/simple_page_ie.mht = MISSING
 BUGCR83833 WIN : mhtml/simple_page_unmht.mht = MISSING
+
+// New test added in r87324
+BUGCR83994 WIN : platform/win/plugins/call-_javascript_-that-destroys-plugin.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87349] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87349] trunk/LayoutTests








Revision 87349
Author ad...@chromium.org
Date 2011-05-25 18:50:55 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Temporarily ignore MHTML test failures on Windows
while we dig into it in http://crbug.com/83833.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87348 => 87349)

--- trunk/LayoutTests/ChangeLog	2011-05-26 01:48:25 UTC (rev 87348)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 01:50:55 UTC (rev 87349)
@@ -1,3 +1,10 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Temporarily ignore MHTML test failures on Windows
+while we dig into it in http://crbug.com/83833.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Qi Zhang  
 
 Reviewed by Simon Hausmann.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87348 => 87349)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:48:25 UTC (rev 87348)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 01:50:55 UTC (rev 87349)
@@ -4143,3 +4143,13 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
 
 BUGWK61486 DEBUG : http/tests/misc/drag-not-loaded-image.html = CRASH
+
+// New tests added in r87189
+BUGCR83833 WIN : mhtml/multi_frames_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/multi_frames_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_css_and_js_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_css_and_js_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_image_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/page_with_image_unmht.mht = MISSING
+BUGCR83833 WIN : mhtml/simple_page_ie.mht = MISSING
+BUGCR83833 WIN : mhtml/simple_page_unmht.mht = MISSING






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87341] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87341] trunk/LayoutTests








Revision 87341
Author ad...@chromium.org
Date 2011-05-25 17:52:17 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87340 => 87341)

--- trunk/LayoutTests/ChangeLog	2011-05-26 00:44:16 UTC (rev 87340)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 00:52:17 UTC (rev 87341)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Jer Noble  
 
 Unreviewed; Skip failing tests after r87328.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87340 => 87341)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:44:16 UTC (rev 87340)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:52:17 UTC (rev 87341)
@@ -4142,4 +4142,4 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
 
-BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH
+BUGWK61486 DEBUG : http/tests/misc/drag-not-loaded-image.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87339] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87339] trunk/LayoutTests








Revision 87339
Author ad...@chromium.org
Date 2011-05-25 17:27:05 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87338 => 87339)

--- trunk/LayoutTests/ChangeLog	2011-05-26 00:24:04 UTC (rev 87338)
+++ trunk/LayoutTests/ChangeLog	2011-05-26 00:27:05 UTC (rev 87339)
@@ -1,5 +1,11 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Rebaseline svg tests after r87310.
 
 * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87338 => 87339)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:24:04 UTC (rev 87338)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-26 00:27:05 UTC (rev 87339)
@@ -3852,7 +3852,7 @@
 
 BUGSENORBLANCO WIN LINUX : animations/animation-drt-api-multiple-keyframes.html = TEXT
 BUGSENORBLANCO WIN LINUX : animations/animation-drt-api.html = TEXT
-BUGSENORBLANCO GPU LEOPARD : compositing/direct-image-compositing.html = IMAGE CRASH
+BUGSENORBLANCO GPU MAC : compositing/direct-image-compositing.html = IMAGE CRASH
 BUGSENORBLANCO MAC LINUX : fast/css/string-quote-binary.html = CRASH PASS
 BUGSENORBLANCO LINUX : fast/events/panScroll-click-hyperlink.html = TEXT
 BUGSENORBLANCO : fast/files/domurl-script-execution-context-crash.html = CRASH PASS
@@ -4141,3 +4141,5 @@
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE
+
+BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87338] trunk/Source/WebKit/chromium

2011-05-25 Thread adamk

Title: [87338] trunk/Source/WebKit/chromium








Revision 87338
Author ad...@chromium.org
Date 2011-05-25 17:24:04 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Sheriff Bot  

Unreviewed, rolling out r87333.
http://trac.webkit.org/changeset/87333
https://bugs.webkit.org/show_bug.cgi?id=61488

Breaks Chromium build due to pure virtual methods. (Requested
by aklein on #webkit).

* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (87337 => 87338)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-05-26 00:24:04 UTC (rev 87338)
@@ -1,3 +1,18 @@
+2011-05-25  Sheriff Bot  
+
+Unreviewed, rolling out r87333.
+http://trac.webkit.org/changeset/87333
+https://bugs.webkit.org/show_bug.cgi?id=61488
+
+Breaks Chromium build due to pure virtual methods. (Requested
+by aklein on #webkit).
+
+* public/WebWidget.h:
+* src/WebPopupMenuImpl.cpp:
+* src/WebPopupMenuImpl.h:
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+
 2011-05-25  Sailesh Agrawal  
 
 Reviewed by Darin Fisher.


Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h	2011-05-26 00:24:04 UTC (rev 87338)
@@ -55,19 +55,9 @@
 // Returns the current size of the WebWidget.
 virtual WebSize size() = 0;
 
-// Used to group a series of resize events. For example, if the user
-// drags a resizer then willStartLiveResize will be called, followed by a
-// sequence of resize events, ending with willEndLiveResize when the user
-// lets go of the resizer.
-virtual void willStartLiveResize() = 0;
-
 // Called to resize the WebWidget.
 virtual void resize(const WebSize&) = 0;
 
-// Ends a group of resize events that was started with a call to
-// willStartLiveResize.
-virtual void willEndLiveResize() = 0;
-
 // Called to update imperative animation state.  This should be called before
 // paint, although the client can rate-limit these calls.
 virtual void animate() = 0;


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp	2011-05-26 00:24:04 UTC (rev 87338)
@@ -136,10 +136,6 @@
 deref();  // Balances ref() from WebWidget::Create
 }
 
-void WebPopupMenuImpl::willStartLiveResize()
-{
-}
-
 void WebPopupMenuImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -157,10 +153,6 @@
 }
 }
 
-void WebPopupMenuImpl::willEndLiveResize()
-{
-}
-
 void WebPopupMenuImpl::animate()
 {
 }


Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h	2011-05-26 00:24:04 UTC (rev 87338)
@@ -62,9 +62,7 @@
 // WebWidget
 virtual void close();
 virtual WebSize size() { return m_size; }
-virtual void willStartLiveResize();
 virtual void resize(const WebSize&);
-virtual void willEndLiveResize();
 virtual void animate();
 virtual void layout();
 virtual void paint(WebCanvas* canvas, const WebRect& rect);


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:04:22 UTC (rev 87337)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-05-26 00:24:04 UTC (rev 87338)
@@ -972,12 +972,6 @@
 deref();  // Balances ref() acquired in WebView::create
 }
 
-void WebViewImpl::willStartLiveResize()
-{
-if (mainFrameImpl() && mainFrameImpl()->frameView())
-mainFrameImpl()->frameView()->willStartLiveResize();
-}
-
 void WebViewImpl::resize(const WebSize& newSize)
 {
 if (m_size == newSize)
@@ -1008,12 +1002,6 @@
 #endif
 }
 
-void WebViewImpl::willEndLiveResize()
-{
-if (mainFrameImpl() && mainFrameImpl()->frameView())
-mainFrameImpl()->frameView()->willEndLiveResize();
-}
-
 void WebViewImpl::animate()
 {
 TRACE_EVENT("WebViewImpl::animate", this, 0);


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (87337 => 87338)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.h	2011-05-26 0

[webkit-changes] [87334] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87334] trunk/LayoutTests








Revision 87334
Author ad...@chromium.org
Date 2011-05-25 16:39:48 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Rebaseline svg tests after r87310.

* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (87333 => 87334)

--- trunk/LayoutTests/ChangeLog	2011-05-25 23:30:41 UTC (rev 87333)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 23:39:48 UTC (rev 87334)
@@ -1,5 +1,20 @@
 2011-05-25  Adam Klein  
 
+Unreviewed. Rebaseline svg tests after r87310.
+
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+
+2011-05-25  Adam Klein  
+
 Unreviewed. Removing test_expectations for non-existent tests.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (0 => 87334)

--- trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt	2011-05-25 23:39:48 UTC (rev 87334)
@@ -0,0 +1,40 @@
+layer at (0,0) size 480x360
+  RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+  RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (82,20) size 362x264
+  RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id="null"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+RenderSVGResourceFilter {filter} [id="nullreg"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+  RenderSVGContainer {g} at (90,20) size 80x114
+RenderSVGPath {circle} at (1

[webkit-changes] [87332] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87332] trunk/LayoutTests








Revision 87332
Author ad...@chromium.org
Date 2011-05-25 16:09:56 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Removing test_expectations for non-existent tests.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87331 => 87332)

--- trunk/LayoutTests/ChangeLog	2011-05-25 23:08:28 UTC (rev 87331)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 23:09:56 UTC (rev 87332)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Removing test_expectations for non-existent tests.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-25  Jer Noble  
 
 Unreviewed; Update Skipped list for failing tests.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87331 => 87332)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 23:08:28 UTC (rev 87331)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 23:09:56 UTC (rev 87332)
@@ -2426,9 +2426,6 @@
 BUGCR58970 LINUX : svg/text/text-tselect-02-f.svg = IMAGE PASS
 BUGCR58931 WIN LINUX : svg/W3C-SVG-1.1/pservers-grad-17-b.svg = IMAGE PASS
 
-// Failing from around r62021
-BUGCR15797 WIN : fast/dom/object-embed-plugin-scripting.html = TIMEOUT PASS TEXT
-
 // Failing from r69420, mac failing from r71493:r71496
 BUGCR58735 SLOW : http/tests/misc/prefetch-purpose.html = PASS
 
@@ -4134,26 +4131,6 @@
 // New tests added in r87274
 BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS
 
-// Regression from webkit r87257
-BUGWK61431 DEBUG : storage/indexeddb/create-and-remove-object-store.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-continue.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-index-delete.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/cursor-update.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/database-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/duplicates.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/exception-in-event-aborts.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/index-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/migrate-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/objectstore-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/objectstore-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/open-cursor.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/request-event-propagation.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/set_version_queue.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-after-close.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-basics.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-event-propagation.html = CRASH
-BUGWK61431 DEBUG : storage/indexeddb/transaction-rollback.html = CRASH
-
 // New tests added in webkit r87284
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dx-attr.html = IMAGE
 BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dy-attr.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87325] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87325] trunk/LayoutTests








Revision 87325
Author ad...@chromium.org
Date 2011-05-25 15:03:52 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Test expectations update, followup to r87291.

The aforementioned change cleared out these files, when the intent
seems to have been removal to remove them.

* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt
trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87324 => 87325)

--- trunk/LayoutTests/ChangeLog	2011-05-25 21:56:21 UTC (rev 87324)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 22:03:52 UTC (rev 87325)
@@ -1,3 +1,15 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Test expectations update, followup to r87291.
+
+The aforementioned change cleared out these files, when the intent
+seems to have been removal to remove them.
+
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
+* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed.
+* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed.
+
 2011-05-25  Jon Honeycutt  
 
 REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery


Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => )

Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
===


Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => )

Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt
===






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87318] trunk/LayoutTests

2011-05-25 Thread adamk

Title: [87318] trunk/LayoutTests








Revision 87318
Author ad...@chromium.org
Date 2011-05-25 14:23:05 -0700 (Wed, 25 May 2011)


Log Message
2011-05-25  Adam Klein  

Unreviewed. Update chromium expectations after r87307.

* platform/chromium/test_expectations.txt: suppress, WK61470.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87317 => 87318)

--- trunk/LayoutTests/ChangeLog	2011-05-25 20:32:37 UTC (rev 87317)
+++ trunk/LayoutTests/ChangeLog	2011-05-25 21:23:05 UTC (rev 87318)
@@ -1,3 +1,9 @@
+2011-05-25  Adam Klein  
+
+Unreviewed. Update chromium expectations after r87307.
+
+* platform/chromium/test_expectations.txt: suppress, WK61470.
+
 2011-05-25  Sheriff Bot  
 
 Unreviewed, rolling out r87257.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87317 => 87318)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 20:32:37 UTC (rev 87317)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-25 21:23:05 UTC (rev 87318)
@@ -1022,8 +1022,9 @@
 // Skia/GPU Anti-aliasing
 BUGCR78458 WIN LINUX GPU : fast/canvas/arc360.html = IMAGE
 BUGCR78458 WIN LINUX GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
-BUGCR78458 WIN LINUX GPU : fast/canvas/canvas-composite.html = IMAGE
 
+BUGWK61470 : fast/canvas/canvas-composite.html = IMAGE
+
 // -
 // Other failures
 // -






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87203] trunk/LayoutTests

2011-05-24 Thread adamk

Title: [87203] trunk/LayoutTests








Revision 87203
Author ad...@chromium.org
Date 2011-05-24 14:12:02 -0700 (Tue, 24 May 2011)


Log Message
2011-05-24  Adam Klein  

Unreviewed. Updating Chromium test expectations.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87202 => 87203)

--- trunk/LayoutTests/ChangeLog	2011-05-24 21:06:39 UTC (rev 87202)
+++ trunk/LayoutTests/ChangeLog	2011-05-24 21:12:02 UTC (rev 87203)
@@ -1,3 +1,9 @@
+2011-05-24  Adam Klein  
+
+Unreviewed. Updating Chromium test expectations.
+
+* platform/chromium/test_expectations.txt:
+
 2011-05-24  Kenneth Russell  
 
 Reviewed by James Robinson.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87202 => 87203)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 21:06:39 UTC (rev 87202)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 21:12:02 UTC (rev 87203)
@@ -641,6 +641,7 @@
 
 // Needs eventSender.scalePageBy().
 BUGWK58013 : fast/repaint/scale-page-shrink.html = IMAGE+TEXT
+BUGWK58013 : fast/events/scroll-in-scaled-page-with-overflow-hidden.html = TEXT
 
 // -
 // Inspector tests
@@ -757,7 +758,7 @@
 // Plugin tests
 // -
 BUGCR21841 MAC WIN DEBUG : plugins/destroy-during-npp-new.html = CRASH PASS
-BUGCR61799 : plugins/evaluate-js-after-removing-plugin-element.html = CRASH TEXT
+BUGCR61799 : plugins/evaluate-js-after-removing-plugin-element.html = CRASH TEXT TIMEOUT
 BUGCR37962 MAC : plugins/iframe-shims.html = TEXT PASS TIMEOUT
 BUGCR10351 MAC : plugins/inner-html-display-none.html = FAIL
 BUGWK48164 MAC LINUX WIN : plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87172] trunk

2011-05-24 Thread adamk

Title: [87172] trunk








Revision 87172
Author ad...@chromium.org
Date 2011-05-24 11:12:39 -0700 (Tue, 24 May 2011)


Log Message
2011-05-24  Adam Klein  

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

* inspector/console/console-eval-syntax-error-expected.txt: Removed.
* inspector/console/console-eval-syntax-error.html: Removed.
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
2011-05-24  Adam Klein  

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp


Removed Paths

trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
trunk/LayoutTests/inspector/console/console-eval-syntax-error.html
trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87171 => 87172)

--- trunk/LayoutTests/ChangeLog	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/ChangeLog	2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,3 +1,15 @@
+2011-05-24  Adam Klein  
+
+Unreviewed, rolling out r87145.
+http://trac.webkit.org/changeset/87145
+https://bugs.webkit.org/show_bug.cgi?id=61194
+
+Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
+
+* inspector/console/console-eval-syntax-error-expected.txt: Removed.
+* inspector/console/console-eval-syntax-error.html: Removed.
+* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
+
 2011-05-24  Matthew Delaney  
 
 Reviewed by Simon Fraser.


Deleted: trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt (87171 => 87172)

--- trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error-expected.txt	2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,5 +0,0 @@
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
-
-foo().
-Error
-


Deleted: trunk/LayoutTests/inspector/console/console-eval-syntax-error.html (87171 => 87172)

--- trunk/LayoutTests/inspector/console/console-eval-syntax-error.html	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/inspector/console/console-eval-syntax-error.html	2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,25 +0,0 @@
-
-
-
-function test()
-{
-InspectorTest.evaluateInConsole("foo().", step1);
-
-function step1()
-{
-InspectorTest.dumpConsoleMessages();
-InspectorTest.completeTest();
-}
-}
-
-
-
-
-
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser.
-
-
-
-


Deleted: trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt (87171 => 87172)

--- trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt	2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,5 +0,0 @@
-Tests that evaluating an _expression_ with a syntax error in the console won't crash the browser. Bug 61194.
-
-foo().
-SyntaxError
-


Modified: trunk/Source/WebCore/ChangeLog (87171 => 87172)

--- trunk/Source/WebCore/ChangeLog	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/Source/WebCore/ChangeLog	2011-05-24 18:12:39 UTC (rev 87172)
@@ -1,3 +1,14 @@
+2011-05-24  Adam Klein  
+
+Unreviewed, rolling out r87145.
+http://trac.webkit.org/changeset/87145
+https://bugs.webkit.org/show_bug.cgi?id=61194
+
+Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.
+
+* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+(WebCore::V8InjectedScriptHost::evaluateCallback):
+
 2011-05-24  Matthew Delaney  
 
 Reviewed by Simon Fraser.


Modified: trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (87171 => 87172)

--- trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2011-05-24 18:04:36 UTC (rev 87171)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2011-05-24 18:12:39 UTC (rev 87172)
@@ -76,8 +76,6 @@
 return v8::ThrowException(v8::Exception::Error(v8::String::Ne

[webkit-changes] [87164] trunk/LayoutTests

2011-05-24 Thread adamk

Title: [87164] trunk/LayoutTests








Revision 87164
Author ad...@chromium.org
Date 2011-05-24 10:14:16 -0700 (Tue, 24 May 2011)


Log Message
2011-05-24  Adam Klein  

Unreviewed.  Updated Chromium test expectations.

* platform/chromium/test_expectations.txt: svg failure on Linux, BUGWK61370.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87163 => 87164)

--- trunk/LayoutTests/ChangeLog	2011-05-24 17:12:09 UTC (rev 87163)
+++ trunk/LayoutTests/ChangeLog	2011-05-24 17:14:16 UTC (rev 87164)
@@ -1,5 +1,11 @@
 2011-05-24  Adam Klein  
 
+Unreviewed.  Updated Chromium test expectations.
+
+* platform/chromium/test_expectations.txt: svg failure on Linux, BUGWK61370.
+
+2011-05-24  Adam Klein  
+
 Unreviewed.
 
 Chromium test expectations update.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87163 => 87164)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 17:12:09 UTC (rev 87163)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 17:14:16 UTC (rev 87164)
@@ -4141,3 +4141,5 @@
 // New tests added in r87121
 BUGWK61169 : css3/images/optimize-contrast-canvas.html = IMAGE
 BUGWK61169 : css3/images/optimize-contrast-image.html = IMAGE
+
+BUGWK61370 LINUX : svg/W3C-SVG-1.1/fonts-glyph-04-t.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87159] trunk/LayoutTests

2011-05-24 Thread adamk

Title: [87159] trunk/LayoutTests








Revision 87159
Author ad...@chromium.org
Date 2011-05-24 09:25:11 -0700 (Tue, 24 May 2011)


Log Message
2011-05-24  Adam Klein  

Unreviewed.

Chromium test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=61169

* platform/chromium/test_expectations.txt: Marked optimize-contrast tests as IMAGE failure, BUGWK61169.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (87158 => 87159)

--- trunk/LayoutTests/ChangeLog	2011-05-24 16:11:02 UTC (rev 87158)
+++ trunk/LayoutTests/ChangeLog	2011-05-24 16:25:11 UTC (rev 87159)
@@ -1,3 +1,12 @@
+2011-05-24  Adam Klein  
+
+Unreviewed.
+
+Chromium test expectations update.
+https://bugs.webkit.org/show_bug.cgi?id=61169
+
+* platform/chromium/test_expectations.txt: Marked optimize-contrast tests as IMAGE failure, BUGWK61169.
+
 2011-05-24  Qi Zhang  
 
 Reviewed by Andreas Kling.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87158 => 87159)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 16:11:02 UTC (rev 87158)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-05-24 16:25:11 UTC (rev 87159)
@@ -4137,3 +4137,7 @@
 BUGWK61342 MAC : fast/events/node-event-anchor-lock.html = TEXT
 BUGWK61342 MAC : fast/events/scroll-after-click-on-tab-index.html = TEXT
 BUGWK61342 MAC : fast/events/scrollbar-double-click.html = TEXT
+
+// New tests added in r87121
+BUGWK61169 : css3/images/optimize-contrast-canvas.html = IMAGE
+BUGWK61169 : css3/images/optimize-contrast-image.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [87095] trunk/Source/WebCore

2011-05-23 Thread adamk

Title: [87095] trunk/Source/WebCore








Revision 87095
Author ad...@chromium.org
Date 2011-05-23 13:47:06 -0700 (Mon, 23 May 2011)


Log Message
2011-05-23  Adam Klein  

Reviewed by Jian Li.

[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
https://bugs.webkit.org/show_bug.cgi?id=61155

Covered by existing tests: fast/filesystem/file-from-file-entry.html
   fast/filesystem/workers/file-from-file-entry.html
   fast/filesystem/workers/file-from-file-entry-sync.html

* fileapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createFile): Updated to call createWithName().
* fileapi/DOMFileSystemSync.cpp:
(WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
* fileapi/File.cpp:
(WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup.
(WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method.
(WebCore::File::File):
* fileapi/File.h:
(WebCore::File::createWithName):
* html/FileInputType.cpp:
(WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/DOMFileSystem.cpp
trunk/Source/WebCore/fileapi/DOMFileSystemSync.cpp
trunk/Source/WebCore/fileapi/File.cpp
trunk/Source/WebCore/fileapi/File.h
trunk/Source/WebCore/html/FileInputType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (87094 => 87095)

--- trunk/Source/WebCore/ChangeLog	2011-05-23 20:40:23 UTC (rev 87094)
+++ trunk/Source/WebCore/ChangeLog	2011-05-23 20:47:06 UTC (rev 87095)
@@ -1,3 +1,27 @@
+2011-05-23  Adam Klein  
+
+Reviewed by Jian Li.
+
+[fileapi] Add a File::createWithName method to avoid obfuscated filename leakage from FileEntry.file() method
+https://bugs.webkit.org/show_bug.cgi?id=61155
+
+Covered by existing tests: fast/filesystem/file-from-file-entry.html
+   fast/filesystem/workers/file-from-file-entry.html
+   fast/filesystem/workers/file-from-file-entry-sync.html
+
+* fileapi/DOMFileSystem.cpp:
+(WebCore::DOMFileSystem::createFile): Updated to call createWithName().
+* fileapi/DOMFileSystemSync.cpp:
+(WebCore::DOMFileSystemSync::createFile): Updated to call createWithName().
+* fileapi/File.cpp:
+(WebCore::createBlobDataForFile): Added an optional name argument to fix MIME type lookup.
+(WebCore::File::createWithRelativePath): Renamed from create() for consistency with new method.
+(WebCore::File::File):
+* fileapi/File.h:
+(WebCore::File::createWithName):
+* html/FileInputType.cpp:
+(WebCore::FileInputType::setFileList): Updated the single caller of File::createWithRelativePath().
+
 2011-05-23  Adrienne Walker  
 
 Reviewed by James Robinson.


Modified: trunk/Source/WebCore/fileapi/DOMFileSystem.cpp (87094 => 87095)

--- trunk/Source/WebCore/fileapi/DOMFileSystem.cpp	2011-05-23 20:40:23 UTC (rev 87094)
+++ trunk/Source/WebCore/fileapi/DOMFileSystem.cpp	2011-05-23 20:47:06 UTC (rev 87095)
@@ -117,9 +117,9 @@
 
 class GetPathCallback : public FileSystemCallbacksBase {
 public:
-static PassOwnPtr create(PassRefPtr filesystem, const String& path, PassRefPtr successCallback, PassRefPtr errorCallback)
+static PassOwnPtr create(PassRefPtr filesystem, const String& path, const String& name, PassRefPtr successCallback, PassRefPtr errorCallback)
 {
-return adoptPtr(new GetPathCallback(filesystem, path, successCallback, errorCallback));
+return adoptPtr(new GetPathCallback(filesystem, path, name, successCallback, errorCallback));
 }
 
 virtual void didReadMetadata(const FileMetadata& metadata)
@@ -127,20 +127,22 @@
 if (!metadata.platformPath.isEmpty())
 m_path = metadata.platformPath;
 
-m_filesystem->scheduleCallback(m_successCallback.release(), File::create(m_path));
+m_filesystem->scheduleCallback(m_successCallback.release(), File::createWithName(m_path, m_name));
 }
 
 private:
-GetPathCallback(PassRefPtr filesystem, const String& path, PassRefPtr successCallback, PassRefPtr errorCallback)
+GetPathCallback(PassRefPtr filesystem, const String& path, const String& name, PassRefPtr successCallback, PassRefPtr errorCallback)
 : FileSystemCallbacksBase(errorCallback)
 , m_filesystem(filesystem)
 , m_path(path)
+, m_name(name)
 , m_successCallback(successCallback)
 {
 }
 
 RefPtr m_filesystem;
 String m_path;
+String m_name;
 RefPtr m_successCallback;
 };
 
@@ -150,7 +152,7 @@
 {
 String platformPath = m_asyncFileSystem->virtualToPlatformPat

< 1 2 3 4

301 - 340 of 340 matches

Mail list logo