[webkit-changes] [WebKit/WebKit] 84313c: [WPE] DRM device detection does not work for imx.8...

2024-03-15 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 84313c5961f1b6f445504a6909c74f6ce7e25d9c
  
https://github.com/WebKit/WebKit/commit/84313c5961f1b6f445504a6909c74f6ce7e25d9c
  Author: Alejandro G. Castro 
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
M Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp

  Log Message:
  ---
  [WPE] DRM device detection does not work for imx.8 boards
https://bugs.webkit.org/show_bug.cgi?id=270867

Reviewed by Carlos Garcia Campos.

In case of imx.8 boards the kms device does not have the boot
VGA flag and in that situation the loop is not correctly keeping
the previous kms capable device data alive.

* Source/WebKit/WPEPlatform/wpe/drm/WPEDisplayDRM.cpp:
(findDevice): Use a struct to return the fd and fileName, rework the
loop to copy and save the references even in case we traverse
all the devices. Fix name typo.
(wpeDisplayDRMConnect): Use the new struct to get the values from
the findDevice.

Canonical link: https://commits.webkit.org/276150@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4aad34: [GTK] Add a DisplayLink implementation

2023-09-29 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4aad349224a3cf6246969fef86972f191b280fc1
  
https://github.com/WebKit/WebKit/commit/4aad349224a3cf6246969fef86972f191b280fc1
  Author: Alejandro G. Castro 
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/SourcesGTK.txt
M Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp
R Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp
R Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.h
M Source/WebKit/PlatformGTK.cmake
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
M 
Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h
M Source/WebKit/Shared/Extensions/WebExtensionAlarmParameters.h
M Source/WebKit/Sources.txt
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/SourcesGTK.txt
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h
A Source/WebKit/UIProcess/DisplayLink.cpp
A Source/WebKit/UIProcess/DisplayLink.h
A Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.cpp
A Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.h
M Source/WebKit/UIProcess/DrawingAreaProxy.cpp
M Source/WebKit/UIProcess/DrawingAreaProxy.h
M Source/WebKit/UIProcess/Extensions/WebExtensionAlarm.cpp
M Source/WebKit/UIProcess/Extensions/WebExtensionContext.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxyInternals.h
M Source/WebKit/UIProcess/WebProcessPool.h
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.h
M Source/WebKit/UIProcess/WebProcessProxy.messages.in
A Source/WebKit/UIProcess/glib/DisplayLinkGLib.cpp
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.h
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.h
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorTimer.cpp
A Source/WebKit/UIProcess/glib/DisplayVBlankMonitorTimer.h
M Source/WebKit/UIProcess/gtk/ScreenManager.cpp
M Source/WebKit/UIProcess/gtk/ScreenManager.h
R Source/WebKit/UIProcess/mac/DisplayLink.cpp
R Source/WebKit/UIProcess/mac/DisplayLink.h
A Source/WebKit/UIProcess/mac/DisplayLinkMac.cpp
R Source/WebKit/UIProcess/mac/DisplayLinkProcessProxyClient.cpp
R Source/WebKit/UIProcess/mac/DisplayLinkProcessProxyClient.h
M Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h
M Source/WebKit/WebProcess/WebPage/DrawingArea.messages.in
M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
M Source/WebKit/WebProcess/WebPage/EventDispatcher.h
M Source/WebKit/WebProcess/WebPage/EventDispatcher.messages.in
A Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.cpp
A Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.h
R Source/WebKit/WebProcess/WebPage/mac/DisplayRefreshMonitorMac.cpp
R Source/WebKit/WebProcess/WebPage/mac/DisplayRefreshMonitorMac.h
M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h
M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  ---
  [GTK] Add a DisplayLink implementation
https://bugs.webkit.org/show_bug.cgi?id=261673

Reviewed by Simon Fraser.

Add DisplayLink implementation using DRM API when available to get the
vblank signal from monitor. When DRM is not available we fallback to use
a timer. The patch includes some refactorings needed to share the
implementation with other ports for non-platform specific parts. The
platform display ID is no longer generated based on the drawing area
identifier, but assigned by the screen manager to every monitor.
ThreadedDisplayRefreshMonitor and DisplayRefreshMonitorGtk are no longer
needed now.

* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
* Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp: Removed.
* Source/WebKit/PlatformGTK.cmake:
*

[webkit-changes] [WebKit/WebKit] 944557: [GTK] Activate WebGL2 layout tests in GTK port

2023-01-25 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94455711c2fd8e48d526dce18c94a97e72a29b73
  
https://github.com/WebKit/WebKit/commit/94455711c2fd8e48d526dce18c94a97e72a29b73
  Author: Alejandro G. Castro 
  Date:   2023-01-25 (Wed, 25 Jan 2023)

  Changed paths:
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [GTK] Activate WebGL2 layout tests in GTK port
https://bugs.webkit.org/show_bug.cgi?id=251106

Reviewed by Carlos Garcia Campos.

Unskipped WebGL2 tests in GTK port. We have marked flakies and
failures in the TestExpectation file and opened a bug to follow
them.

* LayoutTests/platform/gtk/TestExpectations: Also fixed a small typo
in the comments.
* LayoutTests/platform/wpe/TestExpectations: Replaced the bug number
with the one we are going to use to follow WebGL2 failures in both ports.

Canonical link: https://commits.webkit.org/259348@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e34ea9: [WPE] Activate WebGL2 layout tests in WPE port

2023-01-24 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e34ea905e1cc84681835f43324b4146ec9f05c1e
  
https://github.com/WebKit/WebKit/commit/e34ea905e1cc84681835f43324b4146ec9f05c1e
  Author: Alejandro G. Castro 
  Date:   2023-01-24 (Tue, 24 Jan 2023)

  Changed paths:
M LayoutTests/platform/wpe/TestExpectations
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-aliasing-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-matrix-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/context/premultiplyalpha-test-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/context/context-attributes-depth-stencil-antialias-obeyed-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/misc/object-deletion-behaviour-2-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/renderbuffers/multisample-with-full-sample-counts-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/renderbuffers/readbuffer-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/attrib-type-match-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/blitframebuffer-stencil-only-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/rendering/instanced-arrays-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/tex-srgb-mipmap-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/textures/misc/texture-npot-expected.txt
R 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/transform_feedback/unwritten-output-defaults-to-zero-expected.txt
M 
LayoutTests/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt
M 
LayoutTests/webgl/2.0.0/conformance2/state/gl-object-get-calls-expected.txt

  Log Message:
  ---
  [WPE] Activate WebGL2 layout tests in WPE port
https://bugs.webkit.org/show_bug.cgi?id=251080

Reviewed by Adrian Perez de Castro and Carlos Garcia Campos.

Unskip the WebGL2 tests for WPE port, added some expectations and remove
incorrect expected results.

* LayoutTests/platform/wpe/TestExpectations:
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-aliasing-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/attribs/gl-bindAttribLocation-matrix-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/context/premultiplyalpha-test-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/buffer-copying-contents-expected.txt:
 Removed.
* 
LayoutTests/platform/wpe/webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt:
 Removed.
*

[webkit-changes] [WebKit/WebKit] 7014a0: [GTK][WPE] Fix compilation with ENABLE_WEBGL=OFF

2023-01-18 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7014a00d589b4bb4385e9e7489293d523ed608dd
  
https://github.com/WebKit/WebKit/commit/7014a00d589b4bb4385e9e7489293d523ed608dd
  Author: Alejandro G. Castro 
  Date:   2023-01-18 (Wed, 18 Jan 2023)

  Changed paths:
M Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp
M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp

  Log Message:
  ---
  [GTK][WPE] Fix compilation with  ENABLE_WEBGL=OFF
https://bugs.webkit.org/show_bug.cgi?id=250783

Reviewed by Adrian Perez de Castro.

Add guards to a couple of code sections that depend on WebGL
functions.

* Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:

Canonical link: https://commits.webkit.org/259065@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6b4ed0: WebGL compilation disabling WebGL 2 is broken

2022-10-20 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b4ed06fa609ac0e7429e435434c3b6c53a4770e
  
https://github.com/WebKit/WebKit/commit/6b4ed06fa609ac0e7429e435434c3b6c53a4770e
  Author: Alejandro G. Castro 
  Date:   2022-10-20 (Thu, 20 Oct 2022)

  Changed paths:
M Source/WebCore/inspector/InspectorCanvas.cpp
M Source/WebCore/inspector/InspectorCanvasCallTracer.h

  Log Message:
  ---
  WebGL compilation disabling WebGL 2 is broken
https://bugs.webkit.org/show_bug.cgi?id=246753

Reviewed by Kenneth Russell.

WebGLVertexArrayObject is part of the WebGL 2 API but there are some
places in the code where it was added under the WEBGL ifdef instead of WEBGL2.

* Source/WebCore/inspector/InspectorCanvas.cpp:
* Source/WebCore/inspector/InspectorCanvasCallTracer.h:

Canonical link: https://commits.webkit.org/255778@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6cc6d3: [WPE] Failures after ANGLE activation as default W...

2022-10-11 Thread alexgcastro 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6cc6d33db7ac4c4a95cb2faaa85227dddb7ba452
  
https://github.com/WebKit/WebKit/commit/6cc6d33db7ac4c4a95cb2faaa85227dddb7ba452
  Author: Alejandro G. Castro 
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/gtk/TestExpectations
M LayoutTests/platform/wpe/TestExpectations

  Log Message:
  ---
  [WPE] Failures after ANGLE activation as default WebGL backend
https://bugs.webkit.org/show_bug.cgi?id=246337

Unreviewed test gardening.

We have done the gardening after the activation of ANGLE as the
default backend for WebGL in WPE.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/255398@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes