[webkit-changes] [125564] trunk/Tools

[alexis . menard]

Title: [125564] trunk/Tools








Revision 125564
Author alexis.men...@openbossa.org
Date 2012-08-14 07:52:25 -0700 (Tue, 14 Aug 2012)


Log Message
Update INdT build bot to Mountain Lion.
https://bugs.webkit.org/show_bug.cgi?id=93963

Reviewed by Csaba Osztrogonác.

We updated the machine as well as the OS as the Qt port is now running
on top of Qt5.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (125563 => 125564)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-08-14 14:33:40 UTC (rev 125563)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-08-14 14:52:25 UTC (rev 125564)
@@ -51,7 +51,7 @@
 { name: szeged-windows-1, platform: qt-win},
 { name: szeged-windows-2, platform: qt-win},
 
-{ name: indt-snowleopard, platform: qt-mac},
+{ name: indt-mountainlion, platform: qt-mac},
 
 { name: google-windows-1, platform: chromium-win },
 { name: google-windows-2, platform: chromium-win },
@@ -233,9 +233,9 @@
   slavenames: [szeged-windows-2]
 },
 {
-  name: Qt SnowLeopard Release, type: Build, builddir: qt-snowleopard-release,
+  name: Qt Mountain Lion Release, type: Build, builddir: qt-mountainlion-release,
   platform: qt-mac, configuration: release, architectures: [x86_64],
-  slavenames: [indt-snowleopard]
+  slavenames: [indt-mountainlion]
 },
 {
   name: Chromium Win Release, type: Build, builddir: chromium-win-release,
@@ -326,7 +326,7 @@
   builderNames: [GTK Linux 32-bit Release, GTK Linux 64-bit Release, GTK Linux 64-bit Debug,
Qt Linux Release, Qt Linux Release minimal, Qt Linux 64-bit Release (Perf),
Qt Linux 64-bit Release (WebKit2 Perf), Qt Linux ARMv7 Release,
-   Qt Windows 32-bit Release, Qt Windows 32-bit Debug, Qt SnowLeopard Release,
+   Qt Windows 32-bit Release, Qt Windows 32-bit Debug, Qt Mountain Lion Release,
Chromium Win Release, Chromium Mac Release, Chromium Linux Release,
Chromium Android Release,
EFL Linux 64-bit Release, EFL Linux 64-bit Debug, EFL Linux 32-bit Release (Build), EFL Linux 64-bit Debug WK2,


Modified: trunk/Tools/ChangeLog (125563 => 125564)

--- trunk/Tools/ChangeLog	2012-08-14 14:33:40 UTC (rev 125563)
+++ trunk/Tools/ChangeLog	2012-08-14 14:52:25 UTC (rev 125564)
@@ -1,3 +1,15 @@
+2012-08-14  Alexis Menard  alexis.men...@openbossa.org
+
+Update INdT build bot to Mountain Lion.
+https://bugs.webkit.org/show_bug.cgi?id=93963
+
+Reviewed by Csaba Osztrogonác.
+
+We updated the machine as well as the OS as the Qt port is now running
+on top of Qt5.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2012-08-14  Peter Beverloo  pe...@chromium.org
 
 [Chromium] Remove unneeded build logic for Android






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [125027] trunk/Source/WebCore

[alexis . menard]

Title: [125027] trunk/Source/WebCore








Revision 125027
Author alexis.men...@openbossa.org
Date 2012-08-08 06:04:58 -0700 (Wed, 08 Aug 2012)


Log Message
Unreviewed build fix for Qt on Linux.

* platform/qt/GamepadsQt.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/GamepadsQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (125026 => 125027)

--- trunk/Source/WebCore/ChangeLog	2012-08-08 12:53:18 UTC (rev 125026)
+++ trunk/Source/WebCore/ChangeLog	2012-08-08 13:04:58 UTC (rev 125027)
@@ -1,3 +1,9 @@
+2012-08-08  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed build fix for Qt on Linux.
+
+* platform/qt/GamepadsQt.cpp:
+
 2012-08-08  KwangYong Choi  ky0.c...@samsung.com
 
 [EFL] Support DataList for input type=range


Modified: trunk/Source/WebCore/platform/qt/GamepadsQt.cpp (125026 => 125027)

--- trunk/Source/WebCore/platform/qt/GamepadsQt.cpp	2012-08-08 12:53:18 UTC (rev 125026)
+++ trunk/Source/WebCore/platform/qt/GamepadsQt.cpp	2012-08-08 13:04:58 UTC (rev 125027)
@@ -37,6 +37,7 @@
 #include libudev.h
 }
 
+#include unistd.h
 #include wtf/HashMap.h
 #include wtf/PassOwnPtr.h
 #include wtf/text/CString.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [124099] trunk/Source/WebCore

[alexis . menard]

Title: [124099] trunk/Source/WebCore








Revision 124099
Author alexis.men...@openbossa.org
Date 2012-07-30 15:18:20 -0700 (Mon, 30 Jul 2012)


Log Message
Build fix with newer bison 2.6.
https://bugs.webkit.org/show_bug.cgi?id=92264

Reviewed by Adam Barth.

As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
version I had access to as well as recent Linux runs at least version 2.3 so it's safe
to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.

No new tests : build fix and the patch should not trigger any regressions

* css/CSSGrammar.y:
* css/CSSParser.cpp:
* xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
* xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
therefore including this file within the namespace {} declarations leads to xpathyyparse being
defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/xml/XPathGrammar.y
trunk/Source/WebCore/xml/XPathParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (124098 => 124099)

--- trunk/Source/WebCore/ChangeLog	2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/ChangeLog	2012-07-30 22:18:20 UTC (rev 124099)
@@ -1,3 +1,28 @@
+2012-07-30  Alexis Menard  alexis.men...@openbossa.org
+
+Build fix with newer bison 2.6.
+https://bugs.webkit.org/show_bug.cgi?id=92264
+
+Reviewed by Adam Barth.
+
+As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
+YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
+version I had access to as well as recent Linux runs at least version 2.3 so it's safe
+to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
+As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
+of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.
+
+No new tests : build fix and the patch should not trigger any regressions
+
+* css/CSSGrammar.y:
+* css/CSSParser.cpp:
+* xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
+* xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
+therefore including this file within the namespace {} declarations leads to xpathyyparse being
+defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
+(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs 
+to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.
+
 2012-07-30  Sadrul Habib Chowdhury  sad...@chromium.org
 
 Propagate gesture events to plugins.


Modified: trunk/Source/WebCore/css/CSSGrammar.y (124098 => 124099)

--- trunk/Source/WebCore/css/CSSGrammar.y	2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/css/CSSGrammar.y	2012-07-30 22:18:20 UTC (rev 124099)
@@ -53,14 +53,13 @@
 #define YYMAXDEPTH 1
 #define YYDEBUG 0
 
-// FIXME: Replace with %parse-param { CSSParser* parser } once we can depend on bison 2.x
-#define YYPARSE_PARAM parser
-#define YYLEX_PARAM parser
-
 %}
 
 %pure_parser
 
+%parse-param { CSSParser* parser }
+%lex-param { CSSParser* parser }
+
 %union {
 bool boolean;
 char character;
@@ -89,7 +88,7 @@
 
 %{
 
-static inline int cssyyerror(const char*)
+static inline int cssyyerror(void*, const char*)
 {
 return 1;
 }


Modified: trunk/Source/WebCore/css/CSSParser.cpp (124098 => 124099)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-07-30 22:18:20 UTC (rev 124099)
@@ -114,7 +114,7 @@
 extern int cssyydebug;
 #endif
 
-extern int cssyyparse(void* parser);
+extern int cssyyparse(WebCore::CSSParser*);
 
 using namespace std;
 using namespace WTF;


Modified: trunk/Source/WebCore/xml/XPathGrammar.y (124098 => 124099)

--- trunk/Source/WebCore/xml/XPathGrammar.y	2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/xml/XPathGramm

[webkit-changes] [123555] trunk/LayoutTests

[alexis . menard]

Title: [123555] trunk/LayoutTests








Revision 123555
Author alexis.men...@openbossa.org
Date 2012-07-24 17:28:46 -0700 (Tue, 24 Jul 2012)


Log Message
[Qt] svg/as-background-image rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92180

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

* platform/qt-5.0/Skipped:
* platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
* platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-2-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-3-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-4-expected.png: Added.
* platform/qt/svg/as-background-image/svg-as-background-4-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/qt/svg/as-background-image/svg-as-background-5-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-6-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt:
* platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt:
* platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt:
* platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
* platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt:
* platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
trunk/LayoutTests/platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-1-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-2-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-3-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-4-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-5-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-6-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt
trunk/LayoutTests/platform/qt-5.0/Skipped


Added Paths

trunk/LayoutTests/platform/qt/svg/as-background-image/animated-svg-as-background-expected.png
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-4-expected.png
trunk/LayoutTests/platform/qt/svg/as-background-image/svg-as-background-5-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (123554 => 123555)

--- trunk/LayoutTests/ChangeLog	2012-07-25 00:27:19 UTC (rev 123554)
+++ trunk/LayoutTests/ChangeLog	2012-07-25 00:28:46 UTC (rev 123555)
@@ -1,3 +1,34 @@
+2012-07-24  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] svg/as-background-image rebaseline after new test fonts
+https://bugs.webkit.org/show_bug.cgi?id=92180
+
+Unreviewed gardening.
+
+These tests have been skipped because monospace fonts weren't properly used by
+layout tests. After r121971, the test results are normal again.
+
+* platform/qt-5.0/Skipped:
+* platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
+* platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
+* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
+* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
+* platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
+* platform/qt/

[webkit-changes] [122936] trunk/Tools

[alexis . menard]

Title: [122936] trunk/Tools








Revision 122936
Author alexis.men...@openbossa.org
Date 2012-07-18 01:57:47 -0700 (Wed, 18 Jul 2012)


Log Message
[EFL] Build fix in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=91567

Reviewed by Kentaro Hara.

sleep() is defined in unistd.h, we need to include it.

* WebKitTestRunner/efl/TestControllerEfl.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp




Diff

Modified: trunk/Tools/ChangeLog (122935 => 122936)

--- trunk/Tools/ChangeLog	2012-07-18 08:51:53 UTC (rev 122935)
+++ trunk/Tools/ChangeLog	2012-07-18 08:57:47 UTC (rev 122936)
@@ -1,3 +1,14 @@
+2012-07-18  Alexis Menard  alexis.men...@openbossa.org
+
+[EFL] Build fix in WebKitTestRunner.
+https://bugs.webkit.org/show_bug.cgi?id=91567
+
+Reviewed by Kentaro Hara.
+
+sleep() is defined in unistd.h, we need to include it.
+
+* WebKitTestRunner/efl/TestControllerEfl.cpp:
+
 2012-07-18  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [NRWT] Unreviewed gardening after r122913


Modified: trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp (122935 => 122936)

--- trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp	2012-07-18 08:51:53 UTC (rev 122935)
+++ trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp	2012-07-18 08:57:47 UTC (rev 122936)
@@ -23,6 +23,7 @@
 #include Ecore.h
 #include stdio.h
 #include stdlib.h
+#include unistd.h
 #include wtf/Platform.h
 #include wtf/text/WTFString.h
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122907] trunk/Tools

[alexis . menard]

Title: [122907] trunk/Tools








Revision 122907
Author alexis.men...@openbossa.org
Date 2012-07-17 17:58:47 -0700 (Tue, 17 Jul 2012)


Log Message
webkitdirs.pm should fallback to uname -m if arch is not present.
https://bugs.webkit.org/show_bug.cgi?id=91543

Reviewed by Martin Robinson.

It seems that coreutils is moving away from the 'arch' command. Archlinux
for example doesn't ship it anymore (coreutils 8.17). We can then fallback
to 'uname -m' to find out the architecture.

* Scripts/webkitdirs.pm:
(determineArchitecture):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (122906 => 122907)

--- trunk/Tools/ChangeLog	2012-07-18 00:49:59 UTC (rev 122906)
+++ trunk/Tools/ChangeLog	2012-07-18 00:58:47 UTC (rev 122907)
@@ -1,3 +1,17 @@
+2012-07-17  Alexis Menard  alexis.men...@openbossa.org
+
+webkitdirs.pm should fallback to uname -m if arch is not present.
+https://bugs.webkit.org/show_bug.cgi?id=91543
+
+Reviewed by Martin Robinson.
+
+It seems that coreutils is moving away from the 'arch' command. Archlinux
+for example doesn't ship it anymore (coreutils 8.17). We can then fallback
+to 'uname -m' to find out the architecture.
+
+* Scripts/webkitdirs.pm:
+(determineArchitecture):
+
 2012-07-17  Dirk Pranke  dpra...@chromium.org
 
 nrwt: rename printer.print_update to printer.write_update to match metered_stream


Modified: trunk/Tools/Scripts/webkitdirs.pm (122906 => 122907)

--- trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 00:49:59 UTC (rev 122906)
+++ trunk/Tools/Scripts/webkitdirs.pm	2012-07-18 00:58:47 UTC (rev 122907)
@@ -335,6 +335,12 @@
 $architecture = `arch`;
 chomp $architecture;
 }
+
+if (!$architecture  (isGtk() || isAppleMacWebKit() || isEfl())) {
+# Fall back to output of `uname -m', if it is present.
+$architecture = `uname -m`;
+chomp $architecture;
+}
 }
 
 sub determineNumberOfCPUs






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [121761] trunk/Source/WebKit2

[alexis . menard]

Title: [121761] trunk/Source/WebKit2








Revision 121761
Author alexis.men...@openbossa.org
Date 2012-07-03 06:32:29 -0700 (Tue, 03 Jul 2012)


Log Message
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
https://bugs.webkit.org/show_bug.cgi?id=89755

Reviewed by Simon Hausmann.

When calling accept with an empty list of files we can just bailout
and call reject(). Any other processing is pointless.

   * UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
   * UIProcess/qt/QtDialogRunner.cpp:
(WebKit::FilePickerContextObject::accept):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml
trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121760 => 121761)

--- trunk/Source/WebKit2/ChangeLog	2012-07-03 13:00:46 UTC (rev 121760)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-03 13:32:29 UTC (rev 121761)
@@ -1,3 +1,17 @@
+2012-07-03  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
+https://bugs.webkit.org/show_bug.cgi?id=89755
+
+Reviewed by Simon Hausmann.
+
+When calling accept with an empty list of files we can just bailout
+and call reject(). Any other processing is pointless.
+
+   * UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
+   * UIProcess/qt/QtDialogRunner.cpp:
+(WebKit::FilePickerContextObject::accept):
+
 2012-07-03  Balazs Kelemen  kbal...@webkit.org
 
 [Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml (121760 => 121761)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml	2012-07-03 13:00:46 UTC (rev 121760)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml	2012-07-03 13:32:29 UTC (rev 121761)
@@ -11,18 +11,20 @@
 height: 400
 
 property bool selectFile
+property bool returnEmpty: false
 property bool acceptMultiple: false
 
 experimental.filePicker: Item {
 Component.onCompleted: {
-var selectedFiles = [filename1, filename2]
-if (selectFile) {
+if (returnEmpty)
+model.accept();
+else if (selectFile) {
+var selectedFiles = [filename1, filename2];
 if (acceptMultiple)
-model.accept(selectedFiles)
+model.accept(selectedFiles);
 else
 model.accept(acceptedfilename);
-}
-else
+} else
 model.reject();
 }
 }
@@ -57,12 +59,21 @@
 
 function test_multiple() {
 webView.selectFile = true;
+webView.returnEmpty = false;
 webView.acceptMultiple = true;
 openItemSelector()
 titleSpy.wait()
 compare(webView.title, filename1)
 }
 
+function test_rejectIfEmptyAccept() {
+var oldTitle = webView.title
+webView.selectFile = false;
+webView.returnEmpty = true;
+openItemSelector()
+compare(webView.title, oldTitle)
+}
+
 function test_reject() {
 var oldTitle = webView.title
 webView.selectFile = false;


Modified: trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp (121760 => 121761)

--- trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp	2012-07-03 13:00:46 UTC (rev 121760)
+++ trunk/Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp	2012-07-03 13:32:29 UTC (rev 121761)
@@ -223,6 +223,12 @@
 void accept(const QVariant path)
 {
 QStringList filesPath = path.toStringList();
+
+if (filesPath.isEmpty()) {
+emit rejected();
+return;
+}
+
 // For single file upload, send only the first element if there are more than one file paths
 if (!m_allowMultiple  filesPath.count()  1)
 filesPath = QStringList(filesPath.at(0));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121686] trunk/Source/WebKit2

[alexis . menard]

Title: [121686] trunk/Source/WebKit2








Revision 121686
Author alexis.men...@openbossa.org
Date 2012-07-02 09:31:10 -0700 (Mon, 02 Jul 2012)


Log Message
[Qt] Fix WebProcess crash on Mac when accessing a site with video tag.
https://bugs.webkit.org/show_bug.cgi?id=90384

Reviewed by Jocelyn Turcotte.

We need to initialize the private symbols used by MediaPlayerPrivateQTKit
otherwise they will be null and it will lead to a crash. We copy WebSystemInterface
files for WK2 just like the Mac port as WK2 may have different needs than WK1 layer (we
may add or remove symbols in here). It doesn't fix the video rendering yet but it's
first step.

* Target.pri:
* WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Added.
* WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Added.
(InitWebCoreSystemInterfaceForWK2):
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp


Added Paths

trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebSystemInterface.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebSystemInterface.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121685 => 121686)

--- trunk/Source/WebKit2/ChangeLog	2012-07-02 16:22:13 UTC (rev 121685)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-02 16:31:10 UTC (rev 121686)
@@ -1,3 +1,23 @@
+2012-07-02  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Fix WebProcess crash on Mac when accessing a site with video tag.
+https://bugs.webkit.org/show_bug.cgi?id=90384
+
+Reviewed by Jocelyn Turcotte.
+
+We need to initialize the private symbols used by MediaPlayerPrivateQTKit
+otherwise they will be null and it will lead to a crash. We copy WebSystemInterface
+files for WK2 just like the Mac port as WK2 may have different needs than WK1 layer (we
+may add or remove symbols in here). It doesn't fix the video rendering yet but it's
+first step.
+
+* Target.pri:
+* WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Added.
+* WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Added.
+(InitWebCoreSystemInterfaceForWK2):
+* WebProcess/qt/WebProcessMainQt.cpp:
+(WebKit::WebProcessMainQt):
+
 2012-07-02  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL] [WK2] Remove content sniffer and decoder initialization from WebProcess


Modified: trunk/Source/WebKit2/Target.pri (121685 => 121686)

--- trunk/Source/WebKit2/Target.pri	2012-07-02 16:22:13 UTC (rev 121685)
+++ trunk/Source/WebKit2/Target.pri	2012-07-02 16:31:10 UTC (rev 121686)
@@ -771,6 +771,16 @@
 WebProcess/qt/WebProcessQt.cpp
 
 mac: {
+
+contains(DEFINES, WTF_USE_QTKIT=1) {
+DEFINES += NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
+INCLUDEPATH += \
+$$PWD/../../WebKitLibraries/
+HEADERS += \
+WebProcess/WebCoreSupport/qt/WebSystemInterface.h
+SOURCES += \
+WebProcess/WebCoreSupport/qt/WebSystemInterface.mm
+}
 INCLUDEPATH += \
 Platform/mac \
 Platform/CoreIPC/mac


Added: trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebSystemInterface.h (0 => 121686)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebSystemInterface.h	(rev 0)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebSystemInterface.h	2012-07-02 16:31:10 UTC (rev 121686)
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2006 Apple Computer, Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer. 
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution. 
+ * 3.  Neither the name of Apple Computer, Inc. (Apple) nor the names of
+ * its contributors may be used to endorse or promote products derived
+ * from this software without specific prior written permission. 
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS AS IS AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING N

[webkit-changes] [121703] trunk/LayoutTests

[alexis . menard]

Title: [121703] trunk/LayoutTests








Revision 121703
Author alexis.men...@openbossa.org
Date 2012-07-02 12:56:36 -0700 (Mon, 02 Jul 2012)


Log Message
fast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots
https://bugs.webkit.org/show_bug.cgi?id=89620

Reviewed by Simon Fraser.

Remove the border-radius from the test case as it can produce differences between
the test case and the reference html. At first we thought the 3 pixels difference
was only happening on Mac but after investigation it also happens in Qt (at least).
It was not triggered because ImageDiff was called with some tolerance. Turning the
tolerance to 0 on Qt also trigger some pixel differences.

The differences on how the radius is drawn can be explained by the fact that
the reference html and the test case uses two different paths for drawing the border.
The reference on the slice case only draw three borders which leads into the contruction
of three different drawing paths that we use to clip and clip out. We then draw the border with
antialiasing off as we have constructed the outer and inner paths pretty accurately.
The test case in the other hand uses the fast path for drawing the borders. The slice effect
is in fact is happening because the graphics context is clipped to the current InlineFlowBox rect but still
the border has 4 edges and its drawing will happen using the following : create a path with
an outer rounded rectangle and an inner rounded rectangle. The path is then filled with RULE_EVENODD
and anti-aliasing turn on to achieve a nice looking effect.

To conclude the pixel differences are the fact of the two different drawing techniques used here. Fast
drawing and anti-aliasing to get a decent result or more accurate algorithm but slower. The original test
was not about testing the radiuses of the borders but rather if the borders are cloned or sliced. Even
removing the radius still cover the feature.

* fast/box-decoration-break/box-decoration-break-rendering-expected.html:
* fast/box-decoration-break/box-decoration-break-rendering.html:
* platform/mac/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html
trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.html
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (121702 => 121703)

--- trunk/LayoutTests/ChangeLog	2012-07-02 19:46:16 UTC (rev 121702)
+++ trunk/LayoutTests/ChangeLog	2012-07-02 19:56:36 UTC (rev 121703)
@@ -1,3 +1,36 @@
+2012-07-02  Alexis Menard  alexis.men...@openbossa.org
+
+fast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots
+https://bugs.webkit.org/show_bug.cgi?id=89620
+
+Reviewed by Simon Fraser.
+
+Remove the border-radius from the test case as it can produce differences between
+the test case and the reference html. At first we thought the 3 pixels difference
+was only happening on Mac but after investigation it also happens in Qt (at least).
+It was not triggered because ImageDiff was called with some tolerance. Turning the
+tolerance to 0 on Qt also trigger some pixel differences.
+
+The differences on how the radius is drawn can be explained by the fact that
+the reference html and the test case uses two different paths for drawing the border.
+The reference on the slice case only draw three borders which leads into the contruction
+of three different drawing paths that we use to clip and clip out. We then draw the border with
+antialiasing off as we have constructed the outer and inner paths pretty accurately.
+The test case in the other hand uses the fast path for drawing the borders. The slice effect
+is in fact is happening because the graphics context is clipped to the current InlineFlowBox rect but still
+the border has 4 edges and its drawing will happen using the following : create a path with 
+an outer rounded rectangle and an inner rounded rectangle. The path is then filled with RULE_EVENODD
+and anti-aliasing turn on to achieve a nice looking effect.
+
+To conclude the pixel differences are the fact of the two different drawing techniques used here. Fast
+drawing and anti-aliasing to get a decent result or more accurate algorithm but slower. The original test
+was not about testing the radiuses of the borders but rather if the borders are cloned or sliced. Even
+removing the radius still cover the feature.
+
+* fast/box-decoration-break/box-decoration-break-rendering-expected.html:
+* fast/box-decoration-break/box-decoration-break-rendering.html:
+* platform/mac/Skipped:
+
 2012-07-02  Dan Bernstein  m...@apple.com
 
 rdar://problem/11787030 In vertical writing modes, child following float-clearing block has incorrect logi

[webkit-changes] [121392] trunk

[alexis . menard]

Title: [121392] trunk








Revision 121392
Author alexis.men...@openbossa.org
Date 2012-06-27 18:05:27 -0700 (Wed, 27 Jun 2012)


Log Message
Implement selectedOptions attribute of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=80631

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a new collection as a member of HTMLSelectElement which is
used to store the selected elements. Extend HTMLCollection to
support the new collection type needed by this feature. Make sure
that we invalidate the collection when the select state of an
option changes as the select state change does not trigger a dom
tree version change.

Reference : http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#dom-select-selectedoptions

Test: fast/dom/HTMLSelectElement/select-selectedOptions.html

* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::clearCache):
(WebCore):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLCollection.h:
(HTMLCollection):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setSelectedState):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore):
(WebCore::HTMLSelectElement::invalidateSelectedItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
* html/HTMLSelectElement.h:
(WebCore):
(HTMLSelectElement):
* html/HTMLSelectElement.idl:

LayoutTests:

New tests to cover the feature.

* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
* fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
* fast/dom/htmlcollection-non-html-expected.txt:
* fast/dom/htmlcollection-non-html.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/htmlcollection-non-html-expected.txt
trunk/LayoutTests/fast/dom/htmlcollection-non-html.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/CollectionType.h
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLOptionElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h
trunk/Source/WebCore/html/HTMLSelectElement.idl


Added Paths

trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt
trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions.html




Diff

Modified: trunk/LayoutTests/ChangeLog (121391 => 121392)

--- trunk/LayoutTests/ChangeLog	2012-06-28 00:49:55 UTC (rev 121391)
+++ trunk/LayoutTests/ChangeLog	2012-06-28 01:05:27 UTC (rev 121392)
@@ -1,3 +1,17 @@
+2012-06-27  Alexis Menard  alexis.men...@openbossa.org
+
+Implement selectedOptions attribute of HTMLSelectElement.
+https://bugs.webkit.org/show_bug.cgi?id=80631
+
+Reviewed by Ryosuke Niwa.
+
+New tests to cover the feature.
+
+* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Added.
+* fast/dom/HTMLSelectElement/select-selectedOptions.html: Added.
+* fast/dom/htmlcollection-non-html-expected.txt:
+* fast/dom/htmlcollection-non-html.html:
+
 2012-06-27  Filip Pizlo  fpi...@apple.com
 
 _javascript_ SHA-512 gives wrong hash on second and subsequent runs unless Web Inspector _javascript_ Debugging is on


Added: trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt (0 => 121392)

--- trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt	2012-06-28 01:05:27 UTC (rev 121392)
@@ -0,0 +1,51 @@
+
+1) Initial there is no selected options.
+PASS optionsLength is 2
+PASS selectedOptions.length is 0
+2) Select an option should update the selected options collection.
+PASS optionsLength is 2
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'one'
+3) Select two options should update the selected options collection.
+PASS optionsLength is 2
+PASS selectedOptions.length is 2
+PASS selectedOptions[0].text is 'one'
+PASS selectedOptions[1].text is 'two'
+4) Adding a non selected option should not change the selected options collection.
+PASS optionsLength is 3
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'one'
+5) Adding a selected option should change the selected options collection.
+PASS optionsLength is 4
+PASS selectedOptions.length is 2
+PASS selectedOptions[0].text is 'one'
+PASS selectedOptions[1].text is 'five'
+6) Unselect an option should update the selected options collection.
+PASS optionsLength is 4
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'five'
+7) Remove an option unselected should not update the selected options collection.
+PASS optionsLength is 3
+PASS selectedOptions.length is 1
+PASS selectedOptions[0].text is 'five'
+8) Remove an option selected should update the selected options collection.
+PASS optionsLength is 2

[webkit-changes] [120818] trunk/Source/WebKit2

[alexis . menard]

Title: [120818] trunk/Source/WebKit2








Revision 120818
Author alexis.men...@openbossa.org
Date 2012-06-20 06:26:56 -0700 (Wed, 20 Jun 2012)


Log Message
REGRESSION (120705) : LayerTreeHostQt asserts in debug.
https://bugs.webkit.org/show_bug.cgi?id=89487

Reviewed by Noam Rosenthal.

We try to call createHandle twice on the same handle when the
first matching atlas is full. This patch solved the problem by
moving the createHandle call inside UpdateAtlas and call createHandle
only when the atlas is not full. We can also remove the surface()
getter as it is not used anymore.

* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlas):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::beginContentUpdate):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp
trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (120817 => 120818)

--- trunk/Source/WebKit2/ChangeLog	2012-06-20 12:35:41 UTC (rev 120817)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-20 13:26:56 UTC (rev 120818)
@@ -1,3 +1,23 @@
+2012-06-20  Alexis Menard  alexis.men...@openbossa.org
+
+REGRESSION (120705) : LayerTreeHostQt asserts in debug.
+https://bugs.webkit.org/show_bug.cgi?id=89487
+
+Reviewed by Noam Rosenthal.
+
+We try to call createHandle twice on the same handle when the
+first matching atlas is full. This patch solved the problem by
+moving the createHandle call inside UpdateAtlas and call createHandle
+only when the atlas is not full. We can also remove the surface()
+getter as it is not used anymore.
+
+* WebProcess/WebPage/UpdateAtlas.cpp:
+(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
+* WebProcess/WebPage/UpdateAtlas.h:
+(UpdateAtlas):
+* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
+(WebKit::LayerTreeHostQt::beginContentUpdate):
+
 2012-06-19  Ryuan Choi  ryuan.c...@samsung.com
 
 [EFL][Regression] Build break after r120786


Modified: trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp (120817 => 120818)

--- trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp	2012-06-20 12:35:41 UTC (rev 120817)
+++ trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp	2012-06-20 13:26:56 UTC (rev 120818)
@@ -99,7 +99,7 @@
 m_bufferStates[i] = Available;
 }
 
-PassOwnPtrGraphicsContext UpdateAtlas::beginPaintingOnAvailableBuffer(const WebCore::IntSize size, IntPoint offset)
+PassOwnPtrGraphicsContext UpdateAtlas::beginPaintingOnAvailableBuffer(ShareableSurface::Handle handle, const WebCore::IntSize size, IntPoint offset)
 {
 buildLayoutIfNeeded();
 int index = findAvailableIndex(size);
@@ -108,6 +108,9 @@
 if (index  0)
 return PassOwnPtrGraphicsContext();
 
+if (!m_surface-createHandle(handle))
+return PassOwnPtrWebCore::GraphicsContext();
+
 // FIXME: Use tri-state buffers, to allow faster updates.
 m_bufferStates[index] = Taken;
 offset = offsetForIndex(index);


Modified: trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h (120817 => 120818)

--- trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h	2012-06-20 12:35:41 UTC (rev 120817)
+++ trunk/Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h	2012-06-20 13:26:56 UTC (rev 120818)
@@ -34,11 +34,10 @@
 public:
 UpdateAtlas(int dimension, ShareableBitmap::Flags);
 
-PassRefPtrShareableSurface surface() { return m_surface; }
 inline WebCore::IntSize size() const { return m_surface-size(); }
 
 // Returns a null pointer of there is no available buffer.
-PassOwnPtrWebCore::GraphicsContext beginPaintingOnAvailableBuffer(const WebCore::IntSize, WebCore::IntPoint offset);
+PassOwnPtrWebCore::GraphicsContext beginPaintingOnAvailableBuffer(ShareableSurface::Handle, const WebCore::IntSize, WebCore::IntPoint offset);
 void didSwapBuffers();
 ShareableBitmap::Flags flags() const { return m_flags; }
 


Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp (120817 => 120818)

--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-06-20 12:35:41 UTC (rev 120817)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-06-20 13:26:56 UTC (rev 120818)
@@ -552,13 +552,6 @@
 m_updateAtlases.clear();
 }
 
-static PassOwnPtrWebCore::GraphicsContext beginContentUpdateInAtlas(UpdateAtlas atlas, const WebCore::IntSize size, ShareableSurface::Handle handle, WebCore::IntPoint offset)
-{
-if (!atlas.surface()-createHandle(handle))
-return PassOwnPtrWebCore::GraphicsContext();
-return atlas.beginPaintingOnAvailableBuffer(size, offset);
-}
-
 PassOwnPtrWebCore::GraphicsContext LayerTreeHostQt::beginContentUpdate(const WebCore::IntSize size, ShareableB

[webkit-changes] [120835] trunk

[alexis . menard]

Title: [120835] trunk








Revision 120835
Author alexis.men...@openbossa.org
Date 2012-06-20 10:49:18 -0700 (Wed, 20 Jun 2012)


Log Message
[CSS3 Backgrounds and Borders] Implement box-decoration-break rendering.
https://bugs.webkit.org/show_bug.cgi?id=88228

Reviewed by Eric Seidel.

Source/WebCore:

Implement the new CSS property box-decoration-break. It modifies
where we decide whether the borders needs to be sliced or not by
checking if the box-decoration-break is set to clone. If it's the case
then we need to explicitely redraw all edges.

Test: fast/box-decoration-break/box-decoration-break-rendering.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paintFillLayer):

LayoutTests:

Add new tests to cover the feature.

* fast/box-decoration-break/box-decoration-break-rendering-expected.html: Added.
* fast/box-decoration-break/box-decoration-break-rendering.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineFlowBox.cpp


Added Paths

trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html
trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.html




Diff

Modified: trunk/LayoutTests/ChangeLog (120834 => 120835)

--- trunk/LayoutTests/ChangeLog	2012-06-20 17:48:23 UTC (rev 120834)
+++ trunk/LayoutTests/ChangeLog	2012-06-20 17:49:18 UTC (rev 120835)
@@ -1,3 +1,15 @@
+2012-06-20  Alexis Menard  alexis.men...@openbossa.org
+
+[CSS3 Backgrounds and Borders] Implement box-decoration-break rendering.
+https://bugs.webkit.org/show_bug.cgi?id=88228
+
+Reviewed by Eric Seidel.
+
+Add new tests to cover the feature.
+
+* fast/box-decoration-break/box-decoration-break-rendering-expected.html: Added.
+* fast/box-decoration-break/box-decoration-break-rendering.html: Added.
+
 2012-06-20  Hans Wennborg  h...@chromium.org
 
 Speech _javascript_ API: add SpeechRecognition.maxAlternatives attribute


Added: trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html (0 => 120835)

--- trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering-expected.html	2012-06-20 17:49:18 UTC (rev 120835)
@@ -0,0 +1,63 @@
+!DOCTYPE html
+html
+head
+titleTest of box-decoration break rendering when the a text is broken in multiple lines/title
+style type=text/css
+body {
+width:  360px;
+font: monospace 10px;
+}
+span {
+display: block;
+width: 360px;
+}
+#rightCutHighlight {
+display: inline;
+border-top: 2px solid red;
+border-right: 0px solid red;
+border-left: 2px solid red;
+border-bottom: 2px solid red;
+border-top-left-radius: 4px;
+border-top-right-radius: 0px;
+border-bottom-right-radius: 0px;
+border-bottom-left-radius: 4px;
+background: yellow;
+box-shadow: 0px 1px 3px dimgrey;
+}
+#leftCutHighlight {
+display: inline;
+margin: 0px;
+padding: 0px;
+border-top: 2px solid red;
+border-right: 2px solid red;
+border-left: 0px solid red;
+border-bottom: 2px solid red;
+border-top-left-radius: 0px;
+border-top-right-radius: 4px;
+border-bottom-right-radius: 4px;
+border-bottom-left-radius: 0px;
+background: yellow;
+box-shadow: 0px 1px 3px dimgrey;
+}
+.clone {
+display: inline;
+margin: 0px;
+padding: 0px;
+border: 2px solid red;
+border-radius: 4px;
+background: yellow;
+box-shadow: 0px 1px 3px dimgrey;
+}
+/style
+
+/head
+body
+h1Box-decoration-break: slice/h1
+spanThis long word should break in a new line : span id=rightCutHighlightveryveryveryveryveryveryvery-/spanbrspan id=leftCutHighlight-longword/span. box-decoration-break is set to cloned,
+so the right edge of the previous line is cut, and the left edge of the highlight in this line is cut too./span
+h1Box-decoration-break: clone/h1
+spanThis long word should break in a new line : span class=cloneveryveryveryveryveryveryvery-/spanbrspan class=clone-longword/span. box-decoration-break is set to cloned,
+so the right edge of the previous line is similar as its left edge, and the left edge of the highlight in this line is similar as its right one. /span
+/body
+/body
+/html


Added: trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.html (0 => 120835)

--- trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.html	(rev 0)
+++ trunk/LayoutTests/fast/box-decoration-break/box-decoration-break-rendering.htm

[webkit-changes] [120705] trunk/Source/WebKit2

[alexis . menard]

Title: [120705] trunk/Source/WebKit2








Revision 120705
Author alexis.men...@openbossa.org
Date 2012-06-19 04:43:37 -0700 (Tue, 19 Jun 2012)


Log Message
[Qt] Create an extra atlas when there is no available buffer space.
https://bugs.webkit.org/show_bug.cgi?id=89012

Reviewed by Noam Rosenthal.

In case of the desktop mode when we scroll the view all the tiles
are updated. It can happen that there no available buffer space for
the currently used atlas(especially when scrolling fast). In that case
we can create a new one. One future improvement could be to make a timer and
delete this extra atlas when it is not used.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::beginContentUpdateInAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (120704 => 120705)

--- trunk/Source/WebKit2/ChangeLog	2012-06-19 11:34:43 UTC (rev 120704)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-19 11:43:37 UTC (rev 120705)
@@ -1,3 +1,22 @@
+2012-06-19  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Create an extra atlas when there is no available buffer space.
+https://bugs.webkit.org/show_bug.cgi?id=89012
+
+Reviewed by Noam Rosenthal.
+
+In case of the desktop mode when we scroll the view all the tiles
+are updated. It can happen that there no available buffer space for
+the currently used atlas(especially when scrolling fast). In that case 
+we can create a new one. One future improvement could be to make a timer and 
+delete this extra atlas when it is not used.
+
+* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
+(WebKit::beginContentUpdateInAtlas):
+(WebKit::LayerTreeHostQt::beginContentUpdate):
+* WebProcess/WebPage/qt/LayerTreeHostQt.h:
+(LayerTreeHostQt):
+
 2012-06-19  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp (120704 => 120705)

--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-06-19 11:34:43 UTC (rev 120704)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-06-19 11:43:37 UTC (rev 120705)
@@ -552,29 +552,29 @@
 m_updateAtlases.clear();
 }
 
-UpdateAtlas LayerTreeHostQt::getAtlas(ShareableBitmap::Flags flags)
+static PassOwnPtrWebCore::GraphicsContext beginContentUpdateInAtlas(UpdateAtlas atlas, const WebCore::IntSize size, ShareableSurface::Handle handle, WebCore::IntPoint offset)
 {
-for (int i = 0; i  m_updateAtlases.size(); ++i) {
-if (m_updateAtlases[i].flags() == flags)
-return m_updateAtlases[i];
-}
-static const int ScratchBufferDimension = 2000;
-m_updateAtlases.append(UpdateAtlas(ScratchBufferDimension, flags));
-return m_updateAtlases.last();
+if (!atlas.surface()-createHandle(handle))
+return PassOwnPtrWebCore::GraphicsContext();
+return atlas.beginPaintingOnAvailableBuffer(size, offset);
 }
 
 PassOwnPtrWebCore::GraphicsContext LayerTreeHostQt::beginContentUpdate(const WebCore::IntSize size, ShareableBitmap::Flags flags, ShareableSurface::Handle handle, WebCore::IntPoint offset)
 {
-UpdateAtlas atlas = getAtlas(flags);
-if (!atlas.surface()-createHandle(handle))
-return PassOwnPtrWebCore::GraphicsContext();
+OwnPtrWebCore::GraphicsContext graphicsContext;
+for (int i = 0; i  m_updateAtlases.size(); ++i) {
+UpdateAtlas atlas = m_updateAtlases[i];
+if (atlas.flags() == flags) {
+// This will return null if there is no available buffer space.
+graphicsContext = beginContentUpdateInAtlas(atlas, size, handle, offset);
+if (graphicsContext)
+return graphicsContext.release();
+}
+}
 
-// This will return null if there is no available buffer.
-OwnPtrWebCore::GraphicsContext graphicsContext = atlas.beginPaintingOnAvailableBuffer(size, offset);
-if (!graphicsContext)
-return PassOwnPtrWebCore::GraphicsContext();
-
-return graphicsContext.release();
+static const int ScratchBufferDimension = 2000;
+m_updateAtlases.append(UpdateAtlas(ScratchBufferDimension, flags));
+return beginContentUpdateInAtlas(m_updateAtlases.last(), size, handle, offset);
 }
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h (120704 => 120705)

--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h	2012-06-19 11:34:43 UTC (rev 120704)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h	2012-06-19 11:43:37 UTC (rev 120705)
@@ -105,8 +105,6 @@
 void performScheduledL

[webkit-changes] [120211] trunk/Source/WebKit2

[alexis . menard]

Title: [120211] trunk/Source/WebKit2








Revision 120211
Author alexis.men...@openbossa.org
Date 2012-06-13 08:14:33 -0700 (Wed, 13 Jun 2012)


Log Message
Web Inspector: add a way to get the remote inspector url for a given page.
https://bugs.webkit.org/show_bug.cgi?id=88902

Reviewed by Jocelyn Turcotte.

Expose the remote inspector url for a given page in the API. If you want
to create a web view and load directly the inspector for the page you want to inspect,
it helps to get the url as it is impossible to figure it out from the API layer.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::remoteInspectorUrl):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/InspectorServer/WebInspectorServer.cpp:
(WebKit):
(WebKit::WebInspectorServer::inspectorUrlForPageID):
* UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
* UIProcess/InspectorServer/WebSocketServer.cpp:
(WebKit::WebSocketServer::WebSocketServer):
(WebKit::WebSocketServer::listen):
(WebKit::WebSocketServer::close):
* UIProcess/InspectorServer/WebSocketServer.h:
(WebKit::WebSocketServer::bindAddress):
(WebKit::WebSocketServer::port):
(WebKit::WebSocketServer::serverState):
(WebSocketServer):
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
(WebKit::remoteInspectorPagePath):
(WebKit):
(WebKit::WebInspectorServer::inspectorUrlForPageID):
(WebKit::WebInspectorServer::buildPageList):
* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::remoteInspectionPageID):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/InspectorServer/WebInspectorServer.cpp
trunk/Source/WebKit2/UIProcess/InspectorServer/WebInspectorServer.h
trunk/Source/WebKit2/UIProcess/InspectorServer/WebSocketServer.cpp
trunk/Source/WebKit2/UIProcess/InspectorServer/WebSocketServer.h
trunk/Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (120210 => 120211)

--- trunk/Source/WebKit2/ChangeLog	2012-06-13 15:07:57 UTC (rev 120210)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-13 15:14:33 UTC (rev 120211)
@@ -1,3 +1,39 @@
+2012-06-13  Alexis Menard  alexis.men...@openbossa.org
+
+Web Inspector: add a way to get the remote inspector url for a given page.
+https://bugs.webkit.org/show_bug.cgi?id=88902
+
+Reviewed by Jocelyn Turcotte.
+
+Expose the remote inspector url for a given page in the API. If you want
+to create a web view and load directly the inspector for the page you want to inspect,
+it helps to get the url as it is impossible to figure it out from the API layer.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewExperimental::remoteInspectorUrl):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/InspectorServer/WebInspectorServer.cpp:
+(WebKit):
+(WebKit::WebInspectorServer::inspectorUrlForPageID):
+* UIProcess/InspectorServer/WebInspectorServer.h:
+(WebInspectorServer):
+* UIProcess/InspectorServer/WebSocketServer.cpp:
+(WebKit::WebSocketServer::WebSocketServer):
+(WebKit::WebSocketServer::listen):
+(WebKit::WebSocketServer::close):
+* UIProcess/InspectorServer/WebSocketServer.h:
+(WebKit::WebSocketServer::bindAddress):
+(WebKit::WebSocketServer::port):
+(WebKit::WebSocketServer::serverState):
+(WebSocketServer):
+* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
+(WebKit::remoteInspectorPagePath):
+(WebKit):
+(WebKit::WebInspectorServer::inspectorUrlForPageID):
+(WebKit::WebInspectorServer::buildPageList):
+* UIProcess/WebInspectorProxy.h:
+(WebKit::WebInspectorProxy::remoteInspectionPageID):
+
 2012-06-13  Christophe Dumez  christophe.du...@intel.com
 
 [WK2] Add implementation for dispatchIntent in WebFrameLoaderClient


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (120210 => 120211)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-06-13 15:07:57 UTC (rev 120210)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-06-13 15:14:33 UTC (rev 120211)
@@ -34,6 +34,8 @@
 #include QtWebPagePolicyClient.h
 #include UtilsQt.h
 #include WebBackForwardList.h
+#include WebInspectorProxy.h
+#include WebInspectorServer.h
 #if ENABLE(FULLSCREEN_API)
 #include WebFullScreenManagerProxy.h
 #endif
@@ -1295,6 +1297,11 @@
 emit userScriptsChanged();
 }
 
+QUrl QQuickWebViewExperimental::remoteInspectorUrl() const
+{
+return QUrl(WebInspectorServer::shared().inspectorUrlForPageID(d_ptr-webPageProxy-inspector()-remoteInspectionPageID()));
+}
+
 QQuickUrlSchemeDelegate* QQuickWebViewExperimental::schemeDelegates_At(QQmlListPropertyQQuickUrlSchemeDelegate* property, int

[webkit-changes] [120136] trunk/Source/WebCore

[alexis . menard]

Title: [120136] trunk/Source/WebCore








Revision 120136
Author alexis.men...@openbossa.org
Date 2012-06-12 16:07:21 -0700 (Tue, 12 Jun 2012)


Log Message
Fix packing in StyleBoxData for Windows.
https://bugs.webkit.org/show_bug.cgi?id=88858

Reviewed by Tony Chang.

MSVC doesn't pack bitfields if the types are mixed.
We can safely change the bool type to an unsigned so
the packing will happen. I have added a compile assert
for future regressions.

No new tests : we should not see any regressions.

* rendering/style/StyleBoxData.h:
* rendering/style/StyleBoxData.cpp:
(StyleBoxData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/StyleBoxData.cpp
trunk/Source/WebCore/rendering/style/StyleBoxData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (120135 => 120136)

--- trunk/Source/WebCore/ChangeLog	2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/ChangeLog	2012-06-12 23:07:21 UTC (rev 120136)
@@ -1,3 +1,21 @@
+2012-06-12  Alexis Menard  alexis.men...@openbossa.org
+
+Fix packing in StyleBoxData for Windows.
+https://bugs.webkit.org/show_bug.cgi?id=88858
+
+Reviewed by Tony Chang.
+
+MSVC doesn't pack bitfields if the types are mixed.
+We can safely change the bool type to an unsigned so
+the packing will happen. I have added a compile assert
+for future regressions.
+
+No new tests : we should not see any regressions.
+
+* rendering/style/StyleBoxData.h:
+* rendering/style/StyleBoxData.cpp:
+(StyleBoxData):
+
 2012-06-12  Adrienne Walker  e...@google.com
 
 [chromium] Paint scrollbars on WebKit thread and composite those textures


Modified: trunk/Source/WebCore/rendering/style/StyleBoxData.cpp (120135 => 120136)

--- trunk/Source/WebCore/rendering/style/StyleBoxData.cpp	2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/rendering/style/StyleBoxData.cpp	2012-06-12 23:07:21 UTC (rev 120136)
@@ -27,6 +27,14 @@
 
 namespace WebCore {
 
+struct SameSizeAsStyleBoxData : public RefCountedSameSizeAsStyleBoxData {
+Length length[7];
+int m_zIndex;
+uint32_t bitfields;
+};
+
+COMPILE_ASSERT(sizeof(StyleBoxData) == sizeof(SameSizeAsStyleBoxData), StyleBoxData_should_not_grow);
+
 StyleBoxData::StyleBoxData()
 : m_minWidth(RenderStyle::initialMinSize())
 , m_maxWidth(RenderStyle::initialMaxSize())


Modified: trunk/Source/WebCore/rendering/style/StyleBoxData.h (120135 => 120136)

--- trunk/Source/WebCore/rendering/style/StyleBoxData.h	2012-06-12 23:04:17 UTC (rev 120135)
+++ trunk/Source/WebCore/rendering/style/StyleBoxData.h	2012-06-12 23:07:21 UTC (rev 120136)
@@ -80,7 +80,7 @@
 Length m_verticalAlign;
 
 int m_zIndex;
-bool m_hasAutoZIndex : 1;
+unsigned m_hasAutoZIndex : 1;
 unsigned m_boxSizing : 1; // EBoxSizing
 #if ENABLE(CSS_BOX_DECORATION_BREAK)
 unsigned m_boxDecorationBreak : 1; // EBoxDecorationBreak






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [119497] trunk/Source/WebKit2

[alexis . menard]

Title: [119497] trunk/Source/WebKit2








Revision 119497
Author alexis.men...@openbossa.org
Date 2012-06-05 09:30:47 -0700 (Tue, 05 Jun 2012)


Log Message
[Qt] Don't propagate viewport size changes if the viewport is empty.
https://bugs.webkit.org/show_bug.cgi?id=88336

Reviewed by Tor Arne Vestbø.

Qt Quick sequentially set the x, y, width, height of the view. We really want to
start propagating further when the size of the viewport becomes valid, i.e. both
height and width are defined. In any case lower level classes are discarding an empty
size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
through the IPC bus for nothing.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (119496 => 119497)

--- trunk/Source/WebKit2/ChangeLog	2012-06-05 16:23:42 UTC (rev 119496)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-05 16:30:47 UTC (rev 119497)
@@ -1,3 +1,19 @@
+2012-06-05  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Don't propagate viewport size changes if the viewport is empty.
+https://bugs.webkit.org/show_bug.cgi?id=88336
+
+Reviewed by Tor Arne Vestbø.
+
+Qt Quick sequentially set the x, y, width, height of the view. We really want to
+start propagating further when the size of the viewport becomes valid, i.e. both
+height and width are defined. In any case lower level classes are discarding an empty
+size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
+through the IPC bus for nothing.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewLegacyPrivate::updateViewportSize):
+
 2012-06-05  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (119496 => 119497)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-06-05 16:23:42 UTC (rev 119496)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-06-05 16:30:47 UTC (rev 119497)
@@ -775,6 +775,8 @@
 {
 Q_Q(QQuickWebView);
 QSize viewportSize = q-boundingRect().size().toSize();
+if (viewportSize.isEmpty())
+return;
 pageView-setContentsSize(viewportSize);
 // The fixed layout is handled by the FrameView and the drawing area doesn't behave differently
 // whether its fixed or not. We still need to tell the drawing area which part of it






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [119516] trunk/Source/WebKit2

[alexis . menard]

Title: [119516] trunk/Source/WebKit2








Revision 119516
Author alexis.men...@openbossa.org
Date 2012-06-05 12:59:17 -0700 (Tue, 05 Jun 2012)


Log Message
WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte jocelyn.turco...@nokia.com on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (119515 => 119516)

--- trunk/Source/WebKit2/ChangeLog	2012-06-05 19:52:48 UTC (rev 119515)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-05 19:59:17 UTC (rev 119516)
@@ -1,3 +1,18 @@
+2012-06-05  Jocelyn Turcotte  jocelyn.turco...@nokia.com
+
+WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
+https://bugs.webkit.org/show_bug.cgi?id=88357
+
+Reviewed by Alexis Menard.
+
+The contentsScale needs to get a default value in case no
+value is explicitely set yet.
+This fixes the blank-until-resize problem when running MiniBrowser
+in --desktop mode.
+
+* UIProcess/WebLayerTreeRenderer.cpp:
+(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
+
 2012-06-05  Alexis Menard  alexis.men...@openbossa.org
 
 [Qt] Don't propagate viewport size changes if the viewport is empty.


Modified: trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp (119515 => 119516)

--- trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp	2012-06-05 19:52:48 UTC (rev 119515)
+++ trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp	2012-06-05 19:59:17 UTC (rev 119516)
@@ -86,7 +86,8 @@
 }
 
 WebLayerTreeRenderer::WebLayerTreeRenderer(LayerTreeHostProxy* layerTreeHostProxy)
-: m_layerTreeHostProxy(layerTreeHostProxy)
+: m_contentsScale(1)
+, m_layerTreeHostProxy(layerTreeHostProxy)
 , m_rootLayerID(InvalidWebLayerID)
 , m_isActive(false)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118681] trunk/Source/WebCore

[alexis . menard]

Title: [118681] trunk/Source/WebCore








Revision 118681
Author alexis.men...@openbossa.org
Date 2012-05-28 07:54:03 -0700 (Mon, 28 May 2012)


Log Message
Unreviewed build fix for Mac on Lion.

* inspector/CodeGeneratorInspector.py:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (118680 => 118681)

--- trunk/Source/WebCore/ChangeLog	2012-05-28 13:49:30 UTC (rev 118680)
+++ trunk/Source/WebCore/ChangeLog	2012-05-28 14:54:03 UTC (rev 118681)
@@ -1,3 +1,9 @@
+2012-05-28  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed build fix for Mac on Lion.
+
+* inspector/CodeGeneratorInspector.py:
+
 2012-05-28  Keishi Hattori  kei...@webkit.org
 
 Expose value localization function of HTMLInputElement


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (118680 => 118681)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-05-28 13:49:30 UTC (rev 118680)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-05-28 14:54:03 UTC (rev 118681)
@@ -2251,7 +2251,7 @@
 int m_value;
 
 templatetypename T
-static int cast_to_int(T t) { return T::default_case_cast_is_not_supported(); }
+static int cast_to_int(T) { return T::default_case_cast_is_not_supported(); }
 };
 
 template






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [117909] trunk/Source/WebCore

[alexis . menard]

Title: [117909] trunk/Source/WebCore








Revision 117909
Author alexis.men...@openbossa.org
Date 2012-05-21 23:05:07 -0700 (Mon, 21 May 2012)


Log Message
Web Inspector: Remove some dead code in CSSStyleModel.js.
https://bugs.webkit.org/show_bug.cgi?id=87048

Reviewed by Pavel Feldman.

Remove dead and unused code in CSSStyleModel.js.

No new tests : the code is supposedly dead so we should not have
any regressions.

* inspector/front-end/CSSStyleModel.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (117908 => 117909)

--- trunk/Source/WebCore/ChangeLog	2012-05-22 05:58:52 UTC (rev 117908)
+++ trunk/Source/WebCore/ChangeLog	2012-05-22 06:05:07 UTC (rev 117909)
@@ -1,3 +1,17 @@
+2012-05-21  Alexis Menard  alexis.men...@openbossa.org
+
+Web Inspector: Remove some dead code in CSSStyleModel.js.
+https://bugs.webkit.org/show_bug.cgi?id=87048
+
+Reviewed by Pavel Feldman.
+
+Remove dead and unused code in CSSStyleModel.js.
+
+No new tests : the code is supposedly dead so we should not have
+any regressions.
+
+* inspector/front-end/CSSStyleModel.js:
+
 2012-05-21  Adam Barth  aba...@webkit.org
 
 !HAVE(ACCESSIBILITY) should be able to build without linking in any code from WebCore/accessibility


Modified: trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js (117908 => 117909)

--- trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js	2012-05-22 05:58:52 UTC (rev 117908)
+++ trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js	2012-05-22 06:05:07 UTC (rev 117909)
@@ -443,16 +443,6 @@
 
 /**
  * @param {string} name
- * @return {string}
- */
-getPropertyShorthand: function(name)
-{
-var property = this._livePropertyMap[name];
-return property ? property.shorthand : ;
-},
-
-/**
- * @param {string} name
  * @return {boolean}
  */
 isPropertyImplicit: function(name)
@@ -462,40 +452,6 @@
 },
 
 /**
- * @return {string}
- */
-styleTextWithShorthands: function()
-{
-var cssText = ;
-var foundProperties = {};
-for (var i = 0; i  this.length; ++i) {
-var individualProperty = this[i];
-var shorthandProperty = this.getPropertyShorthand(individualProperty);
-var propertyName = (shorthandProperty || individualProperty);
-
-if (propertyName in foundProperties)
-continue;
-
-if (shorthandProperty) {
-var value = this.getShorthandValue(shorthandProperty);
-var priority = this.getShorthandPriority(shorthandProperty);
-} else {
-var value = this.getPropertyValue(individualProperty);
-var priority = this.getPropertyPriority(individualProperty);
-}
-
-foundProperties[propertyName] = true;
-
-cssText += propertyName + :  + value;
-if (priority)
-cssText +=  ! + priority;
-cssText += ; ;
-}
-
-return cssText;
-},
-
-/**
  * @param {string} name
  * @return {Array.WebInspector.CSSProperty}
  */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [117964] trunk/Tools

[alexis . menard]

Title: [117964] trunk/Tools








Revision 117964
Author alexis.men...@openbossa.org
Date 2012-05-22 06:47:11 -0700 (Tue, 22 May 2012)


Log Message
[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
https://bugs.webkit.org/show_bug.cgi?id=87044

Patch by Hugo Parente Lima hugo.l...@openbossa.org on 2012-05-22
Reviewed by Alexis Menard.

Use sendOrQueueEvent instead of m_testController-mainWebView()-sendEvent

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp




Diff

Modified: trunk/Tools/ChangeLog (117963 => 117964)

--- trunk/Tools/ChangeLog	2012-05-22 13:28:52 UTC (rev 117963)
+++ trunk/Tools/ChangeLog	2012-05-22 13:47:11 UTC (rev 117964)
@@ -1,3 +1,15 @@
+2012-05-22  Hugo Parente Lima  hugo.l...@openbossa.org
+
+[Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
+https://bugs.webkit.org/show_bug.cgi?id=87044
+
+Reviewed by Alexis Menard.
+
+Use sendOrQueueEvent instead of m_testController-mainWebView()-sendEvent
+
+* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
+(WTR::EventSenderProxy::keyDown):
+
 2012-05-22  Zan Dobersek  zandober...@gmail.com
 
 [Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results


Modified: trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp (117963 => 117964)

--- trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp	2012-05-22 13:28:52 UTC (rev 117963)
+++ trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp	2012-05-22 13:47:11 UTC (rev 117964)
@@ -238,10 +238,12 @@
 code = Qt::Key_Menu;
 }
 }
-QKeyEvent event(QEvent::KeyPress, code, modifiers, keyText);
-m_testController-mainWebView()-sendEvent(event);
-QKeyEvent event2(QEvent::KeyRelease, code, modifiers, keyText);
-m_testController-mainWebView()-sendEvent(event2);
+
+QKeyEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers, keyText);
+sendOrQueueEvent(pressEvent);
+QKeyEvent* releaseEvent = new QKeyEvent(QEvent::KeyRelease, code, modifiers, keyText);
+sendOrQueueEvent(releaseEvent);
+
 }
 
 void EventSenderProxy::updateClickCountForButton(int button)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [118082] trunk/Source/WebCore

[alexis . menard]

Title: [118082] trunk/Source/WebCore








Revision 118082
Author alexis.men...@openbossa.org
Date 2012-05-22 16:59:08 -0700 (Tue, 22 May 2012)


Log Message
Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue.
https://bugs.webkit.org/show_bug.cgi?id=87169

Reviewed by Tony Chang.

Move some CSS regions properties to the fast path implemented by
CSSParser::isValidKeywordPropertyAndValue.

No new tests : Existing tests should cover.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (118081 => 118082)

--- trunk/Source/WebCore/ChangeLog	2012-05-22 23:56:58 UTC (rev 118081)
+++ trunk/Source/WebCore/ChangeLog	2012-05-22 23:59:08 UTC (rev 118082)
@@ -1,3 +1,20 @@
+2012-05-22  Alexis Menard  alexis.men...@openbossa.org
+
+Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue.
+https://bugs.webkit.org/show_bug.cgi?id=87169
+
+Reviewed by Tony Chang.
+
+Move some CSS regions properties to the fast path implemented by
+CSSParser::isValidKeywordPropertyAndValue.
+
+No new tests : Existing tests should cover.
+
+* css/CSSParser.cpp:
+(WebCore::isValidKeywordPropertyAndValue):
+(WebCore::isKeywordPropertyID):
+(WebCore::CSSParser::parseValue):
+
 2012-05-22  Emil A Eklund  e...@chromium.org
 
 Represents margins as box and simplify writing mode logic


Modified: trunk/Source/WebCore/css/CSSParser.cpp (118081 => 118082)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-05-22 23:56:58 UTC (rev 118081)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-05-22 23:59:08 UTC (rev 118082)
@@ -578,6 +578,18 @@
 if (valueID == CSSValueVisible || valueID == CSSValueHidden || valueID == CSSValueScroll || valueID == CSSValueAuto || valueID == CSSValueOverlay || valueID == CSSValueWebkitMarquee)
 return true;
 break;
+case CSSPropertyPageBreakAfter: // auto | always | avoid | left | right | inherit
+case CSSPropertyPageBreakBefore:
+case CSSPropertyWebkitColumnBreakAfter:
+case CSSPropertyWebkitColumnBreakBefore:
+if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
+return true;
+break;
+case CSSPropertyPageBreakInside: // avoid | auto | inherit
+case CSSPropertyWebkitColumnBreakInside:
+if (valueID == CSSValueAuto || valueID == CSSValueAvoid)
+return true;
+break;
 case CSSPropertyPointerEvents:
 // none | visiblePainted | visibleFill | visibleStroke | visible |
 // painted | fill | stroke | auto | all | inherit
@@ -746,6 +758,19 @@
 if (valueID == CSSValueExact || valueID == CSSValueEconomy)
 return true;
 break;
+case CSSPropertyWebkitRegionBreakAfter:
+case CSSPropertyWebkitRegionBreakBefore:
+if (parserContext.isCSSRegionsEnabled  (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID == CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight))
+return true;
+break;
+case CSSPropertyWebkitRegionBreakInside:
+if (parserContext.isCSSRegionsEnabled  (valueID == CSSValueAuto || valueID == CSSValueAvoid))
+return true;
+break;
+case CSSPropertyWebkitRegionOverflow:
+if (parserContext.isCSSRegionsEnabled  (valueID == CSSValueAuto || valueID == CSSValueBreak))
+return true;
+break;
 case CSSPropertyWebkitRtlOrdering:
 if (valueID == CSSValueLogical || valueID == CSSValueVisual)
 return true;
@@ -840,6 +865,9 @@
 case CSSPropertyOutlineStyle:
 case CSSPropertyOverflowX:
 case CSSPropertyOverflowY:
+case CSSPropertyPageBreakAfter:
+case CSSPropertyPageBreakBefore:
+case CSSPropertyPageBreakInside:
 case CSSPropertyPointerEvents:
 case CSSPropertyPosition:
 case CSSPropertyResize:
@@ -868,6 +896,9 @@
 case CSSPropertyWebkitBoxOrient:
 case CSSPropertyWebkitBoxPack:
 case CSSPropertyWebkitColorCorrection:
+case CSSPropertyWebkitColumnBreakAfter:
+case CSSPropertyWebkitColumnBreakBefore:
+case CSSPropertyWebkitColumnBreakInside:
 case CSSPropertyWebkitColumnRuleStyle:
 case CSSPropertyWebkitFlexAlign:
 case CSSPropertyWebkitFlexDirection:
@@ -893,6 +924,10 @@
 case CSSPropertyWebkitOverflowScrolling:
 #endif
 case CSSPropertyWebkitPrintColorAdjust:
+case CSSPropertyWebkitRegionBreakAfter:
+case CSSPropertyWebkitRegionBreakBefore:
+case CSSPropertyWebkitRegionBreakInside:
+case CSSPropertyWebkitRegionOverflow:
 case CSSPropertyWebkitRtlOrdering:
 case CSSPropertyWebkitTextCombine:
   

[webkit-changes] [117332] trunk/LayoutTests

[alexis . menard]

Title: [117332] trunk/LayoutTests








Revision 117332
Author alexis.men...@openbossa.org
Date 2012-05-16 13:31:17 -0700 (Wed, 16 May 2012)


Log Message
[Qt] REGRESSION?(62951): media tests fail
https://bugs.webkit.org/show_bug.cgi?id=42094

Reviewed by Noam Rosenthal.

Enable some media layout tests so that our coverage is more than inexistant.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (117331 => 117332)

--- trunk/LayoutTests/ChangeLog	2012-05-16 20:25:32 UTC (rev 117331)
+++ trunk/LayoutTests/ChangeLog	2012-05-16 20:31:17 UTC (rev 117332)
@@ -1,3 +1,14 @@
+2012-05-16  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] REGRESSION?(62951): media tests fail
+https://bugs.webkit.org/show_bug.cgi?id=42094
+
+Reviewed by Noam Rosenthal.
+
+Enable some media layout tests so that our coverage is more than inexistant.
+
+* platform/qt/Skipped:
+
 2012-05-16  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening, rebaselining after r117310.


Modified: trunk/LayoutTests/platform/qt/Skipped (117331 => 117332)

--- trunk/LayoutTests/platform/qt/Skipped	2012-05-16 20:25:32 UTC (rev 117331)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-05-16 20:31:17 UTC (rev 117332)
@@ -955,9 +955,8 @@
 # failing media tests
 # === #
 
-# [Qt] media tests are flakey
-# https://bugs.webkit.org/show_bug.cgi?id=57983
-media
+# Track is not enable yet
+media/track
 
 # https://bugs.webkit.org/show_bug.cgi?id=38376
 media/media-document-audio-size.html
@@ -1078,6 +1077,24 @@
 # https://bugs.webkit.org/show_bug.cgi?id=57476
 media/video-playbackrate.html
 
+media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html
+media/W3C/video/canPlayType/canPlayType_codecs_order_1.html
+media/W3C/video/canPlayType/canPlayType_codecs_order_3.html
+media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1.html
+media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3.html
+media/W3C/video/canPlayType/canPlayType_two_implies_one_1.html
+media/W3C/video/canPlayType/canPlayType_two_implies_one_2.html
+media/W3C/video/canPlayType/canPlayType_two_implies_one_5.html
+media/W3C/video/canPlayType/canPlayType_two_implies_one_6.html
+media/audio-garbage-collect.html
+media/media-continues-playing-after-replace-source.html
+media/nodesFromRect-shadowContent.html
+media/sources-fallback-codecs.html
+media/video-controls-rendering-toggle-display-none.html
+media/video-controls-toggling.html
+media/video-playing-and-pause.html
+media/video-volume.html
+
 # = #
 # Crashing tests due to re-enabled Phonon support in Buildbot's Qt  #
 # Skip these until a proper solution for the Phonon related crashes found.  #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [117172] trunk/LayoutTests

[alexis . menard]

Title: [117172] trunk/LayoutTests








Revision 117172
Author alexis.men...@openbossa.org
Date 2012-05-15 15:59:31 -0700 (Tue, 15 May 2012)


Log Message
[Qt]3 fast/borders tests assert intermittently
https://bugs.webkit.org/show_bug.cgi?id=67994

Reviewed by Darin Adler.

These tests are now passing even with --iteration 1000.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (117171 => 117172)

--- trunk/LayoutTests/ChangeLog	2012-05-15 22:51:01 UTC (rev 117171)
+++ trunk/LayoutTests/ChangeLog	2012-05-15 22:59:31 UTC (rev 117172)
@@ -1,3 +1,14 @@
+2012-05-15  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt]3 fast/borders tests assert intermittently
+https://bugs.webkit.org/show_bug.cgi?id=67994
+
+Reviewed by Darin Adler.
+
+These tests are now passing even with --iteration 1000.
+
+* platform/qt/Skipped:
+
 2012-05-15  Erik Arvidsson  a...@chromium.org
 
 Result of fast/dom/DOMException/stack-trace.html depends on path (test introduced in r117016)


Modified: trunk/LayoutTests/platform/qt/Skipped (117171 => 117172)

--- trunk/LayoutTests/platform/qt/Skipped	2012-05-15 22:51:01 UTC (rev 117171)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-05-15 22:59:31 UTC (rev 117172)
@@ -2371,11 +2371,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=69719
 fast/text/line-initial-and-final-swashes.html
 
-# [Qt] Assertion fail in CSSPrimitiveValue ctor
-# https://bugs.webkit.org/show_bug.cgi?id=69933
-fast/borders/inline-mask-overlay-image-outset-vertical-rl.html
-fast/borders/inline-mask-overlay-image-outset.html
-
 # fast/events/touch/page-scaled-touch-gesture-click.html is failing
 # Introduced in r97988. Failure: Gesture manager is not implemented.
 # https://bugs.webkit.org/show_bug.cgi?id=70593






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [117208] trunk/LayoutTests

[alexis . menard]

Title: [117208] trunk/LayoutTests








Revision 117208
Author alexis.men...@openbossa.org
Date 2012-05-15 19:55:46 -0700 (Tue, 15 May 2012)


Log Message
Unreviewed gardening for Qt.

These tests were unskipped but their expectations were not up-to-date.

* platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt:
* platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt
trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (117207 => 117208)

--- trunk/LayoutTests/ChangeLog	2012-05-16 02:54:52 UTC (rev 117207)
+++ trunk/LayoutTests/ChangeLog	2012-05-16 02:55:46 UTC (rev 117208)
@@ -1,3 +1,12 @@
+2012-05-15  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed gardening for Qt.
+
+These tests were unskipped but their expectations were not up-to-date.
+
+* platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt:
+* platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt:
+
 2012-05-15  Kihong Kwon  kihong.k...@samsung.com
 
 [EFL] Enable Fullscreen API


Modified: trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt (117207 => 117208)

--- trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt	2012-05-16 02:54:52 UTC (rev 117207)
+++ trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.txt	2012-05-16 02:55:46 UTC (rev 117208)
@@ -4,10 +4,10 @@
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
   RenderText {#text} at (0,0) size 0x0
-layer at (8,8) size 389x125
-  RenderInline {SPAN} at (0,0) size 389x125 [bgcolor=#808080]
-RenderText {#text} at (75,19) size 314x33
-  text run at (75,19) width 314: This content should be masked
-RenderBR {BR} at (389,43) size 0x0
-RenderText {#text} at (0,91) size 166x33
-  text run at (0,91) width 166: with a soft glow.
+layer at (8,8) size 404x122
+  RenderInline {SPAN} at (0,0) size 404x122 [bgcolor=#808080]
+RenderText {#text} at (75,21) size 329x30
+  text run at (75,21) width 329: This content should be masked
+RenderBR {BR} at (404,44) size 0x0
+RenderText {#text} at (0,93) size 170x30
+  text run at (0,93) width 170: with a soft glow.


Modified: trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt (117207 => 117208)

--- trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt	2012-05-16 02:54:52 UTC (rev 117207)
+++ trunk/LayoutTests/platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.txt	2012-05-16 02:55:46 UTC (rev 117208)
@@ -4,10 +4,10 @@
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
   RenderText {#text} at (0,0) size 0x0
-layer at (8,8) size 125x389
-  RenderInline {SPAN} at (0,0) size 125x389 [bgcolor=#808080]
-RenderText {#text} at (19,75) size 33x314
-  text run at (19,75) width 314: This content should be masked
-RenderBR {BR} at (43,389) size 0x0
-RenderText {#text} at (91,0) size 33x166
-  text run at (91,0) width 166: with a soft glow.
+layer at (8,8) size 122x404
+  RenderInline {SPAN} at (0,0) size 122x404 [bgcolor=#808080]
+RenderText {#text} at (21,75) size 30x329
+  text run at (21,75) width 329: This content should be masked
+RenderBR {BR} at (44,404) size 0x0
+RenderText {#text} at (93,0) size 30x170
+  text run at (93,0) width 170: with a soft glow.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116637] trunk/Source/WebCore

[alexis . menard]

Title: [116637] trunk/Source/WebCore








Revision 116637
Author alexis.men...@openbossa.org
Date 2012-05-10 06:19:08 -0700 (Thu, 10 May 2012)


Log Message
[Qt] Avoid string conversions to construct a QUrl when using Qt5.
https://bugs.webkit.org/show_bug.cgi?id=86006

Reviewed by Kenneth Rohde Christiansen.

In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
code path when building with Qt4.

No new tests : it's a performance improvement which should be covered by tests.

* platform/qt/KURLQt.cpp:
(WebCore::KURL::operator QUrl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/KURLQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (116636 => 116637)

--- trunk/Source/WebCore/ChangeLog	2012-05-10 13:15:47 UTC (rev 116636)
+++ trunk/Source/WebCore/ChangeLog	2012-05-10 13:19:08 UTC (rev 116637)
@@ -1,3 +1,19 @@
+2012-05-10  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Avoid string conversions to construct a QUrl when using Qt5.
+https://bugs.webkit.org/show_bug.cgi?id=86006
+
+Reviewed by Kenneth Rohde Christiansen.
+
+In Qt5, the QUrl constructor can handle the string directly, even in UTF-16 because the
+constructor QUrl(QString) has been fixed. Unfortunately we still need to use the old
+code path when building with Qt4.
+
+No new tests : it's a performance improvement which should be covered by tests.
+
+* platform/qt/KURLQt.cpp:
+(WebCore::KURL::operator QUrl):
+
 2012-05-10  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] REGRESSION(r107389) Visible line artifacts on some JPEG images


Modified: trunk/Source/WebCore/platform/qt/KURLQt.cpp (116636 => 116637)

--- trunk/Source/WebCore/platform/qt/KURLQt.cpp	2012-05-10 13:15:47 UTC (rev 116636)
+++ trunk/Source/WebCore/platform/qt/KURLQt.cpp	2012-05-10 13:19:08 UTC (rev 116637)
@@ -34,11 +34,15 @@
 
 KURL::operator QUrl() const
 {
+#if QT_VERSION  QT_VERSION_CHECK(5, 0, 0)
 QString str = QString::fromRawData(reinterpret_castconst QChar*(m_string.characters()), m_string.length());
 QByteArray ba = str.toUtf8();
 
 QUrl url = ""
 return url;
+#else
+return QUrl(m_string);
+#endif
 }
 
 String KURL::fileSystemPath() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116550] trunk/LayoutTests

[alexis . menard]

Title: [116550] trunk/LayoutTests








Revision 116550
Author alexis.men...@openbossa.org
Date 2012-05-09 12:37:24 -0700 (Wed, 09 May 2012)


Log Message
[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
https://bugs.webkit.org/show_bug.cgi?id=83582

Unreviewed gardening : I don't observe crashes anymore.

* platform/qt-5.0-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (116549 => 116550)

--- trunk/LayoutTests/ChangeLog	2012-05-09 19:36:05 UTC (rev 116549)
+++ trunk/LayoutTests/ChangeLog	2012-05-09 19:37:24 UTC (rev 116550)
@@ -1,3 +1,12 @@
+2012-05-09  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
+https://bugs.webkit.org/show_bug.cgi?id=83582
+
+Unreviewed gardening : I don't observe crashes anymore.
+
+* platform/qt-5.0-wk2/Skipped:
+
 2012-05-09  Christophe Dumez  christophe.du...@intel.com
 
 [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (116549 => 116550)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-09 19:36:05 UTC (rev 116549)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-09 19:37:24 UTC (rev 116550)
@@ -587,10 +587,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=83578
 fast/loader/create-frame-in-DOMContentLoaded.html
 
-# [Qt][WK2] REGRESSION(r113678):After this change fast/text/text-stroke-width-cairo-dos.html makes the next test crash
-# https://bugs.webkit.org/show_bug.cgi?id=83582
-fast/text/text-stroke-width-cairo-dos.html
-
 # Missing layoutTestController.numberOfPendingGeolocationPermissionRequests() implementation
 fast/dom/Geolocation/page-reload-cancel-permission-requests.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116417] trunk

[alexis . menard]

Title: [116417] trunk








Revision 116417
Author alexis.men...@openbossa.org
Date 2012-05-08 07:00:31 -0700 (Tue, 08 May 2012)


Log Message
[Qt] Unbreak debugging of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85839

Reviewed by Simon Hausmann.

Source/WebKit2:

When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (7.0) but not with newer
versions where the behavior of pause() is correct.

* qt/MainQt.cpp:
(sigcontHandler):
(main):

Tools:

When you attach GDB to a running process, it stops it.
http://trac.webkit.org/changeset/115958 introduced a pause()
call to wait the debugger to be attached to then continue
the execution of the WebProcess. Unfortunately the pause()
function does not return unless a signal handler is called.
This patch introduce an event handler to exit from the paused
state when the debugger send the signal SIGCONT. The old code
works with older version of GDB (7.0) but not with newer
versions where the behavior of pause() is correct.

* WebKitTestRunner/qt/main.cpp:
(sigcontHandler):
(main):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/qt/MainQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/main.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116416 => 116417)

--- trunk/Source/WebKit2/ChangeLog	2012-05-08 13:57:20 UTC (rev 116416)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-08 14:00:31 UTC (rev 116417)
@@ -1,3 +1,24 @@
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Unbreak debugging of WebKit2.
+https://bugs.webkit.org/show_bug.cgi?id=85839
+
+Reviewed by Simon Hausmann.
+
+When you attach GDB to a running process, it stops it.
+http://trac.webkit.org/changeset/115958 introduced a pause()
+call to wait the debugger to be attached to then continue
+the execution of the WebProcess. Unfortunately the pause()
+function does not return unless a signal handler is called.
+This patch introduce an event handler to exit from the paused
+state when the debugger send the signal SIGCONT. The old code
+works with older version of GDB (7.0) but not with newer
+versions where the behavior of pause() is correct.
+
+* qt/MainQt.cpp:
+(sigcontHandler):
+(main):
+
 2012-05-07  Julien Chaffraix  jchaffr...@webkit.org
 
 Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency


Modified: trunk/Source/WebKit2/qt/MainQt.cpp (116416 => 116417)

--- trunk/Source/WebKit2/qt/MainQt.cpp	2012-05-08 13:57:20 UTC (rev 116416)
+++ trunk/Source/WebKit2/qt/MainQt.cpp	2012-05-08 14:00:31 UTC (rev 116417)
@@ -28,6 +28,7 @@
 
 #include stdio.h
 #if !defined(NDEBUG)  defined(Q_OS_UNIX)
+#include signal.h
 #include unistd.h
 #endif
 
@@ -36,6 +37,12 @@
 Q_DECL_IMPORT void initializeWebKit2Theme();
 }
 
+#if !defined(NDEBUG)  defined(Q_OS_UNIX)
+static void sigcontHandler(int)
+{
+}
+#endif
+
 static void messageHandler(QtMsgType type, const char* message)
 {
 if (type == QtCriticalMsg) {
@@ -53,8 +60,14 @@
 {
 #if !defined(NDEBUG)  defined(Q_OS_UNIX)
 if (qgetenv(QT_WEBKIT_PAUSE_WEB_PROCESS) == 1 || qgetenv(QT_WEBKIT2_DEBUG) == 1) {
-fprintf(stderr, Pausing web process, please attach to PID %d and continue... , getpid());
+struct sigaction newAction, oldAction;
+newAction.sa_handler = sigcontHandler;
+sigemptyset(newAction.sa_mask);
+newAction.sa_flags = 0;
+sigaction(SIGCONT, newAction, oldAction);
+fprintf(stderr, Pausing UI process, please attach to PID %d and send signal SIGCONT... , getpid());
 pause();
+sigaction(SIGCONT, oldAction, 0);
 fprintf(stderr,  OK\n);
 }
 #endif


Modified: trunk/Tools/ChangeLog (116416 => 116417)

--- trunk/Tools/ChangeLog	2012-05-08 13:57:20 UTC (rev 116416)
+++ trunk/Tools/ChangeLog	2012-05-08 14:00:31 UTC (rev 116417)
@@ -1,3 +1,24 @@
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Unbreak debugging of WebKit2.
+https://bugs.webkit.org/show_bug.cgi?id=85839
+
+Reviewed by Simon Hausmann.
+
+When you attach GDB to a running process, it stops it.
+http://trac.webkit.org/changeset/115958 introduced a pause() 
+call to wait the debugger to be attached to then continue 
+the execution of the WebProcess. Unfortunately the pause()
+function does not return unless a signal handler is called.
+This patch introduce an event handler to exit from the paused
+state when the debugger send the signa

[webkit-changes] [116300] trunk/LayoutTests

[alexis . menard]

Title: [116300] trunk/LayoutTests








Revision 116300
Author alexis.men...@openbossa.org
Date 2012-05-07 04:59:44 -0700 (Mon, 07 May 2012)


Log Message
[Qt] Enable fullscreen api layout tests on WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85616

Reviewed by Csaba Osztrogonác.

http://trac.webkit.org/changeset/116089 implements the fullscreen API for WebKit2,
we can now unskip the related tests.

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/qt-4.8/Skipped
trunk/LayoutTests/platform/qt-5.0-wk1/Skipped
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (116299 => 116300)

--- trunk/LayoutTests/ChangeLog	2012-05-07 11:49:00 UTC (rev 116299)
+++ trunk/LayoutTests/ChangeLog	2012-05-07 11:59:44 UTC (rev 116300)
@@ -1,3 +1,18 @@
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Enable fullscreen api layout tests on WebKit2.
+https://bugs.webkit.org/show_bug.cgi?id=85616
+
+Reviewed by Csaba Osztrogonác.
+
+http://trac.webkit.org/changeset/116089 implements the fullscreen API for WebKit2,
+we can now unskip the related tests.
+
+* platform/qt-4.8/Skipped:
+* platform/qt-5.0-wk1/Skipped:
+* platform/qt-5.0-wk2/Skipped:
+* platform/qt/Skipped:
+
 2012-05-07  Dominik Röttsches  dominik.rottsc...@linux.intel.com
 
 [EFL][DRT] Gardening current IMAGE failures


Modified: trunk/LayoutTests/platform/qt/Skipped (116299 => 116300)

--- trunk/LayoutTests/platform/qt/Skipped	2012-05-07 11:49:00 UTC (rev 116299)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-05-07 11:59:44 UTC (rev 116300)
@@ -359,11 +359,6 @@
 fast/hidpi
 svg/as-image/image-respects-deviceScaleFactor.html
 
-# [Qt] QtWebKit needs fullscreen api support
-# https://bugs.webkit.org/show_bug.cgi?id=70132
-fullscreen
-plugins/fullscreen-plugins-dont-reload.html
-
 # Web Intents is not yet enabled.
 webintents/
 


Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (116299 => 116300)

--- trunk/LayoutTests/platform/qt-4.8/Skipped	2012-05-07 11:49:00 UTC (rev 116299)
+++ trunk/LayoutTests/platform/qt-4.8/Skipped	2012-05-07 11:59:44 UTC (rev 116300)
@@ -78,6 +78,10 @@
 fast/events/page-visibility-iframe-propagation-test.html
 fast/events/page-visibility-transition-test.html
 
+# Fullscreen API is not supported with WK1 therefore not supported with Qt 4.8
+fullscreen
+plugins/fullscreen-plugins-dont-reload.html
+
 # Fail until SUBPIXEL_LAYOUT is enabled
 # https://bugs.webkit.org/show_bug.cgi?id=85532
 fast/sub-pixel/client-width-height-snapping.html


Modified: trunk/LayoutTests/platform/qt-5.0-wk1/Skipped (116299 => 116300)

--- trunk/LayoutTests/platform/qt-5.0-wk1/Skipped	2012-05-07 11:49:00 UTC (rev 116299)
+++ trunk/LayoutTests/platform/qt-5.0-wk1/Skipped	2012-05-07 11:59:44 UTC (rev 116300)
@@ -6,6 +6,10 @@
 plugins
 http/tests/plugins
 
+# Fullscreen API is not supported on WK1
+fullscreen
+plugins/fullscreen-plugins-dont-reload.html
+
 # New test introduced in r102048 fails on Qt-WK1
 # https://bugs.webkit.org/show_bug.cgi?id=73366
 fast/events/dont-loose-last-event.html


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (116299 => 116300)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-07 11:49:00 UTC (rev 116299)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-07 11:59:44 UTC (rev 116300)
@@ -536,6 +536,9 @@
 # Generated results doesn't contain any visible 3d transformation.
 transforms/3d/point-mapping
 
+# Offset of the test appears to be different.
+fullscreen/full-screen-placeholder.html
+
 # [Qt][WK2] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes
 # https://bugs.webkit.org/show_bug.cgi?id=80209
 http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116307] trunk/LayoutTests

[alexis . menard]

Title: [116307] trunk/LayoutTests








Revision 116307
Author alexis.men...@openbossa.org
Date 2012-05-07 07:10:34 -0700 (Mon, 07 May 2012)


Log Message
Unreviewed gardening for Qt port. Updating expectation files and skipped tests which are
timing out.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt: Added.
* platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt: Added.
* platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-5.0-wk2/Skipped


Added Paths

trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/
trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt
trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt
trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (116306 => 116307)

--- trunk/LayoutTests/ChangeLog	2012-05-07 14:06:43 UTC (rev 116306)
+++ trunk/LayoutTests/ChangeLog	2012-05-07 14:10:34 UTC (rev 116307)
@@ -1,5 +1,15 @@
 2012-05-07  Alexis Menard  alexis.men...@openbossa.org
 
+Unreviewed gardening for Qt port. Updating expectation files and skipped tests which are
+timing out.
+
+* platform/qt-5.0-wk2/Skipped:
+* platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt: Added.
+* platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt: Added.
+* platform/qt-5.0-wk2/fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
+
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
 [Qt] Enable fullscreen api layout tests on WebKit2.
 https://bugs.webkit.org/show_bug.cgi?id=85616
 


Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (116306 => 116307)

--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-07 14:06:43 UTC (rev 116306)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped	2012-05-07 14:10:34 UTC (rev 116307)
@@ -536,8 +536,9 @@
 # Generated results doesn't contain any visible 3d transformation.
 transforms/3d/point-mapping
 
-# Offset of the test appears to be different.
-fullscreen/full-screen-placeholder.html
+# For some reason they time-out on the bot.
+fullscreen/video-controls-timeline.html
+fullscreen/full-screen-iframe-legacy.html
 
 # [Qt][WK2] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml crashes
 # https://bugs.webkit.org/show_bug.cgi?id=80209


Added: trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt (0 => 116307)

--- trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt	2012-05-07 14:10:34 UTC (rev 116307)
@@ -0,0 +1,17 @@
+This layout test checks that the offset positions of the blue and green divs does not change when the red div enters full-screen mode. Press go full-screen to begin.
+One
+Two
+EVENT(webkitfullscreenchange)
+EXPECTED (document.webkitCurrentFullScreenElement == '[object HTMLDivElement]') OK
+EXPECTED (one.offsetLeft == '68') OK
+EXPECTED (one.offsetTop == '66') OK
+EXPECTED (two.offsetLeft == '8') OK
+EXPECTED (two.offsetTop == '126') OK
+EVENT(webkitfullscreenchange)
+EXPECTED (document.webkitCurrentFullScreenElement == 'null') OK
+EXPECTED (one.offsetLeft == '68') OK
+EXPECTED (one.offsetTop == '66') OK
+EXPECTED (two.offsetLeft == '8') OK
+EXPECTED (two.offsetTop == '126') OK
+END OF TEST
+


Added: trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt (0 => 116307)

--- trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/fullscreen/full-screen-render-inline-expected.txt	2012-05-07 14:10:34 UTC (rev 116307)
@@ -0,0 +1,24 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {SUMMARY} at (0,0) size 784x51
+RenderBlock (anonymous) at (0,0) size 784x0
+RenderBlock (anonymous) at (0,0) size 784x0
+RenderBlock (anonymous) at (0,0) size 784x17
+  RenderText {#text} at (0,0) size 16x17
+text run at (0,0) width 16: a
+  RenderInline {SPAN} at (0,0) size 16x17
+RenderText {#text} at (16,0) size 16x17
+  text run at (16,0) width 16: b
+RenderBlock (anonymous) at (0,17) size 784x17
+  RenderBlock {DIV} at (0,0) size 784x17
+RenderText {#text} at (0,0) size 16x17
+  text run at (0,0) width 16: c
+RenderBlock (anonymous) at (0,34) size 784x17
+  RenderInline {SPAN} at (0,0

[webkit-changes] [116352] trunk

[alexis . menard]

Title: [116352] trunk








Revision 116352
Author alexis.men...@openbossa.org
Date 2012-05-07 13:41:52 -0700 (Mon, 07 May 2012)


Log Message
Unreviewed Qt build fix in Debug.

We need some system includes here for getpid() to be recognized.

Source/WebKit2:

* qt/MainQt.cpp:

Tools:

* WebKitTestRunner/qt/main.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/qt/MainQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/main.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116351 => 116352)

--- trunk/Source/WebKit2/ChangeLog	2012-05-07 20:40:51 UTC (rev 116351)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-07 20:41:52 UTC (rev 116352)
@@ -1,3 +1,11 @@
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed Qt build fix in Debug.
+
+We need some system includes here for getpid() to be recognized.
+
+* qt/MainQt.cpp:
+
 2012-05-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r116299, r116301, and r116303.


Modified: trunk/Source/WebKit2/qt/MainQt.cpp (116351 => 116352)

--- trunk/Source/WebKit2/qt/MainQt.cpp	2012-05-07 20:40:51 UTC (rev 116351)
+++ trunk/Source/WebKit2/qt/MainQt.cpp	2012-05-07 20:41:52 UTC (rev 116352)
@@ -27,6 +27,9 @@
 #include QApplication
 
 #include stdio.h
+#if !defined(NDEBUG)  defined(Q_OS_UNIX)
+#include unistd.h
+#endif
 
 namespace WebKit {
 Q_DECL_IMPORT int WebProcessMainQt(QGuiApplication*);


Modified: trunk/Tools/ChangeLog (116351 => 116352)

--- trunk/Tools/ChangeLog	2012-05-07 20:40:51 UTC (rev 116351)
+++ trunk/Tools/ChangeLog	2012-05-07 20:41:52 UTC (rev 116352)
@@ -1,3 +1,11 @@
+2012-05-07  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed Qt build fix in Debug.
+
+We need some system includes here for getpid() to be recognized.
+
+* WebKitTestRunner/qt/main.cpp:
+
 2012-05-07  Ojan Vafai  o...@chromium.org
 
 When embedding the flakiness dashboard, hide popups when the frame is blurred.


Modified: trunk/Tools/WebKitTestRunner/qt/main.cpp (116351 => 116352)

--- trunk/Tools/WebKitTestRunner/qt/main.cpp	2012-05-07 20:40:51 UTC (rev 116351)
+++ trunk/Tools/WebKitTestRunner/qt/main.cpp	2012-05-07 20:41:52 UTC (rev 116352)
@@ -30,6 +30,9 @@
 #include qquickwebview_p.h
 
 #include stdio.h
+#if !defined(NDEBUG)  defined(Q_OS_UNIX)
+#include unistd.h
+#endif
 
 #include QApplication
 #include QObject






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [116089] trunk

[alexis . menard]

Title: [116089] trunk








Revision 116089
Author alexis.men...@openbossa.org
Date 2012-05-04 06:32:11 -0700 (Fri, 04 May 2012)


Log Message
[Qt] Enable fullscreen API for WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=85498

Reviewed by Simon Hausmann.

Source/WebKit2:

Enable the fullscreen API for Qt port. It is only
supported on WebKit2. It adds experimental settings
to enable it and also add two experimental signals so
the API user can react when the fullscreen is requested
(e.g hide the urlbar of a browser and change the state
of the window to be fullscreen).

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::fullScreenEnabled):
(QWebPreferences::setFullScreenEnabled):
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/API/qt/qwebpreferences_p_p.h:
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

Tools:

Enable the fullscreen API on the MiniBrowser and turn
it default on WebKit2, disable it on WK1.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
* MiniBrowser/qt/qml/BrowserWindow.qml:
* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.prf:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebpreferences_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qwebpreferences_p_p.h
trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h
trunk/Source/WebKit2/UIProcess/qt/WebFullScreenManagerProxyQt.cpp
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/qmake/mkspecs/features/features.prf




Diff

Modified: trunk/Source/WebKit2/ChangeLog (116088 => 116089)

--- trunk/Source/WebKit2/ChangeLog	2012-05-04 13:16:56 UTC (rev 116088)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-04 13:32:11 UTC (rev 116089)
@@ -1,3 +1,33 @@
+2012-05-03  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Enable fullscreen API for WebKit2.
+https://bugs.webkit.org/show_bug.cgi?id=85498
+
+Reviewed by Simon Hausmann.
+
+Enable the fullscreen API for Qt port. It is only
+supported on WebKit2. It adds experimental settings
+to enable it and also add two experimental signals so
+the API user can react when the fullscreen is requested
+(e.g hide the urlbar of a browser and change the state
+of the window to be fullscreen).
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::initialize):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qwebpreferences.cpp:
+(QWebPreferencesPrivate::testAttribute):
+(QWebPreferencesPrivate::setAttribute):
+(QWebPreferences::fullScreenEnabled):
+(QWebPreferences::setFullScreenEnabled):
+* UIProcess/API/qt/qwebpreferences_p.h:
+* UIProcess/API/qt/qwebpreferences_p_p.h:
+* UIProcess/WebFullScreenManagerProxy.h:
+(WebKit):
+* UIProcess/qt/WebFullScreenManagerProxyQt.cpp:
+(WebKit::WebFullScreenManagerProxy::enterFullScreen):
+(WebKit::WebFullScreenManagerProxy::exitFullScreen):
+
 2012-05-04  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Images are scaled badly in WebKit2


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (116088 => 116089)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-05-04 13:16:56 UTC (rev 116088)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-05-04 13:32:11 UTC (rev 116089)
@@ -33,6 +33,9 @@
 #include QtWebPagePolicyClient.h
 #include UtilsQt.h
 #include WebBackForwardList.h
+#if ENABLE(FULLSCREEN_API)
+#include WebFullScreenManagerProxy.h
+#endif
 #include WebPageGroup.h
 #include WebPreferences.h
 
@@ -183,6 +186,9 @@
 
 context = contextRef ? QtWebContext::create(toImpl(contextRef)) : QtWebContext::defaultContext();
 webPageProxy = context-createWebPage(pageClient, pageGroup.get());
+#if ENABLE(FULLSCREEN_API)
+webPageProxy-fullScreenManager()-setWebView(q_ptr);
+#endif
 
 QQuickWebPagePrivate* const pageViewPrivate = pageView.data()-d;
 pageViewPrivate-initialize(webPageProxy.get());


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (116088 => 116089)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2012-05-04 13:16:56 UTC (rev 116088)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2012-05-04 13:32:11 UTC (rev 116089)

[webkit-changes] [116091] trunk/Source/WebCore

[alexis . menard]

Title: [116091] trunk/Source/WebCore








Revision 116091
Author alexis.men...@openbossa.org
Date 2012-05-04 06:50:21 -0700 (Fri, 04 May 2012)


Log Message
[Qt] Build fix when using libpng version  1.2.
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Tor Arne Vestbø.

Don't enforce the version of libpng when passing the option to the linker.

No new tests : build fix.

* WebCore.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (116090 => 116091)

--- trunk/Source/WebCore/ChangeLog	2012-05-04 13:36:17 UTC (rev 116090)
+++ trunk/Source/WebCore/ChangeLog	2012-05-04 13:50:21 UTC (rev 116091)
@@ -1,3 +1,16 @@
+2012-05-04  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Build fix when using libpng version  1.2.
+https://bugs.webkit.org/show_bug.cgi?id=85614
+
+Reviewed by Tor Arne Vestbø.
+
+Don't enforce the version of libpng when passing the option to the linker.
+
+No new tests : build fix.
+
+* WebCore.pri:
+
 2012-05-04  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Images are scaled badly in WebKit2


Modified: trunk/Source/WebCore/WebCore.pri (116090 => 116091)

--- trunk/Source/WebCore/WebCore.pri	2012-05-04 13:36:17 UTC (rev 116090)
+++ trunk/Source/WebCore/WebCore.pri	2012-05-04 13:50:21 UTC (rev 116091)
@@ -238,7 +238,7 @@
 !contains(config_test_libpng, yes): error(PNG 1.2 library not found!)
 }
 
-LIBS += -ljpeg -lpng12
+LIBS += -ljpeg -lpng
 
 win32-*|wince* {
 DLLDESTDIR = $${ROOT_BUILD_DIR}/bin






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115857] trunk/Source/WebCore

[alexis . menard]

Title: [115857] trunk/Source/WebCore








Revision 115857
Author alexis.men...@openbossa.org
Date 2012-05-02 11:52:49 -0700 (Wed, 02 May 2012)


Log Message
Unreviewed Qt build fix with GCC 4.7.0.

* platform/qt/DeviceMotionProviderQt.h:
(DeviceMotionProviderQt):
* platform/qt/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore):
* platform/qt/DeviceOrientationProviderQt.h:
(DeviceOrientationProviderQt):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/DeviceMotionProviderQt.h
trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp
trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115856 => 115857)

--- trunk/Source/WebCore/ChangeLog	2012-05-02 18:50:23 UTC (rev 115856)
+++ trunk/Source/WebCore/ChangeLog	2012-05-02 18:52:49 UTC (rev 115857)
@@ -1,3 +1,15 @@
+2012-05-02  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed Qt build fix with GCC 4.7.0.
+
+* platform/qt/DeviceMotionProviderQt.h:
+(DeviceMotionProviderQt):
+* platform/qt/DeviceOrientationProviderQt.cpp:
+(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
+(WebCore):
+* platform/qt/DeviceOrientationProviderQt.h:
+(DeviceOrientationProviderQt):
+
 2012-05-02  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Texmap] Enable css filters in TextureMapperGL


Modified: trunk/Source/WebCore/platform/qt/DeviceMotionProviderQt.h (115856 => 115857)

--- trunk/Source/WebCore/platform/qt/DeviceMotionProviderQt.h	2012-05-02 18:50:23 UTC (rev 115856)
+++ trunk/Source/WebCore/platform/qt/DeviceMotionProviderQt.h	2012-05-02 18:52:49 UTC (rev 115857)
@@ -39,7 +39,7 @@
 class DeviceMotionProviderQt : public QAccelerometerFilter {
 public:
 DeviceMotionProviderQt();
-~DeviceMotionProviderQt();
+virtual ~DeviceMotionProviderQt();
 
 void setController(DeviceMotionController*);
 


Modified: trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp (115856 => 115857)

--- trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp	2012-05-02 18:50:23 UTC (rev 115856)
+++ trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.cpp	2012-05-02 18:52:49 UTC (rev 115857)
@@ -29,6 +29,11 @@
 m_lastOrientation = DeviceOrientation::create();
 }
 
+DeviceOrientationProviderQt::~DeviceOrientationProviderQt()
+{
+
+}
+
 void DeviceOrientationProviderQt::setController(DeviceOrientationController* controller)
 {
 if (!controller)


Modified: trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.h (115856 => 115857)

--- trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.h	2012-05-02 18:50:23 UTC (rev 115856)
+++ trunk/Source/WebCore/platform/qt/DeviceOrientationProviderQt.h	2012-05-02 18:52:49 UTC (rev 115857)
@@ -36,6 +36,7 @@
 class DeviceOrientationProviderQt : public QRotationFilter {
 public:
 DeviceOrientationProviderQt();
+virtual ~DeviceOrientationProviderQt();
 
 void setController(DeviceOrientationController*);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115648] trunk/Tools

[alexis . menard]

Title: [115648] trunk/Tools








Revision 115648
Author alexis.men...@openbossa.org
Date 2012-04-30 10:13:23 -0700 (Mon, 30 Apr 2012)


Log Message
Move myself to reviewers.

Reviewed by Andreas Kling.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (115647 => 115648)

--- trunk/Tools/ChangeLog	2012-04-30 17:03:41 UTC (rev 115647)
+++ trunk/Tools/ChangeLog	2012-04-30 17:13:23 UTC (rev 115648)
@@ -1,3 +1,11 @@
+2012-04-30  Alexis Menard  alexis.men...@openbossa.org
+
+Move myself to reviewers.
+
+Reviewed by Andreas Kling.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-04-30  Jocelyn Turcotte  jocelyn.turco...@nokia.com
 
 Unreviewed, move myself to reviewers


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (115647 => 115648)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-04-30 17:03:41 UTC (rev 115647)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-04-30 17:13:23 UTC (rev 115648)
@@ -179,7 +179,6 @@
 Committer(Alexander Kellett, [lypa...@mac.com, a-lists...@lypanov.net, lypa...@kde.org], lypanov),
 Committer(Alexander Pavlov, apav...@chromium.org, apavlov),
 Committer(Alexandru Chiculita, ach...@adobe.com, achicu),
-Committer(Alexis Menard, [alexis.men...@openbossa.org, men...@kde.org, alexis.men...@nokia.com], darktears),
 Committer(Alice Boxhall, aboxh...@chromium.org, aboxhall),
 Committer(Alok Priyadarshi, al...@chromium.org, alokp),
 Committer(Ami Fischman, [fisch...@chromium.org, fisch...@google.com], fischman),
@@ -399,6 +398,7 @@
 Reviewer(Adrienne Walker, [e...@google.com, e...@chromium.org], enne),
 Reviewer(Alejandro G. Castro, [a...@igalia.com, a...@webkit.org], alexg__),
 Reviewer(Alexey Proskuryakov, [a...@webkit.org, a...@apple.com], ap),
+Reviewer(Alexis Menard, [alexis.men...@openbossa.org, men...@kde.org], darktears),
 Reviewer(Alice Liu, alice@apple.com, aliu),
 Reviewer(Alp Toker, [a...@nuanti.com, a...@atoker.com, a...@webkit.org], alp),
 Reviewer(Anders Carlsson, [ander...@apple.com, acarls...@apple.com], andersca),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115221] trunk/Source/WebCore

[alexis . menard]

Title: [115221] trunk/Source/WebCore








Revision 115221
Author alexis.men...@openbossa.org
Date 2012-04-25 09:46:59 -0700 (Wed, 25 Apr 2012)


Log Message
Not reviewed, fix Windows build after r115215.

* css/CSSAllInOne.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSAllInOne.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (115220 => 115221)

--- trunk/Source/WebCore/ChangeLog	2012-04-25 16:28:02 UTC (rev 115220)
+++ trunk/Source/WebCore/ChangeLog	2012-04-25 16:46:59 UTC (rev 115221)
@@ -1,3 +1,9 @@
+2012-04-25  Alexis Menard  alexis.men...@openbossa.org
+
+Not reviewed, fix Windows build after r115215.
+
+* css/CSSAllInOne.cpp:
+
 2012-04-25  Eric Carlson  eric.carl...@apple.com
 
 Not reviewed, attempt to fix Windows build after r115215.


Modified: trunk/Source/WebCore/css/CSSAllInOne.cpp (115220 => 115221)

--- trunk/Source/WebCore/css/CSSAllInOne.cpp	2012-04-25 16:28:02 UTC (rev 115220)
+++ trunk/Source/WebCore/css/CSSAllInOne.cpp	2012-04-25 16:46:59 UTC (rev 115221)
@@ -56,6 +56,7 @@
 #include CSSRule.cpp
 #include CSSRuleList.cpp
 #include CSSSegmentedFontFace.cpp
+#include CSSSelector.cpp
 #include CSSSelectorList.cpp
 #include CSSStyleDeclaration.cpp
 #include CSSStyleRule.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115043] trunk/Source/WebCore

[alexis . menard]

Title: [115043] trunk/Source/WebCore








Revision 115043
Author alexis.men...@openbossa.org
Date 2012-04-24 06:28:06 -0700 (Tue, 24 Apr 2012)


Log Message
Rename CSSStyleApplyProperty class to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84711

Reviewed by Antti Koivisto.

As per discussion on bug https://bugs.webkit.org/show_bug.cgi?id=42764
the name is a bit confusing. This first patch rename the class and a
following one will rename the files. We also drop the CSS prefix of the
class to keep CSS prefixed classes for CSSOM types.

No new tests : renaming, no behavior changes should appear.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):
* css/CSSStyleApplyProperty.h:
(WebCore):
(StyleBuilder):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleApplyProperty.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115042 => 115043)

--- trunk/Source/WebCore/ChangeLog	2012-04-24 13:21:03 UTC (rev 115042)
+++ trunk/Source/WebCore/ChangeLog	2012-04-24 13:28:06 UTC (rev 115043)
@@ -1,3 +1,32 @@
+2012-04-24  Alexis Menard  alexis.men...@openbossa.org
+
+Rename CSSStyleApplyProperty class to StyleBuilder.
+https://bugs.webkit.org/show_bug.cgi?id=84711
+
+Reviewed by Antti Koivisto.
+
+As per discussion on bug https://bugs.webkit.org/show_bug.cgi?id=42764
+the name is a bit confusing. This first patch rename the class and a
+following one will rename the files. We also drop the CSS prefix of the
+class to keep CSS prefixed classes for CSSOM types.
+
+No new tests : renaming, no behavior changes should appear.
+
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::ApplyPropertyExpanding::applyInheritValue):
+(WebCore::ApplyPropertyExpanding::applyInitialValue):
+(WebCore::ApplyPropertyExpanding::applyValue):
+(WebCore::StyleBuilder::sharedStyleBuilder):
+(WebCore::StyleBuilder::StyleBuilder):
+* css/CSSStyleApplyProperty.h:
+(WebCore):
+(StyleBuilder):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::CSSStyleSelector):
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
 2012-04-24  Kent Tamura  tk...@chromium.org
 
 Merge LocalizedCalendar into LocalizedDate


Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (115042 => 115043)

--- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp	2012-04-24 13:21:03 UTC (rev 115042)
+++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp	2012-04-24 13:28:06 UTC (rev 115043)
@@ -58,7 +58,7 @@
 if (id == CSSPropertyInvalid)
 return;
 
-const CSSStyleApplyProperty table = CSSStyleApplyProperty::sharedCSSStyleApplyProperty();
+const StyleBuilder table = StyleBuilder::sharedStyleBuilder();
 const PropertyHandler handler = table.propertyHandler(id);
 if (handler.isValid())
 handler.applyInheritValue(selector);
@@ -79,7 +79,7 @@
 if (id == CSSPropertyInvalid)
 return;
 
-const CSSStyleApplyProperty table = CSSStyleApplyProperty::sharedCSSStyleApplyProperty();
+const StyleBuilder table = StyleBuilder::sharedStyleBuilder();
 const PropertyHandler handler = table.propertyHandler(id);
 if (handler.isValid())
 handler.applyInitialValue(selector);
@@ -100,7 +100,7 @@
 if (id == CSSPropertyInvalid)
 return;
 
-const CSSStyleApplyProperty table = CSSStyleApplyProperty::sharedCSSStyleApplyProperty();
+const StyleBuilder table = StyleBuilder::sharedStyleBuilder();
 const PropertyHandler handler = table.propertyHandler(id);
 if (handler.isValid())
 handler.applyValue(selector, value);
@@ -1764,13 +1764,13 @@
 
 };
 
-const CSSStyleApplyProperty CSSStyleApplyProperty::sharedCSSStyleApplyProperty()
+const StyleBuilder StyleBuilder::sharedStyleBuilder()
 {
-DEFINE_STATIC_LOCAL(CSSStyleApplyProperty, cssStyleApplyPropertyInstance, ());
-return cssStyleApplyPropertyInstance;
+DEFINE_STATIC_LOCAL(StyleBuilder, styleBuilderInstance, ());
+return styleBuilderInstance;
 }
 
-CSSStyleApplyProperty::CSSStyleApplyProperty()
+StyleBuilder::StyleBuilder()
 {
 for (int i = 0; i  numCSSProperties; ++i)
 m_propertyMap[i] = PropertyHandler();


Modified: trunk/

[webkit-changes] [115045] trunk/Source/WebCore

[alexis . menard]

Title: [115045] trunk/Source/WebCore








Revision 115045
Author alexis.men...@openbossa.org
Date 2012-04-24 06:44:08 -0700 (Tue, 24 Apr 2012)


Log Message
Unreviewed build fix attempt for Mac.

* rendering/style/RenderStyle.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115044 => 115045)

--- trunk/Source/WebCore/ChangeLog	2012-04-24 13:28:10 UTC (rev 115044)
+++ trunk/Source/WebCore/ChangeLog	2012-04-24 13:44:08 UTC (rev 115045)
@@ -1,5 +1,11 @@
 2012-04-24  Alexis Menard  alexis.men...@openbossa.org
 
+Unreviewed build fix attempt for Mac.
+
+* rendering/style/RenderStyle.h:
+
+2012-04-24  Alexis Menard  alexis.men...@openbossa.org
+
 Rename CSSStyleApplyProperty class to StyleBuilder.
 https://bugs.webkit.org/show_bug.cgi?id=84711
 


Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (115044 => 115045)

--- trunk/Source/WebCore/rendering/style/RenderStyle.h	2012-04-24 13:28:10 UTC (rev 115044)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h	2012-04-24 13:44:08 UTC (rev 115045)
@@ -122,12 +122,12 @@
 friend class AnimationBase; // Used by CSS animations. We can't allow them to animate based off visited colors.
 friend class ApplyStyleCommand; // Editing has to only reveal unvisited info.
 friend class EditingStyle; // Editing has to only reveal unvisited info.
-friend class CSSStyleApplyProperty; // Sets members directly.
 friend class CSSStyleSelector; // Sets members directly.
 friend class CSSComputedStyleDeclaration; // Ignores visited styles, so needs to be able to see unvisited info.
 friend class PropertyWrapperMaybeInvalidColor; // Used by CSS animations. We can't allow them to animate based off visited colors.
 friend class RenderSVGResource; // FIXME: Needs to alter the visited state by hand. Should clean the SVG code up and move it into RenderStyle perhaps.
 friend class RenderTreeAsText; // FIXME: Only needed so the render tree can keep lying and dump the wrong colors.  Rebaselining would allow this to be yanked.
+friend class StyleBuilder; // Sets members directly.
 protected:
 
 class RenderStyleBitfields {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115047] trunk/Source/WebCore

[alexis . menard]

Title: [115047] trunk/Source/WebCore








Revision 115047
Author alexis.men...@openbossa.org
Date 2012-04-24 06:50:57 -0700 (Tue, 24 Apr 2012)


Log Message
Another unreviewed build fix for Mac.

* css/CSSStyleSelector.h:
(CSSStyleSelector):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (115046 => 115047)

--- trunk/Source/WebCore/ChangeLog	2012-04-24 13:48:27 UTC (rev 115046)
+++ trunk/Source/WebCore/ChangeLog	2012-04-24 13:50:57 UTC (rev 115047)
@@ -1,5 +1,12 @@
 2012-04-24  Alexis Menard  alexis.men...@openbossa.org
 
+Another unreviewed build fix for Mac.
+
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+
+2012-04-24  Alexis Menard  alexis.men...@openbossa.org
+
 Unreviewed build fix attempt for Mac.
 
 * rendering/style/RenderStyle.h:


Modified: trunk/Source/WebCore/css/CSSStyleSelector.h (115046 => 115047)

--- trunk/Source/WebCore/css/CSSStyleSelector.h	2012-04-24 13:48:27 UTC (rev 115046)
+++ trunk/Source/WebCore/css/CSSStyleSelector.h	2012-04-24 13:50:57 UTC (rev 115047)
@@ -529,7 +529,7 @@
 const ContainerNode* m_scopeStackParent;
 #endif
 
-friend class CSSStyleApplyProperty;
+friend class StyleBuilder;
 friend bool operator==(const MatchedProperties, const MatchedProperties);
 friend bool operator!=(const MatchedProperties, const MatchedProperties);
 friend bool operator==(const MatchRanges, const MatchRanges);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115160] trunk

[alexis . menard]

Title: [115160] trunk








Revision 115160
Author alexis.men...@openbossa.org
Date 2012-04-24 19:11:26 -0700 (Tue, 24 Apr 2012)


Log Message
Implement createTBody for table element.
https://bugs.webkit.org/show_bug.cgi?id=84465

Reviewed by Ojan Vafai.

Source/WebCore:

Implement createTBody of table element to allow creating tbodies from JS.
It's following the specification http://dev.w3.org/html5/spec/the-table-element.html#dom-table-createtbody.

Tests: fast/table/table-create-tbody-existing-tbody.html
   fast/table/table-create-tbody-multiple-tbody.html
   fast/table/table-create-tbody.html

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTBody):
(WebCore):
* html/HTMLTableElement.h:
(HTMLTableElement):
* html/HTMLTableElement.idl:

LayoutTests:

Add test to cover the new createTBody method.

* fast/table/table-create-tbody-existing-tbody-expected.txt: Added.
* fast/table/table-create-tbody-existing-tbody.html: Added.
* fast/table/table-create-tbody-expected.txt: Added.
* fast/table/table-create-tbody-multiple-tbody-expected.txt: Added.
* fast/table/table-create-tbody-multiple-tbody.html: Added.
* fast/table/table-create-tbody.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTableElement.cpp
trunk/Source/WebCore/html/HTMLTableElement.h
trunk/Source/WebCore/html/HTMLTableElement.idl


Added Paths

trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody-expected.txt
trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody.html
trunk/LayoutTests/fast/table/table-create-tbody-expected.txt
trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody-expected.txt
trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody.html
trunk/LayoutTests/fast/table/table-create-tbody.html




Diff

Modified: trunk/LayoutTests/ChangeLog (115159 => 115160)

--- trunk/LayoutTests/ChangeLog	2012-04-25 02:07:58 UTC (rev 115159)
+++ trunk/LayoutTests/ChangeLog	2012-04-25 02:11:26 UTC (rev 115160)
@@ -1,3 +1,19 @@
+2012-04-24  Alexis Menard  alexis.men...@openbossa.org
+
+Implement createTBody for table element.
+https://bugs.webkit.org/show_bug.cgi?id=84465
+
+Reviewed by Ojan Vafai.
+
+Add test to cover the new createTBody method.
+
+* fast/table/table-create-tbody-existing-tbody-expected.txt: Added.
+* fast/table/table-create-tbody-existing-tbody.html: Added.
+* fast/table/table-create-tbody-expected.txt: Added.
+* fast/table/table-create-tbody-multiple-tbody-expected.txt: Added.
+* fast/table/table-create-tbody-multiple-tbody.html: Added.
+* fast/table/table-create-tbody.html: Added.
+
 2012-04-24  Yong Li  y...@rim.com
 
 ASSERT failure in RenderLayer::computeRepaintRects


Added: trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody-expected.txt (0 => 115160)

--- trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody-expected.txt	2012-04-25 02:11:26 UTC (rev 115160)
@@ -0,0 +1,19 @@
+| 
+  
+| thead
+|   
+  
+| 
+  
+| tfoot
+|   
+  
+| 
+  
+| tbody
+|   title=existing tbody
+|   
+  
+| tbody
+| 
+


Added: trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody.html (0 => 115160)

--- trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody.html	(rev 0)
+++ trunk/LayoutTests/fast/table/table-create-tbody-existing-tbody.html	2012-04-25 02:11:26 UTC (rev 115160)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+script src=""
+phttps://bugs.webkit.org/show_bug.cgi?id=84465 : Implement createTBody for table element./p
+pThis test verify that createTBody() appends a new tbody tag after the existing one./p
+table
+  thead
+  /thead
+  tfoot
+  /tfoot
+  tbody title=existing tbody
+  /tbody
+/table
+script
+var table = document.getElementsByTagName(table)[0];
+table.createTBody();
+Markup.dump(table);
+/script


Added: trunk/LayoutTests/fast/table/table-create-tbody-expected.txt (0 => 115160)

--- trunk/LayoutTests/fast/table/table-create-tbody-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/table-create-tbody-expected.txt	2012-04-25 02:11:26 UTC (rev 115160)
@@ -0,0 +1,13 @@
+| 
+  
+| thead
+|   
+  
+| 
+  
+| tfoot
+|   
+  
+| 
+
+| tbody


Added: trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody-expected.txt (0 => 115160)

--- trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody-expected.txt	2012-04-25 02:11:26 UTC (rev 115160)
@@ -0,0 +1,25 @@
+| 
+  
+| thead
+|   
+  
+| 
+  
+| tfoot
+|   
+  
+| 
+  
+| tbody
+|   title=tbody1
+|   
+  
+| 
+  
+| tbody
+|   title=tbody2
+|   
+  
+| tbody
+| 
+


Added: trunk/LayoutTests/fast/table/table-create-tbody-multiple-tbody.html

[webkit-changes] [114895] trunk

[alexis . menard]

Title: [114895] trunk








Revision 114895
Author alexis.men...@openbossa.org
Date 2012-04-23 07:26:55 -0700 (Mon, 23 Apr 2012)


Log Message
Simplify CSSParser::parseFont.
https://bugs.webkit.org/show_bug.cgi?id=78698

Reviewed by Antti Koivisto.

Source/WebCore:

Simplify parseFont by sharing the code we have for
the longhands of the font property.

No new tests : Extend the existing font shorthand test and modify expected files
as now the order of the longhands added in the property list of the style
has changed. It's very unlikely that some code is relying on this order though. It will
also match the way the spec order them http://www.w3.org/TR/css3-fonts/#font-prop
even though the order is arbitrary for some values.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseLineHeight):
(WebCore):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::parseFontWeight):  Fix a bug discovered while using parseFontWeight from
the parseFont (case font: 0/0, Arial, sans-serif; in a layout test), we should return true only
when we add something in the property list.
* css/CSSParser.h:

LayoutTests:

Added new incorrect values to improve the test coverage of the font shorthand property.

The patch changed the order the longhands are added to the list
of properties for the style so the expected files need to be updated.

* fast/css/font-shorthand-expected.txt:
* fast/css/font-shorthand.html:
* fast/inspector-support/style-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/font-shorthand-expected.txt
trunk/LayoutTests/fast/css/font-shorthand.html
trunk/LayoutTests/fast/inspector-support/style-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h




Diff

Modified: trunk/LayoutTests/ChangeLog (114894 => 114895)

--- trunk/LayoutTests/ChangeLog	2012-04-23 13:48:57 UTC (rev 114894)
+++ trunk/LayoutTests/ChangeLog	2012-04-23 14:26:55 UTC (rev 114895)
@@ -1,3 +1,19 @@
+2012-04-23  Alexis Menard  alexis.men...@openbossa.org
+
+Simplify CSSParser::parseFont.
+https://bugs.webkit.org/show_bug.cgi?id=78698
+
+Reviewed by Antti Koivisto.
+
+Added new incorrect values to improve the test coverage of the font shorthand property.
+
+The patch changed the order the longhands are added to the list
+of properties for the style so the expected files need to be updated.
+
+* fast/css/font-shorthand-expected.txt:
+* fast/css/font-shorthand.html:
+* fast/inspector-support/style-expected.txt:
+
 2012-04-23  Mikhail Naganov  mnaga...@chromium.org
 
 [Chromium] Unreviewed test expectations update.


Modified: trunk/LayoutTests/fast/css/font-shorthand-expected.txt (114894 => 114895)

--- trunk/LayoutTests/fast/css/font-shorthand-expected.txt	2012-04-23 13:48:57 UTC (rev 114894)
+++ trunk/LayoutTests/fast/css/font-shorthand-expected.txt	2012-04-23 14:26:55 UTC (rev 114895)
@@ -1,75 +1,75 @@
 Test
 Font for '12px monospace':
-font-family: monospace (original property was font)
-font-size: 12px (original property was font)
 font-style: normal (original property was font and property was implicitly set.)
 font-variant: normal (original property was font and property was implicitly set.)
 font-weight: normal (original property was font and property was implicitly set.)
+font-size: 12px (original property was font)
 line-height: normal (original property was font and property was implicitly set.)
+font-family: monospace (original property was font)
 
 Font for '12px/24px serif':
-font-family: serif (original property was font)
-font-size: 12px (original property was font)
 font-style: normal (original property was font and property was implicitly set.)
 font-variant: normal (original property was font and property was implicitly set.)
 font-weight: normal (original property was font and property was implicitly set.)
+font-size: 12px (original property was font)
 line-height: 24px (original property was font)
+font-family: serif (original property was font)
 
 Font for 'normal 12px serif':
-font-family: serif (original property was font)
-font-size: 12px (original property was font)
 font-style: normal (original property was font)
 font-variant: normal (original property was font and property was implicitly set.)
 font-weight: normal (original property was font and property was implicitly set.)
+font-size: 12px (original property was font)
 line-height: normal (original property was font and property was implicitly set.)
+font-family: serif (original property was font)
 
 Font for 'normal normal 12px serif':
-font-family: serif (original property was font)
-font-size: 12px (original property was font)
 font-style: normal (original property was font)
 font-variant: normal (original property was font)
 font-weight: normal (original property was font and property was implicitly set.)
+font-size

[webkit-changes] [114689] trunk/Source/WebCore

[alexis . menard]

Title: [114689] trunk/Source/WebCore








Revision 114689
Author alexis.men...@openbossa.org
Date 2012-04-19 16:27:28 -0700 (Thu, 19 Apr 2012)


Log Message
Unreviewed Qt build warning fix.

The file editing/StringHelper.h does not exist.

* Target.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (114688 => 114689)

--- trunk/Source/WebCore/ChangeLog	2012-04-19 23:01:48 UTC (rev 114688)
+++ trunk/Source/WebCore/ChangeLog	2012-04-19 23:27:28 UTC (rev 114689)
@@ -1,3 +1,11 @@
+2012-04-19  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed Qt build warning fix.
+
+The file editing/StringHelper.h does not exist.
+
+* Target.pri:
+
 2012-04-19  Daniel Bates  dba...@webkit.org
 
 Remove empty directory Source/WebCore/webaudio


Modified: trunk/Source/WebCore/Target.pri (114688 => 114689)

--- trunk/Source/WebCore/Target.pri	2012-04-19 23:01:48 UTC (rev 114688)
+++ trunk/Source/WebCore/Target.pri	2012-04-19 23:27:28 UTC (rev 114689)
@@ -1821,7 +1821,6 @@
 editing/SplitElementCommand.h \
 editing/SplitTextNodeCommand.h \
 editing/SplitTextNodeContainingElementCommand.h \
-editing/StringHelper.h \
 editing/TextInsertionBaseCommand.h \
 editing/TextIterator.h \
 editing/TypingCommand.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [113577] trunk/Source/WebCore

[alexis . menard]

Title: [113577] trunk/Source/WebCore








Revision 113577
Author alexis.men...@openbossa.org
Date 2012-04-09 06:43:25 -0700 (Mon, 09 Apr 2012)


Log Message
[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83466

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.

No new tests : There should be no behavior change in this patch.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::removePropertiesInSet):
* page/animation/AnimationBase.cpp:
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):
* page/animation/AnimationBase.h:
(AnimationBase):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseTransitionAtTime):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::insert):
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::addProperty):
(WebCore::KeyframeValue::containsProperty):
(WebCore::KeyframeValue::properties):
(KeyframeValue):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(KeyframeList):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
trunk/Source/WebCore/css/StylePropertySet.cpp
trunk/Source/WebCore/page/animation/AnimationBase.cpp
trunk/Source/WebCore/page/animation/AnimationBase.h
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.cpp
trunk/Source/WebCore/rendering/style/KeyframeList.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (113576 => 113577)

--- trunk/Source/WebCore/ChangeLog	2012-04-09 13:34:54 UTC (rev 113576)
+++ trunk/Source/WebCore/ChangeLog	2012-04-09 13:43:25 UTC (rev 113577)
@@ -1,3 +1,47 @@
+2012-04-09  Alexis Menard  alexis.men...@openbossa.org
+
+[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
+https://bugs.webkit.org/show_bug.cgi?id=83466
+
+Reviewed by Kentaro Hara.
+
+CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
+as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.
+
+No new tests : There should be no behavior change in this patch.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* css/CSSStyleSelector.h:
+(CSSStyleSelector):
+* css/StylePropertySet.cpp:
+(WebCore::StylePropertySet::removePropertiesInSet):
+* page/animation/AnimationBase.cpp:
+(WebCore::gatherEnclosingShorthandProperties):
+(WebCore::AnimationBase::animatableShorthandsAffectingProperty):
+* page/animation/AnimationBase.h:
+(AnimationBase):
+* page/animation/CompositeAnimation.cpp:
+(WebCore::CompositeAnimation::pauseTransitionAtTime):
+* page/animation/KeyframeAnimation.cpp:
+(WebCore::KeyframeAnimation::animate):
+(WebCore::KeyframeAnimation::getAnimatedStyle):
+(WebCore::KeyframeAnimation::overrideAnimations):
+(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
+(WebCore::KeyframeAnimation::timeToNextService):
+* rendering/style/KeyframeList.cpp:
+(WebCore::KeyframeList::insert):
+* rendering/style/KeyframeList.h:
+(WebCore::KeyframeValue::addProperty):
+(WebCore::KeyframeValue::containsProperty):
+(WebCore::KeyframeValue::properties):
+(KeyframeValue):
+(WebCore::KeyframeList::addProperty):
+(WebCore::KeyframeList::containsProperty):
+(WebCore::KeyframeList::beginProperties):
+(WebCore::KeyframeList::endProperties):
+(KeyframeList):
+
 2012-04-09  Kentaro Hara  hara...@chromium.org
 
 Unreviewed, rebaselined run-bindings-tests results.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (113576 => 113577)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-04-09 13:34:54 UTC (rev 113576)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-04-09 13:43:25 UTC (rev 113577)
@@ -5750,9 +

[webkit-changes] [113586] trunk/Source/WebCore

[alexis . menard]

Title: [113586] trunk/Source/WebCore








Revision 113586
Author alexis.men...@openbossa.org
Date 2012-04-09 09:37:33 -0700 (Mon, 09 Apr 2012)


Log Message
Unreviewed, adding a missing header for the Qt port.

* Target.pri:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (113585 => 113586)

--- trunk/Source/WebCore/ChangeLog	2012-04-09 16:35:58 UTC (rev 113585)
+++ trunk/Source/WebCore/ChangeLog	2012-04-09 16:37:33 UTC (rev 113586)
@@ -1,3 +1,9 @@
+2012-04-09  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed, adding a missing header for the Qt port.
+
+* Target.pri:
+
 2012-04-09  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: [network panel] type column shows undefined instead of (Pending) upon load.


Modified: trunk/Source/WebCore/Target.pri (113585 => 113586)

--- trunk/Source/WebCore/Target.pri	2012-04-09 16:35:58 UTC (rev 113585)
+++ trunk/Source/WebCore/Target.pri	2012-04-09 16:37:33 UTC (rev 113586)
@@ -2258,6 +2258,7 @@
 platform/KillRing.h \
 platform/KURL.h \
 platform/Length.h \
+platform/LengthBox.h \
 platform/leveldb/LevelDBComparator.h \
 platform/leveldb/LevelDBDatabase.h \
 platform/leveldb/LevelDBIterator.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [113187] trunk/Source/WebCore

[alexis . menard]

Title: [113187] trunk/Source/WebCore








Revision 113187
Author alexis.men...@openbossa.org
Date 2012-04-04 07:26:38 -0700 (Wed, 04 Apr 2012)


Log Message
Re-add variable names in CSS related headers to help understanding the meaning of them.
https://bugs.webkit.org/show_bug.cgi?id=83151

Reviewed by Andreas Kling.

r112952, r113031, r113042 removed variable names in some places but at the end it
was better before as it helps understanding what the variables represent. This patch
address this issue and add back the names where it makes sense.

No new tests : cosmetic changes, no behavior change here.

* css/CSSParser.h:
(CSSParser):
* css/StylePropertySet.h:
(StylePropertySet):
* dom/StyledElement.h:
(StyledElement):
* editing/EditingStyle.h:
(EditingStyle):
* editing/Editor.h:
(Editor):
* html/HTMLElement.h:
(HTMLElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/StylePropertySet.h
trunk/Source/WebCore/dom/StyledElement.h
trunk/Source/WebCore/editing/EditingStyle.h
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/html/HTMLElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (113186 => 113187)

--- trunk/Source/WebCore/ChangeLog	2012-04-04 14:11:34 UTC (rev 113186)
+++ trunk/Source/WebCore/ChangeLog	2012-04-04 14:26:38 UTC (rev 113187)
@@ -1,3 +1,29 @@
+2012-04-04  Alexis Menard  alexis.men...@openbossa.org
+
+Re-add variable names in CSS related headers to help understanding the meaning of them.
+https://bugs.webkit.org/show_bug.cgi?id=83151
+
+Reviewed by Andreas Kling.
+
+r112952, r113031, r113042 removed variable names in some places but at the end it
+was better before as it helps understanding what the variables represent. This patch
+address this issue and add back the names where it makes sense.
+
+No new tests : cosmetic changes, no behavior change here.
+
+* css/CSSParser.h:
+(CSSParser):
+* css/StylePropertySet.h:
+(StylePropertySet):
+* dom/StyledElement.h:
+(StyledElement):
+* editing/EditingStyle.h:
+(EditingStyle):
+* editing/Editor.h:
+(Editor):
+* html/HTMLElement.h:
+(HTMLElement):
+
 2012-04-04  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Implement animatedPathSegList support for SVGPathElement


Modified: trunk/Source/WebCore/css/CSSParser.h (113186 => 113187)

--- trunk/Source/WebCore/css/CSSParser.h	2012-04-04 14:11:34 UTC (rev 113186)
+++ trunk/Source/WebCore/css/CSSParser.h	2012-04-04 14:26:38 UTC (rev 113187)
@@ -75,11 +75,11 @@
 void parseSheet(CSSStyleSheet*, const String, int startLineNumber = 0, StyleRuleRangeMap* ruleRangeMap = 0);
 PassRefPtrStyleRuleBase parseRule(CSSStyleSheet*, const String);
 PassRefPtrStyleKeyframe parseKeyframeRule(CSSStyleSheet*, const String);
-static bool parseValue(StylePropertySet*, CSSPropertyID, const String, bool, CSSParserMode, CSSStyleSheet*);
+static bool parseValue(StylePropertySet*, CSSPropertyID, const String, bool important, CSSParserMode, CSSStyleSheet*);
 static bool parseColor(RGBA32 color, const String, bool strict = false);
 static bool parseSystemColor(RGBA32 color, const String, Document*);
 static PassRefPtrCSSValueList parseFontFaceValue(const AtomicString, CSSStyleSheet* contextStyleSheet);
-PassRefPtrCSSPrimitiveValue parseValidPrimitive(int, CSSParserValue*);
+PassRefPtrCSSPrimitiveValue parseValidPrimitive(int ident, CSSParserValue*);
 bool parseDeclaration(StylePropertySet*, const String, RefPtrCSSStyleSourceData*, CSSStyleSheet* contextStyleSheet);
 PassOwnPtrMediaQuery parseMediaQuery(const String);
 
@@ -87,15 +87,15 @@
 
 CSSValuePool* cssValuePool() const { return m_cssValuePool.get(); }
 
-void addProperty(CSSPropertyID, PassRefPtrCSSValue, bool, bool implicit = false);
+void addProperty(CSSPropertyID, PassRefPtrCSSValue, bool important, bool implicit = false);
 void rollbackLastProperties(int num);
 bool hasProperties() const { return !m_parsedProperties.isEmpty(); }
 
-bool parseValue(CSSPropertyID, bool);
-bool parseShorthand(CSSPropertyID, const StylePropertyShorthand, bool);
-bool parse4Values(CSSPropertyID, const CSSPropertyID*, bool);
-bool parseContent(CSSPropertyID, bool);
-bool parseQuotes(CSSPropertyID, bool);
+bool parseValue(CSSPropertyID, bool important);
+bool parseShorthand(CSSPropertyID, const StylePropertyShorthand, bool important);
+bool parse4Values(CSSPropertyID, const CSSPropertyID* properties, bool important);
+bool parseContent(CSSPropertyID, bool important);
+bool parseQuotes(CSSPropertyID, bool important);
 
 PassRefPtrCSSValue parseAttr(CSSParserValueList* args);
 
@@ -112,8 +112,8 @@
 void parseFillRepeat(RefPtrCSSValue, RefPtrCSSValue);
 PassRefPtrCSSValue parseFillSize(CSSPropertyID propId, bool allowComma);
 
-  

[webkit-changes] [113281] trunk/Source/WebCore

[alexis . menard]

Title: [113281] trunk/Source/WebCore








Revision 113281
Author alexis.men...@openbossa.org
Date 2012-04-04 20:08:10 -0700 (Wed, 04 Apr 2012)


Log Message
[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83224

Reviewed by Tony Chang.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* page/animation/AnimationBase.h:
(WebCore::AnimationBase::affectsProperty):
(WebCore::AnimationBase::isAnimatingProperty):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::getAnimationForProperty):
(WebCore::CompositeAnimation::overrideImplicitAnimations):
(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
(WebCore::CompositeAnimation::isAnimatingProperty):
* page/animation/CompositeAnimation.h:
(CompositeAnimation):
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::affectsProperty):
* page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::transitionProperty):
(WebCore::ImplicitAnimation::animatingProperty):
(ImplicitAnimation):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
(WebCore::KeyframeAnimation::hasAnimationForProperty):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::affectsProperty):
* page/animation/KeyframeAnimation.h:
(KeyframeAnimation):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::transitionPaused):
(WebCore::RenderLayerBacking::transitionFinished):
(WebCore::RenderLayerBacking::graphicsLayerToCSSProperty):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/page/animation/AnimationBase.h
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp
trunk/Source/WebCore/page/animation/CompositeAnimation.h
trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp
trunk/Source/WebCore/page/animation/ImplicitAnimation.h
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (113280 => 113281)

--- trunk/Source/WebCore/ChangeLog	2012-04-05 02:50:46 UTC (rev 113280)
+++ trunk/Source/WebCore/ChangeLog	2012-04-05 03:08:10 UTC (rev 113281)
@@ -1,3 +1,51 @@
+2012-04-04  Alexis Menard  alexis.men...@openbossa.org
+
+[Part 4] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
+https://bugs.webkit.org/show_bug.cgi?id=83224
+
+Reviewed by Tony Chang.
+
+CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
+as integers. While it's not incorrect it is nicer to use the enum as a parameter of
+functions manipulating property ids, as we ensure that the value passed will be an
+existing value. This patch clean up some remaining part of code.
+
+No new tests : There should be no behavior change in this patch.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::collectMatchingRulesForList):
+* page/animation/AnimationBase.h:
+(WebCore::AnimationBase::affectsProperty):
+(WebCore::AnimationBase::isAnimatingProperty):
+* page/animation/CompositeAnimation.cpp:
+(WebCore::CompositeAnimation::getAnimationForProperty):
+(WebCore::CompositeAnimation::overrideImplicitAnimations):
+(WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations):
+(WebCore::CompositeAnimation::isAnimatingProperty):
+* page/animation/CompositeAnimation.h:
+(CompositeAnimation):
+* page/animation/ImplicitAnimation.cpp:
+(WebCore::ImplicitAnimation::affectsProperty):
+* page/animation/ImplicitAnimation.h:
+(WebCore::ImplicitAnimation::transitionProperty):
+(WebCore::ImplicitAnimation::animatingProperty):
+(ImplicitAnimation):
+* page/animation/KeyframeAnimation.cpp:
+(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
+(WebCore::KeyframeAnimation::hasAnimationForProperty):
+(WebCore::KeyframeAnimation::overrideAnimations):
+(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
+(WebC

[webkit-changes] [113042] trunk/Source/WebCore

[alexis . menard]

Title: [113042] trunk/Source/WebCore








Revision 113042
Author alexis.men...@openbossa.org
Date 2012-04-03 08:46:20 -0700 (Tue, 03 Apr 2012)


Log Message
[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83032

Reviewed by Kentaro Hara.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. This patch clean up some remaining part of code.

No new tests : There should be no behavior change in this patch.

* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(CSSPropertyInfo):
(WebCore::cssPropertyInfo):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getPositionOffsetValue):
(WebCore::counterToCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValidPrimitive):
Remove the parameter's name from the h file as it doesn't follow the style and also because the
name was simply wrong we don't expect a propId here but an indentifier. Make it clear in the
cpp file too.
* css/CSSParser.h:
(CSSParser):
* page/animation/AnimationBase.cpp:
(WebCore::addPropertyWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/page/animation/AnimationBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (113041 => 113042)

--- trunk/Source/WebCore/ChangeLog	2012-04-03 15:45:02 UTC (rev 113041)
+++ trunk/Source/WebCore/ChangeLog	2012-04-03 15:46:20 UTC (rev 113042)
@@ -1,3 +1,36 @@
+2012-04-03  Alexis Menard  alexis.men...@openbossa.org
+
+[Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
+https://bugs.webkit.org/show_bug.cgi?id=83032
+
+Reviewed by Kentaro Hara.
+
+CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
+as integers. While it's not incorrect it is nicer to use the enum as a parameter of
+functions manipulating property ids, as we ensure that the value passed will be an
+existing value. This patch clean up some remaining part of code.
+
+No new tests : There should be no behavior change in this patch.
+
+* bindings/js/JSCSSStyleDeclarationCustom.cpp:
+(CSSPropertyInfo):
+(WebCore::cssPropertyIDForJSCSSPropertyName):
+* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+(CSSPropertyInfo):
+(WebCore::cssPropertyInfo):
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::getPositionOffsetValue):
+(WebCore::counterToCSSValue):
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValidPrimitive):
+Remove the parameter's name from the h file as it doesn't follow the style and also because the
+name was simply wrong we don't expect a propId here but an indentifier. Make it clear in the
+cpp file too.
+* css/CSSParser.h:
+(CSSParser):
+* page/animation/AnimationBase.cpp:
+(WebCore::addPropertyWrapper):
+
 2012-04-03  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: remove unused references to TimelineCalculator


Modified: trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp (113041 => 113042)

--- trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp	2012-04-03 15:45:02 UTC (rev 113041)
+++ trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp	2012-04-03 15:46:20 UTC (rev 113042)
@@ -60,7 +60,7 @@
 
 class CSSPropertyInfo {
 public:
-int propertyID;
+CSSPropertyID propertyID;
 bool hadPixelOrPosPrefix;
 };
 
@@ -169,7 +169,7 @@
 
 static CSSPropertyInfo cssPropertyIDForJSCSSPropertyName(const Identifier propertyName)
 {
-CSSPropertyInfo propertyInfo = {0, false};
+CSSPropertyInfo propertyInfo = {CSSPropertyInvalid, false};
 bool hadPixelOrPosPrefix = false;
 
 unsigned length = propertyName.length();
@@ -260,7 +260,7 @@
 int propertyID = hashTableEntry ? hashTableEntry-id : 0;
 if (propertyID) {
 propertyInfo.hadPixelOrPosPrefix = hadPixelOrPosPrefix;
-propertyInfo.propertyID = propertyID;
+propertyInfo.propertyID = static_castCSSPropertyID(propertyID);
 propertyInfoCache.add(stringForCache, propertyInfo);
 }
 return propertyInfo;


Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp (113041 => 113042)

--- trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom

[webkit-changes] [113046] trunk/Source/WebCore

[alexis . menard]

Title: [113046] trunk/Source/WebCore








Revision 113046
Author alexis.men...@openbossa.org
Date 2012-04-03 09:23:49 -0700 (Tue, 03 Apr 2012)


Log Message
Unreviewed ASSERT fix on Chromium bots (in debug).

It appears that http://trac.webkit.org/changeset/113031 caused ASSERT in CSSParser::parseFillProperty.
I added the ASSERT to fix the compilation about values not handled in the switch. I supposed the callers
were only property ids handled in the switch case. It wasn't the case, so I'm restoring the old behavior
while keeping the code to compile (it still need a deeper investigation but let fix the bots quickly).

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (113045 => 113046)

--- trunk/Source/WebCore/ChangeLog	2012-04-03 16:11:09 UTC (rev 113045)
+++ trunk/Source/WebCore/ChangeLog	2012-04-03 16:23:49 UTC (rev 113046)
@@ -1,5 +1,17 @@
 2012-04-03  Alexis Menard  alexis.men...@openbossa.org
 
+Unreviewed ASSERT fix on Chromium bots (in debug).
+
+It appears that http://trac.webkit.org/changeset/113031 caused ASSERT in CSSParser::parseFillProperty.
+I added the ASSERT to fix the compilation about values not handled in the switch. I supposed the callers
+were only property ids handled in the switch case. It wasn't the case, so I'm restoring the old behavior
+while keeping the code to compile (it still need a deeper investigation but let fix the bots quickly).
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseFillProperty):
+
+2012-04-03  Alexis Menard  alexis.men...@openbossa.org
+
 [Part 3] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
 https://bugs.webkit.org/show_bug.cgi?id=83032
 


Modified: trunk/Source/WebCore/css/CSSParser.cpp (113045 => 113046)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-04-03 16:11:09 UTC (rev 113045)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-04-03 16:23:49 UTC (rev 113046)
@@ -3506,8 +3506,7 @@
 break;
 }
 default:
-ASSERT_NOT_REACHED();
-return false;
+break;
 }
 if (!currValue)
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112952] trunk/Source

[alexis . menard]

Title: [112952] trunk/Source








Revision 112952
Author alexis.men...@openbossa.org
Date 2012-04-02 15:30:04 -0700 (Mon, 02 Apr 2012)


Log Message
We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82941

Reviewed by Andreas Kling.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. It will also feel more correct after this patch that CSSProperty::id()
return a value of the enum rather than an integer. As this modification is quite big this
is the first part only so it will be easier to review.

Source/WebCore:

No new tests : There should be no behavior change in this patch.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):
* css/CSSParser.h:
(WebCore):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::cssText):
* css/CSSProperty.h:
(WebCore::CSSProperty::id):
(WebCore::CSSProperty::shorthandID):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::asText):
* css/StylePropertySet.h:
(StylePropertySet):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::removePropertiesInStyle):
(WebCore::setTextDecorationProperty):
(WebCore::diffTextDecorations):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue):
* editing/Editor.h:
(Editor):
* editing/EditorCommand.cpp:
(WebCore::valueStyle):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty): Adapt to the API change and also remove an unecessary name-id
conversion.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSProperty.cpp
trunk/Source/WebCore/css/CSSProperty.h
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/css/StylePropertySet.cpp
trunk/Source/WebCore/css/StylePropertySet.h
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/EditorCommand.cpp
trunk/Source/WebKit/qt/Api/qwebelement.cpp
trunk/Source/WebKit/qt/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (112951 => 112952)

--- trunk/Source/WebCore/ChangeLog	2012-04-02 22:19:32 UTC (rev 112951)
+++ trunk/Source/WebCore/ChangeLog	2012-04-02 22:30:04 UTC (rev 112952)
@@ -1,3 +1,56 @@
+2012-04-02  Alexis Menard  alexis.men...@openbossa.org
+
+We should use CSSPropertyID rather than integers when manipulating CSS property ids.
+https://bugs.webkit.org/show_bug.cgi?id=82941
+
+Reviewed by Andreas Kling.
+
+CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
+as integers. While it's not incorrect it is nicer to use the enum as a parameter of
+functions manipulating property ids, as we ensure that the value passed will be an
+existing value. It will also feel more correct after this patch that CSSProperty::id()
+return a value of the enum rather than an integer. As this modification is quite big this
+is the first part only so it will be easier to review.
+
+No new tests : There should be no behavior change in this patch.
+
+* css/CSSParser.cpp:
+(WebCore::cssPropertyID):
+* css/CSSParser.h:
+(WebCore):
+* css/CSSProperty.cpp:
+(WebCore::CSSProperty::cssText):
+* css/CSSProperty.h:
+(WebCore::CSSProperty::id):
+(WebCore::CSSProperty::shorthandID):
+* css/PropertySetCSSStyleDeclaration.cpp:
+(WebCore::PropertySetCSSStyleDeclaration::item):
+(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
+(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
+(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
+(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
+(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
+* css/StylePropertySet.cpp:
+(WebCore::StylePropertySet::getPropertyValue):
+(WebCore::StyleProperty

[webkit-changes] [112387] trunk

[alexis . menard]

Title: [112387] trunk








Revision 112387
Author alexis.men...@openbossa.org
Date 2012-03-28 05:40:31 -0700 (Wed, 28 Mar 2012)


Log Message
Speed up updates of existing CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=82235

Reviewed by Andreas Kling.

Source/WebCore:

Improve the way we handle updating an existing CSS property by replacing its value
by the new one rather than removing the old value and then adding the new one. This
speed up by 35% PerformanceTests/CSS/CSSPropertyUpdateValue.html.

No new tests : Updating existing tests that were relying on the order of the properties
after modification. Each updated property is not appended to the list of properties of the
style therefore the cssText value is slightly different. It matches Firefox behavior but not
Opera.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::addParsedProperty):

LayoutTests:

Updated expectations after behavior change on how we handle updates of
CSS properties from JS. We match now Firefox where the cssText keeps the
order of the properties (but modify its value) whereas before we were appending
the new value at the end of the list of properties.

* editing/pasteboard/data-transfer-items-expected.txt:
* editing/pasteboard/onpaste-text-html-expected.txt:
* fast/dom/css-set-property-exception-expected.txt:
* fast/events/ondrop-text-html-expected.txt:
* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
* inspector/styles/styles-new-API-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/data-transfer-items-expected.txt
trunk/LayoutTests/editing/pasteboard/onpaste-text-html-expected.txt
trunk/LayoutTests/fast/dom/css-set-property-exception-expected.txt
trunk/LayoutTests/fast/events/ondrop-text-html-expected.txt
trunk/LayoutTests/fast/mutation/observe-attributes-expected.txt
trunk/LayoutTests/fast/mutation/observe-attributes.html
trunk/LayoutTests/inspector/styles/styles-new-API-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StylePropertySet.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112386 => 112387)

--- trunk/LayoutTests/ChangeLog	2012-03-28 12:39:40 UTC (rev 112386)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 12:40:31 UTC (rev 112387)
@@ -1,3 +1,23 @@
+2012-03-28  Alexis Menard  alexis.men...@openbossa.org
+
+Speed up updates of existing CSS properties from JS.
+https://bugs.webkit.org/show_bug.cgi?id=82235
+
+Reviewed by Andreas Kling.
+
+Updated expectations after behavior change on how we handle updates of
+CSS properties from JS. We match now Firefox where the cssText keeps the
+order of the properties (but modify its value) whereas before we were appending
+the new value at the end of the list of properties.
+
+* editing/pasteboard/data-transfer-items-expected.txt:
+* editing/pasteboard/onpaste-text-html-expected.txt:
+* fast/dom/css-set-property-exception-expected.txt:
+* fast/events/ondrop-text-html-expected.txt:
+* fast/mutation/observe-attributes-expected.txt:
+* fast/mutation/observe-attributes.html:
+* inspector/styles/styles-new-API-expected.txt:
+
 2012-03-28  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: breakpoints are not shown in sidebar pane after reload.


Modified: trunk/LayoutTests/editing/pasteboard/data-transfer-items-expected.txt (112386 => 112387)

--- trunk/LayoutTests/editing/pasteboard/data-transfer-items-expected.txt	2012-03-28 12:39:40 UTC (rev 112386)
+++ trunk/LayoutTests/editing/pasteboard/data-transfer-items-expected.txt	2012-03-28 12:40:31 UTC (rev 112387)
@@ -20,6 +20,6 @@
 DataTransferItem accessed outside event handler!
 copy: items[0] value: Hello World!
 copy: items[1] value: bHello World!
-paste: items[0] value: span style=color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; display: inline !important; float: none; This file tests the basic functionality and properties of DataTransferItems. This test requires DRT./span
+paste: items[0] value: span style=color: rgb(0, 0, 0); font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; display: inline !important; float: none; This file tests the basic functionality and properties of DataTransferItems. This test requires DRT./span
 paste: items[1] value: This file tests the basic functionality and properties of DataTransfe

[webkit-changes] [112418] trunk/Source/WebCore

[alexis . menard]

Title: [112418] trunk/Source/WebCore








Revision 112418
Author alexis.men...@openbossa.org
Date 2012-03-28 11:29:54 -0700 (Wed, 28 Mar 2012)


Log Message
Increase code sharing between CSSProperty and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82479

Reviewed by Antti Koivisto.

Use longhands declarations from CSSPropertyLonghand in CSSProperty to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSProperty.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112417 => 112418)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 18:24:01 UTC (rev 112417)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 18:29:54 UTC (rev 112418)
@@ -1,3 +1,21 @@
+2012-03-28  Alexis Menard  alexis.men...@openbossa.org
+
+Increase code sharing between CSSProperty and CSSPropertyLonghand.
+https://bugs.webkit.org/show_bug.cgi?id=82479
+
+Reviewed by Antti Koivisto.
+
+Use longhands declarations from CSSPropertyLonghand in CSSProperty to avoid
+code duplication.
+
+No new tests : refactoring only, we shouldn't have any behavior difference.
+
+* css/CSSProperty.cpp:
+(WebCore::resolveToPhysicalProperty):
+(WebCore::borderDirections):
+(WebCore):
+(WebCore::CSSProperty::resolveDirectionAwareProperty):
+
 2012-03-28  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Implement snippets renaming in scripts navigator.


Modified: trunk/Source/WebCore/css/CSSProperty.cpp (112417 => 112418)

--- trunk/Source/WebCore/css/CSSProperty.cpp	2012-03-28 18:24:01 UTC (rev 112417)
+++ trunk/Source/WebCore/css/CSSProperty.cpp	2012-03-28 18:29:54 UTC (rev 112418)
@@ -21,6 +21,7 @@
 #include config.h
 #include CSSProperty.h
 
+#include CSSPropertyLonghand.h
 #include CSSPropertyNames.h
 #include PlatformString.h
 #include RenderStyleConstants.h
@@ -35,26 +36,26 @@
 enum LogicalBoxSide { BeforeSide, EndSide, AfterSide, StartSide };
 enum PhysicalBoxSide { TopSide, RightSide, BottomSide, LeftSide };
 
-static int resolveToPhysicalProperty(TextDirection direction, WritingMode writingMode, LogicalBoxSide logicalSide, const int* properties)
+static int resolveToPhysicalProperty(TextDirection direction, WritingMode writingMode, LogicalBoxSide logicalSide, const CSSPropertyLonghand longhand)
 {
 if (direction == LTR) {
 if (writingMode == TopToBottomWritingMode) {
 // The common case. The logical and physical box sides match.
 // Left = Start, Right = End, Before = Top, After = Bottom
-return properties[logicalSide];
+return longhand.properties()[logicalSide];
 }
 
 if (writingMode == BottomToTopWritingMode) {
 // Start = Left, End = Right, Before = Bottom, After = Top.
 switch (logicalSide) {
 case StartSide:
-return properties[LeftSide];
+return longhand.properties()[LeftSide];
 case EndSide:
-return properties[RightSide];
+return longhand.properties()[RightSide];
 case BeforeSide:
-return properties[BottomSide];
+return longhand.properties()[BottomSide];
 default:
-return properties[TopSide];
+return longhand.properties()[TopSide];
 }
 }
 
@@ -62,26 +63,26 @@
 // Start = Top, End = Bottom, Before = Left, After = Right.
 switch (logicalSide) {
 case StartSide:
-return properties[TopSide];
+return longhand.properties()[TopSide];
 case EndSide:
-return properties[BottomSide];
+return longhand.properties()[BottomSide];
 case BeforeSide:
-return properties[LeftSide];
+return longhand.properties()[LeftSide];
 default:
-return properties[RightSide];
+return longhand.properties()[RightSide];
 }
 }
 
 // Start = Top, End = Bottom, Before = Right, After = Left
 switch (logicalSide) {
 case StartSide:
-return properties[TopSide];
+return longhand.properties()[TopSide];
 case EndSide:
-return properties[BottomSide];
+return longhand.properties()[BottomSide];
 case BeforeSide:
-return properties[RightSide];
+return longhand.properties()[RightSide];
 default:
-return properties[LeftSide];
+return longhand.properties()[LeftSide];
 }
 }
 
@@ -89,13 +90,13 @@
 // Start = Right, End = Left, Before

[webkit-changes] [112253] trunk/PerformanceTests

[alexis . menard]

Title: [112253] trunk/PerformanceTests








Revision 112253
Author alexis.men...@openbossa.org
Date 2012-03-27 04:57:05 -0700 (Tue, 27 Mar 2012)


Log Message
Add a perf test which updates the value of an already declared CSS property.
https://bugs.webkit.org/show_bug.cgi?id=82321

Reviewed by Andreas Kling.

This benchmark update CSS existing properties of the style from JS.

* CSS/CSSPropertyUpdateValue.html: Added.

Modified Paths

trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/CSS/CSSPropertyUpdateValue.html




Diff

Added: trunk/PerformanceTests/CSS/CSSPropertyUpdateValue.html (0 => 112253)

--- trunk/PerformanceTests/CSS/CSSPropertyUpdateValue.html	(rev 0)
+++ trunk/PerformanceTests/CSS/CSSPropertyUpdateValue.html	2012-03-27 11:57:05 UTC (rev 112253)
@@ -0,0 +1,80 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+div id=test/div
+/body
+script
+var div = document.getElementById(test);
+var properties = {
+'azimuth' : 'right',
+'backgroundColor' : 'green',
+'backgroundImage' : 'url(\'test.png\')',
+'backgroundPosition' : 'top',
+'background-repeat' : 'repeat-x',
+'background' : '#ff url(\'img_tree.png\') no-repeat right top',
+'border' : '20px dotted red',
+'borderBottomStyle' : 'dotted',
+'borderCollapse' : 'separate',
+'borderColor' : 'blue',
+'borderSpacing' : '3px',
+'borderStyle' : 'solid',
+'borderTop' : 'green',
+'borderWidth' : '20em',
+'bottom' : '20%',
+'captionSide' : 'top',
+'clear' : 'both',
+'clip' : 'rect(5px, 40px, 45px, 5px)',
+'color' : 'red',
+'content' : 'normal',
+'direction' : 'rtl',
+'display' : 'block',
+'float' : 'right',
+'fontFamily' : 'Times New Roman,Georgia,Serif',
+'fontSize' : '13px',
+'fontVariant' : 'small-caps',
+'fontWeight' : '700',
+'font' : 'italic bold 12px/30px Georgia, serif',
+'height' : '200px',
+'left' : '20%',
+'letterSpacing' : '10px',
+'lineHeight' : '40px',
+'listStyleImage' : 'url(\'test.png\')',
+'listStylePosition' : 'outside',
+'listStyleType' : 'decimal',
+'listStyle' : 'circle inside',
+'marginRight' : '50px',
+'margin' : '10px 20px 30px 5em',
+'maxHeight' : '700px',
+'maxWidth' : '300px',
+'minHeight' : '100px',
+'minWidth' : '100px',
+'outlineColor' : 'gray',
+'outlineStyle' : 'dotted',
+'outlineWidth' : '5px',
+'paddingTop' : '30px',
+'padding' : '30px 20px 10px 50px',
+'pageBreakAfter' : 'always',
+'pageBreakInside' : 'auto',
+'pause' : '2s',
+'position' : 'static',
+'right' : '150px',
+'textAlign' : 'center',
+'textDecoration' : 'blink',
+'textTransform' : 'capitalize',
+'top' : '25%',
+'verticalAlign' : 'text-bottom',
+'visibility' : 'visible',
+'width' : '300px',
+'webkitTransform' : 'scale3d(0.5, 0.5, 0.5)',
+'wordSpacing' : '40px',
+};
+// The first run will just add the properties but it's fine as the first run of the benchmark is always ignored.
+PerfTestRunner.run(function() {
+for (key in properties)
+div.style[key] = properties[key];
+}, 1);
+/script
+/html


Modified: trunk/PerformanceTests/ChangeLog (112252 => 112253)

--- trunk/PerformanceTests/ChangeLog	2012-03-27 11:53:15 UTC (rev 112252)
+++ trunk/PerformanceTests/ChangeLog	2012-03-27 11:57:05 UTC (rev 112253)
@@ -1,3 +1,14 @@
+2012-03-27  Alexis Menard  alexis.men...@openbossa.org
+
+Add a perf test which updates the value of an already declared CSS property.
+https://bugs.webkit.org/show_bug.cgi?id=82321
+
+Reviewed by Andreas Kling.
+
+This benchmark update CSS existing properties of the style from JS.
+
+* CSS/CSSPropertyUpdateValue.html: Added.
+
 2012-03-15  Kentaro Hara  hara...@chromium.org
 
 [PerformanceTests] run-perf-tests should output correct units






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112254] trunk

[alexis . menard]

Title: [112254] trunk








Revision 112254
Author alexis.men...@openbossa.org
Date 2012-03-27 05:00:52 -0700 (Tue, 27 Mar 2012)


Log Message
Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=82261

Reviewed by Ryosuke Niwa.

Source/WebCore:

Use longhands declaration from CSSPropertyLonghand in CSSComputedStyleDeclaration to avoid
code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
* css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
* css/CSSPropertyLonghand.cpp:
(WebCore::outlineLonghand):
Re-order to match the spec default order and also remove outline-offset as it is not part
of the shorthand (http://www.w3.org/TR/css3-ui/#outline). Luckily this was cover by a layout test.

LayoutTests:

Update expectation as it was relying on inaccurate order. All other outline related tests
are expecting the same order (e.g. fast/getComputedStyle/getComputedStyle-outline-shorthand) as well
as Opera.

* fast/css/cssText-shorthand-expected.txt:
* fast/css/cssText-shorthand.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt
trunk/LayoutTests/fast/css/cssText-shorthand.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h
trunk/Source/WebCore/css/CSSPropertyLonghand.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (112253 => 112254)

--- trunk/LayoutTests/ChangeLog	2012-03-27 11:57:05 UTC (rev 112253)
+++ trunk/LayoutTests/ChangeLog	2012-03-27 12:00:52 UTC (rev 112254)
@@ -1,3 +1,17 @@
+2012-03-27  Alexis Menard  alexis.men...@openbossa.org
+
+Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
+https://bugs.webkit.org/show_bug.cgi?id=82261
+
+Reviewed by Ryosuke Niwa.
+
+Update expectation as it was relying on inaccurate order. All other outline related tests
+are expecting the same order (e.g. fast/getComputedStyle/getComputedStyle-outline-shorthand) as well
+as Opera.
+
+* fast/css/cssText-shorthand-expected.txt:
+* fast/css/cssText-shorthand.html:
+
 2012-03-27  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Enable animVal support for SVGAnimatedRect


Modified: trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt (112253 => 112254)

--- trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt	2012-03-27 11:57:05 UTC (rev 112253)
+++ trunk/LayoutTests/fast/css/cssText-shorthand-expected.txt	2012-03-27 12:00:52 UTC (rev 112254)
@@ -17,7 +17,7 @@
 PASS normalizeCssText(element.style.cssText) is font-family: sans-serif; font-size: 3em; font-style: italic; font-weight: bold; line-height: 2em
 PASS normalizeCssText(element.style.cssText) is list-style: circle inside
 PASS normalizeCssText(element.style.cssText) is margin: 1px 2px 3px 4px
-PASS normalizeCssText(element.style.cssText) is outline: 2px dotted blue
+PASS normalizeCssText(element.style.cssText) is outline: blue dotted 2px
 FAIL normalizeCssText(element.style.cssText) should be overflow: scroll hidden. Was overflow-x: scroll; overflow-y: hidden.
 PASS normalizeCssText(element.style.cssText) is padding: 1px 2px 3px 4px
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/fast/css/cssText-shorthand.html (112253 => 112254)

--- trunk/LayoutTests/fast/css/cssText-shorthand.html	2012-03-27 11:57:05 UTC (rev 112253)
+++ trunk/LayoutTests/fast/css/cssText-shorthand.html	2012-03-27 12:00:52 UTC (rev 112254)
@@ -31,7 +31,7 @@
 
 ['list-style-type: circle; list-style-position: inside;', 'list-style: circle inside;'],
 ['margin-top: 1px; margin-right: 2px; margin-bottom: 3px; margin-left: 4px;', 'margin: 1px 2px 3px 4px;'],
-['outline-width: 2px; outline-style: dotted; outline-color: blue;', 'outline: 2px dotted blue;'],
+['outline-width: 2px; outline-style: dotted; outline-color: blue;', 'outline: blue dotted 2px;'],
 ['overflow-x: scroll; overflow-y: hidden;', 'overflow: scroll hidden;'],
 ['padding-top: 1px; padding-right: 2px; padding-bottom: 3px; padding-left: 4px;', 'padding: 1px 2px 3px 4px;'],
 ];


Modified: trunk/Source/WebCore/ChangeLog (112253 => 112254)

--- trunk/Source/WebCore/ChangeLog	2012-03-27 11:57:05 UTC (rev 112253)
+++ trunk/Source/WebCore/ChangeLog	2012-03-27 12:00:52 UTC (rev 112254)
@@ -1,3 +1,27 @@
+2012-03-27  Alexis Menard  alexis.men...@openbossa.org
+
+Increase code sharing between CSSComputedStyleDeclaration and CSSPropertyLonghand.
+https://bugs.webkit.org/show_bug.cgi?id=82261
+
+Reviewed by Ryosuke Niwa.
+

[webkit-changes] [112341] trunk/Source/WebCore

[alexis . menard]

Title: [112341] trunk/Source/WebCore








Revision 112341
Author alexis.men...@openbossa.org
Date 2012-03-27 17:27:27 -0700 (Tue, 27 Mar 2012)


Log Message
Simplify CSSPropertyBorderSpacing parsing.
https://bugs.webkit.org/show_bug.cgi?id=82397

Reviewed by Benjamin Poulain.

Remove the local array of longhand properties as it doesn't really
bring much in this simple parsing algorithm.

No new tests, no functionality change intended.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (112340 => 112341)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1,3 +1,18 @@
+2012-03-27  Alexis Menard  alexis.men...@openbossa.org
+
+Simplify CSSPropertyBorderSpacing parsing.
+https://bugs.webkit.org/show_bug.cgi?id=82397
+
+Reviewed by Benjamin Poulain.
+
+Remove the local array of longhand properties as it doesn't really
+bring much in this simple parsing algorithm.
+
+No new tests, no functionality change intended.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+
 2012-03-27  Anders Carlsson  ander...@apple.com
 
 Fix race condition when initializing the scrolling thread


Modified: trunk/Source/WebCore/css/CSSParser.cpp (112340 => 112341)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:21:13 UTC (rev 112340)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-03-28 00:27:27 UTC (rev 112341)
@@ -1538,19 +1538,17 @@
 return parseFontWeight(important);
 
 case CSSPropertyBorderSpacing: {
-const int properties[2] = { CSSPropertyWebkitBorderHorizontalSpacing,
-CSSPropertyWebkitBorderVerticalSpacing };
 if (num == 1) {
 ShorthandScope scope(this, CSSPropertyBorderSpacing);
-if (!parseValue(properties[0], important))
+if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important))
 return false;
 CSSValue* value = m_parsedProperties.last().value();
-addProperty(properties[1], value, important);
+addProperty(CSSPropertyWebkitBorderVerticalSpacing, value, important);
 return true;
 }
 else if (num == 2) {
 ShorthandScope scope(this, CSSPropertyBorderSpacing);
-if (!parseValue(properties[0], important) || !parseValue(properties[1], important))
+if (!parseValue(CSSPropertyWebkitBorderHorizontalSpacing, important) || !parseValue(CSSPropertyWebkitBorderVerticalSpacing, important))
 return false;
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112078] trunk/Source/WebCore

[alexis . menard]

Title: [112078] trunk/Source/WebCore








Revision 112078
Author alexis.men...@openbossa.org
Date 2012-03-26 05:11:47 -0700 (Mon, 26 Mar 2012)


Log Message
Increase code sharing between StylePropertySet and CSSPropertyLonghand.
https://bugs.webkit.org/show_bug.cgi?id=81960

Reviewed by Antti Koivisto.

Use longhands declaration from CSSPropertyLonghand in StylePropertySet in order
to avoid code duplication.

No new tests : refactoring only, we shouldn't have any behavior difference.

* css/CSSPropertyLonghand.cpp:
(WebCore::backgroundLonghand):
Re-order the array to match the spec default order.
(WebCore::webkitMaskLonghand):
Re-order to match the original order.
(WebCore::webkitTransformOriginLonghand):
A LayoutTest shows that a property was missing.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::asText):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPropertyLonghand.cpp
trunk/Source/WebCore/css/StylePropertySet.cpp
trunk/Source/WebCore/css/StylePropertySet.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (112077 => 112078)

--- trunk/Source/WebCore/ChangeLog	2012-03-26 11:56:53 UTC (rev 112077)
+++ trunk/Source/WebCore/ChangeLog	2012-03-26 12:11:47 UTC (rev 112078)
@@ -1,3 +1,34 @@
+2012-03-26  Alexis Menard  alexis.men...@openbossa.org
+
+Increase code sharing between StylePropertySet and CSSPropertyLonghand.
+https://bugs.webkit.org/show_bug.cgi?id=81960
+
+Reviewed by Antti Koivisto.
+
+Use longhands declaration from CSSPropertyLonghand in StylePropertySet in order
+to avoid code duplication.
+
+No new tests : refactoring only, we shouldn't have any behavior difference.
+
+* css/CSSPropertyLonghand.cpp:
+(WebCore::backgroundLonghand):
+Re-order the array to match the spec default order.
+(WebCore::webkitMaskLonghand):
+Re-order to match the original order.
+(WebCore::webkitTransformOriginLonghand):
+A LayoutTest shows that a property was missing.
+* css/StylePropertySet.cpp:
+(WebCore::StylePropertySet::getPropertyValue):
+(WebCore::StylePropertySet::borderSpacingValue):
+(WebCore::StylePropertySet::get4Values):
+(WebCore::StylePropertySet::getLayeredShorthandValue):
+(WebCore::StylePropertySet::getShorthandValue):
+(WebCore::StylePropertySet::getCommonValue):
+(WebCore::StylePropertySet::asText):
+* css/StylePropertySet.h:
+(WebCore):
+(StylePropertySet):
+
 2012-03-26  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 [Qt] Assert in GestureTapHighlighter.


Modified: trunk/Source/WebCore/css/CSSPropertyLonghand.cpp (112077 => 112078)

--- trunk/Source/WebCore/css/CSSPropertyLonghand.cpp	2012-03-26 11:56:53 UTC (rev 112077)
+++ trunk/Source/WebCore/css/CSSPropertyLonghand.cpp	2012-03-26 12:11:47 UTC (rev 112078)
@@ -30,15 +30,15 @@
 const CSSPropertyLonghand backgroundLonghand()
 {
 static const int backgroundProperties[] = {
-CSSPropertyBackgroundAttachment,
-CSSPropertyBackgroundClip,
 CSSPropertyBackgroundColor,
 CSSPropertyBackgroundImage,
-CSSPropertyBackgroundOrigin,
+CSSPropertyBackgroundRepeatX,
+CSSPropertyBackgroundRepeatY,
+CSSPropertyBackgroundAttachment,
 CSSPropertyBackgroundPositionX,
 CSSPropertyBackgroundPositionY,
-CSSPropertyBackgroundRepeatX,
-CSSPropertyBackgroundRepeatY
+CSSPropertyBackgroundClip,
+CSSPropertyBackgroundOrigin
 };
 DEFINE_STATIC_LOCAL(CSSPropertyLonghand, backgroundLonghand, (backgroundProperties, WTF_ARRAY_LENGTH(backgroundProperties)));
 return backgroundLonghand;
@@ -339,14 +339,14 @@
 const CSSPropertyLonghand webkitMaskLonghand()
 {
 static const int maskProperties[] = {
+CSSPropertyWebkitMaskImage,
+CSSPropertyWebkitMaskRepeatX,
+CSSPropertyWebkitMaskRepeatY,
 CSSPropertyWebkitMaskAttachment,
-CSSPropertyWebkitMaskClip,
-CSSPropertyWebkitMaskImage,
-CSSPropertyWebkitMaskOrigin,
 CSSPropertyWebkitMaskPositionX,
 CSSPropertyWebkitMaskPositionY,
-CSSPropertyWebkitMaskRepeatX,
-CSSPropertyWebkitMaskRepeatY
+CSSPropertyWebkitMaskClip,
+CSSPropertyWebkitMaskOrigin
 };
 DEFINE_STATIC_LOCAL(CSSPropertyLonghand, webkitMaskLonghand, (maskProperties, WTF_ARRAY_LENGTH(maskProperties)));
 return webkitMaskLonghand;
@@ -399,7 +399,8 @@
 {
 static const int transformOriginProperties[] = {
 CSSPropertyWebkitTransformO

[webkit-changes] [110833] trunk/PerformanceTests

[alexis . menard]

Title: [110833] trunk/PerformanceTests








Revision 110833
Author alexis.men...@openbossa.org
Date 2012-03-15 01:57:19 -0700 (Thu, 15 Mar 2012)


Log Message
Add a new perf test to benchmark setting and reading CSS properties from JS.
https://bugs.webkit.org/show_bug.cgi?id=81155

Reviewed by Ryosuke Niwa.

This benchmark read and set CSS properties from JS. It contains a list
of common CSS properties.

* CSS/CSSPropertySetterGetter.html: Added.

Modified Paths

trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/CSS/
trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html




Diff

Added: trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html (0 => 110833)

--- trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html	(rev 0)
+++ trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html	2012-03-15 08:57:19 UTC (rev 110833)
@@ -0,0 +1,82 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+div id=testContent here./div
+/body
+script
+var div = document.getElementById(test);
+var properties = {
+'azimuth' : 'right',
+'backgroundColor' : 'green',
+'backgroundImage' : 'url(\'test.png\')',
+'backgroundPosition' : 'top',
+'background-repeat' : 'repeat-x',
+'background' : '#ff url(\'img_tree.png\') no-repeat right top',
+'border' : '20px dotted red',
+'borderBottomStyle' : 'dotted',
+'borderCollapse' : 'separate',
+'borderColor' : 'blue',
+'borderSpacing' : '3px',
+'borderStyle' : 'solid',
+'borderTop' : 'green',
+'borderWidth' : '20em',
+'bottom' : '20%',
+'captionSide' : 'top',
+'clear' : 'both',
+'clip' : 'rect(5px, 40px, 45px, 5px)',
+'color' : 'red',
+'content' : 'normal',
+'direction' : 'rtl',
+'display' : 'block',
+'float' : 'right',
+'fontFamily' : 'Times New Roman,Georgia,Serif',
+'fontSize' : '13px',
+'fontVariant' : 'small-caps',
+'fontWeight' : '700',
+'font' : 'italic bold 12px/30px Georgia, serif',
+'height' : '200px',
+'left' : '20%',
+'letterSpacing' : '10px',
+'lineHeight' : '40px',
+'listStyleImage' : 'url(\'test.png\')',
+'listStylePosition' : 'outside',
+'listStyleType' : 'decimal',
+'listStyle' : 'circle inside',
+'marginRight' : '50px',
+'margin' : '10px 20px 30px 5em',
+'maxHeight' : '700px',
+'maxWidth' : '300px',
+'minHeight' : '100px',
+'minWidth' : '100px',
+'outlineColor' : 'gray',
+'outlineStyle' : 'dotted',
+'outlineWidth' : '5px',
+'paddingTop' : '30px',
+'padding' : '30px 20px 10px 50px',
+'pageBreakAfter' : 'always',
+'pageBreakInside' : 'auto',
+'pause' : '2s',
+'position' : 'static',
+'right' : '150px',
+'textAlign' : 'center',
+'textDecoration' : 'blink',
+'textTransform' : 'capitalize',
+'top' : '25%',
+'verticalAlign' : 'text-bottom',
+'visibility' : 'visible',
+'width' : '300px',
+'webkitTransform' : 'scale3d(0.5, 0.5, 0.5)',
+'wordSpacing' : '40px',
+};
+PerfTestRunner.run(function() {
+for (key in properties) {
+var value = div.style[key];
+div.style[key] = ;
+div.style[key] = properties[key];
+}
+}, 5000);
+/script
+/html


Modified: trunk/PerformanceTests/ChangeLog (110832 => 110833)

--- trunk/PerformanceTests/ChangeLog	2012-03-15 08:04:49 UTC (rev 110832)
+++ trunk/PerformanceTests/ChangeLog	2012-03-15 08:57:19 UTC (rev 110833)
@@ -1,3 +1,15 @@
+2012-03-14  Alexis Menard  alexis.men...@openbossa.org
+
+Add a new perf test to benchmark setting and reading CSS properties from JS.
+https://bugs.webkit.org/show_bug.cgi?id=81155
+
+Reviewed by Ryosuke Niwa.
+
+This benchmark read and set CSS properties from JS. It contains a list
+of common CSS properties.
+
+* CSS/CSSPropertySetterGetter.html: Added.
+
 2012-03-14  Alexandru Chiculita  ach...@adobe.com
 
 Layout/floats.html should be runnable by run-perf-tests






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [110862] trunk/PerformanceTests

[alexis . menard]

Title: [110862] trunk/PerformanceTests








Revision 110862
Author alexis.men...@openbossa.org
Date 2012-03-15 11:24:01 -0700 (Thu, 15 Mar 2012)


Log Message
Fix the test failing with run-perf-tests.

Rubber stamped by Ryosuke Niwa.

* CSS/CSSPropertySetterGetter.html:

Modified Paths

trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html (110861 => 110862)

--- trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html	2012-03-15 17:37:48 UTC (rev 110861)
+++ trunk/PerformanceTests/CSS/CSSPropertySetterGetter.html	2012-03-15 18:24:01 UTC (rev 110862)
@@ -4,7 +4,7 @@
 script src=""
 /head
 body
-div id=testContent here./div
+div id=test/div
 /body
 script
 var div = document.getElementById(test);


Modified: trunk/PerformanceTests/ChangeLog (110861 => 110862)

--- trunk/PerformanceTests/ChangeLog	2012-03-15 17:37:48 UTC (rev 110861)
+++ trunk/PerformanceTests/ChangeLog	2012-03-15 18:24:01 UTC (rev 110862)
@@ -1,3 +1,11 @@
+2012-03-15  Alexis Menard  alexis.men...@openbossa.org
+
+Fix the test failing with run-perf-tests.
+
+Rubber stamped by Ryosuke Niwa.
+
+* CSS/CSSPropertySetterGetter.html:
+
 2012-03-14  Alexis Menard  alexis.men...@openbossa.org
 
 Add a new perf test to benchmark setting and reading CSS properties from JS.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109968] trunk

[alexis . menard]

Title: [109968] trunk








Revision 109968
Author alexis.men...@openbossa.org
Date 2012-03-06 15:52:29 -0800 (Tue, 06 Mar 2012)


Log Message
getComputedStyle returns incorrect values for the width and height of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=37835

Reviewed by Tony Chang.

Source/WebCore:

In case we are querying the computed style of an element with a pseudo-element we can't use
the renderer of the element as this one is not the one used to render the pseudo-element. We need
to use the one created to render the pseudo-element.

No new tests : Extend the existing getComputedStyle-with-pseudo-element.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover the bug.

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (109967 => 109968)

--- trunk/LayoutTests/ChangeLog	2012-03-06 23:50:15 UTC (rev 109967)
+++ trunk/LayoutTests/ChangeLog	2012-03-06 23:52:29 UTC (rev 109968)
@@ -1,3 +1,15 @@
+2012-03-06  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle returns incorrect values for the width and height of pseudo-elements
+https://bugs.webkit.org/show_bug.cgi?id=37835
+
+Reviewed by Tony Chang.
+
+Extend existing test to cover the bug.
+
+* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
+
 2012-03-06  Dimitri Glazkov  dglaz...@chromium.org
 
 REGRESSION(r109191): Shadow DOM tests stopped running on ports that do not have SHADOW_DOM flag enabled.


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt (109967 => 109968)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt	2012-03-06 23:50:15 UTC (rev 109967)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt	2012-03-06 23:52:29 UTC (rev 109968)
@@ -5,6 +5,11 @@
 
 Middle
 
+div with :before and :after display:table
+
+div with :before and :after display:inline
+
+
 There are no pseudo elements defined on this div.
 
 This should be at full opacity.
@@ -16,10 +21,48 @@
 PASS Expected 'rgb(0, 0, 0)' for color in the computed style for element with id testFirsts and pseudo-element null and got 'rgb(0, 0, 0)'
 PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testBeforeAfter and pseudo-element :before and got 'rgb(165, 42, 42)'
 PASS Expected 'rgb(0, 0, 255)' for color in the computed style for element with id testBeforeAfter and pseudo-element :after and got 'rgb(0, 0, 255)'
+PASS Expected 'rgb(0, 0, 0) dotted 1px' for outline in the computed style for element with id testBeforeAfter and pseudo-element :before and got 'rgb(0, 0, 0) dotted 1px'
+PASS Expected 'rgb(255, 0, 0) solid 5px' for outline in the computed style for element with id testBeforeAfter and pseudo-element :after and got 'rgb(255, 0, 0) solid 5px'
+PASS Expected 'hidden' for overflow in the computed style for element with id testBeforeAfter and pseudo-element :before and got 'hidden'
+PASS Expected 'visible' for overflow in the computed style for element with id testBeforeAfter and pseudo-element :after and got 'visible'
+PASS Expected '250px' for height in the computed style for element with id testBeforeAfter and pseudo-element :before and got '250px'
+PASS Expected '350px' for width in the computed style for element with id testBeforeAfter and pseudo-element :before and got '350px'
+PASS Expected '200px' for height in the computed style for element with id testBeforeAfter and pseudo-element :after and got '200px'
+PASS Expected '300px' for width in the computed style for element with id testBeforeAfter and pseudo-element :after and got '300px'
+PASS Expected '10px 20px 30px 40px' for margin in the computed style for element with id testBeforeAfter and pseudo-element :before and got '10px 20px 30px 40px'
+PASS Expected '0px' for padding in the computed style for element with id testBeforeAfter and pseudo-element :before and got '0px'
+PASS Expected '0px' for margin in the computed style for element with id testBeforeAfter and pseudo-element :after and got '0px'
+PASS Expected '10px 20px 30px 40px' for padding in the computed style for element with id testBeforeAfter and pseudo-element :after and got '10px 20px 30px 40px'
+PASS Expected '250px' for height in the computed style for e

[webkit-changes] [109818] trunk

[alexis . menard]

Title: [109818] trunk








Revision 109818
Author alexis.men...@openbossa.org
Date 2012-03-05 16:51:37 -0800 (Mon, 05 Mar 2012)


Log Message
getComputedStyle gives incorrect information for 'height' property
https://bugs.webkit.org/show_bug.cgi?id=33593

Reviewed by David Hyatt.

Source/WebCore:

Make sure that the contentBoxRect doesn't take into account the
intrinsic padding when querying it. As stated by http://www.w3.org/TR/css3-box/#the-lsquo0
the height is the content area which doesn't include the intrinsic padding, the border, and
the padding.

Test: fast/css/getComputedStyle/getComputedStyle-height.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode):
* rendering/RenderBox.h:
(WebCore::RenderBox::contentBoxRect):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
(WebCore::RenderTableCell::cellBaselinePosition):
* rendering/RenderTableCell.h:
(RenderTableCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstLineBoxBaseline):

LayoutTests:

Make sure that the contentBoxRect doesn't take into account the
intrinsic padding.

* fast/css/getComputedStyle/getComputedStyle-height-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-height.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderTableCell.cpp
trunk/Source/WebCore/rendering/RenderTableCell.h
trunk/Source/WebCore/rendering/RenderTableSection.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height.html




Diff

Modified: trunk/LayoutTests/ChangeLog (109817 => 109818)

--- trunk/LayoutTests/ChangeLog	2012-03-06 00:47:10 UTC (rev 109817)
+++ trunk/LayoutTests/ChangeLog	2012-03-06 00:51:37 UTC (rev 109818)
@@ -1,3 +1,16 @@
+2012-03-05  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle gives incorrect information for 'height' property
+https://bugs.webkit.org/show_bug.cgi?id=33593
+
+Reviewed by David Hyatt.
+
+Make sure that the contentBoxRect doesn't take into account the
+intrinsic padding.
+
+* fast/css/getComputedStyle/getComputedStyle-height-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-height.html: Added.
+
 2012-03-05  Robert Kroeger  rjkro...@chromium.org
 
 Correct a test to work the same on Gtk and non-Gtk chromium in


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height-expected.txt (0 => 109818)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height-expected.txt	2012-03-06 00:51:37 UTC (rev 109818)
@@ -0,0 +1,10 @@
+Test the computed height of a cell : https://bugs.webkit.org/show_bug.cgi?id=33593.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('height') is '200px'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height.html (0 => 109818)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height.html	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-height.html	2012-03-06 00:51:37 UTC (rev 109818)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+style type=text/css
+table td {
+padding: 20px;
+border: 10px solid blue;
+}
+
+#cell1 {
+height: 200px;
+}
+/style
+script src=""
+/head
+body
+table border=0 cellspacing=0 cellpadding=0 id=ta

[webkit-changes] [109134] trunk

[alexis . menard]

Title: [109134] trunk








Revision 109134
Author alexis.men...@openbossa.org
Date 2012-02-28 11:55:39 -0800 (Tue, 28 Feb 2012)


Log Message
getComputedStyle fails for 'first-line' pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=57505

Reviewed by Tony Chang.

Source/WebCore:

Querying the selector with a pseudo-element using getComputedStyle should work
even if the selector was not declared in the stylesheet. When not declared, we need
to use the RenderStyle created to do the rendering as there is no pseudo-style.
This match the behavior of Firefox.

No new tests : Updated expectation and extended getComputedStyle-with-pseudo-element.html.

* dom/Element.cpp:
(WebCore::Element::computedStyle):

LayoutTests:

Update expected results to the new behavior. Also added some extra checks on
other pseudo-elements.

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (109133 => 109134)

--- trunk/LayoutTests/ChangeLog	2012-02-28 19:52:54 UTC (rev 109133)
+++ trunk/LayoutTests/ChangeLog	2012-02-28 19:55:39 UTC (rev 109134)
@@ -1,3 +1,16 @@
+2012-02-28  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle fails for 'first-line' pseudo-element
+https://bugs.webkit.org/show_bug.cgi?id=57505
+
+Reviewed by Tony Chang.
+
+Update expected results to the new behavior. Also added some extra checks on
+other pseudo-elements.
+
+* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:
+
 2012-02-28  Alexey Proskuryakov  a...@apple.com
 
 FileReader crashes when file is not readable


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt (109133 => 109134)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt	2012-02-28 19:52:54 UTC (rev 109133)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt	2012-02-28 19:55:39 UTC (rev 109134)
@@ -17,6 +17,9 @@
 PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testBeforeAfter and pseudo-element :before and got 'rgb(165, 42, 42)'
 PASS Expected 'rgb(0, 0, 255)' for color in the computed style for element with id testBeforeAfter and pseudo-element :after and got 'rgb(0, 0, 255)'
 PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element null and got 'rgb(165, 42, 42)'
-PASS Expected '' for color in the computed style for element with id testNoPseudoElement and pseudo-element :first-line and got ''
+PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element :first-line and got 'rgb(165, 42, 42)'
+PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element :first-letter and got 'rgb(165, 42, 42)'
+PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element :before and got 'rgb(165, 42, 42)'
+PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element :after and got 'rgb(165, 42, 42)'
 PASS Expected 'rgb(165, 42, 42)' for color in the computed style for element with id testNoPseudoElement and pseudo-element :garbage and got 'rgb(165, 42, 42)'
 PASS Expected '0.5' for opacity in the computed style for element with id testHardwareAcceleratedCompositing and pseudo-element :before and got '0.5'


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html (109133 => 109134)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html	2012-02-28 19:52:54 UTC (rev 109133)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html	2012-02-28 19:55:39 UTC (rev 109134)
@@ -67,7 +67,10 @@
 { 'elementId' : 'testBeforeAfter', 'pseudoElement' : ':before', 'property' : 'color', 'expectedValue' : 'rgb(165, 42, 42)' },
 { 'elementId' : 'testBeforeAfter', 'pseudoElement' : ':after', 'property' : 'color', 'expectedValue' : 'rgb(0, 0, 255)' },
 { 'elementId' : 'testNoPseudoElement', 'pseudoElement' : null, 'property' : 'color', 'expectedValue' : 'rgb(165, 42, 42)' },
-{ 'elementId' : 'testNoPseudoElement', 'pseudoElement' : ':first-line', 'property' : 'color', 'expe

[webkit-changes] [108784] trunk/Source/WebCore

[alexis . menard]

Title: [108784] trunk/Source/WebCore








Revision 108784
Author alexis.men...@openbossa.org
Date 2012-02-24 06:16:55 -0800 (Fri, 24 Feb 2012)


Log Message
Little optimization in CSSParser::parseShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79356

Reviewed by Tony Chang.

Remove one loop by initializing array values at declaration time.
Also early return when the number of properties parsed are equals
with longhands count of the shorthand. It happens to be very often
the case (e.g. border). Instruments shows an improvement from 19ms
to 17ms on the time spent in this function for the css-parser-yui
benchmark.

No new tests : refactor, exisiting ones should cover.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseShorthand):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (108783 => 108784)

--- trunk/Source/WebCore/ChangeLog	2012-02-24 14:09:11 UTC (rev 108783)
+++ trunk/Source/WebCore/ChangeLog	2012-02-24 14:16:55 UTC (rev 108784)
@@ -1,3 +1,22 @@
+2012-02-24  Alexis Menard  alexis.men...@openbossa.org
+
+Little optimization in CSSParser::parseShorthand.
+https://bugs.webkit.org/show_bug.cgi?id=79356
+
+Reviewed by Tony Chang.
+
+Remove one loop by initializing array values at declaration time.
+Also early return when the number of properties parsed are equals
+with longhands count of the shorthand. It happens to be very often
+the case (e.g. border). Instruments shows an improvement from 19ms
+to 17ms on the time spent in this function for the css-parser-yui
+benchmark.
+
+No new tests : refactor, exisiting ones should cover.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseShorthand):
+
 2012-02-24  Kentaro Hara  hara...@chromium.org
 
 Move HTML-related APIs from DOMWindow.idl to DOMWindowHTML.idl


Modified: trunk/Source/WebCore/css/CSSParser.cpp (108783 => 108784)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-02-24 14:09:11 UTC (rev 108783)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-02-24 14:16:55 UTC (rev 108784)
@@ -2678,16 +2678,15 @@
 ShorthandScope scope(this, propId);
 
 bool found = false;
-bool fnd[6]; // Trust me ;)
-for (int i = 0; i  numProperties; i++)
-fnd[i] = false;
+int propertiesParsed = 0;
+bool fnd[6]= { false, false, false, false, false, false }; // 6 is enough size.
 
 while (m_valueList-current()) {
 found = false;
 for (int propIndex = 0; !found  propIndex  numProperties; ++propIndex) {
-if (!fnd[propIndex]) {
-if (parseValue(properties[propIndex], important))
+if (!fnd[propIndex]  parseValue(properties[propIndex], important)) {
 fnd[propIndex] = found = true;
+propertiesParsed++;
 }
 }
 
@@ -2697,6 +2696,9 @@
 return false;
 }
 
+if (propertiesParsed == numProperties)
+return true;
+
 // Fill in any remaining properties with the initial value.
 ImplicitScope implicitScope(this, PropertyImplicit);
 for (int i = 0; i  numProperties; ++i) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108365] trunk/Source/WebCore

[alexis . menard]

Title: [108365] trunk/Source/WebCore








Revision 108365
Author alexis.men...@openbossa.org
Date 2012-02-21 09:35:17 -0800 (Tue, 21 Feb 2012)


Log Message
Little optimization for CSSParser::parseFillShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79042

Reviewed by Hajime Morita.

Remove one extra loop that we can combine with the following one
which adds the properties to the parser's list of properties. I also
removed a useless check.
Instruments shows on the css-parser-yui benchmark an improvement
of 13ms (from 77ms spent in the function to 64ms).

No new tests : refactoring, existings tests should cover.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (108364 => 108365)

--- trunk/Source/WebCore/ChangeLog	2012-02-21 17:17:43 UTC (rev 108364)
+++ trunk/Source/WebCore/ChangeLog	2012-02-21 17:35:17 UTC (rev 108365)
@@ -1,3 +1,21 @@
+2012-02-21  Alexis Menard  alexis.men...@openbossa.org
+
+Little optimization for CSSParser::parseFillShorthand.
+https://bugs.webkit.org/show_bug.cgi?id=79042
+
+Reviewed by Hajime Morita.
+
+Remove one extra loop that we can combine with the following one
+which adds the properties to the parser's list of properties. I also
+removed a useless check.
+Instruments shows on the css-parser-yui benchmark an improvement
+of 13ms (from 77ms spent in the function to 64ms).
+
+No new tests : refactoring, existings tests should cover.
+
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseFillShorthand):
+
 2012-02-20  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=79046


Modified: trunk/Source/WebCore/css/CSSParser.cpp (108364 => 108365)

--- trunk/Source/WebCore/css/CSSParser.cpp	2012-02-21 17:17:43 UTC (rev 108364)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-02-21 17:35:17 UTC (rev 108365)
@@ -2481,23 +2481,20 @@
 return false;
 }
 
-// Fill in any remaining properties with the initial value.
-for (i = 0; i  numProperties; ++i) {
+// Now add all of the properties we found.
+for (i = 0; i  numProperties; i++) {
+// Fill in any remaining properties with the initial value.
 if (!parsedProperty[i]) {
 addFillValue(values[i], cssValuePool()-createImplicitInitialValue());
 if (properties[i] == CSSPropertyBackgroundPosition || properties[i] == CSSPropertyWebkitMaskPosition)
 addFillValue(positionYValue, cssValuePool()-createImplicitInitialValue());
 if (properties[i] == CSSPropertyBackgroundRepeat || properties[i] == CSSPropertyWebkitMaskRepeat)
 addFillValue(repeatYValue, cssValuePool()-createImplicitInitialValue());
-if ((properties[i] == CSSPropertyBackgroundOrigin || properties[i] == CSSPropertyWebkitMaskOrigin)  !parsedProperty[i]) {
+if ((properties[i] == CSSPropertyBackgroundOrigin || properties[i] == CSSPropertyWebkitMaskOrigin)) {
 // If background-origin wasn't present, then reset background-clip also.
 addFillValue(clipValue, cssValuePool()-createImplicitInitialValue());
 }
 }
-}
-
-// Now add all of the properties we found.
-for (i = 0; i  numProperties; i++) {
 if (properties[i] == CSSPropertyBackgroundPosition) {
 addProperty(CSSPropertyBackgroundPositionX, values[i].release(), important);
 // it's OK to call positionYValue.release() since we only see CSSPropertyBackgroundPosition once






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107728] trunk

[alexis . menard]

Title: [107728] trunk








Revision 107728
Author alexis.men...@openbossa.org
Date 2012-02-14 13:00:24 -0800 (Tue, 14 Feb 2012)


Log Message
font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181

Reviewed by Tony Chang.

Source/WebCore:

As stated in http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.

Test: fast/css/font-shorthand-mix-inherit.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):

LayoutTests:

* fast/css/font-shorthand-mix-inherit-expected.txt: Added.
* fast/css/font-shorthand-mix-inherit.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp


Added Paths

trunk/LayoutTests/fast/css/font-shorthand-mix-inherit-expected.txt
trunk/LayoutTests/fast/css/font-shorthand-mix-inherit.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107727 => 107728)

--- trunk/LayoutTests/ChangeLog	2012-02-14 20:47:45 UTC (rev 107727)
+++ trunk/LayoutTests/ChangeLog	2012-02-14 21:00:24 UTC (rev 107728)
@@ -1,3 +1,13 @@
+2012-02-14  Alexis Menard  alexis.men...@openbossa.org
+
+font shorthand with inherit keyword incorrectly parsed and rendered
+https://bugs.webkit.org/show_bug.cgi?id=20181
+
+Reviewed by Tony Chang.
+
+* fast/css/font-shorthand-mix-inherit-expected.txt: Added.
+* fast/css/font-shorthand-mix-inherit.html: Added.
+
 2012-02-14  Abhishek Arya  infe...@chromium.org
 
 Crash due to incorrect firing of mutation event during class attribute parsing.


Added: trunk/LayoutTests/fast/css/font-shorthand-mix-inherit-expected.txt (0 => 107728)

--- trunk/LayoutTests/fast/css/font-shorthand-mix-inherit-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/font-shorthand-mix-inherit-expected.txt	2012-02-14 21:00:24 UTC (rev 107728)
@@ -0,0 +1,20 @@
+Test for WebKit bug 20181 : font shorthand with inherit keyword incorrectly parsed and rendered
+
+PASS test.style.getPropertyValue('font') is '12pt/14pt sans-serif'
+PASS test.style.getPropertyValue('font') is 'inherit'
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS test.style.getPropertyValue('font') is ''
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/font-shorthand-mix-inherit.html (0 => 107728)

--- trunk/LayoutTests/fast/css/font-shorthand-mix-inherit.html	(rev 0)
+++ trunk/LayoutTests/fast/css/font-shorthand-mix-inherit.html	2012-02-14 21:00:24 UTC (rev 107728)
@@ -0,0 +1,56 @@
+!DOCTYPE HTML
+html
+head
+titleTest for WebKit bug 20181 : font shorthand with inherit keyword incorrectly parsed and rendered/title
+script src=""
+/head
+body
+p id=descriptionTest for WebKit bug a href="" : font shorthand with inherit keyword incorrectly parsed and rendered/p
+div id=console/div
+
+div id=tests_container
+
+div id=test/div
+
+/div
+
+script
+var test = document.getElementById(test);
+
+// Sanity check.
+test.style.font = 12pt/14pt sans-serif;
+shouldBe(test.style.getPropertyValue('font'), '12pt/14pt sans-serif');
+test.style.font = ;
+test.style.font = inherit;
+shouldBe(test.style.getPropertyValue('font'), 'inherit');
+test.style.font = ;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = 12pt/14pt inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = 12pt/14pt bold inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = italic 12pt/14pt bold inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = italic 12pt/14pt bold arial inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = x-large/110% 'new century schoolbook', serif, inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font =  'inherit';
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = italic inherit 12pt/14pt bold arial inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = arial inherit;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.style.font = Arial, Helvetica, inherit, sans-serif;;
+shouldBe(test.style.getPropertyValue('font'), '');
+test.sty

[webkit-changes] [106672] trunk

[alexis . menard]

Title: [106672] trunk








Revision 106672
Author alexis.men...@openbossa.org
Date 2012-02-03 10:21:22 -0800 (Fri, 03 Feb 2012)


Log Message
REGRESSION (r105401-105403): Blue flash on css border transition
https://bugs.webkit.org/show_bug.cgi?id=77491

Reviewed by Simon Fraser.

Source/WebCore:

The new blend function added with r105403 takes unsigned as parameters therefore
we have to be careful to not overflow in case the to is less than from (animating
from 400 to 0 for example).

Test: animations/animation-border-overflow.html

* platform/animation/AnimationUtilities.h:
(WebCore::blend):

LayoutTests:

* animations/animation-border-overflow-expected.txt: Added.
* animations/animation-border-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/animation/AnimationUtilities.h


Added Paths

trunk/LayoutTests/animations/animation-border-overflow-expected.txt
trunk/LayoutTests/animations/animation-border-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106671 => 106672)

--- trunk/LayoutTests/ChangeLog	2012-02-03 18:02:42 UTC (rev 106671)
+++ trunk/LayoutTests/ChangeLog	2012-02-03 18:21:22 UTC (rev 106672)
@@ -1,3 +1,13 @@
+2012-02-03  Alexis Menard  alexis.men...@openbossa.org
+
+REGRESSION (r105401-105403): Blue flash on css border transition
+https://bugs.webkit.org/show_bug.cgi?id=77491
+
+Reviewed by Simon Fraser.
+
+* animations/animation-border-overflow-expected.txt: Added.
+* animations/animation-border-overflow.html: Added.
+
 2012-02-03  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt][WK2] Incorrect line number dumping


Added: trunk/LayoutTests/animations/animation-border-overflow-expected.txt (0 => 106672)

--- trunk/LayoutTests/animations/animation-border-overflow-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/animation-border-overflow-expected.txt	2012-02-03 18:21:22 UTC (rev 106672)
@@ -0,0 +1,3 @@
+This test performs an animation of the border-top-width property from a given value to 0. It tests if an intermediate value is correct.
+PASS - border-top-width property for box element at 0.1s saw something close to: 200
+


Added: trunk/LayoutTests/animations/animation-border-overflow.html (0 => 106672)

--- trunk/LayoutTests/animations/animation-border-overflow.html	(rev 0)
+++ trunk/LayoutTests/animations/animation-border-overflow.html	2012-02-03 18:21:22 UTC (rev 106672)
@@ -0,0 +1,40 @@
+html
+head
+titleUnfilled Animation Test/title
+style type=text/css media=screen
+#box {
+height: 100px;
+width: 100px;
+border-top-width: 300px;
+border-style: solid;
+-webkit-animation-duration: 1s;
+-webkit-animation-timing-function: ease-in-out;
+-webkit-animation-name: anim;
+}
+@-webkit-keyframes anim {
+from { border-top-width: 200px; }
+to   { border-top-width: 0px; }
+}
+
+/style
+script src="" type=text/_javascript_ charset=utf-8/script
+script type=text/_javascript_ charset=utf-8
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+const expectedValues = [
+  // [animation-name, time, element-id, property, expected-value, tolerance]
+  [anim, 0.1, box, border-top-width, 200, 20],
+];
+
+runAnimationTest(expectedValues);
+/script
+/head
+body
+This test performs an animation of the border-top-width property from a given value to 0. It tests if an intermediate value is correct.
+div id=box
+/div
+div id=result
+/div
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (106671 => 106672)

--- trunk/Source/WebCore/ChangeLog	2012-02-03 18:02:42 UTC (rev 106671)
+++ trunk/Source/WebCore/ChangeLog	2012-02-03 18:21:22 UTC (rev 106672)
@@ -1,3 +1,19 @@
+2012-02-03  Alexis Menard  alexis.men...@openbossa.org
+
+REGRESSION (r105401-105403): Blue flash on css border transition
+https://bugs.webkit.org/show_bug.cgi?id=77491
+
+Reviewed by Simon Fraser.
+
+The new blend function added with r105403 takes unsigned as parameters therefore
+we have to be careful to not overflow in case the to is less than from (animating
+from 400 to 0 for example).
+
+Test: animations/animation-border-overflow.html
+
+* platform/animation/AnimationUtilities.h:
+(WebCore::blend):
+
 2012-02-03  Justin Novosad  ju...@chromium.org
 
 [Chromium] ImageBufferSkia: remove unnecessary overload of flush in


Modified: trunk/Source/WebCore/platform/animation/AnimationUtilities.h (106671 => 106672)

--- trunk/Source/WebCore/platform/animation/AnimationUtilities.h	2012-02-03 18:02:42 UTC (rev 106671)
+++ trunk/Source/WebCore/platform/animation/AnimationUtilities.h	2012-02-03 18:21:22 UTC (rev 106672)
@@ -37,7 +37,7 @@
 
 inline unsigned blend(unsigned from, unsigned to, double progress)
 {
-return static_castunsigned(lrou

[webkit-changes] [106490] trunk

[alexis . menard]

Title: [106490] trunk








Revision 106490
Author alexis.men...@openbossa.org
Date 2012-02-01 13:48:23 -0800 (Wed, 01 Feb 2012)


Log Message
CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
https://bugs.webkit.org/show_bug.cgi?id=49058

Reviewed by Andreas Kling.

Source/WebCore:

CSSMutableStyleDeclaration::getPropertyPriority was not handling shorthands properly. Shorthands are
not part of the property list of the style so we need to query the longhands which are the one added
in the list. Only if the longhands have equal priority the shorthand priority is known. I also renamed
getPropertyPriority (not the CSSOM exposed method) to something more consistent with WebKit naming guidelines.

Test: fast/css/shorthand-priority.html

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::propertyIsImportant):
(WebCore::CSSMutableStyleDeclaration::addParsedProperty):
(WebCore::CSSMutableStyleDeclaration::getPropertyPriority):
* css/CSSMutableStyleDeclaration.h:
(CSSMutableStyleDeclaration):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::EditingStyle::collapseTextDecorationProperties):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::setTextDecorationProperty):
* editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):

Source/WebKit/qt:

Update the code as getPropertyPriority has been renamed to propertyIsImportant.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):

LayoutTests:

* fast/css/shorthand-priority-expected.txt: Added.
* fast/css/shorthand-priority.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSMutableStyleDeclaration.h
trunk/Source/WebCore/editing/EditingStyle.cpp
trunk/Source/WebCore/editing/RemoveCSSPropertyCommand.cpp
trunk/Source/WebKit/qt/Api/qwebelement.cpp
trunk/Source/WebKit/qt/ChangeLog


Added Paths

trunk/LayoutTests/fast/css/shorthand-priority-expected.txt
trunk/LayoutTests/fast/css/shorthand-priority.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106489 => 106490)

--- trunk/LayoutTests/ChangeLog	2012-02-01 21:46:51 UTC (rev 106489)
+++ trunk/LayoutTests/ChangeLog	2012-02-01 21:48:23 UTC (rev 106490)
@@ -1,3 +1,13 @@
+2012-02-01  Alexis Menard  alexis.men...@openbossa.org
+
+CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
+https://bugs.webkit.org/show_bug.cgi?id=49058
+
+Reviewed by Andreas Kling.
+
+* fast/css/shorthand-priority-expected.txt: Added.
+* fast/css/shorthand-priority.html: Added.
+
 2012-02-01  Ryosuke Niwa  rn...@webkit.org
 
 Crash in EventHandler::updateDragAndDrop


Added: trunk/LayoutTests/fast/css/shorthand-priority-expected.txt (0 => 106490)

--- trunk/LayoutTests/fast/css/shorthand-priority-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/shorthand-priority-expected.txt	2012-02-01 21:48:23 UTC (rev 106490)
@@ -0,0 +1,15 @@
+Tests that querying the priority for a shorthand works.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS e.style.getPropertyValue('border-bottom-style') is 'solid'
+PASS e.style.getPropertyPriority('border-bottom-style') is 'important'
+PASS e.style.getPropertyValue('border') is '20px solid green'
+PASS e.style.getPropertyPriority('border') is ''
+PASS e.style.getPropertyValue('border') is '20px solid green'
+PASS e.style.getPropertyPriority('border') is 'important'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/shorthand-priority.html (0 => 106490)

--- trunk/LayoutTests/fast/css/shorthand-priority.html	(rev 0)
+++ trunk/LayoutTests/fast/css/shorthand-priority.html	2012-02-01 21:48:23 UTC (rev 106490)
@@ -0,0 +1,38 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body
+script
+
+description(Tests that querying the priority for a shorthand works.);
+
+var testContainer = document.createElement(div);
+document.body.appendChild(testContainer);
+
+testContainer.innerHTML = 'div id=testhello/div';
+
+e = document.getElementById('test');
+
+// Sanity check.
+e.style.setProperty(border-bottom-style, solid, !important);
+shouldBe(e.style.getPropertyValue('border-bottom-style'), 'solid');
+shouldBe(e.style.getPropertyPriority('border-bottom-style'), 'important');
+
+e.style.borderBottomStyle = ;
+e.style.border = 20px solid green;
+shouldBe(e.style.getPropertyValue('border'), '20px solid green');
+shouldBe(e.style.getPropertyPriority('border'), '');
+
+e.style.border = ;
+e.style.setProperty(border, 20px solid green, !important);
+shouldBe(e.style.getPropertyValue('border'), '20px solid green');
+shouldBe(e.style.getPropertyPriority('border'), 'important');
+
+docume

[webkit-changes] [106364] trunk/Source/WebCore

[alexis . menard]

Title: [106364] trunk/Source/WebCore








Revision 106364
Author alexis.men...@openbossa.org
Date 2012-01-31 09:29:00 -0800 (Tue, 31 Jan 2012)


Log Message
Unreviewed include cleanup.

Tested locally on Qt and Chromium port.

* dom/Node.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106363 => 106364)

--- trunk/Source/WebCore/ChangeLog	2012-01-31 17:11:45 UTC (rev 106363)
+++ trunk/Source/WebCore/ChangeLog	2012-01-31 17:29:00 UTC (rev 106364)
@@ -1,3 +1,11 @@
+2012-01-31  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed include cleanup.
+
+Tested locally on Qt and Chromium port.
+
+* dom/Node.cpp:
+
 2012-01-31  Arko Saha  a...@motorola.com
 
 The spec renamed addTrack() to addTextTrack().


Modified: trunk/Source/WebCore/dom/Node.cpp (106363 => 106364)

--- trunk/Source/WebCore/dom/Node.cpp	2012-01-31 17:11:45 UTC (rev 106363)
+++ trunk/Source/WebCore/dom/Node.cpp	2012-01-31 17:29:00 UTC (rev 106364)
@@ -93,8 +93,6 @@
 #include TreeScopeAdopter.h
 #include UIEvent.h
 #include UIEventWithKeyState.h
-#include WebKitAnimationEvent.h
-#include WebKitTransitionEvent.h
 #include WheelEvent.h
 #include WindowEventContext.h
 #include XMLNames.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106282] trunk/Tools

[alexis . menard]

Title: [106282] trunk/Tools








Revision 106282
Author alexis.men...@openbossa.org
Date 2012-01-30 13:15:38 -0800 (Mon, 30 Jan 2012)


Log Message
Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (106281 => 106282)

--- trunk/Tools/ChangeLog	2012-01-30 21:11:48 UTC (rev 106281)
+++ trunk/Tools/ChangeLog	2012-01-30 21:15:38 UTC (rev 106282)
@@ -1,3 +1,9 @@
+2012-01-30  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2012-01-30  Gavin Barraclough  barraclo...@apple.com
 
 Unreviewed build fix following bug#76855


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (106281 => 106282)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-01-30 21:11:48 UTC (rev 106281)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-01-30 21:15:38 UTC (rev 106282)
@@ -143,7 +143,7 @@
 ChromiumPublicApi: [ fi...@chromium.org, ],
 AppleMacPublicApi: [ timo...@apple.com ],
 Forms: [ tk...@chromium.org, ],
-GStreamerGraphics: [ pnorm...@igalia.com, g...@gnome.org ],
+GStreamerGraphics: [ alexis.men...@openbossa.org, pnorm...@igalia.com, g...@gnome.org ],
 WebIDL: [ aba...@webkit.org, o...@chromium.org ],
 StyleChecker: [ le...@chromium.org, ],
 ThreadingFiles|ThreadingUsage: [ levin+thread...@chromium.org, ],
@@ -156,9 +156,9 @@
 TestFailures: [ aba...@webkit.org, dglaz...@chromium.org ],
 GtkWebKit2PublicAPI: [ cgar...@igalia.com, g...@gnome.org ],
 QtBuildSystem : [ ves...@webkit.org, ],
-QtWebKit2PublicAPI: [ zol...@webkit.org, ],
-QtWebKit2PlatformSpecific: [ zol...@webkit.org, ],
-CSS: [ macpher...@chromium.org, ],
+QtWebKit2PublicAPI: [ alexis.men...@openbossa.org, zol...@webkit.org, ],
+QtWebKit2PlatformSpecific: [ alexis.men...@openbossa.org, zol...@webkit.org, ],
+CSS: [ alexis.men...@openbossa.org, macpher...@chromium.org, ],
 EFL: [ k...@profusion.mobi, ],
 CMake: [ k...@profusion.mobi, ],
 SoupNetwork: [ k...@profusion.mobi, ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105898] trunk

[alexis . menard]

Title: [105898] trunk








Revision 105898
Author alexis.men...@openbossa.org
Date 2012-01-25 10:54:40 -0800 (Wed, 25 Jan 2012)


Log Message
border-image should not crash when the source is not specified.
https://bugs.webkit.org/show_bug.cgi?id=77001

Reviewed by Andreas Kling.

Source/WebCore:

This bug was introduced by r105502 but was exposed by r105738.
The image-source of a border-image is not mandatory therefore it
may happen that you have no value set for it. WebCore::createBorderImageValue
was wrongly assuming that the image is always set. This problem also required a bit
of refactoring in CSSStyleSelector::mapNinePieceImage to take into account that
the image could be optional (just like other properties).

Test: fast/css/border-image-null-image-crash.html

* css/CSSBorderImage.cpp:
(WebCore::createBorderImageValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Add a new test to cover this crash specifically.

* fast/css/border-image-null-image-crash-expected.txt: Added.
* fast/css/border-image-null-image-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSBorderImage.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp


Added Paths

trunk/LayoutTests/fast/css/border-image-null-image-crash-expected.txt
trunk/LayoutTests/fast/css/border-image-null-image-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (105897 => 105898)

--- trunk/LayoutTests/ChangeLog	2012-01-25 18:38:34 UTC (rev 105897)
+++ trunk/LayoutTests/ChangeLog	2012-01-25 18:54:40 UTC (rev 105898)
@@ -1,3 +1,15 @@
+2012-01-25  Alexis Menard  alexis.men...@openbossa.org
+
+border-image should not crash when the source is not specified.
+https://bugs.webkit.org/show_bug.cgi?id=77001
+
+Reviewed by Andreas Kling.
+
+Add a new test to cover this crash specifically.
+
+* fast/css/border-image-null-image-crash-expected.txt: Added.
+* fast/css/border-image-null-image-crash.html: Added.
+
 2012-01-25  Tony Chang  t...@chromium.org
 
 Unreviewed, only skip scrollbars/scroll-rtl-or-bt-layer.html on qt-wk2.


Added: trunk/LayoutTests/fast/css/border-image-null-image-crash-expected.txt (0 => 105898)

--- trunk/LayoutTests/fast/css/border-image-null-image-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/border-image-null-image-crash-expected.txt	2012-01-25 18:54:40 UTC (rev 105898)
@@ -0,0 +1,10 @@
+Tests that shorthand border-image with a null image doesn't crash.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-image') is 'none'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/border-image-null-image-crash.html (0 => 105898)

--- trunk/LayoutTests/fast/css/border-image-null-image-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/border-image-null-image-crash.html	2012-01-25 18:54:40 UTC (rev 105898)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body
+script
+
+description(Tests that shorthand border-image with a null image doesn't crash.);
+
+var testContainer = document.createElement(div);
+document.body.appendChild(testContainer);
+
+testContainer.innerHTML = 'div id=testhello/div';
+
+e = document.getElementById('test');
+computedStyle = window.getComputedStyle(e, null);
+e.style.borderImage = 10% fill;
+
+shouldBe(computedStyle.getPropertyValue('border-image'), 'none');
+
+document.body.removeChild(testContainer);
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (105897 => 105898)

--- trunk/Source/WebCore/ChangeLog	2012-01-25 18:38:34 UTC (rev 105897)
+++ trunk/Source/WebCore/ChangeLog	2012-01-25 18:54:40 UTC (rev 105898)
@@ -1,3 +1,24 @@
+2012-01-25  Alexis Menard  alexis.men...@openbossa.org
+
+border-image should not crash when the source is not specified.
+https://bugs.webkit.org/show_bug.cgi?id=77001
+
+Reviewed by Andreas Kling.
+
+This bug was introduced by r105502 but was exposed by r105738.
+The image-source of a border-image is not mandatory therefore it
+may happen that you have no value set for it. WebCore::createBorderImageValue
+was wrongly assuming that the image is always set. This problem also required a bit
+of refactoring in CSSStyleSelector::mapNinePieceImage to take into account that
+the image could be optional (just like other properties).
+
+Test: fast/css/border-image-null-image-crash.html
+
+* css/CSSBorderImage.cpp:
+(WebCore::createBorderImageValue):
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::mapNinePieceImage):
+
 2012-01-25  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Implement tap feedback respecting -webki

[webkit-changes] [105901] trunk

[alexis . menard]

Title: [105901] trunk








Revision 105901
Author alexis.men...@openbossa.org
Date 2012-01-25 11:11:10 -0800 (Wed, 25 Jan 2012)


Log Message
border-image should be implemented like a shorthand.
https://bugs.webkit.org/show_bug.cgi?id=76697

Reviewed by Tony Chang.

Source/WebCore:

Make sure that border-image is implemented like a shorthand : when we parse
it we set the correct value to its longhands. The code was not doing it
previously as we inherited the old implementation of -webkit-border-image which
is not a shorthand but a regular property. It will then increase
style.length for a given element as we now expand the longhands.
The behavior stays the same for -webkit-border-image.

Test: fast/css/border-image-style-length.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::commitWebKitBorderImage):
(WebCore::BorderImageParseContext::commitBorderImage):
(BorderImageParseContext):
(WebCore::BorderImageParseContext::commitBorderImageProperty):
(WebCore::CSSParser::parseBorderImage):
* css/CSSParser.h:
():
* css/CSSPropertyLonghand.cpp:
(WebCore::initShorthandMap):
* css/CSSStyleApplyProperty.cpp:
():
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImage):
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::ensurePropertyMap):
(WebCore::addShorthandProperties):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::borderImageSlices):
(WebCore::RenderStyleBitfields::borderImageWidth):
(WebCore::RenderStyleBitfields::borderImageOutset):
(RenderStyleBitfields):
(WebCore::RenderStyleBitfields::setBorderImageSlices):
(WebCore::RenderStyleBitfields::setBorderImageWidth):
(WebCore::RenderStyleBitfields::setBorderImageOutset):

LayoutTests:

Make sure we cover that border-image correctly expands its longhands.

* fast/css/border-image-style-length-expected.txt: Added.
* fast/css/border-image-style-length.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h
trunk/Source/WebCore/css/CSSPropertyLonghand.cpp
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/page/animation/AnimationBase.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/fast/css/border-image-style-length-expected.txt
trunk/LayoutTests/fast/css/border-image-style-length.html




Diff

Modified: trunk/LayoutTests/ChangeLog (105900 => 105901)

--- trunk/LayoutTests/ChangeLog	2012-01-25 19:04:10 UTC (rev 105900)
+++ trunk/LayoutTests/ChangeLog	2012-01-25 19:11:10 UTC (rev 105901)
@@ -1,3 +1,15 @@
+2012-01-25  Alexis Menard  alexis.men...@openbossa.org
+
+border-image should be implemented like a shorthand.
+https://bugs.webkit.org/show_bug.cgi?id=76697
+
+Reviewed by Tony Chang.
+
+Make sure we cover that border-image correctly expands its longhands.
+
+* fast/css/border-image-style-length-expected.txt: Added.
+* fast/css/border-image-style-length.html: Added.
+
 2012-01-24  MORITA Hajime  morr...@google.com
 
 [Refactoring][Internals] Should have InternalSettings


Added: trunk/LayoutTests/fast/css/border-image-style-length-expected.txt (0 => 105901)

--- trunk/LayoutTests/fast/css/border-image-style-length-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/border-image-style-length-expected.txt	2012-01-25 19:11:10 UTC (rev 105901)
@@ -0,0 +1,12 @@
+Test the style.length of an element with a border-image.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS e.style.length is 5
+PASS e.style.length is 0
+PASS e.style.length is 1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/border-image-style-length.html (0 => 105901)

--- trunk/LayoutTests/fast/css/border-image-style-length.html	(rev 0)
+++ trunk/LayoutTests/fast/css/border-image-style-length.html	2012-01-25 19:11:10 UTC (rev 105901)
@@ -0,0 +1,29 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body
+script
+
+description(Test the style.length of an element with a border-image.)
+
+var testContainer = document.createElement(div);
+document.body.appendChild(testContainer);
+
+testContainer.innerHTML = 'div id=testhello/div';
+
+e = document.getElementById('test');
+e.style.borderImage = url(dummy://test.png) 10 / 13px 1.5em 1em 10px;
+shouldBe(e.style.length, 5);
+e.style.borderImage = ;
+shouldBe(e.style.length, 0);
+e.style.webkitBorderImage = u

[webkit-changes] [105762] trunk/Source/WebKit2

[alexis . menard]

Title: [105762] trunk/Source/WebKit2








Revision 105762
Author alexis.men...@openbossa.org
Date 2012-01-24 11:26:14 -0800 (Tue, 24 Jan 2012)


Log Message
Unreviewed build fix for Qt.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (105761 => 105762)

--- trunk/Source/WebKit2/ChangeLog	2012-01-24 19:25:00 UTC (rev 105761)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-24 19:26:14 UTC (rev 105762)
@@ -1,3 +1,11 @@
+2012-01-24  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed build fix for Qt.
+
+* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
+(WebKit::LayerTreeHostQt::showDebugBorders):
+(WebKit::LayerTreeHostQt::showRepaintCounter):
+
 2012-01-23  Simon Fraser  simon.fra...@apple.com
 
 Show layer borders for scrollbar layers


Modified: trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp (105761 => 105762)

--- trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-01-24 19:25:00 UTC (rev 105761)
+++ trunk/Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp	2012-01-24 19:26:14 UTC (rev 105762)
@@ -371,12 +371,12 @@
 }
 }
 
-bool LayerTreeHostQt::showDebugBorders() const
+bool LayerTreeHostQt::showDebugBorders(const WebCore::GraphicsLayer*) const
 {
 return m_webPage-corePage()-settings()-showDebugBorders();
 }
 
-bool LayerTreeHostQt::showRepaintCounter() const
+bool LayerTreeHostQt::showRepaintCounter(const WebCore::GraphicsLayer*) const
 {
 return m_webPage-corePage()-settings()-showRepaintCounter();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105403] trunk

[alexis . menard]

Title: [105403] trunk








Revision 105403
Author alexis.men...@openbossa.org
Date 2012-01-19 04:59:52 -0800 (Thu, 19 Jan 2012)


Log Message
Strange Result for getComputedStyle on borderWidth set in em
https://bugs.webkit.org/show_bug.cgi?id=18294

Reviewed by Tony Chang.

Source/WebCore:

BorderValue stores its width on a 12 bits unsigned. This patch
increase it to 27. The patch also modify the way to set the
width or to get it, we now use a unsigned rather than a short.

Test: fast/css/border-width-large.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::AnimationBase::ensurePropertyMap):
* platform/animation/AnimationUtilities.h:
(WebCore::blend):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
* rendering/style/BorderData.h:
(WebCore::BorderData::borderLeftWidth):
(WebCore::BorderData::borderRightWidth):
(WebCore::BorderData::borderTopWidth):
(WebCore::BorderData::borderBottomWidth):
* rendering/style/BorderValue.h:
(WebCore::BorderValue::width):
* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::borderLeftWidth):
(WebCore::RenderStyleBitfields::borderRightWidth):
(WebCore::RenderStyleBitfields::borderTopWidth):
(WebCore::RenderStyleBitfields::borderBottomWidth):
(WebCore::RenderStyleBitfields::setBorderLeftWidth):
(WebCore::RenderStyleBitfields::setBorderRightWidth):
(WebCore::RenderStyleBitfields::setBorderTopWidth):
(WebCore::RenderStyleBitfields::setBorderBottomWidth):
(WebCore::RenderStyleBitfields::initialBorderWidth):
(WebCore::RenderStyleBitfields::initialColumnRuleWidth):
(WebCore::RenderStyleBitfields::initialOutlineWidth):

LayoutTests:

This test covers that setting big values to border-width will
return correct values.

* fast/css/border-width-large-expected.txt: Added.
* fast/css/border-width-large.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
trunk/Source/WebCore/page/animation/AnimationBase.cpp
trunk/Source/WebCore/platform/animation/AnimationUtilities.h
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/style/BorderData.h
trunk/Source/WebCore/rendering/style/BorderValue.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/fast/css/border-width-large-expected.txt
trunk/LayoutTests/fast/css/border-width-large.html




Diff

Modified: trunk/LayoutTests/ChangeLog (105402 => 105403)

--- trunk/LayoutTests/ChangeLog	2012-01-19 12:41:26 UTC (rev 105402)
+++ trunk/LayoutTests/ChangeLog	2012-01-19 12:59:52 UTC (rev 105403)
@@ -1,3 +1,16 @@
+2012-01-19  Alexis Menard  alexis.men...@openbossa.org
+
+Strange Result for getComputedStyle on borderWidth set in em
+https://bugs.webkit.org/show_bug.cgi?id=18294
+
+Reviewed by Tony Chang.
+
+This test covers that setting big values to border-width will
+return correct values.
+
+* fast/css/border-width-large-expected.txt: Added.
+* fast/css/border-width-large.html: Added.
+
 2012-01-18  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Differentiate between SVG/CSS width/height attributes/properties


Added: trunk/LayoutTests/fast/css/border-width-large-expected.txt (0 => 105403)

--- trunk/LayoutTests/fast/css/border-width-large-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/border-width-large-expected.txt	2012-01-19 12:59:52 UTC (rev 105403)
@@ -0,0 +1,11 @@
+Test for WebKit bug 18294 : Strange Result for getComputedStyle on borderWidth set in em
+
+PASS computedStyle.getPropertyValue('border-width') is '12000px 11000px 1px 9010px'
+PASS computedStyle.getPropertyCSSValue('border-top-width').cssText is '12000px'
+PASS computedStyle.getPropertyCSSValue('border-right-width').cssText is '11000px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-width').cssText is '1px'
+PASS computedStyle.getPropertyCSSValue('border-left-width').cssText is '9010px'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/border-width-large.html (0 => 105403)

--- trunk/LayoutTests/fast/css/border-width-large.html	(rev 0)
+++ trunk/LayoutTests/fast/css/border-width-large.html	2012-01-19 12:59:52 UTC (rev 105403)
@@ -0,0 +1,33 @@
+!DOCTYPE HTML
+html
+head
+titleTest for WebKit bug 18294 : Strange Result for getComputedStyle on borderWidth set in em/title
+script src=""
+/head
+body
+p id=descriptionTest for WebKit bug a href="" : Strange Result for getComputedStyle on borderWidth set in em/p
+div id=console/div
+
+div id=tests_container
+
+div id=test style=border-style:solid;font-size

[webkit-changes] [105207] trunk/LayoutTests

[alexis . menard]

Title: [105207] trunk/LayoutTests








Revision 105207
Author alexis.men...@openbossa.org
Date 2012-01-17 16:12:40 -0800 (Tue, 17 Jan 2012)


Log Message
Increase test coverage for -webkit-border-image.
https://bugs.webkit.org/show_bug.cgi?id=76473

Reviewed by Tony Chang.

Make sure we also set the width of the border in the shorthand. It will help
in the future to remove CSSBorderImageValue class without breaking this property.

* fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-image.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image.html




Diff

Modified: trunk/LayoutTests/ChangeLog (105206 => 105207)

--- trunk/LayoutTests/ChangeLog	2012-01-18 00:10:53 UTC (rev 105206)
+++ trunk/LayoutTests/ChangeLog	2012-01-18 00:12:40 UTC (rev 105207)
@@ -1,3 +1,16 @@
+2012-01-17  Alexis Menard  alexis.men...@openbossa.org
+
+Increase test coverage for -webkit-border-image.
+https://bugs.webkit.org/show_bug.cgi?id=76473
+
+Reviewed by Tony Chang.
+
+Make sure we also set the width of the border in the shorthand. It will help
+in the future to remove CSSBorderImageValue class without breaking this property.
+
+* fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-border-image.html:
+
 2012-01-17  James Robinson  jam...@chromium.org
 
 [chromium] Update expectations for line-grid tests and one random svg thing


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt (105206 => 105207)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt	2012-01-18 00:10:53 UTC (rev 105206)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt	2012-01-18 00:12:40 UTC (rev 105207)
@@ -15,3 +15,13 @@
 getPropertyValue:-webkit-gradient(linear, 0 0, 0 0) 50 fill / 1 / 0px repeat
 getPropertyCSSValue: [object CSSValue]
 
+-webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 25 25 25 25 / 20 20 20 20 repeat;
+  -webkit-border-image
+getPropertyValue:-webkit-gradient(linear, 0 0, 0 0) 25 fill / 20 / 0px repeat
+getPropertyCSSValue: [object CSSValue]
+
+-webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 50 / 20 stretch stretch;
+  -webkit-border-image
+getPropertyValue:-webkit-gradient(linear, 0 0, 0 0) 50 fill / 20 / 0px stretch
+getPropertyCSSValue: [object CSSValue]
+


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image.html (105206 => 105207)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image.html	2012-01-18 00:10:53 UTC (rev 105206)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-image.html	2012-01-18 00:12:40 UTC (rev 105207)
@@ -5,6 +5,8 @@
 #borderImageNone { -webkit-border-image: none }
 #borderImageStretch { -webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 25 25 25 25 stretch stretch; }
 #borderImageRepeat { -webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 50 repeat; }
+#borderImageWidth { -webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 25 25 25 25 / 20 20 20 20 repeat; }
+#borderImageWidth2 { -webkit-border-image: -webkit-gradient(linear, 0 0, 0 0) 50 / 20 stretch stretch; }
 /style
 script type=text/_javascript_
 function log(msg)
@@ -40,6 +42,14 @@
 log('');
 
 test('borderImageRepeat', '-webkit-gradient(linear, 0 0, 0 0) 50 repeat');
+
+log('');
+
+test('borderImageWidth', '-webkit-gradient(linear, 0 0, 0 0) 25 25 25 25 / 20 20 20 20 repeat');
+
+log('');
+
+test('borderImageWidth2', '-webkit-gradient(linear, 0 0, 0 0) 50 / 20 stretch stretch');
 }
 /script
 /head
@@ -50,6 +60,7 @@
 div id=borderImageNone/div
 div id=borderImageStretch/div
 div id=borderImageRepeat/div
-
+div id=borderImageWidth/div
+div id=borderImageWidth2/div
 /body
 /html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [104981] trunk/Source

[alexis . menard]

Title: [104981] trunk/Source








Revision 104981
Author alexis.men...@openbossa.org
Date 2012-01-13 13:24:27 -0800 (Fri, 13 Jan 2012)


Log Message
Unreviewed build fix for Qt SnowLeopard build bot.

This is a workaround for the moment.

* wtf/Platform.h:

Modified Paths

trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WTF/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/wtf/Platform.h (104980 => 104981)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2012-01-13 21:23:59 UTC (rev 104980)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2012-01-13 21:24:27 UTC (rev 104981)
@@ -561,9 +561,11 @@
 #if PLATFORM(QT)  OS(DARWIN)
 #define WTF_USE_CF 1
 #define HAVE_DISPATCH_H 1
+#if QT_VERSION = 0x05
 /* FIXME: This is a hack to work around a conflict of MacTypes.h defining a Fixed type. */
 #define CF_OPEN_SOURCE 1
 #endif
+#endif
 
 #if OS(DARWIN)  !PLATFORM(GTK)  !PLATFORM(QT)
 #define ENABLE_PURGEABLE_MEMORY 1


Modified: trunk/Source/WTF/ChangeLog (104980 => 104981)

--- trunk/Source/WTF/ChangeLog	2012-01-13 21:23:59 UTC (rev 104980)
+++ trunk/Source/WTF/ChangeLog	2012-01-13 21:24:27 UTC (rev 104981)
@@ -1,3 +1,11 @@
+2012-01-13  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed build fix for Qt SnowLeopard build bot.
+
+This is a workaround for the moment.
+
+* wtf/Platform.h:
+
 2012-01-12  Simon Hausmann  simon.hausm...@nokia.com
 
 Make the new WTF module build on Qt






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [104452] trunk/Source/WebCore

[alexis . menard]

Title: [104452] trunk/Source/WebCore








Revision 104452
Author alexis.men...@openbossa.org
Date 2012-01-09 05:48:36 -0800 (Mon, 09 Jan 2012)


Log Message
Extend CSSValueList to allow slash separated lists.
https://bugs.webkit.org/show_bug.cgi?id=75841

Reviewed by Andreas Kling.

Multiple CSS properties are using slash to separate
various parts (e.g. border-radius) so having this
feature available in CSSValueList will make it easier
in the future to support these properties.

No new tests : existing ones should cover the refactor.

* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::isImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):
* css/CSSValue.cpp:
(WebCore::CSSValue::isImplicitInitialValue):
* css/CSSValue.h:
In order for CSSValue to not grow I moved m_isImplicitInitialValue
back to CSSInitialValue as this object is used only in CSSValuePool
and is allocated only twice.
(WebCore::CSSValue::CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
Fix also usage of PassRefPtr.
(WebCore::CSSValueList::customCssText):
Refactor to use StringBuilder.
* css/CSSValueList.h:
(WebCore::CSSValueList::createCommaSeparated):
(WebCore::CSSValueList::createSpaceSeparated):
(WebCore::CSSValueList::createSlashSeparated):
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSInitialValue.h
trunk/Source/WebCore/css/CSSValue.cpp
trunk/Source/WebCore/css/CSSValue.h
trunk/Source/WebCore/css/CSSValueList.cpp
trunk/Source/WebCore/css/CSSValueList.h
trunk/Source/WebCore/css/WebKitCSSFilterValue.cpp
trunk/Source/WebCore/css/WebKitCSSTransformValue.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (104451 => 104452)

--- trunk/Source/WebCore/ChangeLog	2012-01-09 13:22:38 UTC (rev 104451)
+++ trunk/Source/WebCore/ChangeLog	2012-01-09 13:48:36 UTC (rev 104452)
@@ -1,3 +1,42 @@
+2012-01-09  Alexis Menard  alexis.men...@openbossa.org
+
+Extend CSSValueList to allow slash separated lists.
+https://bugs.webkit.org/show_bug.cgi?id=75841
+
+Reviewed by Andreas Kling.
+
+Multiple CSS properties are using slash to separate
+various parts (e.g. border-radius) so having this
+feature available in CSSValueList will make it easier
+in the future to support these properties.
+
+No new tests : existing ones should cover the refactor.
+
+* css/CSSInitialValue.h:
+(WebCore::CSSInitialValue::isImplicit):
+(WebCore::CSSInitialValue::CSSInitialValue):
+* css/CSSValue.cpp:
+(WebCore::CSSValue::isImplicitInitialValue):
+* css/CSSValue.h:
+In order for CSSValue to not grow I moved m_isImplicitInitialValue
+back to CSSInitialValue as this object is used only in CSSValuePool
+and is allocated only twice.
+(WebCore::CSSValue::CSSValue):
+* css/CSSValueList.cpp:
+(WebCore::CSSValueList::CSSValueList):
+(WebCore::CSSValueList::copy):
+Fix also usage of PassRefPtr.
+(WebCore::CSSValueList::customCssText):
+Refactor to use StringBuilder.
+* css/CSSValueList.h:
+(WebCore::CSSValueList::createCommaSeparated):
+(WebCore::CSSValueList::createSpaceSeparated):
+(WebCore::CSSValueList::createSlashSeparated):
+* css/WebKitCSSFilterValue.cpp:
+(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
+* css/WebKitCSSTransformValue.cpp:
+(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
+
 2012-01-09  No'am Rosenthal  noam.rosent...@nokia.com
 
 [Texmap] Move surface management from TextureMapperNode to TextureMapper


Modified: trunk/Source/WebCore/css/CSSInitialValue.h (104451 => 104452)

--- trunk/Source/WebCore/css/CSSInitialValue.h	2012-01-09 13:22:38 UTC (rev 104451)
+++ trunk/Source/WebCore/css/CSSInitialValue.h	2012-01-09 13:48:36 UTC (rev 104452)
@@ -39,12 +39,16 @@
 
 String customCssText() const;
 
+bool isImplicit() const { return m_isImplicit; }
+
 private:
 CSSInitialValue(bool implicit)
 : CSSValue(InitialClass)
+, m_isImplicit(implicit)
 {
-m_isImplicitInitialValue = implicit;
 }
+
+bool m_isImplicit;
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/css/CSSValue.cpp (104451 => 104452)

--- trunk/Source/WebCore/css/CSSValue.cpp	2012-01-09 13:22:38 UTC (rev 104451)
+++ trunk/Source/WebCore/css/CSSValue.cpp	2012-01-09 13:48:36 UTC (rev 104452)
@@ -65,6 +65,11 @@
 
 COMPILE_ASSERT(sizeof(CSSValue) == sizeof(SameSizeAsCSSValue), CSS_value_should_stay_small);
 
+bool CSSValue::isImplicitInitialValue() const
+{
+return m_classType == InitialClass  static_castconst CSSInitialValue*(this)-isImplicit();
+}
+
 CSSValue::Type CSSValue::cssValueTyp

[webkit-changes] [104469] trunk

[alexis . menard]

Title: [104469] trunk








Revision 104469
Author alexis.men...@openbossa.org
Date 2012-01-09 11:26:54 -0800 (Mon, 09 Jan 2012)


Log Message
getComputedStyle for border-radius is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75630

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-radius shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (104468 => 104469)

--- trunk/LayoutTests/ChangeLog	2012-01-09 19:17:11 UTC (rev 104468)
+++ trunk/LayoutTests/ChangeLog	2012-01-09 19:26:54 UTC (rev 104469)
@@ -1,3 +1,15 @@
+2012-01-09  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for border-radius is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75630
+
+Reviewed by Tony Chang.
+
+Add new tests to make sure we return the correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html: Added.
+
 2012-01-09  John Knottenbelt  jknot...@chromium.org
 
 [Chromium] Update test expectations.


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt (0 => 104469)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt	2012-01-09 19:26:54 UTC (rev 104469)
@@ -0,0 +1,89 @@
+Test to make sure border-radius shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-radius') is '64px'
+PASS computedStyle.getPropertyCSSValue('border-radius').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-top-left-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-top-right-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-right-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-left-radius').cssText is '64px'
+PASS checkComputedStyleValue() is true
+PASS computedStyle.getPropertyValue('border-radius') is '32px 16px 64px / 8px 48px'
+PASS computedStyle.getPropertyCSSValue('border-radius').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-radius').cssText is '32px 16px 64px / 8px 48px'
+PASS computedStyle.getPropertyCSSValue('border-top-left-radius').cssText is '32px 8px'
+PASS computedStyle.getPropertyCSSValue('border-top-right-radius').cssText is '16px 48px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-right-radius').cssText is '64px 8px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-left-radius').cssText is '16px 48px'
+PASS checkComputedStyleValue() is true
+PASS computedStyle.getPropertyValue('border-radius') is '64px'
+PASS computedStyle.getPropertyCSSValue('border-radius').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-top-left-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-top-right-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-right-radius').cssText is '64px'
+PASS computedStyle.getPropertyCSSValue('border-bottom-left-radius').cssText is '64px'
+PASS checkComputedStyleValue() is true
+PASS computedStyle.getPropertyValue('border-radius') is '1px 2px'
+PASS computedStyle.getPropertyCSSValue('border-radius').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-radius').cssText is '1px 2px'
+PASS computedStyle.getPropertyCSSValue('border-top-left-radius').cssText is '1px'
+PASS computedStyle.getPropertyCSSValue('border-top-right-radius').cssText is '2px'
+PASS computedStyle.getPropertyCSSValue('border-bottom

[webkit-changes] [104144] trunk

[alexis . menard]

Title: [104144] trunk








Revision 104144
Author alexis.men...@openbossa.org
Date 2012-01-05 04:55:50 -0800 (Thu, 05 Jan 2012)


Log Message
getComputedStyle for border-image is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75347

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-color.

fast/css/getComputedStyle/computed-style-border-image.html was extended to cover the
new feature.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values for border-image.

* fast/css/getComputedStyle/computed-style-border-image-expected.txt:
* fast/css/getComputedStyle/computed-style-border-image.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (104143 => 104144)

--- trunk/LayoutTests/ChangeLog	2012-01-05 12:54:04 UTC (rev 104143)
+++ trunk/LayoutTests/ChangeLog	2012-01-05 12:55:50 UTC (rev 104144)
@@ -1,3 +1,15 @@
+2012-01-05  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for border-image is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75347
+
+Reviewed by Tony Chang.
+
+Extend existing test to cover that we return correct values for border-image.
+
+* fast/css/getComputedStyle/computed-style-border-image-expected.txt:
+* fast/css/getComputedStyle/computed-style-border-image.html:
+
 2012-01-05  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2]REGRESSION(r104068): It made editing/pasteboard/copy-in-password-field.html fail


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt (104143 => 104144)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt	2012-01-05 12:54:04 UTC (rev 104143)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt	2012-01-05 12:55:50 UTC (rev 104144)
@@ -1,24 +1,55 @@
 Test computed style for the border-image property and sub-properties
 
 PASS computedBorderImageStyle('12 11 12 11', 'border-image-slice') is '12 11'
+PASS computedBorderImageStyle('12 11 12 11', 'border-image') is 'none'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 12 11 repeat stretch', 'border-image-slice') is '12 11'
+PASS computedBorderImageStyle('url(dummy://test.png) 12 11 repeat stretch', 'border-image') is 'url(dummy://test.png) 12 11 / 1 / 0px repeat stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 1 2 3 4 repeat stretch', 'border-image-slice') is '1 2 3 4'
+PASS computedBorderImageStyle('url(dummy://test.png) 1 2 3 4 repeat stretch', 'border-image') is 'url(dummy://test.png) 1 2 3 4 / 1 / 0px repeat stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 12 repeat stretch', 'border-image-slice') is '12'
 PASS computedBorderImageStyle('url(test.png) 10 10 5 5 repeat stretch', 'border-image-slice') is '10 10 5 5'
 PASS computedBorderImageStyle('url(test.png) 10 a b c repeat stretch', 'border-image-slice') is '100%'
+PASS computedBorderImageStyle('url(dummy://test.png) 10 a b c repeat stretch', 'border-image') is 'none'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 10 20 fill', 'border-image-slice') is '10 20 fill'
+PASS computedBorderImageStyle('url(dummy://test.png) 10 20 fill', 'border-image') is 'url(dummy://test.png) 10 20 fill / 1 / 0px stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(dummy://test.png) 10 10 10 10 repeat stretch', 'border-image-source') is 'url(dummy://test.png)'
+PASS computedBorderImageStyle('url(dummy://test.png) 10 10 10 10 repeat stretch', 'border-image') is 'url(dummy://test.png) 10 / 1 / 0px repeat stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 10', 'border-image-repeat') is 'stretch'
+PASS computedBorderImageStyle('url(dummy://test.png) 10', 'border-image') is 'url(dummy://test.png) 10 / 1 / 0px stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 10 stretch', 'border-image-repeat') is 'stretch'
+PASS computedBorderImageStyle('url(dummy://test.png) 10 stretch', 'border-image') is 'url(dummy://test.png) 10 / 1 / 0px stretch'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 10 kittens', 'border-image-repeat') is 'stretch'
+PASS computedBorderImageStyle('url(dummy://test.png) 10 kittens', 'border-image') is 'none'
+PASS checkComputedStyleValue() is true
 PASS computedBorderImageStyle('url(test.png) 10 stretch stretc

[webkit-changes] [104169] trunk

[alexis . menard]

Title: [104169] trunk








Revision 104169
Author alexis.men...@openbossa.org
Date 2012-01-05 09:29:54 -0800 (Thu, 05 Jan 2012)


Log Message
getComputedStyle for background is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75539

Reviewed by Tony Chang.

Source/WebCore: 

Implement getComputedStyle for background.

Test: fast/css/getComputedStyle/getComputedStyle-background-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests: 

Add new tests to make sure we return the correct values.

* fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (104168 => 104169)

--- trunk/LayoutTests/ChangeLog	2012-01-05 17:02:21 UTC (rev 104168)
+++ trunk/LayoutTests/ChangeLog	2012-01-05 17:29:54 UTC (rev 104169)
@@ -1,3 +1,15 @@
+2012-01-05  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for background is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75539
+
+Reviewed by Tony Chang.
+
+Add new tests to make sure we return the correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-background-shorthand.html: Added.
+
 2012-01-05  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK test_expectations update.


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt (0 => 104169)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt	2012-01-05 17:29:54 UTC (rev 104169)
@@ -0,0 +1,93 @@
+Test to make sure background shorthand properties returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('background') is 'rgb(255, 0, 0) none repeat scroll 0% 0%'
+PASS computedStyle.getPropertyCSSValue('background').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('background').cssText is 'rgb(255, 0, 0) none repeat scroll 0% 0%'
+PASS computedStyle.getPropertyCSSValue('background').length is 5
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('background').item(1).getStringValue() is 'none'
+PASS computedStyle.getPropertyCSSValue('background').item(2).getStringValue() is 'repeat'
+PASS computedStyle.getPropertyCSSValue('background').item(3).getStringValue() is 'scroll'
+PASS computedStyle.getPropertyCSSValue('background').item(4).toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('background').item(4).item(0).getFloatValue(CSSPrimitiveValue.CSS_PERCENTAGE) is 0
+PASS computedStyle.getPropertyCSSValue('background').item(4).item(1).getFloatValue(CSSPrimitiveValue.CSS_PERCENTAGE) is 0
+PASS checkComputedStyleValue() is true
+PASS computedStyle.getPropertyValue('background') is 'rgb(255, 0, 0) url(dummy://test.png) repeat scroll 0% 0%'
+PASS computedStyle.getPropertyCSSValue('background').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('background').cssText is 'rgb(255, 0, 0) url(dummy://test.png) repeat scroll 0% 0%'
+PASS computedStyle.getPropertyCSSValue('background').length is 5
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('background').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('background').item(1).getStringValue() is 'dummy://test.png'
+PASS computedStyle.getPropertyCSSValue('background').item(2).getStringValue() is 'repeat'
+PASS computedStyle.getPropertyCSSValue('background').item(3).getStringValue() is 'scroll'
+PASS computedStyle.getPropertyCS

[webkit-changes] [104268] trunk/Source/WebCore

[alexis . menard]

Title: [104268] trunk/Source/WebCore








Revision 104268
Author alexis.men...@openbossa.org
Date 2012-01-05 21:36:37 -0800 (Thu, 05 Jan 2012)


Log Message
Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLFormControlElement.h
trunk/Source/WebCore/html/HTMLKeygenElement.h
trunk/Source/WebCore/html/HTMLSelectElement.h
trunk/Source/WebCore/html/HTMLTextFormControlElement.h


Added Paths

trunk/Source/WebCore/html/HTMLFormControlElementWithState.cpp
trunk/Source/WebCore/html/HTMLFormControlElementWithState.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (104267 => 104268)

--- trunk/Source/WebCore/CMakeLists.txt	2012-01-06 05:29:28 UTC (rev 104267)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-01-06 05:36:37 UTC (rev 104268)
@@ -740,6 +740,7 @@
 html/HTMLFontElement.cpp
 html/HTMLFormCollection.cpp
 html/HTMLFormControlElement.cpp
+html/HTMLFormControlElementWithState.cpp
 html/HTMLFormElement.cpp
 html/HTMLFrameElement.cpp
 html/HTMLFrameElementBase.cpp


Modified: trunk/Source/WebCore/ChangeLog (104267 => 104268)

--- trunk/Source/WebCore/ChangeLog	2012-01-06 05:29:28 UTC (rev 104267)
+++ trunk/Source/WebCore/ChangeLog	2012-01-06 05:36:37 UTC (rev 104268)
@@ -1,3 +1,28 @@
+2012-01-05  Alexis Menard  alexis.men...@openbossa.org
+
+Move HTMLFormControlElementWithState class in its own header file.
+https://bugs.webkit.org/show_bug.cgi?id=75482
+
+Reviewed by Kent Tamura.
+
+Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
+files into its own header file and its own implementation file.
+
+No new tests : the existing ones should cover the refactoring.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* Target.pri:
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* html/HTMLElementsAllInOne.cpp:
+* html/HTMLFormControlElement.cpp:
+* html/HTMLFormControlElement.h:
+* html/HTMLKeygenElement.h:
+* html/HTMLSelectElement.h:
+* html/HTMLTextFormControlElement.h:
+
 2012-01-05  Wei James  james@intel.com
 
 Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis


Modified: trunk/Source/WebCore/GNUmakefile.list.am (104267 => 104268)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-01-06 05:29:28 UTC (rev 104267)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-01-06 05:36:37 UTC (rev 104268)
@@ -2020,6 +2020,8 @@
 	Source/WebCore/html/HTMLFormCollection.h \
 	Source/WebCore/html/HTMLFormControlElement.cpp \
 	Source/WebCore/html/HTMLFormControlElement.h \
+	Source/WebCore/html/HTMLFormControlElementWithState.cpp \
+	Source/WebCore/html/HTMLFormControlElementWithState.h \
 	Source/WebCore/html/HTMLFormElement.cpp \
 	Source/WebCore/html/HTMLFormElement.h \
 	Source/WebCore/html/HTMLFrameElementBase.cpp \


Modified: trunk/Source/WebCore/Target.pri (104267 => 104268)

--- trunk/Source/WebCore/Target.pri	2012-01-06 05:29:28 UTC (rev 104267)
+++ trunk/Source/WebCore/Target.pri	2012-01-06 05:36:37 UTC (rev 104268)
@@ -725,6 +725,7 @@
 html/HTMLFontElement.cpp \
 html/HTMLFormCollection.cpp \
 html/HTMLFormControlElement.cpp \
+html/HTMLFormControlElementWithState.cpp \
 html/HTMLFormElement.cpp \
 html/HTMLFrameElement.cpp \
 html/HTMLFrameElementBase.cpp \
@@ -1795,6 +1796,7 @@
 html/HTMLFontElement.h \
 html/HTMLFormCollection.h \
 html/HTMLFormControlElement.h \
+html/HTMLFormControlElementWithState.h \
 html/HTMLFormElement.h \
 html/HTMLFrameElementBase.h \
 html/HTMLFrameElement.h \


Modified: trunk/Source/WebCore/WebCore.gypi (104267 => 104268)

--- trunk/Source/WebCore/WebCore.gypi	2012-01-06 05:29:28 UTC (rev 104267)
+++ trunk/Source/WebCore/WebCore.gypi	2012-01-06 05:36:37 UTC (rev 104

[webkit-changes] [103934] trunk

[alexis . menard]

Title: [103934] trunk








Revision 103934
Author alexis.men...@openbossa.org
Date 2012-01-03 04:39:01 -0800 (Tue, 03 Jan 2012)


Log Message
getComputedStyle for outline is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75441

Reviewed by Antonio Gomes.

Source/WebCore:

Implement getComputedStyle for outline.

Test: fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

* fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103933 => 103934)

--- trunk/LayoutTests/ChangeLog	2012-01-03 12:37:19 UTC (rev 103933)
+++ trunk/LayoutTests/ChangeLog	2012-01-03 12:39:01 UTC (rev 103934)
@@ -1,3 +1,15 @@
+2012-01-03  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for outline is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75441
+
+Reviewed by Antonio Gomes.
+
+Add new tests to make sure we return the correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html: Added.
+
 2012-01-03  Alpha Lam  hc...@chromium.org
 
 https://bugs.webkit.org/show_bug.cgi?id=75468


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt (0 => 103934)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand-expected.txt	2012-01-03 12:39:01 UTC (rev 103934)
@@ -0,0 +1,36 @@
+Test to make sure outline shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('outline') is 'rgb(255, 0, 0) solid 5px'
+PASS computedStyle.getPropertyCSSValue('outline').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('outline').length is 3
+PASS computedStyle.getPropertyCSSValue('outline').cssText is 'rgb(255, 0, 0) solid 5px'
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(1).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('outline').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 5
+PASS computedStyle.getPropertyValue('outline') is 'rgb(0, 0, 0) solid 32px'
+PASS computedStyle.getPropertyCSSValue('outline').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('outline').length is 3
+PASS computedStyle.getPropertyCSSValue('outline').cssText is 'rgb(0, 0, 0) solid 32px'
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(1).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('outline').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 32
+PASS computedStyle.getPropertyValue('outline') is 'rgb(255, 0, 0) none 0px'
+PASS computedStyle.getPropertyCSSValue('outline').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('outline').length is 3
+PASS computedStyle.getPropertyCSSValue('outline').cssText is 'rgb(255, 0, 0) none 0px'
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('outline').

[webkit-changes] [103948] trunk

[alexis . menard]

Title: [103948] trunk








Revision 103948
Author alexis.men...@openbossa.org
Date 2012-01-03 11:13:48 -0800 (Tue, 03 Jan 2012)


Log Message
getComputedStyle for border is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75319

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border.

fast/css/getComputedStyle/getComputedStyle-border-shorthand.html was extented.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Extend existing test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (103947 => 103948)

--- trunk/LayoutTests/ChangeLog	2012-01-03 19:03:37 UTC (rev 103947)
+++ trunk/LayoutTests/ChangeLog	2012-01-03 19:13:48 UTC (rev 103948)
@@ -1,5 +1,17 @@
 2012-01-03  Alexis Menard  alexis.men...@openbossa.org
 
+getComputedStyle for border is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75319
+
+Reviewed by Tony Chang.
+
+Extend existing test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-border-shorthand.html:
+
+2012-01-03  Alexis Menard  alexis.men...@openbossa.org
+
 getComputedStyle for outline is not implemented.
 https://bugs.webkit.org/show_bug.cgi?id=75441
 


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt (103947 => 103948)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt	2012-01-03 19:03:37 UTC (rev 103947)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt	2012-01-03 19:13:48 UTC (rev 103948)
@@ -111,6 +111,16 @@
 PASS computedStyle.getPropertyCSSValue('border-left').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
 PASS computedStyle.getPropertyCSSValue('border-left').item(2).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 128
 PASS computedStyle.getPropertyCSSValue('border-left').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyValue('border') is '320px solid rgb(255, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border').cssText is '320px solid rgb(255, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border').length is 3
+PASS computedStyle.getPropertyCSSValue('border').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 320
+PASS computedStyle.getPropertyCSSValue('border').item(1).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border').item(2).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyValue('border') is ''
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html (103947 => 103948)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html	2012-01-03 19:03:37 UTC (rev 103947)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html	2012-01-03 19:13:48 UTC (rev 103948)
@@ -56,6 +56,25 @@
 shouldBe(computedStyle.getPropertyCSSValue(' + properties[i] + ').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER), 0);
 
 }
+
+e.style.cssText = ;
+e.style.border = 20em solid red;
+shouldBe(computedStyle.getPropertyValue('border'), '320px solid rgb(255, 0, 0)');
+shouldBe(computedStyle.getPropertyCSSValue('border').toString(), '[object CSSValueList]');
+shouldBe(computedStyle.getPropertyCSSValue('border').cssText, '320px solid rgb(255, 0, 0)');
+shouldBe(computedStyle.getPropertyCSSValue('border').length, 3);
+shouldBe(computedStyle.getPropertyCSSValue('border').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX), 320);
+shouldBe(computedStyle.getPropertyCSSValue('border').item(1).getStringValue(), 'solid');
+shouldBe(computedStyle.getPropertyCSSValue('border').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER), 255);

[webkit-changes] [103953] trunk

[alexis . menard]

Title: [103953] trunk








Revision 103953
Author alexis.men...@openbossa.org
Date 2012-01-03 11:56:48 -0800 (Tue, 03 Jan 2012)


Log Message
Source/WebCore: getComputedStyle should return shorthands property with the minimum number of sides possible.
https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

Existing tests have been updated accordingly.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
* css/CSSComputedStyleDeclaration.h:

LayoutTests: getComputedStyle should return shorthands properties with the minimum number of sides possible.
https://bugs.webkit.org/show_bug.cgi?id=75434

Reviewed by Tony Chang.

As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
return shorthands properties with the minimum number of sides possible.

* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-width.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h




Diff

Modified: trunk/LayoutTests/ChangeLog (103952 => 103953)

--- trunk/LayoutTests/ChangeLog	2012-01-03 19:53:50 UTC (rev 103952)
+++ trunk/LayoutTests/ChangeLog	2012-01-03 19:56:48 UTC (rev 103953)
@@ -1,3 +1,20 @@
+2012-01-03  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle should return shorthands properties with the minimum number of sides possible.
+https://bugs.webkit.org/show_bug.cgi?id=75434
+
+Reviewed by Tony Chang.
+
+As stated in http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSS2Properties we should
+return shorthands properties with the minimum number of sides possible.
+
+* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html:
+* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html:
+* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-border-width.html:
+
 2012-01-03  Florin Malita  fmal...@google.com
 
 NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform


Modified: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt (103952 => 103953)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt	2012-01-03 19:53:50 UTC (rev 103952)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt	2012-01-03 19:56:48 UTC (rev 103953)
@@ -19,54 +19,27 @@
 PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
 PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
 PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
-PASS computedStyle.getPropertyValue('border-color') is 'rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0)'
+PASS computedStyle.getPropertyValue('border-color') is 'rgb(0, 0, 0)'
 PASS computedStyle.getPropertyCSSValue('border-color').toString() is '[object CSSValueList]'
-PASS computedStyle.getPropertyCSSValue('border-color').length is 4
-PASS computedStyle.getPropertyCSSValue('border-color').cssText is 'rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border-color').length is 1
+PASS computedStyle.getPropertyCSSValue('border

[webkit-changes] [103974] trunk

[alexis . menard]

Title: [103974] trunk








Revision 103974
Author alexis.men...@openbossa.org
Date 2012-01-03 15:20:43 -0800 (Tue, 03 Jan 2012)


Log Message
getComputedStyle for list-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75443

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for list-style.

Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

* fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103973 => 103974)

--- trunk/LayoutTests/ChangeLog	2012-01-03 23:13:52 UTC (rev 103973)
+++ trunk/LayoutTests/ChangeLog	2012-01-03 23:20:43 UTC (rev 103974)
@@ -1,3 +1,15 @@
+2012-01-03  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for list-style is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75443
+
+Reviewed by Tony Chang.
+
+Add new tests to make sure we return the correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
+
 2012-01-03  Tony Chang  t...@chromium.org
 
 [chromium] Unreviewed, rebaseline of svg/hixie/text/003.html.  It


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt (0 => 103974)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt	2012-01-03 23:20:43 UTC (rev 103974)
@@ -0,0 +1,44 @@
+Test to make sure list-style shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('list-style') is 'circle outside url(dummy://test.png)'
+PASS computedStyle.getPropertyCSSValue('list-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('list-style').length is 3
+PASS computedStyle.getPropertyCSSValue('list-style').cssText is 'circle outside url(dummy://test.png)'
+PASS computedStyle.getPropertyCSSValue('list-style').item(0).getStringValue() is 'circle'
+PASS computedStyle.getPropertyCSSValue('list-style').item(1).getStringValue() is 'outside'
+PASS computedStyle.getPropertyCSSValue('list-style').item(2).getStringValue() is 'dummy://test.png'
+PASS computedStyle.getPropertyValue('list-style') is 'disc outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('list-style').length is 3
+PASS computedStyle.getPropertyCSSValue('list-style').cssText is 'disc outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').item(0).getStringValue() is 'disc'
+PASS computedStyle.getPropertyCSSValue('list-style').item(1).getStringValue() is 'outside'
+PASS computedStyle.getPropertyCSSValue('list-style').item(2).getStringValue() is 'none'
+PASS computedStyle.getPropertyValue('list-style') is 'circle outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('list-style').length is 3
+PASS computedStyle.getPropertyCSSValue('list-style').cssText is 'circle outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').item(0).getStringValue() is 'circle'
+PASS computedStyle.getPropertyCSSValue('list-style').item(1).getStringValue() is 'outside'
+PASS computedStyle.getPropertyCSSValue('list-style').item(2).getStringValue() is 'none'
+PASS computedStyle.getPropertyValue('list-style') is 'none outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('list-style').length is 3
+PASS computedStyle.getPropertyCSSValue('list-style').cssText is 'none outside none'
+PASS computedStyle.getPropertyCSSValue('list-style').item(0).getStringValue() is 'none'
+PASS computedStyle.getPropertyCSSValue('list-style').item(1).getStringValue() is 'outside'
+PASS computedStyle.getPropertyCSSValue('list-style').item(2).getStringValue() is 'none'
+PASS computedStyle.getPropertyValue('list-style') is 'circle outside url(dummy://test.png)'
+PASS computedStyle.getPropertyCSSValue

[webkit-changes] [103809] trunk

[alexis . menard]

Title: [103809] trunk








Revision 103809
Author alexis.men...@openbossa.org
Date 2011-12-29 10:36:52 -0800 (Thu, 29 Dec 2011)


Log Message
getComputedStyle for padding is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75352

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for padding shorthand property.

Test: fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103808 => 103809)

--- trunk/LayoutTests/ChangeLog	2011-12-29 18:21:17 UTC (rev 103808)
+++ trunk/LayoutTests/ChangeLog	2011-12-29 18:36:52 UTC (rev 103809)
@@ -1,3 +1,15 @@
+2011-12-29  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for padding is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75352
+
+Reviewed by Andreas Kling.
+
+Add test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html: Added.
+
 2011-12-29  Dale Curtis  dalecur...@chromium.org
 
 [GTK] media/video-scales-in-media-document.html fails


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt (0 => 103809)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand-expected.txt	2011-12-29 18:36:52 UTC (rev 103809)
@@ -0,0 +1,33 @@
+Test to make sure padding shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('padding') is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('padding').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('padding').length is 4
+PASS computedStyle.getPropertyCSSValue('padding').cssText is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('padding').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 10
+PASS computedStyle.getPropertyCSSValue('padding').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 5
+PASS computedStyle.getPropertyCSSValue('padding').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 4
+PASS computedStyle.getPropertyCSSValue('padding').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 3
+PASS computedStyle.getPropertyValue('padding') is '64px 80px 96px 112px'
+PASS computedStyle.getPropertyCSSValue('padding').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('padding').length is 4
+PASS computedStyle.getPropertyCSSValue('padding').cssText is '64px 80px 96px 112px'
+PASS computedStyle.getPropertyCSSValue('padding').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 64
+PASS computedStyle.getPropertyCSSValue('padding').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 80
+PASS computedStyle.getPropertyCSSValue('padding').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 96
+PASS computedStyle.getPropertyCSSValue('padding').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 112
+PASS computedStyle.getPropertyValue('padding') is '5px 6px 7px 8px'
+PASS computedStyle.getPropertyCSSValue('padding').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('padding').length is 4
+PASS computedStyle.getPropertyCSSValue('padding').cssText is '5px 6px 7px 8px'
+PASS computedStyle.getPropertyCSSValue('padding').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 5
+PASS computedStyle.getPropertyCSSValue('padding').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 6
+PASS computedStyle.getPropertyCSSValue('padding').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 7
+PASS computedStyle.getPropertyCSSValue('padding').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 8
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html (0 => 103809)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-padding-short

[webkit-changes] [103811] trunk

[alexis . menard]

Title: [103811] trunk








Revision 103811
Author alexis.men...@openbossa.org
Date 2011-12-29 10:52:25 -0800 (Thu, 29 Dec 2011)


Log Message
getComputedStyle for margin is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75358

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for margin.

Test: fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103810 => 103811)

--- trunk/LayoutTests/ChangeLog	2011-12-29 18:44:45 UTC (rev 103810)
+++ trunk/LayoutTests/ChangeLog	2011-12-29 18:52:25 UTC (rev 103811)
@@ -1,5 +1,17 @@
 2011-12-29  Alexis Menard  alexis.men...@openbossa.org
 
+getComputedStyle for margin is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75358
+
+Reviewed by Andreas Kling.
+
+Add test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html: Added.
+
+2011-12-29  Alexis Menard  alexis.men...@openbossa.org
+
 getComputedStyle for padding is not implemented.
 https://bugs.webkit.org/show_bug.cgi?id=75352
 


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt (0 => 103811)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand-expected.txt	2011-12-29 18:52:25 UTC (rev 103811)
@@ -0,0 +1,33 @@
+Test to make sure margin shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('margin') is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('margin').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('margin').length is 4
+PASS computedStyle.getPropertyCSSValue('margin').cssText is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('margin').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 10
+PASS computedStyle.getPropertyCSSValue('margin').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 5
+PASS computedStyle.getPropertyCSSValue('margin').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 4
+PASS computedStyle.getPropertyCSSValue('margin').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 3
+PASS computedStyle.getPropertyValue('margin') is '64px 80px 96px 112px'
+PASS computedStyle.getPropertyCSSValue('margin').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('margin').length is 4
+PASS computedStyle.getPropertyCSSValue('margin').cssText is '64px 80px 96px 112px'
+PASS computedStyle.getPropertyCSSValue('margin').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 64
+PASS computedStyle.getPropertyCSSValue('margin').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 80
+PASS computedStyle.getPropertyCSSValue('margin').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 96
+PASS computedStyle.getPropertyCSSValue('margin').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 112
+PASS computedStyle.getPropertyValue('margin') is '5px 6px 7px 8px'
+PASS computedStyle.getPropertyCSSValue('margin').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('margin').length is 4
+PASS computedStyle.getPropertyCSSValue('margin').cssText is '5px 6px 7px 8px'
+PASS computedStyle.getPropertyCSSValue('margin').item(0).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 5
+PASS computedStyle.getPropertyCSSValue('margin').item(1).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 6
+PASS computedStyle.getPropertyCSSValue('margin').item(2).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 7
+PASS computedStyle.getPropertyCSSValue('margin').item(3).getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 8
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html (0 => 103811)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-short

[webkit-changes] [103774] trunk

[alexis . menard]

Title: [103774] trunk








Revision 103774
Author alexis.men...@openbossa.org
Date 2011-12-28 12:13:44 -0800 (Wed, 28 Dec 2011)


Log Message
getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74743

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-top, border-bottom, border-right, border-left.

Test: fast/css/getComputedStyle/getComputedStyle-border-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
* css/CSSComputedStyleDeclaration.h:

LayoutTests:

Add test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.h


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103773 => 103774)

--- trunk/LayoutTests/ChangeLog	2011-12-28 19:47:45 UTC (rev 103773)
+++ trunk/LayoutTests/ChangeLog	2011-12-28 20:13:44 UTC (rev 103774)
@@ -1,3 +1,15 @@
+2011-12-28  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=74743
+
+Reviewed by Tony Chang.
+
+Add test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-shorthand.html: Added.
+
 2011-12-28  Robert Hogan  rob...@webkit.org
 
 Inline flow not learning height of all text descendants


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt (0 => 103774)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-shorthand-expected.txt	2011-12-28 20:13:44 UTC (rev 103774)
@@ -0,0 +1,117 @@
+Test to make sure border shorthand properties returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-bottom') is '10px solid rgb(255, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-bottom').cssText is '10px solid rgb(255, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').length is 3
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 10
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(1).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyValue('border-bottom') is '320px solid rgb(0, 0, 255)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-bottom').cssText is '320px solid rgb(0, 0, 255)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').length is 3
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 320
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(1).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-bottom').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyValue('border-bottom') is '0px none rgb(0, 128, 0)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-bottom').cssText is '0px none rgb(0, 128, 0)'
+PASS computedStyle.getPropertyCSSValue('border-bottom').length is 3

[webkit-changes] [103775] trunk

[alexis . menard]

Title: [103775] trunk








Revision 103775
Author alexis.men...@openbossa.org
Date 2011-12-28 12:18:03 -0800 (Wed, 28 Dec 2011)


Log Message
getComputedStyle for border-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75312

Reviewed by Andreas Kling.

Source/WebCore: 

Implement getComputedStyle for border-style.

Test: fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests: 

Add test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103774 => 103775)

--- trunk/LayoutTests/ChangeLog	2011-12-28 20:13:44 UTC (rev 103774)
+++ trunk/LayoutTests/ChangeLog	2011-12-28 20:18:03 UTC (rev 103775)
@@ -1,5 +1,17 @@
 2011-12-28  Alexis Menard  alexis.men...@openbossa.org
 
+getComputedStyle for border-style is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75312
+
+Reviewed by Andreas Kling.
+
+Add test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html: Added.
+
+2011-12-28  Alexis Menard  alexis.men...@openbossa.org
+
 getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
 https://bugs.webkit.org/show_bug.cgi?id=74743
 


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt (0 => 103775)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand-expected.txt	2011-12-28 20:18:03 UTC (rev 103775)
@@ -0,0 +1,25 @@
+Test to make sure border-style shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-style') is 'solid dotted solid dotted'
+PASS computedStyle.getPropertyCSSValue('border-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-style').length is 4
+PASS computedStyle.getPropertyCSSValue('border-style').cssText is 'solid dotted solid dotted'
+PASS computedStyle.getPropertyCSSValue('border-style').item(0).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border-style').item(1).getStringValue() is 'dotted'
+PASS computedStyle.getPropertyCSSValue('border-style').item(2).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border-style').item(3).getStringValue() is 'dotted'
+PASS computedStyle.getPropertyValue('border-style') is 'solid dotted groove dashed'
+PASS computedStyle.getPropertyCSSValue('border-style').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-style').length is 4
+PASS computedStyle.getPropertyCSSValue('border-style').cssText is 'solid dotted groove dashed'
+PASS computedStyle.getPropertyCSSValue('border-style').item(0).getStringValue() is 'solid'
+PASS computedStyle.getPropertyCSSValue('border-style').item(1).getStringValue() is 'dotted'
+PASS computedStyle.getPropertyCSSValue('border-style').item(2).getStringValue() is 'groove'
+PASS computedStyle.getPropertyCSSValue('border-style').item(3).getStringValue() is 'dashed'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html (0 => 103775)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html	2011-12-28 20:18:03 UTC (rev 103775)
@@ -0,0 +1,46 @@
+!DOCTYPE html
+html
+head
+meta charset=utf-8
+script src=""
+/head
+body
+script
+
+description(Test to make sure border-style shorthand property returns CSSValueList properly.)
+
+var testContainer = document.createElement(div);
+testContainer.contentEditable = true;
+document.body.appendChild(testContainer);
+
+testContainer.innerHTML = 'div id=testhello/div';
+
+e = document.getElementById('test');
+computedStyle = window.getComputedStyle(e, null);
+
+e.style.borderStyle = solid dotted;
+shouldBe(computedStyle.getPropertyValue('bor

[webkit-changes] [103780] trunk

[alexis . menard]

Title: [103780] trunk








Revision 103780
Author alexis.men...@openbossa.org
Date 2011-12-28 13:26:35 -0800 (Wed, 28 Dec 2011)


Log Message
getComputedStyle for border-color is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75324

Reviewed by Andreas Kling.

Source/WebCore:

Implement getComputedStyle for border-color.

Test: fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to cover that we return correct values.

* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103779 => 103780)

--- trunk/LayoutTests/ChangeLog	2011-12-28 21:12:23 UTC (rev 103779)
+++ trunk/LayoutTests/ChangeLog	2011-12-28 21:26:35 UTC (rev 103780)
@@ -1,3 +1,15 @@
+2011-12-28  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for border-color is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=75324
+
+Reviewed by Andreas Kling.
+
+Add test to cover that we return correct values.
+
+* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html: Added.
+
 2011-12-28  Robert Hogan  rob...@webkit.org
 
 [Qt] fails fast/inline/nested-text-descendants.html


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt (0 => 103780)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-color-shorthand-expected.txt	2011-12-28 21:26:35 UTC (rev 103780)
@@ -0,0 +1,73 @@
+Test to make sure border-color shorthand property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-color') is 'rgb(255, 0, 0) rgb(0, 0, 255) rgb(0, 128, 0) rgb(255, 255, 255)'
+PASS computedStyle.getPropertyCSSValue('border-color').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-color').length is 4
+PASS computedStyle.getPropertyCSSValue('border-color').cssText is 'rgb(255, 0, 0) rgb(0, 0, 255) rgb(0, 128, 0) rgb(255, 255, 255)'
+PASS computedStyle.getPropertyCSSValue('border-color').item(0).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border-color').item(0).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(0).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(1).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(1).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(1).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border-color').item(2).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(2).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 128
+PASS computedStyle.getPropertyCSSValue('border-color').item(2).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 0
+PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().red.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().green.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyCSSValue('border-color').item(3).getRGBColorValue().blue.getFloatValue(CSSPrimitiveValue.CSS_NUMBER) is 255
+PASS computedStyle.getPropertyValue('border-color') is 'rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border-color').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-color').length is 4
+PASS computedStyle.getPropertyCSSValue('border-color').cssText is 'rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0) rgb(0, 0, 0)'
+PASS computedStyle.getPropertyCSSValue('border-color').

[webkit-changes] [103062] trunk

[alexis . menard]

Title: [103062] trunk








Revision 103062
Author alexis.men...@openbossa.org
Date 2011-12-16 05:43:37 -0800 (Fri, 16 Dec 2011)


Log Message
Add support for ol reversed.
https://bugs.webkit.org/show_bug.cgi?id=36724

The reversed attribute makes an ordered list appear with marker values
decreasing from n, where n is the number of items.
See: http://www.whatwg.org/specs/web-apps/current-work/#attr-ol-reversed

Patch by Alexis Menard  alexis.men...@openbossa.org, Jakub Wieczorek jwieczo...@webkit.org on 2011-12-16
Reviewed by Darin Adler.

Source/WebCore: 

Tests: fast/lists/ol-reversed-dynamic-simple.html
   fast/lists/ol-reversed-dynamic.html
   fast/lists/ol-reversed-nested-items.html
   fast/lists/ol-reversed-nested-list.html
   fast/lists/ol-reversed-simple.html

* html/HTMLAttributeNames.in:
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::HTMLOListElement):
(WebCore::HTMLOListElement::parseMappedAttribute):
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
* html/HTMLOListElement.h:
(WebCore::HTMLOListElement::start):
(WebCore::HTMLOListElement::isReversed):
(WebCore::HTMLOListElement::itemCountChanged):
(WebCore::HTMLOListElement::itemCount):
* html/HTMLOListElement.idl:
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
* rendering/RenderListItem.h:

LayoutTests: 

* fast/lists/ol-reversed-dynamic-expected.txt: Added.
* fast/lists/ol-reversed-dynamic-simple-expected.txt: Added.
* fast/lists/ol-reversed-dynamic-simple.html: Added.
* fast/lists/ol-reversed-dynamic.html: Added.
* fast/lists/ol-reversed-nested-items-expected.txt: Added.
* fast/lists/ol-reversed-nested-items.html: Added.
* fast/lists/ol-reversed-nested-list-expected.txt: Added.
* fast/lists/ol-reversed-nested-list.html: Added.
* fast/lists/ol-reversed-simple-expected.txt: Added.
* fast/lists/ol-reversed-simple.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAttributeNames.in
trunk/Source/WebCore/html/HTMLOListElement.cpp
trunk/Source/WebCore/html/HTMLOListElement.h
trunk/Source/WebCore/html/HTMLOListElement.idl
trunk/Source/WebCore/rendering/RenderListItem.cpp
trunk/Source/WebCore/rendering/RenderListItem.h


Added Paths

trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt
trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple-expected.txt
trunk/LayoutTests/fast/lists/ol-reversed-dynamic-simple.html
trunk/LayoutTests/fast/lists/ol-reversed-dynamic.html
trunk/LayoutTests/fast/lists/ol-reversed-nested-items-expected.txt
trunk/LayoutTests/fast/lists/ol-reversed-nested-items.html
trunk/LayoutTests/fast/lists/ol-reversed-nested-list-expected.txt
trunk/LayoutTests/fast/lists/ol-reversed-nested-list.html
trunk/LayoutTests/fast/lists/ol-reversed-simple-expected.txt
trunk/LayoutTests/fast/lists/ol-reversed-simple.html
trunk/LayoutTests/fast/lists/ol-reversed-simple.xhtml




Diff

Modified: trunk/LayoutTests/ChangeLog (103061 => 103062)

--- trunk/LayoutTests/ChangeLog	2011-12-16 13:39:27 UTC (rev 103061)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 13:43:37 UTC (rev 103062)
@@ -1,3 +1,25 @@
+2011-12-16  Alexis Menard  alexis.men...@openbossa.org, Jakub Wieczorek  jwieczo...@webkit.org
+
+Add support for ol reversed.
+https://bugs.webkit.org/show_bug.cgi?id=36724
+
+The reversed attribute makes an ordered list appear with marker values
+decreasing from n, where n is the number of items.
+See: http://www.whatwg.org/specs/web-apps/current-work/#attr-ol-reversed
+
+Reviewed by Darin Adler.
+
+* fast/lists/ol-reversed-dynamic-expected.txt: Added.
+* fast/lists/ol-reversed-dynamic-simple-expected.txt: Added.
+* fast/lists/ol-reversed-dynamic-simple.html: Added.
+* fast/lists/ol-reversed-dynamic.html: Added.
+* fast/lists/ol-reversed-nested-items-expected.txt: Added.
+* fast/lists/ol-reversed-nested-items.html: Added.
+* fast/lists/ol-reversed-nested-list-expected.txt: Added.
+* fast/lists/ol-reversed-nested-list.html: Added.
+* fast/lists/ol-reversed-simple-expected.txt: Added.
+* fast/lists/ol-reversed-simple.html: Added.
+
 2011-12-16  Hajime Morrita  morr...@chromium.org
 
 Unreviewed, test_expectations.txt update.


Added: trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt (0 => 103062)

--- trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/lists/ol-reversed-dynamic-expected.txt	2011-12-16 13:43:37 UTC (rev 103062)
@@ -0,0 +1,40 @@
+This tests that changing the value of an item updates markers accordingly.
+
+10 Ten
+9 Nine
+8 Eight
+7 Seven
+6 Six
+
+This

[webkit-changes] [103096] trunk

[alexis . menard]

Title: [103096] trunk








Revision 103096
Author alexis.men...@openbossa.org
Date 2011-12-16 12:50:31 -0800 (Fri, 16 Dec 2011)


Log Message
getComputedStyle for border-width is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=74635

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for border-width.

Test: fast/css/getComputedStyle/getComputedStyle-border-width.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Implement a test to cover getComputedStyle for border-width.

* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-border-width.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width.html




Diff

Modified: trunk/LayoutTests/ChangeLog (103095 => 103096)

--- trunk/LayoutTests/ChangeLog	2011-12-16 20:41:51 UTC (rev 103095)
+++ trunk/LayoutTests/ChangeLog	2011-12-16 20:50:31 UTC (rev 103096)
@@ -1,3 +1,15 @@
+2011-12-16  Alexis Menard  alexis.men...@openbossa.org
+
+getComputedStyle for border-width is not implemented.
+https://bugs.webkit.org/show_bug.cgi?id=74635
+
+Reviewed by Tony Chang.
+
+Implement a test to cover getComputedStyle for border-width.
+
+* fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt: Added.
+* fast/css/getComputedStyle/getComputedStyle-border-width.html: Added.
+
 2011-12-16  Dmitry Lomov  dslo...@google.com
 
 https://bugs.webkit.org/show_bug.cgi?id=74657


Added: trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt (0 => 103096)

--- trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/getComputedStyle/getComputedStyle-border-width-expected.txt	2011-12-16 20:50:31 UTC (rev 103096)
@@ -0,0 +1,49 @@
+Test to make sure border-width property returns CSSValueList properly.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS computedStyle.getPropertyValue('border-width') is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '10px 5px 4px 3px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 10
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 5
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 3
+PASS computedStyle.getPropertyValue('border-width') is '320px 160px 64px 80px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '320px 160px 64px 80px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 320
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 160
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 64
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 80
+PASS computedStyle.getPropertyValue('border-width') is '10px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '10px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4
+PASS computedStyle.getPropertyCSSValue('border-width').item(0).getFloatValue(CSSPrimitiveValue.CSS_PX) is 10
+PASS computedStyle.getPropertyCSSValue('border-width').item(1).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyCSSValue('border-width').item(2).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyCSSValue('border-width').item(3).getFloatValue(CSSPrimitiveValue.CSS_PX) is 0
+PASS computedStyle.getPropertyValue('border-width') is '0px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').toString() is '[object CSSValueList]'
+PASS computedStyle.getPropertyCSSValue('border-width').cssText is '0px 0px 0px 0px'
+PASS computedStyle.getPropertyCSSValue('border-width').length is 4

[webkit-changes] [102766] trunk

[alexis . menard]

Title: [102766] trunk








Revision 102766
Author alexis.men...@openbossa.org
Date 2011-12-14 04:50:47 -0800 (Wed, 14 Dec 2011)


Log Message
[Qt] [Gardening] Remove qt-4.7 layout tests dir
https://bugs.webkit.org/show_bug.cgi?id=74426

Building trunk now depends on Qt = 4.8, so no need to keep this directory
on the tree.

Patch by João Paulo Rechi Vita jprv...@openbossa.org on 2011-12-14
Reviewed by Csaba Osztrogonác.

Tools: 

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.qt_version):
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_search_path):

LayoutTests: 

* platform/qt-4.7/Skipped: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py


Removed Paths

trunk/LayoutTests/platform/qt-4.7/




Diff

Modified: trunk/LayoutTests/ChangeLog (102765 => 102766)

--- trunk/LayoutTests/ChangeLog	2011-12-14 12:50:02 UTC (rev 102765)
+++ trunk/LayoutTests/ChangeLog	2011-12-14 12:50:47 UTC (rev 102766)
@@ -1,3 +1,15 @@
+2011-12-14  João Paulo Rechi Vita  jprv...@openbossa.org
+
+[Qt] [Gardening] Remove qt-4.7 layout tests dir
+https://bugs.webkit.org/show_bug.cgi?id=74426
+
+Building trunk now depends on Qt = 4.8, so no need to keep this directory
+on the tree.
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt-4.7/Skipped: Removed.
+
 2011-12-14  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, skip 2 tests failing on 32-bit GTK bot.


Modified: trunk/Tools/ChangeLog (102765 => 102766)

--- trunk/Tools/ChangeLog	2011-12-14 12:50:02 UTC (rev 102765)
+++ trunk/Tools/ChangeLog	2011-12-14 12:50:47 UTC (rev 102766)
@@ -1,3 +1,20 @@
+2011-12-14  João Paulo Rechi Vita  jprv...@openbossa.org
+
+[Qt] [Gardening] Remove qt-4.7 layout tests dir
+https://bugs.webkit.org/show_bug.cgi?id=74426
+
+Building trunk now depends on Qt = 4.8, so no need to keep this directory
+on the tree.
+
+Reviewed by Csaba Osztrogonác.
+
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort.qt_version):
+(QtPort.baseline_search_path):
+(QtPort._skipped_file_search_paths):
+* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
+(QtPortTest._assert_search_path):
+
 2011-12-14  Kentaro Hara  hara...@chromium.org
 
 [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (102765 => 102766)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2011-12-14 12:50:02 UTC (rev 102765)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py	2011-12-14 12:50:47 UTC (rev 102766)
@@ -109,7 +109,7 @@
 version = match.group('version')
 break
 except OSError:
-version = '4.7'
+version = '4.8'
 return version
 
 def baseline_search_path(self):
@@ -118,9 +118,7 @@
 search_paths.append(self._wk2_port_name())
 search_paths.append(self.name())
 version = self.qt_version()
-if '4.7' in version:
-search_paths.append('qt-4.7')
-elif '4.8' in version:
+if '4.8' in version:
 search_paths.append('qt-4.8')
 elif version:
 search_paths.append('qt-5.0')
@@ -130,9 +128,7 @@
 def _skipped_file_search_paths(self):
 search_paths = set([self.port_name, self.name()])
 version = self.qt_version()
-if '4.7' in version:
-search_paths.add('qt-4.7')
-elif '4.8' in version:
+if '4.8' in version:
 search_paths.add('qt-4.8')
 elif version:
 search_paths.add('qt-5.0')


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py (102765 => 102766)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2011-12-14 12:50:02 UTC (rev 102765)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py	2011-12-14 12:50:47 UTC (rev 102766)
@@ -41,7 +41,7 @@
 class QtPortTest(port_testcase.PortTestCase):
 port_maker = QtPort
 
-def _assert_search_path(self, search_paths, sys_platform, use_webkit2=False, qt_version='4.7'):
+def _assert_search_path(self, search_paths, sys_platform, use_webkit2=False, qt_version='4.8'):
 # FIXME: Port constructors should not parse the port name, but
 # rather be passed components (directly or via setters).  Once
 # we fix that, this method will need a re-write.
@@ -53,26 +53,24 @@
 self.assertEquals(port.baseline_search_path(), absolute_search_paths)
 
 def _qt_version(self, qt_version):
-if qt_version in '4.7':
-return 'QMake version 2.01a\nUsing Qt version 4.7.3 in /usr/local/Trolltech/Qt-4.7.3/lib'
 if qt_version in '4.8':

[webkit-changes] [102582] trunk

[alexis . menard]

Title: [102582] trunk








Revision 102582
Author alexis.men...@openbossa.org
Date 2011-12-12 07:39:28 -0800 (Mon, 12 Dec 2011)


Log Message
[Qt][WK2] History is not accessible in QML.
https://bugs.webkit.org/show_bug.cgi?id=73016

Reviewed by Simon Hausmann.

.: 

Add the new QWebNavigationHistory in the map file.

* Source/qtwebkit-export.map:

Source/WebKit/qt: 

Register QWebNavigationHistory and QWebNavigationListModel in the QML plugin.

* declarative/experimental/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2: 

Remove the old qwkhistory and create QWebNavigationHistory which is QML
friendly with data models you can plug to a view in QML

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didChangeBackForwardList):
(QQuickWebViewExperimental::navigationHistory):
(QQuickWebViewExperimental::goForwardTo):
(QQuickWebViewExperimental::goBackTo):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp: Added.
(QWebNavigationListModelPrivate::QWebNavigationListModelPrivate):
(QWebNavigationListModelPrivate::createWebNavigationModel):
(QWebNavigationHistoryPrivate::QWebNavigationHistoryPrivate):
(QWebNavigationHistoryPrivate::createHistory):
(QWebNavigationHistoryPrivate::reset):
(QWebNavigationHistoryPrivate::goBackTo):
(QWebNavigationHistoryPrivate::goForwardTo):
(QWebNavigationListModel::QWebNavigationListModel):
(QWebNavigationListModel::~QWebNavigationListModel):
(QWebNavigationListModel::rowCount):
(QWebNavigationListModel::data):
(QWebNavigationHistory::QWebNavigationHistory):
(QWebNavigationHistory::~QWebNavigationHistory):
(QWebNavigationHistory::backItems):
(QWebNavigationHistory::forwardItems):
* UIProcess/API/qt/qwebnavigationhistory_p.h: Added.
* UIProcess/API/qt/qwebnavigationhistory_p_p.h: Renamed from Source/WebKit2/UIProcess/qt/qwkhistory_p.h.
* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Added.
* UIProcess/qt/QtWebPageLoadClient.cpp:
(QtWebPageLoadClient::QtWebPageLoadClient):
(QtWebPageLoadClient::didChangeBackForwardList):
* UIProcess/qt/QtWebPageLoadClient.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::~QtWebPageProxy):
(QtWebPageProxy::goBackTo):
(QtWebPageProxy::goForwardTo):
(QtWebPageProxy::navigationHistory):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/qwkhistory.cpp: Removed.
* UIProcess/qt/qwkhistory.h: Removed.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageLoadClient.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h
trunk/Source/qtwebkit-export.map




Diff

Modified: trunk/ChangeLog (102581 => 102582)

--- trunk/ChangeLog	2011-12-12 15:24:36 UTC (rev 102581)
+++ trunk/ChangeLog	2011-12-12 15:39:28 UTC (rev 102582)
@@ -1,3 +1,14 @@
+2011-12-12  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] History is not accessible in QML.
+https://bugs.webkit.org/show_bug.cgi?id=73016
+
+Reviewed by Simon Hausmann.
+
+Add the new QWebNavigationHistory in the map file.
+
+* Source/qtwebkit-export.map:
+
 2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt] request parameter of QQuickWebView::navigationRequested is not a registered type


Modified: trunk/Source/WebKit/qt/ChangeLog (102581 => 102582)

--- trunk/Source/WebKit/qt/ChangeLog	2011-12-12 15:24:36 UTC (rev 102581)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-12-12 15:39:28 UTC (rev 102582)
@@ -1,3 +1,15 @@
+2011-12-12  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] History is not accessible in QML.
+https://bugs.webkit.org/show_bug.cgi?id=73016
+
+Reviewed by Simon Hausmann.
+
+Register QWebNavigationHistory and QWebNavigationListModel in the QML plugin.
+
+* declarative/experimental/plugin.cpp:
+(WebKitQmlPlugin::registerTypes):
+
 2011-12-09  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt] request parameter of QQuickWebView::navigationRequested is not a registered type


Modified: trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp (102581 => 102582)

--- trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp	2011-12-12 15:24:36 UTC (rev 102581)
+++ trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp	2011-12-12 15:39:28 UTC (rev 102582)
@@ -21,6 +21,8 @@
 #include qquickwebview_p.h
 #include qwebdownloaditem_p.h
 
+#include qwebnavigationhistory_p.h
+
 #include QtDeclarative/qdeclarative.h
 #include QtDe

[webkit-changes] [102597] trunk/Source/WebKit2

[alexis . menard]

Title: [102597] trunk/Source/WebKit2








Revision 102597
Author alexis.men...@openbossa.org
Date 2011-12-12 10:10:22 -0800 (Mon, 12 Dec 2011)


Log Message
Unreviewed cleanup fix.

Add missing files from https://bugs.webkit.org/show_bug.cgi?id=73016

Also remove the files that should be removed.

* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Added.
* UIProcess/qt/qwkhistory.cpp: Removed.
* UIProcess/qt/qwkhistory.h: Removed.
* UIProcess/qt/qwkhistory_p.h: Removed.

Modified Paths

trunk/Source/WebKit2/ChangeLog


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml


Removed Paths

trunk/Source/WebKit2/UIProcess/qt/qwkhistory.cpp
trunk/Source/WebKit2/UIProcess/qt/qwkhistory.h
trunk/Source/WebKit2/UIProcess/qt/qwkhistory_p.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102596 => 102597)

--- trunk/Source/WebKit2/ChangeLog	2011-12-12 18:03:46 UTC (rev 102596)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-12 18:10:22 UTC (rev 102597)
@@ -1,3 +1,16 @@
+2011-12-12  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed cleanup fix.
+
+Add missing files from https://bugs.webkit.org/show_bug.cgi?id=73016
+
+Also remove the files that should be removed.
+
+* UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Added.
+* UIProcess/qt/qwkhistory.cpp: Removed.
+* UIProcess/qt/qwkhistory.h: Removed.
+* UIProcess/qt/qwkhistory_p.h: Removed.
+
 2011-12-12  Michael Bruning  michael.brun...@nokia.com
 
 [qt][wk2] Postpone scroll effects when page transition is ongoing.


Added: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml (0 => 102597)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml	2011-12-12 18:10:22 UTC (rev 102597)
@@ -0,0 +1,108 @@
+import QtQuick 2.0
+import QtTest 1.0
+import QtWebKit 3.0
+import QtWebKit.experimental 3.0
+
+WebView {
+id: webView
+width: 400
+height: 300
+
+SignalSpy {
+id: spy
+target: webView
+signalName: loadSucceeded
+}
+
+ListView {
+id: backItemsList
+anchors.fill: parent
+model: webView.experimental.navigationHistory.backItems
+delegate:
+Text {
+color:black
+text: title :  + title
+}
+}
+
+ListView {
+id: forwardItemsList
+anchors.fill: parent
+model: webView.experimental.navigationHistory.forwardItems
+delegate:
+Text {
+color:black
+text: title :  + title
+}
+}
+
+TestCase {
+name: WebViewNavigationHistory
+
+function test_navigationHistory() {
+compare(spy.count, 0)
+compare(webView.loadProgress, 0)
+webView.load(Qt.resolvedUrl(../common/test1.html))
+spy.wait()
+compare(webView.canGoBack, false)
+compare(webView.canGoForward, false)
+compare(backItemsList.count, 0)
+compare(forwardItemsList.count, 0)
+spy.clear()
+webView.load(Qt.resolvedUrl(../common/test2.html))
+spy.wait()
+compare(webView.url, Qt.resolvedUrl(../common/test2.html))
+compare(webView.canGoBack, true)
+compare(webView.canGoForward, false)
+compare(backItemsList.count, 1)
+spy.clear()
+webView.experimental.goBackTo(0)
+spy.wait()
+compare(webView.url, Qt.resolvedUrl(../common/test1.html))
+compare(webView.canGoBack, false)
+compare(webView.canGoForward, true)
+compare(backItemsList.count, 0)
+compare(forwardItemsList.count, 1)
+spy.clear()
+webView.goForward()
+spy.wait()
+compare(webView.url, Qt.resolvedUrl(../common/test2.html))
+compare(webView.canGoBack, true)
+compare(webView.canGoForward, false)
+compare(backItemsList.count, 1)
+compare(forwardItemsList.count, 0)
+spy.clear()
+webView.load(Qt.resolvedUrl(../common/_javascript_.html))
+spy.wait()
+compare(webView.url, Qt.resolvedUrl(../common/_javascript_.html))
+compare(webView.canGoBack, true)
+compare(webView.canGoForward, false)
+compare(backItemsList.count, 2)
+compare(forwardItemsList.count, 0)
+spy.clear()
+webView.experimental.goBackTo(1)
+spy.wait()
+compare(webView.url, Qt.resolvedUrl(../common/test1.html))
+compare(webView.canGoBack, false)
+compare(webView.canGoForward, true)
+c

[webkit-changes] [102520] trunk/Source/WebKit2

[alexis . menard]

Title: [102520] trunk/Source/WebKit2








Revision 102520
Author alexis.men...@openbossa.org
Date 2011-12-10 05:55:21 -0800 (Sat, 10 Dec 2011)


Log Message
Unreviewed build fix for Qt.

Build error introduced by r102484.

* Target.pri:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102519 => 102520)

--- trunk/Source/WebKit2/ChangeLog	2011-12-10 09:54:37 UTC (rev 102519)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-10 13:55:21 UTC (rev 102520)
@@ -1,3 +1,11 @@
+2011-12-10  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed build fix for Qt.
+
+Build error introduced by r102484.
+
+* Target.pri:
+
 2011-12-09  Mark Rowe  mr...@apple.com
 
 Fix the Snow Leopard build some more.


Modified: trunk/Source/WebKit2/Target.pri (102519 => 102520)

--- trunk/Source/WebKit2/Target.pri	2011-12-10 09:54:37 UTC (rev 102519)
+++ trunk/Source/WebKit2/Target.pri	2011-12-10 13:55:21 UTC (rev 102520)
@@ -213,6 +213,7 @@
 UIProcess/WebApplicationCacheManagerProxy.h \
 UIProcess/WebConnectionToWebProcess.h \
 UIProcess/WebContext.h \
+UIProcess/WebContextConnectionClient.h \
 UIProcess/WebContextInjectedBundleClient.h \
 UIProcess/WebContextMenuProxy.h \
 UIProcess/WebContextUserMessageCoders.h \
@@ -535,6 +536,7 @@
 UIProcess/WebBackForwardList.cpp \
 UIProcess/WebConnectionToWebProcess.cpp \
 UIProcess/WebContext.cpp \
+UIProcess/WebContextConnectionClient.cpp \
 UIProcess/WebContextInjectedBundleClient.cpp \
 UIProcess/WebContextMenuProxy.cpp \
 UIProcess/WebCookieManagerProxy.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102522] trunk/Source/JavaScriptCore

[alexis . menard]

Title: [102522] trunk/Source/_javascript_Core








Revision 102522
Author alexis.men...@openbossa.org
Date 2011-12-10 09:13:07 -0800 (Sat, 10 Dec 2011)


Log Message
Unused variable in YarrJIT.cpp.
https://bugs.webkit.org/show_bug.cgi?id=74237

Reviewed by Andreas Kling.

Variable is set but not used so we can remove it.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102521 => 102522)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-10 14:50:55 UTC (rev 102521)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-10 17:13:07 UTC (rev 102522)
@@ -1,3 +1,15 @@
+2011-12-10  Alexis Menard  alexis.men...@openbossa.org
+
+Unused variable in YarrJIT.cpp.
+https://bugs.webkit.org/show_bug.cgi?id=74237
+
+Reviewed by Andreas Kling.
+
+Variable is set but not used so we can remove it.
+
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
+
 2011-12-09  Filip Pizlo  fpi...@apple.com
 
 DFG ArithMul power-of-two case does not check for overflow


Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (102521 => 102522)

--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2011-12-10 14:50:55 UTC (rev 102521)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp	2011-12-10 17:13:07 UTC (rev 102522)
@@ -675,7 +675,6 @@
 const RegisterID character = regT0;
 int maxCharactersAtOnce = m_charSize == Char8 ? 4 : 2;
 unsigned ignoreCaseMask = 0;
-unsigned currentCharacterMask = m_charSize == Char8 ? 0xff : 0x;
 int allCharacters = ch;
 int numberCharacters;
 int startTermPosition = term-inputPosition;
@@ -699,7 +698,6 @@
 nextOp-m_isDeadCode = true;
 
 int shiftAmount = (m_charSize == Char8 ? 8 : 16) * numberCharacters;
-currentCharacterMask = (m_charSize == Char8 ? 0xff : 0x)  shiftAmount;  
 
 UChar currentCharacter = nextTerm-patternCharacter;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101171] trunk/Source/WebKit/qt

[alexis . menard]

Title: [101171] trunk/Source/WebKit/qt








Revision 101171
Author alexis.men...@openbossa.org
Date 2011-11-25 06:35:08 -0800 (Fri, 25 Nov 2011)


Log Message
[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
https://bugs.webkit.org/show_bug.cgi?id=73132

Reviewed by Simon Hausmann.

Make sure QWebDownloadItem is registered in the right plugin.

* declarative/experimental/plugin.cpp:
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Modified Paths

trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp
trunk/Source/WebKit/qt/declarative/plugin.cpp




Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (101170 => 101171)

--- trunk/Source/WebKit/qt/ChangeLog	2011-11-25 14:32:21 UTC (rev 101170)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-11-25 14:35:08 UTC (rev 101171)
@@ -1,3 +1,16 @@
+2011-11-25  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
+https://bugs.webkit.org/show_bug.cgi?id=73132
+
+Reviewed by Simon Hausmann.
+
+Make sure QWebDownloadItem is registered in the right plugin.
+
+* declarative/experimental/plugin.cpp:
+* declarative/plugin.cpp:
+(WebKitQmlPlugin::registerTypes):
+
 2011-11-22  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: remove Inspector::bringToFront from the protocol.


Modified: trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp (101170 => 101171)

--- trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp	2011-11-25 14:32:21 UTC (rev 101170)
+++ trunk/Source/WebKit/qt/declarative/experimental/plugin.cpp	2011-11-25 14:35:08 UTC (rev 101171)
@@ -19,6 +19,7 @@
 
 #include qquickwebpage_p.h
 #include qquickwebview_p.h
+#include qwebdownloaditem_p.h
 
 #include QtDeclarative/qdeclarative.h
 #include QtDeclarative/qdeclarativeextensionplugin.h
@@ -40,6 +41,7 @@
 {
 Q_ASSERT(QLatin1String(uri) == QLatin1String(QtWebKit.experimental));
 
+qmlRegisterUncreatableTypeQWebDownloadItem(uri, 3, 0, DownloadItem, QObject::tr(Cannot create separate instance of DownloadItem));
 qmlRegisterExtendedTypeQQuickWebView, QQuickWebViewExperimentalExtension(uri, 3, 0, WebView);
 qmlRegisterUncreatableTypeQQuickWebViewExperimental(uri, 3, 0, QQuickWebViewExperimental,
 QObject::tr(Cannot create separate instance of QQuickWebViewExperimental));


Modified: trunk/Source/WebKit/qt/declarative/plugin.cpp (101170 => 101171)

--- trunk/Source/WebKit/qt/declarative/plugin.cpp	2011-11-25 14:32:21 UTC (rev 101170)
+++ trunk/Source/WebKit/qt/declarative/plugin.cpp	2011-11-25 14:35:08 UTC (rev 101171)
@@ -25,7 +25,6 @@
 #if defined(HAVE_WEBKIT2)
 #include qquickwebpage_p.h
 #include qquickwebview_p.h
-#include qwebdownloaditem_p.h
 #include qwebpreferences_p.h
 
 #include QtNetwork/qnetworkreply.h
@@ -52,7 +51,6 @@
 qmlRegisterUncreatableTypeQWebPreferences(uri, 3, 0, WebPreferences, QObject::tr(Cannot create separate instance of WebPreferences));
 qmlRegisterUncreatableTypeQQuickWebPage(uri, 3, 0, WebPage, QObject::tr(Cannot create separate instance of WebPage, use WebView));
 qmlRegisterUncreatableTypeQNetworkReply(uri, 3, 0, NetworkReply, QObject::tr(Cannot create separate instance of NetworkReply));
-qmlRegisterUncreatableTypeQWebDownloadItem(uri, 5, 0, DownloadItem, QObject::tr(Cannot create separate instance of DownloadItem));
 #endif
 }
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100950] trunk/Source/WebKit2

[alexis . menard]

Title: [100950] trunk/Source/WebKit2








Revision 100950
Author alexis.men...@openbossa.org
Date 2011-11-21 13:06:41 -0800 (Mon, 21 Nov 2011)


Log Message
[Qt] Remove unnecessary initialize method from QQuickWebView.
https://bugs.webkit.org/show_bug.cgi?id=72905

Reviewed by Kenneth Rohde Christiansen.

We don't need this level of indirection.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):
* UIProcess/API/qt/qquickwebview_p_p.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100949 => 100950)

--- trunk/Source/WebKit2/ChangeLog	2011-11-21 21:06:14 UTC (rev 100949)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-21 21:06:41 UTC (rev 100950)
@@ -1,3 +1,17 @@
+2011-11-21  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Remove unnecessary initialize method from QQuickWebView.
+https://bugs.webkit.org/show_bug.cgi?id=72905
+
+Reviewed by Kenneth Rohde Christiansen.
+
+We don't need this level of indirection.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::QQuickWebViewPrivate):
+(QQuickWebView::QQuickWebView):
+* UIProcess/API/qt/qquickwebview_p_p.h:
+
 2011-11-21  Jesus Sanchez-Palencia  jesus.palen...@openbossa.org
 
 [Qt][WK2] Implement loadHtml API for QQuickWebView


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (100949 => 100950)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-21 21:06:14 UTC (rev 100949)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-21 21:06:41 UTC (rev 100950)
@@ -36,8 +36,8 @@
 #include QtWidgets/QInputDialog
 #include WKOpenPanelResultListener.h
 
-QQuickWebViewPrivate::QQuickWebViewPrivate()
-: q_ptr(0)
+QQuickWebViewPrivate::QQuickWebViewPrivate(QQuickWebView* viewport, WKContextRef contextRef, WKPageGroupRef pageGroupRef)
+: q_ptr(viewport)
 , alertDialog(0)
 , confirmDialog(0)
 , promptDialog(0)
@@ -45,6 +45,19 @@
 , transitioningToNewPage(false)
 , useTraditionalDesktopBehaviour(false)
 {
+viewport-setFlags(QQuickItem::ItemClipsChildrenToShape);
+
+QObject::connect(viewport, SIGNAL(visibleChanged()), viewport, SLOT(_q_onVisibleChanged()));
+pageView.reset(new QQuickWebPage(viewport));
+
+QQuickWebPagePrivate* const pageViewPrivate = pageView.data()-d;
+setPageProxy(new QtWebPageProxy(pageView.data(), q_ptr, 0, this, contextRef, pageGroupRef));
+pageViewPrivate-setPageProxy(pageProxy.data());
+
+QWebPreferencesPrivate::get(pageProxy-preferences())-setAttribute(QWebPreferencesPrivate::AcceleratedCompositingEnabled, true);
+pageProxy-init();
+
+QObject::connect(pageProxy.data(), SIGNAL(updateNavigationState()), q_ptr, SIGNAL(navigationStateChanged()));
 }
 
 void QQuickWebViewPrivate::enableMouseEvents()
@@ -65,24 +78,6 @@
 pageView-setAcceptHoverEvents(false);
 }
 
-void QQuickWebViewPrivate::initialize(QQuickWebView* viewport, WKContextRef contextRef, WKPageGroupRef pageGroupRef)
-{
-q_ptr = viewport;
-viewport-setFlags(QQuickItem::ItemClipsChildrenToShape);
-
-QObject::connect(viewport, SIGNAL(visibleChanged()), viewport, SLOT(_q_onVisibleChanged()));
-pageView.reset(new QQuickWebPage(viewport));
-
-QQuickWebPagePrivate* const pageViewPrivate = pageView.data()-d;
-setPageProxy(new QtWebPageProxy(pageView.data(), q_ptr, 0, this, contextRef, pageGroupRef));
-pageViewPrivate-setPageProxy(pageProxy.data());
-
-QWebPreferencesPrivate::get(pageProxy-preferences())-setAttribute(QWebPreferencesPrivate::AcceleratedCompositingEnabled, true);
-pageProxy-init();
-
-QObject::connect(pageProxy.data(), SIGNAL(updateNavigationState()), q_ptr, SIGNAL(navigationStateChanged()));
-}
-
 void QQuickWebViewPrivate::initializeDesktop(QQuickWebView* viewport)
 {
 if (interactionEngine) {
@@ -474,21 +469,19 @@
 
 QQuickWebView::QQuickWebView(QQuickItem* parent)
 : QQuickItem(parent)
-, d_ptr(new QQuickWebViewPrivate)
+, d_ptr(new QQuickWebViewPrivate(this))
 , m_experimental(new QQuickWebViewExperimental(this))
 {
 Q_D(QQuickWebView);
-d-initialize(this);
 d-initializeTouch(this);
 }
 
 QQuickWebView::QQuickWebView(WKContextRef contextRef, WKPageGroupRef pageGroupRef, QQuickItem* parent)
 : QQuickItem(parent)
-, d_ptr(new QQuickWebViewPrivate)
+, d_ptr(new QQuickWebViewPrivate(this, contextRef, pageGroupRef))
 , m_experimental(new QQuickWebViewExperimental(this))
 {
 Q_D(QQuickWebView);
-d-initialize(this, contextRef, pageGroupRef);
 // Used by WebKitTestRunner.
 d-setUseTraditionalDesktopBehaviour(true);
 }


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h (100949 => 100950)

--- trunk/Source/WebKit2/UIProce

[webkit-changes] [100955] trunk/Source/WebKit2

[alexis . menard]

Title: [100955] trunk/Source/WebKit2








Revision 100955
Author alexis.men...@openbossa.org
Date 2011-11-21 13:45:30 -0800 (Mon, 21 Nov 2011)


Log Message
[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
https://bugs.webkit.org/show_bug.cgi?id=72612

Reviewed by Kenneth Rohde Christiansen.

Make sure that when the view is focused, the page knows about it.
Also set a the view to be the focused item in the failing tests.

* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::focusInEvent):
(QQuickWebView::focusOutEvent):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::isViewFocused):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100954 => 100955)

--- trunk/Source/WebKit2/ChangeLog	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-21 21:45:30 UTC (rev 100955)
@@ -1,3 +1,22 @@
+2011-11-21  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] REGRESSION(100483): It made 2 API tests fail
+https://bugs.webkit.org/show_bug.cgi?id=72612
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Make sure that when the view is focused, the page knows about it.
+Also set a the view to be the focused item in the failing tests.
+
+* UIProcess/API/qt/qquickwebpage_p.h:
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::focusInEvent):
+(QQuickWebView::focusOutEvent):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::isViewFocused):
+
 2011-11-21  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Speed up debug builds.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h (100954 => 100955)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebpage_p.h	2011-11-21 21:45:30 UTC (rev 100955)
@@ -72,6 +72,7 @@
 Q_PRIVATE_SLOT(d, void _q_onSceneGraphInitialized());
 
 QQuickWebPagePrivate* d;
+friend class QQuickWebView;
 friend class QQuickWebViewPrivate;
 friend class QtWebPageProxy;
 };


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (100954 => 100955)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-21 21:45:30 UTC (rev 100955)
@@ -603,6 +603,18 @@
 }
 }
 
+void QQuickWebView::focusInEvent(QFocusEvent* event)
+{
+Q_D(QQuickWebView);
+d-pageView-event(event);
+}
+
+void QQuickWebView::focusOutEvent(QFocusEvent* event)
+{
+Q_D(QQuickWebView);
+d-pageView-event(event);
+}
+
 void QQuickWebView::touchEvent(QTouchEvent* event)
 {
 forceActiveFocus();


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (100954 => 100955)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-11-21 21:45:30 UTC (rev 100955)
@@ -115,6 +115,8 @@
 
 protected:
 virtual void geometryChanged(const QRectF, const QRectF);
+virtual void focusInEvent(QFocusEvent*);
+virtual void focusOutEvent(QFocusEvent*);
 virtual void touchEvent(QTouchEvent* event);
 
 private:


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml (100954 => 100955)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml	2011-11-21 21:45:30 UTC (rev 100955)
@@ -7,6 +7,7 @@
 id: webView
 width: 200
 height: 400
+focus: true
 
 property string lastUrl
 property string lastTitle


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (100954 => 100955)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-11-21 21:40:34 UTC (rev 100954)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-11-21 21:45:30 UTC (rev 100955)
@@ -493,7 +493,7 @@
 
 bool QtWebPageProxy::isViewFocused()
 {
-return m_qmlWebPage-hasFocus();
+return m_qmlWebView-hasFocus();
 }
 
 bool QtWebPageProxy::isViewVisible()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.

[webkit-changes] [100617] trunk/Source/WebKit2

[alexis . menard]

Title: [100617] trunk/Source/WebKit2








Revision 100617
Author alexis.men...@openbossa.org
Date 2011-11-17 06:51:52 -0800 (Thu, 17 Nov 2011)


Log Message
[Qt][WK2] Cleanup dead code in QtWebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=72608

Reviewed by Simon Hausmann.

Remove some dead code after we merged our views.
QQuickWebView is now using AC which means that this
path is never called now.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didReceiveDownloadResponse):
* UIProcess/qt/QtWebPageProxy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (100616 => 100617)

--- trunk/Source/WebKit2/ChangeLog	2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-17 14:51:52 UTC (rev 100617)
@@ -1,3 +1,18 @@
+2011-11-17  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] Cleanup dead code in QtWebPageProxy.
+https://bugs.webkit.org/show_bug.cgi?id=72608
+
+Reviewed by Simon Hausmann.
+
+Remove some dead code after we merged our views.
+QQuickWebView is now using AC which means that this
+path is never called now.
+
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::didReceiveDownloadResponse):
+* UIProcess/qt/QtWebPageProxy.h:
+
 2011-11-17  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Remove forwarding header for WebKit2 C API


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (100616 => 100617)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-11-17 14:51:52 UTC (rev 100617)
@@ -607,14 +607,6 @@
 m_viewInterface-didChangeLoadProgress(newLoadProgress);
 }
 
-void QtWebPageProxy::paint(QPainter* painter, const QRect area)
-{
-if (m_webPageProxy-isValid())
-paintContent(painter, area);
-else
-painter-fillRect(area, Qt::white);
-}
-
 bool QtWebPageProxy::canGoBack() const
 {
 return m_webPageProxy-canGoBack();
@@ -821,13 +813,6 @@
 m_viewInterface-downloadRequested(download);
 }
 
-void QtWebPageProxy::paintContent(QPainter* painter, const QRect area)
-{
-// FIXME: Do something with the unpainted region?
-WebCore::Region unpaintedRegion;
-static_castDrawingAreaProxyImpl*(m_webPageProxy-drawingArea())-paint(painter, area, unpaintedRegion);
-}
-
 PassOwnPtrDrawingAreaProxy QtWebPageProxy::createDrawingAreaProxy()
 {
 return DrawingAreaProxyImpl::create(m_webPageProxy.get());


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h (100616 => 100617)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h	2011-11-17 14:49:35 UTC (rev 100616)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h	2011-11-17 14:51:52 UTC (rev 100617)
@@ -147,8 +147,6 @@
 void didChangeLoadProgress(int);
 int loadProgress() const { return m_loadProgress; }
 
-void paint(QPainter*, const QRect);
-
 bool canGoBack() const;
 void goBack();
 bool canGoForward() const;
@@ -211,7 +209,6 @@
 Q_SIGNAL void receivedMessageFromNavigatorQtObject(const QVariantMap);
 
 protected:
-virtual void paintContent(QPainter* painter, const QRect area);
 RefPtrWebKit::WebPageProxy m_webPageProxy;
 WebKit::QtViewInterface* const m_viewInterface;
 QtViewportInteractionEngine* m_interactionEngine;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [99952] trunk

[alexis . menard]

Title: [99952] trunk








Revision 99952
Author alexis.men...@openbossa.org
Date 2011-11-11 05:19:06 -0800 (Fri, 11 Nov 2011)


Log Message
[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.: 

Add the new private QML module in the build.

* Source/QtWebKit.pro:

Source/WebKit/qt: 

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

* declarative/private/plugin.cpp: Added.
(WebKitQmlPluginPrivate::registerTypes):
* declarative/private/private.pro: Added.
* declarative/private/qmldir: Added.

Source/WebKit2: 

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.
(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):
* UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.

Modified Paths

trunk/ChangeLog
trunk/Source/QtWebKit.pro
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h


Added Paths

trunk/Source/WebKit/qt/declarative/private/
trunk/Source/WebKit/qt/declarative/private/plugin.cpp
trunk/Source/WebKit/qt/declarative/private/private.pro
trunk/Source/WebKit/qt/declarative/private/qmldir
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebviewprivateextension.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebviewprivateextension_p.h




Diff

Modified: trunk/ChangeLog (99951 => 99952)

--- trunk/ChangeLog	2011-11-11 13:12:50 UTC (rev 99951)
+++ trunk/ChangeLog	2011-11-11 13:19:06 UTC (rev 99952)
@@ -1,3 +1,14 @@
+2011-11-11  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Add a way to have experimental features in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=67707
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add the new private QML module in the build.
+
+* Source/QtWebKit.pro:
+
 2011-11-10  Balazs Kelemen  kbal...@webkit.org
 
 [Qt] X11 plugins need to be reworked for Qt5


Modified: trunk/Source/QtWebKit.pro (99951 => 99952)

--- trunk/Source/QtWebKit.pro	2011-11-11 13:12:50 UTC (rev 99951)
+++ trunk/Source/QtWebKit.pro	2011-11-11 13:19:06 UTC (rev 99952)
@@ -18,6 +18,9 @@
 include(WebKit/qt/docs/docs.pri)
 
 SUBDIRS += WebKit/qt/declarative
+haveQt(5) {
+SUBDIRS += WebKit/qt/declarative/private
+}
 
 tests.file = tests.pri
 SUBDIRS += tests


Modified: trunk/Source/WebKit/qt/ChangeLog (99951 => 99952)

--- trunk/Source/WebKit/qt/ChangeLog	2011-11-11 13:12:50 UTC (rev 99951)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-11-11 13:19:06 UTC (rev 99952)
@@ -1,3 +1,19 @@
+2011-11-11  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt] Add a way to have experimental features in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=67707
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This patch is adding a new module for accessing private
+method and property from the view. It requires an import
+QtWebKit.private in QML to be used.
+
+* declarative/private/plugin.cpp: Added.
+(WebKitQmlPluginPrivate::registerTypes):
+* declarative/private/private.pro: Added.
+* declarative/private/qmldir: Added.
+
 2011-11-11  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt][WK2] Remove QWebNavigationController


Added: trunk/Source/WebKit/qt/declarative/private/plugin.cpp (0 => 99952)

--- trunk/Source/WebKit/qt/declarative/private/plugin.cpp	(rev 0)
+++ trunk/Source/WebKit/qt/declarative/private/plugin.cpp	2011-11-11 13:19:06 UTC (rev 99952)
@@ -0,0 +1,47 @@
+/*
+Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies)
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Library General Public License for more details.
+
+You should have received a copy of the GNU Library General Public License
+along with this library; see the file COPYING.LIB.  If not, write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA 02110-1301, USA.
+*/
+
+#incl

[webkit-changes] [100038] trunk/Source/WebCore

[alexis . menard]

Title: [100038] trunk/Source/WebCore








Revision 100038
Author alexis.men...@openbossa.org
Date 2011-11-11 15:44:59 -0800 (Fri, 11 Nov 2011)


Log Message
[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

* platform/qt/ScrollbarThemeQt.h:
(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (100037 => 100038)

--- trunk/Source/WebCore/ChangeLog	2011-11-11 23:43:00 UTC (rev 100037)
+++ trunk/Source/WebCore/ChangeLog	2011-11-11 23:44:59 UTC (rev 100038)
@@ -1,3 +1,17 @@
+2011-11-11  Alexis Menard  alexis.men...@openbossa.org
+
+[Qt][WK2] Make sure Scrollbars are in their own layer.
+https://bugs.webkit.org/show_bug.cgi?id=72064
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Make sure we render our scrollbars in a separate layer.
+
+No new tests : existing ones should cover.
+
+* platform/qt/ScrollbarThemeQt.h:
+(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):
+
 2011-11-11  Joel Webber  j...@google.com
 
 Repaint broken when children of filtered SVG elements are updated


Modified: trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.h (100037 => 100038)

--- trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.h	2011-11-11 23:43:00 UTC (rev 100037)
+++ trunk/Source/WebCore/platform/qt/ScrollbarThemeQt.h	2011-11-11 23:44:59 UTC (rev 100038)
@@ -56,6 +56,8 @@
 
 virtual int scrollbarThickness(ScrollbarControlSize = RegularScrollbar);
 
+virtual bool usesOverlayScrollbars() const { return true; }
+
 QStyle* style() const;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [98951] trunk/Source/WebKit/qt

[alexis . menard]

Title: [98951] trunk/Source/WebKit/qt








Revision 98951
Author alexis.men...@openbossa.org
Date 2011-11-01 05:34:15 -0700 (Tue, 01 Nov 2011)


Log Message
Unreviewed Qt documentation fix.

This signal is Qt 4.8 material.

* Api/qwebpage.cpp:

Modified Paths

trunk/Source/WebKit/qt/Api/qwebpage.cpp
trunk/Source/WebKit/qt/ChangeLog




Diff

Modified: trunk/Source/WebKit/qt/Api/qwebpage.cpp (98950 => 98951)

--- trunk/Source/WebKit/qt/Api/qwebpage.cpp	2011-11-01 11:36:17 UTC (rev 98950)
+++ trunk/Source/WebKit/qt/Api/qwebpage.cpp	2011-11-01 12:34:15 UTC (rev 98951)
@@ -3924,7 +3924,7 @@
 }
 
 /*!
-\since 4.7
+\since 4.8
 \fn void QWebPage::viewportChangeRequested()
 
 Page authors can provide the supplied values by using the viewport meta tag. More information


Modified: trunk/Source/WebKit/qt/ChangeLog (98950 => 98951)

--- trunk/Source/WebKit/qt/ChangeLog	2011-11-01 11:36:17 UTC (rev 98950)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-11-01 12:34:15 UTC (rev 98951)
@@ -1,3 +1,11 @@
+2011-11-01  Alexis Menard  alexis.men...@openbossa.org
+
+Unreviewed Qt documentation fix.
+
+This signal is Qt 4.8 material.
+
+* Api/qwebpage.cpp:
+
 2011-10-31  Mark Hahnenberg  mhahnenb...@apple.com
 
 De-virtualize JSObject::defineGetter






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes