from:"carlosgc"

[webkit-changes] [293166] releases/WebKitGTK/webkit-2.36.1/

2022-04-21 Thread carlosgc

Title: [293166] releases/WebKitGTK/webkit-2.36.1/








Revision 293166
Author carlo...@webkit.org
Date 2022-04-21 05:14:17 -0700 (Thu, 21 Apr 2022)


Log Message
WebKitGTK 2.36.1

Added Paths

releases/WebKitGTK/webkit-2.36.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293165] releases/WebKitGTK/webkit-2.36

2022-04-21 Thread carlosgc

Title: [293165] releases/WebKitGTK/webkit-2.36








Revision 293165
Author carlo...@webkit.org
Date 2022-04-21 05:13:45 -0700 (Thu, 21 Apr 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.1 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.36.1.

Modified Paths

releases/WebKitGTK/webkit-2.36/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (293164 => 293165)

--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-04-21 11:41:17 UTC (rev 293164)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-04-21 12:13:45 UTC (rev 293165)
@@ -1,3 +1,9 @@
+2022-04-21  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.1 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-03-25  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.0 release


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (293164 => 293165)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 11:41:17 UTC (rev 293164)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 12:13:45 UTC (rev 293165)
@@ -1,3 +1,9 @@
+2022-04-21  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.1 release
+
+* gtk/NEWS: Add release notes for 2.36.1.
+
 2022-04-08  Philippe Normand  
 
 [WPE][2.36] Build with a11y disabled fails


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS (293164 => 293165)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-04-21 11:41:17 UTC (rev 293164)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-04-21 12:13:45 UTC (rev 293165)
@@ -1,4 +1,14 @@
 
+WebKitGTK 2.36.1
+
+
+What's new in WebKitGTK 2.36.1?
+
+  - Fix the build with accessibility disabled.
+  - Fix several crashes and rendering issues.
+  - Translation updates: Croatian.
+
+
 WebKitGTK 2.36.0
 
 


Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake (293164 => 293165)

--- releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-04-21 11:41:17 UTC (rev 293164)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-04-21 12:13:45 UTC (rev 293165)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 36 0)
+SET_PROJECT_VERSION(2 36 1)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 4 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 4 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 5 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 5 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 4 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 4 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 5 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 5 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293164] releases/WebKitGTK/webkit-2.36/Tools

2022-04-21 Thread carlosgc

Title: [293164] releases/WebKitGTK/webkit-2.36/Tools








Revision 293164
Author carlo...@webkit.org
Date 2022-04-21 04:41:17 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r293163 - [GTK][WPE] Make make-dist script python3 only
https://bugs.webkit.org/show_bug.cgi?id=239596

Reviewed by Adrian Perez de Castro.

It fails with python2 since r291934.

* Scripts/make-dist:

Modified Paths

releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/Scripts/make-dist




Diff

Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (293163 => 293164)

--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-04-21 11:40:05 UTC (rev 293163)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-04-21 11:41:17 UTC (rev 293164)
@@ -1,3 +1,14 @@
+2022-04-21  Carlos Garcia Campos  
+
+[GTK][WPE] Make make-dist script python3 only
+https://bugs.webkit.org/show_bug.cgi?id=239596
+
+Reviewed by Adrian Perez de Castro.
+
+It fails with python2 since r291934.
+
+* Scripts/make-dist:
+
 2022-03-25  Adrian Perez de Castro  
 
 [WPE][GTK] Dist/distcheck targets fail due to Python error


Modified: releases/WebKitGTK/webkit-2.36/Tools/Scripts/make-dist (293163 => 293164)

--- releases/WebKitGTK/webkit-2.36/Tools/Scripts/make-dist	2022-04-21 11:40:05 UTC (rev 293163)
+++ releases/WebKitGTK/webkit-2.36/Tools/Scripts/make-dist	2022-04-21 11:41:17 UTC (rev 293164)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or
@@ -297,7 +297,7 @@
 
 pkgconfig_file = os.path.join(arguments.build_dir, "Source/WebKit/webkit2gtk-4.1.pc")
 if os.path.isfile(pkgconfig_file):
-p = subprocess.Popen(['pkg-config', '--modversion', pkgconfig_file], stdout=subprocess.PIPE)
+p = subprocess.Popen(['pkg-config', '--modversion', pkgconfig_file], stdout=subprocess.PIPE, text="ascii")
 version = p.communicate()[0]
 if version:
 arguments.version = version.rstrip('\n')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293163] trunk/Tools

2022-04-21 Thread carlosgc

Title: [293163] trunk/Tools








Revision 293163
Author carlo...@webkit.org
Date 2022-04-21 04:40:05 -0700 (Thu, 21 Apr 2022)


Log Message
[GTK][WPE] Make make-dist script python3 only
https://bugs.webkit.org/show_bug.cgi?id=239596

Reviewed by Adrian Perez de Castro.

It fails with python2 since r291934.

* Scripts/make-dist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/make-dist




Diff

Modified: trunk/Tools/ChangeLog (293162 => 293163)

--- trunk/Tools/ChangeLog	2022-04-21 10:53:04 UTC (rev 293162)
+++ trunk/Tools/ChangeLog	2022-04-21 11:40:05 UTC (rev 293163)
@@ -1,3 +1,14 @@
+2022-04-21  Carlos Garcia Campos  
+
+[GTK][WPE] Make make-dist script python3 only
+https://bugs.webkit.org/show_bug.cgi?id=239596
+
+Reviewed by Adrian Perez de Castro.
+
+It fails with python2 since r291934.
+
+* Scripts/make-dist:
+
 2022-04-20  Yusuke Suzuki  
 
 Generate well-formed JSON for compile_commands.json


Modified: trunk/Tools/Scripts/make-dist (293162 => 293163)

--- trunk/Tools/Scripts/make-dist	2022-04-21 10:53:04 UTC (rev 293162)
+++ trunk/Tools/Scripts/make-dist	2022-04-21 11:40:05 UTC (rev 293163)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # Copyright (C) 2014 Igalia S.L.
 #
 # This library is free software; you can redistribute it and/or
@@ -297,7 +297,7 @@
 
 pkgconfig_file = os.path.join(arguments.build_dir, "Source/WebKit/webkit2gtk-4.1.pc")
 if os.path.isfile(pkgconfig_file):
-p = subprocess.Popen(['pkg-config', '--modversion', pkgconfig_file], stdout=subprocess.PIPE)
+p = subprocess.Popen(['pkg-config', '--modversion', pkgconfig_file], stdout=subprocess.PIPE, text="ascii")
 version = p.communicate()[0]
 if version:
 arguments.version = version.rstrip('\n')






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293160] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-04-21 Thread carlosgc

Title: [293160] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 293160
Author carlo...@webkit.org
Date 2022-04-21 02:51:44 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r292901 - [GTK] AddressSanitizer: heap-buffer-overflow in WebCore::Length::ref()
https://bugs.webkit.org/show_bug.cgi?id=237389

Reviewed by Žan Doberšek.

* platform/graphics/nicosia/NicosiaAnimation.cpp:
(Nicosia::createThreadsafeKeyFrames): Convert Length members of transform functions to
the fixed variety before they are moved to separate threads.
(Nicosia::Animation::Animation): Use the new helper.
* platform/graphics/transforms/TranslateTransformOperation.h: Added setters.

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (293159 => 293160)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:40 UTC (rev 293159)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:44 UTC (rev 293160)
@@ -1,3 +1,16 @@
+2022-04-14  Martin Robinson  
+
+[GTK] AddressSanitizer: heap-buffer-overflow in WebCore::Length::ref()
+https://bugs.webkit.org/show_bug.cgi?id=237389
+
+Reviewed by Žan Doberšek.
+
+* platform/graphics/nicosia/NicosiaAnimation.cpp:
+(Nicosia::createThreadsafeKeyFrames): Convert Length members of transform functions to
+the fixed variety before they are moved to separate threads.
+(Nicosia::Animation::Animation): Use the new helper.
+* platform/graphics/transforms/TranslateTransformOperation.h: Added setters.
+
 2022-04-01  Carlos Garcia Campos  
 
 REGRESSION(r290360): [GLX] Crash on process exit


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.cpp (293159 => 293160)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.cpp	2022-04-21 09:51:40 UTC (rev 293159)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/nicosia/NicosiaAnimation.cpp	2022-04-21 09:51:44 UTC (rev 293160)
@@ -21,6 +21,7 @@
 #include "NicosiaAnimation.h"
 
 #include "LayoutSize.h"
+#include "TranslateTransformOperation.h"
 
 namespace Nicosia {
 
@@ -166,9 +167,35 @@
 return CubicBezierTimingFunction::defaultTimingFunction();
 }
 
+static KeyframeValueList createThreadsafeKeyFrames(const KeyframeValueList& originalKeyframes, const FloatSize& boxSize)
+{
+if (originalKeyframes.property() != AnimatedPropertyTransform)
+return originalKeyframes;
+
+// Currently translation operations are the only transform operations that store a non-fixed
+// Length. Some Lengths, in particular those for calc() operations, are not thread-safe or
+// multiprocess safe, because they maintain indices into a shared HashMap of CalculationValues.
+// This code converts all possible unsafe Length parameters to fixed Lengths, which are safe to
+// use in other threads and across IPC channels.
+KeyframeValueList keyframes = originalKeyframes;
+for (unsigned i = 0; i < keyframes.size(); i++) {
+const auto& transformValue = static_cast(keyframes.at(i));
+for (auto& operation : transformValue.value().operations()) {
+if (is(operation)) {
+TranslateTransformOperation* translation = static_cast(operation.get());
+translation->setX(Length(translation->xAsFloat(boxSize), LengthType::Fixed));
+translation->setY(Length(translation->yAsFloat(boxSize), LengthType::Fixed));
+translation->setZ(Length(translation->zAsFloat(), LengthType::Fixed));
+}
+}
+}
+
+return keyframes;
+}
+
 Animation::Animation(const String& name, const KeyframeValueList& keyframes, const FloatSize& boxSize, const WebCore::Animation& animation, bool listsMatch, MonotonicTime startTime, Seconds pauseTime, AnimationState state)
 : m_name(name.isSafeToSendToAnotherThread() ? name : name.isolatedCopy())
-, m_keyframes(keyframes)
+, m_keyframes(createThreadsafeKeyFrames(keyframes, boxSize))
 , m_boxSize(boxSize)
 , m_timingFunction(animation.timingFunction()->clone())
 , m_iterationCount(animation.iterationCount())


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h (293159 => 293160)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h	2022-04-21 09:51:40 UTC (rev 293159)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h	2022-04-21 09:51:44 UTC (rev 293160)
@@ -58,6 +58,10 @@
 Length y() const { return m_y; }
 Length z() const { return m

[webkit-changes] [293159] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-04-21 Thread carlosgc

Title: [293159] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 293159
Author carlo...@webkit.org
Date 2022-04-21 02:51:40 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r292628 - [WPE][2.36] Build with a11y disabled fails
https://bugs.webkit.org/show_bug.cgi?id=239004

Patch by Philippe Normand  on 2022-04-08
Reviewed by Michael Catanzaro.

Add accessibility build guards.

* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::launch const):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (293158 => 293159)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:51:36 UTC (rev 293158)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:51:40 UTC (rev 293159)
@@ -1,3 +1,16 @@
+2022-04-08  Philippe Normand  
+
+[WPE][2.36] Build with a11y disabled fails
+https://bugs.webkit.org/show_bug.cgi?id=239004
+
+Reviewed by Michael Catanzaro.
+
+Add accessibility build guards.
+
+* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
+(WebKit::XDGDBusProxy::XDGDBusProxy):
+(WebKit::XDGDBusProxy::launch const):
+
 2022-04-01  Carlos Garcia Campos  
 
 REGRESSION(r290360): [GLX] Crash on process exit


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp (293158 => 293159)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-04-21 09:51:36 UTC (rev 293158)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-04-21 09:51:40 UTC (rev 293159)
@@ -49,7 +49,9 @@
 m_dbusAddress = g_getenv("DBUS_SESSION_BUS_ADDRESS");
 break;
 case Type::AccessibilityBus:
+#if ENABLE(ACCESSIBILITY)
 m_dbusAddress = WebCore::PlatformDisplay::sharedDisplay().accessibilityBusAddress().utf8();
+#endif
 break;
 }
 
@@ -156,6 +158,7 @@
 break;
 }
 case Type::AccessibilityBus:
+#if ENABLE(ACCESSIBILITY)
 proxyArgs.appendVector(Vector {
 "--sloppy-names",
 "--call=org.a11y.atspi.Registry=org.a11y.atspi.Socket.Embed@/org/a11y/atspi/accessible/root",
@@ -166,6 +169,7 @@
 "--call=org.a11y.atspi.Registry=org.a11y.atspi.DeviceEventController.NotifyListenersSync@/org/a11y/atspi/registry/deviceeventcontroller",
 "--call=org.a11y.atspi.Registry=org.a11y.atspi.DeviceEventController.NotifyListenersAsync@/org/a11y/atspi/registry/deviceeventcontroller",
 });
+#endif
 break;
 }
 
@@ -197,8 +201,10 @@
 
 ProcessLauncher::LaunchOptions launchOptions;
 launchOptions.processType = ProcessLauncher::ProcessType::DBusProxy;
+#if ENABLE(ACCESSIBILITY)
 if (m_type == Type::AccessibilityBus && !m_path.isNull())
 launchOptions.extraSandboxPaths.add(m_path, SandboxPermission::ReadOnly);
+#endif
 GUniqueOutPtr error;
 GRefPtr process = bubblewrapSpawn(launcher.get(), launchOptions, argv, &error.outPtr());
 if (!process)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293158] releases/WebKitGTK/webkit-2.36/Source

2022-04-21 Thread carlosgc

Title: [293158] releases/WebKitGTK/webkit-2.36/Source








Revision 293158
Author carlo...@webkit.org
Date 2022-04-21 02:51:36 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r292211 - REGRESSION(r290360): [GLX] Crash on process exit
https://bugs.webkit.org/show_bug.cgi?id=238494

Reviewed by Michael Catanzaro.

Source/WebCore:

When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
to closed signal to release our display dependent resources. Closed signal is emitted right before the native
display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
clear the sharing context before the destructor is called.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):
(WebCore::PlatformDisplay::PlatformDisplay):
(WebCore::PlatformDisplay::sharedDisplayDidClose):
(WebCore::PlatformDisplay::~PlatformDisplay):
(WebCore::PlatformDisplay::clearSharingGLContext):
(WebCore::PlatformDisplay::terminateEGLDisplay):
* platform/graphics/PlatformDisplay.h:
* platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE):
* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::sharedDisplayDidClose):
* platform/graphics/wayland/PlatformDisplayWayland.h:
* platform/graphics/win/PlatformDisplayWin.h:
* platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::create):
(WebCore::clearSharingGLContextAtExit):
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
(WebCore::PlatformDisplayX11::sharedDisplayDidClose):
* platform/graphics/x11/PlatformDisplayX11.h:

Source/WebKit:

* WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/win/PlatformDisplayWin.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/gtk/WaylandCompositorDisplay.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (293157 => 293158)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:29 UTC (rev 293157)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:36 UTC (rev 293158)
@@ -1,3 +1,43 @@
+2022-04-01  Carlos Garcia Campos  
+
+REGRESSION(r290360): [GLX] Crash on process exit
+https://bugs.webkit.org/show_bug.cgi?id=238494
+
+Reviewed by Michael Catanzaro.
+
+When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
+to closed signal to release our display dependent resources. Closed signal is emitted right before the native
+display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
+PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
+terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
+PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
+clear the sharing context before the destructor is called.
+
+* platform/graphics/PlatformDisplay.cpp:
+(WebCore::PlatformDisplay::createPlatformDisplay):
+(WebCore::PlatformDisplay::PlatformDisplay):
+(WebCore::PlatformDisplay::sharedDisplayDidClose):
+(WebCore::PlatformDisplay::~PlatformDisplay):
+(WebCore::PlatformDisplay::clearSharingGLContext):
+(WebCore::PlatformDisplay::terminateEGLDis

[webkit-changes] [293152] releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore

2022-04-21 Thread carlosgc

Title: [293152] releases/WebKitGTK/webkit-2.36/Source/_javascript_Core








Revision 293152
Author carlo...@webkit.org
Date 2022-04-21 02:51:10 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r290788 - Add a DeferTraps scope
https://bugs.webkit.org/show_bug.cgi?id=237306


Reviewed by Mark Lam.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
* bytecode/CodeBlock.h:
* bytecode/RepatchInlines.h:
(JSC::linkFor):
(JSC::virtualForWithFunction):
* dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):
* interpreter/InterpreterInlines.h:
(JSC::Interpreter::execute):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
* runtime/ExceptionScope.h:
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
* runtime/VMTraps.cpp:
(JSC::VMTraps::handleTraps):
(JSC::VMTraps::takeTopPriorityTrap):
* runtime/VMTraps.h:
(JSC::VMTraps::needHandling const):
(JSC::VMTraps::maybeNeedHandling const):
(JSC::VMTraps::hasTrapBit):
(JSC::VMTraps::setTrapBit):
* runtime/VMTrapsInlines.h:
(JSC::DeferTraps::DeferTraps):
(JSC::DeferTraps::~DeferTraps):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/CodeBlock.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/CodeBlock.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/RepatchInlines.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/dfg/DFGOperations.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/interpreter/Interpreter.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/interpreter/InterpreterInlines.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/ExceptionScope.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/ScriptExecutable.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/VMTraps.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/VMTraps.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/runtime/VMTrapsInlines.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (293151 => 293152)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:02 UTC (rev 293151)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:10 UTC (rev 293152)
@@ -1,3 +1,46 @@
+2022-03-03  Saam Barati  
+
+Add a DeferTraps scope
+https://bugs.webkit.org/show_bug.cgi?id=237306
+
+
+Reviewed by Mark Lam.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::CodeBlock):
+(JSC::CodeBlock::jettison):
+(JSC::CodeBlock::noticeIncomingCall):
+* bytecode/CodeBlock.h:
+* bytecode/RepatchInlines.h:
+(JSC::linkFor):
+(JSC::virtualForWithFunction):
+* dfg/DFGOperations.cpp:
+(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::executeProgram):
+(JSC::Interpreter::executeCall):
+(JSC::Interpreter::executeConstruct):
+(JSC::Interpreter::execute):
+(JSC::Interpreter::executeModuleProgram):
+* interpreter/InterpreterInlines.h:
+(JSC::Interpreter::execute):
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::setUpCall):
+* runtime/ExceptionScope.h:
+* runtime/ScriptExecutable.cpp:
+(JSC::ScriptExecutable::installCode):
+* runtime/VMTraps.cpp:
+(JSC::VMTraps::handleTraps):
+(JSC::VMTraps::takeTopPriorityTrap):
+* runtime/VMTraps.h:
+(JSC::VMTraps::needHandling const):
+(JSC::VMTraps::maybeNeedHandling const):
+(JSC::VMTraps::hasTrapBit):
+(JSC::VMTraps::setTrapBit):
+* runtime/VMTrapsInlines.h:
+(JSC::DeferTraps::DeferTraps):
+(JSC::DeferTraps::~DeferTraps):
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/CodeBlock.cpp (293151 => 293152)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-04-21 09:51:02 UTC (rev 293151)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/bytecode/CodeBlock.cpp	2022-04-21 09:51:10 UTC (rev 293152)
@@ -279,6 +279,7 @@
 , m_didFailJITCompilation(false)
 , m_didFailFTLCompilation(false)
 , m_hasBeenCompiledWithFTL(false)
+, m_isJettisoned(false)
 , m_numCalleeLocals(other.m_numCalleeLocals)
 , m_numVars(other.m_numVars)
 , m_numberOfArgumentsToSkip(other.m_numberOfArgumentsToSkip)
@@ -330,6 +331,7 @@

[webkit-changes] [293153] releases/WebKitGTK/webkit-2.36

2022-04-21 Thread carlosgc

Title: [293153] releases/WebKitGTK/webkit-2.36








Revision 293153
Author carlo...@webkit.org
Date 2022-04-21 02:51:14 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r291785 - [JSC] Fix remoteFunctionCallGenerator on MIPS
https://bugs.webkit.org/show_bug.cgi?id=238274

Patch by Geza Lore  on 2022-03-23
Reviewed by Yusuke Suzuki.

JSTests:

* stress/shadow-realm-evaluate.js:

Source/_javascript_Core:

Eliminate register conflict (nonArgGPR0 == regT4, which is used in
valueRegs)

* jit/ThunkGenerators.cpp:
(JSC::remoteFunctionCallGenerator):

Modified Paths

releases/WebKitGTK/webkit-2.36/JSTests/ChangeLog
releases/WebKitGTK/webkit-2.36/JSTests/stress/shadow-realm-evaluate.js
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/ThunkGenerators.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/JSTests/ChangeLog (293152 => 293153)

--- releases/WebKitGTK/webkit-2.36/JSTests/ChangeLog	2022-04-21 09:51:10 UTC (rev 293152)
+++ releases/WebKitGTK/webkit-2.36/JSTests/ChangeLog	2022-04-21 09:51:14 UTC (rev 293153)
@@ -1,3 +1,12 @@
+2022-03-23  Geza Lore  
+
+[JSC] Fix remoteFunctionCallGenerator on MIPS
+https://bugs.webkit.org/show_bug.cgi?id=238274
+
+Reviewed by Yusuke Suzuki.
+
+* stress/shadow-realm-evaluate.js:
+
 2022-02-21  Yusuke Suzuki  
 
 [JSC] Fix ShadowRealm unwinding


Modified: releases/WebKitGTK/webkit-2.36/JSTests/stress/shadow-realm-evaluate.js (293152 => 293153)

--- releases/WebKitGTK/webkit-2.36/JSTests/stress/shadow-realm-evaluate.js	2022-04-21 09:51:10 UTC (rev 293152)
+++ releases/WebKitGTK/webkit-2.36/JSTests/stress/shadow-realm-evaluate.js	2022-04-21 09:51:14 UTC (rev 293153)
@@ -1,4 +1,3 @@
-//@ skip if "mips" == $architecture
 //@ requireOptions("--useShadowRealm=1")
 
 function shouldBe(actual, expected) {


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (293152 => 293153)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:10 UTC (rev 293152)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:14 UTC (rev 293153)
@@ -1,3 +1,16 @@
+2022-03-23  Geza Lore  
+
+[JSC] Fix remoteFunctionCallGenerator on MIPS
+https://bugs.webkit.org/show_bug.cgi?id=238274
+
+Reviewed by Yusuke Suzuki.
+
+Eliminate register conflict (nonArgGPR0 == regT4, which is used in
+valueRegs)
+
+* jit/ThunkGenerators.cpp:
+(JSC::remoteFunctionCallGenerator):
+
 2022-03-03  Saam Barati  
 
 Add a DeferTraps scope


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/ThunkGenerators.cpp (293152 => 293153)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/ThunkGenerators.cpp	2022-04-21 09:51:10 UTC (rev 293152)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/ThunkGenerators.cpp	2022-04-21 09:51:14 UTC (rev 293153)
@@ -1527,11 +1527,10 @@
 
 jit.storePtr(GPRInfo::regT1, jit.addressFor(loopIndex));
 
+jit.prepareCallOperation(vm);
+jit.setupArguments(GPRInfo::regT0, valueRegs);
 jit.move(CCallHelpers::TrustedImmPtr(tagCFunction(operationGetWrappedValueForTarget)), GPRInfo::nonArgGPR0);
 emitPointerValidation(jit, GPRInfo::nonArgGPR0, OperationPtrTag);
-
-jit.setupArguments(GPRInfo::regT0, valueRegs);
-jit.prepareCallOperation(vm);
 jit.call(GPRInfo::nonArgGPR0, OperationPtrTag);
 exceptionChecks.append(jit.emitJumpIfException(vm));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [293156] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-04-21 Thread carlosgc

Title: [293156] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 293156
Author carlo...@webkit.org
Date 2022-04-21 02:51:24 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r292099 - [GTK][WPE] Exit cleanly if Connection to UIProcess severed. Regression (r214307)
https://bugs.webkit.org/show_bug.cgi?id=235224

This patch reverts the WPE and GTK specific code removed in '[WK2] Make
establishing a connection between the WebProcess and the Network process more
robust' (r12345):

GTK+ and WPE ports don't exit on send sync message failure. In those particular
cases, the network process can be terminated by the UI process while the
Web process is still initializing, so we always want to exit instead of crashing. This can
happen when the WebView is created and then destroyed quickly.
See https://bugs.webkit.org/show_bug.cgi?id=183348.

Reviewed by Carlos Garcia Campos.

* WebProcess/WebProcess.cpp:
(WebKit::getNetworkProcessConnection):
(WebKit::WebProcess::getGPUProcessConnection):
(WebKit::getWebAuthnProcessConnection):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (293155 => 293156)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:51:21 UTC (rev 293155)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:51:24 UTC (rev 293156)
@@ -1,3 +1,25 @@
+2022-03-30  Pablo Saavedra  
+
+[GTK][WPE] Exit cleanly if Connection to UIProcess severed. Regression (r214307)
+https://bugs.webkit.org/show_bug.cgi?id=235224
+
+This patch reverts the WPE and GTK specific code removed in '[WK2] Make
+establishing a connection between the WebProcess and the Network process more
+robust' (r12345):
+
+GTK+ and WPE ports don't exit on send sync message failure. In those particular
+cases, the network process can be terminated by the UI process while the
+Web process is still initializing, so we always want to exit instead of crashing. This can
+happen when the WebView is created and then destroyed quickly.
+See https://bugs.webkit.org/show_bug.cgi?id=183348.
+
+Reviewed by Carlos Garcia Campos.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::getNetworkProcessConnection):
+(WebKit::WebProcess::getGPUProcessConnection):
+(WebKit::getWebAuthnProcessConnection):
+
 2022-03-22  Miguel Gomez  
 
 Ensure that proxies are invalidated before destroying them.


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp (293155 => 293156)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-04-21 09:51:21 UTC (rev 293155)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-04-21 09:51:24 UTC (rev 293156)
@@ -1113,6 +1113,20 @@
 injectedBundle->setBundleParameters(value);
 }
 
+NO_RETURN inline void failedToSendSyncMessage()
+{
+#if PLATFORM(GTK) || PLATFORM(WPE)
+// GTK and WPE ports don't exit on send sync message failure.
+// In this particular case, the network process can be terminated by the UI process while the
+// Web process is still initializing, so we always want to exit instead of crashing. This can
+// happen when the WebView is created and then destroyed quickly.
+// See https://bugs.webkit.org/show_bug.cgi?id=183348.
+exit(0);
+#else
+CRASH();
+#endif
+}
+
 static NetworkProcessConnectionInfo getNetworkProcessConnection(IPC::Connection& connection)
 {
 NetworkProcessConnectionInfo connectionInfo;
@@ -1132,7 +1146,7 @@
 unsigned failedAttempts = 0;
 while (!requestConnection()) {
 if (++failedAttempts >= maxFailedAttempts)
-CRASH();
+failedToSendSyncMessage();
 
 RELEASE_LOG_ERROR(Process, "getNetworkProcessConnection: Failed to get connection to network process, will retry...");
 
@@ -1285,7 +1299,7 @@
 // If we failed the first time, retry once. The attachment may have become invalid
 // before it was received by the web process if the network process crashed.
 if (!connection.sendSync(Messages::WebProcessProxy::GetGPUProcessConnection(parameters), Messages::WebProcessProxy::GetGPUProcessConnection::Reply(connectionInfo), 0))
-CRASH();
+failedToSendSyncMessage();
 }
 
 return connectionInfo;
@@ -1370,7 +1384,7 @@
 // before it was received by the web process if the network process crashed.
 if (!connection.sendSync(Messages::WebProcessProxy::GetWebAuthnProcessConnection(), Messages::WebProcessProxy::GetWebAuthnProcessConnection::Reply(connectionInfo), 0)) {
 RELEASE_LOG_ERROR(WebAuthn, "getWebAuthnProcessConnection: Unable to connect to WebAuthn process (Terminating)");
-CRASH();
+failedToSendSyncMessage();
 }
 }

[webkit-changes] [293154] releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore

2022-04-21 Thread carlosgc

Title: [293154] releases/WebKitGTK/webkit-2.36/Source/_javascript_Core








Revision 293154
Author carlo...@webkit.org
Date 2022-04-21 02:51:18 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r291815 - [JSC] JSRemoteFunction thunk should materialize code-pointer
https://bugs.webkit.org/show_bug.cgi?id=238313

Reviewed by Mark Lam.

When invoking a JSRemoteFunction, we must first wrap the arguments passed to it.
The wrapping operation may trigger a GC, and GC can jettison JIT code. As a result,
even though we know that the target JSFunction has JIT code that we want to execute,
the JIT code may be jettisoned (while wrapping the arguments for it) before we get
to the call. This resulted in occasional crashes on the JSTests/stress/shadow-realm-evaluate.js test.

This patch fixes this by doing a null check on the JIT code just before calling it,
and if null (i.e. the JIT code has been jettisoned), re-materializing the JIT code
first before making the call.

* jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
* jit/JITOperations.h:
* jit/ThunkGenerators.cpp:
(JSC::remoteFunctionCallGenerator):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.h
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/ThunkGenerators.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (293153 => 293154)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:14 UTC (rev 293153)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-04-21 09:51:18 UTC (rev 293154)
@@ -1,3 +1,26 @@
+2022-03-24  Yusuke Suzuki  
+
+[JSC] JSRemoteFunction thunk should materialize code-pointer
+https://bugs.webkit.org/show_bug.cgi?id=238313
+
+Reviewed by Mark Lam.
+
+When invoking a JSRemoteFunction, we must first wrap the arguments passed to it.
+The wrapping operation may trigger a GC, and GC can jettison JIT code. As a result,
+even though we know that the target JSFunction has JIT code that we want to execute,
+the JIT code may be jettisoned (while wrapping the arguments for it) before we get
+to the call. This resulted in occasional crashes on the JSTests/stress/shadow-realm-evaluate.js test.
+
+This patch fixes this by doing a null check on the JIT code just before calling it,
+and if null (i.e. the JIT code has been jettisoned), re-materializing the JIT code
+first before making the call.
+
+* jit/JITOperations.cpp:
+(JSC::JSC_DEFINE_JIT_OPERATION):
+* jit/JITOperations.h:
+* jit/ThunkGenerators.cpp:
+(JSC::remoteFunctionCallGenerator):
+
 2022-03-23  Geza Lore  
 
 [JSC] Fix remoteFunctionCallGenerator on MIPS


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.cpp (293153 => 293154)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.cpp	2022-04-21 09:51:14 UTC (rev 293153)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.cpp	2022-04-21 09:51:18 UTC (rev 293154)
@@ -160,6 +160,34 @@
 RELEASE_AND_RETURN(scope, JSValue::encode(getWrappedValue(globalObject, globalObject, JSValue::decode(encodedValue;
 }
 
+JSC_DEFINE_JIT_OPERATION(operationMaterializeRemoteFunctionTargetCode, void*, (JSRemoteFunction* callee))
+{
+JSGlobalObject* globalObject = callee->globalObject();
+VM& vm = globalObject->vm();
+
+CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
+JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
+auto throwScope = DECLARE_THROW_SCOPE(vm);
+
+ASSERT(isRemoteFunction(vm, callee));
+
+auto* targetFunction = jsCast(callee->targetFunction()); // We call this function only when JSRemoteFunction's target is JSFunction.
+ExecutableBase* executable = targetFunction->executable();
+
+// Force the executable to cache its arity entrypoint.
+{
+DeferTraps deferTraps(vm); // We can't jettison any code until after we link the call.
+if (!executable->isHostFunction()) {
+JSScope* scope = targetFunction->scopeUnchecked();
+FunctionExecutable* functionExecutable = static_cast(executable);
+CodeBlock* codeBlockSlot = nullptr;
+functionExecutable->prepareForExecution(vm, targetFunction, scope, CodeForCall, codeBlockSlot);
+RETURN_IF_EXCEPTION(throwScope, nullptr);
+}
+return executable->entrypointFor(CodeForCall, MustCheckArity).executableAddress();
+}
+}
+
 JSC_DEFINE_JIT_OPERATION(operationThrowRemoteFunctionException, EncodedJSValue, (JSRemoteFunction* callee))
 {
 JSGlobalObject* globalObject = callee->globalObject();


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/jit/JITOperations.h (293153 =>

[webkit-changes] [293150] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-04-21 Thread carlosgc

Title: [293150] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 293150
Author carlo...@webkit.org
Date 2022-04-21 02:50:54 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r291621 - Ensure that proxies are invalidated before destroying them.
https://bugs.webkit.org/show_bug.cgi?id=237187

Reviewed by Carlos Garcia Campos.

* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::updateSceneState):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (293149 => 293150)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:35:54 UTC (rev 293149)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-04-21 09:50:54 UTC (rev 293150)
@@ -1,3 +1,13 @@
+2022-03-22  Miguel Gomez  
+
+Ensure that proxies are invalidated before destroying them.
+https://bugs.webkit.org/show_bug.cgi?id=237187
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+(WebKit::CoordinatedGraphicsScene::updateSceneState):
+
 2022-03-25  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.0 release


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (293149 => 293150)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp	2022-04-21 09:35:54 UTC (rev 293149)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp	2022-04-21 09:50:54 UTC (rev 293150)
@@ -230,10 +230,11 @@
 };
 Vector imageBacking;
 } layersByBacking;
+HashSet> replacedProxiesToInvalidate;
 
 // Access the scene state and perform state update for each layer.
 m_nicosia.scene->accessState(
-[this, &layersByBacking](Nicosia::Scene::State& state)
+[this, &layersByBacking, &replacedProxiesToInvalidate](Nicosia::Scene::State& state)
 {
 // FIXME: try to minimize the amount of work in case the Scene::State object
 // didn't change (i.e. no layer flush was done), but don't forget to properly
@@ -250,12 +251,24 @@
 }
 }
 
-// Gather all the to-be-removed layers so that composition-side state
-// can be properly purged after the current state's set of layers is adopted.
 HashSet> removedLayers;
 for (auto& layer : m_nicosia.state.layers) {
+// Gather all the to-be-removed layers so that composition-side state
+// can be properly purged after the current state's set of layers is adopted.
 if (!state.layers.contains(layer))
 removedLayers.add(layer);
+else {
+// Store references to all the proxies that are being used by the layers that are kept in the tree.
+// When adopting the new state, the existent proxies may be replaced or detached from their layers, causing the
+// reference to be lost without having a chance to invalidate them. After the call to commitState, we will
+// invalidate all the proxies that are not being used anymore.
+layer->accessCommitted(
+[&replacedProxiesToInvalidate](const Nicosia::CompositionLayer::LayerState& committed)
+{
+if (committed.contentLayer)
+replacedProxiesToInvalidate.add(Ref { contentLayerImpl(*committed.contentLayer).proxy() });
+});
+}
 }
 
 m_nicosia.state = state;
@@ -270,7 +283,7 @@
 for (auto& compositionLayer : m_nicosia.state.layers) {
 auto& layer = texmapLayer(*compositionLayer);
 compositionLayer->commitState(
-[&layer, &layersByBacking]
+[&layer, &layersByBacking, &replacedProxiesToInvalidate]
 (const Nicosia::CompositionLayer::LayerState& layerState)
 {
 if (layerState.delta.positionChanged)
@@ -346,6 +359,7 @@
 auto& impl = contentLayerImpl(*layerState.contentLayer);
 layersByBacking.contentLayer.append(
 { std::ref(layer), std::ref(impl.proxy()), layerState.delta.contentLayerChanged });
+replacedProxiesToInvalidate.remove(Ref { impl.proxy() });
 } else if (layerState.imageBacking) {
 auto& impl = imageBackingImpl(*layerState.imageBacking);
 lay

[webkit-changes] [293155] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-04-21 Thread carlosgc

Title: [293155] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 293155
Author carlo...@webkit.org
Date 2022-04-21 02:51:21 -0700 (Thu, 21 Apr 2022)


Log Message
Merge r292684 - Include locale.h for LC_MESSAGES definition.
https://bugs.webkit.org/show_bug.cgi?id=239030

Patch by Khem Raj  on 2022-04-09
Reviewed by Michael Catanzaro.

* accessibility/atspi/AccessibilityRootAtspi.cpp:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (293154 => 293155)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:18 UTC (rev 293154)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-04-21 09:51:21 UTC (rev 293155)
@@ -1,3 +1,12 @@
+2022-04-09  Khem Raj  
+
+Include locale.h for LC_MESSAGES definition.
+https://bugs.webkit.org/show_bug.cgi?id=239030
+
+Reviewed by Michael Catanzaro.
+
+* accessibility/atspi/AccessibilityRootAtspi.cpp:
+
 2022-03-24  Jean-Yves Avenard  
 
 Safari can't play video completely at bilibili.com


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp (293154 => 293155)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp	2022-04-21 09:51:18 UTC (rev 293154)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp	2022-04-21 09:51:21 UTC (rev 293155)
@@ -30,6 +30,7 @@
 #include "FrameView.h"
 #include "Page.h"
 #include 
+#include 
 
 namespace WebCore {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292599] trunk/Source/WebKit

2022-04-08 Thread carlosgc

Title: [292599] trunk/Source/WebKit








Revision 292599
Author carlo...@webkit.org
Date 2022-04-08 04:56:29 -0700 (Fri, 08 Apr 2022)


Log Message
[GTK] RemoteInspector: update target list page contents on change instead of reloading
https://bugs.webkit.org/show_bug.cgi?id=238990

Reviewed by Adrian Perez de Castro.

We can use webkit_web_view_run_javascript() to replace the target list with the new one. This also fixes the race
condition when loading inspector:// for the first time that target list is always empty. The web view HashSet is
now a HashMap where the value is a pointer to the client to be able to associate web view with its client
without having to check the host and port.

* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::~RemoteInspectorProtocolHandler): Disconnect web view signals.
(WebKit::RemoteInspectorProtocolHandler::handleRequest): On new web view, connect to notify::uri and remove the
web view if it's no longer showing an inspector page list.
(WebKit::RemoteInspectorProtocolHandler::updateTargetList): Update the target list html.
(WebKit::RemoteInspectorProtocolHandler::webViewLoadChanged): Call updateTargetList() when load finished.
(WebKit::RemoteInspectorProtocolHandler::targetListChanged): Call updateTargetList() for web views that are not
loading. For loading web view connect to load-event to update the target list once the load finishes.
(WebKit::RemoteInspectorProtocolHandler::connectionClosed): Remove the associated web views.
* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h:
* UIProcess/Inspector/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::appendTargertList const): Append the target list html to the given GString.
(WebKit::RemoteInspectorClient::buildTargetListPage const): Use appendTargertList() now.
* UIProcess/Inspector/glib/RemoteInspectorClient.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (292598 => 292599)

--- trunk/Source/WebKit/ChangeLog	2022-04-08 11:15:48 UTC (rev 292598)
+++ trunk/Source/WebKit/ChangeLog	2022-04-08 11:56:29 UTC (rev 292599)
@@ -1,5 +1,32 @@
 2022-04-08  Carlos Garcia Campos  
 
+[GTK] RemoteInspector: update target list page contents on change instead of reloading
+https://bugs.webkit.org/show_bug.cgi?id=238990
+
+Reviewed by Adrian Perez de Castro.
+
+We can use webkit_web_view_run_javascript() to replace the target list with the new one. This also fixes the race
+condition when loading inspector:// for the first time that target list is always empty. The web view HashSet is
+now a HashMap where the value is a pointer to the client to be able to associate web view with its client
+without having to check the host and port.
+
+* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
+(WebKit::RemoteInspectorProtocolHandler::~RemoteInspectorProtocolHandler): Disconnect web view signals.
+(WebKit::RemoteInspectorProtocolHandler::handleRequest): On new web view, connect to notify::uri and remove the
+web view if it's no longer showing an inspector page list.
+(WebKit::RemoteInspectorProtocolHandler::updateTargetList): Update the target list html.
+(WebKit::RemoteInspectorProtocolHandler::webViewLoadChanged): Call updateTargetList() when load finished.
+(WebKit::RemoteInspectorProtocolHandler::targetListChanged): Call updateTargetList() for web views that are not
+loading. For loading web view connect to load-event to update the target list once the load finishes.
+(WebKit::RemoteInspectorProtocolHandler::connectionClosed): Remove the associated web views.
+* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.h:
+* UIProcess/Inspector/glib/RemoteInspectorClient.cpp:
+(WebKit::RemoteInspectorClient::appendTargertList const): Append the target list html to the given GString.
+(WebKit::RemoteInspectorClient::buildTargetListPage const): Use appendTargertList() now.
+* UIProcess/Inspector/glib/RemoteInspectorClient.h:
+
+2022-04-08  Carlos Garcia Campos  
+
 Web Inspector: Use computedStyleMap() instead of deprecated getPropertyCSSValue()
 https://bugs.webkit.org/show_bug.cgi?id=238661
 


Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp (292598 => 292599)

--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp	2022-04-08 11:15:48 UTC (rev 292598)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp	2022-04-08 11:56:29 UTC (rev 292599)
@@ -

[webkit-changes] [292597] trunk/Source

2022-04-08 Thread carlosgc

Title: [292597] trunk/Source








Revision 292597
Author carlo...@webkit.org
Date 2022-04-08 03:23:46 -0700 (Fri, 08 Apr 2022)


Log Message
Web Inspector: Use computedStyleMap() instead of deprecated getPropertyCSSValue()
https://bugs.webkit.org/show_bug.cgi?id=238661

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Add Element.getComputedCSSPropertyNumberValue() instead of using computedStyleMap() directly to have a fallback
in case CSS_TYPED_OM is disabled in build.

* UserInterface/Base/Utilities.js:
(get return):
* UserInterface/Views/DataGridNode.js:
(WI.DataGridNode.prototype.isEventWithinDisclosureTriangle):
* UserInterface/Views/TabBar.js:
(WI.TabBar.prototype._handleMouseMoved.inlineStyleValue):
(WI.TabBar.prototype._handleMouseMoved):
* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.isEventWithinDisclosureTriangle):

Source/WebKit:

Ensure CSS Type OM is enabled in inspector frontend page.

* WebProcess/Inspector/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::enableFrontendFeatures):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js
trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js
trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (292596 => 292597)

--- trunk/Source/WebInspectorUI/ChangeLog	2022-04-08 09:59:15 UTC (rev 292596)
+++ trunk/Source/WebInspectorUI/ChangeLog	2022-04-08 10:23:46 UTC (rev 292597)
@@ -1,3 +1,23 @@
+2022-04-08  Carlos Garcia Campos  
+
+Web Inspector: Use computedStyleMap() instead of deprecated getPropertyCSSValue()
+https://bugs.webkit.org/show_bug.cgi?id=238661
+
+Reviewed by Devin Rousso.
+
+Add Element.getComputedCSSPropertyNumberValue() instead of using computedStyleMap() directly to have a fallback
+in case CSS_TYPED_OM is disabled in build.
+
+* UserInterface/Base/Utilities.js:
+(get return):
+* UserInterface/Views/DataGridNode.js:
+(WI.DataGridNode.prototype.isEventWithinDisclosureTriangle):
+* UserInterface/Views/TabBar.js:
+(WI.TabBar.prototype._handleMouseMoved.inlineStyleValue):
+(WI.TabBar.prototype._handleMouseMoved):
+* UserInterface/Views/TreeElement.js:
+(WI.TreeElement.prototype.isEventWithinDisclosureTriangle):
+
 2022-04-07  Elliott Williams  
 
 [XCBuild] Enable dependency validation by default


Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (292596 => 292597)

--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js	2022-04-08 09:59:15 UTC (rev 292596)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js	2022-04-08 10:23:46 UTC (rev 292597)
@@ -488,6 +488,15 @@
 }
 });
 
+Object.defineProperty(Element.prototype, "getComputedCSSPropertyNumberValue", {
+value(property) {
+let result = undefined;
+result ??= this.computedStyleMap?.().get(property)?.value;
+result ??= window.getComputedStyle(this).getPropertyCSSValue(property)?.getFloatValue(CSSPrimitiveValue.CSS_PX);
+return result;
+},
+});
+
 Object.defineProperty(DocumentFragment.prototype, "createChild",
 {
 value: Element.prototype.createChild


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js (292596 => 292597)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js	2022-04-08 09:59:15 UTC (rev 292596)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGridNode.js	2022-04-08 10:23:46 UTC (rev 292597)
@@ -655,12 +655,11 @@
 if (!cell || !cell.classList.contains("disclosure"))
 return false;
 
-let computedStyle = window.getComputedStyle(cell);
 let start = 0;
 if (WI.resolvedLayoutDirection() === WI.LayoutDirection.RTL)
-start += cell.totalOffsetRight - computedStyle.getPropertyCSSValue("padding-right").getFloatValue(CSSPrimitiveValue.CSS_PX) - this.disclosureToggleWidth;
+start += cell.totalOffsetRight - cell.getComputedCSSPropertyNumberValue("padding-right") - this.disclosureToggleWidth;
 else
-start += cell.totalOffsetLeft + computedStyle.getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);
+start += cell.totalOffsetLeft + cell.getComputedCSSPropertyNumberValue("padding-left");
 return event.pageX >= start && event.pageX <= start + this.disclosureToggleWidth;
 }
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (292596 => 292597)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js	2022-04-08 09:59:15 UTC (rev 292596)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js	2022-04-08 10:23:46 UTC (rev 292597)
@@ -856,7 +856,7 @@
 // FIXME: Animate the tabs

[webkit-changes] [292530] trunk/Source/WebCore

2022-04-07 Thread carlosgc

Title: [292530] trunk/Source/WebCore








Revision 292530
Author carlo...@webkit.org
Date 2022-04-07 04:41:33 -0700 (Thu, 07 Apr 2022)


Log Message
Unreviewed. [GStreamer] Fix compile warning

* Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::gstreamerRtpCapatiblities): Initialize RTCRtpCodecCapability::channels.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (292529 => 292530)

--- trunk/Source/WebCore/ChangeLog	2022-04-07 10:57:53 UTC (rev 292529)
+++ trunk/Source/WebCore/ChangeLog	2022-04-07 11:41:33 UTC (rev 292530)
@@ -1,3 +1,10 @@
+2022-04-07  Carlos Garcia Campos  
+
+Unreviewed. [GStreamer] Fix compile warning
+
+* Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
+(WebCore::gstreamerRtpCapatiblities): Initialize RTCRtpCodecCapability::channels.
+
 2022-04-07  Nikolas Zimmermann  
 
 Unreviewed build fix after r292525.


Modified: trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp (292529 => 292530)

--- trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp	2022-04-07 10:57:53 UTC (rev 292529)
+++ trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp	2022-04-07 11:41:33 UTC (rev 292530)
@@ -83,15 +83,19 @@
 capabilities.codecs.reserveCapacity(4);
 capabilities.codecs.uncheckedAppend({ .mimeType = "video/VP8"_s,
 .clockRate = 9,
+.channels = std::nullopt,
 .sdpFmtpLine = emptyString() });
 capabilities.codecs.uncheckedAppend({ .mimeType = "video/VP9"_s,
 .clockRate = 9,
+.channels = std::nullopt,
 .sdpFmtpLine = "profile-id=0"_s });
 capabilities.codecs.uncheckedAppend({ .mimeType = "video/VP9"_s,
 .clockRate = 9,
+.channels = std::nullopt,
 .sdpFmtpLine = "profile-id=1"_s });
 capabilities.codecs.uncheckedAppend({ .mimeType = "video/H264"_s,
 .clockRate = 9,
+.channels = std::nullopt,
 .sdpFmtpLine = "packetization-mode=1;profile-level-id=42e01f"_s });
 }
 return capabilities;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292529] trunk/Source/WebKit

2022-04-07 Thread carlosgc

Title: [292529] trunk/Source/WebKit








Revision 292529
Author carlo...@webkit.org
Date 2022-04-07 03:57:53 -0700 (Thu, 07 Apr 2022)


Log Message
Unreviewed. Fix GTK build after r292506

* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp:
(webkit_dom_media_list_set_media_text):
* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp:
(webkit_dom_node_set_node_value):
(webkit_dom_node_set_text_content):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (292528 => 292529)

--- trunk/Source/WebKit/ChangeLog	2022-04-07 10:57:36 UTC (rev 292528)
+++ trunk/Source/WebKit/ChangeLog	2022-04-07 10:57:53 UTC (rev 292529)
@@ -1,5 +1,15 @@
 2022-04-07  Carlos Garcia Campos  
 
+Unreviewed. Fix GTK build after r292506
+
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp:
+(webkit_dom_media_list_set_media_text):
+* WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp:
+(webkit_dom_node_set_node_value):
+(webkit_dom_node_set_text_content):
+
+2022-04-07  Carlos Garcia Campos  
+
 [GTK][WPE] RemoteInspector add support for IPv6
 https://bugs.webkit.org/show_bug.cgi?id=238797
 


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp (292528 => 292529)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp	2022-04-07 10:57:36 UTC (rev 292528)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMMediaList.cpp	2022-04-07 10:57:53 UTC (rev 292529)
@@ -214,11 +214,7 @@
 g_return_if_fail(!error || !*error);
 WebCore::MediaList* item = WebKit::core(self);
 WTF::String convertedValue = WTF::String::fromUTF8(value);
-auto result = item->setMediaText(convertedValue);
-if (result.hasException()) {
-auto description = WebCore::DOMException::description(result.releaseException().code());
-g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), description.legacyCode, description.name);
-}
+item->setMediaText(convertedValue);
 }
 
 gulong webkit_dom_media_list_get_length(WebKitDOMMediaList* self)


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp (292528 => 292529)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp	2022-04-07 10:57:36 UTC (rev 292528)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeGtk.cpp	2022-04-07 10:57:53 UTC (rev 292529)
@@ -513,11 +513,7 @@
 g_return_if_fail(!error || !*error);
 WebCore::Node* item = WebKit::core(self);
 WTF::String convertedValue = WTF::String::fromUTF8(value);
-auto result = item->setNodeValue(convertedValue);
-if (result.hasException()) {
-auto description = WebCore::DOMException::description(result.releaseException().code());
-g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), description.legacyCode, description.name);
-}
+item->setNodeValue(convertedValue);
 }
 
 gushort webkit_dom_node_get_node_type(WebKitDOMNode* self)
@@ -618,11 +614,7 @@
 g_return_if_fail(!error || !*error);
 WebCore::Node* item = WebKit::core(self);
 WTF::String convertedValue = WTF::String::fromUTF8(value);
-auto result = item->setTextContent(convertedValue);
-if (result.hasException()) {
-auto description = WebCore::DOMException::description(result.releaseException().code());
-g_set_error_literal(error, g_quark_from_string("WEBKIT_DOM"), description.legacyCode, description.name);
-}
+item->setTextContent(convertedValue);
 }
 
 WebKitDOMElement* webkit_dom_node_get_parent_element(WebKitDOMNode* self)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292527] trunk/Source

2022-04-07 Thread carlosgc

Title: [292527] trunk/Source








Revision 292527
Author carlo...@webkit.org
Date 2022-04-07 03:15:35 -0700 (Thu, 07 Apr 2022)


Log Message
[GTK][WPE] RemoteInspector add support for IPv6
https://bugs.webkit.org/show_bug.cgi?id=238797

Reviewed by Adrian Perez de Castro.

Source/_javascript_Core:

* inspector/remote/glib/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::start): Receive a GSocketAddress instead of address and port parameters.
* inspector/remote/glib/RemoteInspectorServer.h:

Source/WebKit:

Make it possible to connect to remote inspector server using IPv6 address.

* UIProcess/API/glib/WebKitInitialize.cpp:
(WebKit::initializeRemoteInspectorServer): Parse IPv6 address and build GSocketAddress to pass to inspector ot
HTTP server.
* UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::handleRequest): RemoteInspectorClient now expects host and port in a
single String.
* UIProcess/Inspector/glib/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::RemoteInspectorClient): Receive the host and port in a String.
* UIProcess/Inspector/glib/RemoteInspectorClient.h:
* UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp:
* UIProcess/Inspector/glib/RemoteInspectorHTTPServer.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.cpp
trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.h
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp
trunk/Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (292526 => 292527)

--- trunk/Source/_javascript_Core/ChangeLog	2022-04-07 10:11:54 UTC (rev 292526)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-04-07 10:15:35 UTC (rev 292527)
@@ -1,3 +1,14 @@
+2022-04-07  Carlos Garcia Campos  
+
+[GTK][WPE] RemoteInspector add support for IPv6
+https://bugs.webkit.org/show_bug.cgi?id=238797
+
+Reviewed by Adrian Perez de Castro.
+
+* inspector/remote/glib/RemoteInspectorServer.cpp:
+(Inspector::RemoteInspectorServer::start): Receive a GSocketAddress instead of address and port parameters.
+* inspector/remote/glib/RemoteInspectorServer.h:
+
 2022-04-06  Saam Barati  
 
 Call Structure::get instead of Structure::getConcurrently on the mutator thread


Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.cpp (292526 => 292527)

--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.cpp	2022-04-07 10:11:54 UTC (rev 292526)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.cpp	2022-04-07 10:15:35 UTC (rev 292527)
@@ -182,16 +182,16 @@
 g_signal_handlers_disconnect_matched(m_service.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);
 }
 
-bool RemoteInspectorServer::start(const char* address, unsigned port)
+bool RemoteInspectorServer::start(GRefPtr&& socketAddress)
 {
 m_service = adoptGRef(g_socket_service_new());
 g_signal_connect(m_service.get(), "incoming", G_CALLBACK(incomingConnectionCallback), this);
 
-GRefPtr socketAddress = adoptGRef(g_inet_socket_address_new_from_string(address, port));
 GRefPtr effectiveAddress;
 GUniqueOutPtr error;
 if (!g_socket_listener_add_address(G_SOCKET_LISTENER(m_service.get()), socketAddress.get(), G_SOCKET_TYPE_STREAM, G_SOCKET_PROTOCOL_TCP, nullptr, &effectiveAddress.outPtr(), &error.outPtr())) {
-g_warning("Failed to start remote inspector server on %s:%u: %s\n", address, port, error->message);
+GUniquePtr address(g_socket_connectable_to_string(G_SOCKET_CONNECTABLE(socketAddress.get(;
+g_warning("Failed to start remote inspector server on %s: %s", address.get(), error->message);
 return false;
 }
 


Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.h (292526 => 292527)

--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.h	2022-04-07 10:11:54 UTC (rev 292526)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorServer.h	2022-04-07 10:15:35 UTC (rev 292527)
@@ -33,6 +33,7 @@
 #include 
 #include 
 
+typedef struct _GSocketAddress GSocketAddress;
 typedef struct _GSocketConnection GSocketConnection;
 typedef struct _GSocketService GSocketService;
 
@@ -43,7 +44,7 @@
 JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton();
 ~RemoteInspectorServer();
 
-JS_EXPORT_PRIVATE bool start(const char* address, unsigned port);
+JS_EXPORT_PRIVATE bool start(GRefPtr&&);

[webkit-changes] [292460] trunk/Source/WebKit

2022-04-06 Thread carlosgc

Title: [292460] trunk/Source/WebKit








Revision 292460
Author carlo...@webkit.org
Date 2022-04-06 05:36:55 -0700 (Wed, 06 Apr 2022)


Log Message
Unreviewed. Fix GTK build after r292458

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::hostFileDescriptor):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (292459 => 292460)

--- trunk/Source/WebKit/ChangeLog	2022-04-06 11:17:25 UTC (rev 292459)
+++ trunk/Source/WebKit/ChangeLog	2022-04-06 12:36:55 UTC (rev 292460)
@@ -1,3 +1,10 @@
+2022-04-06  Carlos Garcia Campos  
+
+Unreviewed. Fix GTK build after r292458
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::hostFileDescriptor):
+
 2022-04-06  Youenn Fablet  
 
 Implement ServiceWorkerWindowClient.navigate


Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (292459 => 292460)

--- trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2022-04-06 11:17:25 UTC (rev 292459)
+++ trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2022-04-06 12:36:55 UTC (rev 292460)
@@ -55,6 +55,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #if ENABLE(DATE_AND_TIME_INPUT_TYPES)
 #include "WebDateTimePickerGtk.h"
@@ -592,7 +593,7 @@
 #if USE(WPE_RENDERER)
 IPC::Attachment PageClientImpl::hostFileDescriptor()
 {
-return webkitWebViewBaseRenderHostFileDescriptor(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
+return IPC::Attachment({ webkitWebViewBaseRenderHostFileDescriptor(WEBKIT_WEB_VIEW_BASE(m_viewWidget)), UnixFileDescriptor::Adopt });
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292213] trunk

2022-04-01 Thread carlosgc

Title: [292213] trunk








Revision 292213
Author carlo...@webkit.org
Date 2022-04-01 02:17:30 -0700 (Fri, 01 Apr 2022)


Log Message
[GTK][WPE] Enable CSS Typed OM by default
https://bugs.webkit.org/show_bug.cgi?id=238659

Reviewed by Adrian Perez de Castro.

Always build with Typed OM enabled, it's handled by an off by default setting.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake




Diff

Modified: trunk/ChangeLog (292212 => 292213)

--- trunk/ChangeLog	2022-04-01 09:05:25 UTC (rev 292212)
+++ trunk/ChangeLog	2022-04-01 09:17:30 UTC (rev 292213)
@@ -1,3 +1,15 @@
+2022-04-01  Carlos Garcia Campos  
+
+[GTK][WPE] Enable CSS Typed OM by default
+https://bugs.webkit.org/show_bug.cgi?id=238659
+
+Reviewed by Adrian Perez de Castro.
+
+Always build with Typed OM enabled, it's handled by an off by default setting.
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsWPE.cmake:
+
 2022-03-31  Don Olmstead  
 
 [PlayStation] Enable more features by default


Modified: trunk/Source/cmake/OptionsGTK.cmake (292212 => 292213)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-04-01 09:05:25 UTC (rev 292212)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-04-01 09:17:30 UTC (rev 292213)
@@ -134,7 +134,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PRIVATE ON)


Modified: trunk/Source/cmake/OptionsWPE.cmake (292212 => 292213)

--- trunk/Source/cmake/OptionsWPE.cmake	2022-04-01 09:05:25 UTC (rev 292212)
+++ trunk/Source/cmake/OptionsWPE.cmake	2022-04-01 09:17:30 UTC (rev 292213)
@@ -48,7 +48,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PRIVATE ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GPU_PROCESS PRIVATE OFF)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [292212] trunk/Source/WebCore/platform/gtk/po

2022-04-01 Thread carlosgc

Title: [292212] trunk/Source/WebCore/platform/gtk/po








Revision 292212
Author carlo...@webkit.org
Date 2022-04-01 02:05:25 -0700 (Fri, 01 Apr 2022)


Log Message
Croatian translation for WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=238611

Patch by gogo  on 2022-04-01
Rubber-stamped by Carlos Garcia Campos.

* hr.po: Added.

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog


Added Paths

trunk/Source/WebCore/platform/gtk/po/hr.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (292211 => 292212)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2022-04-01 09:00:32 UTC (rev 292211)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2022-04-01 09:05:25 UTC (rev 292212)
@@ -1,3 +1,12 @@
+2022-04-01  gogo  
+
+Croatian translation for WebKitGTK
+https://bugs.webkit.org/show_bug.cgi?id=238611
+
+Rubber-stamped by Carlos Garcia Campos.
+
+* hr.po: Added.
+
 2022-02-15  Yosef Or Boczko  
 
 l10n: Updated Hebrew translation of WebKitGTK


Added: trunk/Source/WebCore/platform/gtk/po/hr.po (0 => 292212)

--- trunk/Source/WebCore/platform/gtk/po/hr.po	(rev 0)
+++ trunk/Source/WebCore/platform/gtk/po/hr.po	2022-04-01 09:05:25 UTC (rev 292212)
@@ -0,0 +1,2917 @@
+# Croatian translation for webkit2gtk
+# Copyright (c) 2021 Rosetta Contributors and Canonical Ltd 2021
+# This file is distributed under the same license as the webkit2gtk package.
+# FIRST AUTHOR , 2021.
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: webkit2gtk\n"
+"Report-Msgid-Bugs-To: FULL NAME \n"
+"POT-Creation-Date: 2022-02-11 08:32+\n"
+"PO-Revision-Date: 2022-03-31 16:39+\n"
+"Last-Translator: gogo \n"
+"Language-Team: Croatian \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=3; plural=n%10==1 && n%100!=11 ? 0 : n%10>=2 && "
+"n%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2;\n"
+"X-Launchpad-Export-Date: 2022-03-31 16:40+\n"
+"X-Generator: Launchpad (build 8668e9380858d822a57f8780c5bef185741f)\n"
+
+#: LocalizedStringsGtk.cpp:43
+msgid "Copy Link Loc_ation"
+msgstr "Kopiraj lokaciju p_oveznice"
+
+#: LocalizedStringsGtk.cpp:48
+msgid "Sa_ve Image As"
+msgstr "Sp_remi sliku kao"
+
+#: LocalizedStringsGtk.cpp:53
+msgid "Copy Image _Address"
+msgstr "Kopiraj adresu _slike"
+
+#: LocalizedStringsGtk.cpp:58
+msgid "Cop_y Video Link Location"
+msgstr "Kopira_j lokaciju video poveznice"
+
+#: LocalizedStringsGtk.cpp:63
+msgid "Cop_y Audio Link Location"
+msgstr "Kopira_j lokaciju poveznice zvuka"
+
+#: LocalizedStringsGtk.cpp:68
+msgid "_Toggle Media Controls"
+msgstr "_Uklj/Isklj medijska upravljanja"
+
+#: LocalizedStringsGtk.cpp:73
+msgid "_Show Media Controls"
+msgstr "_Prikaži medijska upravljanja"
+
+#: LocalizedStringsGtk.cpp:78
+msgid "_Hide Media Controls"
+msgstr "_Sakrij medijska upravljanja"
+
+#: LocalizedStringsGtk.cpp:83
+msgid "Toggle Media _Loop Playback"
+msgstr "Uklj/Isklj ponavljanje _reprodukcije medija"
+
+#: LocalizedStringsGtk.cpp:88
+msgid "Switch Video to _Fullscreen"
+msgstr "Prebaci video na _cijeli zaslon"
+
+#: LocalizedStringsGtk.cpp:93
+msgid "Paste As Plain _Text"
+msgstr "Zalijepi kao običan_tekst"
+
+#: LocalizedStringsGtk.cpp:98
+msgid "_Delete"
+msgstr "_Obriši"
+
+#: LocalizedStringsGtk.cpp:103
+msgid "Select _All"
+msgstr "Odaberi _sve"
+
+#: LocalizedStringsGtk.cpp:108
+msgid "Insert _Emoji"
+msgstr "Umetni _smajli"
+
+#: LocalizedStringsGtk.cpp:113
+msgid "_Insert Unicode Control Character"
+msgstr "_Umetni unikôd kontrolni znak"
+
+#: LocalizedStringsGtk.cpp:118
+msgid "Input _Methods"
+msgstr "_Načini unosa"
+
+#: LocalizedStringsGtk.cpp:123
+msgid "LRM _Left-to-right mark"
+msgstr "LRM označavanje  _s lijeva-na-desno"
+
+#: LocalizedStringsGtk.cpp:128
+msgid "RLM _Right-to-left mark"
+msgstr "RLM označavanje _s desna-na-lijevo"
+
+#: LocalizedStringsGtk.cpp:133
+msgid "LRE Left-to-right _embedding"
+msgstr "LRE s lijeva-na-desno_ubacivanje"
+
+#: LocalizedStringsGtk.cpp:138
+msgid "RLE Right-to-left e_mbedding"
+msgstr "RLE s desna-na-lijevo u_bacivanje"
+
+#: LocalizedStringsGtk.cpp:143
+msgid "LRO Left-to-right _override"
+msgstr "LRO pr_imoravanje s lijeva-na-desno"
+
+#: LocalizedStringsGtk.cpp:148
+msgid "RLO Right-to-left o_verride"
+msgstr "RLO primorava_nje s desna-na-lijevo"
+
+#: LocalizedStringsGtk.cpp:153
+msgid "PDF _Pop directional formatting"
+msgstr "PDF _počni usmjeren zapis"
+
+#: LocalizedStringsGtk.cpp:158
+msgid "ZWS _Zero width space"
+msgstr "ZWS _razmak bez širine"
+
+#: LocalizedStringsGtk.cpp:163
+msgid "ZWJ Zero width _joiner"
+msgstr "ZWJ _spojnica bez širine"
+
+#: LocalizedStringsGtk.cpp:168
+msgid "ZWNJ Zero width _non-joiner"
+msgstr "ZWNJ _nespojnica bez širine"
+
+#: LocalizedStringsGtk.cpp:174
+#, c-format
+msgid "Use at least one character"
+msgid_plural "Use at least %d characters"
+msgstr[0] "Koristi najmanje %d znak"
+msgstr[1] "Koristi najmanje %d znaka"
+msgstr[2] "Koristi

[webkit-changes] [292211] trunk/Source

2022-04-01 Thread carlosgc

Title: [292211] trunk/Source








Revision 292211
Author carlo...@webkit.org
Date 2022-04-01 02:00:32 -0700 (Fri, 01 Apr 2022)


Log Message
REGRESSION(r290360): [GLX] Crash on process exit
https://bugs.webkit.org/show_bug.cgi?id=238494

Reviewed by Michael Catanzaro.

Source/WebCore:

When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
to closed signal to release our display dependent resources. Closed signal is emitted right before the native
display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
clear the sharing context before the destructor is called.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):
(WebCore::PlatformDisplay::PlatformDisplay):
(WebCore::PlatformDisplay::sharedDisplayDidClose):
(WebCore::PlatformDisplay::~PlatformDisplay):
(WebCore::PlatformDisplay::clearSharingGLContext):
(WebCore::PlatformDisplay::terminateEGLDisplay):
* platform/graphics/PlatformDisplay.h:
* platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE):
* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::sharedDisplayDidClose):
* platform/graphics/wayland/PlatformDisplayWayland.h:
* platform/graphics/win/PlatformDisplayWin.h:
* platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::create):
(WebCore::clearSharingGLContextAtExit):
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
(WebCore::PlatformDisplayX11::sharedDisplayDidClose):
* platform/graphics/x11/PlatformDisplayX11.h:

Source/WebKit:

* WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp
trunk/Source/WebCore/platform/graphics/PlatformDisplay.h
trunk/Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp
trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.cpp
trunk/Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.h
trunk/Source/WebCore/platform/graphics/win/PlatformDisplayWin.h
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/gtk/WaylandCompositorDisplay.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (292210 => 292211)

--- trunk/Source/WebCore/ChangeLog	2022-04-01 08:29:51 UTC (rev 292210)
+++ trunk/Source/WebCore/ChangeLog	2022-04-01 09:00:32 UTC (rev 292211)
@@ -1,5 +1,45 @@
 2022-04-01  Carlos Garcia Campos  
 
+REGRESSION(r290360): [GLX] Crash on process exit
+https://bugs.webkit.org/show_bug.cgi?id=238494
+
+Reviewed by Michael Catanzaro.
+
+When creating a PlatformDisplay from a shared GdkDisplay, we need to keep a reference to the display and connect
+to closed signal to release our display dependent resources. Closed signal is emitted right before the native
+display is actually closed by GDK. We also need to make sure that the sharing GL context is released before the
+PlatformDisplay is destroyed. This is always happening for EGL because the sharing GL context is cleared before
+terminating the EGL display in the atexit handler, but that's not the case of GLX. Since X11 only allows one
+PlatformDisplay, which is always the shared one, we can just install an atexit handler in the constructor to
+clear the sharing context before the destructor is called.
+
+* platform/graphics/PlatformDisplay.cpp:
+(WebCore::PlatformDisplay::createPlatformDisplay):
+(WebCore::PlatformDisplay::PlatformDisplay):
+(WebCore::PlatformDisplay::sharedDisplayDidClose):
+(WebCore::PlatformDisplay::~PlatformDisplay):
+(WebCore::PlatformDisplay::clearSharingGLContext):
+(WebCore::PlatformDisplay::terminateEGLDisplay):
+* platform/graphics/PlatformDisplay.h:
+* platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
+(WebCore::PlatformDisplayLibWPE::PlatformDisplayLibWPE):
+* platform/graphics/wayland/PlatformDisplayWayland.cpp:
+(WebCore::PlatformDisplayWayland::create):
+(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
+(WebCore::Pla

[webkit-changes] [291557] releases/WebKitGTK/webkit-2.36.0/

2022-03-21 Thread carlosgc

Title: [291557] releases/WebKitGTK/webkit-2.36.0/








Revision 291557
Author carlo...@webkit.org
Date 2022-03-21 06:17:11 -0700 (Mon, 21 Mar 2022)


Log Message
WebKitGTK 2.36.0

Added Paths

releases/WebKitGTK/webkit-2.36.0/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291556] releases/WebKitGTK/webkit-2.36

2022-03-21 Thread carlosgc

Title: [291556] releases/WebKitGTK/webkit-2.36








Revision 291556
Author carlo...@webkit.org
Date 2022-03-21 06:16:46 -0700 (Mon, 21 Mar 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.36.0.

Modified Paths

releases/WebKitGTK/webkit-2.36/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (291555 => 291556)

--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-21 09:27:07 UTC (rev 291555)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-21 13:16:46 UTC (rev 291556)
@@ -1,3 +1,9 @@
+2022-03-21  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-02-28  Michael Catanzaro  
 
 -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291555 => 291556)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-21 09:27:07 UTC (rev 291555)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-21 13:16:46 UTC (rev 291556)
@@ -1,3 +1,9 @@
+2022-03-21  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.0 release
+
+* gtk/NEWS: Add release notes for 2.36.0.
+
 2022-03-18  Carlos Garcia Campos  
 
 [WPE][GTK] Fix a crash after r290360


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS (291555 => 291556)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-03-21 09:27:07 UTC (rev 291555)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-03-21 13:16:46 UTC (rev 291556)
@@ -1,3 +1,16 @@
+
+WebKitGTK 2.36.0
+
+
+What's new in WebKitGTK 2.36.0?
+
+  - Fix selection foreground color on text with decorations.
+  - Fix seeking on YouTube videos.
+  - Fix list item marker not exposed to a11y when not a direct child of a list item.
+  - Fix a crash while closing a page.
+  - Fix the build to make it reproducible again.
+  - Fix several crashes and rendering issues.
+
 =
 WebKitGTK 2.35.90
 =


Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake (291555 => 291556)

--- releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-03-21 09:27:07 UTC (rev 291555)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-03-21 13:16:46 UTC (rev 291556)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 35 90)
+SET_PROJECT_VERSION(2 36 0)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 3 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 3 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 4 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 4 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 3 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 3 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 4 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 4 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291554] releases/WebKitGTK/webkit-2.36

2022-03-21 Thread carlosgc

Title: [291554] releases/WebKitGTK/webkit-2.36








Revision 291554
Author carlo...@webkit.org
Date 2022-03-21 01:45:10 -0700 (Mon, 21 Mar 2022)


Log Message
Merge r291552 - REGRESSION(r286955): Rendering Links during search: highlighting fails
https://bugs.webkit.org/show_bug.cgi?id=237816

Reviewed by Simon Fraser.

Source/WebCore:

Since r286955 the same coalesced marked text loop is used for painting the foreground text in case of text with
decorations. StyledMarkedText::coalesceAdjacentWithEqualDecorations() doesn't take into account the text style,
so when selected foreground color is different we end up painting the whole decorated text with the same
foreground color for the selected and non-selected parts.

Test: fast/text/selection-with-text-decorations.html

* rendering/StyledMarkedText.cpp:
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations): Take into account the text styles too.
* rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Do not call
StyledMarkedText::coalesceAdjacentWithEqualForeground() in case of text with decorations, since it's unused.

LayoutTests:

* fast/text/selection-with-text-decorations-expected.html: Added.
* fast/text/selection-with-text-decorations.html: Added.
* platform/ios/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/StyledMarkedText.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/TextBoxPainter.cpp


Added Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html
releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291553 => 291554)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-21 08:45:03 UTC (rev 291553)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-21 08:45:10 UTC (rev 291554)
@@ -1,3 +1,14 @@
+2022-03-21  Carlos Garcia Campos  
+
+REGRESSION(r286955): Rendering Links during search: highlighting fails
+https://bugs.webkit.org/show_bug.cgi?id=237816
+
+Reviewed by Simon Fraser.
+
+* fast/text/selection-with-text-decorations-expected.html: Added.
+* fast/text/selection-with-text-decorations.html: Added.
+* platform/ios/TestExpectations:
+
 2022-03-01  Cameron McCormack  
 
 Make input element UA shadow tree creation lazy


Added: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html (0 => 291554)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations-expected.html	2022-03-21 08:45:10 UTC (rev 291554)
@@ -0,0 +1,18 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+
+
+Hello I have a cool underline
+


Added: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html (0 => 291554)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/text/selection-with-text-decorations.html	2022-03-21 08:45:10 UTC (rev 291554)
@@ -0,0 +1,25 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+div::selection {
+color: red;
+background: transparent;
+}
+
+
+Hello I have a cool underline
+
+var target = document.getElementById("target").firstChild;
+getSelection().setBaseAndExtent(target, 0, target, 5);
+


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations (291553 => 291554)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations	2022-03-21 08:45:03 UTC (rev 291553)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/ios/TestExpectations	2022-03-21 08:45:10 UTC (rev 291554)
@@ -134,6 +134,7 @@
 fast/selectors/text-field-selection-text-shadow.html  [ WontFix ]
 fast/selectors/text-field-selection-window-inactive-stroke-color.

[webkit-changes] [291553] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-03-21 Thread carlosgc

Title: [291553] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 291553
Author carlo...@webkit.org
Date 2022-03-21 01:45:03 -0700 (Mon, 21 Mar 2022)


Log Message
Merge r291544 - REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing after SDK update to fdo 21.08 and Gstreamer 1.20
https://bugs.webkit.org/show_bug.cgi?id=237872

Patch by Philippe Normand  on 2022-03-20
Reviewed by Adrian Perez de Castro.

* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291552 => 291553)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-21 08:35:28 UTC (rev 291552)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-21 08:45:03 UTC (rev 291553)
@@ -1,3 +1,13 @@
+2022-03-20  Philippe Normand  
+
+REGRESSION(r289154) [GSTREAMER] webrtc/vp8-then-h264.html is crashing after SDK update to fdo 21.08 and Gstreamer 1.20
+https://bugs.webkit.org/show_bug.cgi?id=237872
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:
+(WebCore::VP8Decoder::Create): Fix typo in decoder factory test.
+
 2022-03-01  Cameron McCormack  
 
 Make input element UA shadow tree creation lazy


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp (291552 => 291553)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp	2022-03-21 08:35:28 UTC (rev 291552)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp	2022-03-21 08:45:03 UTC (rev 291553)
@@ -367,7 +367,7 @@
 static std::unique_ptr Create()
 {
 auto factory = GstDecoderFactory("video/x-vp8");
-if (!factory) {
+if (factory) {
 const auto* factoryName = GST_OBJECT_NAME(GST_OBJECT(factory.get()));
 if (!g_strcmp0(factoryName, "vp8dec") || !g_strcmp0(factoryName, "vp8alphadecodebin")) {
 GST_INFO("Our best GStreamer VP8 decoder is vp8dec, better use the one from LibWebRTC");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291552] trunk

2022-03-21 Thread carlosgc

Title: [291552] trunk








Revision 291552
Author carlo...@webkit.org
Date 2022-03-21 01:35:28 -0700 (Mon, 21 Mar 2022)


Log Message
REGRESSION(r286955): Rendering Links during search: highlighting fails
https://bugs.webkit.org/show_bug.cgi?id=237816

Reviewed by Simon Fraser.

Source/WebCore:

Since r286955 the same coalesced marked text loop is used for painting the foreground text in case of text with
decorations. StyledMarkedText::coalesceAdjacentWithEqualDecorations() doesn't take into account the text style,
so when selected foreground color is different we end up painting the whole decorated text with the same
foreground color for the selected and non-selected parts.

Test: fast/text/selection-with-text-decorations.html

* rendering/StyledMarkedText.cpp:
(WebCore::StyledMarkedText::coalesceAdjacentWithEqualDecorations): Take into account the text styles too.
* rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Do not call
StyledMarkedText::coalesceAdjacentWithEqualForeground() in case of text with decorations, since it's unused.

LayoutTests:

* fast/text/selection-with-text-decorations-expected.html: Added.
* fast/text/selection-with-text-decorations.html: Added.
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/StyledMarkedText.cpp
trunk/Source/WebCore/rendering/TextBoxPainter.cpp


Added Paths

trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html
trunk/LayoutTests/fast/text/selection-with-text-decorations.html




Diff

Modified: trunk/LayoutTests/ChangeLog (291551 => 291552)

--- trunk/LayoutTests/ChangeLog	2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/LayoutTests/ChangeLog	2022-03-21 08:35:28 UTC (rev 291552)
@@ -1,3 +1,14 @@
+2022-03-21  Carlos Garcia Campos  
+
+REGRESSION(r286955): Rendering Links during search: highlighting fails
+https://bugs.webkit.org/show_bug.cgi?id=237816
+
+Reviewed by Simon Fraser.
+
+* fast/text/selection-with-text-decorations-expected.html: Added.
+* fast/text/selection-with-text-decorations.html: Added.
+* platform/ios/TestExpectations:
+
 2022-03-19  Tyler Wilcock  
 
 Rebaseline accessibility/roles-exposed.html for Mac WK1 after https://commits.webkit.org/r291401


Added: trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html (0 => 291552)

--- trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/selection-with-text-decorations-expected.html	2022-03-21 08:35:28 UTC (rev 291552)
@@ -0,0 +1,18 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+
+
+Hello I have a cool underline
+


Added: trunk/LayoutTests/fast/text/selection-with-text-decorations.html (0 => 291552)

--- trunk/LayoutTests/fast/text/selection-with-text-decorations.html	(rev 0)
+++ trunk/LayoutTests/fast/text/selection-with-text-decorations.html	2022-03-21 08:35:28 UTC (rev 291552)
@@ -0,0 +1,25 @@
+
+
+div {
+display: inline-block;
+clip-path: inset(0px 1px 0px 0px); /* workaround for mac. See webkit.org/b/237816. */
+font-family: monospace;
+font-size: 18px;
+text-decoration: underline;
+text-decoration-color: lightgreen;
+text-decoration-thickness: 1ex;
+text-underline-offset: -1.25ex;
+text-decoration-skip-ink: none;
+text-decoration-skip: none;
+}
+div::selection {
+color: red;
+background: transparent;
+}
+
+
+Hello I have a cool underline
+
+var target = document.getElementById("target").firstChild;
+getSelection().setBaseAndExtent(target, 0, target, 5);
+


Modified: trunk/LayoutTests/platform/ios/TestExpectations (291551 => 291552)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-03-21 08:35:28 UTC (rev 291552)
@@ -136,6 +136,7 @@
 fast/selectors/text-field-selection-text-shadow.html  [ WontFix ]
 fast/selectors/text-field-selection-window-inactive-stroke-color.html  [ WontFix ]
 fast/selectors/text-field-selection-window-inactive-text-shadow.html  [ WontFix ]
+fast/text/selection-with-text-decorations.html  [ WontFix ]
 
 # Plugins are not supported on iOS
 plugins


Modified: trunk/Source/WebCore/ChangeLog (291551 => 291552)

--- trunk/Source/WebCore/ChangeLog	2022-03-21 07:41:52 UTC (rev 291551)
+++ trunk/Source/WebCore/ChangeLog	2022-03-21 08:35:28 UTC (rev 291552)
@@ -1,3 +1,23 @@
+2022-03-21  Carlos Garcia Campos  
+

[webkit-changes] [291482] trunk

2022-03-18 Thread carlosgc

Title: [291482] trunk








Revision 291482
Author carlo...@webkit.org
Date 2022-03-18 07:19:45 -0700 (Fri, 18 Mar 2022)


Log Message
[GLIB] Make it possible to call GRefPtr::outPtr() multiple times wihtout an explicit clear
https://bugs.webkit.org/show_bug.cgi?id=238070

Reviewed by Adrian Perez de Castro.

Source/WTF:

Clear the GRefPtr before returning the value in outPtr(), similar to what GUniqueOutPtr does, since it's easy to
forget to explicitly call clear from the callers.

* wtf/glib/GRefPtr.h:
(WTF::GRefPtr::outPtr):

Tools:

Add a unit tests for GRefPtr.

* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/PlatformWPE.cmake:
* TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp: Added.
(TestWebKitAPI::GWeakPtr::GWeakPtr):
(TestWebKitAPI::GWeakPtr::~GWeakPtr):
(TestWebKitAPI::GWeakPtr::set):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/glib/GRefPtr.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/PlatformWPE.cmake


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (291481 => 291482)

--- trunk/Source/WTF/ChangeLog	2022-03-18 13:49:15 UTC (rev 291481)
+++ trunk/Source/WTF/ChangeLog	2022-03-18 14:19:45 UTC (rev 291482)
@@ -1,5 +1,18 @@
 2022-03-18  Carlos Garcia Campos  
 
+[GLIB] Make it possible to call GRefPtr::outPtr() multiple times wihtout an explicit clear
+https://bugs.webkit.org/show_bug.cgi?id=238070
+
+Reviewed by Adrian Perez de Castro.
+
+Clear the GRefPtr before returning the value in outPtr(), similar to what GUniqueOutPtr does, since it's easy to
+forget to explicitly call clear from the callers.
+
+* wtf/glib/GRefPtr.h:
+(WTF::GRefPtr::outPtr):
+
+2022-03-18  Carlos Garcia Campos  
+
 Add a public build option for PDF.js
 https://bugs.webkit.org/show_bug.cgi?id=238023
 


Modified: trunk/Source/WTF/wtf/glib/GRefPtr.h (291481 => 291482)

--- trunk/Source/WTF/wtf/glib/GRefPtr.h	2022-03-18 13:49:15 UTC (rev 291481)
+++ trunk/Source/WTF/wtf/glib/GRefPtr.h	2022-03-18 14:19:45 UTC (rev 291482)
@@ -99,7 +99,7 @@
 
 T*& outPtr()
 {
-ASSERT(!m_ptr);
+clear();
 return m_ptr;
 }
 


Modified: trunk/Tools/ChangeLog (291481 => 291482)

--- trunk/Tools/ChangeLog	2022-03-18 13:49:15 UTC (rev 291481)
+++ trunk/Tools/ChangeLog	2022-03-18 14:19:45 UTC (rev 291482)
@@ -1,5 +1,22 @@
 2022-03-18  Carlos Garcia Campos  
 
+[GLIB] Make it possible to call GRefPtr::outPtr() multiple times wihtout an explicit clear
+https://bugs.webkit.org/show_bug.cgi?id=238070
+
+Reviewed by Adrian Perez de Castro.
+
+Add a unit tests for GRefPtr.
+
+* TestWebKitAPI/PlatformGTK.cmake:
+* TestWebKitAPI/PlatformWPE.cmake:
+* TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp: Added.
+(TestWebKitAPI::GWeakPtr::GWeakPtr):
+(TestWebKitAPI::GWeakPtr::~GWeakPtr):
+(TestWebKitAPI::GWeakPtr::set):
+(TestWebKitAPI::TEST):
+
+2022-03-18  Carlos Garcia Campos  
+
 [ATSPI] accessibility/dropdown-value.html is timing out since added in 248145@main
 https://bugs.webkit.org/show_bug.cgi?id=237803
 


Modified: trunk/Tools/TestWebKitAPI/PlatformGTK.cmake (291481 => 291482)

--- trunk/Tools/TestWebKitAPI/PlatformGTK.cmake	2022-03-18 13:49:15 UTC (rev 291481)
+++ trunk/Tools/TestWebKitAPI/PlatformGTK.cmake	2022-03-18 14:19:45 UTC (rev 291482)
@@ -14,6 +14,7 @@
 list(APPEND TestWTF_SOURCES
 ${test_main_SOURCES}
 
+Tests/WTF/glib/GRefPtr.cpp
 Tests/WTF/glib/GUniquePtr.cpp
 Tests/WTF/glib/WorkQueueGLib.cpp
 


Modified: trunk/Tools/TestWebKitAPI/PlatformWPE.cmake (291481 => 291482)

--- trunk/Tools/TestWebKitAPI/PlatformWPE.cmake	2022-03-18 13:49:15 UTC (rev 291481)
+++ trunk/Tools/TestWebKitAPI/PlatformWPE.cmake	2022-03-18 14:19:45 UTC (rev 291482)
@@ -14,6 +14,7 @@
 list(APPEND TestWTF_SOURCES
 ${test_main_SOURCES}
 
+Tests/WTF/glib/GRefPtr.cpp
 Tests/WTF/glib/GUniquePtr.cpp
 Tests/WTF/glib/WorkQueueGLib.cpp
 


Added: trunk/Tools/TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp (0 => 291482)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp	(rev 0)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/glib/GRefPtr.cpp	2022-03-18 14:19:45 UTC (rev 291482)
@@ -0,0 +1,271 @@
+/*
+ * Copyright (C) 2022 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVI

[webkit-changes] [291479] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-03-18 Thread carlosgc

Title: [291479] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 291479
Author carlo...@webkit.org
Date 2022-03-18 05:59:28 -0700 (Fri, 18 Mar 2022)


Log Message
Merge r291475 - [WPE][GTK] Fix a crash after r290360
https://bugs.webkit.org/show_bug.cgi?id=237917

Reviewed by Youenn Fablet.

When AuxiliaryProcess::shutDown is called for the WebProcess there might be pages not closed yet, for example
when swapping process on navigation, the close message is sent to the page after the shutdown. In the case of
GTK and WPE ports the pages are closed before stopping the run loop to ensure associated resources (like GPU
resources) are released. Closing the last page makes the process termination allowed, which ends up calling
AuxiliaryProcess::terminate again. Also, when the shutdown message is received we don't want to ask again the UI
process whether the process can be terminated, since the UI process asked it.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::enableTermination): Return early if m_isInShutDown is true.
(WebKit::AuxiliaryProcess::shutDown): Set m_isInShutDown for the scope.
* Shared/AuxiliaryProcess.h:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291478 => 291479)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-18 12:59:24 UTC (rev 291478)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-18 12:59:28 UTC (rev 291479)
@@ -1,5 +1,24 @@
 2022-03-18  Carlos Garcia Campos  
 
+[WPE][GTK] Fix a crash after r290360
+https://bugs.webkit.org/show_bug.cgi?id=237917
+
+Reviewed by Youenn Fablet.
+
+When AuxiliaryProcess::shutDown is called for the WebProcess there might be pages not closed yet, for example
+when swapping process on navigation, the close message is sent to the page after the shutdown. In the case of
+GTK and WPE ports the pages are closed before stopping the run loop to ensure associated resources (like GPU
+resources) are released. Closing the last page makes the process termination allowed, which ends up calling
+AuxiliaryProcess::terminate again. Also, when the shutdown message is received we don't want to ask again the UI
+process whether the process can be terminated, since the UI process asked it.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::enableTermination): Return early if m_isInShutDown is true.
+(WebKit::AuxiliaryProcess::shutDown): Set m_isInShutDown for the scope.
+* Shared/AuxiliaryProcess.h:
+
+2022-03-18  Carlos Garcia Campos  
+
 Remove AuxiliaryProcess termination timeout
 https://bugs.webkit.org/show_bug.cgi?id=238012
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp (291478 => 291479)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 12:59:24 UTC (rev 291478)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 12:59:28 UTC (rev 291479)
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #if !OS(WINDOWS)
 #include 
@@ -161,7 +162,7 @@
 ASSERT(m_terminationCounter > 0);
 m_terminationCounter--;
 
-if (m_terminationCounter)
+if (m_terminationCounter || m_isInShutDown)
 return;
 
 if (shouldTerminate())
@@ -204,6 +205,7 @@
 
 void AuxiliaryProcess::shutDown()
 {
+SetForScope isInShutDown(m_isInShutDown, true);
 terminate();
 }
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h (291478 => 291479)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 12:59:24 UTC (rev 291478)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 12:59:28 UTC (rev 291479)
@@ -166,6 +166,8 @@
 // A termination counter; when the counter reaches zero, the process will be terminated.
 unsigned m_terminationCounter;
 
+bool m_isInShutDown { false };
+
 RefPtr m_connection;
 IPC::MessageReceiverMap m_messageReceiverMap;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291478] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-03-18 Thread carlosgc

Title: [291478] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 291478
Author carlo...@webkit.org
Date 2022-03-18 05:59:24 -0700 (Fri, 18 Mar 2022)


Log Message
Merge r291472 - Remove AuxiliaryProcess termination timeout
https://bugs.webkit.org/show_bug.cgi?id=238012

Reviewed by Chris Dumez.

It was only used by the plugin process, now it's always set to 0 for all processes, so it's useless.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::AuxiliaryProcess):
(WebKit::AuxiliaryProcess::disableTermination):
(WebKit::AuxiliaryProcess::enableTermination):
(WebKit::AuxiliaryProcess::terminationTimerFired): Deleted.
* Shared/AuxiliaryProcess.h:
(WebKit::AuxiliaryProcess::setTerminationTimeout): Deleted.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/WebProcessCreationParameters.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/WebProcessCreationParameters.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/UIProcess/WebProcessPool.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291477 => 291478)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-18 12:18:00 UTC (rev 291477)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-18 12:59:24 UTC (rev 291478)
@@ -1,3 +1,28 @@
+2022-03-18  Carlos Garcia Campos  
+
+Remove AuxiliaryProcess termination timeout
+https://bugs.webkit.org/show_bug.cgi?id=238012
+
+Reviewed by Chris Dumez.
+
+It was only used by the plugin process, now it's always set to 0 for all processes, so it's useless.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::AuxiliaryProcess):
+(WebKit::AuxiliaryProcess::disableTermination):
+(WebKit::AuxiliaryProcess::enableTermination):
+(WebKit::AuxiliaryProcess::terminationTimerFired): Deleted.
+* Shared/AuxiliaryProcess.h:
+(WebKit::AuxiliaryProcess::setTerminationTimeout): Deleted.
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::encode const):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeWebProcess):
+
 2022-03-16  Pablo Saavedra  
 
 [GTK][WPE] Crash during the WebPage::close() related to GL resources destruction


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp (291477 => 291478)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 12:18:00 UTC (rev 291477)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 12:59:24 UTC (rev 291478)
@@ -49,7 +49,6 @@
 
 AuxiliaryProcess::AuxiliaryProcess()
 : m_terminationCounter(0)
-, m_terminationTimer(RunLoop::main(), this, &AuxiliaryProcess::terminationTimerFired)
 , m_processSuppressionDisabled("Process Suppression Disabled by UIProcess")
 {
 }
@@ -155,7 +154,6 @@
 void AuxiliaryProcess::disableTermination()
 {
 m_terminationCounter++;
-m_terminationTimer.stop();
 }
 
 void AuxiliaryProcess::enableTermination()
@@ -166,12 +164,8 @@
 if (m_terminationCounter)
 return;
 
-if (!m_terminationTimeout) {
-terminationTimerFired();
-return;
-}
-
-m_terminationTimer.startOneShot(m_terminationTimeout);
+if (shouldTerminate())
+terminate();
 }
 
 void AuxiliaryProcess::mainThreadPing(CompletionHandler&& completionHandler)
@@ -189,14 +183,6 @@
 return 0;
 }
 
-void AuxiliaryProcess::terminationTimerFired()
-{
-if (!shouldTerminate())
-return;
-
-terminate();
-}
-
 void AuxiliaryProcess::stopRunLoop()
 {
 platformStopRunLoop();


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h (291477 => 291478)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 12:18:00 UTC (rev 291477)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 12:59:24 UTC (rev 291478)
@@ -105,8 +105,6 @@
 explicit AuxiliaryProcess();
 virtual ~AuxiliaryProcess();
 
-void setTerminationTimeout(Seconds seconds) { m_terminationTimeout = seconds; }
-

[webkit-changes] [291475] trunk/Source/WebKit

2022-03-18 Thread carlosgc

Title: [291475] trunk/Source/WebKit








Revision 291475
Author carlo...@webkit.org
Date 2022-03-18 02:51:14 -0700 (Fri, 18 Mar 2022)


Log Message
[WPE][GTK] Fix a crash after r290360
https://bugs.webkit.org/show_bug.cgi?id=237917

Reviewed by Youenn Fablet.

When AuxiliaryProcess::shutDown is called for the WebProcess there might be pages not closed yet, for example
when swapping process on navigation, the close message is sent to the page after the shutdown. In the case of
GTK and WPE ports the pages are closed before stopping the run loop to ensure associated resources (like GPU
resources) are released. Closing the last page makes the process termination allowed, which ends up calling
AuxiliaryProcess::terminate again. Also, when the shutdown message is received we don't want to ask again the UI
process whether the process can be terminated, since the UI process asked it.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::enableTermination): Return early if m_isInShutDown is true.
(WebKit::AuxiliaryProcess::shutDown): Set m_isInShutDown for the scope.
* Shared/AuxiliaryProcess.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp
trunk/Source/WebKit/Shared/AuxiliaryProcess.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (291474 => 291475)

--- trunk/Source/WebKit/ChangeLog	2022-03-18 09:01:12 UTC (rev 291474)
+++ trunk/Source/WebKit/ChangeLog	2022-03-18 09:51:14 UTC (rev 291475)
@@ -1,5 +1,24 @@
 2022-03-18  Carlos Garcia Campos  
 
+[WPE][GTK] Fix a crash after r290360
+https://bugs.webkit.org/show_bug.cgi?id=237917
+
+Reviewed by Youenn Fablet.
+
+When AuxiliaryProcess::shutDown is called for the WebProcess there might be pages not closed yet, for example
+when swapping process on navigation, the close message is sent to the page after the shutdown. In the case of
+GTK and WPE ports the pages are closed before stopping the run loop to ensure associated resources (like GPU
+resources) are released. Closing the last page makes the process termination allowed, which ends up calling
+AuxiliaryProcess::terminate again. Also, when the shutdown message is received we don't want to ask again the UI
+process whether the process can be terminated, since the UI process asked it.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::enableTermination): Return early if m_isInShutDown is true.
+(WebKit::AuxiliaryProcess::shutDown): Set m_isInShutDown for the scope.
+* Shared/AuxiliaryProcess.h:
+
+2022-03-18  Carlos Garcia Campos  
+
 Add a public build option for PDF.js
 https://bugs.webkit.org/show_bug.cgi?id=238023
 


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (291474 => 291475)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 09:01:12 UTC (rev 291474)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 09:51:14 UTC (rev 291475)
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #if !OS(WINDOWS)
 #include 
@@ -161,7 +162,7 @@
 ASSERT(m_terminationCounter > 0);
 m_terminationCounter--;
 
-if (m_terminationCounter)
+if (m_terminationCounter || m_isInShutDown)
 return;
 
 if (shouldTerminate())
@@ -204,6 +205,7 @@
 
 void AuxiliaryProcess::shutDown()
 {
+SetForScope isInShutDown(m_isInShutDown, true);
 terminate();
 }
 


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.h (291474 => 291475)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 09:01:12 UTC (rev 291474)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 09:51:14 UTC (rev 291475)
@@ -166,6 +166,8 @@
 // A termination counter; when the counter reaches zero, the process will be terminated.
 unsigned m_terminationCounter;
 
+bool m_isInShutDown { false };
+
 RefPtr m_connection;
 IPC::MessageReceiverMap m_messageReceiverMap;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291473] trunk

2022-03-18 Thread carlosgc

Title: [291473] trunk








Revision 291473
Author carlo...@webkit.org
Date 2022-03-18 01:35:25 -0700 (Fri, 18 Mar 2022)


Log Message
Add a public build option for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=238023

Reviewed by Michael Catanzaro.

.:

PDF.js increases the binary size of the library quite a bit, so embedders might want to disable it if they know
they don't need PDF support at all.

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* html/PDFDocument.cpp:
* html/PDFDocument.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
* platform/LegacySchemeRegistry.cpp:
(WebCore::builtinSecureSchemes):

Source/WebKit:

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
* WebProcess/Network/WebLoaderStrategy.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::canShowMIMEType const):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:
* wtf/PlatformEnable.h:

Modified Paths

trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WTF/wtf/PlatformEnable.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMImplementation.cpp
trunk/Source/WebCore/html/PDFDocument.cpp
trunk/Source/WebCore/html/PDFDocument.h
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/platform/LegacySchemeRegistry.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (291472 => 291473)

--- trunk/ChangeLog	2022-03-18 08:32:16 UTC (rev 291472)
+++ trunk/ChangeLog	2022-03-18 08:35:25 UTC (rev 291473)
@@ -1,3 +1,17 @@
+2022-03-18  Carlos Garcia Campos  
+
+Add a public build option for PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=238023
+
+Reviewed by Michael Catanzaro.
+
+PDF.js increases the binary size of the library quite a bit, so embedders might want to disable it if they know
+they don't need PDF support at all.
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsWPE.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+
 2022-03-17  Zan Dobersek  
 
 [GTK][WPE] Also enable USE_TEXTURE_MAPPER_DMABUF alongside other DMABuf-related defines


Modified: trunk/Source/WTF/ChangeLog (291472 => 291473)

--- trunk/Source/WTF/ChangeLog	2022-03-18 08:32:16 UTC (rev 291472)
+++ trunk/Source/WTF/ChangeLog	2022-03-18 08:35:25 UTC (rev 291473)
@@ -1,3 +1,13 @@
+2022-03-18  Carlos Garcia Campos  
+
+Add a public build option for PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=238023
+
+Reviewed by Michael Catanzaro.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+* wtf/PlatformEnable.h:
+
 2022-03-17  Keith Miller  
 
 tryReserveUncommittedAligned should round up to alignment not bytes requested


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (291472 => 291473)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-03-18 08:32:16 UTC (rev 291472)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-03-18 08:35:25 UTC (rev 291473)
@@ -708,6 +708,7 @@
   type: bool
   humanReadableName: "Enable PDF.js viewer"
   humanReadableDescription: "Enable PDF.js viewer"
+  condition: ENABLE(PDFJS)
   defaultValue:
 WebKitLegacy:
   default: false


Modified: trunk/Source/WTF/wtf/PlatformEnable.h (291472 => 291473)

--- trunk/Source/WTF/wtf/PlatformEnable.h	2022-03-18 08:32:16 UTC (rev 291472)
+++ trunk/Source/WTF/wtf/PlatformEnable.h	2022-03-18 08:35:25 UTC (rev 291473)
@@ -884,6 +884,10 @@
 #endif
 #endif
 
+#if !defined(ENABLE_PDFJS) && (PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE))
+#define ENABLE_PDFJS 1
+#endif
+
 /* This feature works by embedding the OpcodeID in the 32 bit just before the generated LLint code
that executes each opcode. It cannot be supported by the CLoop since there's no way to embed the
OpcodeID word in the CLoop's switch stateme

[webkit-changes] [291472] trunk/Source/WebKit

2022-03-18 Thread carlosgc

Title: [291472] trunk/Source/WebKit








Revision 291472
Author carlo...@webkit.org
Date 2022-03-18 01:32:16 -0700 (Fri, 18 Mar 2022)


Log Message
Remove AuxiliaryProcess termination timeout
https://bugs.webkit.org/show_bug.cgi?id=238012

Reviewed by Chris Dumez.

It was only used by the plugin process, now it's always set to 0 for all processes, so it's useless.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::AuxiliaryProcess):
(WebKit::AuxiliaryProcess::disableTermination):
(WebKit::AuxiliaryProcess::enableTermination):
(WebKit::AuxiliaryProcess::terminationTimerFired): Deleted.
* Shared/AuxiliaryProcess.h:
(WebKit::AuxiliaryProcess::setTerminationTimeout): Deleted.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp
trunk/Source/WebKit/Shared/AuxiliaryProcess.h
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (291471 => 291472)

--- trunk/Source/WebKit/ChangeLog	2022-03-18 08:30:10 UTC (rev 291471)
+++ trunk/Source/WebKit/ChangeLog	2022-03-18 08:32:16 UTC (rev 291472)
@@ -1,3 +1,28 @@
+2022-03-18  Carlos Garcia Campos  
+
+Remove AuxiliaryProcess termination timeout
+https://bugs.webkit.org/show_bug.cgi?id=238012
+
+Reviewed by Chris Dumez.
+
+It was only used by the plugin process, now it's always set to 0 for all processes, so it's useless.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::AuxiliaryProcess):
+(WebKit::AuxiliaryProcess::disableTermination):
+(WebKit::AuxiliaryProcess::enableTermination):
+(WebKit::AuxiliaryProcess::terminationTimerFired): Deleted.
+* Shared/AuxiliaryProcess.h:
+(WebKit::AuxiliaryProcess::setTerminationTimeout): Deleted.
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::encode const):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeWebProcess):
+
 2022-03-18  Youenn Fablet  
 
 Remove MediaSample usage from canvas capture code


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (291471 => 291472)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 08:30:10 UTC (rev 291471)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-03-18 08:32:16 UTC (rev 291472)
@@ -49,7 +49,6 @@
 
 AuxiliaryProcess::AuxiliaryProcess()
 : m_terminationCounter(0)
-, m_terminationTimer(RunLoop::main(), this, &AuxiliaryProcess::terminationTimerFired)
 , m_processSuppressionDisabled("Process Suppression Disabled by UIProcess")
 {
 }
@@ -155,7 +154,6 @@
 void AuxiliaryProcess::disableTermination()
 {
 m_terminationCounter++;
-m_terminationTimer.stop();
 }
 
 void AuxiliaryProcess::enableTermination()
@@ -166,12 +164,8 @@
 if (m_terminationCounter)
 return;
 
-if (!m_terminationTimeout) {
-terminationTimerFired();
-return;
-}
-
-m_terminationTimer.startOneShot(m_terminationTimeout);
+if (shouldTerminate())
+terminate();
 }
 
 void AuxiliaryProcess::mainThreadPing(CompletionHandler&& completionHandler)
@@ -189,14 +183,6 @@
 return 0;
 }
 
-void AuxiliaryProcess::terminationTimerFired()
-{
-if (!shouldTerminate())
-return;
-
-terminate();
-}
-
 void AuxiliaryProcess::stopRunLoop()
 {
 platformStopRunLoop();


Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.h (291471 => 291472)

--- trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 08:30:10 UTC (rev 291471)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.h	2022-03-18 08:32:16 UTC (rev 291472)
@@ -105,8 +105,6 @@
 explicit AuxiliaryProcess();
 virtual ~AuxiliaryProcess();
 
-void setTerminationTimeout(Seconds seconds) { m_terminationTimeout = seconds; }
-
 virtual void initializeProcess(const AuxiliaryProcessInitializationParameters&);
 virtual void initializeProcessName(const AuxiliaryProcessInitializationParameters&);
 virtual void initializeSandbox(const AuxiliaryProcessInitializationParameters&, SandboxInitializationParameters&);
@@ -162,21 +160,12 @@
 
 void shutDown();
 
-void terminationTimerFired();
-
 void platformInitialize(const AuxiliaryProcessInitializationParameters&);
 void pla

[webkit-changes] [291471] trunk

2022-03-18 Thread carlosgc

Title: [291471] trunk








Revision 291471
Author carlo...@webkit.org
Date 2022-03-18 01:30:10 -0700 (Fri, 18 Mar 2022)


Log Message
[ATSPI] accessibility/dropdown-value.html is timing out since added in 248145@main
https://bugs.webkit.org/show_bug.cgi?id=237803


Reviewed by Andres Gonzalez.

Tools:

The test expects the combo box to expose the selected element name as the string value.

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::stringValue): Handle combo boxes as special case and return the selected element
name.

LayoutTests:

* platform/gtk/TestExpectations: Unskip the test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (291470 => 291471)

--- trunk/LayoutTests/ChangeLog	2022-03-18 08:10:45 UTC (rev 291470)
+++ trunk/LayoutTests/ChangeLog	2022-03-18 08:30:10 UTC (rev 291471)
@@ -1,3 +1,13 @@
+2022-03-18  Carlos Garcia Campos  
+
+[ATSPI] accessibility/dropdown-value.html is timing out since added in 248145@main
+https://bugs.webkit.org/show_bug.cgi?id=237803
+
+
+Reviewed by Andres Gonzalez.
+
+* platform/gtk/TestExpectations: Unskip the test.
+
 2022-03-18  Antoine Quint  
 
 REGRESSION(r291129-r291128): [WK1 EWS] 3 imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/* tests are a constant text failure


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (291470 => 291471)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-18 08:10:45 UTC (rev 291470)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-03-18 08:30:10 UTC (rev 291471)
@@ -133,7 +133,6 @@
 webkit.org/b/223862 accessibility/gtk/text-for-range-table-cells.html [ Failure ]
 webkit.org/b/223862 accessibility/gtk/text-for-range-with-link.html [ Failure ]
 accessibility/model-element-attributes.html [ Skip ]
-accessibility/dropdown-value.html [ Skip ]
 
 # Tests failing with ATSPI implementation.
 webkit.org/b/235941 accessibility/gtk/text-at-offset-embedded-objects.html [ Failure ]


Modified: trunk/Tools/ChangeLog (291470 => 291471)

--- trunk/Tools/ChangeLog	2022-03-18 08:10:45 UTC (rev 291470)
+++ trunk/Tools/ChangeLog	2022-03-18 08:30:10 UTC (rev 291471)
@@ -1,3 +1,17 @@
+2022-03-18  Carlos Garcia Campos  
+
+[ATSPI] accessibility/dropdown-value.html is timing out since added in 248145@main
+https://bugs.webkit.org/show_bug.cgi?id=237803
+
+
+Reviewed by Andres Gonzalez.
+
+The test expects the combo box to expose the selected element name as the string value.
+
+* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
+(WTR::AccessibilityUIElement::stringValue): Handle combo boxes as special case and return the selected element
+name.
+
 2022-03-18  Youenn Fablet  
 
 Keep service workers alive when they are inspected even though they should be terminated


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp (291470 => 291471)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp	2022-03-18 08:10:45 UTC (rev 291470)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp	2022-03-18 08:30:10 UTC (rev 291471)
@@ -877,10 +877,18 @@
 
 JSRetainPtr AccessibilityUIElement::stringValue()
 {
+m_element->updateBackingStore();
+if (m_element->role() == WebCore::Atspi::Role::ComboBox) {
+// Tests expect the combo box to expose the selected element name as the string value.
+if (auto menu = childAtIndex(0)) {
+if (auto* selectedChild = menu->m_element->selectedChild(0))
+return OpaqueJSString::tryCreate(makeString("AXValue: ", String::fromUTF8(selectedChild->name(.leakRef();
+}
+}
+
 if (!m_element->interfaces().contains(WebCore::AccessibilityObjectAtspi::Interface::Text))
 return JSStringCreateWithCharacters(nullptr, 0);
 
-m_element->updateBackingStore();
 auto value = makeString("AXValue: ", m_element->text().replace("\n", "<\\n>").replace(objectReplacementCharacter, ""));
 return OpaqueJSString::tryCreate(value).leakRef();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291351] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-03-16 Thread carlosgc

Title: [291351] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 291351
Author carlo...@webkit.org
Date 2022-03-16 08:17:52 -0700 (Wed, 16 Mar 2022)


Log Message
Merge r291335 - [GTK][WPE] Crash during the WebPage::close() related to GL resources destruction
https://bugs.webkit.org/show_bug.cgi?id=237588

Reviewed by Carlos Garcia Campos.

* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::updateSceneWithoutRendering):
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291350 => 291351)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-16 15:10:41 UTC (rev 291350)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-16 15:17:52 UTC (rev 291351)
@@ -1,3 +1,16 @@
+2022-03-16  Pablo Saavedra  
+
+[GTK][WPE] Crash during the WebPage::close() related to GL resources destruction
+https://bugs.webkit.org/show_bug.cgi?id=237588
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
+(WebKit::ThreadedCompositor::invalidate):
+(WebKit::ThreadedCompositor::updateSceneWithoutRendering):
+* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
+
 2022-03-07  Adrian Perez de Castro  
 
 [GTK] generate-automation-atom.py breaks reproducible builds


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h (291350 => 291351)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h	2022-03-16 15:10:41 UTC (rev 291350)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h	2022-03-16 15:17:52 UTC (rev 291351)
@@ -65,6 +65,7 @@
 
 void applyStateChanges(const Vector&);
 void paintToCurrentGLContext(const WebCore::TransformationMatrix&, const WebCore::FloatRect&, WebCore::TextureMapper::PaintFlags = 0);
+void updateSceneState();
 void detach();
 
 // The painting thread must lock the main thread to use below two methods, because two methods access members that the main thread manages. See m_client.
@@ -76,7 +77,6 @@
 
 private:
 void commitSceneState(const WebCore::CoordinatedGraphicsState::NicosiaState&);
-void updateSceneState();
 
 WebCore::TextureMapperLayer* rootLayer() { return m_rootLayer.get(); }
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp (291350 => 291351)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp	2022-03-16 15:10:41 UTC (rev 291350)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp	2022-03-16 15:17:52 UTC (rev 291351)
@@ -106,6 +106,11 @@
 m_compositingRunLoop->performTaskSync([this, protectedThis = Ref { *this }] {
 if (!m_context || !m_context->makeContextCurrent())
 return;
+
+// Update the scene at this point ensures the layers state are correctly propagated
+// in the ThreadedCompositor and in the CompositingCoordinator.
+updateSceneWithoutRendering();
+
 m_scene->purgeGLResources();
 m_context = nullptr;
 m_client.didDestroyGLContext();
@@ -281,6 +286,19 @@
 m_compositingRunLoop->scheduleUpdate();
 }
 
+void ThreadedCompositor::updateSceneWithoutRendering()
+{
+Vector states;
+
+{
+Locker locker { m_attributes.lock };
+states = WTFMove(m_attributes.states);
+
+}
+m_scene->applyStateChanges(states);
+m_scene->updateSceneState();
+}
+
 RefPtr ThreadedCompositor::displayRefreshMonitor(PlatformDisplayID)
 {
 return m_displayRefreshMonitor.copyRef();


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h (291350 => 291351)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h	2022-03-16 15:10:41 UTC (rev 291350)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h	2022-03-16 15:17:52 UTC (rev 291351)
@@ -67,6 +67,7 @@
 
 void updateSc

[webkit-changes] [291350] releases/WebKitGTK/webkit-2.36

2022-03-16 Thread carlosgc

Title: [291350] releases/WebKitGTK/webkit-2.36








Revision 291350
Author carlo...@webkit.org
Date 2022-03-16 08:10:41 -0700 (Wed, 16 Mar 2022)


Log Message
Merge r290639 - Make input element UA shadow tree creation lazy
https://bugs.webkit.org/show_bug.cgi?id=236747

Reviewed by Aditya Keerthi.

Source/WebCore:

We currently delay InputType creation for parser inserted elements until
just after the attributes have been set, so that we don't wastefully
create an InputType and the UA shadow tree creation if a non-text
type="" was specified on the tag. We don't do anything similar for
script inserted input elements. We could make the InputType creation
lazy, but most of the wasted time is due to the shadow tree creation.

This patch makes InputType shadow tree creation lazy by delaying it
until one of the following happens:

1. the element is inserted into the document
2. the type="" or value="" attributes are changed before the element
   is inserted into the document
3. any DOM methods that need access to the innerTextElement() are
   called on the element before the element is inserted into the
   document

Not all places where we call innerTextElement() on the
HTMLInputElement are safe to lazily create the shadow trees, so we
have two accessors:

- innerTextElement() returns the inner text element if it's been
  created already
- innerTextElementCreatingShadowSubtreeIfNeeded will perform the lazy
  shadow tree construction if it hasn't already been done

Since the existing
createShadowSubtreeAndUpdateInnerTextElementEditability function has
more responsibility than just creating the subtree and ensuring the
editability is set appropriately, it's renamed to a more manageable
createShadowSubtree.

This change is a 0.5% progression on Speedometer 2.

Test: fast/forms/lazy-shadow-tree-creation.html

* html/BaseDateAndTimeInputType.h:
* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseDateAndTimeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
* html/ColorInputType.h:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
(WebCore::ColorInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
* html/FileInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree):
(WebCore::InputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
* html/RangeInputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
(WebCore::RangeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
* html/SearchInputType.h:
* html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
(WebCore::SearchInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
Renamed createShadowSubtreeAndUpdateInnerTextElementEditability to
createShadowSubtree and remove the "isInnerTextElementEditable"
argument, since we can ask the element() for its value if needed.
createShadowSubtree is now also responsible for creating the shadow
root.

* html/TextFieldInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):
Renamed. Ensure all shadow tree state is up to date now that it can be
created later.

* html/InputType.h:
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree):
(WebCore::InputType::hasCreatedShadowSubtree const):
New functions to create the shadow subtree if it hasn't been done
already, and to query whether it's been done.

* html/HTMLInputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::innerTextElementCreatingShadowSubtreeIfNeeded):
* html/HTMLTextAreaElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElementCreatingShadowSubtreeIfNeeded):
* html/HTMLTextFormControlElement.h:
* html/InputType.h:
* html/InputType.cpp:
(WebCore::InputType::innerTextElementCreatingShadowSubtreeIfNeeded):
New functions to first create the shadow subtree before returning
innerTextElement(). HTMLTextAreaElement never lazily creates its
shadow subtree and so just returns innerTextElement().

* html/HTMLInputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtreeAndUpdateInnerTextElementEditability):
Deleted. Just call through to m_inputType->createShadowTree()
directly.

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::create):
(WebCore::HTMLInputElement::initializeInputType):
(WebCore::HTMLInputElement::updateType):
Don't immediately create the shadow tree.

(WebCore::HTMLInputElement::didFinishInsertingNode):
Create the shadow subtree now that the element's been inserted. No
need to call dataListMayHaveChanged since
TextFieldInputType::createShadowSubtree will now

[webkit-changes] [291349] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-03-16 Thread carlosgc

Title: [291349] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 291349
Author carlo...@webkit.org
Date 2022-03-16 08:10:27 -0700 (Wed, 16 Mar 2022)


Log Message
Merge r290574 - Add a mechanism to request a UA shadow tree update before style
https://bugs.webkit.org/show_bug.cgi?id=237224

Reviewed by Antti Koivisto.

SVG  elements register themselves with the document when their
shadow tree contents need updating, and this updating is done in
Document::resolveStyle. For lazy HTML  element UA shadow trees
(in bug 236747) we need something similar.

* dom/Document.cpp:
(WebCore::Document::resolveStyle):
(WebCore::Document::addElementWithPendingUserAgentShadowTreeUpdate):
(WebCore::Document::removeElementWithPendingUserAgentShadowTreeUpdate):
* dom/Document.h:
* dom/Element.h:
(WebCore::Element::updateUserAgentShadowTree):
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Deleted.
(WebCore::SVGDocumentExtensions::addUseElementWithPendingShadowTreeUpdate): Deleted.
(WebCore::SVGDocumentExtensions::removeUseElementWithPendingShadowTreeUpdate): Deleted.
* svg/SVGDocumentExtensions.h:
(WebCore::SVGDocumentExtensions::useElementsWithPendingShadowTreeUpdate const): Deleted.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoAncestor):
(WebCore::SVGUseElement::removedFromAncestor):
(WebCore::SVGUseElement::updateUserAgentShadowTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore::SVGUseElement::updateShadowTree): Deleted.
* svg/SVGUseElement.h:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Document.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Document.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Element.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/svg/SVGDocumentExtensions.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/svg/SVGDocumentExtensions.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/svg/SVGUseElement.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/svg/SVGUseElement.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291348 => 291349)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-16 15:10:20 UTC (rev 291348)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-16 15:10:27 UTC (rev 291349)
@@ -1,3 +1,36 @@
+2022-02-27  Cameron McCormack  
+
+Add a mechanism to request a UA shadow tree update before style
+https://bugs.webkit.org/show_bug.cgi?id=237224
+
+Reviewed by Antti Koivisto.
+
+SVG  elements register themselves with the document when their
+shadow tree contents need updating, and this updating is done in
+Document::resolveStyle. For lazy HTML  element UA shadow trees
+(in bug 236747) we need something similar.
+
+* dom/Document.cpp:
+(WebCore::Document::resolveStyle):
+(WebCore::Document::addElementWithPendingUserAgentShadowTreeUpdate):
+(WebCore::Document::removeElementWithPendingUserAgentShadowTreeUpdate):
+* dom/Document.h:
+* dom/Element.h:
+(WebCore::Element::updateUserAgentShadowTree):
+* svg/SVGDocumentExtensions.cpp:
+(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Deleted.
+(WebCore::SVGDocumentExtensions::addUseElementWithPendingShadowTreeUpdate): Deleted.
+(WebCore::SVGDocumentExtensions::removeUseElementWithPendingShadowTreeUpdate): Deleted.
+* svg/SVGDocumentExtensions.h:
+(WebCore::SVGDocumentExtensions::useElementsWithPendingShadowTreeUpdate const): Deleted.
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::insertedIntoAncestor):
+(WebCore::SVGUseElement::removedFromAncestor):
+(WebCore::SVGUseElement::updateUserAgentShadowTree):
+(WebCore::SVGUseElement::invalidateShadowTree):
+(WebCore::SVGUseElement::updateShadowTree): Deleted.
+* svg/SVGUseElement.h:
+
 2022-02-23  Commit Queue  
 
 Unreviewed, reverting r290284.


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Document.cpp (291348 => 291349)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Document.cpp	2022-03-16 15:10:20 UTC (rev 291348)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/dom/Document.cpp	2022-03-16 15:10:27 UTC (rev 291349)
@@ -2005,15 +2005,18 @@
 
 RenderView::RepaintRegionAccumulator repaintRegionAccumulator(renderView());
 
-// FIXME: Do this update per tree scope.
-if (auto* extensions = m_svgExtensions.get()) {
-auto elements = copyToVectorOf>(extensions->useElementsWithPendingShadowTreeUpdate());
-// We can't clear m_svgUseElements here because updateShadowTree may end up executing arbitrary scripts
-// which may insert new SVG use elements or remove existing ones inside sync IPC via ImageLoader::updateFromElement.
-for (auto& element : elements)
-element->updateSh

[webkit-changes] [291348] releases/WebKitGTK/webkit-2.36

2022-03-16 Thread carlosgc

Title: [291348] releases/WebKitGTK/webkit-2.36








Revision 291348
Author carlo...@webkit.org
Date 2022-03-16 08:10:20 -0700 (Wed, 16 Mar 2022)


Log Message
Merge r290414 - Unreviewed, reverting r290284.
https://bugs.webkit.org/show_bug.cgi?id=237131

It is preventing the fuzzer from finding other bugs

Reverted changeset:

"Make input element UA shadow tree creation lazy"
https://bugs.webkit.org/show_bug.cgi?id=236747
https://commits.webkit.org/r290284

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/BaseDateAndTimeInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/BaseDateAndTimeInputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/ColorInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/ColorInputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/FileInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/FileInputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLInputElement.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLInputElement.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLTextAreaElement.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLTextAreaElement.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLTextFormControlElement.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/HTMLTextFormControlElement.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/InputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/InputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/RangeInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/RangeInputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/SearchInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/SearchInputType.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/TextFieldInputType.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/html/TextFieldInputType.h


Removed Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html
releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.html
releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.js




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291347 => 291348)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-16 15:06:35 UTC (rev 291347)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-16 15:10:20 UTC (rev 291348)
@@ -1,3 +1,16 @@
+2022-02-23  Commit Queue  
+
+Unreviewed, reverting r290284.
+https://bugs.webkit.org/show_bug.cgi?id=237131
+
+It is preventing the fuzzer from finding other bugs
+
+Reverted changeset:
+
+"Make input element UA shadow tree creation lazy"
+https://bugs.webkit.org/show_bug.cgi?id=236747
+https://commits.webkit.org/r290284
+
 2022-03-10  Philippe Normand  
 
 REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com


Deleted: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html (291347 => 291348)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html	2022-03-16 15:06:35 UTC (rev 291347)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation-expected.html	2022-03-16 15:10:20 UTC (rev 291348)
@@ -1,6 +0,0 @@
-
-
-
-run({ useParser: true });
-


Deleted: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.html (291347 => 291348)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.html	2022-03-16 15:06:35 UTC (rev 291347)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.html	2022-03-16 15:10:20 UTC (rev 291348)
@@ -1,6 +0,0 @@
-
-
-
-run({ useParser: false });
-


Deleted: releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.js (291347 => 291348)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.js	2022-03-16 15:06:35 UTC (rev 291347)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/fast/forms/lazy-shadow-tree-creation.js	2022-03-16 15:10:20 UTC (rev 291348)
@@ -1,57 +0,0 @@
-const types = {
-"color": { value: "#008000" },
-"date": { value: "2022-01-01" },
-"datetime-local": { value: "2022-01-01" },
-"email": { value: "he...@example.com" },
-"file": { },
-"month": { value: "2022-01" },
-"number": { value: "123" },
-"password": { },
-"range": { value: "75" },
-"search": { value: "abc" },
-"telephone": { value: "+613" },
-"text": { value: "abc" },
-"time": { value: "10:00" },
-"url": { value: "https://example.com/" },
-"week": { value: "2022-W1" },
-};
-
-function supportsType(typeName) {
-let e = document.createElement("input");
-e.type = typeN

[webkit-changes] [291280] releases/WebKitGTK/webkit-2.36/Tools

2022-03-15 Thread carlosgc

Title: [291280] releases/WebKitGTK/webkit-2.36/Tools








Revision 291280
Author carlo...@webkit.org
Date 2022-03-15 03:50:45 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290982 - [GTK][WPE] Do not add new modules under ThirdParty to the tarball
https://bugs.webkit.org/show_bug.cgi?id=237519

Reviewed by Michael Catanzaro.

We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every
time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and
manually add what we need instead.

* gtk/manifest.txt.in:
* wpe/manifest.txt.in:

Modified Paths

releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in
releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in




Diff

Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (291279 => 291280)

--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-03-15 10:00:05 UTC (rev 291279)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-03-15 10:50:45 UTC (rev 291280)
@@ -1,3 +1,17 @@
+2022-03-08  Carlos Garcia Campos  
+
+[GTK][WPE] Do not add new modules under ThirdParty to the tarball
+https://bugs.webkit.org/show_bug.cgi?id=237519
+
+Reviewed by Michael Catanzaro.
+
+We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every
+time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and
+manually add what we need instead.
+
+* gtk/manifest.txt.in:
+* wpe/manifest.txt.in:
+
 2022-02-25  Carlos Garcia Campos  
 
 AX: List item marker not exposed when not a direct child of a list item


Modified: releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in (291279 => 291280)

--- releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in	2022-03-15 10:00:05 UTC (rev 291279)
+++ releases/WebKitGTK/webkit-2.36/Tools/gtk/manifest.txt.in	2022-03-15 10:50:45 UTC (rev 291280)
@@ -47,10 +47,6 @@
 
 directory Source
 exclude Source/_javascript_Core/tests
-exclude Source/ThirdParty/capstone
-exclude Source/ThirdParty/libwebrtc
-exclude Source/ThirdParty/qunit
-exclude Source/ThirdParty/openvr
 exclude Source/WebCore/platform/audio/resources
 exclude Source/WebCore/bindings/scripts/test
 exclude Source/WebCore/Resources
@@ -61,6 +57,11 @@
 exclude Source/cmake/OptionsWPE.cmake$
 exclude Source/WebInspectorUI/Tools
 
+exclude Source/ThirdParty
+directory Source/ThirdParty/ANGLE
+directory Source/ThirdParty/gtest
+directory Source/ThirdParty/xdgmime
+
 exclude Source/WebKit/Resources
 directory Source/WebKit/Resources/gtk
 


Modified: releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in (291279 => 291280)

--- releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in	2022-03-15 10:00:05 UTC (rev 291279)
+++ releases/WebKitGTK/webkit-2.36/Tools/wpe/manifest.txt.in	2022-03-15 10:50:45 UTC (rev 291280)
@@ -47,10 +47,6 @@
 
 directory Source
 exclude Source/_javascript_Core/tests
-exclude Source/ThirdParty/capstone
-exclude Source/ThirdParty/libwebrtc
-exclude Source/ThirdParty/qunit
-exclude Source/ThirdParty/openvr
 exclude Source/WebCore/platform/audio/resources
 exclude Source/WebCore/bindings/scripts/test
 exclude Source/WebCore/Resources
@@ -61,6 +57,11 @@
 exclude Source/cmake/OptionsGTK.cmake$
 exclude Source/WebInspectorUI/Tools
 
+exclude Source/ThirdParty
+directory Source/ThirdParty/ANGLE
+directory Source/ThirdParty/gtest
+directory Source/ThirdParty/xdgmime
+
 exclude Source/WebKit/Resources
 
 # We do want to include the NEWS, but we want it to be in the root of the archive.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291279] releases/WebKitGTK/webkit-2.36

2022-03-15 Thread carlosgc

Title: [291279] releases/WebKitGTK/webkit-2.36








Revision 291279
Author carlo...@webkit.org
Date 2022-03-15 03:00:05 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r29 - REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
https://bugs.webkit.org/show_bug.cgi?id=233861

Unreviewed, manual revert of 284711.

Patch by Philippe Normand  on 2022-03-10

Source/WebCore:

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::currentTimeFudgeFactor):
* platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::timeFudgeFactor const):
* platform/graphics/gstreamer/GStreamerCommon.h:
(WebCore::toGstClockTime):
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::bufferTimeToStreamTime): Deleted.

LayoutTests:

* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/mediasource/MediaSource.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/SourceBufferPrivate.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291278 => 291279)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 10:00:05 UTC (rev 291279)
@@ -1,3 +1,12 @@
+2022-03-10  Philippe Normand  
+
+REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
+https://bugs.webkit.org/show_bug.cgi?id=233861
+
+Unreviewed, manual revert of 284711.
+
+* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
+
 2022-03-02  Carlos Garcia Campos  
 
 REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt (291278 => 291279)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt	2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt	2022-03-15 10:00:05 UTC (rev 291279)
@@ -11,8 +11,8 @@
 PASS Test aborting a remove operation.
 PASS Test remove with a start at the duration.
 PASS Test remove transitioning readyState from 'ended' to 'open'.
-PASS Test removing all appended data.
-PASS Test removing beginning of appended data.
-FAIL Test removing the middle of appended data. assert_equals: Buffered ranges after remove(). expected "{ [0.095, 0.997) [3.298, 6.548) }" but got "{ [0.095, 0.975) [3.298, 6.548) }"
-FAIL Test removing the end of appended data. assert_equals: Buffered ranges after remove(). expected "{ [0.095, 1.022) }" but got "{ [0.095, 0.995) }"
+FAIL Test removing all appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing beginning of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing the middle of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
+FAIL Test removing the end of appended data. assert_equals: Initial buffered range. expected "{ [0.095, 6.548) }" but got "{ [0.000, 6.548) }"
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291278 => 291279)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-15 09:35:36 UTC (rev 291278)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-15 10:00:05 UTC (rev 291279)
@@ -1,3 +1,22 @@
+2022-03-10  Philippe Normand  
+
+REGRESSION(r284711): [GStreamer] Buffering, seek broken on youtube.com
+https://bugs.webkit.org/show_bug.cgi?id=233861
+
+Unreviewed, manual revert of 284711.
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::currentTimeFudgeFactor):
+* platform/graphics/SourceBufferPrivate.h:
+(WebCore::SourceBufferPrivate::timeFudgeFactor const):
+* platform/graphics/gstreamer/GStreamerComm

[webkit-changes] [291277] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-03-15 Thread carlosgc

Title: [291277] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 291277
Author carlo...@webkit.org
Date 2022-03-15 02:35:33 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290883 - makeprop.pl breaks reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=237521

Reviewed by Carlos Garcia Campos.

* css/makeprop.pl: Sort hash elements so the output file is always
the same across different builds.

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (291276 => 291277)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-15 09:35:29 UTC (rev 291276)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-03-15 09:35:33 UTC (rev 291277)
@@ -1,3 +1,13 @@
+2022-03-07  Alberto Garcia  
+
+makeprop.pl breaks reproducible builds
+https://bugs.webkit.org/show_bug.cgi?id=237521
+
+Reviewed by Carlos Garcia Campos.
+
+* css/makeprop.pl: Sort hash elements so the output file is always
+the same across different builds.
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl (291276 => 291277)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl	2022-03-15 09:35:29 UTC (rev 291276)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/css/makeprop.pl	2022-03-15 09:35:33 UTC (rev 291277)
@@ -55,7 +55,7 @@
 my $jsonDecoder = JSON::PP->new->utf8;
 my $jsonHashRef = $jsonDecoder->decode($input);
 my $propertiesHashRef = $jsonHashRef->{properties};
-my @allNames = keys(%$propertiesHashRef);
+my @allNames = sort keys(%$propertiesHashRef);
 die "We've reached more than 1024 CSS properties, please make sure to update CSSProperty/StylePropertyMetadata accordingly" if @allNames > 1024;
 
 my %defines = map { $_ => 1 } split(/ /, $defines);
@@ -472,7 +472,7 @@
 {
 switch (id) {
 EOF
-  foreach my $name (keys %runtimeFlags) {
+  foreach my $name (sort keys %runtimeFlags) {
 print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
 print GPERF "return RuntimeEnabledFeatures::sharedFeatures()." . $runtimeFlags{$name} . "Enabled();\n";
   }
@@ -500,7 +500,7 @@
 switch (id) {
 EOF
 
-foreach my $name (keys %settingsFlags) {
+foreach my $name (sort keys %settingsFlags) {
   print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
   print GPERF "return settings->" . $settingsFlags{$name} . "();\n";
 }
@@ -647,8 +647,8 @@
 {
 switch (id) {
 EOF
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
-for my $name (values %{ $logicalPropertyGroup->{"logical"} }) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
+for my $name (sort values %{ $logicalPropertyGroup->{"logical"} }) {
 print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
 }
 }
@@ -665,9 +665,9 @@
 switch (id) {
 EOF
 
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
 for my $kind ("logical", "physical") {
-for my $name (values %{ $logicalPropertyGroup->{$kind} }) {
+for my $name (sort values %{ $logicalPropertyGroup->{$kind} }) {
 print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
 }
 }
@@ -685,16 +685,18 @@
 switch (id1) {
 EOF
 
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
 my $logical = $logicalPropertyGroup->{"logical"};
 my $physical = $logicalPropertyGroup->{"physical"};
 for my $first ($logical, $physical) {
 my $second = $first eq $logical ? $physical : $logical;
-while (my ($resolver, $name) = each %{ $first }) {
+for my $resolver (sort keys %{ $first }) {
+my $name = $first->{$resolver};
 print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
 }
 print GPERF "switch (id2) {\n";
-while (my ($resolver, $name) = each %{ $second }) {
+for my $resolver (sort keys %{ $second }) {
+my $name = $second->{$resolver};
 print GPERF "case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
 }
 print GPERF << "EOF";
@@ -718,8 +720,9 @@
 switch (propertyID) {
 EOF
 
-for my $logicalPropertyGroup (values %logicalPropertyGroups) {
-while (my ($resolver, $name) = each %{ $logicalPropertyGroup->{"logical"} }) {
+for my $logicalPropertyGroup (sort values %logicalPropertyGroups) {
+for my $resolver (sort keys %{ $logicalPropertyGroup->{"logical"} }) {
+my $name = $logicalPropertyGroup->{"logical"}->{$resolver};
 my $kind = $logicalPropertyG

[webkit-changes] [291278] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-03-15 Thread carlosgc

Title: [291278] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 291278
Author carlo...@webkit.org
Date 2022-03-15 02:35:36 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290890 - [GTK] generate-automation-atom.py breaks reproducible builds
https://bugs.webkit.org/show_bug.cgi?id=237506

Reviewed by Carlos Garcia Campos.

* Scripts/generate-automation-atom.py:
(append_functions): Sort utility functions to produce stable output.

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (291277 => 291278)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-15 09:35:33 UTC (rev 291277)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-03-15 09:35:36 UTC (rev 291278)
@@ -1,3 +1,13 @@
+2022-03-07  Adrian Perez de Castro  
+
+[GTK] generate-automation-atom.py breaks reproducible builds
+https://bugs.webkit.org/show_bug.cgi?id=237506
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/generate-automation-atom.py:
+(append_functions): Sort utility functions to produce stable output.
+
 2022-03-01  Michael Catanzaro  
 
 Misc compiler warnings, late Feb 2022 edition


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py (291277 => 291278)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py	2022-03-15 09:35:33 UTC (rev 291277)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Scripts/generate-automation-atom.py	2022-03-15 09:35:36 UTC (rev 291278)
@@ -50,7 +50,9 @@
 
 
 def append_functions(utils_data, util_functions, util_functions_impl, functions_written):
-for function in util_functions:
+util_functions_list = list(util_functions)
+util_functions_list.sort()
+for function in util_functions_list:
 if function in functions_written:
 continue
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291276] releases/WebKitGTK/webkit-2.36/Source

2022-03-15 Thread carlosgc

Title: [291276] releases/WebKitGTK/webkit-2.36/Source








Revision 291276
Author carlo...@webkit.org
Date 2022-03-15 02:35:29 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290681 - Misc compiler warnings, late Feb 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=237275

Patch by Michael Catanzaro  on 2022-03-01
Reviewed by Adrian Perez de Castro.

Source/_javascript_Core:

Suppress suspected false-positive -Wstringop-overflow and -Wformat-overflow warnings. Also,
remove an unused variable.

* API/tests/MultithreadedMultiVMExecutionTest.cpp:
(startMultithreadedMultiVMExecutionTest):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
* yarr/YarrJIT.cpp:

Source/WebCore:

Remove a redundant move. Sprinkle RELEASE_ASSERT_NOT_REACHED() as required to avoid
-Wreturn-type warnings.

* Modules/push-api/PushDatabase.cpp:
(WebCore::openAndMigrateDatabaseImpl):
* style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluateCondition const):
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
* style/ContainerQueryEvaluator.h:
(WebCore::Style::operator!):
* style/StyleScope.cpp:
(WebCore::Style::Scope::updateQueryContainerState):

Source/WebKit:

Delete an unused function. Remove a redundant move.

* Shared/AuxiliaryProcess.cpp:
(WebKit::applySandboxProfileForDaemon): Deleted.
* Shared/WebFoundTextRange.cpp:
(WebKit::WebFoundTextRange::decode):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLOSRExit.cpp
releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/yarr/YarrJIT.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/Modules/push-api/PushDatabase.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/ContainerQueryEvaluator.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/ContainerQueryEvaluator.h
releases/WebKitGTK/webkit-2.36/Source/WebCore/style/StyleScope.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/WebFoundTextRange.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp (291275 => 291276)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp	2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/API/tests/MultithreadedMultiVMExecutionTest.cpp	2022-03-15 09:35:29 UTC (rev 291276)
@@ -85,7 +85,9 @@
 std::vector buffer;
 buffer.resize(JSStringGetMaximumUTF8CStringSize(string));
 JSStringGetUTF8CString(string, buffer.data(), buffer.size());
+IGNORE_GCC_WARNINGS_BEGIN("format-overflow")
 printf("FAIL: MultithreadedMultiVMExecutionTest: %d %d %s\n", threadNumber, i, buffer.data());
+IGNORE_GCC_WARNINGS_END
 JSStringRelease(string);
 } else
 printf("FAIL: MultithreadedMultiVMExecutionTest: %d %d stringifying exception failed\n", threadNumber, i);


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog (291275 => 291276)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ChangeLog	2022-03-15 09:35:29 UTC (rev 291276)
@@ -1,3 +1,21 @@
+2022-03-01  Michael Catanzaro  
+
+Misc compiler warnings, late Feb 2022 edition
+https://bugs.webkit.org/show_bug.cgi?id=237275
+
+Reviewed by Adrian Perez de Castro.
+
+Suppress suspected false-positive -Wstringop-overflow and -Wformat-overflow warnings. Also,
+remove an unused variable.
+
+* API/tests/MultithreadedMultiVMExecutionTest.cpp:
+(startMultithreadedMultiVMExecutionTest):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
+* ftl/FTLOSRExit.cpp:
+(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
+* yarr/YarrJIT.cpp:
+
 2022-02-23  Adrian Perez de Castro  
 
 Ensure generated inline assembler that setups segments returns to previous state


Modified: releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (291275 => 291276)

--- releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2022-03-15 09:05:02 UTC (rev 291275)
+++ releases/WebKitGTK/webkit-2.36/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2022-03-15 09:35:29 UTC (rev 291276)
@@

[webkit-changes] [291275] releases/WebKitGTK/webkit-2.36

2022-03-15 Thread carlosgc

Title: [291275] releases/WebKitGTK/webkit-2.36








Revision 291275
Author carlo...@webkit.org
Date 2022-03-15 02:05:02 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290597 - -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
https://bugs.webkit.org/show_bug.cgi?id=229867


Patch by Michael Catanzaro  on 2022-02-28
Reviewed by Carlos Garcia Campos.

Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
locally.

* Source/cmake/WebKitCompilerFlags.cmake:

 2022-02-24  Matt Woodrow  

 Unreviewed, update my (Matt Woodrow) status to committer.

 * metadata/contributors.json:

Modified Paths

releases/WebKitGTK/webkit-2.36/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (291274 => 291275)

--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-15 09:04:59 UTC (rev 291274)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-15 09:05:02 UTC (rev 291275)
@@ -1,3 +1,16 @@
+2022-02-28  Michael Catanzaro  
+
+-Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
+https://bugs.webkit.org/show_bug.cgi?id=229867
+
+
+Reviewed by Carlos Garcia Campos.
+
+Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
+locally.
+
+* Source/cmake/WebKitCompilerFlags.cmake:
+
 2022-02-25  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.90 release


Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake (291274 => 291275)

--- releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake	2022-03-15 09:04:59 UTC (rev 291274)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake	2022-03-15 09:05:02 UTC (rev 291275)
@@ -150,6 +150,12 @@
 WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-stringop-overread)
 endif ()
 
+# -Wodr trips over our bindings integrity feature when LTO is enabled.
+# https://bugs.webkit.org/show_bug.cgi?id=229867
+if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-odr)
+endif ()
+
 # -Wexpansion-to-defined produces false positives with GCC but not Clang
 # https://bugs.webkit.org/show_bug.cgi?id=167643#c13
 if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291274] releases/WebKitGTK/webkit-2.36

2022-03-15 Thread carlosgc

Title: [291274] releases/WebKitGTK/webkit-2.36








Revision 291274
Author carlo...@webkit.org
Date 2022-03-15 02:04:59 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290724 - REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
https://bugs.webkit.org/show_bug.cgi?id=171598

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Enable accessibility when a WTR observer is added.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::addNotificationObserver):

LayoutTests:

Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
on the menu and not the combo.

* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
* accessibility/gtk/menu-list-unfocused-notifications.html:
* platform/gtk/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291273 => 291274)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:59 UTC (rev 291274)
@@ -1,5 +1,21 @@
 2022-03-02  Carlos Garcia Campos  
 
+REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
+https://bugs.webkit.org/show_bug.cgi?id=171598
+
+Reviewed by Adrian Perez de Castro.
+
+Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
+the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
+AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
+on the menu and not the combo.
+
+* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
+* accessibility/gtk/menu-list-unfocused-notifications.html:
+* platform/gtk/TestExpectations:
+
+2022-03-02  Carlos Garcia Campos  
+
 [ATSPI] Test accessibility/select-element-at-index.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=237315
 


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt (291273 => 291274)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt	2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt	2022-03-15 09:04:59 UTC (rev 291274)
@@ -9,15 +9,15 @@
 Focused element is: AXRole: AXButton
 
 Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: four
 Focused element is: AXRole: AXButton
 
 Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: three
 Focused element is: AXRole: AXButton
 
-AXLoadComplete: AXRole: AXWebArea
-AXElementBusyChanged: AXRole: AXWebArea
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html (291273 => 291274)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html	2022-03-15 09:04:54 UTC (rev 291273)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html	2022-03-15 09:04:59 UTC (rev 291274)
@@ -19,28 +19,39 @@
 
 if (window.testRunner && window.accessibilityController) {
 accessibilityController.addNotificationListener(function(element, notification) {
-debug(notification + ": " + element.role);
+if (notification == "AXFocusedUIElementChanged" || notification == "AXMenuItemSelected")
+debug(notification + ": " + element.role);
 });
 
-debug("Changing focus to button.");
-document.getElementById('button').focus();
-debug("Focused element is: " + accessibilityController.focusedElement.role + "\n");
+window.setTimeout(function() {
+debug("Changing focus to

[webkit-changes] [291273] releases/WebKitGTK/webkit-2.36/LayoutTests

2022-03-15 Thread carlosgc

Title: [291273] releases/WebKitGTK/webkit-2.36/LayoutTests








Revision 291273
Author carlo...@webkit.org
Date 2022-03-15 02:04:54 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290723 - [ATSPI] Test accessibility/select-element-at-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237315

Reviewed by Adrian Perez de Castro.

This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
should behave like all other ports now.

* accessibility/select-element-at-index.html:
* platform/glib/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291272 => 291273)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:54 UTC (rev 291273)
@@ -1,3 +1,16 @@
+2022-03-02  Carlos Garcia Campos  
+
+[ATSPI] Test accessibility/select-element-at-index.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=237315
+
+Reviewed by Adrian Perez de Castro.
+
+This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
+should behave like all other ports now.
+
+* accessibility/select-element-at-index.html:
+* platform/glib/TestExpectations:
+
 2022-03-01  Carlos Garcia Campos  
 
 [ATSPI] Remove layout tests checking children added/removed notifications


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html (291272 => 291273)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html	2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/select-element-at-index.html	2022-03-15 09:04:54 UTC (rev 291273)
@@ -51,13 +51,7 @@
 // "Option 4" is the third of three selected items, thus the index should be 2.
 shouldBeTrue("selectElement.selectedChildAtIndex(2).isEqual(option4)");
 
-// In ATSPI removeSelectionAtIndex() the index is with respect to the array of
-// selected children; not the array of all children. Thus to remove the selection
-// from "Option 4" in ATSPI, we again need to specify an index of 2.
-if (accessibilityController.platformName == "atspi")
-selectElement.removeSelectionAtIndex(2);
-else
-selectElement.removeSelectionAtIndex(3);
+selectElement.removeSelectionAtIndex(3);
 shouldBeFalse("option4.isSelected");
 shouldBe("selectElement.selectedChildrenCount", "2");
 


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations (291272 => 291273)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations	2022-03-15 09:04:50 UTC (rev 291272)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations	2022-03-15 09:04:54 UTC (rev 291273)
@@ -413,9 +413,6 @@
 
 webkit.org/b/232256 accessibility/auto-fill-crash.html [ Timeout ]
 
-# Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
-
 #
 # End of Accessibility-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291272] releases/WebKitGTK/webkit-2.36

2022-03-15 Thread carlosgc

Title: [291272] releases/WebKitGTK/webkit-2.36








Revision 291272
Author carlo...@webkit.org
Date 2022-03-15 02:04:50 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290633 - [ATSPI] Remove layout tests checking children added/removed notifications
https://bugs.webkit.org/show_bug.cgi?id=237272

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Do not send children-changed notifications to WTR observers.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::childrenChanged):
(WebCore::AccessibilityAtspi::notifyChildrenChanged const): Deleted.
* accessibility/atspi/AccessibilityAtspi.h:

LayoutTests:

Children changed notifications are not expected by any other tests because other ports don't support them. We
already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we
don't emit those notifications either.

* accessibility/children-changed-sends-notification-expected.txt: Removed.
* accessibility/children-changed-sends-notification.html: Removed.
* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
* accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed.
* accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed.
* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo-wk1/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/mac/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/win/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/wincairo-wk1/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h


Removed Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification.html
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children.html




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291271 => 291272)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:41 UTC (rev 291271)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:50 UTC (rev 291272)
@@ -1,3 +1,25 @@
+2022-03-01  Carlos Garcia Campos  
+
+[ATSPI] Remove layout tests checking children added/removed notifications
+https://bugs.webkit.org/show_bug.cgi?id=237272
+
+Reviewed by Adrian Perez de Castro.
+
+Children changed notifications are not expected by any other tests because other ports don't support them. We
+already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we
+don't emit those notifications either.
+
+* accessibility/children-changed-sends-notification-expected.txt: Removed.
+* accessibility/children-changed-sends-notification.html: Removed.
+* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
+* accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed.
+* accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed.
+* platform/glib/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wincairo-wk1/TestExpectations:
+
 2022-02-25  Carlos Garcia Campos  
 
 AX: List item marker not exposed when not a direct child of a list item


Deleted: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (291271 => 291272)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt	2022-03-15 09:04:41 UTC (rev 291271)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/children-changed-sends-notification-expected.txt	2022-03-15 09:04:50 UTC (rev 291272)
@@ -1,17 +0,0 @@
-This test ensures that a notification is being emitted when children are added or removed for an accessibility object
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Plain text paragraph
-
-PARAGRAPH notification: AXChildrenAdded
-GLO

[webkit-changes] [291271] releases/WebKitGTK/webkit-2.36

2022-03-15 Thread carlosgc

Title: [291271] releases/WebKitGTK/webkit-2.36








Revision 291271
Author carlo...@webkit.org
Date 2022-03-15 02:04:41 -0700 (Tue, 15 Mar 2022)


Log Message
Merge r290502 - AX: List item marker not exposed when not a direct child of a list item
https://bugs.webkit.org/show_bug.cgi?id=236777


Reviewed by Adrian Perez de Castro.

Source/WebCore:

It can happen that the marker is not a direct child of a list item, in which case the marker is ignored and not
exposed to ATs.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const): In case of list marker find the marker list item.
(WebCore::AccessibilityRenderObject::markerRenderer const): Helper to return the list item marker renderer.
(WebCore::AccessibilityRenderObject::addListItemMarker): Add always the list item marker as the first child of
list items.
(WebCore::AccessibilityRenderObject::addChildren): Do not add list item marker children, they will be added to
the right parent in addListItemMarker().
* accessibility/AccessibilityRenderObject.h:

Tools:

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::roleValueToString): Return AXStatic for Text role too.

LayoutTests:

Update test results.

* accessibility/gtk/list-items-always-exposed-expected.txt:
* accessibility/gtk/list-items-always-exposed.html:
* accessibility/gtk/spans-expected.txt:
* accessibility/gtk/spans.html:
* platform/gtk/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/spans-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/spans.html
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/AccessibilityRenderObject.h
releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (291270 => 291271)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-03-15 09:04:41 UTC (rev 291271)
@@ -1,3 +1,19 @@
+2022-02-25  Carlos Garcia Campos  
+
+AX: List item marker not exposed when not a direct child of a list item
+https://bugs.webkit.org/show_bug.cgi?id=236777
+
+
+Reviewed by Adrian Perez de Castro.
+
+Update test results.
+
+* accessibility/gtk/list-items-always-exposed-expected.txt:
+* accessibility/gtk/list-items-always-exposed.html:
+* accessibility/gtk/spans-expected.txt:
+* accessibility/gtk/spans.html:
+* platform/gtk/TestExpectations:
+
 2022-02-28  Carlos Garcia Campos  
 
 [ATSPI] Always expose table cells (layout and CSS) that have rendered text content


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt (291270 => 291271)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt	2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt	2022-03-15 09:04:41 UTC (rev 291271)
@@ -8,7 +8,9 @@
 
 PASS list.role is 'AXRole: AXList'
 PASS item1.role is 'AXRole: AXListItem'
+PASS marker1.role is 'AXRole: AXStatic'
 PASS item2.role is 'AXRole: AXListItem'
+PASS marker2.role is 'AXRole: AXStatic'
 PASS paragraph.role is 'AXRole: AXParagraph'
 PASS successfullyParsed is true
 


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html (291270 => 291271)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html	2022-03-15 08:55:30 UTC (rev 291270)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/list-items-always-exposed.html	2022-03-15 09:04:41 UTC (rev 291271)
@@ -23,12 +23,16 @@
 
 var list = webArea.childAtIndex(0);
 var item1 = list.childAtIndex(0);
+var marker1 = item1.childAtIndex(0);
 var item2 = list.childAtIndex(1);
-var paragraph = item2.childAtIndex(0);
+var marker2 = item2.childAtIndex(0);
+var paragraph = item2.childAtIndex(1);
 
 shouldBe("list.role", "'AXRole: AXList'");
 shouldBe("item1.role", "'AXRole: AXListItem'");
+shouldBe("marker1.role", "'AXRole: AXStatic'");
 shouldBe("item2.role", "'AXRole: AXListItem'");
+shouldBe("marker2.role", "'AXRole: AXStatic'");
 shouldBe("pa

[webkit-changes] [291096] trunk/Source/WebCore

2022-03-10 Thread carlosgc

Title: [291096] trunk/Source/WebCore








Revision 291096
Author carlo...@webkit.org
Date 2022-03-10 01:30:38 -0800 (Thu, 10 Mar 2022)


Log Message
[GTK][WPE] Add initial adwaita style for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237527

Reviewed by Michael Catanzaro.

* Modules/pdfjs-extras/adwaita/style.css: Added.
(#openFile):
(.dropdownToolbarButton > select):
* html/PDFDocument.cpp:
(WebCore::PDFDocument::injectStyleAndContentScript):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/PDFDocument.cpp


Added Paths

trunk/Source/WebCore/Modules/pdfjs-extras/adwaita/
trunk/Source/WebCore/Modules/pdfjs-extras/adwaita/style.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (291095 => 291096)

--- trunk/Source/WebCore/ChangeLog	2022-03-10 09:08:01 UTC (rev 291095)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 09:30:38 UTC (rev 291096)
@@ -1,3 +1,16 @@
+2022-03-07  Carlos Garcia Campos  
+
+[GTK][WPE] Add initial adwaita style for PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=237527
+
+Reviewed by Michael Catanzaro.
+
+* Modules/pdfjs-extras/adwaita/style.css: Added.
+(#openFile):
+(.dropdownToolbarButton > select):
+* html/PDFDocument.cpp:
+(WebCore::PDFDocument::injectStyleAndContentScript):
+
 2022-03-10  Youenn Fablet  
 
 Remove RemoteVideoSample


Added: trunk/Source/WebCore/Modules/pdfjs-extras/adwaita/style.css (0 => 291096)

--- trunk/Source/WebCore/Modules/pdfjs-extras/adwaita/style.css	(rev 0)
+++ trunk/Source/WebCore/Modules/pdfjs-extras/adwaita/style.css	2022-03-10 09:30:38 UTC (rev 291096)
@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2022 Igalia S.L.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#openFile {
+display: none !important;
+}
+
+.dropdownToolbarButton > select {
+-webkit-appearance: none;
+}


Modified: trunk/Source/WebCore/html/PDFDocument.cpp (291095 => 291096)

--- trunk/Source/WebCore/html/PDFDocument.cpp	2022-03-10 09:08:01 UTC (rev 291095)
+++ trunk/Source/WebCore/html/PDFDocument.cpp	2022-03-10 09:30:38 UTC (rev 291096)
@@ -214,6 +214,8 @@
 link->setAttribute(relAttr, "stylesheet"_s);
 #if PLATFORM(COCOA)
 link->setAttribute(hrefAttr, "webkit-pdfjs-viewer://pdfjs/extras/cocoa/style.css"_s);
+#elif PLATFORM(GTK) || PLATFORM(WPE)
+link->setAttribute(hrefAttr, "webkit-pdfjs-viewer://pdfjs/extras/adwaita/style.css"_s);
 #endif
 contentDocument->head()->appendChild(link);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291094] trunk

2022-03-10 Thread carlosgc

Title: [291094] trunk








Revision 291094
Author carlo...@webkit.org
Date 2022-03-10 01:00:23 -0800 (Thu, 10 Mar 2022)


Log Message
[GTK][WPE] Add initial support for PDF documents using PDF.js
https://bugs.webkit.org/show_bug.cgi?id=237513

Reviewed by Michael Catanzaro.

Source/WebCore:

Add support for loading PDF documents using PDF.js.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
* loader/soup/ResourceLoaderSoup.cpp:
(WebCore::ResourceLoader::loadGResource):
* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):
* platform/LegacySchemeRegistry.cpp:
(WebCore::builtinSecureSchemes):

Source/WebKit:

Build PDF.js resources into the library.

* PdfJSGResources.cmake: Added.
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType): Claim to support PDF documents when PDF.js is enabled.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canShowMIMEType const): Ditto.

Source/WTF:

Enable PDF.js for GTK and WPE ports.

* Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

Add a script to generate the GResource manifest for PDF.js sources.

* glib/generate-pdfjs-gresource-manifest.py: Added.
(get_filenames):
(get_filenames.should_ignore_resource):
(get_filenames.resource_name):
(is_compressible):
* gtk/manifest.txt.in: Add pdfjs to tarballs.
* wpe/manifest.txt.in: Ditto.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/soup/ResourceLoaderSoup.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/platform/LegacySchemeRegistry.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestOptions.cpp
trunk/Tools/gtk/manifest.txt.in
trunk/Tools/wpe/manifest.txt.in


Added Paths

trunk/Source/WebKit/PdfJSGResources.cmake
trunk/Tools/glib/generate-pdfjs-gresource-manifest.py




Diff

Modified: trunk/Source/WTF/ChangeLog (291093 => 291094)

--- trunk/Source/WTF/ChangeLog	2022-03-10 08:57:52 UTC (rev 291093)
+++ trunk/Source/WTF/ChangeLog	2022-03-10 09:00:23 UTC (rev 291094)
@@ -1,3 +1,14 @@
+2022-03-10  Carlos Garcia Campos  
+
+[GTK][WPE] Add initial support for PDF documents using PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=237513
+
+Reviewed by Michael Catanzaro.
+
+Enable PDF.js for GTK and WPE ports.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2022-03-08  Robin Morisset  
 
 [WTF] LikelyDenseUnsignedIntegerSet::add can cause a reindexing of the entire bit vector with every call in the worst case


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (291093 => 291094)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-03-10 08:57:52 UTC (rev 291093)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-03-10 09:00:23 UTC (rev 291094)
@@ -710,6 +710,7 @@
 WebKitLegacy:
   default: false
 WebKit:
+  "PLATFORM(GTK) || PLATFORM(WPE)": true
   default: false
 WebCore:
   default: false


Modified: trunk/Source/WebCore/ChangeLog (291093 => 291094)

--- trunk/Source/WebCore/ChangeLog	2022-03-10 08:57:52 UTC (rev 291093)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 09:00:23 UTC (rev 291094)
@@ -1,3 +1,22 @@
+2022-03-10  Carlos Garcia Campos  
+
+[GTK][WPE] Add initial support for PDF documents using PDF.js
+https://bugs.webkit.org/show_bug.cgi?id=237513
+
+Reviewed by Michael Catanzaro.
+
+Add support for loading PDF documents using PDF.js.
+
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::start):
+(WebCore::ResourceLoader::isPDFJSResourceLoad const):
+* loader/soup/ResourceLoaderSoup.cpp:
+(WebCore::ResourceLoader::loadGResource):
+* page/SecurityOrigin.cpp:
+(WebCore::shouldTreatAsUniqueOrigin):
+* platform/LegacySchemeRegistry.cpp:
+(WebCore::builtinSecureSchemes):
+
 2022-03-09  Antoine Quint  
 
 [web-animations] counter-increment should support discrete animation


Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (291093 => 291094)

--- trunk/Source/WebCore/loader/ResourceLoader.cpp	2022-03-10 08:57:52 UTC (rev 291093)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp	2022-03-10 09:00:23 UTC (rev 291094)
@@ -247,7 +247,7 @@
 #endif
 
 #if USE(SOUP)
-if (m_request.url().protocolIs("resource")) {
+if (m_request.url().protocolIs("resource") || isPDFJSResourceLoad()) {
 loadGResource();
 return;
 }
@@ -869,7 +869,7 @@
 
 bool ResourceLoader::isPDFJSResourceLoad() const
 {
-#if PLAT

[webkit-changes] [291093] trunk/Source

2022-03-10 Thread carlosgc

Title: [291093] trunk/Source








Revision 291093
Author carlo...@webkit.org
Date 2022-03-10 00:57:52 -0800 (Thu, 10 Mar 2022)


Log Message
[GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers
https://bugs.webkit.org/show_bug.cgi?id=237601

Reviewed by Michael Catanzaro.

Source/_javascript_Core:

Make it possible to start the inspector server with 0 port, meaning any free one will be used.

* inspector/remote/glib/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::start): Pass the effective address to g_socket_listener_add_address and get the port.
* inspector/remote/glib/RemoteInspectorServer.h:
(Inspector::RemoteInspectorServer::port const): Return the port the server is listening to.

Source/WebInspectorUI:

Add Base/BrowserInspectorFrontendHost.js to be used when inspector is run and InspectorFrontendHost is not
defined in window. This new file is only included in the inspector sources for GTK and WPE ports.

* CMakeLists.txt:
* PlatformWPE: Added
* PlatformGTK:
* Scripts/combine-resources.pl: Add --input-script-name to be able to skip individual scripts too.
* Scripts/copy-user-interface-resources.pl: If inspector frontend host should not be included, remove the script
from generated files.
* UserInterface/Base/BrowserInspectorFrontendHost.js: Added.
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsShowCertificate):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get isRemote):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get inspectionLevel):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get debuggableInfo):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get port):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get platform):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get platformVersionName):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsDiagnosticLogging):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.get supportsWebExtensions):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.connect):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.loaded):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.closeWindow):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.reopen):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.reset):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.bringToFront):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.inspectedURLChanged):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.showCertificate):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setZoomFactor):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.zoomFactor):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setForcedAppearance):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.userInterfaceLayoutDirection):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.supportsDockSide):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.requestDockSide):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setAttachedWindowHeight):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setAttachedWindowWidth):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.setSheetRect):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.startWindowDrag):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.moveWindowBy):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.copyText):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.killText):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.openURLExternally):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.canSave):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.save):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.append):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.close):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.showContextMenu):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.dispatchEventAsContextMenuEvent):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.sendMessageToBackend):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.unbufferedLog):
(window.InspectorFrontendHost.WI.BrowserInspectorFrontendHost.prototype.isUnderTest):
(window.InspectorFron

[webkit-changes] [291038] trunk/Source

2022-03-09 Thread carlosgc

Title: [291038] trunk/Source








Revision 291038
Author carlo...@webkit.org
Date 2022-03-09 04:43:36 -0800 (Wed, 09 Mar 2022)


Log Message
[GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector
https://bugs.webkit.org/show_bug.cgi?id=237646

Reviewed by Adrian Perez de Castro.

Source/_javascript_Core:

Add RemoteInspector::s_inspectorServerAddress to keep the remote inspector server address instead of the
environment variable used to start the server.

* inspector/remote/RemoteInspector.h:
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::RemoteInspector): Only call start if s_inspectorServerAddress is not null.
(Inspector::RemoteInspector::start): Use s_inspectorServerAddress instead of querying the environment.

Source/WebKit:

Use it only in the UI process to start the server, but propagate the address to web process using creation
parameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const): Encode inspectorServerAddress.
(WebKit::WebProcessCreationParameters::decode): Decode inspectorServerAddress.
* Shared/WebProcessCreationParameters.h: Add inspectorServerAddress.
* UIProcess/API/glib/WebKitInitialize.cpp:
(WebKit::initializeRemoteInspectorServer): Set RemoteInspector::s_inspectorServerAddress if the server started
successfully.
* UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Set inspectorServerAddress parameter from
RemoteInspector::s_inspectorServerAddress value.
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Set RemoteInspector::s_inspectorServerAddress from creation
parameter value.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h
trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp
trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (291037 => 291038)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-09 12:43:36 UTC (rev 291038)
@@ -1,3 +1,18 @@
+2022-03-09  Carlos Garcia Campos  
+
+[GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector
+https://bugs.webkit.org/show_bug.cgi?id=237646
+
+Reviewed by Adrian Perez de Castro.
+
+Add RemoteInspector::s_inspectorServerAddress to keep the remote inspector server address instead of the
+environment variable used to start the server.
+
+* inspector/remote/RemoteInspector.h:
+* inspector/remote/glib/RemoteInspectorGlib.cpp:
+(Inspector::RemoteInspector::RemoteInspector): Only call start if s_inspectorServerAddress is not null.
+(Inspector::RemoteInspector::start): Use s_inspectorServerAddress instead of querying the environment.
+
 2022-03-08  Robin Morisset  
 
 [WTF] LikelyDenseUnsignedIntegerSet::add can cause a reindexing of the entire bit vector with every call in the worst case


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (291037 => 291038)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2022-03-09 12:43:36 UTC (rev 291038)
@@ -121,6 +121,10 @@
 #if PLATFORM(COCOA)
 static void setNeedMachSandboxExtension(bool needExtension) { needMachSandboxExtension = needExtension; }
 #endif
+#if USE(GLIB)
+static void setInspectorServerAddress(CString&& address) { s_inspectorServerAddress = WTFMove(address); }
+static const CString& inspectorServerAddress() { return s_inspectorServerAddress; }
+#endif
 static void startDisabled();
 static RemoteInspector& singleton();
 friend class LazyNeverDestroyed;
@@ -247,6 +251,9 @@
 #if PLATFORM(COCOA)
 static std::atomic needMachSandboxExtension;
 #endif
+#if USE(GLIB)
+static CString s_inspectorServerAddress;
+#endif
 
 // Targets can be registered from any thread at any time.
 // Any target can send messages over the XPC connection.


Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp (291037 => 291038)

--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp	2022-03-09 12:43:36 UTC (rev 291038)
@@ -38,6 +38,8 @@
 
 namespace Inspector {
 
+CString RemoteInspector::s_inspectorServerAddress;
+
 RemoteInspector& RemoteInspector::singleton()

[webkit-changes] [290982] trunk/Tools

2022-03-08 Thread carlosgc

Title: [290982] trunk/Tools








Revision 290982
Author carlo...@webkit.org
Date 2022-03-08 01:13:25 -0800 (Tue, 08 Mar 2022)


Log Message
[GTK][WPE] Do not add new modules under ThirdParty to the tarball
https://bugs.webkit.org/show_bug.cgi?id=237519

Reviewed by Michael Catanzaro.

We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every
time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and
manually add what we need instead.

* gtk/manifest.txt.in:
* wpe/manifest.txt.in:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/manifest.txt.in
trunk/Tools/wpe/manifest.txt.in




Diff

Modified: trunk/Tools/ChangeLog (290981 => 290982)

--- trunk/Tools/ChangeLog	2022-03-08 09:09:16 UTC (rev 290981)
+++ trunk/Tools/ChangeLog	2022-03-08 09:13:25 UTC (rev 290982)
@@ -1,3 +1,17 @@
+2022-03-08  Carlos Garcia Campos  
+
+[GTK][WPE] Do not add new modules under ThirdParty to the tarball
+https://bugs.webkit.org/show_bug.cgi?id=237519
+
+Reviewed by Michael Catanzaro.
+
+We currently include ThirdParty and exclude individually what we don't want in the tarball. That means every
+time something new is added to ThirdParty we have to manually exclude it. It's better to exclude ThirdParty and
+manually add what we need instead.
+
+* gtk/manifest.txt.in:
+* wpe/manifest.txt.in:
+
 2022-03-08  Sihui Liu  
 
 Add early return for empty path in makeAllDirectories


Modified: trunk/Tools/gtk/manifest.txt.in (290981 => 290982)

--- trunk/Tools/gtk/manifest.txt.in	2022-03-08 09:09:16 UTC (rev 290981)
+++ trunk/Tools/gtk/manifest.txt.in	2022-03-08 09:13:25 UTC (rev 290982)
@@ -47,10 +47,6 @@
 
 directory Source
 exclude Source/_javascript_Core/tests
-exclude Source/ThirdParty/capstone
-exclude Source/ThirdParty/libwebrtc
-exclude Source/ThirdParty/qunit
-exclude Source/ThirdParty/openvr
 exclude Source/WebCore/platform/audio/resources
 exclude Source/WebCore/bindings/scripts/test
 exclude Source/WebCore/Resources
@@ -61,6 +57,11 @@
 exclude Source/cmake/OptionsWPE.cmake$
 exclude Source/WebInspectorUI/Tools
 
+exclude Source/ThirdParty
+directory Source/ThirdParty/ANGLE
+directory Source/ThirdParty/gtest
+directory Source/ThirdParty/xdgmime
+
 exclude Source/WebKit/Resources
 directory Source/WebKit/Resources/gtk
 


Modified: trunk/Tools/wpe/manifest.txt.in (290981 => 290982)

--- trunk/Tools/wpe/manifest.txt.in	2022-03-08 09:09:16 UTC (rev 290981)
+++ trunk/Tools/wpe/manifest.txt.in	2022-03-08 09:13:25 UTC (rev 290982)
@@ -47,10 +47,6 @@
 
 directory Source
 exclude Source/_javascript_Core/tests
-exclude Source/ThirdParty/capstone
-exclude Source/ThirdParty/libwebrtc
-exclude Source/ThirdParty/qunit
-exclude Source/ThirdParty/openvr
 exclude Source/WebCore/platform/audio/resources
 exclude Source/WebCore/bindings/scripts/test
 exclude Source/WebCore/Resources
@@ -61,6 +57,11 @@
 exclude Source/cmake/OptionsGTK.cmake$
 exclude Source/WebInspectorUI/Tools
 
+exclude Source/ThirdParty
+directory Source/ThirdParty/ANGLE
+directory Source/ThirdParty/gtest
+directory Source/ThirdParty/xdgmime
+
 exclude Source/WebKit/Resources
 
 # We do want to include the NEWS, but we want it to be in the root of the archive.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290724] trunk

2022-03-02 Thread carlosgc

Title: [290724] trunk








Revision 290724
Author carlo...@webkit.org
Date 2022-03-02 00:50:52 -0800 (Wed, 02 Mar 2022)


Log Message
REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
https://bugs.webkit.org/show_bug.cgi?id=171598

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Enable accessibility when a WTR observer is added.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::addNotificationObserver):

LayoutTests:

Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
on the menu and not the combo.

* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
* accessibility/gtk/menu-list-unfocused-notifications.html:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt
trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290723 => 290724)

--- trunk/LayoutTests/ChangeLog	2022-03-02 08:49:29 UTC (rev 290723)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 08:50:52 UTC (rev 290724)
@@ -1,5 +1,21 @@
 2022-03-02  Carlos Garcia Campos  
 
+REGRESSION(r216096): [GTK] Test accessibility/gtk/menu-list-unfocused-notifications.html is failing since r216096
+https://bugs.webkit.org/show_bug.cgi?id=171598
+
+Reviewed by Adrian Perez de Castro.
+
+Since r216096 the notification for menu list changes is deffered, so we need to wait one run loop cycle to get
+the notifications. Also update the test to ignore notifications that are not interesting like AXLoadComplete and
+AXElementBusyChanged, and update expectations for the new behavior with ATSPI where the notification is emitted
+on the menu and not the combo.
+
+* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
+* accessibility/gtk/menu-list-unfocused-notifications.html:
+* platform/gtk/TestExpectations:
+
+2022-03-02  Carlos Garcia Campos  
+
 [ATSPI] Test accessibility/select-element-at-index.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=237315
 


Modified: trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt (290723 => 290724)

--- trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt	2022-03-02 08:49:29 UTC (rev 290723)
+++ trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt	2022-03-02 08:50:52 UTC (rev 290724)
@@ -9,15 +9,15 @@
 Focused element is: AXRole: AXButton
 
 Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: four
 Focused element is: AXRole: AXButton
 
 Changing selected item in non-focused combobox.
-AXSelectedChildrenChanged: AXRole: AXComboBox
+AXMenuItemSelected: AXRole: AXMenu
+Selected item is: AXTitle: three
 Focused element is: AXRole: AXButton
 
-AXLoadComplete: AXRole: AXWebArea
-AXElementBusyChanged: AXRole: AXWebArea
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html (290723 => 290724)

--- trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html	2022-03-02 08:49:29 UTC (rev 290723)
+++ trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications.html	2022-03-02 08:50:52 UTC (rev 290724)
@@ -19,28 +19,39 @@
 
 if (window.testRunner && window.accessibilityController) {
 accessibilityController.addNotificationListener(function(element, notification) {
-debug(notification + ": " + element.role);
+if (notification == "AXFocusedUIElementChanged" || notification == "AXMenuItemSelected")
+debug(notification + ": " + element.role);
 });
 
-debug("Changing focus to button.");
-document.getElementById('button').focus();
-debug("Focused element is: " + accessibilityController.focusedElement.role + "\n");
+window.setTimeout(function() {
+debug("Changing focus to button.");
+document.getElementById("button").focus();
+debug("Focused element is: " + accessibilityController.focusedElement.role + "\n");
 
-// Programmatic selection changes in the non-focused combo box do not result
-// in the button losing focus. Therefore the combo box should not claim focus.
-debug("Changing selected item in non-focused combobox.");
-document.getElementById

[webkit-changes] [290723] trunk/LayoutTests

2022-03-02 Thread carlosgc

Title: [290723] trunk/LayoutTests








Revision 290723
Author carlo...@webkit.org
Date 2022-03-02 00:49:29 -0800 (Wed, 02 Mar 2022)


Log Message
[ATSPI] Test accessibility/select-element-at-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237315

Reviewed by Adrian Perez de Castro.

This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
should behave like all other ports now.

* accessibility/select-element-at-index.html:
* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/select-element-at-index.html
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (290722 => 290723)

--- trunk/LayoutTests/ChangeLog	2022-03-02 08:09:08 UTC (rev 290722)
+++ trunk/LayoutTests/ChangeLog	2022-03-02 08:49:29 UTC (rev 290723)
@@ -1,3 +1,16 @@
+2022-03-02  Carlos Garcia Campos  
+
+[ATSPI] Test accessibility/select-element-at-index.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=237315
+
+Reviewed by Adrian Perez de Castro.
+
+This is because the test contains platform specific behavior for ATK that was migrated to ATSPI by mistake. We
+should behave like all other ports now.
+
+* accessibility/select-element-at-index.html:
+* platform/glib/TestExpectations:
+
 2022-03-01  Devin Rousso  
 
 Web Inspector: add a switch to control whether breakpoint evaluations (condition, ignore count, actions) are also affected by script blackboxing


Modified: trunk/LayoutTests/accessibility/select-element-at-index.html (290722 => 290723)

--- trunk/LayoutTests/accessibility/select-element-at-index.html	2022-03-02 08:09:08 UTC (rev 290722)
+++ trunk/LayoutTests/accessibility/select-element-at-index.html	2022-03-02 08:49:29 UTC (rev 290723)
@@ -51,13 +51,7 @@
 // "Option 4" is the third of three selected items, thus the index should be 2.
 shouldBeTrue("selectElement.selectedChildAtIndex(2).isEqual(option4)");
 
-// In ATSPI removeSelectionAtIndex() the index is with respect to the array of
-// selected children; not the array of all children. Thus to remove the selection
-// from "Option 4" in ATSPI, we again need to specify an index of 2.
-if (accessibilityController.platformName == "atspi")
-selectElement.removeSelectionAtIndex(2);
-else
-selectElement.removeSelectionAtIndex(3);
+selectElement.removeSelectionAtIndex(3);
 shouldBeFalse("option4.isSelected");
 shouldBe("selectElement.selectedChildrenCount", "2");
 


Modified: trunk/LayoutTests/platform/glib/TestExpectations (290722 => 290723)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-03-02 08:09:08 UTC (rev 290722)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-03-02 08:49:29 UTC (rev 290723)
@@ -413,9 +413,6 @@
 
 webkit.org/b/232256 accessibility/auto-fill-crash.html [ Timeout ]
 
-# Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
-
 #
 # End of Accessibility-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290633] trunk

2022-03-01 Thread carlosgc

Title: [290633] trunk








Revision 290633
Author carlo...@webkit.org
Date 2022-03-01 00:48:19 -0800 (Tue, 01 Mar 2022)


Log Message
[ATSPI] Remove layout tests checking children added/removed notifications
https://bugs.webkit.org/show_bug.cgi?id=237272

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Do not send children-changed notifications to WTR observers.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::childrenChanged):
(WebCore::AccessibilityAtspi::notifyChildrenChanged const): Deleted.
* accessibility/atspi/AccessibilityAtspi.h:

LayoutTests:

Children changed notifications are not expected by any other tests because other ports don't support them. We
already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we
don't emit those notifications either.

* accessibility/children-changed-sends-notification-expected.txt: Removed.
* accessibility/children-changed-sends-notification.html: Removed.
* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
* accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed.
* accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed.
* platform/glib/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/gtk/menu-list-unfocused-notifications-expected.txt
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/wincairo-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h


Removed Paths

trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt
trunk/LayoutTests/accessibility/children-changed-sends-notification.html
trunk/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt
trunk/LayoutTests/accessibility/gtk/no-notification-for-unrendered-iframe-children.html




Diff

Modified: trunk/LayoutTests/ChangeLog (290632 => 290633)

--- trunk/LayoutTests/ChangeLog	2022-03-01 08:00:50 UTC (rev 290632)
+++ trunk/LayoutTests/ChangeLog	2022-03-01 08:48:19 UTC (rev 290633)
@@ -1,3 +1,25 @@
+2022-03-01  Carlos Garcia Campos  
+
+[ATSPI] Remove layout tests checking children added/removed notifications
+https://bugs.webkit.org/show_bug.cgi?id=237272
+
+Reviewed by Adrian Perez de Castro.
+
+Children changed notifications are not expected by any other tests because other ports don't support them. We
+already have unit tests to ensure they work as expected so we can just remove the layout tests and ensure we
+don't emit those notifications either.
+
+* accessibility/children-changed-sends-notification-expected.txt: Removed.
+* accessibility/children-changed-sends-notification.html: Removed.
+* accessibility/gtk/menu-list-unfocused-notifications-expected.txt:
+* accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Removed.
+* accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Removed.
+* platform/glib/TestExpectations:
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wincairo-wk1/TestExpectations:
+
 2022-02-28  Tyler Wilcock  
 
 AX: WebKit should ignore empty modals rather than trapping focus inside them


Deleted: trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt (290632 => 290633)

--- trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt	2022-03-01 08:00:50 UTC (rev 290632)
+++ trunk/LayoutTests/accessibility/children-changed-sends-notification-expected.txt	2022-03-01 08:48:19 UTC (rev 290633)
@@ -1,17 +0,0 @@
-This test ensures that a notification is being emitted when children are added or removed for an accessibility object
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Plain text paragraph
-
-PARAGRAPH notification: AXChildrenAdded
-GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
-PARAGRAPH notification: AXChildrenRemoved
-GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
-PASS paragraphNotificationCount is globalNotificationCount
-PASS globalNotificationCount is 2
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/accessibility/children-changed-sends-notification.html (290632 => 290633)

--- trunk/LayoutTests/accessibility/children-changed-sends-notification.html	2022-03-01 08:00

[webkit-changes] [290593] releases/WebKitGTK/webkit-2.36

2022-02-28 Thread carlosgc

Title: [290593] releases/WebKitGTK/webkit-2.36








Revision 290593
Author carlo...@webkit.org
Date 2022-02-28 02:47:06 -0800 (Mon, 28 Feb 2022)


Log Message
Merge r290586 - [ATSPI] Always expose table cells (layout and CSS) that have rendered text content
https://bugs.webkit.org/show_bug.cgi?id=237204

Reviewed by Adrian Perez de Castro.

Source/WebCore:

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

LayoutTests:

* accessibility/gtk/nested-block-element-children-expected.txt: Rebaseline.
* platform/glib/TestExpectations: Remove accessibility/generated-content-with-display-table-crash.html.
* platform/gtk/TestExpectations: Remove accessibility/gtk/nested-block-element-children.html.

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (290592 => 290593)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-02-28 10:47:00 UTC (rev 290592)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-02-28 10:47:06 UTC (rev 290593)
@@ -1,5 +1,16 @@
 2022-02-28  Carlos Garcia Campos  
 
+[ATSPI] Always expose table cells (layout and CSS) that have rendered text content
+https://bugs.webkit.org/show_bug.cgi?id=237204
+
+Reviewed by Adrian Perez de Castro.
+
+* accessibility/gtk/nested-block-element-children-expected.txt: Rebaseline.
+* platform/glib/TestExpectations: Remove accessibility/generated-content-with-display-table-crash.html.
+* platform/gtk/TestExpectations: Remove accessibility/gtk/nested-block-element-children.html.
+
+2022-02-28  Carlos Garcia Campos  
+
 [GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
 https://bugs.webkit.org/show_bug.cgi?id=237202
 


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt (290592 => 290593)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt	2022-02-28 10:47:00 UTC (rev 290592)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt	2022-02-28 10:47:06 UTC (rev 290593)
@@ -1,20 +1,20 @@
 AXRole: AXWebArea
 AXRole: AXSection AXValue: Test 1
-AXRole: AXHeading AXValue: Test 1
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 1
 AXRole: AXHeading AXValue: Test 1
 AXRole: AXParagraph AXValue: Test 1
-AXRole: AXHeading AXValue: Test 2
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 2
 AXRole: AXHeading AXValue: Test 2
 AXRole: AXParagraph AXValue: Test 2
 AXRole: AXSection AXValue: Test 3
-AXRole: AXHeading AXValue: Test 3
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 3
 AXRole: AXHeading AXValue: Test 3
 AXRole: AXHeading AXValue: Test 3
 AXRole: AXParagraph AXValue: Test 3
-AXRole: AXHeading AXValue: Test 4
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 4
 AXRole: AXHeading AXValue: Test 4
 AXRole: AXParagraph AXValue: Test 4


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations (290592 => 290593)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations	2022-02-28 10:47:00 UTC (rev 290592)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/glib/TestExpectations	2022-02-28 10:47:06 UTC (rev 290593)
@@ -415,7 +415,6 @@
 
 # Tests failing with ATSPI implementation.
 webkit.org/b/235941 accessibility/children-changed-sends-notification.html [ Failure ]
-webkit.org/b/235941 accessibility/generated-content-with-display-table-crash.html [ Failure ]
 webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
 
 #


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations (290592 => 290593)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations	2022-02-28 10:47:00 UTC (rev 290592)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations	2022-02-28 10:47:06 UTC (rev 290593)
@@ -135,7 +135,6 @@
 accessibility/model-element-attributes.html [ Skip ]
 
 # Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/gtk/nested-block-element-children.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/no-notification-for-unrendered-iframe-c

[webkit-changes] [290592] releases/WebKitGTK/webkit-2.36

2022-02-28 Thread carlosgc

Title: [290592] releases/WebKitGTK/webkit-2.36








Revision 290592
Author carlo...@webkit.org
Date 2022-02-28 02:47:00 -0800 (Mon, 28 Feb 2022)


Log Message
Merge r290585 - [GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
https://bugs.webkit.org/show_bug.cgi?id=237202

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Handle the special case of form item having unknown aria role to be exposed as landmark.

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::effectiveRole const):

LayoutTests:

* platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html.
* platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.

Modified Paths

releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations
releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt
releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog (290591 => 290592)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-02-28 10:18:27 UTC (rev 290591)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/ChangeLog	2022-02-28 10:47:00 UTC (rev 290592)
@@ -1,3 +1,13 @@
+2022-02-28  Carlos Garcia Campos  
+
+[GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
+https://bugs.webkit.org/show_bug.cgi?id=237202
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html.
+* platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.
+
 2022-02-21  Cameron McCormack  
 
 Make input element UA shadow tree creation lazy


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations (290591 => 290592)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations	2022-02-28 10:18:27 UTC (rev 290591)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/TestExpectations	2022-02-28 10:47:00 UTC (rev 290592)
@@ -140,7 +140,6 @@
 webkit.org/b/235941 accessibility/gtk/spans.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-embedded-objects.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-special-chars.html [ Failure ]
-webkit.org/b/235941 accessibility/gtk/xml-roles-exposed.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/caret-offsets.html [ Timeout ]
 
 # canvas


Modified: releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt (290591 => 290592)

--- releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt	2022-02-28 10:18:27 UTC (rev 290591)
+++ releases/WebKitGTK/webkit-2.36/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt	2022-02-28 10:47:00 UTC (rev 290592)
@@ -20,7 +20,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live-role:alert, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
+AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live:assertive, container-live-role:alert, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
 
 AXRole: AXAlert
 AXParent: AXWebArea
@@ -39,7 +39,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: computed-role:alertdialog, container-live-role:alertdialog, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
+AXPlatformAttributes: computed-role:alertdialog, container-live:assertive, container-live-role:alertdialog, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
 
 AXRole: AXEmbedded
 AXParent: AXWebArea
@@ -438,6 +438,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
+AXURL: (null)
 AXPlatformAttributes: computed-role:image, tag:div, xml-roles:img
 
 AXRole: AXInsertion
@@ -496,7 +497,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: computed-role:log, container-live-role:log, container-live:polite, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
+AXPlatformAttributes: computed-role:log, container-live:polite, container-live-role:log, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
 
 AXRole: AXLandmarkMain
 AXParent: AXWebArea
@@ -534,7 +535,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPl

[webkit-changes] [290586] trunk

2022-02-28 Thread carlosgc

Title: [290586] trunk








Revision 290586
Author carlo...@webkit.org
Date 2022-02-28 01:00:19 -0800 (Mon, 28 Feb 2022)


Log Message
[ATSPI] Always expose table cells (layout and CSS) that have rendered text content
https://bugs.webkit.org/show_bug.cgi?id=237204

Reviewed by Adrian Perez de Castro.

Source/WebCore:

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject const):

LayoutTests:

* accessibility/gtk/nested-block-element-children-expected.txt: Rebaseline.
* platform/glib/TestExpectations: Remove accessibility/generated-content-with-display-table-crash.html.
* platform/gtk/TestExpectations: Remove accessibility/gtk/nested-block-element-children.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290585 => 290586)

--- trunk/LayoutTests/ChangeLog	2022-02-28 08:58:55 UTC (rev 290585)
+++ trunk/LayoutTests/ChangeLog	2022-02-28 09:00:19 UTC (rev 290586)
@@ -1,5 +1,16 @@
 2022-02-28  Carlos Garcia Campos  
 
+[ATSPI] Always expose table cells (layout and CSS) that have rendered text content
+https://bugs.webkit.org/show_bug.cgi?id=237204
+
+Reviewed by Adrian Perez de Castro.
+
+* accessibility/gtk/nested-block-element-children-expected.txt: Rebaseline.
+* platform/glib/TestExpectations: Remove accessibility/generated-content-with-display-table-crash.html.
+* platform/gtk/TestExpectations: Remove accessibility/gtk/nested-block-element-children.html.
+
+2022-02-28  Carlos Garcia Campos  
+
 [GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
 https://bugs.webkit.org/show_bug.cgi?id=237202
 


Modified: trunk/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt (290585 => 290586)

--- trunk/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt	2022-02-28 08:58:55 UTC (rev 290585)
+++ trunk/LayoutTests/accessibility/gtk/nested-block-element-children-expected.txt	2022-02-28 09:00:19 UTC (rev 290586)
@@ -1,20 +1,20 @@
 AXRole: AXWebArea
 AXRole: AXSection AXValue: Test 1
-AXRole: AXHeading AXValue: Test 1
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 1
 AXRole: AXHeading AXValue: Test 1
 AXRole: AXParagraph AXValue: Test 1
-AXRole: AXHeading AXValue: Test 2
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 2
 AXRole: AXHeading AXValue: Test 2
 AXRole: AXParagraph AXValue: Test 2
 AXRole: AXSection AXValue: Test 3
-AXRole: AXHeading AXValue: Test 3
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 3
 AXRole: AXHeading AXValue: Test 3
 AXRole: AXHeading AXValue: Test 3
 AXRole: AXParagraph AXValue: Test 3
-AXRole: AXHeading AXValue: Test 4
+AXRole: AXHeading AXValue: 
 AXRole: AXLink AXValue: Test 4
 AXRole: AXHeading AXValue: Test 4
 AXRole: AXParagraph AXValue: Test 4


Modified: trunk/LayoutTests/platform/glib/TestExpectations (290585 => 290586)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-02-28 08:58:55 UTC (rev 290585)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-02-28 09:00:19 UTC (rev 290586)
@@ -414,7 +414,6 @@
 
 # Tests failing with ATSPI implementation.
 webkit.org/b/235941 accessibility/children-changed-sends-notification.html [ Failure ]
-webkit.org/b/235941 accessibility/generated-content-with-display-table-crash.html [ Failure ]
 webkit.org/b/235941 accessibility/select-element-at-index.html [ Failure ]
 
 #


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (290585 => 290586)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-02-28 08:58:55 UTC (rev 290585)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-02-28 09:00:19 UTC (rev 290586)
@@ -135,7 +135,6 @@
 accessibility/model-element-attributes.html [ Skip ]
 
 # Tests failing with ATSPI implementation.
-webkit.org/b/235941 accessibility/gtk/nested-block-element-children.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/no-notification-for-unrendered-iframe-children.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-embedded-objects.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-special-chars.html [ Failure ]


Modified: trunk/Source/WebCore/ChangeLog (290585 => 290586)

--- trunk/Source/WebCore/ChangeLog	2022-02-28 08:58:55 UTC (rev 290585)
+++ trunk/Source/WebCore/ChangeLog	2022-02-28 09:00:19 UTC (rev 290586)
@@ -1,5 +1,15 @@
 2022-02-28  Carlos Garcia Campos  
 
+[ATSPI] Always expose

[webkit-changes] [290585] trunk

2022-02-28 Thread carlosgc

Title: [290585] trunk








Revision 290585
Author carlo...@webkit.org
Date 2022-02-28 00:58:55 -0800 (Mon, 28 Feb 2022)


Log Message
[GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
https://bugs.webkit.org/show_bug.cgi?id=237202

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Handle the special case of form item having unknown aria role to be exposed as landmark.

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::effectiveRole const):

LayoutTests:

* platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html.
* platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290584 => 290585)

--- trunk/LayoutTests/ChangeLog	2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/ChangeLog	2022-02-28 08:58:55 UTC (rev 290585)
@@ -1,3 +1,13 @@
+2022-02-28  Carlos Garcia Campos  
+
+[GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
+https://bugs.webkit.org/show_bug.cgi?id=237202
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html.
+* platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.
+
 2022-02-27  Jonathan Bedard  
 
 webkitpy: WebSocket server doesn't support Python 3


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (290584 => 290585)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-02-28 08:58:55 UTC (rev 290585)
@@ -139,7 +139,6 @@
 webkit.org/b/235941 accessibility/gtk/no-notification-for-unrendered-iframe-children.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-embedded-objects.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/text-at-offset-special-chars.html [ Failure ]
-webkit.org/b/235941 accessibility/gtk/xml-roles-exposed.html [ Failure ]
 webkit.org/b/235941 accessibility/gtk/caret-offsets.html [ Timeout ]
 
 # canvas


Modified: trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt (290584 => 290585)

--- trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt	2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt	2022-02-28 08:58:55 UTC (rev 290585)
@@ -20,7 +20,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live-role:alert, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
+AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live:assertive, container-live-role:alert, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
 
 AXRole: AXAlert
 AXParent: AXWebArea
@@ -39,7 +39,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: computed-role:alertdialog, container-live-role:alertdialog, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
+AXPlatformAttributes: computed-role:alertdialog, container-live:assertive, container-live-role:alertdialog, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
 
 AXRole: AXEmbedded
 AXParent: AXWebArea
@@ -438,6 +438,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
+AXURL: (null)
 AXPlatformAttributes: computed-role:image, tag:div, xml-roles:img
 
 AXRole: AXInsertion
@@ -496,7 +497,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: computed-role:log, container-live-role:log, container-live:polite, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
+AXPlatformAttributes: computed-role:log, container-live:polite, container-live-role:log, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
 
 AXRole: AXLandmarkMain
 AXParent: AXWebArea
@@ -534,7 +535,7 @@
 AXExpanded: 0
 AXRequired: 0
 AXChecked: 0
-AXPlatformAttributes: computed-role:marquee, container-live-role:marquee, container-live:off, container-relevant:additions text, live:off, relevant:additions text, tag:div, xml-roles:marquee
+AXPlatformAttributes: computed-role:marquee, container-live:off, container-live-role:marquee, container-relevant:additions text, live:off, relevant:additions te

[webkit-changes] [290504] releases/WebKitGTK/webkit-2.35.90/

2022-02-25 Thread carlosgc

Title: [290504] releases/WebKitGTK/webkit-2.35.90/








Revision 290504
Author carlo...@webkit.org
Date 2022-02-25 01:50:48 -0800 (Fri, 25 Feb 2022)


Log Message
WebKitGTK 2.35.90

Added Paths

releases/WebKitGTK/webkit-2.35.90/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290503] releases/WebKitGTK/webkit-2.36

2022-02-25 Thread carlosgc

Title: [290503] releases/WebKitGTK/webkit-2.36








Revision 290503
Author carlo...@webkit.org
Date 2022-02-25 01:50:11 -0800 (Fri, 25 Feb 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.90 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.35.90.

Modified Paths

releases/WebKitGTK/webkit-2.36/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (290502 => 290503)

--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-02-25 09:17:31 UTC (rev 290502)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-02-25 09:50:11 UTC (rev 290503)
@@ -1,3 +1,9 @@
+2022-02-25  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.90 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-02-21  Carlos Garcia Campos  
 
 [GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (290502 => 290503)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 09:17:31 UTC (rev 290502)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 09:50:11 UTC (rev 290503)
@@ -1,3 +1,9 @@
+2022-02-25  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.90 release
+
+* gtk/NEWS: Add release notes for 2.35.90.
+
 2022-02-23  Philippe Normand  
 
 [GStreamer] De-initialize GStreamer before terminating WebProcess


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS (290502 => 290503)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-02-25 09:17:31 UTC (rev 290502)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/gtk/NEWS	2022-02-25 09:50:11 UTC (rev 290503)
@@ -1,3 +1,19 @@
+=
+WebKitGTK 2.35.90
+=
+
+What's new in WebKitGTK 2.35.90?
+
+  - Fix scrolling with the mouse wheel on sites using overscroll-behavior.
+  - Suspend web processes after some time in the process cache.
+  - Fix renderning of horizontal scrollbars with themes enabling steppers.
+  - Ensure EGL displays are terminated before web process exits.
+  - Deinitialize gstreamer before web process exits.
+  - Make fonts under XDG_DATA_DIRS available in web process sanbox.
+  - Canonicalize paths passed to bubblewrap launcher.
+  - Fix several crashes and rendering issues.
+  - Translation updates: Hebrew.
+
 
 WebKitGTK 2.35.3
 


Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake (290502 => 290503)

--- releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-02-25 09:17:31 UTC (rev 290502)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/OptionsGTK.cmake	2022-02-25 09:50:11 UTC (rev 290503)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 35 3)
+SET_PROJECT_VERSION(2 35 90)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 2 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 2 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 3 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 3 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 2 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 2 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 3 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 3 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290502] trunk

2022-02-25 Thread carlosgc

Title: [290502] trunk








Revision 290502
Author carlo...@webkit.org
Date 2022-02-25 01:17:31 -0800 (Fri, 25 Feb 2022)


Log Message
AX: List item marker not exposed when not a direct child of a list item
https://bugs.webkit.org/show_bug.cgi?id=236777


Reviewed by Adrian Perez de Castro.

Source/WebCore:

It can happen that the marker is not a direct child of a list item, in which case the marker is ignored and not
exposed to ATs.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectUnignored const): In case of list marker find the marker list item.
(WebCore::AccessibilityRenderObject::markerRenderer const): Helper to return the list item marker renderer.
(WebCore::AccessibilityRenderObject::addListItemMarker): Add always the list item marker as the first child of
list items.
(WebCore::AccessibilityRenderObject::addChildren): Do not add list item marker children, they will be added to
the right parent in addListItemMarker().
* accessibility/AccessibilityRenderObject.h:

Tools:

* WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::roleValueToString): Return AXStatic for Text role too.

LayoutTests:

Update test results.

* accessibility/gtk/list-items-always-exposed-expected.txt:
* accessibility/gtk/list-items-always-exposed.html:
* accessibility/gtk/spans-expected.txt:
* accessibility/gtk/spans.html:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt
trunk/LayoutTests/accessibility/gtk/list-items-always-exposed.html
trunk/LayoutTests/accessibility/gtk/spans-expected.txt
trunk/LayoutTests/accessibility/gtk/spans.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (290501 => 290502)

--- trunk/LayoutTests/ChangeLog	2022-02-25 08:51:49 UTC (rev 290501)
+++ trunk/LayoutTests/ChangeLog	2022-02-25 09:17:31 UTC (rev 290502)
@@ -1,3 +1,19 @@
+2022-02-25  Carlos Garcia Campos  
+
+AX: List item marker not exposed when not a direct child of a list item
+https://bugs.webkit.org/show_bug.cgi?id=236777
+
+
+Reviewed by Adrian Perez de Castro.
+
+Update test results.
+
+* accessibility/gtk/list-items-always-exposed-expected.txt:
+* accessibility/gtk/list-items-always-exposed.html:
+* accessibility/gtk/spans-expected.txt:
+* accessibility/gtk/spans.html:
+* platform/gtk/TestExpectations:
+
 2022-02-25  Arcady Goldmints-Orlov  
 
 [GLIB] Update test baselines after various LFC improvements.


Modified: trunk/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt (290501 => 290502)

--- trunk/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt	2022-02-25 08:51:49 UTC (rev 290501)
+++ trunk/LayoutTests/accessibility/gtk/list-items-always-exposed-expected.txt	2022-02-25 09:17:31 UTC (rev 290502)
@@ -8,7 +8,9 @@
 
 PASS list.role is 'AXRole: AXList'
 PASS item1.role is 'AXRole: AXListItem'
+PASS marker1.role is 'AXRole: AXStatic'
 PASS item2.role is 'AXRole: AXListItem'
+PASS marker2.role is 'AXRole: AXStatic'
 PASS paragraph.role is 'AXRole: AXParagraph'
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/accessibility/gtk/list-items-always-exposed.html (290501 => 290502)

--- trunk/LayoutTests/accessibility/gtk/list-items-always-exposed.html	2022-02-25 08:51:49 UTC (rev 290501)
+++ trunk/LayoutTests/accessibility/gtk/list-items-always-exposed.html	2022-02-25 09:17:31 UTC (rev 290502)
@@ -23,12 +23,16 @@
 
 var list = webArea.childAtIndex(0);
 var item1 = list.childAtIndex(0);
+var marker1 = item1.childAtIndex(0);
 var item2 = list.childAtIndex(1);
-var paragraph = item2.childAtIndex(0);
+var marker2 = item2.childAtIndex(0);
+var paragraph = item2.childAtIndex(1);
 
 shouldBe("list.role", "'AXRole: AXList'");
 shouldBe("item1.role", "'AXRole: AXListItem'");
+shouldBe("marker1.role", "'AXRole: AXStatic'");
 shouldBe("item2.role", "'AXRole: AXListItem'");
+shouldBe("marker2.role", "'AXRole: AXStatic'");
 shouldBe("paragraph.role", "'AXRole: AXParagraph'");
   }
 }


Modified: trunk/LayoutTests/accessibility/gtk/spans-expected.txt (290501 => 290502)

--- trunk/LayoutTests/accessibility/gtk/spans-expected.txt	2022-02-25 08:51:49 UTC (rev 290501)
+++ trunk/LayoutTests/accessibility/gtk/spans-expected.txt	2022-02-25 09:17:31 UTC (rev 290502)
@@ -26,9 +26,13 @@
 PASS element.role is 'AXRole: AXList'
 PASS element.childrenCount is 2
 PASS item.role is 'AXRole: AXListItem'
-PASS item.childrenCount is 0
+PASS item.childrenCount is 1
+PASS marker.role is 'AXRole: AXStatic'
+P

[webkit-changes] [290500] trunk

2022-02-25 Thread carlosgc

Title: [290500] trunk








Revision 290500
Author carlo...@webkit.org
Date 2022-02-25 00:26:02 -0800 (Fri, 25 Feb 2022)


Log Message
Unreviewed. [GTK] Bump version numbers

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (290499 => 290500)

--- trunk/ChangeLog	2022-02-25 08:21:58 UTC (rev 290499)
+++ trunk/ChangeLog	2022-02-25 08:26:02 UTC (rev 290500)
@@ -1,3 +1,9 @@
+2022-02-25  Carlos Garcia Campos  
+
+Unreviewed. [GTK] Bump version numbers
+
+* Source/cmake/OptionsGTK.cmake:
+
 2022-02-24  Ryosuke Niwa  
 
 Explain visit children and opaque roots in Introduction.md


Modified: trunk/Source/cmake/OptionsGTK.cmake (290499 => 290500)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-02-25 08:21:58 UTC (rev 290499)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-02-25 08:26:02 UTC (rev 290500)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 35 3)
+SET_PROJECT_VERSION(2 37 0)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -228,11 +228,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 2 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 2 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 94 0 57)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 39 0 21)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 2 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 2 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 2 0 2)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 2 0 2)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290499] releases/WebKitGTK/webkit-2.36

2022-02-25 Thread carlosgc

Title: [290499] releases/WebKitGTK/webkit-2.36








Revision 290499
Author carlo...@webkit.org
Date 2022-02-25 00:21:58 -0800 (Fri, 25 Feb 2022)


Log Message
Merge r290375 - [GStreamer] De-initialize GStreamer before terminating WebProcess
https://bugs.webkit.org/show_bug.cgi?id=237084

Patch by Philippe Normand  on 2022-02-23
Reviewed by Carlos Garcia Campos.

Source/WebKit:

Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
exits too early, the leak tracer reporting will be interrupted potentially too early. The
workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
handling and leak tracing was done and keeping the second tab open.

* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):

Tools:

* flatpak/flatpakutils.py:
(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
to store paths.

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp
releases/WebKitGTK/webkit-2.36/Tools/ChangeLog
releases/WebKitGTK/webkit-2.36/Tools/flatpak/flatpakutils.py




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (290498 => 290499)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 08:19:41 UTC (rev 290498)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 08:21:58 UTC (rev 290499)
@@ -1,3 +1,18 @@
+2022-02-23  Philippe Normand  
+
+[GStreamer] De-initialize GStreamer before terminating WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=237084
+
+Reviewed by Carlos Garcia Campos.
+
+Allowing the leak tracer to report/log leaks. There is an issue though, if the UIProcess
+exits too early, the leak tracer reporting will be interrupted potentially too early. The
+workaround is to have 2 tabs open in the GTK MiniBrowser, closing the one where media
+handling and leak tracing was done and keeping the second tab open.
+
+* WebProcess/glib/WebProcessGLib.cpp:
+(WebKit::WebProcess::stopRunLoop):
+
 2022-02-22  Brent Fulgham  
 
 PingLoader is failing to call completion handler in error case


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp (290498 => 290499)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2022-02-25 08:19:41 UTC (rev 290498)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2022-02-25 08:21:58 UTC (rev 290499)
@@ -36,6 +36,10 @@
 #include 
 #endif
 
+#if USE(GSTREAMER)
+#include 
+#endif
+
 #if USE(GCRYPT)
 #include 
 #endif
@@ -67,6 +71,13 @@
 
 return true;
 }
+
+void platformFinalize() override
+{
+#if USE(GSTREAMER)
+gst_deinit();
+#endif
+}
 };
 
 int WebProcessMain(int argc, char** argv)


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp (290498 => 290499)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp	2022-02-25 08:19:41 UTC (rev 290498)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/wpe/WebProcessMainWPE.cpp	2022-02-25 08:21:58 UTC (rev 290499)
@@ -40,6 +40,10 @@
 #include 
 #endif
 
+#if USE(GSTREAMER)
+#include 
+#endif
+
 namespace WebKit {
 using namespace WebCore;
 
@@ -99,6 +103,13 @@
 
 return true;
 }
+
+void platformFinalize() override
+{
+#if USE(GSTREAMER)
+gst_deinit();
+#endif
+}
 };
 
 int WebProcessMain(int argc, char** argv)


Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (290498 => 290499)

--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-02-25 08:19:41 UTC (rev 290498)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-02-25 08:21:58 UTC (rev 290499)
@@ -1,3 +1,14 @@
+2022-02-23  Philippe Normand  
+
+[GStreamer] De-initialize GStreamer before terminating WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=237084
+
+Reviewed by Carlos Garcia Campos.
+
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.setup_gstbuild): Do not add extra quotes to GST_TRACERS, this is not supposed
+to store paths.
+
 2022-02-22  Carlos Garcia Campos  
 
 [GTK] Can't run performance tests due to a11y errors


Modified: releases/WebKitGTK/webkit-2.36/Tools/flatpak/flatpakutils.py (290498 => 290499)

--- releases/WebKitGTK/webkit-2.36/Tools/flatpak/flatpakutils.py	2022-02-25 08:19:41 UTC (rev 290498)
+++ releases/WebKitGTK/webkit-2.36/Tools/flatpak/flatpakutils.py	2022-02-25 08:21:58 UTC (rev 290499)
@@ -691,7 +691,7 @@
 command = [os.path.join(gst_dir, 'gst-env.py'), '--builddir', gst_builddir, '--srcdir', gst_dir, "--only-environment"]
 gst_env = run_sanitized(command, gather_output=True)

[webkit-changes] [290498] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-02-25 Thread carlosgc

Title: [290498] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 290498
Author carlo...@webkit.org
Date 2022-02-25 00:19:41 -0800 (Fri, 25 Feb 2022)


Log Message
Merge r290341 - CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=237002

Reviewed by Darin Adler.

Store URLs in the HashMaps instead of Strings since we have URLs initially and we
need URLs eventually. This avoids having to re-parse the URL unnecessarily, which
is fairly expensive.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
(WebCore::CachedResourceLoader::notifyFinished):
* loader/cache/CachedResourceLoader.h:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.cpp
releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.h




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (290497 => 290498)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-25 08:16:21 UTC (rev 290497)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-25 08:19:41 UTC (rev 290498)
@@ -1,3 +1,20 @@
+2022-02-22  Chris Dumez  
+
+CachedResourceLoader::allCachedSVGImages() reparses resource URLs unnecessarily
+https://bugs.webkit.org/show_bug.cgi?id=237002
+
+Reviewed by Darin Adler.
+
+Store URLs in the HashMaps instead of Strings since we have URLs initially and we
+need URLs eventually. This avoids having to re-parse the URL unnecessarily, which
+is fairly expensive.
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::CachedResourceLoader::requestResource):
+(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
+(WebCore::CachedResourceLoader::notifyFinished):
+* loader/cache/CachedResourceLoader.h:
+
 2022-02-22  Pablo Saavedra  
 
 Properly uninitialize EGL display before termination


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.cpp (290497 => 290498)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2022-02-25 08:16:21 UTC (rev 290497)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2022-02-25 08:19:41 UTC (rev 290498)
@@ -1092,7 +1092,7 @@
 }
 
 if (document() && !document()->loadEventFinished() && !resource->resourceRequest().url().protocolIsData())
-m_validatedURLs.add(resource->resourceRequest().url().string());
+m_validatedURLs.add(resource->resourceRequest().url());
 
 ASSERT(resource->url() == url.string());
 m_documentResources.set(resource->url().string(), resource);
@@ -1300,7 +1300,7 @@
 }
 
 // During the initial load, avoid loading the same resource multiple times for a single document, even if the cache policies would tell us to.
-if (document() && !document()->loadEventFinished() && m_validatedURLs.contains(existingResource->url().string()))
+if (document() && !document()->loadEventFinished() && m_validatedURLs.contains(existingResource->url()))
 return Use;
 
 // CachePolicy::Reload always reloads
@@ -1509,7 +1509,7 @@
 void CachedResourceLoader::notifyFinished(const CachedResource& resource)
 {
 if (isSVGImageCachedResource(&resource))
-m_cachedSVGImagesURLs.add(resource.url().string());
+m_cachedSVGImagesURLs.add(resource.url());
 }
 
 Vector> CachedResourceLoader::allCachedSVGImages() const


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.h (290497 => 290498)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.h	2022-02-25 08:16:21 UTC (rev 290497)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/loader/cache/CachedResourceLoader.h	2022-02-25 08:19:41 UTC (rev 290498)
@@ -200,8 +200,8 @@
 bool canRequestAfterRedirection(CachedResource::Type, const URL&, const ResourceLoaderOptions&, const URL& preRedirectURL) const;
 bool canRequestInContentDispositionAttachmentSandbox(CachedResource::Type, const URL&) const;
 
-HashSet m_validatedURLs;
-HashSet m_cachedSVGImagesURLs;
+HashSet m_validatedURLs;
+HashSet m_cachedSVGImagesURLs;
 mutable DocumentResourceMap m_documentResources;
 WeakPtr m_document;
 DocumentLoader* m_documentLoader;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290497] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-02-25 Thread carlosgc

Title: [290497] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 290497
Author carlo...@webkit.org
Date 2022-02-25 00:16:21 -0800 (Fri, 25 Feb 2022)


Log Message
Merge r290338 - PingLoader is failing to call completion handler in error case
https://bugs.webkit.org/show_bug.cgi?id=237062


Reviewed by Chris Dumez.

The completion handler was not being called in the case of a PingLoad being redirected to
a non-HTTP(S) scheme.

* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/NetworkProcess/PingLoad.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (290496 => 290497)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 08:12:27 UTC (rev 290496)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-25 08:16:21 UTC (rev 290497)
@@ -1,3 +1,17 @@
+2022-02-22  Brent Fulgham  
+
+PingLoader is failing to call completion handler in error case
+https://bugs.webkit.org/show_bug.cgi?id=237062
+
+
+Reviewed by Chris Dumez.
+
+The completion handler was not being called in the case of a PingLoad being redirected to
+a non-HTTP(S) scheme.
+
+* NetworkProcess/PingLoad.cpp:
+(WebKit::PingLoad::willPerformHTTPRedirection):
+
 2022-02-23  Maxim Cournoyer  
 
 [WPE][GTK] Paths should be canonicalized before calling bwrap


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/NetworkProcess/PingLoad.cpp (290496 => 290497)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/NetworkProcess/PingLoad.cpp	2022-02-25 08:12:27 UTC (rev 290496)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/NetworkProcess/PingLoad.cpp	2022-02-25 08:16:21 UTC (rev 290497)
@@ -134,13 +134,14 @@
 {
 m_networkLoadChecker->checkRedirection(ResourceRequest { }, WTFMove(request), WTFMove(redirectResponse), nullptr, [this, completionHandler = WTFMove(completionHandler)] (auto&& result) mutable {
 if (!result.has_value()) {
+this->didFinish(result.error());
 completionHandler({ });
-this->didFinish(result.error());
 return;
 }
 auto request = WTFMove(result->redirectRequest);
 if (!request.url().protocolIsInHTTPFamily()) {
 this->didFinish(ResourceError { String { }, 0, request.url(), "Redirection to URL with a scheme that is not HTTP(S)"_s, ResourceError::Type::AccessControl });
+completionHandler({ });
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290427] releases/WebKitGTK/webkit-2.36/Source/WTF

2022-02-24 Thread carlosgc

Title: [290427] releases/WebKitGTK/webkit-2.36/Source/WTF








Revision 290427
Author carlo...@webkit.org
Date 2022-02-24 06:27:40 -0800 (Thu, 24 Feb 2022)


Log Message
Merge r290417 - REGRESSION(r289683): [GTK][WPE] Scrolling with the mouse wheel doesn't work in twitter after r289683
https://bugs.webkit.org/show_bug.cgi?id=237093

Reviewed by Carlos Garcia Campos.

Turn off by default for wpe/gtk and windows to investigate issue.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WTF/ChangeLog (290426 => 290427)

--- releases/WebKitGTK/webkit-2.36/Source/WTF/ChangeLog	2022-02-24 12:32:45 UTC (rev 290426)
+++ releases/WebKitGTK/webkit-2.36/Source/WTF/ChangeLog	2022-02-24 14:27:40 UTC (rev 290427)
@@ -1,3 +1,14 @@
+2022-02-24  Nikolaos Mouchtaris  
+
+REGRESSION(r289683): [GTK][WPE] Scrolling with the mouse wheel doesn't work in twitter after r289683
+https://bugs.webkit.org/show_bug.cgi?id=237093
+
+Reviewed by Carlos Garcia Campos.
+ 
+Turn off by default for wpe/gtk and windows to investigate issue.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2022-02-21  Robin Morisset  
 
 [JSC] Format the output of --reportTotalPhaseTimes=1 more nicely


Modified: releases/WebKitGTK/webkit-2.36/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (290426 => 290427)

--- releases/WebKitGTK/webkit-2.36/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-02-24 12:32:45 UTC (rev 290426)
+++ releases/WebKitGTK/webkit-2.36/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-02-24 14:27:40 UTC (rev 290427)
@@ -976,8 +976,10 @@
 WebKitLegacy:
   default: false
 WebKit:
+  "PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(WPE)": false
   default: true
 WebCore:
+  "PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(WPE)": false
   default: true
 
 PageAtRuleSupportEnabled:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290420] trunk/Source/WTF

2022-02-24 Thread carlosgc

Title: [290420] trunk/Source/WTF








Revision 290420
Author carlo...@webkit.org
Date 2022-02-24 02:22:01 -0800 (Thu, 24 Feb 2022)


Log Message
Unreviewed. Fix compile warnings when asserts are disabled after r290418

* wtf/Threading.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
* wtf/WorkQueue.h:
(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Threading.h
trunk/Source/WTF/wtf/WorkQueue.h




Diff

Modified: trunk/Source/WTF/ChangeLog (290419 => 290420)

--- trunk/Source/WTF/ChangeLog	2022-02-24 09:42:27 UTC (rev 290419)
+++ trunk/Source/WTF/ChangeLog	2022-02-24 10:22:01 UTC (rev 290420)
@@ -1,3 +1,12 @@
+2022-02-24  Carlos Garcia Campos  
+
+Unreviewed. Fix compile warnings when asserts are disabled after r290418
+
+* wtf/Threading.h:
+(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
+* wtf/WorkQueue.h:
+(WTF::WTF_ASSERTS_ACQUIRED_CAPABILITY):
+
 2022-02-24  Kimmo Kinnunen  
 
 Thread safety analysis to assert "code is run sequentially" is not useful when code is mainly run with WorkQueues


Modified: trunk/Source/WTF/wtf/Threading.h (290419 => 290420)

--- trunk/Source/WTF/wtf/Threading.h	2022-02-24 09:42:27 UTC (rev 290419)
+++ trunk/Source/WTF/wtf/Threading.h	2022-02-24 10:22:01 UTC (rev 290420)
@@ -430,7 +430,11 @@
 
 inline void assertIsCurrent(const Thread& thread) WTF_ASSERTS_ACQUIRED_CAPABILITY(thread)
 {
+#if ASSERT_ENABLED
 ASSERT(&thread == &Thread::current());
+#else
+UNUSED_PARAM(thread);
+#endif
 }
 
 } // namespace WTF


Modified: trunk/Source/WTF/wtf/WorkQueue.h (290419 => 290420)

--- trunk/Source/WTF/wtf/WorkQueue.h	2022-02-24 09:42:27 UTC (rev 290419)
+++ trunk/Source/WTF/wtf/WorkQueue.h	2022-02-24 10:22:01 UTC (rev 290420)
@@ -122,6 +122,8 @@
 {
 #if ASSERT_ENABLED
 workQueue.assertIsCurrent();
+#else
+UNUSED_PARAM(workQueue);
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290419] trunk/Source/WebCore

2022-02-24 Thread carlosgc

Title: [290419] trunk/Source/WebCore








Revision 290419
Author carlo...@webkit.org
Date 2022-02-24 01:42:27 -0800 (Thu, 24 Feb 2022)


Log Message
Unreviewed. [GTK] Mark GLContextGLX.cpp as no-unify

* SourcesGTK.txt:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesGTK.txt




Diff

Modified: trunk/Source/WebCore/ChangeLog (290418 => 290419)

--- trunk/Source/WebCore/ChangeLog	2022-02-24 09:03:31 UTC (rev 290418)
+++ trunk/Source/WebCore/ChangeLog	2022-02-24 09:42:27 UTC (rev 290419)
@@ -1,3 +1,9 @@
+2022-02-24  Carlos Garcia Campos  
+
+Unreviewed. [GTK] Mark GLContextGLX.cpp as no-unify
+
+* SourcesGTK.txt:
+
 2022-02-23  Commit Queue  
 
 Unreviewed, reverting r290284.


Modified: trunk/Source/WebCore/SourcesGTK.txt (290418 => 290419)

--- trunk/Source/WebCore/SourcesGTK.txt	2022-02-24 09:03:31 UTC (rev 290418)
+++ trunk/Source/WebCore/SourcesGTK.txt	2022-02-24 09:42:27 UTC (rev 290419)
@@ -103,7 +103,7 @@
 
 platform/graphics/gbm/GBMDevice.cpp
 
-platform/graphics/glx/GLContextGLX.cpp
+platform/graphics/glx/GLContextGLX.cpp @no-unify
 
 platform/graphics/gtk/ColorGtk.cpp
 platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290365] releases/WebKitGTK/webkit-2.36/Source/WebKit

2022-02-23 Thread carlosgc

Title: [290365] releases/WebKitGTK/webkit-2.36/Source/WebKit








Revision 290365
Author carlo...@webkit.org
Date 2022-02-23 04:06:12 -0800 (Wed, 23 Feb 2022)


Log Message
Merge r290360 - [GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
https://bugs.webkit.org/show_bug.cgi?id=217655

Stop the run loop for GTK and WPE to ensure a normal exit, since we need
atexit handlers to be called to cleanup resources like EGL displays.

Reviewed by Carlos Garcia Campos.

* Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::didClose):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
* WebProcess/WebProcess.h:
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::stopRunLoop):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h
releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/ChangeLog	2022-02-23 12:06:12 UTC (rev 290365)
@@ -1,3 +1,21 @@
+2022-02-23  Pablo Saavedra  
+
+[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called
+https://bugs.webkit.org/show_bug.cgi?id=217655
+
+Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+atexit handlers to be called to cleanup resources like EGL displays.
+
+Reviewed by Carlos Garcia Campos.
+
+* Shared/AuxiliaryProcess.cpp:
+(WebKit::AuxiliaryProcess::didClose):
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeConnection):
+* WebProcess/WebProcess.h:
+* WebProcess/glib/WebProcessGLib.cpp:
+(WebKit::WebProcess::stopRunLoop):
+
 2022-02-22  Kate Cheney  
 
 NSSharingServicePicker gets deallocated when using the standard share menu item


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/Shared/AuxiliaryProcess.cpp	2022-02-23 12:06:12 UTC (rev 290365)
@@ -60,7 +60,13 @@
 
 void AuxiliaryProcess::didClose(IPC::Connection&)
 {
+// Stop the run loop for GTK and WPE to ensure a normal exit, since we need
+// atexit handlers to be called to cleanup resources like EGL displays.
+#if PLATFORM(GTK) || PLATFORM(WPE)
+stopRunLoop();
+#else
 _exit(EXIT_SUCCESS);
+#endif
 }
 
 void AuxiliaryProcess::initialize(const AuxiliaryProcessInitializationParameters& parameters)


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.cpp	2022-02-23 12:06:12 UTC (rev 290365)
@@ -257,6 +257,7 @@
 using namespace JSC;
 using namespace WebCore;
 
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 NO_RETURN static void callExit(IPC::Connection*)
 {
 #if OS(WINDOWS)
@@ -266,6 +267,7 @@
 _exit(EXIT_SUCCESS);
 #endif
 }
+#endif
 
 WebProcess& WebProcess::singleton()
 {
@@ -359,9 +361,13 @@
 {
 AuxiliaryProcess::initializeConnection(connection);
 
+// Do not call exit in background queue for GTK and WPE because we need to ensure
+// atexit handlers are called in the main thread to cleanup resources like EGL displays.
+#if !PLATFORM(GTK) && !PLATFORM(WPE)
 // We call _exit() directly from the background queue in case the main thread is unresponsive
 // and AuxiliaryProcess::didClose() does not get called.
 connection->setDidCloseOnConnectionWorkQueueCallback(callExit);
+#endif
 
 #if !PLATFORM(GTK) && !PLATFORM(WPE) && !ENABLE(IPC_TESTING_API)
 connection->setShouldExitOnSyncMessageSendFailure(true);


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebProcess.h	2022-02-23 12:06:12 UTC (rev 290365)
@@ -511,7 +511,7 @@
 bool shouldTerminate() override;
 void terminate() override;
 
-#if USE(APPKIT)
+#if USE(APPKIT) || PLATFORM(GTK) || PLATFORM(WPE)
 void stopRunLoop() override;
 #endif
 


Modified: releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp (290364 => 290365)

--- releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp	2022-02-23 12:06:05 UTC (rev 290364)
+++ releases/WebKi

[webkit-changes] [290364] releases/WebKitGTK/webkit-2.36/Source/WebCore

2022-02-23 Thread carlosgc

Title: [290364] releases/WebKitGTK/webkit-2.36/Source/WebCore








Revision 290364
Author carlo...@webkit.org
Date 2022-02-23 04:06:05 -0800 (Wed, 23 Feb 2022)


Log Message
Merge r290299 - Properly uninitialize EGL display before termination
https://bugs.webkit.org/show_bug.cgi?id=236766

>From the docs [1], if contexts or surfaces associated with display
is current to any thread, they are not released until they
are no longer current as a result of eglMakeCurrent.

So call eglMakeCurrent() to such effect.

[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml

Reviewed by Carlos Garcia Campos.

* platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::terminateEGLDisplay):

Modified Paths

releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog (290363 => 290364)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-23 11:49:04 UTC (rev 290363)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/ChangeLog	2022-02-23 12:06:05 UTC (rev 290364)
@@ -1,3 +1,21 @@
+2022-02-22  Pablo Saavedra  
+
+Properly uninitialize EGL display before termination
+https://bugs.webkit.org/show_bug.cgi?id=236766
+
+From the docs [1], if contexts or surfaces associated with display
+is current to any thread, they are not released until they
+are no longer current as a result of eglMakeCurrent.
+
+So call eglMakeCurrent() to such effect.
+
+[1] https://www.khronos.org/registry/EGL/sdk/docs/man/html/eglMakeCurrent.xhtml
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/graphics/PlatformDisplay.cpp:
+(WebCore::PlatformDisplay::terminateEGLDisplay):
+
 2022-02-21  Alex Christensen  
 
 Improve const correctness for SecurityOrigin accessors


Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp (290363 => 290364)

--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-23 11:49:04 UTC (rev 290363)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-23 12:06:05 UTC (rev 290364)
@@ -278,6 +278,7 @@
 ASSERT(m_eglDisplayInitialized);
 if (m_eglDisplay == EGL_NO_DISPLAY)
 return;
+eglMakeCurrent(m_eglDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
 eglTerminate(m_eglDisplay);
 m_eglDisplay = EGL_NO_DISPLAY;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290294] releases/WebKitGTK/webkit-2.36/

2022-02-22 Thread carlosgc

Title: [290294] releases/WebKitGTK/webkit-2.36/








Revision 290294
Author carlo...@webkit.org
Date 2022-02-22 01:42:11 -0800 (Tue, 22 Feb 2022)


Log Message
Branch WebKitGTK for 2.36

Added Paths

releases/WebKitGTK/webkit-2.36/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290293] trunk/Tools

2022-02-22 Thread carlosgc

Title: [290293] trunk/Tools








Revision 290293
Author carlo...@webkit.org
Date 2022-02-22 01:24:18 -0800 (Tue, 22 Feb 2022)


Log Message
[GTK] Can't run performance tests due to a11y errors
https://bugs.webkit.org/show_bug.cgi?id=230705

Reviewed by Sergio Villar Senin.

Disable a11y in WTR since it's no longer nedded with ATSPI.

* WebKitTestRunner/gtk/main.cpp:
(main):
* WebKitTestRunner/wpe/main.cpp:
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/main.cpp
trunk/Tools/WebKitTestRunner/wpe/main.cpp




Diff

Modified: trunk/Tools/ChangeLog (290292 => 290293)

--- trunk/Tools/ChangeLog	2022-02-22 09:05:51 UTC (rev 290292)
+++ trunk/Tools/ChangeLog	2022-02-22 09:24:18 UTC (rev 290293)
@@ -1,3 +1,17 @@
+2022-02-22  Carlos Garcia Campos  
+
+[GTK] Can't run performance tests due to a11y errors
+https://bugs.webkit.org/show_bug.cgi?id=230705
+
+Reviewed by Sergio Villar Senin.
+
+Disable a11y in WTR since it's no longer nedded with ATSPI.
+
+* WebKitTestRunner/gtk/main.cpp:
+(main):
+* WebKitTestRunner/wpe/main.cpp:
+(main):
+
 2022-02-21  Brandon Stewart  
 
 Use ArgumentParser for parsing args in generate-compile-commands


Modified: trunk/Tools/WebKitTestRunner/gtk/main.cpp (290292 => 290293)

--- trunk/Tools/WebKitTestRunner/gtk/main.cpp	2022-02-22 09:05:51 UTC (rev 290292)
+++ trunk/Tools/WebKitTestRunner/gtk/main.cpp	2022-02-22 09:24:18 UTC (rev 290293)
@@ -47,8 +47,16 @@
 int main(int argc, char** argv)
 {
 g_setenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR", "1", FALSE);
+#if USE(ATSPI)
 g_setenv("WEBKIT_A11Y_BUS_ADDRESS", "", FALSE);
+#if USE(GTK4)
+g_setenv("GTK_A11Y", "none", TRUE);
+#else
+g_setenv("NO_AT_BRIDGE", "1", TRUE);
+#endif
+#endif
 
+
 gtk_init(&argc, &argv);
 
 initializeGtkSettings();


Modified: trunk/Tools/WebKitTestRunner/wpe/main.cpp (290292 => 290293)

--- trunk/Tools/WebKitTestRunner/wpe/main.cpp	2022-02-22 09:05:51 UTC (rev 290292)
+++ trunk/Tools/WebKitTestRunner/wpe/main.cpp	2022-02-22 09:24:18 UTC (rev 290293)
@@ -31,6 +31,9 @@
 int main(int argc, char** argv)
 {
 g_setenv("WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR", "1", FALSE);
+#if USE(ATSPI)
+g_setenv("WEBKIT_A11Y_BUS_ADDRESS", "", FALSE);
+#endif
 
 WTR::TestController controller(argc, const_cast(argv));
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [290291] trunk/Source/WebKit

2022-02-22 Thread carlosgc

Title: [290291] trunk/Source/WebKit








Revision 290291
Author carlo...@webkit.org
Date 2022-02-22 00:47:33 -0800 (Tue, 22 Feb 2022)


Log Message
[GTK][WPE] Suspend web process after some time in the process cache
https://bugs.webkit.org/show_bug.cgi?id=236971

Reviewed by Michael Catanzaro.

Implement platformSuspendProcess() and platformResumeProcess() for GTK and WPE ports.

* UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::CachedProcess::CachedProcess):
(WebKit::WebProcessCache::CachedProcess::~CachedProcess):
(WebKit::WebProcessCache::CachedProcess::takeProcess):
* UIProcess/WebProcessCache.h:
* UIProcess/WebProcessProxy.h:
* UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformSuspendProcess):
(WebKit::WebProcessProxy::platformResumeProcess):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessCache.cpp
trunk/Source/WebKit/UIProcess/WebProcessCache.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (290290 => 290291)

--- trunk/Source/WebKit/ChangeLog	2022-02-22 06:53:58 UTC (rev 290290)
+++ trunk/Source/WebKit/ChangeLog	2022-02-22 08:47:33 UTC (rev 290291)
@@ -1,3 +1,23 @@
+2022-02-22  Carlos Garcia Campos  
+
+[GTK][WPE] Suspend web process after some time in the process cache
+https://bugs.webkit.org/show_bug.cgi?id=236971
+
+Reviewed by Michael Catanzaro.
+
+Implement platformSuspendProcess() and platformResumeProcess() for GTK and WPE ports.
+
+* UIProcess/WebProcessCache.cpp:
+(WebKit::WebProcessCache::addProcess):
+(WebKit::WebProcessCache::CachedProcess::CachedProcess):
+(WebKit::WebProcessCache::CachedProcess::~CachedProcess):
+(WebKit::WebProcessCache::CachedProcess::takeProcess):
+* UIProcess/WebProcessCache.h:
+* UIProcess/WebProcessProxy.h:
+* UIProcess/glib/WebProcessProxyGLib.cpp:
+(WebKit::WebProcessProxy::platformSuspendProcess):
+(WebKit::WebProcessProxy::platformResumeProcess):
+
 2022-02-21  Alex Christensen  
 
 Allow adattributiond to start on iOS devices


Modified: trunk/Source/WebKit/UIProcess/WebProcessCache.cpp (290290 => 290291)

--- trunk/Source/WebKit/UIProcess/WebProcessCache.cpp	2022-02-22 06:53:58 UTC (rev 290290)
+++ trunk/Source/WebKit/UIProcess/WebProcessCache.cpp	2022-02-22 08:47:33 UTC (rev 290291)
@@ -137,7 +137,7 @@
 m_processesPerRegistrableDomain.remove(it);
 }
 
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 cachedProcess->startSuspensionTimer();
 #endif
 
@@ -271,7 +271,7 @@
 WebProcessCache::CachedProcess::CachedProcess(Ref&& process)
 : m_process(WTFMove(process))
 , m_evictionTimer(RunLoop::main(), this, &CachedProcess::evictionTimerFired)
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 , m_suspensionTimer(RunLoop::main(), this, &CachedProcess::suspensionTimerFired)
 #endif
 {
@@ -290,7 +290,7 @@
 ASSERT(!m_process->provisionalPageCount());
 ASSERT(!m_process->suspendedPageCount());
 
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 if (isSuspended())
 m_process->platformResumeProcess();
 #endif
@@ -302,7 +302,7 @@
 {
 ASSERT(m_process);
 m_evictionTimer.stop();
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 if (isSuspended())
 m_process->platformResumeProcess();
 else
@@ -318,7 +318,7 @@
 m_process->processPool().webProcessCache().removeProcess(*m_process, ShouldShutDownProcess::Yes);
 }
 
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 void WebProcessCache::CachedProcess::startSuspensionTimer()
 {
 m_suspensionTimer.startOneShot(cachedProcessSuspensionDelay);


Modified: trunk/Source/WebKit/UIProcess/WebProcessCache.h (290290 => 290291)

--- trunk/Source/WebKit/UIProcess/WebProcessCache.h	2022-02-22 06:53:58 UTC (rev 290290)
+++ trunk/Source/WebKit/UIProcess/WebProcessCache.h	2022-02-22 08:47:33 UTC (rev 290291)
@@ -74,19 +74,19 @@
 WebProcessProxy& process() { ASSERT(m_process); return *m_process; }
 void startSuspensionTimer();
 
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 bool isSuspended() const { return !m_suspensionTimer.isActive(); }
 #endif
 
 private:
 void evictionTimerFired();
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 void suspensionTimerFired();
 #endif
 
 RefPtr m_process;
 RunLoop::Timer m_evictionTimer;
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WPE)
 RunLoop::Timer m_suspensionTimer;
 #endif
 };


Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.h (290290 => 290291)

--- trunk/Source/WebKit/UIProcess/WebProcessProxy.h	2022-02-22 06:53:58 UTC (r

[webkit-changes] [289816] trunk/Source/WebKit

2022-02-15 Thread carlosgc

Title: [289816] trunk/Source/WebKit








Revision 289816
Author carlo...@webkit.org
Date 2022-02-15 08:03:16 -0800 (Tue, 15 Feb 2022)


Log Message
[GTK][WPE] Move WebPage::platformInitialize and WebPage::platformDetach() to WebPageGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=236646

Reviewed by Adrian Perez de Castro.

It's duplicated code related to accessibility.

* WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformDetach):
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize): Deleted.
(WebKit::WebPage::platformDetach): Deleted.
* WebProcess/WebPage/wpe/WebPageWPE.cpp:
(WebKit::WebPage::platformInitialize): Deleted.
(WebKit::WebPage::platformDetach): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp
trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
trunk/Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (289815 => 289816)

--- trunk/Source/WebKit/ChangeLog	2022-02-15 15:45:24 UTC (rev 289815)
+++ trunk/Source/WebKit/ChangeLog	2022-02-15 16:03:16 UTC (rev 289816)
@@ -1,5 +1,24 @@
 2022-02-15  Carlos Garcia Campos  
 
+[GTK][WPE] Move WebPage::platformInitialize and WebPage::platformDetach() to WebPageGLib.cpp
+https://bugs.webkit.org/show_bug.cgi?id=236646
+
+Reviewed by Adrian Perez de Castro.
+
+It's duplicated code related to accessibility.
+
+* WebProcess/WebPage/glib/WebPageGLib.cpp:
+(WebKit::WebPage::platformInitialize):
+(WebKit::WebPage::platformDetach):
+* WebProcess/WebPage/gtk/WebPageGtk.cpp:
+(WebKit::WebPage::platformInitialize): Deleted.
+(WebKit::WebPage::platformDetach): Deleted.
+* WebProcess/WebPage/wpe/WebPageWPE.cpp:
+(WebKit::WebPage::platformInitialize): Deleted.
+(WebKit::WebPage::platformDetach): Deleted.
+
+2022-02-15  Carlos Garcia Campos  
+
 [GTK] D-Bus crash atk-bridge
 https://bugs.webkit.org/show_bug.cgi?id=236208
 


Modified: trunk/Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp (289815 => 289816)

--- trunk/Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp	2022-02-15 15:45:24 UTC (rev 289815)
+++ trunk/Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp	2022-02-15 16:03:16 UTC (rev 289816)
@@ -32,6 +32,7 @@
 #include "WebKitExtensionManager.h"
 #include "WebKitUserMessage.h"
 #include "WebKitWebExtension.h"
+#include "WebKitWebPageAccessibilityObject.h"
 #include "WebKitWebPagePrivate.h"
 #include "WebPageProxyMessages.h"
 #include 
@@ -48,6 +49,60 @@
 namespace WebKit {
 using namespace WebCore;
 
+void WebPage::platformInitialize(const WebPageCreationParameters&)
+{
+#if ENABLE(ACCESSIBILITY)
+// Create the accessible object (the plug) that will serve as the
+// entry point to the Web process, and send a message to the UI
+// process to connect the two worlds through the accessibility
+// object there specifically placed for that purpose (the socket).
+#if USE(ATK)
+auto isValidPlugID = [](const char* plugID) -> bool {
+if (!plugID || plugID[0] != ':')
+return false;
+
+auto* p = g_strrstr(plugID, ":");
+if (!p)
+return false;
+
+if (!g_variant_is_object_path(p + 1))
+return false;
+
+GUniquePtr name(g_strndup(plugID, p - plugID));
+if (!g_dbus_is_unique_name(name.get()))
+return false;
+
+return true;
+};
+
+m_accessibilityObject = adoptGRef(webkitWebPageAccessibilityObjectNew(this));
+GUniquePtr plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject.get(;
+if (isValidPlugID(plugID.get()))
+send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get(;
+#elif USE(ATSPI)
+#if PLATFORM(GTK) && USE(GTK4)
+// FIXME: we need a way to connect DOM and app a11y tree in GTK4.
+#else
+if (auto* page = corePage()) {
+m_accessibilityRootObject = AccessibilityRootAtspi::create(*page);
+m_accessibilityRootObject->registerObject([&](const String& plugID) {
+if (!plugID.isEmpty())
+send(Messages::WebPageProxy::BindAccessibilityTree(plugID));
+});
+}
+#endif
+#endif
+#endif
+}
+
+void WebPage::platformDetach()
+{
+#if USE(ATSPI)
+if (m_accessibilityRootObject)
+m_accessibilityRootObject->unregisterObject();
+#endif
+}
+
 void WebPage::sendMessageToWebExtensionWithReply(UserMessage&& message, CompletionHandler&& completionHandler)
 {
 auto* extension = WebKitExtensionManager::singleton().extension();


Modified: trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp (289815 => 289816)

--- trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 15:45:24 UTC (rev 289815)
+++ trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 16:03:16 UTC (rev 289816)
@@ -30,7 +30,6 @@
 
 #i

[webkit-changes] [289808] releases/WebKitGTK/webkit-2.34/Source

2022-02-15 Thread carlosgc

Title: [289808] releases/WebKitGTK/webkit-2.34/Source








Revision 289808
Author carlo...@webkit.org
Date 2022-02-15 06:30:27 -0800 (Tue, 15 Feb 2022)


Log Message
Merge r289804 - [GTK] D-Bus crash atk-bridge
https://bugs.webkit.org/show_bug.cgi?id=236208

Reviewed by Adrian Perez de Castro.

Source/WebCore:

When a root is unregistered, check first if the registration is still pending to just complete and remove it.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::unregisterRoot):

Source/WebKit:

It seems that for some reason we might end up with an empty string as plug ID which ATK doesn't handle right. We
should not send the BindAccessibilityTree message if the plug ID is not valid. In the case of ATSPI we can just
check it's not empty, since we know we always build a valid ID when we have a connection. In the case of ATK we
should check it's a valid unique name and object path.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (289807 => 289808)

--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2022-02-15 14:23:17 UTC (rev 289807)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog	2022-02-15 14:30:27 UTC (rev 289808)
@@ -1,3 +1,15 @@
+2022-02-15  Carlos Garcia Campos  
+
+[GTK] D-Bus crash atk-bridge
+https://bugs.webkit.org/show_bug.cgi?id=236208
+
+Reviewed by Adrian Perez de Castro.
+
+When a root is unregistered, check first if the registration is still pending to just complete and remove it.
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::unregisterRoot):
+
 2022-02-15  Adrian Perez de Castro  
 
 [GTK][WPE] Inclusion of OpenGLShims.h should not depend on USE(GLX)


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289807 => 289808)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-15 14:23:17 UTC (rev 289807)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-15 14:30:27 UTC (rev 289808)
@@ -1,3 +1,18 @@
+2022-02-15  Carlos Garcia Campos  
+
+[GTK] D-Bus crash atk-bridge
+https://bugs.webkit.org/show_bug.cgi?id=236208
+
+Reviewed by Adrian Perez de Castro.
+
+It seems that for some reason we might end up with an empty string as plug ID which ATK doesn't handle right. We
+should not send the BindAccessibilityTree message if the plug ID is not valid. In the case of ATSPI we can just
+check it's not empty, since we know we always build a valid ID when we have a connection. In the case of ATK we
+should check it's a valid unique name and object path.
+
+* WebProcess/WebPage/gtk/WebPageGtk.cpp:
+(WebKit::WebPage::platformInitialize):
+
 2022-02-15  Adrian Perez de Castro  
 
 [GTK][WPE] Inclusion of OpenGLShims.h should not depend on USE(GLX)


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp (289807 => 289808)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 14:23:17 UTC (rev 289807)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 14:30:27 UTC (rev 289808)
@@ -61,9 +61,28 @@
 // entry point to the Web process, and send a message to the UI
 // process to connect the two worlds through the accessibility
 // object there specifically placed for that purpose (the socket).
+auto isValidPlugID = [](const char* plugID) -> bool {
+if (!plugID || plugID[0] != ':')
+return false;
+
+auto* p = g_strrstr(plugID, ":");
+if (!p)
+return false;
+
+if (!g_variant_is_object_path(p + 1))
+return false;
+
+GUniquePtr name(g_strndup(plugID, p - plugID));
+if (!g_dbus_is_unique_name(name.get()))
+return false;
+
+return true;
+};
+
 m_accessibilityObject = adoptGRef(webkitWebPageAccessibilityObjectNew(this));
 GUniquePtr plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject.get(;
-send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get(;
+if (isValidPlugID(plugID.get()))
+send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get(;
 #endif
 }
 


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp (289807 => 289808)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp	2022-02-15 14:23:17 UTC (rev 289807)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/WebProcess/We

[webkit-changes] [289804] trunk/Source

2022-02-15 Thread carlosgc

Title: [289804] trunk/Source








Revision 289804
Author carlo...@webkit.org
Date 2022-02-15 06:07:45 -0800 (Tue, 15 Feb 2022)


Log Message
[GTK] D-Bus crash atk-bridge
https://bugs.webkit.org/show_bug.cgi?id=236208

Reviewed by Adrian Perez de Castro.

Source/WebCore:

When a root is unregistered, check first if the registration is still pending to just complete and remove it.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::unregisterRoot):

Source/WebKit:

It seems that for some reason we might end up with an empty string as plug ID which ATK doesn't handle right. We
should not send the BindAccessibilityTree message if the plug ID is not valid. In the case of ATSPI we can just
check it's not empty, since we know we always build a valid ID when we have a connection. In the case of ATK we
should check it's a valid unique name and object path.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformInitialize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289803 => 289804)

--- trunk/Source/WebCore/ChangeLog	2022-02-15 14:06:59 UTC (rev 289803)
+++ trunk/Source/WebCore/ChangeLog	2022-02-15 14:07:45 UTC (rev 289804)
@@ -1,3 +1,15 @@
+2022-02-15  Carlos Garcia Campos  
+
+[GTK] D-Bus crash atk-bridge
+https://bugs.webkit.org/show_bug.cgi?id=236208
+
+Reviewed by Adrian Perez de Castro.
+
+When a root is unregistered, check first if the registration is still pending to just complete and remove it.
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::unregisterRoot):
+
 2022-02-15  Enrique Ocaña González  
 
 [GStreamer][MSE] Let MSE set natural video size when using holepunch


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (289803 => 289804)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-15 14:06:59 UTC (rev 289803)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-15 14:07:45 UTC (rev 289804)
@@ -303,6 +303,15 @@
 
 void AccessibilityAtspi::unregisterRoot(AccessibilityRootAtspi& rootObject)
 {
+for (unsigned i = 0; i < m_pendingRootRegistrations.size(); ++i) {
+auto& pendingRootRegistration = m_pendingRootRegistrations[i];
+if (pendingRootRegistration.root.ptr() == &rootObject) {
+pendingRootRegistration.completionHandler({ });
+m_pendingRootRegistrations.remove(i);
+return;
+}
+}
+
 if (!m_connection)
 return;
 


Modified: trunk/Source/WebKit/ChangeLog (289803 => 289804)

--- trunk/Source/WebKit/ChangeLog	2022-02-15 14:06:59 UTC (rev 289803)
+++ trunk/Source/WebKit/ChangeLog	2022-02-15 14:07:45 UTC (rev 289804)
@@ -1,3 +1,18 @@
+2022-02-15  Carlos Garcia Campos  
+
+[GTK] D-Bus crash atk-bridge
+https://bugs.webkit.org/show_bug.cgi?id=236208
+
+Reviewed by Adrian Perez de Castro.
+
+It seems that for some reason we might end up with an empty string as plug ID which ATK doesn't handle right. We
+should not send the BindAccessibilityTree message if the plug ID is not valid. In the case of ATSPI we can just
+check it's not empty, since we know we always build a valid ID when we have a connection. In the case of ATK we
+should check it's a valid unique name and object path.
+
+* WebProcess/WebPage/gtk/WebPageGtk.cpp:
+(WebKit::WebPage::platformInitialize):
+
 2022-02-15  Kimmo Kinnunen  
 
 Memory for messages wrapped for testing is freed before use


Modified: trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp (289803 => 289804)

--- trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 14:06:59 UTC (rev 289803)
+++ trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp	2022-02-15 14:07:45 UTC (rev 289804)
@@ -64,9 +64,28 @@
 // process to connect the two worlds through the accessibility
 // object there specifically placed for that purpose (the socket).
 #if USE(ATK)
+auto isValidPlugID = [](const char* plugID) -> bool {
+if (!plugID || plugID[0] != ':')
+return false;
+
+auto* p = g_strrstr(plugID, ":");
+if (!p)
+return false;
+
+if (!g_variant_is_object_path(p + 1))
+return false;
+
+GUniquePtr name(g_strndup(plugID, p - plugID));
+if (!g_dbus_is_unique_name(name.get()))
+return false;
+
+return true;
+};
+
 m_accessibilityObject = adoptGRef(webkitWebPageAccessibilityObjectNew(this));
 GUniquePtr plugID(atk_plug_get_id(ATK_PLUG(m_accessibilityObject.get(;
-send(Messages::WebPageProxy::BindAccessibilityTree(String(plugID.get(;
+if (isValidPlugID(plugID.get()))
+send

[webkit-changes] [289792] trunk

2022-02-15 Thread carlosgc

Title: [289792] trunk








Revision 289792
Author carlo...@webkit.org
Date 2022-02-15 00:34:24 -0800 (Tue, 15 Feb 2022)


Log Message
REGRESSION(r195447): [GTK] document.activeElement not set on mouse click
https://bugs.webkit.org/show_bug.cgi?id=236217

Reviewed by Michael Catanzaro.

Source/WebCore:

Bring back the behavior before r195447 and focus the links on click which is consistent with other browser in
Linux and ensures active element is the expected one on a click event listener.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable const):

LayoutTests:

* fast/events/click-focus-anchor-expected.txt:
* fast/events/click-focus-anchor.html:
* platform/glib/TestExpectations: Mark imported/blink/fast/events/click-focus-keydown-no-ring.html as failure.
* platform/glib/fast/events/click-focus-anchor-expected.txt: Copied from LayoutTests/fast/events/click-focus-anchor-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/click-focus-anchor-expected.txt
trunk/LayoutTests/fast/events/click-focus-anchor.html
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.cpp


Added Paths

trunk/LayoutTests/platform/glib/fast/events/click-focus-anchor-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (289791 => 289792)

--- trunk/LayoutTests/ChangeLog	2022-02-15 08:26:18 UTC (rev 289791)
+++ trunk/LayoutTests/ChangeLog	2022-02-15 08:34:24 UTC (rev 289792)
@@ -1,3 +1,15 @@
+2022-02-15  Carlos Garcia Campos  
+
+REGRESSION(r195447): [GTK] document.activeElement not set on mouse click
+https://bugs.webkit.org/show_bug.cgi?id=236217
+
+Reviewed by Michael Catanzaro.
+
+* fast/events/click-focus-anchor-expected.txt:
+* fast/events/click-focus-anchor.html:
+* platform/glib/TestExpectations: Mark imported/blink/fast/events/click-focus-keydown-no-ring.html as failure.
+* platform/glib/fast/events/click-focus-anchor-expected.txt: Copied from LayoutTests/fast/events/click-focus-anchor-expected.txt.
+
 2022-02-14  Antti Koivisto  
 
 [CSS Container Queries] Support range operators in size queries


Modified: trunk/LayoutTests/fast/events/click-focus-anchor-expected.txt (289791 => 289792)

--- trunk/LayoutTests/fast/events/click-focus-anchor-expected.txt	2022-02-15 08:26:18 UTC (rev 289791)
+++ trunk/LayoutTests/fast/events/click-focus-anchor-expected.txt	2022-02-15 08:34:24 UTC (rev 289792)
@@ -1,6 +1,6 @@
 This test ensures that we can click to focus an a element. Click on the element below.
 
-The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable.
+The expected result is platform specific. GTK and WPE allow all links to be mouse focusable.
 
 Result
 


Modified: trunk/LayoutTests/fast/events/click-focus-anchor.html (289791 => 289792)

--- trunk/LayoutTests/fast/events/click-focus-anchor.html	2022-02-15 08:26:18 UTC (rev 289791)
+++ trunk/LayoutTests/fast/events/click-focus-anchor.html	2022-02-15 08:34:24 UTC (rev 289792)
@@ -7,13 +7,13 @@
 This test ensures that we can click to focus an a element.
 Click on the element below.
 
-The expected result is platform specific. GTK, QT and EFL allows all links to be
+The expected result is platform specific. GTK and WPE allow all links to be
 mouse focusable.
 
 
 Anchor with tab index
 Anchor without tab index
-Link without tab index
+Link without tab index
 Link with tab index
 Link with contentEditable
 Link inside contentEditable


Modified: trunk/LayoutTests/platform/glib/TestExpectations (289791 => 289792)

--- trunk/LayoutTests/platform/glib/TestExpectations	2022-02-15 08:26:18 UTC (rev 289791)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2022-02-15 08:34:24 UTC (rev 289792)
@@ -723,6 +723,9 @@
 webkit.org/b/218931 fast/events/wheel/wheel-event-in-passive-region-non-cancelable.html [ Timeout ]
 webkit.org/b/218931 fast/events/wheel/wheel-events-become-non-cancelable.html [ Timeout ]
 
+# We draw the focus ring of focused links on keydown event.
+imported/blink/fast/events/click-focus-keydown-no-ring.html [ ImageOnlyFailure ]
+
 #
 # End of Events-related bugs
 #


Copied: trunk/LayoutTests/platform/glib/fast/events/click-focus-anchor-expected.txt (from rev 289791, trunk/LayoutTests/fast/events/click-focus-anchor-expected.txt) (0 => 289792)

--- trunk/LayoutTests/platform/glib/fast/events/click-focus-anchor-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/glib/fast/events/click-focus-anchor-expected.txt	2022-02-15 08:34:24 UTC (rev 289792)
@@ -0,0 +1,11 @@
+This test ensures that we can click to focus an a element. Click on the element below.
+
+The expected result is platform specific. GTK and WPE allow all links to be mous

[webkit-changes] [289728] trunk/Source/WebCore

2022-02-14 Thread carlosgc

Title: [289728] trunk/Source/WebCore








Revision 289728
Author carlo...@webkit.org
Date 2022-02-14 03:20:59 -0800 (Mon, 14 Feb 2022)


Log Message
[ATSPI] Reduce the size of dbus objects Vectors
https://bugs.webkit.org/show_bug.cgi?id=236581

Reviewed by Adrian Perez de Castro.

Use 3 for root, 1 for hyperlink and 7 for object.

* accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::registerObject):
* accessibility/atspi/AccessibilityAtspi.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289727 => 289728)

--- trunk/Source/WebCore/ChangeLog	2022-02-14 07:30:57 UTC (rev 289727)
+++ trunk/Source/WebCore/ChangeLog	2022-02-14 11:20:59 UTC (rev 289728)
@@ -1,3 +1,16 @@
+2022-02-14  Carlos Garcia Campos  
+
+[ATSPI] Reduce the size of dbus objects Vectors
+https://bugs.webkit.org/show_bug.cgi?id=236581
+
+Reviewed by Adrian Perez de Castro.
+
+Use 3 for root, 1 for hyperlink and 7 for object.
+
+* accessibility/atspi/AccessibilityAtspi.cpp:
+(WebCore::AccessibilityAtspi::registerObject):
+* accessibility/atspi/AccessibilityAtspi.h:
+
 2022-02-13  Lauro Moura  
 
 Unreviewed, non-unified build fixes


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp (289727 => 289728)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-14 07:30:57 UTC (rev 289727)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp	2022-02-14 11:20:59 UTC (rev 289728)
@@ -324,7 +324,7 @@
 
 ensureCache();
 String path = makeString("/org/a11y/atspi/accessible/", createVersion4UUIDString().replace('-', '_'));
-Vector registeredObjects;
+Vector registeredObjects;
 registeredObjects.reserveInitialCapacity(interfaces.size());
 for (const auto& interface : interfaces) {
 auto id = g_dbus_connection_register_object(m_connection.get(), path.utf8().data(), interface.first, interface.second, &atspiObject, nullptr, nullptr);


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h (289727 => 289728)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h	2022-02-14 07:30:57 UTC (rev 289727)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityAtspi.h	2022-02-14 11:20:59 UTC (rev 289728)
@@ -128,9 +128,9 @@
 GRefPtr m_registry;
 Vector m_pendingRootRegistrations;
 HashMap>> m_eventListeners;
-HashMap> m_rootObjects;
-HashMap> m_atspiObjects;
-HashMap> m_atspiHyperlinks;
+HashMap> m_rootObjects;
+HashMap> m_atspiObjects;
+HashMap> m_atspiHyperlinks;
 HashMap m_clients;
 unsigned m_cacheID { 0 };
 HashMap m_cache;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289619] trunk/Source/WebKit

2022-02-11 Thread carlosgc

Title: [289619] trunk/Source/WebKit








Revision 289619
Author carlo...@webkit.org
Date 2022-02-11 05:30:47 -0800 (Fri, 11 Feb 2022)


Log Message
[SOUP] Fix memory leak in WebKitDirectoryInputStream
https://bugs.webkit.org/show_bug.cgi?id=236498

Reviewed by Adrian Perez de Castro.

* NetworkProcess/soup/WebKitDirectoryInputStream.cpp:
(webkitDirectoryInputStreamRead): Use adoptGRef() for g_bytes_new_from_bytes().

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (289618 => 289619)

--- trunk/Source/WebKit/ChangeLog	2022-02-11 13:02:18 UTC (rev 289618)
+++ trunk/Source/WebKit/ChangeLog	2022-02-11 13:30:47 UTC (rev 289619)
@@ -1,3 +1,13 @@
+2022-02-11  Carlos Garcia Campos  
+
+[SOUP] Fix memory leak in WebKitDirectoryInputStream
+https://bugs.webkit.org/show_bug.cgi?id=236498
+
+Reviewed by Adrian Perez de Castro.
+
+* NetworkProcess/soup/WebKitDirectoryInputStream.cpp:
+(webkitDirectoryInputStreamRead): Use adoptGRef() for g_bytes_new_from_bytes().
+
 2022-02-11  Youenn Fablet  
 
 Add support to query camera and microphone permissions


Modified: trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp (289618 => 289619)

--- trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp	2022-02-11 13:02:18 UTC (rev 289618)
+++ trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp	2022-02-11 13:30:47 UTC (rev 289619)
@@ -155,7 +155,7 @@
 if (bytesRead == bufferSize)
 stream->priv->buffer = nullptr;
 else
-stream->priv->buffer = g_bytes_new_from_bytes(stream->priv->buffer.get(), bytesRead, bufferSize - bytesRead);
+stream->priv->buffer = adoptGRef(g_bytes_new_from_bytes(stream->priv->buffer.get(), bytesRead, bufferSize - bytesRead));
 totalBytesRead += bytesRead;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289613] releases/WebKitGTK/webkit-2.34/Source/WebKit

2022-02-11 Thread carlosgc

Title: [289613] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 289613
Author carlo...@webkit.org
Date 2022-02-11 02:14:32 -0800 (Fri, 11 Feb 2022)


Log Message
Merge r289528 - [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
https://bugs.webkit.org/show_bug.cgi?id=236437

Reviewed by Adrian Perez de Castro.

Source/WebKit:

This patch moves the XDGDBusProxy launcher implementation to its own file and fixes the following issues:

  - r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need
to ensure we only bind the original socket for the a11y socket and not the session bus one.
  - bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
  - The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XX, it helps to
use a different one.
  - The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the
PlatformDisplay to get the address.

* SourcesGTK.txt:
* SourcesWPE.txt:
* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::argumentsToFileDescriptor):
(WebKit::bindDBusSession):
(WebKit::bindA11y):
(WebKit::bubblewrapSpawn):
(WebKit::argsToFd): Deleted.
(WebKit::XDGDBusProxyLauncher::setAddress): Deleted.
(WebKit::XDGDBusProxyLauncher::isRunning const): Deleted.
(WebKit::XDGDBusProxyLauncher::path const): Deleted.
(WebKit::XDGDBusProxyLauncher::proxyPath const): Deleted.
(WebKit::XDGDBusProxyLauncher::setPermissions): Deleted.
(WebKit::XDGDBusProxyLauncher::launch): Deleted.
(WebKit::XDGDBusProxyLauncher::makeProxyPath): Deleted.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Deleted.
(): Deleted.
* UIProcess/Launcher/glib/BubblewrapLauncher.h:
* UIProcess/Launcher/glib/XDGDBusProxy.cpp: Added.
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::makeProxy const):
(WebKit::XDGDBusProxy::launch const):
* UIProcess/Launcher/glib/XDGDBusProxy.h: Added.
(WebKit::XDGDBusProxy::proxyPath const):
(WebKit::XDGDBusProxy::path const):

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/SourcesGTK.txt
releases/WebKitGTK/webkit-2.34/Source/WebKit/SourcesWPE.txt
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.h


Added Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289612 => 289613)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-11 09:49:20 UTC (rev 289612)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-11 10:14:32 UTC (rev 289613)
@@ -1,3 +1,46 @@
+2022-02-10  Carlos Garcia Campos  
+
+[GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
+https://bugs.webkit.org/show_bug.cgi?id=236437
+
+Reviewed by Adrian Perez de Castro.
+
+This patch moves the XDGDBusProxy launcher implementation to its own file and fixes the following issues:
+
+  - r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need
+to ensure we only bind the original socket for the a11y socket and not the session bus one.
+  - bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
+  - The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XX, it helps to
+use a different one.
+  - The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the
+PlatformDisplay to get the address.
+
+* SourcesGTK.txt:
+* SourcesWPE.txt:
+* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+(WebKit::argumentsToFileDescriptor):
+(WebKit::bindDBusSession):
+(WebKit::bindA11y):
+(WebKit::bubblewrapSpawn):
+(WebKit::argsToFd): Deleted.
+(WebKit::XDGDBusProxyLauncher::setAddress): Deleted.
+(WebKit::XDGDBusProxyLauncher::isRunning const): Deleted.
+(WebKit::XDGDBusProxyLauncher::path const): Deleted.
+(WebKit::XDGDBusProxyLauncher::proxyPath const): Deleted.
+(WebKit::XDGDBusProxyLauncher::setPermissions): Deleted.
+(WebKit::XDGDBusProxyLauncher::launch): Deleted.
+(WebKit::XDGDBusProxyLauncher::makeProxyPath): Deleted.
+(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Deleted.
+(): Deleted.
+* UIProcess/Launcher/glib/BubblewrapLauncher.h:
+* UIProcess/Launcher/glib/XDGDBusProxy.cpp: Added.
+(WebKit::XDGDBusProxy::XDGDBusProxy):
+(WebKit::XDGDBusProxy::makeProxy cons

[webkit-changes] [289614] releases/WebKitGTK/webkit-2.34/Source/WebKit

2022-02-11 Thread carlosgc

Title: [289614] releases/WebKitGTK/webkit-2.34/Source/WebKit








Revision 289614
Author carlo...@webkit.org
Date 2022-02-11 02:14:36 -0800 (Fri, 11 Feb 2022)


Log Message
Merge r289608 - [WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
https://bugs.webkit.org/show_bug.cgi?id=201771

Reviewed by Michael Catanzaro.

xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
explicitly close the sync fd.

* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
(WebKit::XDGDBusProxy::launch const): Return the sync fd.
* UIProcess/Launcher/glib/XDGDBusProxy.h:

Modified Paths

releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h




Diff

Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog (289613 => 289614)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-11 10:14:32 UTC (rev 289613)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/ChangeLog	2022-02-11 10:14:36 UTC (rev 289614)
@@ -1,3 +1,20 @@
+2022-02-11  Carlos Garcia Campos  
+
+[WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
+https://bugs.webkit.org/show_bug.cgi?id=201771
+
+Reviewed by Michael Catanzaro.
+
+xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
+xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
+explicitly close the sync fd.
+
+* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
+(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
+(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
+(WebKit::XDGDBusProxy::launch const): Return the sync fd.
+* UIProcess/Launcher/glib/XDGDBusProxy.h:
+
 2022-02-10  Carlos Garcia Campos  
 
 [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp (289613 => 289614)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-02-11 10:14:32 UTC (rev 289613)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-02-11 10:14:36 UTC (rev 289614)
@@ -86,9 +86,15 @@
 m_path = CString(path, pathEnd - path);
 }
 
-launch(allowPortals);
+m_syncFD = launch(allowPortals);
 }
 
+XDGDBusProxy::~XDGDBusProxy()
+{
+if (m_syncFD != -1)
+close(m_syncFD);
+}
+
 CString XDGDBusProxy::makeProxy() const
 {
 GUniquePtr appRunDir(g_build_filename(g_get_user_runtime_dir(), BASE_DIRECTORY, nullptr));
@@ -118,7 +124,7 @@
 return proxySocketTemplate.get();
 }
 
-void XDGDBusProxy::launch(bool allowPortals) const
+int XDGDBusProxy::launch(bool allowPortals) const
 {
 int syncFds[2];
 if (pipe(syncFds) == -1)
@@ -207,6 +213,8 @@
 char out;
 if (read(syncFds[0], &out, 1) != 1)
 g_error("Failed to fully launch dbus-proxy: %s", g_strerror(errno));
+
+return syncFds[0];
 }
 
 } // namespace WebKit


Modified: releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h (289613 => 289614)

--- releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h	2022-02-11 10:14:32 UTC (rev 289613)
+++ releases/WebKitGTK/webkit-2.34/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h	2022-02-11 10:14:36 UTC (rev 289614)
@@ -37,6 +37,7 @@
 public:
 enum class Type { SessionBus, AccessibilityBus };
 XDGDBusProxy(Type, bool = false);
+~XDGDBusProxy();
 
 const CString& proxyPath() const { return m_proxyPath; }
 const CString& path() const { return m_path; }
@@ -43,12 +44,13 @@
 
 private:
 CString makeProxy() const;
-void launch(bool) const;
+int launch(bool) const;
 
 Type m_type;
 CString m_dbusAddress;
 CString m_proxyPath;
 CString m_path;
+int m_syncFD { -1 };
 };
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289608] trunk/Source/WebKit

2022-02-11 Thread carlosgc

Title: [289608] trunk/Source/WebKit








Revision 289608
Author carlo...@webkit.org
Date 2022-02-11 00:32:35 -0800 (Fri, 11 Feb 2022)


Log Message
[WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
https://bugs.webkit.org/show_bug.cgi?id=201771

Reviewed by Michael Catanzaro.

xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
explicitly close the sync fd.

* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
(WebKit::XDGDBusProxy::launch const): Return the sync fd.
* UIProcess/Launcher/glib/XDGDBusProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (289607 => 289608)

--- trunk/Source/WebKit/ChangeLog	2022-02-11 08:25:05 UTC (rev 289607)
+++ trunk/Source/WebKit/ChangeLog	2022-02-11 08:32:35 UTC (rev 289608)
@@ -1,3 +1,20 @@
+2022-02-11  Carlos Garcia Campos  
+
+[WPE][GTK] BubblewrapLauncher leaks D-Bus proxy sockets
+https://bugs.webkit.org/show_bug.cgi?id=201771
+
+Reviewed by Michael Catanzaro.
+
+xdg-dbus-proxy removes the socket when the sync fd is closed by the application. In most of the cases the
+xdg-dbus-proxy process is killed before the sync fd is closed and the socket file is leaked. We should
+explicitly close the sync fd.
+
+* UIProcess/Launcher/glib/XDGDBusProxy.cpp:
+(WebKit::XDGDBusProxy::XDGDBusProxy): Save the sync fd.
+(WebKit::XDGDBusProxy::~XDGDBusProxy): Close the sync fd is needed.
+(WebKit::XDGDBusProxy::launch const): Return the sync fd.
+* UIProcess/Launcher/glib/XDGDBusProxy.h:
+
 2022-02-10  Simon Fraser  
 
 Separate out setVolatile() from setNonVolatile() on IOSurface-backed buffers


Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp (289607 => 289608)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-02-11 08:25:05 UTC (rev 289607)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp	2022-02-11 08:32:35 UTC (rev 289608)
@@ -74,9 +74,15 @@
 m_path = CString(path, pathEnd - path);
 }
 
-launch(allowPortals);
+m_syncFD = launch(allowPortals);
 }
 
+XDGDBusProxy::~XDGDBusProxy()
+{
+if (m_syncFD != -1)
+close(m_syncFD);
+}
+
 CString XDGDBusProxy::makeProxy() const
 {
 GUniquePtr appRunDir(g_build_filename(g_get_user_runtime_dir(), BASE_DIRECTORY, nullptr));
@@ -106,7 +112,7 @@
 return proxySocketTemplate.get();
 }
 
-void XDGDBusProxy::launch(bool allowPortals) const
+int XDGDBusProxy::launch(bool allowPortals) const
 {
 int syncFds[2];
 if (pipe(syncFds) == -1)
@@ -203,6 +209,8 @@
 char out;
 if (read(syncFds[0], &out, 1) != 1)
 g_error("Failed to fully launch dbus-proxy: %s", g_strerror(errno));
+
+return syncFds[0];
 }
 
 } // namespace WebKit


Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h (289607 => 289608)

--- trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h	2022-02-11 08:25:05 UTC (rev 289607)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h	2022-02-11 08:32:35 UTC (rev 289608)
@@ -37,6 +37,7 @@
 public:
 enum class Type { SessionBus, AccessibilityBus };
 XDGDBusProxy(Type, bool = false);
+~XDGDBusProxy();
 
 const CString& proxyPath() const { return m_proxyPath; }
 const CString& path() const { return m_path; }
@@ -43,12 +44,13 @@
 
 private:
 CString makeProxy() const;
-void launch(bool) const;
+int launch(bool) const;
 
 Type m_type;
 CString m_dbusAddress;
 CString m_proxyPath;
 CString m_path;
+int m_syncFD { -1 };
 };
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289528] trunk/Source

2022-02-10 Thread carlosgc

Title: [289528] trunk/Source








Revision 289528
Author carlo...@webkit.org
Date 2022-02-10 05:54:57 -0800 (Thu, 10 Feb 2022)


Log Message
[GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
https://bugs.webkit.org/show_bug.cgi?id=236437

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Make accessibility bus address API available for ATK too.

* platform/graphics/PlatformDisplay.cpp:
* platform/graphics/PlatformDisplay.h:
* platform/graphics/x11/PlatformDisplayX11.cpp:
* platform/graphics/x11/PlatformDisplayX11.h:

Source/WebKit:

This patch moves the XDGDBusProxy launcher implementation to its own file and fixes the following issues:

  - r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need
to ensure we only bind the original socket for the a11y socket and not the session bus one.
  - bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
  - The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XX, it helps to
use a different one.
  - The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the
PlatformDisplay to get the address.

* SourcesGTK.txt:
* SourcesWPE.txt:
* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::argumentsToFileDescriptor):
(WebKit::bindDBusSession):
(WebKit::bindA11y):
(WebKit::bubblewrapSpawn):
(WebKit::argsToFd): Deleted.
(WebKit::XDGDBusProxyLauncher::setAddress): Deleted.
(WebKit::XDGDBusProxyLauncher::isRunning const): Deleted.
(WebKit::XDGDBusProxyLauncher::path const): Deleted.
(WebKit::XDGDBusProxyLauncher::proxyPath const): Deleted.
(WebKit::XDGDBusProxyLauncher::setPermissions): Deleted.
(WebKit::XDGDBusProxyLauncher::launch): Deleted.
(WebKit::XDGDBusProxyLauncher::makeProxyPath): Deleted.
(WebKit::XDGDBusProxyLauncher::dbusAddressToPath): Deleted.
(): Deleted.
* UIProcess/Launcher/glib/BubblewrapLauncher.h:
* UIProcess/Launcher/glib/XDGDBusProxy.cpp: Added.
(WebKit::XDGDBusProxy::XDGDBusProxy):
(WebKit::XDGDBusProxy::makeProxy const):
(WebKit::XDGDBusProxy::launch const):
* UIProcess/Launcher/glib/XDGDBusProxy.h: Added.
(WebKit::XDGDBusProxy::proxyPath const):
(WebKit::XDGDBusProxy::path const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp
trunk/Source/WebCore/platform/graphics/PlatformDisplay.h
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp
trunk/Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesGTK.txt
trunk/Source/WebKit/SourcesWPE.txt
trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.h


Added Paths

trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp
trunk/Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (289527 => 289528)

--- trunk/Source/WebCore/ChangeLog	2022-02-10 13:02:05 UTC (rev 289527)
+++ trunk/Source/WebCore/ChangeLog	2022-02-10 13:54:57 UTC (rev 289528)
@@ -1,3 +1,17 @@
+2022-02-10  Carlos Garcia Campos  
+
+[GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
+https://bugs.webkit.org/show_bug.cgi?id=236437
+
+Reviewed by Adrian Perez de Castro.
+
+Make accessibility bus address API available for ATK too.
+
+* platform/graphics/PlatformDisplay.cpp:
+* platform/graphics/PlatformDisplay.h:
+* platform/graphics/x11/PlatformDisplayX11.cpp:
+* platform/graphics/x11/PlatformDisplayX11.h:
+
 2022-02-10  Rob Buis  
 
 Incorrect abspos layout when toggling contain


Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp (289527 => 289528)

--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-10 13:02:05 UTC (rev 289527)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp	2022-02-10 13:54:57 UTC (rev 289528)
@@ -293,7 +293,7 @@
 }
 #endif
 
-#if USE(ATSPI)
+#if USE(ATSPI) || USE(ATK)
 const String& PlatformDisplay::accessibilityBusAddress() const
 {
 if (m_accessibilityBusAddress)


Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.h (289527 => 289528)

--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.h	2022-02-10 13:02:05 UTC (rev 289527)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.h	2022-02-10 13:54:57 UTC (rev 289528)
@@ -90,7 +90,7 @@
 virtual cmsHPROFILE colorProfile() const;
 #endif
 
-#if USE(ATSPI)
+#if USE(ATSPI) || USE(ATK)
 void setAccessibilityBusAddress(String&& address) { m_accessibilityBusAddress = WTFMove(address); }
 const String& accessibilityBusAddress() const;
 #endif
@@ -117,7 +117,7 @@
 mutable LCMSProfilePtr m_iccProfile;
 #endif
 
-#if USE(ATSPI)
+#if USE(ATSPI) || USE(ATK)
 virtual String plartformAccessibilityBusAddress() const

[webkit-changes] [289467] trunk

2022-02-09 Thread carlosgc

Title: [289467] trunk








Revision 289467
Author carlo...@webkit.org
Date 2022-02-09 05:49:12 -0800 (Wed, 09 Feb 2022)


Log Message
WebDriver: add a _javascript_ atom to get the visible text
https://bugs.webkit.org/show_bug.cgi?id=174617


Reviewed by Adrian Perez de Castro.

Source/WebDriver:

Generate the _javascript_ atoms using the new command and use the new atom to get element text.

* CMakeLists.txt:
* Session.cpp:
(WebDriver::Session::getElementText):

Source/WebKit:

Add a new _javascript_ atom to get the visible text according to the spec. The new atom uses code from other atoms
like ElementDisplayed and it's also used now by FindNodes one. The atoms are now autogenerated using a script to
include the duplicated code from a common source utils.js.

* Scripts/generate-automation-atom.py: Added.
(collect_utils):
(parse_utils):
(append_functions):
(main):
* UIProcess/Automation/atoms/ElementDisplayed.js:
(isShown.nodeIsElement): Deleted.
(isShown.parentElementForElement): Deleted.
(isShown.enclosingNodeOrSelfMatchingPredicate): Deleted.
(isShown.enclosingElementOrSelfMatchingPredicate): Deleted.
(isShown.cascadedStylePropertyForElement): Deleted.
(isShown.elementSubtreeHasNonZeroDimensions): Deleted.
(isShown): Deleted.
(isShown.isElementSubtreeHiddenByOverflow): Deleted.
* UIProcess/Automation/atoms/ElementText.js: Added.
* UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):
* UIProcess/Automation/atoms/utils.js: Added.
(utils.nodeIsElement):
(utils.enclosingNodeOrSelfMatchingPredicate):
(utils.parentElementForElement):
(utils.cascadedStylePropertyForElement):
(elementSubtreeHasNonZeroDimensions):
(isElementSubtreeHiddenByOverflow):
(utils.isShown):
(appendLines.currentLine):
(appendLines):
(utils.getText):

WebDriverTests:

Remove expectations of tests that are now passing.

* TestExpectations.json:

Modified Paths

trunk/Source/WebDriver/CMakeLists.txt
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js
trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js
trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json


Added Paths

trunk/Source/WebKit/Scripts/generate-automation-atom.py
trunk/Source/WebKit/UIProcess/Automation/atoms/ElementText.js
trunk/Source/WebKit/UIProcess/Automation/atoms/utils.js




Diff

Modified: trunk/Source/WebDriver/CMakeLists.txt (289466 => 289467)

--- trunk/Source/WebDriver/CMakeLists.txt	2022-02-09 12:42:22 UTC (rev 289466)
+++ trunk/Source/WebDriver/CMakeLists.txt	2022-02-09 13:49:12 UTC (rev 289467)
@@ -26,15 +26,33 @@
 
 
 set(WebDriver_SCRIPTS
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementAttribute.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementDisplayed.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementEnabled.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/EnterFullscreen.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FindNodes.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FormElementClear.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FormSubmit.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementAttribute.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementDisplayed.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementEnabled.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementText.js
+${WebDriver_DERIVED_SOURCES_DIR}/EnterFullscreen.js
+${WebDriver_DERIVED_SOURCES_DIR}/FindNodes.js
+${WebDriver_DERIVED_SOURCES_DIR}/FormElementClear.js
+${WebDriver_DERIVED_SOURCES_DIR}/FormSubmit.js
 )
 
+macro(GENERATE_ATOMS _inputs)
+foreach (_file IN ITEMS ${_inputs})
+get_filename_component(_name ${_file} NAME)
+add_custom_command(
+OUTPUT ${_file}
+MAIN_DEPENDENCY ${WEBKIT_DIR}/Scripts/generate-automation-atom.py
+DEPENDS
+${WEBKIT_DIR}/UIProcess/Automation/atoms/${_name}
+${WEBKIT_DIR}/UIProcess/Automation/atoms/utils.js
+COMMAND ${PYTHON_EXECUTABLE} ${WEBKIT_DIR}/Scripts/generate-automation-atom.py ${WEBKIT_DIR}/UIProcess/Automation/atoms/${_name} ${_file}
+VERBATIM
+)
+endforeach ()
+endmacro()
+
+GENERATE_ATOMS("${WebDriver_SCRIPTS}")
+
 MAKE_JS_FILE_ARRAYS(
 ${WebDriver_DERIVED_SOURCES_DIR}/WebDriverAtoms.cpp
 ${WebDriver_DERIVED_SOURCES_DIR}/WebDriverAtoms.h


Modified: trunk/Source/WebDriver/ChangeLog (289466 => 289467)

--- trunk/Source/WebDriver/ChangeLog	2022-02-09 12:42:22 UTC (rev 289466)
+++ trunk/Source/WebDriver/ChangeLog	2022-02-09 13:49:12 UTC (rev 289467)
@@ -1,3 +1,17 @@
+2022-02-09  Carlos Garcia Campos  
+
+WebDriver: add a _javascript_ atom to get the visible text
+https://bugs.webkit.org/show_bug.cgi?id=174617
+
+
+Reviewed by Adrian Perez de Castro.
+
+Generate the _javascript_ atoms using the new command and use the new atom to get element text.
+
+* CMakeLists.txt:
+* Session.cpp:
+

[webkit-changes] [289461] releases/WebKitGTK/webkit-2.35.3/

2022-02-09 Thread carlosgc

Title: [289461] releases/WebKitGTK/webkit-2.35.3/








Revision 289461
Author carlo...@webkit.org
Date 2022-02-09 01:14:53 -0800 (Wed, 09 Feb 2022)


Log Message
WebKitGTK 2.35.3

Added Paths

releases/WebKitGTK/webkit-2.35.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289460] trunk

2022-02-09 Thread carlosgc

Title: [289460] trunk








Revision 289460
Author carlo...@webkit.org
Date 2022-02-09 01:13:55 -0800 (Wed, 09 Feb 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.35.3.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/gtk/NEWS
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (289459 => 289460)

--- trunk/ChangeLog	2022-02-09 08:47:26 UTC (rev 289459)
+++ trunk/ChangeLog	2022-02-09 09:13:55 UTC (rev 289460)
@@ -1,3 +1,9 @@
+2022-02-09  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-02-08  Jonathan Bedard  
 
 [git-webkit] Allow repositories to declare their bug trackers


Modified: trunk/Source/WebKit/ChangeLog (289459 => 289460)

--- trunk/Source/WebKit/ChangeLog	2022-02-09 08:47:26 UTC (rev 289459)
+++ trunk/Source/WebKit/ChangeLog	2022-02-09 09:13:55 UTC (rev 289460)
@@ -1,3 +1,9 @@
+2022-02-09  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
+
+* gtk/NEWS: Add release notes for 2.35.3.
+
 2022-02-08  Jigen Zhou  
 
 [Playstation] Fix build break after r289247 if ENABLE_SERVICE_WORKER is off


Modified: trunk/Source/WebKit/gtk/NEWS (289459 => 289460)

--- trunk/Source/WebKit/gtk/NEWS	2022-02-09 08:47:26 UTC (rev 289459)
+++ trunk/Source/WebKit/gtk/NEWS	2022-02-09 09:13:55 UTC (rev 289460)
@@ -1,4 +1,14 @@
 
+WebKitGTK 2.35.3
+
+
+What's new in WebKitGTK 2.35.3?
+
+  - Fix a crash at startup when bubblewrap sandbox is enabled.
+  - Fix a crash when starting a drag an drop on touchscreen.
+  - Fix several crashes and rendering issues.
+
+
 WebKitGTK 2.35.2
 
 


Modified: trunk/Source/cmake/OptionsGTK.cmake (289459 => 289460)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-02-09 08:47:26 UTC (rev 289459)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-02-09 09:13:55 UTC (rev 289460)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 35 2)
+SET_PROJECT_VERSION(2 35 3)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 1 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 1 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 2 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 2 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 1 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 1 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 2 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 2 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289202] trunk

2022-02-07 Thread carlosgc

Title: [289202] trunk








Revision 289202
Author carlo...@webkit.org
Date 2022-02-07 02:25:15 -0800 (Mon, 07 Feb 2022)


Log Message
[WebDriver] Add support for shadow roots
https://bugs.webkit.org/show_bug.cgi?id=230614


Reviewed by Adrian Perez de Castro.

Source/WebDriver:

Add implementation of new shadow root commands.

* CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const): Handle NoSuchShadowRoot and DetachedShadowRoot errors
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::Session::shadowRootIdentifier): Return shadow root identifier.
(WebDriver::Session::createShadowRoot): Create shadow root elment using the shadow root identifier.
(WebDriver::Session::findElements): Add ElementIsShadowRoot parameters to handle DetachedShadowRoot error.
(WebDriver::Session::getElementShadowRoot): Return the element shadow root.
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::findElement): Pass ElementIsShadowRoot::No to Session::findElements().
(WebDriver::WebDriverService::findElements): Ditto.
(WebDriver::WebDriverService::findElementFromElement): Ditto.
(WebDriver::WebDriverService::findElementsFromElement): Ditto.
(WebDriver::WebDriverService::findElementFromShadowRoot):
(WebDriver::WebDriverService::findElementsFromShadowRoot):
(WebDriver::WebDriverService::getElementShadowRoot):
* WebDriverService.h:

Source/WebKit:

Use querySelectorAll() instead of getElementsByTagName() because it is also available for shadow root.

* UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):

WebDriverTests:

Update test expectations.

* TestExpectations.json:

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/CommandResult.cpp
trunk/Source/WebDriver/CommandResult.h
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebDriver/Session.h
trunk/Source/WebDriver/WebDriverService.cpp
trunk/Source/WebDriver/WebDriverService.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js
trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json




Diff

Modified: trunk/Source/WebDriver/ChangeLog (289201 => 289202)

--- trunk/Source/WebDriver/ChangeLog	2022-02-07 09:22:33 UTC (rev 289201)
+++ trunk/Source/WebDriver/ChangeLog	2022-02-07 10:25:15 UTC (rev 289202)
@@ -1,3 +1,33 @@
+2022-02-07  Carlos Garcia Campos  
+
+[WebDriver] Add support for shadow roots
+https://bugs.webkit.org/show_bug.cgi?id=230614
+
+
+Reviewed by Adrian Perez de Castro.
+
+Add implementation of new shadow root commands.
+
+* CommandResult.cpp:
+(WebDriver::CommandResult::httpStatusCode const): Handle NoSuchShadowRoot and DetachedShadowRoot errors
+(WebDriver::CommandResult::errorString const): Ditto.
+* CommandResult.h:
+* Session.cpp:
+(WebDriver::Session::shadowRootIdentifier): Return shadow root identifier.
+(WebDriver::Session::createShadowRoot): Create shadow root elment using the shadow root identifier.
+(WebDriver::Session::findElements): Add ElementIsShadowRoot parameters to handle DetachedShadowRoot error.
+(WebDriver::Session::getElementShadowRoot): Return the element shadow root.
+* Session.h:
+* WebDriverService.cpp:
+(WebDriver::WebDriverService::findElement): Pass ElementIsShadowRoot::No to Session::findElements().
+(WebDriver::WebDriverService::findElements): Ditto.
+(WebDriver::WebDriverService::findElementFromElement): Ditto.
+(WebDriver::WebDriverService::findElementsFromElement): Ditto.
+(WebDriver::WebDriverService::findElementFromShadowRoot):
+(WebDriver::WebDriverService::findElementsFromShadowRoot):
+(WebDriver::WebDriverService::getElementShadowRoot):
+* WebDriverService.h:
+
 2022-02-02  Youenn Fablet  
 
 Clarify that some UUID routines are dedicated to UUID v4


Modified: trunk/Source/WebDriver/CommandResult.cpp (289201 => 289202)

--- trunk/Source/WebDriver/CommandResult.cpp	2022-02-07 09:22:33 UTC (rev 289201)
+++ trunk/Source/WebDriver/CommandResult.cpp	2022-02-07 10:25:15 UTC (rev 289202)
@@ -145,7 +145,9 @@
 case ErrorCode::NoSuchElement:
 case ErrorCode::NoSuchFrame:
 case ErrorCode::NoSuchWindow:
+case ErrorCode::NoSuchShadowRoot:
 case ErrorCode::StaleElementReference:
+case ErrorCode::DetachedShadowRoot:
 case ErrorCode::InvalidSessionID:
 case ErrorCode::UnknownCommand:
 return 404;
@@ -176,6 +178,8 @@
 return "element not selectable"_s;
 case ErrorCode::ElementNotInteractable:
 return "element not interactable"_s;
+case ErrorCode::DetachedShadowRoot:
+return "detached shadow root"_s;
 case ErrorCode::InvalidArgument:
 return "invalid argument"_s;
 case ErrorCode::InvalidElementState:
@@ -194,6 +198,8 @@
 return "no such element"_s;
 case ErrorCode::NoSuchFrame:
 ret

[webkit-changes] [289047] trunk/WebDriverTests

2022-02-03 Thread carlosgc

Title: [289047] trunk/WebDriverTests








Revision 289047
Author carlo...@webkit.org
Date 2022-02-03 05:45:11 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed. Add another missing file after r288871.

* imported/w3c/tools/webdriver/webdriver/bidi/error.py: Added.

Modified Paths

trunk/WebDriverTests/ChangeLog


Added Paths

trunk/WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/error.py




Diff

Modified: trunk/WebDriverTests/ChangeLog (289046 => 289047)

--- trunk/WebDriverTests/ChangeLog	2022-02-03 13:43:29 UTC (rev 289046)
+++ trunk/WebDriverTests/ChangeLog	2022-02-03 13:45:11 UTC (rev 289047)
@@ -1,5 +1,11 @@
 2022-02-03  Carlos Garcia Campos  
 
+Unreviewed. Add another missing file after r288871.
+
+* imported/w3c/tools/webdriver/webdriver/bidi/error.py: Added.
+
+2022-02-03  Carlos Garcia Campos  
+
 Unreviewed. Add missing files after r283798.
 
 * imported/selenium/py/selenium/webdriver/common/bidi/__init__.py: Added.


Added: trunk/WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/error.py (0 => 289047)

--- trunk/WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/error.py	(rev 0)
+++ trunk/WebDriverTests/imported/w3c/tools/webdriver/webdriver/bidi/error.py	2022-02-03 13:45:11 UTC (rev 289047)
@@ -0,0 +1,65 @@
+import collections
+
+from typing import ClassVar, DefaultDict, Optional, Type
+
+
+class BidiException(Exception):
+# The error_code class variable is used to map the JSON Error Code (see
+# https://w3c.github.io/webdriver/#errors) to a BidiException subclass.
+# TODO: Match on error and let it be a class variables only.
+error_code = None  # type: ClassVar[str]
+
+def __init__(self, error: str, message: str, stacktrace: Optional[str]):
+super(BidiException, self)
+
+self.error = error
+self.message = message
+self.stacktrace = stacktrace
+
+def __repr__(self):
+"""Return the object representation in string format."""
+return f"{self.__class__.__name__}({self.error}, {self.message}, {self.stacktrace})"
+
+def __str__(self):
+"""Return the string representation of the object."""
+message = f"{self.error} ({self.message})"
+
+if self.stacktrace:
+message += f"\n\nRemote-end stacktrace:\n\n{self.stacktrace}"
+
+return message
+
+
+class InvalidArgumentException(BidiException):
+error_code = "invalid argument"
+
+
+class UnknownCommandException(BidiException):
+error_code = "unknown command"
+
+
+class UnknownErrorException(BidiException):
+error_code = "unknown error"
+
+
+def from_error_details(error: str, message: str, stacktrace: Optional[str]) -> BidiException:
+"""Create specific WebDriver BiDi exception class from error details.
+
+Defaults to ``UnknownErrorException`` if `error` is unknown.
+"""
+cls = get(error)
+return cls(error, message, stacktrace)
+
+
+def get(error_code: str) -> Type[BidiException]:
+"""Get exception from `error_code`.
+
+It's falling back to ``UnknownErrorException`` if it is not found.
+"""
+return _errors.get(error_code, UnknownErrorException)
+
+
+_errors: DefaultDict[str, Type[BidiException]] = collections.defaultdict()
+for item in list(locals().values()):
+if type(item) == type and issubclass(item, BidiException):
+_errors[item.error_code] = item






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289046] trunk/Source/WebCore

2022-02-03 Thread carlosgc

Title: [289046] trunk/Source/WebCore








Revision 289046
Author carlo...@webkit.org
Date 2022-02-03 05:43:29 -0800 (Thu, 03 Feb 2022)


Log Message
[GTK][a11y] Test /webkit/WebKitAccessibility/accessible/children-changed times out
https://bugs.webkit.org/show_bug.cgi?id=236070

Reviewed by Adrian Perez de Castro.

This happens because when the new node is added the a11y object children are not updated and the wrapper for the
new child is not created.

* accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Call updateChildrenIfNecessary on AXChildrenChanged.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289045 => 289046)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 13:42:40 UTC (rev 289045)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 13:43:29 UTC (rev 289046)
@@ -1,5 +1,18 @@
 2022-02-03  Carlos Garcia Campos  
 
+[GTK][a11y] Test /webkit/WebKitAccessibility/accessible/children-changed times out
+https://bugs.webkit.org/show_bug.cgi?id=236070
+
+Reviewed by Adrian Perez de Castro.
+
+This happens because when the new node is added the a11y object children are not updated and the wrapper for the
+new child is not created.
+
+* accessibility/atspi/AXObjectCacheAtspi.cpp:
+(WebCore::AXObjectCache::postPlatformNotification): Call updateChildrenIfNecessary on AXChildrenChanged.
+
+2022-02-03  Carlos Garcia Campos  
+
 [GTK][WPE][a11y] Handle parameter of org.a11y.atspi.Text.RemoveSelection
 https://bugs.webkit.org/show_bug.cgi?id=236079
 


Modified: trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp (289045 => 289046)

--- trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp	2022-02-03 13:42:40 UTC (rev 289045)
+++ trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp	2022-02-03 13:43:29 UTC (rev 289046)
@@ -143,6 +143,7 @@
 case AXAutocorrectionOccured:
 break;
 case AXChildrenChanged:
+coreObject->updateChildrenIfNecessary();
 break;
 case AXFocusedUIElementChanged:
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289045] trunk/Source/WebCore

2022-02-03 Thread carlosgc

Title: [289045] trunk/Source/WebCore








Revision 289045
Author carlo...@webkit.org
Date 2022-02-03 05:42:40 -0800 (Thu, 03 Feb 2022)


Log Message
[GTK][WPE][a11y] Handle parameter of org.a11y.atspi.Text.RemoveSelection
https://bugs.webkit.org/show_bug.cgi?id=236079

Reviewed by Adrian Perez de Castro.

* accessibility/atspi/AccessibilityObjectTextAtspi.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (289044 => 289045)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 13:23:42 UTC (rev 289044)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 13:42:40 UTC (rev 289045)
@@ -1,3 +1,12 @@
+2022-02-03  Carlos Garcia Campos  
+
+[GTK][WPE][a11y] Handle parameter of org.a11y.atspi.Text.RemoveSelection
+https://bugs.webkit.org/show_bug.cgi?id=236079
+
+Reviewed by Adrian Perez de Castro.
+
+* accessibility/atspi/AccessibilityObjectTextAtspi.cpp:
+
 2022-02-03  Andres Gonzalez  
 
 Crash in AXIsolatedObject::associatedAXObject.


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp (289044 => 289045)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp	2022-02-03 13:23:42 UTC (rev 289044)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp	2022-02-03 13:42:40 UTC (rev 289045)
@@ -187,6 +187,7 @@
 g_dbus_method_invocation_return_value(invocation, g_variant_new("(b)", atspiObject->selectRange(start, end)));
 } else if (!g_strcmp0(methodName, "RemoveSelection")) {
 int selectionNumber;
+g_variant_get(parameters, "(i)", &selectionNumber);
 int caretOffset = -1;
 if (!selectionNumber) {
 int start, end;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289042] trunk/Tools

2022-02-03 Thread carlosgc

Title: [289042] trunk/Tools








Revision 289042
Author carlo...@webkit.org
Date 2022-02-03 05:11:01 -0800 (Thu, 03 Feb 2022)


Log Message
WebDriver: selenium tests are executed more than once
https://bugs.webkit.org/show_bug.cgi?id=236075

Reviewed by Darin Adler.

I think this happens since we updated the pytest version. Pytest is now collecting test files that don't
contain any test like __init__.py files. When that's given to the runner all the tests under the directory are
executed.

* Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(CollectRecorder.pytest_collectreport): Do not include files with no tests.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py




Diff

Modified: trunk/Tools/ChangeLog (289041 => 289042)

--- trunk/Tools/ChangeLog	2022-02-03 13:06:49 UTC (rev 289041)
+++ trunk/Tools/ChangeLog	2022-02-03 13:11:01 UTC (rev 289042)
@@ -1,3 +1,17 @@
+2022-02-03  Carlos Garcia Campos  
+
+WebDriver: selenium tests are executed more than once
+https://bugs.webkit.org/show_bug.cgi?id=236075
+
+Reviewed by Darin Adler.
+
+I think this happens since we updated the pytest version. Pytest is now collecting test files that don't
+contain any test like __init__.py files. When that's given to the runner all the tests under the directory are
+executed.
+
+* Scripts/webkitpy/webdriver_tests/pytest_runner.py:
+(CollectRecorder.pytest_collectreport): Do not include files with no tests.
+
 2022-02-03  Myles C. Maxfield  
 
 Allow using STIX Two in layout tests


Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py (289041 => 289042)

--- trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py	2022-02-03 13:06:49 UTC (rev 289041)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py	2022-02-03 13:11:01 UTC (rev 289042)
@@ -70,7 +70,7 @@
 self.tests = {}
 
 def pytest_collectreport(self, report):
-if report.nodeid:
+if report.nodeid and report.result:
 self.tests.setdefault(report.nodeid, [])
 for subtest in report.result:
 self.tests[report.nodeid].append(get_item_name(subtest, self._ignore_param))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289040] trunk/WebDriverTests

2022-02-03 Thread carlosgc

Title: [289040] trunk/WebDriverTests








Revision 289040
Author carlo...@webkit.org
Date 2022-02-03 03:39:21 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed. Add missing files after r283798.

* imported/selenium/py/selenium/webdriver/common/bidi/__init__.py: Added.
* imported/selenium/py/selenium/webdriver/common/bidi/cdp.py: Added.
* imported/selenium/py/selenium/webdriver/remote/script_key.py: Added.

Modified Paths

trunk/WebDriverTests/ChangeLog


Added Paths

trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/
trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/__init__.py
trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py
trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/remote/script_key.py




Diff

Modified: trunk/WebDriverTests/ChangeLog (289039 => 289040)

--- trunk/WebDriverTests/ChangeLog	2022-02-03 11:30:39 UTC (rev 289039)
+++ trunk/WebDriverTests/ChangeLog	2022-02-03 11:39:21 UTC (rev 289040)
@@ -1,5 +1,13 @@
 2022-02-03  Carlos Garcia Campos  
 
+Unreviewed. Add missing files after r283798.
+
+* imported/selenium/py/selenium/webdriver/common/bidi/__init__.py: Added.
+* imported/selenium/py/selenium/webdriver/common/bidi/cdp.py: Added.
+* imported/selenium/py/selenium/webdriver/remote/script_key.py: Added.
+
+2022-02-03  Carlos Garcia Campos  
+
 Unreviewed. Add missing file after r288871.
 
 * imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py: Added.


Added: trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/__init__.py (0 => 289040)

--- trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/__init__.py	(rev 0)
+++ trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/__init__.py	2022-02-03 11:39:21 UTC (rev 289040)
@@ -0,0 +1,16 @@
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.


Added: trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py (0 => 289040)

--- trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py	(rev 0)
+++ trunk/WebDriverTests/imported/selenium/py/selenium/webdriver/common/bidi/cdp.py	2022-02-03 11:39:21 UTC (rev 289040)
@@ -0,0 +1,483 @@
+# The MIT License(MIT)
+#
+# Copyright(c) 2018 Hyperion Gray
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files(the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and / or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+#
+# This code comes from https://github.com/HyperionGray/trio-chrome-devtools-protocol/tree/master/trio_cdp
+
+from trio_websocket import (
+ConnectionClosed as WsConnectionClosed,
+connect_websocket_url,
+open_websocket_url
+)
+import trio
+from collections import defaultdict
+from contextlib import (contextmanager, asynccontextmanager)
+from dataclasses import dataclass
+import contextvars
+import importlib
+import itertools
+import json
+import logging
+import sys
+import typing
+
+
+logger = logging.getLogger('trio_cdp')
+T = typing.TypeVar('T')
+MAX_WS_MESSAGE_SIZE = 2**24
+
+devtools = None
+version = None
+
+
+def import_devtools(ver):
+global devtools
+global version
+version = ver
+devtools = importlib.import_module("selenium.webdriver

[webkit-changes] [289039] trunk/WebDriverTests

2022-02-03 Thread carlosgc

Title: [289039] trunk/WebDriverTests








Revision 289039
Author carlo...@webkit.org
Date 2022-02-03 03:30:39 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed. Add missing file after r288871.

* imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py: Added.

Modified Paths

trunk/WebDriverTests/ChangeLog


Added Paths

trunk/WebDriverTests/imported/w3c/webdriver/tests/bidi/session_subscribe/
trunk/WebDriverTests/imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py




Diff

Modified: trunk/WebDriverTests/ChangeLog (289038 => 289039)

--- trunk/WebDriverTests/ChangeLog	2022-02-03 10:13:42 UTC (rev 289038)
+++ trunk/WebDriverTests/ChangeLog	2022-02-03 11:30:39 UTC (rev 289039)
@@ -1,3 +1,9 @@
+2022-02-03  Carlos Garcia Campos  
+
+Unreviewed. Add missing file after r288871.
+
+* imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py: Added.
+
 2022-02-01  Carlos Garcia Campos  
 
 Unreviewed. Update W3C WebDriver imported tests.


Added: trunk/WebDriverTests/imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py (0 => 289039)

--- trunk/WebDriverTests/imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py	(rev 0)
+++ trunk/WebDriverTests/imported/w3c/webdriver/tests/bidi/session_subscribe/subscribe.py	2022-02-03 11:30:39 UTC (rev 289039)
@@ -0,0 +1,70 @@
+import asyncio
+
+import pytest
+
+from webdriver.bidi.error import InvalidArgumentException
+
+
+@pytest.mark.asyncio
+async def test_params_empty(bidi_session, send_blocking_command):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command("session.subscribe", {})
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("value", [None, True, "foo", 42, {}])
+async def test_params_events_invalid_type(bidi_session, send_blocking_command, value):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command("session.subscribe", {"events": value})
+
+
+@pytest.mark.asyncio
+async def test_params_events_empty(bidi_session):
+response = await bidi_session.session.subscribe(events=[])
+assert response == {}
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("value", [None, True, 42, [], {}])
+async def test_params_events_value_invalid_type(send_blocking_command, value):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command("session.subscribe", {"events": [value]})
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("value", ["", "foo", "foo.bar"])
+async def test_params_events_value_invalid_event_name(send_blocking_command, value):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command("session.subscribe", {"events": [value]})
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("value", [None, True, "foo", 42, {}])
+async def test_params_contexts_invalid_type(bidi_session, send_blocking_command, value):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command(
+"session.subscribe",
+{
+"events": [],
+"contexts": value,
+}
+)
+
+
+@pytest.mark.asyncio
+async def test_params_contexts_empty(bidi_session):
+response = await bidi_session.session.subscribe(events=[], contexts=[])
+assert response == {}
+
+
+@pytest.mark.asyncio
+@pytest.mark.parametrize("value", [None, True, 42, [], {}])
+async def test_params_contexts_value_invalid_type(send_blocking_command, value):
+with pytest.raises(InvalidArgumentException):
+response = await send_blocking_command(
+"session.subscribe",
+{
+"events": [],
+"contexts": [value],
+}
+)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289036] releases/WebKitGTK/webkit-2.35.2/

2022-02-03 Thread carlosgc

Title: [289036] releases/WebKitGTK/webkit-2.35.2/








Revision 289036
Author carlo...@webkit.org
Date 2022-02-03 01:18:07 -0800 (Thu, 03 Feb 2022)


Log Message
WebKitGTK 2.35.2

Added Paths

releases/WebKitGTK/webkit-2.35.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289035] trunk

2022-02-03 Thread carlosgc

Title: [289035] trunk








Revision 289035
Author carlo...@webkit.org
Date 2022-02-03 01:16:46 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.35.2.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/gtk/NEWS
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (289034 => 289035)

--- trunk/ChangeLog	2022-02-03 08:52:15 UTC (rev 289034)
+++ trunk/ChangeLog	2022-02-03 09:16:46 UTC (rev 289035)
@@ -1,3 +1,9 @@
+2022-02-03  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2022-02-02  Carlos Garcia Campos  
 
 Unreviewed. [GTK] Apply the same cmake changes of r289029 to GTK port


Modified: trunk/Source/WebKit/ChangeLog (289034 => 289035)

--- trunk/Source/WebKit/ChangeLog	2022-02-03 08:52:15 UTC (rev 289034)
+++ trunk/Source/WebKit/ChangeLog	2022-02-03 09:16:46 UTC (rev 289035)
@@ -1,3 +1,9 @@
+2022-02-03  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release
+
+* gtk/NEWS: Add release notes for 2.35.2.
+
 2022-02-02  Alex Christensen  
 
 Remove debug log accidentally added with r289018


Modified: trunk/Source/WebKit/gtk/NEWS (289034 => 289035)

--- trunk/Source/WebKit/gtk/NEWS	2022-02-03 08:52:15 UTC (rev 289034)
+++ trunk/Source/WebKit/gtk/NEWS	2022-02-03 09:16:46 UTC (rev 289035)
@@ -1,4 +1,18 @@
 
+WebKitGTK 2.35.2
+
+
+What's new in WebKitGTK 2.35.2?
+
+  - Add new accessibility implementation using ATSPI DBus interfaces instead of ATK.
+  - Use native GtkWidgets for form validation popups.
+  - Add support for requestVideoFrameCallback.
+  - Add support for accent colors.
+  - Fix pinch zooming from a link to not activate the link.
+  - Fix kinetic scrolling via touch screen.
+  - Fix several crashes and rendering issues.
+
+
 WebKitGTK 2.35.1
 
 


Modified: trunk/Source/cmake/OptionsGTK.cmake (289034 => 289035)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-02-03 08:52:15 UTC (rev 289034)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-02-03 09:16:46 UTC (rev 289035)
@@ -3,7 +3,7 @@
 
 WEBKIT_OPTION_BEGIN()
 
-SET_PROJECT_VERSION(2 35 1)
+SET_PROJECT_VERSION(2 35 2)
 
 
 set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
@@ -227,11 +227,11 @@
 endif ()
 
 if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 0 56)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 0 20)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 1 56)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 1 20)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1")
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 0 1)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 0 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 1 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 1 1)
 elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0")
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0)
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289033] trunk/Source/WebCore

2022-02-03 Thread carlosgc

Title: [289033] trunk/Source/WebCore








Revision 289033
Author carlo...@webkit.org
Date 2022-02-03 00:41:48 -0800 (Thu, 03 Feb 2022)


Log Message
Unreviewed. Fix GTK make distcheck

Move mac specific file from Sources.txt to SourcesCocoa.txt

* Sources.txt:
* SourcesCocoa.txt:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/SourcesCocoa.txt




Diff

Modified: trunk/Source/WebCore/ChangeLog (289032 => 289033)

--- trunk/Source/WebCore/ChangeLog	2022-02-03 08:35:59 UTC (rev 289032)
+++ trunk/Source/WebCore/ChangeLog	2022-02-03 08:41:48 UTC (rev 289033)
@@ -1,3 +1,12 @@
+2022-02-03  Carlos Garcia Campos  
+
+Unreviewed. Fix GTK make distcheck
+
+Move mac specific file from Sources.txt to SourcesCocoa.txt
+
+* Sources.txt:
+* SourcesCocoa.txt:
+
 2022-02-03  Martin Robinson  
 
 Transform interpolation should blend between shared transform function primitives


Modified: trunk/Source/WebCore/Sources.txt (289032 => 289033)

--- trunk/Source/WebCore/Sources.txt	2022-02-03 08:35:59 UTC (rev 289032)
+++ trunk/Source/WebCore/Sources.txt	2022-02-03 08:41:48 UTC (rev 289033)
@@ -1072,7 +1072,6 @@
 dom/WheelEvent.cpp
 dom/WindowEventLoop.cpp
 dom/XMLDocument.cpp
-dom/mac/ImageControlsMac.cpp
 dom/messageports/MessagePortChannel.cpp
 dom/messageports/MessagePortChannelProvider.cpp
 dom/messageports/MessagePortChannelProviderImpl.cpp


Modified: trunk/Source/WebCore/SourcesCocoa.txt (289032 => 289033)

--- trunk/Source/WebCore/SourcesCocoa.txt	2022-02-03 08:35:59 UTC (rev 289032)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2022-02-03 08:41:48 UTC (rev 289033)
@@ -155,6 +155,7 @@
 dom/ios/MouseEventIOS.cpp
 dom/ios/PointerEventIOS.cpp
 dom/ios/TouchEvents.cpp
+dom/mac/ImageControlsMac.cpp
 editing/SelectionGeometryGatherer.cpp
 editing/SmartReplaceCF.cpp
 editing/cocoa/AlternativeTextContextController.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [289030] trunk

2022-02-02 Thread carlosgc

Title: [289030] trunk








Revision 289030
Author carlo...@webkit.org
Date 2022-02-02 23:33:18 -0800 (Wed, 02 Feb 2022)


Log Message
Unreviewed. [GTK] Apply the same cmake changes of r289029 to GTK port

* Source/cmake/OptionsGTK.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (289029 => 289030)

--- trunk/ChangeLog	2022-02-03 07:05:30 UTC (rev 289029)
+++ trunk/ChangeLog	2022-02-03 07:33:18 UTC (rev 289030)
@@ -1,3 +1,9 @@
+2022-02-02  Carlos Garcia Campos  
+
+Unreviewed. [GTK] Apply the same cmake changes of r289029 to GTK port
+
+* Source/cmake/OptionsGTK.cmake:
+
 2022-02-02  Pablo Saavedra  
 
 [WPE] Fix for non-unified builds with ACCESSIBILITY=OFF


Modified: trunk/Source/cmake/OptionsGTK.cmake (289029 => 289030)

--- trunk/Source/cmake/OptionsGTK.cmake	2022-02-03 07:05:30 UTC (rev 289029)
+++ trunk/Source/cmake/OptionsGTK.cmake	2022-02-03 07:33:18 UTC (rev 289030)
@@ -271,8 +271,15 @@
 set(BUILD_REVISION "tarball")
 endif ()
 
-if (NOT USE_ATSPI)
-SET_AND_EXPOSE_TO_BUILD(USE_ATK TRUE)
+if (ENABLE_ACCESSIBILITY)
+if (USE_ATSPI)
+SET_AND_EXPOSE_TO_BUILD(USE_ATK FALSE)
+else ()
+SET_AND_EXPOSE_TO_BUILD(USE_ATK TRUE)
+endif ()
+else ()
+SET_AND_EXPOSE_TO_BUILD(USE_ATK FALSE)
+SET_AND_EXPOSE_TO_BUILD(USE_ATSPI FALSE)
 endif ()
 
 SET_AND_EXPOSE_TO_BUILD(HAVE_GTK_UNIX_PRINTING ${GTK_UNIX_PRINT_FOUND})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [288873] trunk/Source/WebCore

2022-02-01 Thread carlosgc

Title: [288873] trunk/Source/WebCore








Revision 288873
Author carlo...@webkit.org
Date 2022-02-01 05:15:16 -0800 (Tue, 01 Feb 2022)


Log Message
Unreviewed. [GTK][WPE] Fix compile warning

* accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::atspiRole): Add AccessibilityRole::Model to switch.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (288872 => 288873)

--- trunk/Source/WebCore/ChangeLog	2022-02-01 12:29:00 UTC (rev 288872)
+++ trunk/Source/WebCore/ChangeLog	2022-02-01 13:15:16 UTC (rev 288873)
@@ -1,3 +1,10 @@
+2022-02-01  Carlos Garcia Campos  
+
+Unreviewed. [GTK][WPE] Fix compile warning
+
+* accessibility/atspi/AccessibilityObjectAtspi.cpp:
+(WebCore::atspiRole): Add AccessibilityRole::Model to switch.
+
 2022-02-01  Tim Nguyen  
 
 Entirely remove support for -apple-trailing-word


Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp (288872 => 288873)

--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp	2022-02-01 12:29:00 UTC (rev 288872)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp	2022-02-01 13:15:16 UTC (rev 288873)
@@ -363,6 +363,7 @@
 case AccessibilityRole::Ignored:
 case AccessibilityRole::Incrementor:
 case AccessibilityRole::Matte:
+case AccessibilityRole::Model:
 case AccessibilityRole::Presentational:
 case AccessibilityRole::RowGroup:
 case AccessibilityRole::RubyBase:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

1 2 3 4 5 6 7 8 9 10 >

1 - 100 of 3521 matches

Mail list logo