from:"caseq"

[webkit-changes] [133881] trunk/Source/WebCore

2012-11-08 Thread caseq

Title: [133881] trunk/Source/WebCore








Revision 133881
Author ca...@chromium.org
Date 2012-11-08 04:39:21 -0800 (Thu, 08 Nov 2012)


Log Message
Web Inspector: Console: "time" and "timeEnd" should have same number of required arguments
https://bugs.webkit.org/show_bug.cgi?id=101451

Patch by Eugene Klyuchnikov  on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: make console.time "title" parameter mandatory.

* page/Console.idl: Changed parameter specification.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Console.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (133880 => 133881)

--- trunk/Source/WebCore/ChangeLog	2012-11-08 12:14:39 UTC (rev 133880)
+++ trunk/Source/WebCore/ChangeLog	2012-11-08 12:39:21 UTC (rev 133881)
@@ -1,3 +1,14 @@
+2012-11-08  Eugene Klyuchnikov  
+
+Web Inspector: Console: "time" and "timeEnd" should have same number of required arguments
+https://bugs.webkit.org/show_bug.cgi?id=101451
+
+Reviewed by Yury Semikhatsky.
+
+Solution: make console.time "title" parameter mandatory.
+
+* page/Console.idl: Changed parameter specification.
+
 2012-11-08  Vsevolod Vlasov  
 
 Unreviewed fixed inspector frontend compilation


Modified: trunk/Source/WebCore/page/Console.idl (133880 => 133881)

--- trunk/Source/WebCore/page/Console.idl	2012-11-08 12:14:39 UTC (rev 133880)
+++ trunk/Source/WebCore/page/Console.idl	2012-11-08 12:39:21 UTC (rev 133881)
@@ -52,7 +52,7 @@
 [Custom] void profileEnd(in DOMString title);
 #endif
 
-void time(in [TreatNullAs=NullString, TreatUndefinedAs=NullString,Optional=DefaultIsUndefined] DOMString title);
+void time(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
 [CallWith=ScriptArguments|CallStack] void timeEnd(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
 [CallWith=ScriptArguments|CallStack] void timeStamp();
 [CallWith=ScriptArguments|CallStack] void group();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [133915] trunk/Source/WebCore

2012-11-08 Thread caseq

Title: [133915] trunk/Source/WebCore








Revision 133915
Author ca...@chromium.org
Date 2012-11-08 10:24:07 -0800 (Thu, 08 Nov 2012)


Log Message
Web Inspector: show statistics over selected frame range in Timeline's Frame mode
https://bugs.webkit.org/show_bug.cgi?id=101593

Reviewed by Pavel Feldman.

- change status bar records counter wording to "N of M frames|records shown" depending on mode;
- append average frame length and & stddev in frame mode;
- expand the above to a popover that includes frame count, range duration and min/avg/max/stddev on frame length;
- show frame bars & dividers iff selection range includes < 30 frames (drive-by)

* English.lproj/localizedStrings.js:
* inspector/front-end/TimelineFrameController.js:
(WebInspector.FrameStatistics):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.aggregateTimeByCategory):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusBarItems.getAnchor):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._updateFrameStatistics):
(WebInspector.TimelinePanel.prototype._showFrameStatistics):
(WebInspector.TimelinePanel.prototype._updateFrameBars):
(WebInspector.TimelinePanel.prototype._overviewModeChanged.set if):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):
(WebInspector.TimelinePanel.prototype._refresh):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.):
(WebInspector.TimelinePresentationModel.prototype.compareEndTime):
(WebInspector.TimelinePresentationModel.prototype.filteredFrames):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):
* inspector/front-end/timelinePanel.css:
(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.timeline-records-stats):
(.timeline-frames-stats):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/TimelineFrameController.js
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
trunk/Source/WebCore/inspector/front-end/timelinePanel.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (133914 => 133915)

--- trunk/Source/WebCore/ChangeLog	2012-11-08 18:21:23 UTC (rev 133914)
+++ trunk/Source/WebCore/ChangeLog	2012-11-08 18:24:07 UTC (rev 133915)
@@ -1,3 +1,41 @@
+2012-11-08  Andrey Kosyakov  
+
+Web Inspector: show statistics over selected frame range in Timeline's Frame mode
+https://bugs.webkit.org/show_bug.cgi?id=101593
+
+Reviewed by Pavel Feldman.
+
+- change status bar records counter wording to "N of M frames|records shown" depending on mode;
+- append average frame length and & stddev in frame mode;
+- expand the above to a popover that includes frame count, range duration and min/avg/max/stddev on frame length;
+- show frame bars & dividers iff selection range includes < 30 frames (drive-by)
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/TimelineFrameController.js:
+(WebInspector.FrameStatistics):
+* inspector/front-end/TimelineModel.js:
+(WebInspector.TimelineModel.aggregateTimeByCategory):
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelinePanel.prototype.get statusBarItems):
+(WebInspector.TimelinePanel.prototype._createStatusBarItems.getAnchor):
+(WebInspector.TimelinePanel.prototype._createStatusBarItems):
+(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
+(WebInspector.TimelinePanel.prototype._updateFrameStatistics):
+(WebInspector.TimelinePanel.prototype._showFrameStatistics):
+(WebInspector.TimelinePanel.prototype._updateFrameBars):
+(WebInspector.TimelinePanel.prototype._overviewModeChanged.set if):
+(WebInspector.TimelinePanel.prototype._overviewModeChanged):
+(WebInspector.TimelinePanel.prototype._refresh):
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.prototype.):
+(WebInspector.TimelinePresentationModel.prototype.compareEndTime):
+(WebInspector.TimelinePresentationModel.prototype.filteredFrames):
+(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):
+* inspector/front-end/timelinePanel.css:
+(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
+(.timeline-records-stats):
+(.timeline-frames-stats):
+
 2012-11-08  Jakob Petsovits  
 
 [BlackBerry] Rework the API to use document coor

[webkit-changes] [135518] trunk/Source/WebCore

2012-11-22 Thread caseq

Title: [135518] trunk/Source/WebCore








Revision 135518
Author ca...@chromium.org
Date 2012-11-22 06:30:34 -0800 (Thu, 22 Nov 2012)


Log Message
Web Inspector: Timeline: Disclosure arrows rendered underneath frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=101053

Patch by Eugene Klyuchnikov  on 2012-11-22
Reviewed by Yury Semikhatsky.

In Timeline, when in "frames" mode, event disclosure arrows are rendered
below the dividing lines for the frame (div.timeline-frame-divider).
When this happens, the frame divider can capture mouse clicks and make
it difficult to open the disclosure arrow.

* inspector/front-end/timelinePanel.css:
(#timeline-grid-header): Render dividers under timeline bars.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/timelinePanel.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (135517 => 135518)

--- trunk/Source/WebCore/ChangeLog	2012-11-22 14:22:12 UTC (rev 135517)
+++ trunk/Source/WebCore/ChangeLog	2012-11-22 14:30:34 UTC (rev 135518)
@@ -1,3 +1,18 @@
+2012-11-22  Eugene Klyuchnikov  
+
+Web Inspector: Timeline: Disclosure arrows rendered underneath frame boundaries
+https://bugs.webkit.org/show_bug.cgi?id=101053
+
+Reviewed by Yury Semikhatsky.
+
+In Timeline, when in "frames" mode, event disclosure arrows are rendered
+below the dividing lines for the frame (div.timeline-frame-divider).
+When this happens, the frame divider can capture mouse clicks and make
+it difficult to open the disclosure arrow.
+
+* inspector/front-end/timelinePanel.css:
+(#timeline-grid-header): Render dividers under timeline bars.
+
 2012-11-22  Huang Dongsung  
 
 [TexMap] Reduce public methods of TextureMapperTiledBackingStore.


Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (135517 => 135518)

--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css	2012-11-22 14:22:12 UTC (rev 135517)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css	2012-11-22 14:30:34 UTC (rev 135518)
@@ -655,6 +655,7 @@
 top: 90px;
 bottom: 0;
 pointer-events: none;
+z-index: -100;
 }
 
 .timeline-cpu-bars {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [135586] trunk

2012-11-23 Thread caseq

Title: [135586] trunk








Revision 135586
Author ca...@chromium.org
Date 2012-11-23 03:31:07 -0800 (Fri, 23 Nov 2012)


Log Message
Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
https://bugs.webkit.org/show_bug.cgi?id=100916

Patch by Eugene Klyuchnikov  on 2012-11-22
Reviewed by Yury Semikhatsky.

Source/WebCore:

Fixed order of operations - now receiver is assigned only when save
dialog responds.

* inspector/front-end/HeapSnapshotView.js: Fixed order of operations.

LayoutTests:

Extracted "injectMockProfile" method and reused it in new test.

* inspector/profiler/heap-snapshot-loader-expected.txt: Added test case.
* inspector/profiler/heap-snapshot-loader.html:
Refactored and added new test case.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot-loader-expected.txt
trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js




Diff

Modified: trunk/LayoutTests/ChangeLog (135585 => 135586)

--- trunk/LayoutTests/ChangeLog	2012-11-23 11:29:44 UTC (rev 135585)
+++ trunk/LayoutTests/ChangeLog	2012-11-23 11:31:07 UTC (rev 135586)
@@ -1,3 +1,16 @@
+2012-11-22  Eugene Klyuchnikov  
+
+Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
+https://bugs.webkit.org/show_bug.cgi?id=100916
+
+Reviewed by Yury Semikhatsky.
+
+Extracted "injectMockProfile" method and reused it in new test.
+
+* inspector/profiler/heap-snapshot-loader-expected.txt: Added test case.
+* inspector/profiler/heap-snapshot-loader.html:
+Refactored and added new test case.
+
 2012-11-23  Allan Sandfeld Jensen  
 
 [Qt] REGRESSION(r135507): It made 13 tests fail


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-loader-expected.txt (135585 => 135586)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot-loader-expected.txt	2012-11-23 11:29:44 UTC (rev 135585)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-loader-expected.txt	2012-11-23 11:31:07 UTC (rev 135586)
@@ -7,3 +7,5 @@
 
 Running: heapSnapshotLoadFromFileTest
 
+Running: heapSnapshotRejectToSaveToFileTest
+


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html (135585 => 135586)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html	2012-11-23 11:29:44 UTC (rev 135585)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-loader.html	2012-11-23 11:31:07 UTC (rev 135586)
@@ -16,6 +16,38 @@
 var sourceStringified = JSON.stringify(source);
 var partSize = sourceStringified.length >> 3;
 
+function injectMockProfile(overrideGetProfile, callback) {
+var dispatcher = InspectorBackend._domainDispatchers["Profiler"];
+var panel = WebInspector.panels.profiles;
+panel._reset();
+
+dispatcher.addProfileHeader({
+typeId: WebInspector.HeapSnapshotProfileType.TypeId,
+title: "heapSnapshotSaveToFileTest",
+uid: 42,
+maxJSObjectId: 6
+});
+
+var profileHeader = panel._profiles[0];
+
+function getProfileMock(profileTypeName, uid) {
+for (var i = 0, l = sourceStringified.length; i < l; i += partSize)
+dispatcher.addHeapSnapshotChunk(uid, sourceStringified.slice(i, i + partSize));
+dispatcher.finishHeapSnapshot(uid);
+}
+
+function snapshotLoaded()
+{
+if (overrideGetProfile)
+InspectorTest.override(ProfilerAgent, "getProfile", getProfileMock);
+callback(profileHeader);
+}
+InspectorTest.addSniffer(profileHeader, "_snapshotReceived", snapshotLoaded);
+
+InspectorTest.override(ProfilerAgent, "getProfile", getProfileMock);
+panel.showProfile(profileHeader);
+}
+
 InspectorTest.runTestSuite([
 function heapSnapshotLoaderTest(next)
 {
@@ -32,56 +64,31 @@
 
 function heapSnapshotSaveToFileTest(next)
 {
-var profileUID = 42;
-
-var dispatcher = InspectorBackend._domainDispatchers["Profiler"];
-var panel = WebInspector.panels.profiles;
-panel._reset();
-
-dispatcher.addProfileHeader({
-typeId: WebInspector.HeapSnapshotProfileType.TypeId,
-title: "heapSnapshotSaveToFileTest",
-uid: profileUID,
-maxJSObjectId: 6
-});
-
-var profileHeader = panel._profiles[0];
-
-var oldGetProfile = ProfilerAgent.getProfile;
-ProfilerAgent.getProfile = function getProfileMock(profileTypeName, uid) {
-for (var i = 0, l = sourceStringified.length; i < l; i += partSize)
-dispatcher.addHeapSnapshotChunk(uid, sourceStringified.slice(i, i + partSize));
-dispatcher.finishHeapSnapshot(uid);
-

[webkit-changes] [135588] trunk/Source/WebCore

2012-11-23 Thread caseq

Title: [135588] trunk/Source/WebCore








Revision 135588
Author ca...@chromium.org
Date 2012-11-23 04:08:42 -0800 (Fri, 23 Nov 2012)


Log Message
Web Inspector: dispatch events upon certain user actions on inspector's notification services
https://bugs.webkit.org/show_bug.cgi?id=103114

Reviewed by Pavel Feldman.

Add a bunch of WebInspector.UserMetrics.UserAction, so platform-specific code can wire to user actions
without breaking too often.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._setBreakpoint):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype._tabSelected.set WebInspector):
(WebInspector.NetworkItemView.prototype._tabSelected):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkDataGridNode.prototype.select):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
* inspector/front-end/UserMetrics.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._requestZoom.set var):
(WebInspector._requestZoom):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/NetworkItemView.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/UserMetrics.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/inspector.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (135587 => 135588)

--- trunk/Source/WebCore/ChangeLog	2012-11-23 11:52:11 UTC (rev 135587)
+++ trunk/Source/WebCore/ChangeLog	2012-11-23 12:08:42 UTC (rev 135588)
@@ -1,3 +1,38 @@
+2012-11-23  Andrey Kosyakov  
+
+Web Inspector: dispatch events upon certain user actions on inspector's notification services
+https://bugs.webkit.org/show_bug.cgi?id=103114
+
+Reviewed by Pavel Feldman.
+
+Add a bunch of WebInspector.UserMetrics.UserAction, so platform-specific code can wire to user actions
+without breaking too often.
+
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype._setBreakpoint):
+* inspector/front-end/NetworkItemView.js:
+(WebInspector.NetworkItemView.prototype._tabSelected.set WebInspector):
+(WebInspector.NetworkItemView.prototype._tabSelected):
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView.prototype._sortItems):
+(WebInspector.NetworkDataGridNode.prototype.select):
+* inspector/front-end/ProfilesPanel.js:
+(WebInspector.ProfilesPanel.prototype.addProfileHeader):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._showSourceLine):
+(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype.revertToOriginal):
+(WebInspector.UISourceCode.prototype.revertAndClearHistory):
+(WebInspector.UISourceCode.prototype.commitWorkingCopy):
+* inspector/front-end/UserMetrics.js:
+* inspector/front-end/externs.js:
+* inspector/front-end/inspector.js:
+(WebInspector._requestZoom.set var):
+(WebInspector._requestZoom):
+
 2012-11-23  Christophe Dumez  
 
 WebSocket's MessageEvent.origin attribute is an empty string


Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (135587 => 135588)

--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2012-11-23 11:52:11 UTC (rev 135587)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js	2012-11-23 12:08:42 UTC (rev 135588)
@@ -198,6 +198,13 @@
 WebInspector.cssModel.forcePseudoState(node.id, node.getUserProperty(WebInspector.ElementsTreeOutline.PseudoStateDecorator.PropertyName));
 this._metricsPaneEdited();
 this._stylesPaneEdited();
+
+WebInspector.notifications.dispatchEventToListeners(WebInspector.UserMetrics.UserAction, {
+a

[webkit-changes] [135959] trunk/Source/WebCore

2012-11-27 Thread caseq

Title: [135959] trunk/Source/WebCore








Revision 135959
Author ca...@chromium.org
Date 2012-11-27 17:43:20 -0800 (Tue, 27 Nov 2012)


Log Message
Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart
https://bugs.webkit.org/show_bug.cgi?id=102210

Patch by Eugene Klyuchnikov  on 2012-11-27
Reviewed by Pavel Feldman.

The checkbox changes should take effect in the real time.

* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
Do not show checkpox if browser is not capable.
* inspector/front-end/TimelinePanel.js:
Added setting change listener.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (135958 => 135959)

--- trunk/Source/WebCore/ChangeLog	2012-11-28 01:33:31 UTC (rev 135958)
+++ trunk/Source/WebCore/ChangeLog	2012-11-28 01:43:20 UTC (rev 135959)
@@ -1,3 +1,18 @@
+2012-11-27  Eugene Klyuchnikov  
+
+Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart
+https://bugs.webkit.org/show_bug.cgi?id=102210
+
+Reviewed by Pavel Feldman.
+
+The checkbox changes should take effect in the real time.
+
+* inspector/front-end/SettingsScreen.js:
+(WebInspector.GenericSettingsTab):
+Do not show checkpox if browser is not capable.
+* inspector/front-end/TimelinePanel.js:
+Added setting change listener.
+
 2012-11-27  Andreas Kling  
 
 Compile time size assertions for TreeScope, ShadowRoot and ElementAttributeData.


Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (135958 => 135959)

--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-11-28 01:33:31 UTC (rev 135958)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-11-28 01:43:20 UTC (rev 135959)
@@ -308,8 +308,10 @@
 if (WebInspector.experimentsSettings.nativeMemorySnapshots.isEnabled())
 p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show uninstrumented native memory"), WebInspector.settings.showNativeSnapshotUninstrumentedSize));
 
-p = this._appendSection(WebInspector.UIString("Timeline"));
-p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show CPU activity on the ruler"), WebInspector.settings.showCpuOnTimelineRuler));
+if (Capabilities.timelineCanMonitorMainThread) {
+p = this._appendSection(WebInspector.UIString("Timeline"));
+p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show CPU activity on the ruler"), WebInspector.settings.showCpuOnTimelineRuler));
+}
 
 p = this._appendSection(WebInspector.UIString("Console"));
 p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Log XMLHttpRequests"), WebInspector.settings.monitoringXHREnabled));


Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (135958 => 135959)

--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-11-28 01:33:31 UTC (rev 135958)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js	2012-11-28 01:43:20 UTC (rev 135959)
@@ -131,11 +131,12 @@
 this._expandOffset = 15;
 
 this._headerLineCount = 1;
+this._adjustHeaderHeight();
 
 this._mainThreadTasks = /** @type {!Array.<{startTime: number, endTime: number}>} */ ([]);
-this._mainThreadMonitoringEnabled = false;
-if (WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread)
-this._enableMainThreadMonitoring();
+this._cpuBarsElement = this._timelineGrid.gridHeaderElement.createChild("div", "timeline-cpu-bars");
+this._mainThreadMonitoringEnabled = Capabilities.timelineCanMonitorMainThread && WebInspector.settings.showCpuOnTimelineRuler.get();
+WebInspector.settings.showCpuOnTimelineRuler.addChangeListener(this._showCpuOnTimelineRulerChanged, this);
 
 this._createFileSelector();
 
@@ -155,6 +156,15 @@
 WebInspector.TimelinePanel.rowHeight = 18;
 
 WebInspector.TimelinePanel.prototype = {
+_showCpuOnTimelineRulerChanged: function()
+{
+var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get();
+if (this._mainThreadMonitoringEnabled !== mainThreadMonitoringEnabled) {
+this._mainThreadMonitoringEnabled = mainThreadMonitoringEnabled;
+this._refreshMainThreadBars();
+}
+},
+
 /**
  * @param {Event} event
  * @return {boolean}
@@ -891,7 +901,7 @@
 var startTime = this._overviewPane.windowStartTime() - this._timelinePaddingLeft * scale;
 var endTime = startTime + width * scale;
 
-var tasks = this._mainThreadTasks;
+var tasks = this._mainThreadMonitoringEnabled ? this._mainThreadTasks : [];
 
 function compareEndTime(value, ta

[webkit-changes] [136426] trunk/Source

2012-12-03 Thread caseq

Title: [136426] trunk/Source








Revision 136426
Author ca...@chromium.org
Date 2012-12-03 12:04:05 -0800 (Mon, 03 Dec 2012)


Log Message
Web Inspector: Make main-thread monitoring go through InspectorController
https://bugs.webkit.org/show_bug.cgi?id=103550

Patch by Eugene Klyuchnikov  on 2012-12-03
Reviewed by Pavel Feldman.

InspectorInstrumentation was a wrong path.

Source/WebCore:

* inspector/InspectorClient.h: Remove start/stop methods.
* inspector/InspectorController.cpp:
Dispatch main thread activity notifications.
* inspector/InspectorController.h: Ditto.
* inspector/InspectorInstrumentation.cpp: Remove dispatchng.
* inspector/InspectorInstrumentation.h: Ditto.
* inspector/InspectorTimelineAgent.cpp:
Do not subscribe for notifications explicitly.

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and
listen/unlisten methods.
* src/InspectorClientImpl.h: Ditto.
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
Unsubscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::detach): Ditto.
(WebKit::WebDevToolsAgentImpl::attach):
Subscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TasObserver
interface. Froward to InspectorController.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.
* src/WebDevToolsAgentImpl.h: Implement TasObserver interface.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (136425 => 136426)

--- trunk/Source/WebCore/ChangeLog	2012-12-03 19:55:33 UTC (rev 136425)
+++ trunk/Source/WebCore/ChangeLog	2012-12-03 20:04:05 UTC (rev 136426)
@@ -1,3 +1,21 @@
+2012-12-03  Eugene Klyuchnikov  
+
+Web Inspector: Make main-thread monitoring go through InspectorController
+https://bugs.webkit.org/show_bug.cgi?id=103550
+
+Reviewed by Pavel Feldman.
+
+InspectorInstrumentation was a wrong path.
+
+* inspector/InspectorClient.h: Remove start/stop methods.
+* inspector/InspectorController.cpp:
+Dispatch main thread activity notifications.
+* inspector/InspectorController.h: Ditto.
+* inspector/InspectorInstrumentation.cpp: Remove dispatchng.
+* inspector/InspectorInstrumentation.h: Ditto.
+* inspector/InspectorTimelineAgent.cpp:
+Do not subscribe for notifications explicitly.
+
 2012-12-03  Philip Rogers  
 
 Invalidate SVG width on width attribute changes.


Modified: trunk/Source/WebCore/inspector/InspectorClient.h (136425 => 136426)

--- trunk/Source/WebCore/inspector/InspectorClient.h	2012-12-03 19:55:33 UTC (rev 136425)
+++ trunk/Source/WebCore/inspector/InspectorClient.h	2012-12-03 20:04:05 UTC (rev 136426)
@@ -58,8 +58,6 @@
 virtual bool canClearBrowserCookies() { return false; }
 virtual void clearBrowserCookies() { }
 virtual bool canMonitorMainThread() { return false; }
-virtual void startMainThreadMonitoring() { }
-virtual void stopMainThreadMonitoring() { }
 
 virtual bool canOverrideDeviceMetrics() { return false; }
 


Modified: trunk/Source/WebCore/inspector/InspectorController.cpp (136425 => 136426)

--- trunk/Source/WebCore/inspector/InspectorController.cpp	2012-12-03 19:55:33 UTC (rev 136425)
+++ trunk/Source/WebCore/inspector/InspectorController.cpp	2012-12-03 20:04:05 UTC (rev 136426)
@@ -401,6 +401,18 @@
 info.addMember(m_agents);
 }
 
+void InspectorController::willProcessTask()
+{
+if (InspectorTimelineAgent* timelineAgent = m_instrumentingAgents->inspectorTimelineAgent())
+timelineAgent->willProcessTask();
+}
+
+void InspectorController::didProcessTask()
+{
+if (InspectorTimelineAgent* timelineAgent = m_instrumentingAgents->inspectorTimelineAgent())
+timelineAgent->didProcessTask();
+}
+
 } // namespace WebCore
 
 #endif // ENABLE(INSPECTOR)


Modified: trunk/Source/WebCore/inspector/InspectorController.h (136425 => 136426)

--- trunk/Source/WebCore/inspector/InspectorController.h	2012-12-03 19:55:33 UTC (rev 136425)
+++ trunk/Source/WebCore/inspector/InspectorController.h	2012-12-03 20:04:05 UTC (rev 136426)
@@ -119,6 +119,9 @@
 
 void reportMemoryUsage(MemoryObjectInfo*) const;
 
+void willProcessTask();
+void didProcessTask();
+
 private:
 InspectorController(Page*, InspectorClient*);
 


Modified: trunk/Source/We

[webkit-changes] [136448] trunk/Source/WebCore

2012-12-03 Thread caseq

Title: [136448] trunk/Source/WebCore








Revision 136448
Author ca...@chromium.org
Date 2012-12-03 15:43:27 -0800 (Mon, 03 Dec 2012)


Log Message
Web Inspector: make it possible to fliter out messages from console.{time,timeEnd}()
https://bugs.webkit.org/show_bug.cgi?id=103781

Reviewed by Yury Semikhatsky.

- make console messages produced by console.timeEnd() TimingMessageType & DebugMessageLevel;
- add console filter for Debug messages;

* inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::stopTiming):
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
* inspector/front-end/inspector.css:
(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):
* page/ConsoleTypes.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/ConsoleMessage.cpp
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/ConsoleView.js
trunk/Source/WebCore/inspector/front-end/inspector.css
trunk/Source/WebCore/page/ConsoleTypes.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (136447 => 136448)

--- trunk/Source/WebCore/ChangeLog	2012-12-03 23:42:49 UTC (rev 136447)
+++ trunk/Source/WebCore/ChangeLog	2012-12-03 23:43:27 UTC (rev 136448)
@@ -1,3 +1,29 @@
+2012-11-30  Andrey Kosyakov  
+
+Web Inspector: make it possible to fliter out messages from console.{time,timeEnd}()
+https://bugs.webkit.org/show_bug.cgi?id=103781
+
+Reviewed by Yury Semikhatsky.
+
+- make console messages produced by console.timeEnd() TimingMessageType & DebugMessageLevel;
+- add console filter for Debug messages;
+
+* inspector/ConsoleMessage.cpp:
+(WebCore::messageTypeValue):
+* inspector/Inspector.json:
+* inspector/InspectorConsoleAgent.cpp:
+(WebCore::InspectorConsoleAgent::stopTiming):
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
+* inspector/front-end/ConsoleView.js:
+(WebInspector.ConsoleView.prototype.):
+(WebInspector.ConsoleView.prototype.filter):
+* inspector/front-end/inspector.css:
+(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
+(.filter-all .console-debug-level, .filter-debug .console-debug-level):
+(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):
+* page/ConsoleTypes.h:
+
 2012-12-03  Sheriff Bot  
 
 Unreviewed, rolling out r136444.


Modified: trunk/Source/WebCore/inspector/ConsoleMessage.cpp (136447 => 136448)

--- trunk/Source/WebCore/inspector/ConsoleMessage.cpp	2012-12-03 23:42:49 UTC (rev 136447)
+++ trunk/Source/WebCore/inspector/ConsoleMessage.cpp	2012-12-03 23:43:27 UTC (rev 136448)
@@ -107,6 +107,7 @@
 case StartGroupCollapsedMessageType: return TypeBuilder::Console::ConsoleMessage::Type::StartGroupCollapsed;
 case EndGroupMessageType: return TypeBuilder::Console::ConsoleMessage::Type::EndGroup;
 case AssertMessageType: return TypeBuilder::Console::ConsoleMessage::Type::Assert;
+case TimingMessageType: return TypeBuilder::Console::ConsoleMessage::Type::Timing;
 }
 return TypeBuilder::Console::ConsoleMessage::Type::Log;
 }


Modified: trunk/Source/WebCore/inspector/Inspector.json (136447 => 136448)

--- trunk/Source/WebCore/inspector/Inspector.json	2012-12-03 23:42:49 UTC (rev 136447)
+++ trunk/Source/WebCore/inspector/Inspector.json	2012-12-03 23:43:27 UTC (rev 136448)
@@ -675,7 +675,7 @@
 { "name": "source", "type": "string", "enum": ["html", "wml", "xml", "_javascript_", "network", "console-api", "other"], "description": "Message source." },
 { "name": "level", "type": "string", "enum": ["tip", "log", "warning", "error", "debug"], "description": "Message severity." },
 { "name": "text", "type": "string", "description": "Message text." },
-{ "name": "type", "type": "string", "optional": true, "enum": ["log", "dir", "dirxml", "trace", "clear", "startGroup", "startGroupCollapsed", "endGroup", "assert"], "description": "Console message type." },
+{ "name": "type", "type": "string", "optional": true, "enum": ["log", "dir", "dirxml", "trace", "clear", "startGroup", "startGroupCollapsed", "endGroup", "assert", "timing"], "description

[webkit-changes] [143725] trunk/Source/WebKit/chromium

2013-02-22 Thread caseq

Title: [143725] trunk/Source/WebKit/chromium








Revision 143725
Author ca...@chromium.org
Date 2013-02-22 05:52:46 -0800 (Fri, 22 Feb 2013)


Log Message
Web Inspector: [Chromium] add a browser test for frames on timeline
https://bugs.webkit.org/show_bug.cgi?id=110592

- factor out timeline recording logic from testPageOverlayUpdate for reuse;
- record timeline while running a simple DOM-based animation;
- assure we have frames and Style Recalc/Layout/Paint events in between.

Reviewed by Yury Semikhatsky.

* src/js/Tests.js:
(.TestSuite.prototype.assertHasKey):
(.TestSuite.prototype.testTimelineFrames.step1):
(.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
(.TestSuite.prototype.testTimelineFrames):
(.TestSuite.prototype.testPageOverlayUpdate.step4):
(.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
(.TestSuite.prototype.recordTimeline.addRecord):
(.TestSuite.prototype.recordTimeline.innerAddRecord):
(.TestSuite.prototype.recordTimeline.done):
(.TestSuite.prototype.recordTimeline):
(.TestSuite.prototype.stopTimeline):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/Tests.js




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143724 => 143725)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 13:50:51 UTC (rev 143724)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-22 13:52:46 UTC (rev 143725)
@@ -1,3 +1,27 @@
+2013-02-22  Andrey Kosyakov  
+
+Web Inspector: [Chromium] add a browser test for frames on timeline
+https://bugs.webkit.org/show_bug.cgi?id=110592
+
+- factor out timeline recording logic from testPageOverlayUpdate for reuse;
+- record timeline while running a simple DOM-based animation;
+- assure we have frames and Style Recalc/Layout/Paint events in between.
+
+Reviewed by Yury Semikhatsky.
+
+* src/js/Tests.js:
+(.TestSuite.prototype.assertHasKey):
+(.TestSuite.prototype.testTimelineFrames.step1):
+(.TestSuite.prototype.testTimelineFrames.onTimelineRecorded):
+(.TestSuite.prototype.testTimelineFrames):
+(.TestSuite.prototype.testPageOverlayUpdate.step4):
+(.TestSuite.prototype.testPageOverlayUpdate.onTimelineRecorded):
+(.TestSuite.prototype.recordTimeline.addRecord):
+(.TestSuite.prototype.recordTimeline.innerAddRecord):
+(.TestSuite.prototype.recordTimeline.done):
+(.TestSuite.prototype.recordTimeline):
+(.TestSuite.prototype.stopTimeline):
+
 2013-02-21  Alec Flett  
 
 IndexedDB: Implement SharedBuffer version of put() / onSuccess()


Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (143724 => 143725)

--- trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-22 13:50:51 UTC (rev 143724)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-22 13:52:46 UTC (rev 143725)
@@ -93,6 +93,18 @@
 
 
 /**
+ * HasKey assertion tests that object has given key.
+ * @param {Object} object
+ * @param {string} key
+ */
+TestSuite.prototype.assertHasKey = function(object, key)
+{
+if (!object.hasOwnProperty(key))
+this.fail("Expected object to contain key '" + key + "'");
+};
+
+
+/**
  * Contains assertion tests that string contains substring.
  * @param {string} string Outer.
  * @param {string} substring Inner.
@@ -554,29 +566,52 @@
 this.takeControl();
 };
 
-
-// Regression test for http://webk.it/97466
-TestSuite.prototype.testPageOverlayUpdate = function()
+/**
+ * Tests that timeline receives frame signals.
+ */
+TestSuite.prototype.testTimelineFrames = function()
 {
 var test = this;
-var records = [];
-var dispatchOnRecordType = {}
 
-function addRecord(event)
+function step1()
 {
-innerAddRecord(event.data);
+test.recordTimeline(onTimelineRecorded);
+test.evaluateInConsole_("runTest()", function(){});
 }
 
-function innerAddRecord(record)
+function onTimelineRecorded(records)
 {
-records.push(record);
-if (typeof dispatchOnRecordType[record.type] === "function")
-dispatchOnRecordType[record.type](record);
+var frameCount = 0;
+var recordsInFrame = {};
 
-if (record.children)
-record.children.forEach(innerAddRecord);
+for (var i = 0; i < records.length; ++i) {
+var record = records[i];
+if (record.type !== "BeginFrame") {
+recordsInFrame[record.type] = (recordsInFrame[record.type] || 0) + 1;
+continue;
+}
+if (!frameCount++)
+continue;
+
+test.assertHasKey(recordsInFrame, "FireAnimationFrame");
+test.assertHasKey(recordsInFrame, "Layout");
+test.assertHasKey(recordsInFrame, "RecalculateStyles");
+test.assertHasKey(recordsInFrame, "Paint");
+recordsInFrame = {};
+}
+test.assertTrue(frameCount >= 5, "Not enough frames");

[webkit-changes] [143921] trunk/Source/WebKit/chromium

2013-02-25 Thread caseq

Title: [143921] trunk/Source/WebKit/chromium








Revision 143921
Author ca...@chromium.org
Date 2013-02-25 07:10:15 -0800 (Mon, 25 Feb 2013)


Log Message
Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.

* src/js/Tests.js:
(.TestSuite.prototype.testPageOverlayUpdate.step2):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/Tests.js




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (143920 => 143921)

--- trunk/Source/WebKit/chromium/ChangeLog	2013-02-25 14:53:52 UTC (rev 143920)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-02-25 15:10:15 UTC (rev 143921)
@@ -1,3 +1,10 @@
+2013-02-25  Andrey Kosyakov  
+
+Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.
+
+* src/js/Tests.js:
+(.TestSuite.prototype.testPageOverlayUpdate.step2):
+
 2013-02-25  Anton Vayvod  
 
 [Chromium] Disable registerProtocolHandler on Android


Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (143920 => 143921)

--- trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-25 14:53:52 UTC (rev 143920)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js	2013-02-25 15:10:15 UTC (rev 143921)
@@ -626,7 +626,6 @@
 
 function step1()
 {
-test.recordTimeline(onTimelineRecorded);
 test.evaluateInConsole_(populatePage.toString() + "; populatePage();" +
 "inspect(document.getElementById('div1'))", function() {});
 WebInspector.notifications.addEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step2);
@@ -635,6 +634,7 @@
 function step2()
 {
 WebInspector.notifications.removeEventListener(WebInspector.ElementsTreeOutline.Events.SelectedNodeChanged, step2);
+test.recordTimeline(onTimelineRecorded);
 setTimeout(step3, 500);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144039] trunk/Source/WebCore

2013-02-26 Thread caseq

Title: [144039] trunk/Source/WebCore








Revision 144039
Author ca...@chromium.org
Date 2013-02-26 04:42:58 -0800 (Tue, 26 Feb 2013)


Log Message
Web Inspector: display background events on Timeline
https://bugs.webkit.org/show_bug.cgi?id=108599

Reviewed by Pavel Feldman.

- add optional `thread' field to timeline event;
- if thread field is present, display the event as 'background' (hollow bar / list icon), align to nearest foreground event;
- do not account background events in Frame mode of overview.

* inspector/Inspector.json:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):
* inspector/front-end/timelinePanel.css:
(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/front-end/TimelineFrameController.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
trunk/Source/WebCore/inspector/front-end/timelinePanel.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (144038 => 144039)

--- trunk/Source/WebCore/ChangeLog	2013-02-26 12:33:03 UTC (rev 144038)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 12:42:58 UTC (rev 144039)
@@ -1,3 +1,33 @@
+2013-02-01  Andrey Kosyakov  
+
+Web Inspector: display background events on Timeline
+https://bugs.webkit.org/show_bug.cgi?id=108599
+
+Reviewed by Pavel Feldman.
+
+- add optional `thread' field to timeline event;
+- if thread field is present, display the event as 'background' (hollow bar / list icon), align to nearest foreground event;
+- do not account background events in Frame mode of overview.
+
+* inspector/Inspector.json:
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
+(WebCore):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+* inspector/front-end/TimelineFrameController.js:
+(WebInspector.TimelineFrameController.prototype._addRecord):
+* inspector/front-end/TimelinePanel.js:
+(WebInspector.TimelineRecordListRow.prototype.update):
+(WebInspector.TimelineRecordGraphRow.prototype.update):
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel.Record):
+(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
+(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):
+* inspector/front-end/timelinePanel.css:
+(.timeline-tree-item.background .timeline-tree-icon):
+(.timeline-graph-side.background .timeline-graph-bar):
+
 2013-02-26  Kentaro Hara  
 
 [V8] Rename BatchedCallback to BatchedMethod


Modified: trunk/Source/WebCore/inspector/Inspector.json (144038 => 144039)

--- trunk/Source/WebCore/inspector/Inspector.json	2013-02-26 12:33:03 UTC (rev 144038)
+++ trunk/Source/WebCore/inspector/Inspector.json	2013-02-26 12:42:58 UTC (rev 144039)
@@ -2595,6 +2595,7 @@
 "type": "object",
 "properties": [
 { "name": "type", "type": "string", "description": "Event type." },
+{ "name": "thread", "type": "string", "optional": true, "description": "If present, identifies the thread that produced the event." },
 { "name": "data", "type": "object", "description": "Event data." },
 { "name": "children", "type": "array", "optional": true, "items": { "$ref": "TimelineEvent" }, "description": "Nested records." }
 ],


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (144038 => 144039)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-02-26 12:33:03 UTC (rev 144038)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-02-26 12:42:58 UTC (rev 144039)
@@ -650,6 +650,17 @@
 addRecordToTimeline(record.release(), type, frameId);
 }
 
+void InspectorTimelineAgent::appendBackgroundThreadRecord(PassRefPtr data, const String& type, double startTime, double endTime, con

[webkit-changes] [144041] trunk/Source

2013-02-26 Thread caseq

Title: [144041] trunk/Source








Revision 144041
Author ca...@chromium.org
Date 2013-02-26 04:52:33 -0800 (Tue, 26 Feb 2013)


Log Message
Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

Source/WebCore:

- plumb trace events to Timeline;
- add TimelineTraceEventProcessor to process selected trace events;
- emit timeline events from TimelineTraceEventProcessor.

Note that actual event processing logic is a separate change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorClient.h:
(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendBackgroundThreadRecord):
(WebCore):
(WebCore::InspectorTimelineAgent::page):
* inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
* inspector/TimelineTraceEventProcessor.cpp: Added.
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
* inspector/TimelineTraceEventProcessor.h: Added.
(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.insertRetrospecitveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get isBackground):
* inspector/front-end/timelinePanel.css:
(.timeline-tree-item.background .timeline-tree-icon):
(.timeline-graph-side.background .timeline-graph-bar):

Source/WebKit/chromium:

Plumb trace events to Inspector.

* public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/inspector/InspectorAllInOne.cpp
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h


Added Paths

trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.cpp
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (144040 => 144041)

--- trunk/Source/WebCore/CMakeLists.txt	2013-02-26 12:52:32 UTC (rev 144040)
+++ trunk/Source/WebCore/CMakeLists.txt	2013-02-26 12:52:33 UTC (rev 144041)
@@ -1655,6 +1655,7 @@
 inspector/ScriptCallFrame.cpp
 inspector/ScriptC

[webkit-changes] [144044] trunk

2013-02-26 Thread caseq

Title: [144044] trunk








Revision 144044
Author ca...@chromium.org
Date 2013-02-26 05:12:28 -0800 (Tue, 26 Feb 2013)


Log Message
Source/WebCore: Web Inspector: show raster tasks on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851

- add PaintLayer, Paint & RasterTask trace events handling to trace event processor;
- upon begin frame, emit aggregated background event for all raster tasks related to the inspected page.

Reviewed by Pavel Feldman.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):
* inspector/InspectorInstrumentation.h:
(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
* inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
(WebCore):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
* inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
* inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(TimelineTraceEventProcessor):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):

LayoutTests: Web Inspector: show deferred paints on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851

Reviewed by Pavel Feldman.

* inspector/timeline/timeline-enum-stability-expected.txt: Added "Rasterize" record type.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.cpp
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js




Diff

Modified: trunk/LayoutTests/ChangeLog (144043 => 144044)

--- trunk/LayoutTests/ChangeLog	2013-02-26 13:04:28 UTC (rev 144043)
+++ trunk/LayoutTests/ChangeLog	2013-02-26 13:12:28 UTC (rev 144044)
@@ -1,3 +1,12 @@
+2013-02-26  Andrey Kosyakov  
+
+Web Inspector: show deferred paints on Timeline
+https://bugs.webkit.org/show_bug.cgi?id=105851
+
+Reviewed by Pavel Feldman.
+
+* inspector/timeline/timeline-enum-stability-expected.txt: Added "Rasterize" record type.
+
 2013-02-26  Takashi Toyoshima  
 
 Add User-Agent header in opening handshake headers.


Modified: trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt (144043 => 144044)

--- trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2013-02-26 13:04:28 UTC (rev 144043)
+++ trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2013-02-26 13:12:28 UTC (rev 144044)
@@ -19,6 +19,7 @@
 Paint : "Paint"
 ParseHTML : "ParseHTML"
 Program : "Program"
+Rasterize : "Rasterize"
 RecalculateStyles : "RecalculateStyles"
 RequestAnimationFrame : "RequestAnimationFrame"
 ResizeImage : "ResizeImage"


Modified: trunk/Source/WebCore/Change

[webkit-changes] [144048] trunk/Source/WebCore

2013-02-26 Thread caseq

Title: [144048] trunk/Source/WebCore








Revision 144048
Author ca...@chromium.org
Date 2013-02-26 05:44:38 -0800 (Tue, 26 Feb 2013)


Log Message
Unreviewed build fix following r144041.

* inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144047 => 144048)

--- trunk/Source/WebCore/ChangeLog	2013-02-26 13:43:03 UTC (rev 144047)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 13:44:38 UTC (rev 144048)
@@ -1,3 +1,10 @@
+2013-02-26  Andrey Kosyakov  
+
+Unreviewed build fix following r144041.
+
+* inspector/TimelineTraceEventProcessor.h:
+(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
+
 2013-02-26  Vivek Galatage  
 
 Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node


Modified: trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h (144047 => 144048)

--- trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h	2013-02-26 13:43:03 UTC (rev 144047)
+++ trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h	2013-02-26 13:44:38 UTC (rev 144048)
@@ -101,6 +101,7 @@
 : m_timestamp(timestamp)
 , m_phase(phase)
 , m_name(name)
+, m_id(id)
 , m_threadIdentifier(threadIdentifier)
 , m_argumentCount(argumentCount)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [144062] trunk/Source

2013-02-26 Thread caseq

Title: [144062] trunk/Source








Revision 144062
Author ca...@chromium.org
Date 2013-02-26 08:22:55 -0800 (Tue, 26 Feb 2013)


Log Message
Source/WebCore: Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

- plumb trace events to Timeline;
- add TimelineTraceEventProcessor to process selected trace events;
- emit timeline events from TimelineTraceEventProcessor.

Note that actual event processing logic is a separate change.

* CMakeLists.txt: Added TimelineTraceEventProcessor.{h,cpp}.
* GNUmakefile.list.am:  Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* inspector/InspectorAllInOne.cpp: Ditto.
* inspector/InspectorClient.h:
(InspectorClient):
(WebCore::InspectorClient::setTraceEventCallback):
* inspector/InspectorTimelineAgent.cpp: create/destroy trace event processor on start/stop.
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::page):
(WebCore):
* inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
* inspector/TimelineTraceEventProcessor.cpp: Added.
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::processEvent):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
* inspector/TimelineTraceEventProcessor.h: Added.
(WebCore):
(TimelineTraceEventProcessor):
(TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::timestamp):
(WebCore::TimelineTraceEventProcessor::TraceEvent::phase):
(WebCore::TimelineTraceEventProcessor::TraceEvent::name):
(WebCore::TimelineTraceEventProcessor::TraceEvent::threadIdentifier):
(WebCore::TimelineTraceEventProcessor::TraceEvent::argumentCount):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asBool):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asDouble):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asString):
(WebCore::TimelineTraceEventProcessor::EventTypeEntry::EventTypeEntry):
(EventTypeEntry):

Source/WebKit/chromium: Plumbing trace events to Timeline

Web Inspector: plumb trace events to Timeline agent
https://bugs.webkit.org/show_bug.cgi?id=105796

Reviewed by Pavel Feldman.

* public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::setTraceEventCallback):
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::setTraceEventCallback):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::setTraceEventCallback):
(WebKit):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/inspector/InspectorAllInOne.cpp
trunk/Source/WebCore/inspector/InspectorClient.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h
trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp
trunk/Source/WebKit/chromium/src/InspectorClientImpl.h
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp
trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h


Added Paths

trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.cpp
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (144061 => 144062)

--- trunk/Source/WebCore/CMakeLists.txt	2013-02-26 16:14:12 UTC (rev 144061)
+++ trunk/Source/WebCore/CMakeLists.txt	2013-02-26 16:22:55 UTC (rev 144062)
@@ -1655,6 +1655,7 @@
 inspector/ScriptCallFrame.cpp
 inspector/ScriptCallStack.cpp
 inspector/TimelineRecordFactory.cpp
+inspector/TimelineTraceEventProcessor.cpp
 inspector/WorkerConsoleAgent.cpp
 inspector/WorkerDebuggerAgent.cpp
 inspector/WorkerInspectorController.cpp


Modified: trunk/Source/WebCore/ChangeLog (144061 => 144062)

--- trunk/Source/WebCore/ChangeLog	2013-02-26 16:14:12 UTC (rev 144061)
+++ trunk/Source/WebCore/ChangeLog	2013-02-26 16:22:55 UTC (rev 144062)
@@ -1,3 +1,62 @@
+2013-02-26  Andrey Kosyakov  
+
+

[webkit-changes] [144154] trunk

2013-02-27 Thread caseq

Title: [144154] trunk








Revision 144154
Author ca...@chromium.org
Date 2013-02-27 00:37:15 -0800 (Wed, 27 Feb 2013)


Log Message
Web Inspector: show raster tasks on Timeline
https://bugs.webkit.org/show_bug.cgi?id=105851

- add DeferPaint, Paint & RasterTask trace events handling to trace event processor;
- upon begin frame, emit aggregated background event for all raster tasks related to inspected page.

Reviewed by Pavel Feldman.

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(InstrumentationEvents):
(InstrumentationEventArguments):
* inspector/InspectorInstrumentation.h:
(InstrumentationEvents):
(WebCore):
(InstrumentationEventArguments):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::didBeginFrame):
* inspector/InspectorTimelineAgent.h:
(TimelineRecordType):
(WebCore):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createRasterData):
(WebCore):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
* inspector/TimelineTraceEventProcessor.cpp:
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::~TimelineTraceEventProcessor):
(WebCore):
(WebCore::TimelineTraceEventProcessor::registerHandler):
(WebCore::TimelineTraceEventProcessor::shutdown):
(WebCore::TimelineTraceEventProcessor::TraceEvent::findParameter):
(WebCore::TimelineTraceEventProcessor::TraceEvent::parameter):
(WebCore::TimelineTraceEventProcessor::processEventOnAnyThread):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onPaintLayerBegin):
(WebCore::TimelineTraceEventProcessor::onPaintLayerEnd):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::onLayerDeleted):
(WebCore::TimelineTraceEventProcessor::onPaint):
(WebCore::TimelineTraceEventProcessor::flushRasterizerStatistics):
(WebCore::TimelineTraceEventProcessor::sendTimelineRecord):
(WebCore::TimelineTraceEventProcessor::processBackgroundEvents):
* inspector/TimelineTraceEventProcessor.h:
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::id):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asInt):
(WebCore::TimelineTraceEventProcessor::TraceEvent::asUInt):
(TimelineTraceEventProcessor):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):

Modified Paths

trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.cpp
trunk/Source/WebCore/inspector/TimelineTraceEventProcessor.h
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js




Diff

Modified: trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt (144153 => 144154)

--- trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2013-02-27 08:33:20 UTC (rev 144153)
+++ trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2013-02-27 08:37:15 UTC (rev 144154)
@@ -19,6 +19,7 @@
 Paint : "Paint"
 ParseHTML : "ParseHTML"
 Program : "Program"
+Rasterize : "Rasterize"
 RecalculateStyles : "RecalculateStyles"
 RequestAnimationFrame : "RequestAnimationFrame"
 ResizeImage : "ResizeImage"


Modified: trunk/Source/WebCore/ChangeLog (144153 => 144154)

--- trunk/Source/WebCore/ChangeLog	2013-02-27 08:33:20 UTC (rev 144153)
+++ trunk/Source/WebCore/ChangeLog	2013-02-27 08:37:15 UTC (rev 144154)
@@ -1,3 +1,63 @@
+2013-02-26  Andrey Kosyakov  
+
+Web Inspector: show raster tasks on Timeline
+https://bugs.webkit.org/show_bug.cgi?id=105851
+
+- add DeferPaint, Paint & RasterTask trace events handling to trace event processor;
+- upon begin frame, emit aggregated background event for all raster tasks related to inspected page.
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::willPaintImpl):
+(InstrumentationEvents):
+(InstrumentationEventArguments):
+* inspector/InspectorInstrumentation.h:
+(InstrumentationEvents):
+(WebCore):
+(InstrumentationEventArguments):
+* inspector/InspectorTimelineAgent.cpp:
+(TimelineRe

[webkit-changes] [144746] trunk/Source/WebCore

2013-03-05 Thread caseq

Title: [144746] trunk/Source/WebCore








Revision 144746
Author ca...@chromium.org
Date 2013-03-05 02:53:38 -0800 (Tue, 05 Mar 2013)


Log Message
Web Inspector: use timestamps consistent with rest of Timeline in WebSocket events.
https://bugs.webkit.org/show_bug.cgi?id=111344

- create web socket related records in a manner consistent with the rest of timeline.

Reviewed by Pavel Feldman.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateWebSocket):
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorTimelineAgent::didDestroyWebSocket):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144745 => 144746)

--- trunk/Source/WebCore/ChangeLog	2013-03-05 10:38:48 UTC (rev 144745)
+++ trunk/Source/WebCore/ChangeLog	2013-03-05 10:53:38 UTC (rev 144746)
@@ -1,3 +1,20 @@
+2013-03-04  Andrey Kosyakov  
+
+Web Inspector: use timestamps consistent with rest of Timeline in WebSocket events.
+https://bugs.webkit.org/show_bug.cgi?id=111344
+
+- create web socket related records in a manner consistent with the rest of timeline.
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::didCreateWebSocket):
+(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest):
+(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse):
+(WebCore::InspectorTimelineAgent::didDestroyWebSocket):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+
 2013-03-05  Andrei Bucur  
 
 [CSS Regions] Crash when MathML used in CSS Regions


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (144745 => 144746)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-03-05 10:38:48 UTC (rev 144745)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-03-05 10:53:38 UTC (rev 144746)
@@ -513,39 +513,22 @@
 #if ENABLE(WEB_SOCKETS)
 void InspectorTimelineAgent::didCreateWebSocket(unsigned long identifier, const KURL& url, const String& protocol, Frame* frame)
 {
-pushGCEventRecords();
-RefPtr record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS(), m_maxCallStackDepth);
-record->setObject("data", TimelineRecordFactory::createWebSocketCreateData(identifier, url, protocol));
-String frameId;
-if (frame && m_pageAgent)
-frameId = m_pageAgent->frameId(frame);
-addRecordToTimeline(record.release(), TimelineRecordType::WebSocketCreate, frameId);
+appendRecord(TimelineRecordFactory::createWebSocketCreateData(identifier, url, protocol), TimelineRecordType::WebSocketCreate, true, frame);
 }
 
-void InspectorTimelineAgent::addWebSocketRecord(unsigned long identifier, Frame* frame, const String& type)
-{
-pushGCEventRecords();
-RefPtr record = TimelineRecordFactory::createGenericRecord(WTF::currentTimeMS(), m_maxCallStackDepth);
-record->setObject("data", TimelineRecordFactory::createGenericWebSocketData(identifier));
-String frameId;
-if (frame && m_pageAgent)
-frameId = m_pageAgent->frameId(frame);
-addRecordToTimeline(record.release(), type, frameId);
-}
-
 void InspectorTimelineAgent::willSendWebSocketHandshakeRequest(unsigned long identifier, Frame* frame)
 {
-addWebSocketRecord(identifier, frame, TimelineRecordType::WebSocketSendHandshakeRequest);
+appendRecord(TimelineRecordFactory::createGenericWebSocketData(identifier), TimelineRecordType::WebSocketSendHandshakeRequest, true, frame);
 }
 
 void InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse(unsigned long identifier, Frame* frame)
 {
-addWebSocketRecord(identifier, frame, TimelineRecordType::WebSocketReceiveHandshakeResponse);
+appendRecord(TimelineRecordFactory::createGenericWebSocketData(identifier), TimelineRecordType::WebSocketReceiveHandshakeResponse, false, frame);
 }
 
 void InspectorTimelineAgent::didDestroyWebSocket(unsigned long identifier, Frame* frame)
 {
-addWebSocketRecord(identifier, frame, TimelineRecordType::WebSocketDestroy);
+appendRecord(TimelineRecordFactory::createGenericWebSocketData(identifier), TimelineRecordType::WebSocketDestroy, true, frame);
 }
 #endif // ENABLE(WEB_SOCKETS)
 


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.h (144745 => 144746)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.h	2013-03-05 10:38:48 UTC (rev 144745)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.h	2013-03-05 10:53:38 UTC (rev 144746)
@@ -216,10 +216,6 @@
 void innerAddRecordToTimeline(PassRefPtr, const String& type, const String& frameId);

[webkit-changes] [144749] trunk/Source/WebCore

2013-03-05 Thread caseq

Title: [144749] trunk/Source/WebCore








Revision 144749
Author ca...@chromium.org
Date 2013-03-05 04:23:37 -0800 (Tue, 05 Mar 2013)


Log Message
Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
https://bugs.webkit.org/show_bug.cgi?id=111345

Reviewed by Pavel Feldman.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144748 => 144749)

--- trunk/Source/WebCore/ChangeLog	2013-03-05 11:34:38 UTC (rev 144748)
+++ trunk/Source/WebCore/ChangeLog	2013-03-05 12:23:37 UTC (rev 144749)
@@ -1,3 +1,25 @@
+2013-03-04  Andrey Kosyakov  
+
+Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
+https://bugs.webkit.org/show_bug.cgi?id=111345
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::pushGCEventRecords):
+(WebCore::InspectorTimelineAgent::addRecordToTimeline):
+(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
+(WebCore::InspectorTimelineAgent::setFrameIdentifier):
+(WebCore):
+(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
+(WebCore::InspectorTimelineAgent::appendRecord):
+(WebCore::InspectorTimelineAgent::pushCurrentRecord):
+(WebCore::InspectorTimelineAgent::commitFrameRecord):
+* inspector/InspectorTimelineAgent.h:
+(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
+(TimelineRecordEntry):
+(InspectorTimelineAgent):
+
 2013-03-05  Tommy Widenflycht  
 
 MediaStream API: Add the getStreamById method on RTCPeerConnection


Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (144748 => 144749)

--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-03-05 11:34:38 UTC (rev 144748)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2013-03-05 12:23:37 UTC (rev 144749)
@@ -133,7 +133,7 @@
 RefPtr record = TimelineRecordFactory::createGenericRecord(timestampFromMicroseconds(i->startTime), m_maxCallStackDepth);
 record->setObject("data", TimelineRecordFactory::createGCEventData(i->collectedBytes));
 record->setNumber("endTime", timestampFromMicroseconds(i->endTime));
-addRecordToTimeline(record.release(), TimelineRecordType::GCEvent, String());
+addRecordToTimeline(record.release(), TimelineRecordType::GCEvent);
 }
 }
 
@@ -532,18 +532,16 @@
 }
 #endif // ENABLE(WEB_SOCKETS)
 
-void InspectorTimelineAgent::addRecordToTimeline(PassRefPtr record, const String& type, const String& frameId)
+void InspectorTimelineAgent::addRecordToTimeline(PassRefPtr record, const String& type)
 {
 commitFrameRecord();
-innerAddRecordToTimeline(record, type, frameId);
+innerAddRecordToTimeline(record, type);
 }
 
-void InspectorTimelineAgent::innerAddRecordToTimeline(PassRefPtr prpRecord, const String& type, const String& frameId)
+void InspectorTimelineAgent::innerAddRecordToTimeline(PassRefPtr prpRecord, const String& type)
 {
 RefPtr record(prpRecord);
 record->setString("type", type);
-if (!frameId.isEmpty())
-record->setString("frameId", frameId);
 if (type == TimelineRecordType::Program)
 setNativeHeapStatistics(record.get());
 else
@@ -597,6 +595,16 @@
 record->setObject("nativeHeapStatistics", stats.release());
 }
 
+void InspectorTimelineAgent::setFrameIdentifier(InspectorObject* record, Frame* frame)
+{
+if (!frame || !m_pageAgent)
+return;
+String frameId;
+if (frame && m_pageAgent)
+frameId = m_pageAgent->frameId(frame);
+record->setString("frameId", frameId);
+}
+
 void InspectorTimelineAgent::didCompleteCurrentRecord(const String& type)
 {
 // An empty stack could merely mean that the timeline agent was turned on in the middle of
@@ -617,7 +625,7 @@
 size_t usedHeapSizeDelta = getUsedHeapSize() - entry.usedHeapSizeAtStart;
 if (usedHeapSizeDelta)
 entry.record->setNumber("usedHeapSizeDelta", usedHeapSizeDelta);
-addRecordToTimeline(entry.record

[webkit-changes] [144756] trunk

2013-03-05 Thread caseq

Title: [144756] trunk








Revision 144756
Author ca...@chromium.org
Date 2013-03-05 06:09:20 -0800 (Tue, 05 Mar 2013)


Log Message
Web Inspector: remove length parameter from Parse HTML timeline event
https://bugs.webkit.org/show_bug.cgi?id=111421

Reviewed by Yury Semikhatsky.

Source/WebCore:

- remove length parameter in all instrumentation methods used to emit ParseHTML timeline event;
- drive-by style fixes.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didWriteHTMLImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createParseHTMLData):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):

LayoutTests:

- removed length field from ParseHTML data in expectations.

* inspector/timeline/timeline-parse-html-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h




Diff

Modified: trunk/LayoutTests/ChangeLog (144755 => 144756)

--- trunk/LayoutTests/ChangeLog	2013-03-05 14:06:28 UTC (rev 144755)
+++ trunk/LayoutTests/ChangeLog	2013-03-05 14:09:20 UTC (rev 144756)
@@ -1,3 +1,14 @@
+2013-03-05  Andrey Kosyakov  
+
+Web Inspector: remove length parameter from Parse HTML timeline event
+https://bugs.webkit.org/show_bug.cgi?id=111421
+
+Reviewed by Yury Semikhatsky.
+
+- removed length field from ParseHTML data in expectations.
+
+* inspector/timeline/timeline-parse-html-expected.txt:
+
 2013-03-05  Tim Horton  , Grzegorz Czajkowski  
 
 [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled


Modified: trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt (144755 => 144756)

--- trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt	2013-03-05 14:06:28 UTC (rev 144755)
+++ trunk/LayoutTests/inspector/timeline/timeline-parse-html-expected.txt	2013-03-05 14:09:20 UTC (rev 144756)
@@ -7,7 +7,6 @@
 counters : 
 data : {
 endLine : 0
-length : 9
 startLine : 0
 }
 endTime : 
@@ -23,7 +22,6 @@
 counters : 
 data : {
 endLine : 0
-length : 1
 startLine : 0
 }
 endTime : 


Modified: trunk/Source/WebCore/ChangeLog (144755 => 144756)

--- trunk/Source/WebCore/ChangeLog	2013-03-05 14:06:28 UTC (rev 144755)
+++ trunk/Source/WebCore/ChangeLog	2013-03-05 14:09:20 UTC (rev 144756)
@@ -1,3 +1,35 @@
+2013-03-05  Andrey Kosyakov  
+
+Web Inspector: remove length parameter from Parse HTML timeline event
+https://bugs.webkit.org/show_bug.cgi?id=111421
+
+Reviewed by Yury Semikhatsky.
+
+- remove length parameter in all instrumentation methods used to emit ParseHTML timeline event;
+- drive-by style fixes.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
+(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
+(WebCore::InspectorInstrumentation::didWriteHTMLImpl):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+(WebCore::InspectorInstrumentation::willWriteHTML):
+(WebCore::InspectorInstrumentation::didWriteHTML):
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::willWriteHTML):
+(WebCore::InspectorTimelineAgent::didWriteHTML):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+* inspector/TimelineRecordFactory.cpp:
+(WebCore::TimelineRecordFactory::createParseHTMLData):
+* inspector/TimelineRecordFactory.h:
+(TimelineRecordFactory):
+
 2013-03-05  Alexei

[webkit-changes] [144761] trunk/Source/WebCore

2013-03-05 Thread caseq

Title: [144761] trunk/Source/WebCore








Revision 144761
Author ca...@chromium.org
Date 2013-03-05 08:06:19 -0800 (Tue, 05 Mar 2013)


Log Message
Unreviewed follow-up to r144756, fix broken inspector-less build.

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willWriteHTML):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (144760 => 144761)

--- trunk/Source/WebCore/ChangeLog	2013-03-05 15:54:13 UTC (rev 144760)
+++ trunk/Source/WebCore/ChangeLog	2013-03-05 16:06:19 UTC (rev 144761)
@@ -1,3 +1,10 @@
+2013-03-05  Andrey Kosyakov  
+
+Unreviewed follow-up to r144756, fix broken inspector-less build.
+
+* inspector/InspectorInstrumentation.h:
+(WebCore::InspectorInstrumentation::willWriteHTML):
+
 2013-03-05  Mark Lam  
 
 Improve robustness of WebSQL quota management.


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (144760 => 144761)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2013-03-05 15:54:13 UTC (rev 144760)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2013-03-05 16:06:19 UTC (rev 144761)
@@ -1745,7 +1745,6 @@
 return willWriteHTMLImpl(instrumentingAgents, startLine, document->frame());
 #else
 UNUSED_PARAM(document);
-UNUSED_PARAM(length);
 UNUSED_PARAM(startLine);
 #endif
 return InspectorInstrumentationCookie();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [131870] trunk/Source/WebCore

2012-10-19 Thread caseq

Title: [131870] trunk/Source/WebCore








Revision 131870
Author ca...@chromium.org
Date 2012-10-19 00:51:24 -0700 (Fri, 19 Oct 2012)


Log Message
Web Inspector: Update localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=99701

Patch by Eugene Klyuchnikov  on 2012-10-19
Reviewed by Yury Semikhatsky.

Fixed most of missing strings and orphans.

* English.lproj/localizedStrings.js:
* inspector/front-end/SettingsScreen.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (131869 => 131870)

--- trunk/Source/WebCore/ChangeLog	2012-10-19 07:45:17 UTC (rev 131869)
+++ trunk/Source/WebCore/ChangeLog	2012-10-19 07:51:24 UTC (rev 131870)
@@ -1,3 +1,15 @@
+2012-10-19  Eugene Klyuchnikov  
+
+Web Inspector: Update localizedStrings.js
+https://bugs.webkit.org/show_bug.cgi?id=99701
+
+Reviewed by Yury Semikhatsky.
+
+Fixed most of missing strings and orphans.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/SettingsScreen.js:
+
 2012-10-17  Ilya Tikhonovsky  
 
 Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (131869 => 131870)

--- trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-10-19 07:45:17 UTC (rev 131869)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-10-19 07:51:24 UTC (rev 131870)
@@ -2,7 +2,6 @@
 
 localizedStrings[" (%d)"] = " (%d)";
 localizedStrings[" (repeated %d times)"] = " (repeated %d times)";
-localizedStrings["1 - %d"] = "1 - %d";
 localizedStrings["%.0fB"] = "%.0fB";
 localizedStrings["%.0fKB"] = "%.0fKB";
 localizedStrings["%.0fMB"] = "%.0fMB";
@@ -10,7 +9,7 @@
 localizedStrings["%.1f days"] = "%.1f days";
 localizedStrings["%.1fhrs"] = "%.1fhrs";
 localizedStrings["%.1fmin"] = "%.1fmin";
-localizedStrings["%.2f%%"] = "%.2f%%";
+localizedStrings["%.2f%"] = "%.2f%";
 localizedStrings["%.2fKB"] = "%.2fKB";
 localizedStrings["%.2fMB"] = "%.2fMB";
 localizedStrings["%.2fs"] = "%.2fs";
@@ -25,26 +24,21 @@
 localizedStrings["%d errors"] = "%d errors";
 localizedStrings["%d errors, %d warning"] = "%d errors, %d warning";
 localizedStrings["%d errors, %d warnings"] = "%d errors, %d warnings";
-localizedStrings["%d of %d matches"] = "%d of %d matches";
-localizedStrings["%d matches"] = "%d matches";
+localizedStrings["%d of %d"] = "%d of %d";
 localizedStrings["%d of %d captured records are visible"] = "%d of %d captured records are visible";
 localizedStrings["%d warning"] = "%d warning";
 localizedStrings["%d warnings"] = "%d warnings";
-localizedStrings["%d × %d pixels (Natural: %d × %d pixels)"] = "%d × %d pixels (Natural: %d × %d pixels)";
-localizedStrings["%d × %d pixels"] = "%d × %d pixels";
+localizedStrings["%d \xd7 %d pixels (Natural: %d \xd7 %d pixels)"] = "%d \xd7 %d pixels (Natural: %d \xd7 %d pixels)";
+localizedStrings["%d \xd7 %d pixels"] = "%d \xd7 %d pixels";
 localizedStrings["%d × %d"] = "%d × %d";
 localizedStrings["%s (%s)"] = "%s (%s)";
 localizedStrings["%s (at %s)"] = "%s (at %s)";
 localizedStrings["%s (from cache)"] = "%s (from cache)";
 localizedStrings["%s - Details"] = "%s - Details";
-localizedStrings["%s >1000%%"] = "%s >1000%%";
 localizedStrings["%s collected"] = "%s collected";
 localizedStrings["%s download"] = "%s download";
 localizedStrings["%s latency"] = "%s latency";
 localizedStrings["%s latency, %s download (%s total)"] = "%s latency, %s download (%s total)";
-localizedStrings["%s%.2f%%"] = "%s%.2f%%";
-localizedStrings["%s%d"] = "%s%d";
-localizedStrings["%s%s"] = "%s%s";
 localizedStrings["(anonymous function)"] = "(anonymous function)";
 localizedStrings["(data url)"] = "(data url)";
 localizedStrings["(from cache)"] = "(from cache)";
@@ -56,11 +50,9 @@
 localizedStrings["(text)"] = "(text)";
 localizedStrings["(unable to decode value)"] = "(unable to decode value)";
 localizedStrings["(whitespace)"] = "(whitespace)";
-localizedStrings["1 of 1 match"] = "1 of 1 match";
-localizedStrings["1 match"] = "1 match";
 localizedStrings["Application Cache"] = "Application Cache";
 localizedStrings["Accept suggestion"] = "Accept suggestion";
-localizedStrings["Activate all breakpoints."] = "Activate all breakpoints.";
+localizedStrings["Activate All breakpoints"] = "Activate All breakpoints";
 localizedStrings["Activate all breakpoints"] = "Activate all breakpoints";
 localizedStrings["Add Attribute"] = "Add Attribute";
 localizedStrings["Add attribute"] = "Add attribute";
@@ -69,7 +61,6 @@
 localizedStrings["Add Conditional Breakpoint…"] = "Add Conditional Breakpoint…";
 localizedStrings["Add conditional breakpoint…"] = "Add conditional breakpoint…";
 localizedStrings["Add New"] = "Add New";
-localizedStrings["Add"] = "Add";
 localizedStrings["Aggregated Time"] = "Aggregated Time";
 localizedStrings["All Nodes"]

[webkit-changes] [131872] trunk/Source/WebCore

2012-10-19 Thread caseq

Title: [131872] trunk/Source/WebCore








Revision 131872
Author ca...@chromium.org
Date 2012-10-19 01:02:24 -0700 (Fri, 19 Oct 2012)


Log Message
Web Inspector: Saving HAR, snapshots and timeline data do not work in remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=99179

Patch by Eugene Klyuchnikov  on 2012-10-19
Reviewed by Yury Semikhatsky.

Added method "close" to InspectorFrontendHost.
Symantically, this method forces to flush all unsaved buffers for
specified file. In native implementation this turns to be no-op.

In stub implementation "close" causes compilation of blob object an
navigating to blob-schema url.

Removed "canAppend", as appending in now suppurted
by all implementations.

Repaced schema "data" with "blob" in InspectorFrontendHostStub "save"
to avoid out-of-memory errors.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::close): Compiles blob object and
navigates to blob-object url.
(WebCore):
* inspector/InspectorFrontendHost.h: Added "close" method.
* inspector/InspectorFrontendHost.idl: Ditto.
* inspector/front-end/FileManager.js:
(WebInspector.FileManager.prototype.close): Proxy to InspectorFrontend.
* inspector/front-end/FileUtils.js:
(WebInspector.FileOutputStream.prototype.close):
Invoke "close" on FileManager.
(WebInspector.FileOutputStream.prototype._onAppendDone): Ditto.
* inspector/front-end/HandlerRegistry.js: Added mandatory "close" call.
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.canSaveToFile): Fixed check.
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
Added "appendable" behaviour emulation.
* inspector/front-end/SourceFrame.js: Added mandatory "close" call.
* inspector/front-end/externs.js: Replaced "canAppend" with "close"

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp
trunk/Source/WebCore/inspector/InspectorFrontendHost.h
trunk/Source/WebCore/inspector/InspectorFrontendHost.idl
trunk/Source/WebCore/inspector/front-end/FileManager.js
trunk/Source/WebCore/inspector/front-end/FileUtils.js
trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotView.js
trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/externs.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (131871 => 131872)

--- trunk/Source/WebCore/ChangeLog	2012-10-19 08:01:06 UTC (rev 131871)
+++ trunk/Source/WebCore/ChangeLog	2012-10-19 08:02:24 UTC (rev 131872)
@@ -1,3 +1,44 @@
+2012-10-19  Eugene Klyuchnikov  
+
+Web Inspector: Saving HAR, snapshots and timeline data do not work in remote debugging mode
+https://bugs.webkit.org/show_bug.cgi?id=99179
+
+Reviewed by Yury Semikhatsky.
+
+Added method "close" to InspectorFrontendHost.
+Symantically, this method forces to flush all unsaved buffers for
+specified file. In native implementation this turns to be no-op.
+
+In stub implementation "close" causes compilation of blob object an
+navigating to blob-schema url.
+
+Removed "canAppend", as appending in now suppurted
+by all implementations.
+
+Repaced schema "data" with "blob" in InspectorFrontendHostStub "save"
+to avoid out-of-memory errors.
+
+* inspector/InspectorFrontendHost.cpp:
+(WebCore::InspectorFrontendHost::close): Compiles blob object and
+navigates to blob-object url.
+(WebCore):
+* inspector/InspectorFrontendHost.h: Added "close" method.
+* inspector/InspectorFrontendHost.idl: Ditto.
+* inspector/front-end/FileManager.js:
+(WebInspector.FileManager.prototype.close): Proxy to InspectorFrontend.
+* inspector/front-end/FileUtils.js:
+(WebInspector.FileOutputStream.prototype.close):
+Invoke "close" on FileManager.
+(WebInspector.FileOutputStream.prototype._onAppendDone): Ditto.
+* inspector/front-end/HandlerRegistry.js: Added mandatory "close" call.
+* inspector/front-end/HeapSnapshotView.js:
+(WebInspector.HeapProfileHeader.prototype.canSaveToFile): Fixed check.
+* inspector/front-end/InspectorFrontendHostStub.js:
+(.WebInspector.InspectorFrontendHostStub):
+Added "appendable" behaviour emulation.
+* inspector/front-end/SourceFrame.js: Added mandatory "close" call.
+* inspector/front-end/externs.js: Replaced "canAppend" with "close"
+
 2012-10-18  Dominic Mazzoni  
 
 AX: labelForElement is slow when there are a lot of DOM elements


Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (131871 => 131872)

--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2012-10-19 08:01:06 UTC (rev 131871)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2012-10-1

[webkit-changes] [132048] branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

2012-10-22 Thread caseq

Title: [132048] branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp








Revision 132048
Author ca...@chromium.org
Date 2012-10-22 02:17:23 -0700 (Mon, 22 Oct 2012)


Log Message
Merge 129772 - Page overlays are not updated when WebView is resized
https://bugs.webkit.org/show_bug.cgi?id=97789

Reviewed by Vsevolod Vlasov.

Invalidate page overlays when view is resized.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::sendResizeEventAndRepaint):


TBR=ca...@chromium.org
Review URL: https://codereview.chromium.org/11235024

Modified Paths

branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp (132047 => 132048)

--- branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-22 09:04:50 UTC (rev 132047)
+++ branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-22 09:17:23 UTC (rev 132048)
@@ -3180,6 +3180,8 @@
 m_client->didInvalidateRect(damagedRect);
 }
 }
+if (m_pageOverlays)
+m_pageOverlays->update();
 }
 
 void WebViewImpl::configureAutoResizeMode()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132049] branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp

2012-10-22 Thread caseq

Title: [132049] branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp








Revision 132049
Author ca...@chromium.org
Date 2012-10-22 02:20:42 -0700 (Mon, 22 Oct 2012)


Log Message
Merge 129511 - [chromium] adding a page overlay causes endless update loop when accelerated compositing is used
https://bugs.webkit.org/show_bug.cgi?id=97466

Reviewed by James Robinson.

Do not update overlays in composite() -- doing so ultimately causes invalidation
of the view, hence another update and another call do composite(). Overlays should be
updated only when their content changes.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):

TBR=ca...@chromium.org
Review URL: https://codereview.chromium.org/11235025

Modified Paths

branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp




Diff

Modified: branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp (132048 => 132049)

--- branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-22 09:17:23 UTC (rev 132048)
+++ branches/chromium/1271/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-10-22 09:20:42 UTC (rev 132049)
@@ -1807,9 +1807,6 @@
 if (!page())
 return;
 
-if (m_pageOverlays)
-m_pageOverlays->update();
-
 m_layerTreeView->composite();
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132088] trunk

2012-10-22 Thread caseq

Title: [132088] trunk








Revision 132088
Author ca...@chromium.org
Date 2012-10-22 10:16:54 -0700 (Mon, 22 Oct 2012)


Log Message
Web Inspector: add timeline instrumentation for scrolling of a layer
https://bugs.webkit.org/show_bug.cgi?id=99461

Reviewed by Pavel Feldman.

Source/WebCore:

- added timeline instrumentation for scrolling of a layer;
- added TRACE_EVENT for ScrollableArea::scrollPositionChanged()

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willScrollLayerImpl):
(WebCore::InspectorInstrumentation::didScrollLayerImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore):
(WebCore::InspectorInstrumentation::didScrollLayer):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willScroll):
(WebCore):
(WebCore::InspectorTimelineAgent::didScroll):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):

LayoutTests:

- added Scroll record type;

* inspector/timeline/timeline-enum-stability-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/front-end/TimelineModel.js
trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js
trunk/Source/WebCore/platform/ScrollableArea.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (132087 => 132088)

--- trunk/LayoutTests/ChangeLog	2012-10-22 17:05:53 UTC (rev 132087)
+++ trunk/LayoutTests/ChangeLog	2012-10-22 17:16:54 UTC (rev 132088)
@@ -1,3 +1,14 @@
+2012-10-16  Andrey Kosyakov  
+
+Web Inspector: add timeline instrumentation for scrolling of a layer
+https://bugs.webkit.org/show_bug.cgi?id=99461
+
+Reviewed by Pavel Feldman.
+
+- added Scroll record type;
+
+* inspector/timeline/timeline-enum-stability-expected.txt:
+
 2012-10-22  Vsevolod Vlasov  
 
 Web Inspector: Prepare mappings to moving uiSourceCodes creation out of them to workspace.


Modified: trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt (132087 => 132088)

--- trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2012-10-22 17:05:53 UTC (rev 132087)
+++ trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt	2012-10-22 17:16:54 UTC (rev 132088)
@@ -29,6 +29,7 @@
 Root : "Root"
 ScheduleResourceRequest : "ScheduleResourceRequest"
 ScheduleStyleRecalculation : "ScheduleStyleRecalculation"
+ScrollLayer : "ScrollLayer"
 Time : "Time"
 TimeEnd : "TimeEnd"
 TimeStamp : "TimeStamp"


Modified: trunk/Source/WebCore/ChangeLog (132087 => 132088)

--- trunk/Source/WebCore/ChangeLog	2012-10-22 17:05:53 UTC (rev 132087)
+++ trunk/Source/WebCore/ChangeLog	2012-10-22 17:16:54 UTC (rev 132088)
@@ -1,3 +1,37 @@
+2012-10-16  Andrey Kosyakov  
+
+Web Inspector: add timeline instrumentation for scrolling of a layer
+https://bugs.webkit.org/show_bug.cgi?id=99461
+
+Reviewed by Pavel Feldman.
+
+- added timeline instrumentation for scrolling of a layer;
+- added TRACE_EVENT for ScrollableArea::scrollPositionChanged()
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::willScrollLayerImpl):
+(WebCore::InspectorInstrumentation::didScrollLayerImpl):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+(WebCore::InspectorInstrumentation::willScrollLayer):
+(WebCore):
+(WebCore::InspectorInstrumentation::didScrollLayer):
+* inspector/InspectorTimelineAgent.cpp:
+(TimelineRecordType):
+(WebCore::InspectorTimelineAgent::willScroll):
+(WebCore):
+(WebCore::InspectorTimelineAgent::didScroll):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+* inspector/front-end/TimelineModel.js:
+* inspector/front-end/TimelinePresentationModel.js:
+(WebInspector.TimelinePresentationModel._initRecordStyles):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollTo):
+* platform/ScrollableArea.cpp:
+(WebCore::ScrollableArea::scrollPositionChanged):
+
 2012-10-22  Jan Keromnes  
 
 Moved cmdevtools.j

[webkit-changes] [132239] trunk/Source/WebCore

2012-10-23 Thread caseq

Title: [132239] trunk/Source/WebCore








Revision 132239
Author ca...@chromium.org
Date 2012-10-23 10:06:01 -0700 (Tue, 23 Oct 2012)


Log Message
Web Inspector: paint rectangles are incorrectly shown in case subframes are present
https://bugs.webkit.org/show_bug.cgi?id=99849

Reviewed by Pavel Feldman.

Move GraphicsContext and paint rectangle from willPaint() to didPaint(), so we don't have
to store them as a state of InspectorPageAgent

* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didPaint):
* inspector/InspectorPageAgent.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/TimelineRecordFactory.cpp:
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (132238 => 132239)

--- trunk/Source/WebCore/ChangeLog	2012-10-23 17:04:39 UTC (rev 132238)
+++ trunk/Source/WebCore/ChangeLog	2012-10-23 17:06:01 UTC (rev 132239)
@@ -1,3 +1,37 @@
+2012-10-22  Andrey Kosyakov  
+
+Web Inspector: paint rectangles are incorrectly shown in case subframes are present
+https://bugs.webkit.org/show_bug.cgi?id=99849
+
+Reviewed by Pavel Feldman.
+
+Move GraphicsContext and paint rectangle from willPaint() to didPaint(), so we don't have
+to store them as a state of InspectorPageAgent
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore):
+(WebCore::InspectorInstrumentation::willPaintImpl):
+(WebCore::InspectorInstrumentation::didPaintImpl):
+* inspector/InspectorInstrumentation.h:
+(InspectorInstrumentation):
+(WebCore::InspectorInstrumentation::willPaint):
+(WebCore::InspectorInstrumentation::didPaint):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::didPaint):
+* inspector/InspectorPageAgent.h:
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::willPaint):
+(WebCore::InspectorTimelineAgent::didPaint):
+* inspector/InspectorTimelineAgent.h:
+(InspectorTimelineAgent):
+* inspector/TimelineRecordFactory.cpp:
+* inspector/TimelineRecordFactory.h:
+(TimelineRecordFactory):
+* page/FrameView.cpp:
+(WebCore::FrameView::paintContents):
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintContents):
+
 2012-10-23  Pavel Feldman  
 
 Web Inspector: array grouping does not work for arrays with exactly 1 elements.


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (132238 => 132239)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2012-10-23 17:04:39 UTC (rev 132238)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2012-10-23 17:06:01 UTC (rev 132239)
@@ -494,25 +494,22 @@
 timelineAgent->didDispatchXHRLoadEvent();
 }
 
-InspectorInstrumentationCookie InspectorInstrumentation::willPaintImpl(InstrumentingAgents* instrumentingAgents, GraphicsContext* context, const LayoutRect& rect, Frame* frame)
+InspectorInstrumentationCookie InspectorInstrumentation::willPaintImpl(InstrumentingAgents* instrumentingAgents, Frame* frame)
 {
-if (InspectorPageAgent* pageAgent = instrumentingAgents->inspectorPageAgent())
-pageAgent->willPaint(context, rect);
-
 int timelineAgentId = 0;
 if (InspectorTimelineAgent* timelineAgent = instrumentingAgents->inspectorTimelineAgent()) {
-timelineAgent->willPaint(rect, frame);
+timelineAgent->willPaint(frame);
 timelineAgentId = timelineAgent->id();
 }
 return InspectorInstrumentationCookie(instrumentingAgents, timelineAgentId);
 }
 
-void InspectorInstrumentation::didPaintImpl(const InspectorInstrumentationCookie& cookie)
+void InspectorIns

[webkit-changes] [137266] trunk/LayoutTests

2012-12-11 Thread caseq

Title: [137266] trunk/LayoutTests








Revision 137266
Author ca...@chromium.org
Date 2012-12-11 01:15:43 -0800 (Tue, 11 Dec 2012)


Log Message
Web Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without-inspector.html
https://bugs.webkit.org/show_bug.cgi?id=104071

Reviewed by Pavel Feldman.

Extended test by spinning several function for a total of 400ms to provide coverage for sampling profiler.

* inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt
trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html




Diff

Modified: trunk/LayoutTests/ChangeLog (137265 => 137266)

--- trunk/LayoutTests/ChangeLog	2012-12-11 09:11:24 UTC (rev 137265)
+++ trunk/LayoutTests/ChangeLog	2012-12-11 09:15:43 UTC (rev 137266)
@@ -1,3 +1,15 @@
+2012-12-11  Andrey Kosyakov  
+
+Web Inspector: better coverage for inspector/profiler/cpu-profiler-profiling-without-inspector.html
+https://bugs.webkit.org/show_bug.cgi?id=104071
+
+Reviewed by Pavel Feldman.
+
+Extended test by spinning several function for a total of 400ms to provide coverage for sampling profiler.
+
+* inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt:
+* inspector/profiler/cpu-profiler-profiling-without-inspector.html:
+
 2012-12-10  Mihnea Ovidenie  
 
 [CSSRegions] Clean-up style for 2 regions expected results files


Modified: trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt (137265 => 137266)

--- trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt	2012-12-11 09:11:24 UTC (rev 137265)
+++ trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt	2012-12-11 09:15:43 UTC (rev 137266)
@@ -1,6 +1,9 @@
 Tests that CPU profiling works.
 Doesn't open Inspector, uses console.profile
 
+doWork (line 40): ~400ms
+functionA (line 27): ~400ms
+sleep (line 18): ~200ms
+functionB (line 23): ~200ms
+sleep (line 18): ~200ms
 
-Found pageFunction
-


Modified: trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html (137265 => 137266)

--- trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html	2012-12-11 09:11:24 UTC (rev 137265)
+++ trunk/LayoutTests/inspector/profiler/cpu-profiler-profiling-without-inspector.html	2012-12-11 09:15:43 UTC (rev 137266)
@@ -1,77 +1,91 @@
 
 
-
+