[webkit-changes] [295620] trunk/Source
Title: [295620] trunk/Source
Revision 295620
Author d...@apple.com
Date 2022-06-16 18:11:03 -0700 (Thu, 16 Jun 2022)
Log Message
Clean up code that protects volume from being set on iOS
https://bugs.webkit.org/show_bug.cgi?id=241657
Reviewed by Eric Carlson.
The code to protect HTMLMediaElement.volume from being writable is guarded
by some PLATFORM(IOS_FAMILY) tests. Make this a
HAVE(MEDIA_VOLUME_PER_ELEMENT) test so it can be expanded a bit easier.
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::updateVolume):
(WebCore::HTMLMediaElement::cancelPendingTasks):
(WebCore::HTMLMediaElement::mediaVolumeDidChange):
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume):
Canonical link: https://commits.webkit.org/251625@main
Modified Paths
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WTF/wtf/PlatformHave.h (295619 => 295620)
--- trunk/Source/WTF/wtf/PlatformHave.h 2022-06-17 00:51:38 UTC (rev 295619)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2022-06-17 01:11:03 UTC (rev 295620)
@@ -1256,3 +1256,8 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13)
#define HAVE_POWERLOG_TASK_MODE_QUERY 1
#endif
+
+#if !PLATFORM(IOS_FAMILY)
+#define HAVE_MEDIA_VOLUME_PER_ELEMENT 1
+#endif
+
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (295619 => 295620)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-06-17 00:51:38 UTC (rev 295619)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-06-17 01:11:03 UTC (rev 295620)
@@ -3924,7 +3924,7 @@
if (m_volume == volume)
return { };
-#if !PLATFORM(IOS_FAMILY)
+#if HAVE(MEDIA_VOLUME_PER_ELEMENT)
if (volume && processingUserGestureForMedia())
removeBehaviorRestrictionsAfterFirstUserGesture(MediaElementSession::AllRestrictions & ~MediaElementSession::RequireUserGestureToControlControlsManager);
@@ -5610,14 +5610,7 @@
{
if (!m_player)
return;
-#if PLATFORM(IOS_FAMILY)
-// Only the user can change audio volume so update the cached volume and post the changed event.
-float volume = m_player->volume();
-if (m_volume != volume) {
-m_volume = volume;
-scheduleEvent(eventNames().volumechangeEvent);
-}
-#else
+#if HAVE(MEDIA_VOLUME_PER_ELEMENT)
// Avoid recursion when the player reports volume changes.
if (!processingMediaPlayerCallback()) {
m_player->setMuted(effectiveMuted());
@@ -5625,7 +5618,14 @@
}
document().updateIsPlayingMedia();
-#endif // PLATFORM(IOS_FAMILY)
+#else
+// Only the user can change audio volume so update the cached volume and post the changed event.
+float volume = m_player->volume();
+if (m_volume != volume) {
+m_volume = volume;
+scheduleEvent(eventNames().volumechangeEvent);
+}
+#endif
}
void HTMLMediaElement::scheduleUpdatePlayState()
@@ -5817,7 +5817,7 @@
m_resumeTaskCancellationGroup.cancel();
m_seekTaskCancellationGroup.cancel();
m_playbackControlsManagerBehaviorRestrictionsTaskCancellationGroup.cancel();
-#if PLATFORM(IOS_FAMILY)
+#if !HAVE(MEDIA_VOLUME_PER_ELEMENT)
m_volumeRevertTaskCancellationGroup.cancel();
#endif
}
@@ -6071,8 +6071,8 @@
void HTMLMediaElement::mediaVolumeDidChange()
{
-// FIXME: We should try to reconcile this so there's no difference for PLATFORM(IOS_FAMILY).
-#if !PLATFORM(IOS_FAMILY)
+// FIXME: We should try to reconcile this so there's no difference for !HAVE(MEDIA_VOLUME_PER_ELEMENT).
+#if HAVE(MEDIA_VOLUME_PER_ELEMENT)
INFO_LOG(LOGIDENTIFIER);
updateVolume();
#endif
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (295619 => 295620)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2022-06-17 00:51:38 UTC (rev 295619)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2022-06-17 01:11:03 UTC (rev 295620)
@@ -1590,7 +1590,7 @@
void MediaPlayerPrivateAVFoundationObjC::setVolume(float volume)
{
-#if PLATFORM(IOS_FAMILY)
+#if !HAVE(MEDIA_VOLUME_PER_ELEMENT)
UNUSED_PARAM(volume);
return;
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295460] trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
Title: [295460] trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
Revision 295460
Author d...@apple.com
Date 2022-06-10 13:23:56 -0700 (Fri, 10 Jun 2022)
Log Message
Safari crashes anytime any web links on a webpage are clicked on
https://bugs.webkit.org/show_bug.cgi?id=241500
rdar://94655829
Reviewed by Tim Horton.
In some VM scenarios, IOSurfaceAccelerator is not available, which
causes a crash when navigating (creating the back-forward images).
The solution is to check for null after attempting to create the
accelerator.
* Source/WebCore/platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::convertToFormat): Add a null check and bail.
Canonical link: https://commits.webkit.org/251466@main
Modified Paths
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
Diff
Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (295459 => 295460)
--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2022-06-10 19:01:43 UTC (rev 295459)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2022-06-10 20:23:56 UTC (rev 295460)
@@ -462,6 +462,11 @@
if (!accelerator) {
IOSurfaceAcceleratorCreate(nullptr, nullptr, &accelerator);
+if (!accelerator) {
+callback(nullptr);
+return;
+}
+
auto runLoopSource = IOSurfaceAcceleratorGetRunLoopSource(accelerator);
CFRunLoopAddSource(CFRunLoopGetMain(), runLoopSource, kCFRunLoopDefaultMode);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295104] trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Title: [295104] trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Revision 295104
Author d...@apple.com
Date 2022-06-01 13:36:56 -0700 (Wed, 01 Jun 2022)
Log Message
Relax the assertions for min/max unobscured size
https://bugs.webkit.org/show_bug.cgi?id=241083
Reviewed by Tim Horton.
The assertions in _setMinimumUnobscuredSizeOverride and
_setMaximumUnobscuredSizeOverride often trigger when the current bounds are
0. This is handled acceptably, and the assertion is not necessary in that
case.
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _setMinimumUnobscuredSizeOverride:]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
Canonical link: https://commits.webkit.org/251199@main
Modified Paths
trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm (295103 => 295104)
--- trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-06-01 20:17:33 UTC (rev 295103)
+++ trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm 2022-06-01 20:36:56 UTC (rev 295104)
@@ -2865,7 +2865,7 @@
- (void)_setMinimumUnobscuredSizeOverride:(CGSize)size
{
-ASSERT(size.width <= self.bounds.size.width && size.height <= self.bounds.size.height);
+ASSERT((!self.bounds.size.width || size.width <= self.bounds.size.width) && (!self.bounds.size.height || size.height <= self.bounds.size.height));
_minimumUnobscuredSizeOverride = size;
if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::NotResizing)
@@ -2881,7 +2881,7 @@
- (void)_setMaximumUnobscuredSizeOverride:(CGSize)size
{
-ASSERT(size.width <= self.bounds.size.width && size.height <= self.bounds.size.height);
+ASSERT((!self.bounds.size.width || size.width <= self.bounds.size.width) && (!self.bounds.size.height || size.height <= self.bounds.size.height));
_maximumUnobscuredSizeOverride = size;
if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::NotResizing) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293026] trunk
Title: [293026] trunk Revision 293026 Author d...@apple.com Date 2022-04-19 11:07:05 -0700 (Tue, 19 Apr 2022) Log Message Adding GitHub username. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (293025 => 293026) --- trunk/ChangeLog 2022-04-19 18:02:22 UTC (rev 293025) +++ trunk/ChangeLog 2022-04-19 18:07:05 UTC (rev 293026) @@ -1,3 +1,9 @@ +2022-04-19 Dean Jackson + +Adding GitHub username. + +* metadata/contributors.json: + 2022-04-15 Justin Michaud [PGO] Fix build on intel machines Modified: trunk/metadata/contributors.json (293025 => 293026) --- trunk/metadata/contributors.json 2022-04-19 18:02:22 UTC (rev 293025) +++ trunk/metadata/contributors.json 2022-04-19 18:07:05 UTC (rev 293026) @@ -1921,6 +1921,7 @@ "d...@apple.com" ], "expertise" : "Transforms, Transitions, Animations, Filters", + "github" : "grorg", "name" : "Dean Jackson", "nicks" : [ "dino" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290562] trunk/Source/WebCore
Title: [290562] trunk/Source/WebCore Revision 290562 Author d...@apple.com Date 2022-02-27 08:26:51 -0800 (Sun, 27 Feb 2022) Log Message Loading a USDZ url as the main resource renders as garbage https://bugs.webkit.org/show_bug.cgi?id=237240 rdar://88767033 Reviewed by Antoine Quint. We can't render a USD document if the ModelDocument feature is not enabled. * platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::canShowMIMEType): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/MIMETypeRegistry.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (290561 => 290562) --- trunk/Source/WebCore/ChangeLog 2022-02-27 16:17:03 UTC (rev 290561) +++ trunk/Source/WebCore/ChangeLog 2022-02-27 16:26:51 UTC (rev 290562) @@ -1,3 +1,16 @@ +2022-02-27 Dean Jackson + +Loading a USDZ url as the main resource renders as garbage +https://bugs.webkit.org/show_bug.cgi?id=237240 +rdar://88767033 + +Reviewed by Antoine Quint. + +We can't render a USD document if the ModelDocument feature is not enabled. + +* platform/MIMETypeRegistry.cpp: +(WebCore::MIMETypeRegistry::canShowMIMEType): + 2022-02-27 Antoine Quint [css-animations] implicit keyframes should be inserted after explicit keyframes with the same offset Modified: trunk/Source/WebCore/platform/MIMETypeRegistry.cpp (290561 => 290562) --- trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2022-02-27 16:17:03 UTC (rev 290561) +++ trunk/Source/WebCore/platform/MIMETypeRegistry.cpp 2022-02-27 16:26:51 UTC (rev 290562) @@ -28,6 +28,7 @@ #include "MIMETypeRegistry.h" #include "MediaPlayer.h" +#include "RuntimeEnabledFeatures.h" #include "ThreadGlobalData.h" #include #include @@ -667,7 +668,7 @@ #endif #if ENABLE(MODEL_ELEMENT) -if (isSupportedModelMIMEType(mimeType)) +if (isSupportedModelMIMEType(mimeType) && RuntimeEnabledFeatures::sharedFeatures().modelDocumentEnabled()) return true; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290318] trunk/Tools
Title: [290318] trunk/Tools
Revision 290318
Author d...@apple.com
Date 2022-02-22 10:29:17 -0800 (Tue, 22 Feb 2022)
Log Message
Filter some build output from JSC
https://bugs.webkit.org/show_bug.cgi?id=236885
Reviewed by Simon Fraser.
Add some filter rules for recently added output. In particular:
- whatever prints out the build command
- python executables now having the version numbers in the binary
- creating entitlements files
* Scripts/filter-build-webkit:
(shouldIgnoreLine):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/filter-build-webkit
Diff
Modified: trunk/Tools/ChangeLog (290317 => 290318)
--- trunk/Tools/ChangeLog 2022-02-22 18:21:24 UTC (rev 290317)
+++ trunk/Tools/ChangeLog 2022-02-22 18:29:17 UTC (rev 290318)
@@ -1,3 +1,18 @@
+2022-02-22 Dean Jackson
+
+Filter some build output from JSC
+https://bugs.webkit.org/show_bug.cgi?id=236885
+
+Reviewed by Simon Fraser.
+
+Add some filter rules for recently added output. In particular:
+- whatever prints out the build command
+- python executables now having the version numbers in the binary
+- creating entitlements files
+
+* Scripts/filter-build-webkit:
+(shouldIgnoreLine):
+
2022-02-22 Aditya Keerthi
[iOS] Adopt new _UITextSearching method for range comparison
Modified: trunk/Tools/Scripts/filter-build-webkit (290317 => 290318)
--- trunk/Tools/Scripts/filter-build-webkit 2022-02-22 18:21:24 UTC (rev 290317)
+++ trunk/Tools/Scripts/filter-build-webkit 2022-02-22 18:29:17 UTC (rev 290318)
@@ -169,8 +169,8 @@
} elsif ($line =~ /^cp (\S+)/) {
my $path = basename($1);
printLine("cp $path", STYLE_PLAIN);
-} elsif ($line =~ /python (\S+\.py) (\S+)/) {
-my ($command, $path) = (basename($1), basename($2));
+} elsif ($line =~ /python(\d\.\d+)? (\S+) (.+)/) {
+my ($command, $path) = (basename($2), basename($3));
printLine("python $command $path", STYLE_PLAIN);
} elsif ($line =~ /^\/\S+?(strip|WebCoreExportFileGenerator) .*?(\/|\> )(\S+)/) {
my ($command, $path) = (basename($1), basename($3));
@@ -220,6 +220,13 @@
} elsif ($line =~ /^(\S+\/cc).*?(\S+)\.(out|exp)/) {
my ($command, $path) = (basename($1), basename($2));
printLine("$command $path", STYLE_PLAIN);
+} elsif ($line =~ /^(File Doesn't Exist, Will Create:)(.*\.entitlements)$/) {
+my $path = basename($2);
+printLine("Creating Entitlements File $path", STYLE_PLAIN);
+} elsif ($line =~ /^(building \S+)$/) {
+printLine("$1", STYLE_PLAIN);
+} elsif ($line =~ /^(running build command .*+)$/) {
+printLine("$1", STYLE_PLAIN);
} else {
# This only gets hit if stderr is redirected to stdout.
if (($line =~ /\*\* BUILD FAILED \*\*/) || ($line =~ /^Build FAILED./)) {
@@ -371,6 +378,7 @@
return 1 if $line =~ /^Making app bundle launchable/;
return 1 if $line =~ /^Finished adding entitlements\.$/;
return 1 if $line =~ /^.* will not be code signed because its settings don't specify a development team.$/;
+return 1 if $line =~ /^Initializing Plist...$/;
if ($platform eq "win") {
return 1 if $line =~ /^\s*(touch|perl|cat|rm -f|del|python|\/usr\/bin\/g\+\+|gperf|echo|sed|if \[ \-f|WebCore\/generate-export-file) /;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290209] trunk
Title: [290209] trunk
Revision 290209
Author d...@apple.com
Date 2022-02-19 09:43:14 -0800 (Sat, 19 Feb 2022)
Log Message
[JSC] Implement Temporal.PlainDate
https://bugs.webkit.org/show_bug.cgi?id=230033
Reviewed by Yusuke Suzuki.
JSTests:
Some basic tests for PlainDate.
* stress/temporal-plaindate.js: Added.
(shouldBe):
(shouldThrow):
(shouldBe.String.Temporal.PlainDate.from):
(let.text.of.failures.shouldThrow):
Source/_javascript_Core:
Implement the constructor, `from` and `compare` for Temporal.PlainDate.
This is only a partial implementation, because `from` doesn't
support object parameters, and the `compare` function creates some
internally. However, it is a start!
* DerivedSources-input.xcfilelist: Add new files.
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* heap/Heap.cpp: Create the temporalPlainDateSpace.
* heap/Heap.h:
* heap/HeapSubspaceTypes.h:
* runtime/ISO8601.cpp:
(JSC::ISO8601::daysInMonth): Make this publicly visible.
(JSC::ISO8601::temporalDateToString): New method for printing a date.
* runtime/ISO8601.h:
* runtime/JSGlobalObject.cpp: Make the m_plainDateStructure object.
(JSC::JSGlobalObject::init):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::plainDateStructure):
* runtime/TemporalObject.cpp: Add the PlainDate constructor.
(JSC::createPlainDateConstructor):
* runtime/TemporalObject.h:
* runtime/TemporalPlainDate.cpp: Added.
(JSC::TemporalPlainDate::create):
(JSC::TemporalPlainDate::createStructure):
(JSC::TemporalPlainDate::TemporalPlainDate):
(JSC::TemporalPlainDate::finishCreation):
(JSC::TemporalPlainDate::visitChildrenImpl):
(JSC::toPlainDate):
(JSC::TemporalPlainDate::tryCreateIfValid):
(JSC::TemporalPlainDate::toString const):
(JSC::TemporalPlainDate::from):
(JSC::TemporalPlainDate::compare):
* runtime/TemporalPlainDate.h: Added.
* runtime/TemporalPlainDateConstructor.cpp: Added.
(JSC::TemporalPlainDateConstructor::create):
(JSC::TemporalPlainDateConstructor::createStructure):
(JSC::TemporalPlainDateConstructor::TemporalPlainDateConstructor):
(JSC::TemporalPlainDateConstructor::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):
* runtime/TemporalPlainDateConstructor.h: Added.
* runtime/TemporalPlainDatePrototype.cpp: Added.
(JSC::TemporalPlainDatePrototype::create):
(JSC::TemporalPlainDatePrototype::createStructure):
(JSC::TemporalPlainDatePrototype::TemporalPlainDatePrototype):
(JSC::TemporalPlainDatePrototype::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSC_DEFINE_CUSTOM_GETTER):
* runtime/TemporalPlainDatePrototype.h: Added.
* runtime/VM.h: Define the temporalPlainDateSpace.
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/DerivedSources-input.xcfilelist
trunk/Source/_javascript_Core/DerivedSources-output.xcfilelist
trunk/Source/_javascript_Core/DerivedSources.make
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/HeapSubspaceTypes.h
trunk/Source/_javascript_Core/runtime/ISO8601.cpp
trunk/Source/_javascript_Core/runtime/ISO8601.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/runtime/TemporalObject.cpp
trunk/Source/_javascript_Core/runtime/TemporalObject.h
Added Paths
trunk/JSTests/stress/temporal-plaindate.js
trunk/Source/_javascript_Core/runtime/TemporalPlainDate.cpp
trunk/Source/_javascript_Core/runtime/TemporalPlainDate.h
trunk/Source/_javascript_Core/runtime/TemporalPlainDateConstructor.cpp
trunk/Source/_javascript_Core/runtime/TemporalPlainDateConstructor.h
trunk/Source/_javascript_Core/runtime/TemporalPlainDatePrototype.cpp
trunk/Source/_javascript_Core/runtime/TemporalPlainDatePrototype.h
Diff
Modified: trunk/JSTests/ChangeLog (290208 => 290209)
--- trunk/JSTests/ChangeLog 2022-02-19 17:31:44 UTC (rev 290208)
+++ trunk/JSTests/ChangeLog 2022-02-19 17:43:14 UTC (rev 290209)
@@ -1,3 +1,19 @@
+2022-02-19 Dean Jackson
+
+[JSC] Implement Temporal.PlainDate
+https://bugs.webkit.org/show_bug.cgi?id=230033
+
+
+Reviewed by Yusuke Suzuki.
+
+Some basic tests for PlainDate.
+
+* stress/temporal-plaindate.js: Added.
+(shouldBe):
+(shouldThrow):
+(shouldBe.String.Temporal.PlainDate.from):
+(let.text.of.failures.shouldThrow):
+
2022-02-17 Mikhail R. Gadelha
[32bit] Increase fixedExecutableMemoryPoolSize on ARM to 32MB
Added: trunk/JSTests/stress/temporal-plaindate.js (0 => 290209)
--- trunk/JSTests/stress/temporal-plaindate.js (rev 0)
+++ trunk/JSTests/stress/temporal-plaindate.js 2022-02-19 17:43:14 UTC (rev 290209)
@@ -0,0 +1,162 @@
+//@ requireOptions("--useTemporal=1")
+
+function shouldBe(actual
[webkit-changes] [290168] trunk/Websites/bugs.webkit.org/template/en/default/ queue.json.tmpl
Title: [290168] trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl
Revision 290168
Author d...@apple.com
Date 2022-02-18 14:01:40 -0800 (Fri, 18 Feb 2022)
Log Message
Revert 290166.
Removed Paths
trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl
Diff
Deleted: trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl (290167 => 290168)
--- trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl 2022-02-18 21:38:57 UTC (rev 290167)
+++ trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl 2022-02-18 22:01:40 UTC (rev 290168)
@@ -1,47 +0,0 @@
-[%# This Source Code Form is subject to the terms of the Mozilla Public
- # License, v. 2.0. If a copy of the MPL was not distributed with this
- # file, You can obtain one at http://mozilla.org/MPL/2.0/.
- #
- # This Source Code Form is "Incompatible With Secondary Licenses", as
- # defined by the Mozilla Public License, v. 2.0. #%]
-
-[% RAWPERL %]
-my @display_columns = ('requester', 'requestee', 'type', 'created', 'category',
- 'restricted', 'bug_id', 'bug_summary', 'attach_id',
- 'attach_summary', 'attach_mimetype', 'attach_ispatch');
-my $requests= $stash->get('requests');
-my $time_filter = $context->filter('time', [ '%Y-%m-%dT%H:%M:%SZ', 'UTC' ]);
-my $mail_filter = $context->filter('email');
-
-my @results;
-foreach my $request (@$requests) {
-my %item = ();
-foreach my $column (@display_columns) {
-my $val;
-if ( $column eq 'created' ) {
-$val = $time_filter->( $request->{$column} );
-}
-elsif ( $column =~ /^requeste/ ) {
-$val = $request->{$column} ? {
-email => $request->{$column}->email
-} : undef;
-}
-elsif ( $column =~ /_id$/ ) {
-$val = $request->{$column} ? 0 + $request->{$column} : undef;
-}
-elsif ( $column =~ /^(restricted|attach_ispatch)$/ ) {
-$val = $request->{$column} ? \1 : \0;
-}
-else {
-$val = $request->{$column};
-}
-$item{$column} = $val;
-}
-push @results, \%item;
-}
-{
-use feature 'state';
-state $json = JSON::XS->new->utf8->ascii;
-$output .= $json->encode( \@results );
-}
-[% END %]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290166] trunk/Websites/bugs.webkit.org/template/en/default/ queue.json.tmpl
Title: [290166] trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl
Revision 290166
Author d...@apple.com
Date 2022-02-18 13:32:03 -0800 (Fri, 18 Feb 2022)
Log Message
Temporarily adding JSON output for request queue to see if it works.
Will remove it immediately after testing.
Unreviewed.
* template/en/default/queue.json.tmpl: Added.
Added Paths
trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl
Diff
Added: trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl (0 => 290166)
--- trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl (rev 0)
+++ trunk/Websites/bugs.webkit.org/template/en/default/queue.json.tmpl 2022-02-18 21:32:03 UTC (rev 290166)
@@ -0,0 +1,47 @@
+[%# This Source Code Form is subject to the terms of the Mozilla Public
+ # License, v. 2.0. If a copy of the MPL was not distributed with this
+ # file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ #
+ # This Source Code Form is "Incompatible With Secondary Licenses", as
+ # defined by the Mozilla Public License, v. 2.0. #%]
+
+[% RAWPERL %]
+my @display_columns = ('requester', 'requestee', 'type', 'created', 'category',
+ 'restricted', 'bug_id', 'bug_summary', 'attach_id',
+ 'attach_summary', 'attach_mimetype', 'attach_ispatch');
+my $requests= $stash->get('requests');
+my $time_filter = $context->filter('time', [ '%Y-%m-%dT%H:%M:%SZ', 'UTC' ]);
+my $mail_filter = $context->filter('email');
+
+my @results;
+foreach my $request (@$requests) {
+my %item = ();
+foreach my $column (@display_columns) {
+my $val;
+if ( $column eq 'created' ) {
+$val = $time_filter->( $request->{$column} );
+}
+elsif ( $column =~ /^requeste/ ) {
+$val = $request->{$column} ? {
+email => $request->{$column}->email
+} : undef;
+}
+elsif ( $column =~ /_id$/ ) {
+$val = $request->{$column} ? 0 + $request->{$column} : undef;
+}
+elsif ( $column =~ /^(restricted|attach_ispatch)$/ ) {
+$val = $request->{$column} ? \1 : \0;
+}
+else {
+$val = $request->{$column};
+}
+$item{$column} = $val;
+}
+push @results, \%item;
+}
+{
+use feature 'state';
+state $json = JSON::XS->new->utf8->ascii;
+$output .= $json->encode( \@results );
+}
+[% END %]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [290087] trunk
Title: [290087] trunk Revision 290087 Author d...@apple.com Date 2022-02-17 16:09:11 -0800 (Thu, 17 Feb 2022) Log Message Source/ThirdParty/ANGLE: Metal ANGLE: vertex array does not correctly observe contents of data buffers https://bugs.webkit.org/show_bug.cgi?id=236733 Patch by Kyle Piddington on 2022-02-17 Reviewed by Dean Jackson. Similar to previous bug (236427), we were not correctly observing changes to the vertex buffer data. This caused us to miss rebinding vertex buffers when data was updated without causing conversion * src/libANGLE/renderer/metal/VertexArrayMtl.h: * src/libANGLE/renderer/metal/VertexArrayMtl.mm: (rx::VertexArrayMtl::syncState): (rx::VertexArrayMtl::setupDraw): (rx::VertexArrayMtl::syncDirtyAttrib): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.h trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/VertexArrayMtl.mm Added Paths trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html Diff Modified: trunk/LayoutTests/ChangeLog (290086 => 290087) --- trunk/LayoutTests/ChangeLog 2022-02-18 00:01:20 UTC (rev 290086) +++ trunk/LayoutTests/ChangeLog 2022-02-18 00:09:11 UTC (rev 290087) @@ -25,6 +25,22 @@ * platform/ios/TestExpectations: Mark tests as failing. +2022-02-17 Kyle Piddington + +Metal ANGLE: vertex array does not correctly observe contents of data buffers +https://bugs.webkit.org/show_bug.cgi?id=236733 + + + +Reviewed by Dean Jackson. + +Similar to previous bug (236427), we were not correctly observing changes to the +vertex buffer data. This caused us to miss rebinding vertex buffers +when data was updated without causing conversion + +* fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html: Added. +* fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt: Added. + 2022-02-17 Matteo Flores [css-grid] Incorrectly stretched SVGs without an aspect-ratio. Added: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt (0 => 290087) --- trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt 2022-02-18 00:09:11 UTC (rev 290087) @@ -0,0 +1,14 @@ + Checks that update-draws of bufferSubData are respected + +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS gl.getError() is gl.NO_ERROR +PASS top-left of canvas should be green. +PASS bottom-left of canvas should be green. +PASS Top-right of canvas should be green. +PASS bottom-right of canvas should be green. +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer-expected.txt ___ Added: svn:eol-style +native \ No newline at end of property Added: svn:keywords +Date Revision \ No newline at end of property Added: svn:mime-type +text/plain \ No newline at end of property Added: trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html (0 => 290087) --- trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/buffer-data-subdata-dynamic-buffer.html 2022-02-18 00:09:11 UTC (rev 290087) @@ -0,0 +1,96 @@ + + + + + + + + + +