[webkit-changes] [182791] trunk/Tools

2015-04-14 Thread dominik . rottsches
Title: [182791] trunk/Tools








Revision 182791
Author dominik.rottsc...@intel.com
Date 2015-04-14 04:27:44 -0700 (Tue, 14 Apr 2015)


Log Message
Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
https://bugs.webkit.org/show_bug.cgi?id=143705

Unreviewed change to watchlist file.


* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (182790 => 182791)

--- trunk/Tools/ChangeLog	2015-04-14 11:01:09 UTC (rev 182790)
+++ trunk/Tools/ChangeLog	2015-04-14 11:27:44 UTC (rev 182791)
@@ -1,3 +1,12 @@
+2015-04-14  Dominik Röttsches  
+
+Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
+https://bugs.webkit.org/show_bug.cgi?id=143705
+
+Unreviewed change to watchlist file.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2015-04-14  KwangHyuk Kim  
 
 [EFL] favicon wasn't updated for google.com sometimes.


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (182790 => 182791)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-04-14 11:01:09 UTC (rev 182790)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-04-14 11:27:44 UTC (rev 182791)
@@ -222,12 +222,6 @@
 "filename": r"Source/WebCore/accessibility"
 r"|LayoutTests/.*accessibility",
 },
-"Cairo": {
-"filename": r"Source/WebCore/platform/graphics/cairo",
-},
-"Harfbuzz": {
-"filename": r"Source/WebCore/platform/graphics/harfbuzz",
-},
 "PerformanceTests": {
 "filename": r"PerformanceTests"
 r"|Tools/Scripts/webkitpy/performance_tests",
@@ -334,7 +328,6 @@
 "AppleMacPublicApi": [ "timo...@apple.com" ],
 "Battery": [ "gyuyoung@webkit.org", "dch...@gmail.com" ],
 "BindingsScripts": [ "dch...@gmail.com", "cgar...@igalia.com" ],
-"Cairo": [ "dominik.rottsc...@intel.com" ],
 "CMake": [ "rak...@webkit.org", "gyuyoung@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org" ],
 "CoordinatedGraphics" : [ "n...@webkit.org", "z...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "ryuan.c...@gmail.com", "sergio.corr...@openbossa.org", "gyuyoung@webkit.org" ],
 "ConsoleUsage" : [ "mk...@chromium.org" ],
@@ -357,7 +350,6 @@
 "GStreamerGraphics": [ "ale...@webkit.org", "pnorm...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "cgar...@igalia.com", "calva...@igalia.com", "vjaq...@igalia.com", "ago...@igalia.com" ],
 "GStreamerAudio": [ "pnorm...@igalia.com", "dch...@gmail.com", "sergio.corr...@openbossa.org", "calva...@igalia.com", "vjaq...@igalia.com", "ago...@igalia.com" ],
 "GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org", "be...@igalia.com" ],
-"Harfbuzz": [ "dominik.rottsc...@intel.com" ],
 "HTML": [ "esprehn+aut...@chromium.org", "gyuyoung@webkit.org" ],
 "IndexedDB": [ "alecfl...@chromium.org", "jsb...@chromium.org" ],
 "Loader": [ "jap...@chromium.org" ],
@@ -373,7 +365,7 @@
 "RegionsDevelopment|RegionsExpectationsMore|RegionsExpectationsLess|RegionsUsage": [ "webkitbugtrac...@adobe.com" ],
 "Rendering": [ "esprehn+aut...@chromium.org", "gl...@skynav.com", "kondapallykal...@gmail.com" ],
 "RenderLayers" : [ "simon.fra...@apple.com", "kondapallykal...@gmail.com" ],
-"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org", "dominik.rottsc...@intel.com", "gyuyoung@webkit.org", "sergio.corr...@openbossa.org" ],
+"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org", "gyuyoung@webkit.org", "sergio.corr...@openbossa.org" ],
 "SVNScripts": [ "dba...@webkit.org" ],
 "ScrollingCoordinator": [ "jam...@chromium.org", "toniki...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org" ],
 "Selectors": [ "allan.jen...@digia.com" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [151219] trunk/Tools

2013-06-05 Thread dominik . rottsches
Title: [151219] trunk/Tools








Revision 151219
Author dominik.rottsc...@intel.com
Date 2013-06-05 06:33:03 -0700 (Wed, 05 Jun 2013)


Log Message
Unreviewed name fix after r150662

My firstname got duplicated when fixing bug 116737.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (151218 => 151219)

--- trunk/Tools/ChangeLog	2013-06-05 12:49:14 UTC (rev 151218)
+++ trunk/Tools/ChangeLog	2013-06-05 13:33:03 UTC (rev 151219)
@@ -1,3 +1,11 @@
+2013-06-05  Dominik Röttsches  
+
+Unreviewed name fix after r150662
+
+My firstname got duplicated when fixing bug 116737.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2013-06-05  Raphael Kubo da Costa  
 
 Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (151218 => 151219)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2013-06-05 12:49:14 UTC (rev 151218)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2013-06-05 13:33:03 UTC (rev 151219)
@@ -634,7 +634,7 @@
 "dmazzoni"
  ]
   },
-  "Dominik Dominik R\u00f6ttsches" : {
+  "Dominik R\u00f6ttsches" : {
  "emails" : [
 "dominik.rottsc...@intel.com",
 "d...@roettsches.de"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [150181] trunk/Tools

2013-05-16 Thread dominik . rottsches
Title: [150181] trunk/Tools








Revision 150181
Author dominik.rottsc...@intel.com
Date 2013-05-16 05:49:23 -0700 (Thu, 16 May 2013)


Log Message
[EFL] Remove Intel Wk2 Buildbots from Master
https://bugs.webkit.org/show_bug.cgi?id=116149

Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
since Gyuyoung Kim from Samsung plans to take over and maintain it.

Reviewed by Benjamin Poulain.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (150180 => 150181)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2013-05-16 10:07:01 UTC (rev 150180)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2013-05-16 12:49:23 UTC (rev 150181)
@@ -52,8 +52,6 @@
 { "name": "efl-linux-slave-1", "platform": "efl" },
 { "name": "efl-linux-slave-2", "platform": "efl" },
 { "name": "efl-linux-slave-3", "platform": "efl" },
-{ "name": "efl-linux-slave-4", "platform": "efl" },
-{ "name": "efl-linux-perf-1", "platform": "efl" },
 
 { "name": "mips-1", "platform": "qt-mipsel"},
 
@@ -251,19 +249,9 @@
   "slavenames": ["efl-linux-slave-2"]
 },
 {
-  "name": "EFL Linux 64-bit Debug WK2", "type": "BuildAndTestWebKit2Only", "builddir": "efl-linux-64-debug-wk2",
-  "platform": "efl", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["efl-linux-slave-4"]
-},
-{
   "name": "EFL Linux 32-bit Release (Build)", "type": "Build", "builddir": "efl-linux-32-release",
   "platform": "efl", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["efl-linux-slave-3"]
-},
-{
-  "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTestWebKit2", "builddir": "efl-linux-64-release-wk2-perf",
-  "platform": "efl", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["efl-linux-perf-1"]
 }
   ],
 
@@ -273,8 +261,7 @@
"Qt Linux 64-bit Release (WebKit2 Perf)", "Qt Linux ARMv7 Release", "Qt Linux MIPS32R2 LE Release",
"Qt Linux SH4 Release",
"Qt Windows 32-bit Release", "Qt Windows 32-bit Debug", "Qt Mountain Lion Release",
-   "EFL Linux 64-bit Release", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)", "EFL Linux 64-bit Debug WK2",
-   "EFL Linux 64-bit Release WK2 (Perf)",
+   "EFL Linux 64-bit Release", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)",
"WinCairo Release", "WinCE Release (Build)"]
 },
 { "type": "PlatformSpecificScheduler", "platform": "mac-lion", "branch": "trunk", "treeStableTimer": 45.0,


Modified: trunk/Tools/ChangeLog (150180 => 150181)

--- trunk/Tools/ChangeLog	2013-05-16 10:07:01 UTC (rev 150180)
+++ trunk/Tools/ChangeLog	2013-05-16 12:49:23 UTC (rev 150181)
@@ -1,3 +1,15 @@
+2013-05-15  Dominik Röttsches  
+
+[EFL] Remove Intel Wk2 Buildbots from Master
+https://bugs.webkit.org/show_bug.cgi?id=116149
+
+Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
+since Gyuyoung Kim from Samsung plans to take over and maintain it.
+
+Reviewed by Benjamin Poulain.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2013-05-15  Brent Fulgham  
 
 [Windows] Update various build tools to understand VS2010 environment.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [148606] trunk/LayoutTests

2013-04-17 Thread dominik . rottsches
Title: [148606] trunk/LayoutTests








Revision 148606
Author dominik.rottsc...@intel.com
Date 2013-04-17 06:42:04 -0700 (Wed, 17 Apr 2013)


Log Message
[EFL] Unreviewed Gardening.

Marking compositing reftests added in r148172 as failing.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (148605 => 148606)

--- trunk/LayoutTests/ChangeLog	2013-04-17 13:29:40 UTC (rev 148605)
+++ trunk/LayoutTests/ChangeLog	2013-04-17 13:42:04 UTC (rev 148606)
@@ -1,3 +1,11 @@
+2013-04-17  Dominik Röttsches  
+
+[EFL] Unreviewed Gardening.
+
+Marking compositing reftests added in r148172 as failing.
+
+* platform/efl/TestExpectations:
+
 2013-04-17  Allan Sandfeld Jensen  
 
 [Qt] Unskip tests requiring SUBPIXEL_LAYOUT 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (148605 => 148606)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-04-17 13:29:40 UTC (rev 148605)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-04-17 13:42:04 UTC (rev 148606)
@@ -1976,4 +1976,10 @@
 webkit.org/b/106507 storage/indexeddb/database-quota.html [ Failure ]
 webkit.org/b/107194 storage/indexeddb/pending-activity-workers.html [ Failure ]
 
+# Compositing reftests added in r148172 fail on EFL
+webkit.org/b/114739 compositing/patterns/direct-pattern-compositing-contain.html [ Failure ]
+webkit.org/b/114739 compositing/patterns/direct-pattern-compositing-cover.html [ Failure ]
+webkit.org/b/114739 compositing/patterns/direct-pattern-compositing-padding.html [ Failure ]
+webkit.org/b/114739 compositing/patterns/direct-pattern-compositing-position.html [ Failure ]
+webkit.org/b/114739 compositing/patterns/direct-pattern-compositing-size.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [148602] trunk/LayoutTests

2013-04-17 Thread dominik . rottsches
Title: [148602] trunk/LayoutTests








Revision 148602
Author dominik.rottsc...@intel.com
Date 2013-04-17 05:37:13 -0700 (Wed, 17 Apr 2013)


Log Message
[Qt] Unreviewed gardening. Cleaning up unneeded expecteds after r148596.

Patch by Zoltan Arvai  on 2013-04-17

* platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Removed.
* platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Removed.
* platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Removed.
* platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/selection/select-box-expected.png: Removed.
* platform/qt-5.0-wk2/editing/selection/select-box-expected.txt: Removed.
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
* platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
* platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
* platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
* platform/qt-5.0/editing/selection/select-box-expected.png: Removed.
* platform/qt-5.0/editing/selection/select-box-expected.txt: Removed.
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png: Removed.
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Removed.
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Removed.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt: Removed.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt: Removed.
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png: Removed.
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt: Removed.
* platform/qt-5.0/fast/forms/selectlist-minsize-expected.png: Removed.
* platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.

[webkit-changes] [148598] trunk/LayoutTests

2013-04-17 Thread dominik . rottsches
Title: [148598] trunk/LayoutTests








Revision 148598
Author dominik.rottsc...@intel.com
Date 2013-04-17 04:00:27 -0700 (Wed, 17 Apr 2013)


Log Message
[EFL] Unreviewed Gardening.

Marking a lot of WebGL/CoordinatedGraphics related failures
as crashes after r114731, needs to be looked at in bug 114731.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (148597 => 148598)

--- trunk/LayoutTests/ChangeLog	2013-04-17 10:29:24 UTC (rev 148597)
+++ trunk/LayoutTests/ChangeLog	2013-04-17 11:00:27 UTC (rev 148598)
@@ -1,3 +1,12 @@
+2013-04-17  Dominik Röttsches  
+
+[EFL] Unreviewed Gardening.
+
+Marking a lot of WebGL/CoordinatedGraphics related failures
+as crashes after r114731, needs to be looked at in bug 114731.
+
+* platform/efl/TestExpectations:
+
 2013-04-17  Claudio Saavedra  
 
 execCommand("RemoveFormat") might remove format after the selection


Modified: trunk/LayoutTests/platform/efl/TestExpectations (148597 => 148598)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-04-17 10:29:24 UTC (rev 148597)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-04-17 11:00:27 UTC (rev 148598)
@@ -642,6 +642,136 @@
 
 webkit.org/b/111521 editing/selection/selection-invalid-offset.html [ Crash Pass ]
 
+webkit.org/b/114731 compositing/backface-visibility/backface-visibility-image.html [ Crash ]
+webkit.org/b/114731 compositing/backface-visibility/backface-visibility-webgl.html [ Crash ]
+webkit.org/b/114731 compositing/color-matching/pdf-image-match.html [ Crash ]
+webkit.org/b/114731 compositing/culling/translated-boxshadow.html [ Crash ]
+webkit.org/b/114731 compositing/direct-image-compositing.html [ Crash ]
+webkit.org/b/114731 compositing/images/content-image.html [ Crash ]
+webkit.org/b/114731 compositing/masks/layer-mask-placement.html [ Crash ]
+webkit.org/b/114731 compositing/nested-direct-image-compositing.html [ Crash ]
+webkit.org/b/114731 compositing/reflections/transform-inside-reflection.html [ Crash ]
+webkit.org/b/114731 compositing/visibility/visibility-image-layers-dynamic.html [ Crash ]
+webkit.org/b/114731 compositing/visibility/visibility-image-layers.html [ Crash ]
+webkit.org/b/114731 compositing/webgl/webgl-no-alpha.html [ Crash ]
+webkit.org/b/114731 compositing/webgl/webgl-repaint.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/array-buffer-crash.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/attrib-location-length-limits.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/canvas-2d-webgl-texture.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/canvas-resize-crash.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/canvas-test.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/constants.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/context-lost.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/context-release-upon-reload.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/framebuffer-bindings-unaffected-on-resize.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/framebuffer-test.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/functions-returning-strings.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-enable-enum-test.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-enum-tests.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-get-calls.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-getshadersource.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-getstring.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-pixelstorei.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-teximage.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-uniform-arrays.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-uniformmatrix4fv.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-vertex-attrib-zero-issues.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-vertex-attrib.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/gl-vertexattribpointer.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/glsl-conformance.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/index-validation.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/instanceof-test.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/is-object.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/oes-element-index-uint.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/oes-texture-half-float.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/oes-vertex-array-object.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/point-size.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/program-test.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/read-pixels-pack-alignment.html [ Crash ]
+webkit.org/b/114731 fast/canvas/webgl/renderbuffer-ini

[webkit-changes] [146980] trunk

2013-03-27 Thread dominik . rottsches
Title: [146980] trunk








Revision 146980
Author dominik.rottsc...@intel.com
Date 2013-03-27 07:18:33 -0700 (Wed, 27 Mar 2013)


Log Message
Unreviewed, rolling out r146864.
http://trac.webkit.org/changeset/146864
https://bugs.webkit.org/show_bug.cgi?id=113391

causes crashes on Wk2 EFL release bot (Requested by drott on
#webkit).

Patch by Sheriff Bot  on 2013-03-27

.:

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* platform/efl/TestExpectations:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/ChangeLog (146979 => 146980)

--- trunk/ChangeLog	2013-03-27 14:14:37 UTC (rev 146979)
+++ trunk/ChangeLog	2013-03-27 14:18:33 UTC (rev 146980)
@@ -1,3 +1,14 @@
+2013-03-27  Sheriff Bot  
+
+Unreviewed, rolling out r146864.
+http://trac.webkit.org/changeset/146864
+https://bugs.webkit.org/show_bug.cgi?id=113391
+
+causes crashes on Wk2 EFL release bot (Requested by drott on
+#webkit).
+
+* Source/cmake/OptionsEfl.cmake:
+
 2013-03-26  Rijubrata Bhaumik  
 
 [EFL] Enable IndexedDB by default


Modified: trunk/LayoutTests/ChangeLog (146979 => 146980)

--- trunk/LayoutTests/ChangeLog	2013-03-27 14:14:37 UTC (rev 146979)
+++ trunk/LayoutTests/ChangeLog	2013-03-27 14:18:33 UTC (rev 146980)
@@ -1,3 +1,14 @@
+2013-03-27  Sheriff Bot  
+
+Unreviewed, rolling out r146864.
+http://trac.webkit.org/changeset/146864
+https://bugs.webkit.org/show_bug.cgi?id=113391
+
+causes crashes on Wk2 EFL release bot (Requested by drott on
+#webkit).
+
+* platform/efl/TestExpectations:
+
 2013-03-27  Seokju Kwon  
 
 [EFL] Remove a duplicated test from TestExpectations


Modified: trunk/LayoutTests/platform/efl/TestExpectations (146979 => 146980)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-03-27 14:14:37 UTC (rev 146979)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-03-27 14:18:33 UTC (rev 146980)
@@ -781,24 +781,6 @@
 # Fails, test times out in testLoadErrorGC()
 webkit.org/b/78819 fast/workers/shared-worker-load-error.html [ Failure Pass ]
 
-# Crashing IndexedDB tests
-webkit.org/b/112578 storage/indexeddb/transaction-coordination-across-databases.html [ Crash ]
-webkit.org/b/107194 storage/indexeddb/pending-activity.html [ Crash ]
-webkit.org/b/71 storage/indexeddb/objectstore-basics-workers.html [ Crash ]
-webkit.org/b/71 storage/indexeddb/cursor-advance-workers.html [ Crash ]
-webkit.org/b/107377 storage/indexeddb/keypath-edges.html [ Crash ]
-
-# Flaky IndexedDB tests
-webkit.org/b/107194 storage/indexeddb/index-multientry.html [ Failure Pass ]
-webkit.org/b/107194 storage/indexeddb/index-unique.html [ Failure Crash Pass ]
-webkit.org/b/107194 storage/indexeddb/pending-version-change-on-exit.html [ Failure Crash Pass ]
-webkit.org/b/112468 storage/indexeddb/intversion-bad-parameters.html [ Crash Failure Pass ]
-webkit.org/b/107194 storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html [ Failure Pass ]
-webkit.org/b/107194 storage/indexeddb/intversion-close-in-oncomplete.html [ Failure Pass ]
-webkit.org/b/107194 storage/indexeddb/intversion-close-in-upgradeneeded.html [ Failure Pass ]
-webkit.org/b/107194 storage/indexeddb/transaction-abort.html [ Failure Crash Pass ]
-webkit.org/b/107194 storage/indexeddb/key-generator.html [ Failure Pass ]
-
 #
 # PASSING TESTS WITH INCORRECT EXPECTATIONS
 #
@@ -1107,14 +1089,22 @@
 webkit.org/b/84589 fast/events/scroll-event-during-modal-dialog.html [ Failure ]
 webkit.org/b/84589 http/tests/security/cross-frame-access-get.html [ Failure ]
 
-# Quota API is not supported.
-webkit.org/b/106507 storage/storageinfo-missing-arguments.html
-webkit.org/b/106507 storage/storageinfo-no-callbacks.html
-webkit.org/b/106507 storage/storageinfo-query-usage.html
-webkit.org/b/106507 storage/storageinfo-request-quota.html
-webkit.org/b/106507 storage/storagequota-query-usage.html
-webkit.org/b/106507 storage/storagequota-request-quota.html
+# IndexedDB is not yet enabled.
+Bug(EFL) storage/indexeddb
+Bug(EFL) http/tests/inspector/indexeddb
+Bug(EFL) http/tests/security/cross-origin-indexeddb-allowed.html
+Bug(EFL) http/tests/security/cross-origin-indexeddb.html
+Bug(EFL) http/tests/security/cross-origin-worker-indexeddb-allowed.html
+Bug(EFL) http/tests/security/cross-origin-worker-indexeddb.html
+Bug(EFL) http/tests/security/no-indexeddb-from-sandbox.html
 
+# Quota API is not supported.
+Bug(EFL) storage/storageinfo-missing-arguments.html
+Bug(EFL) storage/storageinfo-no-callbacks.html
+Bug(EFL) storage/storageinfo-query-usage.html
+Bug(EFL) stor

[webkit-changes] [146855] trunk/Source/WebCore

2013-03-26 Thread dominik . rottsches
Title: [146855] trunk/Source/WebCore








Revision 146855
Author dominik.rottsc...@intel.com
Date 2013-03-26 00:51:39 -0700 (Tue, 26 Mar 2013)


Log Message
Remove HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=112087

Reviewed by Martin Robinson.

Folding HarfBuzzShaperBase into HarfBuzzShaper since
there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.

No new tests, no change in behavior.

* GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
* PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
* WebCore.gypi: Removing HarfBuzzShaperBase.*
* platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
(WebCore::HarfBuzzShaper::isWordEnd):
(WebCore::HarfBuzzShaper::determineWordBreakSpacing):
(WebCore::HarfBuzzShaper::setPadding):
* platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::isCodepointSpace):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
* platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.h


Removed Paths

trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (146854 => 146855)

--- trunk/Source/WebCore/ChangeLog	2013-03-26 07:33:28 UTC (rev 146854)
+++ trunk/Source/WebCore/ChangeLog	2013-03-26 07:51:39 UTC (rev 146855)
@@ -1,3 +1,32 @@
+2013-03-26  Dominik Röttsches  
+
+Remove HarfBuzzShaperBase
+https://bugs.webkit.org/show_bug.cgi?id=112087
+
+Reviewed by Martin Robinson.
+
+Folding HarfBuzzShaperBase into HarfBuzzShaper since
+there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.
+
+No new tests, no change in behavior.
+
+* GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
+* PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
+* WebCore.gypi: Removing HarfBuzzShaperBase.*
+* platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.
+(WebCore::HarfBuzzShaper::HarfBuzzShaper):
+(WebCore::normalizeSpacesAndMirrorChars):
+(WebCore):
+(WebCore::HarfBuzzShaper::setNormalizedBuffer):
+(WebCore::HarfBuzzShaper::isWordEnd):
+(WebCore::HarfBuzzShaper::determineWordBreakSpacing):
+(WebCore::HarfBuzzShaper::setPadding):
+* platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.
+(HarfBuzzShaper):
+(WebCore::HarfBuzzShaper::isCodepointSpace):
+* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
+* platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.
+
 2013-03-22  Hajime Morrita  
 
 Listening touch events on ShadowRoot can crash.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (146854 => 146855)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-03-26 07:33:28 UTC (rev 146854)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-03-26 07:51:39 UTC (rev 146855)
@@ -4333,8 +4333,6 @@
 	Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp \
 	Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp \
 	Source/WebCore/platform/graphics/freetype/UTF16UChar32Iterator.h \
-	Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp \
-	Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaperBase.h \
 	Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.cpp \
 	Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFace.h \
 	Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp \


Modified: trunk/Source/WebCore/PlatformEfl.cmake (146854 => 146855)

--- trunk/Source/WebCore/PlatformEfl.cmake	2013-03-26 07:33:28 UTC (rev 146854)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2013-03-26 07:51:39 UTC (rev 146855)
@@ -130,7 +130,6 @@
 platform/graphics/gstreamer/VideoSinkGStreamer.cpp
 platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
 
-platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp
 platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp
 platform/graphics/harfbuzz/HarfBuzzFace.cpp
 platform/graphics/harfbuzz/HarfBuzzShaper.cpp


Modified: trunk/Source/WebCore/WebCore.gypi (146854 => 146855)

--- trunk/Source/WebCore/WebCore.gypi	2013-03-26 07:33:28 UTC (rev 146854)
+++ trunk/Source/WebCore/WebCore.gypi	2013-03-26 07:51:39 UTC (rev 146855)
@@ -4234,8 +4234,6 @@
 'platform/graphics/harfb

[webkit-changes] [146778] trunk/Tools

2013-03-25 Thread dominik . rottsches
Title: [146778] trunk/Tools








Revision 146778
Author dominik.rottsc...@intel.com
Date 2013-03-25 09:05:13 -0700 (Mon, 25 Mar 2013)


Log Message
[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
https://bugs.webkit.org/show_bug.cgi?id=112166

HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.

Reviewed by Martin Robinson.

* efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
* efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
* gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
* gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules
trunk/Tools/gtk/jhbuild.modules


Removed Paths

trunk/Tools/efl/patches/harfbuzz-icu-detection-fix.patch
trunk/Tools/gtk/patches/harfbuzz-icu-detection-fix.patch




Diff

Modified: trunk/Tools/ChangeLog (146777 => 146778)

--- trunk/Tools/ChangeLog	2013-03-25 16:01:21 UTC (rev 146777)
+++ trunk/Tools/ChangeLog	2013-03-25 16:05:13 UTC (rev 146778)
@@ -1,3 +1,19 @@
+2013-03-25  Dominik Röttsches  
+
+[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
+https://bugs.webkit.org/show_bug.cgi?id=112166
+
+HarfBuzz 0.9.14 merged my patch for icu detection without
+pkg-config files, as needed by for example Ubuntu 12.04.
+This obsoletes our local workaround. Removed it for GTK and EFL.
+
+Reviewed by Martin Robinson.
+
+* efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
+* efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
+* gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
+* gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
+
 2013-03-22  Kiran Muppala  
 
 Unreviewed.  Move self from contributor to committer list.


Modified: trunk/Tools/efl/jhbuild.modules (146777 => 146778)

--- trunk/Tools/efl/jhbuild.modules	2013-03-25 16:01:21 UTC (rev 146777)
+++ trunk/Tools/efl/jhbuild.modules	2013-03-25 16:05:13 UTC (rev 146778)
@@ -162,12 +162,11 @@
   
 
  
-   +   repo="freedesktop.org"
-   hash="sha256:bd2999859f8828461fedae23e4af52d926ac32a73245f03ae2d2065205e9cf25"
-   md5sum="db5382728a912352633d3be2e2a1d988">
- 
+   hash="sha256:d07c0ffdbbbfdfbb6c65e73fe9c76466e87dbf04b094cbd0abf5fd7d571a4004"
+   md5sum="7e1990b79060e98e2d31f677a0ac9eed">

  
 


Deleted: trunk/Tools/efl/patches/harfbuzz-icu-detection-fix.patch (146777 => 146778)

--- trunk/Tools/efl/patches/harfbuzz-icu-detection-fix.patch	2013-03-25 16:01:21 UTC (rev 146777)
+++ trunk/Tools/efl/patches/harfbuzz-icu-detection-fix.patch	2013-03-25 16:05:13 UTC (rev 146778)
@@ -1,36 +0,0 @@
-diff --git a/configure.ac b/configure.ac
-index b1948f1..9ae69dd 100644
 a/configure.ac
-+++ b/configure.ac
-@@ -184,6 +184,31 @@ fi
- AM_CONDITIONAL(HAVE_ICU_LE, $have_icu_le)
- 
- dnl ==
-+dnl Fallback to icu-config if ICU pkg-config files could not be found
-+dnl ==
-+
-+if test "$have_icu" != "true"; then
-+AC_PATH_PROG(icu_config, icu-config, no)
-+AC_MSG_CHECKING([for ICU by using icu-config fallback])
-+if test "$icu_config" != "no"; then
-+# We don't use --cflags as this gives us a lot of things that we don't
-+# necessarily want, like debugging and optimization flags
-+# See man (1) icu-config for more info.
-+ICU_CFLAGS=`$icu_config --cppflags`
-+ICU_LIBS=`$icu_config --ldflags-libsonly --ldflags-layout`
-+AC_SUBST(ICU_CFLAGS)
-+AC_SUBST(ICU_LIBS)
-+AC_DEFINE(HAVE_ICU_LE, 1, [Have ICU Layout Engine library])
-+AC_DEFINE(HAVE_ICU, 1, [Have ICU library])
-+AM_CONDITIONAL(HAVE_ICU, true)
-+AM_CONDITIONAL(HAVE_ICU_LE, true)
-+AC_MSG_RESULT([yes])
-+else
-+AC_MSG_RESULT([no])
-+fi
-+fi
-+
-+dnl ==
- 
- PKG_CHECK_MODULES(GRAPHITE2, graphite2, have_graphite=true, have_graphite=false)
- if $have_graphite; then


Modified: trunk/Tools/gtk/jhbuild.modules (146777 => 146778)

--- trunk/Tools/gtk/jhbuild.modules	2013-03-25 16:01:21 UTC (rev 146777)
+++ trunk/Tools/gtk/jhbuild.modules	2013-03-25 16:05:13 UTC (rev 146778)
@@ -92,15 +92,14 @@
 md5sum="647ee8ed266f9a4117c8d0a4855b3d3e"/>
   
 
- 
-   
- 
-   
- 
+  
+
+
+  
 
   
 

Deleted: trunk/Tools/gtk/patches/harfbuzz-icu-detection-fix.patch (146777 => 146778)

--- trunk/Tools/gtk/patches/harfbuzz-icu-detection-fix.patch	2013-03-25 16:01:21 UTC (rev 146777)
+++ trunk/Tools/gtk/patches/harfbuzz-icu-detection-fix.patch	2013-03-25 16:05:13 UTC (rev 146778)
@@ -1,

[webkit-changes] [143458] trunk/LayoutTests

2013-02-20 Thread dominik . rottsches
Title: [143458] trunk/LayoutTests








Revision 143458
Author dominik.rottsc...@intel.com
Date 2013-02-20 06:24:57 -0800 (Wed, 20 Feb 2013)


Log Message
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked touch event emulation test as failing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (143457 => 143458)

--- trunk/LayoutTests/ChangeLog	2013-02-20 14:10:05 UTC (rev 143457)
+++ trunk/LayoutTests/ChangeLog	2013-02-20 14:24:57 UTC (rev 143458)
@@ -1,3 +1,9 @@
+2013-02-20  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+* platform/efl/TestExpectations: Marked touch event emulation test as failing.
+
 2013-02-20  Zoltan Arvai  
 
 [Qt] Unreviewed. Correcting gardening after r143436.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (143457 => 143458)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-02-20 14:10:05 UTC (rev 143457)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-02-20 14:24:57 UTC (rev 143458)
@@ -1870,3 +1870,5 @@
 webkit.org/b/110282 fast/regions/seamless-iframe-flowed-into-regions.html [ ImageOnlyFailure ]
 
 webkit.org/b/110316 svg/as-background-image/tiled-background-image.html [ ImageOnlyFailure ]
+
+webkit.org/b/110338 fast/events/touch/emulate-touch-events.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [143442] trunk/LayoutTests

2013-02-20 Thread dominik . rottsches
Title: [143442] trunk/LayoutTests








Revision 143442
Author dominik.rottsc...@intel.com
Date 2013-02-20 02:01:33 -0800 (Wed, 20 Feb 2013)


Log Message
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
* platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (143441 => 143442)

--- trunk/LayoutTests/ChangeLog	2013-02-20 09:58:37 UTC (rev 143441)
+++ trunk/LayoutTests/ChangeLog	2013-02-20 10:01:33 UTC (rev 143442)
@@ -1,3 +1,10 @@
+2013-02-20  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+* platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
+* platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.
+
 2013-02-20  Andrey Lushnikov  
 
 Web Inspector: highlight undefined word in _javascript_


Modified: trunk/LayoutTests/platform/efl/TestExpectations (143441 => 143442)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-02-20 09:58:37 UTC (rev 143441)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-02-20 10:01:33 UTC (rev 143442)
@@ -1868,3 +1868,5 @@
 
 # Failing after r143256.
 webkit.org/b/110282 fast/regions/seamless-iframe-flowed-into-regions.html [ ImageOnlyFailure ]
+
+webkit.org/b/110316 svg/as-background-image/tiled-background-image.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (143441 => 143442)

--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2013-02-20 09:58:37 UTC (rev 143441)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2013-02-20 10:01:33 UTC (rev 143442)
@@ -147,6 +147,7 @@
 PASS MimeTypeArray.toString() is '[object MimeTypeArrayConstructor]'
 PASS MouseEvent.toString() is '[object MouseEventConstructor]'
 PASS MutationEvent.toString() is '[object MutationEventConstructor]'
+PASS MutationObserver.toString() is '[object MutationObserverConstructor]'
 PASS NamedNodeMap.toString() is '[object NamedNodeMapConstructor]'
 PASS Node.toString() is '[object NodeConstructor]'
 PASS NodeFilter.toString() is '[object NodeFilterConstructor]'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [141908] trunk/Source/WebCore

2013-02-05 Thread dominik . rottsches
Title: [141908] trunk/Source/WebCore








Revision 141908
Author dominik.rottsc...@intel.com
Date 2013-02-05 11:38:19 -0800 (Tue, 05 Feb 2013)


Log Message
[HarfBuzz][Cairo] harfBuzzGetGlyph is slow and hot
https://bugs.webkit.org/show_bug.cgi?id=108941

Reviewed by Kenneth Rohde Christiansen.

The text to glyph conversion using Cairo is slow
due to expensive text codec conversion to UTF-8.
Additionally, the glyph lookup itself is expensive.

Inspired by the approach taken in HarfBuzzFaceSkia.cpp
I suggest to implement a similar caching mechanism to
accelerate this conversion.

Arabic line breaking test, under review in
bug 108948 shows about 58% improvement on my system
with this patch.

* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::HarfBuzzFontData::HarfBuzzFontData):
New container structure that keeps pointers
to the cairo scaled font as well as the glyph cache.
(HarfBuzzFontData):
(WebCore):
(WebCore::harfBuzzGetGlyph): Using the new container structure for accessing the cache.
(WebCore::harfBuzzGetGlyphHorizontalAdvance): Using the new container structure for accessing the scaled font.
(WebCore::harfBuzzGetGlyphExtents): Ditto.
(WebCore::destroyHarfBuzzFontData): Destroying the container that held the pointers.
(WebCore::HarfBuzzFace::createFont):
Initializing the container structure with the pointers
to the cache that is held in HarfBuzzFace and the cairo scaled font.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141907 => 141908)

--- trunk/Source/WebCore/ChangeLog	2013-02-05 19:26:52 UTC (rev 141907)
+++ trunk/Source/WebCore/ChangeLog	2013-02-05 19:38:19 UTC (rev 141908)
@@ -1,3 +1,36 @@
+2013-02-05  Dominik Röttsches  
+
+[HarfBuzz][Cairo] harfBuzzGetGlyph is slow and hot
+https://bugs.webkit.org/show_bug.cgi?id=108941
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The text to glyph conversion using Cairo is slow
+due to expensive text codec conversion to UTF-8.
+Additionally, the glyph lookup itself is expensive.
+
+Inspired by the approach taken in HarfBuzzFaceSkia.cpp
+I suggest to implement a similar caching mechanism to
+accelerate this conversion.
+
+Arabic line breaking test, under review in
+bug 108948 shows about 58% improvement on my system
+with this patch.
+
+* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
+(WebCore::HarfBuzzFontData::HarfBuzzFontData):
+New container structure that keeps pointers
+to the cairo scaled font as well as the glyph cache.
+(HarfBuzzFontData):
+(WebCore):
+(WebCore::harfBuzzGetGlyph): Using the new container structure for accessing the cache.
+(WebCore::harfBuzzGetGlyphHorizontalAdvance): Using the new container structure for accessing the scaled font.
+(WebCore::harfBuzzGetGlyphExtents): Ditto.
+(WebCore::destroyHarfBuzzFontData): Destroying the container that held the pointers.
+(WebCore::HarfBuzzFace::createFont):
+Initializing the container structure with the pointers
+to the cache that is held in HarfBuzzFace and the cairo scaled font.
+
 2013-02-05  Tony Gentilcore  
 
 Call XSSAuditor's didBlockScript() for the threaded HTML parser


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp (141907 => 141908)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp	2013-02-05 19:26:52 UTC (rev 141907)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp	2013-02-05 19:38:19 UTC (rev 141908)
@@ -46,6 +46,15 @@
 
 namespace WebCore {
 
+struct HarfBuzzFontData {
+HarfBuzzFontData(WTF::HashMap* glyphCacheForFaceCacheEntry, cairo_scaled_font_t* cairoScaledFont)
+: m_glyphCacheForFaceCacheEntry(glyphCacheForFaceCacheEntry)
+, m_cairoScaledFont(cairoScaledFont)
+{ }
+WTF::HashMap* m_glyphCacheForFaceCacheEntry;
+cairo_scaled_font_t* m_cairoScaledFont;
+};
+
 class CairoFtFaceLocker {
 public:
 CairoFtFaceLocker(cairo_scaled_font_t* cairoScaledFont) : m_scaledFont(cairoScaledFont) { };
@@ -92,26 +101,30 @@
 
 static hb_bool_t harfBuzzGetGlyph(hb_font_t*, void* fontData, hb_codepoint_t unicode, hb_codepoint_t, hb_codepoint_t* glyph, void*)
 {
-FontPlatformData* platformData = reinterpret_cast(fontData);
-cairo_scaled_font_t* scaledFont = platformData->scaledFont();
+HarfBuzzFontData* hbFontData = reinterpret_cast(fontData);
+cairo_scaled_font_t* scaledFont = hbFontData->m_cairoScaledFont;
 ASSERT(scaledFont);
 
-cairo_glyph_t* glyphs = 0;
-int numGlyphs = 0;
-CString utf8Codepoint = UTF8Encoding().encode(reinterpret_cast(&unicode), 1, QuestionMarksForUnencodables);
-if (CAIRO_STATUS_SUCCESS != cairo_scaled_font_text_to_glyphs(scaledFont, 0, 0, utf8Co

[webkit-changes] [141906] trunk/PerformanceTests

2013-02-05 Thread dominik . rottsches
Title: [141906] trunk/PerformanceTests








Revision 141906
Author dominik.rottsc...@intel.com
Date 2013-02-05 11:15:57 -0800 (Tue, 05 Feb 2013)


Log Message
Add a performance test for arabic line breaking
https://bugs.webkit.org/show_bug.cgi?id=108948

Reviewed by Eric Seidel.

Adding a perfomance test based to exercise the complex
font path used in rendering arabic script.

* Layout/ArabicLineLayout.html: Added.
* Skipped: New test skipped by default as per Ryosuke's request.

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped


Added Paths

trunk/PerformanceTests/Layout/ArabicLineLayout.html




Diff

Modified: trunk/PerformanceTests/ChangeLog (141905 => 141906)

--- trunk/PerformanceTests/ChangeLog	2013-02-05 19:06:26 UTC (rev 141905)
+++ trunk/PerformanceTests/ChangeLog	2013-02-05 19:15:57 UTC (rev 141906)
@@ -1,3 +1,16 @@
+2013-02-05  Dominik Röttsches  
+
+Add a performance test for arabic line breaking
+https://bugs.webkit.org/show_bug.cgi?id=108948
+
+Reviewed by Eric Seidel.
+
+Adding a perfomance test based to exercise the complex
+font path used in rendering arabic script.
+
+* Layout/ArabicLineLayout.html: Added.
+* Skipped: New test skipped by default as per Ryosuke's request.
+
 2013-01-23  Yury Semikhatsky  
 
 Web Inspector: some measurements are missing in PerformanceTests/inspector/heap-*.html


Added: trunk/PerformanceTests/Layout/ArabicLineLayout.html (0 => 141906)

--- trunk/PerformanceTests/Layout/ArabicLineLayout.html	(rev 0)
+++ trunk/PerformanceTests/Layout/ArabicLineLayout.html	2013-02-05 19:15:57 UTC (rev 141906)
@@ -0,0 +1,50 @@
+
+
+
+
+Arabic Line breaking performance test
+
+
+
+

+

[webkit-changes] [141778] trunk/Source/WebCore

2013-02-04 Thread dominik . rottsches
Title: [141778] trunk/Source/WebCore








Revision 141778
Author dominik.rottsc...@intel.com
Date 2013-02-04 10:21:25 -0800 (Mon, 04 Feb 2013)


Log Message
[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=108479

Reviewed by Emil A Eklund.

Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.

No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.

* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::offsetForPositionForComplexText):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (141777 => 141778)

--- trunk/Source/WebCore/ChangeLog	2013-02-04 18:19:31 UTC (rev 141777)
+++ trunk/Source/WebCore/ChangeLog	2013-02-04 18:21:25 UTC (rev 141778)
@@ -1,3 +1,19 @@
+2013-02-04  Dominik Röttsches  
+
+[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
+https://bugs.webkit.org/show_bug.cgi?id=108479
+
+Reviewed by Emil A Eklund.
+
+Remove a FIXME that intended to solve the value truncation.
+Should positively affect SVG text positioning.
+
+No new tests, partially covered by manual test
+ManualTests/harfbuzz-mouse-selection-crash.html.
+
+* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
+(WebCore::Font::offsetForPositionForComplexText):
+
 2013-02-04  Vladislav Kaznacheev  
 
 Web Inspector: Create a container class for SidebarPane instances


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp (141777 => 141778)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp	2013-02-04 18:19:31 UTC (rev 141777)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp	2013-02-04 18:21:25 UTC (rev 141778)
@@ -202,14 +202,10 @@
 int Font::offsetForPositionForComplexText(const TextRun& run, float xFloat,
   bool includePartialGlyphs) const
 {
-// FIXME: This truncation is not a problem for HTML, but only affects SVG, which passes floating-point numbers
-// to Font::offsetForPosition(). Bug http://webkit.org/b/40673 tracks fixing this problem.
-int targetX = static_cast(xFloat);
-
 HarfBuzzShaper shaper(this, run);
 if (!shaper.shape())
 return 0;
-return shaper.offsetForPosition(targetX);
+return shaper.offsetForPosition(xFloat);
 }
 
 // Return the rectangle for selecting the given range of code-points in the TextRun.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [141242] trunk/LayoutTests

2013-01-30 Thread dominik . rottsches
Title: [141242] trunk/LayoutTests








Revision 141242
Author dominik.rottsc...@intel.com
Date 2013-01-30 02:52:58 -0800 (Wed, 30 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

More plugin test cases skipped, failing after r141051,
plugins/document-open.html is not crashing, but currently timing out.

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (141241 => 141242)

--- trunk/LayoutTests/ChangeLog	2013-01-30 10:45:58 UTC (rev 141241)
+++ trunk/LayoutTests/ChangeLog	2013-01-30 10:52:58 UTC (rev 141242)
@@ -3,7 +3,16 @@
 [EFL] Unreviewed gardening.
 
 More plugin test cases skipped, failing after r141051,
+plugins/document-open.html is not crashing, but currently timing out.
 
+* platform/efl-wk2/TestExpectations:
+
+2013-01-30  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+More plugin test cases skipped, failing after r141051,
+
 * platform/efl-wk2/TestExpectations: r140999 leads to assertions in two stacking container tests.
 * platform/efl/TestExpectations: r140613 introduced fast/ruby/select-ruby.html - failing on our port.
 


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (141241 => 141242)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-01-30 10:45:58 UTC (rev 141241)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-01-30 10:52:58 UTC (rev 141242)
@@ -48,8 +48,8 @@
 webkit.org/b/92726 fast/dom/register-protocol-handler.html [ Crash ]
 webkit.org/b/92726 fast/dom/unregister-protocol-handler.html [ Crash ]
 
-# Crashes on plugin test.
-webkit.org/b/98747 plugins/document-open.html [ Crash ]
+# Crashes on plugin test, also blocked by 108077
+webkit.org/b/98747 plugins/document-open.html [ Crash Failure ]
 
 webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-download.html [ Crash Failure ]
 webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Crash Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [141239] trunk/LayoutTests

2013-01-30 Thread dominik . rottsches
Title: [141239] trunk/LayoutTests








Revision 141239
Author dominik.rottsc...@intel.com
Date 2013-01-30 02:31:14 -0800 (Wed, 30 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

More plugin test cases skipped, failing after r141051,

* platform/efl-wk2/TestExpectations: r140999 leads to assertions in two stacking container tests.
* platform/efl/TestExpectations: r140613 introduced fast/ruby/select-ruby.html - failing on our port.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (141238 => 141239)

--- trunk/LayoutTests/ChangeLog	2013-01-30 10:20:46 UTC (rev 141238)
+++ trunk/LayoutTests/ChangeLog	2013-01-30 10:31:14 UTC (rev 141239)
@@ -1,3 +1,12 @@
+2013-01-30  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+More plugin test cases skipped, failing after r141051,
+
+* platform/efl-wk2/TestExpectations: r140999 leads to assertions in two stacking container tests.
+* platform/efl/TestExpectations: r140613 introduced fast/ruby/select-ruby.html - failing on our port.
+
 2013-01-29  Shinya Kawanaka  
 
 Renderer is recreated unexpectedly after detach in HTMLInputElement


Modified: trunk/LayoutTests/platform/efl/TestExpectations (141238 => 141239)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-30 10:20:46 UTC (rev 141238)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-30 10:31:14 UTC (rev 141239)
@@ -1817,3 +1817,5 @@
 webkit.org/b/107476 fast/block/float/024.html [ Failure ]
 webkit.org/b/107476 fast/block/margin-collapse/empty-clear-blocks.html [ Failure ]
 
+# New ruby selection test (in r140613) fails to render correctly, not generating an expected result
+webkit.org/b/108315 fast/ruby/select-ruby.html [ Missing ]


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (141238 => 141239)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-01-30 10:20:46 UTC (rev 141238)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-01-30 10:31:14 UTC (rev 141239)
@@ -61,6 +61,10 @@
 webkit.org/b/102651 [ Debug ] networkinformation/add-listener-from-callback.html [ Crash ]
 webkit.org/b/102651 [ Debug ] networkinformation/basic-operation.html [ Crash ]
 
+# Assertion failure and incorrect results on our port after r140999
+webkit.org/b/106142 compositing/overflow/automatically-opt-into-composited-scrolling.html [ Crash Failure ]
+webkit.org/b/106142 compositing/overflow/composited-scrolling-creates-a-stacking-container.html [ Crash Failure ]
+
 #
 # FLAKY TESTS
 #
@@ -433,3 +437,14 @@
 webkit.org/b/108182 http/tests/security/storage-blocking-loosened-plugin.html [ Skip ]
 webkit.org/b/108182 http/tests/security/storage-blocking-loosened-private-browsing-plugin.html [ Skip ]
 webkit.org/b/108182 plugins [ Skip ]
+webkit.org/b/108182 fast/loader/reload-zero-byte-plugin.html [ Skip ]
+webkit.org/b/108182 fast/frames/iframe-plugin-load-remove-document-crash.html [ Skip ]
+webkit.org/b/108182 fast/replaced/no-focus-ring-object.html [ Skip ]
+webkit.org/b/108182 fast/replaced/object-with-embed-url-param.html [ Skip ]
+webkit.org/b/108182 fast/replaced/no-focus-ring-embed.html [ Skip ]
+webkit.org/b/108182 http/tests/plugins/post-url-file.html [ Skip ]
+webkit.org/b/108182 http/tests/plugins/plugin-document-has-focus.html [ Skip ]
+webkit.org/b/108182 compositing/plugins/small-to-large-composited-plugin.html [ Skip ]
+
+# New ruby selection test (in r140613) fails to render correctly, not generating an expected result
+webkit.org/b/108315 fast/ruby/select-ruby.html [ Missing ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [140257] trunk/LayoutTests

2013-01-19 Thread dominik . rottsches
Title: [140257] trunk/LayoutTests








Revision 140257
Author dominik.rottsc...@intel.com
Date 2013-01-19 13:02:17 -0800 (Sat, 19 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: sticky-top-zoomed.html marked as ImageOnlyFailure.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (140256 => 140257)

--- trunk/LayoutTests/ChangeLog	2013-01-19 20:39:06 UTC (rev 140256)
+++ trunk/LayoutTests/ChangeLog	2013-01-19 21:02:17 UTC (rev 140257)
@@ -2,6 +2,12 @@
 
 [EFL] Unreviewed gardening.
 
+* platform/efl/TestExpectations: sticky-top-zoomed.html marked as ImageOnlyFailure.
+
+2013-01-19  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
 * platform/efl/TestExpectations: Accessibility test now marked as failing.
 * platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt: New baseline without warnings.
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (140256 => 140257)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-19 20:39:06 UTC (rev 140256)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-19 21:02:17 UTC (rev 140257)
@@ -1822,4 +1822,4 @@
 
 webkit.org/b/107013 http/tests/inspector/resource-tree/resource-tree-document-url.html [ Failure ]
 
-webkit.org/b/107375 fast/css/sticky/sticky-top-zoomed.html [ Failure ]
+webkit.org/b/107375 fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [140256] trunk/LayoutTests

2013-01-19 Thread dominik . rottsches
Title: [140256] trunk/LayoutTests








Revision 140256
Author dominik.rottsc...@intel.com
Date 2013-01-19 12:39:06 -0800 (Sat, 19 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Accessibility test now marked as failing.
* platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt: New baseline without warnings.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (140255 => 140256)

--- trunk/LayoutTests/ChangeLog	2013-01-19 20:28:16 UTC (rev 140255)
+++ trunk/LayoutTests/ChangeLog	2013-01-19 20:39:06 UTC (rev 140256)
@@ -1,3 +1,10 @@
+2013-01-19  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+* platform/efl/TestExpectations: Accessibility test now marked as failing.
+* platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt: New baseline without warnings.
+
 2013-01-19  Zan Dobersek  
 
 Unreviewed GTK gardening.
@@ -6,7 +13,7 @@
 
 * platform/gtk/TestExpectations:
 
-2013-01-19  Dominik Röttsches  >
+2013-01-19  Dominik Röttsches  
 
 [EFL] Unreviewed gardening.
 
@@ -15,7 +22,7 @@
 * fast/css/css2-system-fonts-expected.txt: Reverted.
 * platform/efl/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/fast/css/css2-system-fonts-expected.txt.
 
-2013-01-19  Dominik Röttsches  >
+2013-01-19  Dominik Röttsches  
 
 [EFL] Unreviewed gardening.
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (140255 => 140256)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-19 20:28:16 UTC (rev 140255)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-19 20:39:06 UTC (rev 140256)
@@ -696,7 +696,7 @@
 webkit.org/b/105879 editing/spelling/spelling-insert-html.html [ Pass Crash ]
 
 # Sometimes hit cur || !toRenderInline(prev)->continuation() assertion in WebCore::endOfContinuations().
-webkit.org/b/105880 accessibility/render-counter-text.html [ Pass Crash ]
+webkit.org/b/105880 accessibility/render-counter-text.html [ Pass Crash Failure ]
 webkit.org/b/105880 fast/dom/Range/range-extract-contents.html [ Pass Crash ]
 
 # Tests started to crash after r139141.
@@ -1821,3 +1821,5 @@
 webkit.org/b/107001 compositing/layer-creation/overlap-animation-container.html [ Failure ]
 
 webkit.org/b/107013 http/tests/inspector/resource-tree/resource-tree-document-url.html [ Failure ]
+
+webkit.org/b/107375 fast/css/sticky/sticky-top-zoomed.html [ Failure ]


Modified: trunk/LayoutTests/platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt (140255 => 140256)

--- trunk/LayoutTests/platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt	2013-01-19 20:28:16 UTC (rev 140255)
+++ trunk/LayoutTests/platform/efl/inspector/editor/text-editor-highlight-regexp-expected.txt	2013-01-19 20:39:06 UTC (rev 140256)
@@ -1,80 +1,3 @@
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Dock to main window." not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "All Panels" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Go to the panel to the left/right" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Go back/forward in panel history" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Toggle console" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Search" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Search across all sources" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Go to source" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Go to line" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Console" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Elements Panel" not found.
-file:///home/dilbert/dev/WebKitGit_EFL/WebKitBuild/Debug/share/ewebkit-0/inspector/UIString.js:42: CONSOLEAPI WARN: Localized string "Elements" no

[webkit-changes] [140254] trunk/LayoutTests

2013-01-19 Thread dominik . rottsches
Title: [140254] trunk/LayoutTests








Revision 140254
Author dominik.rottsc...@intel.com
Date 2013-01-19 11:43:37 -0800 (Sat, 19 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

	Revert accidental global expectation override.

Patch by Dominik Röttsches  > on 2013-01-19

* fast/css/css2-system-fonts-expected.txt: Reverted.
* platform/efl/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/fast/css/css2-system-fonts-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/css2-system-fonts-expected.txt


Added Paths

trunk/LayoutTests/platform/efl/fast/css/css2-system-fonts-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (140253 => 140254)

--- trunk/LayoutTests/ChangeLog	2013-01-19 19:22:24 UTC (rev 140253)
+++ trunk/LayoutTests/ChangeLog	2013-01-19 19:43:37 UTC (rev 140254)
@@ -2,6 +2,15 @@
 
 [EFL] Unreviewed gardening.
 
+	Revert accidental global expectation override.
+
+* fast/css/css2-system-fonts-expected.txt: Reverted.
+* platform/efl/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/fast/css/css2-system-fonts-expected.txt.
+
+2013-01-19  Dominik Röttsches  >
+
+[EFL] Unreviewed gardening.
+
 A couple of missing rebaselines after enabling subpixel layout and updating freetype.
 
 * fast/css/css2-system-fonts-expected.txt:


Modified: trunk/LayoutTests/fast/css/css2-system-fonts-expected.txt (140253 => 140254)

--- trunk/LayoutTests/fast/css/css2-system-fonts-expected.txt	2013-01-19 19:22:24 UTC (rev 140253)
+++ trunk/LayoutTests/fast/css/css2-system-fonts-expected.txt	2013-01-19 19:43:37 UTC (rev 140254)
@@ -6,41 +6,41 @@
   RenderBlock {H1} at (0,0) size 784x37
 RenderText {#text} at (0,0) size 266x36
   text run at (0,0) width 266: "CSS2 System Fonts"
-  RenderBlock {P} at (0,58) size 784x37
-RenderText {#text} at (0,0) size 387x17
+  RenderBlock {P} at (0,58) size 784x36
+RenderText {#text} at (0,0) size 387x19
   text run at (0,0) width 387: "The following should appear with the fonts specified, per the "
-RenderInline {A} at (0,0) size 75x17 [color=#EE]
-  RenderText {#text} at (387,0) size 75x17
+RenderInline {A} at (0,0) size 75x19 [color=#EE]
+  RenderText {#text} at (387,0) size 75x19
 text run at (387,0) width 75: "CSS2 specs"
-RenderText {#text} at (462,0) size 765x35
+RenderText {#text} at (462,0) size 765x37
   text run at (462,0) width 303: ". If they appear in a monospace font, the test has"
   text run at (0,18) width 39: "failed."
-  RenderBlock {UL} at (0,110) size 784x109
+  RenderBlock {UL} at (0,110) size 784x108
 RenderListItem {LI} at (40,0) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 377x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 377x19
 text run at (0,0) width 377: "Caption (on Mac will be Lucida Grande 13.0 Regular)"
 RenderListItem {LI} at (40,18) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 693x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 693x19
 text run at (0,0) width 693: "Icon (on Mac will be Lucida Grande 13.0 Regular for now, not sure how to get this info from Finder)"
 RenderListItem {LI} at (40,36) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 361x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 361x19
 text run at (0,0) width 361: "Menu (on Mac will be Lucida Grande 13.0 Regular)"
 RenderListItem {LI} at (40,54) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 419x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 419x19
 text run at (0,0) width 419: "Message-Box (on Mac will be Lucida Grande 13.0 Regular)"
 RenderListItem {LI} at (40,72) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 423x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 423x19
 text run at (0,0) width 423: "Small-Caption (on Mac will be Lucida Grande 11.0 Regular)"
 RenderListItem {LI} at (40,90) size 744x18
-  RenderListMarker at (-17,0) size 7x17: bullet
-  RenderText {#text} at (0,0) size 396x17
+  RenderListMarker at (-18,0) size 7x19: bullet
+  RenderText {#text} at (0,0) size 396x19
 text run at (0,0) width 396: "Status-Bar (on Mac will be Lucida Grande 10.0 Regular)"
- 

[webkit-changes] [140111] trunk

2013-01-18 Thread dominik . rottsches
Title: [140111] trunk








Revision 140111
Author dominik.rottsc...@intel.com
Date 2013-01-18 01:48:43 -0800 (Fri, 18 Jan 2013)


Log Message
[EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=106774

Source/WebCore:

In order to fix a long standing linespacing/font ascent & descent issue
we found that FreeType commit b0962ac34e660 solves that problem.
Let's update FreeType accordingly, but bump it to 2.4.11 due to the
maintainer recommending several security updates after that said commit.

Also, in order to avoid extra rebaselining, let's activate subpixel
layout at the same time. With subpixel layout I propose to remove
rounding of the linespacing value in order to not introduce rounding
inaccuracies at the SimpleFontData level. Other platforms don't do that
anymore, furthermore the linegap value is not rounded either.

Reviewed by Martin Robinson.

No new tests, affects a large number of tests that will require rebaselining.

* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit): Remove rounding when setting linespacing.

Source/WTF:

In order to fix a long standing linespacing/font ascent & descent issue
we found that FreeType commit b0962ac34e660 solves that problem.
Let's update FreeType accordingly, but bump it to 2.4.11 due to the
maintainer recommending several security updates after that said commit.

Also, in order to avoid extra rebaselining, let's activate subpixel
layout at the same time.

Reviewed by Martin Robinson.

* wtf/Platform.h: Activate Subpixel Layout for EFL.

Tools:

Reviewed by Martin Robinson.

In order to fix a long standing linespacing/font ascent & descent issue
we found that FreeType commit b0962ac34e660 solves that problem.
Let's update FreeType accordingly, but bump it to 2.4.11 due to the
maintainer recommending several security updates after that said commit.

Also, in order to avoid extra rebaselining, let's activate subpixel
layout at the same time.

* efl/jhbuild.modules: New freetype 2.4.11

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp
trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules




Diff

Modified: trunk/Source/WTF/ChangeLog (140110 => 140111)

--- trunk/Source/WTF/ChangeLog	2013-01-18 09:47:36 UTC (rev 140110)
+++ trunk/Source/WTF/ChangeLog	2013-01-18 09:48:43 UTC (rev 140111)
@@ -1,3 +1,20 @@
+2013-01-14  Dominik Röttsches  
+
+[EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
+https://bugs.webkit.org/show_bug.cgi?id=106774
+
+In order to fix a long standing linespacing/font ascent & descent issue
+we found that FreeType commit b0962ac34e660 solves that problem.
+Let's update FreeType accordingly, but bump it to 2.4.11 due to the
+maintainer recommending several security updates after that said commit.
+
+Also, in order to avoid extra rebaselining, let's activate subpixel
+layout at the same time.
+
+Reviewed by Martin Robinson.
+
+* wtf/Platform.h: Activate Subpixel Layout for EFL.
+
 2013-01-17  Adam Barth  
 
 Teach Functional.h about WeakPtr


Modified: trunk/Source/WTF/wtf/Platform.h (140110 => 140111)

--- trunk/Source/WTF/wtf/Platform.h	2013-01-18 09:47:36 UTC (rev 140110)
+++ trunk/Source/WTF/wtf/Platform.h	2013-01-18 09:48:43 UTC (rev 140111)
@@ -828,8 +828,8 @@
 #endif
 
 #if !defined(ENABLE_SUBPIXEL_LAYOUT)
-#if PLATFORM(CHROMIUM)
-#define ENABLE_SUBPIXEL_LAYOUT 1 
+#if PLATFORM(CHROMIUM) || PLATFORM(EFL)
+#define ENABLE_SUBPIXEL_LAYOUT 1
 #else
 #define ENABLE_SUBPIXEL_LAYOUT 0
 #endif


Modified: trunk/Source/WebCore/ChangeLog (140110 => 140111)

--- trunk/Source/WebCore/ChangeLog	2013-01-18 09:47:36 UTC (rev 140110)
+++ trunk/Source/WebCore/ChangeLog	2013-01-18 09:48:43 UTC (rev 140111)
@@ -1,3 +1,26 @@
+2013-01-14  Dominik Röttsches  
+
+[EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
+https://bugs.webkit.org/show_bug.cgi?id=106774
+
+In order to fix a long standing linespacing/font ascent & descent issue
+we found that FreeType commit b0962ac34e660 solves that problem.
+Let's update FreeType accordingly, but bump it to 2.4.11 due to the
+maintainer recommending several security updates after that said commit.
+
+Also, in order to avoid extra rebaselining, let's activate subpixel
+layout at the same time. With subpixel layout I propose to remove
+rounding of the linespacing value in order to not introduce rounding
+inaccuracies at the SimpleFontData level. Other platforms don't do that
+anymore, furthermore the linegap value is not rounded either.
+
+Reviewed by Martin Robinson.
+
+No new tests, affects a large number of tests that will require rebaselining.
+
+  

[webkit-changes] [139869] trunk/LayoutTests

2013-01-16 Thread dominik . rottsches
Title: [139869] trunk/LayoutTests








Revision 139869
Author dominik.rottsc...@intel.com
Date 2013-01-16 04:02:43 -0800 (Wed, 16 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

Marking compositing/layer-creation/overlap-animation-container as failure
after it started failing in r139794, might just need a rebaseline but first let's have
someone familiar with AC look at it.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139868 => 139869)

--- trunk/LayoutTests/ChangeLog	2013-01-16 12:00:50 UTC (rev 139868)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 12:02:43 UTC (rev 139869)
@@ -1,3 +1,13 @@
+2013-01-16  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Marking compositing/layer-creation/overlap-animation-container as failure
+after it started failing in r139794, might just need a rebaseline but first let's have
+someone familiar with AC look at it.
+
+* platform/efl/TestExpectations:
+
 2013-01-16  Pablo Flouret  
 
 Implement CSSSupportsRule


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139868 => 139869)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-16 12:00:50 UTC (rev 139868)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-16 12:02:43 UTC (rev 139869)
@@ -1816,3 +1816,5 @@
 
 webkit.org/b/106997 fast/dom/MicroData/propertiescollection-crash.html [ Failure ]
 webkit.org/b/106997 fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html [ Failure ]
+
+webkit.org/b/107001 compositing/layer-creation/overlap-animation-container.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139861] trunk/LayoutTests

2013-01-16 Thread dominik . rottsches
Title: [139861] trunk/LayoutTests








Revision 139861
Author dominik.rottsc...@intel.com
Date 2013-01-16 02:42:03 -0800 (Wed, 16 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

Removed fast/events/drag-and-drop-autoscroll from Test expectations after rollout in r139503.
ScrollingCoordinator tests moved to TestExpectations after r139686.
Border size rendering change in r139798 requires a rebaseline for
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm &
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
but they fail to generate pixel results - see bug 106992.
PropertyCollection tests skipped for now after r139756

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139860 => 139861)

--- trunk/LayoutTests/ChangeLog	2013-01-16 10:26:36 UTC (rev 139860)
+++ trunk/LayoutTests/ChangeLog	2013-01-16 10:42:03 UTC (rev 139861)
@@ -1,3 +1,17 @@
+2013-01-16  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Removed fast/events/drag-and-drop-autoscroll from Test expectations after rollout in r139503.
+ScrollingCoordinator tests moved to TestExpectations after r139686.
+Border size rendering change in r139798 requires a rebaseline for
+svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm &
+http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
+but they fail to generate pixel results - see bug 106992.
+PropertyCollection tests skipped for now after r139756
+
+* platform/efl/TestExpectations:
+
 2013-01-15  Vsevolod Vlasov  
 
 Web Inspector: Introduce file mapping allowing to map network loaded scripts and stylesheets to file system files.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139860 => 139861)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-16 10:26:36 UTC (rev 139860)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-16 10:42:03 UTC (rev 139861)
@@ -1784,9 +1784,6 @@
 # New test introduced in r138756 is failing.
 webkit.org/b/106086 fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html [ Failure ]
 
-# [Qt][EFL] New fast/events/drag-and-drop-autoscroll.html fails
-webkit.org/b/106318 fast/events/drag-and-drop-autoscroll.html [ Failure ]
-
 # Fail after r139145 on MAC, EFL, QT, GTK.
 webkit.org/b/106415 fast/workers/worker-close-more.html [ Pass Failure ]
 webkit.org/b/106415 fast/workers/worker-close-more.html [ Pass Failure ]
@@ -1810,3 +1807,11 @@
 # https://bugs.webkit.org/show_bug.cgi?id=106883
 inspector/editor/text-editor-formatter.html
 
+# Fail to generate proper pixel results - let's wait with rebaselining.
+webkit.org/b/106992 scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure ]
+webkit.org/b/106992 scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure ]
+webkit.org/b/106992 svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm [ Failure ]
+webkit.org/b/106992 http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm [ Failure ]
+
+webkit.org/b/106997 fast/dom/MicroData/propertiescollection-crash.html [ Failure ]
+webkit.org/b/106997 fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139781] trunk/Source/WebKit2

2013-01-15 Thread dominik . rottsches
Title: [139781] trunk/Source/WebKit2








Revision 139781
Author dominik.rottsc...@intel.com
Date 2013-01-15 13:40:29 -0800 (Tue, 15 Jan 2013)


Log Message
[CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html
https://bugs.webkit.org/show_bug.cgi?id=106884

Reviewed by Benjamin Poulain.

We need to return false if m_waitingForUIProcess is true since otherwise
we'll not really repaint in performScheduledLayerFlush() and the
UI process will wait forever. Returning false leads to executing the layer flush
synchronously and immediately, then acknowledging the
callback to the WebProcess - which resolves the deadlock.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Return false in order to trigger a synchronous repaint if m_waitingForUIProcess is true.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (139780 => 139781)

--- trunk/Source/WebKit2/ChangeLog	2013-01-15 21:35:08 UTC (rev 139780)
+++ trunk/Source/WebKit2/ChangeLog	2013-01-15 21:40:29 UTC (rev 139781)
@@ -1,3 +1,19 @@
+2013-01-15  Dominik Röttsches  
+
+[CoordinatedGraphics] Deadlock when running abspos-child-container-changes-from-relative-to-static.html
+https://bugs.webkit.org/show_bug.cgi?id=106884
+
+Reviewed by Benjamin Poulain.
+
+We need to return false if m_waitingForUIProcess is true since otherwise
+we'll not really repaint in performScheduledLayerFlush() and the
+UI process will wait forever. Returning false leads to executing the layer flush
+synchronously and immediately, then acknowledging the
+callback to the WebProcess - which resolves the deadlock.
+
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Return false in order to trigger a synchronous repaint if m_waitingForUIProcess is true.
+
 2013-01-15  Simon Fraser  
 
 Allow tiled WKViews to have transparent backgrounds


Modified: trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp (139780 => 139781)

--- trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-01-15 21:35:08 UTC (rev 139780)
+++ trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp	2013-01-15 21:40:29 UTC (rev 139781)
@@ -204,6 +204,10 @@
 
 bool CoordinatedLayerTreeHost::forceRepaintAsync(uint64_t callbackID)
 {
+// Avoid deadlocks when the UI process has requested a forceRepaint by falling back to a synchronous repaint, see caller WebPage::forceRepaint.
+if (m_waitingForUIProcess)
+return false;
+
 // We expect the UI process to not require a new repaint until the previous one has finished.
 ASSERT(!m_forceRepaintAsyncCallbackID);
 m_forceRepaintAsyncCallbackID = callbackID;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139317] trunk/LayoutTests

2013-01-10 Thread dominik . rottsches
Title: [139317] trunk/LayoutTests








Revision 139317
Author dominik.rottsc...@intel.com
Date 2013-01-10 07:13:18 -0800 (Thu, 10 Jan 2013)


Log Message
CSSParser does not allow the absence of whitespace between "and" and "_expression_"
https://bugs.webkit.org/show_bug.cgi?id=106458

Patch by Alexander Pavlov  on 2013-01-10
Reviewed by Antti Koivisto.

* fast/css/media-rule-no-whitespace-expected.txt: Added.
* fast/css/media-rule-no-whitespace.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139316 => 139317)

--- trunk/LayoutTests/ChangeLog	2013-01-10 14:40:53 UTC (rev 139316)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 15:13:18 UTC (rev 139317)
@@ -193,6 +193,14 @@
 
 [EFL] Unreviewed gardening.
 
+video-src-blob.html is flaky, not always crashing.
+
+* platform/efl/TestExpectations:
+
+2013-01-10  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
 Marking one more flaky crasher due to gstreamer.
 
 * platform/efl/TestExpectations:


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139316 => 139317)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 14:40:53 UTC (rev 139316)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 15:13:18 UTC (rev 139317)
@@ -702,7 +702,7 @@
 
 # Media regressions after updating to gstreamer 1.0.
 webkit.org/b/104809 media/adopt-node-crash.html [ Crash ]
-webkit.org/b/104809 media/video-src-blob.html [ Crash ]
+webkit.org/b/104809 media/video-src-blob.html [ Crash Failure ]
 webkit.org/b/104809 media/remove-from-document.html [ Crash Pass ]
 webkit.org/b/104809 media/video-timeupdate-during-playback.html [ Crash Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139311] trunk/LayoutTests

2013-01-10 Thread dominik . rottsches
Title: [139311] trunk/LayoutTests








Revision 139311
Author dominik.rottsc...@intel.com
Date 2013-01-10 04:28:45 -0800 (Thu, 10 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

Marking one more flaky crasher due to gstreamer.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139310 => 139311)

--- trunk/LayoutTests/ChangeLog	2013-01-10 12:28:11 UTC (rev 139310)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 12:28:45 UTC (rev 139311)
@@ -2,6 +2,14 @@
 
 [EFL] Unreviewed gardening.
 
+Marking one more flaky crasher due to gstreamer.
+
+* platform/efl/TestExpectations:
+
+2013-01-10  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
 Marking three media tests as flaky crashers.
 
 * platform/efl/TestExpectations:


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139310 => 139311)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 12:28:11 UTC (rev 139310)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 12:28:45 UTC (rev 139311)
@@ -823,6 +823,7 @@
 webkit.org/b/106551 media/video-src-source.html [ Crash Pass ]
 webkit.org/b/106551 media/video-source-moved.html [ Crash Pass ]
 webkit.org/b/106551 media/video-source.html [ Crash Pass ]
+webkit.org/b/106551 fast/dom/beforeload/remove-video-poster-in-beforeload-listener.html [ Crash Pass ]
 
 #
 # FAILING TESTS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139309] trunk/LayoutTests

2013-01-10 Thread dominik . rottsches
Title: [139309] trunk/LayoutTests








Revision 139309
Author dominik.rottsc...@intel.com
Date 2013-01-10 04:25:44 -0800 (Thu, 10 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

Marking three media tests as flaky crashers.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139308 => 139309)

--- trunk/LayoutTests/ChangeLog	2013-01-10 12:07:36 UTC (rev 139308)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 12:25:44 UTC (rev 139309)
@@ -1,3 +1,11 @@
+2013-01-10  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Marking three media tests as flaky crashers.
+
+* platform/efl/TestExpectations:
+
 2013-01-10  Csaba Osztrogonác  
 
 Unreviewed gardening, paint the bots green.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139308 => 139309)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 12:07:36 UTC (rev 139308)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 12:25:44 UTC (rev 139309)
@@ -820,6 +820,10 @@
 
 webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure Pass ]
 
+webkit.org/b/106551 media/video-src-source.html [ Crash Pass ]
+webkit.org/b/106551 media/video-source-moved.html [ Crash Pass ]
+webkit.org/b/106551 media/video-source.html [ Crash Pass ]
+
 #
 # FAILING TESTS
 #
@@ -1795,3 +1799,4 @@
 
 # Mark as missing image result, same as other ports. Test should be updated to text-based repaint test.
 webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [139298] trunk/LayoutTests

2013-01-10 Thread dominik . rottsches
Title: [139298] trunk/LayoutTests








Revision 139298
Author dominik.rottsc...@intel.com
Date 2013-01-10 01:35:17 -0800 (Thu, 10 Jan 2013)


Log Message
[EFL] Unreviewed gardening.

Marking a missing expectation for fast/repaint/caret-with-transformation.html

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (139297 => 139298)

--- trunk/LayoutTests/ChangeLog	2013-01-10 09:21:37 UTC (rev 139297)
+++ trunk/LayoutTests/ChangeLog	2013-01-10 09:35:17 UTC (rev 139298)
@@ -1,3 +1,11 @@
+2013-01-10  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Marking a missing expectation for fast/repaint/caret-with-transformation.html
+
+* platform/efl/TestExpectations:
+
 2013-01-10  Zan Dobersek  
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (139297 => 139298)

--- trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 09:21:37 UTC (rev 139297)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2013-01-10 09:35:17 UTC (rev 139298)
@@ -1792,3 +1792,6 @@
 
 # Failing after r139140.
 webkit.org/b/106441 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html [ Failure ]
+
+# Mark as missing image result, same as other ports. Test should be updated to text-based repaint test.
+webkit.org/b/103955 fast/repaint/caret-with-transformation.html [ Missing ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138251] trunk/LayoutTests

2012-12-20 Thread dominik . rottsches
Title: [138251] trunk/LayoutTests








Revision 138251
Author dominik.rottsc...@intel.com
Date 2012-12-20 07:14:58 -0800 (Thu, 20 Dec 2012)


Log Message
[EFL] Unreviewed gardening.

Marking inspector-protocol/nmi-webaudio* tests as failing,
they don't work yet after r138248.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (138250 => 138251)

--- trunk/LayoutTests/ChangeLog	2012-12-20 14:54:17 UTC (rev 138250)
+++ trunk/LayoutTests/ChangeLog	2012-12-20 15:14:58 UTC (rev 138251)
@@ -1,3 +1,12 @@
+2012-12-20  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Marking inspector-protocol/nmi-webaudio* tests as failing,
+they don't work yet after r138248.
+
+* platform/efl/TestExpectations:
+
 2012-12-20  Florin Malita  
 
 Incorrect color space conversion for FEImage


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138250 => 138251)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 14:54:17 UTC (rev 138250)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 15:14:58 UTC (rev 138251)
@@ -1799,3 +1799,5 @@
 webkit.org/b/105297 webaudio/audiobuffersource-loop-points.html [ Failure ]
 webkit.org/b/105297 webaudio/audiobuffersource-playbackrate.html [ Failure ]
 webkit.org/b/105298 webaudio/decode-audio-data-basic.html [ Failure ]
+webkit.org/b/105535 inspector-protocol/nmi-webaudio.html [ Failure ]
+webkit.org/b/105535 inspector-protocol/nmi-webaudio-leak-test.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138248] trunk

2012-12-20 Thread dominik . rottsches
Title: [138248] trunk








Revision 138248
Author dominik.rottsc...@intel.com
Date 2012-12-20 06:09:05 -0800 (Thu, 20 Dec 2012)


Log Message
[EFL] MiniBrowser does not play Infinite Gangnam Style
https://bugs.webkit.org/show_bug.cgi?id=103531

Reviewed by Kenneth Rohde Christiansen.

.:

WebAudio now switched to ON for EFL.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Specifying additional define to avoid deprecation warning.

No new tests, compile time change which doesn't affect behavior.

* PlatformEfl.cmake:

Source/WebKit2:

WebAudio preference now defaults to switched on.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):

Tools:

For EFL we would like this feature to be built by default.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Marked remaining webaudio failures.

* platform/efl/TestExpectations:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/ChangeLog (138247 => 138248)

--- trunk/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,14 @@
+2012-12-20  Dominik Röttsches  
+
+[EFL] MiniBrowser does not play Infinite Gangnam Style
+https://bugs.webkit.org/show_bug.cgi?id=103531
+
+Reviewed by Kenneth Rohde Christiansen.
+
+WebAudio now switched to ON for EFL.
+
+* Source/cmake/OptionsEfl.cmake:
+
 2012-12-19  Yael Aharon  
 
 [EFL] Allow the build system to find OpenGL ES


Modified: trunk/LayoutTests/ChangeLog (138247 => 138248)

--- trunk/LayoutTests/ChangeLog	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/LayoutTests/ChangeLog	2012-12-20 14:09:05 UTC (rev 138248)
@@ -1,3 +1,14 @@
+2012-12-20  Dominik Röttsches  
+
+[EFL] MiniBrowser does not play Infinite Gangnam Style
+https://bugs.webkit.org/show_bug.cgi?id=103531
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Marked remaining webaudio failures.
+
+* platform/efl/TestExpectations:
+
 2012-12-20  Csaba Osztrogonác  
 
 Unreviewed gardening, skip a crashing test to paint the bots green.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138247 => 138248)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 13:48:24 UTC (rev 138247)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-20 14:09:05 UTC (rev 138248)
@@ -646,6 +646,13 @@
 webkit.org/b/100519 fast/images/paletted-png-with-color-profile.html [ Skip ]
 
 #
+# CRASHES
+#
+
+webkit.org/b/105299 webaudio/_javascript_audionode.html [ Crash ]
+webkit.org/b/105299 webaudio/_javascript_audionode-upmix2-8channel-input.html [ Pass Crash ]
+
+#
 # FLAKY TESTS
 #
 
@@ -762,6 +769,8 @@
 webkit.org/b/105280 http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html [ Failure Pass ]
 webkit.org/b/105280 http/tests/xmlhttprequest/access-control-preflight-async-not-supported.html [ Failure Pass ]
 
+webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure Pass ]
+
 #
 # FAILING TESTS
 #
@@ -1159,11 +1168,6 @@
 webkit.org/b/88080 pointer-lock [ Skip ]
 webkit.org/b/88080 http/tests/pointer-lock [ Skip ]
 
-# Requires WEB_AUDIO support.
-webkit.org/b/91738 webaudio [ Skip ]
-webkit.org/b/91738 inspector-protocol/nmi-webaudio.html [ Skip ]
-webkit.org/b/91738 inspector-protocol/nmi-webaudio-leak-test.html [ Skip ]
-
 # Requires MEDIA_STREAM support.
 webkit.org/b/87662 fast/mediastream [ Skip ]
 
@@ -1729,5 +1733,26 @@
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ]
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ]
 
-# Failing touch events case 
-webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ] 
+# Failing touch events case
+webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ]
+
+# WebAudio remaining issues
+webkit.org/b/105289 webaudio/mediastreamaudiosourcenode.html [ Failure ]
+webkit.org/b/105289 webaudio/mediastreamaudiodestinationnode.html [ Failure ]
+webkit.org/b/105291 webaudio/oscillator-square.html [ Failure ]
+webkit.org/b/105

[webkit-changes] [138232] trunk

2012-12-20 Thread dominik . rottsches
Title: [138232] trunk








Revision 138232
Author dominik.rottsc...@intel.com
Date 2012-12-20 01:00:43 -0800 (Thu, 20 Dec 2012)


Log Message
[WK2] WebAudio WKTR support
https://bugs.webkit.org/show_bug.cgi?id=95084

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Mac build fixes for adding WebAudio WKTR support.

No new tests, enables audio testing using WebKitTestRunner.

* WebCore.exp.in: toUint8Array symbol exported.
* WebCore.xcodeproj/project.pbxproj: JSUint8Array.h and JSArrayBufferView.h headers made available as private headers.

Source/WebKit2:

Implementing audio data dump support for WebKitTestRunner,
by adding the API to the IDL, enabling IPC for transferring
the audio data as bytebuffer and dumping it according
to run-webkit-tests script's expectations.

I am adding a testrunner specific bundle method to extract data
from a Uint8Array into a bytebuffer. This API is used by
WebKitTestRunner's TestRunner to extract the data into a local
variable, then sending it over IPC.

* DerivedSources.pri: Fixing Qt build by adding JSUint8Array.h header to list of forwarding headers.
* Target.pri: Adding missing WKData.* files. Qt build fix.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleCreateWKDataFromUint8Array): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Adding WKBundleCreateWKDataFromUint8Array.
* WebProcess/InjectedBundle/InjectedBundle.cpp: Convert Uint8Array to WebData.
(WebKit::InjectedBundle::createWebDataFromUint8Array):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundle.h:
(WebKit):
(InjectedBundle):

Tools:

Implementing audio data dump support for WebKitTestRunner,
by adding the API to the IDL, enabling IPC for transferring
the audio data as bytebuffer and dumping it according
to run-webkit-tests script's expectations.
This enables audio testing on WebKit2 ports.
Based on initial wip-patch from Philippe Normand - thanks.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
* WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
(WTR::TestRunner::setAudioData):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
(TestRunner):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
(WTR::InjectedBundle::setAudioResult):
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
* WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
(WTR::TestInvocation::dumpResults):
(WTR):
(WTR::TestInvocation::dumpAudio):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
* WebKitTestRunner/TestInvocation.h:
(TestInvocation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.pri
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h
trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
trunk/Tools/WebKitTestRunner/TestInvocation.cpp
trunk/Tools/WebKitTestRunner/TestInvocation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (138231 => 138232)

--- trunk/Source/WebCore/ChangeLog	2012-12-20 08:54:01 UTC (rev 138231)
+++ trunk/Source/WebCore/ChangeLog	2012-12-20 09:00:43 UTC (rev 138232)
@@ -1,3 +1,17 @@
+2012-12-20  Dominik Röttsches  
+
+[WK2] WebAudio WKTR support
+https://bugs.webkit.org/show_bug.cgi?id=95084
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Mac build fixes for adding WebAudio WKTR support.
+
+No new tests, enables audio testing using WebKitTestRunner.
+
+* WebCore.exp.in: toUint8Array symbol exported.
+* WebCore.xcodeproj/project.pbxproj: JSUint8Array.h and JSArrayBufferView.h headers made available as private headers.
+
 2012-12-20  Patrick Gansterer  
 
 Build fix for WinCE after r137534.


Modified: trunk/Source/WebCore/WebCore.exp.in (

[webkit-changes] [138172] trunk/LayoutTests

2012-12-19 Thread dominik . rottsches
Title: [138172] trunk/LayoutTests








Revision 138172
Author dominik.rottsc...@intel.com
Date 2012-12-19 09:22:27 -0800 (Wed, 19 Dec 2012)


Log Message
[EFL] Unreviewed gardening.

Adding platform specific expectations since our error msg is chattier,
test was introduced in r138165.
Also, marking a crash failure.

* platform/efl/TestExpectations:
* platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations


Added Paths

trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (138171 => 138172)

--- trunk/LayoutTests/ChangeLog	2012-12-19 17:21:13 UTC (rev 138171)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 17:22:27 UTC (rev 138172)
@@ -1,3 +1,14 @@
+2012-12-19  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Adding platform specific expectations since our error msg is chattier,
+test was introduced in r138165.
+Also, marking a crash failure.
+
+* platform/efl/TestExpectations:
+* platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt: Added.
+
 2012-12-19  Zan Dobersek  
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138171 => 138172)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 17:21:13 UTC (rev 138171)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 17:22:27 UTC (rev 138172)
@@ -744,6 +744,8 @@
 
 webkit.org/b/102928 svg/foreignObject/viewport-foreignobject-crash.html [ Crash Failure Pass ]
 
+webkit.org/b/105444 fast/selectors/querySelector-in-range-crash.html [ Crash Pass ]
+
 # Issue with timing for suspend/resumeAnimations()?
 webkit.org/b/49182 animations/stop-animation-on-suspend.html [ Failure Pass ]
 


Added: trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt (0 => 138172)

--- trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/fast/dom/shadow/shadow-root-js-api-expected.txt	2012-12-19 17:22:27 UTC (rev 138172)
@@ -0,0 +1,29 @@
+Tests for ShadowRoot JS APIs. Can only run within DRT
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS window.ShadowRoot is undefined.
+PASS window.WebKitShadowRoot is defined.
+PASS new window.WebKitShadowRoot(document.createElement('div')) threw exception TypeError: '[object ShadowRootConstructor]' is not a constructor (evaluating 'new window.WebKitShadowRoot(document.createElement('div'))').
+PASS shadowRoot instanceof window.WebKitShadowRoot is true
+PASS shadowRoot.getElementById('div1') is div1
+PASS shadowRoot.getElementById('foo') is null
+PASS shadowRoot.getElementsByClassName('class2') is [div2]
+PASS shadowRoot.getElementsByClassName('foo') is []
+PASS shadowRoot.getElementsByTagName('div') is [div1, div2]
+PASS shadowRoot.getElementsByTagName('foo') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'div') is [div1, div2]
+PASS shadowRoot.getElementsByTagNameNS('', 'div') is []
+PASS shadowRoot.getElementsByTagNameNS('*', 'foo') is []
+PASS shadowRoot.querySelector('#div1') is div1
+PASS shadowRoot.querySelector('#foo') is null
+PASS shadowRoot.querySelector('.class2') is div2
+PASS shadowRoot.querySelector('.foo') is null
+PASS shadowRoot.querySelectorAll('div') is [div1, div2]
+PASS shadowRoot.querySelectorAll('foo') is []
+PASS youngerShadowRoot is not shadowRoot
+PASS successfullyParsed is true
+
+TEST COMPLETE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138139] trunk/LayoutTests

2012-12-19 Thread dominik . rottsches
Title: [138139] trunk/LayoutTests








Revision 138139
Author dominik.rottsc...@intel.com
Date 2012-12-19 02:56:01 -0800 (Wed, 19 Dec 2012)


Log Message
[EFL] Unreviewed gardening.

Adding failing touch events case, details in bug 105406.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (138138 => 138139)

--- trunk/LayoutTests/ChangeLog	2012-12-19 10:50:36 UTC (rev 138138)
+++ trunk/LayoutTests/ChangeLog	2012-12-19 10:56:01 UTC (rev 138139)
@@ -1,3 +1,11 @@
+2012-12-19  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Adding failing touch events case, details in bug 105406.
+
+* platform/efl/TestExpectations:
+
 2012-12-19  Tommy Widenflycht  
 
 [JSC] Add support for overloaded constructors


Modified: trunk/LayoutTests/platform/efl/TestExpectations (138138 => 138139)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 10:50:36 UTC (rev 138138)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-12-19 10:56:01 UTC (rev 138139)
@@ -1726,3 +1726,6 @@
 # Note webkit.org/b/104506, random crashes
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes.html [ ImageOnlyFailure Crash ]
 webkit.org/b/105029 fast/canvas/webgl/webgl-composite-modes-repaint.html [ ImageOnlyFailure Crash ]
+
+# Failing touch events case
+webkit.org/b/105406 fast/events/touch/touch-input-element-change-documents.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [138002] trunk/LayoutTests

2012-12-18 Thread dominik . rottsches
Title: [138002] trunk/LayoutTests








Revision 138002
Author dominik.rottsc...@intel.com
Date 2012-12-18 02:40:18 -0800 (Tue, 18 Dec 2012)


Log Message
webaudio/oscillator* tests should use OfflineAudioContext
https://bugs.webkit.org/show_bug.cgi?id=105174

Reviewed by Kentaro Hara.

webaudio/oscillator* tests were using the slower webkitAudioContext for output rendering.
Replacing the usage with webkitOfflineAudioContext allows for faster-than-realtime rendering
in testing. Also, it avoids a deprecation warning on the console.

* webaudio/resources/oscillator-testing.js: Replace usage of webkitAudioContext with webkitOfflineAudioContext
(generateExponentialOscillatorSweep):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webaudio/resources/oscillator-testing.js




Diff

Modified: trunk/LayoutTests/ChangeLog (138001 => 138002)

--- trunk/LayoutTests/ChangeLog	2012-12-18 10:07:53 UTC (rev 138001)
+++ trunk/LayoutTests/ChangeLog	2012-12-18 10:40:18 UTC (rev 138002)
@@ -1,3 +1,17 @@
+2012-12-18  Dominik Röttsches  
+
+webaudio/oscillator* tests should use OfflineAudioContext
+https://bugs.webkit.org/show_bug.cgi?id=105174
+
+Reviewed by Kentaro Hara.
+
+webaudio/oscillator* tests were using the slower webkitAudioContext for output rendering.
+Replacing the usage with webkitOfflineAudioContext allows for faster-than-realtime rendering
+in testing. Also, it avoids a deprecation warning on the console.
+
+* webaudio/resources/oscillator-testing.js: Replace usage of webkitAudioContext with webkitOfflineAudioContext
+(generateExponentialOscillatorSweep):
+
 2012-12-18  Csaba Osztrogonác  
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/webaudio/resources/oscillator-testing.js (138001 => 138002)

--- trunk/LayoutTests/webaudio/resources/oscillator-testing.js	2012-12-18 10:07:53 UTC (rev 138001)
+++ trunk/LayoutTests/webaudio/resources/oscillator-testing.js	2012-12-18 10:40:18 UTC (rev 138002)
@@ -27,7 +27,7 @@
 
 function generateExponentialOscillatorSweep(oscillatorType) {
 // Create offline audio context.
-context = new webkitAudioContext(1, sampleRate * lengthInSeconds, sampleRate);
+context = new webkitOfflineAudioContext(1, sampleRate * lengthInSeconds, sampleRate);
 
 var osc = context.createOscillator();
 if (oscillatorType == OSC.CUSTOM) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [135125] trunk/LayoutTests

2012-11-19 Thread dominik . rottsches
Title: [135125] trunk/LayoutTests








Revision 135125
Author dominik.rottsc...@intel.com
Date 2012-11-19 01:19:02 -0800 (Mon, 19 Nov 2012)


Log Message
[EFL] Update expectation for fast/js/global-constructors.html after r135093
https://bugs.webkit.org/show_bug.cgi?id=102653

Unreviewed EFL gardening.

Update EFL baseline for fast/js/global-constructors.html after r135093.

Patch by Christophe Dumez  on 2012-11-19

* platform/efl/fast/js/global-constructors-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (135124 => 135125)

--- trunk/LayoutTests/ChangeLog	2012-11-19 08:48:43 UTC (rev 135124)
+++ trunk/LayoutTests/ChangeLog	2012-11-19 09:19:02 UTC (rev 135125)
@@ -1,3 +1,14 @@
+2012-11-19  Christophe Dumez  
+
+[EFL] Update expectation for fast/js/global-constructors.html after r135093
+https://bugs.webkit.org/show_bug.cgi?id=102653
+
+Unreviewed EFL gardening.
+
+Update EFL baseline for fast/js/global-constructors.html after r135093.
+
+* platform/efl/fast/js/global-constructors-expected.txt: Added.
+
 2012-11-18  Keishi Hattori  
 
 [Chromium] Add tests for week suggestion picker


Added: trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt (0 => 135125)

--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-expected.txt	2012-11-19 09:19:02 UTC (rev 135125)
@@ -0,0 +1,356 @@
+This test documents our set of global constructors we expose on the window object (FF and Opera don't expose them on the window, btw). This also checks to make sure than any constructor attribute we expose has the expected constructor type.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Attr.toString() is '[object AttrConstructor]'
+PASS Audio.toString() is '[object AudioConstructor]'
+PASS BeforeLoadEvent.toString() is '[object BeforeLoadEventConstructor]'
+PASS Blob.toString() is '[object BlobConstructor]'
+PASS CDATASection.toString() is '[object CDATASectionConstructor]'
+PASS CSSCharsetRule.toString() is '[object CSSCharsetRuleConstructor]'
+PASS CSSFontFaceRule.toString() is '[object CSSFontFaceRuleConstructor]'
+PASS CSSImportRule.toString() is '[object CSSImportRuleConstructor]'
+PASS CSSMediaRule.toString() is '[object CSSMediaRuleConstructor]'
+PASS CSSPageRule.toString() is '[object CSSPageRuleConstructor]'
+PASS CSSPrimitiveValue.toString() is '[object CSSPrimitiveValueConstructor]'
+PASS CSSRule.toString() is '[object CSSRuleConstructor]'
+PASS CSSRuleList.toString() is '[object CSSRuleListConstructor]'
+PASS CSSStyleDeclaration.toString() is '[object CSSStyleDeclarationConstructor]'
+PASS CSSStyleRule.toString() is '[object CSSStyleRuleConstructor]'
+PASS CSSStyleSheet.toString() is '[object CSSStyleSheetConstructor]'
+PASS CSSValue.toString() is '[object CSSValueConstructor]'
+PASS CSSValueList.toString() is '[object CSSValueListConstructor]'
+PASS CanvasGradient.toString() is '[object CanvasGradientConstructor]'
+PASS CanvasPattern.toString() is '[object CanvasPatternConstructor]'
+PASS CanvasRenderingContext2D.toString() is '[object CanvasRenderingContext2DConstructor]'
+PASS CharacterData.toString() is '[object CharacterDataConstructor]'
+PASS ClientRect.toString() is '[object ClientRectConstructor]'
+PASS ClientRectList.toString() is '[object ClientRectListConstructor]'
+PASS Clipboard.toString() is '[object ClipboardConstructor]'
+PASS CloseEvent.toString() is '[object CloseEventConstructor]'
+PASS Comment.toString() is '[object CommentConstructor]'
+PASS CompositionEvent.toString() is '[object CompositionEventConstructor]'
+PASS Counter.toString() is '[object CounterConstructor]'
+PASS CustomEvent.toString() is '[object CustomEventConstructor]'
+PASS DOMException.toString() is '[object DOMExceptionConstructor]'
+PASS DOMImplementation.toString() is '[object DOMImplementationConstructor]'
+PASS DOMParser.toString() is '[object DOMParserConstructor]'
+PASS DOMSettableTokenList.toString() is '[object DOMSettableTokenListConstructor]'
+PASS DOMStringList.toString() is '[object DOMStringListConstructor]'
+PASS DOMStringMap.toString() is '[object DOMStringMapConstructor]'
+PASS DOMTokenList.toString() is '[object DOMTokenListConstructor]'
+PASS Document.toString() is '[object DocumentConstructor]'
+PASS DocumentFragment.toString() is '[object DocumentFragmentConstructor]'
+PASS DocumentType.toString() is '[object DocumentTypeConstructor]'
+PASS Element.toString() is '[object ElementConstructor]'
+PASS Entity.toString() is '[object EntityConstructor]'
+PASS EntityReference.toString() is '[object EntityReferenceConstructor]'
+PASS ErrorEvent.toString() is '[object ErrorEventConstructor]'
+PASS Event.toString() is '[object EventConstructor

[webkit-changes] [134781] trunk

2012-11-15 Thread dominik . rottsches
Title: [134781] trunk








Revision 134781
Author dominik.rottsc...@intel.com
Date 2012-11-15 08:59:27 -0800 (Thu, 15 Nov 2012)


Log Message
[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
https://bugs.webkit.org/show_bug.cgi?id=101323

Reviewed by Martin Robinson.

Source/WebCore:

Removing ifdef since we bumped Harfbuzz dependency. This is the
real fix replacing the previous workaround of having a Chromium
specific ifdef here, since Chromium uses a newer HarfBuzz version
already.

No new tests, covered by css3/flexbox/inline-flex-crash.html
which will not crash anymore even with the ifdef removed.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

Tools:

Bumping Harfbuzz to newer version so that we can remove the
ifdef round the fix for bug 101009 for EFL, too.
We're using the zip snapshot since jhbuild can fallback to the previously
downloaded blob in case of network failures which leads to better
buildbot robustness. This zip snapshot currently needs to be locally
patched to fix ICU detection on systems that don't have icu pkg-config files.
The patch is suggested for merging into HarfBuzz. We can remove it locally
once it's accepted into HarfBuzz upstream.

* efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
* efl/jhbuild.modules: Bumping harfbuzz version.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp
trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules


Added Paths

trunk/Tools/efl/patches/
trunk/Tools/efl/patches/harfbuzz-icu-detection-fix.patch




Diff

Modified: trunk/Source/WebCore/ChangeLog (134780 => 134781)

--- trunk/Source/WebCore/ChangeLog	2012-11-15 16:50:57 UTC (rev 134780)
+++ trunk/Source/WebCore/ChangeLog	2012-11-15 16:59:27 UTC (rev 134781)
@@ -1,3 +1,21 @@
+2012-11-15  Dominik Röttsches  
+
+[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
+https://bugs.webkit.org/show_bug.cgi?id=101323
+
+Reviewed by Martin Robinson.
+
+Removing ifdef since we bumped Harfbuzz dependency. This is the
+real fix replacing the previous workaround of having a Chromium
+specific ifdef here, since Chromium uses a newer HarfBuzz version
+already.
+
+No new tests, covered by css3/flexbox/inline-flex-crash.html
+which will not crash anymore even with the ifdef removed.
+
+* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
+(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
+
 2012-11-15  Andreas Kling  
 
 REGRESSION(r134408): Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement().


Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp (134780 => 134781)

--- trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-11-15 16:50:57 UTC (rev 134780)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp	2012-11-15 16:59:27 UTC (rev 134781)
@@ -328,13 +328,10 @@
 if (shouldSetDirection)
 hb_buffer_set_direction(harfbuzzBuffer.get(), currentRun->rtl() ? HB_DIRECTION_RTL : HB_DIRECTION_LTR);
 
-// This #if should be removed after all ports update harfbuzz-ng.
-#if PLATFORM(CHROMIUM)
 // Add a space as pre-context to the buffer. This prevents showing dotted-circle
 // for combining marks at the beginning of runs.
 static const uint16_t preContext = ' ';
 hb_buffer_add_utf16(harfbuzzBuffer.get(), &preContext, 1, 1, 0);
-#endif
 
 if (m_font->isSmallCaps() && u_islower(m_normalizedBuffer[currentRun->startIndex()])) {
 String upperText = String(m_normalizedBuffer.get() + currentRun->startIndex(), currentRun->numCharacters());


Modified: trunk/Tools/ChangeLog (134780 => 134781)

--- trunk/Tools/ChangeLog	2012-11-15 16:50:57 UTC (rev 134780)
+++ trunk/Tools/ChangeLog	2012-11-15 16:59:27 UTC (rev 134781)
@@ -1,3 +1,22 @@
+2012-11-15  Dominik Röttsches  
+
+[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
+https://bugs.webkit.org/show_bug.cgi?id=101323
+
+Reviewed by Martin Robinson.
+
+Bumping Harfbuzz to newer version so that we can remove the
+ifdef round the fix for bug 101009 for EFL, too.
+We're using the zip snapshot since jhbuild can fallback to the previously
+downloaded blob in case of network failures which leads to better
+buildbot robustness. This zip snapshot currently needs to be locally
+patched to fix ICU detection on systems that don't have icu pkg-config files.
+The patch is suggested for merging into HarfBuzz. We can remove it locally
+once it's accepted into HarfBuzz upstream.
+
+* efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems

[webkit-changes] [134597] trunk/LayoutTests

2012-11-14 Thread dominik . rottsches
Title: [134597] trunk/LayoutTests








Revision 134597
Author dominik.rottsc...@intel.com
Date 2012-11-14 05:35:16 -0800 (Wed, 14 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

anchor-*download.html wander between crashing and failing.
Marking winsize test as failure and added to bug.

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (134596 => 134597)

--- trunk/LayoutTests/ChangeLog	2012-11-14 13:29:16 UTC (rev 134596)
+++ trunk/LayoutTests/ChangeLog	2012-11-14 13:35:16 UTC (rev 134597)
@@ -1,3 +1,12 @@
+2012-11-14  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+anchor-*download.html wander between crashing and failing.
+Marking winsize test as failure and added to bug.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-11-09  Ilya Tikhonovsky  
 
 Web Inspector: NMI add instrumentation for WebAudo related stuff.


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (134596 => 134597)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-14 13:29:16 UTC (rev 134596)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-14 13:35:16 UTC (rev 134597)
@@ -50,8 +50,8 @@
 # Crashes on plugin test.
 webkit.org/b/98747 plugins/document-open.html [ Crash ]
 
-webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ]
-webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Failure ]
+webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-download.html [ Crash Failure ]
+webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Crash Failure ]
 
 #Crash after r132386
 webkit.org/b/100342 fast/dom/nested-script-exceptions.html [ Crash ]
@@ -66,6 +66,8 @@
 webkit.org/b/102203 fast/events/attribute-listener-deletion-crash.html [ Crash ]
 webkit.org/b/102204 http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html [ Crash ]
 
+webkit.org/b/102217 media/audio-concurrent-supported.html [ Crash ]
+
 #
 # FLAKY TESTS
 #
@@ -296,4 +298,7 @@
 webkit.org/b/86881 media/controls-right-click-on-timebar.html [ Failure ]
 
 webkit.org/b/102201 fast/dom/Window/window-resize.html [ Failure ]
+webkit.org/b/102201 fast/dom/Window/open-window-min-size.html [ Failure ]
 webkit.org/b/102202 inspector/timeline/timeline-timer-fired-from-eval-call-site.html [ Failure ]
+
+webkit.org/b/102216 inspector-protocol/nmi-webaudio.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [134581] trunk/LayoutTests

2012-11-14 Thread dominik . rottsches
Title: [134581] trunk/LayoutTests








Revision 134581
Author dominik.rottsc...@intel.com
Date 2012-11-14 02:24:39 -0800 (Wed, 14 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

The bots don't have mercy today.

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (134580 => 134581)

--- trunk/LayoutTests/ChangeLog	2012-11-14 10:06:37 UTC (rev 134580)
+++ trunk/LayoutTests/ChangeLog	2012-11-14 10:24:39 UTC (rev 134581)
@@ -1,3 +1,11 @@
+2012-11-14  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+The bots don't have mercy today.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-11-14  Kent Tamura  
 
 Support for localization tests of calendar picker


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (134580 => 134581)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-14 10:06:37 UTC (rev 134580)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-14 10:24:39 UTC (rev 134581)
@@ -50,11 +50,8 @@
 # Crashes on plugin test.
 webkit.org/b/98747 plugins/document-open.html [ Crash ]
 
-# WebKitTestRunner needs an implementation for download attribute feature
-# The implementation for DumpRenderTree is on https://bugs.webkit.org/show_bug.cgi?id=96462
-# anchor-download-unset.html and anchor-nodownload.html are currently passed, but need to be checked along with below test cases
-Bug(EFL) fast/dom/HTMLAnchorElement/anchor-download.html [ Crash ]
-Bug(EFL) fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Crash ]
+webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ]
+webkit.org/b/102200 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Failure ]
 
 #Crash after r132386
 webkit.org/b/100342 fast/dom/nested-script-exceptions.html [ Crash ]
@@ -66,6 +63,9 @@
 
 webkit.org/b/101428 media/media-continues-playing-after-replace-source.html [ Crash ]
 
+webkit.org/b/102203 fast/events/attribute-listener-deletion-crash.html [ Crash ]
+webkit.org/b/102204 http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html [ Crash ]
+
 #
 # FLAKY TESTS
 #
@@ -294,3 +294,6 @@
 webkit.org/b/86881 fast/events/selectstart-prevent-selection-on-right-click.html [ Failure ]
 webkit.org/b/86881 media/context-menu-actions.html [ Failure ]
 webkit.org/b/86881 media/controls-right-click-on-timebar.html [ Failure ]
+
+webkit.org/b/102201 fast/dom/Window/window-resize.html [ Failure ]
+webkit.org/b/102202 inspector/timeline/timeline-timer-fired-from-eval-call-site.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [134571] trunk/Source/WebKit2

2012-11-14 Thread dominik . rottsches
Title: [134571] trunk/Source/WebKit2








Revision 134571
Author dominik.rottsc...@intel.com
Date 2012-11-14 01:24:14 -0800 (Wed, 14 Nov 2012)


Log Message
Unreviewed, rolling out r134531.
http://trac.webkit.org/changeset/134531
https://bugs.webkit.org/show_bug.cgi?id=102193

Makes >70 tests crash on EFL and Qt bots. (Requested by drott
on #webkit).

Patch by Sheriff Bot  on 2012-11-14

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
(WebCore::CoordinatedGraphicsLayer::setCoordinatedGraphicsLayerClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::createGraphicsLayer):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (134570 => 134571)

--- trunk/Source/WebKit2/ChangeLog	2012-11-14 09:22:30 UTC (rev 134570)
+++ trunk/Source/WebKit2/ChangeLog	2012-11-14 09:24:14 UTC (rev 134571)
@@ -1,3 +1,45 @@
+2012-11-14  Sheriff Bot  
+
+Unreviewed, rolling out r134531.
+http://trac.webkit.org/changeset/134531
+https://bugs.webkit.org/show_bug.cgi?id=102193
+
+Makes >70 tests crash on EFL and Qt bots. (Requested by drott
+on #webkit).
+
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
+(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
+(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
+(WebCore::CoordinatedGraphicsLayer::setChildren):
+(WebCore::CoordinatedGraphicsLayer::addChild):
+(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
+(WebCore::CoordinatedGraphicsLayer::addChildAbove):
+(WebCore::CoordinatedGraphicsLayer::addChildBelow):
+(WebCore::CoordinatedGraphicsLayer::replaceChild):
+(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
+(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
+(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
+(WebCore::CoordinatedGraphicsLayer::syncChildren):
+(WebCore::CoordinatedGraphicsLayer::syncFilters):
+(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
+(WebCore::CoordinatedGraphicsLayer::syncLayerState):
+(WebCore::CoordinatedGraphicsLayer::syncAnimations):
+(WebCore::CoordinatedGraphicsLayer::syncCanvas):
+(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
+(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreUpdatesAllowed):
+(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
+(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
+(WebCore::CoordinatedGraphicsLayer::createTile):
+(WebCore::CoordinatedGraphicsLayer::updateTile):
+(WebCore::CoordinatedGraphicsLayer::removeTile):
+(WebCore::CoordinatedGraphicsLayer::setCoordinatedGraphicsLayerClient):
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
+(CoordinatedGraphicsLayer):
+* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
+(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
+(WebKit::LayerTreeCoordinator::LayerTre

[webkit-changes] [134570] trunk/LayoutTests

2012-11-14 Thread dominik . rottsches
Title: [134570] trunk/LayoutTests








Revision 134570
Author dominik.rottsc...@intel.com
Date 2012-11-14 01:22:30 -0800 (Wed, 14 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

Mark two failures after r134456.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (134569 => 134570)

--- trunk/LayoutTests/ChangeLog	2012-11-14 08:54:48 UTC (rev 134569)
+++ trunk/LayoutTests/ChangeLog	2012-11-14 09:22:30 UTC (rev 134570)
@@ -1,3 +1,11 @@
+2012-11-14  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Mark two failures after r134456.
+
+* platform/efl/TestExpectations:
+
 2012-11-14  Kent Tamura  
 
 Support for localization tests of calendar picker


Modified: trunk/LayoutTests/platform/efl/TestExpectations (134569 => 134570)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-14 08:54:48 UTC (rev 134569)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-14 09:22:30 UTC (rev 134570)
@@ -1684,3 +1684,6 @@
 webkit.org/b/102097 svg/as-image/image-respects-deviceScaleFactor.html [ Skip ]
 
 webkit.org/b/102100 svg/repaint/inner-svg-change-viewBox.svg [ ImageOnlyFailure ]
+
+webkit.org/b/102190 compositing/overflow/updating-scrolling-content.html [ Failure ]
+webkit.org/b/102190 fast/events/overflow-scroll-fake-mouse-move.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [134060] trunk/Tools

2012-11-09 Thread dominik . rottsches
Title: [134060] trunk/Tools








Revision 134060
Author dominik.rottsc...@intel.com
Date 2012-11-09 06:28:37 -0800 (Fri, 09 Nov 2012)


Log Message
webkitpy/layouttests integration test fails if high shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Reviewed by Dirk Pranke.

Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_max_locked_shards):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (134059 => 134060)

--- trunk/Tools/ChangeLog	2012-11-09 14:25:47 UTC (rev 134059)
+++ trunk/Tools/ChangeLog	2012-11-09 14:28:37 UTC (rev 134060)
@@ -1,3 +1,15 @@
+2012-11-09  Dominik Röttsches  
+
+webkitpy/layouttests integration test fails if high shards/processes environment variables are used
+https://bugs.webkit.org/show_bug.cgi?id=101455
+
+Reviewed by Dirk Pranke.
+
+Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(MainTest.test_max_locked_shards):
+
 2012-11-09  Raphael Kubo da Costa  
 
 [EFL][DRT] Force a repaint before tracking repaint rects.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (134059 => 134060)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-11-09 14:25:47 UTC (rev 134059)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-11-09 14:28:37 UTC (rev 134060)
@@ -33,6 +33,7 @@
 import itertools
 import json
 import logging
+import os
 import platform
 import Queue
 import re
@@ -309,10 +310,19 @@
 self.assertTrue(len(batch) <= 2, '%s had too many tests' % ', '.join(batch))
 
 def test_max_locked_shards(self):
+# Tests for the default of using one locked shard even in the case of more than one child process.
 if not self.should_test_processes:
 return
+save_env_webkit_test_max_locked_shards = None
+if "WEBKIT_TEST_MAX_LOCKED_SHARDS" in os.environ:
+save_env_webkit_test_max_locked_shards = os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"]
+del os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"]
 _, _, regular_output, _ = logging_run(['--debug-rwt-logging', '--child-processes', '2'], shared_port=False)
-self.assertTrue(any(['(1 locked)' in line for line in regular_output.buflist]))
+try:
+self.assertTrue(any(['(1 locked)' in line for line in regular_output.buflist]))
+finally:
+if save_env_webkit_test_max_locked_shards:
+os.environ["WEBKIT_TEST_MAX_LOCKED_SHARDS"] = save_env_webkit_test_max_locked_shards
 
 def test_child_processes_2(self):
 if self.should_test_processes:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [134039] trunk/LayoutTests

2012-11-09 Thread dominik . rottsches
Title: [134039] trunk/LayoutTests








Revision 134039
Author dominik.rottsc...@intel.com
Date 2012-11-09 02:10:37 -0800 (Fri, 09 Nov 2012)


Log Message
[EFL] Skip failing test perf/accessibility-title-ui-element.html
https://bugs.webkit.org/show_bug.cgi?id=101728

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni  on 2012-11-09

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (134038 => 134039)

--- trunk/LayoutTests/ChangeLog	2012-11-09 10:09:16 UTC (rev 134038)
+++ trunk/LayoutTests/ChangeLog	2012-11-09 10:10:37 UTC (rev 134039)
@@ -1,5 +1,14 @@
 2012-11-09  Sudarsana Nagineni  
 
+[EFL] Skip failing test perf/accessibility-title-ui-element.html
+https://bugs.webkit.org/show_bug.cgi?id=101728
+
+Unreviewed EFL gardening.
+
+* platform/efl/TestExpectations:
+
+2012-11-09  Sudarsana Nagineni  
+
 [EFL] Update baselines for failing svg tests
 https://bugs.webkit.org/show_bug.cgi?id=101726
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (134038 => 134039)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-09 10:09:16 UTC (rev 134038)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-09 10:10:37 UTC (rev 134039)
@@ -624,6 +624,7 @@
 
 # The EFL port has no support for accessibility features
 Bug(EFL) accessibility [ Skip ]
+webkit.org/b/98895 perf/accessibility-title-ui-element.html [ Skip ]
 
 # Taken from Chromium, this test verifies that a mismatch reftest will fail if both results are the
 # same.  Because the whole point is that this test should fail when run, it's






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133876] trunk

2012-11-08 Thread dominik . rottsches
Title: [133876] trunk








Revision 133876
Author dominik.rottsc...@intel.com
Date 2012-11-08 03:32:19 -0800 (Thu, 08 Nov 2012)


Log Message
Unreviewed, rolling out r133865.
http://trac.webkit.org/changeset/133865
https://bugs.webkit.org/show_bug.cgi?id=101579

dependent patch has been rolled out. (Requested by drott on
#webkit).

Patch by Sheriff Bot  on 2012-11-08

* Source/cmake/OptionsEfl.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsEfl.cmake




Diff

Modified: trunk/ChangeLog (133875 => 133876)

--- trunk/ChangeLog	2012-11-08 11:21:58 UTC (rev 133875)
+++ trunk/ChangeLog	2012-11-08 11:32:19 UTC (rev 133876)
@@ -1,3 +1,14 @@
+2012-11-08  Sheriff Bot  
+
+Unreviewed, rolling out r133865.
+http://trac.webkit.org/changeset/133865
+https://bugs.webkit.org/show_bug.cgi?id=101579
+
+dependent patch has been rolled out. (Requested by drott on
+#webkit).
+
+* Source/cmake/OptionsEfl.cmake:
+
 2012-11-08  Dominik Röttsches  
 
 Unreviewed, rolling out r133859.


Modified: trunk/Source/cmake/OptionsEfl.cmake (133875 => 133876)

--- trunk/Source/cmake/OptionsEfl.cmake	2012-11-08 11:21:58 UTC (rev 133875)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-11-08 11:32:19 UTC (rev 133876)
@@ -94,7 +94,6 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WORKERS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XHR_TIMEOUT ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(WTF_USE_TILED_BACKING_STORE ON)
 
 # FIXME: Perhaps we need a more generic way of defining dependencies between features.
 # VIDEO_TRACK depends on VIDEO.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133875] trunk

2012-11-08 Thread dominik . rottsches
Title: [133875] trunk








Revision 133875
Author dominik.rottsc...@intel.com
Date 2012-11-08 03:21:58 -0800 (Thu, 08 Nov 2012)


Log Message
Unreviewed, rolling out r133859.
http://trac.webkit.org/changeset/133859
https://bugs.webkit.org/show_bug.cgi?id=101526

Breaks EFL bots test execution.

.:

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm




Diff

Modified: trunk/ChangeLog (133874 => 133875)

--- trunk/ChangeLog	2012-11-08 10:49:38 UTC (rev 133874)
+++ trunk/ChangeLog	2012-11-08 11:21:58 UTC (rev 133875)
@@ -1,3 +1,13 @@
+2012-11-08  Dominik Röttsches  
+
+Unreviewed, rolling out r133859.
+http://trac.webkit.org/changeset/133859
+https://bugs.webkit.org/show_bug.cgi?id=101526
+
+Breaks EFL bots test execution.
+
+* Source/cmake/OptionsEfl.cmake:
+
 2012-11-08  Raphael Kubo da Costa  
 
 [EFL] Turn WTF_USE_TILED_BACKING_STORE in OptionsEfl.cmake.


Modified: trunk/Source/cmake/OptionsEfl.cmake (133874 => 133875)

--- trunk/Source/cmake/OptionsEfl.cmake	2012-11-08 10:49:38 UTC (rev 133874)
+++ trunk/Source/cmake/OptionsEfl.cmake	2012-11-08 11:21:58 UTC (rev 133875)
@@ -189,13 +189,11 @@
   SET(ENABLE_3D_RENDERING 1)
   ADD_DEFINITIONS(-DENABLE_3D_RENDERING=1)
 
-  FIND_PACKAGE(OpenGL REQUIRED)
-ENDIF()
-
-IF (ENABLE_WEBGL)
   SET (ENABLE_WEBGL 1)
   ADD_DEFINITIONS(-DWTF_USE_GRAPHICS_SURFACE=1)
   ADD_DEFINITIONS(-DHAVE_GLX)
+
+  FIND_PACKAGE(OpenGL REQUIRED)
 ENDIF()
 
 IF (ENABLE_SPELLCHECK)


Modified: trunk/Tools/ChangeLog (133874 => 133875)

--- trunk/Tools/ChangeLog	2012-11-08 10:49:38 UTC (rev 133874)
+++ trunk/Tools/ChangeLog	2012-11-08 11:21:58 UTC (rev 133875)
@@ -1,3 +1,13 @@
+2012-11-08  Dominik Röttsches  
+
+Unreviewed, rolling out r133859.
+http://trac.webkit.org/changeset/133859
+https://bugs.webkit.org/show_bug.cgi?id=101526
+
+Breaks EFL bots test execution.
+
+* Scripts/webkitperl/FeatureList.pm:
+
 2012-11-08  Csaba Osztrogonác  
 
 [Qt] Reduce the number of clean builds


Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (133874 => 133875)

--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-11-08 10:49:38 UTC (rev 133874)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2012-11-08 11:21:58 UTC (rev 133875)
@@ -391,7 +391,7 @@
   define => "ENABLE_TEXT_AUTOSIZING", default => 0, value => \$textAutosizingSupport },
 
 { option => "tiled-backing-store", desc => "Toggle Tiled Backing Store support",
-  define => "WTF_USE_TILED_BACKING_STORE", default => (isQt() || isEfl()), value => \$tiledBackingStoreSupport },
+  define => "WTF_USE_TILED_BACKING_STORE", default => isQt(), value => \$tiledBackingStoreSupport },
 
 { option => "touch-events", desc => "Toggle Touch Events support",
   define => "ENABLE_TOUCH_EVENTS", default => (isQt() || isBlackBerry() || isEfl()), value => \$touchEventsSupport },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133754] trunk/LayoutTests

2012-11-07 Thread dominik . rottsches
Title: [133754] trunk/LayoutTests








Revision 133754
Author dominik.rottsc...@intel.com
Date 2012-11-07 06:52:02 -0800 (Wed, 07 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

Rebaselining a few ruby tests.

* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png
trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (133753 => 133754)

--- trunk/LayoutTests/ChangeLog	2012-11-07 14:42:12 UTC (rev 133753)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 14:52:02 UTC (rev 133754)
@@ -1,3 +1,16 @@
+2012-11-07  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Rebaselining a few ruby tests.
+
+* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
+* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
+* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
+* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
+* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
+* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
+
 2012-11-07  Csaba Osztrogonác  
 
 [Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expected files.


Modified: trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt (133753 => 133754)

--- trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt	2012-11-07 14:42:12 UTC (rev 133753)
+++ trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt	2012-11-07 14:52:02 UTC (rev 133754)
@@ -1,23 +1,23 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,503) size 800x97
-  RenderBlock {HTML} at (0,0) size 800x97 [border: (10px solid #80)]
-RenderBody {BODY} at (18,18) size 764x61
-  RenderText {#text} at (0,0) size 220x45
-text run at (0,0) width 220: "\x{653B}\x{6BBB} \x{6A5F}\x{52D5}\x{968A} "
-  RenderRuby (inline) {RUBY} at (0,0) size 200x40
-RenderRubyRun (anonymous) at (220,1) size 80x40
-  RenderRubyText {RT} at (0,40) size 80x20
-RenderText {#text} at (0,0) size 80x20
+layer at (0,496) size 800x104
+  RenderBlock {HTML} at (0,0) size 800x104 [border: (10px solid #80)]
+RenderBody {BODY} at (18,18) size 764x68
+  RenderText {#text} at (0,1) size 220x45
+text run at (0,1) width 220: "\x{653B}\x{6BBB} \x{6A5F}\x{52D5}\x{968A} "
+  RenderRuby (inline) {RUBY} at (0,0) size 200x45
+RenderRubyRun (anonymous) at (220,0) size 80x46
+  RenderRubyText {RT} at (0,45) size 80x23
+RenderText {#text} at (0,0) size 80x23
   text run at (0,0) width 80: "\x{3053}\x{3046}\x{304B}\x{304F}"
-  RenderRubyBase (anonymous) at (0,0) size 80x40
-RenderText {#text} at (0,0) size 80x40
+  RenderRubyBase (anonymous) at (0,0) size 80x46
+RenderText {#text} at (0,0) size 80x45
   text run at (0,0) width 80: "\x{653B}\x{6BBB}"
-RenderRubyRun (anonymous) at (300,1) size 120x40
-  RenderRubyText {RT} at (0,40) size 120x20
-RenderText {#text} at (10,0) size 100x20
+RenderRubyRun (anonymous) at (300,0) size 120x46
+  RenderRubyText {RT} at (0,45) size 120x23
+RenderText {#text} at (10,0) size 100x23
   text run at (10,0) width 100: "\x{304D}\x{3069}\x{3046}\x{305F}\x{3044}"
-  RenderRubyBase (anonymous) at (0,0) size 120x40
-RenderText {#text} at (0,0) size 120x40
+  RenderRubyBase (anonymous) at (0,0) size 120x46
+RenderText {#text} at (0,0) size 120x45
   text run at (0,0) width 120: "\x{6A5F}\x{52D5}\x{968A}"
   RenderText {#text} at (0,0) size 0x0


Modified: trunk/LayoutTests/platform/efl/fast/writing-mode/japanese-ruby-vertical-

[webkit-changes] [133748] trunk/LayoutTests

2012-11-07 Thread dominik . rottsches
Title: [133748] trunk/LayoutTests








Revision 133748
Author dominik.rottsc...@intel.com
Date 2012-11-07 05:57:31 -0800 (Wed, 07 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

navigator-vibration.html is still crashing occasionally.

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (133747 => 133748)

--- trunk/LayoutTests/ChangeLog	2012-11-07 13:53:57 UTC (rev 133747)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 13:57:31 UTC (rev 133748)
@@ -1,3 +1,11 @@
+2012-11-07  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+navigator-vibration.html is still crashing occasionally.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-11-07  Andrey Adaikin  
 
 Web Inspector: [Canvas] Save CanvasGradient objects state for a replay


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133747 => 133748)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 13:53:57 UTC (rev 133747)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 13:57:31 UTC (rev 133748)
@@ -66,6 +66,8 @@
 
 webkit.org/b/101428 media/media-continues-playing-after-replace-source.html [ Crash ]
 
+webkit.org/b/100334 fast/dom/navigator-vibration.html [ Crash ]
+
 #
 # FLAKY TESTS
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133735] trunk/Tools

2012-11-07 Thread dominik . rottsches
Title: [133735] trunk/Tools








Revision 133735
Author dominik.rottsc...@intel.com
Date 2012-11-07 04:28:30 -0800 (Wed, 07 Nov 2012)


Log Message
[EFL] Switch the efl-linux-slave-2 to Wk2 Release
https://bugs.webkit.org/show_bug.cgi?id=101345

Reviewed by Gyuyoung Kim.

Switching efl-linux-slave-2 to Wk2 Release.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (133734 => 133735)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-11-07 11:14:32 UTC (rev 133734)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-11-07 12:28:30 UTC (rev 133735)
@@ -314,8 +314,8 @@
   "slavenames": ["efl-linux-slave-1"]
 },
 {
-  "name": "EFL Linux 64-bit Debug", "type": "BuildAndTest", "builddir": "efl-linux-64-debug",
-  "platform": "efl", "configuration": "debug", "architectures": ["x86_64"],
+  "name": "EFL Linux 64-bit Release WK2", "type": "BuildAndTestWebKit2", "builddir": "efl-linux-64-release-wk2",
+  "platform": "efl", "configuration": "release", "architectures": ["x86_64"],
   "slavenames": ["efl-linux-slave-2"]
 },
 {
@@ -337,7 +337,7 @@
"Qt Windows 32-bit Release", "Qt Windows 32-bit Debug", "Qt Mountain Lion Release",
"Chromium Win Release", "Chromium Mac Release", "Chromium Linux Release",
"Chromium Android Release",
-   "EFL Linux 64-bit Release", "EFL Linux 64-bit Debug", "EFL Linux 32-bit Release (Build)", "EFL Linux 64-bit Debug WK2",
+   "EFL Linux 64-bit Release", "EFL Linux 64-bit Release WK2", "EFL Linux 32-bit Release (Build)", "EFL Linux 64-bit Debug WK2",
"WinCairo Release", "WinCE Release (Build)"]
 },
 { "type": "PlatformSpecificScheduler", "platform": "mac-lion", "branch": "trunk", "treeStableTimer": 45.0,


Modified: trunk/Tools/ChangeLog (133734 => 133735)

--- trunk/Tools/ChangeLog	2012-11-07 11:14:32 UTC (rev 133734)
+++ trunk/Tools/ChangeLog	2012-11-07 12:28:30 UTC (rev 133735)
@@ -1,3 +1,14 @@
+2012-11-07  Dominik Röttsches  
+
+[EFL] Switch the efl-linux-slave-2 to Wk2 Release
+https://bugs.webkit.org/show_bug.cgi?id=101345
+
+Reviewed by Gyuyoung Kim.
+
+Switching efl-linux-slave-2 to Wk2 Release.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2012-11-07  Christophe Dumez  
 
 Add replaceWithLiteral() method to WTF::String






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133732] trunk/LayoutTests

2012-11-07 Thread dominik . rottsches
Title: [133732] trunk/LayoutTests








Revision 133732
Author dominik.rottsc...@intel.com
Date 2012-11-07 01:45:32 -0800 (Wed, 07 Nov 2012)


Log Message
[EFL] Unreviewed gardening.

Marking new test media/progress-events-generated-correctly.html as failing on EFL.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (133731 => 133732)

--- trunk/LayoutTests/ChangeLog	2012-11-07 09:43:05 UTC (rev 133731)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 09:45:32 UTC (rev 133732)
@@ -1,5 +1,13 @@
 2012-11-07  Dominik Röttsches  
 
+[EFL] Unreviewed gardening.
+
+Marking new test media/progress-events-generated-correctly.html as failing on EFL.
+
+* platform/efl/TestExpectations:
+
+2012-11-07  Dominik Röttsches  
+
 [EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
 https://bugs.webkit.org/show_bug.cgi?id=101343
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (133731 => 133732)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-07 09:43:05 UTC (rev 133731)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-07 09:45:32 UTC (rev 133732)
@@ -1684,3 +1684,6 @@
 
 webkit.org/b/100846 inspector-protocol/debugger-pause-dedicated-worker.html [ Skip ]
 webkit.org/b/100846 inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html [ Skip ]
+
+# New media test introduced in r133660 fails.
+webkit.org/b/101439 media/progress-events-generated-correctly.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133728] trunk

2012-11-07 Thread dominik . rottsches
Title: [133728] trunk








Revision 133728
Author dominik.rottsc...@intel.com
Date 2012-11-07 00:40:34 -0800 (Wed, 07 Nov 2012)


Log Message
[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
https://bugs.webkit.org/show_bug.cgi?id=101343

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add Cairo to the list of backends that support shouldRespectImageOrientation.

No new tests, fixes exif-orientation-image-document.html.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

LayoutTests:

Unskipping exif-orientation-image-document.html now that respecting
orientation is default enabled for image documents.

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (133727 => 133728)

--- trunk/LayoutTests/ChangeLog	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 08:40:34 UTC (rev 133728)
@@ -1,3 +1,15 @@
+2012-11-07  Dominik Röttsches  
+
+[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
+https://bugs.webkit.org/show_bug.cgi?id=101343
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Unskipping exif-orientation-image-document.html now that respecting
+orientation is default enabled for image documents.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-11-06  Yury Semikhatsky  
 
 Console not displaying all properties of an Object once native Constructor overwritten


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133727 => 133728)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 08:40:34 UTC (rev 133728)
@@ -256,9 +256,6 @@
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-true.html [ Failure ]
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-setProperty.html [ Failure ]
 
-# Test fails because WebKit is in shouldRespectImageOrientation=0 mode.
-webkit.org/b/101343 fast/images/exif-orientation-image-document.html [ Failure ]
-
 # Http plugin test failures.
 webkit.org/b/99561 http/tests/plugins/plugin-document-has-focus.html [ Failure ]
 webkit.org/b/99562 http/tests/plugins/post-url-file.html [ Failure ]


Modified: trunk/Source/WebCore/ChangeLog (133727 => 133728)

--- trunk/Source/WebCore/ChangeLog	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/Source/WebCore/ChangeLog	2012-11-07 08:40:34 UTC (rev 133728)
@@ -1,3 +1,17 @@
+2012-11-07  Dominik Röttsches  
+
+[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
+https://bugs.webkit.org/show_bug.cgi?id=101343
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add Cairo to the list of backends that support shouldRespectImageOrientation.
+
+No new tests, fixes exif-orientation-image-document.html.
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::shouldRespectImageOrientation):
+
 2012-11-06  Yury Semikhatsky  
 
 Console not displaying all properties of an Object once native Constructor overwritten


Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (133727 => 133728)

--- trunk/Source/WebCore/rendering/RenderObject.cpp	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2012-11-07 08:40:34 UTC (rev 133728)
@@ -2227,7 +2227,7 @@
 // Respect the image's orientation if it's being used as a full-page image or it's
 // an  and the setting to respect it everywhere is set.
 return
-#if USE(CG) || PLATFORM(CHROMIUM)
+#if USE(CG) || PLATFORM(CHROMIUM) || USE(CAIRO)
 // This can only be enabled for ports which honor the orientation flag in their drawing code.
 document()->isImageDocument() ||
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133445] trunk/LayoutTests

2012-11-05 Thread dominik . rottsches
Title: [133445] trunk/LayoutTests








Revision 133445
Author dominik.rottsc...@intel.com
Date 2012-11-05 01:33:50 -0800 (Mon, 05 Nov 2012)


Log Message
[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
https://bugs.webkit.org/show_bug.cgi?id=101181

Unreviewed EFL gardening.

Mark compositing/repaint/invalidations-on-composited-layers.html as
expected to fail since accelerated compositing is disabled by default
on EFL port.

Patch by Christophe Dumez  on 2012-11-05

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (133444 => 133445)

--- trunk/LayoutTests/ChangeLog	2012-11-05 09:23:05 UTC (rev 133444)
+++ trunk/LayoutTests/ChangeLog	2012-11-05 09:33:50 UTC (rev 133445)
@@ -1,3 +1,16 @@
+2012-11-05  Christophe Dumez  
+
+[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
+https://bugs.webkit.org/show_bug.cgi?id=101181
+
+Unreviewed EFL gardening.
+
+Mark compositing/repaint/invalidations-on-composited-layers.html as
+expected to fail since accelerated compositing is disabled by default
+on EFL port.
+
+* platform/efl/TestExpectations:
+
 2012-11-05  Zan Dobersek  
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (133444 => 133445)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-11-05 09:23:05 UTC (rev 133444)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-11-05 09:33:50 UTC (rev 133445)
@@ -1110,6 +1110,7 @@
 webkit.org/b/79766 compositing/overflow/textarea-scroll-touch.html [ Failure ]
 webkit.org/b/79766 compositing/plugins/no-backing-store.html [ Failure ]
 webkit.org/b/79766 compositing/plugins/small-to-large-composited-plugin.html [ Failure ]
+webkit.org/b/79766 compositing/repaint/invalidations-on-composited-layers.html [ Failure ]
 webkit.org/b/79766 compositing/rtl/rtl-absolute-overflow-scrolled.html [ Failure ]
 webkit.org/b/79766 compositing/rtl/rtl-absolute-overflow.html [ Failure ]
 webkit.org/b/79766 compositing/rtl/rtl-absolute.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133026] trunk/LayoutTests

2012-10-31 Thread dominik . rottsches
Title: [133026] trunk/LayoutTests








Revision 133026
Author dominik.rottsc...@intel.com
Date 2012-10-31 07:13:18 -0700 (Wed, 31 Oct 2012)


Log Message
[EFL][GTK] Unreviewed gardening.

Removing duplicate in EFL file, changing bug number for exif orientation bug in GTK.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (133025 => 133026)

--- trunk/LayoutTests/ChangeLog	2012-10-31 14:01:59 UTC (rev 133025)
+++ trunk/LayoutTests/ChangeLog	2012-10-31 14:13:18 UTC (rev 133026)
@@ -2,6 +2,15 @@
 
 [EFL][GTK] Unreviewed gardening.
 
+Removing duplicate in EFL file, changing bug number for exif orientation bug in GTK.
+
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+
+2012-10-31  Dominik Röttsches  
+
+[EFL][GTK] Unreviewed gardening.
+
 Exif orientation test marked as failing for GTK & EFL,
 On EFL, the vibration IPC issue may cause crash, see bug 100334.
 


Modified: trunk/LayoutTests/platform/efl/TestExpectations (133025 => 133026)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-10-31 14:01:59 UTC (rev 133025)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-10-31 14:13:18 UTC (rev 133026)
@@ -1665,6 +1665,3 @@
 
 # ESC key does not cancel context menu in EFL port
 Bug(EFL) editing/selection/5354455-1.html [ Failure ]
-
-# Exif Image Orientation not correctly interpreted in image documents
-webkit.org/b/100852 fast/images/exif-orientation.html [ Missing ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (133025 => 133026)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-31 14:01:59 UTC (rev 133025)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-31 14:13:18 UTC (rev 133026)
@@ -1426,7 +1426,7 @@
 
 webkit.org/b/98718 svg/animations/animate-css-xml-attributeType.html [ Failure ]
 
-webkit.org/b/100852 fast/images/exif-orientation.html [ Failure ]
+webkit.org/b/95299 fast/images/exif-orientation.html [ Failure ]
 
 #
 # End of Tests failing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [133025] trunk/LayoutTests

2012-10-31 Thread dominik . rottsches
Title: [133025] trunk/LayoutTests








Revision 133025
Author dominik.rottsc...@intel.com
Date 2012-10-31 07:01:59 -0700 (Wed, 31 Oct 2012)


Log Message
[EFL][GTK] Unreviewed gardening.

Exif orientation test marked as failing for GTK & EFL,
On EFL, the vibration IPC issue may cause crash, see bug 100334.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (133024 => 133025)

--- trunk/LayoutTests/ChangeLog	2012-10-31 14:01:43 UTC (rev 133024)
+++ trunk/LayoutTests/ChangeLog	2012-10-31 14:01:59 UTC (rev 133025)
@@ -1,3 +1,14 @@
+2012-10-31  Dominik Röttsches  
+
+[EFL][GTK] Unreviewed gardening.
+
+Exif orientation test marked as failing for GTK & EFL,
+On EFL, the vibration IPC issue may cause crash, see bug 100334.
+
+* platform/efl-wk2/TestExpectations:
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2012-10-31  Raphael Kubo da Costa  
 
 [EFL] More unreviewed gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (133024 => 133025)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-10-31 14:01:43 UTC (rev 133024)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-10-31 14:01:59 UTC (rev 133025)
@@ -1665,3 +1665,6 @@
 
 # ESC key does not cancel context menu in EFL port
 Bug(EFL) editing/selection/5354455-1.html [ Failure ]
+
+# Exif Image Orientation not correctly interpreted in image documents
+webkit.org/b/100852 fast/images/exif-orientation.html [ Missing ]


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133024 => 133025)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-31 14:01:43 UTC (rev 133024)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-31 14:01:59 UTC (rev 133025)
@@ -57,6 +57,8 @@
 webkit.org/b/100342 networkinformation/add-listener-from-callback.html [ Crash ]
 webkit.org/b/100342 networkinformation/basic-operation.html [ Crash ]
 
+webkit.org/b/100334 fast/dom/navigator-vibration.html [ Crash ]
+
 #
 # FLAKY TESTS
 #


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (133024 => 133025)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-31 14:01:43 UTC (rev 133024)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-31 14:01:59 UTC (rev 133025)
@@ -1426,6 +1426,8 @@
 
 webkit.org/b/98718 svg/animations/animate-css-xml-attributeType.html [ Failure ]
 
+webkit.org/b/100852 fast/images/exif-orientation.html [ Failure ]
+
 #
 # End of Tests failing
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132638] trunk/LayoutTests

2012-10-26 Thread dominik . rottsches
Title: [132638] trunk/LayoutTests








Revision 132638
Author dominik.rottsc...@intel.com
Date 2012-10-26 05:54:40 -0700 (Fri, 26 Oct 2012)


Log Message
Unreviewed Apple Win gardening.

* platform/win/TestExpectations: Skipping XHR timeout tests.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132637 => 132638)

--- trunk/LayoutTests/ChangeLog	2012-10-26 12:48:54 UTC (rev 132637)
+++ trunk/LayoutTests/ChangeLog	2012-10-26 12:54:40 UTC (rev 132638)
@@ -1,3 +1,9 @@
+2012-10-26  Dominik Röttsches  
+
+Unreviewed Apple Win gardening.
+
+* platform/win/TestExpectations: Skipping XHR timeout tests.
+
 2012-10-26  Zan Dobersek  
 
 Unreviewed. Removing bogus '#EOF\n' data in the listed PNG file that's


Modified: trunk/LayoutTests/platform/win/TestExpectations (132637 => 132638)

--- trunk/LayoutTests/platform/win/TestExpectations	2012-10-26 12:48:54 UTC (rev 132637)
+++ trunk/LayoutTests/platform/win/TestExpectations	2012-10-26 12:54:40 UTC (rev 132638)
@@ -2360,3 +2360,14 @@
 # https://bugs.webkit.org/show_bug.cgi?id=99567
 # Not supported on Mac or Windows ports
 inspector/elements/update-shadowdom.html
+
+# Not supported in CFNetwork yet. https://bugs.webkit.org/show_bug.cgi?id=100349
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html
+http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132630] trunk/Source/WebCore

2012-10-26 Thread dominik . rottsches
Title: [132630] trunk/Source/WebCore








Revision 132630
Author dominik.rottsc...@intel.com
Date 2012-10-26 05:24:15 -0700 (Fri, 26 Oct 2012)


Log Message
Unreviewed, rolling out r132493.
http://trac.webkit.org/changeset/132493
https://bugs.webkit.org/show_bug.cgi?id=100509

It didn't fix the tests on the bot as we had hoped. (Requested
by drott on #webkit).

Patch by Sheriff Bot  on 2012-10-26

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (132629 => 132630)

--- trunk/Source/WebCore/ChangeLog	2012-10-26 12:19:46 UTC (rev 132629)
+++ trunk/Source/WebCore/ChangeLog	2012-10-26 12:24:15 UTC (rev 132630)
@@ -1,3 +1,15 @@
+2012-10-26  Sheriff Bot  
+
+Unreviewed, rolling out r132493.
+http://trac.webkit.org/changeset/132493
+https://bugs.webkit.org/show_bug.cgi?id=100509
+
+It didn't fix the tests on the bot as we had hoped. (Requested
+by drott on #webkit).
+
+* platform/network/cf/ResourceErrorCF.cpp:
+(WebCore::ResourceError::ResourceError):
+
 2012-10-26  Zeno Albisser  
 
 [Qt] Temporarily disable use of QXcbNativeInterface in GraphicsSurfaceGLX.


Modified: trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp (132629 => 132630)

--- trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2012-10-26 12:19:46 UTC (rev 132629)
+++ trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2012-10-26 12:24:15 UTC (rev 132630)
@@ -45,8 +45,6 @@
 , m_platformError(cfError)
 {
 m_isNull = !cfError;
-if (!m_isNull)
-m_isTimeout = CFErrorGetCode(m_platformError.get()) == kCFURLErrorTimedOut;
 }
 
 #if PLATFORM(WIN)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132493] trunk/Source/WebCore

2012-10-25 Thread dominik . rottsches
Title: [132493] trunk/Source/WebCore








Revision 132493
Author dominik.rottsc...@intel.com
Date 2012-10-25 09:28:48 -0700 (Thu, 25 Oct 2012)


Log Message
Init timeout flag in ResourceErrorCF
https://bugs.webkit.org/show_bug.cgi?id=100349

Reviewed by Alexey Proskuryakov.

Initialize the timeout property to true if the network error was a timeout error.
This is a speculative fix for the XHR timeout test cases failing on Apple Win -
I can't verify this on a local machine.

No new tests, covered by
LayoutTests/http/tests/xmlhttprequest/timeout/*

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError): Init m_timeout from error code.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (132492 => 132493)

--- trunk/Source/WebCore/ChangeLog	2012-10-25 16:09:01 UTC (rev 132492)
+++ trunk/Source/WebCore/ChangeLog	2012-10-25 16:28:48 UTC (rev 132493)
@@ -1,3 +1,20 @@
+2012-10-25  Dominik Röttsches  
+
+Init timeout flag in ResourceErrorCF
+https://bugs.webkit.org/show_bug.cgi?id=100349
+
+Reviewed by Alexey Proskuryakov.
+
+Initialize the timeout property to true if the network error was a timeout error.
+This is a speculative fix for the XHR timeout test cases failing on Apple Win -
+I can't verify this on a local machine.
+
+No new tests, covered by
+LayoutTests/http/tests/xmlhttprequest/timeout/*
+
+* platform/network/cf/ResourceErrorCF.cpp:
+(WebCore::ResourceError::ResourceError): Init m_timeout from error code.
+
 2012-10-25  Kenneth Rohde Christiansen  
 
 'resolution' MQ: Printing should use use high resolution images when available


Modified: trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp (132492 => 132493)

--- trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2012-10-25 16:09:01 UTC (rev 132492)
+++ trunk/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp	2012-10-25 16:28:48 UTC (rev 132493)
@@ -45,6 +45,8 @@
 , m_platformError(cfError)
 {
 m_isNull = !cfError;
+if (!m_isNull)
+m_isTimeout = CFErrorGetCode(m_platformError.get()) == kCFURLErrorTimedOut;
 }
 
 #if PLATFORM(WIN)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132353] trunk/Source/WebKit2

2012-10-24 Thread dominik . rottsches
Title: [132353] trunk/Source/WebKit2








Revision 132353
Author dominik.rottsc...@intel.com
Date 2012-10-24 07:41:19 -0700 (Wed, 24 Oct 2012)


Log Message
[EFL][AC] Fix build break when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100245

Patch by Sudarsana Nagineni  on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Fix build break after r132337.

* UIProcess/API/efl/EwkViewImpl.h:
* UIProcess/API/efl/ewk_view.cpp:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (132352 => 132353)

--- trunk/Source/WebKit2/ChangeLog	2012-10-24 14:38:11 UTC (rev 132352)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-24 14:41:19 UTC (rev 132353)
@@ -1,3 +1,15 @@
+2012-10-24  Sudarsana Nagineni  
+
+[EFL][AC] Fix build break when AC is enabled
+https://bugs.webkit.org/show_bug.cgi?id=100245
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Fix build break after r132337.
+
+* UIProcess/API/efl/EwkViewImpl.h:
+* UIProcess/API/efl/ewk_view.cpp:
+
 2012-10-24  Thiago Marcos P. Santos  
 
 [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb


Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h (132352 => 132353)

--- trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h	2012-10-24 14:38:11 UTC (rev 132352)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h	2012-10-24 14:41:19 UTC (rev 132353)
@@ -30,6 +30,10 @@
 #include 
 #include 
 
+#if USE(ACCELERATED_COMPOSITING)
+#include 
+#endif
+
 #define EWK_VIEW_PRIV_GET(smartData, priv) \
 EwkViewImpl* priv = smartData->priv
 


Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp (132352 => 132353)

--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2012-10-24 14:38:11 UTC (rev 132352)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp	2012-10-24 14:41:19 UTC (rev 132353)
@@ -75,10 +75,6 @@
 #include "WebInspectorProxy.h"
 #endif
 
-#if USE(ACCELERATED_COMPOSITING)
-#include 
-#endif
-
 #if USE(TILED_BACKING_STORE)
 #include "PageViewportController.h"
 #include "PageViewportControllerClientEfl.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132351] trunk/LayoutTests

2012-10-24 Thread dominik . rottsches
Title: [132351] trunk/LayoutTests








Revision 132351
Author dominik.rottsc...@intel.com
Date 2012-10-24 07:34:18 -0700 (Wed, 24 Oct 2012)


Log Message
[EFL] Unreviewed gardening.

* platform/efl-wk1/TestExpectations: Marking shadow-dom failures after r132303
* platform/efl-wk2/TestExpectations: Marking focus failure after r132342 and drag-select failure between r132333-r132343.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132350 => 132351)

--- trunk/LayoutTests/ChangeLog	2012-10-24 14:33:47 UTC (rev 132350)
+++ trunk/LayoutTests/ChangeLog	2012-10-24 14:34:18 UTC (rev 132351)
@@ -1,3 +1,10 @@
+2012-10-24  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+* platform/efl-wk1/TestExpectations: Marking shadow-dom failures after r132303
+* platform/efl-wk2/TestExpectations: Marking focus failure after r132342 and drag-select failure between r132333-r132343.
+
 2012-10-24  Eric Carlson  
 
 Allow ports to override text track rendering style


Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (132350 => 132351)

--- trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-10-24 14:33:47 UTC (rev 132350)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations	2012-10-24 14:34:18 UTC (rev 132351)
@@ -308,3 +308,8 @@
 webkit.org/b/99824 fast/lists/w3-css3-list-styles-alphabetic.html [ Failure ]
 webkit.org/b/99824 fast/lists/w3-css3-list-styles-fallback-style.html [ Failure ]
 webkit.org/b/99824 fast/lists/w3-list-styles.html [ Failure ]
+
+# Failing after r132303
+webkit.org/b/100246 fast/dom/shadow/shadowdom-dynamic-styling.html [ Failure ] 
+webkit.org/b/100246 fast/dom/shadow/style-scoped-not-enabled.html [ Failure ] 
+webkit.org/b/100246 fast/dom/shadow/athost-atrules.html [ Crash ]


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (132350 => 132351)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-24 14:33:47 UTC (rev 132350)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-24 14:34:18 UTC (rev 132351)
@@ -264,3 +264,8 @@
 
 # EFL WK2 does not support the spellchecker feature
 webkit.org/b/91854 editing/spelling [ Skip ]
+
+webkit.org/b/100248 fast/forms/select-multiple-elements-with-mouse-drag.html [ Failure ]
+
+# Spurious output after fixing flakiness
+webkit.org/b/100010 fast/events/frame-tab-focus.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132064] trunk/LayoutTests

2012-10-22 Thread dominik . rottsches
Title: [132064] trunk/LayoutTests








Revision 132064
Author dominik.rottsc...@intel.com
Date 2012-10-22 04:39:27 -0700 (Mon, 22 Oct 2012)


Log Message
[EFL][WK2] Skip plugins/npruntime/remove-property.html
https://bugs.webkit.org/show_bug.cgi?id=99978

Unreviewed EFL gardening.

Skip plugins/npruntime/remove-property.html which started
failing after r131990.

Patch by Christophe Dumez  on 2012-10-22

* platform/efl-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (132063 => 132064)

--- trunk/LayoutTests/ChangeLog	2012-10-22 11:23:13 UTC (rev 132063)
+++ trunk/LayoutTests/ChangeLog	2012-10-22 11:39:27 UTC (rev 132064)
@@ -1,3 +1,15 @@
+2012-10-22  Christophe Dumez  
+
+[EFL][WK2] Skip plugins/npruntime/remove-property.html
+https://bugs.webkit.org/show_bug.cgi?id=99978
+
+Unreviewed EFL gardening.
+
+Skip plugins/npruntime/remove-property.html which started
+failing after r131990.
+
+* platform/efl-wk2/TestExpectations:
+
 2012-10-22  Dongwoo Joshua Im  
 
 Change the path of the include files in the text decoration test cases.


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (132063 => 132064)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-22 11:23:13 UTC (rev 132063)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-22 11:39:27 UTC (rev 132064)
@@ -247,6 +247,9 @@
 # NPP_SetWindow is not called during plugin destruction on X11.
 webkit.org/b/63261 plugins/npp-set-window-called-during-destruction.html [ Failure ]
 
+# Test started failing on all WK2 ports after r131990.
+webkit.org/b/99977 plugins/npruntime/remove-property.html [ Failure ]
+
 # Delete plugin failures.
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-false.html [ Failure ]
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-true.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [132062] trunk/Tools

2012-10-22 Thread dominik . rottsches
Title: [132062] trunk/Tools








Revision 132062
Author dominik.rottsc...@intel.com
Date 2012-10-22 03:56:26 -0700 (Mon, 22 Oct 2012)


Log Message
Adding Cairo and Harfbuzz watchlist entries

Unreviewed watchlist update.

Added myself to these new ones and SVG.

* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (132061 => 132062)

--- trunk/Tools/ChangeLog	2012-10-22 10:49:16 UTC (rev 132061)
+++ trunk/Tools/ChangeLog	2012-10-22 10:56:26 UTC (rev 132062)
@@ -1,3 +1,13 @@
+2012-10-22  Dominik Röttsches  
+
+Adding Cairo and Harfbuzz watchlist entries
+
+Unreviewed watchlist update.
+
+Added myself to these new ones and SVG.
+
+* Scripts/webkitpy/common/config/watchlist:
+
 2012-10-22  Yury Semikhatsky  
 
 Web Inspector: do not double count memory of objects with multiple ancestors


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (132061 => 132062)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-10-22 10:49:16 UTC (rev 132061)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2012-10-22 10:56:26 UTC (rev 132062)
@@ -269,6 +269,12 @@
 "filename": r"Source/WebCore/accessibility"
 r"|LayoutTests/.*accessibility",
 },
+"Cairo": {
+"filename": r"Source/WebCore/platform/graphics/cairo",
+},
+"Harfbuzz": {
+"filename": r"Source/WebCore/platform/graphics/harfbuzz",
+}
 },
 "CC_RULES": {
 # Note: All email addresses listed must be registered with bugzilla.
@@ -278,6 +284,7 @@
 "AppleMacPublicApi": [ "timo...@apple.com" ],
 "Battery": [ "gyuyoung@samsung.com" ],
 "BlackBerry": [ "mifen...@rim.com", "rwlb...@gmail.com", "toniki...@webkit.org" ],
+"Cairo": [ "dominik.rottsc...@intel.com" ],
 "CMake": [ "rak...@webkit.org", "gyuyoung@samsung.com" ],
 "CSS": [ "ale...@webkit.org", "macpher...@chromium.org", "cmarc...@webkit.org", "allan.jen...@digia.com" ],
 "ChromiumGraphics": [ "jam...@chromium.org", "cc-b...@chromium.org" ],
@@ -292,6 +299,7 @@
 "FrameLoader": [ "aba...@webkit.org", "jap...@chromium.org" ],
 "GStreamerGraphics": [ "ale...@webkit.org", "pnorm...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org" ],
 "GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "mrobin...@webkit.org" ],
+"Harfbuzz": [ "dominik.rottsc...@intel.com" ],
 "Loader": [ "jap...@chromium.org" ],
 "MathML": [ "dbar...@mathscribe.com" ],
 "Media": [ "feature-media-revi...@chromium.org", "eric.carl...@apple.com" ],
@@ -303,7 +311,7 @@
 "QtWebKit2PlatformSpecific": [ "ale...@webkit.org", "cmarc...@webkit.org", "abe...@webkit.org" ],
 "QtWebKit2PublicAPI": [ "ale...@webkit.org", "cmarc...@webkit.org", "abe...@webkit.org" ],
 "Rendering": [ "e...@webkit.org" ],
-"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org" ],
+"SVG": ["schen...@chromium.org", "p...@google.com", "fmal...@chromium.org", "dominik.rottsc...@intel.com" ],
 "SVNScripts": [ "dba...@webkit.org" ],
 "ScrollingCoordinator": [ "ander...@apple.com", "jam...@chromium.org", "toniki...@webkit.org" ],
 "SecurityCritical": [ "aba...@webkit.org" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [131574] trunk/LayoutTests

2012-10-17 Thread dominik . rottsches
Title: [131574] trunk/LayoutTests








Revision 131574
Author dominik.rottsc...@intel.com
Date 2012-10-17 03:02:56 -0700 (Wed, 17 Oct 2012)


Log Message
[EFL] Unreviewed gardening.

Unskipping 4 cases after regression was fixed in r131229,
moving out a crash and incorrect console loggin on the wk2 bot.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131573 => 131574)

--- trunk/LayoutTests/ChangeLog	2012-10-17 10:00:17 UTC (rev 131573)
+++ trunk/LayoutTests/ChangeLog	2012-10-17 10:02:56 UTC (rev 131574)
@@ -1,3 +1,13 @@
+2012-10-17  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Unskipping 4 cases after regression was fixed in r131229,
+moving out a crash and incorrect console loggin on the wk2 bot.
+
+* platform/efl-wk2/TestExpectations:
+* platform/efl/TestExpectations:
+
 2012-10-17  Mike West  
 
 V8 should throw a more descriptive exception when blocking 'eval' via CSP.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (131573 => 131574)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-10-17 10:00:17 UTC (rev 131573)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-10-17 10:02:56 UTC (rev 131574)
@@ -1601,3 +1601,5 @@
 webkit.org/b/99189 fast/borders/inline-mask-overlay-image.html [ ImageOnlyFailure ]
 webkit.org/b/99189 ietestcenter/css3/bordersbackgrounds/border-radius-style-001.htm [ ImageOnlyFailure ]
 webkit.org/b/99189 ietestcenter/css3/bordersbackgrounds/border-radius-style-002.htm [ ImageOnlyFailure ]
+
+webkit.org/b/99573 http/tests/security/xss-DENIED-xsl-external-entity.xml [ Failure ]


Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (131573 => 131574)

--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-17 10:00:17 UTC (rev 131573)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-10-17 10:02:56 UTC (rev 131574)
@@ -49,6 +49,8 @@
 Bug(EFL) fast/dom/HTMLAnchorElement/anchor-download.html [ Crash ]
 Bug(EFL) fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Crash ]
 
+webkit.org/b/99571 http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml [ Crash ]
+
 #
 # FLAKY TESTS
 #
@@ -245,11 +247,5 @@
 # Comparison of two _javascript_ objects in C++ is failing.
 webkit.org/b/98739 plugins/npruntime/embed-property-equality.html [ Failure ]
 
-# Fails after r131057.
-webkit.org/b/99152 plugins/plugin-document-back-forward.html [ Failure ]
-webkit.org/b/99152 http/tests/security/contentSecurityPolicy/object-src-url-allowed.html [ Failure ]
-webkit.org/b/99152 http/tests/security/contentSecurityPolicy/object-src-url-blocked.html [ Failure ]
-webkit.org/b/99152 plugins/iframe-plugin-bgcolor.html [ Failure ]
-
 # Flaky on EFL port.
 webkit.org/b/96641 media/video-seek-past-end-playing.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [131499] trunk/Source/WebCore

2012-10-16 Thread dominik . rottsches
Title: [131499] trunk/Source/WebCore








Revision 131499
Author dominik.rottsc...@intel.com
Date 2012-10-16 14:05:15 -0700 (Tue, 16 Oct 2012)


Log Message
Init timeout flag in ResourceErrorMac
https://bugs.webkit.org/show_bug.cgi?id=99478

Reviewed by Alexey Proskuryakov.

On construction from platform error types, initialize the timeout flag
to true if the error results from a timeout.

No new tests, covered by tests that will be added in bug 74802.

* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::platformLazyInit): Initializing timeout flag if the error was a timeout.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (131498 => 131499)

--- trunk/Source/WebCore/ChangeLog	2012-10-16 21:04:19 UTC (rev 131498)
+++ trunk/Source/WebCore/ChangeLog	2012-10-16 21:05:15 UTC (rev 131499)
@@ -1,3 +1,18 @@
+2012-10-16  Dominik Röttsches  
+
+Init timeout flag in ResourceErrorMac
+https://bugs.webkit.org/show_bug.cgi?id=99478
+
+Reviewed by Alexey Proskuryakov.
+
+On construction from platform error types, initialize the timeout flag 
+to true if the error results from a timeout.
+
+No new tests, covered by tests that will be added in bug 74802.
+
+* platform/network/mac/ResourceErrorMac.mm:
+(WebCore::ResourceError::platformLazyInit): Initializing timeout flag if the error was a timeout.
+
 2012-10-16  Tony Chang  
 
 input[type=range] as a flex item renders thumb at wrong position


Modified: trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm (131498 => 131499)

--- trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm	2012-10-16 21:04:19 UTC (rev 131498)
+++ trunk/Source/WebCore/platform/network/mac/ResourceErrorMac.mm	2012-10-16 21:05:15 UTC (rev 131499)
@@ -95,6 +95,8 @@
 , m_platformError(nsError)
 {
 m_isNull = !nsError;
+if (!m_isNull)
+m_isTimeout = [m_platformError.get() code] == NSURLErrorTimedOut;
 }
 
 ResourceError::ResourceError(CFErrorRef cfError)
@@ -102,6 +104,8 @@
 , m_platformError((NSError *)cfError)
 {
 m_isNull = !cfError;
+if (!m_isNull)
+m_isTimeout = [m_platformError.get() code] == NSURLErrorTimedOut;
 }
 
 void ResourceError::platformLazyInit()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [131303] trunk/LayoutTests

2012-10-15 Thread dominik . rottsches
Title: [131303] trunk/LayoutTests








Revision 131303
Author dominik.rottsc...@intel.com
Date 2012-10-15 08:27:48 -0700 (Mon, 15 Oct 2012)


Log Message
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Silencing a style-checker warning.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (131302 => 131303)

--- trunk/LayoutTests/ChangeLog	2012-10-15 15:06:12 UTC (rev 131302)
+++ trunk/LayoutTests/ChangeLog	2012-10-15 15:27:48 UTC (rev 131303)
@@ -1,3 +1,9 @@
+2012-10-15  Dominik Röttsches  
+
+Unreviewed GTK gardening.
+
+* platform/gtk/TestExpectations: Silencing a style-checker warning.
+
 2012-10-15  Vsevolod Vlasov  
 
 Web Inspector: Scripts for dynamically added script elements are not shown in sources panel.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (131302 => 131303)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-15 15:06:12 UTC (rev 131302)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-10-15 15:27:48 UTC (rev 131303)
@@ -314,7 +314,7 @@
 webkit.org/b/71849 transforms/3d [ Skip ]
 
 # LAYER_TREE_INCLUDES_VISIBLE_RECTS option to layerTreeAsText is only applicable to Mac.
-compositing/visible-rect [ Skip ]
+Bug(GTK) compositing/visible-rect [ Skip ]
 
 # Vibration API support not yet.
 webkit.org/b/99029 fast/dom/navigator-vibration.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [131301] trunk/Source/WebCore

2012-10-15 Thread dominik . rottsches
Title: [131301] trunk/Source/WebCore








Revision 131301
Author dominik.rottsc...@intel.com
Date 2012-10-15 07:47:12 -0700 (Mon, 15 Oct 2012)


Log Message
REGRESSION(130613): Reintroduces crashes when using soup's timeout functionality
https://bugs.webkit.org/show_bug.cgi?id=99311

Reviewed by Gustavo Noronha Silva.

Removing the cleanupSoupRequestOperation call, since the cancel() call will eventually trigger the
cleanup already setting the right flag. Cleaning the handle already here will result in crashes when
using the soup timeout functionality.
The explicit cleanup call reintroduced in r130613, after it had been previously removed in r130348.

No new tests, tests that catch this will be part of bug 74802 for XHR timeout support.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::requestTimeoutCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (131300 => 131301)

--- trunk/Source/WebCore/ChangeLog	2012-10-15 14:06:06 UTC (rev 131300)
+++ trunk/Source/WebCore/ChangeLog	2012-10-15 14:47:12 UTC (rev 131301)
@@ -1,3 +1,20 @@
+2012-10-15  Dominik Röttsches  
+
+REGRESSION(130613): Reintroduces crashes when using soup's timeout functionality
+https://bugs.webkit.org/show_bug.cgi?id=99311
+
+Reviewed by Gustavo Noronha Silva.
+
+Removing the cleanupSoupRequestOperation call, since the cancel() call will eventually trigger the
+cleanup already setting the right flag. Cleaning the handle already here will result in crashes when
+using the soup timeout functionality.
+The explicit cleanup call reintroduced in r130613, after it had been previously removed in r130348.
+
+No new tests, tests that catch this will be part of bug 74802 for XHR timeout support.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::requestTimeoutCallback):
+
 2012-10-15  Ilya Tikhonovsky  
 
 Web Inspector: convert manual size calculation of different WebKit things into MemoryInstrumentation.


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (131300 => 131301)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-10-15 14:06:06 UTC (rev 131300)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-10-15 14:47:12 UTC (rev 131301)
@@ -1002,7 +1002,6 @@
 {
 RefPtr handle = static_cast(data);
 handle->client()->didFail(handle.get(), ResourceError::timeoutError(handle->getInternal()->m_firstRequest.url().string()));
-cleanupSoupRequestOperation(handle.get());
 handle->cancel();
 
 return FALSE;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [130273] trunk/LayoutTests

2012-10-03 Thread dominik . rottsches
Title: [130273] trunk/LayoutTests








Revision 130273
Author dominik.rottsc...@intel.com
Date 2012-10-03 03:15:21 -0700 (Wed, 03 Oct 2012)


Log Message
[EFL] Gardening after r130186 and r130231

Unreviewed, EFL gardening.

r130186 introduces usage of Xvfb which allows us to unskip a few X11 dependent cases.
r130231 introduces caching for the Harfbuzz font path, which caused regressions on Harfbuzz NG + Freetype,
see bug 98247. Temporarily going to skip those failures until I check Kenichi's patch.

* platform/efl-wk1/TestExpectations: DRT disables X11 usage, skip a few tests here only for Wk1.
* platform/efl-wk2/TestExpectations: Unskip a couple of X11 dependent cases. (r130186)
* platform/efl/TestExpectations: Temporarily mark a few complex font text as failed (r130231)
* platform/efl/fast/text/atsui-multiple-renderers-expected.png: Rebaseline incorrect result.
* platform/efl/fast/text/atsui-spacing-features-expected.png: Rebaseline incorrect result.
* platform/efl/fast/text/wide-zero-width-space-expected.png: Rebaseline incorrect result.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/efl/fast/text/atsui-multiple-renderers-expected.png
trunk/LayoutTests/platform/efl/fast/text/atsui-spacing-features-expected.png
trunk/LayoutTests/platform/efl/fast/text/wide-zero-width-space-expected.png
trunk/LayoutTests/platform/efl-wk1/TestExpectations
trunk/LayoutTests/platform/efl-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (130272 => 130273)

--- trunk/LayoutTests/ChangeLog	2012-10-03 10:12:08 UTC (rev 130272)
+++ trunk/LayoutTests/ChangeLog	2012-10-03 10:15:21 UTC (rev 130273)
@@ -1,3 +1,20 @@
+2012-10-03  Dominik Röttsches  
+
+[EFL] Gardening after r130186 and r130231
+
+Unreviewed, EFL gardening.
+
+r130186 introduces usage of Xvfb which allows us to unskip a few X11 dependent cases.
+r130231 introduces caching for the Harfbuzz font path, which caused regressions on Harfbuzz NG + Freetype,
+see bug 98247. Temporarily going to skip those failures until I check Kenichi's patch.
+
+* platform/efl-wk1/TestExpectations: DRT disables X11 usage, skip a few tests here only for Wk1.
+* platform/efl-wk2/TestExpectations: Unskip a couple of X11 dependent cases. (r130186)
+* platform/efl/TestExpectations: Temporarily mark a few complex font text as failed (r130231)
+* platform/efl/fast/text/atsui-multiple-renderers-expected.png: Rebaseline incorrect result.
+* platform/efl/fast/text/atsui-spacing-features-expected.png: Rebaseline incorrect result.
+* platform/efl/fast/text/wide-zero-width-space-expected.png: Rebaseline incorrect result.
+
 2012-10-03  Raphael Kubo da Costa  
 
 [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (130272 => 130273)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-10-03 10:12:08 UTC (rev 130272)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-10-03 10:15:21 UTC (rev 130273)
@@ -1462,21 +1462,11 @@
 webkit.org/b/95551 fast/forms/datalist/input-appearance-range-with-datalist-rtl.html [ ImageOnlyFailure ]
 
 # EFL port does not support plugins yet
-webkit.org/b/96881 fast/dom/Window/Plug-ins.html [ Failure ]
-webkit.org/b/96881 fast/frames/sandboxed-iframe-about-blank.html [ Failure ]
-webkit.org/b/96881 fast/frames/sandboxed-iframe-navigation-allowed.html [ Failure ]
 webkit.org/b/96881 fast/frames/sandboxed-iframe-plugins.html [ Failure ]
-webkit.org/b/96881 fast/replaced/invalid-object-with-fallback.html [ Failure ]
-webkit.org/b/96881 http/tests/security/contentSecurityPolicy/object-src-none-allowed.html [ Failure ]
-webkit.org/b/96881 http/tests/security/contentSecurityPolicy/object-src-url-blocked.html [ Failure ]
 webkit.org/b/96881 http/tests/plugins [ Skip ]
-webkit.org/b/96881 http/tests/security/cross-origin-plugin-allowed.html [ Failure ]
-webkit.org/b/96881 http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html [ Failure ]
 webkit.org/b/96881 http/tests/security/cross-origin-plugin-private-browsing-toggled.html [ Failure ]
 webkit.org/b/96881 http/tests/security/cross-origin-plugin.html [ Failure ]
 webkit.org/b/96881 http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html [ Failure ]
-webkit.org/b/96881 http/tests/security/storage-blocking-loosened-plugin.html [ Failure ]
-webkit.org/b/96881 http/tests/security/storage-blocking-loosened-private-browsing-plugin.html [ Failure ]
 webkit.org/b/96881 http/tests/security/storage-blocking-strengthened-plugin.html [ Failure ]
 webkit.org/b/96881 http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html [ Failure ]
 webkit.org/b/96881 java [ Skip ]
@@ -1506,3 +1496,8 @@
 webkit.org/b/97990 mathml/presentation/roots.xhtml [ Failure ]
 webkit.org/b/97990 mathml/presentation/row-alignment.x

[webkit-changes] [130044] trunk/LayoutTests

2012-10-01 Thread dominik . rottsches
Title: [130044] trunk/LayoutTests








Revision 130044
Author dominik.rottsc...@intel.com
Date 2012-10-01 07:07:57 -0700 (Mon, 01 Oct 2012)


Log Message
[EFL] Remove EFL-specific expectations for fast/regions/webkit-named-flow-*
https://bugs.webkit.org/show_bug.cgi?id=98029

Unreviewed, EFL gardening.

Removing redundant platform-specific test results for webkit-named-flow-* cases.
Fixes bot redness after API rename in r130041.

* platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Removed.
* platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-collection-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-name-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-overset-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt
trunk/LayoutTests/platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (130043 => 130044)

--- trunk/LayoutTests/ChangeLog	2012-10-01 14:04:09 UTC (rev 130043)
+++ trunk/LayoutTests/ChangeLog	2012-10-01 14:07:57 UTC (rev 130044)
@@ -1,3 +1,35 @@
+2012-10-01  Dominik Röttsches  
+
+[EFL] Remove EFL-specific expectations for fast/regions/webkit-named-flow-*
+https://bugs.webkit.org/show_bug.cgi?id=98029
+
+Unreviewed, EFL gardening.
+
+Removing redundant platform-specific test results for webkit-named-flow-* cases.
+Fixes bot redness after API rename in r130041.
+
+* platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Removed.
+* platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Removed.
+* platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Removed.
+* pla

[webkit-changes] [129635] trunk/LayoutTests

2012-09-26 Thread dominik . rottsches
Title: [129635] trunk/LayoutTests








Revision 129635
Author dominik.rottsc...@intel.com
Date 2012-09-26 07:08:20 -0700 (Wed, 26 Sep 2012)


Log Message
[EFL] Unreviewed gardening after r129629.

Marking http/tests/security/xss-eval.html as failing again because of the fix being rolled out.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129634 => 129635)

--- trunk/LayoutTests/ChangeLog	2012-09-26 14:07:42 UTC (rev 129634)
+++ trunk/LayoutTests/ChangeLog	2012-09-26 14:08:20 UTC (rev 129635)
@@ -1,3 +1,11 @@
+2012-09-26  Dominik Röttsches  
+
+[EFL] Unreviewed gardening after r129629.
+
+Marking http/tests/security/xss-eval.html as failing again because of the fix being rolled out.
+
+* platform/efl/TestExpectations:
+
 2012-09-26  Stephen Chenney  
 
 Unreviewed Chromium gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (129634 => 129635)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-26 14:07:42 UTC (rev 129634)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-26 14:08:20 UTC (rev 129635)
@@ -1100,3 +1100,6 @@
 
 # Frame does not get focus as expected
 webkit.org/b/97077 inspector/extensions/extensions-panel.html [ Failure ]
+
+# Marking this as failing again, since r129592 was rolled out.
+webkit.org/b/97529 http/tests/security/xss-eval.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129636] trunk/Source/WebCore

2012-09-26 Thread dominik . rottsches
Title: [129636] trunk/Source/WebCore








Revision 129636
Author dominik.rottsc...@intel.com
Date 2012-09-26 07:08:26 -0700 (Wed, 26 Sep 2012)


Log Message
[soup] Obey setTimeoutInterval in soup backend
https://bugs.webkit.org/show_bug.cgi?id=94796

Reviewed by Gustavo Noronha Silva.

Implementing ResourceHandle's setTimeoutInterval support for the soup backend.
This is preparatory work for bug 74802, timeout support for XHR2. The patch
has been successfully tested in combination with my work-in-progress
for that bug.

No new tests yet, tests will be added with the patch in bug 74802.

* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): Adding a timeout source.
(ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::cleanupSoupRequestOperation): Resetting the timer.
(WebCore::sendRequestCallback): Stopping the timer.
(WebCore::startHTTPRequest): Starting a timeout timer before the async request.
(WebCore::ResourceHandle::platformSetDefersLoading): Starting a timeout timer before the async request.
(WebCore::requestTimeoutCallback): Preparing a corresponding resource error and notifying clients of failure.
(WebCore::startNonHTTPRequest): Starting a timeout timer before the async request.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceHandleInternal.h
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (129635 => 129636)

--- trunk/Source/WebCore/ChangeLog	2012-09-26 14:08:20 UTC (rev 129635)
+++ trunk/Source/WebCore/ChangeLog	2012-09-26 14:08:26 UTC (rev 129636)
@@ -1,3 +1,29 @@
+2012-09-26  Dominik Röttsches  
+
+[soup] Obey setTimeoutInterval in soup backend
+https://bugs.webkit.org/show_bug.cgi?id=94796
+
+Reviewed by Gustavo Noronha Silva.
+
+Implementing ResourceHandle's setTimeoutInterval support for the soup backend.
+This is preparatory work for bug 74802, timeout support for XHR2. The patch
+has been successfully tested in combination with my work-in-progress
+for that bug.
+
+No new tests yet, tests will be added with the patch in bug 74802.
+
+* platform/network/ResourceHandleInternal.h:
+(WebCore::ResourceHandleInternal::ResourceHandleInternal): Adding a timeout source.
+(ResourceHandleInternal):
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore):
+(WebCore::cleanupSoupRequestOperation): Resetting the timer.
+(WebCore::sendRequestCallback): Stopping the timer.
+(WebCore::startHTTPRequest): Starting a timeout timer before the async request.
+(WebCore::ResourceHandle::platformSetDefersLoading): Starting a timeout timer before the async request.
+(WebCore::requestTimeoutCallback): Preparing a corresponding resource error and notifying clients of failure.
+(WebCore::startNonHTTPRequest): Starting a timeout timer before the async request.
+
 2012-09-26  Andrey Kosyakov  
 
 Web Inspector: paint inspector overlay on a transparency layer


Modified: trunk/Source/WebCore/platform/network/ResourceHandleInternal.h (129635 => 129636)

--- trunk/Source/WebCore/platform/network/ResourceHandleInternal.h	2012-09-26 14:08:20 UTC (rev 129635)
+++ trunk/Source/WebCore/platform/network/ResourceHandleInternal.h	2012-09-26 14:08:26 UTC (rev 129636)
@@ -187,6 +187,7 @@
 GRefPtr m_inputStream;
 GRefPtr m_cancellable;
 GRefPtr m_deferredResult;
+GRefPtr m_timeoutSource;
 char* m_buffer;
 unsigned long m_bodySize;
 unsigned long m_bodyDataSent;


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (129635 => 129636)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-09-26 14:08:20 UTC (rev 129635)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-09-26 14:08:26 UTC (rev 129636)
@@ -7,6 +7,7 @@
  * Copyright (C) 2009 Christian Dywan 
  * Copyright (C) 2009, 2010, 2011 Igalia S.L.
  * Copyright (C) 2009 John Kjellberg 
+ * Copyright (C) 2012 Intel Corporation
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -71,6 +72,9 @@
 
 #define READ_BUFFER_SIZE 8192
 
+// Use the same value as in NSURLError.h
+static const int gTimeoutError = -1001;
+
 static bool loadingSynchronousRequest = false;
 
 class WebCoreSynchronousLoader : public ResourceHandleClient {
@@ -201,6 +205,7 @@
 static void sendRequestCallback(GObject*, GAsyncResult*, gpointer);
 static void readCallback(GObject*, GAsyncResult*, gpointer);
 static void closeCallback(GObject*, GAsyncResult*, gpointer);
+static gboolean requestTimeoutCallback(void*);
 static bool startNonHTTPRequest(ResourceHandle*, KURL);
 #if ENABLE(WEB_TIMING)
 static int  milisecondsSinceRequest(double requestT

[webkit-changes] [129617] trunk/LayoutTests

2012-09-26 Thread dominik . rottsches
Title: [129617] trunk/LayoutTests








Revision 129617
Author dominik.rottsc...@intel.com
Date 2012-09-26 02:44:36 -0700 (Wed, 26 Sep 2012)


Log Message
[EFL] Unreviewed gardening after r126983.

* platform/efl/TestExpectations: Marking the RefTest harness check as WontFix as in Chromium.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129616 => 129617)

--- trunk/LayoutTests/ChangeLog	2012-09-26 09:26:59 UTC (rev 129616)
+++ trunk/LayoutTests/ChangeLog	2012-09-26 09:44:36 UTC (rev 129617)
@@ -1,3 +1,9 @@
+2012-09-26  Dominik Röttsches  
+
+[EFL] Unreviewed gardening after r126983.
+
+* platform/efl/TestExpectations: Marking the RefTest harness check as WontFix as in Chromium.
+
 2012-09-26  Raphael Kubo da Costa  
 
 [EFL] Unskip test that seems to pass consistently on 32-bits.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (129616 => 129617)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-26 09:26:59 UTC (rev 129616)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-26 09:44:36 UTC (rev 129617)
@@ -232,6 +232,11 @@
 # The EFL port has no support for accessibility features
 Bug(EFL) accessibility [ Skip ]
 
+# Taken from Chromium, this test verifies that a mismatch reftest will fail if both results are the
+# same.  Because the whole point is that this test should fail when run, it's
+# not SKIP, just WONTFIX.
+webkit.org/b/66218 fast/harness/sample-fail-mismatch-reftest.html [ WontFix ]
+
 # -
 # Only the Chromium port supports the features below, but its DRT implementation is not
 # capable of running those tests either. They are currently skipped by all ports.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [129306] trunk/LayoutTests

2012-09-22 Thread dominik . rottsches
Title: [129306] trunk/LayoutTests








Revision 129306
Author dominik.rottsc...@intel.com
Date 2012-09-22 04:50:07 -0700 (Sat, 22 Sep 2012)


Log Message
[EFL] Garden IETestCenter Bugs
https://bugs.webkit.org/show_bug.cgi?id=97392

Unreviewed EFL gardening.

Unskip a couple of IETestCenter bugs now that they pass.


* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (129305 => 129306)

--- trunk/LayoutTests/ChangeLog	2012-09-22 11:32:30 UTC (rev 129305)
+++ trunk/LayoutTests/ChangeLog	2012-09-22 11:50:07 UTC (rev 129306)
@@ -1,3 +1,14 @@
+2012-09-22  Dominik Röttsches  
+
+[EFL] Garden IETestCenter Bugs
+https://bugs.webkit.org/show_bug.cgi?id=97392
+
+Unreviewed EFL gardening.
+
+Unskip a couple of IETestCenter bugs now that they pass.
+
+* platform/efl/TestExpectations:
+
 2012-09-22  Mihnea Ovidenie  
 
 [CSSRegions]Add test for accelerating compositing of elements in RenderFlowThread


Modified: trunk/LayoutTests/platform/efl/TestExpectations (129305 => 129306)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-22 11:32:30 UTC (rev 129305)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-22 11:50:07 UTC (rev 129306)
@@ -549,16 +549,10 @@
 webkit.org/b/84759 ietestcenter/css3/multicolumn/column-containing-block-001.htm [ ImageOnlyFailure ]
 webkit.org/b/84760 ietestcenter/css3/multicolumn/column-containing-block-002.htm [ ImageOnlyFailure ]
 webkit.org/b/84761 ietestcenter/css3/multicolumn/column-filling-001.htm [ ImageOnlyFailure ]
-webkit.org/b/84764 ietestcenter/css3/multicolumn/column-width-applies-to-001.htm [ ImageOnlyFailure ]
-webkit.org/b/84767 ietestcenter/css3/multicolumn/column-width-applies-to-002.htm [ ImageOnlyFailure ]
-webkit.org/b/84768 ietestcenter/css3/multicolumn/column-width-applies-to-003.htm [ ImageOnlyFailure ]
-webkit.org/b/84769 ietestcenter/css3/multicolumn/column-width-applies-to-004.htm [ ImageOnlyFailure ]
 webkit.org/b/84770 ietestcenter/css3/multicolumn/column-width-applies-to-007.htm [ ImageOnlyFailure ]
 webkit.org/b/84771 ietestcenter/css3/multicolumn/column-width-applies-to-009.htm [ ImageOnlyFailure ]
 webkit.org/b/84772 ietestcenter/css3/multicolumn/column-width-applies-to-010.htm [ ImageOnlyFailure ]
 webkit.org/b/84773 ietestcenter/css3/multicolumn/column-width-applies-to-012.htm [ ImageOnlyFailure ]
-webkit.org/b/84775 ietestcenter/css3/multicolumn/column-width-applies-to-013.htm [ ImageOnlyFailure ]
-webkit.org/b/84776 ietestcenter/css3/multicolumn/column-width-applies-to-014.htm [ ImageOnlyFailure ]
 webkit.org/b/84777 ietestcenter/css3/multicolumn/column-width-applies-to-015.htm [ ImageOnlyFailure ]
 webkit.org/b/84778 ietestcenter/css3/multicolumn/column-width-negative-001.htm [ ImageOnlyFailure ]
 
@@ -744,8 +738,6 @@
 webkit.org/b/86091 fast/events/context-no-deselect.html [ Missing ]
 
 # IETC namespace failures
-webkit.org/b/86137 ietestcenter/css3/namespaces/prefix-007.xml [ ImageOnlyFailure ]
-webkit.org/b/86139 ietestcenter/css3/namespaces/prefix-010.xml [ ImageOnlyFailure ]
 webkit.org/b/86142 ietestcenter/css3/namespaces/syntax-021.xml [ ImageOnlyFailure ]
 
 # Fullscreen API is enabled but not fully implemented.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127722] trunk/LayoutTests

2012-09-06 Thread dominik . rottsches
Title: [127722] trunk/LayoutTests








Revision 127722
Author dominik.rottsc...@intel.com
Date 2012-09-06 03:47:18 -0700 (Thu, 06 Sep 2012)


Log Message
[EFL] Gardening after r127620, r127698 and r127704
https://bugs.webkit.org/show_bug.cgi?id=95963

Unreviewed gardening.

Following tests were added to TestExpectations:
compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.

Patch by Mikhail Pozdnyakov  on 2012-09-06

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127721 => 127722)

--- trunk/LayoutTests/ChangeLog	2012-09-06 10:40:26 UTC (rev 127721)
+++ trunk/LayoutTests/ChangeLog	2012-09-06 10:47:18 UTC (rev 127722)
@@ -1,3 +1,18 @@
+2012-09-06  Mikhail Pozdnyakov  
+
+[EFL] Gardening after r127620, r127698 and r127704
+https://bugs.webkit.org/show_bug.cgi?id=95963
+
+Unreviewed gardening.
+
+Following tests were added to TestExpectations:
+compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
+fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
+fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
+fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.
+
+* platform/efl/TestExpectations:
+
 2012-09-06  Adam Barth  
 
 Three XSLTProcessor functions don't need to be [Custom]


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127721 => 127722)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-06 10:40:26 UTC (rev 127721)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-06 10:47:18 UTC (rev 127722)
@@ -468,6 +468,7 @@
 BUGWK82294 : compositing/overflow/content-loses-scrollbars.html = TEXT
 BUGWK82294 SKIP : compositing/overflow/nested-scrolling.html = MISSING
 BUGWK82294 : compositing/overflow/overflow-auto-with-touch.html = TEXT
+BUGWK82294 : compositing/overflow/overflow-auto-with-touch-toggle.html = TEXT
 BUGWK82294 SKIP : compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html = MISSING
 BUGWK82294 : compositing/overflow/overflow-overlay-with-touch.html = TEXT
 BUGWK82294 : compositing/overflow/overflow-scrollbar-layers.html = TEXT
@@ -1099,3 +1100,10 @@
 BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html = TEXT
 BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled.html = TEXT
 BUGWK95840 : http/tests/security/cross-origin-plugin.html = TEXT
+
+// Fails after r127698.
+BUGWK95944 : fast/dom/HTMLScriptElement/script-reexecution.html = TEXT
+
+// Fail after r127704.
+BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale.html = TEXT
+BUGWK95952 : fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127584] trunk/LayoutTests

2012-09-05 Thread dominik . rottsches
Title: [127584] trunk/LayoutTests








Revision 127584
Author dominik.rottsc...@intel.com
Date 2012-09-05 06:25:17 -0700 (Wed, 05 Sep 2012)


Log Message
[EFL] Unreviewed gardening.

Adding a platform specififc baseline after r127534.

* platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (127583 => 127584)

--- trunk/LayoutTests/ChangeLog	2012-09-05 13:11:35 UTC (rev 127583)
+++ trunk/LayoutTests/ChangeLog	2012-09-05 13:25:17 UTC (rev 127584)
@@ -1,3 +1,11 @@
+2012-09-05  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Adding a platform specififc baseline after r127534.
+
+* platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
+
 2012-09-05  Christophe Dumez  
 
 [EFL][WK2] Provide implementation for WebFrameNetworkingContext


Added: trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt (0 => 127584)

--- trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt	2012-09-05 13:25:17 UTC (rev 127584)
@@ -0,0 +1 @@
+PASS: body and iframe cleared without crashing.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127581] trunk/Source/WebCore

2012-09-05 Thread dominik . rottsches
Title: [127581] trunk/Source/WebCore








Revision 127581
Author dominik.rottsc...@intel.com
Date 2012-09-05 05:34:58 -0700 (Wed, 05 Sep 2012)


Log Message
Unreviewed, rolling out r127573.
http://trac.webkit.org/changeset/127573
https://bugs.webkit.org/show_bug.cgi?id=95844

Breaks EFL Debug bot tests. (Requested by drott on #webkit).

Patch by Sheriff Bot  on 2012-09-05

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::setThemePath):
(WebCore::RenderThemeEfl::createCanvas):
(WebCore::RenderThemeEfl::createEdje):
(WebCore::RenderThemeEfl::applyPartDescriptions):
(WebCore::RenderThemeEfl::themeChanged):
(WebCore):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp
trunk/Source/WebCore/platform/efl/RenderThemeEfl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (127580 => 127581)

--- trunk/Source/WebCore/ChangeLog	2012-09-05 12:09:07 UTC (rev 127580)
+++ trunk/Source/WebCore/ChangeLog	2012-09-05 12:34:58 UTC (rev 127581)
@@ -1,3 +1,24 @@
+2012-09-05  Sheriff Bot  
+
+Unreviewed, rolling out r127573.
+http://trac.webkit.org/changeset/127573
+https://bugs.webkit.org/show_bug.cgi?id=95844
+
+Breaks EFL Debug bot tests. (Requested by drott on #webkit).
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::themePartCacheEntryReset):
+(WebCore::RenderThemeEfl::cacheThemePartNew):
+(WebCore::RenderThemeEfl::paintThemePart):
+(WebCore::RenderThemeEfl::setThemePath):
+(WebCore::RenderThemeEfl::createCanvas):
+(WebCore::RenderThemeEfl::createEdje):
+(WebCore::RenderThemeEfl::applyPartDescriptions):
+(WebCore::RenderThemeEfl::themeChanged):
+(WebCore):
+* platform/efl/RenderThemeEfl.h:
+(RenderThemeEfl):
+
 2012-09-05  MORITA Hajime  
 
 ShadowRoot.cloneNode() must always throw a DATA_CLONE_ERR exception.


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (127580 => 127581)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-09-05 12:09:07 UTC (rev 127580)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2012-09-05 12:34:58 UTC (rev 127581)
@@ -103,6 +103,9 @@
 {
 const char *file, *group;
 
+ASSERT(entry);
+ASSERT(m_edje);
+
 edje_object_file_get(m_edje, &file, 0);
 group = edjeGroupFromFormType(type);
 ASSERT(file);
@@ -156,7 +159,7 @@
 struct RenderThemeEfl::ThemePartCacheEntry* RenderThemeEfl::cacheThemePartNew(FormType type, const IntSize& size)
 {
 if (isFormElementTooLargeToDisplay(size)) {
-EINA_LOG_ERR("Cannot render an element of size %dx%d.", size.width(), size.height());
+EINA_LOG_ERR("cannot render an element of size %dx%d", size.width(), size.height());
 return 0;
 }
 
@@ -308,15 +311,13 @@
 
 bool RenderThemeEfl::paintThemePart(RenderObject* object, FormType type, const PaintInfo& info, const IntRect& rect)
 {
-if (!edje()) {
-EINA_LOG_ERR("Could not paint native HTML part due to missing theme.");
-return false;
-}
-
 ThemePartCacheEntry* entry;
 Eina_List* updates;
 cairo_t* cairo;
 
+ASSERT(m_canvas);
+ASSERT(m_edje);
+
 entry = cacheThemePartGet(type, rect.size());
 if (!entry)
 return false;
@@ -437,59 +438,44 @@
 return;
 
 m_themePath = path;
+themeChanged();
+}
 
-if (m_themePath.isEmpty()) {
-EINA_LOG_ERR("No theme defined, unable to set theme for HTML Forms.");
-return;
-}
-
-if (!m_canvas) {
-m_canvas = ecore_evas_buffer_new(1, 1);
-if (!m_canvas)
-EINA_LOG_ERR("Could not create canvas.");
-}
-
-if (m_edje) {
-// Get rid of current theme.
-cacheThemePartFlush();
-evas_object_del(m_edje);
-m_edje = 0;
-}
+void RenderThemeEfl::createCanvas()
+{
+ASSERT(!m_canvas);
+m_canvas = ecore_evas_buffer_new(1, 1);
+ASSERT(m_canvas);
 }
 
-Evas_Object* RenderThemeEfl::edje()
+void RenderThemeEfl::createEdje()
 {
-if (!m_edje) {
+ASSERT(!m_edje);
+if (m_themePath.isEmpty())
+EINA_LOG_ERR("No theme defined, unable to set RenderThemeEfl.");
+else {
 m_edje = edje_object_add(ecore_evas_get(m_canvas));
-if (!m_edje) {
-EINA_LOG_CRIT("Could not create base Edje object.");
-return 0;
-}
-
-if (!edje_object_file_set(m_edje, m_themePath.utf8().data(), "webkit/base")) {
+if (!m_edje)
+EINA_LOG_ERR("Could not create base edje object.");
+else if (!edje_object_file_set(m_edje, m_themePath.utf8().data(), "webkit/base")) {
 Edje_Load_Error err = edje_object_load_error_get(m_edje);
 const char* errmsg = edje_load_erro

[webkit-changes] [127575] trunk/LayoutTests

2012-09-05 Thread dominik . rottsches
Title: [127575] trunk/LayoutTests








Revision 127575
Author dominik.rottsc...@intel.com
Date 2012-09-05 04:24:55 -0700 (Wed, 05 Sep 2012)


Log Message
[EFL] Unreviewed gardening after r127513

Marking plugin third-party storage tests as failing on EFL.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127574 => 127575)

--- trunk/LayoutTests/ChangeLog	2012-09-05 11:04:33 UTC (rev 127574)
+++ trunk/LayoutTests/ChangeLog	2012-09-05 11:24:55 UTC (rev 127575)
@@ -1,3 +1,11 @@
+2012-09-05  Dominik Röttsches  
+
+[EFL] Unreviewed gardening after r127513
+
+Marking plugin third-party storage tests as failing on EFL.
+
+* platform/efl/TestExpectations:
+
 2012-09-05  Zoltan Arvai  
 
 [Qt] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127574 => 127575)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-05 11:04:33 UTC (rev 127574)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-05 11:24:55 UTC (rev 127575)
@@ -1081,3 +1081,9 @@
 
 // Fails after r127140.
 BUGWK95551 : fast/forms/datalist/input-appearance-range-with-datalist-rtl.html = IMAGE
+
+// Fail after they were introduced in r127513
+BUGWK95840 : http/tests/security/cross-origin-plugin-allowed.html = TEXT
+BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html = TEXT
+BUGWK95840 : http/tests/security/cross-origin-plugin-private-browsing-toggled.html = TEXT
+BUGWK95840 : http/tests/security/cross-origin-plugin.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127495] trunk/Source/WebCore

2012-09-04 Thread dominik . rottsches
Title: [127495] trunk/Source/WebCore








Revision 127495
Author dominik.rottsc...@intel.com
Date 2012-09-04 13:30:09 -0700 (Tue, 04 Sep 2012)


Log Message
ResourceErrorBase needs to identify timeouts
https://bugs.webkit.org/show_bug.cgi?id=95755

Reviewed by Alexey Proskuryakov.

Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.

No new tests, no change in behavior yet.

* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.
* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp
trunk/Source/WebCore/platform/network/ResourceErrorBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (127494 => 127495)

--- trunk/Source/WebCore/ChangeLog	2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/ChangeLog	2012-09-04 20:30:09 UTC (rev 127495)
@@ -1,3 +1,25 @@
+2012-09-04  Dominik Röttsches  
+
+ResourceErrorBase needs to identify timeouts
+https://bugs.webkit.org/show_bug.cgi?id=95755
+
+Reviewed by Alexey Proskuryakov.
+
+Adding a property to check whether this ResourceError was raised due to a timeout.
+This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
+I need to identify some layers up whether the original network problem has been a timeout.
+
+No new tests, no change in behavior yet.
+
+* platform/network/ResourceErrorBase.cpp:
+(WebCore::ResourceErrorBase::copy): Copying new member.
+(WebCore::ResourceErrorBase::compare): Comparing new member.
+* platform/network/ResourceErrorBase.h:
+(WebCore::ResourceErrorBase::setIsTimeout): New setter.
+(WebCore::ResourceErrorBase::isTimeout): New getter.
+(ResourceErrorBase),
+(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.
+
 2012-09-04  Tommy Widenflycht  
 
 MediaStream API: Change the MediaStreamTrackList track added/removed signaling


Modified: trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp (127494 => 127495)

--- trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp	2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/platform/network/ResourceErrorBase.cpp	2012-09-04 20:30:09 UTC (rev 127495)
@@ -42,6 +42,7 @@
 errorCopy.m_localizedDescription = m_localizedDescription.isolatedCopy();
 errorCopy.m_isNull = m_isNull;
 errorCopy.m_isCancellation = m_isCancellation;
+errorCopy.m_isTimeout = m_isTimeout;
 platformCopy(errorCopy);
 return errorCopy;
 }
@@ -74,6 +75,9 @@
 if (a.isCancellation() != b.isCancellation())
 return false;
 
+if (a.isTimeout() != b.isTimeout())
+return false;
+
 return platformCompare(a, b);
 }
 


Modified: trunk/Source/WebCore/platform/network/ResourceErrorBase.h (127494 => 127495)

--- trunk/Source/WebCore/platform/network/ResourceErrorBase.h	2012-09-04 20:25:47 UTC (rev 127494)
+++ trunk/Source/WebCore/platform/network/ResourceErrorBase.h	2012-09-04 20:30:09 UTC (rev 127495)
@@ -49,6 +49,9 @@
 void setIsCancellation(bool isCancellation) { m_isCancellation = isCancellation; }
 bool isCancellation() const { return m_isCancellation; }
 
+void setIsTimeout(bool isTimeout) { m_isTimeout = isTimeout; }
+bool isTimeout() const { return m_isTimeout; }
+
 static bool compare(const ResourceError&, const ResourceError&);
 
 protected:
@@ -56,6 +59,7 @@
 : m_errorCode(0)
 , m_isNull(true)
 , m_isCancellation(false)
+, m_isTimeout(false)
 {
 }
 
@@ -66,6 +70,7 @@
 , m_localizedDescription(localizedDescription)
 , m_isNull(false)
 , m_isCancellation(false)
+, m_isTimeout(false)
 {
 }
 
@@ -86,6 +91,7 @@
 String m_localizedDescription;
 bool m_isNull;
 bool m_isCancellation;
+bool m_isTimeout;
 };
 
 inline bool operator==(const ResourceError& a, const ResourceError& b) { return ResourceErrorBase::compare(a, b); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127447] trunk/LayoutTests

2012-09-04 Thread dominik . rottsches
Title: [127447] trunk/LayoutTests








Revision 127447
Author dominik.rottsc...@intel.com
Date 2012-09-04 01:39:43 -0700 (Tue, 04 Sep 2012)


Log Message
[EFL] Unreviewed gardening.

Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14

* platform/efl/TestExpectations: Previously crashing test removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127446 => 127447)

--- trunk/LayoutTests/ChangeLog	2012-09-04 08:38:18 UTC (rev 127446)
+++ trunk/LayoutTests/ChangeLog	2012-09-04 08:39:43 UTC (rev 127447)
@@ -1,3 +1,12 @@
+2012-09-04  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
+from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14
+
+* platform/efl/TestExpectations: Previously crashing test removed.
+
 2012-09-03  Noel Gordon  
 
 http/tests/incremental/partial-jpeg.html is flaky


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127446 => 127447)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-04 08:38:18 UTC (rev 127446)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-04 08:39:43 UTC (rev 127447)
@@ -177,8 +177,6 @@
 // CRASHES
 //
 
-BUGWK94458 DEBUG : http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html = CRASH TEXT
-
 //
 // FLAKY TESTS
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127416] trunk/LayoutTests

2012-09-03 Thread dominik . rottsches
Title: [127416] trunk/LayoutTests








Revision 127416
Author dominik.rottsc...@intel.com
Date 2012-09-03 03:26:24 -0700 (Mon, 03 Sep 2012)


Log Message
[EFL] Unreviewed gardening.

Unskipping message-port-close.html after bug 85811 was resolved.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127415 => 127416)

--- trunk/LayoutTests/ChangeLog	2012-09-03 09:56:55 UTC (rev 127415)
+++ trunk/LayoutTests/ChangeLog	2012-09-03 10:26:24 UTC (rev 127416)
@@ -1,3 +1,11 @@
+2012-09-03  Dominik Röttsches  
+
+[EFL] Unreviewed gardening.
+
+Unskipping message-port-close.html after bug 85811 was resolved.
+
+* platform/efl/TestExpectations:
+
 2012-08-31  Pavel Feldman  
 
 Web Inspector: get rid of context execution id fallback.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127415 => 127416)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-09-03 09:56:55 UTC (rev 127415)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-09-03 10:26:24 UTC (rev 127416)
@@ -192,7 +192,6 @@
 BUGWK86073 : ietestcenter/css3/flexbox/flexbox-layout-001.htm = IMAGE PASS
 BUGWK86073 : ietestcenter/css3/flexbox/flexbox-layout-003.htm = IMAGE PASS
 BUGWK86074 : media/svg-as-image-with-media-blocked.html = CRASH PASS
-BUGWK86075 : fast/events/message-port-close.html = CRASH PASS
 BUGWK86078 : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT PASS
 BUGWK86079 : http/tests/misc/link-rel-icon-beforeload.html = TEXT PASS
 BUGWK86081 : loader/navigation-while-deferring-loads.html = TEXT PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127274] trunk/LayoutTests

2012-08-31 Thread dominik . rottsches
Title: [127274] trunk/LayoutTests








Revision 127274
Author dominik.rottsc...@intel.com
Date 2012-08-31 10:07:09 -0700 (Fri, 31 Aug 2012)


Log Message
[Chromium] _javascript_-url-stop-loaders.html and zero-length-response.html are flaky on Chromium EWS
https://bugs.webkit.org/show_bug.cgi?id=95581

Unreviewed, Chromium gardening.

Tests mentioned in the title seem to cause flakiness on the Chromium EWS.


* platform/chromium/TestExpectations: Mark as TIMEOUT PASS for now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127273 => 127274)

--- trunk/LayoutTests/ChangeLog	2012-08-31 16:54:07 UTC (rev 127273)
+++ trunk/LayoutTests/ChangeLog	2012-08-31 17:07:09 UTC (rev 127274)
@@ -1,3 +1,14 @@
+2012-08-31  Dominik Röttsches  
+
+[Chromium] _javascript_-url-stop-loaders.html and zero-length-response.html are flaky on Chromium EWS
+https://bugs.webkit.org/show_bug.cgi?id=95581
+
+Unreviewed, Chromium gardening.
+
+Tests mentioned in the title seem to cause flakiness on the Chromium EWS.
+
+* platform/chromium/TestExpectations: Mark as TIMEOUT PASS for now.
+
 2012-08-31  Jessie Berlin  
 
 Web Inspector: sort object properties when dumping them in tests


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (127273 => 127274)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-31 16:54:07 UTC (rev 127273)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-08-31 17:07:09 UTC (rev 127274)
@@ -3498,6 +3498,9 @@
 // Flaky
 BUGWK95246 : http/tests/security/mixedContent/filesystem-url-in-iframe.html = PASS TEXT
 
+BUGWK95581 : http/tests/xmlhttprequest/zero-length-response.html = TIMEOUT PASS
+BUGWK95581 : http/tests/misc/_javascript_-url-stop-loaders.htm = TIMEOUT PASS
+
 BUGWK94261 DEBUG : http/tests/inspector/indexeddb/resources-panel.html = PASS CRASH TIMEOUT
 
 // ENABLE_OVERFLOW_SCROLLING is not currently enabled in Chromium.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127247] trunk/LayoutTests

2012-08-31 Thread dominik . rottsches
Title: [127247] trunk/LayoutTests








Revision 127247
Author dominik.rottsc...@intel.com
Date 2012-08-31 05:07:56 -0700 (Fri, 31 Aug 2012)


Log Message
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=9

Unreviewed EFL gardening of failing tests and new passes.

Patch by Sudarsana Nagineni  on 2012-08-31

* platform/efl/TestExpectations:
* platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations


Added Paths

trunk/LayoutTests/platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (127246 => 127247)

--- trunk/LayoutTests/ChangeLog	2012-08-31 12:05:51 UTC (rev 127246)
+++ trunk/LayoutTests/ChangeLog	2012-08-31 12:07:56 UTC (rev 127247)
@@ -1,3 +1,13 @@
+2012-08-31  Sudarsana Nagineni  
+
+[EFL] Gardening of failing tests and new passes
+https://bugs.webkit.org/show_bug.cgi?id=9
+
+Unreviewed EFL gardening of failing tests and new passes.
+
+* platform/efl/TestExpectations:
+* platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
+
 2012-08-31  János Badics  
 
 [Qt] Gardening after r127140. Skip a failing reftest.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127246 => 127247)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-08-31 12:05:51 UTC (rev 127246)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-08-31 12:07:56 UTC (rev 127247)
@@ -542,7 +542,7 @@
 BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html = TEXT
 BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-allowed.html = TEXT
 BUGWK77219 SKIP : http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html = TEXT
-BUGWK77219 : inspector/profiler/webgl-profiler-api-changes.html = TEXT
+BUGWK77219 : inspector/profiler/webgl/webgl-profiler-api-changes.html = TEXT
 
 BUGWK84759 : ietestcenter/css3/multicolumn/column-containing-block-001.htm = IMAGE
 BUGWK84760 : ietestcenter/css3/multicolumn/column-containing-block-002.htm = IMAGE
@@ -1074,12 +1074,14 @@
 // Fails after r127035.
 BUGWK95428 : media/video-controls-captions.html = TEXT
 
-// Fails after r127039.
-BUGWK95414 : inspector/timeline/timeline-load.html = TEXT
-
 //Require rebaseline after https://bugs.webkit.org/show_bug.cgi?id=80394
 BUGWK80394 : fast/block/margin-collapse/empty-clear-blocks.html = IMAGE+TEXT
 BUGWK80394 : fast/block/float/024.html = IMAGE+TEXT
 BUGWK80394 : fast/block/margin-collapse/025.html = TEXT
 BUGWK80394 : fast/block/margin-collapse/block-inside-inline/025.html = TEXT
 
+// Started failing on JSC ports after r127202.
+BUGWK95530 : http/tests/security/inactive-document-with-empty-security-origin.html = TEXT
+
+// Fails after r127140.
+BUGWK95551 : fast/forms/datalist/input-appearance-range-with-datalist-rtl.html = IMAGE


Added: trunk/LayoutTests/platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt (0 => 127247)

--- trunk/LayoutTests/platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt	2012-08-31 12:07:56 UTC (rev 127247)
@@ -0,0 +1,5 @@
+http://127.0.0.1:8000/misc/resources/willCacheResponse-success.html - willSendRequest  redirectResponse (null)
+http://127.0.0.1:8000/misc/resources/willCacheResponse-success.html - didReceiveResponse 
+This tests for the willCacheResponse resource delegate callback as added for radar 5008925.
+The test is only meaningful if you are running it under DumpRenderTree
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127111] trunk/LayoutTests

2012-08-30 Thread dominik . rottsches
Title: [127111] trunk/LayoutTests








Revision 127111
Author dominik.rottsc...@intel.com
Date 2012-08-30 01:06:28 -0700 (Thu, 30 Aug 2012)


Log Message
[EFL] Gardening after r127135, r127039
https://bugs.webkit.org/show_bug.cgi?id=95433

Unreviewed gardening.

Gardening of media/video-controls-captions.html and inspector/timeline/timeline-load.html.

Patch by Mikhail Pozdnyakov  on 2012-08-30

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (127110 => 127111)

--- trunk/LayoutTests/ChangeLog	2012-08-30 07:57:56 UTC (rev 127110)
+++ trunk/LayoutTests/ChangeLog	2012-08-30 08:06:28 UTC (rev 127111)
@@ -1,3 +1,14 @@
+2012-08-30  Mikhail Pozdnyakov  
+
+[EFL] Gardening after r127135, r127039
+https://bugs.webkit.org/show_bug.cgi?id=95433
+
+Unreviewed gardening.
+
+Gardening of media/video-controls-captions.html and inspector/timeline/timeline-load.html.
+
+* platform/efl/TestExpectations:
+
 2012-08-30  Csaba Osztrogonác  
 
 [Qt] Unreviewed gardening, skip new failing tests.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (127110 => 127111)

--- trunk/LayoutTests/platform/efl/TestExpectations	2012-08-30 07:57:56 UTC (rev 127110)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2012-08-30 08:06:28 UTC (rev 127111)
@@ -997,3 +997,8 @@
 BUGWK77754 : fast/inline/absolute-positioned-inline-in-centred-block.html = TEXT
 BUGWK77754 : fast/css/absolute-child-with-percent-height-inside-relative-parent.html = TEXT
 
+// Fails after r127035.
+BUGWK95428 : media/video-controls-captions.html = TEXT
+
+// Fails after r127039.
+BUGWK95414 : inspector/timeline/timeline-load.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127036] trunk/Tools

2012-08-29 Thread dominik . rottsches
Title: [127036] trunk/Tools








Revision 127036
Author dominik.rottsc...@intel.com
Date 2012-08-29 13:05:54 -0700 (Wed, 29 Aug 2012)


Log Message
Stylechecker warns about comparison to zero when comparing to 0.5
https://bugs.webkit.org/show_bug.cgi?id=94913

Reviewed by Dirk Pranke.

According to the python documentation, \W is the character group with all
non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
to [^\w]. We need to exclude the dot "." as well, so that floating point
values do not trigger this warning. Adding a unit test that shows the problem.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (127035 => 127036)

--- trunk/Tools/ChangeLog	2012-08-29 20:03:11 UTC (rev 127035)
+++ trunk/Tools/ChangeLog	2012-08-29 20:05:54 UTC (rev 127036)
@@ -1,3 +1,20 @@
+2012-08-29  Dominik Röttsches  
+
+Stylechecker warns about comparison to zero when comparing to 0.5
+https://bugs.webkit.org/show_bug.cgi?id=94913
+
+Reviewed by Dirk Pranke.
+
+According to the python documentation, \W is the character group with all
+non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
+to [^\w]. We need to exclude the dot "." as well, so that floating point
+values do not trigger this warning. Adding a unit test that shows the problem.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
+
 2012-08-29  Jon Lee  
 
 WTR build fixes.


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (127035 => 127036)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-08-29 20:03:11 UTC (rev 127035)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2012-08-29 20:05:54 UTC (rev 127036)
@@ -2425,7 +2425,7 @@
 line = clean_lines.elided[line_number]
 
 # Include NULL here so that users don't have to convert NULL to 0 first and then get this error.
-if search(r'[=!]=\s*(NULL|0|true|false)\W', line) or search(r'\W(NULL|0|true|false)\s*[=!]=', line):
+if search(r'[=!]=\s*(NULL|0|true|false)[^\w.]', line) or search(r'[^\w.](NULL|0|true|false)\s*[=!]=', line):
 if not search('LIKELY', line) and not search('UNLIKELY', line):
 error(line_number, 'readability/comparison_to_zero', 5,
   'Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.')


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (127035 => 127036)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-08-29 20:03:11 UTC (rev 127035)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2012-08-29 20:05:54 UTC (rev 127036)
@@ -4376,6 +4376,12 @@
 'if (UNLIKELY(foo == 0))',
 '')
 self.assert_lint(
+'if ((a - b) == 0.5)',
+'')
+self.assert_lint(
+'if (0.5 == (a - b))',
+'')
+self.assert_lint(
 'if (LIKELY(foo == NULL))',
 'Use 0 instead of NULL.  [readability/null] [5]')
 self.assert_lint(






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes


[webkit-changes] [127001] trunk

2012-08-29 Thread dominik . rottsches
Title: [127001] trunk








Revision 127001
Author dominik.rottsc...@intel.com
Date 2012-08-29 08:33:07 -0700 (Wed, 29 Aug 2012)


Log Message
The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272

Reviewed by Benjamin Poulain.

Source/WTF:

Updating previous patch to address Benjamin's comments.
#ifdef in Uint8ClampedArray removed, fallback implementation for MSVC on non-X86 added.

* wtf/MathExtras.h:
(lrint): Fallback implementation for non-X86 & MSVC case.
* wtf/Uint8ClampedArray.h: Removed #ifdef.

Tools:

Updating patch to address Benjamin's review comments.
Adding a WTF test to test lrint implementation.

* TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
* TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
* TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
* TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
(TestWebKitAPI):
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MathExtras.h
trunk/Source/WTF/wtf/Uint8ClampedArray.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
trunk/Tools/TestWebKitAPI/GNUmakefile.am
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gypi
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (127000 => 127001)

--- trunk/Source/WTF/ChangeLog	2012-08-29 14:48:31 UTC (rev 127000)
+++ trunk/Source/WTF/ChangeLog	2012-08-29 15:33:07 UTC (rev 127001)
@@ -1,3 +1,17 @@
+2012-08-29  Dominik Röttsches  
+
+The 2d.imageData.object.round canvas test is failing
+https://bugs.webkit.org/show_bug.cgi?id=40272
+
+Reviewed by Benjamin Poulain.
+
+Updating previous patch to address Benjamin's comments.
+#ifdef in Uint8ClampedArray removed, fallback implementation for MSVC on non-X86 added.
+
+* wtf/MathExtras.h:
+(lrint): Fallback implementation for non-X86 & MSVC case.
+* wtf/Uint8ClampedArray.h: Removed #ifdef.
+
 2012-08-28  Sheriff Bot  
 
 Unreviewed, rolling out r126914.


Modified: trunk/Source/WTF/wtf/MathExtras.h (127000 => 127001)

--- trunk/Source/WTF/wtf/MathExtras.h	2012-08-29 14:48:31 UTC (rev 127000)
+++ trunk/Source/WTF/wtf/MathExtras.h	2012-08-29 15:33:07 UTC (rev 127001)
@@ -205,17 +205,23 @@
 // MSVC's math functions do not bring lrint.
 inline long int lrint(double flt)
 {
-int intgr;
+int64_t intgr;
 #if CPU(X86)
 __asm {
 fld flt
 fistp intgr
 };
 #else
-#pragma message("Falling back to casting for lrint(), causes rounding inaccuracy in halfway case.")
-intgr = static_cast(flt);
+ASSERT(isfinite(flt));
+double rounded = round(flt);
+intgr = static_cast(rounded);
+// If the fractional part is exactly 0.5, we need to check whether
+// the rounded result is even. If it is not we need to add 1 to
+// negative values and subtract one from positive values.
+if (fabs(intgr - flt) == 0.5 & intgr)
+intgr -= ((intgr >> 62) | 1); // 1 with the sign of result, i.e. -1 or 1.
 #endif
-return intgr;
+return static_cast(intgr);
 }
 
 #endif // COMPILER(MSVC)


Modified: trunk/Source/WTF/wtf/Uint8ClampedArray.h (127000 => 127001)

--- trunk/Source/WTF/wtf/Uint8ClampedArray.h	2012-08-29 14:48:31 UTC (rev 127000)
+++ trunk/Source/WTF/wtf/Uint8ClampedArray.h	2012-08-29 15:33:07 UTC (rev 127001)
@@ -31,9 +31,7 @@
 #include 
 
 #include 
-#if COMPILER(MSVC)
 #include 
-#endif
 
 namespace WTF {
 


Modified: trunk/Tools/ChangeLog (127000 => 127001)

--- trunk/Tools/ChangeLog	2012-08-29 14:48:31 UTC (rev 127000)
+++ trunk/Tools/ChangeLog	2012-08-29 15:33:07 UTC (rev 127001)
@@ -1,3 +1,22 @@
+2012-08-29  Dominik Röttsches  
+
+The 2d.imageData.object.round canvas test is failing
+https://bugs.webkit.org/show_bug.cgi?id=40272
+
+Reviewed by Benjamin Poulain.
+
+Updating patch to address Benjamin's review comments.
+Adding a WTF test to test lrint implementation.
+
+* TestWebKitAPI/CMakeLists.txt: Added MathExtras.cpp test file.
+* TestWebKitAPI/GNUmakefile.am: Added MathExtras.cpp test file.
+* TestWebKitAPI/TestWebKitAPI.gypi: Added MathExtras.cpp test file.
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added MathExtras.cpp test file.
+* TestWebKitAPI/Tests/WTF/MathExtras.cpp: Added this test file containing a test for lrint().
+(TestWebKitAPI):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added MathExtras.cpp test file.
+
 2012-08-29  Florin Malita  
 
 Unreviewed, updating Kelly Norton's email